14 years agoFix reviwer of my last commit. It was the other Mark after all.
zimmermann@webkit.org [Tue, 8 Jan 2008 00:40:04 +0000 (00:40 +0000)]
Fix reviwer of my last commit. It was the other Mark after all.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Mark.
zimmermann@webkit.org [Tue, 8 Jan 2008 00:37:40 +0000 (00:37 +0000)]
Reviewed by Mark.
Build fix affecting all builds - again related to the unicode-range addition.
Note: There is still a crasher (svg/W3C-SVG-1.1/fonts-elem-03-b.svg) that Dan is about to fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele@apple.com [Tue, 8 Jan 2008 00:28:55 +0000 (00:28 +0000)]

        Reviewed by Antti, Adam, and Mitz.

        WebCore part of fix for
        <rdar://problem/5619073> Updated look for <video> controls
        <rdar://problem/5619057> Add volume control to video controls

        * WebCore.base.exp: Added symbols for WebKitSystemInterface drawing methods.
        * WebCore.xcodeproj/project.pbxproj: Added MediaControlElements.h/cpp
        * WebCore.vcproj/WebCore.vcproj: ditto.

        * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added cases for new appearances.
        * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added cases for new types.
        * css/CSSSelector.h: (WebCore::CSSSelector::): Added new pseudo elements.
        * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): ditto.
        * css/CSSValueKeywords.in: Added keywords for new control appearance styles.
        * css/html4.css: Added new styles for new controls.

        * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::canPlay): Added. Takes loading state into account.
        * html/HTMLMediaElement.h:

        * page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Make sure the events always go to the capturing node, if there is one.

        * platform/mac/WebCoreSystemInterface.h: Added drawing methods for controls.
        * platform/mac/WebCoreSystemInterface.mm: ditto.

        * rendering/MediaControlElements.cpp: Added.
        (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): Moved from RenderMedia.  Made this relatively positioned, instead of absolute.
        (WebCore::MediaControlInputElement::MediaControlInputElement): Moved from RenderMedia.  Removed call to updateFromElement,
         since its too early to do this here, and causes crashes for the slider.
        (WebCore::MediaControlInputElement::attachToParent): Moved from RenderMedia.
        (WebCore::MediaControlInputElement::update): ditto.
        (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Added.
        (WebCore::MediaControlMuteButtonElement::defaultEventHandler): ditto.
        (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Moved from RenderMedia.
        (WebCore::MediaControlPlayButtonElement::defaultEventHandler): ditto.
        (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Added.
        (WebCore::MediaControlSeekButtonElement::defaultEventHandler): ditto.
        (WebCore::MediaControlSeekButtonElement::seekTimerFired): ditto.
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Moved from RenderMedia.
        (WebCore::MediaControlTimelineElement::defaultEventHandler): ditto.
        (WebCore::MediaControlTimelineElement::update): ditto.
        (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Added.
        (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): ditto.
        * rendering/MediaControlElements.h: Added. Moved from RenderMedia.

        * rendering/RenderMedia.cpp: Moved control element classes to MediaControlElements files.
        (WebCore::RenderMedia::RenderMedia): No need to initialize RefPtrs.
        (WebCore::RenderMedia::layout): Set the position for the controlsRenderer.
        (WebCore::RenderMedia::createPanel): Added nil check for the renderer.
        (WebCore::RenderMedia::createMuteButton): Added.
        (WebCore::RenderMedia::createSeekBackButton): ditto.
        (WebCore::RenderMedia::createSeekForwardButton): ditto.
        (WebCore::RenderMedia::createTimeDisplay): Added nil check for the renderer.
        (WebCore::RenderMedia::createFullscreenButton): Added.
        (WebCore::RenderMedia::updateControls): Create, delete, and update new controls when appropriate.
        (WebCore::RenderMedia::updateControlVisibility): Don't fade controls for audio controls.
        (WebCore::RenderMedia::forwardEvent): Forward events for new controls.
        * rendering/RenderMedia.h: Added new methods for creating new controls.

        * rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): Updated special case for media elements, which are replaced elements,
          but also can contain children (the controls' container) that may need to look for the containing block.

        * rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle): Added case for MediaSliderAppearance.

        * rendering/RenderStyle.h: Added appearance constants and pseudo ids for new controls.

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle): Added cases for new appearances.
        (WebCore::RenderTheme::paint): ditto.
        * rendering/RenderTheme.h: Added new methods for painting new appearances.
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::RenderThemeMac): Initialize m_mediaControlBackgroundImage.
        (WebCore::RenderThemeMac::~RenderThemeMac): Delete m_mediaControlBackgroundImage.
        (WebCore::RenderThemeMac::paintCapsLockIndicator): Use LocalCurrentGraphicsContext here too, since we use it in all other painting methods.
        (WebCore::RenderThemeMac::paintSliderTrack): Added case for MediaSliderAppearance.
        (WebCore::RenderThemeMac::adjustSliderThumbSize): Added case for MediaSliderThumbAppearance.
        (WebCore::RenderThemeMac::paintMediaBackground): Draws the new artwork for the controls.
        (WebCore::RenderThemeMac::paintMediaFullscreenButton): ditto.
        (WebCore::RenderThemeMac::paintMediaMuteButton): ditto.
        (WebCore::RenderThemeMac::paintMediaPlayButton): ditto.
        (WebCore::RenderThemeMac::paintMediaSeekBackButton): ditto.
        (WebCore::RenderThemeMac::paintMediaSeekForwardButton): ditto.
        (WebCore::RenderThemeMac::paintMediaSliderThumb): ditto.
        * rendering/RenderThemeSafari.cpp: Draws the new artwork on Windows.
        * rendering/RenderThemeSafari.h:


        Reviewed by Antti, Adam, and Mitz.

        WebKit part of fix for
        <rdar://problem/5619073> Updated look for <video> controls
        <rdar://problem/5619057> Add volume control to video controls

        * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):


        Reviewed by Antti, Adam, and Mitz.

        WebKitLibraries part of fix for
        <rdar://problem/5619073> Updated look for <video> controls
        <rdar://problem/5619057> Add volume control to video controls

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:


        Reviewed by Antti, Adam, and Mitz.

        Updated results for:
        <rdar://problem/5619073> Updated look for <video> controls
        <rdar://problem/5619057> Add volume control to video controls

        * platform/mac/media/audio-controls-rendering-expected.checksum:
        * platform/mac/media/audio-controls-rendering-expected.png:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/video-controls-rendering-expected.checksum:
        * platform/mac/media/video-controls-rendering-expected.png:
        * platform/mac/media/video-controls-rendering-expected.txt:
        * platform/mac/media/video-display-toggle-expected.checksum:
        * platform/mac/media/video-display-toggle-expected.png:
        * platform/mac/media/video-display-toggle-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
timothy@apple.com [Tue, 8 Jan 2008 00:12:55 +0000 (00:12 +0000)]
    Reviewed by Darin Adler.

        Fix ASSERTION FAILED: dstOffset + srcSegmentLength == static_cast<int>(data.size())
        when the replacment string is a different length.

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::replace): Move the parenthesis to be around only the subtraction in
        the Vector size calculation, correcting the order of math operations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Eric. Hopefully fix build with mac tiger after the unicode-range addition...
zimmermann@webkit.org [Tue, 8 Jan 2008 00:04:30 +0000 (00:04 +0000)]
Reviewed by Eric. Hopefully fix build with mac tiger after the unicode-range addition. NSInteger not available there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
alice.liu@apple.com [Tue, 8 Jan 2008 00:03:51 +0000 (00:03 +0000)]
    Reviewed by Sam.

        checking in platform-specific results. addresses <rdar://5137719>

        * platform/win/Skipped:
        * platform/win/fast/dom/Window/window-screen-properties-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Oliver. Fix build error introduced by Dan's unicode-range support patch...
zimmermann@webkit.org [Mon, 7 Jan 2008 23:54:13 +0000 (23:54 +0000)]
Reviewed by Oliver. Fix build error introduced by Dan's unicode-range support patch & enabling SVG_FONTS by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoNot reviewed. Next try to fix wx/mac leopard build.
zimmermann@webkit.org [Mon, 7 Jan 2008 23:46:50 +0000 (23:46 +0000)]
Not reviewed. Next try to fix wx/mac leopard build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
kmccullough@apple.com [Mon, 7 Jan 2008 23:36:44 +0000 (23:36 +0000)]
    Reviewed by Adele.

        - <rdar://problem/5667022> fast/events/mousemove-after-drag-over-scrollbar.html
        failing (missing a mousemove event)
        - Updated test to reflect it's original intention and filed a different
        bug about the issue that caused the test to fail on Windows.

        * fast/events/mousemove-after-drag-over-scrollbar-expected.txt:
        * fast/events/mousemove-after-drag-over-scrollbar.html:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz@apple.com [Mon, 7 Jan 2008 23:32:55 +0000 (23:32 +0000)]

        Reviewed by Dave Hyatt.

        - <rdar://problem/5665216> Support the unicode-range property in @font-face rules

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/objc/DOM.mm:
        * bridge/mac/WebCoreAXObject.mm:
        * css/CSSComputedStyleDeclaration.cpp:
        * css/CSSFontFace.cpp:
        (WebCore::CSSFontFace::fontLoaded): Changed to call the owning segmented
        font face.
        * css/CSSFontFace.h:
        * css/CSSFontFaceSource.cpp:
        (WebCore::CSSFontFaceSource::pruneTable): Removed the calls to
        GlyphPageTreeNode::pruneTreeCustomFontData because the fonts in the
        font table are not exposed in the glyph page tree. Only the segmented
        font is, and that is taken care of by the segmented font face.
        * css/CSSFontFaceSource.h:
        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule): Changed to collect
        @font-face rules with the same family and traits into a single
        segmented font face, instead of just retaining the most recent one.
        * css/CSSFontSelector.h:
        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseFontFaceUnicodeRange): Added. Parses a unicode
        range value.
        * css/CSSParser.h:
        * css/CSSPrimitiveValue.h:
        * css/CSSPropertyNames.in:
        * css/CSSSegmentedFontFace.cpp: Added.
        * css/CSSSegmentedFontFace.h: Added.
        * css/CSSStyleSelector.cpp:
        * css/CSSUnicodeRangeValue.cpp: Added.
        * css/CSSUnicodeRangeValue.h: Added.
        * css/SVGCSSFontFace.cpp:
        * css/SVGCSSFontFace.h:
        * editing/Editor.cpp:
        * editing/Editor.h:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge fontForSelection:]):
        * platform/graphics/Font.cpp:
        (WebCore::Font::primaryFont): Changed to return the simple font data
        used for the space character.
        * platform/graphics/Font.h:
        * platform/graphics/FontCache.cpp:
        * platform/graphics/FontCache.h:
        * platform/graphics/FontData.cpp: Renamed to SimpleFontData.cpp
        * platform/graphics/FontData.h: Renamed to SimpleFontData.cpp.
        * platform/graphics/FontDataBaseClass.cpp: Added. This will be renamed
        * platform/graphics/FontDataBaseClass.h: Added. This will be renamed
        * platform/graphics/FontFallbackList.cpp:
        * platform/graphics/FontFallbackList.h:
        * platform/graphics/FontSelector.h:
        * platform/graphics/GlyphBuffer.h:
        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::GlyphPageTreeNode::initializePage): Added code to initialize
        pages for segmented font data.
        * platform/graphics/GlyphPageTreeNode.h:
        * platform/graphics/SegmentedFontData.cpp: Added.
        * platform/graphics/SegmentedFontData.h: Added.
        * platform/graphics/SimpleFontData.cpp: Copied from WebCore/platform/graphics/FontData.cpp.
        * platform/graphics/SimpleFontData.h: Copied from WebCore/platform/graphics/FontData.h.
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/gtk/FontCacheGtk.cpp:
        * platform/graphics/gtk/FontDataGtk.cpp: Renamed to
        * platform/graphics/gtk/FontGtk.cpp:
        * platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp:
        * platform/graphics/gtk/SimpleFontDataGtk.cpp: Copied from WebCore/platform/graphics/gtk/FontDataGtk.cpp.
        * platform/graphics/mac/FontCacheMac.mm:
        * platform/graphics/mac/FontDataMac.mm: Renamed to SimpleFontDataMac.mm.
        * platform/graphics/mac/FontMac.mm:
        * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
        * platform/graphics/mac/SimpleFontDataMac.mm: Copied from WebCore/platform/graphics/mac/FontDataMac.mm.
        * platform/graphics/qt/FontDataQt.cpp: Renamed to SimpleFontDataQt.cpp.
        * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
        * platform/graphics/qt/SimpleFontDataQt.cpp: Copied from WebCore/platform/graphics/qt/FontDataQt.cpp.
        * platform/graphics/win/FontCacheWin.cpp:
        * platform/graphics/win/FontDataWin.cpp: Renamed to
        * platform/graphics/win/FontWin.cpp:
        * platform/graphics/win/GlyphPageTreeNodeWin.cpp:
        * platform/graphics/win/SimpleFontDataWin.cpp: Copied from WebCore/platform/graphics/win/FontDataWin.cpp.
        * platform/graphics/wx/FontCacheWx.cpp:
        * platform/graphics/wx/FontDataWx.cpp: Renamed to SimpleFontDataWx.cpp.
        * platform/graphics/wx/FontWx.cpp:
        * platform/graphics/wx/GlyphMapWx.cpp:
        * platform/graphics/wx/SimpleFontDataWx.cpp: Copied from WebCore/platform/graphics/wx/FontDataWx.cpp.
        * platform/mac/FileChooserMac.mm:
        * platform/mac/PopupMenuMac.mm:
        * platform/mac/WebCoreTextRenderer.mm:
        * platform/win/PopupMenuWin.cpp:
        * platform/win/UniscribeController.cpp:
        * platform/win/UniscribeController.h:
        * svg/SVGFont.cpp:
        * svg/SVGFontElement.cpp:
        * svg/SVGFontFaceElement.cpp:
        * svg/SVGFontFaceElement.h:
        * svg/SVGGlyphElement.cpp:


        Reviewed by Dave Hyatt.

        - <rdar://problem/5665216> Support the unicode-range property in @font-face rules

        * Misc/WebNSAttributedStringExtras.mm:


        Reviewed by Dave Hyatt.

        - <rdar://problem/5665216> Support the unicode-range property in @font-face rules

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoNot reviewed. Try to fix mac build by forcing SVGNames regeneration.
zimmermann@webkit.org [Mon, 7 Jan 2008 23:15:59 +0000 (23:15 +0000)]
Not reviewed. Try to fix mac build by forcing SVGNames regeneration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoNot reviewed. Proposed build fix for wx.
zimmermann@webkit.org [Mon, 7 Jan 2008 23:10:38 +0000 (23:10 +0000)]
Not reviewed. Proposed build fix for wx.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago 64-bit build fix
mitz@apple.com [Mon, 7 Jan 2008 23:03:18 +0000 (23:03 +0000)]
    64-bit build fix

        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData): Have to use a
        cast here since FMGetFontFromATSFontRef() is not available on 64-bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Oliver. Parts reviewed by Eric, David Hyatt & Dan & Alexey.
zimmermann@webkit.org [Mon, 7 Jan 2008 22:56:54 +0000 (22:56 +0000)]
Reviewed by Oliver. Parts reviewed by Eric, David Hyatt & Dan & Alexey.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=15741 (REGRESSION: svg/W3C-SVG-1.1/fonts-elem-03-b.svg shows worse behavior on TOT)
Display SVG Fonts, fill svg/SVGFont.cpp with life by adding all needed code to
measure & render glyphs contained in SVG Fonts, including ligature lookup support.

Fixes dozens of testcases, see ChangeLog for details.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by David Kilzer.
darin@apple.com [Mon, 7 Jan 2008 22:10:54 +0000 (22:10 +0000)]
    Rubber stamped by David Kilzer.

        - get rid of empty fpconst.cpp

        * GNUmakefile.am: Remove fpconst.cpp.
        * JavaScriptCore.pri: Ditto.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
        * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
        * JavaScriptCoreSources.bkl: Ditto.

        * kjs/fpconst.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRubberstamped by Oliver.
zimmermann@webkit.org [Mon, 7 Jan 2008 22:01:17 +0000 (22:01 +0000)]
Rubberstamped by Oliver.

Fix all SVG layout tests now that DRT works again reliable for SVG pixel tests.

Move all *-expected.txt files into platform/mac (as most contain text, and other measured values)
Leave only -expected.txt files there which dump as text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by David Kilzer.
darin@apple.com [Mon, 7 Jan 2008 21:50:51 +0000 (21:50 +0000)]
    Reviewed by David Kilzer.

        - fix alignment problem with NaN and Inf globals

        * kjs/fpconst.cpp: Move the contents of this file from here back to
        value.cpp. The reason this was in a separate file is that the DARWIN
        version of this used a declaration of the globals with a different
        type to avoid creating "init routines". That's no longer necessary for
        DARWIN and was never necessary for the non-DARWIN code path.
        To make this patch easy to merge, I didn't actually delete this file
        yet. We'll do that in a separate changeset.

        * kjs/value.cpp: If C99's NAN and INFINITY are present, then use them,
        othrewise use the union trick from fpconst.cpp. I think it would be
        better to eliminate KJS::NaN and KJS::Inf and just use NAN and INFINITY
        directly or std::numeric_limits<double>::quiet_nan() and
        std::numeric_limits<double>::infinity(). But when I tried that, it
        slowed down SunSpider. Someone else could do that cleanup if they
        could do it without slowing down the engine.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - Updated to run a test whose failure was only a build bot state issue.
kmccullough@apple.com [Mon, 7 Jan 2008 21:46:39 +0000 (21:46 +0000)]
    - Updated to run a test whose failure was only a build bot state issue.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for bug 13095, CSS3 multiple backgrounds don't work on table cells.
hyatt@apple.com [Mon, 7 Jan 2008 21:15:47 +0000 (21:15 +0000)]
    Fix for bug 13095, CSS3 multiple backgrounds don't work on table cells.

        Reviewed by Dan

        * rendering/RenderBox.h:
        * rendering/RenderTableCell.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * platform/win/Skipped: Skip the culprit, not the victim.
aroben@apple.com [Mon, 7 Jan 2008 20:50:03 +0000 (20:50 +0000)]
    * platform/win/Skipped: Skip the culprit, not the victim.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix
aroben@apple.com [Mon, 7 Jan 2008 20:43:10 +0000 (20:43 +0000)]
    Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added
        JavaScript.h to the project.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
        Copy JavaScript.h to WEBKITOUTPUTDIR.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
timothy@apple.com [Mon, 7 Jan 2008 20:37:03 +0000 (20:37 +0000)]
    Reviewed by Darin.

        Fix Mac build.

        * API/JSNode.c:
        * API/JSNode.h:
        * API/JSNodeList.c:
        * API/JSNodeList.h:
        * API/JavaScript.h:
        * API/JavaScriptCore.h:
        * API/minidom.c:
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * platform/win/Skipped: Added a few more failures.
aroben@apple.com [Mon, 7 Jan 2008 20:22:23 +0000 (20:22 +0000)]
    * platform/win/Skipped: Added a few more failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Remove a now incorrect Windows-specific result
aroben@apple.com [Mon, 7 Jan 2008 20:02:04 +0000 (20:02 +0000)]
    Remove a now incorrect Windows-specific result

        This should have been done as part of r29187

        * platform/win/fast/dom/wrapper-classes-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixes: http://bugs.webkit.org/show_bug.cgi?id=16244
zimmermann@webkit.org [Mon, 7 Jan 2008 19:58:24 +0000 (19:58 +0000)]
Fixes: bugs.webkit.org/show_bug.cgi?id=16244
DRT doesn't handle platform specific pixel test results correctly.

<test>-expected.txt files and <test>-expected.png files may now live
in different directories (ie. a cross-platform <test>-expected.txt file
and a platform-specific <test>-expected.png file).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-07 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 7 Jan 2008 19:30:40 +0000 (19:30 +0000)]
2008-01-07  Alp Toker  <alp@atoker.com>

        Reviewed by Darin.

        JavaScriptCore.h is not suitable for platforms other than Mac OS X

        Introduce a new JavaScriptCore/JavaScript.h public API header. This
        should be used by all new portable code using the JavaScriptCore API.

        JavaScriptCore/JavaScriptCore.h will remain for compatibility with
        existing applications that depend on it including JSStringRefCF.h
        which isn't portable.

        Also add minidom to the GTK+/autotools build since we can now support
        it on all platforms.

        * API/JSNode.h:
        * API/JSNodeList.h:
        * API/JavaScript.h: Added.
        * API/JavaScriptCore.h:
        * ForwardingHeaders/JavaScriptCore/JavaScript.h: Added.
        * GNUmakefile.am:
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Fix indention
zecke@webkit.org [Mon, 7 Jan 2008 19:16:24 +0000 (19:16 +0000)]
* Fix indention

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* The ContextMenuController is going to live longer than the ContextMenu. It is
zecke@webkit.org [Mon, 7 Jan 2008 19:15:58 +0000 (19:15 +0000)]
* The ContextMenuController is going to live longer than the ContextMenu. It is
  going to live as long as the WebCore::Page is around where the ContextMenu, specially
  in the case of a SubMenu, is gone before we popup the menu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Fix SubMenu handling
zecke@webkit.org [Mon, 7 Jan 2008 19:15:31 +0000 (19:15 +0000)]
* Fix SubMenu handling
* Do not connect to the activated signal if we are a separator or submenu
* Change our type from ActionType to SubMenuType when we have a submenu
* Initialize the SubMenu

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Qt and Gtk must know if a ContextMenuItem is checkable. Add a new ContextMenuItemTy...
zecke@webkit.org [Mon, 7 Jan 2008 19:14:58 +0000 (19:14 +0000)]
* Qt and Gtk must know if a ContextMenuItem is checkable. Add a new ContextMenuItemType for checkable
* Use this information in the Gtk platform to create a GtkCheckMenuItem when needed.
* Update the ContextMenuController to accept CheckableActionTypes as well.
* Change ContextMenu.cpp to use the CheckableActionType. The information if a item is checkable
  was extracted from ContextMenu::checkOrEnableIfNeeded.
* Update the Qt and Windows port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
kmccullough@apple.com [Mon, 7 Jan 2008 18:04:17 +0000 (18:04 +0000)]

        Reviewed by Darin.

        - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
        DRT did not correctly handle printing the '\0' char.  Now it does.

        * DumpRenderTree/win/DumpRenderTree.cpp:


        Reviewed by Darin.

        - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing.
        Since they pass now, the two tests are removed from the Skipped list.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-07 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Mon, 7 Jan 2008 16:23:06 +0000 (16:23 +0000)]
2008-01-07  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        [GTK] Context menu doesn't feel or look native - no icons

        Use GTK+ stock icons for menu items where possible.

        * platform/gtk/ContextMenuItemGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
mitz@apple.com [Mon, 7 Jan 2008 15:16:41 +0000 (15:16 +0000)]
    Reviewed by John Sullivan.

        - make the ATSUI code path work with custom fonts rather than crash

        * platform/graphics/mac/FontCustomPlatformData.cpp:
        * platform/graphics/mac/FontMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix for the Windows build. MSVC wants to see the full
hausmann@webkit.org [Mon, 7 Jan 2008 13:29:00 +0000 (13:29 +0000)]
Build fix for the Windows build. MSVC wants to see the full
declaration of arguments even when just passing them through.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded the missing parameters to make it possible to do POST operations from the publi...
hausmann@webkit.org [Mon, 7 Jan 2008 11:38:00 +0000 (11:38 +0000)]
Added the missing parameters to make it possible to do POST operations from the public API.

This is ugly though as it also requires including qnetworkaccessmanager.h. It would be nicer if the
two extra arguments were in QNetworkRequest :-/

Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoabort() now emits the signals, so disconnect them before you abort()
hausmann@webkit.org [Mon, 7 Jan 2008 11:36:34 +0000 (11:36 +0000)]
abort() now emits the signals, so disconnect them before you abort()

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUse a faster and safer way of flattening the form data.
hausmann@webkit.org [Mon, 7 Jan 2008 11:36:16 +0000 (11:36 +0000)]
Use a faster and safer way of flattening the form data.

Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoPorted of the network backend of the Qt platform to Qt 4.4's new networking API.
hausmann@webkit.org [Mon, 7 Jan 2008 11:35:55 +0000 (11:35 +0000)]
Ported of the network backend of the Qt platform to Qt 4.4's new networking API.

Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Remove m_dirtyRegion as it is not used as we pass every dirty region
hausmann@webkit.org [Mon, 7 Jan 2008 10:46:38 +0000 (10:46 +0000)]
* Remove m_dirtyRegion as it is not used as we pass every dirty region
  directly to the ChromeClient

Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Move the QWebPagePrivate methods up to the other private ones
hausmann@webkit.org [Mon, 7 Jan 2008 10:46:23 +0000 (10:46 +0000)]
* Move the QWebPagePrivate methods up to the other private ones

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Add reimplemented comments for the methods reimplemented in QWebView and QWebPage.
hausmann@webkit.org [Mon, 7 Jan 2008 10:46:08 +0000 (10:46 +0000)]
* Add reimplemented comments for the methods reimplemented in QWebView and QWebPage.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* This layout is not needed anymore as Widget::invalidateRect will not
hausmann@webkit.org [Mon, 7 Jan 2008 10:45:49 +0000 (10:45 +0000)]
* This layout is not needed anymore as Widget::invalidateRect will not
  draw anymore.

Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
eric@webkit.org [Mon, 7 Jan 2008 06:06:43 +0000 (06:06 +0000)]
    Reviewed by Sam.

        Abstract all DateObject.set* functions in preparation for fixing:

        SunSpider had random changes here and there but was overall a wash.

        * kjs/date_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Oliver.
zimmermann@webkit.org [Sun, 6 Jan 2008 22:52:10 +0000 (22:52 +0000)]
Reviewed by Oliver.
Small CG paint server cleanups - use more GraphicsContext method where possible.p

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Dan.
zimmermann@webkit.org [Sun, 6 Jan 2008 22:43:42 +0000 (22:43 +0000)]
Reviewed by Dan.
Add new helper function isArabicChar - SVG Fonts support needs it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andrew@webkit.org [Sun, 6 Jan 2008 22:33:25 +0000 (22:33 +0000)]

        Reviewed by Darin.

        DOMRange doesn't correctly re-size when inserting items (Acid3)

        Update the offset for the range when inserting items into the range.

        Test: fast/dom/Range/range-modifycontents.html

        * dom/Range.cpp:


        Reviewed by Darin.

        DOMRange doesn't correctly re-size when inserting items (Acid3)

        Update the offset for the range when inserting items into the range.

        * fast/dom/Range/range-modifycontents-expected.txt: Added.
        * fast/dom/Range/range-modifycontents.html: Added.
        * fast/dom/Range/resources/range-modifycontents.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add missing expected result.
weinig@apple.com [Sun, 6 Jan 2008 22:25:02 +0000 (22:25 +0000)]
    Add missing expected result.

        * fast/dom/TreeWalker/TreeWalker-currentNode-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by darin.
eric@webkit.org [Sun, 6 Jan 2008 20:35:04 +0000 (20:35 +0000)]
    Reviewed by darin.

        Make attr selectors case-insensitive for certain HTML attributes

        Test: fast/css/html-attr-case-sensitivity.html

        * css/CSSStyleSelector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Sun, 6 Jan 2008 19:35:43 +0000 (19:35 +0000)]
    Reviewed by Darin.

        Incorrect node type for whitespace when setting innerHTML in an XHTML document

        Test: fast/dom/xhtml-fragment-whitespace.xhtml

        * dom/XMLTokenizer.cpp: (WebCore::parseXMLDocumentFragment):
        Use balancedCharactersHandler for ignorable whitespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Sun, 6 Jan 2008 19:33:12 +0000 (19:33 +0000)]
    Reviewed by Darin.

        <rdar://problem/5666580> REGRESSION: URL-encoded space (%20) in livejournal url
        causes page load error

        Test: http/tests/misc/location-with-space.php

        * platform/network/cf/ResourceRequestCFNet.cpp:
        (WebCore::ResourceRequest::doUpdatePlatformRequest): Do update its URL, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-06 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 6 Jan 2008 19:10:01 +0000 (19:10 +0000)]
2008-01-06  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Use $(EXEEXT) to account for the .exe extension in the GTK+ Windows
        build. (This is already done correctly in DerivedSources.make.) Issue
        noticed by Mikkel when building in Cygwin.

        Add a missing slash. This was a hack from the qmake build system that
        isn't necessary with autotools.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
mrowe@apple.com [Sun, 6 Jan 2008 11:35:47 +0000 (11:35 +0000)]
Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.

Reviewed by Alp Toker.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(processWork): Process pending work.
(webViewLoadFinished): Schedule processing of pending work.
* DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andrew@webkit.org [Sun, 6 Jan 2008 11:27:45 +0000 (11:27 +0000)]

        Reviewed by Darin.

        DOMRange.cloneContents does not work (Acid3 bug)

        When cloning an empty range, return an empty DocmentFragment instead of
        null or undefined.

        Test: fast/dom/Range/range-clone-empty.html

        * dom/Range.cpp:


        Reviewed by Darin.

        DOMRange.cloneContents does not work (Acid3 bug)

        When cloning an empty range, return an empty DocmentFragment instead of
        null or undefined.

        * fast/dom/Range/range-clone-empty-expected.txt: Added.
        * fast/dom/Range/range-clone-empty.html: Added.
        * fast/dom/Range/resources/range-clone-empty.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-06 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Sun, 6 Jan 2008 10:57:17 +0000 (10:57 +0000)]
2008-01-06  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        Remove curl handles immediately if the timer is not running.

        * platform/network/curl/ResourceHandleManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-06 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 6 Jan 2008 08:48:10 +0000 (08:48 +0000)]
2008-01-06  Alp Toker  <alp@atoker.com>

        Reviewed by Eric.

        Cairo canvas refcounting fix. Reference the surface in the constructor
        to match its destruction in the destructor.

        Fixes a crash triggered by leaving this page:

        * html/CanvasPattern.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam.
eric@webkit.org [Sun, 6 Jan 2008 08:13:43 +0000 (08:13 +0000)]
    Reviewed by Sam.

        Fix :checked matching type='text' and add test case

        Test: fast/dom/HTMLInputElement/checked-pseudo-selector.html

        * html/HTMLInputElement.h: isChecked() can only be true for RADIO or CHECKBOX

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig@apple.com [Sun, 6 Jan 2008 02:36:11 +0000 (02:36 +0000)]

        Reviewed by Eric Seidel.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=16758
        ASSERT when using TreeWalker methods for a current node outside of the root (Acid3)

        - Ensure that returned nodes are within the root node, or return 0, in adherence with the spec.

        Test: fast/dom/TreeWalker/TreeWalker-currentNode.html

        * dom/TreeWalker.cpp:


        Reviewed by Eric Seidel.

        Test for http://bugs.webkit.org/show_bug.cgi?id=16758
        ASSERT when using TreeWalker methods for a current node outside of the root (Acid3)

        * fast/dom/TreeWalker: Added.
        * fast/dom/TreeWalker/TreeWalker-currentNode.html: Added.
        * fast/dom/TreeWalker/resources: Added.
        * fast/dom/TreeWalker/resources/TreeWalker-currentNode.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * Scripts/do-webcore-rename: Some more renaming plans.
darin@apple.com [Sun, 6 Jan 2008 02:24:30 +0000 (02:24 +0000)]
    * Scripts/do-webcore-rename: Some more renaming plans.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * API/JSRetainPtr.h: One more file that needed the change below.
darin@apple.com [Sun, 6 Jan 2008 02:16:32 +0000 (02:16 +0000)]
    * API/JSRetainPtr.h: One more file that needed the change below.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * wtf/OwnPtr.h: OwnPtr needs the same fix as RefPtr below.
darin@apple.com [Sun, 6 Jan 2008 02:14:29 +0000 (02:14 +0000)]
    * wtf/OwnPtr.h: OwnPtr needs the same fix as RefPtr below.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
aroben@apple.com [Sun, 6 Jan 2008 02:12:37 +0000 (02:12 +0000)]
    Build fix.

        Reviewed by Maciej.

        * wtf/RetainPtr.h: Use PtrType instead of T* because of the
        RemovePointer magic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Maciej Stachowiak.
darin@apple.com [Sat, 5 Jan 2008 22:46:03 +0000 (22:46 +0000)]
    Rubber stamped by Maciej Stachowiak.

        - cut down own PIC branches by using a pointer-to-member-data instead of a
          pointer-to-member-function in WTF smart pointers

        * wtf/OwnArrayPtr.h:
        * wtf/OwnPtr.h:
        * wtf/PassRefPtr.h:
        * wtf/RefPtr.h:
        * wtf/RetainPtr.h:
        Use a pointer to the m_ptr member instead of the get member.
        The GCC compiler generates better code for this idiom.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-05 Alp Toker <alp@atoker.com>
alp@webkit.org [Sat, 5 Jan 2008 11:44:02 +0000 (11:44 +0000)]
2008-01-05  Alp Toker  <alp@atoker.com>

        Rubber-stamped by Mark Rowe.

        Fix configure script output with correct descriptions of the default
        configuration options.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-05 Sylvain Pasche <sylvain.pasche@gmail.com>
alp@webkit.org [Sat, 5 Jan 2008 10:23:01 +0000 (10:23 +0000)]
2008-01-05  Sylvain Pasche  <sylvain.pasche@gmail.com>

        Reviewed by Alp Toker.

        Allow autogen.sh invocation from a separate build directory.

        * autogen.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-05 Henry Mason <hmason@mac.com>
mrowe@apple.com [Sat, 5 Jan 2008 08:26:08 +0000 (08:26 +0000)]
2008-01-05  Henry Mason  <hmason@mac.com>

        Reviewed by Maciej Stachowiak.

        Bug 16738: Collector block offset could be stored as an cell offset instead of a byte offset

        Gives a 0.4% SunSpider boost and prettier code.

        * kjs/collector.cpp: Switched to cell offsets from byte offsets

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoHave the two malloc zones print useful diagnostics if their free method are unexpecte...
mrowe@apple.com [Sat, 5 Jan 2008 08:02:06 +0000 (08:02 +0000)]
Have the two malloc zones print useful diagnostics if their free method are unexpectedly invoked.
Due to <rdar://problem/5671357> this can happen if an application attempts to free a pointer that
was not allocated by any registered malloc zone on the system.

Reviewed by Maciej Stachowiak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - update the list of tests failing on Windows because of font
mitz@apple.com [Sat, 5 Jan 2008 05:45:06 +0000 (05:45 +0000)]
    - update the list of tests failing on Windows because of font
          differences and uncomment a test that has been re-enabled on Mac.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix bounds computation bugs responsible for http://bugs.webkit.org/show_bug.cgi?id...
oliver@apple.com [Sat, 5 Jan 2008 05:20:11 +0000 (05:20 +0000)]
Fix bounds computation bugs responsible for bugs.webkit.org/show_bug.cgi?id=16015
and other image repaint bugs.

Reviewed by Beth Dakin.

We now cache the full local bounds for the <image> element, as otherwise certain
combinations of attribute changes could result in incorrect dirty rects.
Additionally we no longer use any of the integer bounds fields on RenderObject for
determining repaint bounds (this was the principle cause of bug #16015).

I also removed the outline painting code as it was both wrong, and not correctly
repainted.  I feel safe doing this as no other browser or viewer supports outline
properties on svg elements.

I was unable to make a testcase for this unfortunately, despite seemingly deterministic
behaviour :(

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
bdakin@apple.com [Sat, 5 Jan 2008 05:13:25 +0000 (05:13 +0000)]

        Reviewed by Oliver.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=16704 input with
        type="hidden" matches :enabled/:disabled (Acid3 bug)

        Prevent :enabled and :disabled from applying to input type="hidden"

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::checkOneSelector): Rather than
        allowing :enabled and :disabled to apply to all controls, only
        allow it to apply to non-"hidden" controls
        * dom/Element.h:
        * html/HTMLInputElement.h:


        Reviewed by Oliver.

        Test for http://bugs.webkit.org/show_bug.cgi?id=16704 input with
        type="hidden" matches :enabled/:disabled (Acid3 bug)

        * fast/forms/hidden-input-not-enabled-expected.txt: Added.
        * fast/forms/hidden-input-not-enabled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add missing expected result.
weinig@apple.com [Sat, 5 Jan 2008 04:05:30 +0000 (04:05 +0000)]
    Add missing expected result.

        * fast/images/border-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig@apple.com [Sat, 5 Jan 2008 04:04:31 +0000 (04:04 +0000)]

        Reviewed by Oliver Hunt.

        - Match the spec when calling getFloatValue, getStringValue, getCounterValue,
          getRectValue and getRGBColorValue of CSSPrimitiveValue by throwing exceptions
          if the type of the CSSPrimitiveValue is not the same as the type requested.
        - Fix the intermittent assertion failure seen in svg/css/glyph-orientation-rounding-test.xhtml

        Test: fast/css/CSSPrimitiveValue-exceptions.html

        * css/CSSPrimitiveValue.cpp:
        * css/CSSPrimitiveValue.h:
        * css/CSSPrimitiveValue.idl:


        Reviewed by Oliver Hunt.

        Throw exceptions for the CSSPrimitiveValue getters, matching the spec.

        * fast/css/CSSPrimitiveValue-exceptions-expected.txt: Added.
        * fast/css/CSSPrimitiveValue-exceptions.html: Added.
        * fast/css/resources/CSSPrimitiveValue-exceptions.js: Added.
        * fast/dom/prototypes.html:
        * fast/dom/wrapper-classes.html:
        * platform/mac/fast/dom/wrapper-classes-objc.html:
        * svg/css/glyph-orientation-rounding-test-expected.txt:
        * svg/css/glyph-orientation-rounding-test.xhtml: Pass in a unit so this doesn't throw.
        This patch also fixes the associated intermittent failure seen in this test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
antti@apple.com [Sat, 5 Jan 2008 02:32:12 +0000 (02:32 +0000)]
    Reviewed by Darin.

        Windows part of <rdar://problem/5647034>
        Media tests crash if an old version of QuickTime is installed

        Check QuickTime version on Windows too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin McCullough.
weinig@apple.com [Sat, 5 Jan 2008 01:51:02 +0000 (01:51 +0000)]
    Reviewed by Kevin McCullough.

        - Splits Objective-C tests out of wrapper-classes.html and into platform specific test.
        - Adds tests for .__proto__ and .constructor to JS wrapper tests.

        * fast/dom/wrapper-classes.html:
        * platform/mac/fast/dom/wrapper-classes-expected.txt:
        * platform/mac/fast/dom/wrapper-classes-objc-expected.txt: Added.
        * platform/mac/fast/dom/wrapper-classes-objc.html: Copied from fast/dom/wrapper-classes.html.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMove svg/batik/text/smallFonts.svg
slewis@apple.com [Sat, 5 Jan 2008 01:45:31 +0000 (01:45 +0000)]
Move svg/batik/text/smallFonts.svg
to skip list since it is still failing on tiger.

        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin@apple.com [Sat, 5 Jan 2008 01:11:12 +0000 (01:11 +0000)]

        Reviewed by Maciej and Alice.

        - fix <rdar://problem/4404302> Borders where there should be none (canadasmountains.com)

        Test: fast/images/border.html

        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::parseMappedAttribute): Change the code that handles cases
        where the border value is not a number to use the value "0" for the border width instead
        of not setting the border width and style at all. This matches other browsers, and makes
        more sense.


        Reviewed by Maciej and Alice.

        - test for <rdar://problem/4404302> Borders where there should be none (canadasmountains.com)

        * fast/images/border.html: Added.
        * fast/images/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
        * fast/images/resources/border.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
alice.liu@apple.com [Sat, 5 Jan 2008 00:32:52 +0000 (00:32 +0000)]

        Reviewed by Alexey and Darin.

        Adding "home" and "end" to DRT's keydown since
        DOM key events can't handle keyIdentifiers at this point.

        * DumpRenderTree/mac/EventSendingController.mm:
        (-[EventSendingController keyDown:withModifiers:]):
        * DumpRenderTree/win/EventSender.cpp:


        Reviewed by Alexey and Darin.

        * editing/selection/move-begin-end.html:
        add a codepath that will test the same kind of functionality for home and end keys
        * platform/win/Skipped:
        removing section of tests that have been resolved

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Try to fix 64-bit build
antti@apple.com [Sat, 5 Jan 2008 00:28:13 +0000 (00:28 +0000)]
    Try to fix 64-bit build

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix another stringImpl leak.
slewis@apple.com [Sat, 5 Jan 2008 00:15:29 +0000 (00:15 +0000)]
Fix another stringImpl leak.

        * platform/text/StringImpl.cpp: remove an extra allocation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mitz.
alice.liu@apple.com [Fri, 4 Jan 2008 23:34:39 +0000 (23:34 +0000)]
    Reviewed by Mitz.

        * platform/graphics/win/FontCacheWin.cpp:
        fix loop condition that was causing crash

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate tiger layout test results for svg/batik/text/smallFonts, and move to mac-tiger...
oliver@apple.com [Fri, 4 Jan 2008 22:56:41 +0000 (22:56 +0000)]
Update tiger layout test results for svg/batik/text/smallFonts, and move to mac-tiger platform


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
timothy@apple.com [Fri, 4 Jan 2008 22:43:44 +0000 (22:43 +0000)]
    Reviewed by Adam Roben.

        <rdar://problem/5671059> Always show the Timeline and Console buttons in the Inspector

        * page/inspector/inspector.css: Remove styles related to the toggle button
          and make the area always visible.
        * page/inspector/inspector.html: Remove the toggle button.
        * page/inspector/inspector.js: Remove code to toggle the status area.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
ap@webkit.org [Fri, 4 Jan 2008 22:35:29 +0000 (22:35 +0000)]
    Reviewed by Adam Roben.

        Restore compatibility with shipping Safari beta.

        REGRESSION: Crash on Safari Start

        * Interfaces/IWebViewPrivate.idl: Should have added a new method at the end.

        Temporarily restore BackwardDelete for Windows nightlies to work correctly.

        * editing/EditorCommand.cpp: (WebCore::CommandEntry::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap@webkit.org [Fri, 4 Jan 2008 22:27:34 +0000 (22:27 +0000)]
    Reviewed by Darin.

        <rdar://problem/5611712> xsl:sort does not use a case folding sort, and the 'case-order' attribute is ignored (16077)

        Enable the fix on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix build.
antti@apple.com [Fri, 4 Jan 2008 22:08:43 +0000 (22:08 +0000)]
    Fix build.

        * bindings/js/JSHTMLElementWrapperFactory.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
antti@apple.com [Fri, 4 Jan 2008 21:44:52 +0000 (21:44 +0000)]
    Reviewed by Darin.

        Partial fix for <rdar://problem/5647034>
        Media tests crash if an old version of QuickTime is installed

        Disable media support if QuickTime is not current enough (>=7.3).

        Windows patch coming soon.

        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        * bindings/js/kjs_window.cpp:
        * html/HTMLElementFactory.cpp:
        * platform/graphics/MediaPlayer.cpp:
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
timothy@apple.com [Fri, 4 Jan 2008 21:02:16 +0000 (21:02 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/5604409> JavaScript privilege escalation when Web Inspector accesses page unsafely (16011)

        Check if the property is a getter before asking for the value.
        If the property is a getter, we no longer show the value.

        * page/inspector/PropertiesSidebarPane.js:
        * page/inspector/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 4 Jan 2008 20:54:24 +0000 (20:54 +0000)]
2008-01-04  Alp Toker  <alp@atoker.com>

        Rubber-stamped by Mark Rowe.

        Remove AM_MAINTAINER_MODE, as recommended by the automake manual. The
        "rebuild rules" will now be enabled by default.

        This obviates the need to pass '--enable-maintainer-mode' to

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text
aroben@apple.com [Fri, 4 Jan 2008 19:31:37 +0000 (19:31 +0000)]
Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text


        Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text

        Test: platform/win/editing/selection/shift-page-down-up.html

        Reviewed by Oliver.

        * WebView.cpp: Correct the commands associated with


        Added a test for <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text

        Reviewed by Oliver.

        * platform/win/editing/selection/shift-page-up-down-expected.txt: Added.
        * platform/win/editing/selection/shift-page-up-down.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago<rdar://problem/5646437> REGRESSION (r28015): svg/batik/text/smallFonts fails
oliver@apple.com [Fri, 4 Jan 2008 19:25:37 +0000 (19:25 +0000)]
<rdar://problem/5646437> REGRESSION (r28015): svg/batik/text/smallFonts fails

Reviewed by Darin

Regenerated expected output as filter elements are no longer generated in a default
build.  This wasn't done when filters were turned off earlier due to other (now gone)
layout failures i didn't want to put in the expected output.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
mitz@apple.com [Fri, 4 Jan 2008 19:23:07 +0000 (19:23 +0000)]
    Reviewed by Darin Adler.

        - fix synthetic bold and italic on Windows

        Covered by an existing test.

        * platform/graphics/win/FontPlatformDataWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * platform/win/Skipped: Added some more failures.
aroben@apple.com [Fri, 4 Jan 2008 17:18:24 +0000 (17:18 +0000)]
    * platform/win/Skipped: Added some more failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2008-01-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 4 Jan 2008 14:52:11 +0000 (14:52 +0000)]
2008-01-04  Alp Toker  <alp@atoker.com>

        GTK+ autotools build fix. Terminate empty rules.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agofix DRT after the changes to QWebPage.
hausmann@webkit.org [Fri, 4 Jan 2008 14:49:50 +0000 (14:49 +0000)]
fix DRT after the changes to QWebPage.

The great thing is that we actually don't have
any regressions from the QWebPage change :)

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove most dependencies of Widget/ScrollView onto native QWidgets.
hausmann@webkit.org [Fri, 4 Jan 2008 14:49:32 +0000 (14:49 +0000)]
Remove most dependencies of Widget/ScrollView onto native QWidgets.

This also brings the code closer in line with the Windows code. Seems
to work nicely on first try :)

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Remove the todo from QWebPage and move the code to QWebView.
hausmann@webkit.org [Fri, 4 Jan 2008 14:48:55 +0000 (14:48 +0000)]
* Remove the todo from QWebPage and move the code to QWebView.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Move the various event methods to QWebPagePrivate. This is similar to
hausmann@webkit.org [Fri, 4 Jan 2008 14:48:37 +0000 (14:48 +0000)]
* Move the various event methods to QWebPagePrivate. This is similar to
  QTextControl as well.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago* Forward the event from QWebView to QWebPage through QObject::event. This
hausmann@webkit.org [Fri, 4 Jan 2008 14:48:15 +0000 (14:48 +0000)]
* Forward the event from QWebView to QWebPage through QObject::event. This
  is similar to the way QTextControl is working.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agomake QWebPage a QObject and get things to compile.
hausmann@webkit.org [Fri, 4 Jan 2008 14:47:45 +0000 (14:47 +0000)]
make QWebPage a QObject and get things to compile.

Nothing works currently though.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded some preliminary class documentation for QWebView, fixed a missing const()...
hausmann@webkit.org [Fri, 4 Jan 2008 12:26:03 +0000 (12:26 +0000)]
Added some preliminary class documentation for QWebView, fixed a missing const() and some missing Q_PROPERTYs

Signed-off-by: Lars
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadd a viewportSize to QWebPage.
hausmann@webkit.org [Fri, 4 Jan 2008 12:25:42 +0000 (12:25 +0000)]
add a viewportSize to QWebPage.

This is required to eventually make it a QObject only.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29160 268f45cc-cd09-0410-ab3c-d52691b4dbfc