keishi@webkit.org [Fri, 10 Jun 2011 05:54:26 +0000 (05:54 +0000)]
Rollback 88521
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Fri, 10 Jun 2011 05:49:06 +0000 (05:49 +0000)]
test
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 10 Jun 2011 04:43:03 +0000 (04:43 +0000)]
Build fix: Corrected header spelling.
* heap/OldSpace.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 10 Jun 2011 04:38:23 +0000 (04:38 +0000)]
2011-06-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added OldSpace to the project
https://bugs.webkit.org/show_bug.cgi?id=62417
Currently unused.
Added OldSpace, the ability to iterate NewSpace vs OldSpace, and a
per-block flag for testing whether you're in NewSpace vs OldSpace.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Build!
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::inNewSpace):
(JSC::MarkedBlock::setInNewSpace): Added inNewSpace flag, for use in
write barrier.
* heap/NewSpace.cpp:
(JSC::NewSpace::addBlock):
(JSC::NewSpace::removeBlock):
* heap/NewSpace.h:
(JSC::NewSpace::forEachBlock): Added forEachBlock, to use for
NewSpace-specific operations.
* heap/OldSpace.cpp: Added.
(JSC::OldSpace::OldSpace):
(JSC::OldSpace::addBlock):
(JSC::OldSpace::removeBlock):
* heap/OldSpace.h: Added.
(JSC::OldSpace::forEachBlock): New class for holding promoted blocks.
Not in use yet.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 10 Jun 2011 03:52:46 +0000 (03:52 +0000)]
2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361
Add PLATFORM(EFL) to enable ACCELERATED_COMPOSITING on EFL port.
* wtf/Platform.h:
2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361
Add a new class, GraphicsLayerEfl - not yet implemented.
Add ACCELERATED_COMPOSITING related files to CMakeLists.
* CMakeLists.txt:
* CMakeListsEfl.txt:
* platform/graphics/efl/GraphicsLayerEfl.cpp: Added.
(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerEfl::GraphicsLayerEfl):
(WebCore::GraphicsLayerEfl::~GraphicsLayerEfl):
(WebCore::GraphicsLayerEfl::setNeedsDisplay):
(WebCore::GraphicsLayerEfl::setNeedsDisplayInRect):
* platform/graphics/efl/GraphicsLayerEfl.h: Added.
2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Make accelerated compositing build in Webkit-EFL
https://bugs.webkit.org/show_bug.cgi?id=62361
Add functions for accelerated compositing to ChromeClientEfl.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::attachRootGraphicsLayer):
(WebCore::ChromeClientEfl::setNeedsOneShotDrawingSynchronization):
(WebCore::ChromeClientEfl::scheduleCompositingLayerSync):
(WebCore::ChromeClientEfl::allowedCompositingTriggers):
* WebCoreSupport/ChromeClientEfl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
demarchi@webkit.org [Fri, 10 Jun 2011 03:45:07 +0000 (03:45 +0000)]
2011-06-09 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[CMAKE] Never let USER_AGENT defined to nothing
https://bugs.webkit.org/show_bug.cgi?id=62410
This patch is similar to r88342, but sets WEBKIT_USER_AGENT_*
definitions only if that port defined it. A port might prefer to set it
in other place, e.g. a header that is part of the public API (like GTK
does).
By using #cmakedefine instead of #define, if that variable is not set
in CMake it will expand to:
/* #define WEBKIT_USER_AGENT_MAJOR_VERSION */
* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 10 Jun 2011 02:50:43 +0000 (02:50 +0000)]
[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881
https://bugs.webkit.org/show_bug.cgi?id=62278
Last attempt to make buildbot happy against crazy flakiness near inspector tests. :-/
* platform/qt/Skipped: Disable all inspector tests until fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
demarchi@webkit.org [Fri, 10 Jun 2011 02:43:40 +0000 (02:43 +0000)]
2011-05-30 Raphael Kubo da Costa <kubo@profusion.mobi>
Reviewed by Brent Fulgham.
[efl] Do not enable the encoding detector by default.
https://bugs.webkit.org/show_bug.cgi?id=61744
This should match the behaviour of other ports more closely, and makes
at least dom/xhtml/level3/core/documentgetinputencoding01.xhtml pass.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 10 Jun 2011 02:30:59 +0000 (02:30 +0000)]
[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881
https://bugs.webkit.org/show_bug.cgi?id=62278
One more attempt to make buildbot happy
against crazy flakiness near inspector tests. :-/
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 10 Jun 2011 01:59:33 +0000 (01:59 +0000)]
Unreviewed rolling out r88471, because it broke plugin tests on Qt.
Tools:
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventX11):
(NPP_GetValue):
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
(webkit_test_plugin_new_instance):
(webkit_test_plugin_destroy_instance):
(webkit_test_plugin_set_window):
(executeScript):
(webkit_test_plugin_new_stream):
(webkit_test_plugin_destroy_stream):
(webkit_test_plugin_stream_as_file):
(webkit_test_plugin_write_ready):
(webkit_test_plugin_write):
(webkit_test_plugin_print):
(keyEventToChar):
(webkit_test_plugin_handle_event):
(webkit_test_plugin_url_notify):
(webkit_test_plugin_get_value):
(webkit_test_plugin_set_value):
(NP_GetMIMEDescription):
(NP_Initialize):
(NP_Shutdown):
(NP_GetValue):
* GNUmakefile.am:
LayoutTests:
* platform/chromium-linux/plugins/mouse-events-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 10 Jun 2011 01:31:31 +0000 (01:31 +0000)]
[Mac] Unskip fast/forms/input-number-large-padding.html
https://bugs.webkit.org/show_bug.cgi?id=61845
It should work now because we don't use outer-spin-button anymore.
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Fri, 10 Jun 2011 01:09:11 +0000 (01:09 +0000)]
Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419
Reviewed by David Levin.
Source/WebCore:
Test: fast/files/blob-builder-crash.html
* fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):
LayoutTests:
* fast/files/blob-builder-crash-expected.txt: Added.
* fast/files/blob-builder-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
koz@chromium.org [Fri, 10 Jun 2011 01:08:15 +0000 (01:08 +0000)]
2011-06-09 James Kozianski <koz@chromium.org>
[Chromium] Unreviewed. Remove expectations for passing tests.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 10 Jun 2011 00:50:00 +0000 (00:50 +0000)]
2011-06-09 James Robinson <jamesr@chromium.org>
[chromium] Update some chromium gpu baselines
* platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 10 Jun 2011 00:30:25 +0000 (00:30 +0000)]
2011-06-09 James Robinson <jamesr@chromium.org>
[chromium] Mark the fullscreen directory as skipped
https://bugs.webkit.org/show_bug.cgi?id=62397
* platform/chromium/test_expectations.txt:
2011-06-09 James Robinson <jamesr@chromium.org>
Reviewed by Eric Seidel.
[chromium] webkitRequestFullscreen exposed to web even when feature is disabled
https://bugs.webkit.org/show_bug.cgi?id=62397
Remove ENABLE_FULLSCREEN_API define from chromium builds since this exposes the webkitRequestFullscreen function
even when the runtime setting was disabled.
* features.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 10 Jun 2011 00:30:21 +0000 (00:30 +0000)]
Bug 62405 - Fix integer overflow in Array.prototype.push
Reviewed by Geoff Garen.
Fix geoff's review comments re static_cast.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 10 Jun 2011 00:03:18 +0000 (00:03 +0000)]
2011-06-09 Jer Noble <jer.noble@apple.com>
Reviewed by David Hyatt.
Roll out r88468, and fix bug #61911 without making Element::offset functions virtual.
https://bugs.webkit.org/show_bug.cgi?id=62400
No new tests; covered by existing fullscreen/full-screen-video-offset.html test.
* rendering/RenderVideo.cpp:
(WebCore::rendererPlaceholder): Added; returns the placeholder block, if it exists.
(WebCore::RenderVideo::offsetLeft): Pass the offset request to the placeholder block.
(WebCore::RenderVideo::offsetTop): Ditto.
(WebCore::RenderVideo::offsetWidth): Ditto.
(WebCore::RenderVideo::offsetHeight): Ditto.
* rendering/RenderVideo.h: Added virtual overrides for the offset functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 10 Jun 2011 00:02:23 +0000 (00:02 +0000)]
2011-06-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Factored MarkedBlock set management into a helper class with a fast case Bloom filter
https://bugs.webkit.org/show_bug.cgi?id=62413
SunSpider reports a small speedup.
This is in preparation for having ConservativeSet operate on arbitrary
sets of MarkedBlocks, and in preparation for conservative scanning
becoming proportionally more important than other GC activities.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.xcodeproj/project.pbxproj: Build-o.
* heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::add):
* heap/ConservativeRoots.h:
(JSC::ConservativeRoots::ConservativeRoots): Operate on a MarkedBlockSet
directly, instead of a Heap, so we can operate on subsets of the Heap
instead.
Use a TinyBloomFilter for single-cycle exclusion of most pointers. This
is particularly important since we expect not to find our subject pointer
in the MarkedBlock hash, and hash misses are more expensive than typical
hash lookups because they have high collision rates.
No need for single-pointer add() to be public anymore, since nobody uses it.
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/Heap.h:
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock): Use MarkedBlockSet since that's what
ConservativeRoots relies on.
Nixed contains(), since nobody uses it anymore.
* heap/MarkedBlock.h:
(WTF::MarkedBlockHash::hash): Added a faster hash taking advantage of
the VM layout properties of MarkedBlocks.
* heap/MarkedBlockSet.h: Added.
(JSC::MarkedBlockSet::add):
(JSC::MarkedBlockSet::remove):
(JSC::MarkedBlockSet::recomputeFilter):
(JSC::MarkedBlockSet::filter):
(JSC::MarkedBlockSet::set):
* heap/TinyBloomFilter.h: Added.
(JSC::TinyBloomFilter::TinyBloomFilter):
(JSC::TinyBloomFilter::add):
(JSC::TinyBloomFilter::ruleOut): New helper class, used above.
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::gatherConservativeRoots): No need to specifically
exclude values by tag -- the tiny bloom filter is already a register-register
compare, so adding another "rule out" factor just slows things down.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 9 Jun 2011 23:46:54 +0000 (23:46 +0000)]
Bug 62405 - Fix integer overflow in Array.prototype.push
Reviewed by Oliver Hunt.
There are three integer overflows here, leading to safe (not a security risk)
but incorrect (non-spec-compliant) behaviour.
Two overflows occur when calculating the new length after pushing (one in the
fast version of push in JSArray, one in the generic version in ArrayPrototype).
The other occurs calculating indices to write to when multiple items are pushed.
These errors result in three test-262 failures.
Source/JavaScriptCore:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):
* runtime/JSArray.cpp:
(JSC::JSArray::put):
(JSC::JSArray::push):
LayoutTests:
* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A4_T2-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A4_T3-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 9 Jun 2011 23:33:49 +0000 (23:33 +0000)]
2011-06-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603
* platform/gtk/Skipped: Unskip a test that is now passing. Better describe remaining failures.
2011-06-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603
Added DumpRenderTreeSupport methods to support hasMarkedText and markedRange.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setComposition): Use start and length rather than start and
end. This matches other ports. Only use GLib style early returns when checking the
validity of GObjects.
(DumpRenderTreeSupportGtk::hasComposition): Added.
(DumpRenderTreeSupportGtk::compositionRange): Added.
(DumpRenderTreeSupportGtk::confirmComposition): Cleanup as described above.
(DumpRenderTreeSupportGtk::firstRectForCharacterRange): Cleanup as described above.
(DumpRenderTreeSupportGtk::selectedRange): Cleanup as described above.
* WebCoreSupport/DumpRenderTreeSupportGtk.h: Added new declarations.
2011-06-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
https://bugs.webkit.org/show_bug.cgi?id=55603
Add callbacks to support hasMarkedText and markedRange and also clean up existing
TextInputController support.
* DumpRenderTree/gtk/TextInputController.cpp:
(setMarkedTextCallback): Accept parameters in terms of start and length, instead
of start and end. This matches the other ports. Do not use GLib style early returns.
(hasMarkedTextCallback): Added.
(markedRangeCallback): Added.
(insertTextCallback): Cleanup as described above.
(unmarkTextCallback): Cleanup as described above.
(firstRectForCharacterRangeCallback): Cleanup as described above.
(selectedRangeCallback): Cleanup as described above.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Thu, 9 Jun 2011 23:04:51 +0000 (23:04 +0000)]
2011-06-09 Kenneth Russell <kbr@google.com>
Skipped new tests from r88489 on WebKit Win, since WebGL is not yet enabled.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 22:53:53 +0000 (22:53 +0000)]
2011-06-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339
Tests that a layer that should clip its children actually does clip even when scrolled offscreen.
* platform/chromium/compositing/scissor-out-of-viewport-expected.png: Added.
* platform/chromium/compositing/scissor-out-of-viewport-expected.txt: Added.
* platform/chromium/compositing/scissor-out-of-viewport.html: Added.
2011-06-09 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Scissor rect not set for clipping layers set offscreen
https://bugs.webkit.org/show_bug.cgi?id=62339
We set a scissorRect on each layer, but only layers with masksToBounds and their descendants should actually set
a scissor. Layers that didn't need to scissor had empty scissorRects. Unfortunately layers with masksToBounds
and their descendants that are scrolled offscreen also end up with an empty clipped scissor rect.
This patch sets an explicit bit on each layer that should scissor and then checks that bit instead of checking
for an empty scissor rect at draw time. RenderSurfaceChromiums have different requirements for
setScissorToRect, so the old behavior is still available with a flag. This can probably be cleaned up more.
Test: platform/chromium/compositing/scissor-out-of-viewport.html
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::LayerRendererChromium::setScissorToRect):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::draw):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setUsesLayerScissor):
(WebCore::CCLayerImpl::usesLayerScissor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 22:53:32 +0000 (22:53 +0000)]
2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88486.
http://trac.webkit.org/changeset/88486
https://bugs.webkit.org/show_bug.cgi?id=62409
Broke chromium-win compile (Requested by jamesr on #webkit).
* public/WebData.h:
* public/WebPageSerializer.h:
* src/WebData.cpp:
* src/WebPageSerializer.cpp:
(WebKit::WebPageSerializer::serialize):
(WebKit::WebPageSerializer::serializeToMHTML):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 22:23:23 +0000 (22:23 +0000)]
2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88468.
http://trac.webkit.org/changeset/88468
https://bugs.webkit.org/show_bug.cgi?id=62408
It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
on #webkit).
* fullscreen/full-screen-video-offset-expected.txt: Removed.
* fullscreen/full-screen-video-offset.html: Removed.
2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88468.
http://trac.webkit.org/changeset/88468
https://bugs.webkit.org/show_bug.cgi?id=62408
It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
on #webkit).
* dom/Element.cpp:
(WebCore::adjustForLocalZoom):
* dom/Element.h:
* html/HTMLMediaElement.cpp:
* html/HTMLMediaElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Thu, 9 Jun 2011 22:02:22 +0000 (22:02 +0000)]
2011-06-09 Kenneth Russell <kbr@google.com>
Reviewed by Adam Barth.
Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257
Updated WebGL implementation to track recent spec updates in this area.
Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
http/tests/security/webgl-remote-read-remote-image-allowed.html
http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html
* html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::wouldTaintOrigin):
(WebCore::CanvasRenderingContext::checkOrigin):
* html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::checkOrigin):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::videoFrameToImage):
(WebCore::WebGLRenderingContext::texSubImage2D):
* html/canvas/WebGLRenderingContext.h:
2011-06-09 Kenneth Russell <kbr@google.com>
Reviewed by Adam Barth.
Disallow use of cross-domain media (images, video) in WebGL
https://bugs.webkit.org/show_bug.cgi?id=62257
Updated origin-clean-conformance.html to track upstream version in
Khronos repository. Added new layout tests mirroring those added
in bug 61015 which verify that new CORS support for images is
working in the context of WebGL.
Verified new tests in WebKit and Chromium. Skipped tests on
platforms where WebGL is disabled.
* http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
* http/tests/canvas/webgl/origin-clean-conformance.html:
* http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Added.
* http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
* http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Added.
* http/tests/security/webgl-remote-read-remote-image-allowed.html: Added.
* http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
* http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Added.
* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 9 Jun 2011 21:55:24 +0000 (21:55 +0000)]
2011-06-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add an ASSERT to HTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=62403
This ASSERT was useful in investigating a re-entrancy bug. We should
keep it.
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndOfFile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 9 Jun 2011 21:48:35 +0000 (21:48 +0000)]
Fix a regression from r88478.
Reviewed by Darin Adler.
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Add the runs
in reverse order in the RTL case here, since the whole vector is reversed by collectComplexTextRuns()
afterwards.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jcivelli@chromium.org [Thu, 9 Jun 2011 21:45:18 +0000 (21:45 +0000)]
2011-06-09 Jay Civelli <jcivelli@chromium.org>
Reviewed by Darin Fisher.
Page serializer APIs now use WebData instead of fetching the entire
resource contents.
https://bugs.webkit.org/show_bug.cgi?id=61908
* public/WebData.h:
* public/WebPageSerializer.h:
* src/WebData.cpp:
(WebKit::WebData::getSomeData):
* src/WebPageSerializer.cpp:
(WebKit::WebPageSerializer::serialize):
(WebKit::WebPageSerializer::serializeToMHTML):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 9 Jun 2011 21:24:23 +0000 (21:24 +0000)]
2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Mark tests failing after http://trac.webkit.org/changeset/88478/ as failing.
* platform/chromium/test_expectations.txt: Added failing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 9 Jun 2011 21:18:59 +0000 (21:18 +0000)]
2011-06-09 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
nrwt: support webaudio in chromium driver
https://bugs.webkit.org/show_bug.cgi?id=62226
* Scripts/webkitpy/layout_tests/port/chromium.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 9 Jun 2011 21:11:47 +0000 (21:11 +0000)]
2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>
[Chromium] Update expectations.
* platform/chromium-linux/plugins/mouse-events-expected.txt: Added.
* platform/chromium-win/fullscreen/full-screen-video-offset-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 20:53:58 +0000 (20:53 +0000)]
2011-06-09 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by James Robinson.
Web Inspector: Inspector layout tests - extract method for sending XHR
https://bugs.webkit.org/show_bug.cgi?id=62391
* http/tests/inspector/console-xhr-logging.html:
* http/tests/inspector/network-test.js:
(doXHR.xhr.onreadystatechange):
(doXHR):
* http/tests/inspector/network/network-size-sync.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 20:33:20 +0000 (20:33 +0000)]
2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Antti Koivisto.
REGRESSION(84329): Stylesheets on some pages do not load
https://bugs.webkit.org/show_bug.cgi?id=61400
Adding test to cover the regression. The test actually uncovered
a bug in the way we handle alternate stylesheet and thus is
failing some parts.
* fast/css/link-disabled-attr-expected.txt: Added.
* fast/css/link-disabled-attr.html: Added.
2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by Antti Koivisto.
REGRESSION(84329): Stylesheets on some pages do not load
https://bugs.webkit.org/show_bug.cgi?id=61400
Test: fast/css/link-disabled-attr.html
Fixed r84329: the change did not take into account the fact
that HTMLLinkElement did already contain the disabled information
and the 2 information were not linked as they should have!
The new logic pushes the information to the stylesheet as this
is what the spec mandates and what FF is doing. Also it keeps
one bit of information (that JS enabled the stylesheet) as it
is needed for the recalcStyleSelector logic.
* dom/Document.cpp:
(WebCore::Document::recalcStyleSelector): s/isDisabled/disabled.
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement): Removed m_disabledState,
replaced by m_isEnabledViaScript.
(WebCore::HTMLLinkElement::setDisabled): Updated the logic after
m_disabledState removal. It also matches the spec by forwarding
the disabled state to our stylesheet if we have one.
(WebCore::HTMLLinkElement::parseMappedAttribute): Removed harmful
handling of the disabledAttr.
(WebCore::HTMLLinkElement::process): Updated after m_disabledState removal.
* html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::isEnabledViaScript): Ditto.
(WebCore::HTMLLinkElement::isAlternate): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 9 Jun 2011 20:30:39 +0000 (20:30 +0000)]
Simplify ComplexTextController::collectComplexTextRuns()
https://bugs.webkit.org/show_bug.cgi?id=62387
Reviewed by Darin Adler.
No new test, since functionality is unchanged.
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::collectComplexTextRuns): Always iterate characters in logical order,
then reverse the run vector for RTL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 9 Jun 2011 20:29:02 +0000 (20:29 +0000)]
Source/JavaScriptCore: Add Vector::reverse()
https://bugs.webkit.org/show_bug.cgi?id=62393
Reviewed by Anders Carlsson.
* wtf/Vector.h:
(WTF::Vector::reverse): Added
Tools: Added a test for Vector::reverse()
https://bugs.webkit.org/show_bug.cgi?id=62393
Reviewed by Anders Carlsson.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
(TestWebKitAPI::TEST):
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 9 Jun 2011 20:24:59 +0000 (20:24 +0000)]
2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
Fold isShadowBoundary into isShadowRoot.
https://bugs.webkit.org/show_bug.cgi?id=62317
Since there are no longer cases where Node::isShadowBoundary() != Node::isShadowRoot, we can remove this function.
In one case where isShadowBoundary was also tested to find ShadowContentElemnt, added a new isContentElement function.
Refactoring, covered by existing tests.
* css/CSSStyleSelector.cpp:
(WebCore::isAtShadowBoundary): Changed to use isShadowRoot.
* dom/Element.cpp:
(WebCore::Element::isSpellCheckingEnabled): Ditto.
* dom/Node.cpp:
(WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto.
(WebCore::Node::nonShadowBoundaryParentNode): Ditto.
* dom/Node.h:
(WebCore::Node::isContentElement): Added.
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext): Changed to use isShadowRoot.
* dom/Position.cpp:
(WebCore::Position::Position): Ditto.
* dom/ShadowContentElement.h:
(WebCore::ShadowContentElement::isContentElement): Added.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::hasContentElement): Changed to use isContentElement.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNodeAfter): Changed to use isShadowRoot.
* editing/htmlediting.cpp:
(WebCore::visiblePositionBeforeNode): Ditto.
(WebCore::visiblePositionAfterNode): Ditto.
* page/DragController.cpp:
(WebCore::asFileInput): Ditto.
* rendering/RenderTreeAsText.cpp:
(WebCore::nodePosition): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 9 Jun 2011 20:05:51 +0000 (20:05 +0000)]
2011-06-09 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Crashes in RenderLayerBacking::paintingGoesToWindow
https://bugs.webkit.org/show_bug.cgi?id=61159
Speculative fix for unreproducible crash that can occur when RenderObject::repaintUsingContainer()
finds a repaintContainer that is not the RenderView, but that is also not
composited (for unknown reasons), by checking to see if the layer is
compositing before using backing(). An assertion remains to try to catch
this in debug builds.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setBackingNeedsRepaintInRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Thu, 9 Jun 2011 19:52:27 +0000 (19:52 +0000)]
2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Test for WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384
* fast/css/webkit-keyframes-crash-expected.txt: Added.
* fast/css/webkit-keyframes-crash.html: Added.
2011-06-09 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
https://bugs.webkit.org/show_bug.cgi?id=62384
Test: fast/css/webkit-keyframes-crash.html
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed
to return a non-null pointer. Thus null-check here like the rest of the code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 9 Jun 2011 19:44:37 +0000 (19:44 +0000)]
2011-06-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Factored a bunch of Heap functionality into stand-alone functors
https://bugs.webkit.org/show_bug.cgi?id=62337
This is in preparation for making these functors operate on arbitrary
sets of MarkedBlocks.
* JavaScriptCore.exp: This file is a small tragedy.
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Updated for type change and rename.
* heap/HandleHeap.h:
(JSC::HandleHeap::forEachStrongHandle): New function for iterating all
strong handles, so we can play along in the functor game.
* heap/Heap.cpp:
(JSC::CountFunctor::CountFunctor::CountFunctor):
(JSC::CountFunctor::CountFunctor::count):
(JSC::CountFunctor::CountFunctor::returnValue):
(JSC::CountFunctor::ClearMarks::operator()):
(JSC::CountFunctor::ResetAllocator::operator()):
(JSC::CountFunctor::Sweep::operator()):
(JSC::CountFunctor::MarkCount::operator()):
(JSC::CountFunctor::Size::operator()):
(JSC::CountFunctor::Capacity::operator()):
(JSC::CountFunctor::Count::operator()):
(JSC::CountFunctor::CountIfGlobalObject::operator()):
(JSC::CountFunctor::TakeIfEmpty::TakeIfEmpty):
(JSC::CountFunctor::TakeIfEmpty::operator()):
(JSC::CountFunctor::TakeIfEmpty::returnValue):
(JSC::CountFunctor::RecordType::RecordType):
(JSC::CountFunctor::RecordType::typeName):
(JSC::CountFunctor::RecordType::operator()):
(JSC::CountFunctor::RecordType::returnValue): These functors factor out
behavior that used to be in the functions below.
(JSC::Heap::clearMarks):
(JSC::Heap::sweep):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::protectedObjectCount):
(JSC::Heap::protectedObjectTypeCounts):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::resetAllocator):
(JSC::Heap::freeBlocks):
(JSC::Heap::shrink): Factored out behavior into the functors above.
* heap/Heap.h:
(JSC::Heap::forEachProtectedCell):
(JSC::Heap::forEachCell):
(JSC::Heap::forEachBlock): Added forEach* iteration templates. I chose
functor-based templates instead of plain iterators because they're simpler
to implement in this case and they require a lot less code at the call site.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::VoidFunctor::returnValue): Default parent class for
trivial functors.
(JSC::MarkedBlock::forEachCell): Renamed forEach to forEachCell because
we have a few different kind of "for each" now.
* runtime/JSGlobalData.cpp:
(WTF::Recompile::operator()):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::recompileAllJSFunctions): Updated for type change and rename.
* runtime/JSGlobalData.h: Removed globalObjectCount because it was unused.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 19:41:10 +0000 (19:41 +0000)]
2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by David Hyatt.
Test for chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
https://bugs.webkit.org/show_bug.cgi?id=57756
* fast/css/fontMetric-border-radius-null-crash-expected.txt: Added.
* fast/css/fontMetric-border-radius-null-crash.html: Added.
* fast/css/fontMetric-webkit-border-end-width-null-crash-expected.txt: Added.
* fast/css/fontMetric-webkit-border-end-width-null-crash.html: Added.
2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
Reviewed by David Hyatt.
chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
https://bugs.webkit.org/show_bug.cgi?id=57756
Tests: fast/css/fontMetric-border-radius-null-crash.html
fast/css/fontMetric-webkit-border-end-width-null-crash.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForElement): Added a call to Font::update
so that our FontFallbackList is allocated if we ever need it when applying our
style rules.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 9 Jun 2011 19:30:55 +0000 (19:30 +0000)]
2011-06-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Andreas Kling.
[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385
Remove a cr-linux expectation that no longer differs from the default
expectation.
* platform/chromium-linux/plugins/mouse-events-expected.txt: Removed.
2011-06-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Andreas Kling.
[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385
Remove duplicate TestNetscapePlugIn implementation. Having two copies
of this code makes keeping it in sync much more difficult. The files are
almost identical and this change ports the X11 changes to main.cpp.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(keyEventToChar): Added this helper which converts a X11 keycode into a char.
(handleEventX11): Use the handler to properly convert the keycode. Do not print
adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
it should not be in the results.
(NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
* GNUmakefile.am: Update source list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 9 Jun 2011 19:02:48 +0000 (19:02 +0000)]
2011-06-09 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
WebKit2: Remove unused function CoreIPC::Connection::deprecatedWaitFor().
https://bugs.webkit.org/show_bug.cgi?id=62386
* Platform/CoreIPC/Connection.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 18:51:46 +0000 (18:51 +0000)]
2011-06-09 Cary Clark <caryclark@google.com>
Reviewed by Eric Seidel.
Create local CG context for Mac UI elements when Skia is renderer
https://bugs.webkit.org/show_bug.cgi?id=62213
When building Mac Chrome using Skia as the WebKit renderer,
add state to LocalCurrentGraphicsContext to convert the SkCanvas
context passed by WebKit into the CGContext needed by UI
rendering.
No new tests. The define typo in question is
not yet enabled, so this change has no functional
impact.
* platform/mac/LocalCurrentGraphicsContext.h:
Add SkiaBitLocker to create and release the converted CGContext.
Add ContextContainer, a class for Skia to create and release
the converted CGContext. If Skia is not used, the class has no effect.
* platform/mac/LocalCurrentGraphicsContext.mm:
(WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
When building with Skia, create the CGContext before passing it on.
(WebCore::LocalCurrentGraphicsContext::cgContext):
Get the CGContext from the SkiaBitLocker, or the saved context,
as appropriate.
* rendering/RenderThemeMac.mm:
Get the CGContext from Skia conversion or native, as appropriate.
Use the LocalCurrentGraphicsContext if there is one. Otherwise,
add a ContextContainer to house the SkCanvas to CGContext conversion.
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):
(WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Thu, 9 Jun 2011 18:47:27 +0000 (18:47 +0000)]
2011-06-02 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61911
<rdar://problem/
9523017>
* fullscreen/full-screen-video-offset-expected.txt: Added.
* fullscreen/full-screen-video-offset.html: Added.
2011-06-02 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61911
<rdar://problem/
9523017>
Test: fullscreen/full-screen-video-offset.html
When the video element is taken full-screen in the new element full-screen API, return the
offset width and height of the placeholder renderer which is filling in for the full-screen
element. To do so, override offsetWidth, Height, Left, and Top from Element. These are
non-virtual functions, so make them virtual.
* dom/Element.cpp:
(WebCore::Element::adjustForLocalZoom): Made into a class-static function.
* dom/Element.h: Made offset functions virtual.
* html/HTMLMediaElement.cpp:
(WebCore::elementPlaceholder): Added; utility function.
(WebCore::HTMLMediaElement::offsetLeft): Added; virtual override of the
Element function. Will be called directly via javascript.
(WebCore::HTMLMediaElement::offsetTop): Ditto.
(WebCore::HTMLMediaElement::offsetWidth): Ditto.
(WebCore::HTMLMediaElement::offsetHeight): Ditto.
* html/HTMLMediaElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Thu, 9 Jun 2011 18:26:15 +0000 (18:26 +0000)]
2011-06-09 Chang Shu <cshu@webkit.org>
Unreviewed.
Unskip more passed tests after r88461 (bug 62381).
* platform/qt-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 18:21:48 +0000 (18:21 +0000)]
2011-06-09 Bill Budge <bbudge@chromium.org>
Reviewed by Adam Barth.
The AssociatedURLLoader returns URL access errors synchronously. Use a timer to return such errors asynchronously. Also add unit tests for successful loads, same-origin restriction by default, and successful cross-origin loads.
https://bugs.webkit.org/show_bug.cgi?id=60059
* WebKit.gyp:
* WebKit.gypi:
* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::ClientAdapter::clearClient):
(WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
(WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading):
(WebKit::AssociatedURLLoader::ClientAdapter::didFail):
(WebKit::AssociatedURLLoader::ClientAdapter::enableErrorNotifications):
(WebKit::AssociatedURLLoader::ClientAdapter::notifyError):
(WebKit::AssociatedURLLoader::loadAsynchronously):
* tests/AssociatedURLLoaderTest.cpp: Added.
(WebKit::TestWebFrameClient::cancelledError):
(WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest):
(WebKit::AssociatedURLLoaderTest::SetUp):
(WebKit::AssociatedURLLoaderTest::TearDown):
(WebKit::AssociatedURLLoaderTest::serveRequests):
(WebKit::AssociatedURLLoaderTest::createAssociatedURLLoader):
(WebKit::AssociatedURLLoaderTest::willSendRequest):
(WebKit::AssociatedURLLoaderTest::didSendData):
(WebKit::AssociatedURLLoaderTest::didReceiveResponse):
(WebKit::AssociatedURLLoaderTest::didDownloadData):
(WebKit::AssociatedURLLoaderTest::didReceiveData):
(WebKit::AssociatedURLLoaderTest::didReceiveCachedMetadata):
(WebKit::AssociatedURLLoaderTest::didFinishLoading):
(WebKit::AssociatedURLLoaderTest::didFail):
(WebKit::TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 18:21:23 +0000 (18:21 +0000)]
2011-06-09 Noel Gordon <noel.gordon@gmail.com>
Reviewed by Tony Chang.
Test plugin should support event logging on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=61721
The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
calls to mean the plugin handled the event.
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventWin): Return 0 for each event on windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 18:19:38 +0000 (18:19 +0000)]
2011-06-09 Mark Pilgrim <pilgrim@chromium.org>
Reviewed by Tony Chang.
IndexedDB test: behavior of undefined value in record
https://bugs.webkit.org/show_bug.cgi?id=62371
* storage/indexeddb/value-undefined-expected.txt: Added.
* storage/indexeddb/value-undefined.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 9 Jun 2011 18:16:39 +0000 (18:16 +0000)]
2011-06-09 Andreas Kling <kling@webkit.org>
Reviewed by Anders Carlsson.
[Qt][WK2] Remove usage of deprecated CoreIPC functions.
https://bugs.webkit.org/show_bug.cgi?id=62290
Use the new DrawingArea{,Proxy}.messages.in approach to CoreIPC in TiledDrawingArea.
The TiledDrawingArea{,Proxy}-specific messages were moved up into DrawingArea{,Proxy}
and guarded by ENABLE(TILED_BACKING_STORE).
* Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: Removed.
* Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: Removed.
* GNUmakefile.am:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj: Prune deleted files from build system.
* Platform/CoreIPC/MessageID.h: Remove legacy DrawingArea message ID's.
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKViewPrivate::commitScale): No longer waits for all tile updates to complete,
this will be addressed by the soon-to-be-upstreamed TileSet mechanism.
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::didSetSize):
(WebKit::DrawingAreaProxy::invalidate):
(WebKit::DrawingAreaProxy::snapshotTaken):
(WebKit::DrawingAreaProxy::tileUpdated):
(WebKit::DrawingAreaProxy::allTileUpdatesProcessed): Added IPC calls used by
TiledDrawingAreaProxy to DrawingAreaProxy.
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setSize):
(WebKit::DrawingArea::cancelTileUpdate):
(WebKit::DrawingArea::requestTileUpdate):
(WebKit::DrawingArea::takeSnapshot): Added IPC calls used by TiledDrawingArea
to DrawingArea.
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/DrawingAreaProxyImpl.cpp: Remove the now-unneeded didReceiveMessage()
and didReceiveSyncMessage().
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/DrawingAreaImpl.h: Remove the now-unneeded didReceiveMessage().
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::tileUpdated):
(WebKit::TiledDrawingAreaProxy::allTileUpdatesProcessed): Split didReceiveMessage()
into functions.
(WebKit::TiledDrawingAreaProxy::removeTile):
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::takeSnapshot): Use new-style IPC.
* WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::setSize):
(WebKit::TiledDrawingArea::cancelTileUpdate):
(WebKit::TiledDrawingArea::requestTileUpdate):
(WebKit::TiledDrawingArea::takeSnapshot): Split didReceiveMessage() into functions.
(WebKit::TiledDrawingArea::display):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::tileUpdateTimerFired): Use new-style IPC.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage): Remove handling of
CoreIPC::MessageClassDrawingAreaProxyLegacy.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage): Remove handling of
CoreIPC::MessageClassDrawingAreaLegacy.
* UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Remove unneeded includes.
* WebProcess/WebPage/TiledDrawingArea.h: Remove didReceiveMessage() and make
CoreIPC message handlers explicitly virtual.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 9 Jun 2011 18:14:21 +0000 (18:14 +0000)]
2011-06-09 Andreas Kling <kling@webkit.org>
Reviewed by Anders Carlsson.
WebKit2: Generate correct header conditionals in message receivers.
https://bugs.webkit.org/show_bug.cgi?id=62379
Given a *.messages.in file like this:
Foo(AwesomeObject o)
#if ENABLE(ESOTERIC_FEATURE)
Bar(AwesomeObject o)
#endif
messages.py would include AwesomeObject.h only #if ENABLE(ESOTERIC_FEATURE).
This breaks the build on platforms without that defined.
Furthermore, if two messages guarded by different conditionals both pull in the same
header, only the last conditional will be applied, for example:
#if ENABLE(ESOTERIC_FEATURE)
Foo(AwesomeObject o)
#endif
#if ENABLE(MYSTERIOUS_FEATURE)
Bar(AwesomeObject o)
#endif
Would include AwesomeObject.h #if ENABLE(MYSTERIOUS_FEATURE) when it really should
check #if ENABLE(ESOTERIC_FEATURE) || ENABLE(MYSTERIOUS_FEATURE).
Change the generator to consider all conditionals for a given header file.
Also consider conditionals for reply parameters.
* Scripts/webkit2/messages.py:
* Scripts/webkit2/messages_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 18:09:30 +0000 (18:09 +0000)]
2011-06-09 Chang Shu <cshu@webkit.org>
Reviewed by Andreas Kling.
[Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
https://bugs.webkit.org/show_bug.cgi?id=62381
Unskip passed tests.
* platform/qt-wk2/Skipped:
2011-06-09 Chang Shu <cshu@webkit.org>
Reviewed by Andreas Kling.
[Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
https://bugs.webkit.org/show_bug.cgi?id=62381
Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
QWKPagePrivate::isViewFocused() will check it later.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 17:49:35 +0000 (17:49 +0000)]
2011-06-09 Dave Tapuska <dtapuska@rim.com>
Reviewed by Daniel Bates.
PingLoader destructor could dereference 0 if the Resource
Handle creation failed.
https://bugs.webkit.org/show_bug.cgi?id=62304
* loader/PingLoader.cpp:
(WebCore::PingLoader::~PingLoader):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Thu, 9 Jun 2011 16:20:46 +0000 (16:20 +0000)]
2011-06-09 Nico Weber <thakis@chromium.org>
Reviewed by Darin Fisher.
[chromium] Make a few destructors private.
https://bugs.webkit.org/show_bug.cgi?id=62341
No intended functionality change.
* src/NotificationPresenterImpl.cpp:
(WebKit::VoidCallbackClient::~VoidCallbackClient):
* src/WebTextCheckingCompletionImpl.h:
(WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
* src/WebURLRequest.cpp:
(WebKit::WebURLRequestPrivateImpl::~WebURLRequestPrivateImpl):
* src/WebURLResponse.cpp:
(WebKit::WebURLResponsePrivateImpl::~WebURLResponsePrivateImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 9 Jun 2011 16:15:29 +0000 (16:15 +0000)]
2011-06-08 Abhishek Arya <inferno@chromium.org>
Reviewed by Ryosuke Niwa.
Make indexForVisiblePosition and isSelectableElement static.
https://bugs.webkit.org/show_bug.cgi?id=62329
This protects us when converting frame->selection->start() or end()
to VisiblePosition which blows away the RenderTextControl from
underneath (due to layout update).
Test: fast/forms/text-control-selection-crash.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::indexForVisiblePosition):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::selectionStart):
(WebCore::RenderTextControl::selectionEnd):
(WebCore::RenderTextControl::isSelectableElement):
(WebCore::RenderTextControl::indexForVisiblePosition):
* rendering/RenderTextControl.h:
2011-06-08 Abhishek Arya <inferno@chromium.org>
Reviewed by Ryosuke Niwa.
Tests that setting selection on a text control does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=62329
* fast/forms/text-control-selection-crash-expected.txt: Added.
* fast/forms/text-control-selection-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 9 Jun 2011 16:05:08 +0000 (16:05 +0000)]
2011-06-09 Andras Becsi <abecsi@webkit.org>
Reviewed by Andreas Kling.
[Qt] Fix the in-tree build on Linux
https://bugs.webkit.org/show_bug.cgi?id=62378
In case of an in-tree build qmake generates defect prl dependencies for
the QtWebKit library, because the inclusion of qtbase.pri adds explicitlib to CONFIG.
* QtWebKit.pro: Remove explicitlib and staticlib from CONFIG.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benm@google.com [Thu, 9 Jun 2011 15:52:13 +0000 (15:52 +0000)]
2011-06-09 Ben Murdoch <benm@google.com>
Reviewed by Yury Semikhatsky.
Build break in ScriptProfile.cpp and inspector disabled.
https://bugs.webkit.org/show_bug.cgi?id=62373
No new tests - build fix only.
* bindings/v8/ScriptProfile.cpp: Add necessary guards.
* bindings/v8/ScriptProfile.h: ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 15:19:09 +0000 (15:19 +0000)]
2011-06-09 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Network panel preview tab does not reattach SourceFrame when switching between preview and response tabs.
https://bugs.webkit.org/show_bug.cgi?id=62298
* inspector/front-end/ResourcePreviewView.js:
(WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback):
(WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 9 Jun 2011 14:53:39 +0000 (14:53 +0000)]
[Qt] Unreviewed fix after r88447.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 9 Jun 2011 14:44:20 +0000 (14:44 +0000)]
[Qt][Mac] Speculative buildfix after r88286.
* platform/graphics/IntPoint.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 9 Jun 2011 14:28:54 +0000 (14:28 +0000)]
[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881
https://bugs.webkit.org/show_bug.cgi?id=62278
* platform/qt/Skipped: Add inspector/profiler/detailed-heapshots-comparison-show-next.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 9 Jun 2011 14:24:03 +0000 (14:24 +0000)]
[WK2] eventSender.keyDown is unimplemented
* platform/mac-wk2/Skipped: Add fast/dom/shadow/tab-order-iframe-and-shadow.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mikelawther@chromium.org [Thu, 9 Jun 2011 14:12:56 +0000 (14:12 +0000)]
2011-06-09 Mike Lawther <mikelawther@chromium.org>
Reviewed by Kent Tamura.
Parsing issue with -webkit-calc
https://bugs.webkit.org/show_bug.cgi?id=62276
Set the CSSParserString for the calc functions.
* css3/calc/regression-62276-expected.txt: Added.
* css3/calc/regression-62276.html: Added.
2011-06-09 Mike Lawther <mikelawther@chromium.org>
Reviewed by Kent Tamura.
Parsing issue with -webkit-calc
https://bugs.webkit.org/show_bug.cgi?id=62276
Set the CSSParserString for the calc functions.
Test: css3/calc/regression-62276.html
* css/CSSParser.cpp:
(WebCore::CSSParser::lex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 9 Jun 2011 14:11:35 +0000 (14:11 +0000)]
REGRESSION(r88393): Tests fail on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=62374
* platform/qt/Skipped: Add editing/selection/move-by-word-visually-others.html and
editing/selection/move-by-word-visually-single-space-sigle-line.html until fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dominicc@chromium.org [Thu, 9 Jun 2011 14:06:51 +0000 (14:06 +0000)]
2011-06-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074
Unskip fast/harness/internals-object.html
* platform/qt/Skipped:
2011-06-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074
A weakness of the Qt DRT setup is that things like JSContextRef are abstracted
away from the QtWebKit API so we need DumpRenderTreeSupportQt to access WebCore internals.
Since the window.internals object requires JSContextRef we need to implement it in DumpRenderTreeSupportQt
where we can access it. DumpRenderTreeSupportQt cannot be compiled outside Qt's WebCore and as it
is our only possible route into the WebCoreTestSupport class neither can the new window.internals plumbing.
Likewise we can't put the accessor in WebCoreTestSupport because it would then need to know about QWebFrame
and others. The only alternative seems like a compile time guard which we would have to teach the bots about.
* CodeGenerators.pri:
* WebCore.pri:
* WebCore.pro:
2011-06-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::injectInternalsObject):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-06-09 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
Teach Qt about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61074
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::initJSObjects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 9 Jun 2011 13:54:56 +0000 (13:54 +0000)]
[Qt][WK2] Canvas tests make css2.1 ones failing
https://bugs.webkit.org/show_bug.cgi?id=53427
* platform/qt-wk2/Skipped: Unskip passing tests after r88435.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 9 Jun 2011 12:42:40 +0000 (12:42 +0000)]
2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>
Reviewed by Pavel Feldman.
Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
https://bugs.webkit.org/show_bug.cgi?id=52791
No new tests. The problem can be reproduced by trying to create InspectorValue
from 1.0e-100 and call ->toJSONString() on this.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
export 2 functions DecimalNumber::bufferLengthForStringExponential and
DecimalNumber::toStringExponential.
2011-06-08 Mikołaj Małecki <m.malecki@samsung.com>
Reviewed by Pavel Feldman.
Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
https://bugs.webkit.org/show_bug.cgi?id=52791
No new tests. The problem can be reproduced by trying to create InspectorValue
from 1.0e-100 and call ->toJSONString() on this.
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
export 2 functions DecimalNumber::bufferLengthForStringExponential and
DecimalNumber::toStringExponential.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 12:09:14 +0000 (12:09 +0000)]
2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88387.
http://trac.webkit.org/changeset/88387
https://bugs.webkit.org/show_bug.cgi?id=62368
New tests introduced in 88387 fail on Leopard,GTK,Qt bots
(Requested by Ossy on #webkit).
* http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
* http/tests/canvas/webgl/origin-clean-conformance.html:
* http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Removed.
* http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Removed.
* http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Removed.
* http/tests/security/webgl-remote-read-remote-image-allowed.html: Removed.
* http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Removed.
* http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Removed.
* platform/mac-wk2/Skipped:
2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r88387.
http://trac.webkit.org/changeset/88387
https://bugs.webkit.org/show_bug.cgi?id=62368
New tests introduced in 88387 fail on Leopard,GTK,Qt bots
(Requested by Ossy on #webkit).
* html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::checkOrigin):
* html/canvas/CanvasRenderingContext.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::videoFrameToImage):
(WebCore::WebGLRenderingContext::texSubImage2D):
* html/canvas/WebGLRenderingContext.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 9 Jun 2011 11:56:59 +0000 (11:56 +0000)]
[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881
https://bugs.webkit.org/show_bug.cgi?id=62278
* platform/qt/Skipped: Skip 3 inspector tests to make buildbot happy.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 9 Jun 2011 11:10:21 +0000 (11:10 +0000)]
2011-06-09 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: New flakiness in styles tests
https://bugs.webkit.org/show_bug.cgi?id=62309
* inspector/styles/styles-disable-then-change.html:
* inspector/styles/styles-source-lines-inline.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 10:26:49 +0000 (10:26 +0000)]
2011-06-09 Eunmi Lee <eunmi15.lee@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL][WK2] Add PageClientImpl and WebPageProxyEfl for efl port
https://bugs.webkit.org/show_bug.cgi?id=62363
* UIProcess/API/efl/PageClientImpl.cpp: Added.
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::~PageClientImpl):
(WebKit::PageClientImpl::createDrawingAreaProxy):
(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::displayView):
(WebKit::PageClientImpl::scrollView):
(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewInWindow):
(WebKit::PageClientImpl::processDidCrash):
(WebKit::PageClientImpl::didRelaunchProcess):
(WebKit::PageClientImpl::pageClosed):
(WebKit::PageClientImpl::toolTipChanged):
(WebKit::PageClientImpl::setCursor):
(WebKit::PageClientImpl::setViewportArguments):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):
(WebKit::PageClientImpl::convertToDeviceSpace):
(WebKit::PageClientImpl::convertToUserSpace):
(WebKit::PageClientImpl::windowToScreen):
(WebKit::PageClientImpl::doneWithKeyEvent):
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::createContextMenuProxy):
(WebKit::PageClientImpl::setFindIndicator):
(WebKit::PageClientImpl::didChangeScrollbarsForMainFrame):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
(WebKit::PageClientImpl::customRepresentationZoomFactor):
(WebKit::PageClientImpl::setCustomRepresentationZoomFactor):
(WebKit::PageClientImpl::flashBackingStoreUpdates):
(WebKit::PageClientImpl::findStringInCustomRepresentation):
(WebKit::PageClientImpl::countStringMatchesInCustomRepresentation):
(WebKit::PageClientImpl::userSpaceScaleFactor):
* UIProcess/API/efl/PageClientImpl.h: Added.
(WebKit::PageClientImpl::create):
(WebKit::PageClientImpl::viewObject):
(WebKit::PageClientImpl::page):
* UIProcess/WebPageProxy.h:
* UIProcess/efl/WebPageProxyEfl.cpp: Added.
(WebKit::WebPageProxy::viewObject):
(WebKit::WebPageProxy::standardUserAgent):
(WebKit::WebPageProxy::getEditorCommandsForKeyEvent):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 9 Jun 2011 10:06:17 +0000 (10:06 +0000)]
2011-06-09 Kent Tamura <tkent@chromium.org>
[Chromium] Leopard rebaseline for thumbslider-no-parent-slider.html.
* platform/chromium-mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 9 Jun 2011 09:39:13 +0000 (09:39 +0000)]
2011-06-09 Ryosuke Niwa <rniwa@webkit.org>
More Chromium Mac test expectation updates.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 9 Jun 2011 09:36:48 +0000 (09:36 +0000)]
2011-06-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
https://bugs.webkit.org/show_bug.cgi?id=62362
The mac bots are failing inspector tests. We don't know why yet.
So for now, turning run-webkit-tests off for the mac-ews.
Also noticed that due to the wrong variable name the cr-linux
bots weren't running tests!
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 9 Jun 2011 09:21:33 +0000 (09:21 +0000)]
2011-06-09 Ryosuke Niwa <rniwa@webkit.org>
Chromium Mac test expectation updates.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Thu, 9 Jun 2011 08:47:45 +0000 (08:47 +0000)]
[Qt][WK2] Canvas tests make css2.1 ones failing
https://bugs.webkit.org/show_bug.cgi?id=53427
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2011-06-09
Reviewed by Csaba Osztrogonac.
Tools:
Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
Since the Qt port should eventually go to QRawFont, this issue will be resolved
in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
needed for the workaround.
* WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
(WTR::LayoutTestController::platformInitialize):
LayoutTests:
Unskipping canvas tests for WebKit2-Qt.
* platform/qt-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88435
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 9 Jun 2011 08:41:56 +0000 (08:41 +0000)]
2011-06-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Running script from attach can remove elements from the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=62160
* fast/parser/document-write-onload-clear-expected.txt: Added.
* fast/parser/document-write-onload-clear.html: Added.
2011-06-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Running script from attach can remove elements from the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=62160
When the tree build runs script synchronously, that script can remove
arbitrary elements from the stack of open elements. We need to hold a
reference to |parent| in attach instead of rely upon the reference in
the stack of open elements.
Test: fast/parser/document-write-onload-clear.html
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attach):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 9 Jun 2011 07:42:53 +0000 (07:42 +0000)]
2011-06-09 James Robinson <jamesr@chromium.org>
Fix chromium build on build.webkit.org builders.
* features.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Thu, 9 Jun 2011 07:35:28 +0000 (07:35 +0000)]
2011-06-09 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Provide a way in DRT to check the platform name
https://bugs.webkit.org/show_bug.cgi?id=56855
New layout test and expected results to check the new function.
* accessibility/platform-name.html: Added.
* platform/gtk/accessibility/platform-name-expected.txt: Added.
* platform/mac/accessibility/platform-name-expected.txt: Added.
* platform/win/accessibility/platform-name-expected.txt: Added.
2011-06-09 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Provide a way in DRT to check the platform name
https://bugs.webkit.org/show_bug.cgi?id=56855
Patch for adding 'platformName' static property to DRT's
LayoutController and provide platform specific implementations.
In principle, this feature will be only of interest for writing
accessibility tests, so that's why it's only implemented in the
Mac, Gtk and Win platforms.
* DumpRenderTree/LayoutTestController.h: New method platformName().
* DumpRenderTree/LayoutTestController.cpp:
(getPlatformNameCallback): New callback for 'platformName'.
(LayoutTestController::staticValues): New static property.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::platformName): Implemented.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::platformName): Implemented.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::platformName): Implemented.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Thu, 9 Jun 2011 06:55:33 +0000 (06:55 +0000)]
2011-06-08 Luke Macpherson <macpherson@chromium.org>
Reviewed by Eric Seidel.
Make CSSPrimitiveValue support cast to EVerticalAlign.
https://bugs.webkit.org/show_bug.cgi?id=62356
No new tests / refactoring only.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EVerticalAlign):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88431
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 06:40:44 +0000 (06:40 +0000)]
2011-06-08 Justin Novosad <junov@chromium.org>
Reviewed by James Robinson.
[Chromium] Crash when closing a tab with accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=62324
Upon graphics context destruction, it is important to signal skia
to abandon all of its resource handles. This prevents a crash caused
by skia attempting to release resources that were in the destroyed
graphics context.
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
2011-06-08 Justin Novosad <junov@chromium.org>
Reviewed by James Robinson.
[Chromium] Crash when closing a tab with accelerated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=62324
In GraphicsContext3DInternal::setContextLostCallback we are passing a
non-refcounted ptr to a refcounted member. this can cause an access
violation after the destruction of GraphicsContext3D. Upon destruction
a null callback is sent to setContextLostCallback, which is good
except that it gets placed in a non-null adapter object. This fix
prevents the creation of the adapter when the callback is null, thus
preventing a later crash.
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContextLostCallbackAdapter::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88429
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 06:38:08 +0000 (06:38 +0000)]
2011-06-08 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
REGRESSION(88260): 10-50% performance regression across many page cyclers
https://bugs.webkit.org/show_bug.cgi?id=62349
r88260 fixed a font cache resource leak and lowered the inactive font cache threshold. The latter caused a
significant performance regression across many chromium page cyclers, for example
http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/moz/report.html?history=50&rev=88279.
This restores the previous inactive font size thresholds to their previous values, but retains the font cleanup
logic.
* platform/graphics/FontCache.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88428
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 9 Jun 2011 06:37:25 +0000 (06:37 +0000)]
2011-06-08 James Robinson <jamesr@chromium.org>
Hopefully last change to features.gypi - set ENABLE_REGISTER_PROTOCOL_HANDLER based off of the the variable set
in chromium's common.gypi. Should green up the chromium linux tester on build.webkit.org.
* features.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88427
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mikelawther@chromium.org [Thu, 9 Jun 2011 06:07:55 +0000 (06:07 +0000)]
2011-06-08 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
Add mikelawther to committers.py
https://bugs.webkit.org/show_bug.cgi?id=62354
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 9 Jun 2011 05:48:59 +0000 (05:48 +0000)]
2011-06-08 James Robinson <jamesr@chromium.org>
Set ENABLE_REGISTER_PROTOCOL_HANDLER=1 for chromium. I didn't mean to turn that off...
* features.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 9 Jun 2011 05:43:47 +0000 (05:43 +0000)]
2011-06-08 James Robinson <jamesr@chromium.org>
[chromium] Update the chromium-within-WebKit revision to r88481
https://bugs.webkit.org/show_bug.cgi?id=62353
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 9 Jun 2011 05:37:12 +0000 (05:37 +0000)]
[Chromium] Rebaseline for r87881 and r88415.
* platform/chromium-linux/fast/forms/thumbslider-no-parent-slider-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png:
* platform/chromium-mac-leopard/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
* platform/chromium-mac-leopard/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Added.
* platform/chromium-mac/fast/forms/thumbslider-no-parent-slider-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png.
* platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.png:
* platform/chromium-win/fast/forms/thumbslider-no-parent-slider-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 9 Jun 2011 05:35:21 +0000 (05:35 +0000)]
2011-06-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Add stubs to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=62263
This change add stub implementations for all WebWidget functions. Having stub methods should make it easier to add new functions to the class without breaking Chromium.
* public/WebWidget.h:
(WebKit::WebWidget::close):
(WebKit::WebWidget::size):
(WebKit::WebWidget::resize):
(WebKit::WebWidget::animate):
(WebKit::WebWidget::layout):
(WebKit::WebWidget::paint):
(WebKit::WebWidget::composite):
(WebKit::WebWidget::themeChanged):
(WebKit::WebWidget::handleInputEvent):
(WebKit::WebWidget::mouseCaptureLost):
(WebKit::WebWidget::setFocus):
(WebKit::WebWidget::setComposition):
(WebKit::WebWidget::confirmComposition):
(WebKit::WebWidget::compositionRange):
(WebKit::WebWidget::textInputType):
(WebKit::WebWidget::caretOrSelectionBounds):
(WebKit::WebWidget::selectionRange):
(WebKit::WebWidget::caretOrSelectionRange):
(WebKit::WebWidget::setTextDirection):
(WebKit::WebWidget::isAcceleratedCompositingActive):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Thu, 9 Jun 2011 05:33:12 +0000 (05:33 +0000)]
2011-06-08 Hayato Ito <hayato@chromium.org>
Reviewed by Dimitri Glazkov.
A forward/backward tab traversal now visits focusable elements in a shadow root.
https://bugs.webkit.org/show_bug.cgi?id=61410
Like a iframe element, a shadow host becomes a scope of
tabindex. That means all descendant elements in a shadow root are
skipped if the host node of the shadow root is not focusable.
The patch doesn't affect HTMLInputElement and HTMLTextAreaElement,
which uses a shadow root and do extra works in their focus()
method.
A shadow root's <content> is not considered in this patch.
That will be addressed in a following patch.
* fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt: Added.
* fast/dom/shadow/tab-order-iframe-and-shadow.html: Added.
2011-06-08 Hayato Ito <hayato@chromium.org>
Reviewed by Dimitri Glazkov.
A forward/backward tab traversal now visits focusable elements in a shadow root.
https://bugs.webkit.org/show_bug.cgi?id=61410
Test: fast/dom/shadow/tab-order-iframe-and-shadow.html
Like a iframe element, a shadow host becomes a scope of
tabindex. That means all descendant elements in a shadow root are
skipped if the host node of the shadow root is not focusable.
The patch doesn't affect HTMLInputElement and HTMLTextAreaElement,
which uses a shadow root and do extra works in their focus()
method.
A shadow root's <content> is not considered in this patch.
That will be addressed in a following patch.
* page/FocusController.cpp:
(WebCore::shadowRoot):
(WebCore::isTreeScopeOwner):
(WebCore::FocusController::deepFocusableNode):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableNodeAcrossTreeScope):
(WebCore::FocusController::findFocusableNode):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):
(WebCore::FocusController::ownerOfTreeScope):
* page/FocusController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 9 Jun 2011 04:56:37 +0000 (04:56 +0000)]
2011-06-08 Kent Tamura <tkent@chromium.org>
[Chromium] Fix a typo.
* DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
(WebThemeControlDRTWin::draw):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 9 Jun 2011 04:47:27 +0000 (04:47 +0000)]
2011-06-08 Kent Tamura <tkent@chromium.org>
Reviewed by Hajime Morita.
[Chromium] Support vertical sliders in Windows DRT
https://bugs.webkit.org/show_bug.cgi?id=62352
* DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
(WebThemeControlDRTWin::draw):
Paint VerticalSliderThumbType and VerticalSliderTrackType.
* DumpRenderTree/chromium/WebThemeControlDRTWin.h:
Add VerticalSliderTrackType and VerticalSliderThumbType.
* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
(WebThemeEngineDRTWin::paintTrackbar):
Convert Windows identifiers to the internal identifiers for vertical sliders.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Thu, 9 Jun 2011 03:55:17 +0000 (03:55 +0000)]
2011-06-08 Hayato Ito <hayato@chromium.org>
Reviewed by Hajime Morita.
Makes sure that document.activeElement won't be an element in shadow root.
https://bugs.webkit.org/show_bug.cgi?id=61413
* fast/dom/shadow/activeelement-should-be-shadowhost-expected.txt: Added.
* fast/dom/shadow/activeelement-should-be-shadowhost.html: Added.
2011-06-08 Hayato Ito <hayato@chromium.org>
Reviewed by Hajime Morita.
Makes sure that document.activeElement won't be an element in shadow root.
https://bugs.webkit.org/show_bug.cgi?id=61413
Test: fast/dom/shadow/activeelement-should-be-shadowhost.html
* html/HTMLDocument.cpp:
(WebCore::focusedFrameOwnerElement):
(WebCore::HTMLDocument::activeElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 9 Jun 2011 03:42:40 +0000 (03:42 +0000)]
2011-06-08 Kent Tamura <tkent@chromium.org>
[Mac][GTK][Qt] Rebaseline for r88415, and remove old images.
* platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
* platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
* platform/mac-leopard/fast/forms/thumbslider-no-parent-slider-expected.png: Removed.
* platform/qt/fast/forms/thumbslider-no-parent-slider-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
koz@chromium.org [Thu, 9 Jun 2011 02:09:52 +0000 (02:09 +0000)]
2011-06-08 James Kozianski <koz@chromium.org>
[Chromium] Unreviewed. Add TIMEOUT to styles-disable-then-change.html.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 9 Jun 2011 02:06:38 +0000 (02:06 +0000)]
Allow drawing a slider thumb for any nodes.
https://bugs.webkit.org/show_bug.cgi?id=62196
Reviewed by Dimitri Glazkov.
Source/WebCore:
RenderObject::node() should provide various information which is
necessary for rendering. We don't need to refer the parent renderer.
* dom/Node.cpp:
(WebCore::Node::focusDe1egate): Added.
* dom/Node.h: Added a declaration.
* html/shadow/MediaControlElements.cpp:
(WebCore::toParentMediaElement):
Added an overload of toParentMediaElement() with Node* parameter.
* html/shadow/MediaControlElements.h:
(WebCore::toParentMediaElement): ditto.
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::isEnabledFormControl):
Returns the status of the host node.
(WebCore::SliderThumbElement::isReadOnlyFormControl): ditto.
(WebCore::SliderThumbElement::focusDe1egate):
Returns the host node so that RenderTheme::isFocused() returns true.
(WebCore::SliderThumbElement::detach): Style nit.
(WebCore::SliderThumbElement::hostInput):
Make it const because it is called by const functions.
* html/shadow/SliderThumbElement.h:
- Remove inDragMode()
- Update declarations
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintMediaSliderThumb):
Use Node::shadowAncestorNode() instead of RenderObject::parent() to
support deeper thumb nodes.
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaSliderThumb): ditto.
(WebCore::paintMediaVolumeSliderThumb): Remove isSlider() check.
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::inDragMode):
SliderThumbElement::inDragMode() was removed, and Node::active() has
the same information.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint): Remove isSlider() checks.
(WebCore::RenderTheme::isFocused): Apply Node::focusDelegate().
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
isPressed() is enough.
* rendering/RenderThemeChromiumWin.cpp:
isEnabled(), isFocused(), and isPressed() are enough.
(WebCore::RenderThemeChromiumWin::determineSliderThumbState):
(WebCore::RenderThemeChromiumWin::determineClassicState):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSliderThumb):
- Remove isSlider() check.
- Passing 'o' to udpateFooState functions is enough.
- isPressed() is enough.
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintSliderThumb):
We don't need special handling anymore.
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::determineSliderThumbState):
isEnabled(), isFocused(), and isPressed() are enough.
LayoutTests:
The behavior was changed. We should show slider thumbs for any nodes with
-webkit-appearance:slidertumb-horizontal/vertical.
* fast/forms/thumbslider-no-parent-slider.html:
* platform/chromium/test_expections.txt: Expect to fail with thumbslider-no-parent-slider.html.
* platform/mac/fast/forms/thumbslider-no-parent-slider-expected.png:
* platform/mac/fast/forms/thumbslider-no-parent-slider-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
koz@chromium.org [Thu, 9 Jun 2011 01:40:31 +0000 (01:40 +0000)]
2011-06-08 James Kozianski <koz@chromium.org>
[Chromium] Unreviewed. Revert r88412 because it introduced syntax
errors into test_expectations.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
koz@chromium.org [Thu, 9 Jun 2011 01:11:54 +0000 (01:11 +0000)]
2011-06-08 James Kozianski <koz@chromium.org>
[Chromium] Unreviewed. Fix expectations for
styles-disable-then-change.html.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 9 Jun 2011 00:34:13 +0000 (00:34 +0000)]
2011-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Use after free in WebCore::ContainerNode::parserAddChild
https://bugs.webkit.org/show_bug.cgi?id=62160
Test that we don't trigger asserts when re-entering the parser from
tree construction.
* fast/parser/document-write-onload-nesting-expected.txt: Added.
* fast/parser/document-write-onload-nesting.html: Added.
* fast/parser/document-write-onload-ordering-expected.txt: Added.
* fast/parser/document-write-onload-ordering.html: Added.
- The exact ordering of the script execution here differs a bit
between browsers. For example, Firefox executes the scripts in a
slightly different order because Firefox runs the parser on a
separate thread (and therefore cannot be re-entered from tree
construction). If/when we move the parser off the main thread,
we're likely to change the ordering here a bit, which should be
ok.
2011-06-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
constructTreeFromToken can re-enter parser, causing ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=62160
This patch clears the HTMLToken before constructing the tree from the
token, putting the HTMLDocumentParser in a good state to be re-entered.
Tests: fast/parser/document-write-onload-nesting.html
fast/parser/document-write-onload-ordering.html
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLToken.h:
(WebCore::HTMLToken::isUninitialized):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::constructTreeFromToken):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 9 Jun 2011 00:20:26 +0000 (00:20 +0000)]
2011-06-08 Kent Tamura <tkent@chromium.org>
Fix Qt build for r88405.
https://bugs.webkit.org/show_bug.cgi?id=62208
* platform/qt/RenderThemeQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 9 Jun 2011 00:00:46 +0000 (00:00 +0000)]
2011-06-08 Ryosuke Niwa <rniwa@webkit.org>
Add PASS expectations to two tests that have been passing on
build.webkit.org Chromium Linux bot.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Wed, 8 Jun 2011 23:58:27 +0000 (23:58 +0000)]
2011-06-08 James Simonsen <simonjam@chromium.org>
[Chromium] Unreviewed, more inspector flakiness.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log