mitz@apple.com [Wed, 9 Nov 2011 00:24:46 +0000 (00:24 +0000)]
REGRESSION (r99613): Incomplete painting of the root element background in flipped blocks writing mode
https://bugs.webkit.org/show_bug.cgi?id=71863
Reviewed by Anders Carlsson.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxFillLayers): Instead of unconditionally flipping the background
rect here...
* rendering/RenderView.cpp:
(WebCore::RenderView::backgroundRect): ...flip it only in column mode here.
* rendering/RenderView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 9 Nov 2011 00:21:11 +0000 (00:21 +0000)]
DFG OSR exit code should be generated by a separate compiler, not
related to DFG::JITCompiler
https://bugs.webkit.org/show_bug.cgi?id=71787
Reviewed by Gavin Barraclough.
Moves the exitSpeculativeWithOSR() method from JITCompiler to
OSRExitCompiler::compileExit().
* CMakeListsEfl.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
* dfg/DFGJITCompiler32_64.cpp: Removed.
* dfg/DFGOSRExitCompiler.h: Added.
(JSC::DFG::OSRExitCompiler::OSRExitCompiler):
* dfg/DFGOSRExitCompiler32_64.cpp: Added.
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp: Added.
(JSC::DFG::OSRExitCompiler::compileExit):
* runtime/JSValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 9 Nov 2011 00:13:13 +0000 (00:13 +0000)]
Move NSRange / DOMRange functions back to WebFrameInternal
https://bugs.webkit.org/show_bug.cgi?id=71844
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2011-11-08
Reviewed by Alexey Proskuryakov.
* WebView/WebFrame.mm:
(-[WebFrame _convertNSRangeToDOMRange:]):
(-[WebFrame _convertDOMRangeToNSRange:]):
* WebView/WebFrameInternal.h:
* WebView/WebFramePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 9 Nov 2011 00:12:35 +0000 (00:12 +0000)]
Basic DFG definitions should be moved out of DFGNode.h
https://bugs.webkit.org/show_bug.cgi?id=71861
Rubber-stamped by Gavin Barraclough.
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGCommon.h: Added.
(JSC::DFG::NodeIndexTraits::defaultValue):
* dfg/DFGNode.h:
* dfg/DFGOSRExit.h:
* dfg/DFGRegisterBank.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Nov 2011 23:57:23 +0000 (23:57 +0000)]
[Mac] Disable C++ exceptions from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=71834
Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-11-08
Reviewed by Darin Adler.
DumpRenderTree Mac does not handle C++ exceptions. When such exception
happens, it tends to cause the AutoReleasePool stack to be corrupted,
which leads to crashes long after the exception was raised.
This patch disabled C++ exceptions in order to catch the problems where
they happen when a C++ exception is raised.
* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 8 Nov 2011 23:52:36 +0000 (23:52 +0000)]
[WinCairo] Unreviewed build fix after r99613.
* win/WebKit2CFLite.def: Add missing export.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fsamuel@chromium.org [Tue, 8 Nov 2011 23:49:44 +0000 (23:49 +0000)]
Delete WebViewimpl::scalePage
https://bugs.webkit.org/show_bug.cgi?id=71711
Reviewed by Darin Fisher.
Once this patch lands: http://codereview.chromium.org/
8477033
WebViewImpl::scalePage will no longer be used in Chromium and
can safely be deleted.
* public/WebView.h:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 8 Nov 2011 23:48:53 +0000 (23:48 +0000)]
Rebaseline test failing due to subtle antialiasing differences.
Garden-o-matic claims it broke at r99613.
* platform/chromium-cg-mac-leopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
* platform/chromium-cg-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
* platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
* platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 8 Nov 2011 23:45:05 +0000 (23:45 +0000)]
Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
https://bugs.webkit.org/show_bug.cgi?id=71761
Templatized Parser based on Lexer<T>. Moved two enums,
SourceElementsMode and FunctionRequirements out of Parser definition
to work around a clang compiler defect.
Cleaned up SourceCode data() to return StringImpl* and eliminated
the recently added stringData() virtual method.
To keep code in Parser.cpp and keep Parser.h small, the two flavors
of Parser are explicitly instantiated at the end of Parser.cpp.
Patch by Michael Saboff <msaboff@apple.com> on 2011-11-08
Reviewed by Gavin Barraclough.
* interpreter/Interpreter.cpp:
(JSC::appendSourceToError):
* parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::sourceCode):
* parser/Parser.cpp:
(JSC::::Parser):
(JSC::::~Parser):
(JSC::::parseInner):
(JSC::::didFinishParsing):
(JSC::::allowAutomaticSemicolon):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::isBinaryOperator):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):
* parser/Parser.h:
(JSC::::parse):
(JSC::parse):
* parser/SourceCode.h:
(JSC::SourceCode::data):
(JSC::SourceCode::subExpression):
* parser/SourceProvider.h:
(JSC::UStringSourceProvider::data):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 8 Nov 2011 23:44:56 +0000 (23:44 +0000)]
Rebaselines and expectations after r99609 and r99616 and r99613.
* platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
* platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
* platform/chromium-linux-x86/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
* platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
* platform/chromium-linux-x86/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
* platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
* platform/chromium-linux-x86/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
* platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
* platform/chromium-linux-x86/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
* platform/chromium-linux/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
* platform/chromium-linux/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
* platform/chromium-linux/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
* platform/chromium-linux/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
* platform/chromium-linux/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
* platform/chromium-linux/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
* platform/chromium-linux/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
* platform/chromium-linux/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
* platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
* platform/chromium-win-vista/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
* platform/chromium-win-vista/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
* platform/chromium-win-vista/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
* platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
* platform/chromium-win-vista/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
* platform/chromium-win-vista/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
* platform/chromium-win-vista/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
* platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
* platform/chromium-win-xp/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
* platform/chromium-win-xp/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
* platform/chromium-win-xp/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
* platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
* platform/chromium-win-xp/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
* platform/chromium-win-xp/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
* platform/chromium-win-xp/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
* platform/chromium-win/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
* platform/chromium-win/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
* platform/chromium-win/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
* platform/chromium-win/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
* platform/chromium-win/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
* platform/chromium-win/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
* platform/chromium-win/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
* platform/chromium-win/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Tue, 8 Nov 2011 23:42:43 +0000 (23:42 +0000)]
Moved myself to the reviewer list (yay!).
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Tue, 8 Nov 2011 23:17:01 +0000 (23:17 +0000)]
[WinCairo] Unreviewed build fix after r98624 and r99613.
* win/WebKit2CFLite.def: Add missing exports.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Tue, 8 Nov 2011 22:49:27 +0000 (22:49 +0000)]
Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type
https://bugs.webkit.org/show_bug.cgi?id=71761
Source/JavaScriptCore:
Templatized Parser based on Lexer<T>. Moved two enums,
SourceElementsMode and FunctionRequirements out of Parser definition
to work around a clang compiler defect.
Cleaned up SourceCode data() to return StringImpl* and eliminated
the recently added stringData() virtual method.
To keep code in Parser.cpp and keep Parser.h small, the two flavors
of Parser are explicitly instantiated at the end of Parser.cpp.
Reviewed by Gavin Barraclough.
* interpreter/Interpreter.cpp:
(JSC::appendSourceToError):
* parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::sourceCode):
* parser/Parser.cpp:
(JSC::::Parser):
(JSC::::~Parser):
(JSC::::parseInner):
(JSC::::didFinishParsing):
(JSC::::allowAutomaticSemicolon):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::isBinaryOperator):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::::parseUnaryExpression):
* parser/Parser.h:
(JSC::::parse):
(JSC::parse):
* parser/SourceCode.h:
(JSC::SourceCode::data):
(JSC::SourceCode::subExpression):
* parser/SourceProvider.h:
(JSC::UStringSourceProvider::data):
Source/WebCore:
Cleaned up SourceCode data() to return StringImpl* and eliminated
the recently added stringData() virtual method.
No tests added - refactored base class SourceCode and its subclasses.
* bindings/js/CachedScriptSourceProvider.h:
(WebCore::CachedScriptSourceProvider::data):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::dispatchFailedToParseSource):
* bindings/js/StringSourceProvider.h:
(WebCore::StringSourceProvider::data):
Source/WebKit/mac:
Changed WKPCEvaluate() to use emptyString() when the source is
zero length.
Reviewed by Gavin Barraclough.
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCEvaluate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Tue, 8 Nov 2011 22:44:17 +0000 (22:44 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71856
WebKit should use new NSWindowDidChangeBackingPropertiesNotification instead of
old NSWindowDidChangeResolutionNotification
-and corresponding-
<rdar://problem/
10317253>
Reviewed by Tim Hatcher.
Source/WebKit/mac:
* WebView/WebView.mm:
(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
We have to check that the backing scale factor actually changed since this
notification can also be used to signify other changes.
(-[WebView _windowDidChangeBackingProperties:]):
Source/WebKit2:
* UIProcess/API/mac/WKView.mm:
(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
We have to check that the backing scale factor actually changed since this
notification can also be used to signify other changes.
(-[WKView _windowDidChangeBackingProperties:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Tue, 8 Nov 2011 22:22:24 +0000 (22:22 +0000)]
REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left
https://bugs.webkit.org/show_bug.cgi?id=70395
Reviewed by Tony Chang.
Source/WebCore:
Change the condition to perform immediate scolling inside ScrollView::updateScrollbars()
to be correct for RTL page as well, which is checking either the scroll position change or
the m_scrollOrigin changes (such as in window resize in which scroll position might remain the same).
And remove condition checking inside ScrollableArea::scrollToOffsetWithoutAnimation() since
the pass-in offset is adjusted within the current scroll range, it could be the same as
m_currentPos when m_currentPos is (0, 0) and current scroll range is smaller than old
scroll range, but scolling is still needed when page resize and scroll range changes.
Test: fast/dom/rtl-scroll-to-leftmost-and-resize.html
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation): Remove condition checking.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Change condition to perform immediate scrolling to be
correct for RTL pages as well.
* platform/ScrollableArea.cpp: Update m_scrollOriginChanged.
(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::setScrollOrigin):
(WebCore::ScrollableArea::setScrollOriginX):
(WebCore::ScrollableArea::setScrollOriginY):
* platform/ScrollableArea.h: Add m_scrollOriginChanged.
(WebCore::ScrollableArea::scrollOriginChanged):
(WebCore::ScrollableArea::resetScrollOriginChanged):
LayoutTests:
* fast/dom/rtl-scroll-to-leftmost-and-resize.html: Added.
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 8 Nov 2011 22:01:16 +0000 (22:01 +0000)]
Add a basic layer hierarchy to the Core Animation drawing area
https://bugs.webkit.org/show_bug.cgi?id=71838
Reviewed by Sam Weinig.
* UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
Return early if we're using a tiled drawing area.
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
If we're using a tiled drawing area, make the WKView layer backed and set its layer
to a simple CALayer with a white background and set the view's content redraw policy
to never to avoid ever calling drawRect.
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::didUpdateGeometry):
* UIProcess/DrawingAreaProxy.messages.in:
Add a new didUpdateGeometry message.
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
Initialize m_isWaitingForDidUpdateGeometry.
(WebKit::TiledCoreAnimationDrawingAreaProxy::sizeDidChange):
Send an UpdateGeometry message to the web process and wait for a reply.
(WebKit::TiledCoreAnimationDrawingAreaProxy::enterAcceleratedCompositingMode):
Tell the web page proxy to enter accelerated compositing mode.
(WebKit::TiledCoreAnimationDrawingAreaProxy::exitAcceleratedCompositingMode):
Assert that this function is never called.
(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
Send another UpdateGeometry message if needed.
(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
Add helper function to actually send the UpdateGeometry message.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::updateGeometry):
* WebProcess/WebPage/DrawingArea.messages.in:
Add UpdateGeometry message.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Create a red root layer and a remote layer client that hosts it.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Resize the root layer and tell the UI process that we've updated the geometry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 8 Nov 2011 21:57:16 +0000 (21:57 +0000)]
DFG JIT calculation of OSR entry points is not THUMB2 safe
https://bugs.webkit.org/show_bug.cgi?id=71852
Reviewed by Oliver Hunt.
Executable addresses are tagged with a low bit set to distinguish
between THUMB2 and traditional ARM.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* jit/JITCode.h:
(JSC::JITCode::executableAddressAtOffset):
(JSC::JITCode::start):
(JSC::JITCode::size):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 8 Nov 2011 21:14:55 +0000 (21:14 +0000)]
<rdar://problem/
10262225> Allow RenderView to have columns
https://bugs.webkit.org/show_bug.cgi?id=71840
Source/WebCore:
Reviewed by Simon Fraser.
Tests: fast/multicol/pagination-h-horizontal-bt.html
fast/multicol/pagination-h-horizontal-tb.html
fast/multicol/pagination-h-vertical-lr.html
fast/multicol/pagination-h-vertical-rl.html
fast/multicol/pagination-v-horizontal-bt.html
fast/multicol/pagination-v-horizontal-tb.html
fast/multicol/pagination-v-vertical-lr.html
fast/multicol/pagination-v-vertical-rl.html
* WebCore.exp.in: Export Page::setPagination() for WebCoreTestSupport.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument): Set the column axis and the column gap in the
document style if the view is paginated.
* page/Page.cpp:
(WebCore::Page::setPagination): Added this setter.
* page/Page.h:
(WebCore::Page::Pagination::Pagination):
(WebCore::Page::pagination): Added this getter.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::requiresColumns): Added and moved some logic to here from...
(WebCore::RenderBlock::setDesiredColumnCountAndWidth): ...here.
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxFillLayers): Changed to use the new RenderView::backgroundRect()
instead of unscaledDocumentRect().
* rendering/RenderView.cpp:
(WebCore::RenderView::requiresColumns): Added this override that always returns true if the view
is paginated.
(WebCore::RenderView::backgroundRect): Added. In the paginated case, returns a rectangle stretching
across all columns.
* rendering/RenderView.h:
* testing/Internals.cpp:
(WebCore::Internals::reset): Also reset pagination.
(WebCore::Internals::setPagination): Added this setter for testing.
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
* win/WebKit2.def: Export Page::setPagination() for WebCoreTestSupport.
LayoutTests:
Reviewed by Simon Fraser.
* fast/multicol/pagination-h-horizontal-bt.html: Added.
* fast/multicol/pagination-h-horizontal-tb.html: Added.
* fast/multicol/pagination-h-vertical-lr.html: Added.
* fast/multicol/pagination-h-vertical-rl.html: Added.
* fast/multicol/pagination-v-horizontal-bt.html: Added.
* fast/multicol/pagination-v-horizontal-tb.html: Added.
* fast/multicol/pagination-v-vertical-lr.html: Added.
* fast/multicol/pagination-v-vertical-rl.html: Added.
* platform/mac/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
* platform/mac/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
* platform/mac/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
* platform/mac/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
* platform/mac/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
* platform/mac/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
* platform/mac/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
* platform/mac/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
* platform/mac/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
* platform/mac/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
* platform/mac/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
* platform/mac/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
* platform/mac/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
* platform/mac/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
* platform/mac/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
* platform/mac/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Nov 2011 21:02:00 +0000 (21:02 +0000)]
Document.importNode's 'deep' argument should default to true.
https://bugs.webkit.org/show_bug.cgi?id=71190
Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-08
Reviewed by Adam Barth.
Source/WebCore:
As new specification says deep argument of importNode should be default to true.
Test: fast/dom/document-importNode-arguments.html
* dom/Document.h: Added supportive method.
(WebCore::Document::importNode):
* dom/Document.idl: Modified deep argument as optional.
LayoutTests:
Added test to check document.importNode with No deep argument,
deep argument true and false.
* fast/dom/document-importNode-arguments-expected.txt: Added.
* fast/dom/document-importNode-arguments.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Tue, 8 Nov 2011 20:59:47 +0000 (20:59 +0000)]
WebKitMutationObserver.observe should raise a DOMException if passed invalid arguments
https://bugs.webkit.org/show_bug.cgi?id=71596
Reviewed by Ryosuke Niwa.
Source/WebCore:
Adds two cases where WebKitMutationObserver.observe throws an exception:
- When passed a null Node*.
- When passed options that don't make sense, e.g.,
'attributeOldValue' but not 'attributes'.
* bindings/js/JSWebKitMutationObserverCustom.cpp:
(WebCore::JSWebKitMutationObserver::observe):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::observeCallback):
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::validateOptions):
(WebCore::WebKitMutationObserver::observe):
* dom/WebKitMutationObserver.h:
* dom/WebKitMutationObserver.idl:
LayoutTests:
* fast/mutation/observe-exceptions-expected.txt:
* fast/mutation/observe-exceptions.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 8 Nov 2011 20:53:55 +0000 (20:53 +0000)]
Revert check-in. My mistake.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Nov 2011 20:51:14 +0000 (20:51 +0000)]
IndexedDB: implement compound (array) key support
https://bugs.webkit.org/show_bug.cgi?id=62284
Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-08
Reviewed by Tony Chang.
Source/WebCore:
Add support for Array values as IDBKeys. (Multirow indexes are still
not yet supported.)
Tests: storage/indexeddb/cursor-key-order.html
storage/indexeddb/key-type-array.html
* bindings/js/JSIDBKeyCustom.cpp:
(WebCore::toJS):
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* storage/IDBKey.cpp:
(WebCore::IDBKey::compare):
* storage/IDBKey.h:
(WebCore::IDBKey::createArray):
(WebCore::IDBKey::valid):
(WebCore::IDBKey::array):
(WebCore::IDBKey::compareTypes):
* storage/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::compareEncodedStringsWithLength):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
(WebCore::IDBLevelDBCoding::keyTypeByteToKeyType):
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
* storage/IDBLevelDBCoding.h:
Source/WebKit/chromium:
Extend WebKit API to support Array values as IDBKeys.
* public/WebIDBKey.h:
* src/AssertMatchingEnums.cpp:
* src/WebIDBKey.cpp:
(WebKit::WebIDBKey::createArray):
(WebKit::convertFromWebIDBKeyArray):
(WebKit::convertToWebIDBKeyArray):
(WebKit::WebIDBKey::assignArray):
(WebKit::WebIDBKey::array):
* tests/IDBBindingUtilitiesTest.cpp:
(WebCore::TEST):
* tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::createArrayIDBKey):
(IDBLevelDBCoding::TEST):
(IDBLevelDBCoding::compareStrings):
LayoutTests:
* storage/indexeddb/cursor-key-order-expected.txt: Added.
* storage/indexeddb/cursor-key-order.html: Added.
* storage/indexeddb/factory-cmp-expected.txt:
* storage/indexeddb/factory-cmp.html:
* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics.html:
* storage/indexeddb/key-type-array-expected.txt: Added.
* storage/indexeddb/key-type-array.html: Added.
* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/keyrange.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/open-cursor.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Tue, 8 Nov 2011 20:37:52 +0000 (20:37 +0000)]
JSC::Parser::Parser leaks Lexer member
https://bugs.webkit.org/show_bug.cgi?id=71847
Changed m_lexer member of Parser to be OwnPtr to fix a memory leak.
Reviewed by Oliver Hunt.
* parser/Parser.cpp:
(JSC::Parser::Parser):
(JSC::Parser::parseFunctionBody):
* parser/Parser.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Tue, 8 Nov 2011 20:33:30 +0000 (20:33 +0000)]
Remove get() defined in CredentialStorageQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=71829
Reviewed by Andreas Kling.
CredentialStorage::get() is implemented in CredentialStorage.cpp. And CredentialStorage.cpp
provides the base implementation for each platform. We shouldn't re-define
CredentialStorage::get() in CredentialStorageQt.cpp.
* Target.pri: Add files CredentialStorage.{cpp, h}.
* platform/network/qt/CredentialStorageQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Tue, 8 Nov 2011 20:31:25 +0000 (20:31 +0000)]
[WK2] Expose acceptMIMETypes for file inputs
https://bugs.webkit.org/show_bug.cgi?id=71836
<rdar://problem/
10407367>
Reviewed by Anders Carlsson.
* Shared/WebOpenPanelParameters.cpp:
(WebKit::WebOpenPanelParameters::acceptMIMETypes):
* Shared/WebOpenPanelParameters.h:
* UIProcess/API/C/WKOpenPanelParameters.cpp:
(WKOpenPanelParametersCopyAcceptedMIMETypes):
* UIProcess/API/C/WKOpenPanelParameters.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 8 Nov 2011 20:20:08 +0000 (20:20 +0000)]
Fix more build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 8 Nov 2011 20:14:32 +0000 (20:14 +0000)]
Fix build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Nov 2011 20:10:44 +0000 (20:10 +0000)]
[WK2][GTK] The default database & local storage directory names should note they exist for Gtk port's needs
https://bugs.webkit.org/show_bug.cgi?id=71837
Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-08
Reviewed by Martin Robinson.
Ensure that directories for databases and local storage are in a 'webkitgtk'
directory in current user's data directory, noting they originate from the Gtk port.
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Nov 2011 19:41:41 +0000 (19:41 +0000)]
IndexedDB: reference cycle between IDBDatabase and IDBTransaction
https://bugs.webkit.org/show_bug.cgi?id=71749
Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-08
Reviewed by Tony Chang.
Source/WebCore:
Break a cyclic reference leak following a setVersion call.
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::setVersionChangeTransaction):
(WebCore::IDBDatabase::clearVersionChangeTransaction):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
* storage/IDBDatabase.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
LayoutTests:
Add test case to verify that creating/deleting a store outside
a transaction throws same error if store exists. Also fix
the test to actually try removing stores.
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/create-and-remove-object-store.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zeno.albisser@nokia.com [Tue, 8 Nov 2011 19:29:58 +0000 (19:29 +0000)]
Added myself as a committer.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 8 Nov 2011 19:19:35 +0000 (19:19 +0000)]
Fix expectations mixup.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Tue, 8 Nov 2011 19:13:22 +0000 (19:13 +0000)]
Remove get() defined in CredentialStorageSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=71825
Reviewed by Martin Robinson.
CredentialStorage::get() is implemented in CredentialStorage.cpp. And CredentialStorage.cpp
provides the base implementation for each platform. We shouldn't re-define
CredentialStorage::get() in CredentialStorageSoup.cpp.
* GNUmakefile.list.am: Add source file CredentialStorage.cpp.
* platform/network/soup/CredentialStorageSoup.cpp: Remove re-definition of CredentialStorage::get().
CredentialStorage::get() is defined in CredentialStorage.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Tue, 8 Nov 2011 19:04:43 +0000 (19:04 +0000)]
Rename CSS document() -> findDocument(), to indicate tree climbing
https://bugs.webkit.org/show_bug.cgi?id=71764
Renamed document() to findDocument(), styleSheetOwnerNode() to findStyleSheetOwnerNode().
Reviewed by Darin Adler.
No new tests. (simple refactoring)
* css/CSSGrammar.y:
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::setCSSStyleSheet):
(WebCore::CSSImportRule::requestStyleSheet):
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
* css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::findDocument):
(WebCore::CSSParser::parseAttr):
* css/CSSParser.h:
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::findStyleSheetOwnerNode):
(WebCore::CSSStyleSheet::findDocument):
(WebCore::CSSStyleSheet::styleSheetChanged):
* css/CSSStyleSheet.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::bindStyleSheet):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::ownerDocument):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::retrieveResourcesForCSSDeclaration):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 8 Nov 2011 18:39:49 +0000 (18:39 +0000)]
Indent command can insert block quote in non editable content
https://bugs.webkit.org/show_bug.cgi?id=71754
Reviewed by Enrica Casucci.
Source/WebCore:
The bug was caused by IndentOutdentCommand's incorrectly using deprecatedNode to determine the outer block,
not updating the start after inserting the targetBlockquote, and cloneParagraphUnderNewElement's cloning
outerNode even if it was body. Fixed those bugs.
Test: editing/execCommand/indent-images.html
editing/execCommand/indent-images-2.html
editing/execCommand/indent-images-3.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::indentIntoBlockquote):
LayoutTests:
Add tests to indent two images in a document.
* editing/execCommand/indent-images-expected.txt: Added.
* editing/execCommand/indent-images.html: Added.
* editing/execCommand/indent-images-2-expected.txt: Added.
* editing/execCommand/indent-images-2.html: Added.
* editing/execCommand/indent-images-3-expected.txt: Added.
* editing/execCommand/indent-images-3.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Tue, 8 Nov 2011 18:29:54 +0000 (18:29 +0000)]
Only walk up the tree in search of MutationObservers if one has been added
https://bugs.webkit.org/show_bug.cgi?id=71499
Reviewed by Ojan Vafai.
Source/WebCore:
Analogous to m_listenerTypes, added an m_subtreeMutationObserverTypes field
to Document that keeps track of which observer types have been added.
This allows us to avoid doing any extra work if MutationObservers are
not attached to a document.
This could be improved upon to keep a count of each type, as removing
an observer currently has no effect on m_subtreeMutationObserverTypes.
But that would require a more complex implementation: one counter per
mutation type. And it would be easier to get wrong: if the counter
gets out of sync with the actual state of the DOM, we could start
dropping mutation notifications.
Test: fast/mutation/cross-document.html
* dom/Document.h:
(WebCore::Document::hasSubtreeMutationObserverOfType):
(WebCore::Document::hasSubtreeMutationObserver):
(WebCore::Document::addSubtreeMutationObserverTypes):
* dom/MutationObserverRegistration.h:
(WebCore::MutationObserverRegistration::isSubtree):
(WebCore::MutationObserverRegistration::deliveryOptions):
(WebCore::MutationObserverRegistration::mutationTypes):
* dom/Node.cpp:
(WebCore::Node::didMoveToNewOwnerDocument): Update mutationObserverTypes when a Node is moved to a new document.
(WebCore::Node::getRegisteredMutationObserversOfType): Exit early if it's known that no observers of |type| are registered.
(WebCore::Node::notifyMutationObserversNodeWillDetach): Exit early if it's known no subtree observers of any type are registered.
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::observe): Update mutationObserverTypes when an observation occurs.
* dom/WebKitMutationObserver.h: Add WebKitMutationObserver::AllMutationTypes to enum
LayoutTests:
Created a basic test showing that MutationObservers
are preserved when a Node switches documents.
* fast/mutation/cross-document-expected.txt: Added.
* fast/mutation/cross-document.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 8 Nov 2011 18:27:07 +0000 (18:27 +0000)]
Devirtualize CSSValue.
<http://webkit.org/b/71666>
Reviewed by Antti Koivisto.
Make the CSSValue destructor non-virtual (along with all the subclasses.)
This removes the vtables, and the pointers thereto in each value instance,
shrinking each object by one CPU word (4 or 8 bytes.)
We use the same trick as CSSRule to implement destruction; providing our
own deref() instead of RefCounted's, and performing a statically typed
delete in a destroy() method called when the ref count reaches 0.
Also made all the empty subclass destructors inline.
* css/CSSAspectRatioValue.cpp:
* css/CSSAspectRatioValue.h:
(WebCore::CSSAspectRatioValue::~CSSAspectRatioValue):
* css/CSSBorderImageSliceValue.cpp:
* css/CSSBorderImageSliceValue.h:
(WebCore::CSSBorderImageSliceValue::~CSSBorderImageSliceValue):
* css/CSSBorderImageValue.cpp:
* css/CSSBorderImageValue.h:
(WebCore::CSSBorderImageValue::~CSSBorderImageValue):
* css/CSSCanvasValue.h:
* css/CSSCrossfadeValue.cpp:
* css/CSSCrossfadeValue.h:
(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
* css/CSSCursorImageValue.h:
* css/CSSFlexValue.cpp:
* css/CSSFlexValue.h:
(WebCore::CSSFlexValue::~CSSFlexValue):
* css/CSSFontFaceSrcValue.cpp:
* css/CSSFontFaceSrcValue.h:
(WebCore::CSSFontFaceSrcValue::~CSSFontFaceSrcValue):
* css/CSSFunctionValue.cpp:
* css/CSSFunctionValue.h:
(WebCore::CSSFunctionValue::~CSSFunctionValue):
* css/CSSImageGeneratorValue.h:
* css/CSSImageValue.h:
* css/CSSMutableValue.h:
(WebCore::CSSMutableValue::~CSSMutableValue):
* css/CSSParserValues.h:
* css/CSSPrimitiveValue.h:
* css/CSSUnicodeRangeValue.cpp:
* css/CSSUnicodeRangeValue.h:
(WebCore::CSSUnicodeRangeValue::~CSSUnicodeRangeValue):
* css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::deref):
(WebCore::CSSValue::~CSSValue):
* css/CSSValueList.cpp:
* css/CSSValueList.h:
(WebCore::CSSValueList::~CSSValueList):
* css/WebKitCSSFilterValue.cpp:
* css/WebKitCSSFilterValue.h:
(WebCore::WebKitCSSFilterValue::~WebKitCSSFilterValue):
* css/WebKitCSSTransformValue.cpp:
* css/WebKitCSSTransformValue.h:
(WebCore::WebKitCSSTransformValue::~WebKitCSSTransformValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 8 Nov 2011 18:25:31 +0000 (18:25 +0000)]
Speculative fix for crashes seen in DocumentWriter::deprecatedFrameEncoding
https://bugs.webkit.org/show_bug.cgi?id=71828
Reviewed by Nate Chapin.
No new tests; not sure how to reproduce this, but crash traces indicate it
is an otherwise-harmless null dereference.
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::deprecatedFrameEncoding):
Handle null document the same as a document without a URL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 8 Nov 2011 18:24:29 +0000 (18:24 +0000)]
Move regressions from V8 roll to from the downstream expectations file.
Add regressions from http://trac.webkit.org/changeset/99561.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Nov 2011 18:23:30 +0000 (18:23 +0000)]
Unreviewed, rolling out r95720.
http://trac.webkit.org/changeset/95720
https://bugs.webkit.org/show_bug.cgi?id=71831
This has made the menulists on WebKit patch reviews much less
usable (Requested by mrobinson on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-08
* platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::menuPositionFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 8 Nov 2011 18:20:18 +0000 (18:20 +0000)]
[chromium] Remove 6 exit time destructors and 6 static initializers
https://bugs.webkit.org/show_bug.cgi?id=71760
Reviewed by Nate Chapin.
Do this by moving global statics into function-local statics, and using
DEFINE_LOCAL_STATIC to leak them. Since this code is accessed on a single
thread, this is a safe change to make.
No behavior change, so no new tests.
* bindings/v8/ScriptGCEvent.cpp:
(WebCore::sEventListeners):
(WebCore::ScriptGCEvent::addEventListener):
(WebCore::ScriptGCEvent::removeEventListener):
(WebCore::ScriptGCEvent::gcEpilogueCallback):
* bindings/v8/ScriptGCEvent.h:
* bindings/v8/V8NPObject.cpp:
(WebCore::staticTemplateMap):
(WebCore::weakTemplateCallback):
(WebCore::npObjectGetProperty):
(WebCore::staticNPObjectMap):
(WebCore::weakNPObjectCallback):
(WebCore::createV8ObjectForNPObject):
(WebCore::forgetV8ObjectForNPObject):
* bindings/v8/V8Proxy.cpp:
(WebCore::staticExtensionsList):
(WebCore::V8Proxy::registeredExtensionWithV8):
(WebCore::V8Proxy::registerExtension):
(WebCore::V8Proxy::extensions):
* bindings/v8/V8Proxy.h:
* bindings/v8/npruntime.cpp:
* plugins/chromium/PluginDataChromium.cpp:
(WebCore::pluginCache):
(WebCore::PluginData::initPlugins):
(WebCore::PluginData::refresh):
(WebCore::getPluginMimeTypeFromExtension):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 8 Nov 2011 18:17:47 +0000 (18:17 +0000)]
[chromium] broaden test failure for zoom-animator-scale-test2.html to include cg-gpu.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 8 Nov 2011 18:10:31 +0000 (18:10 +0000)]
New tests results after r99539.
zoom-replaced-intrinsic-ratio-001-expected.png is just minor antialiasing differences.
The rest are all changing to a size that matched the pngs in platform/mac.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-cg-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
* platform/chromium-cg-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
* platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Removed.
* platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
* platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.png: Removed.
* platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Removed.
* platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
* platform/chromium/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/chromium/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Nov 2011 18:04:11 +0000 (18:04 +0000)]
Autofocus inputs don't always honor selector input:focus.
https://bugs.webkit.org/show_bug.cgi?id=24093
Already fixed and works on TOT. Adding layout test case for the same.
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-11-08
Reviewed by Kent Tamura.
* fast/forms/autofocus-input-css-style-change-expected.txt: Added.
* fast/forms/autofocus-input-css-style-change.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Tue, 8 Nov 2011 17:51:06 +0000 (17:51 +0000)]
IndexedDB: Start using the onSuccessWithContinuation() callback
https://bugs.webkit.org/show_bug.cgi?id=71565
Reviewed by Tony Chang.
Source/WebCore:
This is a follow-up to r99169 where we start using this new
callback for cursors.
* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::continueFunctionInternal):
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::setCursor):
LayoutTests:
The cursor-inconsistency.html test now passes completely.
* storage/indexeddb/cursor-inconsistency-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Nov 2011 17:49:37 +0000 (17:49 +0000)]
Skip some ECMAScript tests that fail on Linux in some time zones.
https://bugs.webkit.org/show_bug.cgi?id=71371
Patch by Andy Wingo <wingo@igalia.com> on 2011-11-08
Reviewed by Martin Robinson.
* Scripts/run-javascriptcore-tests: Skip some more tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Tue, 8 Nov 2011 17:42:29 +0000 (17:42 +0000)]
Document::loader should use documentLoader(), not activeDocumentLoader()
https://bugs.webkit.org/show_bug.cgi?id=65895
Reviewed by Brady Eidson.
Source/WebCore:
Test: fast/loader/stateobjects/replacestate-in-onunload.html
* dom/Document.cpp:
(WebCore::Document::loader):
LayoutTests:
* fast/loader/stateobjects/replacestate-in-onunload-expected.txt: Added.
* fast/loader/stateobjects/replacestate-in-onunload.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Nov 2011 17:36:04 +0000 (17:36 +0000)]
[WK][GTK] Application cache directory is incorrectly set
https://bugs.webkit.org/show_bug.cgi?id=71769
Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-08
Reviewed by Martin Robinson.
Set the application cache directory to be placed in current user's
cache directory and update documentation for
webkit_application_cache_get_database_directory_path after these
changes and changes in r80715;
* webkit/webkitapplicationcache.cpp:
* webkit/webkitglobals.cpp:
(webkitInit): Switch one string formation to use GOwnPtr<gchar>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 8 Nov 2011 17:33:07 +0000 (17:33 +0000)]
CSSImageGeneratorValue: Devirtualize image(), isFixedSize() and fixedSize().
<http://webkit.org/b/71824>
Reviewed by Darin Adler.
Redirect the calls to the appropriate subclass in CSSImageGeneratorValue.cpp.
* css/CSSCanvasValue.h:
(WebCore::CSSCanvasValue::isFixedSize):
* css/CSSCrossfadeValue.h:
(WebCore::CSSCrossfadeValue::isFixedSize):
* css/CSSGradientValue.h:
(WebCore::CSSGradientValue::isFixedSize):
(WebCore::CSSGradientValue::fixedSize):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::isFixedSize):
(WebCore::CSSImageGeneratorValue::fixedSize):
* css/CSSImageGeneratorValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Nov 2011 17:09:17 +0000 (17:09 +0000)]
[GTK] fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=71774
Patch by Philippe Normand <pnormand@igalia.com> on 2011-11-08
Reviewed by Martin Robinson.
* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
Trigger the test when the iframe loaded to avoid potential
flakyness.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 8 Nov 2011 17:06:33 +0000 (17:06 +0000)]
Web Inspector: [Extension API][Chromium] injected extension API needs to return an object
https://bugs.webkit.org/show_bug.cgi?id=71822
Reviewed by Pavel Feldman.
* inspector/front-end/ExtensionAPI.js:
(buildExtensionAPIInjectedScript):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 8 Nov 2011 16:46:15 +0000 (16:46 +0000)]
CSSImageValue: Devirtualize cachedImage(CachedResourceLoader*).
<http://webkit.org/b/71814>
Reviewed by Antti Koivisto.
Defer to CSSCursorImageValue (the only CSSImageValue subclass)
when appropriate in CSSImageValue::cachedImage(CachedResourceLoader*).
* css/CSSCursorImageValue.h:
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* css/CSSImageValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 8 Nov 2011 16:38:04 +0000 (16:38 +0000)]
Web Inspector: add "Evaluate in console" as a shortcut and context menu items to scripts panel
https://bugs.webkit.org/show_bug.cgi?id=71817
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evaluate):
(WebInspector.ConsoleView.prototype._enterKeyPressed):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._evaluateSelectionInConsole):
* inspector/front-end/ShortcutsScreen.js:
(WebInspector.ShortcutsSection.prototype.addRelatedKeys):
(WebInspector.ShortcutsSection.prototype.addAlternateKeys):
* inspector/front-end/externs.js:
(WebInspector.evaluateInConsole):
* inspector/front-end/inspector.js:
(WebInspector.evaluateInConsole):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 8 Nov 2011 16:26:26 +0000 (16:26 +0000)]
2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline qt results after the recent SVGImage changes.
* platform/qt/Skipped:
* platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
* platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-background-images-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 8 Nov 2011 16:22:16 +0000 (16:22 +0000)]
[Qt] Use qmake's builtin rules for copying framework headers on Mac OS
Now that we generate the forwarding headers eiher as part of QtWebKit.pro
(for Qt 4.8), or as part of the root project file (for Qt 5), we can assume
that the files are there and use $$files() to list the files to be copied.
Reviewed by Csaba Osztrogonác.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Tue, 8 Nov 2011 16:21:26 +0000 (16:21 +0000)]
[Qt] Workaround some problems in QML API tests
https://bugs.webkit.org/show_bug.cgi?id=71818
Reviewed by Tor Arne Vestbø.
This commit workaround the issue of QML's QtTest crashing when we run tests after
"windowShown". We delay to the next run of the mainloop. This workaround is not
pretty but shouldn't affect the semantics of the tests. And we benefit more from
having working tests right now.
This patch also improves Download to: wait for the load before emitting click, and
properly identifying the "succeeded" signal of the downloadItem object.
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 8 Nov 2011 15:40:33 +0000 (15:40 +0000)]
[Qt] Unreviewed trivial fix after build system refactoring.
* Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Tue, 8 Nov 2011 15:34:07 +0000 (15:34 +0000)]
Clean up QtViewportInteractionEngine
Reviewed by Simon Hausmann.
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::setItemRectVisible):
Rename the method to make it more obvious what it does. Avoid implicit
conversion to/from QVariant.
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::itemSizeChanged):
Only call this method on item size changes, and not for every interaction
with the viewport item. Before this change it was even being called during
animations.
* UIProcess/qt/QtViewportInteractionEngine.h:
(WebKit::QtViewportInteractionEngine::scaleAnimationValueChanged):
Rename to make it clean that this is called from the animator.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 8 Nov 2011 15:29:58 +0000 (15:29 +0000)]
CSSValue: Devirtualize cssText().
<http://webkit.org/b/71813>
Reviewed by Antti Koivisto.
Rename all subclass implementations to customCssText() and add
a CSSValue::cssText() that defers to the appropriate subclass
based on the type info.
The rename is both for clarity, and to ensure that calling
cssText() will always end up in the correct method.
* css/CSSAspectRatioValue.cpp:
(WebCore::CSSAspectRatioValue::customCssText):
* css/CSSAspectRatioValue.h:
* css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::customCssText):
* css/CSSBorderImageSliceValue.h:
* css/CSSBorderImageValue.cpp:
(WebCore::CSSBorderImageValue::customCssText):
* css/CSSBorderImageValue.h:
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::customCssText):
* css/CSSCanvasValue.h:
* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::customCssText):
* css/CSSCrossfadeValue.h:
* css/CSSFlexValue.cpp:
(WebCore::CSSFlexValue::customCssText):
* css/CSSFlexValue.h:
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::customCssText):
* css/CSSFontFaceSrcValue.h:
* css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::customCssText):
* css/CSSFunctionValue.h:
* css/CSSGradientValue.cpp:
(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSRadialGradientValue::customCssText):
* css/CSSGradientValue.h:
* css/CSSInheritedValue.cpp:
(WebCore::CSSInheritedValue::customCssText):
* css/CSSInheritedValue.h:
* css/CSSInitialValue.cpp:
(WebCore::CSSInitialValue::customCssText):
* css/CSSInitialValue.h:
* css/CSSLineBoxContainValue.cpp:
(WebCore::CSSLineBoxContainValue::customCssText):
* css/CSSLineBoxContainValue.h:
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::customCssText):
* css/CSSPrimitiveValue.h:
* css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::customCssText):
* css/CSSReflectValue.h:
* css/CSSTimingFunctionValue.cpp:
(WebCore::CSSLinearTimingFunctionValue::customCssText):
(WebCore::CSSCubicBezierTimingFunctionValue::customCssText):
(WebCore::CSSStepsTimingFunctionValue::customCssText):
* css/CSSTimingFunctionValue.h:
(WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue):
* css/CSSUnicodeRangeValue.cpp:
(WebCore::CSSUnicodeRangeValue::customCssText):
* css/CSSUnicodeRangeValue.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::cssText):
* css/CSSValue.h:
* css/CSSValueList.cpp:
(WebCore::CSSValueList::customCssText):
* css/CSSValueList.h:
* css/FontFamilyValue.cpp:
(WebCore::FontFamilyValue::customCssText):
* css/FontFamilyValue.h:
* css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::customCssText):
* css/FontFeatureValue.h:
* css/FontValue.cpp:
(WebCore::FontValue::customCssText):
* css/FontValue.h:
* css/ShadowValue.cpp:
(WebCore::ShadowValue::customCssText):
* css/ShadowValue.h:
* css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::customCssText):
* css/WebKitCSSFilterValue.h:
* css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::customCssText):
* css/WebKitCSSTransformValue.h:
* svg/SVGColor.cpp:
(WebCore::SVGColor::customCssText):
* svg/SVGColor.h:
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::customCssText):
* svg/SVGPaint.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 8 Nov 2011 15:16:16 +0000 (15:16 +0000)]
2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
[Qt] 4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253
Reviewed by Rob Buis.
Address some problems seen on Qt/Chromium:
- Remove the scaled png which is the source of the problem in zoom-background-images.html, we really only want to test zooming in the SVGImage there.
- Don't zoom out more than three times, otherwise its ignored on Mac/DRT, where the minimum zoom factor is clamped to 0.5f.
Qt doesn't have this limit, and currently zooms more than Mac does. There's no need to zoom out that often, three times is enough.
* platform/mac/svg/zoom/page/zoom-background-images-expected.png: Updated.
* platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Update.
* svg/zoom/page/zoom-background-image-tiled.html: Don't set shouldZoomOut to false, it's the default.
* svg/zoom/page/zoom-background-images.html: Don't zoom out more than three times.
* svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Ditto.
* svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Ditto.
* svg/zoom/page/zoom-svg-as-image.html: There is no shouldZoomIn, just remove it, zooming in is the default.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gavinp@chromium.org [Tue, 8 Nov 2011 14:42:25 +0000 (14:42 +0000)]
Fix width of m_type in CachedResource
https://bugs.webkit.org/show_bug.cgi?id=71727
Reviewed by Nate Chapin.
Source/WebCore:
Test: fast/dom/HTMLLinkElement/cachedresource-types.html
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
* loader/cache/CachedResource.h:
LayoutTests:
* fast/dom/HTMLLinkElement/cachedresource-types-expected.txt: Added.
* fast/dom/HTMLLinkElement/cachedresource-types.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 8 Nov 2011 14:40:46 +0000 (14:40 +0000)]
[Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
If a pro file needs to access the OBJECTS_DIR it should use the
form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
after defaults_post has been processed.
Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
the command line will override whatever we set in defaults_pre.
Reviewed by Simon Hausmann.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 8 Nov 2011 14:36:47 +0000 (14:36 +0000)]
Web Inspector: add JavaScript keywords to the autocomplete.
https://bugs.webkit.org/show_bug.cgi?id=71782
Reviewed by Yury Semikhatsky.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):
(WebInspector.ConsoleView.prototype._completions):
(WebInspector.ConsoleView.prototype._reportCompletions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 8 Nov 2011 14:19:40 +0000 (14:19 +0000)]
2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
[Chromium] SVG test failures after r99539
https://bugs.webkit.org/show_bug.cgi?id=71793
Reviewed by Zoltan Herczeg.
It turns out that some of these tests are flakey. Replace <animate> elements with <set>.
That still tests repaint, but there's no need to run a 100ms animation, and then sample it after 400ms.
That cries for problems if the machine is slow or loaded.
I left the 400ms sample snapshot for now, we can still relax it later.
* fast/backgrounds/resources/animated-rect-relative-size.svg:
* svg/as-background-image/resources/animated-rect-relative-size.svg:
* svg/as-image/resources/animated-rect-fixed-size.svg:
* svg/as-image/resources/animated-rect-relative-size.svg:
* svg/as-image/resources/animated-rect-same-image.svg:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 8 Nov 2011 14:14:35 +0000 (14:14 +0000)]
2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
Introduce SVGLengthContext, to allow to resolve relative units to arbitary viewports
https://bugs.webkit.org/show_bug.cgi?id=71780
Reviewed by Zoltan Herczeg.
Introduce SVGLengthContext to cleanup SVGLength, by moving all conversion of relative units that depend on style or viewport
out of SVGLength, into SVGLengthContext. Pass SVGLengthContext& to SVGLength::value/setValue/... functions instead of a pure
"const SVGElement* context", which was previously used to determine the viewport when resolving percentage units.
SVGLengthContext carries an additional FloatRect of the custom viewport, to which percentages are resolved, if specified.
This allows us to kill several duplicates of the same code, which handles objectBoundingBox mode for gradients/patterns/masks/etc..
A follow-up patch will convert filters to use the new SVGLengthContext::resolveRectangle code as well.
This is a preparation for bug 10430, to fix feImage + objectBoundingBox support when rendering referenced elements, instead of files.
Doesn't affect any tests yet.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/svg/RenderSVGResourceGradient.h:
* rendering/svg/RenderSVGResourceLinearGradient.h:
(WebCore::RenderSVGResourceLinearGradient::gradientUnits):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::calculatePatternBoundaries):
(WebCore::RenderSVGResourcePattern::buildTileImageTransform):
(WebCore::RenderSVGResourcePattern::createTileImage):
* rendering/svg/RenderSVGResourceRadialGradient.h:
(WebCore::RenderSVGResourceRadialGradient::gradientUnits):
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeCommonGradientProperties):
(WebCore::writeSVGResourceContainer):
* svg/GradientAttributes.h:
(WebCore::GradientAttributes::GradientAttributes):
(WebCore::GradientAttributes::gradientUnits):
(WebCore::GradientAttributes::setGradientUnits):
(WebCore::GradientAttributes::hasGradientUnits):
* svg/PatternAttributes.h:
(WebCore::PatternAttributes::PatternAttributes):
(WebCore::PatternAttributes::patternUnits):
(WebCore::PatternAttributes::patternContentUnits):
(WebCore::PatternAttributes::setPatternUnits):
(WebCore::PatternAttributes::setPatternContentUnits):
(WebCore::PatternAttributes::hasPatternUnits):
(WebCore::PatternAttributes::hasPatternContentUnits):
* svg/SVGAllInOne.cpp:
* svg/SVGElement.h:
(WebCore::SVGElement::operator SVGLengthContext):
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::filterBoundingBox):
* svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
(WebCore::SVGLength::unitMode):
(WebCore::SVGLength::value):
(WebCore::SVGLength::setValue):
(WebCore::SVGLength::convertToSpecifiedUnits):
* svg/SVGLength.h:
(WebCore::SVGLength::blend):
* svg/SVGLengthContext.cpp: Added.
(WebCore::SVGLengthContext::SVGLengthContext):
(WebCore::SVGLengthContext::resolveRectangle):
(WebCore::SVGLengthContext::resolvePoint):
(WebCore::SVGLengthContext::resolveLength):
(WebCore::SVGLengthContext::convertValueToUserUnits):
(WebCore::SVGLengthContext::convertValueFromUserUnits):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToPercentage):
(WebCore::SVGLengthContext::convertValueFromPercentageToUserUnits):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToEMS):
(WebCore::SVGLengthContext::convertValueFromEMSToUserUnits):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToEXS):
(WebCore::SVGLengthContext::convertValueFromEXSToUserUnits):
(WebCore::SVGLengthContext::determineViewport):
* svg/SVGLengthContext.h: Added.
(WebCore::SVGLengthContext::resolveRectangle):
* svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::collectGradientAttributes):
(WebCore::SVGLinearGradientElement::calculateStartEndPoints):
* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::maskBoundingBox):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):
* svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::collectGradientAttributes):
(WebCore::SVGRadialGradientElement::calculateFocalCenterPointsAndRadius):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 8 Nov 2011 14:01:27 +0000 (14:01 +0000)]
CSSValue: Devirtualize addSubresourceStyleURLs().
<http://webkit.org/b/71805>
Reviewed by Antti Koivisto.
Make addSubresourceStyleURLs() non-virtual and call the appropriate
subclass implementation based on the subclass type info.
* css/CSSBorderImageValue.h:
* css/CSSFontFaceSrcValue.h:
* css/CSSPrimitiveValue.h:
* css/CSSReflectValue.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::addSubresourceStyleURLs):
* css/CSSValue.h:
(WebCore::CSSValue::addSubresourceStyleURLs):
* css/CSSValueList.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuqiang.xian@intel.com [Tue, 8 Nov 2011 13:46:50 +0000 (13:46 +0000)]
Enable DFG JIT by default on X86 Linux and Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=71686
Reviewed by Filip Pizlo.
.:
Remove the DFG cmake option for Efl port as we'll determine whether to
switch on DFG or not based on build target platforms.
* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
We can get 9% on SunSpider, 89% on Kraken and 37% on V8, on Linux X86.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 8 Nov 2011 13:38:13 +0000 (13:38 +0000)]
Web Inspector: do not show object popover when selection is active
https://bugs.webkit.org/show_bug.cgi?id=71804
Reviewed by Yury Semikhatsky.
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._shouldShowPopover):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 8 Nov 2011 13:34:38 +0000 (13:34 +0000)]
Web Inspector: Do not hide SuggestBox if typed-in string in the middle of input equals one of suggestions
https://bugs.webkit.org/show_bug.cgi?id=71797
Reviewed by Yury Semikhatsky.
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPrompt.prototype.complete):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 8 Nov 2011 13:23:24 +0000 (13:23 +0000)]
CSSGradientValue: Devirtualize createGradient().
<http://webkit.org/b/71800>
Reviewed by Antti Koivisto.
Make createGradient() non-virtual and call the appropriate subclass
implementation in image() based on is{Linear,Radial}Gradient().
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
* css/CSSGradientValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Tue, 8 Nov 2011 13:22:03 +0000 (13:22 +0000)]
CSSCanvasValue: Remove inheritance from CanvasObserver.
<http://webkit.org/b/71796>
Reviewed by Antti Koivisto.
To completely devirtualize all the CSSValues, we need to remove
CSSCanvasValue's inheritance from CanvasObserver, as that is forcing
a vptr into the class.
Use the same approach as CSSImportRule and make a simple proxying
CanvasObserver subclass and put that as a member variable of the value.
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::~CSSCanvasValue):
(WebCore::CSSCanvasValue::element):
* css/CSSCanvasValue.h:
(WebCore::CSSCanvasValue::CSSCanvasValue):
(WebCore::CSSCanvasValue::CanvasObserverProxy::CanvasObserverProxy):
(WebCore::CSSCanvasValue::CanvasObserverProxy::~CanvasObserverProxy):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasChanged):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasResized):
(WebCore::CSSCanvasValue::CanvasObserverProxy::canvasDestroyed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 8 Nov 2011 13:06:11 +0000 (13:06 +0000)]
Web Inspector: display notification in the front-end when inspected worker terminates
https://bugs.webkit.org/show_bug.cgi?id=71770
Source/WebCore:
When inspected worker terminates we will show a notification similar to the help
screen. The notification disappears when the worker restarts or the user closes it
manually.
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.loaded):
(WebInspector.WorkerManager.showWorkerTerminatedScreen):
(WebInspector.WorkerTerminatedScreen):
* inspector/front-end/inspector.js:
(WebInspector.disconnectFromBackend):
(WebInspector.frontendReused):
Source/WebKit/chromium:
Exposed an API for the browser to notify inspector front-end when inspeced instance
terminates. It is used now for tracking shared workers termination.
Reviewed by Pavel Feldman.
* public/WebDevToolsAgent.h:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgent::createFrontendDisconnectedEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Tue, 8 Nov 2011 13:03:20 +0000 (13:03 +0000)]
[Chromium] Unreviewed, add three more CG-only failures.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Tue, 8 Nov 2011 12:48:49 +0000 (12:48 +0000)]
[Chromium] Mark fast/backgrounds/svg-as-mask.html as IMAGE on MAC.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Tue, 8 Nov 2011 12:40:54 +0000 (12:40 +0000)]
[Qt] Improve the animation time constant
https://bugs.webkit.org/show_bug.cgi?id=71790
Reviewed by Simon Hausmann.
Use 250 milliseconds instead of 400, which feels a lot more natural
and makes the mini browser feel more responsive.
* UIProcess/qt/QtViewportInteractionEngine.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Tue, 8 Nov 2011 12:37:33 +0000 (12:37 +0000)]
[Chromium] Unreviewed fix of expectation conflict in test_expectations.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 8 Nov 2011 12:29:38 +0000 (12:29 +0000)]
2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
Fold ImageBySizeCache again into CSSImageGeneratorValue
https://bugs.webkit.org/show_bug.cgi?id=71785
Reviewed by Zoltan Herczeg.
Remove ImageBySizeCache, and fold it into CSSImageGeneratorValue, as it used to be.
CachedImage has switched to SVGImageCache and no longer needs it.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::getImage):
(WebCore::CSSImageGeneratorValue::putImage):
* css/CSSImageGeneratorValue.h:
(WebCore::SizeAndCount::SizeAndCount):
(WebCore::CSSImageGeneratorValue::clients):
* rendering/ImageBySizeCache.cpp: Removed.
* rendering/ImageBySizeCache.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 8 Nov 2011 12:22:13 +0000 (12:22 +0000)]
Web Inspector: Avoid automatic Console suggestions with empty expression
https://bugs.webkit.org/show_bug.cgi?id=71783
Reviewed by Yury Semikhatsky.
* inspector/front-end/ConsoleView.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 8 Nov 2011 12:14:55 +0000 (12:14 +0000)]
[Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
Reviewed by Simon Hausmann.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 8 Nov 2011 12:00:26 +0000 (12:00 +0000)]
[Chromium] Web Inspector: add sanity test for automatic reattach to a page which is reloaded after crash
https://bugs.webkit.org/show_bug.cgi?id=71786
Added a test function that checks if console evaluation works after crashed tab reloading.
Reviewed by Pavel Feldman.
* src/js/Tests.js:
(.TestSuite.prototype.testReattachAfterCrash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Tue, 8 Nov 2011 11:58:16 +0000 (11:58 +0000)]
[Chromium] Unreviewed, trying to update test_expectations.txt for the tests which
started to fail after r99539.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 8 Nov 2011 11:54:55 +0000 (11:54 +0000)]
2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix build, by removing an unused variable.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::isOriginClean):
(WebCore::CanvasRenderingContext2D::createPattern):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 8 Nov 2011 11:46:40 +0000 (11:46 +0000)]
2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
https://bugs.webkit.org/show_bug.cgi?id=71368
Reviewed by Zoltan Herczeg.
When determining whether the canvas would be tainted, we need access to the SVGImage, not its cached BitmapImage.
Otherwhise wrong assumptions are mode, leading to regressions.
Fixes http/tests/security/canvas-remote-read-svg-image.html and related tests on the bots.
* html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::wouldTaintOrigin): Forgot to switch them back to use cachedImage->image().
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::isOriginClean): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 8 Nov 2011 11:30:47 +0000 (11:30 +0000)]
[Qt] Ensure forwarding headers are generated before generating install rules
The install rule for headers depends on qmake being able to walk the list of
headers in the $build_root/include/QtWebKit directory, but this directory is
empty until we've generated the forwarding headers. So we need to make sure
the forwarding headers are generated _before_ we run qmake on the api project
file. This applies to Qt 4.8 only, as Qt 5 will run synqt as part of the
root project file (due to the sync.profile file).
https://bugs.webkit.org/show_bug.cgi?id=71697
Reviewed by Simon Hausmann.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 8 Nov 2011 11:22:27 +0000 (11:22 +0000)]
Web Inspector: Console should be scrolled to bottom when shown for the first time.
https://bugs.webkit.org/show_bug.cgi?id=71781
Reviewed by Pavel Feldman.
* inspector/front-end/ConsoleView.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 8 Nov 2011 09:34:04 +0000 (09:34 +0000)]
[Qt] Merge QtDesktopWebPageProxy and QtTouchWebPageProxy into QtWebPageProxy. https://bugs.webkit.org/show_bug.cgi?id=71355
Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-11-08
Reviewed by Simon Hausmann.
As we try to unify our public API offer we need to merge our double
WebPageProxy implementations first into a common class. That will help
to merge our TouchWebView and DesktopWebView views into one class later.
This commit just merge stuff around and doesn't contain any functional changes.
* Target.pri:
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::init):
* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPagePrivate::paintToCurrentGLContext):
* UIProcess/API/qt/qtouchwebpage.h:
* UIProcess/API/qt/qtouchwebpage_p.h:
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::init):
(QTouchWebViewPrivate::_q_viewportUpdated):
(QTouchWebViewPrivate::_q_viewportTrajectoryVectorChanged):
* UIProcess/API/qt/qtouchwebview_p.h:
* UIProcess/qt/QtDesktopWebPageProxy.cpp: Removed.
* UIProcess/qt/QtDesktopWebPageProxy.h: Removed.
* UIProcess/qt/QtTouchWebPageProxy.cpp: Removed.
* UIProcess/qt/QtTouchWebPageProxy.h: Removed.
* UIProcess/qt/QtWebPageProxy.cpp:
(dragOperationToDropAction):
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::handleEvent):
(QtWebPageProxy::handleMouseMoveEvent):
(QtWebPageProxy::handleMousePressEvent):
(QtWebPageProxy::handleMouseReleaseEvent):
(QtWebPageProxy::handleMouseDoubleClickEvent):
(QtWebPageProxy::handleWheelEvent):
(QtWebPageProxy::handleHoverLeaveEvent):
(QtWebPageProxy::handleHoverMoveEvent):
(QtWebPageProxy::handleDragEnterEvent):
(QtWebPageProxy::handleDragLeaveEvent):
(QtWebPageProxy::handleDragMoveEvent):
(QtWebPageProxy::handleDropEvent):
(QtWebPageProxy::timerEvent):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::didReceiveDownloadResponse):
(QtWebPageProxy::paintContent):
(QtWebPageProxy::createDrawingAreaProxy):
(QtWebPageProxy::renderToCurrentGLContext):
(QtWebPageProxy::doneWithTouchEvent):
(QtWebPageProxy::setVisibleContentRectAndScale):
(QtWebPageProxy::setVisibleContentRectTrajectoryVector):
(QtWebPageProxy::touchEvent):
(QtWebPageProxy::findZoomableAreaForPoint):
* UIProcess/qt/QtWebPageProxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 8 Nov 2011 09:32:52 +0000 (09:32 +0000)]
2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
https://bugs.webkit.org/show_bug.cgi?id=71368
Reviewed by Antti Koivisto.
Add some layout tests covering repainting of embedded SVG documents triggered by SMIL animations.
* platform/chromium/test_expectations.txt: Fix test expectations, as described in bug 71226.
* platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
* platform/mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
* platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
* platform/mac/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
* svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html: Added.
* svg/as-image/animated-svg-as-image-same-image.html: Added.
* svg/as-image/resources/animated-rect-same-image.svg: Copied from LayoutTests/svg/as-image/resources/animated-rect-fixed-size.svg.
* svg/zoom/page/zoom-coords-viewattr-01-b.svg: Add comment, why scrollbars shouldn't appear anymore here.
2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
https://bugs.webkit.org/show_bug.cgi?id=71368
Reviewed by Antti Koivisto.
Fix regressions/races introduced by r98852. SVGImage repainting didn't work under certain circumstances.
The problem was hard to reproduce on Mac ports, but easily visible on Chromium, when opening two files
that shared the same animated SVG image. The problem of sharing a single ImageObserver across multiple
instances of the same SVGImage, leads to nasty problems, that are timing dependant. changedInRect() calls
that should only by received in one document, are received in the other as well, due the shared nature
of CachedImage. To avoid these problems alltogether, a new approach is needed, that was initially suggested
by Antti.
Avoid creating multiple SVGImages and caching them for different sizes/zoom levels. Introduce SVGImageCache
which holds rendered versions of the SVGImage at certain sizes/zoom levels. It holds (ImageBuffer, Image) pairs
for each renderer, associated with a size and zoom level.
This is a major change to the cache as introduced some weeks ago. Instead of holding multiple SVGImages, each containing
a whole DOM/render tree, we now create bitmap images rendered at the requested sizes/zoom levels and cache them.
Revert ImageBySizeCache changes that were needed to make it usable wih SVGImage. Its now used only in CSSImageGeneratorValue and
thus the extra information that CSSImageGeneratorValue doesn't need can be removed again (desired/actual size differentations, and the zoom level).
Tests: svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html
svg/as-image/animated-svg-as-image-same-image.html
* CMakeLists.txt: Add svg/graphics/SVGImageCache.* to build.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from svg/graphics, as SVGImageCache is needed by CachedImage in SVG enabled builds.
* WebCore.xcodeproj/project.pbxproj: Add svg/graphics/SVGImageCache.* to build.
* css/CSSImageGeneratorValue.cpp: Remove zoom parameter from addClient/getImage, no need to pass 1 default values anymore.
(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::getImage):
* loader/cache/CachedImage.cpp: Stop using ImageBySizeCache, and switch to the new SVGImageCache.
(WebCore::CachedImage::removeClientForRenderer):
(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::createImage):
(WebCore::CachedImage::destroyDecodedData):
(WebCore::CachedImage::decodedSizeChanged):
(WebCore::CachedImage::didDraw):
(WebCore::CachedImage::shouldPauseAnimation):
(WebCore::CachedImage::animationAdvanced):
(WebCore::CachedImage::changedInRect):
* loader/cache/CachedImage.h:
* page/DragController.cpp: Stop using imageForRenderer(), as it may return cached BitmapImages, that don't carry a filename extension anymore, which is required here.
(WebCore::getImage):
* rendering/ImageBySizeCache.cpp: Revert changes to ImageBySizeCache, which were needed to make it usable for SVGImages. CSSImageGenerator doesn't need it.
(WebCore::ImageBySizeCache::addClient):
(WebCore::ImageBySizeCache::removeClient):
(WebCore::ImageBySizeCache::getImage):
* rendering/ImageBySizeCache.h: Ditto.
(WebCore::SizeAndCount::SizeAndCount):
* rendering/RenderImage.cpp: Stop using imageForRenderer(), use cachedImage()->image(), which is guaranteed to be a SVGImage for svg images, and not a cached bitmap copy.
(WebCore::RenderImage::embeddedContentBox):
* rendering/RenderReplaced.cpp: Simplify logic to figure out the intrinsic size - the special logic for the old SVGImage cache can go away now.
(WebCore::RenderReplaced::computeIntrinsicLogicalWidth):
(WebCore::RenderReplaced::computeIntrinsicLogicalHeight):
* rendering/style/StyleCachedImage.cpp: Call removeClientForRenderer(), which takes care of clearing SVGImageCache entries as well.
(WebCore::StyleCachedImage::removeClient): This change is needed, as we don't want to make removeClient() virtual in CachedResource.
* rendering/svg/RenderSVGRoot.cpp: Rename isEmbeddedThroughImageElement to isEmbeddedThroughSVGImage, as this is what it actually checks.
(WebCore::RenderSVGRoot::isEmbeddedThroughSVGImage):
* rendering/svg/RenderSVGRoot.h:
* svg/SVGSVGElement.cpp: Fix bug that's visible now with the SVGImageCache, which was already there before, but hard to trigger.
(WebCore::SVGSVGElement::currentViewBoxRect): The viewBox depends on who's asking for it: the host document or the embedded document? Take that into account.
* svg/SVGSVGElement.h:
* svg/graphics/SVGImage.cpp: Cleanup some code. Add new logic that draws a SVGImage into an ImageBuffer at a desired size & zoom.
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::size):
(WebCore::SVGImage::drawSVGToImageBuffer):
* svg/graphics/SVGImage.h:
* svg/graphics/SVGImageCache.cpp: Added. SVGImageCache caches Image/ImageBuffer pairs for each _renderer_ and size/zoom level. The ImageBySizeCache only cared about size.
(WebCore::SVGImageCache::SVGImageCache):
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeRendererFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndZoom):
(WebCore::SVGImageCache::getRequestedSizeAndZoom):
(WebCore::SVGImageCache::imageContentChanged):
(WebCore::SVGImageCache::redrawTimerFired):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):
* svg/graphics/SVGImageCache.h: Added.
(WebCore::SVGImageCache::create):
(WebCore::SVGImageCache::CachedSizeAndZoom::CachedSizeAndZoom):
(WebCore::SVGImageCache::CachedImageData::CachedImageData):
2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
Switch SVGImage cache to store ImageBuffers instead of whole SVGImages, including a DOM/Render tree
https://bugs.webkit.org/show_bug.cgi?id=71368
Reviewed by Antti Koivisto.
* CMakeLists.txt: Add svg/graphics include, for SVGImageCache.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 8 Nov 2011 09:13:04 +0000 (09:13 +0000)]
Unreviewed, skip flaky crasher on GTK.
* platform/gtk/Skipped: Skip fast/css/webkit-mask-crash-fieldset-legend.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Nov 2011 09:07:29 +0000 (09:07 +0000)]
[WK2][GTK] Application cache directory is incorrectly set
https://bugs.webkit.org/show_bug.cgi?id=70680
Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-11-08
Reviewed by Philippe Normand.
Correctly set application cache directory to be in current
user's default cache directory.
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::applicationCacheDirectory):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 8 Nov 2011 09:04:45 +0000 (09:04 +0000)]
[Qt] Some tests are flaky with NRWT
https://bugs.webkit.org/show_bug.cgi?id=64002
There can be found the skipped tests:
https://bugs.webkit.org/show_bug.cgi?id=71693
https://bugs.webkit.org/show_bug.cgi?id=71695
These 2 tests caused 7 tests timeouting.
Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2011-11-08
Reviewed by Csaba Osztrogonác.
* platform/qt/Skipped: Skip culprit tests
- http/tests/notifications/icon-does-not-exist.html
- http/tests/xmlhttprequest/workers/abort-exception-assert.html
* platform/qt/test_expectations.txt: Unskip passing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 8 Nov 2011 09:01:39 +0000 (09:01 +0000)]
[Qt] Removing qwebkitglobal.h inclusion from qwebkitplatformplugin.h
https://bugs.webkit.org/show_bug.cgi?id=71759
Patch by Luiz Agostini <luiz.agostini@palm.com> on 2011-11-08
Reviewed by Simon Hausmann.
qwebkitplatformplugin.h must not depend on qwebkitglobal.h.
* Api/qwebkitplatformplugin.h:
Updating the copy of qwebkitplatformplugin.h that is used by the example plugin. The previous
one was very outdated.
* examples/platformplugin/qwebkitplatformplugin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 8 Nov 2011 08:57:20 +0000 (08:57 +0000)]
[Qt] Unreivewed gardening. Reset test results.
Patch by Fehér Zsolt <feherzs@inf.u-szeged.hu> on 2011-11-08
* platform/qt-5.0/fast/css/child-style-can-override-visited-style-expected.txt: Added.
* platform/qt-5.0/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
* platform/qt-5.0/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
* platform/qt-5.0/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
* platform/qt-5.0/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
* platform/qt-5.0/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
* platform/qt-5.0/svg/as-image/same-image-two-instances-expected.txt: Added.
* platform/qt-5.0/svg/as-image/svg-image-change-content-size-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 8 Nov 2011 08:55:51 +0000 (08:55 +0000)]
Web Inspector: refactor shortcuts and settings screens
https://bugs.webkit.org/show_bug.cgi?id=71773
Keep pointer to the visible screen and hide it automatically when new one is going
to be displayed.
Reviewed by Pavel Feldman.
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype.hide):
* inspector/front-end/ShortcutsScreen.js:
(WebInspector.ShortcutsScreen): ShortcutsScreen is now a descendant of HelpScreen.
(WebInspector.ShortcutsScreen.prototype.show):
* inspector/front-end/inspector.js:
(WebInspector._hideSettingsScreen):
(WebInspector.documentKeyDown):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuqiang.xian@intel.com [Tue, 8 Nov 2011 08:52:25 +0000 (08:52 +0000)]
DFG 32_64 - update make lists for efl, gtk, and Qt ports with DFG change r99519
https://bugs.webkit.org/show_bug.cgi?id=71768
Reviewed by Geoffrey Garen.
Also includes a fix to make the newly introduced AssemblyHelpers
friend of JSValue as we need the Tag definitions.
* CMakeListsEfl.txt:
* GNUmakefile.list.am:
* Target.pri:
* runtime/JSValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 8 Nov 2011 08:52:25 +0000 (08:52 +0000)]
Unreviewed, mark 2 tests flaky in GTK.
* platform/gtk/test_expectations.txt:
fast/forms/password-placeholder-text-security.html and
fast/lists/inlineBoxWrapperNullCheck.html are flaky.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 8 Nov 2011 08:43:25 +0000 (08:43 +0000)]
2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix Snow Leopard 32bit builds.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseAspectRatio): CSSParserValue::fValue is a double, use narrowPrecisionToFloat() to convert double->float.
* platform/ClockGeneric.cpp: Remove unneeded variable out of 32bit integer value range.
* webaudio/BiquadDSPKernel.cpp:
(WebCore::BiquadDSPKernel::getFrequencyResponse): Use narrowPrecisionTofloat() to convert double->float.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Tue, 8 Nov 2011 08:14:55 +0000 (08:14 +0000)]
[Chromium] Unreviewed gardening.
Rebaseline tests after r99454. Mark one SVG test as flaky.
* platform/chromium-cg-mac-snowleopard/fast/borders/outline-alpha-block-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/borders/outline-alpha-block-expected.png.
* platform/chromium-mac-leopard/fast/borders/outline-alpha-block-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/outline-alpha-block-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-radius-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/layers/self-painting-outline-expected.png: Added.
* platform/chromium-mac/fast/borders/outline-alpha-block-expected.png: Removed.
* platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png: Removed.
* platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-win/fast/layers/self-painting-outline-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 8 Nov 2011 08:10:27 +0000 (08:10 +0000)]
Touch the pro file to trigger a proper (re)build of the Makefile on
the bot (removed redundant line)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 8 Nov 2011 07:49:53 +0000 (07:49 +0000)]
[Qt][WK2] MiniBrowser should use urlFromUserInput()
https://bugs.webkit.org/show_bug.cgi?id=71680
Use urlFromUserInput() / QUrl::fromUserInput() to automatically
complete urls in MiniBrowser.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-11-07
Reviewed by Tor Arne Vestbø.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::load):
* MiniBrowser/qt/qml/BrowserWindow.qml:
* MiniBrowser/qt/utils.cpp:
(Utils::urlFromUserInput):
* MiniBrowser/qt/utils.h:
(Utils::Utils):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuqiang.xian@intel.com [Tue, 8 Nov 2011 07:32:44 +0000 (07:32 +0000)]
Added myself as a committer.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuqiang.xian@intel.com [Tue, 8 Nov 2011 06:51:43 +0000 (06:51 +0000)]
Fix gcc 4.4 compilation warnings in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=71762
Reviewed by Filip Pizlo.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::registersMatched):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log