alp@webkit.org [Fri, 7 Dec 2007 11:47:32 +0000 (11:47 +0000)]
2007-12-07 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16333
[GTK] Key bindings must work with focused frames.
There are still more cases where getFrameFromView() is mis-used that
need to be fixed, but this is a good start.
* WebView/webkitwebview.cpp:
(webkit_web_view_real_select_all):
(webkit_web_view_real_cut_clipboard):
(webkit_web_view_real_copy_clipboard):
(webkit_web_view_real_paste_clipboard):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 7 Dec 2007 10:17:08 +0000 (10:17 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16325
<rdar://problem/
5632997> REGRESSION: www.xerox.ru doesn't work
Test: http/tests/misc/empty-cookie.html
* platform/mac/CookieJar.mm:
(WebCore::setCookies): Don't store empty cookies.
(WebCore::cookies): Filter out empty cookies if we have them, as they could have been set
with an earlier version of Leopard!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Fri, 7 Dec 2007 07:27:40 +0000 (07:27 +0000)]
Fixed the if statement (ERROR_SUCCESS is 0 and we were actually
returning true when there's an error).
Reviewed by Steve.
* platform/win/FileSystemWin.cpp:
(WebCore::makeAllDirectories):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 7 Dec 2007 07:02:16 +0000 (07:02 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16091
JSCRE needs to import the PCRE test suite
We can use two files from PCRE test suite, as others either test for features not supported
in JS, or use internal debugging facilities of PCRE.
The files are checked in almost unmodified, I have only converted them to UTF-8 and removed two
huge test cases that were completely incompatible with JSC, and were polluting the output.
Many of the failures in results are just legitimate differences in behavior or possibly
problems with the test runner, but some may be genuine bugs and even regressions in JSC.
* fast/regex: Added.
* fast/regex/pcre-test-runner.js: Added.
* fast/regex/test1-expected.txt: Added.
* fast/regex/test1.html: Added.
* fast/regex/test4-expected.txt: Added.
* fast/regex/test4.html: Added.
* fast/regex/testinput1: Added.
* fast/regex/testinput4: Added.
* fast/regex/testoutput1: Added.
* fast/regex/testoutput4: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 7 Dec 2007 06:17:55 +0000 (06:17 +0000)]
Reviewed by Oliver's rubber stamp
Let's go ahead and call the correct UI Delegate method, shall we?
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Call the correct UI delegate
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Fri, 7 Dec 2007 05:33:45 +0000 (05:33 +0000)]
Linux build fix - ensure that webcore is linked before jscore so that the linker will know which symbols it needs to link in. Also fix MSVC project file name typo for sample app.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 7 Dec 2007 03:59:52 +0000 (03:59 +0000)]
- fix broken regression test
* bindings/js/kjs_binding.cpp:
(KJS::setDOMException): Oops, this was just supposed to be PERMISSION_DENIED.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 7 Dec 2007 03:18:21 +0000 (03:18 +0000)]
Reviewed by Sam Weinig.
- fix http://bugs.webkit.org/show_bug.cgi?id=16332
ObjC DOM exception object descriptions should include the exception name
* WebCore.pro: Added ExceptionCode.cpp.
* WebCore.vcproj/WebCore.vcproj: Added ExceptionCode.cpp.
* WebCore.xcodeproj/project.pbxproj: Added ExceptionCode.cpp.
* WebCoreSources.bkl: Added ExceptionCode.cpp.
* bindings/js/kjs_binding.cpp: (KJS::setDOMException): Moved the code to decompose an
ExceptionCode into ExceptionCode.h/cpp -- getExceptionCodeDescription. Also removed
the many unneeded includes that were here. Had to keep one special case here, for
SECURITY_ERR.
* bindings/objc/ExceptionHandlers.mm: (WebCore::raiseDOMException): Changed to use the
new getExceptionCodeDescription function so that this shares the exception name
information that was previously only available to JavaScript.
* dom/ExceptionCode.cpp: Copied from bindings/js/kjs_binding.cpp.
(WebCore::getExceptionCodeDescription): Added some assertions, and made the function
handle exception names in a slightly more robust way that is not subject to integer
overflow. (Not a real world issue since we should never receive a bad exception code.)
* dom/ExceptionCode.h: Added the ExceptionCodeDescription struct and the
getExceptionCodeDescription function.
* svg/SVGException.h: Added a missing #include and got rid of some comments. Some of
the comments were mildly helpful, but others were incorrect. This now matches the other
exception-related headers such as RangeException.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 7 Dec 2007 02:49:48 +0000 (02:49 +0000)]
Reviewed by Darin
Fixed a glaring bug that would prevent a statement from getting run a second time
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::execute): Clear failure due to quota *before* we check the error
and return early
(WebCore::SQLStatement::clearFailureDueToQuota): Only clear the error if it was a quota error
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 7 Dec 2007 02:10:13 +0000 (02:10 +0000)]
Reviewed by Oliver Hunt.
Use keydown instead of keypress so keyIdentifier can be used.
* page/inspector/ConsolePanel.js: Use keydown instead of keypress.
* page/inspector/DatabasePanel.js: Ditto.
* page/inspector/inspector.js: Ditto. Plus call removeEventListener
before deleting windowLoaded.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 7 Dec 2007 02:05:16 +0000 (02:05 +0000)]
Rename FontsTable.plist to FontsList.plist
Rubberstamped by Hyatt.
* platform/graphics/win/FontDatabase.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Fri, 7 Dec 2007 02:00:27 +0000 (02:00 +0000)]
Fixed <rdar://
5540000> onbeforeunload doesn't fire when closing window/tab
Reviewed by Darin.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::shouldClose):
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 7 Dec 2007 01:51:04 +0000 (01:51 +0000)]
Reviewed by Darin
Tweaked a comment and a few assertions from my last checkin
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::execute):
(WebCore::SQLStatement::clearFailureDueToQuota):
(WebCore::SQLStatement::lastExecutionFailedDueToQuota):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 7 Dec 2007 01:04:43 +0000 (01:04 +0000)]
Fix <rdar://
5615283> Crash in WebFrame::receivedPolicyDecision
WebKit/mac:
Remove some assertions we know can fire and replace them with a FIXME
Reviewed by Anders.
* WebCoreSupport/WebFrameLoaderClient.mm:
WebKit/win:
Fix <rdar://
5615283> Crash in WebFrame::receivedPolicyDecision
It's possible for a second policy listener to be created while we're
waiting for a decision on the first policy listener. In this case we
would crash when the first policy listener had a decision made. Mac
WebKit already handles this by invalidating any existing policy
listener when creating a new one.
A test case is coming in a future commit.
Reviewed by Anders.
* WebFrame.cpp:
(WebFrame::setUpPolicyListener): Copy the Mac behavior of invalidating
any existing policy listener, and remove some assertions that we know
can fire.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 7 Dec 2007 00:50:32 +0000 (00:50 +0000)]
Reviewed by Darin
Finished hooking up UI Delegate for databases - Database operations will now enforce a size quota and
will ask the UI Delegate for more space when that quota is met
* platform/sql/SQLiteDatabase.cpp: Add the new SQLResultFull constant
* platform/sql/SQLiteDatabase.h: Ditto
* storage/Database.cpp:
(WebCore::Database::securityOriginData): Added this accessor, copying for thread safety
(WebCore::Database::stringIdentifier): Ditto
* storage/Database.h:
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::SQLStatement):
(WebCore::SQLStatement::execute): Change to return an enum that represents 3 states - success, error, and quota.
If the result is quota, this statement expects that it might be run again, presumably after the user increases
the quota
(WebCore::SQLStatement::setFailureDueToQuota): Setup a quota failure, including a flag and the error
(WebCore::SQLStatement::clearFailureDueToQuota): Clear a quota failure, for when the statement is rerun
(WebCore::SQLStatement::lastExecutionFailedDueToQuota):
* storage/SQLStatement.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::performPendingCallback): Added an acceptable callback pointer
(WebCore::SQLTransaction::openTransactionAndPreflight): Setup the quota in the database that will remain for this
transaction. Note that in this patch, the quota being set is wrong - it makes sense to fix that in a follow up patch
(WebCore::SQLTransaction::runStatements): Modified to add the ability to re-run a statement based on the UI delegate
decision and whether the current statement was already run
(WebCore::SQLTransaction::runCurrentStatement): Added another result condition - the Quota result - and handle it
(WebCore::SQLTransaction::handleCurrentStatementError): Statements can now error-out from two places, so the code
that handles a statement error was moved here
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback): Added - Consult the UI delegate for more quota, then
reschedule the current statement on the database thread
* storage/SQLTransaction.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Thu, 6 Dec 2007 23:32:45 +0000 (23:32 +0000)]
Change the ASSERT added for the previous fix. The ASSERT was firing for 10.5.0.
Only assert if the major version is zero, since zero is handled in the other cases.
* WebView/WebView.mm:
(callGestalt): Remove the ASSERT.
(createMacOSXVersionString): ASSERT that major is not zero.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 6 Dec 2007 23:31:46 +0000 (23:31 +0000)]
<rdar://problem/
5614257> Crash in timer / hashtable code due to uncaught exception
Don't use callback-based timers, since these cause Windows to eat Windows crashes
in code the timers call.
Windows appears to be defending against "shatter" attacks partially by setting
up a structured exception block while dispatching callback-based WM_TIMERs.
I verified this by adding a divide by zero into some timer callback code.
In the case where the timer was dispatched via a callback, the divide by zero
exception was silently handled and ignored, with execution continuing after
our call to DispatchMessage. When processed via the WNDPROC, no SEH
block was established by Windows, and our divide by zero generated a real
crash (which is what we wanted).
Windows handling our crashes for us led us to leave the timer data structures
in an invalid state so the next time a timer was set, we'd crash accessing an
invalid HashMap of timer data.
Reviewed by Hyatt.
* platform/win/SharedTimerWin.cpp:
(WebCore::TimerWindowWndProc):
(WebCore::setSharedTimerFireTime):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 6 Dec 2007 22:36:10 +0000 (22:36 +0000)]
Reviewed by Tim Hatcher.
- fix <rdar://problem/
5513394> No way to detect Tiger vs Leopard from Safari's user agent string
* WebView/WebView.mm:
(callGestalt): Added.
(createMacOSXVersionString): Added.
(-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Added Mac OS X version string,
right after the string "Mac OS X", but with underscores instead of dots to avoid the dreaded
"4." problem (old libraries that think a "4." anywhere in the user agent means Netscape 4).
(-[WebView _userAgentForURL:]): Fixed incorrect bug numbers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 6 Dec 2007 22:11:37 +0000 (22:11 +0000)]
Fix <rdar://
5108390> Feed title is too low in blue banner
WebCore:
Fix <rdar://
5108390> Feed title is too low in blue banner
Way back in r23069 we started applying the same font ascent hack that
Mac WebKit applies to Helvetica, Times, and Courier. We did this so
that those fonts would match the Mac metrics when we run the
regression tests. However, this hack was applying to Arial on Windows
when a site would specify the Helvetica font face because Windows will
alias the font names. Instead of removing the hack entirely, we
turn it off by default but provide some SPI so that DumpRenderTree can
turn it on.
Reviewed by Hyatt.
All tests pass.
* platform/graphics/FontData.h: Add a new static method to turn on the
hack on Windows only.
* platform/graphics/win/FontDataWin.cpp:
(WebCore::FontData::setShouldApplyMacAscentHack): Added.
(WebCore::FontData::platformInit): Only perform the hack if
shouldApplyMacAscentHack is true.
WebKit/win:
Add SPI so that DumpRenderTree can turn on the Mac font ascent hack
Reviewed by Hyatt.
* Interfaces/IWebViewPrivate.idl: Added new method declaration.
* WebView.cpp:
(WebView::setShouldApplyMacFontAscentHack): Added. Just calls down to
FontData.
* WebView.h:
WebKitTools:
Explicitly turn on the Mac font ascent hack on Windows
This keeps our font metrics matching those from Mac.
Reviewed by Hyatt.
* DumpRenderTree/win/DumpRenderTree.cpp:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 6 Dec 2007 21:25:53 +0000 (21:25 +0000)]
- updated render tree results for r28483
* svg/batik/text/textEffect2-expected.txt:
* svg/batik/text/textProperties-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 21:19:07 +0000 (21:19 +0000)]
WebCore:
Reviewed by Sam Weinig.
Fixed http://bugs.webkit.org/show_bug.cgi?id=16328
REGRESSION (r28470): Crash expanding a GMail conversation
* page/Frame.cpp:
(WebCore::Frame::scriptProxy): Only return 0 if JS seems disabled *and*
we haven't created the proxy yet. If we've created the proxy already, a
script may be in the midst of execution, even though we've lost our
settings object. During execution, scripts assume they have free access
to the proxy.
LayoutTests:
Reviewed by Sam Weinig.
Test for http://bugs.webkit.org/show_bug.cgi?id=16328
REGRESSION (r28470): Crash expanding a GMail conversation
* fast/frames/location-put-after-removal.html: Added.
* fast/frames/resources/location-put-after-removal-frame.html: Added.
* fast/frames/resources/location-put-after-removal-frame-expected.txt: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 6 Dec 2007 21:17:05 +0000 (21:17 +0000)]
Rename main.c to main.cpp here too.
* DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 6 Dec 2007 21:10:47 +0000 (21:10 +0000)]
Rubber stamped by Geoff.
* Scripts/do-webcore-rename: Don't rename kjs_css twice.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 6 Dec 2007 21:00:21 +0000 (21:00 +0000)]
* Scripts/do-webcore-rename: Some more renaming plans.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 6 Dec 2007 20:37:53 +0000 (20:37 +0000)]
Remove implementation of testGetIntIdentifier that was accidentally
removed somehow (possibly when I made PluginObject be a cpp file).
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginInvoke):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 6 Dec 2007 20:24:52 +0000 (20:24 +0000)]
JavaScriptCore:
Reviewed by Eric Seidel.
- fix http://bugs.webkit.org/show_bug.cgi?id=16321
new RegExp("[\u0097]{4,6}", "gmy") crashes in DEBUG builds
<rdar://problem/
5632992>
Test: fast/js/regexp-oveflow.html
* pcre/pcre_compile.cpp:
(calculateCompiledPatternLengthAndFlags): In the case where a single character
character class is optimized to not use a character class at all, the preflight
code was not setting the lastitemlength variable.
LayoutTests:
Reviewed by Eric Seidel.
- fix http://bugs.webkit.org/show_bug.cgi?id=16321
new RegExp("[\u0097]{4,6}", "gmy") crashes in DEBUG builds
<rdar://problem/
5632992>
* fast/js/regexp-overflow-expected.txt: Updated.
* fast/js/resources/regexp-overflow.js: Added test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 6 Dec 2007 20:11:04 +0000 (20:11 +0000)]
2007-12-06 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16329
[GTK] Two small cleanups
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::createWindow):
(WebKit::ChromeClient::addMessageToConsole):
(WebKit::ChromeClient::runJavaScriptAlert):
(WebKit::ChromeClient::runJavaScriptConfirm):
(WebKit::ChromeClient::runJavaScriptPrompt):
(WebKit::ChromeClient::setStatusbarText):
(WebKit::ChromeClient::mouseDidMoveOverElement):
(WebKit::ChromeClient::setToolTip):
* WebCoreSupport/ChromeClientGtk.h:
* WebView/webkitprivate.cpp:
(WebKit::kit):
s/m_webPage/m_webView/
* WebView/webkitwebview.cpp:
Chain up to the parent class to activate bindings instead
of doing it explicitely.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Thu, 6 Dec 2007 20:02:21 +0000 (20:02 +0000)]
WebCore:
Reviewed by Oliver.
Fix for <rdar://problem/
5631356> Toggling display property on video causes controls to get lost
* html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attach): Call updateFromElement.
* html/HTMLMediaElement.h:
LayoutTests:
Reviewed by Oliver.
Fix <rdar://problem/
5631356> Toggling display property on video causes controls to get lost
* media/video-display-toggle.html: Added.
* platform/mac/media/video-display-toggle-expected.checksum: Added.
* platform/mac/media/video-display-toggle-expected.png: Added.
* platform/mac/media/video-display-toggle-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Thu, 6 Dec 2007 19:33:04 +0000 (19:33 +0000)]
Build fix.
Reviewed by Geoff.
* WebScriptCallFrame.cpp:
(WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 6 Dec 2007 18:46:23 +0000 (18:46 +0000)]
Reviewed by Oliver.
Rename
Movie -> MediaPlayer
MoviePrivate -> MediaPlayerPrivate
Movie is QuickTime terminology and clashes with its C API.
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::initAndDispatchProgressEvent):
(WebCore::HTMLMediaElement::bufferingRate):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
(WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::currentTime):
(WebCore::HTMLMediaElement::duration):
(WebCore::HTMLMediaElement::playbackRate):
(WebCore::HTMLMediaElement::setPlaybackRate):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::pickMedia):
(WebCore::HTMLMediaElement::checkIfSeekNeeded):
(WebCore::HTMLMediaElement::mediaPlayerVolumeChanged):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::mediaPlayerCuePointReached):
(WebCore::HTMLMediaElement::addCuePoint):
(WebCore::HTMLMediaElement::buffered):
(WebCore::HTMLMediaElement::seekable):
(WebCore::HTMLMediaElement::effectiveStart):
(WebCore::HTMLMediaElement::effectiveEnd):
(WebCore::HTMLMediaElement::effectiveLoopStart):
(WebCore::HTMLMediaElement::effectiveLoopEnd):
(WebCore::HTMLMediaElement::updateMediaPlayer):
(WebCore::HTMLMediaElement::willSaveToCache):
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::player):
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::videoWidth):
(WebCore::HTMLVideoElement::videoHeight):
* platform/MIMETypeRegistry.cpp:
(WebCore::initialiseSupportedMediaMIMETypes):
(WebCore::MIMETypeRegistry::isSupportedMediaMIMEType):
(WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
* platform/MIMETypeRegistry.h:
* platform/graphics/MediaPlayer.cpp: Copied from WebCore/platform/graphics/Movie.cpp.
(WebCore::MediaPlayer::MediaPlayer):
(WebCore::MediaPlayer::~MediaPlayer):
(WebCore::MediaPlayer::load):
(WebCore::MediaPlayer::cancelLoad):
(WebCore::MediaPlayer::play):
(WebCore::MediaPlayer::pause):
(WebCore::MediaPlayer::duration):
(WebCore::MediaPlayer::currentTime):
(WebCore::MediaPlayer::seek):
(WebCore::MediaPlayer::paused):
(WebCore::MediaPlayer::seeking):
(WebCore::MediaPlayer::naturalSize):
(WebCore::MediaPlayer::hasVideo):
(WebCore::MediaPlayer::networkState):
(WebCore::MediaPlayer::readyState):
(WebCore::MediaPlayer::volume):
(WebCore::MediaPlayer::setVolume):
(WebCore::MediaPlayer::rate):
(WebCore::MediaPlayer::setRate):
(WebCore::MediaPlayer::muted):
(WebCore::MediaPlayer::setMuted):
(WebCore::MediaPlayer::dataRate):
(WebCore::MediaPlayer::setEndTime):
(WebCore::MediaPlayer::addCuePoint):
(WebCore::MediaPlayer::removeCuePoint):
(WebCore::MediaPlayer::clearCuePoints):
(WebCore::MediaPlayer::maxTimeBuffered):
(WebCore::MediaPlayer::maxTimeSeekable):
(WebCore::MediaPlayer::bytesLoaded):
(WebCore::MediaPlayer::totalBytesKnown):
(WebCore::MediaPlayer::totalBytes):
(WebCore::MediaPlayer::setRect):
(WebCore::MediaPlayer::visible):
(WebCore::MediaPlayer::setVisible):
(WebCore::MediaPlayer::paint):
(WebCore::MediaPlayer::getSupportedTypes):
(WebCore::MediaPlayer::networkStateChanged):
(WebCore::MediaPlayer::readyStateChanged):
(WebCore::MediaPlayer::volumeChanged):
(WebCore::MediaPlayer::timeChanged):
(WebCore::MediaPlayer::cuePointReached):
* platform/graphics/MediaPlayer.h: Copied from WebCore/platform/graphics/Movie.h.
(WebCore::MediaPlayerClient::~MediaPlayerClient):
(WebCore::MediaPlayerClient::mediaPlayerNetworkStateChanged):
(WebCore::MediaPlayerClient::mediaPlayerReadyStateChanged):
(WebCore::MediaPlayerClient::mediaPlayerVolumeChanged):
(WebCore::MediaPlayerClient::mediaPlayerTimeChanged):
(WebCore::MediaPlayerClient::mediaPlayerCuePointReached):
* platform/graphics/Movie.cpp: Removed.
* platform/graphics/Movie.h: Removed.
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Copied from WebCore/platform/graphics/gtk/MoviePrivateGStreamer.cpp.
(WebCore::mediaPlayerPrivateErrorCallback):
(WebCore::mediaPlayerPrivateEOSCallback):
(WebCore::mediaPlayerPrivateStateCallback):
(WebCore::mediaPlayerPrivateBufferingCallback):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::setEndTime):
(WebCore::MediaPlayerPrivate::addCuePoint):
(WebCore::MediaPlayerPrivate::removeCuePoint):
(WebCore::MediaPlayerPrivate::clearCuePoints):
(WebCore::MediaPlayerPrivate::startCuePointTimerIfNeeded):
(WebCore::MediaPlayerPrivate::cancelSeek):
(WebCore::MediaPlayerPrivate::cuePointTimerFired):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::dataRate):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::maxTimeBuffered):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::maxTimeLoaded):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::totalBytesKnown):
(WebCore::MediaPlayerPrivate::totalBytes):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::loadStateChanged):
(WebCore::MediaPlayerPrivate::rateChanged):
(WebCore::MediaPlayerPrivate::sizeChanged):
(WebCore::MediaPlayerPrivate::timeChanged):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::didEnd):
(WebCore::MediaPlayerPrivate::loadingFailed):
(WebCore::MediaPlayerPrivate::setRect):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::createGSTPlayBin):
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: Copied from WebCore/platform/graphics/gtk/MoviePrivateGStreamer.h.
* platform/graphics/gtk/MoviePrivateGStreamer.cpp: Removed.
* platform/graphics/gtk/MoviePrivateGStreamer.h: Removed.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h: Copied from WebCore/platform/graphics/mac/MoviePrivateQTKit.h.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Copied from WebCore/platform/graphics/mac/MoviePrivateQTKit.mm.
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::createQTMovie):
(WebCore::MediaPlayerPrivate::createQTMovieView):
(WebCore::MediaPlayerPrivate::createQTTime):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::doSeek):
(WebCore::MediaPlayerPrivate::cancelSeek):
(WebCore::MediaPlayerPrivate::seekTimerFired):
(WebCore::MediaPlayerPrivate::setEndTime):
(WebCore::MediaPlayerPrivate::addCuePoint):
(WebCore::MediaPlayerPrivate::removeCuePoint):
(WebCore::MediaPlayerPrivate::clearCuePoints):
(WebCore::MediaPlayerPrivate::startCuePointTimerIfNeeded):
(WebCore::MediaPlayerPrivate::cuePointTimerFired):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::dataRate):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::maxTimeBuffered):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::maxTimeLoaded):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::totalBytesKnown):
(WebCore::MediaPlayerPrivate::totalBytes):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::loadStateChanged):
(WebCore::MediaPlayerPrivate::rateChanged):
(WebCore::MediaPlayerPrivate::sizeChanged):
(WebCore::MediaPlayerPrivate::timeChanged):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::didEnd):
(WebCore::MediaPlayerPrivate::setRect):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(-[WebCoreMovieObserver initWithCallback:WebCore::]):
* platform/graphics/mac/MoviePrivateQTKit.h: Removed.
* platform/graphics/mac/MoviePrivateQTKit.mm: Removed.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::player):
* rendering/RenderMedia.h:
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::RenderVideo):
(WebCore::RenderVideo::~RenderVideo):
(WebCore::RenderVideo::videoSizeChanged):
(WebCore::RenderVideo::paintReplaced):
(WebCore::RenderVideo::layout):
(WebCore::RenderVideo::updateFromElement):
(WebCore::RenderVideo::updatePlayer):
* rendering/RenderVideo.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 18:01:20 +0000 (18:01 +0000)]
Build fix: access global object directly.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::bindingInstance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 6 Dec 2007 12:20:55 +0000 (12:20 +0000)]
Fix bug spotted by GCC 4.2. Remove extraneous semicolon that completely changed the meaning of allowPopUp.
Reviewed by Eric.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 6 Dec 2007 09:26:50 +0000 (09:26 +0000)]
2007-12-06 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16173
Licensing change
Change license from BSD to LGPL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Thu, 6 Dec 2007 07:40:57 +0000 (07:40 +0000)]
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=15289
WebKit does not respect clip paths of a 0x0 rect
Make empty clip paths clip the whole referencing graphic.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 6 Dec 2007 06:25:24 +0000 (06:25 +0000)]
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=16266
<rdar://problem/
5625279> REGRESSION: crash loading CNN.com at
Interpreter::createObjectsForGlobalObjectProperties()
I don't know how to reproduce this in a test.
* bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark):
Call JSEventTargetNode::mark instead of DOMObject::mark. There's no difference
right now, but it's best to call your base class, not your base's base.
* bindings/js/kjs_events.h: Removed unneeded virtual from the
JSUnprotectedEventListener::mark() function; it neither derives from or is
derived from anyone else with a mark() function so there's no need for virtual.
* bindings/js/kjs_window.cpp: (KJS::Window::mark): Call JSGlobalObject::mark,
not JSObject::mark. This is the actual bug fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 6 Dec 2007 05:42:15 +0000 (05:42 +0000)]
2007-12-05 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
http://bugs.webkit.org/show_bug.cgi?id=16145
[gtk] Implement media support in GTK backend
Reviewed by Alp Toker.
Remove old comments, fix variable names, match WebKit coding style.
* platform/graphics/gtk/MoviePrivateGStreamer.cpp:
(WebCore::moviePrivateEOSCallback):
(WebCore::MoviePrivate::MoviePrivate):
(WebCore::MoviePrivate::load):
(WebCore::MoviePrivate::play):
(WebCore::MoviePrivate::pause):
(WebCore::MoviePrivate::currentTime):
(WebCore::MoviePrivate::seek):
(WebCore::MoviePrivate::cancelSeek):
(WebCore::MoviePrivate::seeking):
(WebCore::MoviePrivate::naturalSize):
(WebCore::MoviePrivate::setVolume):
(WebCore::MoviePrivate::setMuted):
(WebCore::MoviePrivate::maxTimeBuffered):
(WebCore::MoviePrivate::bytesLoaded):
(WebCore::MoviePrivate::totalBytesKnown):
(WebCore::MoviePrivate::totalBytes):
(WebCore::MoviePrivate::updateStates):
(WebCore::MoviePrivate::didEnd):
(WebCore::MoviePrivate::paint):
(WebCore::MoviePrivate::createGSTPlayBin):
* platform/graphics/gtk/MoviePrivateGStreamer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 6 Dec 2007 05:37:36 +0000 (05:37 +0000)]
Speculative wx build fix. Add PlugInInfoStore::pluginNameForMIMEType to the temporary link stubs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 6 Dec 2007 05:25:45 +0000 (05:25 +0000)]
Qt Windows build fix. Include the time-related headers in the correct place.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 6 Dec 2007 05:22:38 +0000 (05:22 +0000)]
Not reviewed; just undoing a previous commit.
- remove earlier incorrect fix for http://bugs.webkit.org/show_bug.cgi?id=16220
<rdar://problem/
5625221> Crash opening www.news.com (CNet)
The real bug was the backwards ?: in the compile function, which Geoff just
fixed. Rolling out the incorrect earlier fix.
* pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): Take out
the unneeded preflight change. The regression test proves this is still working
fine, so the bug remains fixed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 6 Dec 2007 05:13:01 +0000 (05:13 +0000)]
2007-12-05 Alp Toker <alp@atoker.com>
Rubber stamped by Mark Rowe.
Remove DEPENDPATH on the generated sources directory. This causes
trouble and is no longer necessary following the glib-genmarshal
generator split.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 6 Dec 2007 04:14:59 +0000 (04:14 +0000)]
Build fix. Include headers before trying to use the things that they declare.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 03:11:50 +0000 (03:11 +0000)]
Build fix: added some #includes.
* kjs/JSImmediate.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 03:07:43 +0000 (03:07 +0000)]
Build fix: added some #includes.
* kjs/JSGlobalObject.cpp:
* kjs/JSImmediate.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 03:02:11 +0000 (03:02 +0000)]
Build fix: Fixed #include spelling.
* kjs/debugger.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 02:57:03 +0000 (02:57 +0000)]
Build fix: added #include.
* kjs/debugger.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 02:51:46 +0000 (02:51 +0000)]
Build fix: added a forward declaration.
* kjs/debugger.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 02:47:57 +0000 (02:47 +0000)]
Build fix: added an #include.
* kjs/error_object.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 02:41:09 +0000 (02:41 +0000)]
Build fix: added an #include.
* kjs/bool_object.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 02:31:41 +0000 (02:31 +0000)]
JavaScriptCore:
Reviewed by Darin Adler.
Third step in refactoring JSGlobalObject: Moved data members and
functions accessing data members from Interpreter to JSGlobalObject.
Changed Interpreter member functions to static functions.
This resolves a bug in global object bootstrapping, where the global
ExecState could be used when uninitialized.
This is a big change, but it's mostly code motion and renaming.
Layout and JS tests, and testjsglue and testapi, pass. SunSpider reports
a .7% regression, but Shark sees no difference related to this patch,
and SunSpider reported a .7% speedup from an earlier step in this
refactoring, so I think it's fair to call that a wash.
JavaScriptGlue:
Reviewed by Darin Adler.
Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject. Replaced JSInterpreter
subclass with JSGlobalObject subclass.
* JSRun.cpp:
(JSRun::JSRun):
(JSRun::Evaluate):
(JSRun::CheckSyntax):
* JSRun.h:
(JSGlueGlobalObject::JSGlueGlobalObject):
* JSUtils.cpp:
(KJSValueToCFTypeInternal):
* JSValueWrapper.cpp:
(getThreadGlobalExecState):
WebCore:
Reviewed by Darin Adler.
Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject. Changed Interpreter
member functions to static functions. Same for the subclass,
ScriptInterpreter.
This is a big change, but it's mostly code motion and renaming.
WebKit/mac:
Reviewed by Darin Adler.
Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.
* WebView/WebFrame.mm:
(-[WebFrame _attachScriptDebugger]):
WebKit/win:
Reviewed by Darin Adler.
Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.
* WebFrame.cpp:
(WebFrame::globalContext):
(WebFrame::attachScriptDebugger):
(WebFrame::windowObjectCleared):
* WebScriptDebugger.cpp:
(WebScriptDebugger::WebScriptDebugger):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Thu, 6 Dec 2007 01:37:14 +0000 (01:37 +0000)]
Reviewed by Antti.
Addressed <rdar://problem/
5137284> fast/events/mouseout-dead-node.html fails on boomer
* fast/events/mouseout-dead-node.html:
Changed the questionable calls to mouseUp() to mouseMoveTo() to better simulate mouseovers
* platform/win/Skipped:
removed this test from skipped file
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 6 Dec 2007 01:36:35 +0000 (01:36 +0000)]
<rdar://problem/
5625327> Crash toggling check grammar w/ spelling when no spell checker exists.
Reviewed by Adam.
* WebView.cpp:
(WebView::setGrammarCheckingEnabled): Add null check
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 6 Dec 2007 00:56:17 +0000 (00:56 +0000)]
* platform/win/Skipped: Add a crashing test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 6 Dec 2007 00:33:23 +0000 (00:33 +0000)]
"Reviewed" by Geoff.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Removed assertion.
(WebCore::FrameLoader::dispatchDidCommitLoad): This one too.
The assertions are firing like crazy. Not sure why yet.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 6 Dec 2007 00:03:19 +0000 (00:03 +0000)]
Reviewed by Darin Adler. (Or vice versa.)
Fixed ASSERT during run-javascriptcore-tests. (Darin just added the
ASSERT, but the bug wasn't new.)
* pcre/pcre_compile.cpp:
(compile_branch): The ?: operator here was backwards, causing us to
execute the loop too many times, adding stray KET opcodes to the
compiled regular expression.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 5 Dec 2007 23:34:19 +0000 (23:34 +0000)]
Make the entry points extern "C".
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 5 Dec 2007 22:58:41 +0000 (22:58 +0000)]
Reviewed by Adam Roben.
- fix http://bugs.webkit.org/show_bug.cgi?id=16306
Assertion failed in WebCore/loader/FrameLoader.cpp:4642
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidCommitLoad): Check m_creatingInitialEmptyDocument
and don't deliver the client call in that case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 5 Dec 2007 22:57:32 +0000 (22:57 +0000)]
C++ warning fixes.
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
(NPP_New):
(NPP_Destroy):
(NPP_SetWindow):
(NPP_NewStream):
(NPP_HandleEvent):
(NPP_URLNotify):
(NPP_GetValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 5 Dec 2007 22:54:46 +0000 (22:54 +0000)]
Add the .cpp files to the TestNetscapePlugIn target.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Wed, 5 Dec 2007 22:48:48 +0000 (22:48 +0000)]
Reviewed by Geoff.
- Wait until local variable data is fully constructed before notifying the debugger of entering
or leaving a call frame.
* kjs/function.cpp:
(KJS::FunctionImp::callAsFunction):
* kjs/nodes.cpp:
(KJS::FunctionBodyNode::execute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 5 Dec 2007 22:42:51 +0000 (22:42 +0000)]
Reviewed by Geoff.
Rename the TestNetscapePlugIn .c files to be .cpp.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
* DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
* DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
* DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
* DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
* DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 5 Dec 2007 22:30:08 +0000 (22:30 +0000)]
Fix 64-bit debug build.
Reviewed by Kevin Decker.
* platform/text/mac/TextCodecMac.cpp:
(WebCore::TextCodecMac::decode): OSStatus is a long for 32-bit but int on 64-bit,
so we need to cast it to be able to use a single format specifier on both.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 5 Dec 2007 22:29:05 +0000 (22:29 +0000)]
Build fix for GCC 4.2. Cast via a union to avoid strict-aliasing issues.
Reviewed by Oliver.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 5 Dec 2007 22:27:25 +0000 (22:27 +0000)]
* platform/win/Skipped: Add another test failing due to fonts.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 5 Dec 2007 22:24:19 +0000 (22:24 +0000)]
Fix case of keypresses from the Windows implementation of eventSender.keyDown
This fixes several regression tests.
Reviewed by Alice.
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback): Virtual keycodes for ASCII characters are always
uppercase, so we need to check the case of the original character
passed in to eventSender.keyDown.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker@apple.com [Wed, 5 Dec 2007 22:08:45 +0000 (22:08 +0000)]
Corrected a Radar number in my previous ChangeLog entry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker@apple.com [Wed, 5 Dec 2007 21:51:09 +0000 (21:51 +0000)]
Reviewed by Hyatt.
<rdar://problem/
5602071> Safari displays each pixel of 300 dpi US Patent TIFF Images, making them extremely large
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldUsePlugin): Allow plug-ins (with the exception of QuickTime) to
takeover TIFF once again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 5 Dec 2007 21:48:39 +0000 (21:48 +0000)]
Add another Inspector screenshot for an upcoming blog post.
* blog-files/InspectorDatabaseBrowser.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 5 Dec 2007 21:16:19 +0000 (21:16 +0000)]
Fix testkjs in 64-bit.
When built for 64-bit the TCMalloc spin lock uses pthread mutexes rather than a custom spin lock
implemented in assembly. If we fail to initialize the pthread mutex, attempts to lock or unlock
it will fail and trigger a call to abort.
Reviewed by Darin.
* wtf/FastMalloc.cpp: Initialize the spin lock so that we can later lock and unlock it.
* wtf/TCSpinLock.h: Add an Init method to the optimised spin lock.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 20:26:42 +0000 (20:26 +0000)]
2007-12-05 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16290
[GTK] Pasting clipboard in rich text.
* platform/gtk/PasteboardGtk.cpp:
(Pasteboard::documentFragment): Implement rich text paste support.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Wed, 5 Dec 2007 20:10:18 +0000 (20:10 +0000)]
Reviewed by Hyatt.
Reverting fix for <rdar://problem/
5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
We need to just fix the underlying focus ring repaint problem.
* rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Wed, 5 Dec 2007 20:01:02 +0000 (20:01 +0000)]
WebCore:
Reviewed by Darin.
- <rdar://
5621435>
- Security Fix. Instead of having it off by default, WebKit now must
explicitly turn off local-resource restriction when needed for backwards
compatibility reasons.
* loader/FrameLoader.cpp:
WebKit/mac:
Reviewed by Darin.
- <rdar://
5621435>
- Security Fix. Instead of having it off by default, WebKit now must
explicitly turn off local-resource restriction when needed for backwards
coimpatibility reasons.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 5 Dec 2007 19:38:02 +0000 (19:38 +0000)]
Expose WebView::setProhibitsMainFrameScrolling through IWebViewPrivate
Reviewed by Steve.
* Interfaces/IWebViewPrivate.idl: Added declaration.
* WebInspectorClient.cpp:
(WebInspectorClient::createPage): Updated for change to
setProhibitsMainFrameScrolling signature.
* WebView.cpp:
(WebView::setProhibitsMainFrameScrolling): Updated and robustified.
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 5 Dec 2007 19:36:56 +0000 (19:36 +0000)]
Set the menu item identifier for all menu items
This allows WebKit clients to distinguish between submenus in the
context menu.
Reviewed by Darin.
No test possible.
* platform/win/ContextMenuItemWin.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 5 Dec 2007 18:51:39 +0000 (18:51 +0000)]
Learn from Tim's mistakes
* DumpRenderTree/win/DumpRenderTree.cpp:
(runTest): Reset the authorAndUserStylesEnabled preference for each
test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 5 Dec 2007 18:46:45 +0000 (18:46 +0000)]
WebCore:
Reviewed by Darin Adler.
- WebCore part of fixing <rdar://problem/
5111082> Flash popup video ad doesn't close when clicked at http://www.firestonecompleteautocare.com/
* manual-tests/nested-plug-ins.html: Added.
* manual-tests/resources/nested-plug-ins-inner-frame.html: Added.
* manual-tests/resources/nested-plug-ins-outer-frame.html: Added.
* platform/ScrollView.h:
* platform/Widget.h:
(WebCore::Widget::attachToWindow): Added. Tells the widget that it is connected
via visible ScrollViews to the root ScrollView of the WebView.
(WebCore::Widget::detachFromWindow): Added. Tells the widget that it is no longer
connected via visible ScrollViews to the root ScrollView of the WebView.
* platform/win/ScrollViewWin.cpp:
(WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): Added
m_visible and m_attachedToWindow members.
(WebCore::ScrollView::attachToWindow): Added. Attaches all children if this
view is visible.
(WebCore::ScrollView::detachFromWindow): Added. Detaches all children if this
view is visible (otherwise they would be detached already).
(WebCore::ScrollView::show): Added. Attaches all children if this view
is attached.
(WebCore::ScrollView::hide): Added. Detaches all children if this view
is attached (otherwise they would be detached already).
(WebCore::ScrollView::isAttachedToWindow): Added.
* platform/win/WidgetWin.cpp:
(WebCore::Widget::setParent): Added calls to attachToWindow() and detachFromWindow()
depending on whether the parent is set and attached or not.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::setFocus):
(WebCore::PluginViewWin::show): Changed to show the plug-in only if
this view is attached.
(WebCore::PluginViewWin::hide): Changed to hide the plug-in only if this
view is attached (otherwise it would be hidden already).
(WebCore::PluginViewWin::attachToWindow): Added. Shows the plug-in if this view
is visible.
(WebCore::PluginViewWin::detachFromWindow): Added. Hides the plug-in if this view
is visible (otherwise it would be hidden already).
(WebCore::PluginViewWin::PluginViewWin):
* plugins/win/PluginViewWin.h: Added m_attachedToWindow member.
WebKit/win:
Reviewed by Darin Adler.
- WebKit/win part of fixing <rdar://problem/
5111082> Flash popup video ad doesn't close when clicked at http://www.firestonecompleteautocare.com/
* WebView.cpp:
(WebView::initWithFrame): Attach the main frame's view.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 5 Dec 2007 18:15:30 +0000 (18:15 +0000)]
Reviewed by Kevin Deckers rubberstamp
Disclose and export the Databases Directory defaults key
* Storage/WebDatabaseManager.mm:
* Storage/WebDatabaseManagerPrivate.h:
* WebKit.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 16:42:14 +0000 (16:42 +0000)]
2007-12-05 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Initialize GTK+ and WebKit so the tests can run.
Reorganize the headers a little.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 15:53:54 +0000 (15:53 +0000)]
2007-12-05 Michael Natterer <mitch@imendio.com>
Reviewed by Alp Toker.
* WebView/webkitwebview.cpp: split key and button event handlers
into separate press and release functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 15:16:47 +0000 (15:16 +0000)]
2007-12-05 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
Handle events for Home and End keys.
* WebView/webkitwebview.cpp:
(webkit_web_view_key_event):
* WebCoreSupport/EditorClientGtk.cpp:
(EditorClient::handleKeypress):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 12:35:47 +0000 (12:35 +0000)]
2007-12-05 Michael Natterer <mitch@imendio.com>
Reviewed by Alp Toker.
* WebView/webkitwebview.cpp
* WebCoreSupport/ChromeClientGtk.cpp
* WebCoreSupport/FrameLoaderClientGtk.cpp: canonicalize signal names.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 5 Dec 2007 08:26:21 +0000 (08:26 +0000)]
Reviewed by Adam Roben.
- adding a test for http://bugs.webkit.org/show_bug.cgi?id=16097
* fast/dom/ImageDocument-image-deletion-expected.txt: Added.
* fast/dom/ImageDocument-image-deletion.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 5 Dec 2007 04:47:32 +0000 (04:47 +0000)]
Fix gtk build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28435
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 5 Dec 2007 03:58:41 +0000 (03:58 +0000)]
Merge TCMalloc r38
Reviewed by Mark Rowe and Geoff Garen.
It also result in a performance progression between 0.5% and
0.9% depending on the test, however most if not all of this
gain will be consumed by the overhead involved in the later
change to release memory to the system.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 02:48:16 +0000 (02:48 +0000)]
2007-12-04 Alp Toker <alp@atoker.com>
Potential GTK+ build fix for the glib-genmarshal issue.
Split the glib-genmarshal qmake generator in two; one for the source
file, another for the header.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 5 Dec 2007 02:34:45 +0000 (02:34 +0000)]
Remove IWebScriptScope include.
* Drosera/win/DebuggerDocumentPlatform.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 5 Dec 2007 02:08:15 +0000 (02:08 +0000)]
2007-12-04 Alp Toker <alp@atoker.com>
GTK+ build fix.
* platform/PlugInInfoStore.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28431
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker@apple.com [Wed, 5 Dec 2007 01:46:33 +0000 (01:46 +0000)]
Reviewed by Anders.
<rdar://problem/
5629125> PluginInfoStore needs the ability to return the name of a plug-in for a given MIME type
* page/mac/WebCoreViewFactory.h: Added pluginNameForMIMEType: method.
* platform/PlugInInfoStore.h:
* platform/gtk/TemporaryLinkStubs.cpp: Added stub version of pluginNameForMIMEType.
(PlugInInfoStore::pluginNameForMIMEType):
* platform/mac/PlugInInfoStoreMac.mm:
(WebCore::PlugInInfoStore::pluginNameForMIMEType): Added.
* platform/qt/PlugInInfoStoreQt.cpp:
(WebCore::PlugInInfoStore::pluginNameForMIMEType): Added stub version of pluginNameForMIMEType.
* plugins/win/PlugInInfoStoreWin.cpp:
(WebCore::PlugInInfoStore::pluginNameForMIMEType): Added stub version of pluginNameForMIMEType.
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory pluginNameForMIMEType:]): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Wed, 5 Dec 2007 01:08:54 +0000 (01:08 +0000)]
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/
5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
* rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle):
Adjust outline-offset so it doesn't extend beyond the border to interfere with typing
LayoutTests:
Reviewed by Darin.
Test for <rdar://problem/
5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
* fast/forms/textfield-outline.html: Added.
* platform/mac/fast/forms/textfield-outline-expected.checksum: Added.
* platform/mac/fast/forms/textfield-outline-expected.png: Added.
* platform/mac/fast/forms/textfield-outline-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Wed, 5 Dec 2007 01:05:00 +0000 (01:05 +0000)]
Provide API for setting the default storage quota per database origin
Reviewed by Jon.
* Interfaces/IWebPreferencesPrivate.idl: added SPI to get/set default database quota
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): default database quota is 5MB
(WebPreferences::longlongValueForKey):
(WebPreferences::setLongLongValue):
(WebPreferences::defaultDatabaseQuota):
(WebPreferences::setDefaultDatabaseQuota):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): propagate default database quota change to WebCore settings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 5 Dec 2007 00:46:38 +0000 (00:46 +0000)]
Reviewed by Jon.
Always call NPP_NewStream, NPP_DestroyStream and NPP_URLNotify for JavaScript
result streams, even if the JavaScript expression threw an exception or returned undefined.
This matches what Firefox does.
* plugins/win/PluginStreamWin.cpp:
(WebCore::PluginStreamWin::sendJavaScriptStream):
Handle the result string being null, and set the correct NPReason if it is.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::performRequest):
Always send the JavaScript stream, regardless of the result could be converted to a string or not.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 5 Dec 2007 00:30:12 +0000 (00:30 +0000)]
Reviewed by Mark Rowe
Tweaked the way we typedef and cast these objc_msgSend calls
* WebView/WebView.mm:
(CallDelegateReturningUnsignedLongLong):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 5 Dec 2007 00:23:55 +0000 (00:23 +0000)]
Rubber stamped by Mark Rowe.
Define CF as platform for mac and revert r28409
* DumpRenderTree/DumpRenderTree.h:
* DumpRenderTree/mac/DumpRenderTreeMac.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 5 Dec 2007 00:14:11 +0000 (00:14 +0000)]
Reviewed by Adam Roben.
Remove http/tests/incremental/frame-focus-before-load.html from the skipped list
as it is no longer crashing. <rdar://problem/
5507278>
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Wed, 5 Dec 2007 00:08:37 +0000 (00:08 +0000)]
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/
5622464> controls should show up for audio element
* css/html4.css: Added styles for audio controls. This will need to be refined, since we may want a different look for audio controls.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged): When the controls attribute changes detach and reattach if necessary.
(WebCore::HTMLMediaElement::rendererIsNeeded): Added.
(WebCore::HTMLMediaElement::createRenderer): Added. Uses RenderMedia.
* html/HTMLMediaElement.h:
* rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Added constructor that doesn't take intrinsic size.
* rendering/RenderMedia.h:
LayoutTests:
Reviewed by Hyatt.
Test for <rdar://problem/
5622464> controls should show up for audio element
* media/audio-controls-rendering.html: Added.
* platform/mac/media/audio-controls-rendering-expected.checksum: Added.
* platform/mac/media/audio-controls-rendering-expected.png: Added.
* platform/mac/media/audio-controls-rendering-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Wed, 5 Dec 2007 00:01:35 +0000 (00:01 +0000)]
Reviewed by Brady Eidson (with help from Mark Rowe)
Fixed return values for unsigned-long-long delegate methods
* WebView/WebView.mm:
(CallDelegateReturningUnsignedLongLong):
redid the change that Brady did at home over the weekend but forgot to check in
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 4 Dec 2007 23:53:04 +0000 (23:53 +0000)]
JavaScriptCore:
Reviewed by Sam.
Make isSafeScript const.
* kjs/JSGlobalObject.h:
(KJS::JSGlobalObject::isSafeScript):
WebCore:
Reviewed by Sam.
Add isSafeScript(const JSGlobalObject*) so we won't get the JSGlobalObject
implementation, which always returns true(!).
* bindings/js/kjs_window.cpp:
(KJS::Window::isSafeScript):
Make the static isSafeScript method take two JSGlobalObjects.
* bindings/js/kjs_window.h:
(KJS::Window::isSafeScript):
Implement isSafeScript and have it call the static method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 4 Dec 2007 23:40:59 +0000 (23:40 +0000)]
Define CF as platform for windows.
Reviewed by Adam Roben.
* DumpRenderTree/win/DumpRenderTreeWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Tue, 4 Dec 2007 23:19:16 +0000 (23:19 +0000)]
WebKit/win:
Reviewed by Adam and Darin.
- Fixed a crasher where the top of the stack was not updated correctly.
And set the eol style on IWebScriptCallFrame.idl file.
* Interfaces/IWebScriptCallFrame.idl:
* WebScriptDebugger.cpp:
(WebScriptDebugger::atStatement):
(WebScriptDebugger::leaveFrame):
WebKitTools:
Reviewed by Adam and Darin.
- Removed a needless BSTR cleanup.
* Drosera/win/DebuggerDocumentPlatform.cpp:
(DebuggerDocument::getPlatformCurrentFunctionStack):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 4 Dec 2007 22:54:37 +0000 (22:54 +0000)]
Hook up the authorAndUserStylesEnabled preference on Windows
WebKit/win:
Hook up the authorAndUserStylesEnabled preference
This is the Windows counterpart of r28071.
Reviewed by Maciej.
* Interfaces/IWebPreferencesPrivate.idl: Added new method
declarations.
* WebPreferenceKeysPrivate.h: Added a new preference key.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Set the default for the
new preference.
(WebPreferences::setAuthorAndUserStylesEnabled): Added.
(WebPreferences::authorAndUserStylesEnabled): Added.
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): Communicate the new preference
down to WebCore::Settings.
WebKitTools:
Fix <rdar://
5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
Reviewed by Maciej.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
LayoutTests:
Remove a now-passing test from the Windows Skipped file
Reviewed by Maciej.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 4 Dec 2007 22:52:47 +0000 (22:52 +0000)]
Make the implementation of Frame::setNeedsReapplyStyles cross-platform
WebCore:
Make the implementation of Frame::setNeedsReapplyStyles cross-platform
Reviewed by Hyatt.
No change in functionality.
* page/Frame.cpp:
(WebCore::Frame::setNeedsReapplyStyles): Added. Invalidates the
FrameView so that FrameView::layout will be called, which ends up
calling reapplyStyles.
(WebCore::Frame::needsReapplyStyles): Added.
(WebCore::Frame::reapplyStyles): Renamed from reparseConfiguration.
(WebCore::FramePrivate::FramePrivate):
* page/Frame.h:
* page/FramePrivate.h: Added new boolean member.
* page/FrameView.cpp:
(WebCore::FrameView::layout): Call Frame::reapplyStyles if needed.
(WebCore::FrameView::needsLayout): Say that we need layout if the
Frame needs styles reapplied.
* page/mac/WebCoreFrameBridge.h: Removed setNeedsReapplyStyles.
* page/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge reapplyStylesForDeviceType:]): Updated for
rename.
* bridge/win/FrameWin.cpp: Removed Frame::setNeedsReapplyStyles.
* page/gtk/FrameGtk.cpp: Ditto.
* page/mac/FrameMac.mm: Ditto.
* page/qt/FrameQt.cpp: Ditto.
* platform/wx/TemporaryLinkStubs.cpp: Ditto.
WebKit/mac:
Remove -[WebFrameBridge setNeedsReapplyStyles]
This functionality is now WebCore's responsibility.
Reviewed by Hyatt.
* WebCoreSupport/WebFrameBridge.mm:
* WebKit.order:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc