WebKit-https.git
10 years ago2011-05-25 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 26 May 2011 05:19:25 +0000 (05:19 +0000)]
2011-05-25  Ryosuke Niwa  <rniwa@webkit.org>

        An attempt to revive Windows bots.

        * runtime/RegExp.cpp:
        * runtime/RegExp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Thu, 26 May 2011 04:16:36 +0000 (04:16 +0000)]
2011-05-25  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Antonio Gomes.

        [Qt] REGRESSION(r87298) Skip drag-not-loaded-image.html failing test
        https://bugs.webkit.org/show_bug.cgi?id=61465

        Skip drag-not-loaded-image.html layout test from Qt. see bug 31332

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 61501 - Unify AbstractMacroAssembler::differenceBetween methods.
barraclough@apple.com [Thu, 26 May 2011 04:12:41 +0000 (04:12 +0000)]
Bug 61501 - Unify AbstractMacroAssembler::differenceBetween methods.

Reviewed by Sam Weinig.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::Call::fromTailJump):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::Jump::isSet):
(JSC::AbstractMacroAssembler::differenceBetween):
(JSC::AbstractMacroAssembler::linkJump):
(JSC::AbstractMacroAssembler::getLinkerCallReturnOffset):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::link):
(JSC::LinkBuffer::locationOf):
(JSC::LinkBuffer::locationOfNearCall):
(JSC::LinkBuffer::returnAddressOffset):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::linkCall):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::linkCall):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::linkCall):
* assembler/MacroAssemblerSH4.cpp:
(JSC::MacroAssemblerSH4::linkCall):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::linkCall):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::linkCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=61500
barraclough@apple.com [Thu, 26 May 2011 04:05:42 +0000 (04:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=61500
Add JSObject::offsetOfPropertyStorage

Reviewed by Sam Weinig.

* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
* runtime/JSObject.h:
(JSC::JSObject::offsetOfPropertyStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Thu, 26 May 2011 03:50:11 +0000 (03:50 +0000)]
2011-05-25  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Rebaseline media tests after moving media controls to flexbox layout.

        https://bugs.webkit.org/show_bug.cgi?id=61380

        * platform/chromium-mac/fast/layers/video-layer-expected.txt:
        * platform/chromium-mac/media/audio-controls-rendering-expected.txt:
        * platform/chromium-mac/media/audio-repaint-expected.txt:
        * platform/chromium-mac/media/controls-after-reload-expected.txt:
        * platform/chromium-mac/media/controls-strict-expected.txt:
        * platform/chromium-mac/media/controls-styling-expected.txt:
        * platform/chromium-mac/media/controls-without-preload-expected.txt:
        * platform/chromium-mac/media/video-controls-rendering-expected.txt:
        * platform/chromium-mac/media/video-display-toggle-expected.txt:
        * platform/chromium-mac/media/video-empty-source-expected.txt:
        * platform/chromium-mac/media/video-no-audio-expected.txt:
        * platform/chromium-mac/media/video-volume-slider-expected.txt:
        * platform/chromium-win/fast/layers/video-layer-expected.txt:
        * platform/chromium-win/media/audio-controls-rendering-expected.txt:
        * platform/chromium-win/media/audio-repaint-expected.txt:
        * platform/chromium-win/media/controls-after-reload-expected.txt:
        * platform/chromium-win/media/controls-strict-expected.txt:
        * platform/chromium-win/media/controls-styling-expected.txt:
        * platform/chromium-win/media/controls-without-preload-expected.txt:
        * platform/chromium-win/media/video-controls-rendering-expected.txt:
        * platform/chromium-win/media/video-display-toggle-expected.txt:
        * platform/chromium-win/media/video-empty-source-expected.txt:
        * platform/chromium-win/media/video-no-audio-expected.txt:
        * platform/chromium-win/media/video-volume-slider-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Gregg Tavares <gman@chromium.org>
commit-queue@webkit.org [Thu, 26 May 2011 03:32:07 +0000 (03:32 +0000)]
2011-05-25  Gregg Tavares  <gman@chromium.org>

        Reviewed by Kenneth Russell.

        Add 'noExtensions' option to Web/GraphicsContext3D attributes.
        https://bugs.webkit.org/show_bug.cgi?id=61460

        * Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
        * Source/WebCore/platform/graphics/GraphicsContext3D.h:
        * Source/WebKit/chromium/public/WebGraphicsContext3D.h:
        * Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 26 May 2011 03:13:31 +0000 (03:13 +0000)]
2011-05-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch itemBoundingBoxRect to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=60789

        Changing itemBoundingBoxRect to use an IntPoint representing the offset
        to be added tot he box rect instead of a pair of ints.

        No new tests since this is just refactoring.

        * accessibility/AccessibilityListBox.cpp:
        (WebCore::AccessibilityListBox::elementAccessibilityHitTest):
        * accessibility/AccessibilityListBoxOption.cpp:
        (WebCore::AccessibilityListBoxOption::elementRect):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::itemBoundingBoxRect):
        (WebCore::RenderListBox::addFocusRingRects):
        (WebCore::RenderListBox::paintItemForeground):
        (WebCore::RenderListBox::paintItemBackground):
        (WebCore::RenderListBox::nodeAtPoint):
        * rendering/RenderListBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 26 May 2011 02:31:38 +0000 (02:31 +0000)]
2011-05-24  MORITA Hajime  <morrita@google.com>

        RenderText with empty text is not created inside ShadowContentElement
        https://bugs.webkit.org/show_bug.cgi?id=61111

        - Added tests that capture the probelem.
        - Updated expectations that were wrong.

        * fast/html/details-replace-summary-child.html: Added.
        * fast/html/details-replace-text.html: Added.
        * platform/gtk/fast/html/details-no-summary4-expected.txt:
        * platform/gtk/fast/html/details-open-javascript-expected.txt:
        * platform/gtk/fast/html/details-open4-expected.txt:
        * platform/mac/fast/html/details-add-details-child-2-expected.txt:
        * platform/mac/fast/html/details-no-summary4-expected.txt:
        * platform/mac/fast/html/details-open-javascript-expected.txt:
        * platform/mac/fast/html/details-open4-expected.txt:
        * platform/mac/fast/html/details-replace-summary-child-expected.png: Added.
        * platform/mac/fast/html/details-replace-summary-child-expected.txt: Added.
        * platform/mac/fast/html/details-replace-text-expected.png: Added.
        * platform/mac/fast/html/details-replace-text-expected.txt: Added.
        * platform/qt/fast/html/details-no-summary4-expected.txt:
        * platform/qt/fast/html/details-open-javascript-expected.txt:
        * platform/qt/fast/html/details-open4-expected.txt:
2011-05-24  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        RenderText with empty text is not created inside ShadowContentElement
        https://bugs.webkit.org/show_bug.cgi?id=61111

        - Changed Text::rendererIsNeeded() to be shadow-aware.
        - previousRenderer(), nextRenderer() and parentRenderer() on NodeRenderingContext is now
          safe even if it's used with an attached node, which was originally used only during attach().
          We need this change because these APIs are called inside CharacterData::updateRenderer() callstack.

        Tests: fast/html/details-replace-summary-child.html
               fast/html/details-replace-text.html

        * dom/NodeRenderingContext.cpp:
        (WebCore::NodeRenderingContext::NodeRenderingContext):
        (WebCore::NodeRenderingContext::nextRenderer):
        (WebCore::NodeRenderingContext::previousRenderer):
        (WebCore::NodeRenderingContext::parentRenderer):
        (WebCore::NodeRenderingContext::shouldCreateRenderer):
        * dom/NodeRenderingContext.h:
        (WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle):
        * dom/Text.cpp:
        (WebCore::Text::rendererIsNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Thu, 26 May 2011 01:58:06 +0000 (01:58 +0000)]
2011-05-25  Adam Klein  <adamk@chromium.org>

        Unreviewed. Add Win/CRASH expectation for new crashy plugin test,
        reported as http://crbug.com/83994.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Thu, 26 May 2011 01:50:55 +0000 (01:50 +0000)]
2011-05-25  Adam Klein  <adamk@chromium.org>

        Unreviewed. Temporarily ignore MHTML test failures on Windows
        while we dig into it in http://crbug.com/83833.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
qi.2.zhang@nokia.com [Thu, 26 May 2011 01:48:25 +0000 (01:48 +0000)]
2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Simon Hausmann.

        WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=42697

        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Simon Hausmann.

        WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=42697

        Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.

        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundleSetPrivateBrowsingEnabled):
        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::setPrivateBrowsingEnabled):
        * WebProcess/InjectedBundle/InjectedBundle.h:
2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Simon Hausmann.

        WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=42697

        Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::beginTesting):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::setPrivateBrowsingEnabled):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Sailesh Agrawal <sail@chromium.org>
commit-queue@webkit.org [Thu, 26 May 2011 01:30:27 +0000 (01:30 +0000)]
2011-05-25  Sailesh Agrawal  <sail@chromium.org>

        Reviewed by Tony Chang.

        Rename ScrollbarOverlayUtilitiesMac to ScrollbarOverlayUtilitiesChromiumMac
        https://bugs.webkit.org/show_bug.cgi?id=61401

        ScrollbarOverlayUtilitiesMac.mm was being excluded from the WebCore project. Fix was to make sure the file name ended with ChromiumMac.

        * WebCore.gypi:
        * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h: Copied from Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.h.
        * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: Copied from Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm.
        * platform/chromium/ScrollbarOverlayUtilitiesMac.h: Removed.
        * platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 26 May 2011 01:12:46 +0000 (01:12 +0000)]
2011-05-25  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make RegExp GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=61490

        Make RegExp GC allocated.  Basically mechanical change to replace
        most use of [Pass]RefPtr<RegExp> with RegExp* or WriteBarrier<RegExp>
        where actual ownership happens.

        Made the RegExpCache use Strong<> references currently to avoid any
        changes in behaviour.

        * JavaScriptCore.exp:
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::visitAggregate):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::addRegExp):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::addRegExp):
        (JSC::BytecodeGenerator::emitNewRegExp):
        * bytecompiler/BytecodeGenerator.h:
        * runtime/JSCell.h:
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        (JSC::JSGlobalData::clearBuiltinStructures):
        (JSC::JSGlobalData::addRegExpToTrace):
        * runtime/JSGlobalData.h:
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::reset):
        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        (JSC::RegExp::create):
        (JSC::RegExp::invalidateCode):
        * runtime/RegExp.h:
        (JSC::RegExp::createStructure):
        * runtime/RegExpCache.cpp:
        (JSC::RegExpCache::lookupOrCreate):
        (JSC::RegExpCache::create):
        * runtime/RegExpCache.h:
        * runtime/RegExpConstructor.cpp:
        (JSC::constructRegExp):
        * runtime/RegExpObject.cpp:
        (JSC::RegExpObject::RegExpObject):
        (JSC::RegExpObject::visitChildren):
        * runtime/RegExpObject.h:
        (JSC::RegExpObject::setRegExp):
        (JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
        * runtime/RegExpPrototype.cpp:
        (JSC::RegExpPrototype::RegExpPrototype):
        (JSC::regExpProtoFuncCompile):
        * runtime/RegExpPrototype.h:
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncMatch):
        (JSC::stringProtoFuncSearch):
2011-05-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Geoffrey Garen

        CachedResource overhead size calculation ignores the actual size of the URL
        https://bugs.webkit.org/show_bug.cgi?id=61481

        CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict
        it.  When the resource is a large data: URL, for example representing image or audio data, the URL size itself
        can be significant.

        This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for
        other types of strings instead of a fixed number.

        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::overheadSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert last change, something weird happened when I went to land.
oliver@apple.com [Thu, 26 May 2011 01:08:57 +0000 (01:08 +0000)]
Revert last change, something weird happened when I went to land.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 26 May 2011 01:07:57 +0000 (01:07 +0000)]
2011-05-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Geoffrey Garen

        CachedResource overhead size calculation ignores the actual size of the URL
        https://bugs.webkit.org/show_bug.cgi?id=61481

        CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict
        it.  When the resource is a large data: URL, for example representing image or audio data, the URL size itself
        can be significant.

        This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for
        other types of strings instead of a fixed number.

        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::overheadSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 26 May 2011 01:01:16 +0000 (01:01 +0000)]
2011-05-25  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make RegExp GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=61490

        Make RegExp GC allocated.  Basically mechanical change to replace
        most use of [Pass]RefPtr<RegExp> with RegExp* or WriteBarrier<RegExp>
        where actual ownership happens.

        Made the RegExpCache use Strong<> references currently to avoid any
        changes in behaviour.

        * JavaScriptCore.exp:
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::visitAggregate):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::addRegExp):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::addRegExp):
        (JSC::BytecodeGenerator::emitNewRegExp):
        * bytecompiler/BytecodeGenerator.h:
        * runtime/JSCell.h:
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        (JSC::JSGlobalData::clearBuiltinStructures):
        (JSC::JSGlobalData::addRegExpToTrace):
        * runtime/JSGlobalData.h:
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::reset):
        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        (JSC::RegExp::create):
        (JSC::RegExp::invalidateCode):
        * runtime/RegExp.h:
        (JSC::RegExp::createStructure):
        * runtime/RegExpCache.cpp:
        (JSC::RegExpCache::lookupOrCreate):
        (JSC::RegExpCache::create):
        * runtime/RegExpCache.h:
        * runtime/RegExpConstructor.cpp:
        (JSC::constructRegExp):
        * runtime/RegExpObject.cpp:
        (JSC::RegExpObject::RegExpObject):
        (JSC::RegExpObject::visitChildren):
        * runtime/RegExpObject.h:
        (JSC::RegExpObject::setRegExp):
        (JSC::RegExpObject::RegExpObjectData::RegExpObjectData):
        * runtime/RegExpPrototype.cpp:
        (JSC::RegExpPrototype::RegExpPrototype):
        (JSC::regExpProtoFuncCompile):
        * runtime/RegExpPrototype.h:
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncMatch):
        (JSC::stringProtoFuncSearch):
2011-05-25  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make RegExp GC allocated
        https://bugs.webkit.org/show_bug.cgi?id=61490

        RegExp is GC'd so we don't need the RefPtr shenanigans anymore.

        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::CloneDeserializer::readTerminal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Shishir Agrawal <shishir@chromium.org>
commit-queue@webkit.org [Thu, 26 May 2011 00:59:47 +0000 (00:59 +0000)]
2011-05-25  Shishir Agrawal  <shishir@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix crash in Chromium memory test.
        https://bugs.webkit.org/show_bug.cgi?id=61451

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Thu, 26 May 2011 00:52:17 +0000 (00:52 +0000)]
2011-05-25  Adam Klein  <adamk@chromium.org>

        Unreviewed. Fix to previous update, mark drag-not-loaded-image crash as DEBUG-only.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; Skip failing tests after r87328.
jer.noble@apple.com [Thu, 26 May 2011 00:44:16 +0000 (00:44 +0000)]
Unreviewed; Skip failing tests after r87328.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Thu, 26 May 2011 00:27:05 +0000 (00:27 +0000)]
2011-05-25  Adam Klein  <adamk@chromium.org>

        Unreviewed. Test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
adamk@chromium.org [Thu, 26 May 2011 00:24:04 +0000 (00:24 +0000)]
2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87333.
        http://trac.webkit.org/changeset/87333
        https://bugs.webkit.org/show_bug.cgi?id=61488

        Breaks Chromium build due to pure virtual methods. (Requested
        by aklein on #webkit).

        * public/WebWidget.h:
        * src/WebPopupMenuImpl.cpp:
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert 79703 since it broke pdf scrolling (http://crbug.com/81878) - 2011-02-15 ...
jam@chromium.org [Thu, 26 May 2011 00:04:22 +0000 (00:04 +0000)]
Revert 79703 since it broke pdf scrolling (crbug.com/81878) - 2011-02-15  Brett Wilson  <brettw@chromium.org>

        Reviewed by Darin Fisher.

        Recover the mouse capture state when we recieve a mouse event where there is no longer a button down.
        https://bugs.webkit.org/show_bug.cgi?id=54503

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::handleInputEvent):

TBR=brettw@chromium.org

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 25 May 2011 23:54:02 +0000 (23:54 +0000)]
2011-05-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Dirk Schulze.

        [Cairo] Move the global alpha property from GraphicsContext to PlatformContextCairo
        https://bugs.webkit.org/show_bug.cgi?id=60185

        Remove Cairo #ifdefs from GraphicsContext.h by pushing the global alpha
        state into PlatformContextCairo. Since Cairo is the only platform that needs
        to store this, this is the proper place for it. Change the image mask stack into
        a more generic state stack that can keep track of the multiple bits of platform
        specific state and properly handle save/restore pairs.

        No new tests. This is just a code refactor.

        * platform/graphics/GraphicsContext.h: Remove Cairo #ifdefs.
        (WebCore::GraphicsContextState::GraphicsContextState): Ditto.
        * platform/graphics/cairo/ContextShadowCairo.cpp: Access global alpha from PlatformContextCairo now.
        (WebCore::ContextShadow::drawRectShadow):
        * platform/graphics/cairo/FontCairo.cpp: Ditto.
        (WebCore::Font::drawGlyphs):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::setPlatformFill): Ditto.
        (WebCore::setPlatformStroke): Ditto.
        (WebCore::GraphicsContext::setAlpha): Ditto.
        * platform/graphics/cairo/PlatformContextCairo.cpp: Moved ImageMaskInformation class from the
        header file, since it can be private now. Abstract the image mask state and the global alpha
        in a generic State class.
        (WebCore::ImageMaskInformation::update):
        (WebCore::ImageMaskInformation::isValid):
        (WebCore::ImageMaskInformation::maskSurface):
        (WebCore::ImageMaskInformation::maskRect):
        (WebCore::PlatformContextCairo::State::State): Added.
        (WebCore::PlatformContextCairo::PlatformContextCairo): Intialize the state
        class when this class is constructed.
        (WebCore::PlatformContextCairo::restore): Now pop the last state off the state stack.
        (WebCore::PlatformContextCairo::~PlatformContextCairo): Added this so that we can forward
        declare the State class in the header.
        (WebCore::PlatformContextCairo::save): Push a new state onto the stack.
        (WebCore::PlatformContextCairo::pushImageMask): Operate on the state stack now.
        (WebCore::PlatformContextCairo::globalAlpha): Added.
        (WebCore::PlatformContextCairo::setGlobalAlpha): Added.
        (WebCore::PlatformContextCairo::drawSurfaceToContext: Call globalAlpha().
        * platform/graphics/cairo/PlatformContextCairo.h: Changed the image mask stack
        into a more generic state stack, much like PlatformContextChromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9504058> Need some way to query user gesture state from injected...
mrowe@apple.com [Wed, 25 May 2011 23:41:07 +0000 (23:41 +0000)]
<rdar://problem/9504058> Need some way to query user gesture state from injected bundle

Reviewed by Sam Weinig.

Source/WebCore:

* WebCore.exp.in: Add an export that WebKit2 needs.

Source/WebKit2:

Add WKBundleIsProcessingUserGesture.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleIsPageBoxVisible):
(WKBundleIsProcessingUserGesture):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::isProcessingUserGesture):
* WebProcess/InjectedBundle/InjectedBundle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Wed, 25 May 2011 23:39:48 +0000 (23:39 +0000)]
2011-05-25  Adam Klein  <adamk@chromium.org>

        Unreviewed. Rebaseline svg tests after r87310.

        * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Sailesh Agrawal <sail@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 23:30:41 +0000 (23:30 +0000)]
2011-05-25  Sailesh Agrawal  <sail@chromium.org>

        Reviewed by Darin Fisher.

        Expose willStartLiveResize and willEndLiveResize in WebWidget
        https://bugs.webkit.org/show_bug.cgi?id=60518

        * public/WebWidget.h:
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::willStartLiveResize):
        (WebKit::WebPopupMenuImpl::willEndLiveResize):
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::willStartLiveResize):
        (WebKit::WebViewImpl::willEndLiveResize):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Wed, 25 May 2011 23:09:56 +0000 (23:09 +0000)]
2011-05-25  Adam Klein  <adamk@chromium.org>

        Unreviewed. Removing test_expectations for non-existent tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUreviewed; Build fix for Leopard and Snow Leopard.
jer.noble@apple.com [Wed, 25 May 2011 23:08:28 +0000 (23:08 +0000)]
Ureviewed; Build fix for Leopard and Snow Leopard.

Move _wkQTMovieResolvedURL outside of a #if check for Leopard and SL.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Wed, 25 May 2011 23:05:29 +0000 (23:05 +0000)]
2011-05-25  Michael Saboff  <msaboff@apple.com>

        Reviewed by Sam Weinig.

        Cleanup of commented items from https://bugs.webkit.org/show_bug.cgi?id=61222
        https://bugs.webkit.org/show_bug.cgi?id=61478

        Cleanup of further comments after patch was landed.  Changes include
        using /2 instead of >>1, adding a blank line after class include,
        making method names start with lower case and adding clarifying
        comments.

        No new tests as the changes are stylistic and not functional.

        * loader/cache/MemoryCache.cpp:
        (WebCore::MemoryCache::pruneLiveResourcesToPercentage):
        (WebCore::MemoryCache::pruneDeadResourcesToPercentage):
        * loader/cache/MemoryCache.h:
        (WebCore::MemoryCache::pruneToPercentage):
        * platform/mac/MemoryPressureHandlerMac.mm:
        (WebCore::MemoryPressureHandler::respondToMemoryPressure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=61407
slewis@apple.com [Wed, 25 May 2011 23:00:45 +0000 (23:00 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=61407
part of <rdar://problem/8675177>
Move Quicklook quirk down into WebCore so it can be caculated when the user
starts a reload.  Restructure the conditions so it only called when absolutely
necessary.

Reviewed by Brady Eidson.

No change in functionality so no new tests.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* platform/network/cf/ResourceRequest.h:
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::initQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):

Source/WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=61407
part of <rdar://problem/8675177>
Remove Quicklook pref.  Moving it enirely down into WebCore so it can
be calculated only on reloads.

Reviewed by Brady Eidson.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 25 May 2011 22:53:23 +0000 (22:53 +0000)]
2011-05-24  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Video fails to play on Vimeo
        https://bugs.webkit.org/show_bug.cgi?id=61403

        No new tests; Covered by media/video-canvas-source.html.

        Vimeo redirects their assets from player.vimeo.com to av.vimeo.com, which is rejected
        by AVFoundation and QTKit due to our setting a ForbidCrossSiteReference option when
        creating an AVAsset or QTMovie. Instead, we should just reject local->remote and
        remote->local and make our answer to hasSingleSecurityOrigin dynamic.

        When checking whether a given request has a single security origin, use a
        SecurityOrigin to check the host, port, and scheme.

        * WebCore.exp.in:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
        (WebCore::MediaPlayerPrivateAVFoundation::assetURL): Added.
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Exchange ForbidCrossSiteReference
            for ForbidRemoteReferenceToLocal and ForbidLocalReferenceToRemote
        (WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin): Check to see that the
            requested and resolved URLs have the same host and port.
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Exchange NoCrossSiteAttribute for
            NoRemoteToLocalSiteAttribute and NoLocalToRemoteSiteAttribute.
        (WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin):     Check to see that the
                requested and resolved URLs have the same host and port.
        * platform/mac/WebCoreSystemInterface.h: Added wkAVAssetResolvedURL.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.
2011-05-24  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Video fails to play on Vimeo
        https://bugs.webkit.org/show_bug.cgi?id=61403

        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
            wkQTMovieResolvedURL.
2011-05-24  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Video fails to play on Vimeo
        https://bugs.webkit.org/show_bug.cgi?id=61403

        * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and
            wkQTMovieResolvedURL.
2011-05-25  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Video fails to play on Vimeo
        https://bugs.webkit.org/show_bug.cgi?id=61403

        Added functions to retrieve the resolved URL for media types supported on
        mac.

        * WebKitSystemInterface.h:
        * WebKitSystemInterface.m:
        (WKAVAssetResolvedURL): Added.
        (WKQTMovieResolvedURL): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 25 May 2011 22:49:56 +0000 (22:49 +0000)]
2011-05-25  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Generate regexp code lazily
        https://bugs.webkit.org/show_bug.cgi?id=61476

        RegExp construction now simply validates the RegExp, it does
        not perform actual codegen.

        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        (JSC::RegExp::recompile):
        (JSC::RegExp::compile):
        (JSC::RegExp::match):
        * runtime/RegExp.h:
        (JSC::RegExp::recompileIfNecessary):
        * runtime/RegExpConstructor.h:
        (JSC::RegExpConstructor::performMatch):
        * runtime/RegExpObject.cpp:
        (JSC::RegExpObject::match):
        * runtime/StringPrototype.cpp:
        (JSC::stringProtoFuncReplace):
        (JSC::stringProtoFuncMatch):
        (JSC::stringProtoFuncSearch):
        (JSC::stringProtoFuncSplit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; Update Skipped list for failing tests.
jer.noble@apple.com [Wed, 25 May 2011 22:46:51 +0000 (22:46 +0000)]
Unreviewed; Update Skipped list for failing tests.

A new full-screen test requires <video> full screen support, which does not
exist on mac-leopard.  Follow-up to r87322.

* platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Wed, 25 May 2011 22:03:52 +0000 (22:03 +0000)]
2011-05-25  Adam Klein  <adamk@chromium.org>

        Unreviewed. Test expectations update, followup to r87291.

        The aforementioned change cleared out these files, when the intent
        seems to have been removal to remove them.

        * platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt: Removed.
        * platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt: Removed.
        * platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt: Removed.
        * platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
jhoneycutt@apple.com [Wed, 25 May 2011 21:56:21 +0000 (21:56 +0000)]
REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
https://bugs.webkit.org/show_bug.cgi?id=61428
<rdar://problem/9457006>

Reviewed by Adam Roben.

Source/WebKit2:

The crash occurs when Flash posts a message to a window that it
creates, and in processing the message, it calls NPN_Evaluate to
evaluate JavaScript that removes the plug-in from the page. Flash then
crashes when we return to Flash code.

* Platform/WorkItem.h:
(DerefWorkItem::DerefWorkItem):
Initialize m_ptr.
(DerefWorkItem::execute):
Deref the object.
(WorkItem::createDeref):
Create and return a DerefWorkItem.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::unprotectPluginFromDestruction):
If the PluginView has only one reference left, deref it asynchronously.

Tools:

The crash occurs when Flash posts a message to a window that it
creates, and in processing the message, it calls NPN_Evaluate to
evaluate JavaScript that removes the plug-in from the page. Flash then
crashes when we return to Flash code.

This test emulates that behavior.

* DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
(CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
Initialize member vars.
(CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
Remove our custom property from the message window, and destroy it.
(CallJSThatDestroysPlugin::NPP_Destroy):
Set m_isDestroyed, log that the plug-in was destroyed, and notify the
layout test controller that we're done.
(wndProc):
Get the PluginTest object, and call its runTest() function.
(CallJSThatDestroysPlugin::NPP_New):
Setup the test: register a class for the message-only window, create
it, and post a message to it to run the test.
(CallJSThatDestroysPlugin::runTest):
Execute JS that removes the plug-in from the page, and if we're not
destroyed, log a success message.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
Add new test to project.

LayoutTests:

* platform/win/plugins/call-javascript-that-destroys-plugin-expected.txt: Added.
* platform/win/plugins/call-javascript-that-destroys-plugin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Wed, 25 May 2011 21:47:39 +0000 (21:47 +0000)]
2011-05-25  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson.

        Fix media element regression where ended event stopped firing after changing the src attribute.

        https://bugs.webkit.org/show_bug.cgi?id=61336

        * media/media-ended-expected.txt: Added.
        * media/media-ended.html: Added.
2011-05-25  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson.

        Fix media element regression where ended event stopped firing after changing the src attribute.

        https://bugs.webkit.org/show_bug.cgi?id=61336

        Test: media/media-ended.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::prepareForLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 25 May 2011 21:38:31 +0000 (21:38 +0000)]
2011-05-25  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
        https://bugs.webkit.org/show_bug.cgi?id=61461

        * fullscreen/full-screen-iframe-legacy-expected.txt: Added.
        * fullscreen/full-screen-iframe-legacy.html: Added.
        * fullscreen/resources/legacy.html: Added.
2011-05-25  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        REGRESSION: Fullscreen button on embedded Vimeo videos does nothing
        https://bugs.webkit.org/show_bug.cgi?id=61461

        Tests: fullscreen/full-screen-iframe-legacy.html

        Allow calls from the legacy full-screen API to bypass the iframe
        "webkitallowfullscreen" requirement by adding a parameter to
        Document::webkitRequestFullScreenForElement specifying the strictness
        of that check.  Specify this new parameter everywhere that function is
        called, including in the default controls' full-screen button handler.

        * dom/Document.cpp:
        (WebCore::Document::webkitRequestFullScreenForElement):
        * dom/Document.h:
        * dom/Element.cpp:
        (WebCore::Element::requestFullScreen): Renamed from webkitRequestFullScreen.
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::enterFullscreen):
        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 25 May 2011 21:33:15 +0000 (21:33 +0000)]
2011-05-25  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        webkitpy's NetworkTransaction shouldn't use mechanize
        https://bugs.webkit.org/show_bug.cgi?id=61450

        mechanize.HTTPError is just an alias for urllib2.HTTPError, so
        use urllib2 directly.  Re-add NetworkTransaction to
        test_results_uploader.py (reverting r87124).

        * Scripts/webkitpy/common/net/networktransaction.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Missing update for expected results in LayoutTests after r87315
caio.oliveira@openbossa.org [Wed, 25 May 2011 21:31:37 +0000 (21:31 +0000)]
[Qt] Missing update for expected results in LayoutTests after r87315
https://bugs.webkit.org/show_bug.cgi?id=61467

Reviewed by Andreas Kling.

We now expose __qt_sender__ as a non-enumarated property in the
global object. Fix our expectations in relevant tests.

* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>
commit-queue@webkit.org [Wed, 25 May 2011 21:29:32 +0000 (21:29 +0000)]
2011-05-25  Kulanthaivel Palanichamy  <kulanthaivel@codeaurora.org>

        Reviewed by David Hyatt.

        Selector matching doesn't update when DOM changes ("[data-a=x] #x")
        https://bugs.webkit.org/show_bug.cgi?id=60752

        Added test cases for all the attribute selector types (CSS2.1 & CSS3).

        * fast/css/attribute-selector-begin-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-begin-dynamic-no-elementstyle.html: Added.
        * fast/css/attribute-selector-contain-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-contain-dynamic-no-elementstyle.html: Added.
        * fast/css/attribute-selector-end-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-end-dynamic-no-elementstyle.html: Added.
        * fast/css/attribute-selector-exact-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-exact-dynamic-no-elementstyle.html: Added.
        * fast/css/attribute-selector-hyphen-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-hyphen-dynamic-no-elementstyle.html: Added.
        * fast/css/attribute-selector-list-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-list-dynamic-no-elementstyle.html: Added.
        * fast/css/attribute-selector-set-dynamic-no-elementstyle-expected.txt: Added.
        * fast/css/attribute-selector-set-dynamic-no-elementstyle.html: Added.
2011-05-25  Kulanthaivel Palanichamy  <kulanthaivel@codeaurora.org>

        Reviewed by David Hyatt.

        Selector matching doesn't update when DOM changes ("[data-a=x] #x")
        https://bugs.webkit.org/show_bug.cgi?id=60752

        Currently CSSStyleSelector maintains a HashSet of attributes (m_selectorAttrs)
        which are used in CSS attribute selectors to determine the need for style
        recalculation whenever element attributes are manipulated in DOM.
        In certain conditions (element with no style, element is styled and attribute
        is not a mapped attribute, attribute is of type 'type' or read-only)
        even when attribute selector matches for an element, the attribute is not
        added to m_selectorAttrs. This results in missing style recalculations
        when a DOM element attribute is changed and is not found in m_selectorAttrs.

        Removing the above said conditions in
        CSSStyleSelector::SelectorChecker::checkOneSelector() for registering
        attributes in m_selectorAttrs will solve this issue. But this particular
        function is called numerous times which triggers adding duplicate attributes
        again and again.

        This patch follows the approach taken for collecting ids in selectors, where
        all the attributes in selectors are added to a HashSet at the time of adding
        style rules to CSSStyleSelector from StyleSheets and when
        CSSStyleSelector::hasSelectorForAttribute() is called, the attribute is
        simply looked up in this pre-populated hash set.

        Test: fast/css/attribute-selector-dynamic-no-elementstyle.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
        (WebCore::CSSStyleSelector::checkSelector):
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        (WebCore::collectFeaturesFromSelector):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::hasSelectorForAttribute):
        * css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Wed, 25 May 2011 21:23:05 +0000 (21:23 +0000)]
2011-05-25  Adam Klein  <adamk@chromium.org>

        Unreviewed. Update chromium expectations after r87307.

        * platform/chromium/test_expectations.txt: suppress, WK61470.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 25 May 2011 20:32:37 +0000 (20:32 +0000)]
2011-05-25  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by James Robinson.

        CSSStyleSelector should provide a way to obtain rules from non-author stylesheets
        https://bugs.webkit.org/show_bug.cgi?id=61454

        Replaced bool and enum arguments of styleRulesForElement and pseudoStyleRulesForElement
        by one enum, and provided a way to obtain rules from UA/user stylesheets.

        * css/CSSRule.h: Removed CSSRuleFilter.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::styleRulesForElement): See above.
        (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto.
        * css/CSSStyleSelector.h: Moved CSSRuleFilter here.
        * editing/markup.cpp:
        (WebCore::styleFromMatchedRulesForElement): Calls styleRulesForElement.
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getStylesForNode): Ditto.
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::getMatchedCSSRules): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 25 May 2011 19:37:18 +0000 (19:37 +0000)]
2011-05-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Geoffrey Garen.

        Removed MarkSetProperties because it was unused
        https://bugs.webkit.org/show_bug.cgi?id=61418

        * heap/MarkStack.h:
        (JSC::MarkSet::MarkSet):
        (JSC::MarkStack::append):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::visitChildren):
        * runtime/JSArray.h:
        (JSC::JSArray::visitChildrenDirect):
        * runtime/JSPropertyNameIterator.cpp:
        (JSC::JSPropertyNameIterator::visitChildren):
        * runtime/WriteBarrier.h:
        (JSC::MarkStack::appendValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Wed, 25 May 2011 19:28:22 +0000 (19:28 +0000)]
2011-05-25  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] JSC bridge: implement __qt_sender__ without using Scope Chain
        https://bugs.webkit.org/show_bug.cgi?id=61343

        Create a stack to keep track of the sender objects. This is simpler than
        the similar mechanism in QObject (C++ API), that keeps a stack per-object.

        Since we do not support multiple threads, one static stack will be enough for
        handling the behavior.

        This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::qtSenderStack):
        We have one static stack of QObject*. The top of the stack contains the
        last object that emitted signal that called a JavaScript function.

        * bridge/qt/qt_instance.h:
        (JSC::Bindings::QtInstance::QtSenderStack::top):
        (JSC::Bindings::QtInstance::QtSenderStack::push):
        (JSC::Bindings::QtInstance::QtSenderStack::pop):
        Minimal functionality to manipulate the sender stack.

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtConnectionObject::execute):
        Remove the previous code that modified the scope chain. Push the sender object
        to the stack before calling the JavaScript function (the "slot" in Qt-speak) and
        pop it afterwards.
2011-05-25  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] JSC bridge: implement __qt_sender__ without using Scope Chain
        https://bugs.webkit.org/show_bug.cgi?id=61343

        Create a '__qt_sender__' property in the global object, that returns the top of
        the qtSenderStack. This is an alternative implementation for the feature of
        providing a way for a function (acting as a Qt 'slot') discover which object
        emitted the signal that caused it to be executed.

        This reduces the coupling of the Qt bridge and JSC internal implementation. The
        patch tries to use as much JSC public API as possible.

        This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
        Instead of emitting the QWebPage::javaScriptWindowObjectCleared() directly, calls
        a QWebPagePrivate function to do it.

        * Api/qwebframe_p.h:
        * Api/qwebframe.cpp:
        (QWebFramePrivate::didClearedWindowObject):
        Before emitting the signal mentioned, adds the '__qt_sender__' to the fresh
        global object.

        (qtSenderCallback):
        Returns the JSObjectRef corresponding to the top of qtSenderStack.

        (QWebFramePrivate::addQtSenderToGlobalObject):
        Create a property with a qtSenderCallback as getter function in the global object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed build fix, do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
kevino@webkit.org [Wed, 25 May 2011 19:25:50 +0000 (19:25 +0000)]
[Chromium] Unreviewed build fix, do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
until the port begins using those export macros.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 25 May 2011 19:23:39 +0000 (19:23 +0000)]
2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87257.
        http://trac.webkit.org/changeset/87257
        https://bugs.webkit.org/show_bug.cgi?id=61457

        This broke layout tests, see bug 61431. (Requested by
        hwennborg on #webkit).

        * storage/indexeddb/migrate-basics-expected.txt: Removed.
        * storage/indexeddb/migrate-basics.html: Removed.
2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87257.
        http://trac.webkit.org/changeset/87257
        https://bugs.webkit.org/show_bug.cgi?id=61457

        This broke layout tests, see bug 61431. (Requested by
        hwennborg on #webkit).

        * storage/IDBBackingStore.h:
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBFactoryBackendImpl.h:
        * storage/IDBFactoryBackendInterface.h:
        * storage/IDBLevelDBBackingStore.cpp:
        * storage/IDBLevelDBBackingStore.h:
        * storage/IDBSQLiteBackingStore.cpp:
        * storage/IDBSQLiteBackingStore.h:
2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87257.
        http://trac.webkit.org/changeset/87257
        https://bugs.webkit.org/show_bug.cgi?id=61457

        This broke layout tests, see bug 61431. (Requested by
        hwennborg on #webkit).

        * public/WebIDBFactory.h:
        * src/AssertMatchingEnums.cpp:
        * src/IDBFactoryBackendProxy.cpp:
        * src/IDBFactoryBackendProxy.h:
        * src/WebIDBFactoryImpl.cpp:
        (WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
        (WebKit::WebIDBFactoryImpl::open):
        * src/WebIDBFactoryImpl.h:
2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87257.
        http://trac.webkit.org/changeset/87257
        https://bugs.webkit.org/show_bug.cgi?id=61457

        This broke layout tests, see bug 61431. (Requested by
        hwennborg on #webkit).

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::clearAllDatabases):
        * DumpRenderTree/chromium/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 25 May 2011 19:22:25 +0000 (19:22 +0000)]
2011-05-25  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Eric Carlson.

        [Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=61279

        Enable the QuickTime backend for the Qt port on Mac. The patch adds the bits in WebCore
        to enable the QTKit backend of the Mac port. It can be enabled by passing DEFINES+=USE_QTKIT=1
        when calling build-webkit.

        * WebCore.pri:
        * WebCore.pro:
        * features.pri:
        * platform/KURL.h:
        * platform/SharedBuffer.h:
        * platform/cf/KURLCFNet.cpp:
        * platform/cf/SharedBufferCF.cpp:
        * platform/graphics/FloatSize.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/MediaPlayer.cpp:
        * platform/graphics/cg/FloatSizeCG.cpp:
        * platform/graphics/cg/IntRectCG.cpp:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
        (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
        (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
        (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
        (WebCore::MediaPlayerPrivateQTKit::paint):
        (-[WebCoreMovieObserver layerHostChanged:]):
        * platform/mac/KURLMac.mm:
        * platform/mac/SharedBufferMac.mm:
        (+[WebCoreSharedBufferData initialize]):
        * platform/mac/WebCoreObjCExtras.mm:
        * platform/qt/WebCoreSystemInterface.h: Added.
        * platform/qt/WebCoreSystemInterface.mm: Added.
2011-05-25  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Eric Carlson.

        [Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=61279

        Enable the usage of QuickTime backend for the Qt port. It can be enabled by
        passing DEFINES+=USE_QTKIT=1 when calling build-webkit.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
        * QtWebKit.pro:
        * WebCoreSupport/FullScreenVideoQt.cpp:
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/WebSystemInterface.h: Added.
        * WebCoreSupport/WebSystemInterface.mm: Added.
        (InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
qi.2.zhang@nokia.com [Wed, 25 May 2011 19:20:29 +0000 (19:20 +0000)]
2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] fast/css/disabled-author-styles.html failed
        https://bugs.webkit.org/show_bug.cgi?id=61438

        Unskip test case and provide expect result files.

        * platform/qt/Skipped:
        * platform/qt/fast/css/disabled-author-styles-expected.png: Added.
        * platform/qt/fast/css/disabled-author-styles-expected.txt: Added.
2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] fast/css/disabled-author-styles.html failed
        https://bugs.webkit.org/show_bug.cgi?id=61438

        Provided API setAuthorAndUserStylesEnabled for DumpRenderTree.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::setAuthorAndUserStylesEnabled):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] fast/css/disabled-author-styles.html failed
        https://bugs.webkit.org/show_bug.cgi?id=61438

        Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setAuthorAndUserStylesEnabled):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Wed, 25 May 2011 19:01:46 +0000 (19:01 +0000)]
2011-05-25  Rob Buis  <rbuis@rim.com>

        Reviewed by Eric Seidel.

        WebKit does not handle missing filter elements correctly
        https://bugs.webkit.org/show_bug.cgi?id=12569

        Updated improved pixel test result and add new SVG1.1 SE test and results.

        * platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
        * platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
        * svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg: Added.
2011-05-25  Rob Buis  <rbuis@rim.com>

        Reviewed by Eric Seidel.
        New test rubber-stamped by Dirk Schulze.

        WebKit does not handle missing filter elements correctly
        https://bugs.webkit.org/show_bug.cgi?id=12569

        Do not render elements that reference non-existant filters.

        Test: svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg

        * rendering/svg/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::prepareToRenderSVGContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 25 May 2011 18:51:27 +0000 (18:51 +0000)]
2011-05-25  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Put view-source documents in a unique origin and always allow them to run scripts. This ensures tools like
        XMLViewer work even when scripts are disabled, while still providing the protections expected when scripts are disabled.
        https://bugs.webkit.org/show_bug.cgi?id=59113

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::canExecuteScripts): Check whether the document is viewing source, and allow scripts in that case.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchUARules):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::setIsViewSource): Renamed from setUsesViewSourceStyles(), set's a unique security origin if we are viewing source.
        * dom/Document.h:
        (WebCore::Document::isViewSource): Renamed from usesViewSourceStyles().
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::receivedFirstData):
        * xml/XMLTreeViewer.cpp:
        (WebCore::XMLTreeViewer::transformDocumentToTreeView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 25 May 2011 18:48:25 +0000 (18:48 +0000)]
2011-05-25  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make allocations with guard pages ensure that the allocation succeeded
        https://bugs.webkit.org/show_bug.cgi?id=61453

        Add null checks, and make PageBlock's operator bool() use
        the realbase, rather than the start of usable memory.

        * wtf/OSAllocatorPosix.cpp:
        (WTF::OSAllocator::reserveAndCommit):
        * wtf/PageBlock.h:
        (WTF::PageBlock::operator bool):
        (WTF::PageBlock::PageBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Julien Chaffraix <jchaffraix@codeaurora.org>
jchaffraix@webkit.org [Wed, 25 May 2011 18:45:56 +0000 (18:45 +0000)]
2011-05-25  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by James Robinson.

        http://philip.html5.org/tests/canvas/suite/tests/2d.composite.uncovered.fill.source-in.html fails
        https://bugs.webkit.org/show_bug.cgi?id=39027

        And:

        - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.source-out.html
          https://bugs.webkit.org/show_bug.cgi?id=48295

        - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-in.html
          https://bugs.webkit.org/show_bug.cgi?id=48304

        - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-out.html
        https://bugs.webkit.org/show_bug.cgi?id=48305

        * canvas/philip/tests/2d.composite.uncovered.pattern.source-in-expected.txt:
        * canvas/philip/tests/2d.composite.uncovered.pattern.source-out-expected.txt:
        Those 2 tests need a trailing line that was added as part of this change.

        * fast/canvas/canvas-composite-alpha.html: Updated the test result to match the specification.
        The changes are fairly simple:
          - Clear up the destination rectangle as it should be always transparent now (source is transparent
            outside the source rectangle).
          - Clear the composition rectangle if source or destination is transparent.
          - Fixed the test when run in the browser.
        Validated the changes against FF and Opera (IE 9 cannot render this test).

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        Re-enable 4 tests.
2011-05-25  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by James Robinson.

        http://philip.html5.org/tests/canvas/suite/tests/2d.composite.uncovered.fill.source-in.html fails
        https://bugs.webkit.org/show_bug.cgi?id=39027

        And:

        - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.source-out.html
          https://bugs.webkit.org/show_bug.cgi?id=48295

        - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-in.html
          https://bugs.webkit.org/show_bug.cgi?id=48304

        - Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.source-out.html
        https://bugs.webkit.org/show_bug.cgi?id=48305

        Those 4 tests have the same root cause for failing. Instead of splitting them in 2 fixes, I squashed
        them together as the fix is common.

        Based on an older work by Ariya Hidayat.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::fill):
        (WebCore::CanvasRenderingContext2D::fillRect): Added call displayTransparencyEverywhere for those 2
        cases if we have to.

        (WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyEverywhere): This method returns true if
        the spec says to display transparency everywhere. We only do so for source-in and source-out for now.
        (WebCore::CanvasRenderingContext2D::displayTransparencyEverywhere): This method implements the spec
        (which matches other browsers' behavior) and "display transparency elsewhere".

        * html/canvas/CanvasRenderingContext2D.h: Added the two previous methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-20 Robert Hogan <robert@webkit.org>
robert@webkit.org [Wed, 25 May 2011 17:58:48 +0000 (17:58 +0000)]
2011-05-20  Robert Hogan  <robert@webkit.org>

        Reviewed by Geoffrey Garen.

        [Qt/Gtk/Chromium] Fix plugins/embed-attributes-setting.html

        Use the test netscape plugin instead of quicktime.
        Allows the test to pass on Qt/Gtk/Chromium as well as Mac.

        https://bugs.webkit.org/show_bug.cgi?id=61182
        http://code.google.com/p/chromium/issues/detail?id=15797

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * plugins/embed-attributes-setting-expected.txt:
        * plugins/embed-attributes-setting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9496795> REGRESSION (r86851): Plug-ins disappear when scrolled with...
mitz@apple.com [Wed, 25 May 2011 17:22:23 +0000 (17:22 +0000)]
<rdar://problem/9496795> REGRESSION (r86851): Plug-ins disappear when scrolled with non-1 page scale
https://bugs.webkit.org/show_bug.cgi?id=61448

Reviewed by Anders Carlsson.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::clipRectInWindowCoordinates): Correct for page scale
after intersecting the two rectangles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Eric Seidel.
kevino@webkit.org [Wed, 25 May 2011 17:10:03 +0000 (17:10 +0000)]
Reviewed by Eric Seidel.

Add JS_EXPORT_PRIVATE macro for exported methods in bytecompiler headers.

https://bugs.webkit.org/show_bug.cgi?id=27551

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 25 May 2011 17:06:32 +0000 (17:06 +0000)]
2011-05-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Add IntPoint versions of IntRect::move and IntPoint::move
        https://bugs.webkit.org/show_bug.cgi?id=61390

        Adding move methods to IntRect and IntPoint that take an IntPoint
        that's acting as an offset. Since we also apply negative offsets,
        also adding a single parameter operator- for IntPoint.

        No new tests since this is refactoring.

        * page/FrameView.cpp:
        (WebCore::FrameView::invalidateScrollbarRect):
        (WebCore::FrameView::convertFromRenderer):
        (WebCore::FrameView::convertToRenderer):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::wheelEvent):
        * platform/ScrollView.h:
        (WebCore::ScrollView::convertChildToSelf):
        (WebCore::ScrollView::convertSelfToChild):
        * platform/ScrollbarThemeComposite.cpp:
        (WebCore::ScrollbarThemeComposite::invalidatePart):
        * platform/graphics/IntPoint.h:
        (WebCore::IntPoint::move):
        (WebCore::operator-):
        * platform/graphics/IntRect.h:
        (WebCore::IntRect::move):
        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::requestedRegionOfInputImageData):
        * platform/graphics/gpu/Texture.cpp:
        (WebCore::Texture::updateSubRect):
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::paint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::logicalRectToPhysicalRect):
        (WebCore::RenderBlock::selectionGaps):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::offsetFromContainer):
        (WebCore::RenderBox::computeRectForRepaint):
        (WebCore::RenderBox::localCaretRect):
        * rendering/RenderDetailsMarker.cpp:
        (WebCore::RenderDetailsMarker::paint):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
        * rendering/RenderInputSpeech.cpp:
        (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::paintScrollbar):
        (WebCore::RenderLayerBacking::paintContents):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::paintScrollbar):
        (WebCore::RenderLayerCompositor::paintContents):
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::positionListMarker):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::computeRectForRepaint):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::repaintViewRectangle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 25 May 2011 17:04:47 +0000 (17:04 +0000)]
2011-05-25  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch addFocusRingRects to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=60783

        Switching addFocusRingRects to use an IntPoint representing the offset being
        applied instead of a pair of ints.

        No new tests as this is only refactoring.

        * platform/graphics/FloatSize.h:
        (WebCore::flooredIntPoint):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addFocusRingRects):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::addFocusRingRects):
        * rendering/RenderBox.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::addFocusRingRects):
        * rendering/RenderInline.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::addFocusRingRects):
        * rendering/RenderListBox.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintFocusRing):
        (WebCore::RenderObject::absoluteFocusRingQuads):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::addFocusRingRects):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::addFocusRingRects):
        * rendering/RenderTextControl.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::addFocusRingRects):
        * rendering/RenderTextControlSingleLine.h:
        * rendering/svg/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::addFocusRingRects):
        * rendering/svg/RenderSVGContainer.h:
        * rendering/svg/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::addFocusRingRects):
        * rendering/svg/RenderSVGImage.h:
        * rendering/svg/RenderSVGPath.cpp:
        (WebCore::RenderSVGPath::addFocusRingRects):
        * rendering/svg/RenderSVGPath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 25 May 2011 16:50:53 +0000 (16:50 +0000)]
2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87229.
        http://trac.webkit.org/changeset/87229
        https://bugs.webkit.org/show_bug.cgi?id=61445

        Lots of tests crashing in
        CFNetwork!URLResponse::createFilenameFromResponseHeaders on
        Windows XP (Requested by aroben on #webkit).

        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::suggestedFilename):
        (WebCore::ResourceResponseBase::setSuggestedFilename):
        (WebCore::ResourceResponseBase::httpStatusText):
        (WebCore::ResourceResponseBase::setHTTPStatusText):
        (WebCore::ResourceResponseBase::httpHeaderField):
        (WebCore::ResourceResponseBase::setHTTPHeaderField):
        (WebCore::ResourceResponseBase::httpHeaderFields):
        (WebCore::ResourceResponseBase::isAttachment):
        (WebCore::ResourceResponseBase::setLastModifiedDate):
        (WebCore::ResourceResponseBase::lastModifiedDate):
        (WebCore::ResourceResponseBase::wasCached):
        (WebCore::ResourceResponseBase::connectionReused):
        (WebCore::ResourceResponseBase::setConnectionReused):
        (WebCore::ResourceResponseBase::connectionID):
        (WebCore::ResourceResponseBase::setConnectionID):
        (WebCore::ResourceResponseBase::resourceLoadTiming):
        (WebCore::ResourceResponseBase::setResourceLoadTiming):
        (WebCore::ResourceResponseBase::resourceLoadInfo):
        (WebCore::ResourceResponseBase::setResourceLoadInfo):
        * platform/network/ResourceResponseBase.h:
        * platform/network/cf/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        * platform/network/cf/ResourceResponseCFNet.cpp:
        (WebCore::ResourceResponse::platformLazyInit):
        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::platformLazyInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Leon Scroggins <scroggo@google.com>
commit-queue@webkit.org [Wed, 25 May 2011 16:48:03 +0000 (16:48 +0000)]
2011-05-25  Leon Scroggins  <scroggo@google.com>

        Reviewed by Steve Block.

        Update chromium expectations for more canvas fixes.
        https://bugs.webkit.org/show_bug.cgi?id=61433

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIdentify, rather than skip, builds where run-webkit-tests exited early due to too...
aroben@apple.com [Wed, 25 May 2011 16:38:29 +0000 (16:38 +0000)]
Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures

Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
started exiting early due to too many crashes, timeouts, or failures

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
run-webkit-tests exits early due to too many failures, pass that information in another
argument to the callback.
(Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
the new structure of the object passed to the callback.
(Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
getNumberOfFailingTests and to pass that along to our own callbacks.
(Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
from _getFailingTests and to store that value in the history object.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(.info): Added.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder): Updated for change in structure to the history
object and to add a note when run-webkit-tests exited early due to too many failures.
(ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
latestBuildInfos since each entry now contains more than just the tester and failure count.
Now displays a message for testers where the latest build exited early due to too many
failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
store that value in latestBuildInfos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Wed, 25 May 2011 16:33:57 +0000 (16:33 +0000)]
2011-05-25  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Antonio Gomes.

        [Qt] QtWebKit crashes when dragging not loaded images
        https://bugs.webkit.org/show_bug.cgi?id=61314

        Checks if WebKit crashes when dragging an image not yet loaded.

        * http/tests/misc/drag-not-loaded-image-expected.txt: Added.
        * http/tests/misc/drag-not-loaded-image.html: Added.
2011-05-25  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Antonio Gomes.

        [Qt] QtWebKit crashes when dragging not loaded images
        https://bugs.webkit.org/show_bug.cgi?id=61314

        Checks if nativeImageForCurrentFrame is a valid pointer.

        Test: http/tests/misc/drag-not-loaded-image.html

        * platform/qt/DragImageQt.cpp:
        (WebCore::createDragImageFromImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Wed, 25 May 2011 16:27:30 +0000 (16:27 +0000)]
2011-05-25  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Xan Lopez.

        [GTK] combobox and scrollbar are rendered small size at gtk+2.22.0
        https://bugs.webkit.org/show_bug.cgi?id=61436

        Fix arguments of gdk_drawable_get_size.

        No new tests, no behavior change.

        * platform/gtk/GtkVersioning.c:
        (getGdkDrawableSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 25 May 2011 14:58:32 +0000 (14:58 +0000)]
2011-05-25  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Skipped 3 new inspector tests that time out on gtk.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Gabor Loki <loki@webkit.org>
loki@webkit.org [Wed, 25 May 2011 14:20:23 +0000 (14:20 +0000)]
2011-05-25  Gabor Loki  <loki@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt] Skip failed tests after r87290 and r87292 on ARM

        * platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-23 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 25 May 2011 14:02:10 +0000 (14:02 +0000)]
2011-05-23  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extreme lagging when searching for "img[src*="
        https://bugs.webkit.org/show_bug.cgi?id=61282

        No new tests, as this is a refactoring: ElementsTreeElement DOM is manipulated directly
        when built and search-highlighted, rather than through innerHTML.

        * inspector/front-end/DOMSyntaxHighlighter.js:
        (WebInspector.DOMSyntaxHighlighter):
        (WebInspector.DOMSyntaxHighlighter.prototype.createSpan):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.highlightSearchResults):
        (WebInspector.ElementsTreeElement.prototype.hideSearchHighlights):
        (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryShow):
        (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight.updateEntryHide):
        (WebInspector.ElementsTreeElement.prototype._updateSearchHighlight):
        (WebInspector.ElementsTreeElement.prototype._addNewAttribute):
        (WebInspector.ElementsTreeElement.prototype.updateTitle):
        (WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
        ():
        * inspector/front-end/utilities.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Leandro Gracia Gil <leandrogracia@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 12:34:04 +0000 (12:34 +0000)]
2011-05-25  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Tony Gentilcore.

        Introduce HTML5 track list objects.
        https://bugs.webkit.org/show_bug.cgi?id=60184

        Introduce the TrackList, MultipleTrackList and ExclusiveTrackList objects
        for their use in the MediaStream API and the HTML Media Element.
        Current spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#tracklist

        The Media Stream API will test this feature in the bug 56587.
        More tests related to the HTML Media Element may be added later.

        * CMakeLists.txt:
        * CodeGenerators.pri:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventTarget.cpp:
        (WebCore::toJS):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
        * dom/DOMAllInOne.cpp:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::toTrackList):
        (WebCore::EventTarget::toMultipleTrackList):
        (WebCore::EventTarget::toExclusiveTrackList):
        * dom/EventTarget.h:
        * dom/ExclusiveTrackList.cpp: Added.
        (WebCore::ExclusiveTrackList::create):
        (WebCore::ExclusiveTrackList::ExclusiveTrackList):
        (WebCore::ExclusiveTrackList::~ExclusiveTrackList):
        (WebCore::ExclusiveTrackList::clear):
        (WebCore::ExclusiveTrackList::select):
        (WebCore::ExclusiveTrackList::toExclusiveTrackList):
        * dom/ExclusiveTrackList.h: Added.
        (WebCore::ExclusiveTrackList::selectedIndex):
        * dom/ExclusiveTrackList.idl: Added.
        * dom/MultipleTrackList.cpp: Added.
        (WebCore::MultipleTrackList::create):
        (WebCore::MultipleTrackList::MultipleTrackList):
        (WebCore::MultipleTrackList::~MultipleTrackList):
        (WebCore::MultipleTrackList::clear):
        (WebCore::MultipleTrackList::isEnabled):
        (WebCore::MultipleTrackList::enable):
        (WebCore::MultipleTrackList::disable):
        (WebCore::MultipleTrackList::toMultipleTrackList):
        * dom/MultipleTrackList.h: Added.
        * dom/MultipleTrackList.idl: Added.
        * dom/TrackList.cpp: Added.
        (WebCore::Track::create):
        (WebCore::Track::Track):
        (WebCore::TrackList::create):
        (WebCore::TrackList::TrackList):
        (WebCore::TrackList::~TrackList):
        (WebCore::TrackList::length):
        (WebCore::TrackList::checkIndex):
        (WebCore::TrackList::getID):
        (WebCore::TrackList::getKind):
        (WebCore::TrackList::getLabel):
        (WebCore::TrackList::getLanguage):
        (WebCore::TrackList::clear):
        (WebCore::TrackList::postChangeEvent):
        (WebCore::TrackList::dispatchChangeEvent):
        (WebCore::TrackList::toTrackList):
        (WebCore::TrackList::scriptExecutionContext):
        (WebCore::TrackList::eventTargetData):
        (WebCore::TrackList::ensureEventTargetData):
        * dom/TrackList.h: Added.
        (WebCore::Track::id):
        (WebCore::Track::kind):
        (WebCore::Track::label):
        (WebCore::Track::language):
        (WebCore::TrackList::DispatchTask::create):
        (WebCore::TrackList::DispatchTask::performTask):
        (WebCore::TrackList::DispatchTask::DispatchTask):
        (WebCore::TrackList::refEventTarget):
        (WebCore::TrackList::derefEventTarget):
        * dom/TrackList.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Keishi Hattori <keishi@webkit.org>
keishi@webkit.org [Wed, 25 May 2011 11:55:13 +0000 (11:55 +0000)]
2011-05-25  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Move ElementWithPseudoId to separate file
        https://bugs.webkit.org/show_bug.cgi?id=61430

        No new tests because no behavior changes.

        * CMakeLists.txt: Added ElementWithPseudoId.cpp
        * GNUmakefile.list.am: Added ElementWithPseudoId.{h,cpp}
        * WebCore.gypi: Added ElementWithPseudoId.{h,cpp}
        * WebCore.pro: Added ElementWithPseudoId.{h,cpp}
        * WebCore.vcproj/WebCore.vcproj: Added ElementWithPseudoId.{h,cpp}
        * WebCore.xcodeproj/project.pbxproj: Added ElementWithPseudoId.{h,cpp}
        * html/ValidationMessage.cpp: Removed ElementWithPseudoId definition.
        * html/shadow/ElementWithPseudoId.cpp: Added.
        (WebCore::ElementWithPseudoId::shadowPseudoId):
        * html/shadow/ElementWithPseudoId.h: Added.
        (WebCore::ElementWithPseudoId::create):
        (WebCore::ElementWithPseudoId::ElementWithPseudoId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Wed, 25 May 2011 11:43:46 +0000 (11:43 +0000)]
2011-05-25  Anton Muhin  <antonm@chromium.org>

        Unreviewed.

        Update test expectations after 3.3.6.1 v8 roll.

        * platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt:
        * platform/chromium-mac/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt:
        * platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-1-expected.txt:
        * platform/chromium-win/ietestcenter/Javascript/15.5.4.20-1-2-expected.txt:
        * platform/chromium/ietestcenter: Added.
        * platform/chromium/ietestcenter/Javascript: Added.
        * platform/chromium/ietestcenter/Javascript/15.4.4.14-5-28-expected.txt: Added.
        * platform/chromium/ietestcenter/Javascript/15.4.4.15-5-28-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 25 May 2011 11:39:41 +0000 (11:39 +0000)]
2011-05-25  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Antonio Gomes.

        [Qt] When QWebView has a different style set on it then the scrollbars are not rendered correctly
        https://bugs.webkit.org/show_bug.cgi?id=34635

        Make sure the scrollbar is properly rendered on Mac with another style than the Mac style. The code had
        two paths, one for Mac and one for any other styles. The problem is that on Mac you can still run the
        application with -style plastique for example, therefore the code used for other styles should also be
        used whenever the current style is not the Mac style.

        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::ScrollbarThemeQt::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 11:21:29 +0000 (11:21 +0000)]
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt: svn/dynamic-updates failing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Gabor Loki <loki@webkit.org>
loki@webkit.org [Wed, 25 May 2011 11:19:39 +0000 (11:19 +0000)]
2011-05-25  Gabor Loki  <loki@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt] Skip a flakey timed out test on ARM

        * platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 11:08:55 +0000 (11:08 +0000)]
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt: mhtml tests pass

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 11:00:08 +0000 (11:00 +0000)]
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ukai@chromium.org [Wed, 25 May 2011 10:41:39 +0000 (10:41 +0000)]
Unreviewed.

Update chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu>
commit-queue@webkit.org [Wed, 25 May 2011 10:34:20 +0000 (10:34 +0000)]
2011-05-25  Felician Marton  <marton.felician.zoltan@stud.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        Added dynamic tests for missing properties (and attributes) in TextElement. The corresponding Mac pixel test results also added.
        https://bugs.webkit.org/show_bug.cgi?id=59677

        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.png: Added.
        * svg/dynamic-updates/SVGTextElement-dom-dx-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-dx-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-dy-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-dy-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-rotate-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-x-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-x-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-dom-y-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-dom-y-attr.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-dx-prop.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-dy-prop.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-x-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-x-prop.html: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-y-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html: Added.
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-dx-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-dy-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-rotate-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-x-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-dom-y-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-dx-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-dy-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-x-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGTextElement-svgdom-y-prop.js: Added.
        (executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 25 May 2011 10:12:35 +0000 (10:12 +0000)]
2011-05-25  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Clean up WebSocket test expectations
        https://bugs.webkit.org/show_bug.cgi?id=61429

        * platform/chromium/test_expectations.txt:
        Remove two test expectations for tests that are no longer failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 25 May 2011 09:52:36 +0000 (09:52 +0000)]
2011-05-25  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Use fail() when WebSocketChannel has failed
        https://bugs.webkit.org/show_bug.cgi?id=61353

        * http/tests/websocket/tests/frame-length-overflow-expected.txt:
        Added a new console message.
2011-05-25  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Use fail() when WebSocketChannel has failed
        https://bugs.webkit.org/show_bug.cgi?id=61353

        An existing error message has been modified, but it is impossible
        to test this message in LayoutTests because it is only shown when
        memory allocation has failed, which is hard to reproduce reliably.

        One new message has been added. It is covered by an existing test
        http/tests/websocket/tests/frame-length-overflow.html.

        There is no other change in behavior. No new tests are added.

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::fail):
        Do not close if we know the socket stream is already closed. This does not
        change the behavior, because SocketStreamBase does nothing if it is already
        closed.
        (WebCore::WebSocketChannel::didOpen):
        (WebCore::WebSocketChannel::didReceiveData):
        We need to set m_shouldDiscardReceivedData to true before calling fail(),
        so I moved the error message from appendToBuffer() to here.
        The error message was rephrased in order to improve readability.
        (WebCore::WebSocketChannel::appendToBuffer):
        Unnested the code.
        (WebCore::WebSocketChannel::processBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 25 May 2011 09:35:43 +0000 (09:35 +0000)]
2011-05-16  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by David Levin.

        CSSParser: m_implicitShorthand should probably be RAII
        https://bugs.webkit.org/show_bug.cgi?id=51586

        It was impossible to entirely eliminate the m_implicitShorthand manual changes
        due to the parseFill*() method stateful call chains.

        No new tests, as this is a refactoring.

        * css/CSSParser.cpp:
        (ImplicitScope::ImplicitScope):
        (ImplicitScope::~ImplicitScope):
        (WebCore::CSSParser::parseShorthand):
        (WebCore::CSSParser::parse4Values):
        (WebCore::CSSParser::parseBorderRadius):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 25 May 2011 09:03:11 +0000 (09:03 +0000)]
2011-05-24  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: inspected page crashes when call stack is empty after live edit.
        https://bugs.webkit.org/show_bug.cgi?id=61364

        * inspector/debugger/live-edit-expected.txt:
        * inspector/debugger/live-edit.html:
        * platform/chromium/test_expectations.txt:
2011-05-24  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: inspected page crashes when call stack is empty after live edit.
        https://bugs.webkit.org/show_bug.cgi?id=61364

        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::currentCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Mads Ager <ager@chromium.org>
ager@chromium.org [Wed, 25 May 2011 07:48:53 +0000 (07:48 +0000)]
2011-05-25  Mads Ager  <ager@chromium.org>

        Reviewed by Adam Barth.

        Update chromium expectations after removal of execScript from V8
        https://bugs.webkit.org/show_bug.cgi?id=61267

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-23 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 25 May 2011 07:45:33 +0000 (07:45 +0000)]
2011-05-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
        https://bugs.webkit.org/show_bug.cgi?id=61194

        Test: inspector/console/console-eval-syntax-error.html

        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::evaluateCallback): return immediately in case of syntax error

2011-05-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console
        https://bugs.webkit.org/show_bug.cgi?id=61194

        * inspector/console/console-eval-syntax-error-expected.txt: Added.
        * inspector/console/console-eval-syntax-error.html: Added.
        * platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-25 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 25 May 2011 07:17:21 +0000 (07:17 +0000)]
2011-05-25  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Kent Tamura.

        Fix for Bug 61352 - Refactor RenderView::{enable,disable}LayoutState call sites to use RIIA
        https://bugs.webkit.org/show_bug.cgi?id=61352

        No new tests because no behavior changes.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::RenderMediaVolumeSliderContainer::layout):
        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::repaintOverhangingFloats):
        (WebCore::RenderBlock::updateFirstLetter):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):
        (WebCore::RenderLayer::updateScrollInfoAfterLayout):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::layout):
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::updateMarkerLocation):
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::layout):
        * rendering/RenderView.h:
        (WebCore::RenderView::disableLayoutState):
        (WebCore::RenderView::enableLayoutState):
        (WebCore::LayoutStateDisabler::LayoutStateDisabler):
        (WebCore::LayoutStateDisabler::~LayoutStateDisabler):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed typo fix after r87228.
ossy@webkit.org [Wed, 25 May 2011 06:42:11 +0000 (06:42 +0000)]
[Qt] Unreviewed typo fix after r87228.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake the Web Inspector bring the right window to the front when docked.
timothy@apple.com [Wed, 25 May 2011 06:37:42 +0000 (06:37 +0000)]
Make the Web Inspector bring the right window to the front when docked.

rdar://problem/9464685
https://webkit.org/b/61420

Reviewed by Brian Weinstein.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformBringToFront): Order front the parent window of the Inspector's WKView.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformBringToFront): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Keishi Hattori <keishi@webkit.org>
tkent@chromium.org [Wed, 25 May 2011 06:03:09 +0000 (06:03 +0000)]
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * configure.ac: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * fast/forms/ValidityState-typeMismatch-color-expected.txt: Removed.
        * fast/forms/ValidityState-typeMismatch-color.html: Removed.
        * fast/forms/color/input-value-sanitization-color-expected.txt: Added.
        * fast/forms/color/input-value-sanitization-color.html: Added. Tests
        sanitization algorithm for input type=color.
        * fast/forms/input-type-change3-expected.txt:
        * fast/forms/input-widths-expected.txt:
        * fast/forms/input-widths.html: Removed type=color because it
        is no loger a text input type.
        * fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Changed to range input type.
        * fast/forms/script-tests/ValidityState-typeMismatch-color.js: Removed.
        * fast/forms/script-tests/input-type-change3.js:
        * platform/gtk/Skipped: Skip fast/forms/color.
        * platform/mac/Skipped: Skip fast/forms/color.
        * platform/qt/Skipped: Skip fast/forms/color.
        * platform/win/Skipped: Skip fast/forms/color.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        Test: fast/forms/color/input-value-sanitization-color.html

        * Configurations/FeatureDefines.xcconfig: Added COLOR_INPUT feature flag.
        * GNUmakefile.am: Added COLOR_INPUT feature flag.
        * features.pri: Added COLOR_INPUT feature flag.
        * html/ColorInputType.cpp: Wrapped with COLOR_INPUT feature flag.
        (WebCore::ColorInputType::isColorControl): Added.
        (WebCore::ColorInputType::fallbackValue): Added. Fallback value defined in spec.
        (WebCore::ColorInputType::sanitizeValue): Added. Sanitize value string as defined in spec.
        * html/ColorInputType.h: Wrapped with COLOR_INPUT feature flag.
        (WebCore::ColorInputType::ColorInputType): Changed to inherit BaseButtonInputType.
        * html/InputType.cpp:
        (WebCore::InputType::isColorControl): Added.
        * html/InputType.h:
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * features.gypi: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * Configurations/FeatureDefines.xcconfig: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * Scripts/build-webkit: Added INPUT_COLOR feature flag.
2011-05-24  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Disable input color. Add INPUT_COLOR feature flag. Implement input color sanitizer.
        https://bugs.webkit.org/show_bug.cgi?id=61273

        * win/tools/vsprops/FeatureDefines.vsprops: Added INPUT_COLOR feature flag.
        * win/tools/vsprops/FeatureDefinesCairo.vsprops: Added INPUT_COLOR feature flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Skip new failing test.
ossy@webkit.org [Wed, 25 May 2011 05:56:58 +0000 (05:56 +0000)]
[Qt][WK2] Skip new failing test.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 25 May 2011 04:54:46 +0000 (04:54 +0000)]
2011-05-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Update the WebProcess sandbox exceptions to silence warnings for a file that is accessed uselessly
        https://bugs.webkit.org/show_bug.cgi?id=61349
        <rdar://problem/9476255>

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:38:26 +0000 (04:38 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/editing/selection/4895428-1 and -4 to dump-as-markup
        https://bugs.webkit.org/show_bug.cgi?id=61402

        Converts the two html files to dump-as-markup and adds doctype, html, and body tags.

        * editing/selection/4895428-1-expected.txt: Added.
        * editing/selection/4895428-1.html: Converted to dump-as-markup
        * editing/selection/4895428-4-expected.txt: Added.
        * editing/selection/4895428-4.html: Converted to dump-as-markup
        * platform/chromium-linux/editing/selection/4895428-1-expected.png: Removed.
        * platform/chromium-linux/editing/selection/4895428-4-expected.png: Removed.
        * platform/chromium-win/editing/selection/4895428-1-expected.png: Removed.
        * platform/chromium-win/editing/selection/4895428-1-expected.txt: Removed.
        * platform/chromium-win/editing/selection/4895428-4-expected.png: Removed.
        * platform/chromium-win/editing/selection/4895428-4-expected.txt: Removed.
        * platform/gtk/editing/selection/4895428-1-expected.png: Removed.
        * platform/gtk/editing/selection/4895428-1-expected.txt: Removed.
        * platform/gtk/editing/selection/4895428-4-expected.png: Removed.
        * platform/gtk/editing/selection/4895428-4-expected.txt: Removed.
        * platform/mac-leopard/editing/selection/4895428-1-expected.png: Removed.
        * platform/mac-leopard/editing/selection/4895428-4-expected.png: Removed.
        * platform/mac/editing/selection/4895428-1-expected.png: Removed.
        * platform/mac/editing/selection/4895428-1-expected.txt: Removed.
        * platform/mac/editing/selection/4895428-4-expected.png: Removed.
        * platform/mac/editing/selection/4895428-4-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Eric Seidel.
kevino@webkit.org [Wed, 25 May 2011 04:38:26 +0000 (04:38 +0000)]
Reviewed by Eric Seidel.

Add export macros to WTFString.h.

https://bugs.webkit.org/show_bug.cgi?id=27551

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:35:37 +0000 (04:35 +0000)]
2011-05-24  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Move chromium media controls timeline back to flexible rather than absolute
        layout.

        https://bugs.webkit.org/show_bug.cgi?id=61379

        * platform/chromium/test_expectations.txt: Added expected failures from this change.
2011-05-24  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        Move chromium media controls timeline back to flexible rather than absolute
        layout.

        https://bugs.webkit.org/show_bug.cgi?id=61379

        * css/mediaControlsChromium.css:
        (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
        (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 25 May 2011 04:26:04 +0000 (04:26 +0000)]
2011-05-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        Convert fast/forms/input-type-change.html to a dumpAsText() test
        https://bugs.webkit.org/show_bug.cgi?id=61029

        Merge input-type-change2 to input-type-change.html, and convert it to
        a dumpAsText() test.

        * fast/forms/input-type-change-expected.txt:
        * fast/forms/input-type-change.html:
        * fast/forms/input-type-change2.html: Removed.
        * platform/chromium-linux/fast/forms/input-type-change-expected.png: Removed.
        * platform/chromium-linux/fast/forms/input-type-change2-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/forms/input-type-change-expected.png: Removed.
        * platform/chromium-mac/fast/forms/input-type-change-expected.png: Removed.
        * platform/chromium-win/fast/forms/input-type-change-expected.png: Removed.
        * platform/chromium-win/fast/forms/input-type-change-expected.txt: Removed.
        * platform/chromium-win/fast/forms/input-type-change2-expected.png: Removed.
        * platform/chromium-win/fast/forms/input-type-change2-expected.txt: Removed.
        * platform/gtk/fast/forms/input-type-change-expected.png: Removed.
        * platform/gtk/fast/forms/input-type-change-expected.txt: Removed.
        * platform/gtk/fast/forms/input-type-change2-expected.png: Removed.
        * platform/gtk/fast/forms/input-type-change2-expected.txt: Removed.
        * platform/mac-leopard/fast/forms/input-type-change-expected.png: Removed.
        * platform/mac-leopard/fast/forms/input-type-change2-expected.png: Removed.
        * platform/mac/fast/forms/input-type-change-expected.png: Removed.
        * platform/mac/fast/forms/input-type-change-expected.txt:
        * platform/mac/fast/forms/input-type-change-expected.txt: Removed.
        * platform/mac/fast/forms/input-type-change2-expected.png: Removed.
        * platform/mac/fast/forms/input-type-change2-expected.txt: Removed.
        * platform/qt-arm/Skipped: Remove input-type-change2.html.
        * platform/qt-mac/Skipped: ditto.
        * platform/qt/fast/forms/input-type-change-expected.txt: Removed.
        * platform/qt/fast/forms/input-type-change2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fix clang error.
ukai@chromium.org [Wed, 25 May 2011 04:20:02 +0000 (04:20 +0000)]
Unreviewed. Fix clang error.

error: initialization of pointer of type 'WebCore::MHTMLArchive *' to
NULL from a constant boolean expression [-Werror,-Wbool-conversio

* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:17:03 +0000 (04:17 +0000)]
2011-05-24  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Hajime Morita.

        <legend> element is dropped on the floor
        https://bugs.webkit.org/show_bug.cgi?id=18691

        * html5lib/resources/webkit02.dat: Added a passing
        test for <legend> parsing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:14:51 +0000 (04:14 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Tony Chang.

        editing/deleting/5032066 should be a dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=61327

        Converts 5032066 to dump-as-markup and adds doctype, html, and body tags.

        * editing/deleting/5032066-expected.txt: Added.
        * editing/deleting/5032066.html:
        * platform/chromium-linux/editing/deleting/5032066-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5032066-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5032066-expected.txt: Removed.
        * platform/gtk/editing/deleting/5032066-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/5032066-expected.png: Removed.
        * platform/mac/editing/deleting/5032066-expected.png: Removed.
        * platform/mac/editing/deleting/5032066-expected.txt: Removed.
        * platform/qt/editing/deleting/5032066-expected.png: Removed.
        * platform/qt/editing/deleting/5032066-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 04:04:03 +0000 (04:04 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/editing/deleting/5115601.html to dump-as-markup.
        https://bugs.webkit.org/show_bug.cgi?id=61330

        Converted to dump-as-markup and added a little html cleanup.

        * editing/deleting/5115601-expected.txt: Added.
        * editing/deleting/5115601.html: Convert to dump-as-markup.
        * platform/chromium-linux/editing/deleting/5115601-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5115601-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5115601-expected.txt: Removed.
        * platform/gtk/editing/deleting/5115601-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/5115601-expected.png: Removed.
        * platform/mac/editing/deleting/5115601-expected.png: Removed.
        * platform/mac/editing/deleting/5115601-expected.txt: Removed.
        * platform/qt/editing/deleting/5115601-expected.png: Removed.
        * platform/qt/editing/deleting/5115601-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 03:50:54 +0000 (03:50 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/editing/deleting/5206311-2.html to dump-as-markup
        https://bugs.webkit.org/show_bug.cgi?id=61332

        Used dump-as-markup to improve readability of results.
        Also improved HTML and cleaned up descriptions.

        * editing/deleting/5206311-2-expected.txt: Added.
        * editing/deleting/5206311-2.html: Convert to dump-as-markup.
        * platform/chromium-linux/editing/deleting/5206311-2-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5206311-2-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5206311-2-expected.txt: Removed.
        * platform/gtk/editing/deleting/5206311-2-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/5206311-2-expected.png: Removed.
        * platform/mac/editing/deleting/5206311-2-expected.png: Removed.
        * platform/mac/editing/deleting/5206311-2-expected.txt: Removed.
        * platform/qt/editing/deleting/5206311-2-expected.png: Removed.
        * platform/qt/editing/deleting/5206311-2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 03:39:22 +0000 (03:39 +0000)]
2011-05-24  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert LayoutTests/editing/deleting/delete-block-table.html to dumpAsText test.
        https://bugs.webkit.org/show_bug.cgi?id=61333

        Converts delete-block-table.html to dumpAsText test by changing to use runDumpAsTextEditingTest.

        * editing/deleting/delete-block-table-expected.txt: Added.
        * editing/deleting/delete-block-table.html: Converted to dump-as-markup.
        * platform/chromium-linux/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/chromium-win/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/chromium-win/editing/deleting/delete-block-table-expected.txt: Removed.
        * platform/gtk/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/gtk/editing/deleting/delete-block-table-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/mac/editing/deleting/delete-block-table-expected.png: Removed.
        * platform/mac/editing/deleting/delete-block-table-expected.txt: Removed.
        * platform/qt/editing/deleting/delete-block-table-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 25 May 2011 03:39:21 +0000 (03:39 +0000)]
2011-05-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add FIXME comments about removing FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=61395

        All the callers of the API are wrong.  They should call the more modern
        static member function of ScriptController instead.  I'll remove the
        FrameLoader function in a future patch.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::processingUserGesture):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::click):
2011-05-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add FIXME comments about removing FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=61395

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::isProcessingUserGesture):
2011-05-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add FIXME comments about removing FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=61395

        * WebView/WebView.mm:
        (-[WebView _isProcessingUserGesture]):
2011-05-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add FIXME comments about removing FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=61395

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (drtPrintFrameUserGestureStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Justin Novosad <junov@chromium.org>
commit-queue@webkit.org [Wed, 25 May 2011 03:28:18 +0000 (03:28 +0000)]
2011-05-24  Justin Novosad  <junov@chromium.org>

        Reviewed by Stephen White.

        [Chromium] cleanup test expectations for drawImage that are no longer
        flaky
        https://bugs.webkit.org/show_bug.cgi?id=61389

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Wed, 25 May 2011 03:03:46 +0000 (03:03 +0000)]
2011-05-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed. Fix style error.

        * platform/efl/WidgetEfl.cpp:
        (WebCore::WidgetPrivate::WidgetPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87258 268f45cc-cd09-0410-ab3c-d52691b4dbfc