WebKit-https.git
9 years agoUnreviewed. Rebaselines for r120477.
inferno@chromium.org [Fri, 15 Jun 2012 20:00:56 +0000 (20:00 +0000)]
Unreviewed. Rebaselines for r120477.

* platform/chromium-linux/fast/forms/formmove3-expected.txt:
* platform/chromium-win/editing/deleting/delete-3800834-fix-expected.txt:
* platform/chromium-win/fast/dynamic/011-expected.txt:
* platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
* platform/chromium-win/fast/invalid/001-expected.txt:
* platform/chromium-win/fast/invalid/003-expected.txt:
* platform/chromium-win/fast/invalid/004-expected.txt:
* platform/chromium-win/fast/invalid/007-expected.txt:
* platform/chromium-win/fast/invalid/019-expected.txt:
* platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug647-expected.txt:
* platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd new Pointer Lock spec webkitRequestPointerLock and webkitExitPointerLock methods.
scheib@chromium.org [Fri, 15 Jun 2012 19:53:27 +0000 (19:53 +0000)]
Add new Pointer Lock spec webkitRequestPointerLock and webkitExitPointerLock methods.
https://bugs.webkit.org/show_bug.cgi?id=88891

Reviewed by Dimitri Glazkov.

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402

Entering and exiting mouse lock is provided in the new webkitRequestPointerLock and
webkitExitPointerLock methods.

Source/WebCore:

Existing pointer-lock tests updated to use the new methods.

* dom/Document.cpp:
(WebCore::Document::webkitExitPointerLock):
(WebCore):
* dom/Document.h:
(Document):
* dom/Document.idl:
* dom/Element.cpp:
(WebCore):
(WebCore::Element::webkitRequestPointerLock):
* dom/Element.h:
* dom/Element.idl:

LayoutTests:

Existing tests updated to use the new methods. Also, several updated to
support manual testing.

* pointer-lock/lock-already-locked-expected.txt:
* pointer-lock/lock-already-locked.html:
* pointer-lock/mouse-event-delivery-expected.txt:
* pointer-lock/mouse-event-delivery.html:
* pointer-lock/pointer-lock-api-expected.txt:
* pointer-lock/pointer-lock-api.html:
* pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
* pointer-lock/pointerlockchange-pointerlockerror-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [chromium] Add iccjpeg and qcms to chromium port
commit-queue@webkit.org [Fri, 15 Jun 2012 19:51:50 +0000 (19:51 +0000)]
Source/WebCore:        [chromium] Add iccjpeg and qcms to chromium port
       https://bugs.webkit.org/show_bug.cgi?id=81974

       Reviewed by Adam Barth.

       Covered by existing layout tests which will be rebaselined.

       * WebCore.gyp/WebCore.gyp: Add qcms to the build.
       * platform/image-decoders/ImageDecoder.h:
       (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile.
       On OSX, return the default RGB profile. Add FIXME to use the user's
       monitor profile and verify that profile for other platforms.

       * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
       (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the
       two known output color spaces for which the decoder uses a data swizzle.
       (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For
       libjpeg-turbo, alpha may be present in the swizzled output color space.

       (WebCore::JPEGImageReader::JPEGImageReader):
       (WebCore::JPEGImageReader::close):
       (WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
       to use during decoding, and ensure we switch to inputing RGBA data to qcms
       even if the desired output data is BGRA: outputScanlines() sends BGRA data
       to the frame buffer following color correction if needed.
       (JPEGImageReader):
       (WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
       (WebCore::JPEGImageReader::createColorTransform): Create color transform.
       Release the existing transform (if any) and assign to the color transform
       created from the color profile data.
       (WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
       transform to each decoded image row.

       * platform/image-decoders/png/PNGImageDecoder.cpp:
       (WebCore::PNGImageReader::PNGImageReader):
       (WebCore::PNGImageReader::close):
       (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other
       setters and getters.
       (WebCore::PNGImageReader::decodingSizeOnly): Ditto.
       (WebCore::PNGImageReader::setHasAlpha): Ditto.
       (WebCore::PNGImageReader::hasAlpha): Ditto.
       (WebCore::PNGImageReader::interlaceBuffer): Ditto.
       (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer,
       used when a color transform is applied to the decoded image pixels.
       (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer.
       (WebCore::PNGImageReader::colorTransform): qcms color transform getter.
       (WebCore::PNGImageReader::createColorTransform): Create color transform.
       Release the existing transform (if any) and assign to the color transform
       created from the color profile data.
       (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color
       transform to use for decoding. Clear m_colorProfile (not used anymore).
       (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if
       a color transform is needed for decoding. Apply color transform to each
       decoded image row.

       * platform/image-decoders/skia/ImageDecoderSkia.cpp:
       (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no
       longer used. Add a FIXME to remove the old implementation.
       (WebCore::ImageFrame::setStatus): Remove old color correction code.

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-15

Source/WTF: [chromium] Add iccjpeg and qcms to chromium port.
https://bugs.webkit.org/show_bug.cgi?id=81974

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-15

* wtf/Platform.h: Add Chromium USE defines for ICCJPEG and QCMSLIB
to each Chromium platform, excluding Android.

Reviewed by Adam Barth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd bbudge@chromium.org to committers.py
bbudge@chromium.org [Fri, 15 Jun 2012 19:41:45 +0000 (19:41 +0000)]
Add bbudge@chromium.org to committers.py

Unreviewed.

Patch by Bill Budge <bbudge@chromium.org> on 2012-06-15

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Disable WebCore::EventHandler synthesized mouse events during touch...
tonikitoo@webkit.org [Fri, 15 Jun 2012 18:53:27 +0000 (18:53 +0000)]
[BlackBerry] Disable WebCore::EventHandler synthesized mouse events during touch scrolling
https://bugs.webkit.org/show_bug.cgi?id=89227
PR #146642

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

Make use of the Settings::supportsMouseDevice setting in order to
prevent mouse move event to fire as a response to a scroll action.
We might still want to dynamically toggle this setting ON, in case for
example of a mouse wheel driven scroll action, but we can revisit it
when it becomes a fully supported/primary use case.

Internally reviewed by Eli Fidler.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::isDeviceSupportsMouseEnabled):
(BlackBerry::WebKit::WebSettings::setDeviceSupportsMouseEnabled):
* Api/WebSettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rebaselines for r120477.
inferno@chromium.org [Fri, 15 Jun 2012 18:43:28 +0000 (18:43 +0000)]
Unreviewed. Rebaselines for r120477.

* fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/chromium-mac-leopard/fast/forms/formmove3-expected.txt: Added.
* platform/chromium-mac-leopard/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
* platform/chromium-mac-leopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
* platform/chromium-mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
* platform/chromium-mac/fast/forms/formmove3-expected.txt:
* platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
* platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/chromium-mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
* platform/efl/TestExpectations:
* platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
* platform/gtk/fast/dynamic/011-expected.txt:
* platform/gtk/fast/forms/formmove3-expected.txt:
* platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
* platform/gtk/fast/invalid/001-expected.txt:
* platform/gtk/fast/invalid/003-expected.txt:
* platform/gtk/fast/invalid/004-expected.txt:
* platform/gtk/fast/invalid/007-expected.txt:
* platform/gtk/fast/invalid/019-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug647-expected.txt:
* platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt:
* platform/qt/editing/deleting/delete-3800834-fix-expected.txt:
* platform/qt/fast/dynamic/011-expected.txt:
* platform/qt/fast/forms/formmove3-expected.txt:
* platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.txt:
* platform/qt/fast/invalid/001-expected.txt:
* platform/qt/fast/invalid/003-expected.txt:
* platform/qt/fast/invalid/004-expected.txt:
* platform/qt/fast/invalid/007-expected.txt:
* platform/qt/fast/invalid/019-expected.txt:
* platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/qt/tables/mozilla/bugs/bug647-expected.txt:
* platform/qt/tables/mozilla/other/wa_table_tr_align-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline some tests after r120411.
simon.fraser@apple.com [Fri, 15 Jun 2012 18:39:33 +0000 (18:39 +0000)]
Rebaseline some tests after r120411.

* platform/mac/fast/forms/box-shadow-override-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/range/input-appearance-range-expected.txt:
* platform/mac/fast/multicol/client-rects-expected.txt:
* platform/mac/media/controls-after-reload-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium rebaseline for r120467.
fmalita@chromium.org [Fri, 15 Jun 2012 18:37:51 +0000 (18:37 +0000)]
Unreviewed chromium rebaseline for r120467.

Patch by Florin Malita <fmalita@chromium.org> on 2012-06-15

* platform/chromium-linux-x86/svg/filters/feLighting-crash-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
* platform/chromium-mac-leopard/svg/filters/feLighting-crash-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/feLighting-crash-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
* platform/chromium-mac/svg/filters/feLighting-crash-expected.png:
* platform/chromium-win-vista/svg/filters/feLighting-crash-expected.png:
* platform/chromium-win-xp/svg/filters/feLighting-crash-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
* platform/chromium-win/svg/filters/feLighting-crash-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove volume thumb for videos without audio track.
commit-queue@webkit.org [Fri, 15 Jun 2012 17:59:50 +0000 (17:59 +0000)]
Remove volume thumb for videos without audio track.
https://bugs.webkit.org/show_bug.cgi?id=89093

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-15
Reviewed by Eric Carlson.

No new tests, since this was already tested in media/video-no-audio.html.

* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaMuteButton):
Change mute button when there is no audio or no source file.
(WebCore::paintMediaVolumeSlider):
Set volume slider to 0 when there is no audio or no source file.
(WebCore::paintMediaVolumeSliderThumb):
Don't paint the volume slider thumb when there is no audio or no source file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleanup empty anonymous block continuation.
inferno@chromium.org [Fri, 15 Jun 2012 17:57:57 +0000 (17:57 +0000)]
Cleanup empty anonymous block continuation.
https://bugs.webkit.org/show_bug.cgi?id=74976

Reviewed by Julien Chaffraix.

Source/WebCore:

Fix rendering on http://docs.google.com/demo.

Test: fast/inline/inline-empty-block-continuation-remove.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild): If we are removing our last child,
and are an anonymous block which is part of a continuation chain, then
we need to first fix our continuation chain by setting our previous
continuation renderer to point to the next continuation renderer. Then,
we reset our continuation pointer and destroy ourselves. Since we no
longer are part of continuation chain, we will be removed and previous
and next anonymous block will be merged automatically.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::previousInPreOrder): add an argument to previousInOrder
- stayWithin.
(WebCore):
* rendering/RenderObject.h:
(RenderObject):

LayoutTests:

* fast/inline/inline-empty-block-continuation-remove-expected.html: Added.
* fast/inline/inline-empty-block-continuation-remove.html: Added.
and a bunch of rebaselines in existing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up the flaky tests section in Gtk's TestExpectations file. Remove
zandobersek@gmail.com [Fri, 15 Jun 2012 17:47:18 +0000 (17:47 +0000)]
Clean up the flaky tests section in Gtk's TestExpectations file. Remove
flakiness expectations for tests that have been consistently passing and
move expectations for tests that have been consistently failing under
the failing tests section, changing the expectations to represent a constant
expected failure for that test.

Rubber-stamped by Philippe Normand.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Move FileSystem frame management from frontend to backend
commit-queue@webkit.org [Fri, 15 Jun 2012 17:16:30 +0000 (17:16 +0000)]
Web Inspector: Move FileSystem frame management from frontend to backend
https://bugs.webkit.org/show_bug.cgi?id=89190

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: http/tests/inspector/filesystem/read-directory.html

* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore::InspectorFileSystemAgent::readDirectory):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::scriptExecutionContextForOrigin):
(WebCore):
* inspector/InspectorFileSystemAgent.h:
(WebCore):
(InspectorFileSystemAgent):

LayoutTests:

* http/tests/inspector/filesystem/read-directory.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, build fix after r120469.
apavlov@chromium.org [Fri, 15 Jun 2012 17:13:52 +0000 (17:13 +0000)]
Unreviewed, build fix after r120469.

* css/CSSPropertySourceData.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Certain web pages (i.e., http://www.cloudtweaks.com/) are allowed to...
zhajiang@rim.com [Fri, 15 Jun 2012 17:10:06 +0000 (17:10 +0000)]
[BlackBerry] Certain web pages (i.e., cloudtweaks.com/) are allowed to be wider than the screen
https://bugs.webkit.org/show_bug.cgi?id=89211

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 135215
Make simpler rules for zoom to fit scale:
- Zoom to fit horizontally first without clamping the contents width.
- Zoom to fit vertically instead without clamping the contents height
  if the horizontal zoom to fit can cause a grey area below the web
  page. Get rid of the virtual viewport guard as there may be cases
  that zooming can cause a grey area without a virtual viewport.
- Clamp the scale by the minimum zoom to fit scale 0.25 and apply
  this rule to image documents as well. This minimum scale can be
  changed if there is a better vaule in the future.
In this way, we can get rid of the issue that many web pages don't fit
the screen.

Reviewed internally by Arvid Nilsson.

* Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::zoomToFitScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Add FileSystemRequestManager and FileSystemDispatcher
commit-queue@webkit.org [Fri, 15 Jun 2012 16:57:11 +0000 (16:57 +0000)]
Web Inspector: Add FileSystemRequestManager and FileSystemDispatcher
https://bugs.webkit.org/show_bug.cgi?id=89191

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.

* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototoype._requestId):
(WebInspector.FileSystemRequestManager.prototoype.readDirectory):
(WebInspector.FileSystemRequestManager.prototoype._didReadDirectory):
(WebInspector.FileSystemDispatcher):
(WebInspector.FileSystemDispatcher.prototype.gotFileSystemRoot):
(WebInspector.FileSystemDispatcher.prototype.didReadDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: extension's Resource.getContent always returns original revision.
pfeldman@chromium.org [Fri, 15 Jun 2012 16:50:44 +0000 (16:50 +0000)]
Web Inspector: extension's Resource.getContent always returns original revision.
https://bugs.webkit.org/show_bug.cgi?id=89219

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Fetching proper content from the UISourceCode now.

* inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerResourceBinding.prototype.setContent):
* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping.prototype._debuggerReset):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.isHidden):
(WebInspector.Resource.prototype.uiSourceCode):
(WebInspector.Resource.prototype.setUISourceCode):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):

LayoutTests:

* inspector/extensions/extensions-resources-expected.txt:
* inspector/extensions/extensions-resources.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: CRASH when DebuggerAgent.setBreakpoint was called twice for the same...
loislo@chromium.org [Fri, 15 Jun 2012 16:48:21 +0000 (16:48 +0000)]
Web Inspector: CRASH when DebuggerAgent.setBreakpoint was called twice for the same location.
https://bugs.webkit.org/show_bug.cgi?id=89225

Reviewed by Pavel Feldman.

* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: CSSParser::parseSheet() should provide ready-to-use source data
apavlov@chromium.org [Fri, 15 Jun 2012 16:36:17 +0000 (16:36 +0000)]
Web Inspector: CSSParser::parseSheet() should provide ready-to-use source data
https://bugs.webkit.org/show_bug.cgi?id=88646

Reviewed by Antti Koivisto.

This change moves the post-processing step from InspectorStyleSheet into CSSParser, so that
CSSParser::parseSheet() will return a ready-to-use list with style rule source code data.
Also, universal data structures are introduced, which allow for the full rule source data tree building.

No new tests, as this is a refactoring.

* css/CSSParser.cpp: Use universal data structures, which can be used for building the full rule tree.
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::parseSheet): Return ready-to-use source code data entries rather than an intermediate structure.
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::addNewRuleToSourceTree):
(WebCore):
(WebCore::CSSParser::popRuleData):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::fixUnparsedPropertyRanges): Moved in from InspectorStyleSheet.
(WebCore::CSSParser::markSelectorListStart):
(WebCore::CSSParser::markSelectorListEnd):
(WebCore::CSSParser::markRuleBodyStart):
(WebCore::CSSParser::markRuleBodyEnd):
(WebCore::CSSParser::markPropertyEnd):
* css/CSSParser.h:
(CSSParser):
(WebCore::CSSParser::resetPropertyRange): Renamed.
(WebCore::CSSParser::isExtractingSourceData): A convenience check.
* css/CSSPropertySourceData.h: Introduce the RuleSourceDataList typedef.
(WebCore):
* inspector/InspectorStyleSheet.cpp: Make use of RuleSourceDataList and follow the CSSParser::parse*() API changes.
(ParsedStyleSheet::sourceData):
(ParsedStyleSheet):
(ParsedStyleSheet::setSourceData):
(WebCore::InspectorStyleSheet::ensureSourceData): Remove source data postprocessing, follow the new parseSheet() API.
* inspector/InspectorStyleSheet.h:
(WebCore::InspectorCSSId::InspectorCSSId): Drive-by: uninitialized field fix.
(WebCore::InspectorStyleProperty::InspectorStyleProperty): Ditto.
(InspectorStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Long frame urls make all/errors/warnings/logs buttons inaccessible.
pfeldman@chromium.org [Fri, 15 Jun 2012 16:03:35 +0000 (16:03 +0000)]
Web Inspector: Long frame urls make all/errors/warnings/logs buttons inaccessible.
https://bugs.webkit.org/show_bug.cgi?id=88907

Reviewed by Vsevolod Vlasov.

* inspector/front-end/inspector.css:
(#console-context):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpecular light filters produce dark results
fmalita@chromium.org [Fri, 15 Jun 2012 15:56:18 +0000 (15:56 +0000)]
Specular light filters produce dark results
https://bugs.webkit.org/show_bug.cgi?id=89116

Reviewed by Dirk Schulze.

Source/WebCore:

Tests: svg/filters/feSpecularLight-premultiplied-expected.svg
       svg/filters/feSpecularLight-premultiplied.svg

Per spec (http://www.w3.org/TR/SVG/filters.html#feSpecularLightingElement),
light filters should operate on pre-multiplied RGBA. Currently, the results
are stored in the unmultiplied buffer but the alpha channel is calculated
for premultiplied values (which causes a darkening of the result upon the
subsequent unmultiplied->premultiplied conversion). This patch updates
FELighting to generate premultiplied results.

* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApplySoftware):

LayoutTests:

* platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
* platform/chromium-linux/svg/filters/feLighting-crash-expected.png:
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:
* svg/filters/feSpecularLight-premultiplied-expected.svg: Added.
* svg/filters/feSpecularLight-premultiplied.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed style fix after r120351.
ossy@webkit.org [Fri, 15 Jun 2012 15:56:08 +0000 (15:56 +0000)]
Unreviewed style fix after r120351.

* BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(body.interface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: incorrect filtering of async timeline events
caseq@chromium.org [Fri, 15 Jun 2012 15:51:56 +0000 (15:51 +0000)]
Web Inspector: incorrect filtering of async timeline events
https://bugs.webkit.org/show_bug.cgi?id=89214

Reviewed by Vsevolod Vlasov.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.accept):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVG Composite of Offset filters incorrectly clips
schenney@chromium.org [Fri, 15 Jun 2012 15:37:12 +0000 (15:37 +0000)]
SVG Composite of Offset filters incorrectly clips
https://bugs.webkit.org/show_bug.cgi?id=77660

Reviewed by Dirk Schulze.

Source/WebCore:

Prior to this patch, when a group of filtered objects was used as input to another filter,
the filter only operated on the stroke boundary of the group, and hence excluded the results
of filtering elements within the group, or extraneously included regions clipped from the
elements in the group.

This patch modifies the strokeBoundingBox of SVG container elements to
be the union of the repaint rects for the children. This modifes the
results returned for sizing filters and for absoluteRects, which will cause
inline layout around the group to factor in the resources applied to
the group's children.

The relevant spec entry is this, in Section 3.7 of the SVG 1.1 spec: "...the result must be
as though the paint operations had been applied to an intermediate canvas initialized to
transparent black, of a size determined by the rules given in Filter Effects then filtered
by the processes defined in Filter Effects." In this case the "paint operations" is implied
to include the result of applying "paint" but no resources to the group, which in turn would
have resources applied to the children of the group. This makes the most sense, as the current,
incorrect behavior makes it extremely diffucult to understand the actions of filters on
groups of filtered content.

Tests: svg/filters/container-with-filters-expected.svg
       svg/filters/container-with-filters.svg

* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::updateCachedBoundaries):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::updateCachedBoundaries):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

LayoutTests:

* svg/filters/container-with-filters-expected.svg: Added.
* svg/filters/container-with-filters.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Remove BackingStoreClient::scrollsHorizontally/scrollsVeritically()
commit-queue@webkit.org [Fri, 15 Jun 2012 15:29:44 +0000 (15:29 +0000)]
[BlackBerry] Remove BackingStoreClient::scrollsHorizontally/scrollsVeritically()
https://bugs.webkit.org/show_bug.cgi?id=89210

Patch by Yong Li <yoli@rim.com> on 2012-06-15
Reviewed by Antonio Gomes.

Remove BackingStoreClient::scrollsHorizontally()/scrollsVeritically(), because
calling them is neither nessary nor safe.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::blitHorizontalScrollbar):
(BlackBerry::WebKit::BackingStorePrivate::blitVerticalScrollbar):
* WebKitSupport/BackingStoreClient.cpp:
* WebKitSupport/BackingStoreClient.h:
(BackingStoreClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSort ENABLE(INSPECTOR) section of WebCore.exp.in
ddkilzer@apple.com [Fri, 15 Jun 2012 15:19:50 +0000 (15:19 +0000)]
Sort ENABLE(INSPECTOR) section of WebCore.exp.in

* WebCore.exp.in: Sort ENABLE(INSPECTOR) symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove duplicate symbol from WebCore.exp.in
ddkilzer@apple.com [Fri, 15 Jun 2012 15:19:44 +0000 (15:19 +0000)]
Remove duplicate symbol from WebCore.exp.in

* WebCore.exp.in: Remove duplicate symbol for:
WebCore::Range::textQuads(WTF::Vector<WebCore::FloatQuad, 0ul>&, bool, WebCore::Range::RangeInFixedPosition*) const

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed debug build fix for r120457
fmalita@chromium.org [Fri, 15 Jun 2012 15:18:59 +0000 (15:18 +0000)]
[Chromium] Unreviewed debug build fix for r120457

Patch by Florin Malita <fmalita@chromium.org> on 2012-06-15

* platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::toYUVVideoDrawQuad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed: remove redundant Mac-specific style rule from inspector front-end.
pfeldman@chromium.org [Fri, 15 Jun 2012 15:15:01 +0000 (15:15 +0000)]
Not reviewed: remove redundant Mac-specific style rule from inspector front-end.

* inspector/front-end/helpScreen.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: fix help close button appearance on Mac
pfeldman@chromium.org [Fri, 15 Jun 2012 15:11:02 +0000 (15:11 +0000)]
Web Inspector: fix help close button appearance on Mac
https://bugs.webkit.org/show_bug.cgi?id=89208

Reviewed by Vsevolod Vlasov.

* inspector/front-end/helpScreen.css:
(.help-close-button):
(body.platform-mac .help-close-button):
(body.platform-mac .help-window-main .tabbed-pane-header-contents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Create a CCYUVVideoDrawQuad and remove the now-unused generic CCVideoDrawQuad
danakj@chromium.org [Fri, 15 Jun 2012 14:34:29 +0000 (14:34 +0000)]
[chromium] Create a CCYUVVideoDrawQuad and remove the now-unused generic CCVideoDrawQuad
https://bugs.webkit.org/show_bug.cgi?id=88828

Reviewed by Adrienne Walker.

The CCVideoDrawQuad is now only used for YUV video, so we remove the
class and replace it with CCYUVVideoDrawQuad. This class holds what is
needed to draw a YUV video frame.

No new tests, no change in behaviour.

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::toYUVVideoDrawQuad):
* platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore):
(CCDrawQuad):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCVideoDrawQuad.cpp.
(WebCore):
(WebCore::CCYUVVideoDrawQuad::create):
(WebCore::CCYUVVideoDrawQuad::CCYUVVideoDrawQuad):
* platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCVideoDrawQuad.h.
(WebCore):
(CCYUVVideoDrawQuad):
(WebCore::CCYUVVideoDrawQuad::yPlane):
(WebCore::CCYUVVideoDrawQuad::uPlane):
(WebCore::CCYUVVideoDrawQuad::vPlane):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: CRASH: getProfile is crashing for unknown profiles.
loislo@chromium.org [Fri, 15 Jun 2012 14:28:20 +0000 (14:28 +0000)]
Web Inspector: CRASH: getProfile is crashing for unknown profiles.
https://bugs.webkit.org/show_bug.cgi?id=89202

Source/WebCore:

agents' functions have to set a value to errorString if it can't assign values to the mandatory out arguments.

Reviewed by Pavel Feldman.

Test: inspector/profiler/heap-snapshot-get-profile-crash.html

* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getProfile):

LayoutTests:

Reviewed by Pavel Feldman.

* inspector/profiler/heap-snapshot-get-profile-crash-expected.txt: Added.
* inspector/profiler/heap-snapshot-get-profile-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomaster.cfg cleanup, remove unnecessary workaround
ossy@webkit.org [Fri, 15 Jun 2012 14:26:13 +0000 (14:26 +0000)]
master.cfg cleanup, remove unnecessary workaround
https://bugs.webkit.org/show_bug.cgi?id=88994

Reviewed by Lucas Forschler.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes...
dpranke@chromium.org [Fri, 15 Jun 2012 14:22:13 +0000 (14:22 +0000)]
webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
https://bugs.webkit.org/show_bug.cgi?id=88581

Reviewed by Adam Barth.

Make sure we only optimize the suffixes we rebaselined during
rebaseline-expectations, and not all suffixes for a test.
While optimizing is somewhere between harmless and good, it's also confusing :)

* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations._rebaseline_port):
(RebaselineExpectations.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] media volume slider in wrong position (master_38 regression)
commit-queue@webkit.org [Fri, 15 Jun 2012 14:17:29 +0000 (14:17 +0000)]
[BlackBerry] media volume slider in wrong position (master_38 regression)
https://bugs.webkit.org/show_bug.cgi?id=89165

Patch by Max Feil <mfeil@rim.com> on 2012-06-15
Reviewed by Antonio Gomes.

Due to upstream simplification of the volume slider (webkit.org
bug 82150) it now appears in the wrong location below the
media controls. The programmatic controls sizing we do in
RenderThemeBlackBerry.cpp relies on absolute positioning of the
volume slider container, so the best way to fix this is to set
the bottom offset.

No new tests since this is a regression fix. BlackBerry media
controls are manually tested.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate builder.html template for newer buildmaster
ossy@webkit.org [Fri, 15 Jun 2012 14:14:43 +0000 (14:14 +0000)]
Update builder.html template for newer buildmaster
https://bugs.webkit.org/show_bug.cgi?id=89207

Rebasing builder.html template from v0.8.3 to v0.8.6p1.

Reviewed by Zoltan Herczeg.

* BuildSlaveSupport/build.webkit.org-config/templates/builder.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline for type=range tests.
tkent@chromium.org [Fri, 15 Jun 2012 14:10:36 +0000 (14:10 +0000)]
[Chromium] Rebaseline for type=range tests.
https://bugs.webkit.org/show_bug.cgi?id=89067

* platform/chromium-linux/fast/forms/range/input-appearance-range-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse testRunner instead of layoutTestController in layout test resources
rniwa@webkit.org [Fri, 15 Jun 2012 14:07:22 +0000 (14:07 +0000)]
Use testRunner instead of layoutTestController in layout test resources
https://bugs.webkit.org/show_bug.cgi?id=89182

Reviewed by Kent Tamura.

* resources/dump-as-markup.js:
(Markup.waitUntilDone):
(Markup.notifyDone):
* resources/magnitude-perf.js:
(Magnitude._run):
(Magnitude._runIteration):
(Magnitude):
* resources/testharnessreport.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed: remove garbage line from inspector view in docked-to-right mode.
pfeldman@chromium.org [Fri, 15 Jun 2012 13:58:42 +0000 (13:58 +0000)]
Not reviewed: remove garbage line from inspector view in docked-to-right mode.

* inspector/front-end/inspectorCommon.css:
(body.docked.dock-to-right.docked):
(body.docked.dock-to-right.inactive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening, adding TEXT expectation for
zandobersek@gmail.com [Fri, 15 Jun 2012 13:54:40 +0000 (13:54 +0000)]
Unreviewed GTK gardening, adding TEXT expectation for
editing/spelling/grammar-edit-word.html after r120423.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuildfix for !ENABLE(BLOB) platforms after r120433.
ossy@webkit.org [Fri, 15 Jun 2012 13:36:57 +0000 (13:36 +0000)]
Buildfix for !ENABLE(BLOB) platforms after r120433.
https://bugs.webkit.org/show_bug.cgi?id=78648

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-15
Reviewed by Csaba Osztrogonác.

* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline for type=range tests.
tkent@chromium.org [Fri, 15 Jun 2012 13:27:48 +0000 (13:27 +0000)]
[Chromium] Rebaseline for type=range tests.
https://bugs.webkit.org/show_bug.cgi?id=89067

* fast/forms/range/range-thumb-height-percentage-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/range/range-thumb-height-percentage-expected.txt.
* platform/chromium-linux/fast/forms/range/range-thumb-height-percentage-expected.txt: Renamed from LayoutTests/platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt.
* platform/chromium-linux/fast/forms/range/slider-padding-expected.txt: Added.
* platform/chromium-linux/fast/forms/range/slider-thumb-shared-style-expected.txt: Added.
* platform/chromium-win/fast/forms/range/input-appearance-range-expected.png:
* platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Gardening. Skip a failing test. After r120423.
ossy@webkit.org [Fri, 15 Jun 2012 13:06:33 +0000 (13:06 +0000)]
[Qt] Gardening. Skip a failing test. After r120423.
https://bugs.webkit.org/show_bug.cgi?id=89199

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-06-15
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Allow scrolling non-root layers in the compositor thread
commit-queue@webkit.org [Fri, 15 Jun 2012 12:45:58 +0000 (12:45 +0000)]
[chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-06-15
Reviewed by James Robinson.

Source/WebCore:

This patch enables scrolling child layers in the compositor thread.
Scroll deltas are accumulated for each scrolled CCLayerImpl and
synchronized to the main thread.

If a layer has no room to scroll in a given direction, one of its
ancestor layers is scrolled instead if possible.

Layer hit testing code by Shawn Singh.

Added new unit tests to verify layer scrolling behavior:

    CCLayerTreeHostCommonTest.verifySubtreeSearch
    CCLayerTreeHostImplTest.clearRootRenderSurfaceAndScroll
    CCLayerTreeHostImplTest.inhibitScrollAndPageScaleUpdatesWhileAnimatingPageScale
    CCLayerTreeHostImplTest.inhibitScrollAndPageScaleUpdatesWhilePinchZooming
    CCLayerTreeHostImplTest.replaceTreeWhileScrolling
    CCLayerTreeHostImplTest.scrollBeforeRedraw
    CCLayerTreeHostImplTest.scrollBlockedByContentLayer
    CCLayerTreeHostImplTest.scrollChildAndChangePageScaleOnMainThread
    CCLayerTreeHostImplTest.scrollChildBeyondLimit
    CCLayerTreeHostImplTest.scrollChildCallsCommitAndRedraw
    CCLayerTreeHostImplTest.scrollEventBubbling
    CCLayerTreeHostImplTest.scrollMissesBackfacingChild
    CCLayerTreeHostImplTest.scrollMissesChild
    CCLayerTreeHostImplTest.scrollNonCompositedRoot
    CCLayerTreeHostImplTest.scrollRootAndChangePageScaleOnImplThread
    CCLayerTreeHostImplTest.scrollRootAndChangePageScaleOnMainThread
    CCLayerTreeHostImplTest.scrollRootIgnored
    CCLayerTreeHostImplTest.scrollWithoutRootLayer
    CCLayerTreeHostTestScrollChildLayer
    WebCompositorInputHandlerImplTest.gestureScrollOnMainThread

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setMaxScrollPosition):
(WebCore):
(WebCore::LayerChromium::scrollBy):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore):
(LayerChromiumScrollDelegate):
(WebCore::LayerChromiumScrollDelegate::~LayerChromiumScrollDelegate):
(LayerChromium):
(WebCore::LayerChromium::maxScrollPosition):
(WebCore::LayerChromium::scrollable):
(WebCore::LayerChromium::setLayerScrollDelegate):
* platform/graphics/chromium/cc/CCInputHandler.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::tryScroll):
(WebCore):
(WebCore::sortLayers):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::findFirstScrollableLayer):
(WebCore):
(WebCore::CCLayerTreeHost::applyScrollAndScale):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(CCLayerTreeHostCommon):
(WebCore):
(WebCore::CCLayerTreeHostCommon::findLayerInSubtree):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::findRootScrollLayer):
(WebCore):
(WebCore::findScrollLayerForContentLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::detachLayerTree):
(WebCore::adjustScrollsForPageScaleChange):
(WebCore::applyPageScaleDeltaToScrollLayers):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::clearCurrentlyScrollingLayer):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::collectScrollDeltas):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):
(WebCore::CCLayerTreeHostImpl::clearRenderSurfaces):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(FrameData):
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::rootScrollLayer):

Source/WebKit/chromium:

New unit tests to verify layer scrolling behavior and the associated
utility functions.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
(WTF::MockContentLayerDelegate::paintContents):
(CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginTest):
(WTF::CCLayerTreeHostTestScrollChildLayer::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::afterTest):
(WTF):
(WTF::TEST_F):
* tests/WebCompositorInputHandlerImplTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd ForceScheduler to build.webkit.org
ossy@webkit.org [Fri, 15 Jun 2012 12:31:24 +0000 (12:31 +0000)]
Add ForceScheduler to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=88982

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Add title support to Ewk_View
commit-queue@webkit.org [Fri, 15 Jun 2012 12:16:55 +0000 (12:16 +0000)]
[EFL][WK2] Add title support to Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=89095

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add a method to get the title of the main frame in
an Ewk_View. A "title,changed" signal is now emitted
on the view to notify clients that the main frame
title was changed.

* PlatformEfl.cmake:
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_del):
(ewk_view_base_add):
(ewk_view_title_get):
(ewk_view_title_changed):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_loader_client.cpp: Added.
(didReceiveTitleForFrame):
(ewk_view_loader_client_attach):
* UIProcess/API/efl/ewk_view_loader_client_private.h: Added.
* UIProcess/API/efl/ewk_view_private.h:

Tools:

Update the MiniBrowser so it listens for the "title,change"
signal on the view and keeps the browser window title
up-to-date.

* MiniBrowser/efl/main.c:
(on_title_changed):
(browserCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Gardening after r120411
commit-queue@webkit.org [Fri, 15 Jun 2012 11:48:19 +0000 (11:48 +0000)]
[EFL] Gardening after r120411
https://bugs.webkit.org/show_bug.cgi?id=89194

Unreviewed EFL gardening, updating baselines after r120411.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-15

* platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/efl/fast/forms/box-shadow-override-expected.png:
* platform/efl/fast/forms/box-shadow-override-expected.txt:
* platform/efl/fast/forms/input-appearance-height-expected.png:
* platform/efl/fast/forms/input-appearance-height-expected.txt:
* platform/efl/fast/forms/range/input-appearance-range-expected.png:
* platform/efl/fast/forms/range/input-appearance-range-expected.txt:
* platform/efl/fast/forms/range/range-thumb-height-percentage-expected.png:
* platform/efl/fast/forms/range/range-thumb-height-percentage-expected.txt:
* platform/efl/fast/forms/range/slider-padding-expected.png:
* platform/efl/fast/forms/range/slider-padding-expected.txt:
* platform/efl/fast/forms/range/slider-thumb-shared-style-expected.png:
* platform/efl/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/efl/fast/forms/range/slider-thumb-stylability-expected.txt:
* platform/efl/fast/multicol/client-rects-expected.png:
* platform/efl/fast/multicol/client-rects-expected.txt:
* platform/efl/fast/repaint/slider-thumb-drag-release-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectation rebaselining.
morrita@google.com [Fri, 15 Jun 2012 11:44:27 +0000 (11:44 +0000)]
Unreviewed expectation rebaselining.

* platform/chromium-linux-x86/fast/multicol/client-rects-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/multicol/client-rects-expected.png.
* platform/chromium-linux-x86/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
* platform/chromium-linux/fast/multicol/client-rects-expected.png:
* platform/chromium-linux/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
* platform/chromium-mac-snowleopard/fast/multicol/client-rects-expected.txt: Added.
* platform/chromium-win-vista/fast/multicol/client-rects-expected.png: Added.
* platform/chromium-win-vista/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
* platform/chromium-win-xp/fast/multicol/client-rects-expected.png: Added.
* platform/chromium-win-xp/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
* platform/chromium-win/fast/multicol/client-rects-expected.png:
* platform/chromium-win/fast/multicol/client-rects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline for type=range tests.
tkent@chromium.org [Fri, 15 Jun 2012 11:41:59 +0000 (11:41 +0000)]
[Chromium] Rebaseline for type=range tests.
https://bugs.webkit.org/show_bug.cgi?id=89067

* platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.
* platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt:
* platform/chromium-win/fast/forms/range/slider-padding-expected.txt:
* platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/chromium-win/fast/repaint/slider-thumb-float-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Gardening after r120411. Updated baselines of 7 tests because of a color propert...
ossy@webkit.org [Fri, 15 Jun 2012 11:22:07 +0000 (11:22 +0000)]
[Qt] Gardening after r120411. Updated baselines of 7 tests because of a color property change.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-06-15
Reviewed by Csaba Osztrogonác.

* platform/qt/fast/dom/HTMLInputElement/input-slider-update-expected.png:
* platform/qt/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/qt/fast/forms/box-shadow-override-expected.png:
* platform/qt/fast/forms/box-shadow-override-expected.txt:
* platform/qt/fast/forms/range/input-appearance-range-expected.txt:
* platform/qt/fast/forms/range/range-thumb-height-percentage-expected.png: Added.
* platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt:
* platform/qt/fast/forms/range/slider-padding-expected.png:
* platform/qt/fast/forms/range/slider-padding-expected.txt:
* platform/qt/fast/multicol/client-rects-expected.png: Added.
* platform/qt/fast/multicol/client-rects-expected.txt:
* platform/qt/fast/repaint/slider-thumb-drag-release-expected.png:
* platform/qt/fast/repaint/slider-thumb-drag-release-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][EFL] Implement navigation back/forward in Ewk_View
commit-queue@webkit.org [Fri, 15 Jun 2012 10:58:45 +0000 (10:58 +0000)]
[WK2][EFL] Implement navigation back/forward in Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=89173

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add API for Ewk_View to ask the main frame to navigate backwards
or forwards in history. Also add API to query if such navigation
is possible.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_back):
(ewk_view_forward):
(ewk_view_back_possible):
(ewk_view_forward_possible):
* UIProcess/API/efl/ewk_view.h:

Tools:

Implement navigation back / forward in MiniBrowser. Use
'F1' to navigate back and 'F2' to navigate forward.

* MiniBrowser/efl/main.c:
(on_key_down):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update TestExpectations
tkent@chromium.org [Fri, 15 Jun 2012 10:32:02 +0000 (10:32 +0000)]
[Chromium] Update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89067

* platform/chromium/TestExpectations:
Mark some tests for type=range FAIL until all bots have the new results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fix a syntax error of TestExpectations.
tkent@chromium.org [Fri, 15 Jun 2012 10:03:10 +0000 (10:03 +0000)]
[Chromium] Fix a syntax error of TestExpectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r120404.
commit-queue@webkit.org [Fri, 15 Jun 2012 09:58:10 +0000 (09:58 +0000)]
Unreviewed, rolling out r120404.
http://trac.webkit.org/changeset/120404
https://bugs.webkit.org/show_bug.cgi?id=89193

This patch breaks [BlackBerry]'s text selection handles moving
in editable elements. (Requested by Sean1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-15

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFileReader is dysfunctional in documents with "null" origin string
jianli@chromium.org [Fri, 15 Jun 2012 09:57:13 +0000 (09:57 +0000)]
FileReader is dysfunctional in documents with "null" origin string
https://bugs.webkit.org/show_bug.cgi?id=78648

Reviewed by Adam Barth.

Source/WebCore:

The fix is to keep in-memory map from blob URL to SecurityOrigin for the
unique origin case.

Test: fast/files/file-reader-file-url.html

* fileapi/Blob.cpp:
(WebCore::Blob::Blob):
* fileapi/BlobURL.cpp:
(WebCore::BlobURL::getOrigin): Return the origin string embeded in the blob URL.
(WebCore):
(WebCore::BlobURL::createBlobURL): Remove the check for null origin string since it is handled now.
* fileapi/BlobURL.h:
(BlobURL):
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
* fileapi/ThreadableBlobRegistry.cpp:
(WebCore):
(WebCore::originMap): Thread-specific in-memory map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::registerBlobURL): Add the map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::unregisterBlobURL): Remove the map for the unregistered blob URL.
(WebCore::ThreadableBlobRegistry::getCachedOrigin): Retrieve the origin associated with the blob URL.
* fileapi/ThreadableBlobRegistry.h:
(WebCore):
(ThreadableBlobRegistry):
* html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
* page/SecurityOrigin.cpp:
(WebCore::getCachedOrigin): Return the cached origin for the blob URL if it exists.
(WebCore):
(WebCore::SecurityOrigin::create): Call getCachedOrigin to get the cached origin first.

LayoutTests:

* fast/files/file-reader-file-url-expected.txt: Added.
* fast/files/file-reader-file-url.html: Added.
* fast/files/resources/file-reader-file-url-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Forms] Move search field related code to RenderSearchField from RenderTextControlSin...
yosin@chromium.org [Fri, 15 Jun 2012 09:53:22 +0000 (09:53 +0000)]
[Forms] Move search field related code to RenderSearchField from RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=88980

Reviewed by Kent Tamura.

This patch moves search field related methods in RenderTextControlSingleLine
to new class RenderSearchField and changes related classes to use
RenderSearchField.

No new tests. This patch doesn't change behavior.

* CMakeLists.txt: Added new file RenderSearchField.cpp
* GNUmakefile.list.am: Added new file RenderSearchField.cpp and RenderSearchField.h
* Target.pri: ditto
* WebCore.gypi: ditto
* WebCore.vcproj/WebCore.vcproj: ditto
* WebCore.xcodeproj/project.pbxproj: ditto
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::subtreeHasChanged): Call RenderSearchField::updateCancelButtonVisibility
(WebCore::HTMLInputElement::addSearchResult): Changed to call InputType::addSearchResult.
* html/InputType.cpp:
(WebCore::InputType::addSearchResult): Added.
* html/InputType.h:
* html/SearchInputType.cpp:
(WebCore::SearchInputType::addSearchResult): Moved from HTMLInputElement.
(WebCore::SearchInputType::createRenderer): Added to create RenderSearchField.
* html/SearchInputType.h:
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler): Use RenderSearchField instead of RenderTextControlSingleLine.
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create): Got rid isSearchField() guard for addSearchResult().
* rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::RenderSearchField): Renamed to RenderSearchField.
(WebCore::RenderSearchField::~RenderSearchField): ditto
(WebCore::RenderSearchField::resultsButtonElement): ditto
(WebCore::RenderSearchField::cancelButtonElement): ditto
(WebCore::RenderSearchField::addSearchResult): ditto
(WebCore::RenderSearchField::showPopup): ditto
(WebCore::RenderSearchField::hidePopup): ditto
(WebCore::RenderSearchField::computeControlHeight): Added.
(WebCore::RenderSearchField::updateFromElement): Moved search field related code from RenderTextControlSingleLine.
(WebCore::RenderSearchField::updateCancelButtonVisibility): Renamed to RenderSearchField.
(WebCore::RenderSearchField::visibilityForCancelButton): ditto
(WebCore::RenderSearchField::autosaveName): ditto
(WebCore::RenderSearchField::valueChanged): ditto
(WebCore::RenderSearchField::itemText): ditto
(WebCore::RenderSearchField::itemLabel): ditto
(WebCore::RenderSearchField::itemIcon): ditto
(WebCore::RenderSearchField::itemIsEnabled): ditto
(WebCore::RenderSearchField::itemStyle): ditto
(WebCore::RenderSearchField::menuStyle): ditto
(WebCore::RenderSearchField::clientInsetLeft): ditto
(WebCore::RenderSearchField::clientInsetRight): ditto
(WebCore::RenderSearchField::clientPaddingLeft): ditto
(WebCore::RenderSearchField::clientPaddingRight): ditto
(WebCore::RenderSearchField::listSize): ditto
(WebCore::RenderSearchField::selectedIndex): ditto
(WebCore::RenderSearchField::popupDidHide): ditto
(WebCore::RenderSearchField::itemIsSeparator): ditto
(WebCore::RenderSearchField::itemIsLabel): ditto
(WebCore::RenderSearchField::itemIsSelected): ditto
(WebCore::RenderSearchField::setTextFromItem): ditto
(WebCore::RenderSearchField::fontSelector): ditto
(WebCore::RenderSearchField::hostWindow): ditto
(WebCore::RenderSearchField::createScrollbar): ditto
(WebCore::RenderSearchField::computeHeightLimit): Added.
(WebCore::RenderSearchField::centerContainerIfNeeded): Added.
* rendering/RenderSearchField.h:
(WebCore::toRenderSearchField): Added.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Remove search field related code.
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): ditto.
(WebCore::RenderTextControlSingleLine::computeHeightLimit): Added.
(WebCore::RenderTextControlSingleLine::layout): Use new methods for removing isSearchField.
(WebCore::RenderTextControlSingleLine::computeControlHeight): Added.
(WebCore::RenderTextControlSingleLine::updateFromElement): Remove search field related code.
* rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::centerContainerIfNeeded): Added.
(WebCore::RenderTextControlSingleLine::containerElement): Exposed for RenderSearchField.
(WebCore::RenderTextControlSingleLine::innerBlockElement): Exposed for RenderSearchField.
* rendering/RenderingAllInOne.cpp: Added RenderSearchField.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update TestExpectations
tkent@chromium.org [Fri, 15 Jun 2012 09:41:15 +0000 (09:41 +0000)]
[Chromium] Update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89067

* platform/chromium-mac/fast/multicol/client-rects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: LayoutTest http/tests/inspector/filesystem/* should clean up FileSyste...
commit-queue@webkit.org [Fri, 15 Jun 2012 09:33:12 +0000 (09:33 +0000)]
Web Inspector: LayoutTest http/tests/inspector/filesystem/* should clean up FileSystem after test.
https://bugs.webkit.org/show_bug.cgi?id=89066

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.

* http/tests/inspector/filesystem/filesystem-test.js:
(initialize_FileSystemTest.InspectorTest.clearFileSystem):
(dispatchCallback):
(createDirectory.gotFileSystem):
(createDirectory):
(createFile.gotFileSystem):
(clearFileSystem.gotRoot):
(clearFileSystem.gotRoot.removeAll):
(clearFileSystem.onError):
* http/tests/inspector/filesystem/read-directory.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update TestExpectations
tkent@chromium.org [Fri, 15 Jun 2012 09:30:18 +0000 (09:30 +0000)]
[Chromium] Update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89192

* platform/chromium/TestExpectations:
Failulre of platform/chromium/accessibility/add-to-menu-list-crashes.html is expected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] EFL's LayoutTestController does not support titleTextDirection
commit-queue@webkit.org [Fri, 15 Jun 2012 09:24:04 +0000 (09:24 +0000)]
[EFL] EFL's LayoutTestController does not support titleTextDirection
https://bugs.webkit.org/show_bug.cgi?id=86475

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-15
Reviewed by Hajime Morita.

Source/WebKit/efl:

Emit the "title,changed" signal even if the title direction has
changed but not its text.

* ewk/ewk_frame.cpp:
(ewk_frame_title_set):

Tools:

Add titleTextDirection getter and setter to LayoutTestController and
expose its value to JavaScript.
Update the titleTextDirection value from EFL's "title,changed"
callback in DumpRenderTree.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(getTitleTextDirectionCallback):
(LayoutTestController::staticValues):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::titleTextDirection):
(LayoutTestController::setTitleTextDirection):
(LayoutTestController):
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onFrameTitleChanged):

LayoutTests:

Unskip title-directionality tests now that EFL's LayoutTestController
supports titleTextDirection.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Implement reload / stop in Ewk_View
commit-queue@webkit.org [Fri, 15 Jun 2012 09:20:26 +0000 (09:20 +0000)]
[EFL][WK2] Implement reload / stop in Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=89168

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add API on the Ewk_View to reload the main frame
and to stop the current load.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_reload):
(ewk_view_stop):
* UIProcess/API/efl/ewk_view.h:

Tools:

Implement view reload / stop loading in MiniBrowser.
Use 'F5' for reload and 'F6' for stopping the load.

* MiniBrowser/efl/main.c:
(on_key_down):
(browserCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium windows rebaseline.
eae@chromium.org [Fri, 15 Jun 2012 09:07:53 +0000 (09:07 +0000)]
Unreviewed chromium windows rebaseline.

* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA followup for r120413.
tkent@chromium.org [Fri, 15 Jun 2012 08:55:30 +0000 (08:55 +0000)]
A followup for r120413.
https://bugs.webkit.org/show_bug.cgi?id=89187

We need to update fast/dom/htmlcollection-non-html.html for
HTMLSelectElement::selectedOptions removal.

* fast/dom/htmlcollection-non-html-expected.txt:
* fast/dom/htmlcollection-non-html.html:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening, adding a CRASH PASS expectation for
zandobersek@gmail.com [Fri, 15 Jun 2012 08:45:44 +0000 (08:45 +0000)]
Unreviewed GTK gardening, adding a CRASH PASS expectation for
storage/websql/quota-tracking.html which crashes intermittently
on release builds.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow platforms to choose whether to remove markers on editing
hbono@chromium.org [Fri, 15 Jun 2012 08:41:30 +0000 (08:41 +0000)]
Allow platforms to choose whether to remove markers on editing
https://bugs.webkit.org/show_bug.cgi?id=88838

Reviewed by Hajime Morita.

Source/WebCore:

This change allows platforms to choose whether to remove markers on a word being
edited. WebKit does not remove markers when we move a selection to a markered
word on platforms that shouldEraseMarkersAfterChangeSelection returns false.
On such platforms, WebKit expects to set WTF_USE_MARKER_REMOVAL_UPON_EDITING to
1 so Editor::updateMarkersForWordsAffectedByEditing can remove markers. This
change also checks the return value of shouldEraseMarkersAfterChangeSelection so
platform can choose it. This change also adds grammar markers so it can also
remove grammar markers.

Test: editing/spelling/grammar-edit-word.html

* editing/Editor.cpp:
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):

Source/WebKit/chromium:

This change implements EditorClientImpl::checkGrammarOfString so
DumpRenderTree can run grammar tests.

* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::isGrammarCheckingEnabled): Return true also when unified text-checking is enabled.
(WebKit::EditorClientImpl::shouldEraseMarkersAfterChangeSelection): ditto.
(WebKit::EditorClientImpl::checkGrammarOfString): Implement this function with our unified text-checker.

Tools:

This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
run grammar tests.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.

LayoutTests:

This change adds a test that verifies WebKit removes a grammar marker from a
grammatically-incorrect word when editing the word.

* editing/spelling/grammar-edit-word-expected.txt: Added.
* editing/spelling/grammar-edit-word.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening, adding test expectation for
zandobersek@gmail.com [Fri, 15 Jun 2012 08:36:06 +0000 (08:36 +0000)]
Unreviewed GTK gardening, adding test expectation for
fast/dom/htmlcollection-non-html.html after r120413.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [WebGL] Simple implementation of the InjectedWebGLScriptSource to...
commit-queue@webkit.org [Fri, 15 Jun 2012 08:15:43 +0000 (08:15 +0000)]
Web Inspector: [WebGL] Simple implementation of the InjectedWebGLScriptSource to support capturing WebGL calls for a frame
https://bugs.webkit.org/show_bug.cgi?id=89088

Simple experimental implementation of the InjectedWebGLScriptSource.js that allows to wrap
a WebGL context and capture names (for now) of the WebGL function calls for a frame being captured.

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.

* inspector/InjectedWebGLScriptSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium mac rebaseline.
eae@chromium.org [Fri, 15 Jun 2012 08:15:02 +0000 (08:15 +0000)]
Unreviewed chromium mac rebaseline.

* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r120370.
zandobersek@gmail.com [Fri, 15 Jun 2012 07:50:57 +0000 (07:50 +0000)]
Unreviewed, rolling out r120370.
http://trac.webkit.org/changeset/120370
https://bugs.webkit.org/show_bug.cgi?id=89183

Broke webkit-patch rebaseline (Requested by zdobersek on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-15

* Scripts/webkitpy/layout_tests/port/base.py:
(DummyOptions):
(DummyOptions.__init__):
(DummyOptions.__init__.this):
(Port.__init__):
(Port.get_option):
(Port.set_option_default):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.RegisterCygwinOption):
(ChromiumWinTest.RegisterCygwinOption.__init__):
(ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_expectations_path):
* Scripts/webkitpy/tool/mocktool.py:
(MockOptions.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening, updating baselines after r120411.
zandobersek@gmail.com [Fri, 15 Jun 2012 07:40:30 +0000 (07:40 +0000)]
Unreviewed GTK gardening, updating baselines after r120411.

* platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/range/input-appearance-range-expected.txt:
* platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt:
* platform/gtk/fast/forms/range/slider-padding-expected.txt:
* platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/gtk/fast/forms/range/slider-thumb-stylability-expected.txt:
* platform/gtk/fast/multicol/client-rects-expected.txt:
* platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse testRunner instead of layoutTestController in networkinformation, perf, plugins...
rniwa@webkit.org [Fri, 15 Jun 2012 07:38:37 +0000 (07:38 +0000)]
Use testRunner instead of layoutTestController in networkinformation, perf, plugins, pointer-lock, printing, scrollbars, and security tests
https://bugs.webkit.org/show_bug.cgi?id=89181

Reviewed by Kent Tamura.

* perf/clone-with-focus.html:
* perf/nested-combined-selectors.html:
* perf/table-rows-length-caching.html:
* platform/chromium/plugins/call-as-function.html:
* platform/chromium/plugins/get-url-with-blank-target2.html:
* platform/chromium/plugins/get-url-with-iframe-target-no-crash.html:
* platform/chromium/printing/custom-page-size-style-expected.txt:
* platform/chromium/printing/custom-page-size-style.html:
* platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html:
* platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html:
* platform/mac-wk2/plugins/contents-scale-factor.html:
* platform/mac-wk2/plugins/mouse-events-scaled.html:
* platform/mac/plugins/bindings-array-apply-crash.html:
* platform/mac/plugins/bindings-objc-long-method-name.html:
* platform/mac/plugins/bindings-objc-method-name-conversion.html:
* platform/mac/plugins/bindings-test-objc.html:
* platform/mac/plugins/call-as-function-test.html:
* platform/mac/plugins/convert-point.html:
* platform/mac/plugins/disable-plugins.html:
* platform/mac/plugins/jsobjc-dom-wrappers.html:
* platform/mac/plugins/jsobjc-simple.html:
* platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html-disabled:
* platform/mac/plugins/root-object-premature-delete-crash.html:
* platform/mac/plugins/supports-carbon-event-model.html:
* platform/mac/plugins/testplugin-onnew-onpaint.html:
* platform/mac/plugins/throw-on-dealloc.html:
* platform/mac/plugins/undefined-property-crash.html:
* platform/mac/plugins/update-widget-from-style-recalc.html:
* platform/mac/plugins/webScriptObject-exception-deadlock.html:
* platform/mac/scrollbars/key-window-not-first-responder.html:
* platform/qt/plugins/application-plugin-plugins-disabled.html:
* platform/win/plugins/call-javascript-that-destroys-plugin.html:
* platform/win/plugins/get-value-netscape-window.html:
* platform/win/plugins/iframe-inside-overflow.html:
* platform/win/plugins/npn-invalidate-rect-invalidates-window.html:
* platform/win/plugins/visibility-hidden.html:
* platform/win/plugins/window-geometry-initialized-before-set-window.html:
* platform/win/plugins/window-region-is-set-to-clip-rect.html:
* platform/win/plugins/windowless-paint-rect-coordinates.html:
* plugins/:
* pointer-lock/lock-fail-responses-expected.txt:
* pointer-lock/lock-fail-responses.html:
* pointer-lock/pointer-lock-api.html:
* pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
* pointer-lock/pointerlockchange-pointerlockerror-events.html:
* pointer-lock/pointerlocklost-event-expected.txt:
* pointer-lock/pointerlocklost-event.html:
* printing/compositing-layer-printing.html:
* printing/css2.1/README.txt:
* printing/css2.1/page-break-after-000.html:
* printing/css2.1/page-break-after-001.html:
* printing/css2.1/page-break-after-002.html:
* printing/css2.1/page-break-after-003.html:
* printing/css2.1/page-break-after-004.html:
* printing/css2.1/page-break-before-000.html:
* printing/css2.1/page-break-before-001.html:
* printing/css2.1/page-break-before-002.html:
* printing/css2.1/page-break-inside-000.html:
* printing/iframe-print.html:
* printing/media-queries-print.html:
* printing/numberOfPages-expected.txt:
* printing/page-count-layout-overflow.html:
* printing/page-count-relayout-shrink.html:
* printing/page-count-with-one-word.html:
* printing/page-format-data-display-none.html:
* printing/page-format-data-expected.txt:
* printing/page-format-data.html:
* printing/page-rule-css-text.html:
* printing/page-rule-in-media-query.html:
* printing/page-rule-selection-expected.txt:
* printing/page-rule-selection.html:
* printing/pageNumerForElementById-expected.txt:
* printing/print-close-crash.html:
* printing/pseudo-class-outside-page.html:
* printing/resources/paged-media-test-utils.js:
(pageNumberForElementShouldBe):
(numberOfPagesShouldBe):
(runPrintingTest):
* printing/return-from-printing-mode.html:
* printing/script-tests/numberOfPages.js:
* printing/script-tests/pageNumerForElementById.js:
* printing/setPrinting.html:
* printing/simultaneous-position-float-change.html:
* printing/single-line-must-not-be-split-into-two-pages.html:
* printing/width-overflow.html:
* printing/zoomed-document.html:
* scrollbars/hidden-iframe-scrollbar-crash.html:
* scrollbars/hidden-iframe-scrollbar-crash2.html:
* scrollbars/hidden-scrollbar-prevents-layout.html:
* scrollbars/overflow-custom-scrollbar-crash.html:
* scrollbars/resources/hidden-iframe-scrollbar-crash2.html:
* scrollbars/scroll-rtl-or-bt-layer.html:
* scrollbars/scrollable-iframe-remove-crash.html:
* scrollbars/scrollbar-click-does-not-blur-content.html:
* scrollbars/scrollbar-crash-on-refresh.html:
* scrollbars/scrollbar-drag-thumb-with-large-content.html:
* scrollbars/scrollbar-gradient-crash.html:
* scrollbars/scrollbar-iframe-click-does-not-blur-content.html:
* scrollbars/scrollbar-initial-position.html:
* scrollbars/scrollbar-middleclick-nopaste.html:
* scrollbars/scrollbar-miss-mousemove-disabled.html:
* scrollbars/scrollbar-miss-mousemove.html:
* scrollbars/scrollbar-owning-renderer-crash.html:
* scrollbars/scrollbar-part-created-with-no-parent-crash.html:
* scrollbars/scrollbar-percent-padding-crash.html:
* scrollbars/scrollbar-scrollbarparts-repaint-crash.html:
* scrollbars/scrollevent-iframe-no-scrolling-wheel.html:
* scrollbars/scrollevent-iframe-no-scrolling.html:
* security/autocomplete-cleared-on-back.html:
* security/block-test-no-port.html:
* security/block-test.html:
* security/set-form-autocomplete-attribute.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse testRunner instead of layoutTestController in ietestcenter, inspector, java,...
rniwa@webkit.org [Fri, 15 Jun 2012 07:33:22 +0000 (07:33 +0000)]
Use testRunner instead of layoutTestController in ietestcenter, inspector, java, jquery, loader, mathml, media, and mhtml tests
https://bugs.webkit.org/show_bug.cgi?id=89176

Reviewed by Kent Tamura.

* ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm:
* inspector/audits/resources/audits-style1.css:
* inspector/console/console-long-eval-crash.html:
* inspector/extensions/extensions-audits-content-script.html:
* inspector/extensions/extensions-eval-content-script.html:
* inspector/profiler/cpu-profiler-profiling-without-inspector.html:
* inspector/timeline/timeline-animation-frame.html:
* inspector/timeline/timeline-paint.html:
* inspector/timeline/timeline-receive-response-event.html:
* inspector/timeline/timeline-timer.html:
* java/argument-to-object-type.html:
* java/array-return.html:
* java/array-sort.html:
* java/embedding-java-with-object.html:
* java/inaccessible-class.html:
* java/inline-applet-crash.html:
* java/java-and-plugins.html:
* java/lc3/:
* jquery/resources/helper.js:
* loader/go-back-to-different-window-size.html:
* loader/load-defer-resume-crash.html:
* loader/navigation-while-deferring-loads.html:
* loader/reload-subresource-when-type-changes.html:
* mathml/EmptyMFracCrash.xhtml:
* mathml/EmptyMunderOverCrash.xhtml:
* mathml/empty-mroot-crash.xhtml:
* mathml/empty-msubsup-crash.html:
* mathml/fenced-whitespace-separators-crash.html:
* mathml/msub-anonymous-child-render-crash.html:
* mathml/msubsup-no-grandchild.xhtml:
* mathml/msubsup-remove-children.xhtml:
* mathml/munderover-remove-children.html:
* mathml/operator-hijacks-fenced-node.xhtml:
* mathml/wbr-in-mroot-crash.html:
* media/W3C/w3cwrapper.js:
(test):
(async_test.t.done):
(async_test):
* media/adopt-node-crash.html:
* media/audio-controls-do-not-fade-out.html:
* media/audio-controls-rendering.html:
* media/audio-delete-while-slider-thumb-clicked.html:
* media/audio-delete-while-step-button-clicked.html:
* media/audio-garbage-collect.html:
* media/audio-no-installed-engines.html:
* media/audio-only-video-intrinsic-size.html:
* media/audio-repaint.html:
* media/context-menu-actions.html:
* media/controls-after-reload.html:
* media/controls-drag-timebar.html:
* media/controls-layout-direction.html:
* media/controls-right-click-on-timebar.html:
* media/controls-without-preload.html:
* media/crash-closing-page-with-media-as-plugin-fallback.html:
* media/fallback.html:
* media/media-blocked-by-beforeload.html:
* media/media-blocked-by-willsendrequest.html:
* media/media-controls-clone-crash.html:
* media/media-controls-invalid-url.html:
* media/media-document-audio-repaint.html:
* media/media-document-audio-size.html:
* media/media-fullscreen.js:
(canplaythrough):
* media/media-volume-slider-rendered-normal.html:
* media/no-auto-play-in-sandbox.html:
* media/remove-from-document-before-load.html:
* media/resources/foreignobject-media.svg:
* media/restore-from-page-cache.html:
* media/svg-as-image-with-media-blocked.html:
* media/video-beforeload-remove-source.html:
* media/video-canvas-alpha.html:
* media/video-canvas.html-disabled:
* media/video-click-dblckick-standalone.html:
* media/video-controls-in-media-document.html:
* media/video-controls-no-scripting.html:
* media/video-controls-toggling.html:
* media/video-controls-visible-audio-only.html:
* media/video-controls-with-mutation-event-handler.html:
* media/video-delay-load-event.html:
* media/video-display-toggle.html:
* media/video-document-types.html:
* media/video-element-other-namespace-crash.html:
* media/video-empty-source.html:
* media/video-no-audio.html:
* media/video-paint-test.js:
(init.waitForMultipleEvents):
(initAndPause.waitForMultipleEvents):
(initAndPause):
* media/video-plays-past-end-of-test.html:
* media/video-poster-blocked-by-willsendrequest.html:
* media/video-replaces-poster.html:
* media/video-source-inserted.html:
* media/video-test.js:
(endTest):
* media/video-volume-slider.html:
* media/video-zoom.html:
* mhtml/check_domain.mht:
* mhtml/multi_frames.html_original:
* mhtml/multi_frames_binary.mht:
* mhtml/multi_frames_ie.mht:
* mhtml/multi_frames_unmht.mht:
* mhtml/page_with_css_and_js_ie.mht:
* mhtml/page_with_css_and_js_unmht.mht:
* mhtml/page_with_image.html_original:
* mhtml/page_with_image_ie.mht:
* mhtml/page_with_image_unmht.mht:
* mhtml/simple_page.html_original:
* mhtml/simple_page_ie.mht:
* mhtml/simple_page_unmht.mht:
* networkinformation/resources/event-after-navigation-new.html:
* networkinformation/script-tests/event-after-navigation.js:
* platform/chromium/media/video-frame-size-change.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium win and mac rebaseline for r120403.
eae@chromium.org [Fri, 15 Jun 2012 07:22:34 +0000 (07:22 +0000)]
Unreviewed chromium win and mac rebaseline for r120403.

* platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd fullscreen button to Chrome video controls for video.
commit-queue@webkit.org [Fri, 15 Jun 2012 07:19:53 +0000 (07:19 +0000)]
Add fullscreen button to Chrome video controls for video.
https://bugs.webkit.org/show_bug.cgi?id=88818

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-15
Reviewed by Eric Carlson.

No new tests, final patch will contain the rebaselined tests.

The Chrome video controls are receiving a visual update.
This patch includes a fullscreen button for video elements and the rendering of the controls
in fullscreen including hiding them after 2 seconds when the mouse is out of the controls
and not moved.

* css/fullscreen.css:
(video:-webkit-full-screen, audio:-webkit-full-screen):
Add audio to the default fullscreen styling rules.
* css/mediaControlsChromium.css:
(video:-webkit-full-page-media::-webkit-media-controls-panel):
Align controls to the bottom of the fullscreen page.
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
Include styling for the fullscreen button.
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore):
Add a constant for when to hide the controls in fullscreen.
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
Add member fields for fullscreen button, hiding timer and tracking of whether we are in fullscreen.
(WebCore::MediaControlRootElementChromium::create):
Add fullscreen button element to the visual layout.
(WebCore::MediaControlRootElementChromium::setMediaController):
Add fullscreen button element to the media controller.
(WebCore::MediaControlRootElementChromium::reset):
Show the fullscreen button if the controller supports fullscreen.
(WebCore::MediaControlRootElementChromium::playbackStarted):
Start the timer to hide the controls in fullscreen.
(WebCore::MediaControlRootElementChromium::playbackStopped):
Don't hide the controls when the video is paused in fullscreen.
(WebCore::MediaControlRootElementChromium::reportedError):
Hide the fullscreen button when we hit an error.
(WebCore::MediaControlRootElementChromium::defaultEventHandler):
Add logic for mouse events in fullscreen to start/stop the hiding timer.
(WebCore::MediaControlRootElementChromium::startHideFullscreenControlsTimer):
Start the fullscreen hiding timer.
(WebCore::MediaControlRootElementChromium::hideFullscreenControlsTimerFired):
Timer fired: hide the video controls in fullscreen.
(WebCore::MediaControlRootElementChromium::stopHideFullscreenControlsTimer):
Reset the fullscreen hiding timer.
(WebCore::MediaControlRootElementChromium::enteredFullscreen):
Add logic to enter fullscreen.
(WebCore::MediaControlRootElementChromium::exitedFullscreen):
Add logic to exit fullscreen.
* html/shadow/MediaControlRootElementChromium.h:
(MediaControlRootElementChromium):
Add declaration of member functions and fields for fullscreen.
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaFullscreenButton):
Use the new image for the fullscreen button.
* rendering/RenderThemeChromiumMac.h:
(RenderThemeChromiumMac):
Declare the fullscreen painting function for Chrome Mac.
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
Hook up the fullscreen paining function for Chrome Mac.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintMediaFullscreenButton):
Hook up the fullscreen paining function for Chrome Skia.
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
Declare the fullscreen painting function for Chrome Skia.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r110340.
tkent@chromium.org [Fri, 15 Jun 2012 07:13:35 +0000 (07:13 +0000)]
Unreviewed, rolling out r110340.
http://trac.webkit.org/changeset/110340
https://bugs.webkit.org/show_bug.cgi?id=88749

Source/WebCore:

r110340 added a broken implementation of
HTMLSelectElement::selectedOptions. This roll out removes
HTMLSelectElement::selectedOptions.

* html/CollectionType.h:
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
* html/HTMLSelectElement.cpp:
* html/HTMLSelectElement.h:
(HTMLSelectElement):
* html/HTMLSelectElement.idl:

LayoutTests:

* fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Removed.
* fast/dom/HTMLSelectElement/select-selectedOptions.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed typo fix for r120405.
morrita@google.com [Fri, 15 Jun 2012 07:11:00 +0000 (07:11 +0000)]
Unreviewed typo fix for r120405.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd color property to input type=range
keishi@webkit.org [Fri, 15 Jun 2012 06:52:53 +0000 (06:52 +0000)]
Add color property to input type=range
https://bugs.webkit.org/show_bug.cgi?id=89067

Reviewed by Kent Tamura.

Source/WebCore:

Adding color property to input type=range in preparation for
supporting tick marks for datalist for input type=range.

* css/html.css:
(input[type="range"]): Setting color property for input type=range.
This will set the color of tick mark when we implement <datalist>.
* css/themeChromiumLinux.css:
(input[type=range]):
* css/themeWin.css:
(input[type="range"]):

LayoutTests:

* fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
* fast/repaint/slider-thumb-float-expected.txt:
* platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt.
* platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Copied from LayoutTests/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt.
* platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-linux/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt.
* platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt.
* platform/chromium-linux/fast/repaint/slider-thumb-float-expected.txt: Copied from LayoutTests/fast/repaint/slider-thumb-float-expected.txt.
* platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-mac/fast/forms/range/input-appearance-range-expected.txt:
* platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt:
* platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt:
* platform/chromium-win/fast/forms/range/slider-padding-expected.txt:
* platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt.
* platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt:
* platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/mac/fast/forms/range/range-thumb-height-percentage-expected.txt:
* platform/mac/fast/forms/range/slider-padding-expected.txt:
* platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt:
* platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt:
* platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport file extensions in HTMLInputElement::accept
tkent@chromium.org [Fri, 15 Jun 2012 06:38:25 +0000 (06:38 +0000)]
Support file extensions in HTMLInputElement::accept
https://bugs.webkit.org/show_bug.cgi?id=88298

Reviewed by Hajime Morita.

Source/WebCore:

The WHATWG specification added file extensions supoprt for
HTMLInputElement::accept recently.

In the WebCore FileChooser interface, we rejected invalid MIME type
strings in HTMLInputElement::acceptMIMETypes(), and platform file
choosers don't expect that it containts file extensions. So, this patch
introduces additional member "acceptFileExtensions" to
FileChooserSettings, and it contains only file extensions specified by
an accept attribute.

* html/FileInputType.cpp:
Sets HTMLInputElement::acceptFileExtensions() to
FileChooserSettings::acceptFileExtensions.
(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::receiveDropForDirectoryUpload):
* html/HTMLInputElement.cpp:
(WebCore::isValidFileExtension): Added.
(WebCore::parseAcceptAttribute):
Common part for acceptMIMETyps() and acceptFileExtensions().
(WebCore::HTMLInputElement::acceptMIMETypes):
Uses parseAcceptAttribute() with isValidMIMEType().
(WebCore::HTMLInputElement::acceptFileExtensions):
Added. Uses parseAcceptAttribute() with isValidFileExtension().
* html/HTMLInputElement.h:
(HTMLInputElement): Add acceptFileExtensions().
* platform/FileChooser.h:
(FileChooserSettings): Add acceptFileExtensions and acceptTypes().
* platform/FileChooser.cpp:
(WebCore::FileChooserSettings::acceptTypes): Added.

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::runOpenPanel):
Use FileChooserSettings::acceptTypes() to get both of MIME types and file extensions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rebaseline for mac chromium following r120403.
eae@chromium.org [Fri, 15 Jun 2012 06:35:42 +0000 (06:35 +0000)]
Unreviewed rebaseline for mac chromium following r120403.

* platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove support for counterValueForElementById from chromium port
kaustubh@motorola.com [Fri, 15 Jun 2012 06:33:25 +0000 (06:33 +0000)]
Remove support for counterValueForElementById from chromium port
https://bugs.webkit.org/show_bug.cgi?id=88851

Reviewed by Adam Barth.

Moved the counterValueForElementById from LayoutTestCotroller to Internals so
remove the old platform specific implementations as it exclusively tests WebCore functionality.

* public/WebFrame.h:
(WebFrame):
* src/WebFrameImpl.cpp:
(WebKit):
* src/WebFrameImpl.h:
(WebFrameImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse testRunner instead of layoutTestController in battery status and canvas tests
rniwa@webkit.org [Fri, 15 Jun 2012 06:23:21 +0000 (06:23 +0000)]
Use testRunner instead of layoutTestController in battery status and canvas tests
https://bugs.webkit.org/show_bug.cgi?id=88761

Reviewed by Tony Chang.

* batterystatus/resources/event-after-navigation-new.html:
* batterystatus/script-tests/event-after-navigation.js:
* canvas/philip/tests.js:
(_addTest.endTest):
(_addTest.window.onload):
(_addTest):
* canvas/philip/tests/2d.text-custom-font-load-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove unused CanvasLayerChromium.h/cpp from the tree
commit-queue@webkit.org [Fri, 15 Jun 2012 06:18:18 +0000 (06:18 +0000)]
[chromium] Remove unused CanvasLayerChromium.h/cpp from the tree
https://bugs.webkit.org/show_bug.cgi?id=89152

Patch by James Robinson <jamesr@chromium.org> on 2012-06-14
Reviewed by Adrienne Walker.

These files have been unused and not in the build system since r119769

* platform/graphics/chromium/CanvasLayerChromium.cpp: Removed.
* platform/graphics/chromium/CanvasLayerChromium.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCast paddings to int in RenderTableCell
morrita@google.com [Fri, 15 Jun 2012 06:17:57 +0000 (06:17 +0000)]
Cast paddings to int in RenderTableCell
https://bugs.webkit.org/show_bug.cgi?id=88918

Patch by Emil A Eklund <eae@chromium.org> on 2012-06-14
Reviewed by Levi Weintraub.

Add test ensuring that table cells does not wrap when using fractional
paddings.

* fast/sub-pixel/table-cells-with-padding-do-not-wrap-expected.txt: Added.
* fast/sub-pixel/table-cells-with-padding-do-not-wrap.html: Added.
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Selection - Crash when manipulating selection by dragging handle
commit-queue@webkit.org [Fri, 15 Jun 2012 06:16:14 +0000 (06:16 +0000)]
[BlackBerry] Selection - Crash when manipulating selection by dragging handle
https://bugs.webkit.org/show_bug.cgi?id=89160

RIMBUG:164970
Avoid to set position in shadow tree to the new selection's base. It
crashes when setting a shadow position to a selection' base.

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-06-14
Reviewed by Antonio Gomes.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCast paddings to int in RenderTableCell
eae@chromium.org [Fri, 15 Jun 2012 06:07:24 +0000 (06:07 +0000)]
Cast paddings to int in RenderTableCell
https://bugs.webkit.org/show_bug.cgi?id=88918

Reviewed by Levi Weintraub.

Source/WebCore:

Table layout uses integers throughout yet the TableCell paddingLeft/
Right/Top/Bottom methods returns LayoutUnits. This causes inconsistent
rounding as some call sites cast the numbers to ints before doing
computation and others do computation before casting.

By changing the methods to always cast the padding values to int we
ensure consistent padding calculations.

Ideally we'd change the type of the return value for the methods but as
they are overriden that would likely cause more confusion.

Test: fast/sub-pixel/table-cells-with-padding-do-not-wrap.html

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):

LayoutTests:

Add test ensuring that table cells does not wrap when using fractional
paddings.

* fast/sub-pixel/table-cells-with-padding-do-not-wrap-expected.txt: Added.
* fast/sub-pixel/table-cells-with-padding-do-not-wrap.html: Added.
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Check the result of FontCache::getCachedFontPlatformData()
bashi@chromium.org [Fri, 15 Jun 2012 05:55:42 +0000 (05:55 +0000)]
[Chromium] Check the result of FontCache::getCachedFontPlatformData()
https://bugs.webkit.org/show_bug.cgi?id=89141

Reviewed by Kent Tamura.

The value of FontCache::getCachedFontPlatformData() could be invalid,
so we should check the value before use it.

No new tests. No new functionality.

* platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix framebuffer completeness test
commit-queue@webkit.org [Fri, 15 Jun 2012 05:53:52 +0000 (05:53 +0000)]
Fix framebuffer completeness test
https://bugs.webkit.org/show_bug.cgi?id=89127

Patch by Gregg Tavares <gman@google.com> on 2012-06-14
Reviewed by Kenneth Russell.

No new tests just fixing failing tests.

* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::initializeAttachments):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::getClearBitsByAttachmentType):
(WebCore):
(WebCore::GraphicsContext3D::getClearBitsByFormat):
(WebCore::GraphicsContext3D::getChannelBitsByFormat):
* platform/graphics/GraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectation update.
morrita@google.com [Fri, 15 Jun 2012 05:29:54 +0000 (05:29 +0000)]
Unreviewed expectation update.
- Marked cross-domain-message-event-dispatch.html and track-cue-rendering-snap-to-lines-not-set.html

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] empty plugin cause browser hang
mary.wu@torchmobile.com.cn [Fri, 15 Jun 2012 05:24:21 +0000 (05:24 +0000)]
[BlackBerry] empty plugin cause browser hang
https://bugs.webkit.org/show_bug.cgi?id=89091

Reviewed by Rob Buis.

Add check before clean pluginView in FrameLoaderBlackBerry in case
it didn't have any content.
RIM PR# 165336
Reviewed internally by George Staikos

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::finishedLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Make TiledLayerChromium robust to unexpected null tiles
enne@google.com [Fri, 15 Jun 2012 04:59:37 +0000 (04:59 +0000)]
[chromium] Make TiledLayerChromium robust to unexpected null tiles
https://bugs.webkit.org/show_bug.cgi?id=89143

Reviewed by James Robinson.

Although there shouldn't ever be null tiles in the map, it appears to
be occurring frequently enough to show up in crash reports. In the
short term, be robust to this so the tiler doesn't crash. This should
eventually be reverted.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoValidate form state strings in FormController::setStateForNewFormElements()
tkent@chromium.org [Fri, 15 Jun 2012 04:34:25 +0000 (04:34 +0000)]
Validate form state strings in FormController::setStateForNewFormElements()
https://bugs.webkit.org/show_bug.cgi?id=88768

Reviewed by Hajime Morita.

.:

* Source/autotools/symbols.filter: Expose some symbols used by Internals.cpp.

Source/WebCore:

Reject invalid form state vectors. This state vectors are generated by
WebKit itself. However it can be invalid because
- Serialized state vectors can be corrupted
- A future version of WebKit might change the format

So we had better reject unexpected state vectors as possible.

Test: fast/forms/state-restore-broken-state.html

* WebCore.exp.in: Expose some symbols used by Internals.cpp.
* html/FormController.cpp:
(WebCore::isNotFormControlTypeCharacter): A helper for state validation.
(WebCore::FormController::setStateForNewFormElements):
Reject state vectors of which size is not a multiple of 3, or a type name is invalid.
* testing/Internals.cpp:
(WebCore::Internals::formControlStateOfPreviousHistoryItem):
Returns a form state vector of the previous document.
(WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
Sets a form state vector for the previous document.
* testing/Internals.h: Declare new functions.
* testing/Internals.idl: ditto.

Source/WebKit2:

* win/WebKit2.def: Expose some symbols used by Internals.cpp.
* win/WebKit2CFLite.def: ditto.

LayoutTests:

* fast/forms/resources/state-restore-broken-state-1.html: Added.
* fast/forms/resources/state-restore-broken-state-2.html: Added.
* fast/forms/state-restore-broken-state-expected.txt: Added.
* fast/forms/state-restore-broken-state.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r120393.
commit-queue@webkit.org [Fri, 15 Jun 2012 04:21:38 +0000 (04:21 +0000)]
Unreviewed, rolling out r120393.
http://trac.webkit.org/changeset/120393
https://bugs.webkit.org/show_bug.cgi?id=89163

breaks cr-mac build (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-14

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* platform/image-decoders/ImageDecoder.h:
(ImageFrame):
(ImageDecoder):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(turboSwizzled):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::decode):
(JPEGImageReader):
(WebCore::JPEGImageDecoder::outputScanlines):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::currentBufferSize):
(PNGImageReader):
(WebCore::PNGImageReader::decodingSizeOnly):
(WebCore::PNGImageReader::interlaceBuffer):
(WebCore::PNGImageReader::hasAlpha):
(WebCore::PNGImageReader::setHasAlpha):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore):
(WebCore::resolveColorSpace):
(WebCore::createColorSpace):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):

Source/WTF:

* wtf/Platform.h:

LayoutTests:

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRenderLayer subtrees without any self-painting layer shouldn't be walked during painting
jchaffraix@webkit.org [Fri, 15 Jun 2012 04:17:39 +0000 (04:17 +0000)]
RenderLayer subtrees without any self-painting layer shouldn't be walked during painting
https://bugs.webkit.org/show_bug.cgi?id=88888

Reviewed by Simon Fraser.

Performance optimization, covered by existing tests.

The gist of this change is to add a has-self-painting-layer-descendant flag (including an
invalidation logic) that is used to avoid walking subtrees without any self-painting layer.

On http://dglazkov.github.com/performance-tests/biggrid.html with a 100,000 rows
by 100 columns table, it brings the paint time during scrolling from ~45ms to ~6ms
on my machine. The test case is a pathologic example here but the optimization should
apply in other cases.

The new update logic piggy-backs on top of the existing updateVisibilityStatus() one that
got repurposed and renamed as part of this change.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::styleChanged):
These functions were updated to dirty / set the new flag.

(WebCore::RenderLayer::dirtyAncestorChainHasSelfPaintingLayerDescendantStatus):
(WebCore::RenderLayer::setAncestorChainHasSelfPaintingLayerDescendant):
Added those functions to handle setting / invalidating the new flag.

(WebCore::RenderLayer::updateSelfPaintingLayerAfterStyleChange):
Added this function to handle style update.

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):
Changed this logic to bail out if we have no self-painting descendants. This is what
is giving the performance improvement. Also added some performance ASSERTs to ensure
the methods are not called when they shouldn't.

(WebCore::RenderLayer::updateDescendantDependentFlags):
Renamed from updateVisibilityStatus to account for the new usage.

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::collectLayers):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
Updated after updateVisibilityStatus rename.

* rendering/RenderLayer.h:
(WebCore::RenderLayer::hasSelfPaintingLayerDescendant):
Added the declaration of the new functions as well as the new flag and dirty bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium-Android] Initialize font rendering in DumpRenderTree
wangxianzhu@chromium.org [Fri, 15 Jun 2012 03:06:53 +0000 (03:06 +0000)]
[Chromium-Android] Initialize font rendering in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=89133

Reviewed by Adam Barth.

Source/WebKit/chromium:

* src/linuxish/WebFontRendering.cpp:
(WebKit::WebFontRendering::setSubpixelPositioning): Now calls WebFontInfo::setSubpixelPositioning to avoid API users from calling both and simplify platform differences at call sites.

Tools:

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):
* DumpRenderTree/chromium/TestShellAndroid.cpp:
(platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [chromium] Add iccjpeg and qcms to chromium port
commit-queue@webkit.org [Fri, 15 Jun 2012 02:53:17 +0000 (02:53 +0000)]
Source/WebCore:        [chromium] Add iccjpeg and qcms to chromium port
       https://bugs.webkit.org/show_bug.cgi?id=81974

       Reviewed by Adam Barth.

       Covered by existing layout tests which will be rebaselined.

       * WebCore.gyp/WebCore.gyp: Add qcms to the build.
       * platform/image-decoders/ImageDecoder.h:
       (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile.
       On OSX, return the default RGB profile. Add FIXME to use the user's
       monitor profile and verify that profile for other platforms.

       * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
       (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the
       two known output color spaces for which the decoder uses a data swizzle.
       (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For
       libjpeg-turbo, alpha may be present in the swizzled output color space.

       (WebCore::JPEGImageReader::JPEGImageReader):
       (WebCore::JPEGImageReader::close):
       (WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
       to use during decoding, and ensure we switch to inputing RGBA data to qcms
       even if the desired output data is BGRA: outputScanlines() sends BGRA data
       to the frame buffer following color correction if needed.
       (JPEGImageReader):
       (WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
       (WebCore::JPEGImageReader::createColorTransform): Create color transform.
       Release the existing transform (if any) and assign to the color transform
       created from the color profile data.
       (WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
       transform to each decoded image row.

       * platform/image-decoders/png/PNGImageDecoder.cpp:
       (WebCore::PNGImageReader::PNGImageReader):
       (WebCore::PNGImageReader::close):
       (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other
       setters and getters.
       (WebCore::PNGImageReader::decodingSizeOnly): Ditto.
       (WebCore::PNGImageReader::setHasAlpha): Ditto.
       (WebCore::PNGImageReader::hasAlpha): Ditto.
       (WebCore::PNGImageReader::interlaceBuffer): Ditto.
       (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer,
       used when a color transform is applied to the decoded image pixels.
       (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer.
       (WebCore::PNGImageReader::colorTransform): qcms color transform getter.
       (WebCore::PNGImageReader::createColorTransform): Create color transform.
       Release the existing transform (if any) and assign to the color transform
       created from the color profile data.
       (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color
       transform to use for decoding. Clear m_colorProfile (not used anymore).
       (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if
       a color transform is needed for decoding. Apply color transform to each
       decoded image row.

       * platform/image-decoders/skia/ImageDecoderSkia.cpp:
       (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no
       longer used. Add a FIXME to remove the old implementation.
       (WebCore::ImageFrame::setStatus): Remove old color correction code.

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-14

Source/WTF: [chromium] Add iccjpeg and qcms to chromium port.
https://bugs.webkit.org/show_bug.cgi?id=81974

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-14

* wtf/Platform.h: Add Chromium USE defines for ICCJPEG and QCMSLIB
to each Chromium platform, excluding Android.

Reviewed by Adam Barth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r120384.
commit-queue@webkit.org [Fri, 15 Jun 2012 02:50:55 +0000 (02:50 +0000)]
Unreviewed, rolling out r120384.
http://trac.webkit.org/changeset/120384
https://bugs.webkit.org/show_bug.cgi?id=89157

breaks create-blob-url-from-data-url.html (Requested by
morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-14

Source/WebCore:

* fileapi/Blob.cpp:
(WebCore::Blob::Blob):
* fileapi/BlobURL.cpp:
(WebCore::BlobURL::createBlobURL):
* fileapi/BlobURL.h:
(BlobURL):
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
* fileapi/ThreadableBlobRegistry.cpp:
(WebCore):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
* fileapi/ThreadableBlobRegistry.h:
(WebCore):
(ThreadableBlobRegistry):
* html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::create):

LayoutTests:

* fast/files/file-reader-file-url-expected.txt: Removed.
* fast/files/file-reader-file-url.html: Removed.
* fast/files/resources/file-reader-file-url-iframe.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Port IFrameRedirectTest.Test from test_shell_tests to webkit_unit_tests
tony@chromium.org [Fri, 15 Jun 2012 02:46:41 +0000 (02:46 +0000)]
[chromium] Port IFrameRedirectTest.Test from test_shell_tests to webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=89132

Reviewed by Adam Barth.

This test is currently in src/webkit/glue/iframe_redirect_unittest.cc
and uses test_shell's layoutTestController. Moving this will make
it easier to get rid of layoutTestController in test_shell.

* tests/WebFrameTest.cpp:
(WebKit::TEST_F):
(WebKit):
* tests/data/iframe_redirect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h}
yosin@chromium.org [Fri, 15 Jun 2012 02:25:15 +0000 (02:25 +0000)]
[Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=89155

Reviewed by Kent Tamura.

This patch copies RenderTextControlSingleLine.cpp and .h into RenderSearchField.cpp
and .h with just "cp" code. New files aren't compiled until bug 88980.

No new tests. This patch doesn't change behavior.

* rendering/RenderSearchField.cpp: Added.
(WebCore::RenderTextControlInnerBlock::positionForPoint):
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::containerElement):
(WebCore::RenderTextControlSingleLine::innerBlockElement):
(WebCore::RenderTextControlSingleLine::innerSpinButtonElement):
(WebCore::RenderTextControlSingleLine::resultsButtonElement):
(WebCore::RenderTextControlSingleLine::cancelButtonElement):
(WebCore::RenderTextControlSingleLine::textBaseStyle):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::paint):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::styleDidChange):
(WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
(WebCore::RenderTextControlSingleLine::hasControlClip):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::getAvgCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::computeControlHeight):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
(WebCore::RenderTextControlSingleLine::autosaveName):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::itemText):
(WebCore::RenderTextControlSingleLine::itemLabel):
(WebCore::RenderTextControlSingleLine::itemIcon):
(WebCore::RenderTextControlSingleLine::itemIsEnabled):
(WebCore::RenderTextControlSingleLine::itemStyle):
(WebCore::RenderTextControlSingleLine::menuStyle):
(WebCore::RenderTextControlSingleLine::clientInsetLeft):
(WebCore::RenderTextControlSingleLine::clientInsetRight):
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
(WebCore::RenderTextControlSingleLine::listSize):
(WebCore::RenderTextControlSingleLine::selectedIndex):
(WebCore::RenderTextControlSingleLine::popupDidHide):
(WebCore::RenderTextControlSingleLine::itemIsSeparator):
(WebCore::RenderTextControlSingleLine::itemIsLabel):
(WebCore::RenderTextControlSingleLine::itemIsSelected):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::fontSelector):
(WebCore::RenderTextControlSingleLine::hostWindow):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):
(WebCore::RenderTextControlSingleLine::createScrollbar):
(WebCore::RenderTextControlSingleLine::inputElement):
* rendering/RenderSearchField.h: Added.
(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::popupIsVisible):
(WebCore::RenderTextControlSingleLine::isTextField):
(WebCore::toRenderTextControlSingleLine):
(RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[JSC/V8] "DOMString[]" for function return values should not be null
tkent@chromium.org [Fri, 15 Jun 2012 02:11:28 +0000 (02:11 +0000)]
[JSC/V8] "DOMString[]" for function return values should not be null
https://bugs.webkit.org/show_bug.cgi?id=89151

Reviewed by Kentaro Hara.

jsArray and v8Array are used for "DOMString[]", not "DOMString[]?". So
we should not return JavaScript null object.

No new tests. We have no plan to use this code in production code for
now. It will be used for window.internals functions.

* bindings/js/JSDOMBinding.cpp:
(WebCore::jsArray): For null input, returns an empty array, not null.
* bindings/v8/V8Binding.cpp:
(WebCore::v8Array): Implement DOMStringList -> JavaScript array conversion.
Like jsArray(), we don't return null object.
* bindings/v8/V8Binding.h:
(WebCore): Declare v8Array().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms.
commit-queue@webkit.org [Fri, 15 Jun 2012 02:04:43 +0000 (02:04 +0000)]
Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms.
https://bugs.webkit.org/show_bug.cgi?id=89129

Source/WebCore:

As titled, click-to-pause and double-click-to-play behavior are unwanted on Chromium.  A
long standing issue (~3 years) has been to disable this feature.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-06-14
Reviewed by Eric Carlson.

Uses existing click/double-click test.

* html/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):

LayoutTests:

Fixes layout test to actually test what it says it tests.  Previously it was
testing the opposite behavior and passing because MediaDocument auto-plays.

Additionally failing one half of the test would still allow you to pass the
other half.  Both issues have been fixed.

Updates the test expectations for Chromium to reflect a failure.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-06-14
Reviewed by Eric Carlson.

* media/video-click-dblckick-standalone-expected.txt:
* media/video-click-dblckick-standalone.html:
* platform/chromium/media/video-click-dblckick-standalone-expected.txt: Copied from LayoutTests/media/video-click-dblckick-standalone-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Skip the failed test due to r120384 for future investigation.
jianli@chromium.org [Fri, 15 Jun 2012 01:45:44 +0000 (01:45 +0000)]
Unreviewed. Skip the failed test due to r120384 for future investigation.

* platform/chromium/TestExpectations:
* platform/efl/Skipped:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120387 268f45cc-cd09-0410-ab3c-d52691b4dbfc