weinig [Fri, 13 Jul 2007 22:37:38 +0000 (22:37 +0000)]
LayoutTests:
Reviewed by Geoff Garen.
Tests for <rdar://problem/
5318394>
http site can read/write content of https site in same domain
Adds ssl configuration information and tests.
* http/conf/apache2-httpd.conf:
* http/conf/cygwin-httpd.conf:
* http/conf/httpd.conf:
* http/conf/webkit-httpd.pem: Added.
* http/tests/security/cross-frame-access-expected.txt:
* http/tests/security/cross-frame-access-first-time-expected.txt:
* http/tests/security/cross-frame-access-protocol-expected.txt: Added.
* http/tests/security/cross-frame-access-protocol.html: Added.
* http/tests/security/cross-frame-access-put-expected.txt:
* http/tests/ssl: Added.
* http/tests/ssl/resources: Added.
* http/tests/ssl/resources/cross-frame-access-protocol-iframe.html: Added.
* http/tests/ssl/verify-ssl-enabled-expected.txt: Added.
* http/tests/ssl/verify-ssl-enabled.php: Added.
WebCore:
Reviewed by Geoff Garen.
Patch for <rdar://problem/
5318394>
http site can read/write content of https site in same domain
Add protocol and port checks in isSafeScript.
* bindings/js/kjs_window.cpp:
(KJS::Window::isSafeScript):
WebKitTools:
Reviewed by Geoff Garen.
Add support for running SSL tests over HTTPS.
* DumpRenderTree/DumpRenderTree.m:
(runTest):
* DumpRenderTree/FrameLoadDelegate.m:
(-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
* Scripts/run-webkit-httpd:
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 13 Jul 2007 22:20:13 +0000 (22:20 +0000)]
Reviewed by Mitz Pettel.
<rdar://problem/
5298870>
REGRESSION: In Yahoo Mail modal dialog, OK and Cancel buttons do not work, and descriptive text is missing (14327)
http://bugs.webkit.org/show_bug.cgi?id=14327
REGRESSION (r21367): dialogArguments not set in window generated by showModalDialog
When creating popup windows/dialogs, prevent the window properties from being cleared by the initial frame load.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::createWindow):
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::begin):
(WebCore::FrameLoader::open):
* loader/FrameLoader.h:
(WebCore::FrameLoader::setShouldClearWindowProperties):
* manual-tests/modal-dialog-arguments.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 13 Jul 2007 21:45:04 +0000 (21:45 +0000)]
Reviewed by Oliver Hunt.
<rdar://problem/
5333766> Can't include WebEditingDelegatePrivate.h
* WebView/WebEditingDelegatePrivate.h: Changed the include to be a framework include,
so other projects can use this header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Fri, 13 Jul 2007 21:29:14 +0000 (21:29 +0000)]
Bump version for submit
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Fri, 13 Jul 2007 20:17:16 +0000 (20:17 +0000)]
Update ResourceError related code to account for changes in CF interfaces.
Reviewed by Darin, Ada.
* platform/network/ResourceError.h: Change Mac conditionals to CF to share more code.
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::ResourceError): Modified based on CFErrorRef changes
(WebCore::ResourceError::unpackPlatformError): Ported from ResourceErrorMac.mm.
(WebCore::ResourceError::operator CFErrorRef): Ported from ResourceErrorMac.mm.
(WebCore::ResourceError::operator CFStreamError): Modified based on CFErrorRef changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 13 Jul 2007 19:06:53 +0000 (19:06 +0000)]
Reviewed by Darin and Maciej.
<rdar://problem/
5271096> panic after Safari stress test, caused by port leak
Replace uses of -[NSObject performSelector:withObject:afterDelay:] with CFRunLoopTimer. performSelector
causes the target (the WebHTMLView in this case) to be retained until the timer fires. Furthermore, when
running the PLT or iBench, the timers will not fire until the main loop is entered (usually after running all tests).
This means that the timers and ports will not be released until after the test has finished running.
* WebView/WebHTMLView.mm:
(-[WebHTMLViewPrivate dealloc]):
(-[WebHTMLView _cancelUpdateMouseoverTimer]):
(-[WebHTMLView _updateMouseoverWithFakeEvent]):
(-[WebHTMLView _updateMouseoverTimerCallback:]):
(-[WebHTMLView _frameOrBoundsChanged]):
(-[WebHTMLView _updateActiveState]):
(-[WebHTMLView _updateActiveStateTimerCallback:]):
(-[WebHTMLView viewWillMoveToWindow:]):
(-[WebHTMLView viewDidMoveToWindow]):
(-[WebHTMLView mouseDown:]):
(-[WebTextCompleteController dealloc]):
* WebView/WebHTMLViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Fri, 13 Jul 2007 18:55:42 +0000 (18:55 +0000)]
LayoutTests:
Reviewed by Adele.
Test for <rdar://problem/
5192256>
click() in onchange handler causes another change event (causes hang at http://forums.whirlpool.net.au/)
* fast/events/onchange-click-hang-expected.txt: Added.
* fast/events/onchange-click-hang.html: Added.
WebCore:
Reviewed by Adele.
Fix <rdar://problem/
5192256>
click() in onchange handler causes another change event (causes hang at http://forums.whirlpool.net.au/)
Guard against generating a simulated event from within a simulated event in the same node. Try to
match Firefox behavior.
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::dispatchSimulatedMouseEvent):
(WebCore::EventTargetNode::dispatchSimulatedClick):
* dom/Node.cpp:
(WebCore::Node::Node):
* dom/Node.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Fri, 13 Jul 2007 18:29:30 +0000 (18:29 +0000)]
LayoutTests:
Reviewed by Darin.
Test for x <rdar://problem/
5333387>
Combination of selection and click() on checkbox crashes
* fast/dynamic/checkbox-selection-crash-expected.txt: Added.
* fast/dynamic/checkbox-selection-crash.html: Added.
WebCore:
Reviewed by Darin.
Fix <rdar://problem/
5333387>
Combination of selection and click() on checkbox crashes
Ensure there is no pending style update before doing synchronous paint. Under certain
circumstances this ends up doing style recalc in middle of paint() which may
for example tear down the rendering tree being painted, with bad results.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::setActive):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Fri, 13 Jul 2007 18:16:15 +0000 (18:16 +0000)]
2007-07-13 David Kilzer <ddkilzer@apple.com>
Reviewed by Darin.
Added support for -h|--help argument and verify that all command line arguments parse
correctly.
* Scripts/run-webkit-httpd:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Fri, 13 Jul 2007 18:13:01 +0000 (18:13 +0000)]
Fixed comment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Fri, 13 Jul 2007 18:11:02 +0000 (18:11 +0000)]
LayoutTests:
Reviewed by Adele.
Test for <rdar://problem/
5333365>
Calling click() is very slow
* fast/forms/slow-click-expected.txt: Added.
* fast/forms/slow-click.html: Added.
WebCore:
Reviewed by Adele.
Fix <rdar://problem/
5333365>
Calling click() is very slow
There is a 100ms delay in ContainerNode::setActive() to do an activation effect. It is used for
simulated mouse activations (using keyboard for example). However, it shouldn't be done when calling from javascript
(through click() interface) since it hangs script execution.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::click):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 13 Jul 2007 17:21:03 +0000 (17:21 +0000)]
Update versioning of trunk.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 13 Jul 2007 16:34:03 +0000 (16:34 +0000)]
2007-07-14 Mark Rowe <mrowe@apple.com>
Reviewed by Sam.
Apply the change to Apache 2 configuration from r24204 to the other two Apache configuration files.
* http/conf/cygwin-httpd.conf:
* http/conf/httpd.conf:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 13 Jul 2007 12:00:23 +0000 (12:00 +0000)]
2007-07-13 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=13873
Incomplete repaint of replaced element's box shadow
Tests: fast/repaint/box-shadow-h.html
fast/repaint/box-shadow-v.html
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::layout): Added a call to adjustOverflowForBoxShadow().
* rendering/RenderImage.cpp:
(WebCore::RenderImage::layout): Ditto.
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::layout): Ditto.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced): Initialize m_hasOverflow.
(WebCore::RenderReplaced::~RenderReplaced): Added. Removes this object from the
overflow rect map if it has overflow.
(WebCore::RenderReplaced::shouldPaint): Account for overflow.
(WebCore::RenderReplaced::adjustOverflowForBoxShadow): Added. Creates or
removes an entry for this object in the global overflow rect map.
(WebCore::RenderReplaced::overflowHeight): Added.
(WebCore::RenderReplaced::overflowWidth): Added.
(WebCore::RenderReplaced::overflowLeft): Added.
(WebCore::RenderReplaced::overflowTop): Added.
(WebCore::RenderReplaced::overflowRect): Added.
* rendering/RenderReplaced.h:
2007-07-13 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- updated tests and results for http://bugs.webkit.org/show_bug.cgi?id=13873
Incomplete repaint of replaced element's box shadow
* fast/repaint/box-shadow-h-expected.checksum:
* fast/repaint/box-shadow-h-expected.png:
* fast/repaint/box-shadow-h-expected.txt:
* fast/repaint/box-shadow-h.html:
* fast/repaint/box-shadow-v-expected.checksum:
* fast/repaint/box-shadow-v-expected.png:
* fast/repaint/box-shadow-v-expected.txt:
* fast/repaint/box-shadow-v.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 13 Jul 2007 11:51:40 +0000 (11:51 +0000)]
2007-07-13 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=14395
When a <p> is inside <li> two <BR>s are rendered
Test: fast/lists/marker-before-empty-inline.html
* rendering/RenderBlock.h:
* rendering/RenderListItem.cpp:
(WebCore::getParentOfFirstLineBox): Changed to skip empty inline flows that
do not actually generate any line boxes. Limited the nested lists quirk to
the case where the list is a child of the list item, to match Firefox.
* rendering/bidi.cpp:
(WebCore::requiresLineBox): Added. Factored out of skipWhitespace.
(WebCore::RenderBlock::generatesLineBoxesForInlineChild): Added. Checkes
whether the child or any of its siblings following it will generate a line
box in the flow.
(WebCore::RenderBlock::skipWhitespace):
2007-07-13 Mitz Pettel <mitz@webkit.org>
Reviewed by Dave Hyatt.
- test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14395
When a <p> is inside <li> two <BR>s are rendered
* editing/pasteboard/
4861080-expected.checksum:
* editing/pasteboard/
4861080-expected.png:
* editing/pasteboard/
4861080-expected.txt:
* fast/lists/marker-before-empty-inline-expected.checksum: Added.
* fast/lists/marker-before-empty-inline-expected.png: Added.
* fast/lists/marker-before-empty-inline-expected.txt: Added.
* fast/lists/marker-before-empty-inline.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 13 Jul 2007 11:47:10 +0000 (11:47 +0000)]
2007-07-13 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Alexey.
Move HTTP methods to parse Content-Type from xmlhttprequest.cpp
which is LGPL to HTTPParsers.cpp. As both files were written by the
same author and the advice to move them came from him I think this move
is what is meant to be done.
Move filenameFromHTTPContentDisposition to HTTPParsers as well. This parse
function uses Vector<String>::split and doesn't honor quoting. This needs
to be fixed in later versions.
http://bugs.webkit.org/show_bug.cgi?id=5954 and http://bugs.webkit.org/show_bug.cgi?id=14059
benefit from this change.
* platform/network/HTTPParsers.cpp:
(WebCore::filenameFromHTTPContentDisposition):
(WebCore::extractMIMETypeFromMediaType):
(WebCore::extractCharsetFromMediaType):
* platform/network/HTTPParsers.h:
* platform/network/cf/ResourceResponseCFNet.cpp:
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::responseMIMEType):
(WebCore::XMLHttpRequest::didReceiveResponse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 13 Jul 2007 05:46:07 +0000 (05:46 +0000)]
2007-07-13 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Build fix. Stub out ChromeClientGdk::print and SVGEmptyChromeClient::print.
* platform/gdk/ChromeClientGdk.h:
* platform/gdk/TemporaryLinkStubs.cpp:
(ChromeClientGdk::print):
* platform/graphics/svg/SVGImageEmptyClients.h:
(WebCore::SVGEmptyChromeClient::print):
2007-07-13 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Build fix. Stub out WebChromeClient::print.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::print):
2007-07-13 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Build fix. Stub out ChromeClientQt::print.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::print):
* WebCoreSupport/ChromeClientQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Fri, 13 Jul 2007 05:00:51 +0000 (05:00 +0000)]
WebCore:
Reviewed by Maciej and Steve.
fixed <rdar://
4982432> window.print() needs to be implemented
* bridge/win/FrameWin.cpp:
(WebCore::Frame::print):
* page/Chrome.cpp:
(WebCore::Chrome::print):
* page/Chrome.h:
* page/ChromeClient.h:
* platform/win/TemporaryLinkStubs.cpp:
win:
Reviewed by Maciej and Steve.
fixed <rdar://
4982432> window.print() needs to be implemented
* Interfaces/IWebUIDelegate.idl:
* WebChromeClient.cpp:
(WebChromeClient::print):
* WebChromeClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Fri, 13 Jul 2007 03:16:27 +0000 (03:16 +0000)]
2007-07-12 George Staikos <staikos@kde.org>
Reviewed by NOBODY.
Backed out previous change. This worked fine with Safari, but not so much with DumpRenderTree.
* http/tests/security/cross-frame-access-put.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Fri, 13 Jul 2007 02:53:15 +0000 (02:53 +0000)]
2007-07-12 David Kilzer <ddkilzer@apple.com>
Reviewed by NOBODY.
Don't hard code the hostname to make it work with run-webkit-httpd on other interfaces.
* http/tests/security/cross-frame-access-put.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 12 Jul 2007 19:26:56 +0000 (19:26 +0000)]
LayoutTests:
Reviewed by Harrison.
<rdar://problem/
5300379> Mail hung on option-delete
* editing/deleting/
5300379-expected.checksum: Added.
* editing/deleting/
5300379-expected.png: Added.
* editing/deleting/
5300379-expected.txt: Added.
* editing/deleting/
5300379.html: Added.
WebCore:
Reviewed by Harrison.
<rdar://problem/
5300379> Mail hung on option-delete
We were starting backward iteration at [container, 0] and
emitting for container over and over.
* editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::advance): Don't
emit characters for a node if we're starting iteration at
[container, 0]. Don't emit characters for exiting containers
if we've already done so.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 12 Jul 2007 19:14:58 +0000 (19:14 +0000)]
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=14596
Fix JSC compilation with KJS_VERBOSE.
* kjs/function.cpp:
(KJS::FunctionImp::passInParameters):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker [Thu, 12 Jul 2007 17:37:06 +0000 (17:37 +0000)]
Reviewed by Mark Rowe.
<rdar://problem/
5039463> find a good gray that works well for full frame plug-ins; consistent look for plugins
* loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::createDocumentStructure): Changed values to a darker gray, per request from the HI team.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 12 Jul 2007 16:34:14 +0000 (16:34 +0000)]
LayoutTests:
Reviewed by Maciej.
Test for <rdar://problem/
5329841>
Calling window.closed on a closed window causes Safari to crash
* fast/dom/Window/window-closed-crash-expected.txt: Added.
* fast/dom/Window/window-closed-crash.html: Added.
WebCore:
Reviewed by Maciej.
Patch for <rdar://problem/
5329841>
Calling window.closed on a closed window causes Safari to crash
- Replaces the Frame member variable in KJS::Window for more appropriate DOMWindow
- Adds additional new null checks as necessary
- Removes bogus toBoolean method
- Removes unused scheduleClose method
Test: fast/dom/Window/window-closed-crash.html
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::create):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::customGetOwnPropertySlot):
(WebCore::JSDOMWindow::customPut):
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
* bindings/js/kjs_events.cpp:
(WebCore::JSAbstractEventListener::handleEvent):
(WebCore::JSLazyEventListener::parseCode):
* bindings/js/kjs_window.cpp:
(KJS::Window::Window):
(KJS::Window::impl):
(KJS::Window::interpreter):
(KJS::Window::location):
(KJS::Window::find):
(KJS::allowPopUp):
(KJS::createWindow):
(KJS::canShowModalDialog):
(KJS::canShowModalDialogNow):
(KJS::showModalDialog):
(KJS::Window::getValueProperty):
(KJS::Window::childFrameGetter):
(KJS::Window::indexGetter):
(KJS::Window::namedItemGetter):
(KJS::Window::getOwnPropertySlot):
(KJS::Window::put):
(KJS::Window::isSafeScript):
(KJS::Window::setListener):
(KJS::Window::getListener):
(KJS::Window::clear):
(KJS::WindowFunc::callAsFunction):
(KJS::Window::updateLayout):
(KJS::ScheduledAction::execute):
(KJS::Window::disconnectFrame):
(KJS::Location::put):
(KJS::LocationFunc::callAsFunction):
* bindings/js/kjs_window.h:
* page/mac/WebCoreFrameBridge.mm:
(updateRenderingForBindings):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 12 Jul 2007 16:24:48 +0000 (16:24 +0000)]
2007-07-12 Mitz Pettel <mitz@webkit.org>
Reviewed by Mark Rowe.
- try to fix hang seen on buildbot after the last fix
* fast/history/resources/history_reload_window.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 12 Jul 2007 15:15:06 +0000 (15:15 +0000)]
2007-07-12 Mitz Pettel <mitz@webkit.org>
Reviewed by Mark Rowe.
- fix an assertion failure in DumpRenderTree when running fast/history/resources/history_reload_window.html
* fast/history/resources/history_reload_window.html: Delay notifyDone() until
after the window actually closes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 12 Jul 2007 14:01:41 +0000 (14:01 +0000)]
2007-07-12 Mark Rowe <mrowe@apple.com>
Reviewed by Ada.
<rdar://problem/
5329877> REGRESSION: Document::setTransformSource leaks an xmlDocPtr if called more than once per document
* dom/Document.cpp:
(WebCore::Document::setTransformSource): Free any existing m_transformSource before overwriting it, rather than simply leaking it.
* dom/Document.h:
2007-07-12 Mark Rowe <mrowe@apple.com>
Reviewed by Ada.
Remove leak suppression for xmlDocPtrForString now that <rdar://problem/
5329877> is fixed.
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 12 Jul 2007 11:18:53 +0000 (11:18 +0000)]
2007-07-12 Maxime Britto <mbritto@pleyo.com>
Reviewed by Mark Rowe.
Update the expected results now that they match what the test describes as the correct rendering.
* svg/custom/invalid-fill-hex-expected.txt:
* svg/custom/invalid-fill-hex-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 12 Jul 2007 10:49:35 +0000 (10:49 +0000)]
2007-07-12 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
Fix compilation of the CURL backend after the removing of accessors from ResourceHandle in r24202
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::setupPOST):
(WebCore::ResourceHandleManager::startJob):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 12 Jul 2007 08:15:21 +0000 (08:15 +0000)]
Reviewed by Oliver Hunt.
Made the leaks tests pass on Leopard.
* Scripts/run-webkit-tests: Added some leaks to exclude on Leopard.
* Scripts/run-leaks: Updated parser for slight change in text output.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 12 Jul 2007 07:21:00 +0000 (07:21 +0000)]
2007-07-12 Mark Rowe <mrowe@apple.com>
Reviewed by Darin.
<rdar://problem/
5327189> Logic error in DeprecatedString::to{,U}Int{,64} can lead to reading past end of buffer
The fix for reading past the end of the buffer is to verify we are not at the end of the string before checking
for a leading '+' character. Rather than fixing the logic error in four nearly-identical functions I chose to
extract the common functionality into the toIntegralType helper function which the four functions call through to.
* platform/DeprecatedString.cpp:
(WebCore::isCharacterAllowedInBase):
(WebCore::toIntegralType):
(WebCore::DeprecatedString::toInt):
(WebCore::DeprecatedString::toInt64):
(WebCore::DeprecatedString::toUInt):
(WebCore::DeprecatedString::toUInt64):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Thu, 12 Jul 2007 06:23:06 +0000 (06:23 +0000)]
Bump version for submit
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 12 Jul 2007 05:06:46 +0000 (05:06 +0000)]
remove two unused variables and fix combobox rendering
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Thu, 12 Jul 2007 04:34:48 +0000 (04:34 +0000)]
Reviewed by Maciej
Fix for <rdar://problem/
5329712> GMail crash when trying to compose new message
* platform/win/FontDataWin.cpp:
(WebCore::FontData::containsCharacters):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 12 Jul 2007 04:17:17 +0000 (04:17 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14584
XMLHttpRequest treats null login/password incorrectly
Test: http/tests/xmlhttprequest/null-auth.php
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::open):
* xml/xmlhttprequest.h:
Split the open() method into three to distinguish between missing and null credentials.
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): Call the appropriate open().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 12 Jul 2007 03:04:45 +0000 (03:04 +0000)]
Fix build in debug mode
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Thu, 12 Jul 2007 02:48:15 +0000 (02:48 +0000)]
2007-07-11 David Kilzer <ddkilzer@apple.com>
Reviewed by Maciej.
Update the iExploder list of CSS properties after box-sizing was renamed to
-webkit-box-sizing in r21026 to fix <rdar://problem/
4667227>.
* iExploder/htdocs/cssproperties.in: Added -webkit-box-sizing. Both box-sizing and
-moz-box-sizing remain.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 12 Jul 2007 02:22:33 +0000 (02:22 +0000)]
Make it compile
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Thu, 12 Jul 2007 02:07:51 +0000 (02:07 +0000)]
Build fix for windows
* page/Frame.cpp:
(WebCore::Frame::firstRectForRange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Thu, 12 Jul 2007 01:20:34 +0000 (01:20 +0000)]
Reviewed by Maciej.
Fix <rdar://problem/
5329481> Character range rect code for IME support needs to be crossplatform
Move -[WebCoreFrameBridge firstRectForDOMRange:] to Frame::firstRectForRange
* page/Frame.cpp:
(WebCore::Frame::firstRectForRange):
* page/Frame.h:
* page/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge firstRectForDOMRange:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 11 Jul 2007 23:17:40 +0000 (23:17 +0000)]
Reviewed by Oliver.
<rdar://problem/
5108789> WEBVIEW: Drawing artifacts when dragging in IB
Interface Builder 3 is relying on KVO notifications for frameOrigin and frameSize,
among other standard NSView keys. Change automaticallyNotifiesObserversForKey to
return NO only for keys WebView manually fires notifications for.
* WebView/WebView.mm:
(+[WebView automaticallyNotifiesObserversForKey:]): Selectivly return NO for keys we manually fire.
(-[WebView _declaredKeys]): Code clean up.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 11 Jul 2007 22:49:51 +0000 (22:49 +0000)]
Static analysis build fix.
Only specify /analyze (PREfast) if it is available.
Prevents entire project from rebuilding each time.
Reviewed by Hyatt.
* WebKit.vcproj/WebKit.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 11 Jul 2007 22:49:18 +0000 (22:49 +0000)]
Static analysis build fix.
Only specify /analyze (PREfast) if it is available.
Prevents entire project from rebuilding each time.
Reviewed by Hyatt.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 11 Jul 2007 22:01:41 +0000 (22:01 +0000)]
Make comboboxes update when the current item is changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 11 Jul 2007 19:59:45 +0000 (19:59 +0000)]
Add a destructor to cleanup the SQL handle (presently unused, but will be soon).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 11 Jul 2007 19:29:16 +0000 (19:29 +0000)]
Fix build with assertions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 11 Jul 2007 19:24:17 +0000 (19:24 +0000)]
top level:
Reviewed by Darin.
As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
* WebKit.pri: Adjust INCLUDEPATH
JavaScriptCore:
Reviewed by Darin.
As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
* ForwardingHeaders: Added.
* ForwardingHeaders/JavaScriptCore: Copied from WebCore/ForwardingHeaders/JavaScriptCore.
WebCore:
Reviewed by Darin.
As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
* ForwardingHeaders/JavaScriptCore: Removed.
* ForwardingHeaders/JavaScriptCore/APICast.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSBase.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSContextRef.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSStringRef.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Removed.
* ForwardingHeaders/JavaScriptCore/JSValueRef.h: Removed.
* ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 11 Jul 2007 19:22:39 +0000 (19:22 +0000)]
Fix build.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
(WebCore::didReceiveResponse):
(WebCore::didReceiveData):
(WebCore::didFinishLoading):
(WebCore::didFail):
(WebCore::didReceiveChallenge):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 11 Jul 2007 19:20:04 +0000 (19:20 +0000)]
Another build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 11 Jul 2007 19:16:43 +0000 (19:16 +0000)]
Repair the build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 11 Jul 2007 19:09:39 +0000 (19:09 +0000)]
Reviewed by Darin.
Fix for <rdar://problem/
5230188> REGRESSION: Active/inactive marked text is not distinguished in textfields and textareas
We were previously trying to leave room for 1px of space between the text and the underline.
This change removes that requirement so that if we don't have room for the extra space, we still draw the thick underline
touching the text.
* rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextUnderline):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 11 Jul 2007 18:47:33 +0000 (18:47 +0000)]
Reviewed by Darin and Geoff.
<rdar://problem/
5313508>
REGRESSION (Leopard): http/tests/xmlhttprequest/basic-auth.html hangs
Leopard Foundation now ignores credentials passed in as part of the URL so we need to pass them ourselves.
For the asynchronous case, we simply keep track of the URL and if it has a user name and password, we
pass those if we're asked to authenticate.
For the synchronous case, implement a new connection delegate and run it in a separate mode so
no other sources will fire.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::loadResourceSynchronously):
(-[WebCoreResourceHandleAsDelegate dealloc]):
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreSynchronousLoader _isDone]):
(-[WebCoreSynchronousLoader dealloc]):
(-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]):
(-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreSynchronousLoader connection:didReceiveResponse:]):
(-[WebCoreSynchronousLoader connection:didReceiveData:]):
(-[WebCoreSynchronousLoader connectionDidFinishLoading:]):
(-[WebCoreSynchronousLoader connection:didFailWithError:]):
(-[WebCoreSynchronousLoader _data]):
(-[WebCoreSynchronousLoader _response]):
(-[WebCoreSynchronousLoader _error]):
(+[WebCoreSynchronousLoader loadRequest:returningResponse:error:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 11 Jul 2007 18:21:09 +0000 (18:21 +0000)]
Reviewed by Geoff.
Create the lock file in a writable directory.
* http/conf/apache2-httpd.conf:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 11 Jul 2007 18:11:32 +0000 (18:11 +0000)]
Reviewed by Sam Weinig.
- fix <rdar://problem/
5315265> REGRESSION: Leopard launch time -
there are about 190 stats of icudt36b files during launch
* platform/TextEncodingRegistry.cpp: (WebCore::atomicCanonicalTextEncodingName):
Add a special case for the empty string so we don't load the extended text
encodings just so we can return 0 for that case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 11 Jul 2007 17:12:22 +0000 (17:12 +0000)]
Reviewed by Darin.
Remove a bunch of unneeded accessors from ResourceHandle.
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::didReceiveResponse):
(WebCore::IconLoader::didFail):
(WebCore::IconLoader::didFinishLoading):
* platform/network/ResourceHandle.cpp:
* platform/network/ResourceHandle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Wed, 11 Jul 2007 12:56:05 +0000 (12:56 +0000)]
Reviewed by Mark.
Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 11 Jul 2007 10:21:09 +0000 (10:21 +0000)]
LayoutTests:
Reviewed by Darin.
<rdar://problem/
5234383> REGRESSION: Sentence breaker method returning entire document length
* editing/selection/
5234383-1-expected.checksum: Added.
* editing/selection/
5234383-1-expected.png: Added.
* editing/selection/
5234383-1-expected.txt: Added.
* editing/selection/
5234383-1.html: Added.
* editing/selection/
5234383-2-expected.checksum: Added.
* editing/selection/
5234383-2-expected.png: Added.
* editing/selection/
5234383-2-expected.txt: Added.
* editing/selection/
5234383-2.html: Added.
WebCore:
Reviewed by Darin.
<rdar://problem/
5234383> REGRESSION: Sentence breaker method returning entire document length
The functions for moving the caret to the next/previous sentence boundary
were in many cases moving to the beginning/end of the document. The functions that
should move the caret to an equivalent position in the next/previous sentence behaved
like the aforementioned functions ought to. Put the code from the second two functions
in the first and made sure that the second two are properly FIXMEd. They're rarely
used (filed
5323691).
* editing/SelectionController.cpp:
(WebCore::SelectionController::modify): Added an option for sentenceBoundary granularity,
so that we can test the functions that were broken from JS.
* editing/visible_units.cpp:
(WebCore::startOfSentence): Removed the FIXME about
5234383.
(WebCore::endSentenceBoundary): Make this function do what nextSentencePositionBoundary
current does.
(WebCore::endOfSentence): Removed the FIXME about
5234383.
(WebCore::previousSentencePosition): Removed an incorrect FIXME.
(WebCore::nextSentencePositionBoundary): Tweaked FIXME. This function is
identical, not close to endSentenceBoundary.
(WebCore::nextSentencePosition): Removed an incorrect FIXME.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Wed, 11 Jul 2007 08:10:16 +0000 (08:10 +0000)]
Reviewed by John.
Fix <rdar://problem/
4570550>
Hang in layout/layoutBlock/layoutBlockChildren preparing to print certain Mail messages
When printing from Mail, WebHTMLView is a subview of the view that is actually printed and does not
receive calls that would set it to printing mode. Method adjustPageHeightNew is called repeatedly (for each page) during
printing and it enables printing mode temporarily for each call. This triggers two full style recalcs and layouts
each time making printing at least O(n^2).
Instead of enabling printing mode and resetting it back immediatly do the resetting asynchronously, after
all adjustPageHeightNew calls are done. Normal Safari printing is not affected as adjustPageHeightNew is only
called in case WebHTMLView is embedded in the view that is being printed.
No automatic test possible, requires printing and non-Safari client.
* WebView/WebHTMLView.mm:
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Wed, 11 Jul 2007 07:40:18 +0000 (07:40 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone
Be less strict for the hex color definition.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Wed, 11 Jul 2007 07:34:58 +0000 (07:34 +0000)]
Reviewed by Oliver.
Forgot to commit this as part of commit r24146. Now we are sure
createElement creates elements in the xhtml namespace only.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 11 Jul 2007 06:20:28 +0000 (06:20 +0000)]
Reviewed by Maciej Stachowiak.
- Fixed <rdar://problem/
5049509> REGRESSION(10.4.9-9A377a): REAP Suite
installer shows empty modal alert window (hangs) if user cancels during
"installing shared components" phase
Added Adobe installers to the family of apps that need a data load
loading quirk.
Added a linked-on-or-after check because this code is no longer
Tiger-only.
I tested this code on Tiger and Leopard.
* Misc/WebKitVersionChecks.h:
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebDocumentLoaderMac.mm:
(needsDataLoadWorkaround):
(WebDocumentLoaderMac::setDataSource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 11 Jul 2007 05:10:24 +0000 (05:10 +0000)]
LayoutTests:
Reviewed by Oliver.
* fast/dom/Window/get-set-properties-expected.txt: Added.
* fast/dom/Window/get-set-properties.html: Added.
WebCore:
Reviewed by Oliver.
Move more attributes from the pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings
Test: fast/dom/Window/get-set-properties.html
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::customGetOwnPropertySlot): Change to use propHashTable in
JSDOMWindow instead of KJS::Window
* bindings/js/kjs_window.cpp:
(KJS::Window::getValueProperty):
(KJS::Window::put):
* bindings/js/kjs_window.h:
(KJS::Window::):
* bindings/scripts/CodeGeneratorJS.pm: Cleanup getValueProperty and put generation
to reduce code duplication.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::closed):
(WebCore::DOMWindow::length):
(WebCore::DOMWindow::name):
(WebCore::DOMWindow::setName):
(WebCore::DOMWindow::status):
(WebCore::DOMWindow::setStatus):
(WebCore::DOMWindow::defaultStatus):
(WebCore::DOMWindow::setDefaultStatus):
* page/DOMWindow.h:
(WebCore::DOMWindow::defaultstatus):
(WebCore::DOMWindow::setDefaultstatus):
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 11 Jul 2007 03:46:42 +0000 (03:46 +0000)]
LayoutTests:
Reviewed by Geoff.
Tests for <rdar://problem/
5326791>
* http/tests/security/cross-frame-access-expected.txt:
* http/tests/security/cross-frame-access-put-expected.txt: Added.
* http/tests/security/cross-frame-access-put.html: Added.
* http/tests/security/resources/cross-frame-iframe-for-put-test.html: Added.
WebCore:
Reviewed by Geoff.
Fix for <rdar://problem/
5326791> XSS vulnerability: ability to set window.defaultStatus,
window.defaultstatus and window.status cross domains
Test: http/tests/security/cross-frame-access-put.html
* bindings/js/kjs_window.cpp:
(KJS::Window::put): Adds isSafeScript check for defaultStatus,
defaultstatus and status cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 11 Jul 2007 03:11:13 +0000 (03:11 +0000)]
* Scripts/run-webkit-tests: Add an ignore item for a leak in Tiger's
Foundation's multipart/mixed-replace support -- I already verified that
the bug has been fixed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 11 Jul 2007 02:13:05 +0000 (02:13 +0000)]
rubber stamped by Maciej.
fixed <rdar://
5137972> editing/selection/editable-links.html fails on Windows
* DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
(initializePreferences):
set editable link behavior to match Mac DRT.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 11 Jul 2007 01:42:17 +0000 (01:42 +0000)]
Fix build for BuildBot.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::outerHeight):
(WebCore::DOMWindow::outerWidth):
(WebCore::DOMWindow::screenX):
(WebCore::DOMWindow::screenY):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 11 Jul 2007 01:38:30 +0000 (01:38 +0000)]
Reviewed by Sam
<rdar://problem/
5326653> - REGRESSION: [WebBackForwardList forwardListCount] might return incorrect result
No layout test because this is an API issue that can't be tested in DRT or the browser
* history/BackForwardList.cpp:
(WebCore::BackForwardList::forwardListCount): If the index is NoCurrentItemIndex, return 0
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 11 Jul 2007 00:28:45 +0000 (00:28 +0000)]
Reviewed by Darin.
Move more readonly attributes from pure JS bindings in KJS::Window
to the implementation in DOMWindow and autogenerate the new bindings.
* bindings/js/kjs_window.cpp:
(KJS::Window::getValueProperty): Sort the hashmap comment into categories
to make further migration easier.
* bindings/js/kjs_window.h: Sort the enum into categories to make further
migration easier.
(KJS::Window::):
* page/DOMWindow.cpp: Add new methods.
(WebCore::DOMWindow::focus):
(WebCore::DOMWindow::blur):
(WebCore::DOMWindow::offscreenBuffering):
(WebCore::DOMWindow::outerHeight):
(WebCore::DOMWindow::outerWidth):
(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
(WebCore::DOMWindow::screenX):
(WebCore::DOMWindow::screenY):
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::getComputedStyle):
(WebCore::DOMWindow::getMatchedCSSRules): Add null Document assertion.
(WebCore::DOMWindow::devicePixelRatio): Add null Frame and Page checks.
* page/DOMWindow.h:
(WebCore::DOMWindow::screenLeft):
(WebCore::DOMWindow::screenTop):
(WebCore::DOMWindow::pageXOffset):
(WebCore::DOMWindow::pageYOffset):
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 11 Jul 2007 00:23:21 +0000 (00:23 +0000)]
Reviewed by Maciej.
Fix for <rdar://problem/
5326417> Editor::unmarkText needs to be crossplatform
Missed this in earlier patch to make text marking platform independent.
* editing/Editor.cpp:
(WebCore::Editor::unmarkText):
Add platform independent impl
* editing/mac/EditorMac.mm:
Remove the old mac path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 10 Jul 2007 23:52:42 +0000 (23:52 +0000)]
WebCore:
Reviewed by Tim Hatcher.
Added a Page counter. This helped me while investigating
<rdar://problem/
5314463> 40MB of WebKit memory still allocated after
closing large email in Mail
* WebCore.xcodeproj/project.pbxproj:
* page/Page.cpp:
(WebCore::):
(WebCore::PageCounter::~PageCounter):
(WebCore::Page::Page):
(WebCore::Page::~Page):
WebKitTools:
Reviewed by Tim Hatcher.
Ignore Page.o in debug builds because it now has a static PageCounter
object.
* Scripts/check-for-global-initializers:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 10 Jul 2007 23:44:17 +0000 (23:44 +0000)]
Reviewed by Geoff.
<rdar://problem/
5326126> InspectorResource holds onto more data than it needs
Reduces the fixed size of InspectorResource from 630 bytes to 224 bytes. Now
selectively pick out parts of the ResourceRequest and ResourceResponse objects
for the info needed and store that directly in InspectorResource.
The ResourceRequest and ResourceResponse objects hold a reference to the original
NSURL object, so almost double the data was being kept around. So the struct size
reduction is just the tip of the ice burg on what this really saves.
In a test of 100,000 XMLHTTPRequests using a 85 byte long data URL, I see ~21 MB less
RSIZE compared to Safari running without this change.
* page/InspectorController.cpp:
(WebCore::InspectorResource::InspectorResource):
(WebCore::InspectorResource::type):
(WebCore::addSourceToFrame):
(WebCore::scriptObjectForRequest):
(WebCore::scriptObjectForResponse):
(WebCore::InspectorController::addScriptResource):
(WebCore::InspectorController::addAndUpdateScriptResource):
(WebCore::updateResourceRequest):
(WebCore::updateResourceResponse):
(WebCore::InspectorController::updateScriptResourceRequest):
(WebCore::InspectorController::updateScriptResourceResponse):
(WebCore::InspectorController::didLoadResourceFromMemoryCache):
(WebCore::InspectorController::identifierForInitialRequest):
(WebCore::InspectorController::willSendRequest):
(WebCore::InspectorController::didReceiveResponse):
(WebCore::InspectorController::didFailLoading):
* page/InspectorController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 10 Jul 2007 22:37:44 +0000 (22:37 +0000)]
Reviewed by Brady.
- fix crash introduced by my patch for
5318732, only seen in release builds
* page/Page.cpp: (WebCore::Page::~Page): Added a missing null check.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Tue, 10 Jul 2007 22:30:42 +0000 (22:30 +0000)]
Patch from Andrea Cavalli to fix sunken state of text fields.
Bug #14576
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Tue, 10 Jul 2007 22:13:33 +0000 (22:13 +0000)]
Patch from Qing Zhao to draw focus rects on non-QStyle rendered nodes. Needs a
bit more work once we figure out how to use QPainterPathStroker in a more
sophisticated manner.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan [Tue, 10 Jul 2007 21:53:19 +0000 (21:53 +0000)]
2007-07-10 Ada Chan <adachan@apple.com>
Fixed build.
* WebView.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Tue, 10 Jul 2007 21:46:52 +0000 (21:46 +0000)]
Reviewed by Geoff.
Fix 'unsigned int' overflow in CodeGeneratorJS.pm.
This fixes hashing of "SVG_FEBLEND_MODE_NORMAL". Its hashvalue exceeded 2^32, which
is no problem in perl but in the cpp code. Emulate C/C++ behaviour by using "% 2^32" in
the perl code. Testcase available in feature-branch soon (js-svg-constructors.svg).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 10 Jul 2007 21:45:04 +0000 (21:45 +0000)]
Reviewed by Maciej Stachowiak.
Disabled Arena recycling in RenderArena. PLT shows no regression
(possibly a small speedup), and this can reduce allocated memory in
WebKit clients by about 120K (4K per Arena * 30 Arenas).
I happened upon this optimization while investigating
<rdar://problem/
5314463> WebKit hangs on to 40MB RAM after closing
large email in Mail (appears to be render tree arena allocator),
although I don't think it will come close to fixing that bug
completely.
* rendering/RenderArena.cpp:
(WebCore::RenderArena::~RenderArena): Use FinishArenaPool, which frees
the ArenaPool's Arenas immediately.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 10 Jul 2007 21:37:07 +0000 (21:37 +0000)]
LayoutTests:
Reviewed by Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=14449
REGRESSION (r14345-r14375): Absolutely positioned image does not scale to containing element's height
* fast/replaced/absolute-position-percentage-height-expected.checksum: Added.
* fast/replaced/absolute-position-percentage-height-expected.png: Added.
* fast/replaced/absolute-position-percentage-height-expected.txt: Added.
* fast/replaced/absolute-position-percentage-height.html: Added.
WebCore:
Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=14449
REGRESSION (r14345-r14375): Absolutely positioned image does not scale to containing element's height
Test: fast/replaced/absolute-position-percentage-height.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcReplacedHeightUsing): For positioned elements, evaluate
the percentage with respect to the container's final height.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 10 Jul 2007 20:21:03 +0000 (20:21 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 10 Jul 2007 20:13:26 +0000 (20:13 +0000)]
Correctness fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 10 Jul 2007 20:03:18 +0000 (20:03 +0000)]
- fix build
* WebView/WebHTMLView.mm: Add include of ContextMenu.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 10 Jul 2007 19:54:32 +0000 (19:54 +0000)]
Reviewed by Mark Rowe
Add 64-bit integer converters to our string classes for future work
* platform/DeprecatedString.cpp:
(WebCore::DeprecatedString::toInt64):
(WebCore::DeprecatedString::toUInt64):
* platform/DeprecatedString.h:
* platform/PlatformString.h:
* platform/String.cpp:
(WebCore::String::toInt64):
(WebCore::String::toUInt64):
* platform/StringImpl.cpp:
(WebCore::StringImpl::toInt64):
(WebCore::StringImpl::toUInt64):
* platform/StringImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Tue, 10 Jul 2007 19:45:38 +0000 (19:45 +0000)]
* win/Skipped:
removing tests that were blocked on lack of support for smart pasting and DOM Paste API
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 10 Jul 2007 19:21:23 +0000 (19:21 +0000)]
Reviewed by Anders.
- fix <rdar://problem/
5318732> REGRESSION: In Mail, a crash occurs when attempting to send
a HTML based message (nytimes.com, washingtonpost.com, latimes.com)
Did an audit of calls to get the inspector and most other uses of Page* and added null
checks since Frame* can outlast its Page*.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::createWindow): Added null check.
(WebCore::FrameLoader::loadSubframe): Ditto.
(WebCore::FrameLoader::load): Ditto.
(WebCore::FrameLoader::transitionToCommitted): Ditto.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Ditto.
(WebCore::FrameLoader::addExtraFieldsToRequest): Ditto.
(WebCore::FrameLoader::loadResourceSynchronously): Ditto.
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto.
(WebCore::FrameLoader::requestFromDelegate): Ditto.
(WebCore::FrameLoader::canGoBackOrForward): Ditto.
(WebCore::FrameLoader::getHistoryLength): Ditto.
(WebCore::FrameLoader::historyURL): Ditto.
(WebCore::FrameLoader::cachePageForHistoryItem): Ditto.
(WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Ditto.
(WebCore::FrameLoader::goToItem): Ditto.
(WebCore::FrameLoader::dispatchWindowObjectAvailable): Ditto.
(WebCore::FrameLoader::dispatchDidCommitLoad): Ditto.
(WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto.
(WebCore::FrameLoader::dispatchWillSendRequest): Ditto.
(WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto.
(WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto.
(WebCore::FrameLoader::dispatchDidFinishLoading): Ditto.
(WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.
* page/ContextMenuController.h:
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::ContextMenuController): Removed unneeded and
unused Page* parameter.
(WebCore::openNewWindow): Added null check.
(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
* page/InspectorController.h:
(WebCore::InspectorController::pageDestroyed): Added. Since this object is
owned by the Page and has a back-pointer to it, it needs an explicit disconnect.
There's already a higher-level one, but this is more reliable than that.
* page/InspectorController.cpp:
(WebCore::InspectorController::windowScriptObjectAvailable): Added null check.
(WebCore::InspectorController::windowUnloading): Ditto.
* page/Page.cpp:
(WebCore::Page::Page): Updated for change in parameters of ContextMenuController
constructor.
(WebCore::Page::~Page): Added call to InspectorController pageDestroyed().
* page/Chrome.cpp: Updated includes.
* page/DragController.cpp: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 10 Jul 2007 18:47:49 +0000 (18:47 +0000)]
Reviewed by John Sullivan.
- <rdar://problem/
5321953> remove workaround for fixed AppKit mouse moved bug
* WebView/WebHTMLView.mm: Put the workaround for bug
3429631 inside an
ifdef BUILDING_ON_TIGER.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Tue, 10 Jul 2007 16:39:54 +0000 (16:39 +0000)]
Patch from Adam Treat to make the scroll wheel behave sanely
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 10 Jul 2007 16:25:40 +0000 (16:25 +0000)]
LayoutTests:
Reviewed by Maciej Stachowiak.
* fast/events/onload-after-document-close-no-subresource-expected.txt: Added.
* fast/events/onload-after-document-close-no-subresource.html: Added.
* fast/events/onload-after-document-close-with-subresource-expected.txt: Added.
* fast/events/onload-after-document-close-with-subresource.html: Added.
* fast/events/resources/onload-image.png: Added.
WebCore:
Reviewed by Maciej Stachowiak.
Fixed http://bugs.webkit.org/show_bug.cgi?id=13241 | <rdar://problem/
5126396>
onload fires before content is finished loading (woot.com)
* dom/Document.cpp:
(WebCore::Document::close): Try to go through the normal "Am I done loading?"
machinery before dispatching the load event. As the comment indicates,
we can't do this in all cases, so the fix isn't perfect. However, a perfect
solution would require much riskier sweeping changes to the loader, which
are best left for later, I think.
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource): Removed a slightly
worse solution to the same problem.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 10 Jul 2007 10:25:57 +0000 (10:25 +0000)]
2007-07-10 Mark Rowe <mrowe@apple.com>
Qt build fix after r24126.
* Api/qwebframe.cpp:
(QWebFrame::evaluateJavaScript):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24147
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Tue, 10 Jul 2007 09:21:47 +0000 (09:21 +0000)]
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=8007
createElement() and XHTML (A dynamically created table not rendered as such)
Follow the HTML5 rules of making the name lowercase and then
creating the element in the xhtml namespace.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Tue, 10 Jul 2007 01:43:21 +0000 (01:43 +0000)]
Patch from Qing Zhao to add context menu support for Qt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 9 Jul 2007 23:38:57 +0000 (23:38 +0000)]
* Scripts/run-webkit-tests: Moved leaks from Tiger that are marked as fixed in Leopard to a Tiger-only section.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Mon, 9 Jul 2007 23:23:22 +0000 (23:23 +0000)]
LayoutTests:
* win/Skipped:
removed one test from skipped list to see whether it will pass with the new
DOM Paste API change that is being added simultaneously.
WebKitTools:
Reviewed by Adam Roben.
setting DOM Paste Allowed Pref
* DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
(initializePreferences):
win:
Reviewed by Adam Roben.
Adding DOM Paste Allowed preference, setters and getters
for the purpose of layout tests.
* Interfaces/IWebPreferences.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::isDOMPasteAllowed):
(WebPreferences::setDOMPasteAllowed):
* WebPreferences.h:
* WebView.cpp:
(WebView::updateWebCoreSettingsFromPreferences):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 9 Jul 2007 23:19:16 +0000 (23:19 +0000)]
Build fix.
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 9 Jul 2007 23:18:14 +0000 (23:18 +0000)]
Build fix.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::performRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 9 Jul 2007 22:10:15 +0000 (22:10 +0000)]
Reviewed by Geoff.
Get rid of the node argument in our various script execution functions.
* bindings/js/kjs_proxy.cpp:
(WebCore::KJSProxy::evaluate):
* bindings/js/kjs_proxy.h:
* bindings/js/kjs_window.cpp:
(KJS::ScheduledAction::execute):
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::endElementNs):
(WebCore::XMLTokenizer::notifyFinished):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::evaluateScript):
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::scriptExecution):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::replaceContentsWithScriptResult):
(WebCore::FrameLoader::executeScript):
* loader/FrameLoader.h:
* page/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Mon, 9 Jul 2007 22:06:54 +0000 (22:06 +0000)]
Reviewed by Adam, Sam, and Ada.
- Inital checkin of Drosera for Win. This isn't pretty and doesn't connect to Safari but debug builds and runs.
* Drosera/Images/Drosera.ico: Added.
* Drosera/Images/small.ico: Added.
* Drosera/win: Added.
* Drosera/win/BaseDelegate.h: Added.
(BaseDelegate::QueryInterface):
(BaseDelegate::didFinishLoadForFrame):
(BaseDelegate::windowScriptObjectAvailable):
(BaseDelegate::didStartProvisionalLoadForFrame):
(BaseDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
(BaseDelegate::didFailProvisionalLoadWithError):
(BaseDelegate::didCommitLoadForFrame):
(BaseDelegate::didReceiveTitle):
(BaseDelegate::didReceiveIcon):
(BaseDelegate::didFailLoadWithError):
(BaseDelegate::didChangeLocationWithinPageForFrame):
(BaseDelegate::willPerformClientRedirectToURL):
(BaseDelegate::didCancelClientRedirectForFrame):
(BaseDelegate::willCloseFrame):
(BaseDelegate::createWebViewWithRequest):
(BaseDelegate::webViewShow):
(BaseDelegate::webViewClose):
(BaseDelegate::webViewFocus):
(BaseDelegate::webViewUnfocus):
(BaseDelegate::webViewFirstResponder):
(BaseDelegate::makeFirstResponder):
(BaseDelegate::setStatusText):
(BaseDelegate::webViewStatusText):
(BaseDelegate::webViewAreToolbarsVisible):
(BaseDelegate::setToolbarsVisible):
(BaseDelegate::webViewIsStatusBarVisible):
(BaseDelegate::setStatusBarVisible):
(BaseDelegate::webViewIsResizable):
(BaseDelegate::setResizable):
(BaseDelegate::setFrame):
(BaseDelegate::webViewFrame):
(BaseDelegate::setContentRect):
(BaseDelegate::webViewContentRect):
(BaseDelegate::runJavaScriptAlertPanelWithMessage):
(BaseDelegate::runJavaScriptConfirmPanelWithMessage):
(BaseDelegate::runJavaScriptTextInputPanelWithPrompt):
(BaseDelegate::runBeforeUnloadConfirmPanelWithMessage):
(BaseDelegate::runOpenPanelForFileButtonWithResultListener):
(BaseDelegate::mouseDidMoveOverElement):
(BaseDelegate::contextMenuItemsForElement):
(BaseDelegate::validateUserInterfaceItem):
(BaseDelegate::shouldPerformAction):
(BaseDelegate::dragDestinationActionMaskForDraggingInfo):
(BaseDelegate::willPerformDragDestinationAction):
(BaseDelegate::dragSourceActionMaskForPoint):
(BaseDelegate::willPerformDragSourceAction):
(BaseDelegate::contextMenuItemSelected):
(BaseDelegate::hasCustomMenuImplementation):
(BaseDelegate::trackCustomPopupMenu):
(BaseDelegate::measureCustomMenuItem):
(BaseDelegate::drawCustomMenuItem):
(BaseDelegate::addCustomMenuDrawingData):
(BaseDelegate::cleanUpCustomMenuDrawingData):
(BaseDelegate::canTakeFocus):
(BaseDelegate::takeFocus):
(BaseDelegate::registerUndoWithTarget):
(BaseDelegate::removeAllActionsWithTarget):
(BaseDelegate::setActionTitle):
(BaseDelegate::undo):
(BaseDelegate::redo):
(BaseDelegate::canUndo):
(BaseDelegate::canRedo):
* Drosera/win/DebuggerApplication.cpp: Added.
(DebuggerApplication::serverLoaded):
(DebuggerApplication::serverUnloaded):
(DebuggerApplication::attach):
(DebuggerApplication::numberOfRowsInTableView):
(DebuggerApplication::tableView):
* Drosera/win/DebuggerApplication.h: Added.
(DebuggerApplication::DebuggerApplication):
(DebuggerApplication::knownServers):
* Drosera/win/DebuggerObjectCallbacks.cpp: Added.
(breakpointEditorHTMLCallback):
(currentFunctionStackCallback):
(doubleClickMillisecondsCallback):
(evaluateScript_inCallFrame_Callback):
(isPausedCallback):
(localScopeVariableNamesForCallFrame_Callback):
(pauseCallback):
(resumeCallback):
(stepIntoCallback):
(valueForScopeVariableNamed_inCallFrame_Callback):
(staticFunctions):
* Drosera/win/DebuggerObjectCallbacks.h: Added.
* Drosera/win/Drosera.cpp: Added.
(_tWinMain):
(RegisterDroseraClass):
(DroseraWndProc):
(About):
(Attach):
(Drosera::Drosera):
(Drosera::initUI):
(Drosera::QueryInterface):
(Drosera::AddRef):
(Drosera::Release):
(Drosera::didFinishLoadForFrame):
(getDroseraJSClass):
(Drosera::windowScriptObjectAvailable):
(Drosera::webViewClose):
(Drosera::validateUserInterfaceItem):
(Drosera::runJavaScriptAlertPanelWithMessage):
(Drosera::onSize):
* Drosera/win/Drosera.h: Added.
(Drosera::webViewLoaded):
* Drosera/win/Drosera.vcproj: Added.
* Drosera/win/Drosera.vcproj/Drosera.rc: Added.
* Drosera/win/Drosera.vcproj/Drosera.vcproj: Added.
* Drosera/win/Drosera.vcproj/debug.vsprops: Added.
* Drosera/win/Drosera.vcproj/release.vsprops: Added.
* Drosera/win/HelperFunctions.h: Added.
(CFStringToBSTR):
* Drosera/win/Info.plist: Added.
* Drosera/win/resource.h: Added.
* Drosera/win/stdafx.cpp: Added.
* Drosera/win/stdafx.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Mon, 9 Jul 2007 21:25:12 +0000 (21:25 +0000)]
Patch from Eli Fidler to properly decode data: urls.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Mon, 9 Jul 2007 21:23:28 +0000 (21:23 +0000)]
LayoutTests:
Rolling the fix for
5310404 back in now that
5310404 has been fixed in Mail.
* editing/deleting/
4845371-expected.checksum:
* editing/deleting/
4845371-expected.txt:
* editing/deleting/
4845371.html:
* editing/deleting/
5126166-expected.txt:
* editing/deleting/
5290534.html: Added.
* editing/deleting/
5290534.html-disabled: Removed.
WebCore:
Rolling the fix for
5290534 back in now that
5310404 has been fixed in Mail.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 9 Jul 2007 21:08:10 +0000 (21:08 +0000)]
Reviewed by Anders Carlsson.
A little more FrameLoader cleanup while working on <rdar://problem/
5126396>.
Rename: "checkEmitLoadEvent" => "checkCallImplicitClose" because the function
doesn't emit the load event; it just calls implicitClose.
Rename: "m_wasLoadEventEmitted" => "m_didCallImplicitClose" because the variable
tracks whether implicitClose was called.
* dom/Document.cpp:
(WebCore::Document::implicitClose): Turned 12 lines of code into 6, adding ASSERT.
* loader/FrameLoader.h: Removed bogus declaration of non-existent emitLoadEvent().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Mon, 9 Jul 2007 20:27:05 +0000 (20:27 +0000)]
LayoutTests:
Reviewed by John.
<rdar://problem/
5156801> REGRESSION: Crash when deleting table content in Leopard Mail
* editing/deleting/
5156801-expected.checksum: Added.
* editing/deleting/
5156801-expected.png: Added.
* editing/deleting/
5156801-expected.txt: Added.
* editing/deleting/
5156801.html: Added.
WebCore:
Reviewed by John.
REGRESSION: Crash when deleting table content in Leopard Mail
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr
for the next node to delete, in case it is destroyed when the
current node is deleted. In the crash reported in the radar, we
crash because the next node is the div that holds the delete button
and it's destroyed when the node that contains the selection is removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc