WebKit-https.git
13 years ago <rdar://problem/5667017> storage/execute-sql-args.html failing -- openDatabas...
ap@webkit.org [Mon, 28 Jan 2008 20:04:08 +0000 (20:04 +0000)]
    <rdar://problem/5667017> storage/execute-sql-args.html failing -- openDatabase returning null on buildbot

        * platform/win/Skipped: Removed a passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Mon, 28 Jan 2008 17:40:34 +0000 (17:40 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16774
          REGRESSION (r27464-r27504) javascript popup menu does not display 'close' button

        Test: fast/dynamic/float-no-longer-overhanging.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addOverhangingFloats): If a child's float turns
        out not to be overhanging at this time, ensure that the child paints it.

LayoutTests:

        Reviewed by Darin Adler.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=16774
          REGRESSION (r27464-r27504) javascript popup menu does not display 'close' button

        * fast/dynamic/float-no-longer-overhanging.html: Added.
        * platform/mac/fast/dynamic/float-no-longer-overhanging-expected.checksum: Added.
        * platform/mac/fast/dynamic/float-no-longer-overhanging-expected.png: Added.
        * platform/mac/fast/dynamic/float-no-longer-overhanging-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMore wx fixes
oliver@apple.com [Mon, 28 Jan 2008 11:19:25 +0000 (11:19 +0000)]
More wx fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnd another Wx build fix
oliver@apple.com [Mon, 28 Jan 2008 10:43:48 +0000 (10:43 +0000)]
And another Wx build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDue to a difference between the collision bounds for paths
oliver@apple.com [Mon, 28 Jan 2008 10:34:56 +0000 (10:34 +0000)]
Due to a difference between the collision bounds for paths
in different versions of CG these tests need modiifed to
pass on tiger and leopard.

RS=Mark

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoYet another Wx build fix
oliver@apple.com [Mon, 28 Jan 2008 09:23:24 +0000 (09:23 +0000)]
Yet another Wx build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWx build fix
oliver@apple.com [Mon, 28 Jan 2008 08:31:16 +0000 (08:31 +0000)]
Wx build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoGtk build fix
oliver@apple.com [Mon, 28 Jan 2008 08:18:43 +0000 (08:18 +0000)]
Gtk build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 16629: <canvas> does not support isPointInPath()
oliver@apple.com [Mon, 28 Jan 2008 07:04:56 +0000 (07:04 +0000)]
Bug 16629: <canvas> does not support isPointInPath()

Reviewed by Sam Weinig.

Relatively trivial change to implement pointInPath and add
it to the bindings.  Most of this patch is the addition of
GraphicsContext::getCTM() by pulling the various platform
implementations from CanvasRenderingContext2D::willDraw

Test: fast/canvas/pointInPath.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Mon, 28 Jan 2008 05:02:28 +0000 (05:02 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=17014
        REGRESSION: EUC-CN code A3A0 is mapped to U+E5E5 instead of U+3000

        Test: fast/encoding/char-decoding.html

        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::decode): Added a workaround that we used to have in Mac code.

        * platform/text/mac/TextCodecMac.cpp:
        (WebCore::TextCodecMac::decode): Corrected a comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
weinig@apple.com [Mon, 28 Jan 2008 00:14:24 +0000 (00:14 +0000)]
    Reviewed by Oliver Hunt.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=17025
        nodes.h/cpp has been rolling around in the mud - lets hose it down

        - Rename member variables to use the m_ prefix.

        (NOTE: Specific changed functions elided for space and clarity)
        * kjs/grammar.y:
        * kjs/nodes.cpp:
        * kjs/nodes.h:
        * kjs/nodes2string.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-27 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 28 Jan 2008 00:04:31 +0000 (00:04 +0000)]
2008-01-27  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        http://bugs.webkit.org/show_bug.cgi?id=17029
        Use of deprecated class function but declares GTK_DISABLE_DEPRECATED

        Sync gtkdrawing.h (1.51) and gtk2drawing.c (1.71) from Mozilla
        upstream.

        Adapt RenderThemeGtk.cpp to track minor changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-27 Jan Michael Alonzo <jmalonzo@unpluggable.com>
alp@webkit.org [Sun, 27 Jan 2008 23:24:17 +0000 (23:24 +0000)]
2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        GTK+ DRT build fix for breakage introduced in r29822.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setPersistentUserStyleSheetLocation):
        (LayoutTestController::clearPersistentUserStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
mitz@apple.com [Sun, 27 Jan 2008 20:00:29 +0000 (20:00 +0000)]
WebKitTools:

        Reviewed by Darin Adler.

        - add support for directory prologues and epilogues to run-webkit-tests
        - allow setting a persistent user style sheet in DumpRenderTree
        - activate the WebKit Layout Tests font in Windows DumpRenderTree

        * DumpRenderTree/LayoutTestController.cpp:
        (clearPersistentUserStyleSheetCallback): Added.
        (setPersistentUserStyleSheetLocationCallback): Added.
        (LayoutTestController::staticFunctions): Added.
        clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (setPersistentUserStyleSheetLocation): Added.
        (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
        to the set of things this function resets. Now it either disables the
        user style sheet or sets it to the persistent user style sheet and
        enables it.
        * DumpRenderTree/mac/DumpRenderTreeMac.h:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
        (LayoutTestController::clearPersistentUserStyleSheet): Added.
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (setPersistentUserStyleSheetLocation): Added.
        (initialize): Added the WebKit Layout Tests font to the set of fonts to
        install.
        (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
        * DumpRenderTree/win/DumpRenderTreeWin.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
        (LayoutTestController::clearPersistentUserStyleSheet): Added.
        * Scripts/run-webkit-tests: Changed to look for, and if found process in
        DumpRenderTree, files named run-webkit-tests-prologue.html and
        run-webkit-tests-epilogue.html in the resources subdirectory of any
        test directory and platform test results directory. The prologues are
        processed before the first test from the directory (and its
        subdirectories) is run, and the epilogues are processed after the last
        test from the directory is run. Platform-specific prologues and
        epilogues are processed in order of specificity.

LayoutTests:

        Reviewed by Darin Adler.

        - make some CSS2.1 tests pass on Windows by using @font-face to force
          font fallback to match Mac OS X.

        * platform/win/Skipped:
        * platform/win/css2.1: Added.
        * platform/win/css2.1/resources: Added.
        * platform/win/css2.1/resources/Mac-compatible-font-fallback.css: Added.
        * platform/win/css2.1/resources/run-webkit-tests-epilogue.html: Added.
        * platform/win/css2.1/resources/run-webkit-tests-prologue.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-27 Jan Michael Alonzo <jmalonzo@unpluggable.com>
alp@webkit.org [Sun, 27 Jan 2008 19:49:01 +0000 (19:49 +0000)]
2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=14811
        [gtk] [request] add a webkit_gtk_page_go_to_history_item function

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * http/tests/security/cross-frame-access-put-expected.txt: Updated again.
darin@apple.com [Sun, 27 Jan 2008 10:17:21 +0000 (10:17 +0000)]
    * http/tests/security/cross-frame-access-put-expected.txt: Updated again.
        Not sure why, but I generated a different result the first time I tried.
        I suspect this test gives different results depending on what other tests
        are run with it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - updated some test results I missed that were affected by my fix for bug...
darin@apple.com [Sun, 27 Jan 2008 09:55:09 +0000 (09:55 +0000)]
    - updated some test results I missed that were affected by my fix for bug 16498

        * fast/dom/xmlhttprequest-get-expected.txt:
        * http/tests/security/cross-frame-access-put-expected.txt:
        * plugins/inner-html-display-none-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Sun, 27 Jan 2008 09:38:01 +0000 (09:38 +0000)]
JavaScriptCore:

        Reviewed by Oliver.

        - fix <rdar://problem/5657450> REGRESSION: const is broken

        Test: fast/js/const.html

        SunSpider said this was 0.3% slower. And I saw some Shark samples in
        JSGlobalObject::put -- not a lot but a few. We may be able to regain the
        speed, but for now we will take that small hit for correctness sake.

        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::put): Pass the checkReadOnly flag in to symbolTablePut
        instead of passing attributes.

        * kjs/JSVariableObject.h:
        (KJS::JSVariableObject::symbolTablePut): Removed the code to set attributes
        here, since we only set attributes when creating a property. Added the code
        to check read-only here, since we need that to implement const!

        * kjs/function.cpp:
        (KJS::ActivationImp::put): Pass the checkReadOnly flag in to symbolTablePut
        instead of passing attributes.

        * kjs/nodes.cpp:
        (KJS::isConstant): Added.
        (KJS::PostIncResolveNode::optimizeVariableAccess): Create a PostIncConstNode
        if optimizing for a local variable and the variable is constant.
        (KJS::PostDecResolveNode::optimizeVariableAccess): Ditto. But PostDecConstNode.
        (KJS::PreIncResolveNode::optimizeVariableAccess): Ditto. But PreIncConstNode.
        (KJS::PreDecResolveNode::optimizeVariableAccess): Ditto. But PreDecConstNode.
        (KJS::PreIncConstNode::evaluate): Return the value + 1.
        (KJS::PreDecConstNode::evaluate): Return the value - 1.
        (KJS::PostIncConstNode::evaluate): Return the value converted to a number.
        (KJS::PostDecConstNode::evaluate): Ditto.
        (KJS::ReadModifyResolveNode::optimizeVariableAccess): Create a ReadModifyConstNode
        if optimizing for a local variable and the variable is constant.
        (KJS::AssignResolveNode::optimizeVariableAccess): Ditto. But AssignConstNode.
        (KJS::ScopeNode::optimizeVariableAccess): Pass the local storage to the
        node optimizeVariableAccess functions, since that's where we need to look to
        figure out if a variable is constant.
        (KJS::FunctionBodyNode::processDeclarations): Moved the call to
        optimizeVariableAccess until after localStorage is set up.
        (KJS::ProgramNode::processDeclarations): Ditto.

        * kjs/nodes.h: Fixed the IsConstant and HasInitializer values. They are used
        as flag masks, so a value of 0 will not work for IsConstant. Changed the
        first parameter to optimizeVariableAccess to be a const reference to a symbol
        table and added a const reference to local storage. Added classes for const
        versions of local variable access: PostIncConstNode, PostDecConstNode,
        PreIncConstNode, PreDecConstNode, ReadModifyConstNode, and AssignConstNode.

        * kjs/object.cpp:
        (KJS::JSObject::put): Tweaked comments a bit, and changed the checkReadOnly
        expression to match the form used at the two other call sites.

LayoutTests:

        Reviewed by Oliver.

        - tests for <rdar://problem/5657450> REGRESSION: const is broken

        * fast/js/const-expected.txt: Updated with results that express success
        rather than failure, and to include the many new tests I added.
        * fast/js/kde/const-expected.txt: Ditto.
        * fast/js/resources/const.js: Added many new tests, covering the various
        cases of const in globals, function locals, the slow case inside eval,
        the different node types, and the values of the expressions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Sun, 27 Jan 2008 08:54:25 +0000 (08:54 +0000)]
JavaScriptCore:

        Reviewed by Oliver.

        - fix http://bugs.webkit.org/show_bug.cgi?id=16498
          ''.constructor.toString() gives [function]

        Test: fast/js/function-names.html

        * kjs/array_object.cpp:
        (KJS::ArrayObjectImp::ArrayObjectImp): Use the class name as the constructor's function name.
        * kjs/bool_object.cpp:
        (KJS::BooleanObjectImp::BooleanObjectImp): Ditto.
        * kjs/date_object.cpp:
        (KJS::DateObjectImp::DateObjectImp): Ditto.
        * kjs/error_object.cpp:
        (KJS::ErrorPrototype::ErrorPrototype): Make the error object be an Error.
        (KJS::ErrorObjectImp::ErrorObjectImp): Use the class name as the constructor's function name.
        (KJS::NativeErrorPrototype::NativeErrorPrototype): Take const UString&.
        (KJS::NativeErrorImp::NativeErrorImp): Use the prototype's name as the constructor's function
        name.
        * kjs/error_object.h: Change ErrorPrototype to inherit from ErrorInstance. Change the
        NativeErrorImp constructor to take a NativeErrorPrototype pointer for its prototype.
        * kjs/function.h: Removed unneeded constructor for internal functions without names.
        We want to avoid those!
        * kjs/function_object.cpp:
        (KJS::functionProtoFuncToString): Removed code that writes out just [function] for functions
        that have no names. There's no reason to do that.
        (KJS::FunctionObjectImp::FunctionObjectImp): Use the class name as the constructor's
        function name.
        * kjs/internal.cpp: Removed the unused constructor.
        * kjs/number_object.cpp:
        (KJS::fractionalPartToString): Marked static for internal linkage.
        (KJS::exponentialPartToString): Ditto.
        (KJS::numberProtoFuncToPrecision): Removed an unneeded else.
        (KJS::NumberObjectImp::NumberObjectImp): Use the class name as the constructor's
        function name.
        (KJS::NumberObjectImp::getValueProperty): Tweaked formatting.
        * kjs/object_object.cpp:
        (KJS::ObjectObjectImp::ObjectObjectImp): Use "Object" for the function name.
        * kjs/regexp_object.cpp:
        (KJS::RegExpObjectImp::RegExpObjectImp): Use "RegExp" for the function name.
        * kjs/string_object.cpp:
        (KJS::StringObjectImp::StringObjectImp): Use the class name as the constructor's
        function name.

LayoutTests:

        Reviewed by Oliver.

        - test for http://bugs.webkit.org/show_bug.cgi?id=16498
          ''.constructor.toString() gives [function]

        * fast/js/function-names-expected.txt: Updated for new tests.
        * fast/js/kde/resources/function.js: Updated test to expect the format that Gecko uses
        for native code, which we now match character for character.
        * fast/js/resources/function-names.js: Added tests for the names of all the constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Sun, 27 Jan 2008 08:48:16 +0000 (08:48 +0000)]
WebCore:

        Reviewed and tweaked quite a bit by Darin.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=14959
        No back forward entry added for pages created in javascript

        A new HistoryItem is created for calls to Document::open. Calls to
        Document::write save the written data to a SharedBuffer that is also
        stored on the HistoryItem. When the user navigates back to a
        HistoryItem that has a valid buffer, that data is used for the page
        content.

        Tests: http/tests/navigation/document-open-adds-history-item.html
               http/tests/navigation/document-open-delayed-adds-history-item.html
               http/tests/navigation/document-open-new-window-adds-history-item.html
               http/tests/navigation/document-open-replace-no-history-item.html

        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::open): Pass a MIME type of either "text/html" or
        "text/plain" and a boolean for "replace" in rather than always setting replace
        to true and the MIME type to "text/html".

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createHTMLDocument): Pass in MIME type and
        replace boolean explicitly, since we don't want to rely on Document::open()'s
        default.

        * dom/Document.cpp:
        (WebCore::Document::open): Correctly determine the "replace" boolean.
        Pass along the MIME type, replace boolean, and shared buffer to the
        frame loader's didExplicitOpen function.
        (WebCore::Document::write): Pass MIME type and replace boolean explicitly
        to the open function so we don't do treat it as replace if you write without
        an open. Store text written by the script so it can be used later for history.
        (WebCore::Document::clear): Drop the text written byt he script.

        * dom/Document.h: Added MIME type and replace boolean parameters for open.
        Had to keep the old version for the sake of DOM bindings. Added the shared
        buffer used for text written by script.

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem): Copy m_substituteData.
        (WebCore::HistoryItem::substituteData): Added.
        (WebCore::HistoryItem::setSubstituteData): Added.
        * history/HistoryItem.h: Added m_substituteData, getter, and setter.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::didExplicitOpen): Added code to create or update the
        history item, including attaching the shared buffer that will contain all
        the data written by script.
        (WebCore::FrameLoader::load): Added a SubstituteData parameter, passed through
        when creating the document loader.
        (WebCore::FrameLoader::reloadAllowingStaleData): Create the document loader
        with the substitute data from the current history item.
        (WebCore::FrameLoader::reload): Ditto.
        (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): If the current history
        item has substitute data, then consider the URL from the substitute data
        rather than the one in the history item itself.
        (WebCore::FrameLoader::loadItem): Pass in the history item's substitute data.
        * loader/FrameLoader.h: Added parameters to load and didExplicitOpen.

        * platform/text/CharacterNames.h: Added byteOrderMark, and also added it under
        its other official name, zeroWidthNoBreakSpace.

        * xml/DOMParser.cpp:
        (WebCore::DOMParser::parseFromString): Pass in MIME type and replace boolean
        explicitly, since we don't want to rely on Document::open()'s default.
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::getResponseXML): Ditto.
        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource): Ditto.

LayoutTests:

        Reviewed by Darin.

        Test cases for fix to http://bugs.webkit.org/show_bug.cgi?id=14959
        No back forward entry added for pages created in javascript.

        * http/tests/navigation/document-open-adds-history-item-expected.txt: Added.
        * http/tests/navigation/document-open-adds-history-item.html: Added.
        * http/tests/navigation/document-open-delayed-adds-history-item-expected.txt: Added.
        * http/tests/navigation/document-open-delayed-adds-history-item.html: Added.
        * http/tests/navigation/document-open-new-window-adds-history-item-expected.txt: Added.
        * http/tests/navigation/document-open-new-window-adds-history-item.html: Added.
        * http/tests/navigation/document-open-replace-no-history-item-expected.txt: Added.
        * http/tests/navigation/document-open-replace-no-history-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Sun, 27 Jan 2008 04:21:43 +0000 (04:21 +0000)]
JavaScriptCore:

        Reviewed by Oliver.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17027
          Incorrect Function.toString behaviour with read/modify/write operators performed on negative numbers

        Test: fast/js/function-toString-parentheses.html

        The problem here was that a NumberNode with a negative number in it had the wrong
        precedence. It's not a primary expression, it's a unary operator with a primary
        expression after it.

        Once the precedence of NumberNode was fixed, the cases from bug 17020 were also
        fixed without trying to treat bracket nodes like dot nodes. That wasn't needed.
        The reason we handle numbers before dot nodes specially is that the dot is a
        legal character in a number. The same is not true of a bracket. Eventually we
        could get smarter, and only add the parentheses when there is actual ambiguity.
        There is none if the string form of the number already has a dot in it, or if
        it's a number with a alphabetic name like infinity or NAN.

        * kjs/nodes.h: Renamed back from ObjectAccess to DotExpr.
        (KJS::NumberNode::precedence): Return PrecUnary for negative numbers, since
        they serialize as a unary operator, not a primary expression.
        * kjs/nodes2string.cpp:
        (KJS::SourceStream::operator<<): Clear m_numberNeedsParens if this adds
        parens; one set is enough.
        (KJS::bracketNodeStreamTo): Remove unneeded special flag here. Normal
        operator precedence suffices.
        (KJS::NewExprNode::streamTo): Ditto.

LayoutTests:

        Reviewed by Oliver.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17027
          Incorrect Function.toString behaviour with read/modify/write operators performed on negative numbers

        * fast/js/function-toString-parentheses-expected.txt: Updated.
        * fast/js/resources/function-toString-parentheses.js: More test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix leaks seen after loading <http://www.funnyordie.com/videos/d70b5a11cb>.
mrowe@apple.com [Sun, 27 Jan 2008 04:10:18 +0000 (04:10 +0000)]
Fix leaks seen after loading <funnyordie.com/videos/d70b5a11cb>.

Reviewed by Darin Adler.

* Misc/WebNSDataExtras.m:
(-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
to the new CFString so that they will be freed when no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix for http://bugs.webkit.org/show_bug.cgi?id=17020
oliver@apple.com [Sun, 27 Jan 2008 02:16:11 +0000 (02:16 +0000)]
Fix for bugs.webkit.org/show_bug.cgi?id=17020
Function.toString does not parenthesise numbers for the bracket accessor

Reviewed by Maciej and Darin.

It turns out that logic was there for all of the dot accessor nodes to make numbers be
parenthesised properly, so it was a trivial extension to extend that to the bracket nodes.
I renamed the enum type to reflect the fact that it is now used for both dot and bracket
accessors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Bug 17018: Incorrect code generated from Function.toString for get/setters in...
oliver@apple.com [Sun, 27 Jan 2008 00:40:59 +0000 (00:40 +0000)]
Fix Bug 17018: Incorrect code generated from Function.toString for get/setters in object literals

Reviewed by Darin.

Don't quote getter and setter names during output, as that is simply wrong.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKit:
ddkilzer@apple.com [Sun, 27 Jan 2008 00:17:08 +0000 (00:17 +0000)]
WebKit:

        <rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit

        Reviewed by Darin.

        * WebKit.xcodeproj/project.pbxproj: Removed WebDashboardRegion.h.

WebKit/mac:

        <rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit

        Reviewed by Darin.

        * WebCoreSupport/WebDashboardRegion.h: Removed.
        * WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric Seidel.
darin@apple.com [Sat, 26 Jan 2008 18:55:52 +0000 (18:55 +0000)]
    Reviewed by Eric Seidel.

        - http://bugs.webkit.org/show_bug.cgi?id=16860
          a bit of cleanup after the Activation optimization

        * JavaScriptCore.exp: Export the GlobalExecState constructor instead of
        the global flavor of the ExecState constructor. It'd probably be cleaner
        to not export either one, but JSGlobalObject inlines the code that
        constructs the ExecState. If we changed that, we could remove this export.

        * JavaScriptCore.xcodeproj/project.pbxproj: Re-sorted a few things and
        put the new source files into the kjs group rather than at the top level.

        * kjs/ExecState.cpp:
        (KJS::ExecState::ExecState): Marked inline and updated for data member
        name changes. This is now only for use for the derived classes. Also removed
        code that sets the unused m_savedExec data member for the global case. That
        data member is only used for the other two types.
        (KJS::ExecState::~ExecState): Marked inline and removed all the code.
        The derived class destructors now inclde the appropriate code.
        (KJS::ExecState::lexicalGlobalObject): Removed unneeded special case for
        an empty scope chain. The bottom function already returns 0 for that case,
        so the general case code handles it fine. Also changed to use data members
        directly rather than calling functions.
        (KJS::GlobalExecState::GlobalExecState): Added. Calls through to the base
        class constructor.
        (KJS::GlobalExecState::~GlobalExecState): Added.
        (KJS::InterpreterExecState::InterpreterExecState): Added. Moved code to
        manipulate activeExecStates here since we don't want to have to check for the
        special case of globalExec.
        (KJS::InterpreterExecState::~InterpreterExecState): Added.
        (KJS::EvalExecState::EvalExecState): Added.
        (KJS::EvalExecState::~EvalExecState): Added.
        (KJS::FunctionExecState::FunctionExecState): Added.
        (KJS::FunctionExecState::~FunctionExecState): Added.

        * kjs/ExecState.h: Tweaked the header, includes, and declarations a bit.
        Made ExecState inherit from Noncopyable. Reformatted some comments and
        made them a bit more brief. Rearranged declarations a little bit and removed
        unused savedExec function. Changed seenLabels function to return a reference
        rather than a pointer. Made constructors and destructor protected, and also
        did the same with all data members. Renamed m_thisVal to m_thisValue and
        ls to m_labelStack. Added three new derived classes for each of the
        types of ExecState. The primary goal here was to remove a branch from the
        code in the destructor, but it's also clearer than overloading the arguments
        to the ExecState constructor.

        * kjs/JSGlobalObject.cpp:
        (KJS::getCurrentTime): Fixed formatting.
        (KJS::JSGlobalObject::pushActivation): Removed parentheses that don't make
        the expression clearer -- other similar sites didn't have these parentheses,
        even the one a couple lines earlier that sets stackEntry.
        (KJS::JSGlobalObject::tearOffActivation): Got rid of unneeded static_cast
        (I think I mentioned this during patch review) and used an early exit so that
        the entire contents of the function aren't nested inside an if statement.
        Also removed the check of codeType, instead checking Activation for 0.
        For now, I kept the codeType check, but inside an assertion.

        * kjs/JSGlobalObject.h: Changed type of globalExec to GlobalExecState.
        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction): Changed type to FunctionExecState.
        (KJS::GlobalFuncImp::callAsFunction): Changed type to EvalExecState.
        * kjs/interpreter.cpp:
        (KJS::Interpreter::evaluate): Changed type to GlobalExecState.

        * kjs/nodes.cpp:
        (KJS::ContinueNode::execute): Changed code since seenLabels() returns a
        reference now instead of a pointer.
        (KJS::BreakNode::execute): Ditto.
        (KJS::LabelNode::execute): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe.
weinig@apple.com [Sat, 26 Jan 2008 18:27:57 +0000 (18:27 +0000)]
    Reviewed by Mark Rowe.

        Cleanup node2string a little.
        - Remove some unnecessary branching.
        - Factor out bracket and dot streaming into static inline functions.

        * kjs/nodes.h:
        * kjs/nodes2string.cpp:
        (KJS::bracketNodeStreamTo):
        (KJS::dotNodeStreamTo):
        (KJS::FunctionCallBracketNode::streamTo):
        (KJS::FunctionCallDotNode::streamTo):
        (KJS::PostIncBracketNode::streamTo):
        (KJS::PostDecBracketNode::streamTo):
        (KJS::PostIncDotNode::streamTo):
        (KJS::PostDecDotNode::streamTo):
        (KJS::DeleteBracketNode::streamTo):
        (KJS::DeleteDotNode::streamTo):
        (KJS::PreIncBracketNode::streamTo):
        (KJS::PreDecBracketNode::streamTo):
        (KJS::PreIncDotNode::streamTo):
        (KJS::PreDecDotNode::streamTo):
        (KJS::ReadModifyBracketNode::streamTo):
        (KJS::AssignBracketNode::streamTo):
        (KJS::ReadModifyDotNode::streamTo):
        (KJS::AssignDotNode::streamTo):
        (KJS::WhileNode::streamTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago <rdar://problem/5707607> REGRESSION: I hear a beep when selecting Alt-enter...
sfalken@apple.com [Sat, 26 Jan 2008 17:58:48 +0000 (17:58 +0000)]
    <rdar://problem/5707607> REGRESSION: I hear a beep when selecting Alt-enter in address or search fields

        Reviewed by Oliver.

        * WebView.cpp:
        (WebView::keyDown): Allow alt-return to be marked as handled by WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix http://bugs.webkit.org/show_bug.cgi?id=17007 ([GTK] autogen.sh attempts to use...
mrowe@apple.com [Sat, 26 Jan 2008 12:32:49 +0000 (12:32 +0000)]
Fix bugs.webkit.org/show_bug.cgi?id=17007 ([GTK] autogen.sh attempts to use "libtoolize" on the Mac).

Reviewed by Alp Toker.

libtoolize is installed as glibtoolize on Mac OS X to avoid naming conflicts
with other system commands.  Check for the presence of glibtoolize if libtoolize
cannot be found.

* autogen.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix http://bugs.webkit.org/show_bug.cgi?id=17001 (Build error with Gtk port on Mac...
mrowe@apple.com [Sat, 26 Jan 2008 10:01:46 +0000 (10:01 +0000)]
Fix bugs.webkit.org/show_bug.cgi?id=17001 (Build error with Gtk port on Mac OS X).

Reviewed by Darin Adler.

If both XP_MACOSX and XP_UNIX are defined then X11.h and Carbon.h will both be included.
These provide conflicting definitions for a type named 'Cursor'.  As XP_UNIX is set by
the build system when targeting X11, it doesn't make sense for XP_MACOSX to also be set
in this instance.

* bindings/npapi.h: Don't define XP_MACOSX if XP_UNIX is defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam and Darin.
eric@webkit.org [Sat, 26 Jan 2008 09:42:39 +0000 (09:42 +0000)]
    Reviewed by Sam and Darin.

        Fire a warning shot in DeprecatedChar's direction.

        Remove DeprecatedChar::isSpace() usage, in preparation for removing DeprecatedChar
        Remove a needless String -> DeprecatedString -> String conversion for <script> tags

        * css/MediaQueryEvaluator.cpp:
        (WebCore::parseAspectRatio):
        * css/SVGCSSParser.cpp:
        * dom/Position.cpp:
        (WebCore::Position::leadingWhitespacePosition):
        (WebCore::Position::trailingWhitespacePosition):
        * editing/TextIterator.cpp:
        (WebCore::WordAwareIterator::advance):
        * html/HTMLFontElement.cpp:
        (WebCore::parseFontSizeNumber):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptHandler):
        (WebCore::HTMLTokenizer::scriptExecution):
        (WebCore::HTMLTokenizer::notifyFinished):
        * html/HTMLTokenizer.h:
        * loader/CachedCSSStyleSheet.cpp:
        * loader/TextResourceDecoder.cpp:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::getData):
        * platform/network/HTTPParsers.cpp:
        (WebCore::extractMIMETypeFromMediaType):
        * platform/text/PlatformString.h:
        * platform/text/StringImpl.cpp:
        (WebCore::parseLength):
        (WebCore::StringImpl::stripWhiteSpace):
        (WebCore::StringImpl::simplifyWhiteSpace):
        (WebCore::StringImpl::toInt):
        (WebCore::StringImpl::toInt64):
        (WebCore::StringImpl::toUInt64):
        * platform/text/StringImpl.h:
        (WebCore::isSpaceOrNewline):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter):
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeHorizontalPositionsForLine):
        * svg/SVGFontFaceElement.cpp:
        (WebCore::mapAttributeToCSSProperty):
        * svg/SVGLength.cpp:
        * svg/SVGStyledElement.cpp:
        (WebCore::mapAttributeToCSSProperty):
        * xml/XPathParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Sat, 26 Jan 2008 09:01:40 +0000 (09:01 +0000)]
JavaScriptCore:

        Reviewed by Oliver.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17013
          JSC can't round trip certain for-loops

        Test: fast/js/toString-for-var-decl.html

        * kjs/nodes.h: Added PlaceholderTrueNode so we can put nodes into
        for loops without injecting the word "true" into them (nice, but not
        the bug fix). Fixed ForNode constructor so expr1WasVarDecl is set
        only when there is an expression, since it's common for the actual
        variable declaration to be moved by the parser.

        * kjs/nodes2string.cpp:
        (KJS::PlaceholderTrueNode::streamTo): Added. Empty.

LayoutTests:

        Reviewed by Oliver.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17013
          JSC can't round trip certain for-loops

        * fast/js/resources/toString-for-var-decl.js: Streamlined the test a bit, with more
        of the execution within shouldBe so that exceptions are caught for us. Added a new
        test case reflecting the just-fixed bug.
        * fast/js/toString-for-var-decl-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix typo in changelog
oliver@apple.com [Sat, 26 Jan 2008 07:58:45 +0000 (07:58 +0000)]
Fix typo in changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix for bug 17012: REGRESSION: JSC can't round trip an object literal
oliver@apple.com [Sat, 26 Jan 2008 07:54:50 +0000 (07:54 +0000)]
Fix for bug 17012: REGRESSION: JSC can't round trip an object literal

Reviewed by Maciej.

Add logic to ensure that object literals and function expressions get
parenthesis when necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofix changelog
slewis@apple.com [Sat, 26 Jan 2008 01:16:29 +0000 (01:16 +0000)]
fix changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago 2008-01-25 U-SLEWIS-WIN\Stephanie <slewis@apple.com>
slewis@apple.com [Sat, 26 Jan 2008 01:09:43 +0000 (01:09 +0000)]
 2008-01-25  U-SLEWIS-WIN\Stephanie  <slewis@apple.com>

         Reviewed by Tim.

         expand workaround for <rdar://5695848> to include js files so that the
         web inspector can work

         * platform/network/cf/ResourceResponseCFNet.cpp:
         (WebCore::ResourceResponse::doUpdateResourceResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
antti@apple.com [Sat, 26 Jan 2008 01:03:17 +0000 (01:03 +0000)]
    Reviewed by Adele.

        (this is for r29798, my commit failed to include the log)

        Windows fix to match r29773
        If the media is playing and the load stalls the playback wont restart by seeking backwards.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::updateStates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
antti@apple.com [Fri, 25 Jan 2008 23:41:25 +0000 (23:41 +0000)]
    Reviewed by Adele.

        Windows fix to match r29773
        If the media is playing and the load stalls the playback wont restart by seeking backwards.

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::updateStates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Fri, 25 Jan 2008 23:40:56 +0000 (23:40 +0000)]
WebCore:

        Reviewed by Anders.

        - fix <rdar://problem/5691072> ASSERTION FAILED: isPrepared() when executing an empty statement

        For empty statements, SQLite returns 0 for the statement. We have to cope with that.

        Test: storage/empty-statement.html

        * platform/sql/SQLiteStatement.cpp:
        (WebCore::sqlite3_prepare16_v2): Added overload so we don't need an #if inside the prepare
        function.
        (WebCore::SQLiteStatement::SQLiteStatement): Initialize the m_isPrepared boolean. Removed
        the code to add a null character to the end of the string; instead we will use
        charactersWithNullTermination.
        (WebCore::SQLiteStatement::prepare): Set m_isPrepared based on the error value returned.
        Use the error value from sqlite3_prepare16_v2, not from lastError().
        (WebCore::SQLiteStatement::step): Assert that the statement is prepared rather than checking
        it at runtime. However, in the case where this is called with m_statement of 0, return
        success rather than an error. That's needed for empty statements.
        (WebCore::SQLiteStatement::finalize): Use early return idiom for clarity. When there is no
        statement, return SQLITE_OK instead of calling lastError().
        (WebCore::SQLiteStatement::reset): Use early return idiom for clarity. When there is no
        statement, return SQLITE_OK rather than SQLITE_ERROR, but assert the statement is prepared.
        (WebCore::SQLiteStatement::executeCommand): Adjust the code that does a prepare so that it
        will work for empty statements. Do we really need to allow calling this without prepare?
        It would be simpler to just be able to assert that it's prepared.
        (WebCore::SQLiteStatement::returnsAtLeastOneResult): Ditto.
        (WebCore::SQLiteStatement::bindBlob): Added some assertions. Return SQLITE_ERROR if this
        is called with m_statement of 0 (should not be possible without assertions firing first).
        Return the actual error code rather than lastError().
        (WebCore::SQLiteStatement::bindText): Ditto. Also simplified the special case for empty
        strings, since it requires any non-null pointer, not a pointer to a global zero character.
        (WebCore::SQLiteStatement::bindInt64): Ditto.
        (WebCore::SQLiteStatement::bindDouble): Ditto.
        (WebCore::SQLiteStatement::bindNull): Ditto.
        (WebCore::SQLiteStatement::bindValue): Moved default case out of the switch to take
        advantage of the gcc compiler warning for unhandled enum values in a switch.
        (WebCore::SQLiteStatement::bindParameterCount): Added assertion and code to handle the
        empty statement case.
        (WebCore::SQLiteStatement::columnCount): Added assertion and changed the code to use
        the early-return idiom.
        (WebCore::SQLiteStatement::getColumnName): Removed getColumnName16 -- we always use 16-bit
        characters and have no reason to ever use the 8-bit function. Added assertions about the
        passed-in column number. It's a little strange that this function checks the column number
        for too-large column numbers, but not for negative ones. I didn't change that for now.
        (WebCore::SQLiteStatement::getColumnText): Ditto.
        (WebCore::SQLiteStatement::getColumnDouble): Ditto.
        (WebCore::SQLiteStatement::getColumnInt): Ditto.
        (WebCore::SQLiteStatement::getColumnInt64): Ditto.
        (WebCore::SQLiteStatement::getColumnBlobAsVector): Ditto.
        (WebCore::SQLiteStatement::getColumnBlob): Tightened up function a bit, including use of
        the early-return idiom and replacing the multiple "size = 0" with a single one at the
        start of the function.
        (WebCore::SQLiteStatement::returnTextResults): Added a failure case when the prepare
        call doesn't work. Cleared the vector earlier to make the failure code simpler. Moved
        the declaration of the result boolean down lower to make it clearer what it's for.
        Changed use of lastError() to call on the database, to make it clearer that there's
        no per-statement last error kept around. It'd be even better to not use lastError() here.
        (WebCore::SQLiteStatement::returnIntResults): Ditto.
        (WebCore::SQLiteStatement::returnInt64Results): Ditto.
        (WebCore::SQLiteStatement::returnDoubleResults): Ditto.
        (WebCore::SQLiteStatement::isExpired): Changed to use || rather than ?: because I think
        it's slightly easier to read that way.

        * platform/sql/SQLiteStatement.h: Removed unneeded includes and forward declarations.
        Also removed unnneeded functions isPrepared, getColumnName16, getColumnText16,
        returnTextResults16, lastError, and lastErrorMsg. Changed prepareAndStep so that it
        checks the result of prepare before callling step. Added a debug-only m_isPrepared boolean.

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::checkIntegrity): Remove 16 suffix from text-related function names.
        (WebCore::IconDatabase::performURLImport): Ditto.
        (WebCore::IconDatabase::pruneUnretainedIcons): Ditto.
        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::clearAllTables): Ditto.
        * storage/Database.cpp:
        (WebCore::retrieveTextResultFromDatabase): Ditto.
        (WebCore::Database::performGetTableNames): Ditto.
        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::fullPathForDatabase): Ditto.
        (WebCore::DatabaseTracker::populateOrigins): Ditto.
        (WebCore::DatabaseTracker::databaseNamesForOrigin): Ditto.
        (WebCore::DatabaseTracker::addDatabase): Ditto.
        * storage/SQLStatement.cpp:
        (WebCore::SQLStatement::execute): Ditto.

        * platform/sql/SQLiteDatabase.h: Removed unneeded includes.
        * storage/SQLResultSet.h: Ditto.
        * storage/SQLResultSetRowList.h: Ditto.

LayoutTests:

        Reviewed by Anders.

        - test for <rdar://problem/5691072> ASSERTION FAILED: isPrepared() when executing an empty statement

        * storage/empty-statement-expected.txt: Added.
        * storage/empty-statement.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
antti@apple.com [Fri, 25 Jan 2008 23:07:13 +0000 (23:07 +0000)]
    Reviewed by Darin.

        Fix <rdar://problem/5674282>
        Some media tests fail on Windows

        - fix the script to exit cleanly
        - slightly increase the amount of data to hand out before stalling, apparently
          QT on Windows needs more to start playback

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele@apple.com [Fri, 25 Jan 2008 22:28:49 +0000 (22:28 +0000)]
WebCore:

        Reviewed by Sam.

        Fix for <rdar://problem/5679452> Finish tweaking layout/alignment of media controls slider to match QuickTime plug-in

        * css/html4.css: Add horizontal padding to the media slider.
        * rendering/RenderSlider.cpp:
        (WebCore::HTMLSliderThumbElement::defaultEventHandler): Replace use of absoluteBoundingBox() with width() and height()
        (WebCore::RenderSlider::positionForOffset): ditto. Also, use the trackSize() for the maximum offset.
        (WebCore::RenderSlider::layout):  Use contentWidth() and contentHeight() to take padding into account.
        (WebCore::RenderSlider::trackSize): ditto.

LayoutTests:

        Reviewed by Sam.

        Adding new test and updated results for:
        <rdar://problem/5679452> Finish tweaking layout/alignment of media controls slider to match QuickTime plug-in

        * fast/forms/slider-padding.html: Added.
        * platform/mac/fast/forms/slider-padding-expected.checksum: Added.
        * platform/mac/fast/forms/slider-padding-expected.png: Added.
        * platform/mac/fast/forms/slider-padding-expected.txt: Added.
        * platform/mac/media/audio-controls-rendering-expected.checksum:
        * platform/mac/media/audio-controls-rendering-expected.png:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/broken-video-expected.checksum:
        * platform/mac/media/broken-video-expected.png:
        * platform/mac/media/progress-event-expected.checksum:
        * platform/mac/media/progress-event-expected.png:
        * platform/mac/media/unsupported-rtsp-expected.checksum:
        * platform/mac/media/unsupported-rtsp-expected.png:
        * platform/mac/media/unsupported-tracks-expected.checksum:
        * platform/mac/media/unsupported-tracks-expected.png:
        * platform/mac/media/video-append-source-expected.checksum:
        * platform/mac/media/video-append-source-expected.png:
        * platform/mac/media/video-autoplay-expected.checksum:
        * platform/mac/media/video-autoplay-expected.png:
        * platform/mac/media/video-buffered-expected.checksum:
        * platform/mac/media/video-buffered-expected.png:
        * platform/mac/media/video-controls-expected.checksum:
        * platform/mac/media/video-controls-expected.png:
        * platform/mac/media/video-controls-rendering-expected.checksum:
        * platform/mac/media/video-controls-rendering-expected.png:
        * platform/mac/media/video-controls-rendering-expected.txt:
        * platform/mac/media/video-currentTime-set2-expected.checksum:
        * platform/mac/media/video-currentTime-set2-expected.png:
        * platform/mac/media/video-display-toggle-expected.checksum:
        * platform/mac/media/video-display-toggle-expected.png:
        * platform/mac/media/video-display-toggle-expected.txt:
        * platform/mac/media/video-dom-autoplay-expected.checksum:
        * platform/mac/media/video-dom-autoplay-expected.png:
        * platform/mac/media/video-dom-src-expected.checksum:
        * platform/mac/media/video-dom-src-expected.png:
        * platform/mac/media/video-dom-start-expected.checksum:
        * platform/mac/media/video-dom-start-expected.png:
        * platform/mac/media/video-error-abort-expected.checksum:
        * platform/mac/media/video-error-abort-expected.png:
        * platform/mac/media/video-error-does-not-exist-expected.checksum:
        * platform/mac/media/video-error-does-not-exist-expected.png:
        * platform/mac/media/video-load-networkState-expected.checksum:
        * platform/mac/media/video-load-networkState-expected.png:
        * platform/mac/media/video-load-readyState-expected.checksum:
        * platform/mac/media/video-load-readyState-expected.png:
        * platform/mac/media/video-muted-expected.checksum:
        * platform/mac/media/video-muted-expected.png:
        * platform/mac/media/video-no-autoplay-expected.checksum:
        * platform/mac/media/video-no-autoplay-expected.png:
        * platform/mac/media/video-pause-empty-events-expected.checksum:
        * platform/mac/media/video-pause-empty-events-expected.png:
        * platform/mac/media/video-play-empty-events-expected.checksum:
        * platform/mac/media/video-play-empty-events-expected.png:
        * platform/mac/media/video-play-pause-events-expected.checksum:
        * platform/mac/media/video-play-pause-events-expected.png:
        * platform/mac/media/video-play-pause-exception-expected.checksum:
        * platform/mac/media/video-play-pause-exception-expected.png:
        * platform/mac/media/video-seek-past-end-paused-expected.checksum:
        * platform/mac/media/video-seek-past-end-paused-expected.png:
        * platform/mac/media/video-seek-past-end-playing-expected.checksum:
        * platform/mac/media/video-seek-past-end-playing-expected.png:
        * platform/mac/media/video-seekable-expected.checksum:
        * platform/mac/media/video-seekable-expected.png:
        * platform/mac/media/video-seeking-expected.checksum:
        * platform/mac/media/video-seeking-expected.png:
        * platform/mac/media/video-size-expected.checksum:
        * platform/mac/media/video-size-expected.png:
        * platform/mac/media/video-source-expected.checksum:
        * platform/mac/media/video-source-expected.png:
        * platform/mac/media/video-source-media-expected.checksum:
        * platform/mac/media/video-source-media-expected.png:
        * platform/mac/media/video-source-type-expected.checksum:
        * platform/mac/media/video-source-type-expected.png:
        * platform/mac/media/video-src-change-expected.checksum:
        * platform/mac/media/video-src-change-expected.png:
        * platform/mac/media/video-src-expected.checksum:
        * platform/mac/media/video-src-expected.png:
        * platform/mac/media/video-src-remove-expected.checksum:
        * platform/mac/media/video-src-remove-expected.png:
        * platform/mac/media/video-src-set-expected.checksum:
        * platform/mac/media/video-src-set-expected.png:
        * platform/mac/media/video-src-source-expected.checksum:
        * platform/mac/media/video-src-source-expected.png:
        * platform/mac/media/video-start-expected.checksum:
        * platform/mac/media/video-start-expected.png:
        * platform/mac/media/video-volume-expected.checksum:
        * platform/mac/media/video-volume-expected.png:
        * platform/mac/media/video-width-height-expected.checksum:
        * platform/mac/media/video-width-height-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago <rdar://problem/5674277>
antti@apple.com [Fri, 25 Jan 2008 21:38:28 +0000 (21:38 +0000)]
    <rdar://problem/5674277>
        Test media/video-display-toggle.html crashes on Windows

        Appears to be some problem in DRT when test ends with layout pending.
        Fixed by forcing layout, this improves test coverage too.

        * media/video-display-toggle.html:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-25 Ori Bernstein <ori@eigenstate.org>
alp@webkit.org [Fri, 25 Jan 2008 18:31:04 +0000 (18:31 +0000)]
2008-01-25  Ori Bernstein  <ori@eigenstate.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=16795
        WebKitGtk crashes when there is no focused Frame

        Add a null check. focusedFrame() isn't used directly anywhere else so
        this is the only case that needs to be fixed.

        * WebView/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago <rdar://problem/5706788> http/tests/security/cross-frame-access-port-explicit...
ap@webkit.org [Fri, 25 Jan 2008 15:01:01 +0000 (15:01 +0000)]
    <rdar://problem/5706788> http/tests/security/cross-frame-access-port-explicit-domain.html fails on Windows

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago http/tests/xmlhttprequest/readystatechange.html fails on buildbot.
ap@webkit.org [Fri, 25 Jan 2008 14:42:37 +0000 (14:42 +0000)]
    http/tests/xmlhttprequest/readystatechange.html fails on buildbot.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe.
ap@webkit.org [Fri, 25 Jan 2008 11:45:18 +0000 (11:45 +0000)]
    Reviewed by Mark Rowe.

        <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing

        * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
        (matching Mac DRT).
        * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix
sfalken@apple.com [Fri, 25 Jan 2008 01:13:38 +0000 (01:13 +0000)]
    Build fix

        * WebKit.vcproj/WebKit.sln:
        * WebKit.vcproj/WebKit.submit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
sfalken@apple.com [Fri, 25 Jan 2008 01:08:54 +0000 (01:08 +0000)]
    Build fix.

        * JavaScriptCore.vcproj/JavaScriptCore.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
sfalken@apple.com [Fri, 25 Jan 2008 01:07:16 +0000 (01:07 +0000)]
    Build fix.

        * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
weinig@apple.com [Fri, 25 Jan 2008 00:51:55 +0000 (00:51 +0000)]
WebKitTools:

        Reviewed by Ada Chan.

        Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo

        - Adds simplified UndoManager to windows DRT to allow testing the
          undo/redo code paths in WebCore and WebKit.  This is a temporary
          solution to an issue that should eventually be solved by having a
          shared UndoManager in WebKit.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (runTest):
        * DumpRenderTree/win/UIDelegate.cpp:
        (DRTUndoObject::DRTUndoObject):
        (DRTUndoObject::invoke):
        (DRTUndoStack::~DRTUndoStack):
        (DRTUndoStack::isEmpty):
        (DRTUndoStack::clear):
        (DRTUndoStack::push):
        (DRTUndoStack::pop):
        (DRTUndoManager::canRedo):
        (DRTUndoManager::canUndo):
        (DRTUndoManager::DRTUndoManager):
        (DRTUndoManager::removeAllActions):
        (DRTUndoManager::registerUndoWithTarget):
        (DRTUndoManager::redo):
        (DRTUndoManager::undo):
        (UIDelegate::UIDelegate):
        (UIDelegate::resetUndoManager):
        (UIDelegate::registerUndoWithTarget):
        (UIDelegate::removeAllActionsWithTarget):
        (UIDelegate::setActionTitle):
        (UIDelegate::undo):
        (UIDelegate::redo):
        (UIDelegate::canUndo):
        (UIDelegate::canRedo):
        * DumpRenderTree/win/UIDelegate.h:

LayoutTests:

        Reviewed by Ada Chan.

        <rdar://5131975> DumpRenderTree doesn't support undo/redo

        * platform/win/Skipped: With undo/redo support enabled, we can now
        remove the undo tests from the Skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Better fix for Bug 16996
aroben@apple.com [Thu, 24 Jan 2008 23:50:34 +0000 (23:50 +0000)]
    Better fix for Bug 16996

        Rubberstamped by Mitz.

        * loader/CachedFont.cpp:
        (WebCore::CachedFont::ensureCustomFontData): Don't call
        createFontCustomPlatformData if m_data is null.
        * platform/graphics/gtk/FontCustomPlatformData.cpp:
        (WebCore::createFontCustomPlatformData): Added an assertion.
        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::createFontCustomPlatformData): Ditto.
        * platform/graphics/qt/FontCustomPlatformData.cpp:
        (WebCore::createFontCustomPlatformData): Ditto.
        * platform/graphics/win/FontCustomPlatformData.cpp:
        (WebCore::createFontCustomPlatformData): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 16996: Crash in createFontCustomPlatformData when loading 0-byte font via...
aroben@apple.com [Thu, 24 Jan 2008 23:13:26 +0000 (23:13 +0000)]
 Fix Bug 16996: Crash in createFontCustomPlatformData when loading 0-byte font via @font-face

 WebCore:

         Fix Bug 16996: Crash in createFontCustomPlatformData when loading
         0-byte font via @font-face

         <http://bugs.webkit.org/show_bug.cgi?id=16996>

         Reviewed by Hyatt.

         Test: fast/loader/font-face-empty.html

         * platform/graphics/win/FontCustomPlatformData.cpp:
         (WebCore::createFontCustomPlatformData): Null-check the buffer
         parameter.

 LayoutTests:

         Test for Bug 16996: Crash in createFontCustomPlatformData when loading
         0-byte font via @font-face

         <http://bugs.webkit.org/show_bug.cgi?id=16996>

         Reviewed by Hyatt.

         * fast/loader/font-face-empty-expected.txt: Added.
         * fast/loader/font-face-empty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate results for an editing test that changed from Acid3 fix.
hyatt@apple.com [Thu, 24 Jan 2008 22:02:11 +0000 (22:02 +0000)]
Update results for an editing test that changed from Acid3 fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-24 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 24 Jan 2008 21:53:29 +0000 (21:53 +0000)]
2008-01-24  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Anders.

        <rdar://problem/5588807> Crash in Flash when destroying plug-in (found
        using yahoo beta mail)

        Flash can dereference NULL in the call to NPP_URLNotify if a request
        made with NPN_PostURLNotify fails before NPP_NewStream is called.

        Work around this by creating a quirk, PluginQuirkFlashURLNotifyBug, and
        checking for this quirk before calling NPP_URLNotify for any request
        made with NPN_PostURLNotify. If the quirk is present, call NPP_NewStream
        and NPP_DestroyStream before calling NPP_URLNotify.

        * WebCore.vcproj/WebCore.vcproj:
        * plugins/PluginQuirkSet.h: Added. Moved quirks out of PluginViewWin so
        PluginViewWin and PluginStream could share it. Created a class,
        PluginQuirkSet, to store plug-in quirks
        (WebCore::):
        (WebCore::PluginQuirkSet::PluginQuirkSet):
        (WebCore::PluginQuirkSet::add):
        (WebCore::PluginQuirkSet::contains):
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::PluginStream): Copy the PluginQuirkSet for this
        plug-in
        (WebCore::PluginStream::destroyStream): Check for the FlashURLNotifyBug
        quirk
        * plugins/PluginStream.h:
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginViewWin::performRequest): Pass the quirks when creating
        the PluginStream
        (WebCore::PluginViewWin::didReceiveResponse): Same
        (WebCore::PluginViewWin::wndProc): Use add / contains instead of
        bit ops
        (WebCore::PluginViewWin::userAgent): Same
        (WebCore::PluginViewWin::invalidateRect): Same
        (WebCore::PluginViewWin::~PluginViewWin): Same
        (WebCore::PluginViewWin::determineQuirks): Same
        (WebCore::PluginViewWin::setParameters): Same
        (WebCore::PluginViewWin::PluginViewWin): Same
        (WebCore::PluginViewWin::init): Same
        (WebCore::PluginViewWin::setCallingPlugin): Same
        * plugins/win/PluginViewWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd test results for Acid3 buckets parsing issue.
hyatt@apple.com [Thu, 24 Jan 2008 21:52:07 +0000 (21:52 +0000)]
Add test results for Acid3 buckets parsing issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd test of Acid3 buckets parsing issue.
hyatt@apple.com [Thu, 24 Jan 2008 21:51:37 +0000 (21:51 +0000)]
Add test of Acid3 buckets parsing issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago http://bugs.webkit.org/show_bug.cgi?id=16982
hyatt@apple.com [Thu, 24 Jan 2008 21:49:25 +0000 (21:49 +0000)]
    bugs.webkit.org/show_bug.cgi?id=16982

        Make sure to make <head> the current block if it is created before a <body> already exists.

        Reviewed by Dan

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::createHead):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago http://bugs.webkit.org/show_bug.cgi?id=16993
ap@webkit.org [Thu, 24 Jan 2008 19:40:05 +0000 (19:40 +0000)]
    bugs.webkit.org/show_bug.cgi?id=16993
        <rdar://problem/5704331> REGRESSION: Loading page leads to many unexpected redirections

        Rolled out r29590, which was not a correct fix for <rdar://problem/5692566>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
antti@apple.com [Thu, 24 Jan 2008 18:24:59 +0000 (18:24 +0000)]
WebCore:

        Reviewed by Adam.

        If the media is playing and the load stalls the playback wont restart by seeking backwards.

        We should be in CAN_PLAY state if the current time is less than the maximum loaded time. Rate
        tricks were for streaming case and are not necessary now since that is now disabled.

        Windows patch coming separately.

        Test: http/tests/media/video-play-stall-seek.html

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::updateStates):

LayoutTests:

        Reviewed by Adam.

        Test that playback can be resumed by seeking backwards after a stall.

        * http/tests/media/video-play-stall-seek-expected.txt: Added.
        * http/tests/media/video-play-stall-seek.html: Added.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
antti@apple.com [Thu, 24 Jan 2008 18:18:30 +0000 (18:18 +0000)]
    Reviewed by Adam.

        Fix <rdar://problem/5684815>
        After navigating back to the page that contains a <audio> that has been muted, the audio is still heard

        - get rid of the separate muted state in MediaPlayer, maintain the state in the cross platform code only
        - remove volumeChanged() callbacks from HTMLMediaElement and OS X MediaPlayer, they were not used for anything
        - rename updateMediaPlayer -> updatePlayState which tells more about what it actually does

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::load):
        (WebCore::HTMLMediaElement::setReadyState):
        (WebCore::HTMLMediaElement::play):
        (WebCore::HTMLMediaElement::pause):
        (WebCore::HTMLMediaElement::setVolume):
        (WebCore::HTMLMediaElement::setMuted):
        (WebCore::HTMLMediaElement::checkIfSeekNeeded):
        (WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
        (WebCore::HTMLMediaElement::updateVolume):
        (WebCore::HTMLMediaElement::updatePlayState):
        (WebCore::HTMLMediaElement::setPausedInternal):
        * html/HTMLMediaElement.h:
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::MediaPlayer):
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovie):
        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
        * platform/graphics/win/QTMovieWin.cpp:
        * platform/graphics/win/QTMovieWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix
aroben@apple.com [Thu, 24 Jan 2008 17:38:33 +0000 (17:38 +0000)]
    Build fix

        * WebView.cpp: Added a comma.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Allow directories containing ChangeLogs to be passed to resolve-ChangeLogs
aroben@apple.com [Thu, 24 Jan 2008 17:27:26 +0000 (17:27 +0000)]
     Allow directories containing ChangeLogs to be passed to resolve-ChangeLogs

         Reviewed by David Kilzer.

         * Scripts/resolve-ChangeLogs:
         (sub findChangeLog): Return a ChangeLog contained within the specified
         directory if one exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
ap@webkit.org [Thu, 24 Jan 2008 16:36:54 +0000 (16:36 +0000)]
    Reviewed by Adam Roben.

        <rdar://problem/5702734> REGRESSION(r28936/r15890): Shift+del does not work in win Safari

        * WebView.cpp: Fixed keyDownEntries to list this shortcut (and related ones, for consistency).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:52:05 +0000 (14:52 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Fix "QObject::startTimer: QTimer can only be used with threads started with QThread"
* The JSC GCController gets automatically destructed on application exit, it will stop
  its timer and we try to schedule the next timer. Now the GCController can get destructed
  after our QApplication is gone. This will trigger the above warning, we can avoid this
  by checking if our qApp is still around.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMorten Johan Sørvig <msorvig@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:27:58 +0000 (14:27 +0000)]
Morten Johan Sørvig <msorvig@trolltech.com>

Qt/Mac: Make sure the scrollbars does not overlap the grow box.

When showing only one scrollbar we need to move it so it doesn't overlap the
grow box. This is similar to the code in QAbstractScrollArea.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDavid Boddie <dboddie@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:24:48 +0000 (14:24 +0000)]
David Boddie <dboddie@trolltech.com>

Documentation tidying.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJarek Kobus <jkobus@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:23:50 +0000 (14:23 +0000)]
Jarek Kobus <jkobus@trolltech.com>

Text for translations were used wrongly as comments

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:18:34 +0000 (14:18 +0000)]
Michael Goddard  <michael.goddard@trolltech.com>

http://bugs.webkit.org/show_bug.cgi?id=16888

Fix for CSS crash in -webkit-border-image.
Reviewed by Darin.

While parsing -webkit-border-image, store
the border widths as naked pointers rather
than as OwnPtrs, since they point to the
middle of an array.

Test: fast/css/border-image-crash.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:13:36 +0000 (14:13 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* We have a KURL->QUrl conversion on KURL itself, make use of it.
* This conversion is supposed to be loss-free

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:08:12 +0000 (14:08 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Attempt to fix showing of popup again after a popup has been shown but
  the user did not select any item (e.g. clicked outside of the popup)
* Keep track of the popup status using the virtuals showPopup and hidePopup
  and do not go into recursion when hiding a popup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 14:01:48 +0000 (14:01 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Assert the presence of the PopupMenuClient

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 13:56:49 +0000 (13:56 +0000)]
Michael Goddard <michael.goddard@trolltech.com>

Fix QDateTime to JS Date conversion.
Several conversion errors (some UTC related, some month
offset related) and the conversion distance for Date
to DateTime conversion weights were fixed (it should never
be better to convert a JS Number into a Date rather than
an int).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 13:51:26 +0000 (13:51 +0000)]
Michael Goddard <michael.goddard@trolltech.com>

Add support for calling QObjects.
Add support for invokeDefaultMethod (via a call to
a specific slot), and also allow using it as a
constructor, like QtScript.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 13:44:46 +0000 (13:44 +0000)]
Michael Goddard <michael.goddard@trolltech.com>

Code style cleanups.
Add spaces before/after braces in inline function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 13:41:14 +0000 (13:41 +0000)]
Michael Goddard <michael.goddard@trolltech.com>

Code style cleanups.
Remove spaces and unneeded declared parameter names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMichael Goddard <michael.goddard@trolltech.com>
hausmann@webkit.org [Thu, 24 Jan 2008 13:37:49 +0000 (13:37 +0000)]
Michael Goddard <michael.goddard@trolltech.com>

Clear stale RuntimeObjectImps.
Since other objects can have refs to the QtInstance,
we can't rely on the QtInstance being deleted when the
RuntimeObjectImp is invalidate or deleted.  This
could result in a stale JSObject being returned for
a valid Instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoVersioning.
mrowe@apple.com [Thu, 24 Jan 2008 07:44:50 +0000 (07:44 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago <rdar://problem/5702947> WebCore: CGContextDrawPDFDocument will be deprecated
ddkilzer@apple.com [Thu, 24 Jan 2008 00:47:00 +0000 (00:47 +0000)]
    <rdar://problem/5702947> WebCore: CGContextDrawPDFDocument will be deprecated

        Reviewed by Darin.

        No test cases added since there is no change in behavior.

        * platform/graphics/cg/PDFDocumentImage.cpp:
        (WebCore::PDFDocumentImage::draw): Replace CGContextDrawPDFDocument() with
        calls to CG methods that perform the equivalent work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt, Adele.
antti@apple.com [Wed, 23 Jan 2008 23:08:54 +0000 (23:08 +0000)]
    Reviewed by Hyatt, Adele.

        Timers for media controls keep running when the page is in the page cache.

        Stop timers in RenderMedia and get rid of the controls tree when the page goes to the cache.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement):
        (WebCore::HTMLMediaElement::willSaveToCache):
        (WebCore::HTMLMediaElement::didRestoreFromCache):
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::inPageCache):
        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::updateControls):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
antti@apple.com [Wed, 23 Jan 2008 22:26:01 +0000 (22:26 +0000)]
    Reviewed by Adam.

        Video that had already played to the end would start playing (from beginning) on back/forward navigation.

        Use setPausedInternal() instead of pause(). This avoid generating pause/play events and matches specification text.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::willSaveToCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Wed, 23 Jan 2008 22:20:55 +0000 (22:20 +0000)]
    Reviewed by Darin.

        <rdar://problem/4200075> Missing support for accented chars in mailto forms

        With some combinations of form parameters, this was resulting in regressed behavior.

        Tests: fast/forms/mailto/get-non-ascii-text-plain-latin-1.html
               fast/forms/mailto/post-text-plain-with-accept-charset.html
               fast/forms/mailto/post-text-plain.html

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::formData): Ignore accept-charset for mailto forms, which are always
        encoded as UTF-8.
        (WebCore::HTMLFormElement::isMailtoForm): Added.
        (WebCore::HTMLFormElement::dataEncoding): Added (factored out from formData).
        (WebCore::HTMLFormElement::submit): When round-tripping in text/plain case, use utf-8 encoding.
        * html/HTMLFormElement.h: Added a isMailtoForm() function. It may be a bit unfortunate that
        its result is calculated repeatedly, but this doesn't seem to be anywhere near hot code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
sfalken@apple.com [Wed, 23 Jan 2008 22:04:16 +0000 (22:04 +0000)]
WebCore:

        Reviewed by Alice Liu.

        <rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::updateFromElement): If value == text() and
        m_innerText is empty, then value and text() are "". In that case both DOM
        mutations are no-ops and there is no reason to clear the Undo stack.

WebKit/win:

        <rdar://problem/5698732> Copyright strings should include 2008

        Reviewed by Sam.

        * WebKit.vcproj/WebKit.rc:

WebKitTools:

        <rdar://problem/5698732> Copyright strings should include 2008

        Reviewed by Sam.

        * Drosera/win/Drosera.vcproj/Drosera.rc:
        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justin.garcia@apple.com [Wed, 23 Jan 2008 21:51:13 +0000 (21:51 +0000)]
WebCore:

        Reviewed by Alice Liu.

        <rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::updateFromElement): If value == text() and
        m_innerText is empty, then value and text() are "". In that case both DOM
        mutations are no-ops and there is no reason to clear the Undo stack.

LayoutTests:

        Reviewed by Alice Liu.

        <rdar://problem/5658727> Undo/redo for pasted or typed text in yahoo mail becomes disabled after one round of being selected

        * editing/undo/5658727-expected.txt: Added.
        * editing/undo/5658727.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix <rdar://5698502> Inspector window reverts to default position/size unexp...
aroben@apple.com [Wed, 23 Jan 2008 21:08:15 +0000 (21:08 +0000)]
     Fix <rdar://5698502> Inspector window reverts to default position/size unexpectedly

         Reviewed by Hyatt.

         * WebInspectorClient.cpp:
         (defaultWindowRect): Added.
         (WebInspectorClient::createPage):
             - Use defaultWindowRect() to set the initial size/position of the
               Inspector window.
             - Pass the Inspector window's client rect to
               IWebView::initWithFrame so that the WebView will be initially
               sized to fill the window.
         (WebInspectorClient::showWindow): Don't move/resize the window back to
         the defaults every time this method is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open...
aroben@apple.com [Wed, 23 Jan 2008 21:07:47 +0000 (21:07 +0000)]
 Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com

 WebKit/win:

         Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com

         Test: fast/events/contextmenu-scrolled-page-with-frame.html

         Reviewed by Dan.

         * WebView.cpp:
         (WebView::handleContextMenuEvent): Translate the mouse coordinates
         into document coordinates before performing the hit-test. This is what
         EventHandler does internally.

 LayoutTests:

         Add a test for <rdar://5700620> REGRESSION (r28190): "Open frame in
         new tab" instead of "Open link in new tab" @ digg.com

         Reviewed by Dan.

         * fast/events/contextmenu-scrolled-page-with-frame-expected.txt: Added.
         * fast/events/contextmenu-scrolled-page-with-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
sfalken@apple.com [Wed, 23 Jan 2008 19:43:14 +0000 (19:43 +0000)]
WebCore:

        <rdar://problem/5699509> Allow file upload dialog to be localized.

        Reviewed by Darin.

        * platform/LocalizedStrings.h:
        * platform/win/FileChooserWin.cpp:
        (WebCore::FileChooser::openFileChooser):

WebKit:

        Update localization exceptions.

        Reviewed by Darin.

        * English.lproj/Localizable.strings:
        * StringsNotToBeLocalized.txt:

WebKit/win:

        <rdar://problem/5699509> Allow file upload dialog to be localized.

        Reviewed by Darin.

        * English.lproj/Localizable.strings: Updated.
        * WebCoreLocalizedStrings.cpp:
        (WebCore::uploadFileText): Added.
        (WebCore::allFilesText): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
dsmith@webkit.org [Wed, 23 Jan 2008 17:49:23 +0000 (17:49 +0000)]
    Reviewed by Darin.

        Added a modified version of the MooTools SlickSpeed Selector Test/Benchmark to show off querySelectorAll. MIT licensed.

        * perf/slickspeed: Added.
        * perf/slickspeed/config.ini: Added.
        * perf/slickspeed/footer.html: Added.
        * perf/slickspeed/frameworks: Added.
        * perf/slickspeed/frameworks/DomQuery.js: Added.
        * perf/slickspeed/frameworks/dummy.js: Added.
        * perf/slickspeed/frameworks/jquery-1.2.1.js: Added.
        * perf/slickspeed/frameworks/prototype.js: Added.
        * perf/slickspeed/header.html: Added.
        * perf/slickspeed/index.php: Added.
        * perf/slickspeed/instructions.txt: Added.
        * perf/slickspeed/logo.png: Added.
        * perf/slickspeed/selectors.list: Added.
        * perf/slickspeed/style.css: Added.
        * perf/slickspeed/system: Added.
        * perf/slickspeed/system/index.php: Added.
        * perf/slickspeed/system/slickspeed.js: Added.
        * perf/slickspeed/system/template.php: Added.
        * perf/slickspeed/template.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix behavior of type-to-select in <select> menus
aroben@apple.com [Wed, 23 Jan 2008 17:38:17 +0000 (17:38 +0000)]
     Fix behavior of type-to-select in <select> menus

         In r27825 we started posting both a WM_KEYDOWN and WM_CHAR message
         whenever a key was pressed in the dropdown menu. However, since posted
         messages go through TranslateMessage, the WM_KEYDOWN was generating
         another WM_CHAR message, so two WM_CHAR messages in a row would reach
         the WebView. This caused the searching to happen twice for each key,
         so typing "dog" would search for "ddoogg".

         Reviewed by Darin.

         * platform/win/PopupMenuWin.cpp:
         (WebCore::PopupWndProc): Repost the WM_KEYDOWN message to the WebView.
         This is will generate a WM_CHAR message which will trigger the
         type-to-select behavior. This is very similar to our behavior prior to
         r27825, except that we're now calling PostMessage instead of
         SendMessage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - updated results following <http://trac.webkit.org/projects/webkit/changeset...
mitz@apple.com [Wed, 23 Jan 2008 16:18:24 +0000 (16:18 +0000)]
    - updated results following <trac.webkit.org/projects/webkit/changeset/29721>

        * platform/mac/fast/frames/viewsource-attribute-expected.checksum:
        * platform/mac/fast/frames/viewsource-attribute-expected.png:
        * platform/mac/fast/frames/viewsource-attribute-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-01-23 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 23 Jan 2008 15:55:41 +0000 (15:55 +0000)]
2008-01-23  Alp Toker  <alp@atoker.com>

        Rubber-stamped by Mark Rowe.

        Remove whitespace after -I in automake include lists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 11:16:45 +0000 (11:16 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Fix leaking of sub frames (WebCore::Frame). We keep one reference too many.
  This was found while working on the page-cache, other ports are not affected.
* Rubber stamped by Simon

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 11:14:06 +0000 (11:14 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Load images incrementally. This will show warnings on the console
  and we want to fix them for Qt4.4. If that happens we have to remove
  the comment from the enum inside the ImageDecoderQt.cpp

* Rubber stamped by Simon

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRohan McGovern <rohan.mcgovern@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 11:11:27 +0000 (11:11 +0000)]
Rohan McGovern <rohan.mcgovern@trolltech.com>

Fix Qtopia compilation with QT_NO_TOOLTIP

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoGeir Vattekar <gvatteka@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 11:11:13 +0000 (11:11 +0000)]
Geir Vattekar <gvatteka@trolltech.com>

Doc: Replaced \code with snippets in the docs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLars Knoll <lars@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 11:10:57 +0000 (11:10 +0000)]
Lars Knoll <lars@trolltech.com>

Fix rendering of the Scrollbar as well as mouse handling for some styles.

The QStyle expects that that painter is set up to clip to the scrollbar bounds
and some of the styles seem to paint somewhat outside of these bounds. Clipping to
the scrollbar bounds before drawing removes some artifacts.

Also set m_opt.rect.topLeft to (0/0) in the mouse handlers. Fixes some issues with
the oxygen style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMichael Brasser <michael.brasser@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 09:55:46 +0000 (09:55 +0000)]
Michael Brasser <michael.brasser@trolltech.com>

Rendering fixes for Qtopia.

Make the focus ring work with line breaks (until we have QPainterPath::simplify) and
call QStyle with better arguments when painting themed elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 09:55:28 +0000 (09:55 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* FormData::flatten does not include to be uploaded files. Create our own QIODevice
  for the QNetworkAccessManager and feed the complete content of the FormData* to
  the (HTTP) backend.
* Try to optimize the ::readData implementation to fill the buffer as best as possible

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHolger Hans Peter Freyther <holger.freyther@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 09:55:08 +0000 (09:55 +0000)]
Holger Hans Peter Freyther <holger.freyther@trolltech.com>

* Coding-Style fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMichael Brasser <michael.brasser@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 09:48:22 +0000 (09:48 +0000)]
Michael Brasser <michael.brasser@trolltech.com>

use PopupClient's font for popup menu. Otherwise, in Qtopia, the popup's font is much bigger (QApplication::font()?) and the text doesn't fit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBenjamin Meyer <bmeyer@trolltech.com>
hausmann@webkit.org [Wed, 23 Jan 2008 09:44:09 +0000 (09:44 +0000)]
Benjamin Meyer <bmeyer@trolltech.com>

Tweak key presses even to match commonly expected behavior
- space key == page down
- page down moved down not a page, but slightly less then a page so you don't loose your spot when reading.
- Use font height rather then a hard coded "10" for left, right, up, down
- Ctrl-Up moves to the top of the page
- Ctrl-Down move to the bottom of the page
- Backspace == GoBack
- Shift-Backspace == GoForward

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29731 268f45cc-cd09-0410-ab3c-d52691b4dbfc