15 years ago2007-12-05 Michael Natterer <mitch@imendio.com>
alp@webkit.org [Wed, 5 Dec 2007 12:35:47 +0000 (12:35 +0000)]
2007-12-05  Michael Natterer  <mitch@imendio.com>

        Reviewed by Alp Toker.

        * WebView/webkitwebview.cpp
        * WebCoreSupport/ChromeClientGtk.cpp
        * WebCoreSupport/FrameLoaderClientGtk.cpp: canonicalize signal names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
mitz@apple.com [Wed, 5 Dec 2007 08:26:21 +0000 (08:26 +0000)]
    Reviewed by Adam Roben.

        - adding a test for http://bugs.webkit.org/show_bug.cgi?id=16097

        * fast/dom/ImageDocument-image-deletion-expected.txt: Added.
        * fast/dom/ImageDocument-image-deletion.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix gtk build
oliver@apple.com [Wed, 5 Dec 2007 04:47:32 +0000 (04:47 +0000)]
Fix gtk build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMerge TCMalloc r38
oliver@apple.com [Wed, 5 Dec 2007 03:58:41 +0000 (03:58 +0000)]
Merge TCMalloc r38

Reviewed by Mark Rowe and Geoff Garen.

It also result in a performance progression between 0.5% and
0.9% depending on the test, however most if not all of this
gain will be consumed by the overhead involved in the later
change to release memory to the system.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 5 Dec 2007 02:48:16 +0000 (02:48 +0000)]
2007-12-04  Alp Toker  <alp@atoker.com>

        Potential GTK+ build fix for the glib-genmarshal issue.

        Split the glib-genmarshal qmake generator in two; one for the source
        file, another for the header.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Remove IWebScriptScope include.
andersca@apple.com [Wed, 5 Dec 2007 02:34:45 +0000 (02:34 +0000)]
    Remove IWebScriptScope include.

        * Drosera/win/DebuggerDocumentPlatform.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 5 Dec 2007 02:08:15 +0000 (02:08 +0000)]
2007-12-04  Alp Toker  <alp@atoker.com>

        GTK+ build fix.

        * platform/PlugInInfoStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
kdecker@apple.com [Wed, 5 Dec 2007 01:46:33 +0000 (01:46 +0000)]
    Reviewed by Anders.

        <rdar://problem/5629125> PluginInfoStore needs the ability to return the name of a plug-in for a given MIME type

        * page/mac/WebCoreViewFactory.h: Added pluginNameForMIMEType: method.
        * platform/PlugInInfoStore.h:
        * platform/gtk/TemporaryLinkStubs.cpp: Added stub version of pluginNameForMIMEType.
        * platform/mac/PlugInInfoStoreMac.mm:
        (WebCore::PlugInInfoStore::pluginNameForMIMEType): Added.
        * platform/qt/PlugInInfoStoreQt.cpp:
        (WebCore::PlugInInfoStore::pluginNameForMIMEType): Added stub version of pluginNameForMIMEType.
        * plugins/win/PlugInInfoStoreWin.cpp:
        (WebCore::PlugInInfoStore::pluginNameForMIMEType): Added stub version of pluginNameForMIMEType.

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory pluginNameForMIMEType:]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele@apple.com [Wed, 5 Dec 2007 01:08:54 +0000 (01:08 +0000)]

        Reviewed by Darin.

        Fix for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

        * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle):
        Adjust outline-offset so it doesn't extend beyond the border to interfere with typing


        Reviewed by Darin.

        Test for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges

        * fast/forms/textfield-outline.html: Added.
        * platform/mac/fast/forms/textfield-outline-expected.checksum: Added.
        * platform/mac/fast/forms/textfield-outline-expected.png: Added.
        * platform/mac/fast/forms/textfield-outline-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Provide API for setting the default storage quota per database origin
adachan@apple.com [Wed, 5 Dec 2007 01:05:00 +0000 (01:05 +0000)]
    Provide API for setting the default storage quota per database origin

        Reviewed by Jon.

        * Interfaces/IWebPreferencesPrivate.idl: added SPI to get/set default database quota
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings): default database quota is 5MB
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged): propagate default database quota change to WebCore settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Jon.
andersca@apple.com [Wed, 5 Dec 2007 00:46:38 +0000 (00:46 +0000)]
    Reviewed by Jon.

        Always call NPP_NewStream, NPP_DestroyStream and NPP_URLNotify for JavaScript
        result streams, even if the JavaScript expression threw an exception or returned undefined.
        This matches what Firefox does.

        * plugins/win/PluginStreamWin.cpp:
        Handle the result string being null, and set the correct NPReason if it is.

        * plugins/win/PluginViewWin.cpp:
        Always send the JavaScript stream, regardless of the result could be converted to a string or not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe
beidson@apple.com [Wed, 5 Dec 2007 00:30:12 +0000 (00:30 +0000)]
    Reviewed by Mark Rowe

        Tweaked the way we typedef and cast these objc_msgSend calls

        * WebView/WebView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Mark Rowe.
weinig@apple.com [Wed, 5 Dec 2007 00:23:55 +0000 (00:23 +0000)]
    Rubber stamped by Mark Rowe.

        Define CF as platform for mac and revert r28409

        * DumpRenderTree/DumpRenderTree.h:
        * DumpRenderTree/mac/DumpRenderTreeMac.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
weinig@apple.com [Wed, 5 Dec 2007 00:14:11 +0000 (00:14 +0000)]
    Reviewed by Adam Roben.

        Remove http/tests/incremental/frame-focus-before-load.html from the skipped list
        as it is no longer crashing. <rdar://problem/5507278>

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele@apple.com [Wed, 5 Dec 2007 00:08:37 +0000 (00:08 +0000)]

        Reviewed by Hyatt.

        Fix for <rdar://problem/5622464> controls should show up for audio element

        * css/html4.css: Added styles for audio controls.  This will need to be refined, since we may want a different look for audio controls.
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::attributeChanged): When the controls attribute changes detach and reattach if necessary.
        (WebCore::HTMLMediaElement::rendererIsNeeded): Added.
        (WebCore::HTMLMediaElement::createRenderer): Added.  Uses RenderMedia.
        * html/HTMLMediaElement.h:
        * rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Added constructor that doesn't take intrinsic size.
        * rendering/RenderMedia.h:


        Reviewed by Hyatt.

        Test for <rdar://problem/5622464> controls should show up for audio element

        * media/audio-controls-rendering.html: Added.
        * platform/mac/media/audio-controls-rendering-expected.checksum: Added.
        * platform/mac/media/audio-controls-rendering-expected.png: Added.
        * platform/mac/media/audio-controls-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady Eidson (with help from Mark Rowe)
sullivan@apple.com [Wed, 5 Dec 2007 00:01:35 +0000 (00:01 +0000)]
    Reviewed by Brady Eidson (with help from Mark Rowe)

        Fixed return values for unsigned-long-long delegate methods

        * WebView/WebView.mm:
        redid the change that Brady did at home over the weekend but forgot to check in

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
andersca@apple.com [Tue, 4 Dec 2007 23:53:04 +0000 (23:53 +0000)]

        Reviewed by Sam.

        Make isSafeScript const.

        * kjs/JSGlobalObject.h:


        Reviewed by Sam.

        Add isSafeScript(const JSGlobalObject*) so we won't get the JSGlobalObject
        implementation, which always returns true(!).

        * bindings/js/kjs_window.cpp:
        Make the static isSafeScript method take two JSGlobalObjects.

        * bindings/js/kjs_window.h:
        Implement isSafeScript and have it call the static method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Define CF as platform for windows.
weinig@apple.com [Tue, 4 Dec 2007 23:40:59 +0000 (23:40 +0000)]
    Define CF as platform for windows.

        Reviewed by Adam Roben.

        * DumpRenderTree/win/DumpRenderTreeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKit/win:
kmccullough@apple.com [Tue, 4 Dec 2007 23:19:16 +0000 (23:19 +0000)]

        Reviewed by Adam and Darin.

        - Fixed a crasher where the top of the stack was not updated correctly.
        And set the eol style on IWebScriptCallFrame.idl file.

        * Interfaces/IWebScriptCallFrame.idl:
        * WebScriptDebugger.cpp:


        Reviewed by Adam and Darin.

        - Removed a needless BSTR cleanup.

        * Drosera/win/DebuggerDocumentPlatform.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Hook up the authorAndUserStylesEnabled preference on Windows
aroben@apple.com [Tue, 4 Dec 2007 22:54:37 +0000 (22:54 +0000)]
 Hook up the authorAndUserStylesEnabled preference on Windows


         Hook up the authorAndUserStylesEnabled preference

         This is the Windows counterpart of r28071.

         Reviewed by Maciej.

         * Interfaces/IWebPreferencesPrivate.idl: Added new method
         * WebPreferenceKeysPrivate.h: Added a new preference key.
         * WebPreferences.cpp:
         (WebPreferences::initializeDefaultSettings): Set the default for the
         new preference.
         (WebPreferences::setAuthorAndUserStylesEnabled): Added.
         (WebPreferences::authorAndUserStylesEnabled): Added.
         * WebPreferences.h:
         * WebView.cpp:
         (WebView::notifyPreferencesChanged): Communicate the new preference
         down to WebCore::Settings.


         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT

         Reviewed by Maciej.

         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.


         Remove a now-passing test from the Windows Skipped file

         Reviewed by Maciej.

         * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make the implementation of Frame::setNeedsReapplyStyles cross-platform
aroben@apple.com [Tue, 4 Dec 2007 22:52:47 +0000 (22:52 +0000)]
 Make the implementation of Frame::setNeedsReapplyStyles cross-platform


         Make the implementation of Frame::setNeedsReapplyStyles cross-platform

         Reviewed by Hyatt.

         No change in functionality.

         * page/Frame.cpp:
         (WebCore::Frame::setNeedsReapplyStyles): Added. Invalidates the
         FrameView so that FrameView::layout will be called, which ends up
         calling reapplyStyles.
         (WebCore::Frame::needsReapplyStyles): Added.
         (WebCore::Frame::reapplyStyles): Renamed from reparseConfiguration.
         * page/Frame.h:
         * page/FramePrivate.h: Added new boolean member.
         * page/FrameView.cpp:
         (WebCore::FrameView::layout): Call Frame::reapplyStyles if needed.
         (WebCore::FrameView::needsLayout): Say that we need layout if the
         Frame needs styles reapplied.
         * page/mac/WebCoreFrameBridge.h: Removed setNeedsReapplyStyles.
         * page/mac/WebCoreFrameBridge.mm:
         (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): Updated for

         * bridge/win/FrameWin.cpp: Removed Frame::setNeedsReapplyStyles.
         * page/gtk/FrameGtk.cpp: Ditto.
         * page/mac/FrameMac.mm: Ditto.
         * page/qt/FrameQt.cpp: Ditto.
         * platform/wx/TemporaryLinkStubs.cpp: Ditto.


         Remove -[WebFrameBridge setNeedsReapplyStyles]

         This functionality is now WebCore's responsibility.

         Reviewed by Hyatt.

         * WebCoreSupport/WebFrameBridge.mm:
         * WebKit.order:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 4 Dec 2007 22:28:06 +0000 (22:28 +0000)]
2007-12-04  Alp Toker  <alp@atoker.com>

        Prospective Win DRT build fix.

        * DumpRenderTree/DumpRenderTree.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
antti@apple.com [Tue, 4 Dec 2007 21:46:26 +0000 (21:46 +0000)]
    Reviewed by Adele.

        Pass intrinsic size to the base class.

        * rendering/RenderMedia.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Tue, 4 Dec 2007 21:12:34 +0000 (21:12 +0000)]
2007-12-04  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Ollie.

        Don't crash if our JavaPlugin DLL can't be found

        * WebFrame.cpp:
        (WebFrame::createJavaAppletWidget): Added null check

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin
sullivan@apple.com [Tue, 4 Dec 2007 21:11:38 +0000 (21:11 +0000)]
    Reviewed by Darin

        Added deleteOrigin: SPI, which isn't fully implemented

        * Storage/WebDatabaseManagerPrivate.h:
        * Storage/WebDatabaseManager.mm:
        (-[WebDatabaseManager deleteOrigin:]):
        just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
adele@apple.com [Tue, 4 Dec 2007 21:11:21 +0000 (21:11 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/5578209> REGRESSION: Crash in WebCore::DeprecatedValueListImpl::Private::copyList when going back on zoomerang.com/survey

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation):
          When the new url is exactly the same as the old url, don't treat it like a fragment navigation, since its going to cause a reload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
timothy@apple.com [Tue, 4 Dec 2007 20:26:39 +0000 (20:26 +0000)]
    Reviewed by Mark Rowe.

        Remove a check for early versions of Leopard CFNetwork now that
        Leopard has shipped.

        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Kevin Decker <kdecker@apple.com>
kdecker@apple.com [Tue, 4 Dec 2007 19:56:50 +0000 (19:56 +0000)]
2007-12-04  Kevin Decker  <kdecker@apple.com>

        Reviewed by Darin.

        Revised fix for: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang

        This fix is exactly the same as chageset 28359 with the exception of an added early return in
        updateAndSetWindow to cover the additional case of when a plug-in isn't drawable.

        The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would
        only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with
        Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context
        regardless of whether or not it actually needs to draw.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned
        down an ASSERT that was too strict.
        (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins
        which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow()
        function. Also tweaked a comment and added an early return if the plug-in can't draw.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin@apple.com [Tue, 4 Dec 2007 19:47:13 +0000 (19:47 +0000)]

        Reviewed by Kevin Decker.

        - added an assertion for a situation that leads to a Safari assertion:
          a commit that is not followed by a load completion

        - removed some unneeded FrameLoader stuff -- maybe some day we'll get this
          class cut down to size

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader): Added boolean for assertion.
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Added code to assert
        that we already sent a commit before sending a complete.
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Call
        client directly instead of indirecting through a function.
        (WebCore::FrameLoader::loadItem): Ditto.
        (WebCore::FrameLoader::goToItem): Ditto.
        (WebCore::FrameLoader::addHistoryForCurrentLocation): Get the private browsing
        state from Settings instead of FrameLoaderClient. Also call client directly
        instead of indirecting through a function.
        (WebCore::FrameLoader::updateHistoryForReload): Call client directly instead
        of indirecting through a function.
        (WebCore::FrameLoader::dispatchDidCommitLoad): Added code to assert
        that we did not yet send a commit and set the flag that will be used to check
        that we don't do this twice in a row without an intervening completion call.

        * loader/FrameLoader.h: Added a boolean for the assertion. Removed six
        now-unneeded functions.

        * loader/FrameLoaderClient.h: Removed now-unneeded privateBrowsingEnabled function.

        * loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willCacheResponse): Get
        the private browsing state from Settings instead of FrameLoaderClient.

        * svg/graphics/SVGImageEmptyClients.h: Removed obsolete privateBrowsingEnabled.


        Reviewed by Kevin Decker.

        * WebCoreSupport/FrameLoaderClientGtk.cpp: Removed obsolete privateBrowsingEnabled.
        * WebCoreSupport/FrameLoaderClientGtk.h: Ditto.


        Reviewed by Kevin Decker.

        * WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
        * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
        * WebKit.order: Ditto.


        Reviewed by Kevin Decker.

        * WebCoreSupport/FrameLoaderClientQt.cpp: Removed obsolete privateBrowsingEnabled.
        * WebCoreSupport/FrameLoaderClientQt.h: Ditto.


        Reviewed by Kevin Decker.

        * WebFrame.cpp: Removed obsolete privateBrowsingEnabled.
        * WebFrame.h: Ditto.


        Reviewed by Kevin Decker.

        * WebKitSupport/FrameLoaderClientWx.cpp: Removed obsolete privateBrowsingEnabled.
        * WebKitSupport/FrameLoaderClientWx.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdate StringsNotToBeLocalized.txt.
timothy@apple.com [Tue, 4 Dec 2007 19:46:45 +0000 (19:46 +0000)]
Update StringsNotToBeLocalized.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
antti@apple.com [Tue, 4 Dec 2007 19:21:09 +0000 (19:21 +0000)]

        Reviewed by Adele.

        Fix <rdar://problem/5624802>
        Controller displays outside of <video> element when width and height aren't specified

        - Explicitly adjust size of the controls tree root.
        - Switch RenderMedia base class back to RenderReplaced. It is easier to manage the shadow tree
          by hand. This also allows better code sharing with other replaced element classes.
        - Move duplicated layout and painting code from subclasses up to RenderReplaced.

        Test: media/video-controls-rendering.html

        * rendering/RenderHTMLCanvas.cpp:
        * rendering/RenderHTMLCanvas.h:
            Share code.
        * rendering/RenderImage.cpp:
        * rendering/RenderImage.h:
            Share code.
        * rendering/RenderMedia.cpp:
            Add a subclass just to get through encapsulation to use setParent().
            Move initialization to the constructor.
            Resize and layout the controller root by hand.
            Support one child renderer for controls.
        * rendering/RenderMedia.h:
            Switch base class to RenderReplaced, delete the now unnecessary stuff.
        * rendering/RenderReplaced.cpp:
        * rendering/RenderReplaced.h:
            Share code.
        * rendering/RenderVideo.cpp:
            Simplify, just request relayout.
        * rendering/RenderVideo.h:
            Share code.


        Reviewed by Adele.

        Test for <rdar://problem/5624802>
        Controller displays outside of <video> element when width and height aren't specified

        * media/remove-from-document.html: Improve coverage by doing relayout before finishing.
        * media/video-controls-rendering.html: Added.
        * platform/mac/media/video-controls-rendering-expected.checksum: Added.
        * platform/mac/media/video-controls-rendering-expected.png: Added.
        * platform/mac/media/video-controls-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Michael Natterer <mitch@imendio.com>
alp@webkit.org [Tue, 4 Dec 2007 19:10:19 +0000 (19:10 +0000)]
2007-12-04  Michael Natterer  <mitch@imendio.com>

        Reviewed by Alp Toker.

        * WebCore.pro: fix build of webkit-marshal by building the
        functions into a separate .cpp file instead of including them in
        the header. This way we can use the marshallers from more than one
        file without using bad hacks.

        Add the generated sources directory to DEPENDPATH.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin@apple.com [Tue, 4 Dec 2007 19:08:28 +0000 (19:08 +0000)]

        Reviewed by Geoff.

        - fix first part of http://bugs.webkit.org/show_bug.cgi?id=16220
          <rdar://problem/5625221> Crash opening www.news.com (CNet)

        Test: fast/js/regexp-overflow.html

        * pcre/pcre_compile.cpp:
        (calculateCompiledPatternLengthAndFlags): Add room for the additional BRA/KET that
        was generated in the compile code but not taken into account here.


        Reviewed by Geoff.

        - test for first part of http://bugs.webkit.org/show_bug.cgi?id=16220
          <rdar://problem/5625221> Crash opening www.news.com (CNet)

        * fast/js/regexp-overflow-expected.txt: Updated.
        * fast/js/resources/regexp-overflow.js: Added test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix.
sfalken@apple.com [Tue, 4 Dec 2007 18:28:30 +0000 (18:28 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows build fix
aroben@apple.com [Tue, 4 Dec 2007 18:27:48 +0000 (18:27 +0000)]
    Windows build fix

        * WebScriptCallFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 4 Dec 2007 17:58:18 +0000 (17:58 +0000)]
2007-12-04  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Link to Planet WebKit.

        * nav.inc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
alp@webkit.org [Tue, 4 Dec 2007 16:50:38 +0000 (16:50 +0000)]
2007-12-04  Pierre-Luc Beaudoin  <pierre-luc.beaudoin@collabora.co.uk>

        Reviewed by Alp Toker.

        [gtk] Implement media support in GTK backend

        This implements the media tags of HTML5 on the GTK+ port based on the
        Mac port. Media tests pass although some tests required a small modifications:
        As per the HTML5 spec, the loading of the clip should start only after
        all script are done.  But in the case of the tests, the loading starts
        before some callbacks get registered.  This has been discussed with
        Antti Koivisto, and the tests should be updated.

        There is only one known issue: one time in 10 tries, loading a buffered
        clip will never end buffering.  The buffering will stall at 97% for no
        apparent reasons.  Reloading the page usually works around the problem.
        On the GStreamer side, some codecs don't return correct values, therefore
        they make the tests fail.  For instance H.264 will make the video-end
        test fail.  This should be fixed in GStreamer 0.10.15.

        This version displays video in a pop up window.  A place holder is drawn
        on the page where the video should appear.

        By default, it is turned off in WebCore.pro until GStreamer/X
        detection issues are sorted out.

        * WebCore.pro:
        Disable video for now
        * platform/Logging.cpp:
        * platform/Logging.h:
        Added a logging level for Media stuff
        * platform/graphics/Movie.cpp:
        * platform/graphics/gtk/MoviePrivateGStreamer.cpp: Added.
        * platform/graphics/gtk/MoviePrivateGStreamer.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Tue, 4 Dec 2007 14:12:16 +0000 (14:12 +0000)]
2007-12-04  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        Fix a regression in key press propagation in r28386.

        Fix indentation (was off by two spaces).

        * WebView/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd the missing ChangeLog entries for r28349.
zecke@webkit.org [Tue, 4 Dec 2007 13:19:05 +0000 (13:19 +0000)]
Add the missing ChangeLog entries for r28349.

2007-12-04  Holger Hans Peter Freyther <holger.freyther@trolltech.com>

        Reviewed by Simon.

        * Implement the InspectorClient for the Qt port
        * It does not support highlighting of nodes yet
        * Use QRC to open the internal page. The important thing is the
        '/' in the URL to make WebCore::Document::completeURL behave the
        way we want.
        * To make the InspectorClient work we will have to mark qrc as secure.

        * WebCore.pro:
        * loader/FrameLoader.cpp:
        * page/inspector/WebKit.qrc: Added.

2007-12-04  Holger Hans Peter Freyther <holger.freyther@trolltech.com>

        Reviewed by Simon.

        * Implement the InspectorClient for the Qt port
        * It does not support highlighting of nodes yet
        * Use QRC to open the internal page. The important thing is the
        '/' in the URL to make WebCore::Document::completeURL behave the
        way we want.
        * To make the InspectorClient work we will have to mark qrc as secure.

        * Api/qwebpage.cpp:
        * Api/qwebpage.h:
        * WebCoreSupport/InspectorClientQt.cpp:
        * WebCoreSupport/InspectorClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Tue, 4 Dec 2007 13:14:40 +0000 (13:14 +0000)]
2007-12-04  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        [GTK] Use GtkBindingSet to make key bindings user-configurable

        This patch doesn't cover the full range of bindings, only the ones
        that seem obviously correct and have clear public API.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::handleKeypress): do not handle clipboard operations and select-all
        * WebView/webkitwebview.cpp: add cut, copy, paste and select-all signals and allow binding sets (issue #15911 and #16144)
        * WebView/webkitwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 4 Dec 2007 12:34:44 +0000 (12:34 +0000)]
2007-12-04  Alp Toker  <alp@atoker.com>

        Fix a clobbered copyright header.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Xan Lopez <xan@gnome.org>
alp@webkit.org [Tue, 4 Dec 2007 12:16:38 +0000 (12:16 +0000)]
2007-12-04  Xan Lopez  <xan@gnome.org>

        Reviewed by Alp Toker.

        GTK port needs DumpRenderTree implementation

        Start work on the GTK+ DRT.

        This does not work yet, and there are a few lingering style issues
        (nothing major) but this patch has been stuck in the bug tracker for
        too long already.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRoll out r28359 as it causes serious problems with tabbed browsing in Safari when...
mrowe@apple.com [Tue, 4 Dec 2007 08:40:47 +0000 (08:40 +0000)]
Roll out r28359 as it causes serious problems with tabbed browsing in Safari when viewing pages containing plugins (<rdar://problem/5627529>).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 4 Dec 2007 08:31:07 +0000 (08:31 +0000)]
2007-12-04  Alp Toker  <alp@atoker.com>

        Rubber stamped by Mark Rowe.

        Remove two unused variables to silence warnings.

        * html/CanvasRenderingContext2D.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubberstamped by Tim.
pewtermoose@webkit.org [Tue, 4 Dec 2007 07:35:18 +0000 (07:35 +0000)]
    Rubberstamped by Tim.

        Make the bullets lickable.

        * wwwroot/planetwebkit.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
pewtermoose@webkit.org [Tue, 4 Dec 2007 07:19:32 +0000 (07:19 +0000)]
    Reviewed by Adam.

        Make it sexy with awesome icon and tweaks from Tim.

        * templates/index.html.tmpl:
        * wwwroot/ie.css: Added.
        * wwwroot/images/ie-nav-blue.png: Added.
        * wwwroot/planetwebkit.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdded bug reference.
ddkilzer@apple.com [Tue, 4 Dec 2007 06:59:50 +0000 (06:59 +0000)]
Added bug reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Move JavaScriptCore thread testing code to pthread specific directory
weinig@apple.com [Tue, 4 Dec 2007 05:17:09 +0000 (05:17 +0000)]
    Move JavaScriptCore thread testing code to pthread specific directory
        and remove the dependance on CoreFoundation by using WTF::HashSet.

        Reviewed by Geoff and Oliver.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
        * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
        * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
        * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
        * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
        * DumpRenderTree/pthreads: Added.
        * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoVersioning.
aroben@apple.com [Tue, 4 Dec 2007 04:57:32 +0000 (04:57 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-03 Andrew Bonventre <andybons@google.com>
mitz@apple.com [Tue, 4 Dec 2007 01:08:26 +0000 (01:08 +0000)]
2007-12-03  Andrew Bonventre  <andybons@google.com>

        Reviewed by Darin Adler.

        * Drosera/debugger.js: Fixed javascript error where document property
        should have been used instead of contentDocument in switchFunction that
        was breaking the select symbol dropdown menu.  This is because
        window.frames will return a Window object and not a frame object like
        the author was originally expecting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Tue, 4 Dec 2007 00:28:02 +0000 (00:28 +0000)]

        Reviewed by Darin Adler.

        - fix <rdar://problem/5134044> fast/frames/frame-src-attribute.html fails on Windows

        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::visibleWidth): Do not return negative values.
        (WebCore::ScrollView::visibleHeight): Ditto.


        Reviewed by Darin Adler.

        - remove passing test

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Tue, 4 Dec 2007 00:25:38 +0000 (00:25 +0000)]

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

        Test: fast/events/resize-subframe.html

        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::FrameViewPrivate): Added a timer used when
        deferring tasks that need to be done after layout.
        (WebCore::FrameView::layout): Moved the updating of widget positions,
        loading plug-ins and sending events queued up during layout into
        performPostLayoutTasks(). performPostLayoutTasks() is called after
        layout unless the layout was triggered by a previous layout's post-
        layout tasks. In the latter case, performPostLayoutTasks() is scheduled
        to run later.
        (WebCore::FrameView::performPostLayoutTasks): Performs work that needs
        to be done after layout but which can result in arbitrary code
        execution and therefore may re-invalidate the layout. This includes
        updating widget positions, loading plug-ins, and dispatching layout-
        related DOM events (scroll, overflow and resize).
        * page/FrameView.h:
        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm: Removed -sendResizeEvent since this
        is handled by FrameView now.


        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

        * WebView/webkitwebview.cpp: Remove the call to sendResizeEvent() since
        FrameView sends it now.


        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code
        that checked if the view had resized and sent the resize event, since
        FrameView sends resize events now.
        * WebView/WebHTMLViewInternal.h:


        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

        * WebView.cpp:
        (WebViewWndProc): Removed call to sendResizeEvent() since FrameView
        sends them now.


        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

        * fast/events/resize-subframe-expected.txt: Added.
        * fast/events/resize-subframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin@apple.com [Mon, 3 Dec 2007 22:56:42 +0000 (22:56 +0000)]

        Reviewed by Geoff.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15618
          <rdar://problem/5619353> REGRESSION: Stack overflow/crash in KJS::equal (15618)

        Test: fast/js/recursion-limit-equal.html

        * kjs/operations.cpp: (KJS::equal): Check the exception from toPrimitive.


        Reviewed by Geoff.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15618
          <rdar://problem/5619353> REGRESSION: Stack overflow/crash in KJS::equal (15618)

        * fast/js/recursion-limit-equal-expected.txt: Added.
        * fast/js/recursion-limit-equal.html: Added.
        * fast/js/resources/recursion-limit-equal.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKit/win:
kmccullough@apple.com [Mon, 3 Dec 2007 22:15:50 +0000 (22:15 +0000)]

        Reviewed by Adam.

        - <rdar://5618942> Drosera: Console window does not process everything
        - <rdar://5619005> Drosera: could be sped up by moving the
        WebScriptScope stuff into the WebScriptCallFrame.
        - Now the console can correctly process objects and does not receive
        notifications from JavaScriptCore about the JavaScript in Drosera's
        own process.

        * Interfaces/IWebScriptCallFrame.idl: Moved the variable lookup
        functions from WebScriptScope to here.
        * Interfaces/WebKit.idl: Removed WebScriptScope.
        * WebKit.vcproj/Interfaces.vcproj: Ditto.
        * WebKit.vcproj/WebKit.vcproj: Ditto.
        * WebKit.vcproj/WebKitGUID.vcproj: Ditto.
        * WebScriptCallFrame.cpp: Moved WebScriptScope functionality into here.
        (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Now
        returns a string value for things that are not strings.
        (WebScriptCallFrame::variableNames): Moved from WebScriptScope.
        (WebScriptCallFrame::valueForVariable): Moved from WebScriptScope.
        (WebScriptCallFrame::jsValueToString): Helper functions that converts
        any JSValue to a String.
        * WebScriptCallFrame.h: Moved WebScriptScope functionality into here.
        * WebScriptDebugger.cpp: Added nested guards so that Drosera does not
        receive notifications about JavaScript that Drosera is running just the
        JavaScript WebKit is running.
        * WebScriptDebugger.h: Ditto.
        * WebScriptScope.cpp: Removed.
        * WebScriptScope.h: Removed.


        Reviewed by Adam.

        - <rdar://5618942> Drosera: Console window does not process everything
        - <rdar://5619005> Drosera: could be sped up by moving the
        WebScriptScope stuff into the WebScriptCallFrame.
        - Now the console can correctly process objects and does not receive
        notifications from JavaScriptCore about the JavaScript in Drosera's
        own process.

        * Drosera/win/DebuggerDocumentPlatform.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix a copy-and-paste-o
mitz@apple.com [Mon, 3 Dec 2007 22:14:45 +0000 (22:14 +0000)]
    - fix a copy-and-paste-o

        * bindings/npruntime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCheck to see if we are building a debug root
slewis@apple.com [Mon, 3 Dec 2007 22:12:28 +0000 (22:12 +0000)]
Check to see if we are building a debug root

        * Scripts/check-for-global-initializers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
mitz@apple.com [Mon, 3 Dec 2007 22:07:43 +0000 (22:07 +0000)]

        Reviewed by Darin Adler.

        - fix an ASSERT when getIntIdentifier is called with 0 or -1

        * bindings/npruntime.cpp:
        (_NPN_GetIntIdentifier): We cannot use the hashmap for 0 and -1 since
        they are the empty value and the deleted value. Instead, keep the
        identifiers for those two integers in a static array.


        Reviewed by Darin Adler.

        - added a testGetIntIdentifier() method to TestNetscapePlugIn

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:


        Reviewed by Darin Adler.

        - added a test of the behavior of getIntIdentifier with the integers
          0 and -1

        * plugins/getintidentifier-special-values-expected.txt: Added.
        * plugins/getintidentifier-special-values.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
timothy@apple.com [Mon, 3 Dec 2007 21:43:29 +0000 (21:43 +0000)]
    Reviewed by Darin.

        Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations
        to return a pointer to the implementation struct instead of a copy of the struct. This changes
        all of the callers to dereference the pointer to access the struct fields.

        * Plugins/WebNullPluginView.mm:
        (-[WebNullPluginView reportFailure]):
        * WebCoreSupport/WebFrameBridge.mm:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebView.mm:
        (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the build, move JSDOMWindow.h to the Copy Generated Headers phase.
timothy@apple.com [Mon, 3 Dec 2007 21:37:58 +0000 (21:37 +0000)]
Fix the build, move JSDOMWindow.h to the Copy Generated Headers phase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
rwlbuis@webkit.org [Mon, 3 Dec 2007 21:25:27 +0000 (21:25 +0000)]
    Reviewed by Darin.

        Text decorations do not respect "visibility" property

        Only paint decorations if visibility is "visible".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady Eidson.
timothy@apple.com [Mon, 3 Dec 2007 20:35:53 +0000 (20:35 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/5539913> 188 crashes in WebViewGetFrameLoadDelegateImplementations
        <rdar://problem/5586095> CrashTracer: [USER] 5000+ crashes in Safari and Dashboard in dispatchDidFailLoading
        <rdar://problem/5607081> CrashTracer: [USER] 2150 crashes in Safari at com.apple.WebKit:
        WebViewGetResourceLoadDelegateImplementations + 28

        * WebView/WebView.mm:
        (-[WebView _cacheResourceLoadDelegateImplementations]): If the delegate is nil, bzero the
        implementation cache. This just prevents us from calling getMethod() multiple times just to zero.
        (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.
        (WebViewGetResourceLoadDelegateImplementations): Return a zeroed implementations struct
        if the WebView is nil. This fixes the crashes.
        (WebViewGetFrameLoadDelegateImplementations): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Removing passing tests
alice.liu@apple.com [Mon, 3 Dec 2007 20:24:22 +0000 (20:24 +0000)]
    Removing passing tests

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix build.
sfalken@apple.com [Mon, 3 Dec 2007 19:55:44 +0000 (19:55 +0000)]
    Fix build.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoi Reviewed by Darin.
kdecker@apple.com [Mon, 3 Dec 2007 19:47:21 +0000 (19:47 +0000)]
i        Reviewed by Darin.

        Fixed: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang

        The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would only call into the NPP_SetWindow()
        function when we tell the plug-in to draw. This created havoc with Flash because Flash expects the browser to call NPP_SetWindow()
        and provide a valid graphics context regardless of whether or not it actually needs to draw.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned down an ASSERT that was too strict.
        (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins which would sometimes
        altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by David.
zimmermann@webkit.org [Mon, 3 Dec 2007 18:57:23 +0000 (18:57 +0000)]
Reviewed by David.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=15645
Don't allow selectors to interfere with the SVG shadow tree (<use> internal non-exposed tree).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRubber stamped by Mark.
zimmermann@webkit.org [Mon, 3 Dec 2007 18:44:25 +0000 (18:44 +0000)]
Rubber stamped by Mark.
Commit missing layout test results from my last commit (fix for bug 15403)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-03 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
zecke@webkit.org [Mon, 3 Dec 2007 18:09:35 +0000 (18:09 +0000)]
2007-12-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>

        Rubber stamped by Mark.

        Always include config.h at the beginning of the file.

        * Api/qwebsettings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Mon, 3 Dec 2007 18:09:34 +0000 (18:09 +0000)]

        Reviewed by Adam Roben.

        - fix <rdar://problem/5538651> REGRESSSION: domfuzz: null deref in WebCore::Document::canReplaceChild

        Test: fast/dom/Document/replaceChild-null-oldChild.html

        * dom/Document.cpp:


        Reviewed by Adam Roben.

        - test for <rdar://problem/5538651> REGRESSSION: domfuzz: null deref in WebCore::Document::canReplaceChild

        * fast/dom/Document/replaceChild-null-oldChild-expected.txt: Added.
        * fast/dom/Document/replaceChild-null-oldChild.html: Added.
        * fast/dom/Document/resources/replaceChild-null-oldChild.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Avoid crashes by making sure everything is layouted before
zecke@webkit.org [Mon, 3 Dec 2007 18:05:11 +0000 (18:05 +0000)]
* Avoid crashes by making sure everything is layouted before
  we start painting. This avoids a crash in Widget::invalidateRect
  because QPainter::begin would fail
* The QWebFrame::layout() methods and calls are left untouched because
  this would be an API decision.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Implement GraphicsContext::fillRoundedRect similiar to the
zecke@webkit.org [Mon, 3 Dec 2007 18:02:59 +0000 (18:02 +0000)]
* Implement GraphicsContext::fillRoundedRect similiar to the
  CoreGraphics implementation only addPath is not called this
  seems to be only needed for CoreGraphics.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* SubClass QWebPage to handle hide and close events.
zecke@webkit.org [Mon, 3 Dec 2007 18:01:56 +0000 (18:01 +0000)]
* SubClass QWebPage to handle hide and close events.
* Forward these events to the InspectorController
* The other options would have been using an eventFilter
  on the webpage and making InspectorClient a QObject or
  creating a QObject Observer.
* Provide a simple QWebPage* createWindow implementation. This is needed
  to make FrameLoaderClientQt::dispatchCreatePage stop crashing in the case
  of the inspector client.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Coding Style fixes
zecke@webkit.org [Mon, 3 Dec 2007 18:01:10 +0000 (18:01 +0000)]
* Coding Style fixes

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Implement the InspectorClient for the Qt port
zecke@webkit.org [Mon, 3 Dec 2007 18:00:14 +0000 (18:00 +0000)]
* Implement the InspectorClient for the Qt port
* It does not support highlighting of nodes yet
* Use QRC to open the internal page. The important thing is the
 '/' in the URL to make WebCore::Document::completeURL behave the
  way we want.
* To make the InspectorClient work we will have to mark qrc as secure.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Allow adding the Inspect ContextMenuItem to our Menu
zecke@webkit.org [Mon, 3 Dec 2007 17:58:23 +0000 (17:58 +0000)]
* Allow adding the Inspect ContextMenuItem to our Menu
* Open the Inspector when Inspect was activated. This requires
  that we keep the innerNonSharedNode from the HitTest around. This
  forces us to include <wtf/RefPtr.h> in the private header. It is
  the first non Qt header but should be okay.

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago* Add the Developer Extras to the WebAttribute and propagate it
zecke@webkit.org [Mon, 3 Dec 2007 17:57:04 +0000 (17:57 +0000)]
* Add the Developer Extras to the WebAttribute and propagate it
  to WebCore::Settings. This will enable the Inspect Element menu item
* CodingStyle fixes in QWebSettings
* Enable the Developer Extras in the QtLauncher

Signed-off-by: Simon
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin@apple.com [Mon, 3 Dec 2007 15:46:14 +0000 (15:46 +0000)]

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15848
          <rdar://problem/5619330> REGRESSION: Assertion failure viewing comments page on digg.com

        Test: fast/js/sparse-array.html

        * kjs/array_instance.cpp:
        (KJS::ArrayInstance::inlineGetOwnPropertySlot): Check sparse array cutoff before looking
        in hash map. Can't avoid the branch because we can't look for 0 in the hash.
        (KJS::ArrayInstance::deleteProperty): Ditto.


        Reviewed by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15848
          <rdar://problem/5619330> REGRESSION: Assertion failure viewing comments page on digg.com

        * fast/js/resources/sparse-array.js: Added.
        * fast/js/sparse-array-expected.txt: Added.
        * fast/js/sparse-array.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-03 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 3 Dec 2007 12:57:14 +0000 (12:57 +0000)]
2007-12-03  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Don't delete the decoder if it's already been created. The one we have
        is fine.

        Cairo image cleanups. Nothing substantial.

        Notify ImageObservers where appropriate.

        * platform/graphics/cairo/ImageCairo.cpp:
        * platform/graphics/cairo/ImageSourceCairo.cpp:
        * platform/graphics/gtk/ImageGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixed crash when rendering form elements with Qt 4.4
hausmann@webkit.org [Mon, 3 Dec 2007 12:04:31 +0000 (12:04 +0000)]
Fixed crash when rendering form elements with Qt 4.4

QPainter::device() is not guaranteed to return a QWidget, so do the safe "cast" with the
help of QPaintDevice::devType().
Also fall back to the QApplication::style() if we don't have a widget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
zecke@webkit.org [Mon, 3 Dec 2007 10:36:03 +0000 (10:36 +0000)]
2007-12-02  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>

        Reviewed by Sam Weinig.

        * Add FrameLoader::shouldTreatSchemeAsLocal which is similar to
        * Make use of FrameLoader::shouldTreatSchemeAsLocal in SecurityOrigin
        and do not hardcode "file". This is needed for the WebKit/qt port to make
        the Web Inspector work as it using the qrc protocol instead of file.

        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * platform/SecurityOrigin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
zecke@webkit.org [Mon, 3 Dec 2007 10:34:17 +0000 (10:34 +0000)]
2007-12-02  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>

        Rubber stamped by Sam Weinig.

        Only add applewebdata to the localSchemes when building for the
        mac. This is in preparation of adding qrc for the Qt port there
        as well and http://bugs.webkit.org/show_bug.cgi?id=15938.

        According to Anders applewebdata is not used on the win port.

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
zecke@webkit.org [Mon, 3 Dec 2007 10:33:20 +0000 (10:33 +0000)]
2007-12-02  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>

        Rubber stamped by Sam Weinig.

        Fix a typo. It is contains and not containts

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-03 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Mon, 3 Dec 2007 09:25:45 +0000 (09:25 +0000)]
2007-12-03  Mark Rowe  <mrowe@apple.com>

        Speculative Windows build fix.

        * WebScriptCallFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-03 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Mon, 3 Dec 2007 09:19:26 +0000 (09:19 +0000)]
2007-12-03  Mark Rowe  <mrowe@apple.com>

        wx build fix.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
ap@webkit.org [Mon, 3 Dec 2007 09:10:04 +0000 (09:10 +0000)]
    Reviewed by Oliver.

        Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
        in a more fine-grained manner than eventSender.keyDown().

        * DumpRenderTree/win/EventSender.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Another speculative Windows build fix
aroben@apple.com [Mon, 3 Dec 2007 09:05:06 +0000 (09:05 +0000)]
    Another speculative Windows build fix

        * WebScriptCallFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-12-03 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 3 Dec 2007 08:58:06 +0000 (08:58 +0000)]
2007-12-03  Alp Toker  <alp@atoker.com>

        Add another missing DEPENDPATH.

        Noticed when fixing the build.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Speculative Windows build fix
aroben@apple.com [Mon, 3 Dec 2007 08:52:44 +0000 (08:52 +0000)]
    Speculative Windows build fix

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Speculative Windows build fix
aroben@apple.com [Mon, 3 Dec 2007 08:43:56 +0000 (08:43 +0000)]
    Speculative Windows build fix

        * WebFrame.cpp:
        * WebScriptDebugger.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Removed unnecessary and possibly incorrect #include from my last
ggaren@apple.com [Mon, 3 Dec 2007 08:13:00 +0000 (08:13 +0000)]
    Removed unnecessary and possibly incorrect #include from my last

        * Api/qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago GTK Build fix: get globalExec from the right place.
ggaren@apple.com [Mon, 3 Dec 2007 08:10:06 +0000 (08:10 +0000)]
    GTK Build fix: get globalExec from the right place.

        * WebView/webkitwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Qt build fix: Get globalExec() from the right place.
ggaren@apple.com [Mon, 3 Dec 2007 08:06:50 +0000 (08:06 +0000)]
    Qt build fix: Get globalExec() from the right place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix: added symbols to the right .exp file.
ggaren@apple.com [Mon, 3 Dec 2007 08:02:04 +0000 (08:02 +0000)]
    Build fix: added symbols to the right .exp file.

        * WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix: added an #include.
ggaren@apple.com [Mon, 3 Dec 2007 07:53:03 +0000 (07:53 +0000)]
    Build fix: added an #include.

        * kjs/collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren@apple.com [Mon, 3 Dec 2007 07:43:29 +0000 (07:43 +0000)]

        Reviewed by Eric Seidel.

        Second step in refactoring JSGlobalObject: moved virtual functions from
        Interpreter to JSGlobalObject.

        Layout and JS tests pass. SunSpider reports a .7% speedup -- don't
        believe his lies.


        Reviewed by Eric Seidel.

        Updated to match the JavaScriptCore change to move virtual methods from
        Interpreter to JSGlobalObject.

        * JSRun.cpp:
        * JSRun.h:
        * JSValueWrapper.cpp:
        * JavaScriptGlue.cpp:


        Reviewed by Eric Seidel.

        Updated to match the JavaScriptCore change to move virtual methods from
        Interpreter to JSGlobalObject.

        Moved virtual ScriptInterpreter functions to Window.


        Reviewed by Eric Seidel.

        Updated to match the JavaScriptCore change to move virtual methods from
        Interpreter to JSGlobalObject.

        * WebView/WebFrame.mm:
        (-[WebFrame globalContext]): Use the toRef function instead of manually

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin@apple.com [Mon, 3 Dec 2007 04:57:59 +0000 (04:57 +0000)]

        Reviewed by Mitz.

        - fix <rdar://problem/5601995> Hang/crash on http://ebay-uk.custhelp.com/

        There were two problems here:

            1) Incorrect HTMLCollection behavior led to us trying to insert a
               new row inside an existing row instead of next to it. The fix for
               this is to make HTMLCollection work better for table-related

            2) HTMLTableRowElement::insertCell would return a bad pointer if
               the insertion failed. The code should have failed, but not crashed,
               so it's worth fixing that too.

        While fixing the HTMLCollection issues, I did some clean-up of that
        class and its derived classes.

        Test: fast/dom/HTMLTableElement/rows.html
        Test: fast/dom/HTMLTableElement/tBodies.html
        Test: fast/dom/HTMLTableRowElement/cells.html
        Test: fast/dom/HTMLTableRowElement/insertCell.html
        Test: fast/dom/HTMLTableSectionElement/rows.html

        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::toJS): Updated because collectionType() was renamed to type().

        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::HTMLCollection): Updated for data member name
        changes. Also added a protected constructor for use by derived classes
        that pass in a CollectionInfo.
        (WebCore::HTMLCollection::CollectionInfo::copyCacheMap): Moved out of
        the header.
        (WebCore::isTableSection): Added.
        (WebCore::HTMLCollection::itemAfter): Renamed from traverseNextItem,
        because the old name was grammatically incorrect and thus a bit confusing.
        Changed to operate on Element* instead of Node*, and use 0 to start
        rather than passing in the base node (required since the base node can be
        a document, which is not an element). Generalized the code that made
        NodeChildren not descend into deeper descendants so it can be used for
        TRCells, TSectionRows, TableTBodies, and TableRows. Reformatted the
        switch statement and got rid of the "found" boolean since we can just
        return when we find something. Got rid of the default case, and instead
        listed all the enum values. Also changed to use a for loop for clarity.
        (WebCore::HTMLCollection::calcLength): Updated for itemAfter changes.
        (WebCore::HTMLCollection::item): Ditto.
        (WebCore::HTMLCollection::nextItem): Ditto.
        (WebCore::HTMLCollection::checkForNameMatch): Updated to take an Element
        instead of a Node pointer.
        (WebCore::HTMLCollection::namedItem): More of the same.
        (WebCore::HTMLCollection::updateNameCache): Ditto.
        (WebCore::HTMLCollection::namedItems): Ditto.
        (WebCore::HTMLCollection::nextNamedItem): Ditto.
        (WebCore::HTMLCollection::tags): Ditto.

        * html/HTMLCollection.h: Added a type FormElements, so that the
        HTMLFormCollection would not have a type of DocImages, which is what
        it previously did. Changed the base parameter to be a PassRefPtr to
        make it clear we take ownership of it. Added a comment explaining
        why we should change the name CollectionInfo. Made a lot more members
        private instead of protected. Renamed traverseNextItem to itemAfter.
        Changed most functions to take Element* instead of Node*.

        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::formCollectionInfo): Added.
        (WebCore::HTMLFormCollection::HTMLFormCollection): Updated to pass
        collection info into the base class.
        (WebCore::HTMLFormCollection::calcLength): Updated to use base() so we
        don't need to get at m_base directly.
        (WebCore::HTMLFormCollection::item): Same, but for info().
        (WebCore::HTMLFormCollection::getNamedItem): Removed unused first
        (WebCore::HTMLFormCollection::getNamedFormItem): Got rid of unneeded
        checks that the base is still an element and still a form, since that's
        (WebCore::HTMLFormCollection::nextItem): Use info().
        (WebCore::HTMLFormCollection::nextNamedItemInternal): Node instead of
        Element, some name changes.
        (WebCore::HTMLFormCollection::namedItem): Update for changes elsewhere.
        (WebCore::HTMLFormCollection::nextNamedItem): Ditto, also rewrote loop
        to be much simpler.
        (WebCore::HTMLFormCollection::updateNameCache): More of the same.

        * html/HTMLFormCollection.h: Changed constructor to take an
        HTMLFormElement, using a PassRefPtr to communicate transfer of
        ownership. Made everything private instead of protected. Removed
        unneeded override of firstItem. Made getNamedItem and
        nextNamedItemInternal non-virtual. Removed unused first argument of
        getNamedItem. Added declaration of formCollectionInfo.

        * html/HTMLNameCollection.cpp:
        (WebCore::HTMLNameCollection::HTMLNameCollection): Updated to pass
        collection info into the base class.
        (WebCore::HTMLNameCollection::itemAfter): Reformatted a bit and
        changed into a for loop.

        * html/HTMLNameCollection.h: Updated for name changes. Made function
        private instead of public. Used PassRefPtr in constructor.

        * html/HTMLOptionsCollection.cpp:
        (WebCore::HTMLOptionsCollection::HTMLOptionsCollection): Updated to
        pass collection info into the base class.
        (WebCore::HTMLOptionsCollection::add): Updated for public/private
        changes in the base class.
        (WebCore::HTMLOptionsCollection::selectedIndex): Ditto.
        (WebCore::HTMLOptionsCollection::setSelectedIndex): Ditto.
        (WebCore::HTMLOptionsCollection::setLength): Ditto.

        * html/HTMLOptionsCollection.h: Changed constructor parameter to be a

        * html/HTMLTableRowElement.cpp:
        (WebCore::HTMLTableRowElement::insertCell): Changed code to use RefPtr
        and PassRefPtr since this creates a new object. This alone fixed the
        crash. Also cleaned up logic a bit to be more readable.

        * html/HTMLTableRowElement.h: Changed insertCell to return a PassRefPtr.
        Also reordered functions a bit to make things a little more logical and
        removed the unused ncols data member.

        * html/HTMLTableSectionElement.cpp:
        (WebCore::HTMLTableSectionElement::rows): Pass TSectionRows, not
        TableRows. This mistake was harmless before because TableRows and
        TSectionRows were handled identically inside HTMLCollection, but that is
        no longer the case with this fix.

        * bindings/scripts/CodeGeneratorJS.pm: Add an include to cope with the
        fact that HTMLOptionsCollection no longer includes HTMLOptionElement.
        I don't think this really should be a special case -- might be worth
        returning later to see if this can be optimized.


        Reviewed by Mitz.

        - tests for table-related HTMLCollection classes for misnested
          tables and for <rdar://problem/5601995> Hang/crash on http://ebay-uk.custhelp.com/

        * fast/dom/HTMLTableElement/resources: Added.
        * fast/dom/HTMLTableElement/resources/TEMPLATE.html: Added.
        * fast/dom/HTMLTableElement/resources/rows.js: Added.
        * fast/dom/HTMLTableElement/resources/tBodies.js: Added.
        * fast/dom/HTMLTableElement/rows-expected.txt: Added.
        * fast/dom/HTMLTableElement/rows.html: Added.
        * fast/dom/HTMLTableElement/tBodies-expected.txt: Added.
        * fast/dom/HTMLTableElement/tBodies.html: Added.
        * fast/dom/HTMLTableRowElement: Added.
        * fast/dom/HTMLTableRowElement/cells-expected.txt: Added.
        * fast/dom/HTMLTableRowElement/cells.html: Added.
        * fast/dom/HTMLTableRowElement/insertCell-expected.txt: Added.
        * fast/dom/HTMLTableRowElement/insertCell.html: Added.
        * fast/dom/HTMLTableRowElement/resources: Added.
        * fast/dom/HTMLTableRowElement/resources/TEMPLATE.html: Added.
        * fast/dom/HTMLTableRowElement/resources/cells.js: Added.
        * fast/dom/HTMLTableSectionElement: Added.
        * fast/dom/HTMLTableSectionElement/resources: Added.
        * fast/dom/HTMLTableSectionElement/resources/TEMPLATE.html: Added.
        * fast/dom/HTMLTableSectionElement/resources/rows.js: Added.
        * fast/dom/HTMLTableSectionElement/rows-expected.txt: Added.
        * fast/dom/HTMLTableSectionElement/rows.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * Scripts/do-webcore-rename: More planned renaming.
darin@apple.com [Mon, 3 Dec 2007 04:41:08 +0000 (04:41 +0000)]
    * Scripts/do-webcore-rename: More planned renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Adam.
zimmermann@webkit.org [Mon, 3 Dec 2007 01:05:25 +0000 (01:05 +0000)]
Reviewed by Adam.

RenderSVGViewportContainer sets wrong width/height.
Share code with RenderSVGContainer in a central calcBounds() function.

- svg/custom/use-css-events.svg (http://bugs.webkit.org/show_bug.cgi?id=15403)
- svg/custom/deep-dynamic-updates.svg
- svg/custom/use-clipped-hit.svg
- svg/custom/image-clipped-hit.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Anders.
weinig@apple.com [Sun, 2 Dec 2007 23:40:21 +0000 (23:40 +0000)]
    Rubber stamped by Anders.

        Use [NSURL absoluteString] instead of [NSURL description] in order to get
        more uniform results cross platform.

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[NSURL _drt_descriptionSuitableForTestResult]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Niko.
weinig@apple.com [Sun, 2 Dec 2007 23:32:42 +0000 (23:32 +0000)]
    Rubber stamped by Niko.

        Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
        * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
        * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
        * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin
beidson@apple.com [Sun, 2 Dec 2007 20:20:07 +0000 (20:20 +0000)]
    Reviewed by Darin

        databaseChanged notifications were being sent out on the database thread - they need to be on the main thread
        like all other notifications we send out!

        * platform/SecurityOriginData.cpp:
        (WebCore::SecurityOriginData::copy): Add a deep copy method, for when an object thread hops
        * platform/SecurityOriginData.h:

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): Add the origin/name pair to a queue
        (WebCore::DatabaseTracker::scheduleForNotification): Schedule to deliver this queue of notifications
          on the main thread
        (WebCore::DatabaseTracker::notifyDatabasesChanged): Deliver all notifications in the queue
        * storage/DatabaseTracker.h:

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::postflightAndCommit): scheduleNotifyDatabaseChanged() instead of "notify now!"
        (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28322 268f45cc-cd09-0410-ab3c-d52691b4dbfc