WebKit-https.git
8 years ago[BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute from...
commit-queue@webkit.org [Wed, 20 Feb 2013 15:24:26 +0000 (15:24 +0000)]
[BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute from element
https://bugs.webkit.org/show_bug.cgi?id=110235

Patch by Yongxin Dai <yodai@rim.com> on 2013-02-20
Reviewed by Yong Li.

PR #257207.

Read "data-blackberry-text-selection-handle-position" attribute from element and pass it along
with notifySelectionDetailsChanged(). If "data-blackberry-text-selection-handle-position" attribute
is specified in the element, the selection handle is always flipped to the required position.
along with selected text within element.

Reviewed Internally by Mike Fenton.

* Api/WebPageClient.h:
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::selectionContainerElement):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::elementHandlePositionAttribute):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::requestedSelectionHandlePosition):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
* WebKitSupport/SelectionHandler.h:
(SelectionHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Fix usage of HitTestRequest::RequestType
commit-queue@webkit.org [Wed, 20 Feb 2013 15:04:51 +0000 (15:04 +0000)]
[BlackBerry] Fix usage of HitTestRequest::RequestType
https://bugs.webkit.org/show_bug.cgi?id=110342

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-20
Reviewed by Carlos Garcia Campos.

Rename HitTestResult::* -> HitTestRequest::*
This was introduced by mistake in r142977.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 20 Feb 2013 14:24:57 +0000 (14:24 +0000)]
[EFL] Unreviewed gardening.

* platform/efl/TestExpectations: Marked touch event emulation test as failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] move most of the remaining mocks to TestRunner library
jochen@chromium.org [Wed, 20 Feb 2013 14:10:05 +0000 (14:10 +0000)]
[chromium] move most of the remaining mocks to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=110217

Reviewed by Nico Weber.

While most of the functionality provided by these mocks is also
available in the content module, there is no straight forward way to
inject the mock results required for layout tests.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner):
(WebTestRunner::WebTestProxy::geolocationClient):
(WebTestRunner::WebTestProxy::speechInputController):
(WebTestRunner::WebTestProxy::speechRecognizer):
(WebTestRunner::WebTestProxy::deviceOrientationClient):
(WebTestRunner::WebTestProxy::requestPointerLock):
(WebTestRunner::WebTestProxy::requestPointerUnlock):
(WebTestRunner::WebTestProxy::isPointerLocked):
* DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
(WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
(WebTestRunner):
(WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
(WebTestRunner::MockWebSpeechInputController::setDelegate):
(WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
(WebTestRunner::MockWebSpeechInputController::setDumpRect):
(WebTestRunner::MockWebSpeechInputController::clearResults):
(WebTestRunner::MockWebSpeechInputController::startRecognition):
(WebTestRunner::MockWebSpeechInputController::cancelRecognition):
(WebTestRunner::MockWebSpeechInputController::stopRecording):
(WebTestRunner::MockWebSpeechInputController::speechTaskFired):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
* DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
(WebKit):
(WebTestRunner):
(MockWebSpeechInputController):
(WebTestRunner::MockWebSpeechInputController::taskList):
(SpeechTask):
* DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
(WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
(WebTestRunner):
(WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
(WebTestRunner::MockWebSpeechRecognizer::setDelegate):
(WebTestRunner::MockWebSpeechRecognizer::start):
(WebTestRunner::MockWebSpeechRecognizer::stop):
(WebTestRunner::MockWebSpeechRecognizer::abort):
(WebTestRunner::MockWebSpeechRecognizer::addMockResult):
(WebTestRunner::MockWebSpeechRecognizer::setError):
(WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
(WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
(WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
* DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
(WebKit):
(WebTestRunner):
(MockWebSpeechRecognizer):
(WebTestRunner::MockWebSpeechRecognizer::wasAborted):
(WebTestRunner::MockWebSpeechRecognizer::client):
(WebTestRunner::MockWebSpeechRecognizer::handle):
(WebTestRunner::MockWebSpeechRecognizer::taskList):
(Task):
(WebTestRunner::MockWebSpeechRecognizer::Task::Task):
(WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
(StepTask):
(WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::windowOpened):
(WebTestRunner):
(WebTestRunner::TestInterfaces::windowClosed):
(WebTestRunner::TestInterfaces::windowList):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::requestPointerLock):
(WebTestRunner):
(WebTestRunner::TestRunner::requestPointerUnlock):
(WebTestRunner::TestRunner::isPointerLocked):
(WebTestRunner::TestRunner::didAcquirePointerLockInternal):
(WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
(WebTestRunner::TestRunner::didLosePointerLockInternal):
(WebTestRunner::TestRunner::windowCount):
(WebTestRunner::TestRunner::setMockDeviceOrientation):
(WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
(WebTestRunner::TestRunner::setGeolocationPermission):
(WebTestRunner::TestRunner::setMockGeolocationPosition):
(WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
(WebTestRunner::TestRunner::addMockSpeechInputResult):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
(WebTestRunner::TestRunner::setMockSpeechRecognitionError):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::didAcquirePointerLock):
(WebTestRunner::TestRunner::didNotAcquirePointerLock):
(WebTestRunner::TestRunner::didLosePointerLock):
(WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner):
(TestRunner):
(HostMethodTask):
(WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
(WebTestRunner::TestRunner::HostMethodTask::runIfValid):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::setInterfaces):
(WebTestRunner::WebTestProxyBase::setDelegate):
(WebTestRunner::WebTestProxyBase::reset):
(WebTestRunner::WebTestProxyBase::captureTree):
(WebTestRunner::WebTestProxyBase::geolocationClientMock):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
(WebTestRunner::WebTestProxyBase::speechInputControllerMock):
(WebTestRunner::WebTestProxyBase::speechRecognizerMock):
(WebTestRunner::WebTestProxyBase::geolocationClient):
(WebTestRunner::WebTestProxyBase::speechInputController):
(WebTestRunner::WebTestProxyBase::speechRecognizer):
(WebTestRunner::WebTestProxyBase::deviceOrientationClient):
(WebTestRunner::WebTestProxyBase::requestPointerLock):
(WebTestRunner::WebTestProxyBase::requestPointerUnlock):
(WebTestRunner::WebTestProxyBase::isPointerLocked):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::reset):
* DumpRenderTree/chromium/WebViewHost.h:
(WebKit):
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed. Correcting gardening after r143436.
zarvai@inf.u-szeged.hu [Wed, 20 Feb 2013 13:42:20 +0000 (13:42 +0000)]
[Qt] Unreviewed. Correcting gardening after r143436.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: fix for frontend closure compile errors.
loislo@chromium.org [Wed, 20 Feb 2013 13:40:19 +0000 (13:40 +0000)]
Web Inspector: fix for frontend closure compile errors.
https://bugs.webkit.org/show_bug.cgi?id=110329

Reviewed by Vsevolod Vlasov.

It has no tests because it has no code changes.

* inspector/front-end/HeapSnapshot.js:
(HeapSnapshotMetainfo):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClear SVGPathSeg role on removal.
fmalita@chromium.org [Wed, 20 Feb 2013 13:38:02 +0000 (13:38 +0000)]
Clear SVGPathSeg role on removal.
https://bugs.webkit.org/show_bug.cgi?id=110058

Reviewed by Dirk Schulze.

Source/WebCore:

SVGPathSegListPropertyTearOff::initialize() and SVGPathSegListPropertyTearOff::replaceItem()
need to clear the context and role for segments being expunged from the list, similarly to
removeItem(). Otherwise, processIncomingListItemValue() can get confused and attempt to
remove stale segments.

Test: svg/dom/SVGPathSegList-crash.html

* svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):
(WebCore::SVGPathSegListPropertyTearOff::clear):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore):
* svg/properties/SVGPathSegListPropertyTearOff.h:
(WebCore::SVGPathSegListPropertyTearOff::initialize):
(SVGPathSegListPropertyTearOff):

LayoutTests:

* svg/dom/SVGPathSegList-crash-expected.txt: Added.
* svg/dom/SVGPathSegList-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r143434.
commit-queue@webkit.org [Wed, 20 Feb 2013 12:45:58 +0000 (12:45 +0000)]
Unreviewed, rolling out r143434.
http://trac.webkit.org/changeset/143434
https://bugs.webkit.org/show_bug.cgi?id=110326

added reftest fails on chromium mac 10.6 (Requested by
toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-20

Source/WebCore:

* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

* fast/forms/file/file-vertical-padding-border-expected.html: Removed.
* fast/forms/file/file-vertical-padding-border.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Make debug builds possible on 32bit Linux
abecsi@webkit.org [Wed, 20 Feb 2013 12:36:45 +0000 (12:36 +0000)]
[Qt] Make debug builds possible on 32bit Linux
https://bugs.webkit.org/show_bug.cgi?id=110231

Reviewed by Tor Arne Vestbø.

Use the stabs format for debug builds to make the object files
a bit smaller so that they can be linked on a 32bit system.

* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Make UISourceCode.path() an array of path segments.
vsevik@chromium.org [Wed, 20 Feb 2013 12:33:20 +0000 (12:33 +0000)]
Web Inspector: Make UISourceCode.path() an array of path segments.
https://bugs.webkit.org/show_bug.cgi?id=110229

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype._filePathForPath):
(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._contentTypeForPath):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
* inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate.prototype.requestFileContent):
(WebInspector.SimpleProjectDelegate.prototype.searchInFileContent):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleProjectDelegate.prototype._ensureUniquePath):
(WebInspector.SimpleProjectDelegate.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFileByName):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.uri):
* inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCode):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.urlForPath):

LayoutTests:

* inspector/workspace-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update expectation for chromium gardening.
toyoshim@chromium.org [Wed, 20 Feb 2013 12:17:24 +0000 (12:17 +0000)]
Unreviewed, update expectation for chromium gardening.
https://bugs.webkit.org/show_bug.cgi?id=110324

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: fix message for non-existent domain warning
yurys@chromium.org [Wed, 20 Feb 2013 12:15:51 +0000 (12:15 +0000)]
Web Inspector: fix message for non-existent domain warning
https://bugs.webkit.org/show_bug.cgi?id=110315

Reviewed by Alexander Pavlov.

Only send (Heap)Profiler.resetProfiles event if the client has
requested profile headers before.

* inspector/InspectorHeapProfilerAgent.cpp:
(HeapProfilerAgentState):
(WebCore):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorHeapProfilerAgent::clearFrontend):
(WebCore::InspectorHeapProfilerAgent::restore):
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
* inspector/InspectorHeapProfilerAgent.h:
(InspectorHeapProfilerAgent):
* inspector/InspectorProfilerAgent.cpp:
(ProfilerAgentState):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorProfilerAgent::restore):
* inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Move workspace specific code from FileMapping to workspace.
vsevik@chromium.org [Wed, 20 Feb 2013 12:06:43 +0000 (12:06 +0000)]
Web Inspector: Move workspace specific code from FileMapping to workspace.
https://bugs.webkit.org/show_bug.cgi?id=110219

Reviewed by Pavel Feldman.

Source/WebCore:

Extracted workspace specific code from FileMapping to Workspace.
This allows to reduce usage of uri and eventually make UISourceCode.path an array of path segments.

Test: inspector/workspace-mapping.html

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.rawLocationToUILocation):
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.get addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.get addScript):
* inspector/front-end/FileMapping.js:
(WebInspector.FileMapping):
(WebInspector.FileMapping.prototype.mappingEntryForURL):
(WebInspector.FileMapping.prototype.mappingEntryForPath):
* inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMapping.prototype.fileSystemPathForPrefix):
(WebInspector.FileSystemMappingImpl.prototype.addFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.removeFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPathForPrefix):
* inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
* inspector/front-end/IsolatedFileSystemManager.js:
(WebInspector.IsolatedFileSystemManager):
* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._workspaceUISourceCodeForScript):
* inspector/front-end/ResourceUtils.js:
(WebInspector.displayNameForURL):
* inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(WebInspector.SASSSourceMapping.prototype._bindUISourceCode):
(WebInspector.SASSSourceMapping.prototype.rawLocationToUILocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
* inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleWorkspaceProvider.pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
* inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._resourceAdded):
(WebInspector.StylesSourceMapping.prototype._mainFrameCreatedOrNavigated):
(WebInspector.StyleContentBinding):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):
* inspector/front-end/Workspace.js:
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.hasMappingForURL):
(WebInspector.Workspace.prototype._fileSystemPathForEntry):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.urlForPath):
* inspector/front-end/inspector.js:

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:
* http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
* inspector/debugger/network-uisourcecode-provider.html:
* inspector/file-mapping-expected.txt:
* inspector/file-mapping.html:
* inspector/file-system-mapping-expected.txt:
* inspector/file-system-mapping.html:
* inspector/file-system-project.html:
* inspector/workspace-mapping-expected.txt: Added.
* inspector/workspace-mapping.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add myself to watch lists.
toyoshim@chromium.org [Wed, 20 Feb 2013 11:48:18 +0000 (11:48 +0000)]
Unreviewed. Add myself to watch lists.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed BlackBerry build fix.
carlosgc@webkit.org [Wed, 20 Feb 2013 11:25:16 +0000 (11:25 +0000)]
Unreviewed BlackBerry build fix.

WebPage::download was renamed in the header by mistake to
convertMainResourceLoadToDownload in r137845.

* Api/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 20 Feb 2013 11:18:46 +0000 (11:18 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding failure expectations for tests added in r143395, r143420 and r143439.
* platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r143386.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Port EwkPopupMenuItem to the C API
ch.dumez@sisa.samsung.com [Wed, 20 Feb 2013 11:08:29 +0000 (11:08 +0000)]
[EFL][WK2] Port EwkPopupMenuItem to the C API
https://bugs.webkit.org/show_bug.cgi?id=108798

Reviewed by Kenneth Rohde Christiansen.

Make use of the new WKPopupItem C API inside EwkPopupMenuItem to remove
dependency on internal WebPopupItem type. Eina shared string members
are now lazily initialized to make the object cheaper to construct.

* UIProcess/API/efl/ewk_popup_menu.cpp:
(EwkPopupMenu::EwkPopupMenu):
* UIProcess/API/efl/ewk_popup_menu_item.cpp:
(EwkPopupMenuItem::EwkPopupMenuItem):
(EwkPopupMenuItem::type):
(EwkPopupMenuItem::textDirection):
(EwkPopupMenuItem::text):
(EwkPopupMenuItem::tooltipText):
(EwkPopupMenuItem::accessibilityText):
(EwkPopupMenuItem::hasTextDirectionOverride):
(EwkPopupMenuItem::isEnabled):
(EwkPopupMenuItem::isLabel):
(EwkPopupMenuItem::isSelected):
* UIProcess/API/efl/ewk_popup_menu_item_private.h:
(EwkPopupMenuItem::create):
(EwkPopupMenuItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Introduce SecurityOriginAdded and SecurityOriginRemoved events into...
apavlov@chromium.org [Wed, 20 Feb 2013 11:01:27 +0000 (11:01 +0000)]
Web Inspector: Introduce SecurityOriginAdded and SecurityOriginRemoved events into ResourceTreeModel
https://bugs.webkit.org/show_bug.cgi?id=110232

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._addSecurityOrigin): Added.
(WebInspector.ResourceTreeModel.prototype._removeSecurityOrigin): Added.
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached): Added.
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):

LayoutTests:

* http/tests/inspector/resource-tree/resource-tree-events-expected.txt:
* http/tests/inspector/resource-tree/resource-tree-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 20 Feb 2013 10:01:33 +0000 (10:01 +0000)]
[EFL] Unreviewed gardening.

* platform/efl/TestExpectations: Marked new failing ref test svg/as-background-image/tiled-background-image.html.
* platform/efl/fast/js/global-constructors-expected.txt: Rebaselined, MutationObserver constructor now found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[v8] ScriptValue has dangerous copy semantics
commit-queue@webkit.org [Wed, 20 Feb 2013 09:58:37 +0000 (09:58 +0000)]
[v8] ScriptValue has dangerous copy semantics
https://bugs.webkit.org/show_bug.cgi?id=110206

Patch by Dan Carney <dcarney@google.com> on 2013-02-20
Reviewed by Kentaro Hara.

Update ScriptValue to used a SharedPersistent,
making it impossible to return dead references.

No new tests. No change in functionality.

* bindings/v8/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):
* bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(ScriptValue):
(WebCore::ScriptValue::v8Value):
(WebCore::ScriptValue::v8ValueRaw):
* bindings/v8/SharedPersistent.h:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::scriptValueAsNode):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAttrGetterCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: highlight undefined word in JavaScript
commit-queue@webkit.org [Wed, 20 Feb 2013 09:44:37 +0000 (09:44 +0000)]
Web Inspector: highlight undefined word in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=109585

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-20
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test enhancement: inspector/syntax-highlight-javascript.html

Add global object value properties to tokenizer and add a css style
class to highlight "undefined" with gray color.

* inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
* inspector/front-end/SourceJavaScriptTokenizer.re2js:
* inspector/front-end/inspectorSyntaxHighlight.css:
(.webkit-javascript-undef):

LayoutTests:

Enhance layout test to verify highlighting of global object value properties.

* inspector/syntax-highlight-javascript-expected.txt:
* inspector/syntax-highlight-javascript.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse EventPathWalker rather than parentNode() to normalize event targets in EventHandler.
mkwst@chromium.org [Wed, 20 Feb 2013 09:43:11 +0000 (09:43 +0000)]
Use EventPathWalker rather than parentNode() to normalize event targets in EventHandler.
https://bugs.webkit.org/show_bug.cgi?id=110037

Reviewed by Ryosuke Niwa.

Source/WebCore:

We need to teach EventHandler about Shadow DOM in a few places in order
to ensure that we properly target events dispatched upon text nodes.
Rather than naively grabbing the text node's direct parent via
parentNode(), we need to account for the case in which the text node is
distributed[1] to an insertion point inside a shadow host.
EventPathWalker::parent understands these relationships, and should
be used when dealing with mouse, drag, and touch events.

[1]: http://www.w3.org/TR/shadow-dom/#dfn-distribution

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::passGestureEventToWidgetIfPossible):
(WebCore::EventHandler::updateDragAndDrop):
    Refactor parentNode callsites to use EventPathWalker::parent().

LayoutTests:

* fast/dom/shadow/resources/event-dispatching.js:
(scrollMouseWheel):
(addEventListeners):
    Add MouseWheel, Drag, and Touch support to the event-dispatching
    tests in Shadow DOM.
* fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html:
* fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root.html:
    Scroll the mouse wheel, drag a bit, and touch before leaving the
    text node, and record the generated events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Regression] Search in ProfilesPanel is broken
vsevik@chromium.org [Wed, 20 Feb 2013 09:24:00 +0000 (09:24 +0000)]
Web Inspector: [Regression] Search in ProfilesPanel is broken
https://bugs.webkit.org/show_bug.cgi?id=110312

Reviewed by Pavel Feldman.

* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: View.markAsRoot should never be invoked on attached view.
eustas@chromium.org [Wed, 20 Feb 2013 09:21:09 +0000 (09:21 +0000)]
Web Inspector: View.markAsRoot should never be invoked on attached view.
https://bugs.webkit.org/show_bug.cgi?id=110224

Reviewed by Pavel Feldman.

This will cause CSS loading problems after "show".

* inspector/front-end/Drawer.js:
Ensure child view is detached before marked as root.
* inspector/front-end/View.js:
(WebInspector.View.prototype.markAsRoot): Added assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Wed, 20 Feb 2013 09:17:34 +0000 (09:17 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/TestExpectations:
* platform/qt/fast/js/global-constructors-expected.txt: Rebaseline after r143420.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardenning. Unskip now passing tests.
kadam@inf.u-szeged.hu [Wed, 20 Feb 2013 09:06:08 +0000 (09:06 +0000)]
[Qt] Unreviewed gardenning. Unskip now passing tests.
https://bugs.webkit.org/show_bug.cgi?id=99306

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFile upload control doesn't apply CSS vertical padding or border to file name
commit-queue@webkit.org [Wed, 20 Feb 2013 08:10:10 +0000 (08:10 +0000)]
File upload control doesn't apply CSS vertical padding or border to file name
https://bugs.webkit.org/show_bug.cgi?id=109011

Patch by Nils Barth <nbarth@google.com> on 2013-02-20
Reviewed by Hajime Morrita.

Source/WebCore:

Test: fast/forms/file/file-vertical-padding-border.html

* rendering/RenderFileUploadControl.cpp:
    Add borderTop() and paddingTop() when computing position.
(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

* fast/forms/file/file-vertical-padding-border.html: Added.
* fast/forms/file/file-vertical-padding-border-expected.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Mark fast/regions/seamless-iframe-flowed-into-regions.html failure
commit-queue@webkit.org [Wed, 20 Feb 2013 07:42:09 +0000 (07:42 +0000)]
[EFL] Mark fast/regions/seamless-iframe-flowed-into-regions.html failure
https://bugs.webkit.org/show_bug.cgi?id=110283

Unreviewed. This test is added by r143256 and it is failing.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-19

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFew methods in WebGLRenderingContext.idl have incorrect signatures
aandrey@chromium.org [Wed, 20 Feb 2013 06:54:23 +0000 (06:54 +0000)]
Few methods in WebGLRenderingContext.idl have incorrect signatures
https://bugs.webkit.org/show_bug.cgi?id=110305

Reviewed by Kentaro Hara.

* html/canvas/WebGLRenderingContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r143393.
commit-queue@webkit.org [Wed, 20 Feb 2013 06:14:19 +0000 (06:14 +0000)]
Unreviewed, rolling out r143393.
http://trac.webkit.org/changeset/143393
https://bugs.webkit.org/show_bug.cgi?id=110302

the converted reftest fails in chromium mac 10.6 and 10.7
(Requested by toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

* fast/flexbox/box-orient-button.html:
* fast/flexbox/resources/box-orient-button.js:
* fast/invalid/residual-style-expected.html: Removed.
* fast/invalid/residual-style.html:
* platform/chromium-android/fast/invalid/residual-style-expected.png: Added.
* platform/chromium-android/fast/invalid/residual-style-expected.txt: Added.
* platform/chromium-linux/fast/invalid/residual-style-expected.png: Added.
* platform/chromium-linux/fast/invalid/residual-style-expected.txt: Added.
* platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Added.
* platform/chromium-mac/fast/invalid/residual-style-expected.png: Added.
* platform/chromium-mac/fast/invalid/residual-style-expected.txt: Added.
* platform/chromium-win/fast/invalid/residual-style-expected.png: Added.
* platform/chromium-win/fast/invalid/residual-style-expected.txt: Added.
* platform/efl/fast/invalid/residual-style-expected.png: Added.
* platform/efl/fast/invalid/residual-style-expected.txt: Added.
* platform/gtk/fast/invalid/residual-style-expected.png: Added.
* platform/gtk/fast/invalid/residual-style-expected.txt: Added.
* platform/mac/fast/invalid/residual-style-expected.png: Added.
* platform/mac/fast/invalid/residual-style-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, uninteresting change to test a theory about bad dependency handling.
mrowe@apple.com [Wed, 20 Feb 2013 06:02:17 +0000 (06:02 +0000)]
Unreviewed, uninteresting change to test a theory about bad dependency handling.

* API/JSStringRefCF.cpp:
(JSStringCreateWithCFString): Remove an unnecessary else clause.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r143338.
commit-queue@webkit.org [Wed, 20 Feb 2013 05:57:29 +0000 (05:57 +0000)]
Unreviewed, rolling out r143338.
http://trac.webkit.org/changeset/143338
https://bugs.webkit.org/show_bug.cgi?id=110301

False alarm, no need to export the symbol (Requested by
aandrey on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

* WebKit.vcproj/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClarify isInWindow vs. isVisible path through to RenderLayerCompositor
timothy_horton@apple.com [Wed, 20 Feb 2013 05:53:02 +0000 (05:53 +0000)]
Clarify isInWindow vs. isVisible path through to RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=110261
<rdar://problem/13196122>

Reviewed by Simon Fraser.

Remove RenderLayerCompositor::willMoveOffscreen/didMoveOnscreen.
Add RenderLayerCompositor::setIsInWindow, and pipe in-window changes through from Page::setIsInWindow.
Adjust a few Document functions that previously called RenderView::didMoveOnscreen/willMoveOffscreen to use setIsInWindow instead, since in-win$

* WebCore.exp.in: Export Page::setIsInWindow.
* dom/Document.cpp:
(WebCore::Document::attach): Use setIsInWindow instead of didMoveOnscreen.
(WebCore::Document::documentWillBecomeInactive): Use setIsInWindow instead of willMoveOffscreen.
(WebCore::Document::documentDidResumeFromPageCache): Use setIsInWindow instead of didMoveOnscreen.
* page/FrameView.cpp:
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
RenderView doesn't care about moving on/offscreen, just in-window state.
(WebCore::FrameView::setIsInWindow): Added. Forward isInWindow changes to our RenderView.
* page/FrameView.h:
(FrameView): Add setIsInWindow.
* page/Page.cpp:
(WebCore::Page::setIsInWindow): Added. Forward isInWindow changes to the Page's FrameViews.
* page/Page.h:
(Page): Add setIsInWindow.
(WebCore::Page::isInWindow):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::setIsInWindow): Added. Replace willMoveOffscreen/didMoveOnscreen with setIsInWindow,
since that's the only change we actually care about.
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor): Add setIsInWindow.
* rendering/RenderView.cpp:
(WebCore::RenderView::setIsInWindow): Added. Replace willMoveOffscreen/didMoveOnscreen with setIsInWindow,
since that's the only change RenderLayerCompositor actually cares about.
* rendering/RenderView.h:
(RenderView): Add setIsInWindow.

* WebView/WebView.mm:
(-[WebView viewWillMoveToWindow:]):
(-[WebView viewDidMoveToWindow]):
Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setIsInWindow):
Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Cleanup and add JSDocs to SuggestBox
eustas@chromium.org [Wed, 20 Feb 2013 05:24:35 +0000 (05:24 +0000)]
Web Inspector: Cleanup and add JSDocs to SuggestBox
https://bugs.webkit.org/show_bug.cgi?id=110202

Reviewed by Pavel Feldman.

SuggestBox contains some obsolete/unused code and not fully
covered with JSDocs.

* inspector/front-end/SuggestBox.js:
(WebInspector.SuggestBox.prototype.visible):
Replaced getter with function.
(WebInspector.SuggestBox.prototype._onScrollOrResize):
Use camel-case for function names.
(WebInspector.SuggestBox.prototype._onBoxMouseDown): Ditto.
(WebInspector.SuggestBox.prototype.updateSuggestions):
Removed unused code.
(WebInspector.SuggestBox.prototype.hide): Adopt changes.
(WebInspector.SuggestBox.prototype._applySuggestion): Ditto.
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.isSuggestBoxVisible): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCalculate EventPath in EventDispatcher's constructor.
hayato@chromium.org [Wed, 20 Feb 2013 03:05:32 +0000 (03:05 +0000)]
Calculate EventPath in EventDispatcher's constructor.
https://bugs.webkit.org/show_bug.cgi?id=109905

Reviewed by Dimitri Glazkov.

This patch calculates an EventPath in EventDispatcher's
constructor and removes EventDispatcher::ensureEventPath().
We don't have any reason to initialize an EventPath lazily.

No tests. No change in behavior.

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatch):
* dom/EventDispatcher.h:
(WebCore::EventDispatcher::eventPath):
(EventDispatcher):
* dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove warning from run-bindings-tests
jsbell@chromium.org [Wed, 20 Feb 2013 02:49:15 +0000 (02:49 +0000)]
Remove warning from run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=110285

Reviewed by Kentaro Hara.

Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
"Unknown option: idlattributesfile". That option was removed from
bindings/scripts/preprocess-idls.pl but was still being passed by
the test script. Remove it.

* Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency): Remove unused arg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r143400.
commit-queue@webkit.org [Wed, 20 Feb 2013 02:46:28 +0000 (02:46 +0000)]
Unreviewed, rolling out r143400.
http://trac.webkit.org/changeset/143400
https://bugs.webkit.org/show_bug.cgi?id=110290

breaks everything (instacrash launching Safari) (Requested by
thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

* wtf/FastMalloc.cpp:
(WTF::internalEntropyValue):
(WTF):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix TileCache tile size when zoomed on slow-scrolling site
simon.fraser@apple.com [Wed, 20 Feb 2013 02:28:34 +0000 (02:28 +0000)]
Fix TileCache tile size when zoomed on slow-scrolling site
https://bugs.webkit.org/show_bug.cgi?id=110289

Source/WebCore:

Reviewed by Tim Horton.

In slow scrolling mode, we use the tile coverage rect as the tile size
(so a single tile covers the viewport). When zoomed, the tile coverage rect
shrinks relative to the TileCache, so scale the tile size back up.

Test: platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::tileSizeForCoverageRect):

LayoutTests:

Reviewed by Tim Horton.

Test that dumps tile coverage in a slow-scrolling, zoomed page.

* platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename AncestorChainWalker.
hayato@chromium.org [Wed, 20 Feb 2013 02:27:30 +0000 (02:27 +0000)]
Rename AncestorChainWalker.
https://bugs.webkit.org/show_bug.cgi?id=110146

Reviewed by Dimitri Glazkov.

Rename AncestorChainWalker to EventPathWalker.
The term of EventPath is used in DOM Core spec.  EventPath was
already introduced into a EventContext.h in r112055. We should
spread this term into the Walker class since they share the same
purpose.

No new tests, no behavior change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/EventDispatcher.cpp:
* dom/EventPathWalker.cpp: Renamed from Source/WebCore/dom/AncestorChainWalker.cpp.
(WebCore):
(WebCore::EventPathWalker::EventPathWalker):
(WebCore::EventPathWalker::parent): parent() is now a static function to cover simple use cases.
(WebCore::EventPathWalker::moveToParent): Renamed from parent().
* dom/EventPathWalker.h: Renamed from Source/WebCore/dom/AncestorChainWalker.h.
(WebCore):
(EventPathWalker):
(WebCore::EventPathWalker::node):
(WebCore::EventPathWalker::isVisitingInsertionPointInReprojection): Renamed from isCrossingInsertionPoint().
* dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::calculateEventPath):
(WebCore::EventRetargeter::buildRelatedNodeMap):
* dom/TreeScope.cpp:
(WebCore::TreeScope::focusedNode):
* html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
* page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::handleWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSnapshotted plugin label should not be selectable
dino@apple.com [Wed, 20 Feb 2013 01:59:23 +0000 (01:59 +0000)]
Snapshotted plugin label should not be selectable
https://bugs.webkit.org/show_bug.cgi?id=110286

Reviewed by Simon Fraser.

Update the CSS to make it clear that you should click
on a snapshot (use the finger pointer) and disable
text selection.

* css/plugIns.css:
(embed::-webkit-snapshotted-plugin-content .snapshot-container .snapshot-label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Exclusions] Enable shape-inside support for ellipses
hmuller@adobe.com [Wed, 20 Feb 2013 01:56:15 +0000 (01:56 +0000)]
[CSS Exclusions] Enable shape-inside support for ellipses
https://bugs.webkit.org/show_bug.cgi?id=109868

Reviewed by Dirk Schulze.

Source/WebCore:

This change is very similar to the one recently made for circles:
removed the test that disabled ellipse values for shape-inside.
The remaining support for ellipses, which is based on rounded rectangles
whose width/height is equal to their radiusX/radiusY, has not changed.

Test: fast/exclusions/shape-inside/shape-inside-ellipse.html

* rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): No longer disallows any BasicShape type.

LayoutTests:

Added a test for ellipse shape-inside values.

* fast/exclusions/shape-inside/shape-inside-ellipse-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-ellipse.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago'round' not implemented in border-image
commit-queue@webkit.org [Wed, 20 Feb 2013 01:46:14 +0000 (01:46 +0000)]
'round' not implemented in border-image
https://bugs.webkit.org/show_bug.cgi?id=14185

Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-19
Reviewed by David Hyatt.

Source/WebCore:

Add rendering support for 'round' keyword of border-image-repeat CSS property
http://dev.w3.org/csswg/css3-background/#border-image-repeat
Rebased original patch by Benjamin Otte <otte@gnome.org> and made few fixes.

Test: fast/borders/border-image-02.html

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawTiledImage):
* platform/graphics/GraphicsContext.h:
(GraphicsContext):
* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
* platform/graphics/Image.h:
(Image):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage): For 'round' keyword,
the image is tiled (repeated) to fill the area. If it does not fill the area
with a whole number of tiles, the image is rescaled so that it does.

LayoutTests:

Added test for 'round' keyword of border-image-repeat CSS property
http://dev.w3.org/csswg/css3-background/#border-image-repeat

* fast/borders/border-image-02.html: Added.
* platform/chromium-linux/fast/borders/border-image-02-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/borders/border-image-02-expected.txt: Added.
* platform/efl/TestExpectations:
* platform/gtk/fast/borders/border-image-02-expected.png: Added.
* platform/gtk/fast/borders/border-image-02-expected.txt: Added.
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow UI clients to handle vertical wheel events.
commit-queue@webkit.org [Wed, 20 Feb 2013 01:42:47 +0000 (01:42 +0000)]
Allow UI clients to handle vertical wheel events.
https://bugs.webkit.org/show_bug.cgi?id=110006

Patch by Conrad Shultz <conrad_shultz@apple.com> on 2013-02-19
Reviewed by Tim Horton.

Source/WebCore:

Add API to allow matching changes in WebKit2 to control rubber-banding behavior at vertical page extrema.
If rubber-banding is disabled during a scroll event that would otherwise trigger rubber-banding, dispatch
didNotHandleWheelEvent() to the page UI client.

* WebCore.exp.in:
Export new rubber-banding API.

* page/Page.cpp:
(WebCore):
(WebCore::Page::rubberBandsAtBottom):
Proxy for the corresponding function in ScrollingCoordinator.
(WebCore::Page::setRubberBandsAtBottom):
Ditto.
(WebCore::Page::rubberBandsAtTop):
Ditto.
(WebCore::Page::setRubberBandsAtTop):
Ditto.

* page/Page.h:
(Page):
Declare new rubber-banding API (above).

* page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::rubberBandsAtBottom):
Stub API implementation.
(WebCore::ScrollingCoordinator::setRubberBandsAtBottom):
Ditto.
(WebCore::ScrollingCoordinator::rubberBandsAtTop):
Ditto.
(WebCore::ScrollingCoordinator::setRubberBandsAtTop):
Ditto.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
Initialize new member variables.
(WebCore::ScrollingTree::setMainFramePinState):
Set top/bottom pinned states.
(WebCore::ScrollingTree::rubberBandsAtBottom):
New accessor function.
(WebCore::ScrollingTree::setRubberBandsAtBottom):
New mutator function.
(WebCore::ScrollingTree::rubberBandsAtTop):
New accessor function.
(WebCore::ScrollingTree::setRubberBandsAtTop):
New mutator function.
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
Start a vertical swipe event if the frame is pinned at the top or bottom and associated rubber-banding is disabled.

* page/scrolling/ScrollingTree.h:
(ScrollingTree):
Declare new rubber-banding API and associated member variables.

* page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollingCoordinatorMac):
Declare API overrides.

* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::rubberBandsAtBottom):
Method override; proxy to corresponding function in ScrollingTree.
(WebCore::ScrollingCoordinatorMac::setRubberBandsAtBottom):
Ditto.
(WebCore::ScrollingCoordinatorMac::rubberBandsAtTop):
Ditto.
(WebCore::ScrollingCoordinatorMac::setRubberBandsAtTop):
Ditto.

* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::pinnedInDirection):
Remove trailing whitespace.
(WebCore::ScrollingTreeScrollingNodeMac::updateMainFramePinState):
Calculate and pass vertical pinning state to ScrollingTree::setMainFramePinState().

Source/WebKit2:

Add API to allow clients to selectively control rubber-banding at vertical page extrema.

* UIProcess/API/C/WKPage.cpp:
(WKPageRubberBandsAtBottom):
Proxy for the corresponding function in WebCore::Page.
(WKPageSetRubberBandsAtBottom):
Ditto.
(WKPageRubberBandsAtTop):
Ditto.
(WKPageSetRubberBandsAtTop):
Ditto.

* UIProcess/API/C/WKPage.h:
Declare new API.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Initialize new member variables.
(WebKit::WebPageProxy::setRubberBandsAtBottom):
New function; dispatches a matching message to the WebKit::WebPage.
(WebKit::WebPageProxy::setRubberBandsAtTop):
Ditto.

* UIProcess/WebPageProxy.h:
(WebPageProxy):
Declare new API.
(WebKit::WebPageProxy::rubberBandsAtBottom):
New accessor function.
(WebKit::WebPageProxy::rubberBandsAtTop):
Ditto.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setRubberBandsAtBottom):
New function; call the matching function on the associated WebCore::Page.
(WebKit::WebPage::setRubberBandsAtTop):
Ditto.

* WebProcess/WebPage/WebPage.h:
(WebPage):
Declare new rubber-banding API.

* WebProcess/WebPage/WebPage.messages.in:
Declare new rubber-banding API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRubber-banding should not affect the visibleRect of the TileCache
simon.fraser@apple.com [Wed, 20 Feb 2013 01:29:39 +0000 (01:29 +0000)]
Rubber-banding should not affect the visibleRect of the TileCache
https://bugs.webkit.org/show_bug.cgi?id=110278

Reviewed by Beth Dakin.

When rubber-banding a slow-scrolling page, or image document, we would constantly re-create
the bottom tile because of the logic that adapts the tile size to the visible rect when slow
scrolling.

Avoid that by ensuring that the visibleRect is not affected by rubber-banding. This is done
via a GraphicsLayerClient function that allows RenderLayerCompositor to provide a custom
position for the scroll layer. We constrain that scroll position to remove the overhang that
results from rubber-banding.

I wasn't able to make a test for this, even with internals.setScrollViewPosition().

* platform/graphics/GraphicsLayerClient.h:
(GraphicsLayerClient):
(WebCore::GraphicsLayerClient::customPositionForVisibleRectComputation):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::computeVisibleRect):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::customPositionForVisibleRectComputation):
* rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, force file to recompile to fix win build.
tony@chromium.org [Wed, 20 Feb 2013 01:24:49 +0000 (01:24 +0000)]
Unreviewed, force file to recompile to fix win build.

* WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix crash in preloading scanning base tags with no href attribute for background...
tonyg@chromium.org [Wed, 20 Feb 2013 01:20:48 +0000 (01:20 +0000)]
Fix crash in preloading scanning base tags with no href attribute for background parser
https://bugs.webkit.org/show_bug.cgi?id=110276

Reviewed by Eric Seidel.

Previously a <base> tag without an href attribute (like the one in fast/dom/HTMLAnchorElement/set-href-attribute-rebase.html)
would crash the background parser's preload scanner.

To fix that, we only call stripLeadingAndTrailingHTMLSpaces() if the href attribute is non-null. This matches the main thread parser.

Along with this, I decided to templatize updatePredictedBaseURL() so that the main and background parser can share the same impl.

This required making CompactHTMLToken and HTMLToken a little more similar:
1. Give HTMLToken a getAttributeItem() method.
2. Move CompactAttribute to CompactHTMLToken::Attribute and make it a struct.

No new tests because covered by existing tests.

* html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken):
(WebCore::CompactHTMLToken::getAttributeItem):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):
* html/parser/CompactHTMLToken.h:
(WebCore::CompactHTMLToken::Attribute::Attribute):
(Attribute):
(WebCore::CompactHTMLToken::attributes):
(CompactHTMLToken):
(WebCore::CompactHTMLToken::publicIdentifier):
(WebCore::CompactHTMLToken::systemIdentifier):
* html/parser/HTMLParserIdioms.h:
(WebCore):
(WebCore::stripLeadingAndTrailingHTMLSpaces):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore):
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
* html/parser/HTMLPreloadScanner.h:
* html/parser/HTMLToken.h:
(WebCore::HTMLToken::getAttributeItem):
(HTMLToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, include exports for VS2010 as well.
tony@chromium.org [Wed, 20 Feb 2013 01:18:24 +0000 (01:18 +0000)]
Unreviewed, include exports for VS2010 as well.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroducing AbstractSQLTransaction and AbstractSQLTransactionBackend.
mark.lam@apple.com [Wed, 20 Feb 2013 00:48:25 +0000 (00:48 +0000)]
Introducing AbstractSQLTransaction and AbstractSQLTransactionBackend.
https://bugs.webkit.org/show_bug.cgi?id=110273.

Reviewed by Anders Carlsson.

This is part of the webdatabase refactoring for webkit2.
- Also changed the frontend and backend to only refer to the
  abstract interface of each other.

No new tests.

* Modules/webdatabase/AbstractSQLTransaction.h: Added.
(AbstractSQLTransaction):
(WebCore::AbstractSQLTransaction::~AbstractSQLTransaction):
* Modules/webdatabase/AbstractSQLTransactionBackend.h: Added.
(AbstractSQLTransactionBackend):
(WebCore::AbstractSQLTransactionBackend::~AbstractSQLTransactionBackend):
* Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::hasCallback):
(WebCore::SQLTransaction::hasSuccessCallback):
(WebCore::SQLTransaction::hasErrorCallback):
(WebCore::SQLTransaction::setBackend):
* Modules/webdatabase/SQLTransaction.h:
(SQLTransaction):
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
* Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
* Modules/webdatabase/SQLTransactionStateMachine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSilence some analyzer warnings
oliver@apple.com [Wed, 20 Feb 2013 00:47:52 +0000 (00:47 +0000)]
Silence some analyzer warnings
https://bugs.webkit.org/show_bug.cgi?id=110281

Reviewed by Mark Hahnenberg.

The static analyzer believes that callerCodeBlock can be null,
based on other code performing null tests.  This should not
ever be the case, but we'll add RELEASE_ASSERTs to make it
obvious if we're ever wrong.

* interpreter/Interpreter.cpp:
(JSC::getCallerInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange computeStickyPositionConstraints to use LayoutBoxExtent for margins
eae@chromium.org [Wed, 20 Feb 2013 00:45:40 +0000 (00:45 +0000)]
Change computeStickyPositionConstraints to use LayoutBoxExtent for margins
https://bugs.webkit.org/show_bug.cgi?id=108872

Reviewed by Levi Weintraub.

Change RenderBoxModelObject::computeStickyPositionConstraints to
use a LayoutBoxExtent to represent margins.

No new tests, no change in functionality.

* platform/graphics/LayoutRect.h:
(WebCore::LayoutRect::contract):
Add version contract methods that takes a LayoutBoxExtent object.

* platform/graphics/LayoutSize.h:
(WebCore::LayoutSize::shrink):
Add shrink method.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints):
Change to use a LayoutBoxExtent object to represent margins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, fix the Windows build after r143398.
tony@chromium.org [Wed, 20 Feb 2013 00:45:09 +0000 (00:45 +0000)]
Unreviewed, fix the Windows build after r143398.
Add new setters to the export list.

* WebKit.vcproj/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't force everything to be blinded in debug builds
oliver@apple.com [Wed, 20 Feb 2013 00:42:22 +0000 (00:42 +0000)]
Don't force everything to be blinded in debug builds
https://bugs.webkit.org/show_bug.cgi?id=110279

Reviewed by Mark Hahnenberg.

Switch to an explicit flag for indicating that we want
every constant to be blinded.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlind):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable ASSERT(!hasInsertionPoint()) for background parser
tonyg@chromium.org [Wed, 20 Feb 2013 00:35:51 +0000 (00:35 +0000)]
Disable ASSERT(!hasInsertionPoint()) for background parser
https://bugs.webkit.org/show_bug.cgi?id=110251

Reviewed by Adam Barth.

The background parser crashes about 10 layout tests by hitting ASSERT(!hasInsertionPoint()).
Now, finish() is the thing that closes the HTMLInputStream which removes the insertion point.
In these tests, a document.open() calls insert() which clears the HTMLInputStream which causes
there to be an insertion point again.

With the main thread parser, insert() is called before finish() so the ASSERT passes.
However, with the threaded parser, finish() is called before insert(), so we fail the ASSERT.

This patch disables the ASSERT for the background parser because m_input isn't really relevant.
This causes us to pass the tests. However, there is a risk that now hasInsertionPoint() may be incorrect
and Document has a non-debug branch that tests hasInsertionPoint().

No new tests because covered by existing tests.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add myself to watch lists.
esprehn@chromium.org [Wed, 20 Feb 2013 00:34:16 +0000 (00:34 +0000)]
Unreviewed. Add myself to watch lists.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, corrected primary email.
hmuller@adobe.com [Wed, 20 Feb 2013 00:26:45 +0000 (00:26 +0000)]
Unreviewed, corrected primary email.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSeparate constraining for overhang from fixed-position zooming behavior in scrollOffs...
simon.fraser@apple.com [Wed, 20 Feb 2013 00:25:06 +0000 (00:25 +0000)]
Separate constraining for overhang from fixed-position zooming behavior in scrollOffsetForFixedPosition()
https://bugs.webkit.org/show_bug.cgi?id=110267

Reviewed by Beth Dakin.

The static scrollOffsetForFixedPosition() function in ScrollingCoordinator did two things;
it constrained the scroll position when rubber-banding, and applied the special scaling for
fixed position when zoomed.

Separate these out so that we can use the rubber-banding constrained elsewhere.

* page/FrameView.cpp:
(WebCore::FrameView::scrollOffsetForFixedPosition): The static function is here now.
* page/FrameView.h:
* page/scrolling/ScrollingCoordinator.cpp: Code moved to FrameView.
* page/scrolling/ScrollingCoordinator.h:
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition): scrollOffsetForFixedPosition()
is now on FrameView.
* platform/ScrollableArea.cpp:
(WebCore::constrainedScrollPosition): Helper to constrain one axis for overhang.
(WebCore::ScrollableArea::constrainScrollPositionForOverhang): Static function that
can be called by FrameView::scrollOffsetForFixedPosition().
* platform/ScrollableArea.h: Static function constrainScrollPositionForOverhang()
so we can call it from another thread. Also a member fuction of the same name, which takes
the scrollPosition as input (so we can feed it a layer position in a later patch).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r143382 and r143401.
enne@google.com [Wed, 20 Feb 2013 00:20:29 +0000 (00:20 +0000)]
Unreviewed, rolling out r143382 and r143401.
http://trac.webkit.org/changeset/143382
http://trac.webkit.org/changeset/143401
https://bugs.webkit.org/show_bug.cgi?id=106457

Breaks Chromium win/mac canary compilation

Source/Platform:

* chromium/public/Platform.h:

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::idbFactory):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix checkThatTokensAreSafeToSendToAnotherThread() now that the preload scanner is...
tonyg@chromium.org [Wed, 20 Feb 2013 00:15:23 +0000 (00:15 +0000)]
Fix checkThatTokensAreSafeToSendToAnotherThread() now that the preload scanner is enabled
https://bugs.webkit.org/show_bug.cgi?id=110258

Reviewed by Adam Barth.

We were hitting this ASSERT on numerous tests with the background parser enabled. This copy fixes the assertion.

No new tests becuase covered by existing tests.

* html/parser/HTMLResourcePreloader.h:
(WebCore::PreloadRequest::setCharset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move WebKitPlatformSupport declaration to Platform.h
pilgrim@chromium.org [Wed, 20 Feb 2013 00:14:25 +0000 (00:14 +0000)]
[Chromium] Move WebKitPlatformSupport declaration to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=110262

Reviewed by Adam Barth.

In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.

Source/Platform:

* chromium/public/Platform.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMoar hardening
oliver@apple.com [Wed, 20 Feb 2013 00:13:26 +0000 (00:13 +0000)]
Moar hardening
https://bugs.webkit.org/show_bug.cgi?id=110275

Reviewed by Anders Carlsson.

We now poison objects when they get freed, and verify that
any object that is being freed is not poisoned.  If the
object looks like it's poisoned we validate the freelist,
and ensure the object is not already present.  If it is
we crash.

On allocation, we ensure that the object being allocated
is poisoned, then clear the poisoning fields.

* wtf/FastMalloc.cpp:
(WTF::internalEntropyValue):
(WTF):
(WTF::freedObjectStartPoison):
(WTF::freedObjectEndPoison):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix typo: inititatorFor->initiatorFor
tonyg@chromium.org [Tue, 19 Feb 2013 23:58:25 +0000 (23:58 +0000)]
Fix typo: inititatorFor->initiatorFor
https://bugs.webkit.org/show_bug.cgi?id=110260

Reviewed by Adam Barth.

No new tests because no changed functionality.

* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::initiatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
* html/parser/HTMLPreloadScanner.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert 3 settings to use Settings.in
tony@chromium.org [Tue, 19 Feb 2013 23:38:15 +0000 (23:38 +0000)]
Convert 3 settings to use Settings.in
https://bugs.webkit.org/show_bug.cgi?id=109875

Reviewed by Ryosuke Niwa.

Source/WebCore:

Convert mediaEnabled, applicationChromeMode and DOMPasteAllowed to
use Settings.in. They previously had inconsistently named setters.

No new tests, this is a refactoring.

* Source/WebCore/WebCore.exp.in: Remove symbols that are now inlined from exports.
* Source/WebCore/WebCore.order: Remove symbols that no longer exist.
* dom/make_names.pl:
(printConstructorInterior): Rename isMediaEnabled to mediaEnabled.
(printWrapperFunctions): Rename isMediaEnabled to mediaEnabled.
* editing/EditorCommand.cpp:
(WebCore::supportedPaste): Rename isDOMPasteAllowed to DOMPasteAllowed.
* page/Settings.cpp:
(WebCore::Settings::Settings): Remove custom code.
* page/Settings.h:
(Settings): Remove custom code.
* page/Settings.in: Add entries for mediaEnabled, applicationChromeMode and DOMPasteAllowed.
* page/make_settings.pl:
(setterFunctionName): Expand uppercase rules to include DOM.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isDefault): Rename inApplicationChromeMode to applicationChromeMode.
* rendering/RenderThemeWin.cpp:
(WebCore::documentIsInApplicationChromeMode): Rename inApplicationChromeMode to applicationChromeMode.

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(_ewk_view_priv_new): Rename isDOMPasteAllowed to DOMPasteAllowed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Grid Layout] Refactor the code in preparation of auto placement support
jchaffraix@webkit.org [Tue, 19 Feb 2013 23:34:33 +0000 (23:34 +0000)]
[CSS Grid Layout] Refactor the code in preparation of auto placement support
https://bugs.webkit.org/show_bug.cgi?id=110244

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-auto-flow-resolution.html

In order to support auto placement, we need to iterate over the grid items with
auto row / column several times. This changes makes us do that in a very simple,
not-yet-conformant way. While touching this code, the distinction between grid-auto-flow
none and row / column was better drawn (and enforced).

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPositionFromStyle):
Made it illegal to call resolveGridPositionFromStyle if the grid track is auto and
grid-auto-flow is not none. This would catch bad use of the function.

(WebCore::RenderGrid::maximumIndexInDirection):
Updated to bail out if the grid track is auto. Also improved the comment.

(WebCore::RenderGrid::placeItemsOnGrid):
Updated the function to do several iterations. Also handled the grid-auto-flow: none
case differently as it shouldn't need the extra iteration(s).

LayoutTests:

* fast/css-grid-layout/grid-auto-flow-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-auto-flow-resolution.html: Added.
* fast/css-grid-layout/implicit-position-dynamic-change.html:
* fast/css-grid-layout/resources/grid.css:
(.autoRowAutoColumn):
(.firstRowAutoColumn):
(.secondRowAutoColumn):
(.thirdRowAutoColumn):
(.autoRowFirstColumn):
(.autoRowSecondColumn):
(.autoRowThirdColumn):
Added these helper classes, some will be used in a follow-up patch.

(.sizedToGridArea):
Hoisted this class into the common style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStorageAreaProxy should know its quota
andersca@apple.com [Tue, 19 Feb 2013 23:31:58 +0000 (23:31 +0000)]
StorageAreaProxy should know its quota
https://bugs.webkit.org/show_bug.cgi?id=110268

Reviewed by Sam Weinig.

Begin stubbing out StorageAreaProxy::setItem and add some quota member variables.

* WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::StorageAreaProxy):
(WebKit::StorageAreaProxy::setItem):
* WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
* WebProcess/Storage/StorageNamespaceProxy.cpp:
(WebKit::StorageNamespaceProxy::createSessionStorageNamespace):
(WebKit::StorageNamespaceProxy::StorageNamespaceProxy):
* WebProcess/Storage/StorageNamespaceProxy.h:
(WebKit::StorageNamespaceProxy::quota):
(StorageNamespaceProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[New Multicolumn] REGRESSION: RenderMultiColumnSets broken by the RenderRegion -...
hyatt@apple.com [Tue, 19 Feb 2013 23:23:39 +0000 (23:23 +0000)]
[New Multicolumn] REGRESSION: RenderMultiColumnSets broken by the RenderRegion -> RenderBlock subclassing.
https://bugs.webkit.org/show_bug.cgi?id=110239.

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/multicol/newmulticol/column-rules-fixed-height.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::columnRectAt):
Make sure the columnGap() in the old multicolumn code is always expressed as a LayoutUnit. This was the
one place where it was still an int.

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
Rework the painting of flow thread portions to account for the fact that regions paint at an integral
translation. This means you have to construct clipping around that integral destination. Subpixel layout
regions did not clip correctly as a result of this issue.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnRectAt):
Fix the same bug with columnGap() that the old column code has, i.e., one spot where it was an int.

(WebCore::RenderMultiColumnSet::paintObject):
RenderMultiColumnSet should be using paintObject and not paint and it needs to check for visibility
and phases now that it is a RenderBlock subclass.

(WebCore::RenderMultiColumnSet::paintColumnRules):
Fix the bug that Opera guys fixed in the old multi-column code. They didn't patch the new code, so this
takes care of that.

* rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
Change to use paintObject instead of paint.

LayoutTests:

* fast/multicol/newmulticol: Added.
* fast/multicol/newmulticol/column-rules-fixed-height-expected.html: Added.
* fast/multicol/newmulticol/column-rules-fixed-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix indentation of Opcode.h
fpizlo@apple.com [Tue, 19 Feb 2013 23:21:06 +0000 (23:21 +0000)]
Fix indentation of Opcode.h

Rubber stamped by Mark Hahnenberg.

* bytecode/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert residual-style.html test to a reftest (and fix typos)
commit-queue@webkit.org [Tue, 19 Feb 2013 23:20:37 +0000 (23:20 +0000)]
Convert residual-style.html test to a reftest (and fix typos)
https://bugs.webkit.org/show_bug.cgi?id=109981

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-19
Reviewed by Darin Adler.

* fast/flexbox/box-orient-button.html: clsas->class
* fast/flexbox/resources/box-orient-button.js: DTR->DRT
* fast/invalid/residual-style-expected.html: Added. New reftest
version. Note that some lines are red, which is
https://bugs.webkit.org/show_bug.cgi?id=109984
* fast/invalid/residual-style.html: Add missing semicolon in <style>.
Also close a few more <font> tags, so that the descriptive text is
in black as it should be.

* platform/chromium-android/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-android/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-linux/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-linux/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-win/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-win/fast/invalid/residual-style-expected.txt: Removed.
* platform/efl/fast/invalid/residual-style-expected.png: Removed.
* platform/efl/fast/invalid/residual-style-expected.txt: Removed.
* platform/gtk/fast/invalid/residual-style-expected.png: Removed.
* platform/gtk/fast/invalid/residual-style-expected.txt: Removed.
* platform/mac/fast/invalid/residual-style-expected.png: Removed.
* platform/mac/fast/invalid/residual-style-expected.txt: Removed.
Removed old expectation files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMoved PolymorphicAccessStructureList into its own file.
fpizlo@apple.com [Tue, 19 Feb 2013 23:19:25 +0000 (23:19 +0000)]
Moved PolymorphicAccessStructureList into its own file.

Rubber stamped by Mark Hahnenberg.

* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/Instruction.h:
(JSC):
* bytecode/PolymorphicAccessStructureList.h: Added.
(JSC):
(PolymorphicAccessStructureList):
(PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::visitWeak):
* bytecode/StructureStubInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Appropriately handle word wrapping in SpellingHandler
nghanavatian@rim.com [Tue, 19 Feb 2013 23:15:42 +0000 (23:15 +0000)]
[BlackBerry] Appropriately handle word wrapping in SpellingHandler
https://bugs.webkit.org/show_bug.cgi?id=110253

Reviewed by Rob Buis.

PR286001
Since we traverse through text by visual lines instead of blocks, word wrapping causes some
bad behavior. Changing the way we traverse text to jump by words instead of lines. This will
mean it takes longer to finish spellchecking, but the removal of any loops allows webkit
processing to continue. This gives priority to user actions while still completing a large
paragraph in a reasonable amount of time.

Internally reviewed by Mike Fenton

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
* WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
(BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
(BlackBerry::WebKit::SpellingHandler::startOfNextWord):
(WebKit):
(BlackBerry::WebKit::SpellingHandler::incrementByWord):
(BlackBerry::WebKit::SpellingHandler::doesWordWrap):
* WebKitSupport/SpellingHandler.h:
(SpellingHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix indentation of Instruction.h
fpizlo@apple.com [Tue, 19 Feb 2013 23:10:35 +0000 (23:10 +0000)]
Fix indentation of Instruction.h

Rubber stamped by Mark Hahnenberg.

* bytecode/Instruction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix 'slice' aspect ratio calculation
pdr@google.com [Tue, 19 Feb 2013 23:04:34 +0000 (23:04 +0000)]
Fix 'slice' aspect ratio calculation
https://bugs.webkit.org/show_bug.cgi?id=99984

Patch by Branimir Lambov <blambov@google.com> on 2013-02-19
Reviewed by Dirk Schulze.

Source/WebCore:

Previously the calculation for the 'slice' aspect ratio would incorrectly calculate the
source rect location based on the destination rect offset. This caused our source rect to be
incorrect, and sometimes render outside the visible area completely. After this patch
our implementation matches the implementation of both Gecko and Presto.

The relevant spec section:
http://www.w3.org/TR/SVG/single-page.html#coords-PreserveAspectRatioAttribute

Tests: svg/as-image/image-preserveAspectRatio-all.svg
       svg/filters/feImage-preserveAspectRatio-all.svg

* svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::transformRect):

LayoutTests:

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
* svg/as-image/image-preserveAspectRatio-all-expected.txt: Added.
* svg/as-image/image-preserveAspectRatio-all.svg: Added.
* svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
* svg/filters/feImage-preserveAspectRatio-all-expected.txt: Added.
* svg/filters/feImage-preserveAspectRatio-all.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test Expectations to reflect flakey calendar tests.
schenney@chromium.org [Tue, 19 Feb 2013 23:03:15 +0000 (23:03 +0000)]
[Chromium] Test Expectations to reflect flakey calendar tests.
https://bugs.webkit.org/show_bug.cgi?id=107508

Unreviewed test expectations.

* platform/chromium/TestExpectations: Re-added all the flakey calendar tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
commit-queue@webkit.org [Tue, 19 Feb 2013 23:01:20 +0000 (23:01 +0000)]
[V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
https://bugs.webkit.org/show_bug.cgi?id=110254

Patch by Kentaro Hara <haraken@google.com> on 2013-02-19
Reviewed by Adam Barth.

Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951

Currently ScriptRunner::runCompiledScript() calls
ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is
hitting the ASSERT(). The ASSERT() does not make sense at all.
Instead, we should return an empty handle when OOM occurs.

No tests. The bug happens only when OOM occurs.

* bindings/v8/ScriptRunner.cpp:
(WebCore::ScriptRunner::runCompiledScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport both MutationObserver and WebKitMutationObserver
esprehn@chromium.org [Tue, 19 Feb 2013 22:58:29 +0000 (22:58 +0000)]
Support both MutationObserver and WebKitMutationObserver
https://bugs.webkit.org/show_bug.cgi?id=109776

Reviewed by Ojan Vafai.

Source/WebCore:

We should allow new MutationObserver now that we support parser generated
mutations. This leaves the old prefixed constructor in until we decide
people don't depend on it.

Test: fast/dom/MutationObserver/mutation-observer-prefix.html

* page/DOMWindow.idl:

LayoutTests:

* fast/dom/MutationObserver/added-out-of-order.html:
* fast/dom/MutationObserver/callback-arguments.html:
* fast/dom/MutationObserver/clear-transient-without-delivery.html:
* fast/dom/MutationObserver/create-during-delivery.html:
* fast/dom/MutationObserver/cross-document.html:
* fast/dom/MutationObserver/database-callback-delivery.html:
* fast/dom/MutationObserver/delivery-order.html:
* fast/dom/MutationObserver/disconnect-cancel-pending.html:
* fast/dom/MutationObserver/document-fragment-insertion.html:
* fast/dom/MutationObserver/end-of-task-delivery.html:
* fast/dom/MutationObserver/filesystem-callback-delivery.html:
* fast/dom/MutationObserver/inline-event-listener.html:
* fast/dom/MutationObserver/mutate-during-delivery.html:
* fast/dom/MutationObserver/mutation-callback-non-element-crash.html:
* fast/dom/MutationObserver/mutation-observer-constructor.html:
* fast/dom/MutationObserver/mutation-observer-prefix-expected.txt: Added.
* fast/dom/MutationObserver/mutation-observer-prefix.html: Added.
* fast/dom/MutationObserver/mutation-record-nullity.html:
* fast/dom/MutationObserver/observe-attributes.html:
* fast/dom/MutationObserver/observe-characterdata.html:
* fast/dom/MutationObserver/observe-childList.html:
* fast/dom/MutationObserver/observe-exceptions.html:
* fast/dom/MutationObserver/observe-subtree.html:
* fast/dom/MutationObserver/observer-wrapper-dropoff-transient.html:
* fast/dom/MutationObserver/observer-wrapper-dropoff.html:
* fast/dom/MutationObserver/parser-mutations.html:
* fast/dom/MutationObserver/removed-out-of-order.html:
* fast/dom/MutationObserver/shadow-dom.html:
* fast/dom/MutationObserver/takeRecords.html:
* fast/dom/MutationObserver/transient-gc-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago <rdar://problem/13239119> NetworkProcess generates timeout spindump logs
ap@apple.com [Tue, 19 Feb 2013 22:38:35 +0000 (22:38 +0000)]
    <rdar://problem/13239119> NetworkProcess generates timeout spindump logs

        Reviewed by Mark Rowe.

        Don't keep a window server connection in processes that don't need it, and don't
        run an NSApplication run loop.

        * Shared/ChildProcess.h:
        * Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::shutdownWindowServerConnection):
        Added a function to shut down connections, and to make sure we don't get one in the future.

        * NetworkProcess/mac/NetworkProcessMac.mm:
        (WebKit::NetworkProcess::initializeProcessName):
        * OfflineStorageProcess/mac/OfflineStorageProcessMac.mm:
        (WebKit::OfflineStorageProcess::initializeProcessName):
        * SharedWorkerProcess/mac/SharedWorkerProcessMac.mm:
        (WebKit::SharedWorkerProcess::platformInitializeSharedWorkerProcess): Also removed
        some unused includes and forward declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling in r143348.
ggaren@apple.com [Tue, 19 Feb 2013 22:29:03 +0000 (22:29 +0000)]
Unreviewed, rolling in r143348.
http://trac.webkit.org/changeset/143348
https://bugs.webkit.org/show_bug.cgi?id=110242

The bug was that isEmptyValue() was returning true for the deleted value.
Fixed this and simplified things further by delegating to m_sourceCode
for both isNull() and isHashTableDeletedValue(), so they can't be out of
sync.

* runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
* runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Adding myself as a committer.
hmuller@adobe.com [Tue, 19 Feb 2013 22:15:58 +0000 (22:15 +0000)]
Unreviewed. Adding myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove idbFactory from WebKitPlatformSupport
pilgrim@chromium.org [Tue, 19 Feb 2013 22:02:47 +0000 (22:02 +0000)]
[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Kentaro Hara.

Now that https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

* public/platform/WebKitPlatformSupport.h:
(WebKit):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Improve gyp build JavaScriptCore code generation
mrobinson@webkit.org [Tue, 19 Feb 2013 21:53:57 +0000 (21:53 +0000)]
[GTK] Improve gyp build JavaScriptCore code generation
https://bugs.webkit.org/show_bug.cgi?id=109969

Reviewed by Dirk Pranke.

Switch away from using DerivedSources.make when building JavaScriptCore generated
sources. This bring a couple advantages, such as building the sources in parallel,
but requires us to list the generated sources more than once.

* JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Add rules for generating JavaScriptCore sources.
* JavaScriptCore.gyp/generate-derived-sources.sh: Added.
* JavaScriptCore.gyp/redirect-stdout.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove RenderText::updateText
esprehn@chromium.org [Tue, 19 Feb 2013 21:51:19 +0000 (21:51 +0000)]
Remove RenderText::updateText
https://bugs.webkit.org/show_bug.cgi?id=109991

Reviewed by Eric Seidel.

There's no reason for the generic RenderText::updateText virtual hook
anymore now that r143060 made RenderQuote stop setting dirty bits during
layout since the hook is only used by RenderCounter.

Instead add updateCounterIfNeeded and make it clear this is a hack for
counters.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::updateCounterIfNeeded): Added, not handles the counter specific hack.
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::updateCounter):
* rendering/RenderCounter.h:
(RenderCounter):
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::updateDepth):
* rendering/RenderQuote.h:
(RenderQuote):
* rendering/RenderText.h:
(RenderText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS3: add line-break tests, initially skipping on all platforms
glenn@skynav.com [Tue, 19 Feb 2013 21:46:06 +0000 (21:46 +0000)]
CSS3: add line-break tests, initially skipping on all platforms
https://bugs.webkit.org/show_bug.cgi?id=109954

Reviewed by Dirk Pranke.

See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping

See also:
https://bugs.webkit.org/show_bug.cgi?id=89235

* TestExpectations:
* css3/line-break/line-break-auto-centered-expected.html: Added.
* css3/line-break/line-break-auto-centered.html: Added.
* css3/line-break/line-break-auto-half-kana-expected.html: Added.
* css3/line-break/line-break-auto-half-kana.html: Added.
* css3/line-break/line-break-auto-hyphens-expected.html: Added.
* css3/line-break/line-break-auto-hyphens.html: Added.
* css3/line-break/line-break-auto-inseparables-expected.html: Added.
* css3/line-break/line-break-auto-inseparables.html: Added.
* css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
* css3/line-break/line-break-auto-iteration-marks.html: Added.
* css3/line-break/line-break-auto-postfixes-expected.html: Added.
* css3/line-break/line-break-auto-postfixes.html: Added.
* css3/line-break/line-break-auto-prefixes-expected.html: Added.
* css3/line-break/line-break-auto-prefixes.html: Added.
* css3/line-break/line-break-auto-sound-marks-expected.html: Added.
* css3/line-break/line-break-auto-sound-marks.html: Added.
* css3/line-break/line-break-loose-centered-expected.html: Added.
* css3/line-break/line-break-loose-centered.html: Added.
* css3/line-break/line-break-loose-half-kana-expected.html: Added.
* css3/line-break/line-break-loose-half-kana.html: Added.
* css3/line-break/line-break-loose-hyphens-expected.html: Added.
* css3/line-break/line-break-loose-hyphens.html: Added.
* css3/line-break/line-break-loose-inseparables-expected.html: Added.
* css3/line-break/line-break-loose-inseparables.html: Added.
* css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
* css3/line-break/line-break-loose-iteration-marks.html: Added.
* css3/line-break/line-break-loose-postfixes-expected.html: Added.
* css3/line-break/line-break-loose-postfixes.html: Added.
* css3/line-break/line-break-loose-prefixes-expected.html: Added.
* css3/line-break/line-break-loose-prefixes.html: Added.
* css3/line-break/line-break-loose-sound-marks-expected.html: Added.
* css3/line-break/line-break-loose-sound-marks.html: Added.
* css3/line-break/line-break-normal-centered-expected.html: Added.
* css3/line-break/line-break-normal-centered.html: Added.
* css3/line-break/line-break-normal-half-kana-expected.html: Added.
* css3/line-break/line-break-normal-half-kana.html: Added.
* css3/line-break/line-break-normal-hyphens-expected.html: Added.
* css3/line-break/line-break-normal-hyphens.html: Added.
* css3/line-break/line-break-normal-inseparables-expected.html: Added.
* css3/line-break/line-break-normal-inseparables.html: Added.
* css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
* css3/line-break/line-break-normal-iteration-marks.html: Added.
* css3/line-break/line-break-normal-postfixes-expected.html: Added.
* css3/line-break/line-break-normal-postfixes.html: Added.
* css3/line-break/line-break-normal-prefixes-expected.html: Added.
* css3/line-break/line-break-normal-prefixes.html: Added.
* css3/line-break/line-break-normal-sound-marks-expected.html: Added.
* css3/line-break/line-break-normal-sound-marks.html: Added.
* css3/line-break/line-break-strict-centered-expected.html: Added.
* css3/line-break/line-break-strict-centered.html: Added.
* css3/line-break/line-break-strict-half-kana-expected.html: Added.
* css3/line-break/line-break-strict-half-kana.html: Added.
* css3/line-break/line-break-strict-hyphens-expected.html: Added.
* css3/line-break/line-break-strict-hyphens.html: Added.
* css3/line-break/line-break-strict-inseparables-expected.html: Added.
* css3/line-break/line-break-strict-inseparables.html: Added.
* css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
* css3/line-break/line-break-strict-iteration-marks.html: Added.
* css3/line-break/line-break-strict-postfixes-expected.html: Added.
* css3/line-break/line-break-strict-postfixes.html: Added.
* css3/line-break/line-break-strict-prefixes-expected.html: Added.
* css3/line-break/line-break-strict-prefixes.html: Added.
* css3/line-break/line-break-strict-sound-marks-expected.html: Added.
* css3/line-break/line-break-strict-sound-marks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBorder changes on tables with collapsed borders doesn't relayout table cells
tony@chromium.org [Tue, 19 Feb 2013 21:18:00 +0000 (21:18 +0000)]
Border changes on tables with collapsed borders doesn't relayout table cells
https://bugs.webkit.org/show_bug.cgi?id=109774

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/border-collapsing/dynamic-border-width-change.html

Changes to border top and border bottom on table rows also changes the size
of the table cell causing a relayout to be needed.

* rendering/RenderTableRow.cpp:
(WebCore::borderWidthChanged): Also include border top and bottom.
(WebCore::RenderTableRow::styleDidChange): Remove logical from the helper function name.

LayoutTests:

* fast/table/border-collapsing/dynamic-border-width-change-expected.txt: Added.
* fast/table/border-collapsing/dynamic-border-width-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a test result missed in r143074.
simon.fraser@apple.com [Tue, 19 Feb 2013 20:56:14 +0000 (20:56 +0000)]
Add a test result missed in r143074.

* platform/mac-wk2/tiled-drawing/null-parent-back-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Tue, 19 Feb 2013 20:49:40 +0000 (20:49 +0000)]
[Chromium] Unreviewed gardening.
Remove two now-passing tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaselined run-bindings-tests.
haraken@chromium.org [Tue, 19 Feb 2013 20:47:51 +0000 (20:47 +0000)]
Unreviewed. Rebaselined run-bindings-tests.

* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebGL] Fix oes-element-index-uint.html test.
commit-queue@webkit.org [Tue, 19 Feb 2013 20:43:48 +0000 (20:43 +0000)]
[WebGL] Fix oes-element-index-uint.html test.
https://bugs.webkit.org/show_bug.cgi?id=110045

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-19
Reviewed by Kenneth Russell.

This patch fixes the test case to use updated WebGLTestUtils functions
and adds shaders used during resized buffer tests. This patch
also enables the test for EFL port.

* fast/canvas/webgl/oes-element-index-uint-expected.txt:
* fast/canvas/webgl/oes-element-index-uint.html:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebAudio API: Change the Platform::createAudioDevice function to take a DeviceId...
tommyw@google.com [Tue, 19 Feb 2013 20:36:36 +0000 (20:36 +0000)]
WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter
https://bugs.webkit.org/show_bug.cgi?id=110192

Reviewed by Adam Barth.

* chromium/public/Platform.h:
(WebKit::Platform::createAudioDevice):
(Platform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][AC] Implement matrix transform animation with clutter ac backend
commit-queue@webkit.org [Tue, 19 Feb 2013 20:10:11 +0000 (20:10 +0000)]
[GTK][AC] Implement matrix transform animation with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=109848

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-02-19
Reviewed by Gustavo Noronha Silva.

Clutter 1.12 doesn't support additive transform animations yet, so the combination
of two or more transformations(such as rotation after translation) runs unexpectedly.
So we use a matrix transformation instead for the case.

Covered by existing animation tests.

* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
* platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::toClutterActorPropertyString): Add actor property "transform"
(WebCore::clutterMatrixProgress): Handle interpolation between two matrices instead of default clutter_matrix_progress.
(WebCore):
(WebCore::PlatformClutterAnimation::supportsAdditiveValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue): for TransformationMatrix.
(WebCore::PlatformClutterAnimation::setToValue): ditto.
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addTransformTransition):
* platform/graphics/clutter/PlatformClutterAnimation.h:
(PlatformClutterAnimation):
* platform/graphics/clutter/TransformationMatrixClutter.cpp: Add copy constructor for CoglMatrix.
(WebCore::TransformationMatrix::TransformationMatrix):
(WebCore):
* platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark fast/workers/storage/interrupt-database.html as flaky crasher
enne@google.com [Tue, 19 Feb 2013 20:01:48 +0000 (20:01 +0000)]
[chromium] Mark fast/workers/storage/interrupt-database.html as flaky crasher
https://bugs.webkit.org/show_bug.cgi?id=110247

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r143348.
commit-queue@webkit.org [Tue, 19 Feb 2013 19:39:54 +0000 (19:39 +0000)]
Unreviewed, rolling out r143348.
http://trac.webkit.org/changeset/143348
https://bugs.webkit.org/show_bug.cgi?id=110242

"Caused a deleted value sentinel crash on the layout tests"
(Requested by ggaren on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

* runtime/CodeCache.cpp:
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
* runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaselining, again, calendar tests
schenney@chromium.org [Tue, 19 Feb 2013 19:29:42 +0000 (19:29 +0000)]
Rebaselining, again, calendar tests
https://bugs.webkit.org/show_bug.cgi?id=110240

Unreviewed expectations update.

* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Removed.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Removed.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate FeatureObserver on top level navigation in addition to page destruction.
commit-queue@webkit.org [Tue, 19 Feb 2013 19:19:02 +0000 (19:19 +0000)]
Update FeatureObserver on top level navigation in addition to page destruction.
https://bugs.webkit.org/show_bug.cgi?id=109874

Patch by Kassy Coan <kassycoan@chromium.org> on 2013-02-19
Reviewed by Adam Barth.

No new tests. Only effect is to histogram more frequently.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidCommitLoad):
* page/FeatureObserver.cpp:
(WebCore::FeatureObserver::~FeatureObserver):
(WebCore):
(WebCore::FeatureObserver::updateMeasurements):
(WebCore::FeatureObserver::didCommitLoad):
* page/FeatureObserver.h:
(FeatureObserver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, changing primary email.
pravin.d@samsung.com [Tue, 19 Feb 2013 19:15:33 +0000 (19:15 +0000)]
Unreviewed, changing primary email.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unnecessary (and problematic) copy-constructor from LayoutUnit
commit-queue@webkit.org [Tue, 19 Feb 2013 19:10:45 +0000 (19:10 +0000)]
Remove unnecessary (and problematic) copy-constructor from LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=110121

This copy constructor does what a default copy constructor would do, so
it's not necessary. Furthermore, this copy constructor is the only
reason why LayoutUnit becomes non-POD, and that triggers a gdb bug,
making it impossible to do things like "print location()" when inside
some RenderBlock, for instance.

Gdb bug http://sourceware.org/bugzilla/show_bug.cgi?id=15154 reported.

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-02-19
Reviewed by Benjamin Poulain.

No tests. Apart from dealing with buggy debuggers, this is just code cleanup.

* platform/LayoutUnit.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: Sheriffbot is failing to process rollout requests
commit-queue@webkit.org [Tue, 19 Feb 2013 19:10:27 +0000 (19:10 +0000)]
REGRESSION: Sheriffbot is failing to process rollout requests
https://bugs.webkit.org/show_bug.cgi?id=106945

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-19
Reviewed by Adam Barth.

Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
This resolves problems when Sheriffbot attempts to perform a rollout request.

* EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
* EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
* EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRomanian translation for WebKitGtk+ HEAD
kov@webkit.org [Tue, 19 Feb 2013 19:08:11 +0000 (19:08 +0000)]
Romanian translation for WebKitGtk+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=110009

Patch by Mișu Moldovan <dumol@gnome.org> on 2013-02-19
Reviewed by Gustavo Noronha.

* ro.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [WK2] Cannot load documents with blob urls
ap@apple.com [Tue, 19 Feb 2013 19:06:40 +0000 (19:06 +0000)]
    [WK2] Cannot load documents with blob urls
        https://bugs.webkit.org/show_bug.cgi?id=110160

        Reviewed by Sam Weinig.

        * http/tests/fileapi/blob-url-in-subframe-expected.txt: Added.
        * http/tests/fileapi/blob-url-in-subframe.html: Added.
        * http/tests/fileapi/resources: Added.
        * http/tests/fileapi/resources/blob-url-in-subframe-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayoutUnit::epsilon shouldn't be necessary to place floats
eae@chromium.org [Tue, 19 Feb 2013 19:00:35 +0000 (19:00 +0000)]
LayoutUnit::epsilon shouldn't be necessary to place floats
https://bugs.webkit.org/show_bug.cgi?id=94000

Reviewed by Levi Weintraub.

Currently, to get float placement correct, we need to have an
epsilon tolerance in RenderBlock::computeLogicalLocationForFloat
for the width of the line to fit them on. This really shouldn't
be necessary, and probably indicates we're losing precision
elsewhere.

Remove epsilon as it no longer appears to be needed. All layout
tests pass without it.

No new tests, covered by existing tests.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoText Autosizing: prevent oscillation of font sizes during autosizing
commit-queue@webkit.org [Tue, 19 Feb 2013 18:57:31 +0000 (18:57 +0000)]
Text Autosizing: prevent oscillation of font sizes during autosizing
https://bugs.webkit.org/show_bug.cgi?id=108205

Patch by Tim Volodine <timvolodine@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

On some websites autosized font-sizes oscillate due to layouts caused by
hovering or incremental page loading (and on other sites font sizes do
eventually stabilize, but it takes many layouts before they reach a steady
size). To prevent all these cases, we no longer allow the autosizing
multiplier to change after it has been set (to a value other than 1).

This won't always give exactly the same results, but testing on 2000 top
sites shows that this makes little difference in practice, and it prevents
these very jarring cases. As a happy side-effect, this speeds up layouts
as font sizes change less.

Test: fast/text-autosizing/oscillation-javascript-fontsize-change.html

* page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
* page/Settings.cpp:
(WebCore::Settings::setTextAutosizingFontScaleFactor):
* rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::recalculateMultipliers):
(WebCore):
(WebCore::TextAutosizer::processContainer):
* rendering/TextAutosizer.h:
(TextAutosizer):

LayoutTests:

Added overflow-y:hidden to some existing tests, since previously those tests
would start off with incorrect multipliers (because mainFrame->view()-layoutSize()
is initially 785 instead of 800 as ScrollView wrongly guesses a scrollbar will
be needed), and then the multipliers would get corrected on a subsequent layout.
Now that we don't allow the multiplier to change after being set, it needs to be
right first time.
Also added specific oscillation test triggered by javascript.

* fast/text-autosizing/constrained-height-body-expected.html:
* fast/text-autosizing/constrained-height-body.html:
* fast/text-autosizing/constrained-then-float-ancestors-expected.html:
* fast/text-autosizing/constrained-then-float-ancestors.html:
* fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
* fast/text-autosizing/constrained-then-position-fixed-ancestors.html:
* fast/text-autosizing/nested-em-line-height-expected.html:
* fast/text-autosizing/nested-em-line-height.html:
* fast/text-autosizing/oscillation-javascript-fontsize-change-expected.html: Added.
* fast/text-autosizing/oscillation-javascript-fontsize-change.html: Added.
* fast/text-autosizing/simple-paragraph-expected.html:
* fast/text-autosizing/simple-paragraph.html:
* fast/text-autosizing/span-child-expected.html:
* fast/text-autosizing/span-child.html:
* fast/text-autosizing/unwrappable-blocks-expected.html:
* fast/text-autosizing/unwrappable-blocks.html:
* fast/text-autosizing/unwrappable-inlines-expected.html:
* fast/text-autosizing/unwrappable-inlines.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix races in double-tap zoom minimum scale policy
aelias@chromium.org [Tue, 19 Feb 2013 18:42:27 +0000 (18:42 +0000)]
[chromium] Fix races in double-tap zoom minimum scale policy
https://bugs.webkit.org/show_bug.cgi?id=110183

Reviewed by Adam Barth.

Double-tap zoom on Android is supposed to return to minimum scale
if no pinch zoom occurred since the last double-tap. Because both
pinch zoom and the result of double-tap zoom gets passed in from CC
via applyScrollAndScale, this logic was brittle and prone to races
depending on when the animation update was received. This patch
keeps track of what the target double-tap scale is to make it more
robust.

I also fixed double-tap zoom test mocking to exercise the entire
page scale animation flow (our previous way of testing was hiding the
raciness), and added a new test case in DivAutoZoomMultipleParamsTest.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::startPageScaleAnimation):
(WebKit):
(WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::animateZoomAroundPoint):
(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::applyScrollAndScale):
* src/WebViewImpl.h:
(WebViewImpl):
(WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting):
(WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting):
(WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting):
(WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting):
* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143355 268f45cc-cd09-0410-ab3c-d52691b4dbfc