kevino@webkit.org [Wed, 21 Nov 2007 01:14:27 +0000 (01:14 +0000)]
wx build fix for Windows. Don't use WebCore/move-js-headers.sh as it indiscriminately copies any headers inside JavaScriptCore, which includes Tiger ICU headers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 20 Nov 2007 22:11:51 +0000 (22:11 +0000)]
2007-11-20 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Avoid pointlessly mallocing and freeing this transform matrix.
* platform/gtk/FontPlatformDataGtk.cpp:
(WebCore::FontPlatformData::FontPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 20 Nov 2007 21:46:26 +0000 (21:46 +0000)]
2007-11-20 Naiem Shaik <naiem.shaik@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15763
[GTK] Enter key does not take to the link highlighted.
Add missing keycode cases.
* platform/gtk/KeyEventGtk.cpp:
(WebCore::keyIdentifierForGdkKeyCode):
(WebCore::windowsKeyCodeForKeyEvent):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 20 Nov 2007 21:36:34 +0000 (21:36 +0000)]
Fix http://bugs.webkit.org/show_bug.cgi?id=16074
Bug 16074: execCommand("InsertHorizontalRule", false, "") results in id="" being inserted
For consistency with InsertOrderedList and InsertUnorderedList a value parameter of "" should
not result in an id being set.
Reviewed by Sam Weinig.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Tue, 20 Nov 2007 18:01:54 +0000 (18:01 +0000)]
* Prepend git branch name to $baseProductDir
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 20 Nov 2007 17:38:54 +0000 (17:38 +0000)]
Reviewed by Adam Roben.
- fix <rdar://problem/
5090708> Textareas render broken-looking scrollbars when too short to show full scrollbar
* platform/win/PlatformScrollBar.h:
* platform/win/PlatformScrollBarSafari.cpp:
Added the "hit inset" constants (representing how far the track eats
into the button).
(WebCore::PlatformScrollbar::paint): Changed to paint the buttons and
the thumb only if they should be showing.
(WebCore::PlatformScrollbar::hasButtons): Added. Returns whether the
arrows should be drawn.
(WebCore::PlatformScrollbar::hasThumb): Added. Returns whether the thumb
should be drawn.
(WebCore::PlatformScrollbar::forwardButtonRect):
(WebCore::PlatformScrollbar::trackRect): Changed to return the entire
bounds of the scrollbar if the scrollbar has no buttons.
(WebCore::PlatformScrollbar::paintTrack): Changed to paint a disabled
track along the entire scrollbar if it has not buttons.
(WebCore::PlatformScrollbar::hitTest): Changed to hit test only the
parts that the scrollbar has in its current dimensions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 20 Nov 2007 16:06:23 +0000 (16:06 +0000)]
2007-11-20 Mark Rowe <mrowe@apple.com>
Reviewed by Alp Toker.
* WebKit.pri: Add in -Wno-unused-parameter to silence warnings in WebCore.
2007-11-20 Mark Rowe <mrowe@apple.com>
Reviewed by Alp Toker.
* config.h: Change #if to #ifdef to silence warnings on non-Apple platforms.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 20 Nov 2007 15:53:35 +0000 (15:53 +0000)]
2007-11-20 Mark Rowe <mrowe@apple.com>
Reviewed by Simon Hausmann.
* Scripts/build-webkit: Pass "clean" flag down into buildQMakeProject.
* Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
Have it trigger a "make distclean" rather than "make clean" to ensure that the
built product and generated Makefile's are removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 20 Nov 2007 15:35:49 +0000 (15:35 +0000)]
2007-11-20 Alp Toker <alp@atoker.com>
Reviewed by Simon Hausmann.
Clean up GTK+ port configuration.
Use similar compiler warning flags to the Mac build.
Add the qmake changes needed for DirectFB support.
* WebKit.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 20 Nov 2007 15:27:36 +0000 (15:27 +0000)]
Remove static linkage of QtWebKit against the ICO image format plugin.
Instead build the support for the ICO image format as a proper standalone qt image format plugin and install it.
Signed-off-by: Adam Treat <treat@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Tue, 20 Nov 2007 14:52:27 +0000 (14:52 +0000)]
Fix typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Tue, 20 Nov 2007 14:48:57 +0000 (14:48 +0000)]
no-svg build broken after r27278
<http://bugs.webkit.org/show_bug.cgi?id=16061>
Reviewed by Eric.
* bindings/scripts/CodeGeneratorObjC.pm: Always generate DOMHTMLEmbedElementPrivate.h
and DOMHTMLObjectElementPrivate.h for no-svg build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 20 Nov 2007 14:23:28 +0000 (14:23 +0000)]
Added a default argument to textContent for the hoveringOverLink signal to keep existing two-argument connections working
Signed-off-by: George Staikos <staikos@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Tue, 20 Nov 2007 13:26:30 +0000 (13:26 +0000)]
* Don't use so much heap memory.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Tue, 20 Nov 2007 12:37:03 +0000 (12:37 +0000)]
* Make gif animations work for instance.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 20 Nov 2007 09:06:06 +0000 (09:06 +0000)]
Add an argument to pass the link text in the hovering signal
Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 20 Nov 2007 09:03:00 +0000 (09:03 +0000)]
Adjust some test result after fixing a bug related to computation
of QFont::xHeight() in Qt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 20 Nov 2007 09:02:36 +0000 (09:02 +0000)]
Fix text break interators.
The break iterators where trying to be smart about the input
string and caching their results. Unfortunately a pointer/string length
comparison is not good enough in all cases (since some input is stack based
temp strings). Removed the caching but at the same time started to use a more
efficient constructor of QTextBoundaryFinder that doesn't need to malloc for
most strings.
Fixes two test cases that test "text-transform: capitalize".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Tue, 20 Nov 2007 08:50:44 +0000 (08:50 +0000)]
* Build in release mode
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Tue, 20 Nov 2007 08:29:26 +0000 (08:29 +0000)]
* Be quiet and allow suppression of NotImplemented calls at runtime.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 20 Nov 2007 02:39:31 +0000 (02:39 +0000)]
2007-11-19 Doug Turner <dougt@meer.net>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16054
Crash when GlyphPage::fill is called with more than 256 bytes of data
http://bugs.webkit.org/show_bug.cgi?id=14446
[GDK] Crash on http://www.wikipedia.org/
setGlyphDataForIndex() uses a fixed array of size 256 which we can't
exceed. We need to return failure if the buffer has Unicode
supplementary characters for now.
This strategy matches the Win port, which also doesn't support this
case yet.
Add an assertion so nobody makes this mistake again.
* platform/GlyphPageTreeNode.h:
(WebCore::GlyphPage::setGlyphDataForIndex):
* platform/gtk/GlyphPageTreeNodeGtk.cpp:
(WebCore::GlyphPage::fill):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Tue, 20 Nov 2007 00:24:49 +0000 (00:24 +0000)]
wx port build fix (wx headers include ctype functions).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 19 Nov 2007 22:53:07 +0000 (22:53 +0000)]
Rubber-stamped by bdash.
Improve coverage of these tests.
* media/video-muted-expected.txt:
* media/video-muted.html:
* media/video-volume-expected.txt:
* media/video-volume.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Mon, 19 Nov 2007 19:00:54 +0000 (19:00 +0000)]
Remove outdated and unused Windows port files.
Reviewed by Adam Roben.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 19 Nov 2007 18:01:58 +0000 (18:01 +0000)]
2007-11-19 Doug Turner <dougt@meer.net>
Reviewed by Timothy Hatcher.
http://bugs.webkit.org/show_bug.cgi?id=16050
sqlite3_prepare16_v2 build bustage.
Using the correct SQLITE_VERSION_NUMBER around sqlite_prepare16_v2
to fix build bustage.
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 19 Nov 2007 17:56:33 +0000 (17:56 +0000)]
2007-11-19 Mark Rowe <mrowe@apple.com>
Build fix. Don't over-qualify the constructor name.
* storage/DatabaseDetails.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 19 Nov 2007 17:51:44 +0000 (17:51 +0000)]
WebCore:
Reviewed by Maciej
Stub out the WebCore parts of the WebKit API
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* storage/DatabaseDetails.h: Added. Simple container for vitals on a specific database
(WebCore::DatabaseDetails::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::isValid):
(WebCore::DatabaseDetails::name):
(WebCore::DatabaseDetails::version):
(WebCore::DatabaseDetails::displayName):
(WebCore::DatabaseDetails::expectedUsage):
(WebCore::DatabaseDetails::currentUsage):
* storage/DatabaseTracker.cpp: Added various methods for API usage
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
* storage/DatabaseTracker.h:
WebKit:
Reviewed by Maciej
* WebKit.xcodeproj/project.pbxproj: Sorted!
WebKit/mac:
Reviewed by Maciej
Finished hooking up the WebKit API for database management.
Most of the API is actually implemented in WebCore and some of those methods might
only be stubs for now.
* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager origins]): Call through to the WebCore tracker and construct an API result
(-[WebDatabaseManager databasesWithOrigin:]): Ditto
(-[WebDatabaseManager detailsForDatabase:withOrigin:]): Ditto
* Storage/WebSecurityOrigin.mm:
(-[WebSecurityOrigin usage]): Call through to WebCore
(-[WebSecurityOrigin quota]): Ditto
(-[WebSecurityOrigin setQuota:]): Ditto
(-[WebSecurityOrigin _core]): Get WebCore version of this object
* Storage/WebSecurityOriginInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Mon, 19 Nov 2007 17:28:38 +0000 (17:28 +0000)]
wx port build fix for !USE(WXGC).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 19 Nov 2007 15:59:17 +0000 (15:59 +0000)]
2007-11-19 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=16040
[GTK] GtkLauncher should be written in C
Port GtkLauncher to plain C.
Use a more conventional GTK+ coding style.
Use a toolbar instead of menus.
Various signature fixes and cleanups.
Add a license header. Assume all previous modifications were copyright
assigned to Apple Inc. by default.
* GtkLauncher/GtkLauncher.pro:
* GtkLauncher/main.c: Added.
(activate_url_entry_cb):
(update_title):
(link_hover_cb):
(title_change_cb):
(progress_change_cb):
(destroy_cb):
(go_back_cb):
(go_forward_cb):
(create_browser):
(create_statusbar):
(create_toolbar):
(create_window):
(main):
* GtkLauncher/main.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 19 Nov 2007 15:53:38 +0000 (15:53 +0000)]
2007-11-19 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
GTK+ drawing fixes.
Add a check to avoid crashing when the GraphicsContext is not
associated with a GdkDrawable. This was noticed when adding printing
support but might be triggered in other situations too.
Do not render themes when painting is disabled. This is an
optimisation for cases where GraphicsContext is used to calculate page
dimensions etc. without actually rendering.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::gdkDrawable):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::paintMozWidget):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Mon, 19 Nov 2007 15:33:55 +0000 (15:33 +0000)]
* Don't segfault when event pos is outside of the widget.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 19 Nov 2007 13:43:55 +0000 (13:43 +0000)]
2007-11-13 Rahul Abrol <ra5ul@comcast.net>
Reviewed by Tim Hatcher.
http://bugs.webkit.org/show_bug.cgi?id=15977
Resizing images preference now toggles default image state.
* loader/ImageDocument.cpp:
(WebCore::ImageDocument::ImageDocument):
(WebCore::ImageDocument::createDocumentStructure):
(WebCore::ImageDocument::imageChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 19 Nov 2007 13:02:46 +0000 (13:02 +0000)]
Roll out r27896 as it caused lots of build breakages.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 19 Nov 2007 12:51:30 +0000 (12:51 +0000)]
2007-11-19 Mark Rowe <mrowe@apple.com>
Build fix.
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::initFrameBuffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 19 Nov 2007 12:47:52 +0000 (12:47 +0000)]
2007-11-19 Mark Rowe <mrowe@apple.com>
Build fix.
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::initFrameBuffer): Remove reference to SkBitmap type that doesn't belong.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 19 Nov 2007 12:37:13 +0000 (12:37 +0000)]
2007-11-19 Kevin Ollivier <kevino@theolliviers.com>
Build script fixes to ensure they do the right thing for the
wx port, and update build-wxwebkit to reflect the way the
build scripts now work.
Reviewed by Adam.
* Scripts/build-testkjs:
* Scripts/build-webkit:
* Scripts/run-javascriptcore-tests:
* Scripts/webkitdirs.pm:
* wx/build-wxwebkit:
2007-11-19 Kevin Ollivier <kevino@theolliviers.com>
Add pcre directory to JSCore includes, and update the wx port
to reflect the Shared -> RefCounted name change. Also, fix
WebFrame.cpp to re-enable code that should never have been
committed disabled.
Reviewed by Adam.
2007-11-19 Kevin Ollivier <kevino@theolliviers.com>
Update wx port build sources with recent changes, update
wx FontPlatformData to be a class (MSVC7 gets confused
otherwise...) and implement its hash() method.
Reviewed by Adam.
* WebCoreSources.bkl:
* platform/wx/FontPlatformData.h:
(WebCore::FontPlatformData::hash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 19 Nov 2007 12:30:34 +0000 (12:30 +0000)]
2007-11-19 Julien Chaffraix <julien.chaffraix@gmail.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12194
Bug 12194: Trying to access XMLHttpRequest.responseText or responseXML when they
are not available should raise an exception
Tests: http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html
http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::JSXMLHttpRequest::getValueProperty):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::getResponseText):
(WebCore::XMLHttpRequest::getResponseXML):
* xml/XMLHttpRequest.h:
2007-11-19 Julien Chaffraix <julien.chaffraix@gmail.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12194
Bug 12194: Trying to access XMLHttpRequest.responseText or responseXML when they are not
available should raise an exception
* http/tests/xmlhttprequest/xmlhttprequest-responseText-exception-expected.txt: Added.
* http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html: Added.
* http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception-expected.txt: Added.
* http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html: Added.
* http/tests/xmlhttprequest/zero-length-response-expected.txt: Updated result
* http/tests/xmlhttprequest/zero-length-response-sync-expected.txt: Updated result
* http/tests/xmlhttprequest/zero-length-response-sync.html: Corrected URL & added
exception handling to test case
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 19 Nov 2007 12:22:50 +0000 (12:22 +0000)]
2007-11-19 Peter Kasting <zerodpx@gmail.com>
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=15971
The GIF decoder should not fail decoding if the caller asks it to
decode again when no new data has arrived since the last call.
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 19 Nov 2007 12:22:19 +0000 (12:22 +0000)]
2007-11-19 Peter Kasting <zerodpx@gmail.com>
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=15974
GIF decoding should respect frames' specified disposal methods.
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::):
(WebCore::RGBA32Buffer::RGBA32Buffer):
(WebCore::RGBA32Buffer::disposalMethod):
(WebCore::RGBA32Buffer::setDisposalMethod):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::initFrameBuffer):
(WebCore::GIFImageDecoder::prepEmptyFrameBuffer):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
* platform/image-decoders/gif/GIFImageReader.h:
(GIFFrameReader::GIFFrameReader):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 19 Nov 2007 07:14:37 +0000 (07:14 +0000)]
Reviewed by Eric
Fix a crash hashing a default SecurityOriginData object
* storage/DatabaseTracker.cpp:
(WebCore::SecurityOriginDataHash::hash): The default object has some default strings with NULL
StringImpls - don't try to hash those!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 19 Nov 2007 00:40:38 +0000 (00:40 +0000)]
2007-11-18 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
* tests/mozilla/jsDriver.pl: exit non-0 when user aborts test run
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sun, 18 Nov 2007 23:04:19 +0000 (23:04 +0000)]
Reviewed by Sam Weinig.
Bug 16043: Remove InspectorController.log now that console.log works
http://bugs.webkit.org/show_bug.cgi?id=16043
Remove the last uses of InspectorController.log. Once use was no longer needed,
checking an erro case that can't happen anymore. The other case now uses console.error.
* page/InspectorController.cpp: Remove the log function.
(WebCore::InspectorController::windowScriptObjectAvailable): Remove the log function from
InspectorController script class.
* page/inspector/DocumentPanel.js: Remove a use of InspectorController.log that isn't needed.
* page/inspector/Panel.js: Change InspectorController.log to console.log and early return.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sun, 18 Nov 2007 23:01:03 +0000 (23:01 +0000)]
Reviewed by Brady.
Bug 16041: REGRESSION: the Database panel in the Inspector stopped showing errors
http://bugs.webkit.org/show_bug.cgi?id=16041
* page/inspector/DatabasePanel.js: Implement error callbacks to pass to executeSql()
and transaction(). Refactored some code for the success and error callbacks to use.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sun, 18 Nov 2007 22:18:49 +0000 (22:18 +0000)]
2007-11-18 Eric Seidel <eric@webkit.org>
Reviewed by Anders.
Make run-javascriptcore-tests report failures on exit (to support git bisect)
* Scripts/run-javascriptcore-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sun, 18 Nov 2007 17:54:55 +0000 (17:54 +0000)]
Reviewed by Adam Roben.
Make run-webkit-tests work with Windows debug build.
* DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
* DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sun, 18 Nov 2007 17:15:24 +0000 (17:15 +0000)]
Add wxWebKit sample and build script, and integrate it with build-webkit. Also make build-webkit --clean work for all ports.
Reviewed by Darin Adler.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sun, 18 Nov 2007 11:31:04 +0000 (11:31 +0000)]
2007-11-18 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented
Correct script-prompt to return NULL when cancelled.
Small changes to avoid compiler warnings.
* Api/webkitgtkpage.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sun, 18 Nov 2007 09:49:21 +0000 (09:49 +0000)]
Restoring a binary svn:mime-type on the test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sun, 18 Nov 2007 09:46:05 +0000 (09:46 +0000)]
Reviewed by Maciej.
<rdar://problem/
5546393> Whitespace handling doesn't match HTML5.
HTML5 definition is the same as MSIE's, with the exception that the latter strips null
characters. Firefox also treats U+0008 as whitespace, but not U+000B or U+000C.
Test: fast/parser/html-whitespace.html
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::parseSpecial):
(WebCore::HTMLTokenizer::parseTag):
Use isASCIISpace, which matches HTML5 definition of whitespace, and also what we use to
check for whitespace almost everywhere.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 18 Nov 2007 09:09:27 +0000 (09:09 +0000)]
Fix: <rdar://problem/
5607032> (REGRESSION: testapi exits with assertion failure in debug build) and <rdar://problem/
5440659> (JSGlobalContextCreate throws away globalObjectClass's prototype)
Split Interpreter's initialization into two distinct steps: the creation of the global prototypes
and constructors, and storing them on the global object. This allows JSClassRef's passed to
JSGlobalContextCreate to be instantiated with the correct prototype.
Reviewed by Darin Adler.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sun, 18 Nov 2007 06:58:49 +0000 (06:58 +0000)]
Attempt to fix port builds.
'
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sun, 18 Nov 2007 06:40:27 +0000 (06:40 +0000)]
WebCore:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
Add support for localization to the Web Inspector. Clients need to
implement localizedStringsURL() to return the URL of the
InspectorLocalizedStrings.js that best matches the user's language.
* English.lproj: Added.
* English.lproj/InspectorLocalizedStrings.js: Added.
* WebCore.xcodeproj/project.pbxproj: Add InspectorLocalizedStrings.js.
* page/InspectorClient.h: Add localizedStringsURL.
* page/InspectorController.cpp: Add localizedStringsURL that calls
the client. Also added a version exposed to JavaScript.
* page/InspectorController.h: Add localizedStringsURL.
* page/inspector/ConsolePanel.js: Call WebInspector.UIString
for user visible strings.
* page/inspector/DatabasePanel.js: Ditto.
* page/inspector/DocumentPanel.js: Ditto.
* page/inspector/ImagePanel.js: Ditto.
* page/inspector/MetricsSidebarPane.js: Ditto.
* page/inspector/NetworkPanel.js: Ditto.
* page/inspector/Panel.js: Ditto.
* page/inspector/PropertiesSidebarPane.js: Ditto.
* page/inspector/Resource.js: Ditto.
* page/inspector/ResourceCategory.js: Ditto.
* page/inspector/SourcePanel.js: Ditto.
* page/inspector/StylesSidebarPane.js: Ditto.
* page/inspector/inspector.css: Use pre-wrap so database errors can use \n.
* page/inspector/inspector.html: Remove some user visible strings.
* page/inspector/inspector.js: Added WebInspector.UIString and call
WebInspector.UIString for user visible strings. Some code needed to be
moved to WebInspector.loaded to use UIString after the localized strings
get loaded.
* platform/graphics/svg/SVGImageEmptyClients.h:
(WebCore::SVGEmptyFrameLoaderClient::redirectDataToPlugin): Remove WebCore:: prefix.
(WebCore::SVGEmptyInspectorClient::createPage): Ditto.
(WebCore::SVGEmptyInspectorClient::localizedStringsURL): Add empty stub.
(WebCore::SVGEmptyInspectorClient::highlight): Remove WebCore:: prefix.
(WebCore::SVGEmptyInspectorClient::inspectedURLChanged): Ditto.
WebKit:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
Update the localized strings and the file encoding of WebInspectorClient.mm.
* English.lproj/Localizable.strings:
* StringsNotToBeLocalized.txt:
* WebKit.xcodeproj/project.pbxproj:
WebKit/gtk:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::localizedStringsURL): Empty stub.
* WebCoreSupport/InspectorClientGtk.h: Add localizedStringsURL.
WebKit/mac:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
Implement the localizedStringsURL() client method to return the
localized URL of InspectorLocalizedStrings.js in WebCore.
* WebCoreSupport/WebInspectorClient.h: Added localizedStringsURL.
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::localizedStringsURL): Added.
(WebInspectorClient::updateWindowTitle): Localized the window title.
(-[WebInspectorWindowController init]): Remove a FIXME that dosen't make sense anymore.
(-[WebInspectorWindowController initWithInspectedWebView:]): Code style cleanup.
WebKit/qt:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::localizedStringsURL): Empty stub.
* WebCoreSupport/InspectorClientQt.h: Added localizedStringsURL.
WebKit/win:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
* English.lproj/Localizable.strings: Updated.
* WebInspectorClient.cpp:
(WebInspectorClient::localizedStringsURL): Empty stub.
* WebInspectorClient.h: Added localizedStringsURL.
WebKit/wx:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
* WebKitSupport/InspectorClientWx.cpp:
(WebCore::InspectorClientWx::localizedStringsURL): Empty stub.
* WebKitSupport/InspectorClientWx.h: Added localizedStringsURL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 18 Nov 2007 05:36:52 +0000 (05:36 +0000)]
Prevent testapi from reporting false leaks.
Clear out local variables pointing at JSObjectRefs to allow their values to be collected.
Reviewed by Sam Weinig.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 18 Nov 2007 05:36:29 +0000 (05:36 +0000)]
Prevent testapi from crashing if testapi.js can not be found by nil-checking the result of createStringWithContentsOfFile.
Reviewed by Sam Weinig.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sun, 18 Nov 2007 01:14:41 +0000 (01:14 +0000)]
Remove IDL files from the WebCore.framework Resources.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 17 Nov 2007 23:14:40 +0000 (23:14 +0000)]
2007-11-17 Alp Toker <alp@atoker.com>
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=16032
JS minidom is not portable
Use a plain UTF-8 string instead of a CFString.
Print to stdout, not stderr like CFShow() would have done, since that
behaviour seems unintentional.
* API/minidom.c:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Sat, 17 Nov 2007 20:49:33 +0000 (20:49 +0000)]
Make it easy to run Safari in the debugger on Windows
WebKitSite:
Update Windows debugging instructions
Reviewed by Mark Rowe.
* building/debug.html:
WebKitTools:
Make it easy to run Safari in the debugger on Windows
I've added a new script, debug-safari, which launches Safari in the
debugger. On OS X it just calls gdb-safari.
Reviewed by Mark Rowe.
* FindSafari/FindSafari.cpp:
(_tmain): Added a /debugger flag, which in combination with
/printSafariLauncher will print a script that launches Safari in the
debugger.
* Scripts/debug-safari: Added.
* Scripts/run-safari: Changed to call runSafari().
* Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
vsvars32.bat, which will let us find VS/VC++ Express, and passes the
first argument along to FindSafari.
* Scripts/webkitdirs.pm:
(sub runSafari): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sat, 17 Nov 2007 20:02:10 +0000 (20:02 +0000)]
Reviewed by Adam.
Reworte String.sprintf to fix many bad bugs and to not use RegExp. Also added
String.vsprintf so it can be used later for the localization function.
This version only supports argument reordering, precision for floats, and these
format characters: d, f, s and @. Any unsupported format characters are logged
and substituted like strings.
* page/inspector/utilities.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Sat, 17 Nov 2007 16:53:38 +0000 (16:53 +0000)]
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sat, 17 Nov 2007 10:39:11 +0000 (10:39 +0000)]
Windows build fix
WebKit:
* WebView.cpp:
(WebView::deleteSelection): Use canSmartCopyOrDelete() directly.
WebCore:
* editing/Editor.h: Made canSmartCopyOrDelete public, as Windows WebView still needs it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sat, 17 Nov 2007 08:58:24 +0000 (08:58 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15969
Eliminate Editor::deleteRange()
No change in functionality.
WebCore:
* editing/CompositeEditCommand.h: Removed unimplemented deleteKeyPressed().
* editing/Editor.cpp:
(WebCore::Editor::deleteWithDirection):
(WebCore::Editor::cut):
(WebCore::Editor::performDelete):
* editing/Editor.h:
Moved relevant Editor::deleteRange() functionality to its callers.
Removed deleteSelectionWithSmartDelete(void), which was more confusing than helpful
in my opinion.
* editing/mac/EditorMac.mm:
(WebCore::initializeKillRingIfNeeded):
(WebCore::Editor::addToKillRing):
(WebCore::Editor::yank):
(WebCore::Editor::yankAndSelect):
(WebCore::Editor::setMark):
(WebCore::unionDOMRanges):
(WebCore::Editor::deleteToMark):
(WebCore::Editor::selectToMark):
(WebCore::Editor::swapWithMark):
Pushed kill ring handling down from WebCore.
* page/mac/WebCoreFrameBridge.h:
* page/mac/WebCoreFrameBridge.mm:
Removed setMarkDOMRange (the corresponding getter is still needed).
* WebCore.base.exp: No longer need to export Editor::deleteRange() and Editor::insertTextWithoutSendingTextEvent().
Export the new kill ring functions.
WebKit:
* WebView/WebHTMLView.mm:
(+[WebHTMLView initialize]):
(-[WebHTMLView yank:]):
(-[WebHTMLView yankAndSelect:]):
(-[WebHTMLView setMark:]):
(-[WebHTMLView deleteToMark:]):
(-[WebHTMLView selectToMark:]):
(-[WebHTMLView swapWithMark:]):
Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sat, 17 Nov 2007 08:28:23 +0000 (08:28 +0000)]
Reviewed by Adam Roben.
* Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sat, 17 Nov 2007 06:47:50 +0000 (06:47 +0000)]
2007-11-16 Ryan Leavengood <leavengood@gmail.com>
Reviewed by David Kilzer.
Build fix: the needed headers for POSIX file functions were not
included.
* platform/posix/FileSystemPOSIX.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sat, 17 Nov 2007 06:42:36 +0000 (06:42 +0000)]
2007-11-16 Ryan Leavengood <leavengood@gmail.com>
Reviewed by David Kilzer.
The git config command was renamed to repo-config at some point. This
change tries git config and then git repo-config if the first fails.
* Scripts/prepare-ChangeLog:
(gitConfig):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 17 Nov 2007 05:10:41 +0000 (05:10 +0000)]
WebCore:
Reviewed by Darin Adler.
- fix the common case of <http://bugs.webkit.org/show_bug.cgi?id=15994>
REGRESSION: Incomplete repaint of CSS image substitution
Test: fast/repaint/clip-with-layout-delta.html
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState): Account for layout delta when
pushing additional clip.
LayoutTests:
Reviewed by Darin Adler.
- repaint test for <http://bugs.webkit.org/show_bug.cgi?id=15994>
REGRESSION: Incomplete repaint of CSS image substitution
* fast/repaint/clip-with-layout-delta.html: Added.
* platform/mac/fast/repaint/clip-with-layout-delta-expected.checksum: Added.
* platform/mac/fast/repaint/clip-with-layout-delta-expected.png: Added.
* platform/mac/fast/repaint/clip-with-layout-delta-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 17 Nov 2007 04:05:51 +0000 (04:05 +0000)]
Reviewed by Adam.
<rdar://problem/
5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.
Add wkSetCFURLRequestShouldContentSniff.
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:
* win/lib/WebKitSystemInterface_debug.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sat, 17 Nov 2007 02:13:48 +0000 (02:13 +0000)]
Fix ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sat, 17 Nov 2007 02:10:16 +0000 (02:10 +0000)]
WebCore:
Reviewed by Adele.
Seeking related fixes, updates match to the latest specification
- rename loopCount of HTMLMediaElement to playCount
- add explicit seeking attribute to HTMLMediaElement to get semantics right
- implement the specification behavior that currentTime must immediately return seeked position in HTMLMediaElement
instead of MoviePrivateQTKit
- fix broken behavior when seeking past end of the media, add tests
- replace Movie didEnd callback with broader timeChanged callback (which gets called in didEnd case too)
- use setDelayCallbacks: in various MoviePrivateQTKit methods to avoid bug prone synchronous callbacks from QT, make
HTMLMediaElement not depend on synchronous callbacks
- do some cleanups and simplifications in MoviePrivateQTKit, get rid of m_rateBeforeSeek and m_blockStateUpdate variables
Tests: http/tests/media/video-seekable-stall.html
media/video-seeking.html
media/video-seek-past-end-paused.html
media/video-seek-past-end-playing.html
* html/HTMLAttributeNames.in:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::movieNetworkStateChanged):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::seeking):
(WebCore::HTMLMediaElement::currentTime):
(WebCore::HTMLMediaElement::ended):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::playCount):
(WebCore::HTMLMediaElement::setPlayCount):
(WebCore::HTMLMediaElement::checkIfSeekNeeded):
(WebCore::HTMLMediaElement::movieTimeChanged):
(WebCore::HTMLMediaElement::endedPlayback):
(WebCore::HTMLMediaElement::updateMovie):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* platform/graphics/Movie.cpp:
(WebCore::Movie::timeChanged):
* platform/graphics/Movie.h:
(WebCore::MovieClient::movieTimeChanged):
* platform/graphics/mac/MoviePrivateQTKit.h:
* platform/graphics/mac/MoviePrivateQTKit.mm:
(WebCore::MoviePrivate::MoviePrivate):
(WebCore::MoviePrivate::load):
(WebCore::MoviePrivate::play):
(WebCore::MoviePrivate::pause):
(WebCore::MoviePrivate::currentTime):
(WebCore::MoviePrivate::seek):
(WebCore::MoviePrivate::doSeek):
(WebCore::MoviePrivate::cancelSeek):
(WebCore::MoviePrivate::seekTimerFired):
(WebCore::MoviePrivate::startCuePointTimerIfNeeded):
(WebCore::MoviePrivate::paused):
(WebCore::MoviePrivate::updateStates):
(WebCore::MoviePrivate::timeChanged):
(WebCore::MoviePrivate::didEnd):
LayoutTests:
Reviewed by Adele.
Seeking related test updates
- update to match specificiation
- rename loopCount to playCount everywhere
- timeupdate events during seek
- fix that some tests (like audio ones) depended on timing sensitive ordering of play and load events
- add text about what is being tested
Add new tests for seeking past end, seeking past loaded position and 'seeking' DOM attribute.
* http/tests/media/video-seekable-stall-expected.txt: Added.
* http/tests/media/video-seekable-stall.html: Added.
* media/audio-constructor-expected.txt:
* media/audio-constructor-src-expected.txt:
* media/audio-constructor-src.html:
* media/audio-constructor.html:
* media/video-dom-loopcount-expected.txt:
* media/video-dom-loopcount.html:
* media/video-dom-loopend-expected.txt:
* media/video-dom-loopend.html:
* media/video-dom-loopstart-expected.txt:
* media/video-dom-loopstart.html:
* media/video-dom-start-expected.txt:
* media/video-dom-start.html:
* media/video-loopcount-expected.txt:
* media/video-loopcount.html:
* media/video-loopend-expected.txt:
* media/video-loopend.html:
* media/video-loopstart-expected.txt:
* media/video-loopstart.html:
* media/video-seek-past-end-paused-expected.txt: Added.
* media/video-seek-past-end-paused.html: Added.
* media/video-seek-past-end-playing-expected.txt: Added.
* media/video-seek-past-end-playing.html: Added.
* media/video-seeking-expected.txt: Added.
* media/video-seeking.html: Added.
* media/video-test.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 17 Nov 2007 01:32:01 +0000 (01:32 +0000)]
WebCore:
Reviewed by Adam.
<rdar://problem/
5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::makeFinalRequest):
Add new parameter which controls whether content sniffing should be turned off.
(WebCore::ResourceHandle::loadResourceSynchronously):
Always content sniff sync loads.
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
If the ResourceRequest already has a backing CFURLRequest, make a copy of it. This preserves
any properties set on the CFURLRequest.
LayoutTests:
Reviewed by Adam.
<rdar://problem/
5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.
Remove http/tests/xmlhttprequest/small-chunks-response-text.html from the Skipped list.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 17 Nov 2007 01:25:55 +0000 (01:25 +0000)]
Fix ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 17 Nov 2007 01:24:53 +0000 (01:24 +0000)]
WebKitTools:
Reviewed by Darin Adler and Sam Weinig.
- fix <rdar://problem/
5134075> fast/forms/select-type-ahead-non-latin.html fails on boomer
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback): For characters that cannot be entered on the active
keyboard layout, send a WM_CHAR message with the character along with
a WM_KEYDOWN message with a virtual key code of 255.
LayoutTests:
Reviewed by Darin Adler and Sam Weinig.
- remove fast/forms/select-type-ahead-non-latin.html after fixing <rdar://problem/
5134075>
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Sat, 17 Nov 2007 01:16:56 +0000 (01:16 +0000)]
2007-11-16 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Ollie.
<rdar://problem/
5605175> Crash closing or leaving window with ViewPoint
Media player plugin
ViewPoint plugin requires that we pass a valid NPSavedData* to
NPP_Destroy.
* plugins/win/PluginViewWin.cpp: Pass a valid NPSavedData* to
NPP_Destroy. If the plugin allocates data, discard it
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 17 Nov 2007 00:52:17 +0000 (00:52 +0000)]
Windows build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 23:50:45 +0000 (23:50 +0000)]
Build WebCore as a sub-framework of WebKit in all configurations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 22:43:36 +0000 (22:43 +0000)]
2007-11-16 Mark Rowe <mrowe@apple.com>
Reviewed by Eric.
Replace strings, identifier, buffer8 and buffer16 members of Lexer with vectors.
SunSpider claims this is a 0.7% speedup.
* kjs/lexer.cpp:
(KJS::Lexer::Lexer):
(KJS::Lexer::lex):
(KJS::Lexer::record8):
(KJS::Lexer::record16):
(KJS::Lexer::scanRegExp):
(KJS::Lexer::clear):
(KJS::Lexer::makeIdentifier):
(KJS::Lexer::makeUString):
* kjs/lexer.h:
* kjs/ustring.cpp:
(KJS::UString::UString): Add a convenience constructor that takes a const Vector<UChar>&.
* kjs/ustring.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 16 Nov 2007 22:27:03 +0000 (22:27 +0000)]
2007-11-16 Doug Turner <dougt@meer.net>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=16018
build bustage when building on debian 4.0
Fix build bustage on GTK+ with older versions of Pango.
Don't cache the return value since the docs say it can change.
* platform/gtk/Language.cpp:
(WebCore::defaultLanguage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 16 Nov 2007 21:55:14 +0000 (21:55 +0000)]
Windows build fix
* JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Add a new include path
and ignore the int -> bool conversion warning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 16 Nov 2007 19:21:42 +0000 (19:21 +0000)]
Reviewed by Brady
* WebKit.exp:
Exported some new database-related symbols
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 19:06:23 +0000 (19:06 +0000)]
* WebKit.xcodeproj/project.pbxproj: WebDatabaseManagerPrivate.h, also!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 18:59:25 +0000 (18:59 +0000)]
* WebKit.xcodeproj/project.pbxproj: Mark WebSecurityOriginPrivate.h private so
it is exported
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 17:34:57 +0000 (17:34 +0000)]
WebKit/mac:
Reviewed by John
Database management API tweaks
Fleshed out "WebSecurityOrigin" to be the API object representing an origin. This relieves some
burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself
Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
the WebKit tree?
* Misc/WebSecurityOrigin.mm: Removed.
* Misc/WebSecurityOriginInternal.h: Removed.
* Misc/WebSecurityOriginPrivate.h: Removed.
* Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
* Storage/WebDatabaseManagerPrivate.h:
* Storage/WebSecurityOrigin.mm: Added.
(-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
(-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]):
(-[WebSecurityOriginPrivate finalize]):
(-[WebSecurityOriginPrivate dealloc]):
(-[WebSecurityOrigin initWithProtocol:domain:]):
(-[WebSecurityOrigin initWithProtocol:domain:port:]):
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin port]):
(-[WebSecurityOrigin usage]):
(-[WebSecurityOrigin quota]):
(-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself
(-[WebSecurityOrigin dealloc]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
* Storage/WebSecurityOriginInternal.h: Added.
* Storage/WebSecurityOriginPrivate.h: Added.
WebKit:
Reviewed by John
Database management API tweaks
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 17:25:17 +0000 (17:25 +0000)]
Build fix
* platform/SecurityOriginData.h:
(WebCore::operator!=): Whoops!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 17:13:20 +0000 (17:13 +0000)]
Reviewed by Sam
Further purify DatabaseTracker to use SecurityOriginData instead of "a String"
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcproj/WebCore.vcproj
* WebCore.pro
* platform/SecurityOriginData.cpp: Added.
(WebCore::SecurityOriginData::SecurityOriginData): Add a constructor that takes a "stringIdentifier"-style string,
since that form is what will be stored in the Databases.db on disk
(WebCore::SecurityOriginData::stringIdentifier):
* platform/SecurityOriginData.h:
(WebCore::SecurityOriginData::protocol):
(WebCore::SecurityOriginData::host):
(WebCore::SecurityOriginData::port):
* storage/DatabaseTracker.cpp:
(WebCore::SecurityOriginDataHash::hash): Follow the pattern Darin set in FontCache.cpp to make a decent hash for
a SecurityOriginData object
(WebCore::SecurityOriginDataHash::equal):
(WebCore::SecurityOriginDataTraits::deletedValue): "file::1" will never exist in normal operation
(WebCore::SecurityOriginDataTraits::emptyValue): "file::2" will never exist in normal operation
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::addDatabase):
* storage/DatabaseTracker.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 16 Nov 2007 12:22:34 +0000 (12:22 +0000)]
Rubberstamped by Eric.
Full update of the SVG pixel tests - all files containing text show rendering improvements.
Text looks more 'bold' as it's supposed to be according to the W3C reference rendering, not
sure what commit actually caused it - but it's better now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 12:20:01 +0000 (12:20 +0000)]
Windows build fix.
* WebCore.vcproj/WebCore.vcproj: Removed VoidCallback.cpp, added JSCustomVoidCallback.{h,cpp}.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 16 Nov 2007 11:20:56 +0000 (11:20 +0000)]
Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12290
Implement all SVGTextContentElement DOM methods.
This is the last missing SVG text feature. SVG fonts is next.
Added testcase: svg/custom/text-dom-01-f.svg (tests all new methods)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 10:49:40 +0000 (10:49 +0000)]
Fix Windows debug build.
Rubber-stamped by Eric
* pcre/pcre_exec.cpp: (match): Removed ASSERT_NOT_REACHED assertions that were making MSVC
complain about unreachable code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 07:47:52 +0000 (07:47 +0000)]
2007-11-15 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* kjs/Parser.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 07:44:18 +0000 (07:44 +0000)]
Mac build and header search path sanity fix.
Reviewed by Sam Weinig and Tim Hatcher.
Move base setting for HEADER_SEARCH_PATHS into Base.xcconfig, and extend
it in JavaScriptCore.xcconfig. This removes the need to override it on a
per-target basis inside the .xcodeproj file.
* Configurations/Base.xcconfig:
* Configurations/JavaScriptCore.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 07:08:05 +0000 (07:08 +0000)]
2007-11-15 Mark Rowe <mrowe@apple.com>
Qt build fix.
* kjs/Parser.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Fri, 16 Nov 2007 07:00:50 +0000 (07:00 +0000)]
WebCore:
Reviewed by Oliver.
Fix for <rdar://problem/
5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)
Test: fast/forms/menulist-no-renderer-onmousedown.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::defaultEventHandler): Nil check the renderer here. None of the default behavior makes sense if there's no renderer.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Moved the nil check to the main defaultEventHandler.
LayoutTests:
Reviewed by Oliver.
Test for <rdar://problem/
5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)
* fast/forms/menulist-no-renderer-onmousedown-expected.txt: Added.
* fast/forms/menulist-no-renderer-onmousedown.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 16 Nov 2007 06:54:09 +0000 (06:54 +0000)]
Reviewed by Eric Seidel.
Another round of grammar / parsing cleanup.
1. Created distinct parser calls for parsing function bodies vs
programs. This will help later with optimizing global variable access.
2. Turned Parser into a singleton. Cleaned up Lexer's singleton
interface.
3. Modified Lexer to free a little more memory when done lexing. (Added
FIXMEs for similar issues that I didn't fix.)
4. Changed Lexer::makeIdentifier and Lexer::makeUString to start
respecting the arguments passed to them. (No behavior change, but this
problem could have caused serious problems for an unsuspecting user of
these functions.)
5. Removed KJS_DEBUG_MEM because it was bit-rotted.
6. Removed Parser::prettyPrint because the same work was simpler to do
at the call site.
7. Some renames:
"Parser::accept" => "Parser::didFinishParsing"
"Parser::sid" => "Parser::m_sourceID"
"Lexer::doneParsing" => "Lexer::clear"
"sid" => "sourceId"
"lineno" => "lineNo"
* JavaScriptCore.exp:
* kjs/Parser.cpp:
(KJS::Parser::Parser):
(KJS::Parser::parseProgram):
(KJS::Parser::parseFunctionBody):
(KJS::Parser::parse):
(KJS::Parser::didFinishParsing):
(KJS::parser):
* kjs/Parser.h:
(KJS::Parser::sourceId):
* kjs/function.cpp:
(KJS::GlobalFuncImp::callAsFunction):
* kjs/function_object.cpp:
(FunctionObjectImp::construct):
* kjs/grammar.y:
* kjs/interpreter.cpp:
(KJS::Interpreter::checkSyntax):
(KJS::Interpreter::evaluate):
* kjs/interpreter.h:
* kjs/lexer.cpp:
(kjsyylex):
(KJS::lexer):
(KJS::Lexer::Lexer):
(KJS::Lexer::~Lexer):
(KJS::Lexer::scanRegExp):
(KJS::Lexer::doneParsing):
(KJS::Lexer::makeIdentifier):
(KJS::Lexer::makeUString):
* kjs/lexer.h:
(KJS::Lexer::pattern):
(KJS::Lexer::flags):
(KJS::Lexer::sawError):
* kjs/nodes.cpp:
(KJS::Node::Node):
(KJS::FunctionBodyNode::FunctionBodyNode):
* kjs/nodes.h:
* kjs/testkjs.cpp:
(prettyPrintScript):
(kjsmain):
* kjs/ustring.cpp:
* kjs/ustring.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 16 Nov 2007 06:25:36 +0000 (06:25 +0000)]
Reviewed by Adele.
Fix <rdar://problem/
5601598>
The movie tag should do initialization on need and not during startup.
Initialize Movie MIME type hash on demand
* platform/MIMETypeRegistry.cpp:
(WebCore::initialiseSupportedMovieMIMETypes):
(WebCore::initialiseMIMETypeRegistry):
(WebCore::MIMETypeRegistry::isSupportedMovieMIMEType):
(WebCore::MIMETypeRegistry::getSupportedMovieMIMETypes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 06:18:22 +0000 (06:18 +0000)]
2007-11-15 Mark Rowe <mrowe@apple.com>
Build fix for Qt on Windows.
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 16 Nov 2007 06:15:18 +0000 (06:15 +0000)]
Reviewed by Mark Rowe.
Bug 14761: Web Inspector leaks JS objects and DOM nodes
http://bugs.webkit.org/show_bug.cgi?id=14761
* page/InspectorController.cpp:
(WebCore::InspectorController::~InspectorController):
Change the tear down order so that inspectorDestroyed() is called before
InspectorController private data is set to Zero. The inspectorDestroyed()
call ends up closing the WebView and triggering InspectorController::close()
which unprotects m_scriptObject. This didn't happen when the private data
was cleared before calling inspectorDestroyed().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 06:10:30 +0000 (06:10 +0000)]
2007-11-15 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 06:04:45 +0000 (06:04 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15989
XPath queries with predicates incorrectly retains the current node across unions
Test: fast/xpath/union-context-node.xhtml
* xml/XPathPath.cpp:
(WebCore::XPath::LocationPath::evaluate): Restore context after evaluation.
* xml/XPathStep.cpp:
(WebCore::XPath::Step::evaluate): Do not backup context, as we can easily re-create it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 06:02:20 +0000 (06:02 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15448
Import XPath test suite from amachang.art-code.org
Test by Hitoshi Amano <seijro@gmail.com>.
* fast/xpath/xpath-functional-test-expected.txt: Added.
* fast/xpath/xpath-functional-test.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 06:00:53 +0000 (06:00 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15988
REGRESSION: XPath preceding-axis query misses nested elements
Test: fast/xpath/preceding-axis.xhtml
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis): Hopefully correct this time.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 16 Nov 2007 01:21:32 +0000 (01:21 +0000)]
Reviewed by Mark Rowe and Sam.
This corrects a couple of issues in the Web Inspector where selected search results
would not have the right text color when the window is inactive or the results are focused.
* page/inspector/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc