aroben [Thu, 25 Oct 2007 05:20:32 +0000 (05:20 +0000)]
Added some font-related functions needed for <rdar://
5549919>
Reviewed by Ada.
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:
* win/lib/WebKitSystemInterface_debug.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 25 Oct 2007 05:01:13 +0000 (05:01 +0000)]
2007-10-24 Sven Herzberg <sven@imendio.com>
Reviewed by Mark Rowe.
Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
Bug 15614: [GTK] qmake based backends don't build on OS X
* Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
GTK backend on a Mac
* Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
isDarwin() to make it reusable in other places (like the workaround-
for-prebuilt-qmake in build-webkit)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Thu, 25 Oct 2007 03:51:10 +0000 (03:51 +0000)]
Refurbish update-webkit script.
Reviewed by Adam.
* Scripts/update-webkit: Add -h|--help switch and usage statement. Check result of
GetOptions() call. Fix -q|--quiet switch to be passed to svn command properly. Use
multi-argument version of system() for flexibility and security. Check for existence
of Internal directory using -d test instead of -x.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Thu, 25 Oct 2007 03:50:17 +0000 (03:50 +0000)]
Minor clean-up of prepare-ChangeLog script.
Reviewed by Adam.
* Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
of a string. Use multi-argument versions of open() and system() for flexibility and
security.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan [Thu, 25 Oct 2007 02:40:58 +0000 (02:40 +0000)]
<rdar://problem/
5552221> REGRESSION(310A24-ToT): Shortcut key disable. (15604)
Reviewed by Adam.
* WebView.cpp:
(WebView::handleEditingKeyboardEvent): don't handle system key events as text input
(WebView::keyDown): only remove WM_SYSCHAR message from the queue if we handle it.
For WM_SYSCHAR message that we don't handle, let it stay in the queue and return
false to let windows handle it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 25 Oct 2007 01:19:50 +0000 (01:19 +0000)]
Touch all files that include *.lut.h to fix Windows builds
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 25 Oct 2007 01:16:07 +0000 (01:16 +0000)]
2007-10-24 Mark Rowe <mrowe@apple.com>
Gtk build fix. Track WebCore changes in r27004.
* Api/webkitgtkglobal.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 25 Oct 2007 00:58:54 +0000 (00:58 +0000)]
WebCore:
Reviewed by Darin Adler.
Correcting the fix for:
<rdar://problem/
5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time
Made removal of the previous composition part of the current Undo step in the
case where the new composition is the empty string, too.
* editing/Editor.cpp:
(WebCore::Editor::confirmComposition): Call the new TypingCommand::deleteSelection,
which either has the currently open typing command delete the current selection, or
opens a new typing command (of type DeleteSelection) if one is not already open.
(WebCore::Editor::setComposition): Ditto.
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteSelection): Added.
(WebCore::TypingCommand::doApply): Handle DeleteSelection.
(WebCore::TypingCommand::deleteKeyPressed): Clarified which deleteSelection
is called.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
(WebCore::TypingCommand::preservesTypingStyle): Handle DeleteSelection.
* editing/TypingCommand.h:
LayoutTests:
Reviewed by Darin.
<rdar://problem/
5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time
* platform/mac/editing/input/text-input-controller-expected.txt: The delete
we were using previously to remove the old composition makes fewer calls to
the editing delegate.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 25 Oct 2007 00:30:02 +0000 (00:30 +0000)]
Build fix.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 25 Oct 2007 00:10:22 +0000 (00:10 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 24 Oct 2007 23:55:42 +0000 (23:55 +0000)]
WebKit:
Reviewed by Mark Rowe.
<rdar://problem/
5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard
Use the WebKitSystemInterface that matches the system version.
* Configurations/DebugRelease.xcconfig:
* WebKit.xcodeproj/project.pbxproj:
WebKitLibraries:
Reviewed by Mark Rowe.
<rdar://problem/
5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard
Add system specific versions of WebKitSystemInterface.
* libWebKitSystemInterface.a: Removed.
* libWebKitSystemInterfaceLeopard.a: Added.
* libWebKitSystemInterfaceTiger.a: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 24 Oct 2007 23:29:09 +0000 (23:29 +0000)]
WebCore:
Reviewed by Oliver.
Fix <rdar://
5410959> editing/selection/drag-to-contenteditable-iframe.html fails on Windows
* page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::passMouseMoveEventToSubframe):
Some mouse move events are actually drags, which on mac return early from this function.
Adding the same logic to its Windows equivalent.
WebKitTools:
Reviewed by Oliver.
Fix <rdar://
5410959> editing/selection/drag-to-contenteditable-iframe.html fails on Windows
Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
replay the saved events when we're still processing the mousedown that starts the drag
* DumpRenderTree/win/EventSender.cpp:
(doMouseMove):
* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::doDragDrop):
LayoutTests:
Removing fixed test
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 24 Oct 2007 23:02:02 +0000 (23:02 +0000)]
WebCore:
Reviewed by Anders
<rdar://
5554130> DatabaseTracker.o has a global initializer
Since DatabaseTracker is a singleton, it makes much more sense to keep the database path as a member variable.
Now constructing the shared DatabaseTracker no longer implicitly opens it - It is only opened when the databases
path is set.
* WebCore.vcproj/WebCore.vcproj: Copy WebCore/storage headers for WebKit build
* storage/Database.cpp:
(WebCore::Database::~Database): Remove bogus assertion
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::DatabaseTracker): Does nothing now! Move this code to openTrackerDatabase
(WebCore::DatabaseTracker::setDatabasePath): Set the member variable, also closing/opening the database if needed
(WebCore::DatabaseTracker::databasePath):
(WebCore::DatabaseTracker::openTrackerDatabase): To open and validate the Databases db, moved from the c'tor
(WebCore::DatabaseTracker::fullPathForDatabase): Return the member variable
* storage/DatabaseTracker.h:
WebKit/win:
Reviewed by Anders
Windows portion of <rdar://
5554130>
Slowly introduce Windows WebKit portion of the Database API that sets the
on-disk location for databases
* WebDatabaseManager.cpp: Added.
(WebKitSetWebDatabasesPathIfNecessary):
* WebDatabaseManager.h: Added.
* WebKit.vcproj/WebKit.vcproj:
* WebView.cpp:
(WebView::initWithFrame): Call WebKitSetWebDatabasesPathIfNecessary()
WebKit:
Reviewed by Anders
<rdar://problem/
5554130> DatabaseTracker.o has a global initializer
* Misc/WebDatabaseManager.mm:
(WebKitSetWebDatabasesPathIfNecessary): Call the member function instead of a static one
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 24 Oct 2007 23:00:26 +0000 (23:00 +0000)]
WebKitTools:
Reviewed by Sam, Steve and Darin.
- Stubbed out the WebScriptDebugListener functionality in the Server
Connection class to prepare it for receiving those callbacks.
- Also I changed the instantiation of DebuggerClient, DebuggerDocument
and the ServerConnection to not need to be initialized with a server
name, since that is not the way we connect to the WebKit server.
* Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
no exception. Now it only loggs when there is an exception
(DebuggerDocument::willExecuteStatement):
(DebuggerDocument::didEnterCallFrame):
(DebuggerDocument::willLeaveCallFrame):
(DebuggerDocument::windowScriptObjectAvailable):
(DebuggerDocument::callFunctionOnObject):
* Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
to be instantiated with a server's name.
(DebuggerClient::DebuggerClient):
(DebuggerClient::didFinishLoadForFrame):
* Drosera/win/DebuggerClient.h: Removed unsued variable.
* Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
a server name.
(Drosera::init):
(Drosera::initServer):
* Drosera/win/Drosera.h: No longer need the ServerConnection to be
instantiated with a server's name.
* Drosera/win/ServerConnection.cpp:
(ServerConnection::ServerConnection): No longer needs a server name
(ServerConnection::~ServerConnection): Only release the global context
if there is one.
(ServerConnection::serverConnectionDidDie): Stub for
IWebScriptDebugListener
(ServerConnection::QueryInterface): ditto
(ServerConnection::AddRef): ditto
(ServerConnection::Release): ditto
(ServerConnection::didLoadMainResourceForDataSource): ditto
(ServerConnection::didParseSource): ditto
(ServerConnection::failedToParseSource): ditto
(ServerConnection::didEnterCallFrame): ditto
(ServerConnection::willExecuteStatement): ditto
(ServerConnection::willLeaveCallFrame): ditto
(ServerConnection::exceptionWasRaised): ditto
* Drosera/win/ServerConnection.h: Stubbed out the
IWebScriptDebugListener functions, and this class no longer needs to be
instantiated with a server name.
win:
Reviewed by Sam, Steve and Darin.
- Added stubs for what will be neede to let Drosera attach to the
WebKit process and debug it.
* Interfaces/IWebScriptCallFrame.idl: Added.
* Interfaces/IWebScriptDebugListener.idl: Added.
* Interfaces/WebKit.idl:
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 24 Oct 2007 22:10:19 +0000 (22:10 +0000)]
2007-10-24 Eric Seidel <eric@webkit.org>
Build fix for Gtk, no review.
* kjs/collector.cpp: #include "context.h"
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 24 Oct 2007 21:31:27 +0000 (21:31 +0000)]
2007-10-24 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
Stop checking isOutOfMemory after every allocation, instead let the collector
notify all ExecStates if we ever hit this rare condition.
SunSpider claims this was a 2.2% speedup.
* kjs/collector.cpp:
(KJS::Collector::collect):
(KJS::Collector::reportOutOfMemoryToAllInterpreters):
* kjs/collector.h:
* kjs/nodes.cpp:
(KJS::TryNode::execute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 24 Oct 2007 20:33:34 +0000 (20:33 +0000)]
Don't try to gap fill transformed selections. Fix the invalidation of selection to use the clip to visible content
code path so that it works with multi-column layouts and transforms.
Reviewed by aroben
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::fillSelectionGaps):
* rendering/RenderView.cpp:
(WebCore::RenderView::setSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 24 Oct 2007 20:25:01 +0000 (20:25 +0000)]
2007-10-24 Eric Seidel <eric@webkit.org>
No review, I want to tickle the CIA bot to test changes,
and took this as an opportunity to clean up some old change logs.
* ChangeLog-2005-08-23: update email address
* ChangeLog-2006-12-31: fix spelling mistakes
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Wed, 24 Oct 2007 18:45:27 +0000 (18:45 +0000)]
WebCore:
Reviewed by Oliver Hunt.
- add "(anonymous)" to the renderName of anonymous table cells, rows and sections
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::renderName):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::renderName):
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::renderName):
LayoutTests:
Reviewed by Oliver Hunt.
- updated results to reflect which table parts are anonymous
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 24 Oct 2007 18:41:40 +0000 (18:41 +0000)]
Reviewed by Adam.
Bug 15476: DOM tree fully expands some elements when arrowing up
http://bugs.webkit.org/show_bug.cgi?id=15476
Add a new expandTreeElementsWhenArrowing option to TreeOutline. This option
is used only for the sidebar and search results.
* page/inspector/inspector.js: Opt-in for the sidebar and search results.
* page/inspector/treeoutline.js: Add expandTreeElementsWhenArrowing and pass
this option to traverseNextTreeElement and traversePreviousTreeElement.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 24 Oct 2007 18:30:37 +0000 (18:30 +0000)]
2007-10-24 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* kjs/identifier.h: Remove extra qualification.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 24 Oct 2007 18:04:38 +0000 (18:04 +0000)]
Reviewed by Sam Weinig.
Disable ALWAYS_INLINE in debug builds, since it drives the debugger
crazy.
* wtf/AlwaysInline.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 24 Oct 2007 18:02:07 +0000 (18:02 +0000)]
Reviewed by Sam Weinig.
Inlined the fast path for creating an Identifier from an Identifier.
This is a .4% speedup on SunSpider overall, but as big as a 2.5%
speedup on certain individual tests. 65% of the Identifiers creating
by SunSpider are already Identifiers.
(The main reason I'm making this change is that it resolves a large
regression in a patch I haven't checked in yet.)
* JavaScriptCore.exp:
* kjs/identifier.cpp:
(KJS::Identifier::addSlowCase):
* kjs/identifier.h:
(KJS::Identifier::Identifier::add):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26994
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 24 Oct 2007 17:58:17 +0000 (17:58 +0000)]
Fix ChangeLog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26993
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 24 Oct 2007 17:56:18 +0000 (17:56 +0000)]
Reviewed by Geoff and Mitz.
<rdar://problem/
5493833>
REGRESSION: ~5MB of image data leaked @ cuteoverload.com (often seen while browsing other sites, too)
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/kjs_binding.cpp:
(KJS::ScriptInterpreter::markDOMNodesForDocument):
If an image element that is currently loading an image is not in the document,
it should still be marked.
* bindings/js/kjs_html.cpp:
(WebCore::ImageConstructorImp::construct):
Force the document wrapper to be created.
* html/HTMLImageElement.h:
(WebCore::HTMLImageElement::haveFiredLoadEvent):
New method which calls down to the image loader.
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::HTMLImageLoader):
(WebCore::HTMLImageLoader::~HTMLImageLoader):
(WebCore::HTMLImageLoader::setLoadingImage):
(WebCore::HTMLImageLoader::dispatchLoadEvent):
Remove code that's not needed anymore.
* html/HTMLImageLoader.h:
(WebCore::HTMLImageLoader::haveFiredLoadEvent):
Make this public.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26992
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 24 Oct 2007 17:27:53 +0000 (17:27 +0000)]
Move Windows safe file creation code into WebCore from WebPreferences
WebCore:
Move Windows safe file creation code into WebCore from WebPreferences
Reviewed by Brady.
* platform/FileSystem.h:
* platform/win/FileSystemWin.cpp:
(WebCore::safeCreateFile): Moved here from WebKit/win/WebPreferences.cpp.
WebKit/win:
Move safe file creation code to WebCore
Reviewed by Brady.
* WebPreferences.cpp:
(preferencesPath): Made into a static helper function.
(WebPreferences::save): Now calls WebCore's safeCreateFile function.
(WebPreferences::load): Uses String/CString to handle the UTF-8
conversion.
* WebPreferences.h: Removed preferencesPath and
safeCreateFileWithData.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26991
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 24 Oct 2007 17:27:02 +0000 (17:27 +0000)]
Reduce code duplication by using WebCore's FileSystem functions
WebCore:
Add methods to FileSystemWin to get some user profile directories
These directories are used to hold things like preferences, caches,
etc.
Reviewed by Brady.
* platform/FileSystem.h: Added new method declarations for Windows
only.
* platform/win/FileSystemWin.cpp:
(WebCore::bundleName): Added.
(WebCore::storageDirectory): Added.
(WebCore::cachedStorageDirectory): Added.
(WebCore::localUserSpecificStorageDirectory): Added. Returns the
directory where WebKit should store any user-specific data that should
stay local to the current machine (i.e., shouldn't be stored in a
roaming profile).
(WebCore::roamingUserSpecificStorageDirectory): Added. Returns the
directory where WebKit should store any user-specific data that should
move with the user from machine to machine (i.e., should be stored in
a roaming profile).
WebKit/win:
Reduce code duplication by using WebCore's FileSystem functions
Reviewed by Brady.
* WebIconDatabase.cpp: Removed a now-unused function and a fixed
FIXME.
(WebIconDatabase::init): Changed to use FileSystem functions.
* WebPreferences.cpp:
(WebPreferences::preferencesPath): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26990
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 24 Oct 2007 13:28:03 +0000 (13:28 +0000)]
2007-10-24 Mark Rowe <mrowe@apple.com>
Fix incorrect test results landed with r26986.
* http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt:
* http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 13:21:19 +0000 (13:21 +0000)]
update some test results for the Qt port.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26988
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Wed, 24 Oct 2007 13:06:35 +0000 (13:06 +0000)]
2007-10-24 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=15659
InlineTextBox does not setStrokeStyle() as needed
GraphicsContextCairo workaround to support a GraphicsContextCG quirk:
Save and restore the StrokeStyle manually.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 24 Oct 2007 12:49:35 +0000 (12:49 +0000)]
2007-10-24 Julien Chaffraix <julien.chaffraix@gmail.com>
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=15356
Bug 15356: getResponseHeader and getAllResponseHeaders do not throw exceptions
- getAllResponseHeaders and getResponseHeader throws INVALID_STATE_ERR exception as specified in the specification
- Add the check to field-name production in getResponseHeader (call to isValidToken) and returns an empty string if the header is not valid (Opera and IE behaviour)
- Updated XMLHttpRequest::responseMIMEType() to keep its behaviour
Tests: http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html
http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html
http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html
* bindings/js/JSXMLHttpRequest.cpp:
(KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::getAllResponseHeaders):
(WebCore::XMLHttpRequest::getResponseHeader):
(WebCore::XMLHttpRequest::responseMIMEType):
* xml/XMLHttpRequest.h:
2007-10-24 Julien Chaffraix <julien.chaffraix@gmail.com>
Reviewed by Darin.
Tests for http://bugs.webkit.org/show_bug.cgi?id=15356
getResponseHeader and getAllResponseHeaders do not throw exceptions
* http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders-expected.txt: Added.
* http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getAllRequestHeaders.html: Added.
* http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader-expected.txt: Added.
* http/tests/xmlhttprequest/xmlhttprequest-InvalidStateException-getRequestHeader.html: Added.
* http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader-expected.txt: Added.
* http/tests/xmlhttprequest/xmlhttprequest-invalidHeader-getRequestHeader.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26986
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:33:34 +0000 (12:33 +0000)]
these tests don't crash anymore :)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:33:31 +0000 (12:33 +0000)]
* Stop crashing on fast/events/frame-tab-focus.html the keyEvent can be 0.
Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26984
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:33:29 +0000 (12:33 +0000)]
implement most of DragData.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:33:26 +0000 (12:33 +0000)]
add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:33:19 +0000 (12:33 +0000)]
we're passing most editing tests now. Commit them.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:33:02 +0000 (12:33 +0000)]
add another command.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:58 +0000 (12:32 +0000)]
convert the text to be text only, and fix it up a little so it doesn't depend on specific font metrics anymore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:55 +0000 (12:32 +0000)]
remove some notImplemented() warnings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:53 +0000 (12:32 +0000)]
add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:49 +0000 (12:32 +0000)]
remove a stupid notImplemented() warning and implement PasteBoad::clear().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:47 +0000 (12:32 +0000)]
allow paste from DOM so we pass more test cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:44 +0000 (12:32 +0000)]
implement Pasteboard::documentFragment(), and fix a mem leak.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:40 +0000 (12:32 +0000)]
implement eventSender.keyDown().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:36 +0000 (12:32 +0000)]
some changes to the way JS values are converted to Qt values in the script bindings. Added support for converting JS arrays into QStringList's.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:34 +0000 (12:32 +0000)]
Simplify the PlatformKeyEvent constructor. No need to have an extra boolean for isKeyUp in there, as the QKeyEvent has the information.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:31 +0000 (12:32 +0000)]
some smaller fixes to the editing support in DRT. Makes another few tests pass.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:27 +0000 (12:32 +0000)]
explicitly add some tests that currently cause DRT to hang.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:25 +0000 (12:32 +0000)]
first bit of implementation for the textinputcontroller.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:21 +0000 (12:32 +0000)]
implemented support for most editing shortcuts to make contentEditable usable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:19 +0000 (12:32 +0000)]
no need to call setIsActive ourselves on the frame, as the focus controller does it for us.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:17 +0000 (12:32 +0000)]
make the man webpage believe it has focus, so the editing tests work correctly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:13 +0000 (12:32 +0000)]
implement layoutTestController.dumpEditingCallbacks() correctly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:09 +0000 (12:32 +0000)]
use the new QTextBoundaryFinder class in Qt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 24 Oct 2007 12:32:05 +0000 (12:32 +0000)]
Implement support for testing editing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 24 Oct 2007 08:53:45 +0000 (08:53 +0000)]
Remove old relation method, replace with specialised LessThan and lessThenEq functions for a 0.5-0.6% improvement in SunSpider
Reviewed by Darin
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 24 Oct 2007 08:50:12 +0000 (08:50 +0000)]
2007-10-24 Eric Seidel <eric@webkit.org>
Reviewed by darin.
* kjs/nodes.h:
(KJS::ImmediateNumberNode::): Fix ASSERT correctness (and debug build!)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Oct 2007 08:21:21 +0000 (08:21 +0000)]
Reviewed by Eric.
* kjs/object.cpp: (KJS::JSObject::defaultValue): Get rid of a little
Identifier ref/deref for what SunSpider claims is a 0.4% speedup.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Oct 2007 08:14:32 +0000 (08:14 +0000)]
Reviewed by Maciej.
- separate out the code to create a hash table the first time from the code
to rehash
SunSpider claims this was a 0.7% speedup.
* kjs/property_map.cpp:
(KJS::PropertyMap::expand): Changed to call either createTable or rehash.
(KJS::PropertyMap::createTable): Added. For the case where we had no table.
(KJS::PropertyMap::rehash): Removed code needed only in the case where we
had no table.
* kjs/property_map.h: Added createTable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 24 Oct 2007 08:06:03 +0000 (08:06 +0000)]
2007-10-24 Eric Seidel <eric@webkit.org>
Reviewed by darin.
Add ImmediateNumberNode to hold a JSValue* instead of a double for numbers
which can be represented by JSImmediate.
* kjs/grammar.y:
* kjs/nodes.cpp:
(KJS::NumberNode::evaluate):
(KJS::ImmediateNumberNode::evaluate):
* kjs/nodes.h:
(KJS::Node::):
(KJS::ImmediateNumberNode::):
* kjs/nodes2string.cpp:
(ImmediateNumberNode::streamTo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Oct 2007 08:03:02 +0000 (08:03 +0000)]
JavaScriptCore:
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15657
change static hash tables to use powers of two for speed
Seems to give 0.7% SunSpider speedup.
* kjs/create_hash_table: Updated to generate new format.
* kjs/lookup.cpp:
(KJS::keysMatch): Took out unneeded typecast.
(KJS::findEntry): Updated to expect table type 3 -- changed the printf to a plain old assert.
Replaced the modulus with a bit mask.
(KJS::Lookup::findEntry): Get the hash directly, since we know identifiers already have computed
their hash -- saves a branch.
(KJS::Lookup::find): Ditto.
* kjs/lookup.h: Changed attr from 2-byte value to one-byte value. Replaced hashSize with hashSizeMask.
WebCore:
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15657
change static hash tables to use powers of two for speed
* bindings/scripts/CodeGeneratorJS.pm: Updated to generate new format.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 24 Oct 2007 07:59:21 +0000 (07:59 +0000)]
Reviewed by Darin.
- remove KJS_CHECKEXCEPTIONs in places where exceptions can't happen for 0.6% SunSpider speedup
* kjs/nodes.cpp:
(KJS::DoWhileNode::execute):
(KJS::WhileNode::execute):
(KJS::ForNode::execute):
(KJS::ForInNode::execute):
(KJS::SourceElementsNode::execute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Oct 2007 07:41:45 +0000 (07:41 +0000)]
Reviewed by Eric.
* sunspider: Open the profile in shark after completing a run.
* sunspider-compare-results: Tiny perl tweaks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Wed, 24 Oct 2007 07:40:29 +0000 (07:40 +0000)]
Fix pathByAppendingComponent for the Qt port.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 24 Oct 2007 06:52:51 +0000 (06:52 +0000)]
Make repainting work with transforms.
Reviewed by John Sullivan
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeAbsoluteRepaintRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Oct 2007 06:41:16 +0000 (06:41 +0000)]
Ignore files generated by the make-hosted script.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 24 Oct 2007 06:19:39 +0000 (06:19 +0000)]
Reviewed by Maciej.
* kjs/JSImmediate.h: (KJS::JSImmediate::getUInt32):
Changed an && to an & for a 1% gain in SunSpider.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Wed, 24 Oct 2007 04:40:58 +0000 (04:40 +0000)]
2007-10-23 Alp Toker <alp@atoker.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14412
[GDK] Clipboard support
Initial clipboard implementation for the GTK+ port.
* platform/gtk/ClipboardGtk.cpp:
(WebCore::Editor::newGeneralClipboard):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::generalPasteboard):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::~Pasteboard):
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::plainText):
* platform/gtk/TemporaryLinkStubs.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 24 Oct 2007 04:35:26 +0000 (04:35 +0000)]
Reviewed by Adam.
Fixes the Network panel so that it refreshes as needed.
* page/inspector/ConsolePanel.js: Call the base class show() and hide() first.
* page/inspector/NetworkPanel.js: Add refreshNeeded and refreshIfNeeded back. Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 24 Oct 2007 03:47:16 +0000 (03:47 +0000)]
Check for null BSTR that can be passed to the UIDelegate methods
from javascript null and undefined. Fixes a failing test case on
Windows (fast/dom/Window/alert-undefined.html)
Reviewed by Eric Seidel.
* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::runJavaScriptAlertPanelWithMessage):
(UIDelegate::runJavaScriptConfirmPanelWithMessage):
(UIDelegate::runJavaScriptTextInputPanelWithPrompt):
(UIDelegate::webViewAddMessageToConsole):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Wed, 24 Oct 2007 02:15:32 +0000 (02:15 +0000)]
Rolled out r26941 because it of layout test failures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 24 Oct 2007 02:01:53 +0000 (02:01 +0000)]
Reduce branching in implementations of some operator implementations, yielding 1.3% boost to SunSpider.
Reviewed by Maciej
* kjs/nodes.cpp:
(KJS::MultNode::evaluate):
(KJS::DivNode::evaluate):
(KJS::ModNode::evaluate):
(KJS::add):
(KJS::sub):
(KJS::AddNode::evaluate):
(KJS::SubNode::evaluate):
(KJS::valueForReadModifyAssignment):
* kjs/operations.cpp:
* kjs/operations.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 24 Oct 2007 01:59:37 +0000 (01:59 +0000)]
Fixing an accidental change made in r25484.
* editing/pasteboard/quirks-mode-br-1.html:
* platform/mac/editing/pasteboard/quirks-mode-br-1-expected.checksum:
* platform/mac/editing/pasteboard/quirks-mode-br-1-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 24 Oct 2007 01:56:56 +0000 (01:56 +0000)]
Reviewed by Oliver Hunt.
<rdar://problem/
5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time
* platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
* platform/mac/editing/input/text-input-controller-expected.txt:
* platform/mac/editing/input/wrapped-line-char-rect-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 24 Oct 2007 01:53:53 +0000 (01:53 +0000)]
Reviewed by Oliver Hunt.
<rdar://problem/
5544856>
REGRESSION: After typing 2-byte text, undo only undoes one keystroke at a time
No layout test for now because I'm having trouble getting Undo during a layout
test to only undo the last Undo step, and I want to write a test that fails
without the code change.
* editing/Editor.cpp:
(WebCore::Editor::confirmComposition): When we replace the previous composition,
delete it with a sub-command of the command used to insert the new composition,
instead of with a separate command. No new code was added because insertText
already deletes the current selection.
(WebCore::Editor::setComposition): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz [Wed, 24 Oct 2007 01:51:04 +0000 (01:51 +0000)]
Reviewed by Eric Seidel.
- fix http://bugs.webkit.org/show_bug.cgi?id=15405
ASSERTION FAILED: d->m_view && !d->m_view->needsLayout() in Frame::Paint
Calling updateWidget() during attach() led to arbitrary (plugin and resource load delegate)
code execution under attach(). The fix is to use the mechanism that's already in place for
deferring updateWidget() until after layout.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::attach): Replaced call to updateWidget() with call to updateWidgetSoon()
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::attach): Ditto.
* manual-tests/paint-during-plugin-attach.html: Added.
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidgetSoon): Added this function that schedules the
updateWidget() call for after the next layout.
* rendering/RenderPartObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 24 Oct 2007 01:36:05 +0000 (01:36 +0000)]
Make the WebNotificationCenter work with null (wildcard) and specific
observed objects, matching NSNotificationCenter.
- Removes the ObserverKey, ObserverHash, and ObserverKeyTraits as we now
hash against the notification name only and check the object on notification
posting.
- Use OwnPtr for the WebNotificationCenterPrivate member variable.
Reviewed by Adam Roben.
* WebNotificationCenter.cpp:
(WebNotificationCenter::WebNotificationCenter):
(WebNotificationCenter::~WebNotificationCenter):
(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::postNotification):
(WebNotificationCenter::postNotificationName):
(WebNotificationCenter::removeObserver):
* WebNotificationCenter.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 24 Oct 2007 01:30:00 +0000 (01:30 +0000)]
Fix the behavior of pathByAppendingComponent when path is empty
We now use the Windows Shell API function PathAppendW instead of
rolling our own broken implementation.
Reviewed by Anders.
* platform/win/FileSystemWin.cpp:
(WebCore::pathByAppendingComponent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 24 Oct 2007 00:56:15 +0000 (00:56 +0000)]
Reviewed by Darin.
Don't print a massive pile of setenvs from tools that automatically build testkjs.
* Scripts/build-testkjs:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 24 Oct 2007 00:40:35 +0000 (00:40 +0000)]
SunSpider:
Reviewed by Darin.
- Don't hardcode my path to testkjs
* sunspider-compare-results:
WebKitTools:
Reviewed by Darin.
- add wrapper that finds the right copy of testkjs
* Scripts/sunspider-compare-results: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 24 Oct 2007 00:12:28 +0000 (00:12 +0000)]
WebCore:
Reviewed by Darin.
Fix for <rdar://problem/
5543228> CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::HTMLInputElement::defaultEventHandler + 872
Test: fast/forms/textfield-onchange-deletion.html
* html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
Refetch the renderer since arbitrary JS code run during onchange can do anything, including destroying it.
LayoutTests:
Reviewed by Darin.
Test for <rdar://problem/
5543228> CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::HTMLInputElement::defaultEventHandler + 872
* fast/forms/textfield-onchange-deletion-expected.txt: Added.
* fast/forms/textfield-onchange-deletion.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 24 Oct 2007 00:08:06 +0000 (00:08 +0000)]
Reviewed by Sam Weinig.
- Made seperate files for the various classes in ResourcePanel.js.
- Broke up ResourcePanel.js and created seperate panel classes for different resource types.
- Moved View code down to the Panel base-class.
- Reduced code duplication in DatabasePanel.js by sub-classing from the new ResourcePanel.
* page/inspector/DatabasePanel.js:
* page/inspector/DocumentPanel.js: Added.
* page/inspector/FontPanel.js: Added.
* page/inspector/ImagePanel.js: Added.
* page/inspector/Panel.js: Added.
* page/inspector/PropertiesSection.js: Added.
* page/inspector/Resource.js:
* page/inspector/ResourcePanel.js:
* page/inspector/SidebarPane.js: Added.
* page/inspector/SourcePanel.js: Added.
* page/inspector/inspector.css:
* page/inspector/inspector.html:
* page/inspector/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 23 Oct 2007 23:47:50 +0000 (23:47 +0000)]
Correct the version #if check.
* platform/sql/SQLDatabase.cpp:
(WebCore::SQLDatabase::authorizerFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
honeycutt [Tue, 23 Oct 2007 23:16:06 +0000 (23:16 +0000)]
2007-10-23 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
<rdar://
5548217>: [NTS] Java 6 update 3 crashes Safari when loading a
java page
It is possible to load Mozilla's Java plugin instead of our own, which
can lead to a crash. The fix is to prefer plugins in our own Plugins
directory when searching for a plugin.
* plugins/win/PluginDatabaseWin.cpp:
(WebCore::safariPluginsPath): Return the path to our own Plugins
directory
(WebCore::PluginDatabaseWin::defaultPluginPaths): Use new method
safariPluginsPath()
(WebCore::PluginDatabaseWin::pluginForMIMEType): If the plugin's path is
our Plugins path, return this plugin. Otherwise, continue scanning the
list of plugins
(WebCore::PluginDatabaseWin::pluginForExtension): Same
* plugins/win/PluginPackageWin.h:
(WebCore::PluginPackageWin::path): Return this plugin's path
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan [Tue, 23 Oct 2007 23:14:58 +0000 (23:14 +0000)]
<rdar://problem/
5244261> SafariWin ignores cookie policy setting "never" in the preferences
Custom WebPreferences (not the shared WebPreferences) could override the cookie accept
policy setting on the default cookie storage. To fix that, I added a new method in
WebView called updateGlobalSettingsFromPreferences() to handle updating the global pref
options such as cookie accept policy, and it's only called to update changes from
the shared WebPreferences.
Use CLSID_WebPreferences and remove IID_WebPreferences.
Reviewed by Darin and Adam.
* WebPreferences.cpp:
(WebPreferences::QueryInterface):
* WebPreferences.h:
* WebView.cpp:
(WebView::updateWebCoreSettingsFromPreferences):
(WebView::updateGlobalSettingsFromPreferences):
(WebView::updateSettingsFromPreferences):
(WebView::developerExtrasEnabled):
(WebView::initWithFrame):
(WebView::onNotify):
* WebView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Tue, 23 Oct 2007 23:11:39 +0000 (23:11 +0000)]
Reviewed by Sam.
- After talking with Steve I now see that the WebKit server must be
running for DCOM to create the distributed objects, which makes sense
and currently WebKit only allows one instance to be running at a time
which avoids accidentally connecting to the wrong server
- In light of this I have removed the code for the attach box and
NotificationServer and known server names, since they are all extranious
now.
* Drosera/win/Drosera.cpp: Removed notification classes and known server
names.
(_tWinMain): Uses init instead of initUI.
(droseraWndProc): No longer creats an attach dialog box.
(Drosera::Drosera): Does the OleInitialize so COM is ready to go and
it's not manditory to call init before doing COM stuff.
(Drosera::init): calls initUI and will call attach when the
functionality exists.
(Drosera::initUI): Has changed very little.
(Drosera::attach): Changed the signature to reflect that we no longer
need the dictionary of known server names.
* Drosera/win/Drosera.h: Removed notification classes and known server
names. Also renamed and moved some functions.
* Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
* Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
headers to the resources folder.
* Drosera/win/resource.h: Removed the Attach box.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 23 Oct 2007 22:27:42 +0000 (22:27 +0000)]
Reviewed by Darin.
- Add a compare script to compare results, and improve formatting of standard results a bit.
* resources/sunspider-analyze-results.js:
* resources/sunspider-compare-results.js: Added.
* sunspider-compare-results: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Tue, 23 Oct 2007 21:25:44 +0000 (21:25 +0000)]
Separating all of the simple binary expression nodes into multiple classes
Reviewed by Maciej
Separating all of the simple (eg. non-read-modify-write) binary operators into separate classes in preparation for further JS optimisations.
Happily this produces a 0.8% to 1.0% performance increase in SunSpider with no further work.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp [Tue, 23 Oct 2007 19:29:03 +0000 (19:29 +0000)]
2007-10-23 Jasper Bryant-Greene <m@ni.ac.nz>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15058
Precedence fault in KeyEventGdk causes shift, control, alt etc to work incorrectly
Corrected precendence fault which was causing Shift, Alt, Control and
Meta to behave incorrectly on GTK.
Coding style fix by Alp.
* platform/gtk/KeyEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 23 Oct 2007 18:25:58 +0000 (18:25 +0000)]
Add some SVG tests to the Windows Skipped file
Reviewed by Oliver.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 23 Oct 2007 18:11:16 +0000 (18:11 +0000)]
Reviewed by Tim Hatcher.
Add resizing of the DOM view right sidebar. This allows us to actually see the values now.
* page/inspector/ResourcePanel.js:
* page/inspector/inspector.css:
* page/inspector/inspector.js:
* page/inspector/utilities.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 23 Oct 2007 15:52:26 +0000 (15:52 +0000)]
Get basic hit testing right for transforms.
Reviewed by ollliej
* platform/graphics/AffineTransform.cpp:
(WebCore::AffineTransform::mapPoint):
* platform/graphics/AffineTransform.h:
* rendering/InlineBox.cpp:
(WebCore::InlineBox::nodeAtPoint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestLayer):
* rendering/RenderLayer.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::hitTest):
* rendering/RenderObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Oct 2007 15:49:31 +0000 (15:49 +0000)]
- removed numeric results so the test is more platform-independent
* fast/js/math-expected.txt: Updated.
* fast/js/resources/math.js: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Oct 2007 14:12:30 +0000 (14:12 +0000)]
JavaScriptCore:
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=15639
fix Math.abs(0), Math.ceil(-0), and Math.floor(-0)
Test: fast/js/math.html
* kjs/math_object.cpp: (MathFuncImp::callAsFunction):
Fix abs to look at the sign bit. Add a special case for values in the range
between -0 and -1 and a special case for ceil and for -0 for floor.
LayoutTests:
Reviewed by Maciej.
- test for http://bugs.webkit.org/show_bug.cgi?id=15639
Math functions
* fast/js/math-expected.txt: Added.
* fast/js/math.html: Added.
* fast/js/resources/math.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 23 Oct 2007 12:11:13 +0000 (12:11 +0000)]
2007-10-23 Mark Rowe <mrowe@apple.com>
Build fix for Eric's build fix in r26916.
* MigrateHeaders.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 23 Oct 2007 09:44:06 +0000 (09:44 +0000)]
2007-10-23 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Fix leaks seen on TOT from new font-face code.
* ksvg2/svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace): use a stack allocated CSSProperty instead of mallocing
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 23 Oct 2007 08:33:05 +0000 (08:33 +0000)]
2007-10-23 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Sacrifice three virgin hours upon the altar of the heathen XCode gods
and pray that our build troubles are finally over. :(
* DerivedSources.make: add DOMSVGException.h
* WebCore.xcodeproj/project.pbxproj: Remove DOMSVG*Interal.h files from "Copy Generated Headers" phase. Why? Who knows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 23 Oct 2007 07:07:37 +0000 (07:07 +0000)]
Reviewed by Darin.
* resources/sunspider-analyze-results.js: Do the error range
properly, using the t-distribution instead of 1.96 (which was
based on the normal distribution).
* sunspider: Print results in a way that will be friendlier to the
soon-to-come compare mode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 23 Oct 2007 07:00:37 +0000 (07:00 +0000)]
Reviewed by Eric.
- streamline exception handling code for a >1% speed-up of SunSpider
* kjs/nodes.cpp: Changed macros to use functions for everything that's not
part of normal execution. We'll take function call overhead when propagating
an exception or out of memory.
(KJS::createOutOfMemoryCompletion): Added.
(KJS::substitute): Use append instead of the relatively inefficient + operator.
(KJS::Node::rethrowException): Added.
* kjs/nodes.h: Added rethrowException.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Tue, 23 Oct 2007 06:45:32 +0000 (06:45 +0000)]
Fix build.
* plugins/win/PluginViewWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc