WebKit-https.git
9 years agoAdd a missing result after r150551.
rniwa@webkit.org [Wed, 22 May 2013 23:27:54 +0000 (23:27 +0000)]
Add a missing result after r150551.

* http/tests/inspector/network/network-size-chunked-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac test expectation corrections after r150545.
rniwa@webkit.org [Wed, 22 May 2013 23:24:51 +0000 (23:24 +0000)]
Mac test expectation corrections after r150545.

* platform/mac-lion/http/tests/multipart/policy-ignore-crash-expected.txt: Added.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore Mac test expectation cleanups.
rniwa@webkit.org [Wed, 22 May 2013 22:53:22 +0000 (22:53 +0000)]
More Mac test expectation cleanups.

* http/tests/inspector/network/network-size-sync-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix assertion in the getComputedStyle-background-shorthand.html test
simon.fraser@apple.com [Wed, 22 May 2013 22:19:18 +0000 (22:19 +0000)]
Fix assertion in the getComputedStyle-background-shorthand.html test
https://bugs.webkit.org/show_bug.cgi?id=116639

Reviewed by Ryosuke Niwa.

getComputedStyle-background-shorthand.html was asserting under the newly added
code in willBeRemovedFromTree(). The assertion was caused by too many calls to
FrameView::removeSlowRepaintObject(), which happened because we called it for
RenderTexts, which share style with their parent renderer.

RenderText overrides styleWillChange() to do nothing, so we never
call add/removeSlowRepaintObject() for them. Thus we should also skip this
work in willBeRemovedFromTree() for RenderTexts.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeRemovedFromTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: fast/files/workers tests crash
rniwa@webkit.org [Wed, 22 May 2013 22:18:37 +0000 (22:18 +0000)]
REGRESSION: fast/files/workers tests crash
https://bugs.webkit.org/show_bug.cgi?id=45575

Unskip the test since they no longer crash. Also rebaseline two tests as needed.

* fast/files/workers/worker-read-blob-async-expected.txt:
* fast/files/workers/worker-read-blob-sync-expected.txt:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac test expectation cleanups. Unskip a bunch of tests and rebaseline them as needed.
rniwa@webkit.org [Wed, 22 May 2013 22:11:07 +0000 (22:11 +0000)]
Mac test expectation cleanups. Unskip a bunch of tests and rebaseline them as needed.

* accessibility/aria-menubar-menuitems-expected.txt: Added.
* fast/replaced/border-radius-clip-expected.png:
* platform/mac/TestExpectations:
* platform/mac/fast/replaced/border-radius-clip-expected.txt:
* platform/mac/http/tests/multipart/policy-ignore-crash-expected.txt: Copied from LayoutTests/http/tests/multipart/policy-ignore-crash-expected.txt.
* platform/mac/media/video-volume-slider-expected.png: Added.
* platform/mac/media/video-volume-slider-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHeap-use-after-free in WebCore::RenderLayerModelObject::hasSelfPaintingLayer
commit-queue@webkit.org [Wed, 22 May 2013 22:08:21 +0000 (22:08 +0000)]
Heap-use-after-free in WebCore::RenderLayerModelObject::hasSelfPaintingLayer
https://bugs.webkit.org/show_bug.cgi?id=116626

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-05-22
Reviewed by David Hyatt.

This is a port of a Blink bug fix by Emil Eklund.

Account for saturated estimated position in RenderBlock::layoutBlockChild.

If the estimated top position is saturated the comparison with oldLogicalTop
might yield a false negative as adding and removing margins, borders etc from
a saturated number might yield incorrect results. If this is the case always
mark for layout.

Minimal test case impractical. See bug for raw fuzzer test case.

* platform/LayoutUnit.h:
(WebCore::LayoutUnit::mightBeSaturated): Add helper method for checking whether
    a number might be saturated.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChild): Check if logicalTopEstimate is likely
    to be saturated and if so mark for layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix crash when closing a page that's trying to access session storage
andersca@apple.com [Wed, 22 May 2013 21:25:22 +0000 (21:25 +0000)]
Fix crash when closing a page that's trying to access session storage
https://bugs.webkit.org/show_bug.cgi?id=116634
<rdar://problem/13904054>

Reviewed by Geoffrey Garen.

It is possible for the StorageManager to get messages from a web page that has already been closed by the UI process.
If that happens, just ignore the messages.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::getValues):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::removeItem):
(WebKit::StorageManager::clear):
(WebKit::StorageManager::destroySessionStorageNamespaceInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Exclusions] property parsing tests should be revised
hmuller@adobe.com [Wed, 22 May 2013 21:22:56 +0000 (21:22 +0000)]
[CSS Exclusions] property parsing tests should be revised
https://bugs.webkit.org/show_bug.cgi?id=116446

Reviewed by Alexandru Chiculita.

This is just a cleanup of the existing parsing tests. None of the tests have effectively
changed. The cleaned-up version should be simpler, more regular, and shorter:
- Moved all of parsing tests into a fast/exclusions/parsing subdirectory.
- Remove the obsolete "wrap-" prefix from file names.
- Eiminated excessive and needless stringification in many of the test functions.
- Moved common code into parsing-test-utils.js and refactored redundant code.

* fast/exclusions/parsing-wrap-shape-inside-expected.txt: Removed.
* fast/exclusions/parsing-wrap-shape-inside.html: Removed.
* fast/exclusions/parsing-wrap-shape-lengths-expected.txt: Removed.
* fast/exclusions/parsing-wrap-shape-lengths.html: Removed.
* fast/exclusions/parsing-wrap-shape-outside-expected.txt: Removed.
* fast/exclusions/parsing-wrap-shape-outside.html: Removed.
* fast/exclusions/parsing/parsing-shape-inside-expected.txt: Added.
* fast/exclusions/parsing/parsing-shape-inside.html: Added.
* fast/exclusions/parsing/parsing-shape-lengths-expected.txt: Added.
* fast/exclusions/parsing/parsing-shape-lengths.html: Added.
* fast/exclusions/parsing/parsing-shape-margin-expected.txt: Added.
* fast/exclusions/parsing/parsing-shape-margin.html: Added.
* fast/exclusions/parsing/parsing-shape-outside-expected.txt: Added.
* fast/exclusions/parsing/parsing-shape-outside.html: Added.
* fast/exclusions/parsing/parsing-shape-padding-expected.txt: Added.
* fast/exclusions/parsing/parsing-shape-padding.html: Added.
* fast/exclusions/parsing/parsing-wrap-flow-expected.txt: Added.
* fast/exclusions/parsing/parsing-wrap-flow.html: Added.
* fast/exclusions/parsing/parsing-wrap-through-expected.txt: Added.
* fast/exclusions/parsing/parsing-wrap-through.html: Added.
* fast/exclusions/parsing/script-tests/parsing-shape-inside.js: Added.
(string_appeared_here):
* fast/exclusions/parsing/script-tests/parsing-shape-lengths.js: Added.
(getStyleValue):
(testStyleValue):
(testComputedStyleValue):
(testInvalidValue):
* fast/exclusions/parsing/script-tests/parsing-shape-margin.js: Added.
(testShapeSpecifiedProperty):
* fast/exclusions/parsing/script-tests/parsing-shape-outside.js: Added.
(testShapePropertyParsingFailure):
* fast/exclusions/parsing/script-tests/parsing-shape-padding.js: Added.
(testShapeSpecifiedProperty):
* fast/exclusions/parsing/script-tests/parsing-test-utils.js: Added.
(getCSSText):
(getComputedStyleValue):
(getParentAndChildComputedStyles):
(getParentAndChildComputedStylesString):
(getChildComputedStyle):
(testShapeSpecifiedProperty):
(testShapeComputedProperty):
(testNotInheritedShapeChildProperty):
* fast/exclusions/parsing/script-tests/parsing-wrap-flow.js: Added.
* fast/exclusions/parsing/script-tests/parsing-wrap-through.js: Added.
* fast/exclusions/shape-margin-parsing-expected.txt: Removed.
* fast/exclusions/shape-margin-parsing.html: Removed.
* fast/exclusions/shape-padding-parsing-expected.txt: Removed.
* fast/exclusions/shape-padding-parsing.html: Removed.
* fast/exclusions/wrap-flow-parsing-expected.txt: Removed.
* fast/exclusions/wrap-flow-parsing.html: Removed.
* fast/exclusions/wrap-through-parsing-expected.txt: Removed.
* fast/exclusions/wrap-through-parsing.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove CSSPropertySourceData emptyCSSPropertySourceData
benjamin@webkit.org [Wed, 22 May 2013 20:52:07 +0000 (20:52 +0000)]
Remove CSSPropertySourceData emptyCSSPropertySourceData
https://bugs.webkit.org/show_bug.cgi?id=116517

Reviewed by Darin Adler.

This was added for chromium and does not seem to be used
anywhere anymore.

* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
* css/CSSPropertySourceData.cpp:
* css/CSSPropertySourceData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Crashes in NetworkProcess due to incorrect private browsing session tracking
ap@apple.com [Wed, 22 May 2013 20:50:44 +0000 (20:50 +0000)]
    Crashes in NetworkProcess due to incorrect private browsing session tracking
        https://bugs.webkit.org/show_bug.cgi?id=116628

        Reviewed by Brady Eidson.

        The current API for private browsing makes it extremely difficult to track sessions.
        Private browsing is enabled via WKPreferences, but the session is shared, so it
        has to be maintained while there is any chance that any page group anywhere still
        needs it.

        This patch fixes some of the issues, but ultimately, I think that we'll just need
        to deprecate and replace the API.

        * NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::storageSession):
        There are valid scenarios where privateBrowsingEnabled is true, but there is no
        private browsing session. Handle that without crashing, although this unfortunately
        means that it will be harder to spot logic errors when using a wrong session.
        (WebKit::NetworkConnectionToWebProcess::registerBlobURL): Removed an obsolete FIXME.

        * NetworkProcess/mac/RemoteNetworkingContext.h: Changed privateBrowsingSession()
        to return a pointer, as no caller could know when it was safe to call it.

        * NetworkProcess/mac/RemoteNetworkingContext.mm:
        (WebKit::RemoteNetworkingContext::storageSession): Handle the case where private
        browsing session is unexpectedly missing without crashing.
        (WebKit::RemoteNetworkingContext::privateBrowsingSession): Changed to return a pointer.

        * UIProcess/WebContext.cpp: (WebKit::WebContext::ensureNetworkProcess):
        Actually initialize privateBrowsingEnabled creation parameter. It would be very
        difficult to figure out 100% reliably whether NetworkProcess needs a private browsing
        session with the current API, but for existing clients, looking at
        m_privateBrowsingEnterCount is good enough. Certainly better than not initializing.

        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::setPrivateBrowsingEnabled): Added a FIXME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuildfix for !ENABLE(FULLSCREEN_API) platforms.
ossy@webkit.org [Wed, 22 May 2013 20:30:41 +0000 (20:30 +0000)]
Buildfix for !ENABLE(FULLSCREEN_API) platforms.

Rubber-stamped by Ryosuke Niwa.

* rendering/RenderInline.cpp: Missing #if guard added.
(WebCore::RenderInline::splitInlines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a typo in 150469.
rniwa@webkit.org [Wed, 22 May 2013 20:11:56 +0000 (20:11 +0000)]
Fix a typo in 150469.

* editing/Editor.cpp:
(WebCore::dispatchEditableContentChangedEvents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wk2] Should be able to make tiled WKViews clip to the view's exposed rect without...
timothy_horton@apple.com [Wed, 22 May 2013 19:48:26 +0000 (19:48 +0000)]
[wk2] Should be able to make tiled WKViews clip to the view's exposed rect without using autolayout
https://bugs.webkit.org/show_bug.cgi?id=116625
<rdar://problem/13962816>

Reviewed by Anders Carlsson.

The two modes are not dependent; it should be possible to enable
clips-to-exposed-rect without using autolayout. This enables apps to
make very large tiled WKViews that don't create tiles for the whole
area of the view (and also disables scrolling, since that is currently
incompatible with clipping to the exposed rect).

* UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView forceAsyncDrawingAreaSizeUpdate:]):
Rename _expandsToFitContentViaAutoLayout to _clipsToVisibleRect for accuracy.

(-[WKView setMinimumWidthForAutoLayout:]):
Factor clips-to-sisible-rect toggle out into setShouldClipToVisibleRect.

(-[WKView shouldClipToVisibleRect]):
(-[WKView setShouldClipToVisibleRect:]):
Allow setting clips-to-visible-rect without autolayout.

* UIProcess/API/mac/WKViewPrivate.h:
Add shouldClipToVisibleRect property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: ASSERTION FAILED: obj->isRenderInline() || obj == this, Bad cast in WebCo...
rniwa@webkit.org [Wed, 22 May 2013 19:21:52 +0000 (19:21 +0000)]
REGRESSION: ASSERTION FAILED: obj->isRenderInline() || obj == this, Bad cast in WebCore::RenderBlock::createLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=110622

Reviewed by David Hyatt.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/998ad358eed702b873dd54697b3fa3f952e0feb7

Inserting an element before the fullscreened element could crash if it caused a containing inline to be split,
since the splitting logic doesn't expect the fullscreened element to be wrapped in a RenderFullScreen. This patch changes
inline splitting to be aware of RenderFullScreen.

Test: fullscreen/full-screen-inline-split-crash.html

* rendering/RenderInline.cpp:
(WebCore::RenderInline::splitInlines):

LayoutTests:

Add a regression test.

* fullscreen/full-screen-inline-split-crash-expected.txt: Added.
* fullscreen/full-screen-inline-split-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix issues with focus rings on search fields
simon.fraser@apple.com [Wed, 22 May 2013 19:06:13 +0000 (19:06 +0000)]
Fix issues with focus rings on search fields
https://bugs.webkit.org/show_bug.cgi?id=116591

Source/WebCore:

Reviewed by Darin Adler.

On a future OS, the rect returned by _focusRingVisibleRect should
be in the coordinate system of the that NSView, not the base
coordinate system, so fix the code that sets and reads the global
focusRingClipRect variable accordingly.

* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
* platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView _focusRingVisibleRect]):

Source/WebKit/mac:

Reviewed by Darin Adler.

In WebKit1, focus rings didn't render correctly on some OSes until
some other control drew a focus ring, which changes internal AppKit state
on the focused view. Fix by overriding an internal AppKit method to always
disable AppKit's "automatic" focus ring drawing.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _automaticFocusRingDisabled]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew Flickr doesn't get fast scrolling but should
simon.fraser@apple.com [Wed, 22 May 2013 19:06:09 +0000 (19:06 +0000)]
New Flickr doesn't get fast scrolling but should
https://bugs.webkit.org/show_bug.cgi?id=116514

Source/WebCore:

Reviewed by Darin Adler.

RenderObject increments and decrements a counter of slow repaint objects on
FrameView when it sees style changes related to background-attachment:fixed.
However, it omitted to decrement the count when a renderer with a fixed background
was destroyed.

This caused Flickr to never fall into fast scrolling mode, since it toggled
display:none on an element with a fixed background during loading, then removed
the fixed background.

Did some minor cleanup of #ENABLE(FAST_MOBILE_SCROLLING) crap.

Tests: platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html
       platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html
       platform/mac-wk2/tiled-drawing/slow-scrolling.html

* rendering/RenderObject.cpp:
(WebCore::shouldRepaintFixedBackgroundsOnScroll):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::willBeRemovedFromTree):

LayoutTests:

Reviewed by Darin Adler.

slow-scrolling-hidden-background-toggle.html actually tests this patch. The other
two tests were added because there appear to be no tests for basic internals.mainThreadScrollingReasons()
functionality.

* platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html: Added.
* platform/mac-wk2/tiled-drawing/slow-scrolling-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html: Added.
* platform/mac-wk2/tiled-drawing/slow-scrolling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed to Remove Anonymous Wrappers When All Children Become Inline
robert@webkit.org [Wed, 22 May 2013 18:59:38 +0000 (18:59 +0000)]
Need to Remove Anonymous Wrappers When All Children Become Inline
https://bugs.webkit.org/show_bug.cgi?id=115687

Reviewed by David Hyatt.

Source/WebCore:

Remove a simple subset of anonymous wrappers, i.e. anonymous blocks without continuations,
when a block becoming float or positioned removes the need for them.

Test: fast/block/remove-anonymous-wrappers-when-element-changes-to-float-or-positioned.html

* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderObject.cpp:
(WebCore):
(WebCore::RenderObject::removeAnonymousWrappersFromLineIfNecessary):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):
* rendering/RenderObject.h:
(RenderObject):

LayoutTests:

* fast/block/remove-anonymous-wrappers-when-element-changes-to-float-or-positioned-expected.txt: Added.
* fast/block/remove-anonymous-wrappers-when-element-changes-to-float-or-positioned.html: Added.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling2-expected.txt:
* platform/qt/fast/dynamic/002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[css] Update ETextDecorations enum to TextDecorations
bruno.abinader@basyskom.com [Wed, 22 May 2013 18:38:07 +0000 (18:38 +0000)]
[css] Update ETextDecorations enum to TextDecorations
https://bugs.webkit.org/show_bug.cgi?id=116581

Reviewed by Andreas Kling.

Currently, ETextDecorations enum uses a C-like coding style for its
enumeration values, as well as a 'E' prefix that surely had some meaning
in the past, but not nowadays.

No behavior changes, covered by existing tests.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::hasPlainText):
(WebCore::AccessibilityRenderObject::hasUnderline):
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(AXAttributeStringSetStyle):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXAttributeStringSetStyle):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationFlagsToCSSValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TextDecoration):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyTextDecoration::createHandler):
* editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
* platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):
* rendering/InlineTextBox.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
(WebCore::operator|):
(WebCore::operator|=):
* rendering/style/StyleVisualData.h:
(StyleVisualData):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paint):
(WebCore::positionOffsetForDecoration):
(WebCore::thicknessForDecoration):
(WebCore::findRenderObjectDefininingTextDecoration):
(WebCore::SVGInlineTextBox::paintDecoration):
(WebCore::SVGInlineTextBox::paintDecorationWithStyle):
* rendering/svg/SVGInlineTextBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GStreamer] Allow multiple log levels in media player
commit-queue@webkit.org [Wed, 22 May 2013 18:30:55 +0000 (18:30 +0000)]
[GStreamer] Allow multiple log levels in media player
https://bugs.webkit.org/show_bug.cgi?id=116618

Patch by Lori Anderson <lori@rkymtnhi.com> on 2013-05-22
Reviewed by Philippe Normand.

No new tests, just changing logging.

* platform/graphics/gstreamer/GStreamerUtilities.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
(WebCore::MediaPlayerPrivateGStreamer::pause):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Added myself to contributors.json.
achristensen@apple.com [Wed, 22 May 2013 18:13:32 +0000 (18:13 +0000)]
Unreviewed.  Added myself to contributors.json.

* Scripts/webkitpy/common/config/contributors.json:
Added myself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe LayoutMilestones didLayout callback sometimes fires with a milestone value of 0
bdakin@apple.com [Wed, 22 May 2013 18:06:23 +0000 (18:06 +0000)]
The LayoutMilestones didLayout callback sometimes fires with a milestone value of 0
https://bugs.webkit.org/show_bug.cgi?id=116623

Reviewed by Geoffrey Garen.

Make sure we have actually achieved some milestones before calling didLayout().
* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Remove unused private browsing override support
ap@apple.com [Wed, 22 May 2013 17:09:13 +0000 (17:09 +0000)]
    Remove unused private browsing override support
        <rdar://problem/11969491>

        Rubber-stamped by Sam Weinig.

        Private browsing override is unused, and it complicates tracking of private
        browsing sessions in UI process (in fact, it doesn't plug into this tracking at all,
        so we would just assert if we used the API).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[sh4] Remove MacroAssemblerSH4.cpp file.
commit-queue@webkit.org [Wed, 22 May 2013 16:42:29 +0000 (16:42 +0000)]
[sh4] Remove MacroAssemblerSH4.cpp file.
https://bugs.webkit.org/show_bug.cgi?id=116596.

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-22
Reviewed by Geoffrey Garen.

Move linkCall and repatchCall implementations from MacroAssemblerSH4.cpp
to MacroAssemblerSH4.h and remove MacroAssemblerSH4.cpp, as it is done
for other architectures.

* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/MacroAssemblerSH4.cpp: Removed.
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::linkCall):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::repatchCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Reimplement atk_text_get_text_*_offset for CHAR boundary
mario@webkit.org [Wed, 22 May 2013 16:22:05 +0000 (16:22 +0000)]
[GTK] Reimplement atk_text_get_text_*_offset for CHAR boundary
https://bugs.webkit.org/show_bug.cgi?id=114870

Reviewed by Martin Robinson.

Re-implement this functions without using GailTextUtil nor Pango.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetChar): New function.
(webkitAccessibleTextGetTextForOffset): Call the new function for CHAR.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Unreviewed gardening. Skipping failing printing tests after r150046.
zarvai@inf.u-szeged.hu [Wed, 22 May 2013 16:18:26 +0000 (16:18 +0000)]
[Qt][WK2] Unreviewed gardening. Skipping failing printing tests after r150046.
https://bugs.webkit.org/show_bug.cgi?id=116617

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] Captions menu isn't internationalized, doesn't use rtl layout for rtl languages
graouts@apple.com [Wed, 22 May 2013 16:11:55 +0000 (16:11 +0000)]
[Mac] Captions menu isn't internationalized, doesn't use rtl layout for rtl languages
https://bugs.webkit.org/show_bug.cgi?id=116605

Reviewed by Eric Carlson.

Ensure that rtl languages are properly recognized by the captions menu such that text
layout and alignment is natural.

* css/mediaControls.css:
(::-webkit-media-controls):
Remove the forced "direction: ltr" property which was forcing all layout to be
left-to-right.

* css/mediaControlsQuickTime.css:
(video::-webkit-media-controls-closed-captions-track-list):
Remove the forced "text-align: left" property which was forcing all caption
titles to be left-aligned.

(video::-webkit-media-controls-closed-captions-track-list h3):
Use "-webkit-margin-start" instead of "padding-left" to position the heading
such that it adds the margin on the left for ltr languages and on the right
for rtl languages.

(video::-webkit-media-controls-closed-captions-track-list li):
Set "position: relative" such that the ::before pseudo-class can use "position: absolute"
to position itself relative to the caption title rather than the list element.

(video::-webkit-media-controls-closed-captions-track-list li.selected::before):
(video::-webkit-media-controls-closed-captions-track-list li.selected:hover::before):
Make the checkmarks a ::before pseudo-class rather than a background-image such that
we may control its positioning using the internationlization-friendly "-webkit-margin-start"
property.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsContainerElement::create):
Set the "dir" attribute to "auto" such that rtl languages are correctly handled. This
means that the first string displayed within the captions container, currently the
"Subtitles" <h3> element, defines the direction for the whole container. It is therefore
crucial that this string is properly localized in rtl languages as falling back to
english would mean the entire caption container is using ltr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Add sub menus to MiniBrowser
commit-queue@webkit.org [Wed, 22 May 2013 14:16:54 +0000 (14:16 +0000)]
[EFL][WK2] Add sub menus to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=114728

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-05-22
Reviewed by Christophe Dumez.

Elementary Ctxpopup widget API does not provide support for submenu item.
To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
Elementary Menu widget.

* MiniBrowser/efl/main.c:
(_Browser_Window):
(on_window_resize):
(window_free):
(context_menu_item_selected_cb):
(context_menu_populate):
(on_context_menu_show):
(on_context_menu_hide):
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Skip failing tests after r150065 and r150498.
kadam@inf.u-szeged.hu [Wed, 22 May 2013 14:15:31 +0000 (14:15 +0000)]
[Qt] Unreviewed gardening. Skip failing tests after r150065 and r150498.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore fails to compile with -Werror=maybe-uninitialized on GCC 4.8.0
hugo.lima@openbossa.org [Wed, 22 May 2013 13:45:15 +0000 (13:45 +0000)]
WebCore fails to compile with -Werror=maybe-uninitialized on GCC 4.8.0
https://bugs.webkit.org/show_bug.cgi?id=116340

Reviewed by Christophe Dumez.

No new tests, just a simple build fix.

* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem): Init frame variable.
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): Init frame variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSSRegions] Remove platform-specific differences from offsetLeft/offsetTop tests
commit-queue@webkit.org [Wed, 22 May 2013 13:36:43 +0000 (13:36 +0000)]
[CSSRegions] Remove platform-specific differences from offsetLeft/offsetTop tests
https://bugs.webkit.org/show_bug.cgi?id=116607

Patch by Radu Stavila <stavila@adobe.com> on 2013-05-22
Reviewed by Antti Koivisto.

* fast/regions/offsetLeft-offsetTop-in-multiple-regions-expected.txt:
* fast/regions/offsetLeft-offsetTop-in-multiple-regions.html:
* fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl.html:
* fast/regions/offsetLeft-offsetTop-inlines-region-in-element.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add command line option to MiniBrowser to set cookies policy.
commit-queue@webkit.org [Wed, 22 May 2013 12:49:15 +0000 (12:49 +0000)]
[EFL] Add command line option to MiniBrowser to set cookies policy.
https://bugs.webkit.org/show_bug.cgi?id=115028

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-05-22
Reviewed by Christophe Dumez.

Add command line option to MiniBrowser EFL to set cookies policy:
-p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).

* MiniBrowser/efl/main.c:
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening, updating expected files after r150508.
zarvai@inf.u-szeged.hu [Wed, 22 May 2013 12:20:32 +0000 (12:20 +0000)]
[Qt] Unreviewed gardening, updating expected files after r150508.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22

* platform/qt-5.0-wk2/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
* platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHave IDL interface names match their global constructor
ch.dumez@sisa.samsung.com [Wed, 22 May 2013 12:04:35 +0000 (12:04 +0000)]
Have IDL interface names match their global constructor
https://bugs.webkit.org/show_bug.cgi?id=116520

Reviewed by Kentaro Hara.

Have IDL interface names match their global constructor name on DOMWindow.idl
using [InterfaceName] extended attribute. This affects in particular webkit
prefixed constructors. This is mandated by Web IDL specification:
http://dev.w3.org/2006/webapi/WebIDL/#es-interfaces

As a consequence, we can now get rid of [NoInterfaceObject] extended attribute
for those interfaces and have their global constructors automatically generated
by the bindings generator.

No new tests, no behavior change for layout tests.

* Modules/mediasource/MediaSource.idl:
* Modules/mediasource/SourceBuffer.idl:
* Modules/mediasource/SourceBufferList.idl:
* Modules/mediastream/MediaStream.idl:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/speech/SpeechGrammar.idl:
* Modules/speech/SpeechGrammarList.idl:
* Modules/speech/SpeechRecognition.idl:
* Modules/speech/SpeechRecognitionError.idl:
* Modules/speech/SpeechRecognitionEvent.idl:
* Modules/webaudio/OfflineAudioContext.idl:
* Modules/webaudio/PannerNode.idl:
* dom/ShadowRoot.idl:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Unskipping some tests.
zarvai@inf.u-szeged.hu [Wed, 22 May 2013 11:42:40 +0000 (11:42 +0000)]
[Qt] Unreviewed gardening. Unskipping some tests.
https://bugs.webkit.org/show_bug.cgi?id=26830
https://bugs.webkit.org/show_bug.cgi?id=99870
https://bugs.webkit.org/show_bug.cgi?id=108429
https://bugs.webkit.org/show_bug.cgi?id=23166
https://bugs.webkit.org/show_bug.cgi?id=98523
https://bugs.webkit.org/show_bug.cgi?id=110654

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22

* platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
* platform/qt/TestExpectations:
* platform/qt/css2.1/20110323/replaced-elements-001-expected.png:
* platform/qt/css2.1/20110323/replaced-elements-001-expected.txt:
* platform/qt/css3/flexbox/button-expected.png: Added.
* platform/qt/css3/flexbox/button-expected.txt: Added.
* platform/qt/fast/css/background-clip-radius-values-expected.png: Added.
* platform/qt/fast/css/background-clip-radius-values-expected.txt: Added.
* platform/qt/fast/images/repaint-subrect-grid-expected.txt: Added.
* platform/qt/fast/multicol/single-line-expected.png: Added.
* platform/qt/fast/multicol/single-line-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
* platform/qt/svg/custom/foreign-object-skew-expected.txt:
* platform/qt/svg/custom/js-late-pattern-creation-expected.png:
* platform/qt/svg/custom/pattern-scaling-expected.png: Added.
* platform/qt/svg/custom/pattern-scaling-expected.txt: Added.
* platform/qt/svg/custom/pattern-skew-transformed-expected.png:
* platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Added.
* platform/qt/svg/custom/pattern-with-transformation-expected.png:
* platform/qt/svg/custom/text-ctm-expected.png:
* platform/qt/svg/custom/text-ctm-expected.txt:
* platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
* platform/qt/tables/mozilla/bugs/bug92647-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Change Ewk_Context_Menu_Item's parent menu to raw pointer
commit-queue@webkit.org [Wed, 22 May 2013 09:37:49 +0000 (09:37 +0000)]
[EFL][WK2] Change Ewk_Context_Menu_Item's parent menu to raw pointer
https://bugs.webkit.org/show_bug.cgi?id=116549

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-05-22
Reviewed by Christophe Dumez.

A context menu item should have only a pointer to parent menu instead
of owning parent menu.

* UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
* UIProcess/API/efl/ewk_context_menu_item_private.h:
(EwkContextMenuItem::create):
(EwkContextMenuItem::parentMenu):
(EwkContextMenuItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Unskipping some tests.
zarvai@inf.u-szeged.hu [Wed, 22 May 2013 09:25:55 +0000 (09:25 +0000)]
[Qt] Unreviewed gardening. Unskipping some tests.
https://bugs.webkit.org/show_bug.cgi?id=105437

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22

* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.txt: Added.
* platform/qt/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Copied from LayoutTests/platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.png.
* platform/qt/svg/filters/feImage-animated-transform-on-target-rect-expected.txt: Added.
* platform/qt/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
* platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
* platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
* platform/qt/svg/filters/feImage-late-indirect-update-expected.png:
* platform/qt/svg/filters/feImage-late-indirect-update-expected.txt: Added.
* platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.png:
* platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
* platform/qt/svg/filters/feImage-position-expected.png:
* platform/qt/svg/filters/feImage-position-expected.txt: Added.
* platform/qt/svg/filters/feImage-preserveAspectratio-expected.png:
* platform/qt/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
* platform/qt/svg/filters/feImage-reference-invalidation-expected.png:
* platform/qt/svg/filters/feImage-reference-invalidation-expected.txt: Added.
* platform/qt/svg/filters/feImage-subregions-expected.png:
* platform/qt/svg/filters/feImage-subregions-expected.txt: Added.
* platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
* platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.txt: Added.
* platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
* platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-add-to-document-expected.png:
* platform/qt/svg/filters/feImage-target-add-to-document-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-attribute-change-expected.png:
* platform/qt/svg/filters/feImage-target-attribute-change-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
* platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
* platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-changes-id-expected.png:
* platform/qt/svg/filters/feImage-target-changes-id-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-id-change-expected.png:
* platform/qt/svg/filters/feImage-target-id-change-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-inline-style-change-expected.png:
* platform/qt/svg/filters/feImage-target-inline-style-change-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-property-change-expected.png:
* platform/qt/svg/filters/feImage-target-property-change-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-reappend-to-document-expected.png:
* platform/qt/svg/filters/feImage-target-reappend-to-document-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-remove-from-document-expected.png:
* platform/qt/svg/filters/feImage-target-remove-from-document-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-style-change-expected.png:
* platform/qt/svg/filters/feImage-target-style-change-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] accessibility/label-for-control-hittest.html is failing
commit-queue@webkit.org [Wed, 22 May 2013 07:24:14 +0000 (07:24 +0000)]
[EFL] accessibility/label-for-control-hittest.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112029

Unreviewed EFL gardening.

accessibility/label-for-control-hittest.html passes after r150439.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-05-22

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Unreviewed buildfix after r150484.
ossy@webkit.org [Wed, 22 May 2013 07:07:15 +0000 (07:07 +0000)]
[Qt][WK2] Unreviewed buildfix after r150484.

* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Update the background blending implementation to match the changes...
commit-queue@webkit.org [Wed, 22 May 2013 06:26:11 +0000 (06:26 +0000)]
Source/WebCore: Update the background blending implementation to match the changes done
in the spec. This implies that background color blending is removed and
the background layers won't blend with the content behind the element
any more.
https://bugs.webkit.org/show_bug.cgi?id=116212

Patch by Mihai Tica <mitica@adobe.com> on 2013-05-21
Reviewed by Dean Jackson.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests: Updating element background blending to conform to the changes in the spec.
This implies that the background layers won't longer blend with the content
behind the element.
Removing the background color tests, as background color blending is no longer
a valid use case, also modified the current background image tests.
https://bugs.webkit.org/show_bug.cgi?id=116212

Patch by Mihai Tica <mitica@adobe.com> on 2013-05-21
Reviewed by Dean Jackson.

* css3/compositing/effect-background-blend-mode-color-expected.txt: Removed.
* css3/compositing/effect-background-blend-mode-color.html: Removed.
* css3/compositing/effect-background-blend-mode-color2-expected.txt: Removed.
* css3/compositing/effect-background-blend-mode-color2.html: Removed.
* css3/compositing/effect-background-blend-mode-stacking-expected.png: Removed.
* css3/compositing/effect-background-blend-mode-stacking.html:
* platform/mac/css3/compositing/effect-background-blend-mode-color-expected.png: Removed.
* platform/mac/css3/compositing/effect-background-blend-mode-color2-expected.png: Removed.
* platform/mac/css3/compositing/effect-background-blend-mode-expected.png:
* platform/mac/css3/compositing/effect-background-blend-mode-stacking-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Cleanup TestExpectations to pass --lint-test-files
commit-queue@webkit.org [Wed, 22 May 2013 06:18:04 +0000 (06:18 +0000)]
[EFL] Cleanup TestExpectations to pass --lint-test-files
https://bugs.webkit.org/show_bug.cgi?id=116590

Unreviewed EFL gardening.

http/tests/websocket/tests/hybi/close-on-navigate-new-location.html was skipped in r150497.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-21

* platform/efl/TestExpectations: Remove duplicate entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Mac] inspector/geolocation-error.html is flaky
rniwa@webkit.org [Wed, 22 May 2013 06:09:57 +0000 (06:09 +0000)]
Web Inspector: [Mac] inspector/geolocation-error.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=116592

Add a flaky test expectation.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r150491): WebKit2.CloseThenTerminate asserting below WebContext::disconnec...
akling@apple.com [Wed, 22 May 2013 05:49:53 +0000 (05:49 +0000)]
REGRESSION(r150491): WebKit2.CloseThenTerminate asserting below WebContext::disconnectProcess().
<http://webkit.org/b/116588>

Reviewed by Sam Weinig.

Do an early return from WebProcessProxy::requestTermination() if there is no child process
connection to terminate.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::requestTermination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows, curl] WebDownloadCurl.cpp should not include SystemTime.h
commit-queue@webkit.org [Wed, 22 May 2013 03:07:20 +0000 (03:07 +0000)]
[Windows, curl] WebDownloadCurl.cpp should not include SystemTime.h
https://bugs.webkit.org/show_bug.cgi?id=116584

Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-05-21
Reviewed by Brent Fulgham.

SystemTime header and implementation are no longer used and were removed
recently - http://trac.webkit.org/changeset/150216.

* WebDownloadCurl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse-after-free in DOMSelection::containsNode
rniwa@webkit.org [Wed, 22 May 2013 02:36:37 +0000 (02:36 +0000)]
Use-after-free in DOMSelection::containsNode
https://bugs.webkit.org/show_bug.cgi?id=116468

Reviewed by Andreas Kling.

Source/WebCore:

Retain the node pointer. Also bail out early if the node was not in the document
since Range::compareBoundaryPoints sets ec to WRONG_DOCUMENT_ERR otherwise.

Test: editing/selection/contains-node-crash.html

* page/DOMSelection.cpp:
(WebCore::DOMSelection::containsNode):
* page/DOMSelection.h:
(DOMSelection):

LayoutTests:

Add a regression test from https://chromium.googlesource.com/chromium/blink/+/40bb8089352b15dd034641b4c131111cd79b44f1.

* editing/selection/contains-node-crash-expected.txt: Added.
* editing/selection/contains-node-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed EFL gardening.
gyuyoung.kim@samsung.com [Wed, 22 May 2013 02:35:51 +0000 (02:35 +0000)]
Unreviewed EFL gardening.

Skip a test which has problem related to ecore library.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: InspectorFrontendHost::loadResourceSynchronously() builds ASCII-only...
commit-queue@webkit.org [Wed, 22 May 2013 02:13:58 +0000 (02:13 +0000)]
Web Inspector: InspectorFrontendHost::loadResourceSynchronously() builds ASCII-only results
https://bugs.webkit.org/show_bug.cgi?id=116569

Merge: https://chromium.googlesource.com/chromium/blink/+/7f1cfecfe34f4dbc6ce1ef0250b13f2058128eeb

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-05-21
Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector/load-resource-synchronously-utf8.html

* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::loadResourceSynchronously):

LayoutTests:

* inspector/load-resource-synchronously-utf8-expected.txt: Added.
* inspector/load-resource-synchronously-utf8.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/13915556> Sluggish scrolling in web content
mrowe@apple.com [Wed, 22 May 2013 02:13:14 +0000 (02:13 +0000)]
<rdar://problem/13915556> Sluggish scrolling in web content

Reviewed by Gavin Barraclough.

* Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setProcessSuppressionEnabled): When process suppression is disabled, low latency is important.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build break after r150484
gyuyoung.kim@samsung.com [Wed, 22 May 2013 01:47:39 +0000 (01:47 +0000)]
Fix build break after r150484

Unreviewed, fix build break on EFL, GTK.

* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
* UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r150369): WebKit2WillLoadTest tests are failing
rniwa@webkit.org [Wed, 22 May 2013 00:25:21 +0000 (00:25 +0000)]
REGRESSION(r150369): WebKit2WillLoadTest tests are failing
https://bugs.webkit.org/show_bug.cgi?id=116585

Reviewed by Alexey Proskuryakov.

willLoadURLRequest and willLoadDataRequest require the API version 6.

* TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCheck in the test and result I forgot to 'git add' before committing r150490.
aestes@apple.com [Wed, 22 May 2013 00:07:07 +0000 (00:07 +0000)]
Check in the test and result I forgot to 'git add' before committing r150490.

* http/tests/security/cross-origin-session-storage-third-party-blocked-expected.txt: Added.
* http/tests/security/cross-origin-session-storage-third-party-blocked.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPPT: Closing tab that is hung or chewing 100% CPU leaves abandoned WebProcess.
akling@apple.com [Wed, 22 May 2013 00:07:02 +0000 (00:07 +0000)]
PPT: Closing tab that is hung or chewing 100% CPU leaves abandoned WebProcess.
<http://webkit.org/b/116464>
<rdar://problem/10103795>

Reviewed by Anders Carlsson.

Simplify the web process sacrifice ritual. Instead of murderizing the process when its last tab closes,
just shut down the CoreIPC connection from the UI process. The web process, upon noticing this,
will start a 10 second watchdog timer, and if it hasn't shut down by the time it fires, well, it'll shut down.

(WebKit::WebProcessProxy::removeWebPage):

    When the last page is removed from a WebProcessProxy, disconnect the process so that it'll die off
    eventually, even if the WebPage::Close message never gets properly handled.

* Shared/ChildProcessProxy.h:
* Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::abortProcessLaunchIfNeeded):

    Added a helper to abort any in-progress launch of a new web process. Otherwise we'll have a race
    where the exiting web process may get re-used for a new tab.

* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::enableSuddenTermination):
(WebKit::WebProcessProxy::disableSuddenTermination):

    Remove WebProcessProxy's sudden termination counter. The web process will do what it needs in
    response to the WebPage::Close message. We still forward these calls to NSProcessInfo on Mac though.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow session storage for third-party origins even if third-party data access is...
aestes@apple.com [Wed, 22 May 2013 00:03:15 +0000 (00:03 +0000)]
Allow session storage for third-party origins even if third-party data access is blocked.
https://bugs.webkit.org/show_bug.cgi?id=116532

Reviewed by Anders Carlsson.

Source/WebCore:

In http://trac.webkit.org/changeset/149326 we relaxed our policy for
localStorage when third-party data blocking is enabled to create a
transient, session-scoped storage area for the third-party origin
instead of throwing an exception. Since this gives essentially the same
behavior as sessionStorage, we might as well also allow sessionStorage
for third-party origins.

Test: http/tests/security/cross-origin-session-storage-third-party-blocked.html

* WebCore.exp.in: Updated the symbol for
SecurityOrigin::canAccessStorage.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage): Called canAccessSessionStorage()
rather than canAccessLocalStorage().
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canAccessStorage): Passed in an enum
indicating if access should be allowed from third-party origins.
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canAccessSessionStorage): Called
canAccessStorage() with AlwaysAllowFromThirdParty.
(SecurityOrigin):

LayoutTests:

* http/tests/security/cross-origin-session-storage-third-party-blocked-expected.txt: Renamed from LayoutTests/http/tests/security/cross-origin-session-storage-expected.txt.
* http/tests/security/cross-origin-session-storage-third-party-blocked.html: Renamed from LayoutTests/http/tests/security/cross-origin-session-storage.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows] Unreviewed speculative fix for test-bots.
bfulgham@apple.com [Tue, 21 May 2013 23:53:49 +0000 (23:53 +0000)]
[Windows] Unreviewed speculative fix for test-bots.

Add export declaration for WTFInvokeCrashHook to avoid runtime
load error on test bots.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: inspector/styles/import-pseudoclass-crash.html intermittently hits...
rniwa@webkit.org [Tue, 21 May 2013 23:34:37 +0000 (23:34 +0000)]
Web Inspector: inspector/styles/import-pseudoclass-crash.html intermittently hits an assertion in HTMLLinkElement::startLoadingDynamicSheet
https://bugs.webkit.org/show_bug.cgi?id=116582

Add a flaky crash expectation.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Mountain Lion test expectations per bug 116477.
rniwa@webkit.org [Tue, 21 May 2013 23:09:51 +0000 (23:09 +0000)]
Update Mountain Lion test expectations per bug 116477.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Tue, 21 May 2013 23:02:34 +0000 (23:02 +0000)]
Fix build.

* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Stop using lambdas :(

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add missing #if guards on drag support methods
hugo.lima@openbossa.org [Tue, 21 May 2013 23:01:29 +0000 (23:01 +0000)]
[EFL] Add missing #if guards on drag support methods
https://bugs.webkit.org/show_bug.cgi?id=116574

Reviewed by Christophe Dumez.

* platform/efl/PasteboardEfl.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoProvide an API to run sandboxed plug-ins outside of their sandbox
andersca@apple.com [Tue, 21 May 2013 22:54:21 +0000 (22:54 +0000)]
Provide an API to run sandboxed plug-ins outside of their sandbox
https://bugs.webkit.org/show_bug.cgi?id=116578

Reviewed by Andreas Kling.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add new overload.

* PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
(WebKit::PluginProcessMainDelegate::getExtraInitializationData):
Handle "disable-sandbox".

* PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(WebKit::PluginServiceInitializerDelegate::getExtraInitializationData):
Handle "disable-sandbox".

* PluginProcess/PluginProcess.h:
Move Type to PluginProcessAttributes and remove hash traits for type.

* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::platformInitializePluginProcess):
Update for new type name.

(WebKit::PluginProcess::initializeSandbox):
Return early if the sandbox is disabled.

* Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::getPluginModuleInformation):
PluginInfoStore::policyForPlugin has been renamed to PluginInfoStore::defaultLoadPolicyForPlugin.

* Shared/Plugins/PluginModuleInfo.h:
Add PluginModuleLoadUnsandboxed.

* Shared/Plugins/PluginProcessAttributes.h: Added.
Add new header with various plug-in process attributes.

* Shared/Plugins/PluginProcessCreationParameters.h:
Change type enum.

* UIProcess/API/C/WKAPICast.h:
(WebKit::toWKPluginLoadPolicy):
(WebKit::toPluginModuleLoadPolicy):
Handle the unsandboxed enum.

* UIProcess/API/C/WKPage.h:
Add kWKPluginLoadPolicyLoadUnsandboxed.

* UIProcess/Plugins/PluginInfoStore.h:
Rename policyForPlugin to defaultLoadPolicyForPlugin.

* UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::pluginProcessToken):
Add new helper function for getting a token given plug-in attributes.

(WebKit::PluginProcessManager::getPluginProcessConnection):
This now takes a pluginProcessToken.

(WebKit::PluginProcessManager::getSitesWithData):
Make sure to call pluginProcessToken.

(WebKit::PluginProcessManager::clearSiteData):
Ditto.

(WebKit::PluginProcessManager::getOrCreatePluginProcess):
This now takes a token.

* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::create):
(WebKit::PluginProcessProxy::PluginProcessProxy):
Pass the PluginProcessAttributes as well as the plug-in process token.

(WebKit::PluginProcessProxy::getLaunchOptions):
Pass the plug-in process attributes to platformGetLaunchOptions.

(WebKit::PluginProcessProxy::didClose):
Pass the token to PluginProcessCrashed.

(WebKit::PluginProcessProxy::didFinishLaunching):
Update for type change.

* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::shouldBlockPlugin):
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
Rename policyForPlugin to defaultLoadPolicyForPlugin.

* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
Set the "disable-sandbox" data if needed.

(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit::PluginProcessProxy::openPluginPreferencePane):
Get the module info from m_pluginProcessAttributes.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
This now returns a token.

* UIProcess/WebPageProxy.messages.in:
FindPlugin now returns a token instead of the path.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginProcessConnection):
Pass the token to the plug-in process manager.

* UIProcess/WebProcessProxy.messages.in:
This now takes a token.

* WebKit2.xcodeproj/project.pbxproj:
Add new files.

* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::PluginProcessConnection):
This now takes a token.

* WebProcess/Plugins/PluginProcessConnection.h:
(WebKit::PluginProcessConnection::create):
(WebKit::PluginProcessConnection::pluginProcessToken):
Create this with a token instead of a path and process type.

* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
This now takes a token.

(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):
Ditto.

* WebProcess/Plugins/PluginProcessConnectionManager.messages.in:
PluginProcessCrashed now takes a token.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::create):
(WebKit::PluginProxy::PluginProxy):
These now take tokens.

(WebKit::PluginProxy::initialize):
Pass the token when getting the connection.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Get the token from the UI process and pass it to the PluginProxy.

(WebKit::WebPage::canPluginHandleResponse):
Update now that FindPlugin returns a token.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove stub HTMLContentElement
antti@apple.com [Tue, 21 May 2013 22:48:37 +0000 (22:48 +0000)]
Remove stub HTMLContentElement
https://bugs.webkit.org/show_bug.cgi?id=116580

Reviewed by Andreas Kling.

Inherit DetailsContentElement and DetailsSummaryElement directly from InsertionPoint instead.

* html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
* html/HTMLSummaryElement.cpp:
(WebCore::SummaryContentElement::SummaryContentElement):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::contentTagName):
* html/shadow/HTMLContentElement.h:
(WebCore::isHTMLContentElement):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::setResetStyleInheritance):
* html/shadow/InsertionPoint.h:

    Also remove some leftover selector code.

(WebCore::InsertionPoint::insertionPointType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRobustify repaint of previous caret node when moving FrameSelection.
akling@apple.com [Tue, 21 May 2013 22:20:50 +0000 (22:20 +0000)]
Robustify repaint of previous caret node when moving FrameSelection.
<http://webkit.org/b/116558>

Reviewed by Ryosuke Niwa.

As a follow-up to r150396, also repaint the caret rects if the previous node is contenteditable.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::recomputeCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix after r150469. We need to bail out here when DOM is mutated...
rniwa@webkit.org [Tue, 21 May 2013 22:06:35 +0000 (22:06 +0000)]
Unreviewed build fix after r150469. We need to bail out here when DOM is mutated by an event listener such that
the split text nodes no longer exist right next to each other.

* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove ScopeContentDistribution
antti@apple.com [Tue, 21 May 2013 21:38:13 +0000 (21:38 +0000)]
Remove ScopeContentDistribution
https://bugs.webkit.org/show_bug.cgi?id=116576

Reviewed by Andreas Kling.

With maximum one ShadowRoot per Element this can be smashed into ContentDistributor.

* dom/ShadowRoot.cpp:
(WebCore):
* dom/ShadowRoot.h:
(WebCore):
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::ContentDistributor):
(WebCore):
(WebCore::ContentDistributor::~ContentDistributor):
(WebCore::ContentDistributor::invalidateInsertionPointList):
(WebCore::ContentDistributor::ensureInsertionPointList):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):
* html/shadow/ContentDistributor.h:
(WebCore):
(ContentDistributor):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):

    Simplify insertion point list invalidation.

* html/shadow/InsertionPoint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
rniwa@webkit.org [Tue, 21 May 2013 21:28:03 +0000 (21:28 +0000)]
REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
https://bugs.webkit.org/show_bug.cgi?id=116516

Reviewed by Alexey Proskuryakov.

Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.

* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow): Match the ordering.
(resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Regions][CSS Exclusions] Multiple regions with shape-insides should respect...
zoltan@webkit.org [Tue, 21 May 2013 21:04:27 +0000 (21:04 +0000)]
[CSS Regions][CSS Exclusions] Multiple regions with shape-insides should respect positioned shapes and overflow
https://bugs.webkit.org/show_bug.cgi?id=115001

Reviewed by David Hyatt.

In r150375 I implemented the new overflow behavior for shape-inside on regions, but it covered only the simple cases
when you had only one region. This patch adds support for the new overflow behavior for multiple regions with multiple
positioned shape-insides and overflow.

Source/WebCore:

Tests: fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html
       fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateLineBoundariesForExclusions): Cover cases when content flows into the next region, update the
line segments for the overflow.
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): In flow thread case we don't want to adjust the height
in two places.

LayoutTests:

* fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html: Added.
* fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html: Added.
* fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes-expected.html: Added.
* fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows] Reenable storage tests
bfulgham@apple.com [Tue, 21 May 2013 21:00:18 +0000 (21:00 +0000)]
[Windows] Reenable storage tests
https://bugs.webkit.org/show_bug.cgi?id=116559

Unreviewed update to TestExpectations:
1. Storage features are present on Windows, so test them.
2. Disable (for now) the four websql tests that fail.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening; rebaseline and re-enable media/track/track-cue-rendering-snap...
jer.noble@apple.com [Tue, 21 May 2013 20:52:55 +0000 (20:52 +0000)]
Unreviewed gardening; rebaseline and re-enable media/track/track-cue-rendering-snap-to-lines-not-set.html

* media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r150425.
rniwa@webkit.org [Tue, 21 May 2013 20:42:32 +0000 (20:42 +0000)]
Unreviewed, rolling out r150425.
http://trac.webkit.org/changeset/150425
https://bugs.webkit.org/show_bug.cgi?id=116573

Not the right fix for WebKit2 (Requested by rniwa on #webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2013-05-21

* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
ap@apple.com [Tue, 21 May 2013 20:38:04 +0000 (20:38 +0000)]
    <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
        https://bugs.webkit.org/show_bug.cgi?id=116568

        Reviewed by Anders Carlsson.

        * WebKitTestRunner/WebNotificationProvider.cpp:
        (WTR::WebNotificationProvider::~WebNotificationProvider):
        * WebKitTestRunner/WebNotificationProvider.h:
        When the provider is destroyed, it should no longer be registered with the manager.

        * WebKitTestRunner/GeolocationProviderMock.cpp:
        (WTR::GeolocationProviderMock::~GeolocationProviderMock):
        * WebKitTestRunner/GeolocationProviderMock.h:
        I wasn't seeing a crash here, but this code has the same issue as notification
        provider, so applying the same fix.

        * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
        Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
        destructor having fixed the above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate test expectations after r150472 for the bug 116125.
rniwa@webkit.org [Tue, 21 May 2013 20:32:23 +0000 (20:32 +0000)]
Update test expectations after r150472 for the bug 116125.

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r150386 and r150397.
commit-queue@webkit.org [Tue, 21 May 2013 20:21:24 +0000 (20:21 +0000)]
Unreviewed, rolling out r150386 and r150397.
http://trac.webkit.org/changeset/150386
http://trac.webkit.org/changeset/150397
https://bugs.webkit.org/show_bug.cgi?id=116572

Broke a test; Alex is going to try again later. (Requested by
thorton on #webkit).

Tools:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::pathSuitableForTestResult):
(WTR::dumpRequestDescriptionSuitableForTestResult):
(WTR::dumpResponseDescriptionSuitableForTestResult):
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
(WTR::InjectedBundlePage::didInitiateLoadForResource):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::didReceiveResponseForResource):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):

LayoutTests:

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening; rebaseline and re-enable media/track/track-cue-rendering-snap...
jer.noble@apple.com [Tue, 21 May 2013 20:02:11 +0000 (20:02 +0000)]
Unreviewed gardening; rebaseline and re-enable media/track/track-cue-rendering-snap-to-lines-not-set.html
https://bugs.webkit.org/show_bug.cgi?id=116567

* media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agodispatchEvent call can execute javascript and blow away endRoot from underneath
rniwa@webkit.org [Tue, 21 May 2013 19:34:31 +0000 (19:34 +0000)]
dispatchEvent call can execute javascript and blow away endRoot from underneath
https://bugs.webkit.org/show_bug.cgi?id=116483

Source/WebCore:

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/798cba0af9b2aff21e475e2e08ea3ca5e97dfc2c.

Test: editing/undo/undo-after-event-edited.html

* editing/Editor.cpp:
(WebCore::dispatchEditableContentChangedEvents):

LayoutTests:

Reviewed by Andreas Kling.

Add a regression test.

* editing/undo/undo-after-event-edited-expected.txt: Added.
* editing/undo/undo-after-event-edited.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomedia/track/track-cue-rendering-snap-to-lines-not-set.html is failing
bfulgham@apple.com [Tue, 21 May 2013 19:32:07 +0000 (19:32 +0000)]
media/track/track-cue-rendering-snap-to-lines-not-set.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116567

Add a failing test expectation to the test added in r150452.

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2013-05-21

* platform/mac/TestExpectations:
* platform/mac/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomedia/track/track-cue-rendering-snap-to-lines-not-set.html is failing
rniwa@webkit.org [Tue, 21 May 2013 19:28:49 +0000 (19:28 +0000)]
media/track/track-cue-rendering-snap-to-lines-not-set.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116567

Add a failing test expectation to the test added in r150452.

* platform/mac/TestExpectations:
* platform/mac/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove ContentDistribution
antti@apple.com [Tue, 21 May 2013 19:09:14 +0000 (19:09 +0000)]
Remove ContentDistribution
https://bugs.webkit.org/show_bug.cgi?id=116527

Reviewed by Andreas Kling.

Resolving distribution on traversal is simpler.

* WebCore.exp.in:
* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseDistributedNodes):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
* html/HTMLDetailsElement.cpp:
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distributeSelectionsTo):
* html/shadow/ContentDistributor.h:
* html/shadow/HTMLContentElement.idl:

    Remove getDistributedNodes().

* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore):
(WebCore::InsertionPoint::firstDistributed):
(WebCore::InsertionPoint::lastDistributed):
(WebCore::InsertionPoint::nextDistributedTo):
(WebCore::InsertionPoint::previousDistributedTo):

    Rename for clarity.

* html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::hasDistribution):
(WebCore::InsertionPoint::setHasDistribution):
(WebCore::InsertionPoint::clearDistribution):
(WebCore::InsertionPoint::matchTypeFor):
(InsertionPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows] Workers are crashing tests.
bfulgham@apple.com [Tue, 21 May 2013 19:03:26 +0000 (19:03 +0000)]
[Windows] Workers are crashing tests.
https://bugs.webkit.org/show_bug.cgi?id=116560.

Unreviewed change to TestExpectations while investigating.

* platform/win/TestExpectations: Disable worker tests under Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Add myself as committer in contributors.json.
marcelo.lira@openbossa.org [Tue, 21 May 2013 19:02:46 +0000 (19:02 +0000)]
Unreviewed. Add myself as committer in contributors.json.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a python unittest after r149419. We need to support Python 2.6 on Windows.
rniwa@webkit.org [Tue, 21 May 2013 18:59:38 +0000 (18:59 +0000)]
Fix a python unittest after r149419. We need to support Python 2.6 on Windows.

* Scripts/webkitpy/tool/commands/suggestnominations.py:
(AbstractCommitLogCommand._recent_commit_messages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] [CMake] Add support for building WebKit2
mrobinson@webkit.org [Tue, 21 May 2013 18:49:40 +0000 (18:49 +0000)]
[GTK] [CMake] Add support for building WebKit2
https://bugs.webkit.org/show_bug.cgi?id=116372

Reviewed by Gustavo Noronha Silva.

.:

* Source/cmake/FindWebP.cmake: Added.
* Source/cmake/OptionsGTK.cmake: Turn on WebKit2 and the plugin process and also look
for WebP. These missing symbols were hidden up until now. ENABLE_TEXTURE_MAPPER was
also incorrect specified.

Source/WebCore:

* PlatformGTK.cmake: Add missing source files, include directories, and WebP properties.

Source/WebKit2:

* CMakeLists.txt: Add common directories to the common include list and remove UIProcess/PageViewportController.cpp
from the source list since it should only be compiled for WebKitEFL. Instead of taking explicit forwarding-header
dependencies accept a list of "tacked-on" dependencies for WebKit2. This allows GTK+ to specify its extra fake
installed header step.
* PlatformEfl.cmake: Remove common include directories and add UIProcess/PageViewportController.cpp to the source
list. Fix up forwarding header dependencies now.
* PlatformGTK.cmake: Added.
* config.h: First check whether this is a CMake build and then fall back to the autotools header.

Tools:

* CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
* MiniBrowser/gtk/CMakeLists.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows] Unreviewed test expectation change - skip failing tests.
bfulgham@apple.com [Tue, 21 May 2013 18:41:24 +0000 (18:41 +0000)]
[Windows] Unreviewed test expectation change - skip failing tests.
https://bugs.webkit.org/show_bug.cgi?id=116564

1. Skip a number of failing tests, and investigate the sources of the
problems.  Progress will be tracked on the above bug.
2. Correct a typo I made in r150382
3. Remove skip entries from https://webkit.org/b/113908; these were
replaced with new tests added in https://webkit.org/b/113946.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSSRegions] Remove percentages from offsetLeft/offsetTop tests to avoid sub-pixel...
commit-queue@webkit.org [Tue, 21 May 2013 18:21:14 +0000 (18:21 +0000)]
[CSSRegions] Remove percentages from offsetLeft/offsetTop tests to avoid sub-pixel errors
https://bugs.webkit.org/show_bug.cgi?id=116544

Patch by Radu Stavila <stavila@adobe.com> on 2013-05-21
Reviewed by Andreas Kling.

* fast/regions/offsetLeft-offsetTop-in-multiple-regions.html:
* fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert r149635, it was too optimistic.
jberlin@webkit.org [Tue, 21 May 2013 18:15:39 +0000 (18:15 +0000)]
Revert r149635, it was too optimistic.

Rubber-stamped by Andreas Kling.

We are not at the point where we can always use more descriptive macros instead of PLATFORM()

* Scripts/webkitpy/style/checkers/cpp.py:
(check_invalid_increment):
(process_line):
(CppChecker):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_plain_integral_bitfields):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
jer.noble@apple.com [Tue, 21 May 2013 17:26:54 +0000 (17:26 +0000)]
Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.

* lldb/lldb_webkit.py:
(WTFVectorProvider.num_children):
(WTFVectorProvider.get_child_index):
(WTFVectorProvider.get_child_at_index):
(WTFVectorProvider.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r101810): Media controls status text missing for live-stream videos.
jer.noble@apple.com [Tue, 21 May 2013 17:20:17 +0000 (17:20 +0000)]
REGRESSION(r101810): Media controls status text missing for live-stream videos.
https://bugs.webkit.org/show_bug.cgi?id=116547

Reviewed by Eric Carlson.

Un-reverse the logic in loadedMetadata() so that the status text isn't
hidden (when it should be shown) for live-stream videos.

* html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::loadedMetadata):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement overlap-avoidance for in-band text track cues.
jer.noble@apple.com [Tue, 21 May 2013 17:16:34 +0000 (17:16 +0000)]
Implement overlap-avoidance for in-band text track cues.
https://bugs.webkit.org/show_bug.cgi?id=116540

Reviewed by Eric Carlson.

In-band (or Generic) cues need special casing for certain features
present in in-band tracks, like paint-on and roll-up modes. To avoid
the problem of overlap avoidance forcing a caption meant to appear
below a cue to appear above it when a larger font size is selected,
impose an additional sort ordering for "generic cues". Instead of
cues being ordered by the order they appear in the track, "generic
cues" further sorted by their position within the video area, such
that cues at the bottom of the video area appear first, and later
cues are pushed up to avoid them, preserving the desired apparent
ordering.

* html/HTMLMediaElement.cpp:
(WebCore::compareCueInterval): Added; wrapper around
    TextTrackCue::isOrderedBefore.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
    After creating the list of current cues, sort them.
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::isOrderedBefore): Added; implementation moved
    from TextTrackCueList::add().
* html/track/TextTrackCue.h:
* html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::isOrderedBefore): Added override;
    impose additional oredring on generic cues.
* html/track/TextTrackCueGeneric.h:
* html/track/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::add): Moved ordering test into
    isOrderedBefore().
* rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::repositionGenericCue):
    Call repositionCueSnapToLinesNotSet() after positioning the cue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement overlap avoidance for cues with snap-to-lines flag not set
jer.noble@apple.com [Tue, 21 May 2013 17:14:53 +0000 (17:14 +0000)]
Implement overlap avoidance for cues with snap-to-lines flag not set
https://bugs.webkit.org/show_bug.cgi?id=84296

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-cue-overlap-snap-to-lines-not-set.html

Support overlap avoidance for the non-snap-to-lines part of the WebVTT spec.

* rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::isOutside): Split implementation into rectIsWithinContainer().
(WebCore::RenderTextTrackCue::rectIsWithinContainer): Ditto.
(WebCore::RenderTextTrackCue::isOverlapping): Split into overlappingObject() and overlappingObjectForRect().
(WebCore::RenderTextTrackCue::overlappingObject): Ditto.
(WebCore::RenderTextTrackCue::overlappingObjectForRect): Ditto.
(WebCore::RenderTextTrackCue::moveIfNecessaryToKeepWithinContainer): Added.
(WebCore::RenderTextTrackCue::findNonOverlappingPosition): When an overlapping object is found, move the
    cue to just above or below that object and try again.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Move implementation into moveIfNecessaryToKeepWithinContainer().
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesNotSet): Add implementanton based on above.
* rendering/RenderTextTrackCue.h:

LayoutTests:

* media/track/track-cue-overlap-snap-to-lines-not-set-expected.txt: Added.
* media/track/track-cue-overlap-snap-to-lines-not-set.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
andersca@apple.com [Tue, 21 May 2013 16:57:55 +0000 (16:57 +0000)]
Build fix.

* wtf/NeverDestroyed.h:
(NeverDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WTF::NeverDestroyed and start using it in WTF
andersca@apple.com [Tue, 21 May 2013 16:56:14 +0000 (16:56 +0000)]
Add WTF::NeverDestroyed and start using it in WTF
https://bugs.webkit.org/show_bug.cgi?id=116472

Reviewed by Benjamin Poulain.

NeverDestroyed is a class template that can be used for singletons and other objects that we never
want to destroy. It's intended as a replacement for WTF_STATIC_LOCAL with the advantage that it doesn't
fragment the heap.

* GNUmakefile.list.am:
* WTF.vcproj/WTF.vcproj:
* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:
* WTF.xcodeproj/project.pbxproj:
Add NeverDestroyed.h

* wtf/Compiler.h:
Add a helper macro, WTF_DELETED_FUNCTION.

* wtf/CryptographicallyRandomNumber.cpp:
Use NeverDestroyed.

* wtf/NeverDestroyed.h: Added.

* wtf/Noncopyable.h:
Use WTF_DELETED_FUNCTION.

* wtf/text/WTFString.cpp:
(WTF::emptyString):
Use

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded missing assert condition for PositiveOrZero in ARM branch32().
mark.lam@apple.com [Tue, 21 May 2013 16:44:01 +0000 (16:44 +0000)]
Added missing assert condition for PositiveOrZero in ARM branch32().
https://bugs.webkit.org/show_bug.cgi?id=116538.

Reviewed by Geoffrey Garen.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchAdd32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove GraphicsLayerClient::contentsVisible()
commit-queue@webkit.org [Tue, 21 May 2013 16:09:52 +0000 (16:09 +0000)]
Remove GraphicsLayerClient::contentsVisible()
https://bugs.webkit.org/show_bug.cgi?id=116523

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-21
Reviewed by Darin Adler.

This is dead code from the BlackBerry port.

* platform/graphics/GraphicsLayerClient.h:
* rendering/RenderLayerBacking.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Compile everything in C++11 mode
zandobersek@gmail.com [Tue, 21 May 2013 16:05:31 +0000 (16:05 +0000)]
[GTK] Compile everything in C++11 mode
https://bugs.webkit.org/show_bug.cgi?id=116452

Reviewed by Anders Carlsson.

.:

* Source/autotools/SetupCompilerFlags.m4: Use the C++11 standard by default when compiling C++ source code.
Perform some minor cleanup around the comments and the order of specifying additional CXXFLAGS entries.

Source/WebKit2:

* GNUmakefile.am: Remove the -std=c++11 flags from the various CPPFLAGS lists, the mode is now specified
by default for all the C++ source code in SetupCompilerFlags.m4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPLATFORM(*) macros used in Source/WebCore/loader/archive/ArchiveFactory.cpp
zandobersek@gmail.com [Tue, 21 May 2013 16:03:07 +0000 (16:03 +0000)]
PLATFORM(*) macros used in Source/WebCore/loader/archive/ArchiveFactory.cpp
https://bugs.webkit.org/show_bug.cgi?id=116453

Reviewed by Alexey Proskuryakov.

* loader/archive/ArchiveFactory.cpp: Remove a redundant PLATFORM(QT) macro when checking whether
to include the LegacyWebArchive.h header that's specific to the WebArchive support. The Qt port
does not enable the WebArchive feature at all (which is enabled only on AppleMac, AppleWin and iOS
platforms) so there's no reason to additionally condition the header include with building on
non-Qt platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd BlackBerry definition of NativeImagePtr
commit-queue@webkit.org [Tue, 21 May 2013 15:58:53 +0000 (15:58 +0000)]
Add BlackBerry definition of NativeImagePtr
https://bugs.webkit.org/show_bug.cgi?id=116526

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-21
Reviewed by Darin Adler.

* platform/graphics/NativeImagePtr.h:
(Graphics):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] FontCache::getFontDataForCharacters() returns nullptr
commit-queue@webkit.org [Tue, 21 May 2013 15:50:15 +0000 (15:50 +0000)]
[BlackBerry] FontCache::getFontDataForCharacters() returns nullptr
https://bugs.webkit.org/show_bug.cgi?id=116529

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-21
Reviewed by Andreas Kling.

This cannot be converted to a PassRefPtr and breaks the build.

* platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpose a way to know when forms are added to a page or when form controls are added...
jberlin@webkit.org [Tue, 21 May 2013 13:44:46 +0000 (13:44 +0000)]
Expose a way to know when forms are added to a page or when form controls are added to a form
in the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=116334

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Add shouldNotifyOnFormChanges and didAssociateFormControls to the WKBundlePageFormClient.

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Add the new callbacks as part of version 2 of the WKBundlePageFormClient.

* WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
Pass the message along to the client if the client has a handler.
(WebKit::InjectedBundlePageFormClient::shouldNotifyOnFormChanges):
Ditto.
* WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didAssociateFormControls):
Tell the injected bundle form client for the page.
(WebKit::WebChromeClient::shouldNotifyOnFormChanges):
Ditto.
* WebProcess/WebCoreSupport/WebChromeClient.h:

Tools:

Add tests for the new callbacks.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html

* TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
(TestWebKitAPI::nullJavaScriptCallback):
A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
being passed in for the callback.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
After receiving the message that didAssociateFormControls callback was invoked from adding
the form in the onload handler, tell the page to add a password field to the form, which
should also invoke didAssociateFormControls callback.
(TestWebKitAPI::setInjectedBundleClient):
Register to receive messages.
(TestWebKitAPI::TEST):
Load associate-form-controls.html and wait until the didAssociateFormControls callback has
been invoked for both adding the form and for adding a password field to the form.

* TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
(TestWebKitAPI::shouldNotifyOnFormChanges):
Return true so the didAssociateFormControls callback is invoked.
(TestWebKitAPI::didAssociateFormControls):
Tell the UI process.
(TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
(TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.

* TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
Add a form in response to the onload event. Add a button that will add the password field
for manual testing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Always use EGL to create the GL context when running on Wayland
commit-queue@webkit.org [Tue, 21 May 2013 13:37:17 +0000 (13:37 +0000)]
[GTK] Always use EGL to create the GL context when running on Wayland
https://bugs.webkit.org/show_bug.cgi?id=115721

Patch by Iago Toral Quiroga <itoral@igalia.com> on 2013-05-21
Reviewed by Martin Robinson.

* platform/graphics/cairo/GLContext.cpp:
(WebCore::GLContext::createContextForWindow):
(WebCore::GLContext::createOffscreenContext): Always use EGL to create the GL context
instead of GLX when running on Wayland and make createOffScreenContext reuse the code
in createContextWindow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][WK2] accessibility/label-for-control-hittest.html is failing
commit-queue@webkit.org [Tue, 21 May 2013 13:16:24 +0000 (13:16 +0000)]
[GTK][WK2] accessibility/label-for-control-hittest.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106341

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-05-21
Reviewed by Martin Robinson.

Tools:

Adds support for retrieving accessibility element at exact point.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::elementAtPoint):

LayoutTests:

Fixing failing test. The reason of failure is missing
possibility of getting accessibility object at exact position.

* platform/gtk-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] accessibility/accessibility-node-reparent.html is failing
commit-queue@webkit.org [Tue, 21 May 2013 13:14:22 +0000 (13:14 +0000)]
[EFL] accessibility/accessibility-node-reparent.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112026

Unreviewed EFL gardening.

accessibility/accessibility-node-reparent.html passes after r150431.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-05-21

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd FloatRect::normalized() for BlackBerry
commit-queue@webkit.org [Tue, 21 May 2013 12:50:46 +0000 (12:50 +0000)]
Add FloatRect::normalized() for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=116531

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-21
Reviewed by Carlos Garcia Campos.

This was added to FloatRectBlackBerry.cpp in r111072 when the
graphics platform code was upstreamed, but this change was
missing.

* platform/graphics/FloatRect.h:
(FloatRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150437 268f45cc-cd09-0410-ab3c-d52691b4dbfc