WebKit-https.git
10 years agoUnreviewed tests rebaseline following r98852.
caseq@chromium.org [Mon, 31 Oct 2011 17:38:27 +0000 (17:38 +0000)]
Unreviewed tests rebaseline following r98852.

* fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-cg-mac-leopard/fast/block/float/015-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
* platform/chromium-cg-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-tiled-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-cg-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/css1/text_properties/vertical_align-expected.png.
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
* platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
* platform/chromium-linux/fast/block/float/015-expected.png:
* platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
* platform/chromium-linux/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
* platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png:
* platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-linux/svg/as-image/same-image-two-instances-expected.png: Added.
* platform/chromium-linux/svg/as-image/svg-as-relative-image-expected.png: Added.
* platform/chromium-linux/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
* platform/chromium-linux/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Renamed from LayoutTests/platform/chromium-mac/css1/text_properties/vertical_align-expected.png.
* platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/float/015-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/background-image-tiled-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/as-image/animated-svg-as-image-expected.png.
* platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/same-image-two-instances-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/svg-as-relative-image-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-win/css1/text_properties/vertical_align-expected.txt:
* platform/chromium-win/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
* platform/chromium-win/fast/block/float/015-expected.png:
* platform/chromium-win/fast/block/float/015-expected.txt:
* platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
* platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.txt:
* platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
* platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
* platform/chromium-win/svg/as-background-image/background-image-tiled-expected.png: Added.
* platform/chromium-win/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
* platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
* platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-win/svg/as-image/same-image-two-instances-expected.png: Added.
* platform/chromium-win/svg/as-image/same-image-two-instances-expected.txt: Added.
* platform/chromium-win/svg/as-image/svg-as-relative-image-expected.png: Added.
* platform/chromium-win/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
* platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.txt: Added.
* platform/chromium-win/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
* platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Copied from LayoutTests/platform/chromium-win/svg/zoom/page/relative-sized-document-scrollbars-expected.png.
* platform/chromium-win/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/chromium/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Added.
* svg/as-background-image/svg-as-background-4-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.txt.
* svg/as-image/svg-as-relative-image-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-image/svg-as-relative-image-expected.txt.
* svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Renamed from LayoutTests/platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Unreviewed. Add pixel baselines for tests in fast/ directory.
leandro@webkit.org [Mon, 31 Oct 2011 17:30:09 +0000 (17:30 +0000)]
[EFL] Unreviewed. Add pixel baselines for tests in fast/ directory.

* platform/efl/fast/backgrounds: [...]
* platform/efl/fast/block: [...]
* platform/efl/fast/body-propagation: [...]
* platform/efl/fast/borders: [...]
* platform/efl/fast/box-shadow: [...]
* platform/efl/fast/canvas: [...]
* platform/efl/fast/clip: [...]
* platform/efl/fast/compact: [...]
* platform/efl/fast/css-generated-content: [...]
* platform/efl/fast/css: [...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSRule: Devirtualize insertedIntoParent()
andreas.kling@nokia.com [Mon, 31 Oct 2011 17:02:49 +0000 (17:02 +0000)]
CSSRule: Devirtualize insertedIntoParent()
https://bugs.webkit.org/show_bug.cgi?id=71223

Reviewed by Antti Koivisto.

Moved insertedIntoParent() down into CSSImportRule and renamed it to
requestStyleSheet(). CSSImportRule is the only user of this function.

* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::requestStyleSheet):
* css/CSSImportRule.h:
* css/CSSRule.h:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::append):
(WebCore::CSSStyleSheet::insertRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement load notification and events for <track>.
annacc@chromium.org [Mon, 31 Oct 2011 16:35:56 +0000 (16:35 +0000)]
Implement load notification and events for <track>.
https://bugs.webkit.org/show_bug.cgi?id=71054

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-load-error-readyState.html
       media/track/track-load-from-element-readyState.html
       media/track/track-load-from-src-readyState.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::trackWasAdded):
(WebCore::HTMLMediaElement::trackWillBeRemoved):
(WebCore::HTMLMediaElement::trackSourceChanged):
* html/HTMLMediaElement.h:
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::parseMappedAttribute):
(WebCore::HTMLTrackElement::attributeChanged):
* html/HTMLTrackElement.h:
* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

* media/track/track-load-error-readyState-expected.txt: Added.
* media/track/track-load-error-readyState.html: Added.
* media/track/track-load-from-element-readyState-expected.txt: Added.
* media/track/track-load-from-element-readyState.html: Added.
* media/track/track-load-from-src-readyState-expected.txt: Added.
* media/track/track-load-from-src-readyState.html: Added.
* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSSRule: Devirtualize type() and isFooRule()
andreas.kling@nokia.com [Mon, 31 Oct 2011 15:53:14 +0000 (15:53 +0000)]
CSSRule: Devirtualize type() and isFooRule()
https://bugs.webkit.org/show_bug.cgi?id=71221

Reviewed by Antti Koivisto.

Store the rule type in a CSSRule member (packed with the parent-is-rule flag)
and let the isFooRule() functions return type() == FOO_TYPE.

CSSPageRule will no longer return true for isStyleRule(), tweaked call sites
accordingly.

* css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::CSSCharsetRule):
* css/CSSCharsetRule.h:
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::CSSFontFaceRule):
* css/CSSFontFaceRule.h:
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::CSSImportRule):
* css/CSSImportRule.h:
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule):
* css/CSSMediaRule.h:
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::CSSPageRule):
* css/CSSPageRule.h:
* css/CSSRegionStyleRule.cpp:
(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
* css/CSSRegionStyleRule.h:
* css/CSSRule.h:
(WebCore::CSSRule::type):
(WebCore::CSSRule::isCharsetRule):
(WebCore::CSSRule::isFontFaceRule):
(WebCore::CSSRule::isKeyframeRule):
(WebCore::CSSRule::isKeyframesRule):
(WebCore::CSSRule::isMediaRule):
(WebCore::CSSRule::isPageRule):
(WebCore::CSSRule::isStyleRule):
(WebCore::CSSRule::isRegionStyleRule):
(WebCore::CSSRule::isImportRule):
(WebCore::CSSRule::CSSRule):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::CSSStyleRule):
* css/CSSStyleRule.h:
* css/CSSStyleSelector.cpp:
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
* css/CSSUnknownRule.h:
(WebCore::CSSUnknownRule::CSSUnknownRule):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
* css/WebKitCSSKeyframeRule.h:
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
* css/WebKitCSSKeyframesRule.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::asCSSStyleRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Fix qmltests after r98460 added widgets dependency.
abecsi@webkit.org [Mon, 31 Oct 2011 15:49:04 +0000 (15:49 +0000)]
[Qt][WK2] Fix qmltests after r98460 added widgets dependency.

Reviewed by Simon Hausmann.

Use QApplication and QtWidgets until we get rid of the widgets dependency of QScroller.

* UIProcess/API/qt/tests/qmltests/qmltests.pro:
* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-10-31 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 31 Oct 2011 15:29:38 +0000 (15:29 +0000)]
2011-10-31  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: reorder inspector js files to fix remote mode.

        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [refactoring] TextPrompt: ensure encapsulation, extract history management
apavlov@chromium.org [Mon, 31 Oct 2011 15:09:02 +0000 (15:09 +0000)]
Web Inspector: [refactoring] TextPrompt: ensure encapsulation, extract history management
https://bugs.webkit.org/show_bug.cgi?id=70936

Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView):
(WebInspector.DatabaseQueryView.prototype._enterKeyPressed):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylePropertyTreeElement.prototype.selectElement):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.context):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.event):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.context.event):
():
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.get proxyElement):
(WebInspector.TextPrompt.prototype.attach):
(WebInspector.TextPrompt.prototype.attachAndStartEditing):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.detach):
(WebInspector.TextPrompt.prototype.get text):
(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeFromElement):
(WebInspector.TextPrompt.prototype._startEditing):
(WebInspector.TextPrompt.prototype._stopEditing):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype._onKeyDown):
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretInsidePrompt):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.isCaretOnFirstLine):
(WebInspector.TextPrompt.prototype.isCaretOnLastLine):
(WebInspector.TextPrompt.prototype.moveCaretToEndOfPrompt):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPromptConfig):
(WebInspector.TextPromptWithHistory):
(WebInspector.TextPromptWithHistory.prototype.get historyData):
(WebInspector.TextPromptWithHistory.prototype.setHistoryData):
(WebInspector.TextPromptWithHistory.prototype.pushHistoryItem):
(WebInspector.TextPromptWithHistory.prototype._pushCurrentText):
(WebInspector.TextPromptWithHistory.prototype._previous):
(WebInspector.TextPromptWithHistory.prototype._next):
(WebInspector.TextPromptWithHistory.prototype._currentHistoryItem):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: move localization support into UIUtil.js, reduce externs.
pfeldman@chromium.org [Mon, 31 Oct 2011 14:32:40 +0000 (14:32 +0000)]
Web Inspector: move localization support into UIUtil.js, reduce externs.
https://bugs.webkit.org/show_bug.cgi?id=71220

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/compile-front-end.sh:
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.focus):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.afterShow):
* inspector/front-end/Drawer.js:
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.prototype._hide):
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype.hide):
(WebInspector.HelpScreen.prototype._onBlur):
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut._keyName):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype._onSearchFieldManualFocus):
(WebInspector.SearchController.prototype._onKeyDown):
* inspector/front-end/Settings.js:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.prototype._toolbarDragStart):
* inspector/front-end/UIUtils.js:
(WebInspector.startEditing.cleanUpAfterEditing):
(WebInspector.startEditing.var):
(WebInspector.startEditing):
(WebInspector.UIString):
(WebInspector.useLowerCaseMenuTitles):
(WebInspector.platform):
(WebInspector.isMac):
(WebInspector.platformFlavor):
(WebInspector.port):
(WebInspector.installPortStyles):
(WebInspector._windowFocused):
(WebInspector._windowBlurred):
(WebInspector.previousFocusElement):
(WebInspector.currentFocusElement):
(WebInspector._focusChanged):
(WebInspector.setCurrentFocusElement):
* inspector/front-end/externs.js:
(Event.prototype.initWebKitWheelEvent):
(window.getComputedStyle):
(InspectorBackend.runAfterPendingDispatches):
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
(WebInspector.addMainEventListeners):

Source/WebKit/chromium:

* src/js/DevTools.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] MiniBrowser doesn't resize as the size is always overridden
kenneth@webkit.org [Mon, 31 Oct 2011 14:15:09 +0000 (14:15 +0000)]
[Qt] MiniBrowser doesn't resize as the size is always overridden
https://bugs.webkit.org/show_bug.cgi?id=71212

Reviewed by Simon Hausmann.

Remove call overriden the size.

* MiniBrowser/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoKill StyleBase.
andreas.kling@nokia.com [Mon, 31 Oct 2011 14:13:14 +0000 (14:13 +0000)]
Kill StyleBase.
https://bugs.webkit.org/show_bug.cgi?id=71218

Reviewed by Antti Koivisto.

Remove the StyleBase class and make all subclasses stand alone. CSSRule and StyleSheet
now inherit from RefCounted<T> instead, and XSLImportRule doesn't even need that,
so StyleBase is replaced by nothing.

* css/StyleBase.cpp:
* css/StyleBase.h:

    Removed.

* css/CSSRule.cpp:
* css/CSSRule.h:
(WebCore::CSSRule::~CSSRule):
(WebCore::CSSRule::useStrictParsing):
(WebCore::CSSRule::setParentStyleSheet):
(WebCore::CSSRule::setParentRule):
(WebCore::CSSRule::parentStyleSheet):
(WebCore::CSSRule::parentRule):
(WebCore::CSSRule::baseURL):
(WebCore::CSSRule::CSSRule):

    CSSRule now inherits directly from RefCounted, and has either a CSSRule or a
    CSSStyleSheet as its parent. Made these getters/setters inline since they are
    trivial now.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

    Purge StyleBase.* from the build systems.

* bindings/js/JSDOMBinding.h:
(WebCore::root):

    New root() functions for CSSRule and StyleSheet.

* bindings/js/JSNodeCustom.h:

    Remove StyleBase.h include.

* css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::parentStyleSheet):

    Added CSS-specific parentStyleSheet() so we don't have to cast it to a
    CSSStyleSheet* at the call sites.

* css/StyleSheet.cpp:
(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::parentStyleSheet):
(WebCore::StyleSheet::baseURL):
* css/StyleSheet.h:
(WebCore::StyleSheet::parentRule):
(WebCore::StyleSheet::setParentRule):
(WebCore::StyleSheet::isCSSStyleSheet):
(WebCore::StyleSheet::isXSLStyleSheet):

    StyleSheet now inherits directly from RefCounted and always has a parent CSSRule
    though it can be null. parentStyleSheet() returns that rule's parent style sheet.
    Moved the relevant guts from StyleBase down here.

* loader/cache/CachedStyleSheetClient.h:

    Remove unnecessary WTF_MAKE_FAST_ALLOCATED, we get it from CachedResourceClient.

* xml/XSLImportRule.cpp:
(WebCore::XSLImportRule::XSLImportRule):
(WebCore::XSLImportRule::~XSLImportRule):
(WebCore::XSLImportRule::parentStyleSheet):
(WebCore::XSLImportRule::setXSLStyleSheet):
(WebCore::XSLImportRule::loadSheet):
* xml/XSLImportRule.h:
(WebCore::XSLImportRule::create):
(WebCore::XSLImportRule::setParentStyleSheet):

    Remove inheritance from StyleBase, and have create() return a PassOwnPtr instead.
    This is fine, since XSLStyleSheet is the only object that ever manages these rules.

* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedIntoDocument):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::ownerRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::checkLoaded):
(WebCore::CSSStyleSheet::document):
(WebCore::CSSStyleSheet::styleSheetChanged):
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::setCSSStyleSheet):
(WebCore::CSSImportRule::insertedIntoParent):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::append):
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
* css/CSSRegionStyleRule.cpp:
(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::~CSSRegionStyleRule):
* css/CSSRuleList.cpp:
(WebCore::CSSRuleList::deleteRule):
* css/CSSStyleDeclaration.h:
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::append):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::parseStyleSheet):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::parentStyleSheet):
* xml/XSLStyleSheet.h:
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::~XSLStyleSheet):
(WebCore::XSLStyleSheet::checkLoaded):
(WebCore::XSLStyleSheet::loadChildSheet):
* xml/XSLStyleSheetQt.cpp:
(WebCore::XSLStyleSheet::~XSLStyleSheet):

    Use the new, more explicit, parenting functions of StyleSheet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-10-31 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 31 Oct 2011 14:07:49 +0000 (14:07 +0000)]
2011-10-31  Nikolas Zimmermann  <nzimmermann@rim.com>

        CSS 2.1 failure: background-intrinsic-*
        https://bugs.webkit.org/show_bug.cgi?id=47156

        Reviewed by Antti Koivisto.

        Add all *intrinsic* tests from the CSS 2.1 Testsuite - we pass all of them now.
        All tests regarding SVG are now imported in LayoutTests, none are failing anymore.

        Add several new testcases covering the SVG Image size negotiation logic, as defined in CSS 2.1.

        * css2.1/20110323/background-intrinsic-001.htm: Added.
        * css2.1/20110323/background-intrinsic-002.htm: Added.
        * css2.1/20110323/background-intrinsic-003.htm: Added.
        * css2.1/20110323/background-intrinsic-004.htm: Added.
        * css2.1/20110323/background-intrinsic-005.htm: Added.
        * css2.1/20110323/background-intrinsic-006.htm: Added.
        * css2.1/20110323/background-intrinsic-007.htm: Added.
        * css2.1/20110323/background-intrinsic-008.htm: Added.
        * css2.1/20110323/background-intrinsic-009.htm: Added.
        * css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-height.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-none.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-width-height.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-width.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-height.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-none.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-width-height.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-width.svg: Added.
        * fast/backgrounds/size/contain-and-cover-zoomed.html: Added.
        * fast/images/percent-height-image-expected.txt: Update results, testcase is fixed now.
        * fast/images/percent-height-image.html: Make test async, to make it work cross-browser. With this patch we now pass this testcase.
        * platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
        * platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
        * platform/mac/css1/text_properties/vertical_align-expected.txt: Update for rounding differences.
        * platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
        * platform/mac/fast/backgrounds/size/contain-and-cover-expected.png: Updated for rounding differences.
        * platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
        * platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
        * platform/mac/fast/block/float/015-expected.png: Slight changes, due 49x50 -> 50x50 size change.
        * platform/mac/fast/block/float/015-expected.txt: Ditto.
        * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Slight changes due to rounding.
        * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Ditto.
        * platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Ditto.
        * platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Ditto.
        * platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
        * platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
        * platform/mac/svg/as-background-image/background-image-tiled-expected.png: Added.
        * platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Added.
        * platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
        * platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
        * platform/mac/svg/as-background-image/svg-as-background-4-expected.png: Adapt to preserveAspectRatio changes in hearts.svg.
        * platform/mac/svg/as-border-image/svg-as-border-image-expected.png: This needed a rebaseline, it was forgotten before.
        * platform/mac/svg/as-image/animated-svg-as-image-expected.png: Progression, now both images share the same size & ratio, as desired.
        * platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
        * platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
        * platform/mac/svg/as-image/same-image-two-instances-expected.png: Added.
        * platform/mac/svg/as-image/same-image-two-instances-expected.txt: Added.
        * platform/mac/svg/as-image/svg-as-relative-image-expected.png: Adapt to green-relative-size-rect.svg - a circle got added to make it easier to compare.
        * platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
        * platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
        * platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Added.
        * platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Added.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Ditto.
        * platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-background-images-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Ditto.
        * platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-image-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
        * svg/as-background-image/background-image-preserveaspectRatio-support.html: Added.
        * svg/as-background-image/background-image-tiled.html: Added.
        * svg/as-background-image/resources/construction-tape.svg: Added.
        * svg/as-background-image/resources/hearts.svg: Fix testcase, by adding pAR="none", which is now respected. Now the image looks as desired across Opera/FF and us.
        * svg/as-background-image/same-image-two-instances-background-image.html: Added.
        * svg/as-image/img-preserveAspectRatio-support-1.html: Added.
        * svg/as-image/resources/circle-default-meet.svg: Added.
        * svg/as-image/resources/circle-default-none.svg: Added.
        * svg/as-image/resources/circle-default-slice.svg: Added.
        * svg/as-image/resources/circle-nosize.svg: Added.
        * svg/as-image/resources/circle-viewbox-default.svg: Added.
        * svg/as-image/resources/circle-viewbox-meet.svg: Added.
        * svg/as-image/resources/circle-viewbox-none.svg: Added.
        * svg/as-image/resources/circle-viewbox-slice.svg: Added.
        * svg/as-image/resources/green-relative-size-rect.svg: Use relative units everywhere as intended. Add circle to make it easy to spot ratio changes.
        * svg/as-image/same-image-two-instances.html: Added.
        * svg/as-image/svg-as-relative-image-with-explicit-size.html: Added.
        * svg/as-image/svg-image-change-content-size.xhtml: Added.
        * svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Added.
        * svg/zoom/page/zoom-background-image-tiled.html: Added.
        * svg/zoom/page/zoom-background-images.html: Added.
        * svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Added.
        * svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Added.
        * svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Added.
        * svg/zoom/page/zoom-svg-as-image.html: Added.
        * svg/zoom/page/zoom-svg-as-relative-image.html: Added.

2011-10-31  Nikolas Zimmermann  <nzimmermann@rim.com>

        CSS 2.1 failure: background-intrinsic-*
        https://bugs.webkit.org/show_bug.cgi?id=47156

        SVGs do not work as tiled background images
        https://bugs.webkit.org/show_bug.cgi?id=16281

        Apply preserveAspectRatio and synthesize viewboxes in <img>
        https://bugs.webkit.org/show_bug.cgi?id=34521

        SVG background doesn't resize properly when dimensions are changed
        https://bugs.webkit.org/show_bug.cgi?id=42944

        Images with percent height inside a floated div should use intrinsic height.
        https://bugs.webkit.org/show_bug.cgi?id=45439

        SVG image in HTML changes size as the window is resized
        https://bugs.webkit.org/show_bug.cgi?id=52045

        Reviewed by Antti Koivisto.

        Implement intrinsic sizing support for SVGImage (svg embedded through <html:img>/<svg:image>/background-image/border-image/...).
        This is demanded by CSS 2.1, and covered by new layout tests in LayoutTests/css2.1 and several new custom testcases.

        Tests: css2.1/20110323/background-intrinsic-001.htm
               css2.1/20110323/background-intrinsic-002.htm
               css2.1/20110323/background-intrinsic-003.htm
               css2.1/20110323/background-intrinsic-004.htm
               css2.1/20110323/background-intrinsic-005.htm
               css2.1/20110323/background-intrinsic-006.htm
               css2.1/20110323/background-intrinsic-007.htm
               css2.1/20110323/background-intrinsic-008.htm
               css2.1/20110323/background-intrinsic-009.htm
               svg/as-background-image/background-image-preserveaspectRatio-support.html (adapted from testcase from bug 34521)
               svg/as-background-image/background-image-tiled.html (reduction from bug 16281)
               svg/as-background-image/same-image-two-instances-background-image.html
               svg/as-image/img-preserveAspectRatio-support-1.html (reduction from bug 34521)
               svg/as-image/same-image-two-instances.html
               svg/as-image/svg-as-relative-image-with-explicit-size.html
               svg/as-image/svg-image-change-content-size.xhtml (reduction from bug 42944)
               svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
               svg/zoom/page/zoom-svg-as-image.html
               svg/zoom/page/zoom-svg-as-relative-image.html

        * css/CSSImageGeneratorValue.cpp:
        (WebCore::CSSImageGeneratorValue::addClient): Pass default zoom factor.
        (WebCore::CSSImageGeneratorValue::getImage): Ditto.
        * loader/cache/CachedImage.cpp: Enable SVGImage <-> IntSize cache.
        (WebCore::CachedImage::lookupImageForSize): Use recently introduced ImageBySizeCache, to lookup an image for a certain size.
        (WebCore::CachedImage::lookupOrCreateImageForRenderer): Use recently introduced ImageBySizeCache, to dynamically create copies of m_image if needed.
        (WebCore::CachedImage::imageForRenderer): Lookup image by renderer, which first looks up a size for a renderer, then uses lookupImageForSize().
        (WebCore::CachedImage::setContainerSizeForRenderer): For SVGImages, pass on container size handling to ImageBySizeCache.
        (WebCore::CachedImage::imageSizeForRenderer): Figure out the image size, respecting per-renderer overrides, for a certain renderer.
        (WebCore::CachedImage::computeIntrinsicDimensions): Remove unnecessary RenderObject parameter.
        * loader/cache/CachedImage.h:
        * page/ChromeClient.h:
        (WebCore::ChromeClient::isSVGImageChromeClient): Used to identify whether a RenderSVGRoot is embedded through a SVGImage. Returns false, by default.
        * platform/graphics/Image.h:
        (WebCore::Image::setImageObserver): Add helper.
        * rendering/ImageBySizeCache.cpp: Cleanup code.
        (WebCore::ImageBySizeCache::addClient): Assert the passed renderer is valid.
        (WebCore::ImageBySizeCache::removeClient): Ditto. Allow removeClient() to be called w/o prio addClient() usage.
        (WebCore::ImageBySizeCache::getImage): Add zoom parameter.
        (WebCore::ImageBySizeCache::getRequestedSizeAndZoom): Add way to get requested size from cache, instead of actual cached sizes.
        (WebCore::ImageBySizeCache::imageForSize): Respect empty sizes, just return 0, instead of asserting.
        (WebCore::ImageBySizeCache::imageForRenderer): Added a helper that retrieves an image for a renderer, by lookup up its size and using imageForSize().
        * rendering/ImageBySizeCache.h: Cleaup code, introduce struct that replaces the std::pair<IntSize, int>.
        (WebCore::SizeZoomAndCount::SizeZoomAndCount):
        * rendering/RenderBoxModelObject.cpp: Implement CSS 2.1 intrinsic size negotiation for images.
        (WebCore::resolveWidthForRatio): New inline helper function used by calculateImageIntrinsicDimensions.
        (WebCore::resolveHeightForRatio): Ditto.
        (WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio): Ditto.
        (WebCore::resolveAgainstIntrinsicRatio):  Ditto.
        (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): New helper function, containing the main algorithm, which is a pure transcription of the spec.
        (WebCore::RenderBoxModelObject::calculateFillTileSize): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size.
        (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Propagate calculateFillTileSize() result to the image resource, via setContainerSizeForRenderer().
        (WebCore::RenderBoxModelObject::paintNinePieceImage): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size.
        * rendering/RenderBoxModelObject.h: Clarify some variable names, added calculateImageIntrinsicDimensions().
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::RenderImage): Use IntSize(), instead of IntSize(0, 0).
        (WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Refactored from imageDimensionsChanged().
        (WebCore::RenderImage::imageDimensionsChanged): Use updateIntrinsicSizeIfNeeded().
        (WebCore::RenderImage::computeReplacedLogicalWidth): Use RenderReplaced::computeReplacedLogicalWidth() exclusively. For this to work, the intrinsic size must be correct.
        (WebCore::RenderImage::computeIntrinsicRatioInformation): Default implementation for non-SVGImages.
        (WebCore::RenderImage::needsPreferredWidthsRecalculation): Return true, just like RenderPart, if embeddedContentBox is not null.
        (WebCore::RenderImage::embeddedContentBox): Returns the RenderSVGRoot* renderer of the embedded SVG, if possible.
        * rendering/RenderImage.h: Remove isLogicalWidth/HeightSpecified() / computeReplacedLogicalHeight() / calcAspectRatioLogicalWidth/Height().
        * rendering/RenderImageResource.cpp:
        (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass around new "float containerZoomFactor" parameter.
        * rendering/RenderImageResourceStyleImage.cpp:
        (WebCore::RenderImageResourceStyleImage::image): embeddedContentBox() is now calling image() earlier than before. We now have to handle the case that the image is pending.
        (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Pass zoom factor.
        * rendering/RenderImageResourceStyleImage.h:
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::computePreferredLogicalWidths): Pass effective zoom to setContainerSizeForRenderer().
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): Generalized this code, as RenderImage is using it as well now. Marginal changes needed.
        (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto.
        (WebCore::RenderReplaced::computeReplacedLogicalWidth): Ditto.
        * rendering/style/StyleCachedImage.cpp:
        (WebCore::StyleCachedImage::computeIntrinsicDimensions): Stop passing m_renderer to CachedImage, it's no longer needed.
        (WebCore::StyleCachedImage::setContainerSizeForRenderer): Add "float containerZoomFactor" parameter.
        * rendering/style/StyleCachedImage.h: Add "float containerZoomFactor" parameter to setContainerSizeForRenderer.
        * rendering/style/StyleGeneratedImage.h:
        (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Ditto.
        * rendering/style/StyleImage.h: Ditto.
        * rendering/style/StylePendingImage.h:
        (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
        * rendering/svg/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::layout): Always supply a container size when embedding SVGs in <svg:image>.
        * rendering/svg/RenderSVGRoot.cpp: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs.
        (WebCore::RenderSVGRoot::isEmbeddedThroughImageElement): Add helper method to determine whether we're loaded through SVGImage.
        (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): If we have a valid container size, it has precendence (only supplied via external SVGImages).
        (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
        (WebCore::RenderSVGRoot::layout): Remove calcViewport() usage, no need to track/override the viewport size anymore, all done in coputeReplacedLogical* now.
        (WebCore::RenderSVGRoot::paint): Use borderBoxRect() which now always matches the previously computed m_viewportSize.
        (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto.
        * rendering/svg/RenderSVGRoot.h: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs.
        (WebCore::RenderSVGRoot::containerSize):
        (WebCore::RenderSVGRoot::setContainerSize):
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::determineViewport): Resolve lengths against override container size in documents embedded through SVGImage.
        * svg/SVGSVGElement.cpp: Remove "override container size" handling from SVGSVGElement.
        (WebCore::SVGSVGElement::SVGSVGElement): Ditto.
        (WebCore::SVGSVGElement::currentViewBoxRect): Always synthesize a viewBox, if we're embedded through SVGImage, as demanded by SVG 1.1 2nd Edition.
        * svg/SVGSVGElement.h:
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImageChromeClient::isSVGImageChromeClient): Return true, used to identify whether RenderSVGRoot is embedded through SVGImage.
        (WebCore::SVGImage::createWithDataAndSize): Add new helper function.
        (WebCore::SVGImage::setContainerZoom): Forwarded to Page::setPageZoomFactor.
        (WebCore::SVGImage::setContainerSize): Assert that container size is not empty. We should never receive an empty container size.
        (WebCore::SVGImage::usesContainerSize): Adapt to override container size changes, it now lives in RenderSVGRoot instead of SVGSVGElement.
        (WebCore::SVGImage::size): New algorithm to figure out the size of an embedded SVG, as demanded by the CSS/SVG specs.
        (WebCore::SVGImage::embeddedContentBox): Add helper which returns the RenderSVGRoot of the document.
        (WebCore::SVGImage::computeIntrinsicDimensions): Implement intrinsic ratio calculation.
        (WebCore::SVGImage::dataChanged): Force calling FrameView::setCanHaveScrollbars(false), as SVG images now always synthesize a viewBox, and thus never receive scrollbars.
        * svg/graphics/SVGImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Make QWebPreferences hold a QtWebPageProxy
caio.oliveira@openbossa.org [Mon, 31 Oct 2011 13:51:19 +0000 (13:51 +0000)]
[Qt] Make QWebPreferences hold a QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=71219

Reviewed by Andreas Kling.

Change QWebPreferences to keep a pointer to QtWebPageProxy.  The reason is that
some features we want to control (like the messaging exchange between WebView and
the web process) are not available via WKPreferencesRef.

QtWebPageProxy now uses an OwnPtr to keep the QWebPreferences to clarify the
ownership relationship. Before this change the QWebPreferences created was leaking.

* UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::createPreferences):
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
(QWebPreferencesPrivate::preferencesRef):
* UIProcess/API/qt/qwebpreferences.h:
* UIProcess/API/qt/qwebpreferences_p.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::preferences):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-10-31 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 31 Oct 2011 12:45:40 +0000 (12:45 +0000)]
2011-10-31  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Add ResourcePreviewView.js to the list of inspector front-end
        files on Qt.

        * inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatti...
vsevik@chromium.org [Mon, 31 Oct 2011 12:28:37 +0000 (12:28 +0000)]
Unreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatting-source.html on QT.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Marked animations/change-keyframes.html as failing on SNOWLEOPARD DEBUG.
caseq@chromium.org [Mon, 31 Oct 2011 12:00:37 +0000 (12:00 +0000)]
Unreviewed. Marked animations/change-keyframes.html as failing on SNOWLEOPARD DEBUG.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: do not map scripts generated with document.write to the document resou...
pfeldman@chromium.org [Mon, 31 Oct 2011 11:55:59 +0000 (11:55 +0000)]
Web Inspector: do not map scripts generated with document.write to the document resources.
https://bugs.webkit.org/show_bug.cgi?id=71114

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/bind-script-to-resource.html

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
* inspector/front-end/Script.js:

LayoutTests:

* inspector/debugger/bind-script-to-resource-expected.txt: Added.
* inspector/debugger/bind-script-to-resource.html: Added.
* inspector/debugger/linkifier.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Add webkit_settings_new_with_settings() to WebKit2 GTK+ API
carlosgc@webkit.org [Mon, 31 Oct 2011 11:55:52 +0000 (11:55 +0000)]
[GTK] Add webkit_settings_new_with_settings() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71111

Reviewed by Martin Robinson.

Convenient method to create a WebKitSettings object with initial
settings.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_new_with_settings):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettingsNewWithSettings):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Add methods to get/set the settings of a web view to WebKit2 GTK+ API
carlosgc@webkit.org [Mon, 31 Oct 2011 11:45:37 +0000 (11:45 +0000)]
[GTK] Add methods to get/set the settings of a web view to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71109

Reviewed by Martin Robinson.

* GNUmakefile.am: Add WebKitSettingsPrivate.h.
* UIProcess/API/gtk/WebKitSettings.cpp:
(webkitSettingsAttachSettingsToPage): Set the preferences of the
given WebKitSettings object to the page group of the given WKPage.
* UIProcess/API/gtk/WebKitSettingsPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Create the default WebKitSettings for
the view.
(webkit_web_view_set_settings):
(webkit_web_view_get_settings):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSettings):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=71012
antti@apple.com [Mon, 31 Oct 2011 11:23:34 +0000 (11:23 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71012
Use StringHasher to generate the matched declaration cache hash

Reviewed by Sam Weinig.

Make sure the MatchedStyleDeclarations are fully zero-initialized as we calculate a hash over a raw memory array of these.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclaration):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
* css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
caseq@chromium.org [Mon, 31 Oct 2011 10:28:34 +0000 (10:28 +0000)]
Unreviewed.
Removed Mac10.5 CG expectation for css2.1/20110323/block-non-replaced-width-008.htm, marked it as fail.

* platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fix make distcheck build.
carlosgc@webkit.org [Mon, 31 Oct 2011 10:26:48 +0000 (10:26 +0000)]
Unreviewed. Fix make distcheck build.

Source/WebCore:

* GNUmakefile.am: Add InFilesCompiler.pm to SCRIPTS_BINDINGS and
EXTRA_DIST. Also remove duplicated entries in EXTRA_DIST.

Source/WebKit2:

* GNUmakefile.am: Remove docs/GNUmakefile.in from EXTRA_DIST,
since its generation was removed from configure.ac in r98498.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Mark fast/canvas/shadow-offset-3.html as PASS CRASH on GPU LINUX DEBUG.
caseq@chromium.org [Mon, 31 Oct 2011 09:35:58 +0000 (09:35 +0000)]
Unreviewed. Mark fast/canvas/shadow-offset-3.html as PASS CRASH on GPU LINUX DEBUG.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: factor out ResourceUtils, clean up externs.
pfeldman@chromium.org [Mon, 31 Oct 2011 09:18:30 +0000 (09:18 +0000)]
Web Inspector: factor out ResourceUtils, clean up externs.
https://bugs.webkit.org/show_bug.cgi?id=71192

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-31
Reviewed by Yury Semikhatsky.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/Resource.js:
(WebInspector.Resource.displayName):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._createResource):
* inspector/front-end/ResourceUtils.js: Added.
(WebInspector.resourceForURL):
(WebInspector.forAllResources):
(WebInspector.displayNameForURL):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.registerLinkifierPlugin):
(WebInspector.linkifyStringAsFragment):
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyURL):
(WebInspector.formatLinkText):
(WebInspector.linkifyResourceAsNode):
(WebInspector.resourceURLForRelatedNode.callback):
(WebInspector.resourceURLForRelatedNode):
(WebInspector.populateHrefContextMenu):
(WebInspector.completeURL):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.selectElement):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.networkResourceById):
* inspector/front-end/utilities.js:
(setupPrototypeUtilities.Element.prototype.selectionLeftOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Using keyboard to increment/decrement units is inconsistent
apavlov@chromium.org [Mon, 31 Oct 2011 08:37:32 +0000 (08:37 +0000)]
Web Inspector: Using keyboard to increment/decrement units is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=71119

Reviewed by Pavel Feldman.

Source/WebCore:

This change makes the behavior consistent with that described at http://trac.webkit.org/wiki/WebInspector

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.alteredFloatNumber):
(WebInspector.StylesSidebarPane.prototype._attributesModified):

LayoutTests:

* inspector/styles/up-down-numerics-and-colors-expected.txt:
* inspector/styles/up-down-numerics-and-colors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. compositing/visibility/visibility-image-layers.html fails on GPU.
caseq@chromium.org [Mon, 31 Oct 2011 08:28:13 +0000 (08:28 +0000)]
Unreviewed. compositing/visibility/visibility-image-layers.html fails on GPU.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] The Chromium port calls OwnPtr::get and RefPtr::get way more often than...
abarth@webkit.org [Mon, 31 Oct 2011 07:48:21 +0000 (07:48 +0000)]
[Chromium] The Chromium port calls OwnPtr::get and RefPtr::get way more often than needed
https://bugs.webkit.org/show_bug.cgi?id=71205

Reviewed by Ryosuke Niwa.

WebKit style is to use the implicit Boolean conversions rather than
calling get() on these pointer types.  This patch cleans up most (all?)
of these style issues in the Chromium port in the hopes that they'll be
copy/pasted less in the future.

* src/ApplicationCacheHostInternal.h:
(WebCore::ApplicationCacheHostInternal::toWebApplicationCacheHost):
* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::start):
(WebCore::AudioDestinationChromium::stop):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::setMainDocumentError):
(WebKit::FrameLoaderClientImpl::committedLoad):
(WebKit::FrameLoaderClientImpl::finishedLoading):
(WebKit::FrameLoaderClientImpl::redirectDataToPlugin):
* src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::postMessageToRemote):
* src/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
* src/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::connect):
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::hitTest):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::findChildByExpression):
(WebKit::WebFrameImpl::loadHistoryItem):
(WebKit::WebFrameImpl::characterIndexForPoint):
(WebKit::WebFrameImpl::selectionAsText):
(WebKit::WebFrameImpl::selectionAsMarkup):
(WebKit::WebFrameImpl::getPrintPageShrink):
(WebKit::WebFrameImpl::printPage):
(WebKit::WebFrameImpl::printEnd):
(WebKit::WebFrameImpl::scopeStringMatches):
* src/WebIDBKey.cpp:
(WebKit::WebIDBKey::type):
* src/WebIDBKeyRange.cpp:
(WebKit::WebIDBKeyRange::lower):
(WebKit::WebIDBKeyRange::upper):
(WebKit::WebIDBKeyRange::lowerOpen):
(WebKit::WebIDBKeyRange::upperOpen):
* src/WebImageCG.cpp:
(WebKit::WebImage::WebImage):
(WebKit::WebImage::operator=):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::cancelLoad):
(WebKit::WebMediaPlayerClientImpl::play):
(WebKit::WebMediaPlayerClientImpl::pause):
(WebKit::WebMediaPlayerClientImpl::sourceAppend):
(WebKit::WebMediaPlayerClientImpl::sourceEndOfStream):
(WebKit::WebMediaPlayerClientImpl::naturalSize):
(WebKit::WebMediaPlayerClientImpl::hasVideo):
(WebKit::WebMediaPlayerClientImpl::hasAudio):
(WebKit::WebMediaPlayerClientImpl::setVisible):
(WebKit::WebMediaPlayerClientImpl::duration):
(WebKit::WebMediaPlayerClientImpl::currentTime):
(WebKit::WebMediaPlayerClientImpl::seek):
(WebKit::WebMediaPlayerClientImpl::seeking):
(WebKit::WebMediaPlayerClientImpl::setEndTime):
(WebKit::WebMediaPlayerClientImpl::setRate):
(WebKit::WebMediaPlayerClientImpl::paused):
(WebKit::WebMediaPlayerClientImpl::supportsFullscreen):
(WebKit::WebMediaPlayerClientImpl::supportsSave):
(WebKit::WebMediaPlayerClientImpl::setVolume):
(WebKit::WebMediaPlayerClientImpl::networkState):
(WebKit::WebMediaPlayerClientImpl::readyState):
(WebKit::WebMediaPlayerClientImpl::maxTimeSeekable):
(WebKit::WebMediaPlayerClientImpl::buffered):
(WebKit::WebMediaPlayerClientImpl::dataRate):
(WebKit::WebMediaPlayerClientImpl::totalBytesKnown):
(WebKit::WebMediaPlayerClientImpl::totalBytes):
(WebKit::WebMediaPlayerClientImpl::bytesLoaded):
(WebKit::WebMediaPlayerClientImpl::setSize):
(WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext):
(WebKit::WebMediaPlayerClientImpl::setPreload):
(WebKit::WebMediaPlayerClientImpl::hasSingleSecurityOrigin):
(WebKit::WebMediaPlayerClientImpl::movieLoadType):
(WebKit::WebMediaPlayerClientImpl::mediaTimeForTimeValue):
(WebKit::WebMediaPlayerClientImpl::decodedFrameCount):
(WebKit::WebMediaPlayerClientImpl::droppedFrameCount):
(WebKit::WebMediaPlayerClientImpl::audioDecodedByteCount):
(WebKit::WebMediaPlayerClientImpl::videoDecodedByteCount):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::startDelayedLoad):
* src/WebURLRequest.cpp:
(WebKit::WebURLRequest::extraData):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::theme):
(WebKit::WebViewImpl::mainFrameImpl):
(WebKit::WebViewImpl::tabKeyCyclesThroughElements):
(WebKit::WebViewImpl::hideSelectPopup):
(WebKit::WebViewImpl::popupClosed):
(WebKit::WebViewImpl::focusedWebCoreFrame):
(WebKit::WebViewImpl::close):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::handleInputEvent):
(WebKit::WebViewImpl::setFocus):
(WebKit::WebViewImpl::compositionRange):
(WebKit::WebViewImpl::caretOrSelectionRange):
(WebKit::WebViewImpl::settings):
(WebKit::WebViewImpl::pageEncoding):
(WebKit::WebViewImpl::setPageEncoding):
(WebKit::WebViewImpl::setInitialFocus):
(WebKit::WebViewImpl::clearFocusedNode):
(WebKit::WebViewImpl::copyImageAt):
(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragLeave):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):
(WebKit::WebViewImpl::inspectElementAt):
(WebKit::WebViewImpl::applyAutofillSuggestions):
* src/WebWorkerBase.cpp:
(WebKit::WebWorkerBase::postMessageTask):
* src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::waitForOperationToComplete):
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing declaration in WebSettings.h
vangelis@chromium.org [Mon, 31 Oct 2011 07:10:01 +0000 (07:10 +0000)]
Add missing declaration in WebSettings.h
https://bugs.webkit.org/show_bug.cgi?id=71165

Reviewed by Darin Fisher.

* public/WebSettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebSocket: iframe in reload-crash.html reloads forever
yutak@chromium.org [Mon, 31 Oct 2011 02:50:30 +0000 (02:50 +0000)]
WebSocket: iframe in reload-crash.html reloads forever
https://bugs.webkit.org/show_bug.cgi?id=71098

Reviewed by Kent Tamura.

iframe in this test should not get reloaded more than once.

* http/tests/websocket/tests/hixie76/reload-crash.html:
Provide the value of reloadCount to the script in iframe.
* http/tests/websocket/tests/hixie76/resources/reload-crash-iframe.html:
Call location.reload() only if reloadCount is zero.
* http/tests/websocket/tests/hybi/reload-crash.html:
* http/tests/websocket/tests/hybi/resources/reload-crash-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJSParser::parsePrimaryExpression should have an overflow check
fpizlo@apple.com [Mon, 31 Oct 2011 01:50:34 +0000 (01:50 +0000)]
JSParser::parsePrimaryExpression should have an overflow check
https://bugs.webkit.org/show_bug.cgi?id=71197

Reviewed by Geoff Garen.

* parser/JSParser.cpp:
(JSC::JSParser::parsePrimaryExpression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r98819, r98823, r98825, and r98830.
commit-queue@webkit.org [Mon, 31 Oct 2011 01:43:44 +0000 (01:43 +0000)]
Unreviewed, rolling out r98819, r98823, r98825, and r98830.
http://trac.webkit.org/changeset/98819
http://trac.webkit.org/changeset/98823
http://trac.webkit.org/changeset/98825
http://trac.webkit.org/changeset/98830
https://bugs.webkit.org/show_bug.cgi?id=71199

Broke Chromium Windows bot (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-30

* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
* Scripts/webkitpy/layout_tests/port/efl.py:
* Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/qt.py:
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG ValueAdd(string, int) should not fail speculation
fpizlo@apple.com [Mon, 31 Oct 2011 00:21:15 +0000 (00:21 +0000)]
DFG ValueAdd(string, int) should not fail speculation
https://bugs.webkit.org/show_bug.cgi?id=71195

Reviewed by Geoff Garen.

1% speed-up on V8.

* dfg/DFGNode.h:
(JSC::DFG::Node::shouldNotSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateInteger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThe DFG inliner should not flush the callee
fpizlo@apple.com [Sun, 30 Oct 2011 22:47:31 +0000 (22:47 +0000)]
The DFG inliner should not flush the callee
https://bugs.webkit.org/show_bug.cgi?id=71191

Reviewed by Oliver Hunt.

0.6% speed-up on V8.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeOrigin.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrameSlow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonew-run-webkit-tests is locale dependent
eric@webkit.org [Sun, 30 Oct 2011 22:42:24 +0000 (22:42 +0000)]
new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.

This is a temporary hack until someone from the cr-win port
can take a look and determine which environment variable
lighttpd is missing.

* Scripts/webkitpy/layout_tests/port/chromium_win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Peter Beverloo's feed to Planet WebKit
rik@webkit.org [Sun, 30 Oct 2011 22:06:03 +0000 (22:06 +0000)]
Add Peter Beverloo's feed to Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=70316

Reviewed by Andreas Kling.

* config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove crash expectations from tests that have not been crashing on Chromium.
rniwa@webkit.org [Sun, 30 Oct 2011 19:34:32 +0000 (19:34 +0000)]
Remove crash expectations from tests that have not been crashing on Chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Switch to a backing store approach for painting WebKitWebView
mrobinson@webkit.org [Sun, 30 Oct 2011 16:29:33 +0000 (16:29 +0000)]
[GTK] Switch to a backing store approach for painting WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=70213

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. The changes to WebCore should not change
behavior. The changes in WebKit are covered by existing
tests.

* platform/cairo/WidgetBackingStore.h:
(WebCore::WidgetBackingStore::size): Added this getter for the size.
* platform/cairo/WidgetBackingStoreCairo.cpp:
(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize size.
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::copyRectFromCairoSurfaceToContext): Added this new helper.
(WebCore::copyRectFromOneSurfaceToAnother): Use the new helper.
* platform/graphics/cairo/CairoUtilities.h:
* platform/gtk/GtkWidgetBackingStoreX11.cpp:
(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize the size.

Source/WebKit/gtk:

Paint the WebView into a backing store. This prevents expose events from
triggering a layout, making scrolling and resizing much smoother.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::ChromeClient): Initialize new members.
(WebKit::repaintEverythingSoonTimeout): Added this helper which repaints
the WebView more quickly during resize events.
(WebKit::clipOutOldWidgetArea): Clips out the old widget area, so that we
can clear out invalid pixels when growing the widget into a pre-existing
backing store.
(WebKit::clearEverywhereInBackingStore): Clear out the entire backing store.
(WebKit::ChromeClient::widgetSizeChanged): Handle widget size changes by
intelligently resizing or reusing the existing backing store.
(WebKit::coalesceRectsIfPossible): Moved this method from webkitwebview.cpp.
(WebKit::paintWebView): Moved this method from webkitwebview.cpp.
(WebKit::ChromeClient::performAllPendingScrolls): If there are any pending
scrolling operations, perform them by scrolling the backing store.
(WebKit::ChromeClient::paint): Added this timer callback, which paints the
WebView after a short timeout.
(WebKit::ChromeClient::invalidateWindow): No need to do anything here any longer.
(WebKit::ChromeClient::invalidateContentsAndWindow): Now unite the rect with
the existing dirty region and queue the paint timeout.
(WebKit::ChromeClient::scroll): Now just queue a scroll event in the repaint timeout.
Intelligently calculate the area to move and the dirty area using code derived
from WebKit2.
* WebCoreSupport/ChromeClientGtk.h: Added new method definitions and also use
the WebCore namespace to avoid lots of uses of "WebCore::".
* webkit/webkitwebview.cpp:
(webkit_web_view_draw): Now just blit the backing store into the widget.
(webkit_web_view_expose): Ditto.
(webkit_web_view_size_allocate): Let the ChromeClient know the widget size changed.
(webkit_web_view_init): Turn off GDK double buffering as we have our own double
buffer.
* webkit/webkitwebviewprivate.h: Add the backing store member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r98803.
commit-queue@webkit.org [Sun, 30 Oct 2011 16:03:52 +0000 (16:03 +0000)]
Unreviewed, rolling out r98803.
http://trac.webkit.org/changeset/98803
https://bugs.webkit.org/show_bug.cgi?id=71186

Causing test and assertion failures on some platforms
(Requested by anttik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-30

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyMatchedDeclarations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonew-run-webkit-tests is locale dependent
eric@webkit.org [Sun, 30 Oct 2011 07:57:04 +0000 (07:57 +0000)]
new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.  I would have preferred to have this reviewed,
but relevant reviewers are asleep and bots are broken.

This was a regression from moving to a clean environment.
ChromiumWin (and possibly other ports), need the "PATH"
environment copied over.  This wasn't caught in my testing
because although we had unittests to cover this, they
weren't being run on anything but windows.  The vast majority
of this change is just fixing the unittests to use our
modern MockFileSystem/MockUser/MockExecutive so they can
be run on any system (and removing the platform checks from
the unittests so they are run everywhere).

The actual fix is the single line "PATH" string added to base.py.
The rest of this change is just fixing the Chromium port unittests
to run on all systems (including changing the Chromium port to
use FileSystem.path_to_module instead of __file__).

* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
* Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mrowe@apple.com [Sun, 30 Oct 2011 05:36:14 +0000 (05:36 +0000)]
Build fix.

* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonew-run-webkit-tests is locale dependent
eric@webkit.org [Sun, 30 Oct 2011 03:06:10 +0000 (03:06 +0000)]
new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.

Fix the Qt port and unittest the function so we don't break it again.

* Scripts/webkitpy/layout_tests/port/qt.py:
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mrowe@apple.com [Sun, 30 Oct 2011 00:45:50 +0000 (00:45 +0000)]
Build fix.

* editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename DataTransferItems to DataTransferItemList
dcheng@chromium.org [Sat, 29 Oct 2011 23:27:38 +0000 (23:27 +0000)]
Rename DataTransferItems to DataTransferItemList
https://bugs.webkit.org/show_bug.cgi?id=71151

Per feedback that Items and Item are hard to distinguish between, the HTML5 spec renamed
DataTransferItems to DataTransferItemList:
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-datatransferitemlist-interface

Reviewed by Tony Chang.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Clipboard.h:
* dom/Clipboard.idl:
* dom/DataTransferItemList.cpp: Renamed from Source/WebCore/dom/DataTransferItems.cpp.
(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::length):
(WebCore::DataTransferItemList::item):
(WebCore::DataTransferItemList::deleteItem):
(WebCore::DataTransferItemList::clear):
(WebCore::DataTransferItemList::add):
* dom/DataTransferItemList.h: Renamed from Source/WebCore/dom/DataTransferItems.h.
(WebCore::DataTransferItemList::~DataTransferItemList):
* dom/DataTransferItemList.idl: Renamed from Source/WebCore/dom/DataTransferItems.idl.
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::items):
* platform/chromium/ClipboardChromium.h:
* platform/chromium/DataTransferItemListChromium.cpp: Renamed from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
(WebCore::DataTransferItemListChromium::create):
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
(WebCore::DataTransferItemListChromium::addPasteboardItem):
* platform/chromium/DataTransferItemListChromium.h: Renamed from Source/WebCore/platform/chromium/DataTransferItemsChromium.h.
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::items):
* platform/qt/ClipboardQt.h:
* platform/qt/DataTransferItemListQt.cpp: Renamed from Source/WebCore/platform/qt/DataTransferItemsQt.cpp.
(WebCore::DataTransferItemListQt::create):
(WebCore::DataTransferItemListQt::DataTransferItemListQt):
(WebCore::DataTransferItemListQt::addPasteboardItem):
* platform/qt/DataTransferItemListQt.h: Renamed from Source/WebCore/platform/qt/DataTransferItemsQt.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd track-text-track-destructor-crash.html to Skipped files for mac and win
annacc@chromium.org [Sat, 29 Oct 2011 22:55:54 +0000 (22:55 +0000)]
Add track-text-track-destructor-crash.html to Skipped files for mac and win
https://bugs.webkit.org/show_bug.cgi?id=71182

Reviewed by Ryosuke Niwa.

* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonew-run-webkit-tests is locale dependent
eric@webkit.org [Sat, 29 Oct 2011 22:06:50 +0000 (22:06 +0000)]
new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Reviewed by Adam Barth.

Make NRWT use a clean environment just like ORWT did.
I've manually validated that NRWT now copies over
the same environment variables that ORWT did.
This new code is exercised by existing setup_environ_for_server tests.

* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/efl.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/qt.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac rebaseline after r98813.
rniwa@webkit.org [Sat, 29 Oct 2011 22:04:11 +0000 (22:04 +0000)]
Mac rebaseline after r98813.

* platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:
* platform/mac/fast/replaced/width100percent-searchfield-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd flaky test expectation to fast/forms/input-step-as-double.html on Chromium.
rniwa@webkit.org [Sat, 29 Oct 2011 21:34:30 +0000 (21:34 +0000)]
Add flaky test expectation to fast/forms/input-step-as-double.html on Chromium.
The failure is tracked by the bug 71181.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGTK+ and Qt rebaselines after r98794.
rniwa@webkit.org [Sat, 29 Oct 2011 21:20:17 +0000 (21:20 +0000)]
GTK+ and Qt rebaselines after r98794.

* platform/gtk/editing/pasteboard/5134759-expected.txt:
* platform/qt/editing/pasteboard/5134759-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSecond attempt to add results for tests introduced in http://trac.webkit.org/changese...
robert@webkit.org [Sat, 29 Oct 2011 20:35:10 +0000 (20:35 +0000)]
Second attempt to add results for tests introduced in trac.webkit.org/changeset/98812

* platform/chromium-linux/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
* platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt:
* platform/chromium/css2.1/20110323/block-non-replaced-width-008-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png.
* platform/chromium/css2.1/20110323/block-non-replaced-width-008-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoQt and Gtk Results for tests updated by http://trac.webkit.org/changeset/98812
robert@webkit.org [Sat, 29 Oct 2011 20:14:40 +0000 (20:14 +0000)]
Qt and Gtk Results for tests updated by  trac.webkit.org/changeset/98812

Unreviewed, platform-specific results.

* platform/gtk/css2.1/20110323/block-non-replaced-width-008-expected.txt:
* platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
* platform/qt/css2.1/20110323/block-non-replaced-width-008-expected.txt:
* platform/qt/fast/replaced/width100percent-searchfield-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd results for tests introduced in http://trac.webkit.org/changeset/98812.
robert@webkit.org [Sat, 29 Oct 2011 20:06:48 +0000 (20:06 +0000)]
Add results for tests introduced in trac.webkit.org/changeset/98812.

Unreviewed, platform-specific results.

* platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-searchfield-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png.
* platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.png: Added.
* platform/chromium-win/css2.1/20110323/block-non-replaced-width-008-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSS 2.1 failure: block-non-replaced-width-008.htm
robert@webkit.org [Sat, 29 Oct 2011 19:15:51 +0000 (19:15 +0000)]
CSS 2.1 failure: block-non-replaced-width-008.htm
https://bugs.webkit.org/show_bug.cgi?id=69278

Reviewed by Simon Fraser.

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthUsing):
  Include the margins in the calculation of logical width even when the containing block's
  width is zero. This is required by section '10.3.3 Block-level, non-replaced elements in
  normal flow' in the CSS 2.1 spec. Tested by block-non-replaced-width-008.htm in the CSS
  test suite.

LayoutTests:

* platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
  The pixel result is preserved, but the width of the containing block in the render
  tree now accurately reflects the rendered size of the cells.
* platform/chromium/test_expectations.txt:
* platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.png:
* platform/mac/css2.1/20110323/block-non-replaced-width-008-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd results for tests introduced in http://trac.webkit.org/changeset/98805.
abarth@webkit.org [Sat, 29 Oct 2011 18:58:42 +0000 (18:58 +0000)]
Add results for tests introduced in trac.webkit.org/changeset/98805.

* platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.txt: Removed.
* platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
* platform/chromium-win-vista/css2.1: Removed.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
* platform/chromium-win/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
* platform/chromium/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
* platform/chromium/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
* platform/chromium/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
* platform/chromium/css2.1/20110323/dynamic-top-change-004-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate results after http://trac.webkit.org/changeset/98794 to remove
abarth@webkit.org [Sat, 29 Oct 2011 18:29:31 +0000 (18:29 +0000)]
Update results after trac.webkit.org/changeset/98794 to remove
0x0 DIV from the render tree.

* platform/chromium-win/editing/pasteboard/5134759-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate line number in baseline.
abarth@webkit.org [Sat, 29 Oct 2011 18:26:04 +0000 (18:26 +0000)]
Update line number in baseline.

* platform/chromium-linux-x86/fast/dom: Removed.
* platform/chromium/fast/dom/nested-script-exceptions-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPlatform-specific results for r98805
robert@webkit.org [Sat, 29 Oct 2011 17:28:01 +0000 (17:28 +0000)]
Platform-specific results for r98805

Unreviewed, add new results.

* platform/gtk/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
* platform/gtk/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
* platform/gtk/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
* platform/gtk/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
* platform/mac/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
* platform/mac/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
* platform/mac/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
* platform/mac/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
* platform/qt/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
* platform/qt/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
* platform/qt/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
* platform/qt/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake sure TextTracks are destructed if HTMLMediaElement goes away.
annacc@chromium.org [Sat, 29 Oct 2011 16:52:23 +0000 (16:52 +0000)]
Make sure TextTracks are destructed if HTMLMediaElement goes away.
https://bugs.webkit.org/show_bug.cgi?id=71148

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-text-track-destructor-crash.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
    Destroy the client (this) on TextTracks.
(WebCore::HTMLMediaElement::loadTextTracks):
    Move TextTrack creation to loadNextTextTrack.
(WebCore::HTMLMediaElement::loadNextTextTrack):
    Keep track of new TextTrack in a list.
(WebCore::HTMLMediaElement::addTrack):
    Keep track of new TextTrack in a list.
* html/HTMLMediaElement.h:
    Add m_textTracks and loadNextTextTrack().

LayoutTests:

* media/track/track-text-track-destructor-crash-expected.txt: Added.
* media/track/track-text-track-destructor-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement IDBFactory.deleteDatabase
jochen@chromium.org [Sat, 29 Oct 2011 16:18:44 +0000 (16:18 +0000)]
Implement IDBFactory.deleteDatabase
https://bugs.webkit.org/show_bug.cgi?id=62622

Reviewed by Tony Chang.

Source/WebCore:

Tests: storage/indexeddb/factory-deletedatabase-interactions.html
       storage/indexeddb/factory-deletedatabase.html

* storage/IDBBackingStore.h:
* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::callbacks):
(WebCore::IDBDatabaseBackendImpl::PendingDeleteCall::PendingDeleteCall):
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
* storage/IDBDatabaseBackendImpl.h:
* storage/IDBFactory.cpp:
(WebCore::IDBFactory::deleteDatabase):
* storage/IDBFactory.h:
* storage/IDBFactory.idl:
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::deleteDatabase):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBFactoryBackendInterface.h:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::deleteRange):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
* storage/IDBLevelDBBackingStore.h:
* storage/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):

Source/WebKit/chromium:

* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::deleteDatabase):
* src/IDBFactoryBackendProxy.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):
(WebKit::WebIDBFactoryImpl::deleteDatabase):
* src/WebIDBFactoryImpl.h:

LayoutTests:

* storage/indexeddb/factory-basics-expected.txt: Updated.
* storage/indexeddb/factory-basics.html: Updated.
* storage/indexeddb/factory-deletedatabase-expected.txt: Added.
* storage/indexeddb/factory-deletedatabase-interactions-expected.txt: Added.
* storage/indexeddb/factory-deletedatabase-interactions.html: Added.
* storage/indexeddb/factory-deletedatabase.html: Added.
* storage/indexeddb/open-close-version-expected.txt: Updated.
* storage/indexeddb/open-close-version.html: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSS 2.1 failure: dynamic-top-change-001 to 004 fail
robert@webkit.org [Sat, 29 Oct 2011 14:52:05 +0000 (14:52 +0000)]
CSS 2.1 failure: dynamic-top-change-001 to 004 fail
https://bugs.webkit.org/show_bug.cgi?id=68149

Reviewed by David Hyatt.

Source/WebCore:

In these tests a child inherits its top value from its parent and the parent's top value
is later updated by an onload event. The updated value is expected to cascade to the child.

The tests were failing because updating the value did not cascade immediately to the child inheriting it, though
it could be forced eventually with a full recalculation of the RenderStyle by changing the zoom factor
or opening the inspector.

The fix is to let the parent RenderStyle know that a child inherits a property explicitly and
recalculate children's style if the parent ever changes. This only happens if the property is inherited
explicitly, it does not apply to cases where the property is inherited by default.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* dom/Node.cpp:
(WebCore::Node::diff):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setHasExplicitlyInheritedProperties):
(WebCore::InheritedFlags::hasExplicitlyInheritedProperties):

LayoutTests:

* css2.1/20110323/dynamic-top-change-001.htm: Added.
* css2.1/20110323/dynamic-top-change-002.htm: Added.
* css2.1/20110323/dynamic-top-change-003.htm: Added.
* css2.1/20110323/dynamic-top-change-004.htm: Added.
* fast/table/border-collapsing/cached-change-tbody-border-color-expected.png:
  See https://bugs.webkit.org/show_bug.cgi?id=68149#c15
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonew-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
kbalazs@webkit.org [Sat, 29 Oct 2011 14:45:23 +0000 (14:45 +0000)]
new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
https://bugs.webkit.org/show_bug.cgi?id=34984

Patch by Eric Seidel <eric@webkit.org> on 2011-10-29
Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

* Scripts/run-webkit-tests:
(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTighten font change conditions in matched declaration cache
antti@apple.com [Sat, 29 Oct 2011 09:36:12 +0000 (09:36 +0000)]
Tighten font change conditions in matched declaration cache
https://bugs.webkit.org/show_bug.cgi?id=71026

Reviewed by Darin Adler.

We currently test if font description has changed to see if all properties need to be applied. However
only a few size related metrics can actually affect other properties. We can just test those, making
the cache somewhat more effective while also making the equality test faster.

* css/CSSStyleSelector.cpp:
(WebCore::fontDifferenceAffectsNonInherited):
(WebCore::CSSStyleSelector::applyMatchedDeclarations):

    Test for text computedSize, xHeight and orientation only. Other text properties don't affect computed
    values of non-text CSS properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDOMURL should keep its own state rather than storing it on ScriptExecutionContext
abarth@webkit.org [Sat, 29 Oct 2011 09:10:31 +0000 (09:10 +0000)]
DOMURL should keep its own state rather than storing it on ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=71169

Reviewed by Eric Seidel.

This patch untwists this code.  I think this code was originally
twisted because these APIs moved onto DOMURL after they were first
implemented.

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
* dom/ScriptExecutionContext.h:
* fileapi/FileWriter.h:
* html/DOMURL.cpp:
(WebCore::DOMURL::contextDestroyed):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):
* html/DOMURL.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r98780.
commit-queue@webkit.org [Sat, 29 Oct 2011 08:21:28 +0000 (08:21 +0000)]
Unreviewed, rolling out r98780.
http://trac.webkit.org/changeset/98780
https://bugs.webkit.org/show_bug.cgi?id=71173

Broke Qt bots (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-29

* Scripts/run-webkit-tests:
(useNewRunWebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
antti@apple.com [Sat, 29 Oct 2011 07:58:04 +0000 (07:58 +0000)]
REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
https://bugs.webkit.org/show_bug.cgi?id=71032

Reviewed by Ryosuke Niwa.

In an effort to gain Hyatt points, add a less obscure test for this case.

* fast/css/inherited-properties-explicit-expected.txt: Added.
* fast/css/inherited-properties-explicit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r98795.
commit-queue@webkit.org [Sat, 29 Oct 2011 07:19:26 +0000 (07:19 +0000)]
Unreviewed, rolling out r98795.
http://trac.webkit.org/changeset/98795
https://bugs.webkit.org/show_bug.cgi?id=71171

Causes worker tests to crash (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-29

* dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::contextDestroyed):
* dom/MessagePort.cpp:
(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::contextDestroyed):
* dom/MessagePort.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::closeMessagePorts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac rebaseline after r98617.
rniwa@webkit.org [Sat, 29 Oct 2011 07:04:15 +0000 (07:04 +0000)]
Mac rebaseline after r98617.

* platform/mac/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt:
* platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline after r98775.
rniwa@webkit.org [Sat, 29 Oct 2011 06:41:28 +0000 (06:41 +0000)]
Rebaseline after r98775.

* fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPotential crash in ReplaceNodeWithSpanCommand
rniwa@webkit.org [Sat, 29 Oct 2011 06:31:16 +0000 (06:31 +0000)]
Potential crash in ReplaceNodeWithSpanCommand
https://bugs.webkit.org/show_bug.cgi?id=71145

Reviewed by Ojan Vafai.

Fix a potential crash without tests because we don't have a reduction.

* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMessagePort should be a ContextDestructionObserver
abarth@webkit.org [Sat, 29 Oct 2011 05:51:51 +0000 (05:51 +0000)]
MessagePort should be a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=71167

Reviewed by Eric Seidel.

I couldn't quite get rid of all the uses of the
ScriptExecutionContext::m_messagePorts in this patch.  I hope to get
rid of them in the future as the "extra data" design for
ScriptExecutionContext emerges.

* dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::contextDestroyed):
* dom/MessagePort.cpp:
(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::contextDestroyed):
* dom/MessagePort.h:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::closeMessagePorts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThe copy and paste result in nested scrollbars on http://dojotoolkit.org/widgets
rniwa@webkit.org [Sat, 29 Oct 2011 05:27:07 +0000 (05:27 +0000)]
The copy and paste result in nested scrollbars on dojotoolkit.org/widgets
https://bugs.webkit.org/show_bug.cgi?id=70799

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by WebKit's treating a fully selected root with background property as a special common ancestor.
A variant of this bug was caused by treating any element with text-decoration property as a presentational element.

Fixed the above two bugs by not serializing the said nodes. The effective background color was already serialized
by wrappingStyleForSerialization, there was nothing to be done besides stop including it in highestAncestorToWrapMarkup.

For text-decoration property, added the logic to compute the effective value in EditingStyle::init. Also treat it
as a non-inheritable editing property so that the rest of EditingStyle just works.

Test: editing/pasteboard/avoid-copying-body-with-background.html

* editing/EditingStyle.cpp: Added CSSPropertyTextDecoration to the list of editing properties.
(WebCore::copyEditingProperties):
(WebCore::EditingStyle::init): Compute the effective text decoration when propertiesToInclude is
EditingPropertiesInEffect.
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeInlineStyleOfElement):
(WebCore::EditingStyle::wrappingStyleForSerialization):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
* editing/EditingStyle.h: Renamed EditingInheritablePropertiesAndBackgroundColorInEffect to
EditingPropertiesInEffect.
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): Removed an assertion that's no longer valid.
(WebCore::isElementPresentational): Don't consider an element with text-decoration as a presentational element.
(WebCore::highestAncestorToWrapMarkup): Don't consider fully selected root as a special common ancestor ever.
Background color is computed property when we compute the wrapping style.
(WebCore::createMarkup):

LayoutTests:

Added a test to copy contents inside a body with background and text-decoration properties.

WebKit should not copy body element.

* editing/deleting/delete-line-break-before-underlined-content-expected.txt: an erroneous inline div
is replaced by a span.
* editing/deleting/deleting-line-break-preserves-underline-color-expected.txt: two style spans are
merged into one.
* editing/pasteboard/19644-2-expected.txt: div is replaced by span. This is okay because it's the only
content in the body. Even though we now only put the gray background under text as inline style as
opposed to apply at the block level, that's what execCommand('BackColor'...) does and what user expects.
* editing/pasteboard/avoid-copying-body-with-background-expected.txt: Added.
* editing/pasteboard/avoid-copying-body-with-background.html: Added.
* editing/pasteboard/preserve-underline-color-expected.txt:
* platform/mac/editing/pasteboard/5134759-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename ExceptionCodeDescription.in to DOMExceptions.in
abarth@webkit.org [Sat, 29 Oct 2011 01:56:13 +0000 (01:56 +0000)]
Rename ExceptionCodeDescription.in to DOMExceptions.in
https://bugs.webkit.org/show_bug.cgi?id=71157

Reviewed by Eric Seidel.

.:

* Source/cmake/WebKitMacros.cmake:

Source/WebCore:

This file is now used for more than just the descriptions of the exceptions.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/action_makenames.py:
* dom/DOMExceptions.in: Copied from Source/WebCore/dom/ExceptionCodeDescription.in.
* dom/ExceptionCodeDescription.in: Removed.
* dom/make_dom_exceptions.pl: Copied from Source/WebCore/dom/make_exception_code_description.pl.
* dom/make_exception_code_description.pl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSincResampler must be able to resample progressively
crogers@google.com [Sat, 29 Oct 2011 01:47:50 +0000 (01:47 +0000)]
SincResampler must be able to resample progressively
https://bugs.webkit.org/show_bug.cgi?id=71131

Reviewed by Kenneth Russell.

No new tests.  There is not yet an implementation using progressive resampling to test.

* platform/audio/SincResampler.cpp:
(WebCore::SincResampler::SincResampler):
(WebCore::SincResampler::consumeSource):
(WebCore::SincResampler::process):
* platform/audio/SincResampler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[MutationObservers] Support attributeOldValue for attribute mutations
adamk@chromium.org [Sat, 29 Oct 2011 01:31:04 +0000 (01:31 +0000)]
[MutationObservers] Support attributeOldValue for attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=70861

Reviewed by Ryosuke Niwa.

Source/WebCore:

Respect 'attributeOldValue' when passed to WebKitMutationObserver.observe().

If multiple observers have different attributeOldValue settings in
their registrations, two different MutationRecords are created (one is
a wrapper around the other).

If a single observer has multiple registrations that apply to a single
mutation, and those registrations have different values for
attributeOldValue, the observer is passed the oldValue.

* dom/Element.cpp:
(WebCore::hasOldValue):
(WebCore::enqueueAttributesMutationRecord):
(WebCore::Element::setAttribute):
* dom/MutationRecord.cpp:
(WebCore::MutationRecord::createAttributes):
(WebCore::MutationRecord::createWithNullOldValue):
* dom/MutationRecord.h:
(WebCore::MutationRecord::oldValue):

LayoutTests:

Added test cases for attributeOldValue to existing tests.

* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDelete ExceptionCode.cpp, which is empty
abarth@webkit.org [Sat, 29 Oct 2011 01:14:41 +0000 (01:14 +0000)]
Delete ExceptionCode.cpp, which is empty
https://bugs.webkit.org/show_bug.cgi?id=71159

Reviewed by Eric Seidel.

This file has been stripped down to nothing and can be removed.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/ExceptionCode.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r98776.
commit-queue@webkit.org [Sat, 29 Oct 2011 00:51:37 +0000 (00:51 +0000)]
Unreviewed, rolling out r98776.
http://trac.webkit.org/changeset/98776
https://bugs.webkit.org/show_bug.cgi?id=71164

caused lots of test crashes (Requested by smfr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-28

Source/WebCore:

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateVisibilityStatus):
(WebCore::RenderLayer::dirtyZOrderLists):
* rendering/RenderLayer.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enableCompositingMode):

LayoutTests:

* animations/resources/animation-test-helpers.js:
(checkExpectedValue):
* compositing/visibility/animation-visibility-expected.png: Removed.
* compositing/visibility/animation-visibility-expected.txt: Removed.
* compositing/visibility/animation-visibility.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImprovement to the fix for:
sullivan@apple.com [Sat, 29 Oct 2011 00:32:36 +0000 (00:32 +0000)]
Improvement to the fix for:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Dan Bernstein.

* page/EventHandler.cpp:
(WebCore::EventHandler::defaultBackspaceEventHandler):
Do the frame->settings() check after the !page check, since
a null page means null settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake DOMURL a ContextDestructionObserver
abarth@webkit.org [Sat, 29 Oct 2011 00:30:00 +0000 (00:30 +0000)]
Make DOMURL a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=71162

Reviewed by Eric Seidel.

This removes a bunch of hand-rolled ifdefed code.

* dom/ActiveDOMObject.h:
    - One-argument constructors should be explicit.
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
* dom/ScriptExecutionContext.h:
* html/DOMURL.cpp:
(WebCore::DOMURL::DOMURL):
(WebCore::DOMURL::~DOMURL):
* html/DOMURL.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove this horribly outdated file. It was showing up in
dino@apple.com [Sat, 29 Oct 2011 00:10:11 +0000 (00:10 +0000)]
Remove this horribly outdated file. It was showing up in
Google searches and shouldn't be used as official
documentation.

Rubber-stamped by Simon Fraser.

* specs/MediaQueriesExtensions.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkit.py gdb visualizer is broken after change to StringImpl
commit-queue@webkit.org [Sat, 29 Oct 2011 00:03:46 +0000 (00:03 +0000)]
webkit.py gdb visualizer is broken after change to StringImpl
https://bugs.webkit.org/show_bug.cgi?id=71154

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-10-28
Reviewed by Tony Chang.

r98624 changed StringImpl m_data to m_data32. This changes updates
webkit.py to match.

* gdb/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFactor ContextDestructionObserver out of ActiveDOMObject
abarth@webkit.org [Fri, 28 Oct 2011 23:57:21 +0000 (23:57 +0000)]
Factor ContextDestructionObserver out of ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=71153

Reviewed by Sam Weinig.

This patch paves the way to make more objects observe the destruction
of ScriptExecutioContext without needing to add ifdefs to
ScriptExecutionContext.h/cpp.  (As an example, see DOMURL.)

* dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ContextDestructionObserver::contextDestroyed):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
* dom/ActiveDOMObject.h:
(WebCore::ContextDestructionObserver::scriptExecutionContext):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::didCreateActiveDOMObject):
(WebCore::ScriptExecutionContext::willDestroyActiveDOMObject):
(WebCore::didCreateDestructionObserver):
(WebCore::willDestroyDestructionObserver):
* dom/ScriptExecutionContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/71144> Fix typo in check-for-inappropriate-objc-class-names
joepeck@webkit.org [Fri, 28 Oct 2011 23:51:12 +0000 (23:51 +0000)]
<webkit.org/b/71144> Fix typo in check-for-inappropriate-objc-class-names

Reviewed by Dan Bernstein.

* Scripts/check-for-inappropriate-objc-class-names:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd support for sending scroll-update events from EventSender.
commit-queue@webkit.org [Fri, 28 Oct 2011 23:44:30 +0000 (23:44 +0000)]
Add support for sending scroll-update events from EventSender.
https://bugs.webkit.org/show_bug.cgi?id=66272

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-10-28
Reviewed by Adam Barth.

Source/WebKit/chromium:

* public/WebInputEvent.h:
(WebKit::WebGestureEvent::WebGestureEvent):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):

Tools:

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::reset):
(EventSender::gestureScrollUpdate):
(EventSender::gestureEvent):
* DumpRenderTree/chromium/EventSender.h:

LayoutTests:

* fast/events/touch/gesture/gesture-scroll-expected.txt: Added.
* fast/events/touch/gesture/gesture-scroll.html: Added.
* platform/chromium/fast/events/touch/gesture/gesture-scroll-expected.txt: Added.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
jeffm@apple.com [Fri, 28 Oct 2011 23:35:08 +0000 (23:35 +0000)]
More work on WebKit2 should respect WebKitOmitPDFSupport preference on the Mac
https://bugs.webkit.org/show_bug.cgi?id=71156

Don't include PDF and PostScript types in the set of MIME types with custom representations
when initializing the web process if WebKitOmitPDFSupport is set.

I believe the previous patch r98513 was actually sufficient to prevent PDFs from being
shown inline when this preference was set, but to be complete we should exclude the MIME
types here as well.

Reviewed by Alexey Proskuryakov.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonew-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
eric@webkit.org [Fri, 28 Oct 2011 23:31:41 +0000 (23:31 +0000)]
new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
https://bugs.webkit.org/show_bug.cgi?id=34984

Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

* Scripts/run-webkit-tests:
(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOne more unreviewed build fix due to r98775.
timothy_horton@apple.com [Fri, 28 Oct 2011 23:31:11 +0000 (23:31 +0000)]
One more unreviewed build fix due to r98775.

No new tests.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Track wheel event handler registration and pass to input filter
jamesr@google.com [Fri, 28 Oct 2011 23:30:07 +0000 (23:30 +0000)]
[chromium] Track wheel event handler registration and pass to input filter
https://bugs.webkit.org/show_bug.cgi?id=71078

Reviewed by Kenneth Russell.

Source/WebCore:

This propagates mouse wheel registration notifications to the compositor input filter. If there are any handlers
registered, which includes JS handlers and scrollable areas other than the main view, the input filter will pass
mouse wheel events to the widget. Otherwise when threaded compositing is enabled the input filter translates
wheel events into root layer scrolling.

Only changes behavior with an off-by-default flag enabled, so no tests.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setHaveWheelEventHandlers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::haveWheelEventHandlers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::setHaveWheelEventHandlers):
* platform/graphics/chromium/cc/CCScrollController.h:

Source/WebKit/chromium:

Pushes mouse wheel event handler notifications to CCLayerTreeHost when compositing.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::numWheelEventHandlersChanged):
* src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::numberOfWheelEventHandlersChanged):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix due to r98775.
timothy_horton@apple.com [Fri, 28 Oct 2011 23:27:32 +0000 (23:27 +0000)]
Unreviewed build fix due to r98775.

No new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIf visibility changes while an accelerated animation is running, element jumps around
simon.fraser@apple.com [Fri, 28 Oct 2011 23:18:08 +0000 (23:18 +0000)]
If visibility changes while an accelerated animation is running, element jumps around
https://bugs.webkit.org/show_bug.cgi?id=29984

Source/WebCore:

Reviewed by Chris Marrin.

Compositing now affects whether RenderLayers for visibility:hidden elements
are included in z-order lists. So we have to dirty those lists when we enter
compopsiting mode.

Test: compositing/visibility/animation-visibility.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateVisibilityStatus): Removed trailing whitespace.
(WebCore::RenderLayer::dirtyZOrderLists): Call dirtyZOrderListsInternal(), which doesn't have
to ping the compositor.
(WebCore::RenderLayer::dirtyZOrderListsInternal):
(WebCore::RenderLayer::dirtyZOrderListsIncludingDescendants): Recursively dirty z-order
lists.
* rendering/RenderLayer.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::enableCompositingMode): When going into compositing mode,
dirty all z-order lists.

LayoutTests:

Reviewed by Chris Marrin.

Add testcase for visibility changing in the middle of an accelerated animation.

* animations/resources/animation-test-helpers.js: Add some constants for readability.
(checkExpectedValue): Add support for testing 'visibility'.
* compositing/visibility/animation-visibility-expected.png: Added.
* compositing/visibility/animation-visibility-expected.txt: Added.
* compositing/visibility/animation-visibility.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement CSS3 Images cross-fade() image function
timothy_horton@apple.com [Fri, 28 Oct 2011 23:08:51 +0000 (23:08 +0000)]
Implement CSS3 Images cross-fade() image function
https://bugs.webkit.org/show_bug.cgi?id=52162
<rdar://problem/10209254>

Reviewed by Simon Fraser.

Parse -webkit-cross-fade according to the CSS3 Images Values specification.

Also, adjust other CSS parsing functions to support nested functions, by using a specific CSS value list
instead of the global one. This allows - for example - cross-fade to pass each of its arguments back into
parseFillImage and to successfully parse image functions in this fashion.

Test: fast/css/getComputedStyle/computed-style-cross-fade.html

* WebCore.xcodeproj/project.pbxproj:
* css/CSSCrossfadeValue.cpp: Added.
(WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::cssText):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::image):
* css/CSSCrossfadeValue.h: Added.
(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::isFixedSize):
(WebCore::CSSCrossfadeValue::setFromImage):
(WebCore::CSSCrossfadeValue::setToImage):
(WebCore::CSSCrossfadeValue::setPercentage):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isGeneratedImageValue):
(WebCore::CSSParser::parseGeneratedImage):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseCanvas):
* css/CSSParser.h:

Add tests to ensure that -webkit-cross-fade is parsed correctly.

* fast/css/getComputedStyle/computed-style-cross-fade-expected.txt: Added.
* fast/css/getComputedStyle/computed-style-cross-fade.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAttempted build fix after r98765.
mitz@apple.com [Fri, 28 Oct 2011 23:06:00 +0000 (23:06 +0000)]
Attempted build fix after r98765.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformWidthForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCSS grammar doesn't support functions with no parameters
cmarrin@apple.com [Fri, 28 Oct 2011 22:55:37 +0000 (22:55 +0000)]
CSS grammar doesn't support functions with no parameters
https://bugs.webkit.org/show_bug.cgi?id=69110

Reviewed by Dean Jackson.

Source/WebCore:

Add rule to grammar to accept functions with 0 args and return
this case with a CSSParserValueList with 0 values. Also fixed
filter creation function to properly handle filters with 0
arguments.

* css/CSSGrammar.y:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createFilterOperations):

LayoutTests:

Updated tests to include tests for allowing 0 argument functions and for
disallowing functions with trailing commas (to pickup a couple of theses
cases not in the current tests). Also fixed one typo.

* css3/filters/filter-property-computed-style-expected.txt:
* css3/filters/filter-property-parsing-expected.txt:
* css3/filters/filter-property-parsing-invalid-expected.txt:
* css3/filters/script-tests/filter-property-computed-style.js:
* css3/filters/script-tests/filter-property-parsing-invalid.js:
* css3/filters/script-tests/filter-property-parsing.js:
(testFilterRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r98757.
johnnyg@google.com [Fri, 28 Oct 2011 22:34:42 +0000 (22:34 +0000)]
Unreviewed, rolling out r98757.
http://trac.webkit.org/changeset/98757
https://bugs.webkit.org/show_bug.cgi?id=71150

crashes webkit_unit_tests on chromium windows (Requested by
johnny_g on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-28

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Eric Seidel.
abarth@webkit.org [Fri, 28 Oct 2011 22:21:49 +0000 (22:21 +0000)]
Rubber-stamped by Eric Seidel.

Fix namespace indent in ScriptExecutionContext.h.

* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isDocument):
(WebCore::ScriptExecutionContext::isWorkerContext):
(WebCore::ScriptExecutionContext::setHasOpenDatabases):
(WebCore::ScriptExecutionContext::hasOpenDatabases):
(WebCore::ScriptExecutionContext::url):
(WebCore::ScriptExecutionContext::completeURL):
(WebCore::ScriptExecutionContext::securityOrigin):
(WebCore::ScriptExecutionContext::contentSecurityPolicy):
(WebCore::ScriptExecutionContext::activeDOMObjects):
(WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks):
(WebCore::ScriptExecutionContext::messagePorts):
(WebCore::ScriptExecutionContext::domUrls):
(WebCore::ScriptExecutionContext::ref):
(WebCore::ScriptExecutionContext::deref):
(WebCore::ScriptExecutionContext::Task::Task):
(WebCore::ScriptExecutionContext::Task::isCleanupTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: WebCore part of:
sullivan@apple.com [Fri, 28 Oct 2011 22:07:16 +0000 (22:07 +0000)]
Source/WebCore: WebCore part of:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

* page/EventHandler.cpp:
(WebCore::EventHandler::defaultBackspaceEventHandler):
Bail out if backspace navigation is not enabled.

* page/Settings.cpp:
(WebCore::Settings::Settings):
Initialize m_backspaceKeyNavigationEnabled to true to match current behavior.

* page/Settings.h:
Declared m_backspaceKeyNavigationEnabled.
(WebCore::Settings::setBackspaceKeyNavigationEnabled):
New function, simple setter.
(WebCore::Settings::backspaceKeyNavigationEnabled):
New function, simple getter.

Source/WebKit/mac: WebKit part of:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

* WebView/WebFrameView.mm:
(-[WebFrameView keyDown:]):
Honor the new preference.

* WebView/WebPreferenceKeysPrivate.h:
Added #define for WebKitBackspaceKeyNavigationEnabledKey

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Initialize new pref to YES, to match current behavior.
(-[WebPreferences setBackspaceKeyNavigationEnabled:]):
New method, standard prefs setter.
(-[WebPreferences backspaceKeyNavigationEnabled]):
New method, standard prefs getter.

* WebView/WebPreferencesPrivate.h:
Declared new methods.

* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Updates WebCore settings from WebKit prefs.

Source/WebKit2: WebKit2 part of:
https://bugs.webkit.org/show_bug.cgi?id=71142
Whether backspace goes Back should be configurable

Reviewed by Sam Weinig.

* Shared/WebPreferencesStore.h:
Declared backspaceKeyNavigationEnabled property using macro. This initializes
it to true, to match current behavior.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetBackspaceKeyNavigationEnabled):
New function, pass value to impl.
(WKPreferencesGetBackspaceKeyNavigationEnabled):
New function, returns result from impl.

* UIProcess/API/C/WKPreferences.h:
Declared API functions for new preference.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Updates WebCore settings from WebKit2 prefs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening.
johnnyg@google.com [Fri, 28 Oct 2011 21:55:59 +0000 (21:55 +0000)]
Unreviewed gardening.

* platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/dom: Removed.
* platform/chromium-cg-mac/fast/dom/nested-script-exceptions-expected.txt: Removed.
* platform/chromium-cg-mac/svg/hixie/perf: Removed.
* platform/chromium-cg-mac/svg/hixie/perf/001-expected.png: Removed.
* platform/chromium-gpu-mac/compositing/visibility: Added.
* platform/chromium-gpu-mac/compositing/visibility/visibility-image-layers-expected.png: Added.
* platform/chromium-gpu-win/compositing/visibility: Added.
* platform/chromium-gpu-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
* platform/chromium-gpu-win/compositing/visibility/visibility-image-layers-expected.png: Added.
* platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
* platform/chromium-linux/svg/hixie/perf/001-expected.png:
* platform/chromium-mac-snowleopard/fast/dom: Removed.
* platform/chromium-mac/fast/dom/nested-script-exceptions-expected.txt: Removed.
* platform/chromium-mac/svg/hixie/perf/001-expected.png: Removed.
* platform/chromium-mac/svg/hixie/perf/001-expected.txt: Removed.
* platform/chromium-win-xp/svg/batik/text/textOnPath-expected.png: Removed.
* platform/chromium-win/fast/dom/nested-script-exceptions-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOverridden clippedOverflowRectForRepaint() still uses IntRects
eae@chromium.org [Fri, 28 Oct 2011 21:55:11 +0000 (21:55 +0000)]
Overridden clippedOverflowRectForRepaint() still uses IntRects
https://bugs.webkit.org/show_bug.cgi?id=71046

Reviewed by Simon Fraser.

Change all virtual clippedOverflowRectForRepaint functions to use the
same signature.

No new tests.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
* rendering/RenderObject.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
* rendering/RenderReplaced.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
* rendering/RenderTableCell.h:
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::clippedOverflowRectForRepaint):
* rendering/RenderTableCol.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
* rendering/RenderTableRow.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint):
* rendering/RenderText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unused parsers for 'exception' and 'alias' IDL keywords
adamk@chromium.org [Fri, 28 Oct 2011 21:46:17 +0000 (21:46 +0000)]
Remove unused parsers for 'exception' and 'alias' IDL keywords
https://bugs.webkit.org/show_bug.cgi?id=71140

Reviewed by Adam Barth.

* bindings/scripts/IDLParser.pm:
(ParseInterface):
(DetermineParseMode):
(ProcessSection):
* bindings/scripts/IDLStructure.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/10288006> Emoji characters are too close to each other in small font...
mitz@apple.com [Fri, 28 Oct 2011 21:41:43 +0000 (21:41 +0000)]
<rdar://problem/10288006> Emoji characters are too close to each other in small font size

Reviewed by Sam Weinig.

Source/WebCore:

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformWidthForGlyph): If the font is a color bitmap font, use
-[NSFont advancementForGlyph:] instead of wkGetGlyphTransformedAdvances().

LayoutTests:

* platform/mac/fast/css/font-family-pictograph-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unused default constructor
abarth@webkit.org [Fri, 28 Oct 2011 21:30:44 +0000 (21:30 +0000)]
Remove unused default constructor
https://bugs.webkit.org/show_bug.cgi?id=71136

Reviewed by Eric Seidel.

No one is calling this constructor anymore now that we've fixed the
callers.

* dom/make_exception_code_description.pl:
(generateHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash when splitting inline flows with generated floats
commit-queue@webkit.org [Fri, 28 Oct 2011 21:28:39 +0000 (21:28 +0000)]
Crash when splitting inline flows with generated floats
https://bugs.webkit.org/show_bug.cgi?id=70458

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-28
Reviewed by David Hyatt.

Source/WebCore:

When lineBoxes on a RenderBlock are being deleted, we now check the floating object list to
ensure references to them are being cleared.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::deleteLineBoxTree): Remove references to lineBox when deleting them

LayoutTests:

Added test for crash condition when splitting inline flows on an object with generated floats.

* fast/css-generated-content/inline-splitting-with-after-float-crash.html: Added
* fast/css-generated-content/inline-splitting-with-after-float-crash-expected.txt: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98763 268f45cc-cd09-0410-ab3c-d52691b4dbfc