WebKit-https.git
13 years ago<rdar://problem/5119360> ER - Seed: Google results do not have AXHeading information
cfleizach@apple.com [Tue, 4 Mar 2008 19:36:01 +0000 (19:36 +0000)]
<rdar://problem/5119360> ER - Seed: Google results do not have AXHeading information

Make headers appear in AX regardless of whether they have BlockFlow renderers or not

Reviewed by Darin Adler.

* page/mac/WebCoreAXObject.mm:
(headingLevel): no longer ignores BlockFlow rendered headers
(-[WebCoreAXObject accessibilityIsIgnored]): does not ignore headers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to be...
aroben@apple.com [Tue, 4 Mar 2008 19:15:16 +0000 (19:15 +0000)]
    * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to be omitted from the hunk header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change WebView's string-finding methods to call through to Page
aroben@apple.com [Tue, 4 Mar 2008 17:59:28 +0000 (17:59 +0000)]
     Change WebView's string-finding methods to call through to Page

         These methods were added to Page back in r28878 (and the
         implementation was copied from WebView!) but we never switched over to
         using them.

         Reviewed by Sam.

         * WebView.cpp:
         (WebView::searchFor): Call through to Page::findString.
         (WebView::markAllMatchesForText): Call through to Page.
         (WebView::unmarkAllTextMatches): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago GTK+ build fix.
weinig@apple.com [Tue, 4 Mar 2008 17:57:18 +0000 (17:57 +0000)]
    GTK+ build fix.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
weinig@apple.com [Tue, 4 Mar 2008 17:46:01 +0000 (17:46 +0000)]
    Reviewed by Darin Adler.

        Remame ImageConstructorImp to JSImageConstructor and move it into its
        own file.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSImageConstructor.cpp: Copied from bindings/js/kjs_html.cpp.
        (WebCore::JSImageConstructor::JSImageConstructor):
        (WebCore::JSImageConstructor::construct):
        * bindings/js/JSImageConstructor.h: Copied from bindings/js/kjs_html.h.
        * bindings/js/kjs_html.cpp:
        (WebCore::getRuntimeObject): Make this function static since it is only used
        in this file.
        * bindings/js/kjs_html.h:
        * bindings/js/kjs_window.cpp:
        (WebCore::JSDOMWindowBase::getValueProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
darin@apple.com [Tue, 4 Mar 2008 17:24:42 +0000 (17:24 +0000)]
    Reviewed by Adam.

        - fix 200+ failing regression tests
        - fix http://bugs.webkit.org/show_bug.cgi?id=17668
          Vertical scrollbar at slashdot.org is randomly not shown

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting
        code here to exactly match the way it was before it was moved from WebCore. I had
        introduced a storage leak and that was causing problems with scroll bars!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix an uninitialized value warning in CodeGeneratorJS.pm
aroben@apple.com [Tue, 4 Mar 2008 17:21:44 +0000 (17:21 +0000)]
    Fix an uninitialized value warning in CodeGeneratorJS.pm

        * bindings/scripts/CodeGeneratorJS.pm: Remove reference to
        non-existent $maybeOkParam (this was removed in r30753).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
weinig@apple.com [Tue, 4 Mar 2008 17:02:20 +0000 (17:02 +0000)]
    Reviewed by Darin Adler.

        Remove kjs_dom.{h,cpp}.

        - Removed custom toAttr, which took a boolean ok, and teach CodeGeneratorJS.pm
          to us a null return value as an indication of failure. (This new logic is used
          for toVoidCallback as well.)
        - Move getRuntimeObject to kjs_html where a bunch of other runtime object related
          functions currently live.
        - Move checkNodeSecurity to kjs_binding, where other frame security functions
          currently live.
        - Remove getNodeConstructor.  It had no implementation.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSAttrCustom.cpp:
        * bindings/js/JSCustomVoidCallback.cpp:
        (WebCore::toVoidCallback):
        * bindings/js/JSCustomVoidCallback.h:
        * bindings/js/JSDatabaseCustom.cpp:
        (WebCore::JSDatabase::changeVersion):
        (WebCore::JSDatabase::transaction):
        * bindings/js/JSElementCustom.cpp:
        (WebCore::JSElement::setAttributeNode):
        (WebCore::JSElement::setAttributeNodeNS):
        * bindings/js/JSEventTargetBase.cpp:
        (WebCore::toJS):
        * bindings/js/JSEventTargetBase.h:
        * bindings/js/JSHTMLAppletElementCustom.cpp:
        * bindings/js/JSHTMLElementCustom.cpp:
        * bindings/js/JSHTMLEmbedElementCustom.cpp:
        * bindings/js/JSHTMLFormElementCustom.cpp:
        * bindings/js/JSHTMLFrameElementCustom.cpp:
        * bindings/js/JSHTMLIFrameElementCustom.cpp:
        * bindings/js/JSHTMLObjectElementCustom.cpp:
        * bindings/js/JSNamedNodeMapCustom.cpp:
        * bindings/js/JSNamedNodesCollection.cpp:
        * bindings/js/JSNodeFilterCustom.cpp:
        * bindings/js/JSXSLTProcessor.cpp:
        * bindings/js/kjs_binding.cpp:
        (WebCore::checkNodeSecurity):
        * bindings/js/kjs_binding.h:
        * bindings/js/kjs_css.cpp:
        * bindings/js/kjs_dom.cpp: Removed.
        * bindings/js/kjs_dom.h: Removed.
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_html.cpp:
        (WebCore::getRuntimeObject):
        * bindings/js/kjs_html.h:
        * bindings/js/kjs_window.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Attr.idl:
        * html/HTMLPlugInElement.cpp:
        * page/InspectorController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Actually pause the process while Drosera is at a breakpoint
aroben@apple.com [Tue, 4 Mar 2008 17:00:22 +0000 (17:00 +0000)]
     Actually pause the process while Drosera is at a breakpoint

         WebScriptDebugServer::suspendProcessIfPaused is supposed to pause the
         process while Drosera is at a breakpoint. Previously we were just
         starting a message pump that would deliver messages to all windows in
         the process, allowing mouse events, JS timers, etc. to execute.

         Now we only deliver messages to COM's message window, which is all we
         need to allow RPC to function.

         Reviewed by Anders.

         * WebScriptDebugServer.cpp:
         (comMessageWindow): Added. Finds COM's message window.
         (WebScriptDebugServer::suspendProcessIfPaused): Only deliver messages
         to COM's message window so that mouse events, JS timers, etc., won't
         execute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Generate WebScriptCallFrame instances dynamically
aroben@apple.com [Tue, 4 Mar 2008 17:00:04 +0000 (17:00 +0000)]
    Generate WebScriptCallFrame instances dynamically

        WebScriptDebugger no longer holds a reference to the topmost call
        frame, and WebScriptCallFrame no longer holds a reference to its
        caller. We now generate WebScriptCallFrame instances as needed by
        walking the callingExecState chain.

        By making WebKit no longer responsible for keeping track of the call
        stack, we get one step closer to moving most JS debugging code out of
        WebKit entirely.

        This incidentally fixes a bug in Drosera where we'd never show the
        global scope in the call stack.

        Reviewed by Sam and Kevin M.

        * WebScriptCallFrame.cpp:
        (callingFunctionOrGlobalExecState): Finds the nearest calling
        ExecState that is a FunctionExecState or GlobalExecState, if any, and
        returns it.
        (WebScriptCallFrame::WebScriptCallFrame):
          - No longer takes a caller parameter.
          - Sets m_state to the callingFunctionOrGlobalExecState of the
            ExecState passed in.
        (WebScriptCallFrame::createInstance): Removed the caller parameter.
        (WebScriptCallFrame::caller): Generate a new WebScriptCallFrame on the
        fly from our ExecState.
        * WebScriptCallFrame.h: No longer holds a reference to the caller.
        * WebScriptDebugger.cpp:
        (WebScriptDebugger::WebScriptDebugger): Removed the call to callEvent
        that was supposed to set up the global scope call frame, but never
        worked because m_callingServer was set to true, which would cause
        callEvent to return early without doing anything. Also removed the
        m_callingServer guards since we're not calling callEvent anymore.
        (WebScriptDebugger::callEvent): Create a WebScriptCallFrame on the
        fly from the passed-in ExecState.
        (WebScriptDebugger::atStatement): Ditto.
        (WebScriptDebugger::returnEvent): Ditto, but use the callingExecState.
        This is equivalent to what calling leaveFrame() did before.
        (WebScriptDebugger::exception): Ditto, using the passed-in ExecState.
        * WebScriptDebugger.h: Removed m_topStackFrame member and
        enterFrame/leaveFrame methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Win/Qt/GTK+/wx build fix after r30740
aroben@apple.com [Tue, 4 Mar 2008 16:59:43 +0000 (16:59 +0000)]
    Win/Qt/GTK+/wx build fix after r30740

        * editing/Editor.cpp: Added missing #include.
        * page/qt/FrameQt.cpp: Removed Frame::dashboardRegionsChanged.
        * page/win/FrameWin.cpp: Ditto.
        * platform/wx/TemporaryLinkStubs.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 4 Mar 2008 16:57:03 +0000 (16:57 +0000)]
2008-03-04  Alp Toker  <alp@atoker.com>

        GTK+ build fix for breakage introduced in r30740.

        Remove Frame::dashboardRegionsChanged(). There's now a default
        implementation at ChromeClient::dashboardRegionsChanged().

        * page/gtk/FrameGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-04 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 4 Mar 2008 16:49:48 +0000 (16:49 +0000)]
2008-03-04  Alp Toker  <alp@atoker.com>

        GTK+ build fix suggested by aroben. Remove an unused Mac-specific
        included introduced in r30740.

        * page/ChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 4 Mar 2008 16:03:02 +0000 (16:03 +0000)]
WebCore:

        Reviewed by Sam Weinig.

        - fix <rdar://problem/5622336> Burmese text does not render on http://www.myanmarbible.com/bible/Judson/html/index.html

        Test: platform/win/fast/text/uniscribe-missing-glyph.html

        Note that default installations of Windows do not have Myanmar fonts.
        What this patch does is ensure that the Myanmar and other complex
        scripts are rendered as missing glyphs rather than not rendered at all.
        The particular page in the bug measures the relative widths of two
        rendered strings and, if they are rendered as missing glyphs, detects
        that a Myanmar fonts is not available and substitutes the text with
        images. By not rendering (and measuring) missing glyphs, WebKit was
        throwing the page's detection code off.

        * platform/graphics/win/UniscribeController.cpp:
        (WebCore::UniscribeController::shape): Removed an early return in case
        shaping resulted in missing glyphs. This is now expected if font
        fallback failed to produce a font containing glyphs for the character.
        Also changed two resize()s to shrink()s.

LayoutTests:

        - test for <rdar://problem/5622336> Burmese text does not render on http://www.myanmarbible.com/bible/Judson/html/index.html

        * platform/win/fast/text/uniscribe-missing-glyph-expected.txt: Added.
        * platform/win/fast/text/uniscribe-missing-glyph.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:34:24 +0000 (15:34 +0000)]
WebCore:

        Reviewed by Adam.

        - remove WebCoreFrameBridge reapplyStyles method

        * WebCore.base.exp: Added exports.
        * page/mac/WebCoreFrameBridge.h: Removed WebCoreDeviceType and
        reapplyStylesForDeviceType: method.
        * page/mac/WebCoreFrameBridge.mm: Ditto.

WebKit/mac:

        Reviewed by Adam.

        - remove WebCoreFrameBridge reapplyStyles method

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:29:08 +0000 (15:29 +0000)]
WebCore:

        Reviewed by Adam.

        - eliminate WebCoreFrameBridge createFrameViewWithNSView

        * WebCore.base.exp: Added some more exports.
        * page/mac/WebCoreFrameBridge.h: Deleted createFrameViewWithNSView.
        * page/mac/WebCoreFrameBridge.mm: Ditto.

WebKit/mac:

        Reviewed by Adam.

        - eliminate WebCoreFrameBridge createFrameViewWithNSView

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::transitionToCommittedForNewPage):
        Moved code here from createFrameViewWithNSView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:24:43 +0000 (15:24 +0000)]
WebCore:

        Reviewed by Adam.

        - removed WebCoreFrameBridge scrollOverflowInDirection

        * WebCore.base.exp: Export function needed by WebKit.
        * page/mac/WebCoreFrameBridge.h: Removed WebScrollDirection, WebScrollGranularity,
        and scrollOverflowInDirection.
        * page/mac/WebCoreFrameBridge.mm: Removed method.

WebKit/mac:

        Reviewed by Adam.

        - removed WebCoreFrameBridge scrollOverflowInDirection

        * WebView/WebFrameView.mm:
        (-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call
        EventHandler directly instead of using the bridge.
        (-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead
        of the ones from the bridge.
        (-[WebFrameView scrollToEndOfDocument:]): Ditto.
        (-[WebFrameView _pageVertically:]): Ditto.
        (-[WebFrameView _pageHorizontally:]): Ditto.
        (-[WebFrameView _scrollLineVertically:]): Ditto.
        (-[WebFrameView _scrollLineHorizontally:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:21:42 +0000 (15:21 +0000)]
WebCore:

        Reviewed by Adam.

        - remove WebCoreFrameBridge installInFrame: method

        * WebCore.base.exp: Export a few symbols.
        * WebCore.xcodeproj/project.pbxproj: Export a few files.
        * page/mac/WebCoreFrameBridge.h: Remove installInFrame:.
        * page/mac/WebCoreFrameBridge.mm: Ditto.

WebKit/mac:

        Reviewed by Adam.

        - remove WebCoreFrameBridge installInFrame: method

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
        -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
        * WebView/WebFrameView.mm:
        (-[WebFrameView _install]): Added. Has code from -[WebCoreFrameBridge installInFrame:].
        (-[WebFrameView _setCustomScrollViewClass:]): Used early return idiom so the entire
        method isn't nested inside an if statement. Call
        -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
        * WebView/WebFrameViewInternal.h: Added declaration of _install method so it can be
        used in WebFrameLoaderClient.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:20:16 +0000 (15:20 +0000)]
WebCore:

        Reviewed by Adam.

        - remove WebCoreFrameBridge window method

        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): Get the window by calling
        window on the NSView instead of using the bridge. The WebKit side wasn't doing anything
        special, so a call to -[NSView window] is fine.

        * page/mac/WebCoreFrameBridge.h: Removed the window method.

WebKit/mac:

        Reviewed by Adam.

        - remove WebCoreFrameBridge window method

        * WebCoreSupport/WebFrameBridge.mm: Removed window method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
darin@apple.com [Tue, 4 Mar 2008 15:17:35 +0000 (15:17 +0000)]
    Reviewed by Adam.

        - move code from WebFrameBridge into WebFrameLoaderClient

        * WebCoreSupport/WebFrameBridge.h: Removed unused fields, changed frame name parameters
        to use WebCore::String instead of NSString, add initSubframeWithOwnerElement declaration,
        removed viewForPluginWithFrame, viewForJavaAppletWithFrame, createChildFrameNamed,
        redirectDataToPlugin, determineObjectFromMIMEType, and windowObjectCleared methods.
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
        Changed to use WebCore::String.
        (-[WebFrameBridge initMainFrameWithPage:frameName:WebCore::frameView:]): Ditto.
        (-[WebFrameBridge initSubframeWithOwnerElement:frameName:WebCore::frameView:]): Ditto.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::setOriginalURLForDownload): Removed some dead code I found here
        and added a FIXME.
        (WebFrameLoaderClient::createFrame): Moved the code from WebFrameBridge here.
        (WebFrameLoaderClient::objectContentType): Ditto.
        (parameterValue): Added.  Helper function, based on code originally in WebFrameBridge.
        (pluginView): Ditto.
        (WebFrameLoaderClient::createPlugin): Moved the code from WebFrameBridge here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:10:30 +0000 (15:10 +0000)]
WebCore:

        Reviewed by Adam.

        - remove -[WebCoreFrameBridge dashboardRegionsChanged:]

        * WebCore.base.exp: Updated.
        * page/Chrome.cpp:
        (WebCore::ChromeClient::dashboardRegionsChanged): Added.
        * page/ChromeClient.h: Added virtual function for dashboardRegionsChanged.
        * page/Frame.h: Removed dashboardRegionsChanged function.
        * page/FrameView.cpp:
        (WebCore::FrameView::updateDashboardRegions): Changed to call dashboardRegionsChanged
        on ChromeClient and to only call it when the regions actually changed.
        * page/mac/FrameMac.mm: Removed dashboardRegionsChanged function.
        * page/mac/WebCoreFrameBridge.h: Removed dashboardRegionsChanged: method.

WebKit/mac:

        Reviewed by Adam.

        - remove -[WebCoreFrameBridge dashboardRegionsChanged:]

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::dashboardRegionsChanged): Moved code here from the bridge.
        The WebCore side now calls this only when there's an actual change.
        * WebCoreSupport/WebFrameBridge.h: Removed lastDashboardRegions.
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge dealloc]): Removed code to release lastDashboardRegions.
        Removed _compareDashboardRegions: and dashboardRegionsChanged: methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 4 Mar 2008 15:07:48 +0000 (15:07 +0000)]
WebCore:

        Reviewed by Adam.

        - remove WebCoreFrameBridge issuePasteComand method

        * editing/Editor.cpp:
        (WebCore::Editor::paste): Moved the Mac-specific part of this to EditorMac.
        * editing/mac/EditorMac.mm:
        (WebCore::Editor::paste): Added. Calls paste: on the document view (normally a
        WebHTMLView). We should get rid of this eventually.
        * page/Frame.h: Removed issuePasteCommand.
        * page/mac/FrameMac.mm: Ditto.
        * page/mac/WebCoreFrameBridge.h: Ditto.

WebKit/mac:

        Reviewed by Adam.

        - remove WebCoreFrameBridge issuePasteComand method

        * WebCoreSupport/WebFrameBridge.mm: Removed issuePasteCommand method.
        * WebView/WebHTMLViewInternal.h: Removed declaration of paste: method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Suggested by Darin, rubber-stamped by Mark.
ap@webkit.org [Tue, 4 Mar 2008 09:11:35 +0000 (09:11 +0000)]
    Suggested by Darin, rubber-stamped by Mark.

        http://bugs.webkit.org/show_bug.cgi?id=17569
        REGRESSION (r30571): Buzzword.com doesn't load

        Rolling out r30571, as determining what is wrong with it proved tricky.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::tokenizerProcessedData):
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-04 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Tue, 4 Mar 2008 08:25:26 +0000 (08:25 +0000)]
2008-03-04  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Add a note about preferring if over else if when the previous if is terminated by a return statement.

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
weinig@apple.com [Tue, 4 Mar 2008 08:11:50 +0000 (08:11 +0000)]
    Build fix.

        * bindings/js/kjs_events.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Tue, 4 Mar 2008 07:48:53 +0000 (07:48 +0000)]
WebCore:

        Reviewed by Mark Rowe.

        Move JSClipboard into its own file.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSAttrCustom.cpp:
        * bindings/js/JSClipboardCustom.cpp: Added.
        (WebCore::JSClipboard::types):
        (WebCore::JSClipboard::clearData):
        (WebCore::JSClipboard::getData):
        (WebCore::JSClipboard::setData):
        (WebCore::JSClipboard::setDragImage):
        * bindings/js/JSElementCustom.cpp:
        * bindings/js/JSEventCustom.cpp:
        * bindings/js/JSHTMLFrameElementCustom.cpp:
        * bindings/js/JSHTMLIFrameElementCustom.cpp:
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_window.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Clipboard.cpp:
        (WebCore::Clipboard::setDropEffect):
        (WebCore::Clipboard::setEffectAllowed):
        * dom/Clipboard.idl: Added.

LayoutTests:

        Reviewed by Mark Rowe.

        Update test results.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago GTK+ build fix.
weinig@apple.com [Tue, 4 Mar 2008 06:20:31 +0000 (06:20 +0000)]
    GTK+ build fix.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::windowObjectCleared):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix.
weinig@apple.com [Tue, 4 Mar 2008 05:33:13 +0000 (05:33 +0000)]
    Windows build fix.

        * WebFrame.cpp:
        (WebFrame::windowObjectCleared):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build-fix.
weinig@apple.com [Tue, 4 Mar 2008 05:05:16 +0000 (05:05 +0000)]
    Windows build-fix.

        * page/Chrome.cpp:
        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
weinig@apple.com [Tue, 4 Mar 2008 03:08:30 +0000 (03:08 +0000)]
    Reviewed by Darin Adler.

        Cleanup and plumbing in preparation for the great Window split.

        - Rename KJS::Window to WebCore::JSDOMWindowBase.
        - Remove KJS::Window::retrieve() and KJS::Window::retrieveWindow() and replace
          with the new toJSDOMWindow().
        - Remove KJS::Window::retrieveActive() and replace with explicit call to
          exec->dynamicGlobalObject() and toJSDOMWindow().

        * bindings/js/JSCustomVoidCallback.cpp:
        (WebCore::toVoidCallback):.
        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::create):
        * bindings/js/JSDatabaseCustom.cpp:
        (WebCore::JSDatabase::changeVersion):
        (WebCore::JSDatabase::transaction):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::location):
        (WebCore::toJS):
        * bindings/js/JSEventTargetBase.cpp:
        (WebCore::jsEventTargetAddEventListener):
        (WebCore::jsEventTargetRemoveEventListener):
        * bindings/js/JSEventTargetNode.cpp:
        (WebCore::JSEventTargetNode::setListener):
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::nameGetter):
        (WebCore::JSHTMLDocument::open):
        * bindings/js/JSHTMLFrameSetElementCustom.cpp:
        (WebCore::JSHTMLFrameSetElement::nameGetter):
        * bindings/js/JSLocation.cpp:
        (WebCore::JSLocation::put):
        (WebCore::jsLocationProtoFuncReplace):
        (WebCore::jsLocationProtoFuncReload):
        (WebCore::jsLocationProtoFuncAssign):
        * bindings/js/JSLocation.h:
        * bindings/js/JSSQLTransactionCustom.cpp:
        (WebCore::JSSQLTransaction::executeSql):
        * bindings/js/JSSVGLazyEventListener.cpp:
        (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener):
        (WebCore::JSSVGLazyEventListener::eventParameterName):
        * bindings/js/JSSVGLazyEventListener.h:
        * bindings/js/JSXMLHttpRequest.cpp:
        (WebCore::JSXMLHttpRequest::putValueProperty):
        (WebCore::jsXMLHttpRequestPrototypeFunctionOpen):
        (WebCore::jsXMLHttpRequestPrototypeFunctionAddEventListener):
        (WebCore::jsXMLHttpRequestPrototypeFunctionRemoveEventListener):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScheduledAction.h:
        * bindings/js/kjs_binding.cpp:
        (WebCore::allowsAccessFromFrame):
        (WebCore::printErrorMessageForFrame):
        * bindings/js/kjs_events.cpp:
        (WebCore::JSAbstractEventListener::handleEvent):
        (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
        (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
        (WebCore::JSUnprotectedEventListener::windowObj):
        (WebCore::JSEventListener::JSEventListener):
        (WebCore::JSEventListener::~JSEventListener):
        (WebCore::JSEventListener::windowObj):
        (WebCore::JSLazyEventListener::JSLazyEventListener):
        (WebCore::JSLazyEventListener::parseCode):
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_navigator.cpp:
        (WebCore::MimeType::getValueProperty):
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::evaluate):
        (WebCore::KJSProxy::createHTMLEventHandler):
        (WebCore::KJSProxy::createSVGEventHandler):
        * bindings/js/kjs_window.cpp:
        (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate):
        (WebCore::DOMWindowTimer::DOMWindowTimer):
        (WebCore::DOMWindowTimer::action):
        (WebCore::DOMWindowTimer::takeAction):
        (WebCore::):
        (WebCore::JSDOMWindowBase::JSDOMWindowBase):
        (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
        (WebCore::JSDOMWindowBase::location):
        (WebCore::JSDOMWindowBase::mark):
        (WebCore::allowPopUp):
        (WebCore::createWindow):
        (WebCore::showModalDialog):
        (WebCore::JSDOMWindowBase::getValueProperty):
        (WebCore::JSDOMWindowBase::childFrameGetter):
        (WebCore::JSDOMWindowBase::indexGetter):
        (WebCore::JSDOMWindowBase::namedItemGetter):
        (WebCore::JSDOMWindowBase::getOwnPropertySlot):
        (WebCore::JSDOMWindowBase::put):
        (WebCore::JSDOMWindowBase::allowsAccessFrom):
        (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
        (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
        (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
        (WebCore::JSDOMWindowBase::printErrorMessage):
        (WebCore::JSDOMWindowBase::globalExec):
        (WebCore::JSDOMWindowBase::shouldInterruptScript):
        (WebCore::JSDOMWindowBase::setListener):
        (WebCore::JSDOMWindowBase::getListener):
        (WebCore::JSDOMWindowBase::findJSEventListener):
        (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
        (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
        (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
        (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
        (WebCore::JSDOMWindowBase::clear):
        (WebCore::JSDOMWindowBase::setCurrentEvent):
        (WebCore::JSDOMWindowBase::currentEvent):
        (WebCore::windowProtoFuncAToB):
        (WebCore::windowProtoFuncBToA):
        (WebCore::windowProtoFuncOpen):
        (WebCore::windowProtoFuncSetTimeout):
        (WebCore::windowProtoFuncClearTimeout):
        (WebCore::windowProtoFuncSetInterval):
        (WebCore::windowProtoFuncAddEventListener):
        (WebCore::windowProtoFuncRemoveEventListener):
        (WebCore::windowProtoFuncShowModalDialog):
        (WebCore::windowProtoFuncNotImplemented):
        (WebCore::JSDOMWindowBase::setReturnValueSlot):
        (WebCore::JSDOMWindowBase::clearAllTimeouts):
        (WebCore::JSDOMWindowBase::installTimeout):
        (WebCore::JSDOMWindowBase::pauseTimeouts):
        (WebCore::JSDOMWindowBase::resumeTimeouts):
        (WebCore::JSDOMWindowBase::clearTimeout):
        (WebCore::JSDOMWindowBase::timerFired):
        (WebCore::JSDOMWindowBase::disconnectFrame):
        (WebCore::JSDOMWindowBase::jsEventListeners):
        (WebCore::JSDOMWindowBase::jsHTMLEventListeners):
        (WebCore::JSDOMWindowBase::jsUnprotectedEventListeners):
        (WebCore::JSDOMWindowBase::jsUnprotectedHTMLEventListeners):
        (WebCore::toJS):
        (WebCore::toJSDOMWindow):
        (WebCore::toJSDOMWindow):
        * bindings/js/kjs_window.h:
        (WebCore::JSDOMWindowBase::impl):
        (WebCore::JSDOMWindowBase::classInfo):
        (WebCore::JSDOMWindowBase::):
        * bindings/objc/DOMUtility.mm:
        (KJS::createDOMWrapper):
        * bindings/scripts/CodeGeneratorJS.pm:
        * history/CachedPage.cpp:
        (WebCore::CachedPage::CachedPage):
        (WebCore::CachedPage::restore):
        * page/Chrome.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
        * page/DOMWindow.idl:
        * page/Frame.cpp:
        (WebCore::Frame::~Frame):
        (WebCore::Frame::windowScriptNPObject):
        (WebCore::Frame::pageDestroyed):
        * page/InspectorController.cpp:
        (WebCore::inspectedWindow):
        * page/mac/FrameMac.mm:
        (WebCore::Frame::windowScriptObject):
        * page/mac/WebCoreFrameBridge.mm:
        (updateRenderingForBindings):
        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canAccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake ForInNode check for the timeout interrupt
oliver@apple.com [Tue, 4 Mar 2008 00:24:54 +0000 (00:24 +0000)]
Make ForInNode check for the timeout interrupt

Reviewed by Anders

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fixes after recent Frame-related changes.
kevino@webkit.org [Mon, 3 Mar 2008 23:08:53 +0000 (23:08 +0000)]
wx build fixes after recent Frame-related changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Mon, 3 Mar 2008 22:59:30 +0000 (22:59 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - make :first-letter apply to the first letter in normal flow, skipping
          floats and positioned objects

        Test: fast/css/first-letter-skip-out-of-flow.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter):

LayoutTests:

        Reviewed by Darin Adler.

        - test that :first-letter applies to the first letter in normal flow,
          skipping floats and positioned objects

        * fast/css/first-letter-skip-out-of-flow.html: Added.
        * platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.checksum: Added.
        * platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.png: Added.
        * platform/mac/fast/css/first-letter-skip-out-of-flow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix build.
adachan@apple.com [Mon, 3 Mar 2008 22:58:34 +0000 (22:58 +0000)]
    Fix build.

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-03 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Mon, 3 Mar 2008 22:43:57 +0000 (22:43 +0000)]
2008-03-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Fix http://bugs.webkit.org/show_bug.cgi?id=17313
        Bug 17313: querySelectorAll() causing crashes when called via dojo.query() wrapper

        Node::querySelector and SelectorNodeList were not sufficiently initializing the CSSStyleSelector
        before using it to resolve styles, which lead to it having a stale m_style member in some situations.
        This stale m_style member resulted in a wild store that would write over whatever object now resided
        at the location m_style pointed to.

        Test: fast/dom/SelectorAPI/bug-17313.html

        * dom/Node.cpp:
        (WebCore::Node::querySelector): Call initForStyleResolve to further initialize the CSSStyleSelector.
        * dom/SelectorNodeList.cpp:
        (WebCore::SelectorNodeList::SelectorNodeList): Ditto.

2008-03-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Test for http://bugs.webkit.org/show_bug.cgi?id=17313
        Bug 17313: querySelectorAll() causing crashes when called via dojo.query() wrapper

        * fast/dom/SelectorAPI/bug-17313-expected.txt: Added.
        * fast/dom/SelectorAPI/bug-17313.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-03 Brent Fulgham <bfulgham@gmail.com>
alp@webkit.org [Mon, 3 Mar 2008 22:06:52 +0000 (22:06 +0000)]
2008-03-03  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=17644
        Build GTK on Mac OS X using native ICU library

        Use Apple native ICU libraries when building GTK
        webkit on Mac OS.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin and Sam.
andersca@apple.com [Mon, 3 Mar 2008 21:53:58 +0000 (21:53 +0000)]
    Reviewed by Darin and Sam.

        Include fixes, in preparation of using the headers in WebCore/bridge.

        * bindings/js/kjs_binding.h:
        * bindings/js/kjs_dom.cpp:
        * bindings/objc/DOMInternal.mm:
        * bindings/objc/DOMUtility.mm:
        * bindings/objc/WebScriptObject.mm:
        * bindings/objc/WebScriptObjectPrivate.h:
        * bridge/objc/objc_class.h:
        * bridge/objc/objc_instance.h:
        * bridge/objc/objc_runtime.h:
        * bridge/objc/objc_utility.h:
        * bridge/runtime.h:
        * bridge/runtime_object.h:
        * bridge/runtime_root.h:
        * html/HTMLAppletElement.cpp:
        * html/HTMLAppletElement.h:
        * html/HTMLEmbedElement.cpp:
        * html/HTMLEmbedElement.h:
        * html/HTMLObjectElement.cpp:
        * html/HTMLPlugInElement.cpp:
        * html/HTMLPlugInElement.h:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:
        * page/mac/WebCoreScriptDebugger.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Mon, 3 Mar 2008 21:18:22 +0000 (21:18 +0000)]
WebCore:

        Full page zoom plumbing.  Add a notion of whether or not a zoom is text only or a full zoom to the
        Frame.  setTextSizeMultiplier does a text only zoom.

        Reviewed by Tim H.

        * page/Frame.cpp:
        (WebCore::Frame::zoomFactor):
        (WebCore::Frame::isZoomFactorTextOnly):
        (WebCore::Frame::setZoomFactor):
        (WebCore::FramePrivate::FramePrivate):
        * page/Frame.h:
        * page/FramePrivate.h:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge setTextSizeMultiplier:]):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::setCurrentScale):

WebKit/win:

        Full page zoom work.  Make setting of a zoom factor take a boolean saying whether it is a text only
        or full page zoom.

        Reviewed by Tim H.

        * WebFrame.cpp:
        (WebFrame::setTextSizeMultiplier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-03 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 3 Mar 2008 20:03:16 +0000 (20:03 +0000)]
2008-03-03  Alp Toker  <alp@atoker.com>

        Fix the GTK+ build following breakage introduced in r30712.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::imContextCommitted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for <rdar://problem/5776161> REGRESSION: Google Docs Spreadsheet crash
hyatt@apple.com [Mon, 3 Mar 2008 19:51:59 +0000 (19:51 +0000)]
    Fix for <rdar://problem/5776161> REGRESSION: Google Docs Spreadsheet crash

        This is also http://bugs.webkit.org/show_bug.cgi?id=17543, fixed table layout corrupts heap.

        Make sure not to access position -1 of the size 0 vectors.

        Reviewed by ggaren

        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ddkilzer@apple.com [Mon, 3 Mar 2008 19:45:21 +0000 (19:45 +0000)]
WebCore:

        Dynamically inserting CSS rule with @media query fails with DOM Exception 12
        <http://bugs.webkit.org/show_bug.cgi?id=15986>

        Reviewed by Darin.

        Allow any valid rule (@font-face, @import, @media, @page or style) to be
        parsed when using CSSStyleSheet.insertRule().  Previously only import and
        style rules were allowed.  Note that @page rules always throw an exception
        because they're not implemented yet, so no test case was added for them.

        Tests: fast/css/insertRule-font-face.html
               fast/css/insertRule-media.html

        * css/CSSGrammar.y: Extracted 'valid_rule' out of 'rule'.  Renamed
        'ruleset_or_import' to 'valid_rule_or_import' and changed its definition.

LayoutTests:

        Dynamically inserting CSS rule with @media query fails with DOM Exception 12
        <http://bugs.webkit.org/show_bug.cgi?id=15986>

        Reviewed by Darin.

        * fast/css/insertRule-font-face.html: Added.
        * fast/css/insertRule-media.html: Added.
        * fast/css/resources/insertRule-font-face.js: Added.
        * fast/css/resources/insertRule-media.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Mon, 3 Mar 2008 19:43:29 +0000 (19:43 +0000)]
    Reviewed by Sam.

        Copy JSC bindings directory over to WebCore/bridge.

        * bridge: Copied from ../JavaScriptCore/bindings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
mitz@apple.com [Mon, 3 Mar 2008 18:56:20 +0000 (18:56 +0000)]
    Reviewed by Darin Adler.

        - remove CSSMutableStyleDeclaration::setChanged()'s change type
          parameter

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setChanged): Removed the change
        type parameter and made this function determine the correct change type
        based on whether this is an inline style declaration.
        (WebCore::CSSMutableStyleDeclaration::setProperty):
        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::clear): Removed this unused
        method.
        (WebCore::CSSMutableStyleDeclaration::setChanged): Made private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Mon, 3 Mar 2008 18:44:12 +0000 (18:44 +0000)]
WebCore:

        Reviewed by Adam.

        - some "cleanup" on the path to removing WebCoreFrameBridge

        * WebCore.base.exp: Exported some stuff we either already use or
        I am about to use in an upcoming patch.

        * WebCore.xcodeproj/project.pbxproj: Made FileChooser.h private rather
        than project, for future use in WebKit.

        * bindings/objc/WebScriptObject.mm: Removed some dead code.

        * dom/ContainerNode.cpp: Added a now-needed or soon-to-be-needed include.
        * editing/Editor.cpp: Ditto.

        * editing/Editor.h: Removed many unneeded declarations and includes.
        Removed the unused userVisibleString function.

        * editing/EditorCommand.cpp:
        (WebCore::executeYank): Added parameter for triggeringEvent, which no
        longer has a default value.
        (WebCore::executeYankAndSelect): Ditto.

        * editing/mac/EditorMac.mm: Removed userVisibleString.

        * page/mac/EventHandlerMac.mm:
        (WebCore::isKeyboardOptionTab): Tweaked formattin.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge dragSourceMovedTo:]): Get window from -[NSView window]
        rather than from the bridge. There's no special value in the bridge's window
        method and we can use NSView directly.
        (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): Ditto.

        * platform/graphics/mac/ImageMac.mm:
        (WebCore::Image::loadPlatformResource): Use a new WebCoreBundleFinder class to
        find the bundle rather than using WebCoreFrameBridge.

        * platform/mac/ClipboardMac.mm: Added a now-needed or soon-to-be-needed include.
        * platform/mac/PasteboardMac.mm: Ditto.

        * rendering/RenderObject.h:
        (WebCore::DashboardRegionValue::operator==): Fixed mistake where this wasn't
        comparing the clip rectangle.
        (WebCore::DashboardRegionValue::operator!=): Added. Needed by my future work.

WebKit/mac:

        Reviewed by Adam.

        - some "cleanup" on the path to removing WebCoreFrameBridge

        * Storage/WebDatabaseManager.mm: Tweak includes.
        * Storage/WebDatabaseTrackerClient.mm: Ditto.
        * Storage/WebSecurityOrigin.mm: Ditto.
        * Storage/WebSecurityOriginInternal.h: Ditto.

        * WebView/WebFrame.mm:
        (core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly
        match WebCore::EditableLinkBehavior.
        * WebView/WebFrameInternal.h: Removed unused kit function.

        * WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here.
        * WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here.
        * WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations.

        * WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 17620: getImageData lies
oliver@apple.com [Mon, 3 Mar 2008 09:34:49 +0000 (09:34 +0000)]
Bug 17620: getImageData lies
http://bugs.webkit.org/show_bug.cgi?id=17620

Reviewed by Mark Rowe

Correct logic to actually iterate over the source row

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCorrect incorrect assertion
oliver@apple.com [Mon, 3 Mar 2008 08:17:08 +0000 (08:17 +0000)]
Correct incorrect assertion

Reviewed by Mark Rowe

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-02 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 3 Mar 2008 05:34:58 +0000 (05:34 +0000)]
2008-03-02  Alp Toker  <alp@atoker.com>

        Another fix for non-database builds after changes in r30331.

        Conditionalize a stopDatabases() call.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Alp Toker.
kevino@webkit.org [Mon, 3 Mar 2008 05:29:38 +0000 (05:29 +0000)]
Reviewed by Alp Toker.

Scrolling fixes. Implement page scrolling, initialize mouse wheel event variables, and remove duplicate event binding for TOP scrolling event.

http://bugs.webkit.org/show_bug.cgi?id=17643

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-02 Brent Fulgham <bfulgham@gmail.com>
alp@webkit.org [Mon, 3 Mar 2008 05:10:18 +0000 (05:10 +0000)]
2008-03-02  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=17415
        GTK Build (using autotools) on Mac OS (DarwinPorts) Fails

        Add -lstdc++ to link flags for minidom program.  This corrects
        a build error for the GTK+ on Mac OS.

        Add ICU_CPPFLAGS earlier in include path for WebCore
        so that we find $(icu_cppflags)/unicode/utf8.h, rather than
        the wtf/unicode/UTF8.h on case-insensitive file systems.

        Remove some needless LIBS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-02 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 3 Mar 2008 05:02:38 +0000 (05:02 +0000)]
2008-03-02  Alp Toker  <alp@atoker.com>

        Fix building without database support after changes in r30331.

        * dom/Document.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fix for Windows after PageWin.cpp move.
kevino@webkit.org [Mon, 3 Mar 2008 03:16:05 +0000 (03:16 +0000)]
wx build fix for Windows after PageWin.cpp move.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Dave Hyatt.
kevino@webkit.org [Mon, 3 Mar 2008 02:02:28 +0000 (02:02 +0000)]
Reviewed by Dave Hyatt.

Gracefully handle a CSS rule containing an invalid value.
(Fixes http://bugs.webkit.org/show_bug.cgi?id=16898)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-02 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 2 Mar 2008 22:58:47 +0000 (22:58 +0000)]
2008-03-02  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Improve the Cairo Path::isEmpty() function

        Use cairo_has_current_point() where available.

        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::isEmpty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-02 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 2 Mar 2008 19:51:26 +0000 (19:51 +0000)]
2008-03-02  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Split the WebKit GTK+ build out of the WebCore build and change the
        shared object name to match the package name.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate Xcode configuration to support building debug and release from the mysterious...
mrowe@apple.com [Sun, 2 Mar 2008 07:08:59 +0000 (07:08 +0000)]
Update Xcode configuration to support building debug and release from the mysterious future.

Reviewed by Tim Hatcher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 16954: Support putImageData
oliver@apple.com [Sun, 2 Mar 2008 06:55:44 +0000 (06:55 +0000)]
Bug 16954: Support putImageData

Reviewed by Sam Weinig.

Implement support for HTML5's putImageData for the CG port.  All other ports
are currently just using stubs for the final blit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTypo fix.
kevino@webkit.org [Sun, 2 Mar 2008 02:13:44 +0000 (02:13 +0000)]
Typo fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-03-01 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sun, 2 Mar 2008 02:02:38 +0000 (02:02 +0000)]
2008-03-01  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        <rdar://problem/5772987> Crashing viewing page with two VLC plug-in
        instances

        The VLC Netscape plug-in crashes if more than one instance is created.

        Added a quirk that disallows a plug-in from having more than one
        instance and set this for the VLC plug-in.

        In addition, we now sort plug-ins that handle the same MIME
        type to choose the most appropriate one. This sorting first sorts by
        whether a plug-in has an issue that should put it at the end of the
        list, then whether it appears in a "preferred" plug-in directory.

        * plugins/PluginQuirkSet.h: Added PluginQuirkDontAllowMultipleInstances.
        * plugins/PluginDatabase.cpp:
        (WebCore::PluginDatabase::preferredPluginCompare): Comparator for
        sorting plug-ins; calls PluginPackage::compare().
        (WebCore::PluginDatabase::pluginForMIMEType): Add all of the plug-ins
        that handle this MIME type to a list, sort the list, and return the
        first item.
        (WebCore::PluginDatabase::MIMETypeForExtension): Add all of the plug-ins
        that handle this extension to a list, sort the list, and return the MIME
        type used by the plug-in at the beginning of the list.
        * plugins/PluginDatabase.h:
        * plugins/PluginPackage.h:
        (WebCore::PluginPackage::version): Added; returns the module version.
        * plugins/win/PluginDatabaseWin.cpp:
        (WebCore::PluginDatabase::isPreferredPluginPath): Made static; removed
        const.
        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackage::compare): Sorts plug-ins with known issues to
        the end, then plug-ins in preferred directories to the beginning, then
        alphabetically by file name, numerically by version, and alphabetically
        by parent directory.
        (WebCore::PluginPackage::determineQuirks): Set the "don't allow multiple
        instances" quirk for VLC.
        (WebCore::PluginPackage::load): Return false if the plug-in library has
        already been loaded and the "don't allow multiple instances" quirk is
        set.
        * platform/gtk/TemporaryLinkStubs.cpp:
        (PluginPackage::compare): Added stub.
        (PluginDatabase::IsPreferredPluginPath): Update the GTK stub.
        * platform/qt/TemporaryLinkStubs.cpp:
        (PluginPackage::compare): Added stub.
        (PluginDatabase::IsPreferredPluginPath): Update the Qt stub.
        * platform/wx/TemporaryLinkStubs.cpp:
        (PluginPackage::compare): Added stub.
        (PluginDatabase::IsPreferredPluginPath): Update the wx stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Mark Rowe.
weinig@apple.com [Sat, 1 Mar 2008 21:55:42 +0000 (21:55 +0000)]
    Rubber-stamped by Mark Rowe.

        Remove reference to the now non-existent bridge directory.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Sat, 1 Mar 2008 20:19:27 +0000 (20:19 +0000)]
WebCore:

        Reviewed by Darin Adler.

        Search the entire prototype chain when doing early prototype lookup in
        the Window's getOwnPropertySlot method.

        Makes fast/dom/Window/window-function-name-getter-precedence.html pass all tests.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::getOwnPropertySlot):

LayoutTests:

        Reviewed by Darin Adler.

        Update test result.

        * fast/dom/Window/window-function-name-getter-precedence-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Oliver.
zimmermann@webkit.org [Sat, 1 Mar 2008 13:46:29 +0000 (13:46 +0000)]
Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17568 (SVGForeignObjectElement can't react to width/height SVG DOM changes)
As the bug title says, fix all dynamic update problems that occour with SVGForeignObjectElement.

Tests: svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr.html
   svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr.html
   svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr.html
   svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr.html
   svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop.html
   svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop.html
   svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop.html
   svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by build-fix karma
beidson@apple.com [Sat, 1 Mar 2008 02:15:04 +0000 (02:15 +0000)]
    Reviewed by build-fix karma

        Bonehead mistake.  Revert function to previous version for all non-Windows+CFNetwork platforms

        * platform/network/ProtectionSpace.cpp:
        (WebCore::ProtectionSpace::receivesCredentialSecurely): Make my previous change conditionally

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate Tiger version of WebKitSystemInterface to match r30690.
mrowe@apple.com [Sat, 1 Mar 2008 02:01:57 +0000 (02:01 +0000)]
Update Tiger version of WebKitSystemInterface to match r30690.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark.
adele@apple.com [Sat, 1 Mar 2008 01:56:30 +0000 (01:56 +0000)]
    Reviewed by Mark.

        Auto-generate image arrays.

        * libWebKitSystemInterfaceLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
beidson@apple.com [Sat, 1 Mar 2008 01:50:32 +0000 (01:50 +0000)]
    Reviewed by Darin

        <rdar://problem/5771227> - Incorrect password handling text in credential sheet

        * platform/network/ProtectionSpace.cpp:
        (WebCore::ProtectionSpace::receivesCredentialSecurely): Call functional CFNetwork method to
          get "secureness" of the auth challenge instead of figuring it out ourselves

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Sam Weinig.
mitz@apple.com [Sat, 1 Mar 2008 01:35:09 +0000 (01:35 +0000)]
    Rubber-stamped by Sam Weinig.

        - update test results following r30649

        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-29 Brent Fulgham <bfulgham@gmail.com>
pewtermoose@webkit.org [Sat, 1 Mar 2008 00:29:22 +0000 (00:29 +0000)]
2008-02-29  Brent Fulgham  <bfulgham@gmail.com>
JavaScriptCore:

        http://bugs.webkit.org/show_bug.cgi?id=17483
        Implement scrollbars on Windows (Cairo)

        Reviewed by Adam Roben.

        * wtf/Platform.h:

WebCore:

        http://bugs.webkit.org/show_bug.cgi?id=17483
        Implement scrollbars on Windows (Cairo)

        Reviewed by Adam Roben.

        * platform/win/PlatfromScrollBarWin.cpp: Duplicate implementation
          from PlatformScrollBarWinSafari.cpp, then modify to use the
          native Windows theme engine.  Use SOFT_LINK.  Use platform
          'GetSystemMetrics' call to decide size of scrollbars and buttons.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Delete an unused file
aroben@apple.com [Sat, 1 Mar 2008 00:14:22 +0000 (00:14 +0000)]
    Delete an unused file

        Rubberstamped by Brady.

        * Interfaces/IWebScriptScope.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change WebPreferences to be backed by CFPreferences
aroben@apple.com [Sat, 1 Mar 2008 00:14:04 +0000 (00:14 +0000)]
    Change WebPreferences to be backed by CFPreferences

        Reviewed by Ada, Geoff, Steve, and Darin.

        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::sharedStandardPreferences): Changed to call
        setAutoSaves(TRUE) before calling load(). This ensures that the
        preferences being migrated to CFPreferences are saved to disk.
        (WebPreferences::valueForKey): Changed to return a RetainPtr to ensure
        that the refcount is managed properly. Now attempts to retrieve a
        value from CFPreferences before falling back to the default settings.
        (WebPreferences::setValueForKey): Now saves the value in
        CFPreferences if m_autoSaves is true.
        (WebPreferences::stringValueForKey): Updated for valueForKey changes.
        (WebPreferences::integerValueForKey): DItto.
        (WebPreferences::boolValueForKey): Ditto.
        (WebPreferences::floatValueForKey): Ditto.
        (WebPreferences::save): Now simply calls CFPreferencesAppSynchronize.
        (WebPreferences::load): Always initializes m_privatePrefs to an empty
        CFMutableDictionary.
        (WebPreferences::migrateWebKitPreferencesToCFPreferences): Migrates
        preferences from our old custom plist to CFPreferences and then
        deletes our custom plist, if the migration has never occurred before.
        (WebPreferences::copyWebKitPreferencesToCFPreferences): Copies
        preferences to CFPreferences. If we've never migrated the default
        settings from Safari 3 Beta before, we omit them from this copying
        procedure.
        * WebPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Refactor value <-> CFNumber conversions into some helper functions
aroben@apple.com [Sat, 1 Mar 2008 00:13:46 +0000 (00:13 +0000)]
    Refactor value <-> CFNumber conversions into some helper functions

        Reviewed by Jon.

        * WebPreferences.cpp:
        (preferencesPath): Changed to return a const String&.
        (numberValueForPreferencesValue): Converts a value from preferences to
        a native numeric type.
        (cfNumber): Converts a native numeric value to a CFNumberRef.
        (booleanValueForPreferencesValue): Converts a value from preferences
        to a native boolean.
        (WebPreferences::integerValueForKey): Changed to call
        numberValueForPreferencesValue.
        (WebPreferences::floatValueForKey): Ditto.
        (WebPreferences::boolValueForKey): Changed to call
        booleanValueForPreferencesValue.
        (WebPreferences::setIntegerValue): Changed to call cfNumber.
        (WebPreferences::setLongLongValue): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add WebPreferences::setValueForKey
aroben@apple.com [Sat, 1 Mar 2008 00:13:29 +0000 (00:13 +0000)]
    Add WebPreferences::setValueForKey

        This is just a small refactoring of some duplicated logic into a
        shared method.

        Reviewed by Sam.

        * WebPreferences.cpp:
        (WebPreferences::setValueForKey): Added.
        (WebPreferences::setStringValue): Call setValueForKey.
        (WebPreferences::setIntegerValue): Ditto.
        (WebPreferences::setBoolValue): Ditto.
        (WebPreferences::setLongLongValue): Ditto.
        * WebPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove WebPreferences' static members
aroben@apple.com [Sat, 1 Mar 2008 00:13:10 +0000 (00:13 +0000)]
    Remove WebPreferences' static members

        s_defaultSettings is now a file-level static, and
        s_standardPreferences has been removed completely (it wasn't being
        used).

        Reviewed by Sam.

        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::valueForKey):
        (WebPreferences::migrateDefaultSettingsFromSafari3Beta):
        (WebPreferences::removeValuesMatchingDefaultSettings):
        * WebPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix
aroben@apple.com [Sat, 1 Mar 2008 00:09:50 +0000 (00:09 +0000)]
    Windows build fix

        * WebCore.vcproj/WebCore.vcproj: Remove bridge/* from the include path
        and the post-build event, and add page/win to each. Also let VS have
        its way with the order of the files.
        * page/win/PageWin.cpp: Copied from bridge/win/PageWin.cpp in r30673
        * page/win/GlobalHistoryWin.cpp: Copied from
        bridge/win/GlobalHistoryWin.cpp in r30673

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Remove unused DebuggerImp::abort and DebuggerImp::aborted
aroben@apple.com [Fri, 29 Feb 2008 23:48:42 +0000 (23:48 +0000)]
    Remove unused DebuggerImp::abort and DebuggerImp::aborted

        Reviewed by Tim and Sam.

        * kjs/function_object.cpp:
        (KJS::FunctionObjectImp::construct):
        * kjs/internal.h:
        (KJS::DebuggerImp::DebuggerImp):
        * kjs/nodes.cpp:
        (KJS::Node::handleException):
        (KJS::FunctionBodyNodeWithDebuggerHooks::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
andersca@apple.com [Fri, 29 Feb 2008 23:45:39 +0000 (23:45 +0000)]
    Build fix.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by David Harrison.
ggaren@apple.com [Fri, 29 Feb 2008 23:08:42 +0000 (23:08 +0000)]
    Reviewed by David Harrison.

        Fixed <rdar://problem/5765063> TOT REGRESSION: Software Update crash in
        KJS::Collector::collect() (missing JSLock)

        * JSValueWrapper.cpp:
        (unprotectGlobalObject): Added missing JSLock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 22:47:54 +0000 (22:47 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        64-bit build fix.

        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::pathFromFont): Provide stub implementation of pathFromFont for 64-bit as
        FMGetATSFontRefFromFont is not available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix. Only declare pathFromFont in debug builds as it is unused in release...
mrowe@apple.com [Fri, 29 Feb 2008 22:27:56 +0000 (22:27 +0000)]
Build fix.  Only declare pathFromFont in debug builds as it is unused in release builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
andersca@apple.com [Fri, 29 Feb 2008 22:19:57 +0000 (22:19 +0000)]
    Reviewed by Adam.

        Copy the remaining files in bridge/ over to page/

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bridge: Removed.
        * bridge/AXObjectCache.h: Removed.
        * bridge/EditorClient.h: Removed.
        * bridge/GlobalHistory.h: Removed.
        * bridge/win: Removed.
        * bridge/win/FrameCGWin.cpp: Removed.
        * bridge/win/FrameCairoWin.cpp: Removed.
        * bridge/win/FrameWin.cpp: Removed.
        * bridge/win/FrameWin.h: Removed.
        * bridge/win/GlobalHistoryWin.cpp: Removed.
        * bridge/win/PageWin.cpp: Removed.
        * page/AXObjectCache.h: Copied from bridge/AXObjectCache.h.
        * page/EditorClient.h: Copied from bridge/EditorClient.h.
        * page/GlobalHistory.h: Copied from bridge/GlobalHistory.h.
        * page/win/FrameCGWin.cpp: Copied from bridge/win/FrameCGWin.cpp.
        * page/win/FrameCairoWin.cpp: Copied from bridge/win/FrameCairoWin.cpp.
        * page/win/FrameWin.cpp: Copied from bridge/win/FrameWin.cpp.
        * page/win/FrameWin.h: Copied from bridge/win/FrameWin.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-29 Robert Blaut <webkit@blaut.biz>
mrowe@apple.com [Fri, 29 Feb 2008 22:10:54 +0000 (22:10 +0000)]
2008-02-29  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17532
          Webkit imports styles from <link> element which doesn't have rel=stylesheet defined

        Test: fast/html/link-rel-stylesheet.html

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):

2008-02-29  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin Adler.

        - Tests for http://bugs.webkit.org/show_bug.cgi?id=17532
          Webkit imports styles from <link> element which doesn't have rel=stylesheet defined

        * fast/html/link-rel-stylesheet.html: Added.
        * fast/media/mq-simple-query-02.html:
        * fast/media/mq-width-absolute-02.html:
        * platform/mac/fast/html/link-rel-stylesheet-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 22:06:56 +0000 (22:06 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders Carlsson.

        Replace use of WKPathFromFont with implementation in terms of public API.

        * WebCore.base.exp: Remove unused symbol.
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::initFontData):
        (WebCore::pathFromFont): Implement pathFromFont in terms of public API.
        (WebCore::SimpleFontData::platformInit):
        * platform/mac/WebCoreSystemInterface.h: Remove unused symbol.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders Carlsson.

        Replace use of WKPathFromFont with implementation in terms of public API.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Remove unused symbol.

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders Carlsson.

        Replace use of WKPathFromFont with implementation in terms of public API.

        * WebKitSystemInterface.h:  Remove unused symbol.
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
andersca@apple.com [Fri, 29 Feb 2008 21:56:06 +0000 (21:56 +0000)]
    Reviewed by Adam.

        Move a bunch of files from bridge/mac to page/mac.

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac: Removed.
        * bridge/mac/AXObjectCacheMac.mm: Removed.
        * bridge/mac/GlobalHistoryMac.mm: Removed.
        * bridge/mac/WebCoreAXObject.h: Removed.
        * bridge/mac/WebCoreAXObject.mm: Removed.
        * bridge/mac/WebCoreScriptDebugger.h: Removed.
        * bridge/mac/WebCoreScriptDebugger.mm: Removed.
        * page/mac/AXObjectCacheMac.mm: Copied from bridge/mac/AXObjectCacheMac.mm.
        * page/mac/GlobalHistoryMac.mm: Copied from bridge/mac/GlobalHistoryMac.mm.
        * page/mac/WebCoreAXObject.h: Copied from bridge/mac/WebCoreAXObject.h.
        * page/mac/WebCoreAXObject.mm: Copied from bridge/mac/WebCoreAXObject.mm.
        * page/mac/WebCoreScriptDebugger.h: Copied from bridge/mac/WebCoreScriptDebugger.h.
        * page/mac/WebCoreScriptDebugger.mm: Copied from bridge/mac/WebCoreScriptDebugger.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for http://bugs.webkit.org/show_bug.cgi?id=17559, media query tests crash...
hyatt@apple.com [Fri, 29 Feb 2008 21:14:25 +0000 (21:14 +0000)]
    Fix for bugs.webkit.org/show_bug.cgi?id=17559, media query tests crashing under
        guard malloc.  Pass along the style selector so it can be accessed, since it has not yet
        been assigned into the document's member variable.

        Reviewed by aroben

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSRuleSet::addRulesFromSheet):
        * css/MediaQueryEvaluator.cpp:
        (WebCore::MediaQueryEvaluator::eval):
        * css/MediaQueryEvaluator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Don't free the VARIANT passed into Write, since it is an input parameter...
sfalken@apple.com [Fri, 29 Feb 2008 20:55:03 +0000 (20:55 +0000)]
    Don't free the VARIANT passed into Write, since it is an input parameter owned by the caller.
        Found via code inspection.

        Reviewed by Adam.

        * WebActionPropertyBag.cpp:
        (WebActionPropertyBag::Write):
        * WebElementPropertyBag.cpp:
        (WebElementPropertyBag::Write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Pass the correct configuration switch (--Debug|--Release) to build-testkjs.
ddkilzer@apple.com [Fri, 29 Feb 2008 19:11:22 +0000 (19:11 +0000)]
    Pass the correct configuration switch (--Debug|--Release) to build-testkjs.

        Reviewed by Dan.

        Originally broken in r26838.

        * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
        not local, unused @args variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago <rdar://problem/5755916> REGRESSION: Loading HTML5 spec is 5x slower on TOT...
hyatt@apple.com [Fri, 29 Feb 2008 18:58:06 +0000 (18:58 +0000)]
    <rdar://problem/5755916> REGRESSION: Loading HTML5 spec is 5x slower on TOT than in 3.0.4

        Improve the performance of dynamic sibling and CSS3 selectors so that there is no slowdown any more.
        Be more precise in terms of what nodes we mark dirty.

        Reviewed by Beth

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::checkSelector):
        * dom/Element.cpp:
        (WebCore::Element::recalcStyle):
        (WebCore::checkForSiblingStyleChanges):
        (WebCore::Element::childrenChanged):
        (WebCore::Element::finishParsingChildren):
        * rendering/RenderStyle.cpp:
        (WebCore::RenderStyle::RenderStyle):
        * rendering/RenderStyle.h:
        (WebCore::RenderStyle::childrenAffectedByPositionalRules):
        (WebCore::RenderStyle::childrenAffectedByDirectAdjacentRules):
        (WebCore::RenderStyle::setChildrenAffectedByDirectAdjacentRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Bug 15754: webarchive layout tests fail when WebKit directory path contains...
ddkilzer@apple.com [Fri, 29 Feb 2008 18:22:15 +0000 (18:22 +0000)]
    Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks

        <http://bugs.webkit.org/show_bug.cgi?id=15754>

        Reviewed by Geoff and Darin.

        We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
        then removing that path from all file:/// URLs in the WebArchive output so these tests
        would pass no matter where they were run.

        The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
        current working directory, but the WebArchive does not.  This left the current working
        directory in all file:/// URLs in the test output, and thus all tests failed, for any
        developer that used symlinks to get to their WebKit source directory.

        The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
        remove the current working directory path (no matter what it is) after "file://" but
        before "/LayoutTests/".

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
        current working directory as described above.
        (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
        calls to normalizeWebResourceURL().
        (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
        normalizeWebResourceURL() and convertWebResourceResponseToDictionary().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Fri, 29 Feb 2008 17:58:00 +0000 (17:58 +0000)]
    Reviewed by Darin.

        <rdar://problem/5766352> REGRESSION (r27151): XMLHttpRequest.abort() resets response status

        Test: http/tests/xmlhttprequest/status-after-abort.html

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::getStatus):
        (WebCore::XMLHttpRequest::getStatusText):
        Changed to match Firefox more closely (IE just raises an exception in most of those cases).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Fri, 29 Feb 2008 17:28:13 +0000 (17:28 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix a bug where explicit embedding past the end of a line could
          affect text that line

        Test: fast/text/embed-at-end-of-pre-wrap-line.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::skipWhitespace): Removed calls to
        setAdjustEmbedding().
        (WebCore::RenderBlock::findNextLineBreak): Added calls to
        setAdjustEmbedding() around skipWhitespace() only where needed.

LayoutTests:

        Reviewed by Darin Adler.

        - test for a bug where explicit embedding past the end of a line could
          affect text that line

        * fast/text/embed-at-end-of-pre-wrap-line.html: Added.
        * platform/mac-leopard/fast/text/embed-at-end-of-pre-wrap-line-expected.checksum: Added.
        * platform/mac-leopard/fast/text/embed-at-end-of-pre-wrap-line-expected.png: Added.
        * platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 11:26:10 +0000 (11:26 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.

        * Misc/WebNSURLExtras.mm:
        (-[NSURL _webkit_canonicalize]):
        * WebKit.order:

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 11:25:55 +0000 (11:25 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.

        * platform/mac/WebCoreSystemInterface.h: Don't declare WKSupportsMultipartXMixedReplace on Leopard.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.
        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't call WKSupportsMultipartXMixedReplace on Leopard.
        * WebCore.Tiger.exp: Move Tiger-only symbol here.
        * WebCore.base.exp:

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 11:25:31 +0000 (11:25 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.

        * Misc/WebNSViewExtras.m:  Remove _web_superviewOfClass:stoppingAtClass:.
        * Misc/WebNSWindowExtras.m:  Remove _webkit_displayThrottledWindows.
        * Misc/WebSearchableTextView.m:  Remove selectionImageForcingWhiteText:.
        * WebCoreSupport/WebImageRendererFactory.m:  Update comment to mention the last version of Safari that
        requires this class.
        * WebInspector/WebInspector.mm:  Remove sharedWebInspector and update comments to mention the last version
        of Safari that calls other obsolete methods.
        * WebView/WebDocumentPrivate.h:  Remove selectionImageForcingWhiteText:.
        * WebView/WebHTMLView.mm:  Ditto.
        * WebView/WebPDFView.mm:  Ditto.
        * WebView/WebView.mm:  Update comment to mentoin the last version of Safari that requires the obsolete method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 09:23:24 +0000 (09:23 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Eric Seidel.

        Remove unneeded includes of WebCoreSystemInterface.h.

        * loader/mac/LoaderNSURLExtras.m:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.mm:
        * platform/MIMETypeRegistry.cpp:
        * platform/graphics/mac/ImageMac.mm:
        * platform/mac/PasteboardMac.mm:

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Eric Seidel.

        Remove unneeded includes of WebKitSystemInterface.h.

        * History/WebHistoryItem.mm:
        * Misc/WebNSViewExtras.m:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebDataSource.mm:
        * WebView/WebPDFView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-29 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 09:05:03 +0000 (09:05 +0000)]
2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt and Oliver Hunt.

        <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.

        * platform/mac/SystemTimeMac.cpp:  Replace use of WKSecondsSinceLastInputEvent with CGEventSourceSecondsSinceLastEventType.
        * platform/mac/WebCoreSystemInterface.h:  Remove unused symbol.
        * platform/mac/WebCoreSystemInterface.mm:  Ditto.
        * WebCore.base.exp:  Ditto.

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt and Oliver Hunt.

        <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):  Remove unused symbol.
        * WebKit.order:  Ditto.

2008-02-29  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt and Oliver Hunt.

        <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.

        * WebKitSystemInterface.h:  Remove unused symbol.
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-28 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 07:54:45 +0000 (07:54 +0000)]
2008-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Remove two unused functions from WebKitSystemInterface.

        * WebKitSystemInterface.h:  Remove WKPreferRGB32Key and WKGetDefaultGlyphForChar as they are unused. Also remove
        a duplicate declaration of WKSecondsSinceLastInputEvent.
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-28 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 29 Feb 2008 06:19:22 +0000 (06:19 +0000)]
2008-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dave Hyatt.

        Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

        * DerivedSources.make:  Add Tiger-only symbols to the export file when running on Tiger.
        * WebCore.Tiger.exp:  Added.  Move Tiger-only symbol here from WebCore.base.exp.
        * WebCore.base.exp:
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit):  Use Leopard APIs when building on Leopard.
        * platform/mac/WebCoreSystemInterface.h:  Don't declare wkGetFontMetrics on Leopard as it is unused.
        * platform/mac/WebCoreSystemInterface.mm:  Ditto.

2008-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dave Hyatt.

        Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

        * WebKitSystemInterface.h:  Only declare WKGetFontMetrics on Tiger.
        * libWebKitSystemInterfaceLeopard.a:  Update for removal of WKGetFontMetrics.

2008-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dave Hyatt.

        Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
pewtermoose@webkit.org [Thu, 28 Feb 2008 23:11:49 +0000 (23:11 +0000)]
    Reviewed by Tim Hatcher.

        Bug 16535: Stylesheets loaded with @import are not editable
        http://bugs.webkit.org/show_bug.cgi?id=16535
        <rdar://problem/5712899>

        Sheets loaded using @import were incorrectly being flagged as non-editable
        user agent sheets because their parent sheet doesn't have an ownerNode. We now
        check to make sure sheets also don't have a href before restricting their editability.

        * page/inspector/StylesSidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoffrey Garen.
ggaren@apple.com [Thu, 28 Feb 2008 22:16:46 +0000 (22:16 +0000)]
    Reviewed by Geoffrey Garen.

        ** TOTAL **:          1.005x as fast    2867.6ms +/- 0.4%  2853.2ms +/- 0.3%    significant

        * kjs/nodes.cpp: Tell the compiler that exceptions are unexpected (for
        the sake of branch prediction and code organization).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-28 Rodney Dawes <dobey@wayofthemonkey.com>
pewtermoose@webkit.org [Thu, 28 Feb 2008 20:46:37 +0000 (20:46 +0000)]
2008-02-28  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Adam Roben.

        Copy PluginPackageWin.cpp to shared PluginPackage.cpp.
        Add PluginPackage.cpp to build configurations.
        Remove PluginPackage destructor from TemporaryLinkStubs.cpp.
        Use cross-platform pathGetFilename method.
        Remove platform-specific code from shared PluginPackage implementation.
        Remove shared code from PluginPackageWin.cpp.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCoreSources.bkl:
        * WebCore.vcproj/WebCore.vcproj:
        * platform/gtk/TemporaryLinkStubs.cpp:
        * platform/qt/TemporaryLinkStubs.cpp:
        * platform/wx/TemporaryLinkStubs.cpp:
        * plugins/PluginPackage.cpp:
        * plugins/win/PluginPackageWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justin.garcia@apple.com [Thu, 28 Feb 2008 20:42:27 +0000 (20:42 +0000)]
WebCore:

        Reviewed by Darin Adler.

        <rdar://problem/4930986> REGRESSION: Paste As Quotation pastes black text instead of blue

        Add a second style span at copy time to hold document default styles.  This helps us
        differentiate between those and user applied styles at paste time, where we'll want
        to let Mail's Paste As Quotation blockquote override document default styles, but
        not others.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed the unit type used
        for -webkit-text-stroke-width from CSS_NUMBER to CSS_PX, to match other properties that
        are thick | medium | thin | <length>.  Before, there was a mismatch between the unit
        type of -webkit-text-stroke-width property values in a CSSComputedStyleDeclaration for
        an element and that element's inlineStyleDecl(), causing identical values to always appear
        different to diff().
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Fixed.  Don't just change
        the class to an empty string, completely remove it, it's no longer needed.
        (WebCore::handleStyleSpansBeforeInsertion): Moved the optimization from doApply here.
        (WebCore::ReplaceSelectionCommand::handleStyleSpans):
        Added, replaces removeRedundantStyles.
        We aren't (yet) removing all redundant styles, just those on style spans, so I removed the
        unused code and renamed the function.
        There won't be more than two style spans that we need to consider, the one with the
        source document's default styles and styles on the commonAncestor of the copied Range,
        so don't look for more than two.
        Let elements that wrap the incoming fragment override the source document's styles.
        (WebCore::ReplaceSelectionCommand::doApply): Moved code to handleStyleSpansBeforeInsertion
        and call the renamed handleStyleSpans.
        * editing/ReplaceSelectionCommand.h:
        * editing/markup.cpp:
        (WebCore::removeDefaultStyles): Added.  Don't add document defaults to the style span
        that holds user applied styles, since they'll be added to their own style span.
        (WebCore::createMarkup):
        Add a second style span that holds just the document defaults. This lets us differentiate
        between those and user applied styles at paste time.
        Mail blockquotes are just another type of special element, moved their handling there. This
        also lets paste code make assumptions about the position of the two style spans (they are
        *always* parent-child).

LayoutTests:

        Reviewed by Darin Adler.

        <rdar://problem/4930986> REGRESSION: Paste As Quotation pastes black text instead of blue

        Demonstrates the bug:
        * editing/pasteboard/4930986-1-expected.txt: Added.
        * editing/pasteboard/4930986-1.html: Added.
        * editing/pasteboard/4930986-2-expected.txt: Added.
        * editing/pasteboard/4930986-2.html: Added.

        Demonstrates a problem with the first version of the patch:
        * editing/pasteboard/4930986-3-expected.txt: Added.
        * editing/pasteboard/4930986-3.html: Added.

        Visual problem fixed.  An anonymous renderer changed position, DOM remains unchanged:
        * editing/execCommand/5144139-1.html:
        * platform/mac/editing/execCommand/5144139-1-expected.checksum:
        * platform/mac/editing/execCommand/5144139-1-expected.png:
        * platform/mac/editing/execCommand/5144139-1-expected.txt:

        Removed unnecessary style spans, visual result unchanged:
        * platform/mac/editing/pasteboard/merge-end-blockquote-expected.checksum:
        * platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
        * platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
        * platform/mac/editing/style/font-family-with-space-expected.checksum:
        * platform/mac/editing/style/font-family-with-space-expected.png:
        * platform/mac/editing/style/font-family-with-space-expected.txt:

        A style span isn't removed because at paste time because we don't anticipate
        encountering styles on style spans that are non-inheritable, because we don't
        create style spans like that at copy time. Turned this into a text only
        test. Test remains visually unchanged:
        * editing/pasteboard/5245519-expected.txt: Added.
        * editing/pasteboard/5245519.html:
        * platform/mac/editing/pasteboard/5245519-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/5245519-expected.png: Removed.
        * platform/mac/editing/pasteboard/5245519-expected.txt: Removed.

        Added an extra empty anonymous renderer, DOM and visual result remain unchanged:
        * platform/mac/editing/execCommand/create-list-with-hr-expected.checksum:
        * platform/mac/editing/execCommand/create-list-with-hr-expected.png:
        * platform/mac/editing/execCommand/create-list-with-hr-expected.txt:
        * platform/mac/editing/pasteboard/paste-list-001-expected.checksum:
        * platform/mac/editing/pasteboard/paste-list-001-expected.png:
        * platform/mac/editing/pasteboard/paste-list-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-table-001-expected.checksum:
        * platform/mac/editing/pasteboard/paste-table-001-expected.png:
        * platform/mac/editing/pasteboard/paste-table-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-003-expected.checksum:
        * platform/mac/editing/pasteboard/paste-text-003-expected.png:
        * platform/mac/editing/pasteboard/paste-text-003-expected.txt:

        Reflects changes to CSSComputedStyleDeclaration::getPropertyCSSValue:
        * fast/css/computed-style-expected.txt:
        * fast/css/computed-style-without-renderer-expected.txt:

        We don't remove styles from style spans that are overridden by all of their
        children, even though they are unnecessary. We've never done this, but now
        that there can be two style spans at paste time we are more likely to have
        a style span left over because of this problem.  Mentioned this in the test
        case and turned this into a text only test:
        * editing/pasteboard/4840662.html:
        * editing/pasteboard/4840662-expected.txt: Added.
        * platform/mac/editing/pasteboard/4840662-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/4840662-expected.png: Removed.
        * platform/mac/editing/pasteboard/4840662-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30649 268f45cc-cd09-0410-ab3c-d52691b4dbfc