WebKit-https.git
10 years ago2011-03-28 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 28 Mar 2011 19:32:19 +0000 (19:32 +0000)]
2011-03-28  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
        https://bugs.webkit.org/show_bug.cgi?id=52629

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
        QWebPage::repaintRequested() use a Qt::QueuedConnection.

        * tests/qwebpage/tst_qwebpage.cpp:
        (RepaintRequestedRenderer::RepaintRequestedRenderer):
        (RepaintRequestedRenderer::onRepaintRequested):
        (tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
        QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
        doesn't cause recursive signal emissions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 28 Mar 2011 19:10:52 +0000 (19:10 +0000)]
2011-03-28  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
        to link against WebKit.framework for now.

        * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unused CFErrorRef.
jeffm@apple.com [Mon, 28 Mar 2011 18:28:01 +0000 (18:28 +0000)]
Remove unused CFErrorRef.

Rubber-stamped by Adam Roben.

* Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::encodeResourceError): Remove unused CFErrorRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r82130): It made all tests crash (Requested by Ossy on #webkit).
oliver@apple.com [Mon, 28 Mar 2011 18:25:52 +0000 (18:25 +0000)]
REGRESSION(r82130): It made all tests crash (Requested by Ossy on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=57251

Build fix, had remnant of another patch in r82130

* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdChainList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Andrei Popescu <andreip@google.com>
andreip@google.com [Mon, 28 Mar 2011 18:17:08 +0000 (18:17 +0000)]
2011-03-28  Andrei Popescu  <andreip@google.com>

        Reviewed by Steve Block.

        V8IDBKeyCustom.cpp does not compile with INDEXED_DATABASE disabled
        https://bugs.webkit.org/show_bug.cgi?id=57100

        Close the ENABLE guard and the namespace in the right order.

        No new tests, just cleanup.

        * bindings/v8/custom/V8IDBAnyCustom.cpp:
        * bindings/v8/custom/V8IDBKeyCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Mon, 28 Mar 2011 18:16:18 +0000 (18:16 +0000)]
2011-03-28  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        Include certificate when sending a WebCore::ResourceError to UI process on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57195

        Rename wkGetSSLPeerCertificateData() to wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*, and
        implement wkGetSSLPeerCertificateData() to return a CFDataRef.  Add wkSetSSLPeerCertificateData() so
        WebCore::ResourceError can set the certificate in the user info dictionary.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
2011-03-28  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        Include certificate when sending a WebCore::ResourceError to UI process on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57195

        Rename callers of wkGetSSLPeerCertificateData() to use wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*.

        * WebError.cpp:
        (WebError::sslPeerCertificate):
        * WebURLResponse.cpp:
        (WebURLResponse::sslPeerCertificate):
2011-03-28  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        Include certificate when sending a WebCore::ResourceError to UI process on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57195

        Add support for tracking the certificate in WebCore::ResourceError.

        * platform/network/ResourceErrorBase.cpp:
        (WebCore::ResourceErrorBase::copy): Call platformCopy() to copy platform-specific fields.
        * platform/network/ResourceErrorBase.h:
        (WebCore::ResourceErrorBase::platformCopy): Added.
        * platform/network/cf/ResourceError.h: Added constructor that takes certificate data, shadowed platformCopy, added m_certificate.
        (WebCore::ResourceError::certificate): Added.
        * platform/network/cf/ResourceErrorCF.cpp:
        (WebCore::ResourceError::ResourceError): Added constructor that takes certificate data.
        (WebCore::ResourceError::platformLazyInit): Read any certificate from the userInfo dictionary.
        (WebCore::ResourceError::platformCopy): Copy m_certificate.
        (WebCore::ResourceError::cfError): Add any certificate data to the userInfo dictionary in the CFErrorRef.
2011-03-28  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        Include certificate when sending a WebCore::ResourceError to UI process on Windows
        https://bugs.webkit.org/show_bug.cgi?id=57195

        Add support for sending the certificate with the WebCore::ResourceError.

        * Shared/win/WebCoreArgumentCodersWin.cpp:
        (CoreIPC::encodeResourceError): Encode certificate data.
        (CoreIPC::deallocCertContext): Added.
        (CoreIPC::createCertContextDeallocator): Added.
        (CoreIPC::copyCert): Added.
        (CoreIPC::decodeResourceError): Decode certificate data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd an extra newline to the end of the generated Inspector.idl file so that it does not
jberlin@webkit.org [Mon, 28 Mar 2011 17:57:30 +0000 (17:57 +0000)]
Add an extra newline to the end of the generated Inspector.idl file so that it does not
trigger the Windows "no newline at at end of file" warning.

Rubber-stamped by Adam Roben.

* inspector/generate-inspector-idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Mon, 28 Mar 2011 17:49:41 +0000 (17:49 +0000)]
2011-03-28  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, added new GTK+ test expectations.

        * platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.checksum: Added.
        * platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.png: Added.
        * platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.txt: Added.
        * platform/gtk/fast/block/positioning/trailing-space-test-expected.checksum: Added.
        * platform/gtk/fast/block/positioning/trailing-space-test-expected.png: Added.
        * platform/gtk/fast/block/positioning/trailing-space-test-expected.txt: Added.
        * platform/gtk/fast/blockflow/fallback-orientation-expected.checksum: Added.
        * platform/gtk/fast/blockflow/fallback-orientation-expected.png: Added.
        * platform/gtk/fast/blockflow/fallback-orientation-expected.txt: Added.
        * platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.checksum: Added.
        * platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
        * platform/gtk/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
        * platform/gtk/svg/text/text-path-middle-align-expected.checksum: Added.
        * platform/gtk/svg/text/text-path-middle-align-expected.png: Added.
        * platform/gtk/svg/text/text-path-middle-align-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuildfix after r82125.
ossy@webkit.org [Mon, 28 Mar 2011 17:46:10 +0000 (17:46 +0000)]
Buildfix after r82125.

[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
https://bugs.webkit.org/show_bug.cgi?id=57087

* platform/graphics/qt/MediaPlayerPrivateQt.cpp: Convert all char* to QString explicitly.
(WebCore::MediaPlayerPrivateQt::getSupportedTypes):
(WebCore::MediaPlayerPrivateQt::commitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Mar 2011 17:29:44 +0000 (17:29 +0000)]
2011-03-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: fixed chromium build.

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgent::shouldInterruptForMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Sheriff Bot <webkit.review.bot@gmail.com>
pfeldman@chromium.org [Mon, 28 Mar 2011 17:19:52 +0000 (17:19 +0000)]
2011-03-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82099.
        http://trac.webkit.org/changeset/82099
        https://bugs.webkit.org/show_bug.cgi?id=57245

        Breaks live edits tests on chromium. (Requested by pfeldman on
        #webkit).

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._handleSave):
        (WebInspector.SourceFrameDelegate.prototype.editScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Mar 2011 17:16:52 +0000 (17:16 +0000)]
2011-03-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: brush up and rename debugger domain functions.
        https://bugs.webkit.org/show_bug.cgi?id=57240

        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::setBreakpointsActive):
        (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        (WebCore::InspectorDebuggerAgent::removeBreakpoint):
        (WebCore::InspectorDebuggerAgent::editScriptSource):
        (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        (WebCore::InspectorDebuggerAgent::failedToParseSource):
        (WebCore::InspectorDebuggerAgent::didPause):
        (WebCore::InspectorDebuggerAgent::didContinue):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.setBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
        (WebInspector.DebuggerModel.prototype.removeBreakpoint):
        (WebInspector.DebuggerModel.prototype._didEditScriptSource):
        (WebInspector.DebuggerDispatcher.prototype.paused):
        (WebInspector.DebuggerDispatcher.prototype.resumed):
        (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
        (WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):
        (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.toggleBreakpointsClicked):
        * inspector/front-end/inspector.js:
        (WebInspector.didCreateWorker):
        (WebInspector.didDestroyWorker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 28 Mar 2011 17:14:57 +0000 (17:14 +0000)]
2011-03-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        Add additional immediate types to allow us to distinguish the source of a JIT immediate
        https://bugs.webkit.org/show_bug.cgi?id=57190

        Allow us to distinguish whether a JIT immediate is a value that we
        control (TrustedImm32 and TrustedImmPtr) vs. ones that can be controlled
        or influenced by code we are compiling.  Currently we do nothing with this
        information -- this change is large and mechanical but would obscure any
        logic changes that we would have made.

        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
        (JSC::AbstractMacroAssembler::ImmPtr::ImmPtr):
        (JSC::AbstractMacroAssembler::TrustedImm32::TrustedImm32):
        (JSC::AbstractMacroAssembler::Imm32::Imm32):
        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::pop):
        (JSC::MacroAssembler::poke):
        (JSC::MacroAssembler::branchPtr):
        (JSC::MacroAssembler::branch32):
        (JSC::MacroAssembler::addPtr):
        (JSC::MacroAssembler::andPtr):
        (JSC::MacroAssembler::orPtr):
        (JSC::MacroAssembler::subPtr):
        (JSC::MacroAssembler::xorPtr):
        (JSC::MacroAssembler::setPtr):
        (JSC::MacroAssembler::storePtr):
        (JSC::MacroAssembler::branchTestPtr):
        (JSC::MacroAssembler::branchSubPtr):
        (JSC::MacroAssembler::branchTest8):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::add32):
        (JSC::MacroAssemblerARM::and32):
        (JSC::MacroAssemblerARM::lshift32):
        (JSC::MacroAssemblerARM::mul32):
        (JSC::MacroAssemblerARM::or32):
        (JSC::MacroAssemblerARM::rshift32):
        (JSC::MacroAssemblerARM::urshift32):
        (JSC::MacroAssemblerARM::sub32):
        (JSC::MacroAssemblerARM::xor32):
        (JSC::MacroAssemblerARM::store32):
        (JSC::MacroAssemblerARM::push):
        (JSC::MacroAssemblerARM::move):
        (JSC::MacroAssemblerARM::branch8):
        (JSC::MacroAssemblerARM::branch32):
        (JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords):
        (JSC::MacroAssemblerARM::branch16):
        (JSC::MacroAssemblerARM::branchTest8):
        (JSC::MacroAssemblerARM::branchTest32):
        (JSC::MacroAssemblerARM::branchAdd32):
        (JSC::MacroAssemblerARM::branchMul32):
        (JSC::MacroAssemblerARM::branchSub32):
        (JSC::MacroAssemblerARM::set32Compare32):
        (JSC::MacroAssemblerARM::set8Compare32):
        (JSC::MacroAssemblerARM::set32Test32):
        (JSC::MacroAssemblerARM::set32Test8):
        (JSC::MacroAssemblerARM::moveWithPatch):
        (JSC::MacroAssemblerARM::branchPtrWithPatch):
        (JSC::MacroAssemblerARM::storePtrWithPatch):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::add32):
        (JSC::MacroAssemblerARMv7::and32):
        (JSC::MacroAssemblerARMv7::lshift32):
        (JSC::MacroAssemblerARMv7::mul32):
        (JSC::MacroAssemblerARMv7::or32):
        (JSC::MacroAssemblerARMv7::rshift32):
        (JSC::MacroAssemblerARMv7::urshift32):
        (JSC::MacroAssemblerARMv7::sub32):
        (JSC::MacroAssemblerARMv7::xor32):
        (JSC::MacroAssemblerARMv7::load32):
        (JSC::MacroAssemblerARMv7::load32WithAddressOffsetPatch):
        (JSC::MacroAssemblerARMv7::load16):
        (JSC::MacroAssemblerARMv7::store32WithAddressOffsetPatch):
        (JSC::MacroAssemblerARMv7::store32):
        (JSC::MacroAssemblerARMv7::loadDouble):
        (JSC::MacroAssemblerARMv7::storeDouble):
        (JSC::MacroAssemblerARMv7::push):
        (JSC::MacroAssemblerARMv7::move):
        (JSC::MacroAssemblerARMv7::compare32):
        (JSC::MacroAssemblerARMv7::test32):
        (JSC::MacroAssemblerARMv7::branch32):
        (JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords):
        (JSC::MacroAssemblerARMv7::branch16):
        (JSC::MacroAssemblerARMv7::branch8):
        (JSC::MacroAssemblerARMv7::branchTest32):
        (JSC::MacroAssemblerARMv7::branchTest8):
        (JSC::MacroAssemblerARMv7::branchAdd32):
        (JSC::MacroAssemblerARMv7::branchMul32):
        (JSC::MacroAssemblerARMv7::branchSub32):
        (JSC::MacroAssemblerARMv7::nearCall):
        (JSC::MacroAssemblerARMv7::call):
        (JSC::MacroAssemblerARMv7::set32Compare32):
        (JSC::MacroAssemblerARMv7::set8Compare32):
        (JSC::MacroAssemblerARMv7::set32Test32):
        (JSC::MacroAssemblerARMv7::set32Test8):
        (JSC::MacroAssemblerARMv7::moveWithPatch):
        (JSC::MacroAssemblerARMv7::branchPtrWithPatch):
        (JSC::MacroAssemblerARMv7::storePtrWithPatch):
        (JSC::MacroAssemblerARMv7::tailRecursiveCall):
        (JSC::MacroAssemblerARMv7::makeJump):
        (JSC::MacroAssemblerARMv7::makeBranch):
        (JSC::MacroAssemblerARMv7::setupArmAddress):
        (JSC::MacroAssemblerARMv7::makeBaseIndexBase):
        (JSC::MacroAssemblerARMv7::moveFixedWidthEncoding):
        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::add32):
        (JSC::MacroAssemblerMIPS::and32):
        (JSC::MacroAssemblerMIPS::lshift32):
        (JSC::MacroAssemblerMIPS::mul32):
        (JSC::MacroAssemblerMIPS::or32):
        (JSC::MacroAssemblerMIPS::rshift32):
        (JSC::MacroAssemblerMIPS::urshift32):
        (JSC::MacroAssemblerMIPS::sub32):
        (JSC::MacroAssemblerMIPS::xor32):
        (JSC::MacroAssemblerMIPS::load32):
        (JSC::MacroAssemblerMIPS::load32WithAddressOffsetPatch):
        (JSC::MacroAssemblerMIPS::store32WithAddressOffsetPatch):
        (JSC::MacroAssemblerMIPS::store32):
        (JSC::MacroAssemblerMIPS::push):
        (JSC::MacroAssemblerMIPS::move):
        (JSC::MacroAssemblerMIPS::branch8):
        (JSC::MacroAssemblerMIPS::branch32):
        (JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords):
        (JSC::MacroAssemblerMIPS::branch16):
        (JSC::MacroAssemblerMIPS::branchTest32):
        (JSC::MacroAssemblerMIPS::branchTest8):
        (JSC::MacroAssemblerMIPS::branchAdd32):
        (JSC::MacroAssemblerMIPS::branchMul32):
        (JSC::MacroAssemblerMIPS::branchSub32):
        (JSC::MacroAssemblerMIPS::set8Compare32):
        (JSC::MacroAssemblerMIPS::set32Compare32):
        (JSC::MacroAssemblerMIPS::set32Test8):
        (JSC::MacroAssemblerMIPS::set32Test32):
        (JSC::MacroAssemblerMIPS::moveWithPatch):
        (JSC::MacroAssemblerMIPS::branchPtrWithPatch):
        (JSC::MacroAssemblerMIPS::storePtrWithPatch):
        (JSC::MacroAssemblerMIPS::tailRecursiveCall):
        (JSC::MacroAssemblerMIPS::loadDouble):
        (JSC::MacroAssemblerMIPS::storeDouble):
        (JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::add32):
        (JSC::MacroAssemblerX86::addWithCarry32):
        (JSC::MacroAssemblerX86::and32):
        (JSC::MacroAssemblerX86::or32):
        (JSC::MacroAssemblerX86::sub32):
        (JSC::MacroAssemblerX86::store32):
        (JSC::MacroAssemblerX86::branch32):
        (JSC::MacroAssemblerX86::moveWithPatch):
        (JSC::MacroAssemblerX86::branchPtrWithPatch):
        (JSC::MacroAssemblerX86::storePtrWithPatch):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::add32):
        (JSC::MacroAssemblerX86Common::and32):
        (JSC::MacroAssemblerX86Common::lshift32):
        (JSC::MacroAssemblerX86Common::mul32):
        (JSC::MacroAssemblerX86Common::or32):
        (JSC::MacroAssemblerX86Common::rshift32):
        (JSC::MacroAssemblerX86Common::urshift32):
        (JSC::MacroAssemblerX86Common::sub32):
        (JSC::MacroAssemblerX86Common::xor32):
        (JSC::MacroAssemblerX86Common::store32):
        (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
        (JSC::MacroAssemblerX86Common::push):
        (JSC::MacroAssemblerX86Common::move):
        (JSC::MacroAssemblerX86Common::branch8):
        (JSC::MacroAssemblerX86Common::branch32):
        (JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords):
        (JSC::MacroAssemblerX86Common::branch16):
        (JSC::MacroAssemblerX86Common::branchTest32):
        (JSC::MacroAssemblerX86Common::branchTest8):
        (JSC::MacroAssemblerX86Common::branchAdd32):
        (JSC::MacroAssemblerX86Common::branchMul32):
        (JSC::MacroAssemblerX86Common::branchSub32):
        (JSC::MacroAssemblerX86Common::set8Compare32):
        (JSC::MacroAssemblerX86Common::set32Compare32):
        (JSC::MacroAssemblerX86Common::set32Test8):
        (JSC::MacroAssemblerX86Common::set32Test32):
        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::add32):
        (JSC::MacroAssemblerX86_64::and32):
        (JSC::MacroAssemblerX86_64::or32):
        (JSC::MacroAssemblerX86_64::sub32):
        (JSC::MacroAssemblerX86_64::loadDouble):
        (JSC::MacroAssemblerX86_64::addDouble):
        (JSC::MacroAssemblerX86_64::convertInt32ToDouble):
        (JSC::MacroAssemblerX86_64::store32):
        (JSC::MacroAssemblerX86_64::call):
        (JSC::MacroAssemblerX86_64::tailRecursiveCall):
        (JSC::MacroAssemblerX86_64::makeTailRecursiveCall):
        (JSC::MacroAssemblerX86_64::addPtr):
        (JSC::MacroAssemblerX86_64::andPtr):
        (JSC::MacroAssemblerX86_64::orPtr):
        (JSC::MacroAssemblerX86_64::subPtr):
        (JSC::MacroAssemblerX86_64::xorPtr):
        (JSC::MacroAssemblerX86_64::storePtr):
        (JSC::MacroAssemblerX86_64::setPtr):
        (JSC::MacroAssemblerX86_64::branchPtr):
        (JSC::MacroAssemblerX86_64::branchTestPtr):
        (JSC::MacroAssemblerX86_64::branchSubPtr):
        (JSC::MacroAssemblerX86_64::moveWithPatch):
        (JSC::MacroAssemblerX86_64::branchPtrWithPatch):
        (JSC::MacroAssemblerX86_64::storePtrWithPatch):
        (JSC::MacroAssemblerX86_64::branchTest8):
        * dfg/DFGJITCodeGenerator.h:
        (JSC::DFG::JITCodeGenerator::callOperation):
        * dfg/DFGJITCompiler.cpp:
        (JSC::DFG::JITCompiler::jitAssertIsInt32):
        (JSC::DFG::JITCompiler::emitCount):
        * dfg/DFGJITCompiler.h:
        (JSC::DFG::JITCompiler::emitPutImmediateToCallFrameHeader):
        * dfg/DFGNonSpeculativeJIT.cpp:
        (JSC::DFG::NonSpeculativeJIT::compile):
        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::fillSpeculateCell):
        (JSC::DFG::SpeculativeJIT::compile):
        * jit/JIT.cpp:
        (JSC::JIT::emitTimeoutCheck):
        (JSC::JIT::privateCompile):
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        (JSC::JIT::emit_op_urshift):
        (JSC::JIT::emitSlow_op_urshift):
        (JSC::JIT::emit_op_post_inc):
        (JSC::JIT::emit_op_post_dec):
        (JSC::JIT::emit_op_pre_inc):
        (JSC::JIT::emit_op_pre_dec):
        (JSC::JIT::emit_op_mod):
        * jit/JITArithmetic32_64.cpp:
        (JSC::JIT::emit_op_negate):
        (JSC::JIT::emit_op_jnless):
        (JSC::JIT::emit_op_jless):
        (JSC::JIT::emit_op_jlesseq):
        (JSC::JIT::emit_op_lshift):
        (JSC::JIT::emitRightShift):
        (JSC::JIT::emitRightShiftSlowCase):
        (JSC::JIT::emit_op_bitand):
        (JSC::JIT::emit_op_bitor):
        (JSC::JIT::emit_op_bitxor):
        (JSC::JIT::emit_op_bitnot):
        (JSC::JIT::emit_op_post_inc):
        (JSC::JIT::emit_op_post_dec):
        (JSC::JIT::emitSlow_op_post_dec):
        (JSC::JIT::emit_op_pre_inc):
        (JSC::JIT::emit_op_pre_dec):
        (JSC::JIT::emit_op_add):
        (JSC::JIT::emitAdd32Constant):
        (JSC::JIT::emit_op_sub):
        (JSC::JIT::emitSub32Constant):
        (JSC::JIT::emitBinaryDoubleOp):
        (JSC::JIT::emit_op_mul):
        (JSC::JIT::emitSlow_op_mul):
        (JSC::JIT::emit_op_div):
        (JSC::JIT::emit_op_mod):
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::emit_op_ret_object_or_this):
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitPutCellToCallFrameHeader):
        (JSC::JIT::emitPutIntToCallFrameHeader):
        (JSC::JIT::emitPutImmediateToCallFrameHeader):
        (JSC::JIT::emitLoadCharacterString):
        (JSC::JIT::restoreArgumentReferenceForTrampoline):
        (JSC::JIT::checkStructure):
        (JSC::JIT::setSamplingFlag):
        (JSC::JIT::clearSamplingFlag):
        (JSC::JIT::emitCount):
        (JSC::JIT::sampleInstruction):
        (JSC::JIT::sampleCodeBlock):
        (JSC::JIT::emitStoreInt32):
        (JSC::JIT::emitStoreCell):
        (JSC::JIT::emitStoreBool):
        (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
        (JSC::JIT::emitInitRegister):
        (JSC::JIT::emitJumpIfJSCell):
        (JSC::JIT::emitJumpIfNotJSCell):
        (JSC::JIT::emitJumpIfImmediateInteger):
        (JSC::JIT::emitJumpIfNotImmediateInteger):
        (JSC::JIT::emitFastArithDeTagImmediate):
        (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
        (JSC::JIT::emitFastArithReTagImmediate):
        (JSC::JIT::emitTagAsBoolImmediate):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        (JSC::JIT::privateCompileCTINativeCall):
        (JSC::JIT::emit_op_check_has_instance):
        (JSC::JIT::emit_op_instanceof):
        (JSC::JIT::emit_op_ret_object_or_this):
        (JSC::JIT::emit_op_resolve):
        (JSC::JIT::emit_op_to_primitive):
        (JSC::JIT::emit_op_resolve_base):
        (JSC::JIT::emit_op_ensure_property_exists):
        (JSC::JIT::emit_op_resolve_skip):
        (JSC::JIT::emit_op_resolve_global):
        (JSC::JIT::emitSlow_op_resolve_global):
        (JSC::JIT::emit_op_not):
        (JSC::JIT::emit_op_jfalse):
        (JSC::JIT::emit_op_jeq_null):
        (JSC::JIT::emit_op_jneq_null):
        (JSC::JIT::emit_op_jneq_ptr):
        (JSC::JIT::emit_op_jsr):
        (JSC::JIT::emit_op_resolve_with_base):
        (JSC::JIT::emit_op_new_func_exp):
        (JSC::JIT::emit_op_jtrue):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        (JSC::JIT::emit_op_to_jsnumber):
        (JSC::JIT::emit_op_push_new_scope):
        (JSC::JIT::emit_op_catch):
        (JSC::JIT::emit_op_eq_null):
        (JSC::JIT::emit_op_neq_null):
        (JSC::JIT::emit_op_init_lazy_reg):
        (JSC::JIT::emit_op_convert_this):
        (JSC::JIT::emit_op_convert_this_strict):
        (JSC::JIT::emitSlow_op_not):
        (JSC::JIT::emitSlow_op_neq):
        (JSC::JIT::emit_op_get_arguments_length):
        (JSC::JIT::emitSlow_op_get_arguments_length):
        (JSC::JIT::emit_op_get_argument_by_val):
        (JSC::JIT::emitSlow_op_resolve_global_dynamic):
        (JSC::JIT::emit_op_new_regexp):
        (JSC::JIT::emit_op_load_varargs):
        (JSC::JIT::emitSlow_op_load_varargs):
        (JSC::JIT::emit_op_new_func):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        (JSC::JIT::privateCompileCTINativeCall):
        (JSC::JIT::emit_op_loop_if_lesseq):
        (JSC::JIT::emit_op_check_has_instance):
        (JSC::JIT::emit_op_instanceof):
        (JSC::JIT::emit_op_get_scoped_var):
        (JSC::JIT::emit_op_put_scoped_var):
        (JSC::JIT::emit_op_tear_off_activation):
        (JSC::JIT::emit_op_tear_off_arguments):
        (JSC::JIT::emit_op_resolve):
        (JSC::JIT::emit_op_to_primitive):
        (JSC::JIT::emit_op_resolve_base):
        (JSC::JIT::emit_op_ensure_property_exists):
        (JSC::JIT::emit_op_resolve_skip):
        (JSC::JIT::emit_op_resolve_global):
        (JSC::JIT::emitSlow_op_resolve_global):
        (JSC::JIT::emit_op_not):
        (JSC::JIT::emit_op_jfalse):
        (JSC::JIT::emit_op_jtrue):
        (JSC::JIT::emit_op_jeq_null):
        (JSC::JIT::emit_op_jneq_null):
        (JSC::JIT::emit_op_jneq_ptr):
        (JSC::JIT::emit_op_jsr):
        (JSC::JIT::emit_op_eq):
        (JSC::JIT::emitSlow_op_eq):
        (JSC::JIT::emit_op_neq):
        (JSC::JIT::emitSlow_op_neq):
        (JSC::JIT::compileOpStrictEq):
        (JSC::JIT::emit_op_eq_null):
        (JSC::JIT::emit_op_neq_null):
        (JSC::JIT::emit_op_resolve_with_base):
        (JSC::JIT::emit_op_new_func_exp):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        (JSC::JIT::emit_op_to_jsnumber):
        (JSC::JIT::emit_op_push_new_scope):
        (JSC::JIT::emit_op_catch):
        (JSC::JIT::emit_op_create_activation):
        (JSC::JIT::emit_op_create_arguments):
        (JSC::JIT::emit_op_convert_this):
        (JSC::JIT::emit_op_convert_this_strict):
        (JSC::JIT::emit_op_get_arguments_length):
        (JSC::JIT::emitSlow_op_get_arguments_length):
        (JSC::JIT::emit_op_get_argument_by_val):
        (JSC::JIT::softModulo):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::stringGetByValStubGenerator):
        (JSC::JIT::emit_op_get_by_val):
        (JSC::JIT::emitSlow_op_get_by_val):
        (JSC::JIT::emit_op_get_by_pname):
        (JSC::JIT::emit_op_put_by_val):
        (JSC::JIT::emit_op_put_by_index):
        (JSC::JIT::emit_op_put_getter):
        (JSC::JIT::emit_op_put_setter):
        (JSC::JIT::emit_op_del_by_id):
        (JSC::JIT::emit_op_get_by_id):
        (JSC::JIT::emit_op_put_by_id):
        (JSC::JIT::emit_op_method_check):
        (JSC::JIT::compileGetByIdHotPath):
        (JSC::JIT::compileGetByIdSlowCase):
        (JSC::JIT::emitSlow_op_put_by_id):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdSelfList):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::emit_op_put_getter):
        (JSC::JIT::emit_op_put_setter):
        (JSC::JIT::emit_op_del_by_id):
        (JSC::JIT::emit_op_get_by_id):
        (JSC::JIT::emit_op_put_by_id):
        (JSC::JIT::emit_op_method_check):
        (JSC::JIT::stringGetByValStubGenerator):
        (JSC::JIT::emit_op_get_by_val):
        (JSC::JIT::emitSlow_op_get_by_val):
        (JSC::JIT::emit_op_put_by_val):
        (JSC::JIT::compileGetByIdHotPath):
        (JSC::JIT::compileGetByIdSlowCase):
        (JSC::JIT::emitSlow_op_put_by_id):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdSelfList):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        (JSC::JIT::emit_op_get_by_pname):
        * jit/JITStubCall.h:
        (JSC::JITStubCall::addArgument):
        * jit/JITStubs.cpp:
        (JSC::getPolymorphicAccessStructureListSlot):
        (JSC::DEFINE_STUB_FUNCTION):
        * jit/JSInterfaceJIT.h:
        (JSC::JSInterfaceJIT::emitJumpIfNotJSCell):
        (JSC::JSInterfaceJIT::emitLoadInt32):
        (JSC::JSInterfaceJIT::emitLoadDouble):
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::SpecializedThunkJIT):
        (JSC::SpecializedThunkJIT::loadJSStringArgument):
        (JSC::SpecializedThunkJIT::tagReturnAsInt32):
        (JSC::SpecializedThunkJIT::tagReturnAsJSCell):
        * jit/ThunkGenerators.cpp:
        (JSC::charToString):
        (JSC::powThunkGenerator):
        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::matchCharacterClass):
        (JSC::Yarr::YarrGenerator::storeToFrame):
        (JSC::Yarr::YarrGenerator::storeToFrameWithPatch):
        (JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterSingle):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
        (JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
        (JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
        (JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
        (JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
        (JSC::Yarr::YarrGenerator::generateParenthesesSingle):
        (JSC::Yarr::YarrGenerator::generateDisjunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Windows 7 Release Tests] editing/spelling/spelling-backspace-between-lines.html...
jberlin@webkit.org [Mon, 28 Mar 2011 17:10:30 +0000 (17:10 +0000)]
[Windows 7 Release Tests] editing/spelling/spelling-backspace-between-lines.html fails.
https://bugs.webkit.org/show_bug.cgi?id=57243

Rubber-stamped by Adam Roben.

* platform/win/Skipped:
Remove the two tests that were removed in r71392.
Also, remove spelling-backspace-between-lines.html because it is not flakey and the
layoutTestController method is implemented on Windows, it just fails with this test.

* platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/57239> Use forward class declaration instead of including header
ddkilzer@apple.com [Mon, 28 Mar 2011 17:07:44 +0000 (17:07 +0000)]
<webkit.org/b/57239> Use forward class declaration instead of including header

Reviewed by Dan Bernstein.

Adding a "using namespace WebCore;" statement in a header may
cause issues when <WebCore/Length.h> is included before
<CoreText/CoreText.h>.

Length.h defines the LengthType enum with a 'Fixed' value.
CoreText.h includes MacTypes.h, which has a
"typedef SInt32 Fixed;" statement, and then CoreText.h includes
other headers that also use 'Fixed', but expect the typedef to
be defined, not the enum.  If another header includes
"using namespace WebCore;" before CoreText.h, the
following compiler errors result (paths abbreviated):

    CoreText.framework/Headers/SFNTLayoutTypes.h:689: error: reference to 'Fixed' is ambiguous
    MacTypes.h:184: error: candidates are: typedef SInt32 Fixed
    Length.h:37: error:                 WebCore::LengthType WebCore::Fixed
    SFNTLayoutTypes.h:689: error: 'Fixed' does not name a type

* platform/mac/HTMLConverter.h: Use forward declaration of
DocumentLoader class instead of including header.  Remove the
unused "using namespace WebCore;" statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 28 Mar 2011 17:01:21 +0000 (17:01 +0000)]
2011-03-26  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Introduce EventDispatcher, the new common way to fire events.
        https://bugs.webkit.org/show_bug.cgi?id=57168

        The goal here is two-fold:
        1) reduce the need to randomly sprinkle guards around the dispatch code
        by creating a well-scoped abstraction for dispatching events.
        2) create a place where fiddly event-related things like creating event
        contexts for ancestors can be done lazily.

        Additionally, with all the free-standing static functions, this code was
        just begging to come out of Node.cpp.

        The first step is a near-mechanical extraction of mouse-related events
        from Node.cpp to EventDispatcher. For now, the call sites are just
        replaced with invoking EventDispatcher. Later, we can remove these methods
        from Node.

        Refactoring, no functional changes.

        * Android.mk: Added EventDispatcher to build system.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * dom/DOMAllInOne.cpp: Ditto.
        * dom/EventDispatcher.cpp: Added.
        * dom/EventDispatcher.h: Added.
        * dom/Node.cpp:
        (WebCore::Node::dispatchScopedEvent): Replaced to use EventDispatcher.
        (WebCore::Node::dispatchEvent): Ditto.
        (WebCore::Node::dispatchMouseEvent): Ditto.
        (WebCore::Node::dispatchSimulatedClick): Ditto.
        * dom/Node.h: Updated decls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Windows 7 Release Tests] fast/blockflow/fallback-orientation.html failing since
jberlin@webkit.org [Mon, 28 Mar 2011 16:37:50 +0000 (16:37 +0000)]
[Windows 7 Release Tests] fast/blockflow/fallback-orientation.html failing since
introduction in r82056.
https://bugs.webkit.org/show_bug.cgi?id=57238

Unreviewed, add expected failing results, since vertical text is not yet implemented on
Windows, to get the bots green.

* platform/win/fast/blockflow/fallback-orientation-expected.checksum: Added.
* platform/win/fast/blockflow/fallback-orientation-expected.png: Added.
* platform/win/fast/blockflow/fallback-orientation-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Mon, 28 Mar 2011 16:29:08 +0000 (16:29 +0000)]
2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
        https://bugs.webkit.org/show_bug.cgi?id=57087

        Enable QT_ASCII_CAST_WARNINGS by default in webkit.pri to catch the errors early on.

        * Source/WebKit.pri:
2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
        https://bugs.webkit.org/show_bug.cgi?id=57087

        * QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
        * tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
        since they are applications, not libraries.
2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
        https://bugs.webkit.org/show_bug.cgi?id=57087

        Disable QT_ASCII_CAST_WARNINGS for applications.

        * DumpRenderTree/qt/DumpRenderTree.pro:
        * DumpRenderTree/qt/ImageDiff.pro:
        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
        * MiniBrowser/qt/MiniBrowser.pro:
        * QtTestBrowser/QtTestBrowser.pro:
        * WebKitTestRunner/qt/WebKitTestRunner.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Mon, 28 Mar 2011 16:24:02 +0000 (16:24 +0000)]
2011-03-28  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fullscreen tests failing after r82084
        https://bugs.webkit.org/show_bug.cgi?id=57219

        Unskipped some fullscreen tests passing now.

        * platform/gtk/Skipped:
2011-03-28  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fullscreen tests failing after r82084
        https://bugs.webkit.org/show_bug.cgi?id=57219

        Added the withKeyboard parameter to supportsFullScreenForElement
        method in ChromeClient. Fullscreen will be disabled for keyboard
        access by default.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::supportsFullScreenForElement):
        * WebCoreSupport/ChromeClientGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9003382> Incomplete repaint of overflow in flipped lines writing...
mitz@apple.com [Mon, 28 Mar 2011 16:17:07 +0000 (16:17 +0000)]
<rdar://problem/9003382> Incomplete repaint of overflow in flipped lines writing modes
https://bugs.webkit.org/show_bug.cgi?id=57197

Reviewed by Maciej Stachowiak.

Source/WebCore:

Tests: fast/repaint/overflow-flipped-writing-mode-block.html
       fast/repaint/overflow-flipped-writing-mode-table.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint): Flip the overflow rect before testing for intersection
with the damage rect.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::paint): Made the intersection check more like the one in
RenderBlock::paint().

LayoutTests:

* fast/repaint/overflow-flipped-writing-mode-block-expected.checksum: Added.
* fast/repaint/overflow-flipped-writing-mode-block-expected.png: Added.
* fast/repaint/overflow-flipped-writing-mode-block-expected.txt: Added.
* fast/repaint/overflow-flipped-writing-mode-block.html: Added.
* fast/repaint/overflow-flipped-writing-mode-table-expected.checksum: Added.
* fast/repaint/overflow-flipped-writing-mode-table-expected.png: Added.
* fast/repaint/overflow-flipped-writing-mode-table-expected.txt: Added.
* fast/repaint/overflow-flipped-writing-mode-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Mon, 28 Mar 2011 15:58:40 +0000 (15:58 +0000)]
2011-03-28  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, rebaseline GTK+ test results.

        * platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
        * platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
        * platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Mon, 28 Mar 2011 15:56:11 +0000 (15:56 +0000)]
2011-03-28  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Ryosuke Niwa.

        move directionOfEnclosingBlock() to be global so that it could be reused.
        https://bugs.webkit.org/show_bug.cgi?id=57233.

        Provide global function directionOfEnclosingBlock(Node*) so that it could be
        reused in SelectionController and other functionalities that need enclosing
        block's direcionality, such as moving caret by word in visual order.

        No new functionality, so no new tests.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::directionOfEnclosingBlock):
        * editing/htmlediting.cpp:
        (WebCore::directionOfEnclosingBlock):
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSet eol-style to native on more files. I noticed the last check-in had an entire...
darin@apple.com [Mon, 28 Mar 2011 15:48:11 +0000 (15:48 +0000)]
Set eol-style to native on more files. I noticed the last check-in had an entire file
changing because of an EOL style change, and setting this property prevents that from
happening in future. We may want to do this systematically for more of WebKit later.

* AccessibleBase.cpp: Added property svn:eol-style.
* AccessibleBase.h: Added property svn:eol-style.
* AccessibleDocument.cpp: Added property svn:eol-style.
* AccessibleDocument.h: Added property svn:eol-style.
* AccessibleImage.cpp: Added property svn:eol-style.
* AccessibleImage.h: Added property svn:eol-style.
* COMVariantSetter.h: Added property svn:eol-style.
* FullscreenVideoController.cpp: Added property svn:eol-style.
* FullscreenVideoController.h: Added property svn:eol-style.
* WebCoreSupport/EmbeddedWidget.cpp: Added property svn:eol-style.
* WebCoreSupport/EmbeddedWidget.h: Added property svn:eol-style.
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added property svn:eol-style.
* WebCoreSupport/WebDesktopNotificationsDelegate.h: Added property svn:eol-style.
* WebCoreSupport/WebFrameLoaderClient.cpp: Added property svn:eol-style.
* WebCoreSupport/WebInspectorDelegate.cpp: Added property svn:eol-style.
* WebCoreSupport/WebInspectorDelegate.h: Added property svn:eol-style.
* WebCoreSupport/WebPlatformStrategies.cpp: Added property svn:eol-style.
* WebCoreSupport/WebPlatformStrategies.h: Added property svn:eol-style.
* WebCoreSupport/WebPluginHalterClient.cpp: Added property svn:eol-style.
* WebCoreSupport/WebPluginHalterClient.h: Added property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttp/tests/navigation/changing-frame-hierarchy-in-onload.html flakey on Snow Leopard
jberlin@webkit.org [Mon, 28 Mar 2011 15:47:49 +0000 (15:47 +0000)]
http/tests/navigation/changing-frame-hierarchy-in-onload.html flakey on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=57236

Unreviewed, skip the flakey test in order to get the bots green.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Mon, 28 Mar 2011 14:43:33 +0000 (14:43 +0000)]
2011-03-28  Sergio Villar Senin  <svillar@igalia.com>

        Unreviewed, update pixel test expectations after r82105.

        * platform/gtk/fast/css/text-align-expected.checksum:
        * platform/gtk/fast/css/text-align-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
commit-queue@webkit.org [Mon, 28 Mar 2011 14:39:59 +0000 (14:39 +0000)]
2011-03-28  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Benjamin Poulain.

        [Qt] fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html fails
        https://bugs.webkit.org/show_bug.cgi?id=56825

        Fixes for context attribute handling:
        - Initialize depth and stencil buffer depending on whether they
        are enabled in context attributes.
        - Always enable depth buffer when stencil buffer is enabled.
        - Disable stencil buffer on OpenGL ES 2.0
        - Cleaned up clutter code from initialization. Made code paths
        more sane.
        - Clear mask is now set correctly in reshape().

        Tests: fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3DInternal::isValid):
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::reshape):
        (WebCore::GraphicsContext3DInternal::paint):
        (WebCore::GraphicsContext3DInternal::getProcAddress):
        (WebCore::GraphicsContext3D::GraphicsContext3D):
        (WebCore::GraphicsContext3D::reshape):
        (WebCore::GraphicsContext3D::bindFramebuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 28 Mar 2011 14:34:40 +0000 (14:34 +0000)]
2011-03-28  Ryosuke Niwa  <rniwa@webkit.org>

        [Chromium] [Mac Leopard] Update test expectations after r82105.

        * platform/chromium-linux/fast/css/text-align-expected.checksum:
        * platform/chromium-linux/fast/css/text-align-expected.png:
        * platform/chromium-win/fast/css/text-align-expected.checksum:
        * platform/chromium-win/fast/css/text-align-expected.png:
        * platform/chromium-win/fast/css/text-align-expected.txt:
        * platform/mac-leopard/fast/css/text-align-expected.checksum:
        * platform/mac-leopard/fast/css/text-align-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Mon, 28 Mar 2011 14:33:07 +0000 (14:33 +0000)]
2011-03-28  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] QtWebKit does not link with --3d-canvas using MinGW
        https://bugs.webkit.org/show_bug.cgi?id=57225

        * QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove WebKitSystemInterface_debug.lib, it hasn't been used for a few months now.
jeffm@apple.com [Mon, 28 Mar 2011 14:21:45 +0000 (14:21 +0000)]
Remove WebKitSystemInterface_debug.lib, it hasn't been used for a few months now.

Rubber-stamped by Adam Roben.

* win/lib/WebKitSystemInterface_debug.lib: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
ossy@webkit.org [Mon, 28 Mar 2011 14:12:29 +0000 (14:12 +0000)]
REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
https://bugs.webkit.org/show_bug.cgi?id=57183

Reviewed by Andreas Kling.

Windows buildfix after r82065.

* Api/DerivedSources.pro: Readding escaping on Windows platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 28 Mar 2011 14:10:17 +0000 (14:10 +0000)]
2011-03-28  Ryosuke Niwa  <rniwa@webkit.org>

        [GTK] Update text expectations after r82105.

        * platform/gtk/fast/css/text-align-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Mar 2011 13:44:10 +0000 (13:44 +0000)]
2011-03-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: rename network domain events from didHappenSomething to somethingHappened.
        https://bugs.webkit.org/show_bug.cgi?id=57226

        * inspector/Inspector.json:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::willSendRequest):
        (WebCore::InspectorResourceAgent::markResourceAsCached):
        (WebCore::InspectorResourceAgent::didReceiveResponse):
        (WebCore::InspectorResourceAgent::didReceiveContentLength):
        (WebCore::InspectorResourceAgent::didFinishLoading):
        (WebCore::InspectorResourceAgent::didFailLoading):
        (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
        (WebCore::InspectorResourceAgent::setInitialContent):
        (WebCore::InspectorResourceAgent::didCommitLoad):
        (WebCore::InspectorResourceAgent::frameDetachedFromParent):
        (WebCore::InspectorResourceAgent::didCreateWebSocket):
        (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
        (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
        (WebCore::InspectorResourceAgent::didCloseWebSocket):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
        (WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached):
        (WebInspector.NetworkDispatcher.prototype.responseReceived):
        (WebInspector.NetworkDispatcher.prototype.dataReceived):
        (WebInspector.NetworkDispatcher.prototype.loadingFinished):
        (WebInspector.NetworkDispatcher.prototype.loadingFailed):
        (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):
        (WebInspector.NetworkDispatcher.prototype.frameDetached):
        (WebInspector.NetworkDispatcher.prototype.initialContentSet):
        (WebInspector.NetworkDispatcher.prototype.frameNavigated):
        (WebInspector.NetworkDispatcher.prototype.webSocketCreated):
        (WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
        (WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
        (WebInspector.NetworkDispatcher.prototype.webSocketClosed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update expectations after r82105.
ossy@webkit.org [Mon, 28 Mar 2011 13:05:24 +0000 (13:05 +0000)]
[Qt] Update expectations after r82105.

* platform/qt/fast/css/text-align-expected.checksum:
* platform/qt/fast/css/text-align-expected.png:
* platform/qt/fast/css/text-align-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 28 Mar 2011 12:41:10 +0000 (12:41 +0000)]
2011-03-28  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
        https://bugs.webkit.org/show_bug.cgi?id=57224

        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::buildUI):
        (MainWindow::onTitleChanged):
        * QtTestBrowser/mainwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Mon, 28 Mar 2011 12:24:41 +0000 (12:24 +0000)]
2011-03-28  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: [Chromium] Delete native CPU profiles and heap snapshots on binding disposal.
        https://bugs.webkit.org/show_bug.cgi?id=57099

        * bindings/v8/ScriptHeapSnapshot.cpp:
        (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot):
        * bindings/v8/ScriptHeapSnapshot.h:
        * bindings/v8/ScriptProfile.cpp:
        (WebCore::ScriptProfile::~ScriptProfile):
        * bindings/v8/ScriptProfile.h:
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::resetState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-24 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 28 Mar 2011 12:23:15 +0000 (12:23 +0000)]
2011-03-24  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix console messages positions in formatted scripts.
        https://bugs.webkit.org/show_bug.cgi?id=57010

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
        (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage.didRequestMapping):
        (WebInspector.DebuggerPresentationModel.prototype.addConsoleMessage):
        (WebInspector.DebuggerPresentationModel.prototype.clearConsoleMessages):
        (WebInspector.DebuggerPresentationModel.prototype._reset):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel.prototype.addConsoleMessage):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.addConsoleMessage):
        (WebInspector.ScriptsPanel.prototype.clearConsoleMessages):
        (WebInspector.ScriptsPanel.prototype._consoleMessageAdded):
        (WebInspector.ScriptsPanel.prototype.reset):
        (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.addMessage):
        (WebInspector.SourceFrame.prototype._addExistingMessagesToSource):
        (WebInspector.SourceFrame.prototype.addMessageToSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Mar 2011 12:18:02 +0000 (12:18 +0000)]
2011-03-27  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: refactor ResourceTreeModel to remove poor dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=57186

        * http/tests/inspector/console-resource-errors-expected.txt:
        * http/tests/inspector/console-resource-errors.html:
        * http/tests/inspector/resources/console-resource-errors-iframe.html: Added.
        * inspector/report-protocol-errors.html:
        * inspector/storage-panel-dom-storage.html:
2011-03-27  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: refactor ResourceTreeModel to remove poor dependencies.
        https://bugs.webkit.org/show_bug.cgi?id=57186

        - ResourceTreeModel is now event target (Object)
        - There is no ResourceTreeModel -> UI dependencies
        - NetworkManager -> ResourceTreeModel dependencies has been removed
        - NetworkManager is no longer dealing with the resources tree, it is only responsible for network events
        - ResourceTreeModel requests tree structure from the backend separately
        - Cached resources tree payload is now limited to url and type (no headers involved)
        - Resources tree is being rendered lazily upon request from the panel.

        * inspector/Inspector.json:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::resourceContent):
        (WebCore::InspectorResourceAgent::resourceContentBase64):
        (WebCore::buildObjectForFrameTree):
        (WebCore::InspectorResourceAgent::enable):
        (WebCore::InspectorResourceAgent::getCachedResources):
        (WebCore::InspectorResourceAgent::getResourceContent):
        * inspector/InspectorResourceAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::resourceStyleSheetText):
        * inspector/front-end/InspectorFrontendHostStub.js:
        (.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend):
        (.WebInspector.InspectorFrontendHostStub.prototype.loadSessionSetting):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager):
        (WebInspector.NetworkManager.prototype.frontendReused):
        (WebInspector.NetworkManager.prototype.requestContent):
        (WebInspector.NetworkDispatcher):
        (WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
        (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache):
        (WebInspector.NetworkDispatcher.prototype.frameDetachedFromParent):
        (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype._updateSummaryBar):
        (WebInspector.NetworkPanel.prototype._onFrameCommitLoad):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel):
        (WebInspector.ResourceTreeModel.prototype.frontendReused):
        (WebInspector.ResourceTreeModel.prototype._processCachedResources):
        (WebInspector.ResourceTreeModel.prototype._addOrUpdateFrame):
        (WebInspector.ResourceTreeModel.prototype.frames):
        (WebInspector.ResourceTreeModel.prototype.subframes):
        (WebInspector.ResourceTreeModel.prototype.resources):
        (WebInspector.ResourceTreeModel.prototype._onCommitLoad):
        (WebInspector.ResourceTreeModel.prototype._onFrameDetachedFromParent):
        (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
        (WebInspector.ResourceTreeModel.prototype._addResourceToFrame):
        (WebInspector.ResourceTreeModel.prototype.resourceForURL):
        (WebInspector.ResourceTreeModel.prototype._bindResourceURL):
        (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
        (WebInspector.ResourceTreeModel.prototype._clearResources):
        (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
        (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
        (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
        (WebInspector.ResourceTreeModel.prototype._createResource):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):
        (WebInspector.ResourcesPanel.prototype.show):
        (WebInspector.ResourcesPanel.prototype._populateResourceTree.populateFrame):
        (WebInspector.ResourcesPanel.prototype._populateResourceTree):
        (WebInspector.ResourcesPanel.prototype._frameAdded):
        (WebInspector.ResourcesPanel.prototype._frameDetached):
        (WebInspector.ResourcesPanel.prototype._resourceAdded):
        (WebInspector.ResourcesPanel.prototype._frameNavigated):
        (WebInspector.FrameTreeElement.prototype.setTitles):
        * inspector/front-end/inspector.js:
        (WebInspector.frontendReused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 28 Mar 2011 12:04:56 +0000 (12:04 +0000)]
2011-03-27  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        WebKit's behavior for text-align inherit differs from other browsers
        https://bugs.webkit.org/show_bug.cgi?id=56377

        The bug was caused by WebKit's resolving text-align: start and text-align: end too early.
        As discussed on the bug, when text-align: start and text-align: end are inherited by descendent nodes,
        the alignment of the text in those nodes should be determined based on the directionality of the text,
        not by the directionality of the ancestor node from which text-align property is inherited.

        Fixed the bug by introducing new enum values to ETextAlign: TASTART and TAEND. These two values will
        align text to the left in a LTR context and to the right in a RTL context respectively.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added the support for TASTART and TAEND.
        (WebCore::CSSPrimitiveValue::operator ETextAlign): Ditto.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): No longer processes CSSValueStart and CSSValueEnd.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::localCaretRect): Added the support for TASTART and TAEND.
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Added the support for TASTART and TAEND.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect): Ditto.
        * rendering/style/RenderStyle.h: ETextAlign now has 10 values and requires 4 bits.
        * rendering/style/RenderStyleConstants.h: Added TASTART and TAEND to ETextAlign.
2011-03-27  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        WebKit's behavior for text-align inherit differs from other browsers
        https://bugs.webkit.org/show_bug.cgi?id=56377

        Added test more cases to text-align, which already has some tests for text-align: start and text-align: end.

        * fast/css/text-align-expected.txt:
        * fast/css/text-align.html:
        * platform/mac/fast/css/text-align-expected.checksum:
        * platform/mac/fast/css/text-align-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Mon, 28 Mar 2011 12:02:25 +0000 (12:02 +0000)]
2011-03-28  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Fix the linking of jsc with MinGW after r81963.

        * jsc.pro: add -l and remove the lib suffix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 28 Mar 2011 11:57:29 +0000 (11:57 +0000)]
2011-03-28  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix breakpoints positions in formatted scripts.
        https://bugs.webkit.org/show_bug.cgi?id=56931

        Add async requestMapping method to SourceFile interface as required for populating
        breakpoints sidebar pane when in "format all scripts" mode.

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didRequestSourceMapping):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.didRequestSourceMapping):
        (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
        (WebInspector.PresentationBreakpoint): Breakpoint wrapper for UI.
        (WebInspector.PresentationBreakpoint.prototype.get sourceFileId):
        (WebInspector.PresentationBreakpoint.prototype.get lineNumber):
        (WebInspector.PresentationBreakpoint.prototype.get condition):
        (WebInspector.PresentationBreakpoint.prototype.get enabled):
        (WebInspector.PresentationBreakpoint.prototype.get url):
        (WebInspector.PresentationBreakpoint.prototype.get resolved):
        (WebInspector.PresentationBreakpoint.prototype.loadSnippet):
        * inspector/front-end/ScriptFormatter.js:
        (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
        (WebInspector.ScriptFormatter.prototype.formatContent):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile.prototype.requestSourceMapping):
        (WebInspector.FormattedSourceFile.prototype.requestSourceMapping):
        (WebInspector.FormattedSourceFile.prototype._didRequestContent):
        (WebInspector.SourceMapping):
        (WebInspector.SourceMapping.prototype.scriptLocationToSourceLocation):
        (WebInspector.SourceMapping.prototype.sourceLocationToScriptLocation):
        (WebInspector.FormattedSourceMapping):
        (WebInspector.FormattedSourceMapping.prototype.scriptLocationToSourceLocation):
        (WebInspector.FormattedSourceMapping.prototype.sourceLocationToScriptLocation):
        (WebInspector.FormattedSourceMapping.prototype._convertPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThis patch fixes linking errors on Qt Webkit Windows MinGW builds.
ossy@webkit.org [Mon, 28 Mar 2011 11:49:35 +0000 (11:49 +0000)]
This patch fixes linking errors on Qt Webkit Windows MinGW builds.
This patch sets the BUILDING_WEBKIT & QT_MAKEDLL macros so that
QWEBKIT_EXPORT is defined as follows:

Patch by Nancy Piedra <nancy.piedra@nokia.com> on 2011-03-28
Reviewed by Csaba Osztrogonác.

No new tests needed since only changing .pro file.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 28 Mar 2011 11:46:14 +0000 (11:46 +0000)]
2011-03-28  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix.

        * COMPropertyBag.h: Added missing include.
        * WebKitCOMAPI.h: Ditto.
        * WebCoreSupport/WebFrameLoaderClient.h: Added missing forward declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Mon, 28 Mar 2011 11:36:46 +0000 (11:36 +0000)]
2011-03-28  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Yet another test result fix for fast/blockflow/fallback-orientation-expected.html.

        * platform/chromium-win/fast/blockflow/fallback-orientation-expected.txt: Renamed from LayoutTests/platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Mon, 28 Mar 2011 11:31:35 +0000 (11:31 +0000)]
2011-03-28  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: source frame should show the error to user when live edit is failed
        https://bugs.webkit.org/show_bug.cgi?id=57002

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._handleSave.didSaveScriptSource):
        (WebInspector.SourceFrame.prototype._handleSave):
        (WebInspector.SourceFrameDelegate.prototype.editScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Mon, 28 Mar 2011 11:30:12 +0000 (11:30 +0000)]
2011-03-28  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, add Chromium test expectation for inspector/debugger/debugger-activation-crash.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Mon, 28 Mar 2011 11:06:52 +0000 (11:06 +0000)]
2011-03-28  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, move Chromium test results into the right directory (move WinXP
        baseline into chromium-win-xp).

        * platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/blockflow/fallback-orientation-expected.checksum.
        * platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/blockflow/fallback-orientation-expected.png.
        * platform/chromium-win-xp/fast/blockflow/fallback-orientation-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/blockflow/fallback-orientation-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Mon, 28 Mar 2011 10:45:59 +0000 (10:45 +0000)]
2011-03-28  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, add new Chromium test results and expectation.

        * platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/fast/block/positioning/047-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Mon, 28 Mar 2011 10:16:38 +0000 (10:16 +0000)]
2011-03-26  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Expose the AtkValue interface for WAI-ARIA sliders
        https://bugs.webkit.org/show_bug.cgi?id=56655

        New test to check WAI-ARIA sliders required attributes.

        * platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Added.
        * platform/gtk/accessibility/aria-slider-required-attributes.html: Added.
2011-03-26  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Expose the AtkValue interface for WAI-ARIA sliders
        https://bugs.webkit.org/show_bug.cgi?id=56655

        Implement AtkValue interface for WAI-ARIA sliders.

        Test: platform/gtk/accessibility/aria-slider-required-attributes.html

        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::AXObjectCache::postPlatformNotification): Emit the
        'property-change::accessible-value' signal when needed.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (core): New, returns a core object from an AtkValue.
        (webkitAccessibleValueGetCurrentValue): New, implements AtkValue.
        (webkitAccessibleValueGetMaximumValue): Ditto.
        (webkitAccessibleValueGetMinimumValue): Ditto.
        (webkitAccessibleValueSetCurrentValue): Ditto.
        (webkitAccessibleValueGetMinimumIncrement): Ditto.
        (atkValueInterfaceInit): Ditto.
        (GetAtkInterfaceTypeFromWAIType): Add ATK_TYPE_VALUE.
        (getInterfaceMaskFromObject): Set the WAI_VALUE bit for sliders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Mon, 28 Mar 2011 09:49:27 +0000 (09:49 +0000)]
2011-03-28  Sergio Villar Senin  <svillar@igalia.com>

        [GTK] Fullscreen tests failing after r82084
        https://bugs.webkit.org/show_bug.cgi?id=57219

        Skipping some fullscreen tests failing since r82084

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 28 Mar 2011 09:33:59 +0000 (09:33 +0000)]
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Assigning location.path to something that doesn't start with / mangles the authority
        https://bugs.webkit.org/show_bug.cgi?id=57209
        <rdar://problem/9195132>

        Tests: http/tests/uri/assign-path-with-leading-slash.html
               http/tests/uri/assign-path-without-leading-slash.html

        * platform/KURL.cpp:
        (WebCore::KURL::setPath): If the new path does not have a leading slash, add one.
2011-03-28  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Assigning location.path to something that doesn't start with / mangles the authority
        https://bugs.webkit.org/show_bug.cgi?id=57209
        <rdar://problem/9195132>

        * http/tests/uri/assign-path-with-leading-slash-expected.txt: Added.
        * http/tests/uri/assign-path-with-leading-slash.html: Added.
        * http/tests/uri/assign-path-without-leading-slash-expected.txt: Added.
        * http/tests/uri/assign-path-without-leading-slash.html: Added.
        * http/tests/uri/resources/assign-path-landing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Mon, 28 Mar 2011 09:28:44 +0000 (09:28 +0000)]
2011-03-28  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, add Chromium test expectation for fast/text/justify-ideograph-leading-expansion.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 28 Mar 2011 09:19:50 +0000 (09:19 +0000)]
2011-03-28  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Extract functions to update logical width from computeInlineDirectionPositionsForLine
        https://bugs.webkit.org/show_bug.cgi?id=57213

        Extracted updateLogicalWidthForLeftAlignedBlock, updateLogicalWidthForRightAlignedBlock,
        and updateLogicalWidthForCenterAlignedBlock from computeInlineDirectionPositionsForLine.

        They are used to update logical widths, logical left, and total logical width for left,
        right, and center aligned blocks.

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::updateLogicalWidthForLeftAlignedBlock):
        (WebCore::updateLogicalWidthForRightAlignedBlock):
        (WebCore::updateLogicalWidthForCenterAlignedBlock):
        (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Evan Martin <evan@chromium.org>
evan@chromium.org [Mon, 28 Mar 2011 08:57:27 +0000 (08:57 +0000)]
2011-03-28  Evan Martin  <evan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Refactor duplicate code in HTMLTextElement
        https://bugs.webkit.org/show_bug.cgi?id=57215

        * html/HTMLTitleElement.cpp:
        (WebCore::HTMLTitleElement::childrenChanged):
        This method did an equivalent loop to the text() method on
        the same object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-28 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Mon, 28 Mar 2011 08:26:16 +0000 (08:26 +0000)]
2011-03-28  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, update Chromium test results for plugins/plugin-javascript-access.html.

        * platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
        * platform/chromium-win/plugins/plugin-javascript-access-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Mon, 28 Mar 2011 06:46:23 +0000 (06:46 +0000)]
2011-03-27  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Don't call WebSocket::didClose() more than once.
        https://bugs.webkit.org/show_bug.cgi?id=57081

        If WebSocket close() is called, and connection is established, then
        it will call didClose() that resets m_channel to 0.
        After that, when connection is closed, WebSocketChannel will call
        didClose for the WebSocket instance.

        * http/tests/websocket/tests/close-unref-websocket-expected.txt: Added.
        * http/tests/websocket/tests/close-unref-websocket.html: Added.
        * http/tests/websocket/tests/hanging-handshake_wsh.py: Added.
2011-03-27  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Don't call WebSocket::didClose() more than once.
        https://bugs.webkit.org/show_bug.cgi?id=57081

        If WebSocket close() is called, and connection is established, then
        it will call didClose() that resets m_channel to 0.
        After that, when connection is closed, WebSocketChannel will call
        didClose for the WebSocket instance.

        Call WebSocketChannel::disconnect() before m_channel = 0 to make sure
        WebSocketChannel suppress the second didClose().

        Test: http/tests/websocket/tests/close-unref-websocket.html

        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Andy Estes <aestes@apple.com>
aestes@apple.com [Mon, 28 Mar 2011 06:41:41 +0000 (06:41 +0000)]
2011-03-27  Andy Estes  <aestes@apple.com>

        Reviewed by Maciej Stachowiak.

        Correctly get a plug-in's MIME type when it uses WebPluginMIMETypesFilename
        https://bugs.webkit.org/show_bug.cgi?id=57205

        If the plug-in's Info.plist uses WebPluginMIMETypesFilename to specify
        plug-in MIME types, WebKit has to check for a property list file in
        ~/Library/Preferences for the MIME type dictionary.

        * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
        (WebKit::getMIMETypesFromPluginBundle): If the bundle's Info dictionary
        has the key WebPluginMIMETypesFilename, open the property list
        specified by that key's value and return the MIME type dictionary from
        there. Otherwise, return the MIME type dictionary specified by the key
        WebPluginMIMETypes.
        (WebKit::getPluginInfoFromPropertyLists): Call
        getMIMETypesFromPluginBundle().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Mon, 28 Mar 2011 06:09:43 +0000 (06:09 +0000)]
2011-03-27  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, add Chromium test results for fast/blockflow/fallback-orientation.html.

        * platform/chromium-mac-leopard/fast/blockflow/fallback-orientation-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/blockflow/fallback-orientation-expected.png: Added.
        * platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.checksum: Added.
        * platform/chromium-win-vista/fast/blockflow/fallback-orientation-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 28 Mar 2011 05:15:38 +0000 (05:15 +0000)]
2011-03-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Fix script-src redirect handling
        https://bugs.webkit.org/show_bug.cgi?id=57196

        Test both allow => disallow and disallow => allow redirect cases.
        Previously, we had incorrect expectations for one of the redirect
        cases.  Also, I've updated the policy syntax to match the default-src
        syntax.

        * http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
        * http/tests/security/contentSecurityPolicy/script-src-redirect.html:
2011-03-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Fix script-src redirect handling
        https://bugs.webkit.org/show_bug.cgi?id=57196

        Resource-loading requirements in CSP apply to each hop in the redirect
        chain.  To make that work properly, we need to move enforcement into
        the loader.  Fortunately, we already have a choke-point in the loader
        for enforcing this kind of policy.

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::requestScript):
        * html/parser/HTMLDocumentParser.cpp:
        * html/parser/HTMLDocumentParser.h:
        * html/parser/HTMLScriptRunnerHost.h:
        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::canRequest):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::allowScriptFromSource):
        * page/ContentSecurityPolicy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 28 Mar 2011 04:27:54 +0000 (04:27 +0000)]
2011-03-27  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Full Screen: disable keyboard access by default
        https://bugs.webkit.org/show_bug.cgi?id=56684

        Pass whether keyboard access was requested up to ChromeClient when asking
        if fullscreen mode is supported.

        * dom/Document.cpp:
        (WebCore::Document::webkitRequestFullScreenForElement):
        * page/ChromeClient.h:
        (WebCore::ChromeClient::supportsFullscreenForElement):
2011-03-27  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Full Screen: disable keyboard access by default
        https://bugs.webkit.org/show_bug.cgi?id=56684

        Take into account whether keyboard access was requested when deciding whether full
        screen mode is supported.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::supportsFullScreenForElement):
        * WebView/WebView.mm:
        (-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):
        * WebView/WebViewInternal.h:
2011-03-27  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Full Screen: disable keyboard access by default
        https://bugs.webkit.org/show_bug.cgi?id=56684

        Take into account whether keyboard access was requested when deciding whether full
        screen mode is supported.

        * UIProcess/WebFullScreenManagerProxy.cpp:
        (WebKit::WebFullScreenManagerProxy::supportsFullScreen):
        * UIProcess/WebFullScreenManagerProxy.h:
        * UIProcess/WebFullScreenManagerProxy.messages.in:
        * WebProcess/FullScreen/WebFullScreenManager.cpp:
        (WebKit::WebFullScreenManager::supportsFullScreen):
        * WebProcess/FullScreen/WebFullScreenManager.h:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::supportsFullScreenForElement):
        * WebProcess/WebCoreSupport/WebChromeClient.h:
2011-03-27  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Full Screen: disable keyboard access by default
        https://bugs.webkit.org/show_bug.cgi?id=56684

        Accept the withKeyboard parameter to supportsFullScreenForElement.

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 28 Mar 2011 02:33:12 +0000 (02:33 +0000)]
2011-03-27  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by David Levin.

        check-webkit-style should check ChangeLog for a valid bug number
        https://bugs.webkit.org/show_bug.cgi?id=57184

        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:
        * Scripts/webkitpy/style/checkers/changelog.py: Added.
        * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Sun, 27 Mar 2011 22:54:59 +0000 (22:54 +0000)]
2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
        https://bugs.webkit.org/show_bug.cgi?id=57087

        Use explicit conversion for string to avoid depending on the default codec
        installed by the user code.

        * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
        (WTR::activateFonts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sun, 27 Mar 2011 19:56:02 +0000 (19:56 +0000)]
2011-03-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Dock doesn't come back after leaving fullscreen on Hulu
        https://bugs.webkit.org/show_bug.cgi?id=57189
        <rdar://problem/9192413>

        Port some code over from the old WebKit1 plug-in host.

        * PluginProcess/mac/PluginProcessShim.mm:
        (WebKit::shimShowMenuBar):
        (WebKit::shimHideMenuBar):
        (WebKit::shimIsMenuBarVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoKeep a strong reference to the connection to avoid crashes.
andersca@apple.com [Sun, 27 Mar 2011 19:26:47 +0000 (19:26 +0000)]
Keep a strong reference to the connection to avoid crashes.

Reviewed by Sam Weinig.

* Platform/CoreIPC/Connection.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 27 Mar 2011 19:15:58 +0000 (19:15 +0000)]
2011-03-27  Andreas Kling  <kling@webkit.org>

        Fix build warning about IconDatabaseClient.h (wrong path.)

        * QtWebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 27 Mar 2011 19:12:19 +0000 (19:12 +0000)]
2011-03-27  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Support for CSS color and background-color properties on select element's dropdown list
        https://bugs.webkit.org/show_bug.cgi?id=51627

        Extend the QWebSelectData interface with background and foreground colors
        for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
        getters in RenderMenuList.

        * Api/qwebkitplatformplugin.h:
        * WebCoreSupport/PopupMenuQt.cpp:
        (SelectData::backgroundColor):
        (SelectData::foregroundColor):
        (SelectData::itemBackgroundColor):
        (SelectData::itemForegroundColor):
        * WebCoreSupport/QtFallbackWebPopup.cpp:
        (WebCore::QtFallbackWebPopup::show):
        (WebCore::QtFallbackWebPopup::populate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Sun, 27 Mar 2011 18:26:11 +0000 (18:26 +0000)]
2011-03-27  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt][Symbian] Fix Api test failure -- microFocusCoordinates
        https://bugs.webkit.org/show_bug.cgi?id=57108

        Since the canvas is not self-closing tag, we need to add '</canvas>'.

        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        (tst_QGraphicsWebView::microFocusCoordinates):
        * tests/qwebview/tst_qwebview.cpp:
        (tst_QWebView::microFocusCoordinates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Sun, 27 Mar 2011 17:52:39 +0000 (17:52 +0000)]
2011-03-27  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
        https://bugs.webkit.org/show_bug.cgi?id=57143

        Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
        define WTF_USE_TEXTURE_MAPPER=1.

        * QtWebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 27 Mar 2011 17:42:08 +0000 (17:42 +0000)]
2011-03-27  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Fix agentOS() in FrameLoaderClientEfl
        https://bugs.webkit.org/show_bug.cgi?id=57177

        Replace old PLATFORM macro with OS and CPU.

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::agentOS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 27 Mar 2011 17:38:45 +0000 (17:38 +0000)]
2011-03-27  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [EFL] Use an appropriate user agent string
        https://bugs.webkit.org/show_bug.cgi?id=57176

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::composeUserAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 27 Mar 2011 17:28:57 +0000 (17:28 +0000)]
2011-03-27  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [WINCE] Use a appropriate user agent string
        https://bugs.webkit.org/show_bug.cgi?id=57175

        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
        (WebKit::FrameLoaderClientWinCE::userAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 27 Mar 2011 17:24:43 +0000 (17:24 +0000)]
2011-03-27  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Generate WebKitVersion.h
        https://bugs.webkit.org/show_bug.cgi?id=57128

        This file will be used for the user agent string by the CMake based ports.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Sun, 27 Mar 2011 16:36:28 +0000 (16:36 +0000)]
2011-03-27  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, add new Chromium test result and expectations.

        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Sun, 27 Mar 2011 16:36:13 +0000 (16:36 +0000)]
2011-03-27  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=57170  Fix last elements
        in an enum to remove a trailing comma. Sun Studio 12 CC errors out.

        Compile fix only, no actual code change.

        * wtf/MessageQueue.h:
2011-03-27  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=57170  Fix last elements
        in an enum to remove a trailing comma. Sun Studio 12 CC errors out.

        Compile fix only, no actual code change.

        * dom/ExceptionCode.h:
        * editing/EditorInsertAction.h:
        * loader/FrameLoaderTypes.h:
        * platform/PlatformKeyboardEvent.h:
        * platform/ScrollTypes.h:
        * platform/graphics/BitmapImage.h:
        * platform/image-decoders/ImageDecoder.h:
        * platform/network/ProtectionSpace.h:
        * platform/network/ResourceHandleClient.h:
        * platform/network/ResourceRequestBase.h:
        * platform/text/TextCodec.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Sun, 27 Mar 2011 14:50:17 +0000 (14:50 +0000)]
2011-03-27  Rob Buis  <rwlbuis@gmail.com>

        Unreviewed, update improve test result.

        * platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 27 Mar 2011 14:23:30 +0000 (14:23 +0000)]
2011-03-27  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
        https://bugs.webkit.org/show_bug.cgi?id=57183

        The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
        which was due to the outputting code previously being wrapped in eval().

        * Api/DerivedSources.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Sun, 27 Mar 2011 13:26:10 +0000 (13:26 +0000)]
2011-03-27  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, update Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Sun, 27 Mar 2011 12:38:49 +0000 (12:38 +0000)]
2011-03-27  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, add new Chromium test results.

        * platform/chromium-linux/svg/text/text-path-middle-align-expected.checksum: Added.
        * platform/chromium-linux/svg/text/text-path-middle-align-expected.png: Added.
        * platform/chromium-win/fast/blockflow/fallback-orientation-expected.checksum: Added.
        * platform/chromium-win/fast/blockflow/fallback-orientation-expected.png: Added.
        * platform/chromium-win/fast/blockflow/fallback-orientation-expected.txt: Added.
        * platform/chromium-win/svg/text/text-path-middle-align-expected.checksum: Added.
        * platform/chromium-win/svg/text/text-path-middle-align-expected.png: Added.
        * platform/chromium-win/svg/text/text-path-middle-align-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Sun, 27 Mar 2011 12:25:40 +0000 (12:25 +0000)]
2011-03-27  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, fix Chromium text expectation.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Sun, 27 Mar 2011 11:16:44 +0000 (11:16 +0000)]
2011-03-27  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Nikolas Zimmermann.

        Text on path positioning at zero startOffset
        https://bugs.webkit.org/show_bug.cgi?id=56245

        Since for length 0 no previous point is set, choose epsilon
        length to get normal at starting point of the path.

        Test: svg/text/text-path-middle-align.svg

        * platform/graphics/Path.cpp:
        (WebCore::Path::normalAngleAtLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Sun, 27 Mar 2011 09:53:52 +0000 (09:53 +0000)]
2011-03-27  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=57151, patch derived from set
        created by Thiago Macieria in bug https://bugs.webkit.org/show_bug.cgi?id=24932

        Fix compile issue on Solaris 10/Sun Studio 12 regarding ambiguity on ?: functions

        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::thisObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Sun, 27 Mar 2011 07:18:55 +0000 (07:18 +0000)]
2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
        https://bugs.webkit.org/show_bug.cgi?id=57087

        Use explicit conversion for string to avoid depending on the default codec
        installed by the user code.

        * Api/qwebkitversion.cpp:
        (qWebKitVersion):
        * Api/qwebpage.cpp:
        (QWebPagePrivate::dynamicPropertyChangeEvent):
        (QWebPage::javaScriptConsoleMessage):
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (convertToPropertyName):
        (DumpRenderTreeSupportQt::setEditingBehavior):
        (DumpRenderTreeSupportQt::plainText):
        * WebCoreSupport/EditorClientQt.cpp:
        (dumpRange):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (drtDescriptionSuitableForTestResult):
        (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::openInspectorFrontend):
        * WebCoreSupport/InspectorServerQt.cpp:
        (WebCore::parseWebSocketChallengeNumber):
        (WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Sun, 27 Mar 2011 05:19:17 +0000 (05:19 +0000)]
2011-03-26  Jeff Miller  <jeffm@apple.com>

        Reviewed by Sam Weinig.

        WKErrorCopyCFError() doesn&apos;t actually return a copy of the CFErrorRef
        https://bugs.webkit.org/show_bug.cgi?id=57172

        * Shared/API/c/cf/WKErrorCF.cpp:
        (WKErrorCopyCFError): Use RetainPtr<> and leakRef() to return a real copy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix.
jer.noble@apple.com [Sun, 27 Mar 2011 03:12:06 +0000 (03:12 +0000)]
Unreviewed build fix.

Fix a bug which was causing the "skip back" button to be missing, causing
the media layout tests to fail.

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldRenderMediaControlPart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9180716> REGRESSION (r80582): Angle bracket rendered upright in verti...
mitz@apple.com [Sun, 27 Mar 2011 01:38:47 +0000 (01:38 +0000)]
<rdar://problem/9180716> REGRESSION (r80582): Angle bracket rendered upright in vertical mode
https://bugs.webkit.org/show_bug.cgi?id=57169

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/blockflow/fallback-orientation.html

* platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataForCharacter): If the font has vertical glyphs, use it, rather
than continuing down the fallback list.

LayoutTests:

* fast/blockflow/fallback-orientation.html: Added.
* platform/mac/fast/blockflow/fallback-orientation-expected.checksum: Added.
* platform/mac/fast/blockflow/fallback-orientation-expected.png: Added.
* platform/mac/fast/blockflow/fallback-orientation-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebKit2: Revert inadvertantly commited changes.
mjs@apple.com [Sun, 27 Mar 2011 01:10:02 +0000 (01:10 +0000)]
Source/WebKit2: Revert inadvertantly commited changes.

* WebProcess/com.apple.WebProcess.sb:

Tools: Revert inadvertantly committed changes.

* Scripts/old-run-webkit-tests:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 27 Mar 2011 00:58:34 +0000 (00:58 +0000)]
2011-03-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        Follow-up fix for crash with giant inline stylesheets - actually don't crash, and add test
        https://bugs.webkit.org/show_bug.cgi?id=56150

        Test: fast/css/giant-stylesheet-crash.html

        * dom/StyleElement.cpp:
        (WebCore::StyleElement::process):
2011-03-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        Follow-up fix for crash with giant inline stylesheets - actually don't crash, and add test
        https://bugs.webkit.org/show_bug.cgi?id=56150

        * fast/css/giant-stylesheet-crash-expected.txt: Added.
        * fast/css/giant-stylesheet-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sun, 27 Mar 2011 00:15:48 +0000 (00:15 +0000)]
2011-03-22  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Media controls must use full screen style when in new full screen mode.
        https://bugs.webkit.org/show_bug.cgi?id=56851

        Add new full screen styles for the full screen media elements.

        * DerivedSources.make: Add fullScreenQuickTime.css.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * css/CSSStyleSelector.cpp: Removed loadFullScreenRulesIfNeeded().
        (WebCore::CSSStyleSelector::CSSStyleSelector): Ditto.
        (WebCore::CSSStyleSelector::styleForElement): Load full screen rules
            if needed.
        * css/fullscreenQuickTime.css: Added.
        * css/mediaControls.css:
        * html/shadow/MediaControls.cpp:
        (WebCore::isFullScreen): Added.
        (WebCore::MediaControls::create): Add new full screen volume controls.
        (WebCore::MediaControls::updateStyle): Ditto.
        (WebCore::MediaControls::update): Ditto.
        (WebCore::MediaControls::updateVolumeSliderContainer): Ditto.
        (WebCore::MediaControls::forwardEvent): Ditto.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement): Added.
        (WebCore::MediaControlFullscreenVolumeSliderElement::create): Added.
        (WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId): Added.
        (WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement): Addet
        (WebCore::MediaControlFullscreenVolumeMinButtonElement::create): Added.
        (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Added.
        (WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId): Added.
        (WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement): Added.
        (WebCore::MediaControlFullscreenVolumeMaxButtonElement::create): Added.
        (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Added.
        (WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId): Added.
        * rendering/MediaControlElements.h:
            Added m_overridePosition.
        (WebCore::MediaControlVolumeSliderContainerElement::setOverridesPosition): Added.
        * rendering/MediaControlElements.h:
        (WebCore::MediaControlVolumeSliderContainerElement::overridesPosition): Added.
        * rendering/RenderTheme.h:
        (WebCore::RenderTheme::extraFullScreenStyleSheet): Added.
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::extraFullScreenStyleSheet): Added.
        (WebCore::RenderThemeMac::shouldRenderMediaControlPart): Render seek forward and backward
            buttons.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sun, 27 Mar 2011 00:03:14 +0000 (00:03 +0000)]
2011-03-26  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Enable the Full Screen API by default in WebKit/mac and WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=56956

        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]): Default the WebKitFullScreenEnabled preference to true.
2011-03-26  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Enable the Full Screen API by default in WebKit/mac and WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=56956

        * Shared/WebPreferencesStore.h: Default the fullScreenEnabled preference to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sat, 26 Mar 2011 23:46:08 +0000 (23:46 +0000)]
2011-03-26  Jer Noble  <jer.noble@apple.com>

        Reviewed by Dan Bernstein.

        RenderMedia should obey the view's flattening bit.
        https://bugs.webkit.org/show_bug.cgi?id=57156

        Paint the current frame in software when the associated FrameView
        has its flattening bit set.

        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::paintReplaced):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 26 Mar 2011 23:05:32 +0000 (23:05 +0000)]
2011-03-26  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed build fix for !ENABLE(DOM_STORAGE).

        * storage/StorageTracker.cpp:
            Added #if ENABLE(DOM_STORAGE) like in the other storage files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd PlatformCertificateInfo::PlatformCertificateInfo(PCCERT_CONTEXT) constructor...
jeffm@apple.com [Sat, 26 Mar 2011 22:53:49 +0000 (22:53 +0000)]
Add PlatformCertificateInfo::PlatformCertificateInfo(PCCERT_CONTEXT) constructor on Windows
https://bugs.webkit.org/show_bug.cgi?id=57152

Reviewed by Steve Falkenburg.

We're going to need to create a PlatformCertificateInfo with a single certificate on Windows to support client certificates.
Also, stop relying on the fact that the Win32 API CertDuplicateCertificateContext() currently returns the same PCCERT_CONTEXT that you pass to it, since that may change in the future.

* Shared/win/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Added PlatformCertificateInfo(PCCERT_CONTEXT) construtor. Use return value from CertDuplicateCertificateContext().
(WebKit::PlatformCertificateInfo::operator=): Use return value from CertDuplicateCertificateContext().
* Shared/win/PlatformCertificateInfo.h: Added PlatformCertificateInfo(PCCERT_CONTEXT) construtor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 26 Mar 2011 21:36:14 +0000 (21:36 +0000)]
2011-03-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Graphic corruption appeared with Silverlight contents while resizing window
        https://bugs.webkit.org/show_bug.cgi?id=57167
        <rdar://problem/9094052>

        Pass DispatchMessageEvenWhenWaitingForSyncReply when sending GeometryDidChange messages since that will guarantee
        that those messages will be handled before PaintEntirePlugin messages which prevents the PaintEntirePlugin handler from
        painting into the wrong backing store.

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::geometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 26 Mar 2011 21:18:07 +0000 (21:18 +0000)]
2011-03-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Web process considered unresponsive (SPOD shown) when displaying a JavaScript alert() as a result of a click
        <rdar://problem/9067557>
        https://bugs.webkit.org/show_bug.cgi?id=57166

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::runJavaScriptAlert):
        (WebKit::WebPageProxy::runJavaScriptConfirm):
        (WebKit::WebPageProxy::runJavaScriptPrompt):
        Invalidate the responsiveness timer before calling out to the client.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Andreas Kling <kling@webkit.org>
commit-queue@webkit.org [Sat, 26 Mar 2011 21:17:57 +0000 (21:17 +0000)]
2011-03-26  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Show page icons (favicons) in QtTestBrowser location bar.
        https://bugs.webkit.org/show_bug.cgi?id=57162

        * QtTestBrowser/QtTestBrowser.qrc:
        * QtTestBrowser/favicon.png: Added.
        * QtTestBrowser/locationedit.cpp:
        (defaultPageIcon):
        (LocationEdit::LocationEdit):
        (LocationEdit::setPageIcon):
        (LocationEdit::resizeEvent):
        (LocationEdit::updateInternalGeometry):
        * QtTestBrowser/locationedit.h:
        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::buildUI):
        (MainWindow::onIconChanged):
        (MainWindow::onLoadStarted):
        * QtTestBrowser/mainwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 26 Mar 2011 21:15:07 +0000 (21:15 +0000)]
2011-03-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        ASSERTION FAILED: m_operationInProgress == NoOperation loading nytimes.com
        https://bugs.webkit.org/show_bug.cgi?id=57165
        <rdar://problem/9024311>

        The assertion fired because during GC, the web process sends a synchronous NPObjectMessageReceiver::Deallocate
        message to the plug-in process. Since this is a synchronous message, the web process needs to process incoming synchronous
        messages. While waiting, we get an incoming PluginProxy::Evaluate message from the plug-in. This causes JavaScript to run
        during GC which is very bad.

        The fix for this is to add a flag on the connection that will cause synchronous messages sent by the connection (in this case the
        plug-in process) to not be processed while the other side (the web process) is waiting for a synchronous reply _unless_ the connection
        is actually processing a synchronous message. (The last part is to avoid deadlocks).

        Since the call to NPN_Evaluate by the plug-in (that ends up sending the PluginProxy::Evaluate message) comes from a run loop timer firing,
        it's OK to wait for it to be processed by the web process when it returns to the run loop.

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::Connection):
        Initialize m_onlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage and m_inDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount.

        (CoreIPC::Connection::setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage):
        Set m_onlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage.

        (CoreIPC::Connection::sendMessage):
        Don't add the MessageID::DispatchMessageWhenWaitingForSyncReply flag when the right flags has been set on the connection, and it's not processing a synchronous message.

        (CoreIPC::Connection::dispatchMessage):
        Increment and decrement m_inDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount accordingly.

        * PluginProcess/WebProcessConnection.cpp:
        (WebKit::WebProcessConnection::WebProcessConnection):
        Call setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage on the connection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Sat, 26 Mar 2011 20:50:47 +0000 (20:50 +0000)]
2011-03-26  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Benjamin Poulain.

        [Qt] Remove GraphicsLayerTextureMapper::nativeLayer
        https://bugs.webkit.org/show_bug.cgi?id=57141

        GraphicsLayer::nativeLayer was removed in r73380.

        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
        * platform/graphics/texmap/GraphicsLayerTextureMapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRollout r82042 (If a user doesn't have a Database/LocalStorage directory, it can...
weinig@apple.com [Sat, 26 Mar 2011 20:48:58 +0000 (20:48 +0000)]
Rollout r82042 (If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations))

-[NSString stringByResolvingSymlinksInPath] does not do what we needed for paths within /private.
This caused all SSL sites to stop working.

* WebProcess/mac/WebProcessMac.mm:
(WebKit::appendSandboxParameterPath):
(WebKit::initializeSandbox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 26 Mar 2011 20:32:34 +0000 (20:32 +0000)]
2011-03-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        If a user doesn't have a Database/LocalStorage directory, it can't be created (sandbox violations)
        <rdar://problem/9127411>
        https://bugs.webkit.org/show_bug.cgi?id=57164

        * WebProcess/mac/WebProcessMac.mm:
        (WebKit::appendSandboxParameterPath):
        (WebKit::initializeSandbox):
        Use -[NSString stringByResolvingSymlinksInPath] instead of realpath to ensure we can resolve
        symlinks even if the file/directory doesn't exist yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 26 Mar 2011 20:20:46 +0000 (20:20 +0000)]
2011-03-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Factor processing of incoming sync replies out into processIncomingSyncReply
        https://bugs.webkit.org/show_bug.cgi?id=57161

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::sendSyncMessage):
        Pass DispatchMessageEvenWhenWaitingForSyncReply to sendMessage.

        (CoreIPC::Connection::processIncomingSyncReply):
        Move code from processIncomingMessage to here.

        (CoreIPC::Connection::processIncomingMessage):
        Call processIncomingSyncReply.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-26 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 26 Mar 2011 20:14:04 +0000 (20:14 +0000)]
2011-03-26  Martin Robinson  <mrobinson@igalia.com>

        [GTK] layoutTestController.overridePreference("WebKitDefaultFontSize"...) does not take into account screen DPI
        https://bugs.webkit.org/show_bug.cgi?id=57160

        Skip failing test. This bug was uncovered by r82033.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82040 268f45cc-cd09-0410-ab3c-d52691b4dbfc