ap [Sat, 18 Nov 2006 09:30:58 +0000 (09:30 +0000)]
2006-11-18 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
Gender-neutrality fix.
* coding/contributing.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sat, 18 Nov 2006 09:29:27 +0000 (09:29 +0000)]
2006-11-18 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Properly adjust CFAbsoluteTime to time_t to fix date calculations.
Compare lastModified w/ MAX_TIME_T when setting last modified date
instead of comparing expiration against MAX_TIME_T.
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::getResourceResponse): Add kCFAbsoluteTimeIntervalSince1970 in assignment
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 18 Nov 2006 05:57:13 +0000 (05:57 +0000)]
Reviewed by Geoff.
More conversions from DeprecatedValueList to Vector and HashSet.
* css/CSSValueList.cpp:
(WebCore::CSSValueList::~CSSValueList):
(WebCore::CSSValueList::append):
(WebCore::CSSValueList::cssText):
* css/CSSValueList.h:
(WebCore::CSSValueList::length):
(WebCore::CSSValueList::item):
* dom/Document.cpp:
(WebCore::Document::attachNodeIterator):
(WebCore::Document::notifyBeforeNodeRemoval):
* dom/Document.h:
* ksvg2/svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::notifyAttributeChange):
* ksvg2/svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::notifyClientsToRepaint):
* platform/graphics/svg/SVGResource.cpp:
(WebCore::SVGResource::invalidate):
(WebCore::SVGResource::addClient):
* platform/graphics/svg/SVGResource.h:
* rendering/RenderBlock.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 18 Nov 2006 03:15:42 +0000 (03:15 +0000)]
2006-11-17 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
Make sure that we always use std::min and std::max instead of macros.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* kjs/config.h:
* wtf/Vector.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 18 Nov 2006 02:24:44 +0000 (02:24 +0000)]
Fixing the assertion failure, forgot to remove an enable() call.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 18 Nov 2006 01:21:07 +0000 (01:21 +0000)]
Versioning
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 18 Nov 2006 01:06:41 +0000 (01:06 +0000)]
Reviewed by Harrison.
<rdar://problem/
4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made
Disable the delete button controller when cloning nodes, Mail does this before saving a draft.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::cloneChildNodes):
* editing/markup.cpp:
(WebCore::createFragmentFromNodes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Sat, 18 Nov 2006 01:04:48 +0000 (01:04 +0000)]
LayoutTests:
Reviewed by harrison
<rdar://problem/
4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/
4017358> quoted text is wrong color, when pasted as quotation
Fixed:
* editing/pasteboard/merge-end-blockquote-expected.checksum:
* editing/pasteboard/merge-end-blockquote-expected.png:
* editing/pasteboard/merge-end-blockquote-expected.txt:
* editing/pasteboard/merge-end-blockquote.html:
Added:
* editing/pasteboard/paste-blockquote-1-expected.checksum: Added.
* editing/pasteboard/paste-blockquote-1-expected.png: Added.
* editing/pasteboard/paste-blockquote-1-expected.txt: Added.
* editing/pasteboard/paste-blockquote-1.html: Added.
* editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
* editing/pasteboard/paste-blockquote-2-expected.png: Added.
* editing/pasteboard/paste-blockquote-2-expected.txt: Added.
* editing/pasteboard/paste-blockquote-2.html: Added.
* editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
* editing/pasteboard/paste-blockquote-3-expected.png: Added.
* editing/pasteboard/paste-blockquote-3-expected.txt: Added.
* editing/pasteboard/paste-blockquote-3.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/
4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/
4017358> quoted text is wrong color, when pasted as quotation
* editing/ReplaceSelectionCommand.cpp:
(WebCore::isMailPasteAsQuotationNode): Added. Checks for the node
that Mail wraps around an incoming fragment when it wants it to be pasted
with quoting (no merging should be done).
(WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Added
this virtual method in order to adjust the nodes that ReplaceSelectionCommand
tracks.
(WebCore::ReplaceSelectionCommand::shouldMerge): Don't merge from content
inside a Mail Paste as Quotation node. Allow merging from Mail blockquotes.
(WebCore::ReplaceSelectionCommand::removeRedundantStyles): When pasting into
a Mail blockquote, we ignore the parts of the source document's default style
that are overriden by styles from the Mail blockquote. This is necessary in order
for text that's black (because black is the source document's default font color)
to appear blue/green/whatever when it's pasted into a Mail blockquote.
(WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Turn an inserted
Mail Paste as Quotation node into a normal Mail blockquote. This will prevent
a copied blockquote that was inserted into the document using Paste as Quotation
from triggering Paste as Quotation behavior when it's pasted.
(WebCore::ReplaceSelectionCommand::doApply): Call the new/altered methods.
* editing/ReplaceSelectionCommand.h:
* editing/markup.cpp:
(WebCore::styleFromMatchedRulesForElement): Put this code into a subroutine.
(WebCore::removeEnclosingMailBlockquoteStyle): Added.
(WebCore::startMarkup): When wrapping text nodes in style spans, leave out
styles that Mail blockquotes contribute, so that Mail blockquote styles can
be differentiated from styles that the user has applied. When creating markup
for elements, do the same thing.
(WebCore::createMarkup): Call the new subroutine.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 18 Nov 2006 00:22:23 +0000 (00:22 +0000)]
Forgoet the project change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 18 Nov 2006 00:21:05 +0000 (00:21 +0000)]
Reviewed by Geoff.
<rdar://problem/
4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebView.mm:
(+[WebView initialize]):
(-[WebView setPreferences:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 17 Nov 2006 20:14:05 +0000 (20:14 +0000)]
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11635
Bug 11635: Fix potential issue with non-xslt build
Fix the issue and do style guideline corrections.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 17 Nov 2006 19:47:46 +0000 (19:47 +0000)]
Reviewed by Harrison.
<rdar://problem/
4843131> text entry is slow inside element that has the deletion rectangle around it
Only disable/enable the delete button inside applyCommand() to prevent slowing down typing.
This reintroduces <rdar://problem/
4796657> table deletion outline does not always follow the table size as editing occurs inside
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply):
(WebCore::EditCommand::unapply):
(WebCore::EditCommand::reapply):
(WebCore::applyCommand):
* editing/EditCommand.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann [Fri, 17 Nov 2006 19:23:45 +0000 (19:23 +0000)]
Reviewed by Mitz. Landed by Niko.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11617
Adapt to latest API changes, fixing Qt/Linux build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Fri, 17 Nov 2006 19:21:22 +0000 (19:21 +0000)]
Reviewed by Adele.
<rdar://problem/
4799899> Frame::revealSelection() only scrolls the startContainer's layer
Replace an assert with a fixme that refers to this bug.
* page/Frame.cpp:
(WebCore::Frame::revealSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 17 Nov 2006 02:11:54 +0000 (02:11 +0000)]
LayoutTests:
Reviewed and landed by Brady
Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=11590
Bug 11590: REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render
* fast/css/import-rule-regression-11590-expected.txt: Added.
* fast/css/import-rule-regression-11590.html: Added.
* fast/css/resources/imports.css: Added.
* fast/css/resources/style.css: Added.
WebCore:
Reviewed and landed by Brady
Fixes http://bugs.webkit.org/show_bug.cgi?id=11590 -
REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render
Fix the regression by setting m_loadCompleted correctly.
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::checkLoaded):
* dom/Node.h:
(WebCore::Node::sheetLoaded):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::sheetLoaded):
* dom/ProcessingInstruction.h:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::sheetLoaded):
* html/HTMLLinkElement.h:
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::sheetLoaded):
* html/HTMLStyleElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Fri, 17 Nov 2006 01:06:58 +0000 (01:06 +0000)]
Reviewed by Beth.
<rdar://problem/
4056100> REGRESSION (Tiger): Deleting top part of reply email leaves fails to clear text at end of message
The problem was triggered by the fact that the parent div was changing both
in position and in height. The renderer normally bifurcates its logic for
x-position changes vs height changes.
Call repaintDuringLayoutIfMoved() with old rect (incl. width and height) instead of just the old position.
Test added:
* manual-tests/delete-into-nested-block.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::positionNewFloats):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintDuringLayoutIfMoved):
* rendering/RenderBox.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::placeChild):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintDuringLayoutIfMoved):
* rendering/RenderObject.h:
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 17 Nov 2006 00:03:01 +0000 (00:03 +0000)]
Reviewed by Adam.
Slider cleanup. Let the theme set the size of the slider thumb.
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::setStyle): Moving the thumb's appearance adjustment to createThumbStyle.
(WebCore::RenderSlider::createThumbStyle):
(WebCore::RenderSlider::layout): Let the theme set the size of the thumb.
* rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbSize): Added.
* rendering/RenderTheme.h: ditto.
* rendering/RenderThemeMac.h: ditto.
* rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 16 Nov 2006 21:22:48 +0000 (21:22 +0000)]
Reviewed by Darin.
Use Vector instead of DeprecatedValueList in a few places.
* bindings/js/kjs_dom.cpp:
(KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
(KJS::DOMNamedNodesCollection::lengthGetter):
(KJS::DOMNamedNodesCollection::getOwnPropertySlot):
* bindings/js/kjs_dom.h:
* bindings/js/kjs_html.cpp:
(KJS::JSHTMLDocument::namedItemGetter):
(KJS::JSHTMLElement::classInfo):
(KJS::JSHTMLElement::accessors):
(KJS::JSHTMLCollection::getNamedItems):
* bindings/objc/DOM.mm:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::dashboardRegionsDictionary):
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::diff):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::namedItems):
* html/HTMLCollection.h:
* kcanvas/KCanvasFilters.cpp:
(WebCore::KCanvasFilter::externalRepresentation):
* kcanvas/KCanvasFilters.h:
(WebCore::KCanvasFEColorMatrix::values):
(WebCore::KCanvasFEColorMatrix::setValues):
(WebCore::KCanvasFEConvolveMatrix::kernel):
(WebCore::KCanvasFEConvolveMatrix::setKernel):
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(WebCore::KCanvasFilterQuartz::getCIFilterStack):
(WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
* ksvg2/svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::filterEffect):
* platform/graphics/svg/SVGResourceClipper.h:
* platform/graphics/svg/cg/SVGResourceClipperCg.cpp:
(WebCore::SVGResourceClipper::applyClip):
* platform/network/FormData.h:
* rendering/RenderPath.h:
* rendering/SVGRenderTreeAsText.h:
(WebCore::operator<<):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 16 Nov 2006 21:03:10 +0000 (21:03 +0000)]
Reviewed by Tim.
* editing/markup.cpp:
(WebCore::createMarkup):
Add null-checks for the frame, it might not exist for all documents.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 16 Nov 2006 20:32:21 +0000 (20:32 +0000)]
2006-11-16 Don Gibson <dgibson77@gmail.com>
Reviewed and landed by ap.
http://bugs.webkit.org/show_bug.cgi?id=11509:
Windows build bustage.
Also reorganizes WebCore.vcproj to add files whose absence wasn't
causing compile errors, but which should have been there, and to
make the include directory ordering (and contents) sane.
Also reorganizes TemporaryLinkStubs.cpp to put headers and
function groups in alphabetical order, and ensure that all functions
in the file call notImplemented().
WebCore:
* WebCore.vcproj/WebCore/WebCore.vcproj:
* bridge/win/ChromeClientWin.h:
(WebCore::ChromeClientWin::ref):
(WebCore::ChromeClientWin::deref):
* bridge/win/ContextMenuClientWin.h: Added.
(WebCore::ContextMenuClientWin::~ContextMenuClientWin):
(WebCore::ContextMenuClientWin::ref):
(WebCore::ContextMenuClientWin::deref):
* bridge/win/EditorClientWin.h:
* bridge/win/FrameWin.cpp:
(WebCore::FrameWin::~FrameWin):
(WebCore::FrameWin::keyPress):
* bridge/win/FrameWin.h:
* bridge/win/PageWin.cpp: Removed.
* editing/EditCommand.h:
* loader/FormState.h:
* loader/FrameLoader.h:
* page/EventHandler.cpp:
* platform/MimeTypeRegistry.cpp:
(WebCore::initialiseSupportedImageMIMETypes):
* platform/graphics/win/ImageWin.cpp:
* platform/network/ResourceError.cpp:
* platform/network/ResourceHandleInternal.h:
* platform/network/win/ResourceHandleWin.cpp:
(WebCore::ResourceHandle::onHandleCreated):
(WebCore::ResourceHandle::onRequestRedirected):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
* platform/win/ScreenWin.cpp:
(WebCore::monitorInfo):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
(WebCore::screenDepth):
* platform/win/SoundWin.cpp: Added.
(WebCore::systemBeep):
* platform/win/TemporaryLinkStubs.cpp:
(WebCore::CacheObjectExpiresTime):
(WebCore::CheckCacheObjectStatus):
(WebCore::CheckIfReloading):
(WebCore::defaultLanguage):
(WebCore::fileButtonChooseFileLabel):
(WebCore::fileButtonNoFileSelectedLabel):
(WebCore::findNextSentenceFromIndex):
(WebCore::findNextWordFromIndex):
(WebCore::findSentenceBoundary):
(WebCore::findWordBoundary):
(WebCore::focusRingColor):
(WebCore::historyContains):
(WebCore::inputElementAltText):
(WebCore::IsResponseURLEqualToURL):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::moveCursor):
(WebCore::verticalTextCursor):
(WebCore::refreshPlugins):
(WebCore::resetButtonDefaultLabel):
(WebCore::ResponseIsMultipart):
(WebCore::ResponseMIMEType):
(WebCore::ResponseURL):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::searchableIndexIntroduction):
(WebCore::ServeSynchronousRequest):
(WebCore::setFocusRingColorChangeFunction):
(WebCore::submitButtonDefaultLabel):
(WebCore::CachedResource::setPlatformResponse):
(WebCore::CachedResource::setAllData):
(WebCore::ChromeClientWin::setWindowRect):
(WebCore::ChromeClientWin::windowRect):
(WebCore::ChromeClientWin::pageRect):
(WebCore::ChromeClientWin::scaleFactor):
(WebCore::ChromeClientWin::focus):
(WebCore::ChromeClientWin::unfocus):
(WebCore::ChromeClientWin::createWindow):
(WebCore::ChromeClientWin::createModalDialog):
(WebCore::ChromeClientWin::show):
(WebCore::ChromeClientWin::canRunModal):
(WebCore::ChromeClientWin::runModal):
(WebCore::ChromeClientWin::setToolbarsVisible):
(WebCore::ChromeClientWin::toolbarsVisible):
(WebCore::ChromeClientWin::setStatusbarVisible):
(WebCore::ChromeClientWin::statusbarVisible):
(WebCore::ChromeClientWin::setScrollbarsVisible):
(WebCore::ChromeClientWin::scrollbarsVisible):
(WebCore::ChromeClientWin::setMenubarVisible):
(WebCore::ChromeClientWin::menubarVisible):
(WebCore::ChromeClientWin::setResizable):
(WebCore::ContextMenu::appendItem):
(WebCore::ContextMenuClientWin::addCustomContextMenuItems):
(WebCore::DocumentLoader::setFrame):
(WebCore::DocumentLoader::frameLoader):
(WebCore::DocumentLoader::URL):
(WebCore::DocumentLoader::isStopping):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::setLoading):
(WebCore::DocumentLoader::updateLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::stopRecordingResponses):
(WebCore::EditorClientWin::shouldDeleteRange):
(WebCore::EditorClientWin::shouldShowDeleteInterface):
(WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
(WebCore::EditorClientWin::isGrammarCheckingEnabled):
(WebCore::EditorClientWin::spellCheckerDocumentTag):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::handleMouseUp):
(WebCore::EventHandler::lastEventIsMouseUp):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::passWheelEventToSubframe):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passMousePressEventToScrollbar):
(WebCore::EventHandler::shouldDragAutoNode):
(WebCore::EventHandler::tabsToAllControls):
(WebCore::EventHandler::tabsToLinks):
(WebCore::Frame::setNeedsReapplyStyles):
(WebCore::FrameLoader::didFirstLayout):
(WebCore::FrameLoader::overrideMediaType):
(WebCore::FrameLoader::createJavaAppletWidget):
(WebCore::FrameLoader::redirectDataToPlugin):
(WebCore::FrameLoader::getHistoryLength):
(WebCore::FrameLoader::setTitle):
(WebCore::FrameLoader::referrer):
(WebCore::FrameLoader::saveDocumentState):
(WebCore::FrameLoader::restoreDocumentState):
(WebCore::FrameLoader::goBackOrForward):
(WebCore::FrameLoader::historyURL):
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::createFrame):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::partClearedInBegin):
(WebCore::FrameLoader::originalRequestURL):
(WebCore::FrameLoader::canGoBackOrForward):
(WebCore::FrameLoader::objectContentType):
(WebCore::FrameLoader::createPlugin):
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameView::updateBorder):
(WebCore::FrameWin::bindingRootObject):
(WebCore::FrameWin::canPaste):
(WebCore::FrameWin::issuePasteAndMatchStyleCommand):
(WebCore::FrameWin::markedTextRange):
(WebCore::FrameWin::passSubframeEventToSubframe):
(WebCore::FrameWin::lastEventIsMouseUp):
(WebCore::FrameWin::addMessageToConsole):
(WebCore::FrameWin::shouldChangeSelection):
(WebCore::FrameWin::respondToChangedSelection):
(WebCore::FrameWin::clearUndoRedoOperations):
(WebCore::FrameWin::markMisspellingsInAdjacentWords):
(WebCore::FrameWin::respondToChangedContents):
(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::setShadow):
(WebCore::GraphicsContext::clearShadow):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::setLineWidth):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::setCompositeOperation):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::scale):
(WebCore::Icon::Icon):
(WebCore::Icon::~Icon):
(WebCore::Icon::newIconForFile):
(WebCore::Icon::paint):
(WebCore::IconDatabase::isIconExpiredForIconURL):
(WebCore::IconDatabase::hasEntryForIconURL):
(WebCore::IconDatabase::sharedIconDatabase):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::Image::drawTiled):
(WebCore::Image::getHBITMAP):
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::contains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::operator=):
(WebCore::Path::clear):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::transform):
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(WebCore::PlatformScrollbar::PlatformScrollbar):
(WebCore::PlatformScrollbar::~PlatformScrollbar):
(WebCore::PlatformScrollbar::width):
(WebCore::PlatformScrollbar::height):
(WebCore::PlatformScrollbar::setEnabled):
(WebCore::PlatformScrollbar::paint):
(WebCore::PlatformScrollbar::updateThumbPosition):
(WebCore::PlatformScrollbar::updateThumbProportion):
(WebCore::PlatformScrollbar::setRect):
(WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
(WebCore::PlugInInfoStore::pluginCount):
(WebCore::PlugInInfoStore::supportsMIMEType):
(WebCore::PolicyCheck::PolicyCheck):
(WebCore::PolicyCheck::clear):
(WebCore::PolicyCheck::clearRequest):
(WebCore::PolicyCheck::call):
(WebCore::RenderThemeWin::systemFont):
(WebCore::RenderThemeWin::paintMenuList):
(WebCore::RenderThemeWin::adjustMenuListStyle):
(WebCore::ResourceLoader::cancel):
(WebCore::ScrollView::addChild):
(WebCore::ScrollView::removeChild):
(WebCore::ScrollView::scrollPointRecursively):
(WebCore::ScrollView::inWindow):
(WebCore::ScrollView::paint):
(WebCore::ScrollView::wheelEvent):
(WebCore::ScrollView::themeChanged):
(WebCore::ScrollView::convertChildToSelf):
(WebCore::ScrollView::convertSelfToChild):
(WebCore::ScrollView::geometryChanged):
(WebCore::ScrollView::scrollbarUnderMouse):
(WebCore::ScrollView::setFrameGeometry):
(WebCore::ScrollView::windowResizerRect):
(WebCore::ScrollView::resizerOverlapsContent):
(WebCore::TextField::selectAll):
(WebCore::TextField::addSearchResult):
(WebCore::TextField::selectionStart):
(WebCore::TextField::hasSelectedText):
(WebCore::TextField::selectedText):
(WebCore::TextField::setAutoSaveName):
(WebCore::TextField::checksDescendantsForFocus):
(WebCore::TextField::setSelection):
(WebCore::TextField::setMaxResults):
(WebCore::TextField::edited):
(WebCore::TextField::focusPolicy):
(WebCore::TextField::TextField):
(WebCore::TextField::~TextField):
(WebCore::TextField::setFont):
(WebCore::TextField::setAlignment):
(WebCore::TextField::setWritingDirection):
(WebCore::TextField::maxLength):
(WebCore::TextField::setMaxLength):
(WebCore::TextField::text):
(WebCore::TextField::setText):
(WebCore::TextField::cursorPosition):
(WebCore::TextField::setCursorPosition):
(WebCore::TextField::setEdited):
(WebCore::TextField::setReadOnly):
(WebCore::TextField::setPlaceholderString):
(WebCore::TextField::setColors):
(WebCore::TextField::sizeForCharacterWidth):
(WebCore::TextField::baselinePosition):
(WebCore::TextField::setLiveSearch):
(WebCore::Widget::enableFlushDrawing):
(WebCore::Widget::isEnabled):
(WebCore::Widget::focusPolicy):
(WebCore::Widget::disableFlushDrawing):
(WebCore::Widget::removeFromParent):
(WebCore::Widget::lockDrawingFocus):
(WebCore::Widget::unlockDrawingFocus):
(WebCore::Widget::capturingMouse):
(WebCore::Widget::setCapturingMouse):
(WebCore::Widget::capturingTarget):
(WebCore::Widget::capturingChild):
(WebCore::Widget::setCapturingChild):
(WebCore::Widget::convertChildToSelf):
(WebCore::Widget::convertSelfToChild):
(WebCore::Widget::setParent):
(WebCore::Widget::parent):
(WebCore::Widget::setEnabled):
(WebCore::Widget::paint):
(WebCore::Widget::setIsSelected):
(WebCore::Widget::invalidate):
(WebCore::Widget::invalidateRect):
* platform/win/WidgetWin.cpp:
(WebCore::Widget::clearFocus):
WebKit:
* COM/WebFrame.cpp:
(WebFrame::initWithName):
(WebFrame::loadHTMLString):
(WebFrame::stopLoading):
(WebFrame::reload):
(WebFrame::loadDataSource):
(WebFrame::didReceiveData):
(WebFrame::receivedResponse):
(WebFrame::receivedAllData):
* COM/WebFrame.h:
* COM/WebView.cpp:
(WebView::mouseMoved):
(WebView::mouseDown):
(WebView::mouseUp):
(WebView::mouseDoubleClick):
* WebKit.vcproj/WebKit.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 16 Nov 2006 19:58:02 +0000 (19:58 +0000)]
Reviewed by Adam.
<rdar://problem/
4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made
* editing/markup.cpp:
(WebCore::createMarkup): disable the delete button so it's elements are not serialized into the markup
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 16 Nov 2006 19:52:28 +0000 (19:52 +0000)]
Rubberstamped by Maciej.
Making the code valgrind clean.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 16 Nov 2006 19:49:12 +0000 (19:49 +0000)]
Reviewed by Tim.
<rdar://problem/
4841123>
REGRESSION: Crash in WebCore::Range::boundaryPointsValid when replying to a mail Message
* Misc/WebNSAttributedStringExtras.m:
(+[NSAttributedString _web_attributedStringFromRange:]):
If the range passed in is null, return null. When this function was in the bridge, it would never get called
with a null range when nothing was selected. Instead, the range would just have invalid boundary points.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 16 Nov 2006 18:35:57 +0000 (18:35 +0000)]
Adding back a correct version of this assert.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Thu, 16 Nov 2006 17:59:49 +0000 (17:59 +0000)]
Reviewed by Darin and Tim.
<rdar://problem/
4799949> REGRESSION: Crash in FrameMac::eventMayStartDrag() by clicking on a page
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::eventMayStartDrag):
Add nil check of hitTest's result.innerNode().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 16 Nov 2006 17:52:33 +0000 (17:52 +0000)]
Reviewed by Darin.
<rdar://problem/
4836897> Deletion rectangle disappears when multiple list items are selected
Consider the container of the selection range for deletion before asking enclosingNodeOfType().
* editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Thu, 16 Nov 2006 08:43:25 +0000 (08:43 +0000)]
Reviewed by hyatt.
Removal of unused m_styleElement.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 16 Nov 2006 07:14:38 +0000 (07:14 +0000)]
Build fix.
Rename the items in the ContextMenuAction enum so that they don't
conflict with WebKit names.
* WebCore.xcodeproj/project.pbxproj:
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::populate):
* platform/ContextMenu.h:
(WebCore::):
(WebCore::ContextMenuItem::ContextMenuItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 16 Nov 2006 06:56:05 +0000 (06:56 +0000)]
Reviewed by Anders.
Change m_contextMenu to an OwnPtr.
* WebCore.xcodeproj/project.pbxproj:
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::handleContextMenuEvent):
* page/ContextMenuController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 16 Nov 2006 06:43:58 +0000 (06:43 +0000)]
WebCore:
Reviewed by Anders.
Add new ContextMenuController and ContextMenuClient classes, and move
context menu responsibilities from Chrome and ChromeClient to them.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj: Add new files to project, and
alphabetize some others.
* page/Chrome.cpp: Remove context menu-related code.
* page/Chrome.h: Ditto.
* page/ChromeClient.h:
* page/ContextMenuClient.h: Added.
* page/ContextMenuController.cpp: Added.
(WebCore::ContextMenuController::ContextMenuController):
(WebCore::ContextMenuController::~ContextMenuController):
(WebCore::ContextMenuController::handleContextMenuEvent):
(WebCore::ContextMenuController::contextMenuActionSelected):
* page/ContextMenuController.h: Added.
(WebCore::ContextMenuController::client):
* page/Page.cpp: Every Page now has a ContextMenuController.
(WebCore::Page::Page):
* page/Page.h: Made m_dragCaretController and m_chrome objects instead
of pointers to objects.
(WebCore::Page::contextMenuController):
* platform/ContextMenu.cpp:
(WebCore::ContextMenu::populate): Removed the call to Chrome to ask the
delegate to add its menu items, and moved the code from the static
addDefaultItems function into this method.
* platform/ContextMenu.h:
(WebCore::ContextMenu::show): Added an empty method body since this
method is now called from ContextMenuController (although no one calls
into ContextMenuController yet, so it's OK for this to be empty).
(WebCore::ContextMenu::hide): Ditto.
WebKit:
Reviewed by Anders.
Added new WebContextMenuClient class to act as WebCore's ChromeClient,
and moved context menu-related code there from WebChromeClient.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
* WebCoreSupport/WebContextMenuClient.h: Added.
(WebContextMenuClient::webView):
* WebCoreSupport/WebContextMenuClient.mm: Added.
(WebContextMenuClient::create):
(WebContextMenuClient::WebContextMenuClient):
(WebContextMenuClient::ref):
(WebContextMenuClient::deref):
(WebContextMenuClient::addCustomContextMenuItems):
* WebKit.xcodeproj/project.pbxproj: Added new files.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 16 Nov 2006 05:53:18 +0000 (05:53 +0000)]
Removing this assert until I can look into the problem further.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 16 Nov 2006 04:23:46 +0000 (04:23 +0000)]
Reviewed by Darin.
Add null checks on the node filter, they can be null if no filter was passed to the respective
create functions.
* bindings/js/JSNodeIteratorCustom.cpp:
(WebCore::JSNodeIterator::mark):
* bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::mark):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Thu, 16 Nov 2006 03:07:42 +0000 (03:07 +0000)]
2006-11-15 Oliver Hunt <oliver@apple.com>
Reviewed by Anders.
Allow <embed> and <object> tags to include non-plugin
content when plugins are disabled
Fixes <rdar://problems/
4839488>
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::rendererIsNeeded):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::rendererIsNeeded):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::requestObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 16 Nov 2006 02:34:44 +0000 (02:34 +0000)]
Build fix. Another type problem that I don't see locally.
* rendering/RenderSlider.cpp: (WebCore::RenderSlider::setPositionFromValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 16 Nov 2006 02:24:44 +0000 (02:24 +0000)]
Reviewed by Adam.
Adding MathExtras header.
* rendering/RenderSlider.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 16 Nov 2006 02:00:56 +0000 (02:00 +0000)]
Reviewed by Harrison.
<rdar://problem/
4832894> Crash deleting an element inside a list while deletion rectangle is visible (compareBoundaryPoints)
* Disable and hide the deletion UI for each editing command. This prevents editing commands from being affected
by the deletion UI elements we insert. The deletion UI is then shown after the editing commands are completely done.
* Multiple calls to DeleteButtonController's disable() needed to be paired with the same number of enable() calls before
the deletion UI is enabled again. This allows for nested editing commands to be called without thrashing the deletion UI.
* Make sure the the renderers are currently reflecting the latest style changes, so call updateLayoutIgnorePendingStylesheets().
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::DeleteButtonController):
(WebCore::isDeletableElement):
(WebCore::DeleteButtonController::respondToChangedSelection): check the enabled state
(WebCore::DeleteButtonController::respondToChangedContents): check the enabled state
(WebCore::DeleteButtonController::show): call isDeletableElement() to make sure the element is allowed
(WebCore::DeleteButtonController::deleteTarget): check the enabled state
* editing/DeleteButtonController.h:
(WebCore::DeleteButtonController::disable):
(WebCore::DeleteButtonController::enable):
(WebCore::DeleteButtonController::enabled):
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply): hide and disable the deletion UI, then show at the end
(WebCore::EditCommand::unapply): ditto
(WebCore::EditCommand::reapply): ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 16 Nov 2006 01:42:28 +0000 (01:42 +0000)]
LayoutTests:
Reviewed by Adam.
Updating results for new slider implementation.
* fast/forms/input-appearance-height-expected.checksum:
* fast/forms/input-appearance-height-expected.png:
* fast/forms/input-appearance-height-expected.txt:
WebCore:
Reviewed by Adam.
New implementation of slider control.
* WebCore.xcodeproj/project.pbxproj: Removed DeprecatedSlider and Slider classes, added RenderSlider class.
* rendering/DeprecatedSlider.cpp: Removed.
* rendering/DeprecatedSlider.h: Removed.
* platform/Slider.h: Removed.
* platform/mac/SliderMac.mm: Removed.
* platform/win/TemporaryLinkStubs.cpp:
* css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoElement for thumb, PseudoSliderThumb.
* css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added code for "-webkit-slider-thumb".
* css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
* rendering/RenderStyle.cpp:
(WebCore::):
(WebCore::pseudoBit):
* rendering/RenderStyle.h: (WebCore::RenderStyle::):
* css/html4.css: Added style for input[type="range"] and input[type="range"]::-webkit-slider-thumb
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::createRenderer): Create RenderSlider for input type="range" elements.
(WebCore::HTMLInputElement::defaultEventHandler): Allow the renderer to forward events, and set thumb position when click occurs on the track.
* page/EventHandler.cpp: Added concept of a node that will capture all mouse events. This will be used by the slider thumb, so it can
continue to capture mouse move events during the drag, even though those events aren't directly over the slider.
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::setCapturingMouseEventsNode):
(WebCore::EventHandler::dispatchMouseEvent): If the capturingMouseEventsNode is set, then dispatch all mouse events to that node.
* page/EventHandler.h:
* rendering/RenderSlider.cpp: Added.
(WebCore::HTMLSliderThumbElement::isShadowNode):
(WebCore::HTMLSliderThumbElement::shadowParentNode):
(WebCore::HTMLSliderThumbElement::inDragMode): Keeps track of whether or not the thumb is in drag mode.
(WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement):
(WebCore::HTMLSliderThumbElement::defaultEventHandler): Handles positioning of slider thumb during drag.
(WebCore::RenderSlider::RenderSlider):
(WebCore::RenderSlider::~RenderSlider):
(WebCore::RenderSlider::baselinePosition):
(WebCore::RenderSlider::calcMinMaxWidth):
(WebCore::RenderSlider::setStyle):
(WebCore::RenderSlider::createThumbStyle):
(WebCore::RenderSlider::layout): Positions the thumb to be centered on the track.
(WebCore::RenderSlider::updateFromElement):
(WebCore::RenderSlider::mouseEventIsInThumb):
(WebCore::RenderSlider::setValueForPosition):
(WebCore::RenderSlider::setPositionFromValue):
(WebCore::RenderSlider::positionForOffset):
(WebCore::RenderSlider::valueChanged):
(WebCore::RenderSlider::currentPosition):
(WebCore::RenderSlider::setCurrentPosition):
(WebCore::RenderSlider::trackSize):
(WebCore::RenderSlider::forwardEvent):
(WebCore::RenderSlider::inDragMode):
* rendering/RenderSlider.h: Added.
(WebCore::RenderSlider::renderName):
* rendering/RenderTheme.cpp: Added drawing code for slider track and thumb.
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::adjustSliderTrackStyle):
(WebCore::RenderTheme::adjustSliderThumbStyle):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::paintSliderTrack):
(WebCore::RenderTheme::paintSliderThumb):
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::TrackGradientInterpolate):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Thu, 16 Nov 2006 01:36:10 +0000 (01:36 +0000)]
Reviewed by Adam.
Oops! Forgot to add this!
* platform/mac/ContextMenuMac.mm: Added.
(-[MenuTarget forwardContextMenuAction:initWithContextMenu:WebCore::]):
(-[MenuTarget WebCore::]):
(-[MenuTarget setMenu:WebCore::]):
(-[MenuTarget forwardContextMenuAction:]):
(getNSMenuItem):
(ContextMenu::appendItem):
(ContextMenu::itemCount):
(ContextMenu::insertItem):
(ContextMenu::setPlatformMenuDescription):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Thu, 16 Nov 2006 01:27:16 +0000 (01:27 +0000)]
WebCore:
Reviewed by Adam and Beth.
Initial cut at pushing Context Menus into WebCore. Nobody actually
calls this code just yet.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* page/Chrome.cpp:
(WebCore::Chrome::addCustomContextMenuItems): Use the chrome to
call into addContextMenuItems on the UIDelegate.
* page/Chrome.h:
* page/ChromeClient.h:
* platform/ContextMenu.cpp: Added.
(WebCore::addDefaultItems):
(WebCore::ContextMenu::populate):
* platform/ContextMenu.h: Added.
(WebCore::):
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::hitTestResult):
(WebCore::ContextMenu::platformMenuDescription):
WebKit:
Reviewed by Adam & Beth.
WebKit side of first cut at engine context menus. Use the client to
call into the UIDelegate.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::addCustomContextMenuItems):
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Thu, 16 Nov 2006 00:56:51 +0000 (00:56 +0000)]
Reviewed by Maciej
Quick change of files to ObjC++ for BF cache re-write
* History/WebBackForwardList.m: Removed.
* History/WebBackForwardList.mm: Added.
* History/WebHistoryItem.m: Removed.
* History/WebHistoryItem.mm: Added.
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 15 Nov 2006 23:49:19 +0000 (23:49 +0000)]
Reviewed by Hyatt.
- Fix for <rdar://problem/
4780306> REGRESSION: clicking in textarea does not set selection at PunBB.org
* css/html4.css: Removed "-webkit-user-select: ignore" for labels.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 15 Nov 2006 21:44:45 +0000 (21:44 +0000)]
Reviewed by Sarge
SPI addition
* WebView/WebFrame.mm:
(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
* WebView/WebFrameInternal.h:
* WebView/WebFramePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 15 Nov 2006 19:46:50 +0000 (19:46 +0000)]
Reviewed by Adele
<rdar://problem/
4838729> - Replace mistakenly removed SPI
* WebView/WebHTMLView.m:
(-[WebHTMLView _handleAutoscrollForMouseDragged:]):
* WebView/WebHTMLViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 15 Nov 2006 19:41:26 +0000 (19:41 +0000)]
Explicitly set GCC 4 for all of our projects, since the system default can be GCC 3.3.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Wed, 15 Nov 2006 19:35:42 +0000 (19:35 +0000)]
Reviewed by Darin.
<rdar://problem/
4836034> REGRESSION: Hang while spell-checking (advanceToNextMisspelling)
Test:
* manual-tests/keep_spelling_markers.html:
Updated to include checking for this bug.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::advanceToNextMisspelling):
it.advance() even when current string is a single space.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 15 Nov 2006 19:24:35 +0000 (19:24 +0000)]
Reviewed by lamadio
Backing out macro expansion
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::isRecognizedTagName):
* ksvg2/scripts/make_names.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Wed, 15 Nov 2006 18:41:41 +0000 (18:41 +0000)]
Reviewed by Darin.
<rdar://problem/
4770453> VO not honoring secure edit fields in web pages
The remaining problem was the password fields would return their contents
even though they did not advertise that they could. Apparently, VoiceOver
does not read the ads.
* bridge/mac/WebCoreAXObject.mm:
(isPasswordFieldElement):
(-[WebCoreAXObject isPasswordField]):
(-[WebCoreAXObject textMarkerForVisiblePosition:]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
(-[WebCoreAXObject doAXStringForRange:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lamadio [Wed, 15 Nov 2006 18:19:37 +0000 (18:19 +0000)]
2006-11-13 Lou Amadio <lamadio@apple.com>
Reviewed by Darin Adler, Maciej Stachowiak
Cleanup: Expanded macros in generated files
* html/HTMLElement.cpp:
(WebCore::HTMLElement::isRecognizedTagName):
* ksvg2/scripts/make_names.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 17:34:13 +0000 (17:34 +0000)]
Reviewed by Geoff.
Use Vector instead of DeprecatedPtrList.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
* editing/BreakBlockquoteCommand.cpp:
* rendering/RenderFlow.cpp:
(WebCore::RenderFlow::paintOutline):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 17:24:05 +0000 (17:24 +0000)]
Reviewed by Adele.
isTargetItem is used by DRT, so make it private instead of internal.
* History/WebHistoryItem.m:
(-[WebHistoryItem isTargetItem]):
* History/WebHistoryItemInternal.h:
* History/WebHistoryItemPrivate.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 15 Nov 2006 09:45:48 +0000 (09:45 +0000)]
Build fix.
* page/EventHandler.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 15 Nov 2006 09:29:28 +0000 (09:29 +0000)]
Reviewed by Maciej
Split much of unused WebHistoryItemPrivate.h SPI into WebHistoryItemInternal.h
* History/WebBackForwardList.m:
* History/WebHistory.m:
* History/WebHistoryItem.m:
(-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
(-[WebHistoryItem initWithURL:title:]):
(-[WebHistoryItem visitCount]):
(-[WebHistoryItem RSSFeedReferrer]):
(-[WebHistoryItem setRSSFeedReferrer:]):
(-[WebHistoryItem children]):
(-[WebHistoryItem dictionaryRepresentation]):
(-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
(+[WebHistoryItem _releaseAllPendingPageCaches]):
(-[WebHistoryItem URL]):
(-[WebHistoryItem target]):
(-[WebHistoryItem _setLastVisitedTimeInterval:]):
(-[WebHistoryItem _lastVisitedDate]):
(-[WebHistoryItem targetItem]):
* History/WebHistoryItemInternal.h: Added.
* History/WebHistoryItemPrivate.h:
* WebCoreSupport/WebFrameBridge.mm:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebFrame.mm:
* WebView/WebView.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 15 Nov 2006 06:57:15 +0000 (06:57 +0000)]
2006-11-14 Matt Lilek <pewtermoose@gmail.com>
Reviewed by Tim Hatcher.
Moved the web developer page to the wiki, adding link to the Drosera page.
* .htaccess: Add permanent redirect to the new page on the wiki.
* contact.html: Trac numbers are no longer one off.
* nav.inc:
* webdevelopers/index.html: Removed.
* webdevelopers/webkit_version.html: Removed.
* webdevelopers/webkit_version.js: Removed.
* webdevelopers/webkit_version_xl.html: Removed.
* webdevelopers/webkit_version_xl.js: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 15 Nov 2006 06:09:32 +0000 (06:09 +0000)]
WebCore:
Reviewed by Geoff.
Moving things off the bridge and onto clients.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::selectWordBeforeMenuEvent):
(WebEditorClient::isEditable):
* WebCoreSupport/WebFrameBridge.mm:
* WebKit.xcodeproj/project.pbxproj:
WebKit:
Reviewed by Geoff.
Move things off the bridge, and move sendContextMenuEvent() from
EventHandlerMac to EventHandler.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bridge/EditorClient.h:
* bridge/mac/WebCoreFrameBridge.h:
* editing/Editor.cpp:
(WebCore::Editor::selectWordBeforeMenuEvent):
(WebCore::Editor::clientIsEditable):
* editing/Editor.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):
* page/EventHandler.h:
* page/mac/EventHandlerMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 15 Nov 2006 05:42:44 +0000 (05:42 +0000)]
WebCore:
Reviewed by Harrison.
<rdar://problem/
4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
Adds an EditableLinkNeverLive setting that will make links in editable areas always dead.
* bridge/mac/WebCoreSettings.mm:
(-[WebCoreSettings setEditableLinkBehavior:]):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::setActive):
(WebCore::HTMLAnchorElement::isLiveLink):
* page/FrameView.cpp:
(WebCore::selectCursor):
* page/Settings.h:
(WebCore::Settings::):
WebKit:
Reviewed by Harrison.
<rdar://problem/
4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
Adds an Open Link, Open Link in New Window and Copy Link to the editing context menu.
Adds a new WebKitEditableLinkNeverLive preference value that maps to WebCore's EditableLinkNeverLive.
* DefaultDelegates/WebDefaultContextMenuDelegate.m:
(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
(-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
(-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
(-[WebDefaultUIDelegate requestWithURL:includingReferrerFromFrame:]):
(-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
(-[WebDefaultUIDelegate openLink:]):
* English.lproj/Localizable.strings:
* WebKit.exp:
* WebView/WebPreferences.m:
(-[WebPreferences editableLinkBehavior]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebUIDelegatePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 15 Nov 2006 05:17:41 +0000 (05:17 +0000)]
2006-11-14 Mark Rowe <bdash@webkit.org>
Reviewed by Oliver.
Build fix
* bindings/scripts/CodeGenerator.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 05:06:24 +0000 (05:06 +0000)]
WebCore:
Turns out I wasn't forcing DWARF on the world at all,
it's now the default!
* WebCore.xcodeproj/project.pbxproj:
WebKit:
Turns out I wasn't forcing DWARF on the world at all,
it's now the default!
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 05:01:15 +0000 (05:01 +0000)]
WebCore:
I must stop trying to force DWARF on the world.
* WebCore.xcodeproj/project.pbxproj:
WebKit:
I must stop trying to force DWARF on the world.
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 15 Nov 2006 03:52:19 +0000 (03:52 +0000)]
LayoutTests:
Reviewed by harrison
<rdar://problem/
4806874>
Missing background image after paste
Checking in new expected results for fixes:
* editing/inserting/insert-
3851164-fix-expected.checksum:
* editing/inserting/insert-
3851164-fix-expected.png:
* editing/selection/drag-in-iframe-expected.checksum:
* editing/selection/drag-in-iframe-expected.png:
Same, but also removing an outdated comment about a bug:
* editing/pasteboard/paste-text-019-expected.checksum:
* editing/pasteboard/paste-text-019-expected.png:
* editing/pasteboard/paste-text-019-expected.txt:
* editing/pasteboard/paste-text-019.html:
Added:
* editing/pasteboard/
4806874-expected.checksum: Added.
* editing/pasteboard/
4806874-expected.png: Added.
* editing/pasteboard/
4806874-expected.txt: Added.
* editing/pasteboard/
4806874.html: Added.
Equivalent render trees:
* editing/inserting/insert-
3907422-fix-expected.txt:
* editing/pasteboard/paste-text-011-expected.txt:
* editing/pasteboard/paste-text-015-expected.txt:
WebCore:
Reviewed by harrison
<rdar://problem/
4806874>
Missing background image after paste
* editing/markup.cpp:
(WebCore::createMarkup): If the body is fully selected, add a
div with its CSS properties to the markup. Migrated a use of
enclosingBlockFlowElement to enclosingBlock to fix an infinite
loop when pasting <div><input></div>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 03:20:06 +0000 (03:20 +0000)]
2006-11-14 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
Add Undo/Redo to execCommand.
* editing/Editor.cpp:
(WebCore::execRedo):
(WebCore::execUndo):
(WebCore::canRedo):
(WebCore::canUndo):
(WebCore::CommandEntry::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 15 Nov 2006 01:29:46 +0000 (01:29 +0000)]
WebCore:
Reviewed by Anders.
- created EventHandler class, moved event handling code from both
Frame and FrameView in there
- added ScrollTypes.h header so you can include the scroller-related
enums without all of Scrollbar.h
* page/EventHandler.cpp: Added.
* page/EventHandler.h: Added.
* page/mac/EventHandlerMac.mm: Added.
* platform/ScrollBarMode.h: Removed.
* platform/ScrollTypes.h: Added.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::FrameMac):
(WebCore::FrameMac::~FrameMac):
(WebCore::FrameMac::bridgeForWidget):
(WebCore::FrameMac::imageFromRect):
* bridge/mac/FrameViewMac.mm:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge scrollOverflowInDirection:granularity:]):
(-[WebCoreFrameBridge nextKeyView]):
(-[WebCoreFrameBridge previousKeyView]):
(-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]):
(-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):
(-[WebCoreFrameBridge _visiblePositionForPoint:]):
(-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
(-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
(-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
(-[WebCoreFrameBridge dragSourceMovedTo:]):
(-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
* dom/Document.cpp:
(WebCore::Document::hoveredNodeDetached):
* dom/Element.h:
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::defaultEventHandler):
* editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController):
* editing/SelectionController.h:
(WebCore::SelectionController::setCaretBlinkingSuspended):
(WebCore::SelectionController::isCaretBlinkingSuspended):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isKeyboardFocusable):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setFocus):
* html/HTMLFrameElementBase.h:
* html/HTMLGenericFormElement.cpp:
(WebCore::HTMLGenericFormElement::isKeyboardFocusable):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::open):
* page/Frame.cpp:
(WebCore::Frame::caretBlinkTimerFired):
(WebCore::Frame::frameForWidget):
(WebCore::Frame::eventHandler):
(WebCore::Frame::setProhibitsScrolling):
(WebCore::FramePrivate::FramePrivate):
* page/Frame.h:
* page/FramePrivate.h:
* page/FrameView.cpp:
(WebCore::FrameViewPrivate::FrameViewPrivate):
(WebCore::FrameViewPrivate::reset):
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::clear):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::addRepaintInfo):
(WebCore::FrameView::layout):
(WebCore::FrameView::scrollPointRecursively):
(WebCore::FrameView::setContentsPos):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::scheduleEvent):
(WebCore::FrameView::updateOverflowStatus):
(WebCore::FrameView::dispatchScheduledEvents):
(WebCore::FrameView::windowClipRectForLayer):
(WebCore::FrameView::handleMouseMoveEvent):
(WebCore::FrameView::handleMouseReleaseEvent):
* page/FrameView.h:
* page/PageState.cpp:
(WebCore::PageState::PageState):
(WebCore::PageState::restore):
* page/PageState.h:
* platform/ScrollBar.h:
* platform/ScrollView.h:
* platform/mac/ClipboardMac.mm:
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::show):
* platform/mac/SliderMac.mm:
(-[WebCoreSlider becomeFirstResponder]):
(-[WebCoreSlider nextKeyView]):
(-[WebCoreSlider previousKeyView]):
(-[WebCoreSlider canBecomeKeyView]):
(Slider::focusPolicy):
* platform/mac/WebCoreTextField.mm:
(-[WebCoreTextFieldController textView:shouldHandleEvent:]):
(-[WebCoreTextFieldController setHasFocus:]):
(-[WebCoreSearchField nextKeyView]):
(-[WebCoreSearchField previousKeyView]):
(-[WebCoreSearchFieldCell _addStringToRecentSearches:]):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::hasFocus):
(WebCore::Widget::clearFocus):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::setResizing):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::autoscroll):
(WebCore::RenderLayer::resize):
(WebCore::RenderLayer::updateOverflowStatus):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::autoscroll):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::draggableNode):
(WebCore::RenderObject::destroy):
* rendering/RenderObject.h:
(WebCore::RenderObject::RepaintInfo::RepaintInfo):
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::viewCleared):
WebKit:
Reviewed by Anders.
- update for creation of EventHandler
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::actionDictionary):
* WebView/WebHTMLView.m:
(-[WebHTMLView _updateMouseoverWithEvent:]):
(-[NSArray menuForEvent:]):
(-[NSArray scrollWheel:]):
(-[NSArray acceptsFirstMouse:]):
(-[NSArray shouldDelayWindowOrderingForEvent:]):
(-[NSArray mouseDown:]):
(-[NSArray mouseDragged:]):
(-[NSArray mouseUp:]):
(-[NSArray keyDown:]):
(-[NSArray keyUp:]):
(-[NSArray performKeyEquivalent:]):
(-[WebHTMLView elementAtPoint:allowShadowContent:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 01:21:36 +0000 (01:21 +0000)]
Fix build for real this time.
* WebCoreSupport/WebEditorClient.mm:
(-[WebEditCommand initWithEditCommand:WebCore::]):
(-[WebEditCommand dealloc]):
(-[WebEditCommand finalize]):
(+[WebEditCommand commandWithEditCommand:]):
(-[WebEditCommand command]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 01:07:43 +0000 (01:07 +0000)]
2006-11-14 Anders Carlsson <acarlsson@apple.com>
Try fixing the build.
* WebCoreSupport/WebEditorClient.mm:
(-[WebEditorUndoTarget undoEditing:]):
(-[WebEditorUndoTarget redoEditing:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 15 Nov 2006 00:36:50 +0000 (00:36 +0000)]
WebCore:
Reviewed by Darin.
Let the editor client handle undo/redo.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bridge/EditorClient.h:
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::canUndo):
(WebCore::FrameMac::canRedo):
* bridge/mac/WebCoreEditCommand.h: Removed.
* bridge/mac/WebCoreEditCommand.mm: Removed.
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
* editing/JSEditor.cpp:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::closeURL):
* page/Frame.cpp:
* page/Frame.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::updateFromElement):
WebKit:
Reviewed by Darin.
Move undo/redo handling into WebEditorClient.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::WebEditorClient):
(WebEditorClient::~WebEditorClient):
(-[WebEditCommand initWithEditCommand:WebCore::]):
(-[WebEditCommand dealloc]):
(-[WebEditCommand finalize]):
(+[WebEditCommand commandWithEditCommand:]):
(-[WebEditCommand command]):
(-[WebEditorUndoTarget undoEditing:]):
(-[WebEditorUndoTarget redoEditing:]):
(undoNameForEditAction):
(WebEditorClient::registerCommandForUndoOrRedo):
(WebEditorClient::registerCommandForUndo):
(WebEditorClient::registerCommandForRedo):
(WebEditorClient::clearUndoRedoOperations):
(WebEditorClient::canUndo):
(WebEditorClient::canRedo):
(WebEditorClient::undo):
(WebEditorClient::redo):
* WebCoreSupport/WebFrameBridge.mm:
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 14 Nov 2006 22:33:49 +0000 (22:33 +0000)]
Reviewed and landed by Brady
Fix Qt/Linux build.
* ChangeLog:
* loader/qt/FrameLoaderQt.cpp:
(WebCore::FrameLoader::submitForm):
* platform/network/qt/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::add):
* platform/qt/FrameQtClient.cpp:
(WebCore::FrameQtClientDefault::submitForm):
* platform/qt/FrameQtClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 14 Nov 2006 21:51:02 +0000 (21:51 +0000)]
Fixing the site.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 14 Nov 2006 21:44:01 +0000 (21:44 +0000)]
2006-11-14 Mark Rowe <bdash@webkit.org>
Reviewed by Tim Hatcher.
http://bugs.webkit.org/show_bug.cgi?id=9529
Bug 9529: Navigation HTML duplicated on webkit.org web site
* blog/wp-content/themes/webkit/sidebar.php: Include navigation from nav.inc rather than duplicating it here.
* nav.inc: Generate WordPress archive list if included from within WordPress.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 14 Nov 2006 19:52:07 +0000 (19:52 +0000)]
Reviewed by Anders
Cleanup of my patch last night and merging with aroben-style changes from this morning
(More ref-counted FormData stuff)
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::postData):
* platform/network/ResourceHandle.h:
* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::setHTTPBody):
* platform/network/mac/FormDataStreamMac.h:
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::getStreamFormDatas):
(WebCore::formCreate):
(WebCore::formFinalize):
(WebCore::setHTTPBody):
(WebCore::httpBodyFromStream):
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::getResourceRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 14 Nov 2006 18:57:01 +0000 (18:57 +0000)]
2006-11-14 Rob Buis <buis@kde.org>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11575
Bug 11575: REGRESSION: WebCore crash in CSSParser/HTMLTokenizer
Test: fast/css/css-imports.html
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::insertedIntoParent):
Fix the crash by testing for null pointer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 14 Nov 2006 18:11:51 +0000 (18:11 +0000)]
Reviewed by Tim H.
http://bugs.webkit.org/show_bug.cgi?id=3387
Redundant keydown, keypress, keyup events sent for arrow keys
Added another layer of ugly hacks around AppKit event dispatching.
1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store
_private->keyDownEvent in both methods, and make it persist after leaving them.
2. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind,
use [NSApp currentEvent] to check for this to prevent it from being passed to WebCore.
Test: manual-tests/arrow-key-events.html
* WebView/WebHTMLView.m:
(-[NSMutableDictionary dealloc]):
(-[NSArray keyDown:]):
(-[NSArray keyUp:]):
(-[NSArray performKeyEquivalent:]):
* WebView/WebHTMLViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 14 Nov 2006 18:06:07 +0000 (18:06 +0000)]
2006-11-14 Darin Adler <darin@apple.com>
Reviewed by Adam.
Fix up usages of FormData within CFNet loader code.
* platform/network/ResourceRequest.h:
(WebCore::ResourceRequest::httpBody):
* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::getStreamFormDatas): Store RefPtr<FormData>s in the
streamFormDatas HashMap.
(WebCore::formCreate):
(WebCore::formFinalize): Removed delete because the remove() will deref
and delete if necessary.
(WebCore::setHTTPBody): Changed parameter to PassRefPtr.
(WebCore::httpBodyFromStream):
* platform/network/cf/FormDataStreamCFNet.h: Fix declarations.
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::getResourceRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 14 Nov 2006 11:55:34 +0000 (11:55 +0000)]
2006-11-14 Greg Jackson <gjspanner@gmail.com>
Reviewed by Darin.
Preserves any pre-existing value for WEBCORE_NAVIGATOR_PLATFORM
rather than overriding it based on platform detection.
* bindings/js/kjs_navigator.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 14 Nov 2006 03:54:33 +0000 (03:54 +0000)]
Reviewed by Maciej
Made FormData Shared, and pass it around as such.
* WebCore.xcodeproj/project.pbxproj: Reordered some items
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formData):
(WebCore::HTMLFormElement::submit):
* html/HTMLFormElement.h:
* loader/FrameLoader.cpp:
(WebCore::FormSubmission::FormSubmission):
(WebCore::FrameLoader::submitForm):
* loader/FrameLoader.h:
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::post):
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::create):
* platform/network/FormData.h: Made FormData shared
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::postData):
* platform/network/ResourceRequest.h:
(WebCore::ResourceRequest::httpBody):
(WebCore::ResourceRequest::setHTTPBody):
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::getResourceRequest):
(WebCore::nsURLRequest):
* platform/network/mac/FormDataStreamMac.h:
* platform/network/mac/FormDataStreamMac.mm:
(WebCore::getStreamFormDatas): Hash Streams to RefPtr<FormData>s
(WebCore::formCreate):
(WebCore::formFinalize):
(WebCore::setHTTPBody):
(WebCore::httpBodyFromStream):
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::send):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 14 Nov 2006 02:45:08 +0000 (02:45 +0000)]
I accidently checked in old expected results in my previous checkin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 14 Nov 2006 02:37:58 +0000 (02:37 +0000)]
LayoutTests:
Reviewed by harrison
* editing/selection/drag-select-1-expected.checksum: Added.
* editing/selection/drag-select-1-expected.png: Added.
* editing/selection/drag-select-1-expected.txt: Added.
* editing/selection/drag-select-1.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/
4828264>
In Mail, a crash occurs at WebCore::Selection::toRange() when selecting this web content (http://www.cnet.com/)
The start of the selection is in an editable area, and the end is in an
input field inside that editable area. The code that should pull the end
of such a selection outside the input field didn't escape shadow nodes,
it would leave a dangling end, causing the crash in toRange.
* editing/Selection.cpp:
(WebCore::Selection::adjustForEditableContent): Added an ASSERT and a fixup
to prevent crashes like this in future Release builds.
* editing/htmlediting.cpp:
(WebCore::firstEditablePositionAfterPositionInRoot): Let this function
escape shadow nodes. We might eventually push this code down into
next/previous{VisuallyDistinct}Canditate.
(WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Mon, 13 Nov 2006 23:56:01 +0000 (23:56 +0000)]
Reviewed by darin
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
* editing/Editor.h:
(WebCore::Editor::setRemovedAnchor): Pass a PassRefPtr.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Mon, 13 Nov 2006 23:37:43 +0000 (23:37 +0000)]
LayoutTests:
Reviewed by Oliver
* editing/pasteboard/paste-unrendered-select-expected.checksum: Added.
* editing/pasteboard/paste-unrendered-select-expected.png: Added.
* editing/pasteboard/paste-unrendered-select-expected.txt: Added.
* editing/pasteboard/paste-unrendered-select.html: Added.
WebCore:
Reviewed by Oliver
<rdar://problem/
4820026>
copy/paste of news.google.com yields text from hidden select element options
We were adding descendants of unrendered select elements.
* editing/markup.cpp:
(WebCore::createMarkup): Don't traverse into nodes without renderers, unless
they are grandfathered in by a rendered select element.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 13 Nov 2006 21:46:59 +0000 (21:46 +0000)]
Explicitly set Dwarf for projects that didn't specify the debugging format.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 13 Nov 2006 21:38:23 +0000 (21:38 +0000)]
Switching to Dwarf for Debug and Production. Debuggign will work best with Xcode 2.4.1 or later.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 13 Nov 2006 07:13:39 +0000 (07:13 +0000)]
Rubberstamped by Anders
Changed some #includes from <WebKit/foo.h> to "foo.h"
* History/WebBackForwardList.m:
* History/WebHistory.m:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sun, 12 Nov 2006 23:44:42 +0000 (23:44 +0000)]
Reviewed by Beth Dakin.
Added project-wide setting to disable Microsoft's made-up deprecation
warnings related to std:: functions. (Doesn't have any affect yet,
since we currently disable all deprecation warnings.)
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 12 Nov 2006 15:18:32 +0000 (15:18 +0000)]
2006-11-12 Simon Hausmann <hausmann@kde.org>
Reviewed by Sam Weinig.
Fix Qt build. Missing AbstractShared implementation.
http://bugs.webkit.org/show_bug.cgi?id=11581
* loader/qt/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::ref):
(WebCore::FrameLoaderClientQt::deref):
* loader/qt/FrameLoaderClientQt.h:
* platform/qt/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::ref):
(WebCore::ChromeClientQt::deref):
* platform/qt/ChromeClientQt.h:
* platform/qt/EditorClientQt.cpp:
(WebCore::EditorClientQt::ref):
(WebCore::EditorClientQt::deref):
* platform/qt/EditorClientQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 12 Nov 2006 12:29:58 +0000 (12:29 +0000)]
2006-11-13 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Fix some Linux/Gdk build issues noted by Alp Toker.
* Projects/gdk/webcore-gdk.bkl:
* WebCoreSources.bkl:
* platform/graphics/gdk/ImageGdk.cpp:
(WebCore::Image::loadPlatformResource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sun, 12 Nov 2006 09:31:36 +0000 (09:31 +0000)]
Reviewed by Anders
Logging channel plumbing for future work
* platform/Logging.cpp:
(WebCore::):
* platform/Logging.h:
* platform/mac/LoggingMac.mm:
(WebCore::InitializeLoggingChannelsIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 12 Nov 2006 08:47:51 +0000 (08:47 +0000)]
2006-11-12 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Linux/Gdk compilation fixes, and bakefile cleanups. Based on patches by
Alp Toker.
* Projects/gdk/webcore-gdk.bkl:
* WebCoreSources.bkl:
* page/PageState.cpp:
* platform/gdk/ChromeClientGdk.h:
(WebCore::ChromeClientGdk::ref):
(WebCore::ChromeClientGdk::deref):
* platform/gdk/FrameGdk.cpp:
(WebCore::FrameGdkClientDefault::openURL):
(WebCore::FrameGdkClientDefault::didReceiveData):
(WebCore::FrameGdkClientDefault::receivedAllData):
(WebCore::FrameGdk::FrameGdk):
(WebCore::FrameGdk::~FrameGdk):
* platform/gdk/FrameGdk.h:
* platform/gdk/KeyEventGdk.cpp:
(WebCore::keyIdentifierForGdkKeyCode):
* platform/gdk/ScreenClientGdk.h: Removed.
* platform/gdk/TemporaryLinkStubs.cpp:
(FrameGdk::canPaste):
(FrameGdk::originalRequestURL):
(TextField::TextField):
* platform/network/gdk/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::add):
(WebCore::ResourceHandleManager::cancel):
* webcore-base.bkl:
2006-11-12 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Clean up of JavaScriptCore bakefiles.
* JavaScriptCoreSources.bkl:
* jscore.bkl:
2006-11-12 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Clean up of GdkLauncher bakefile.
* GdkLauncher/gdklauncher.bkl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sun, 12 Nov 2006 04:53:17 +0000 (04:53 +0000)]
WebCore:
Reviewed by Maciej Stachowiak.
- Fixed loader crash by clarifying ownership of WebKit client objects.
WebCore objects own their WebKit clients, and ref and deref through
virtual methods, leaving WebKit free to use whatever client / reference-counting
implementation it likes.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bridge/EditorClient.h: Fixed up function prototypes for style.
* loader/FrameLoader.cpp: Removed detachFrameLoader, since its real purpose
was to implement an alternative ownership model.
(WebCore::FrameLoader::~FrameLoader): Removed empty destructor.
(WebCore::FrameLoader::setClient): This function now takes ownership
(WebCore::FrameLoader::client):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* page/ChromeClient.h:
* platform/AbstractShared.h: Added. This is the virtual function-based refcounting
complement to Shared.
(WebCore::AbstractShared::~AbstractShared):
WebKit:
Reviewed by Maciej Stachowiak.
- Fixed loader crash by clarifying ownership of WebKit client objects.
WebCore objects own their WebKit clients, and ref and deref through
virtual methods, leaving WebKit free to use whatever client / reference-counting
implementation it likes.
WebKit on Mac just uses the same refcounting class that WebCore uses (Shared),
but other platforms may choose to do other things.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::ref):
(WebChromeClient::deref):
(WebChromeClient::refCount):
* WebCoreSupport/WebEditorClient.h: Nixed commented-out function prototypes.
The ones in WebCore make clear what remains to be implemented. Replaced constructor
with factory function to avoid leaks.
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::create):
(WebEditorClient::WebEditorClient):
(WebEditorClient::setWebFrame):
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
(-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
* WebCoreSupport/WebFrameLoaderClient.h: Replaced constructor with factory
function to avoid leaks.
(WebFrameLoaderClient::ref):
(WebFrameLoaderClient::deref):
(WebFrameLoaderClient::refCount):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::create):
* WebView/WebFrame.mm:
(-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Sun, 12 Nov 2006 00:13:29 +0000 (00:13 +0000)]
Reviewed by Maciej.
Fix uninitialized variable.
* rendering/RenderStyle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sat, 11 Nov 2006 21:34:15 +0000 (21:34 +0000)]
Grammar fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sat, 11 Nov 2006 21:32:58 +0000 (21:32 +0000)]
Reviewed/landed by Adam.
Complete cleanup of the CMakeLists.txt.
Now all files to be build are sorted in alphabetic order.
General style cleanup, remove all tabs etc.
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 11 Nov 2006 21:32:07 +0000 (21:32 +0000)]
Changed one last bugzilla.opendarwin.org URL to bugs.webkit.org.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer [Sat, 11 Nov 2006 21:28:20 +0000 (21:28 +0000)]
Changed bugzilla.opendarwin.org URLs to bugs.webkit.org in ChangeLog files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 11 Nov 2006 19:10:29 +0000 (19:10 +0000)]
Reviewed and landed by Anders.
Make DRT work again on Qt/Linux.
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sat, 11 Nov 2006 18:36:23 +0000 (18:36 +0000)]
Reviewed by Maciej Stachowiak.
Added missing initializer to ResourceRequest -- fixes some loader crashes
due to assuming a request always has a non-null httpMethod.
* platform/network/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 11 Nov 2006 18:08:40 +0000 (18:08 +0000)]
Reviewed by Maciej
Fixed header guard
* loader/FrameLoaderClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 11 Nov 2006 16:48:47 +0000 (16:48 +0000)]
- attempt to fix Qt build
* platform/qt/CursorQt.cpp:
(WebCore::verticalTextCursor): Added. Just returns pointer cursor.
(WebCore::cellCursor): Ditto.
(WebCore::contextMenuCursor): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Sat, 11 Nov 2006 15:49:45 +0000 (15:49 +0000)]
Reviewed by hyatt.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
InsertRule can not handle @import statements
Allow @import as part of a css rule.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 11 Nov 2006 15:31:13 +0000 (15:31 +0000)]
Attempt to fix Qt build.
* CMakeLists.txt: PathQt.cpp is in graphics/qt now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 11 Nov 2006 15:15:53 +0000 (15:15 +0000)]
2006-11-11 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)
[CSS 3] support for vertical-text, cell and context-menu cursors
http://bugs.webkit.org/show_bug.cgi?id=11494
* Resources/cellCursor.png: Added.
* Resources/contextMenuCursor.png: Added.
* Resources/verticalTextCursor.png: Added.
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSValueKeywords.in:
* manual-tests/cursor.html:
* page/FrameView.cpp:
(WebCore::selectCursor):
* platform/Cursor.h:
* platform/mac/CursorMac.mm:
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
* rendering/RenderStyle.h:
(WebCore::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 11 Nov 2006 14:31:46 +0000 (14:31 +0000)]
2006-11-11 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by aroben and ap, landed by ap.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468
Group graphics related files in platform/graphics.
Move certain files from certain subdirectories
into platform/graphics/{win,mac,cg,gdk,qt}
* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/AffineTransform.cpp: Removed.
* platform/AffineTransform.h: Removed.
* platform/Color.cpp: Removed.
* platform/Color.h: Removed.
* platform/FloatPoint.cpp: Removed.
* platform/FloatPoint.h: Removed.
* platform/FloatRect.cpp: Removed.
* platform/FloatRect.h: Removed.
* platform/FloatSize.cpp: Removed.
* platform/FloatSize.h: Removed.
* platform/Icon.h: Removed.
* platform/Image.cpp: Removed.
* platform/Image.h: Removed.
* platform/ImageSource.h: Removed.
* platform/IntPoint.h: Removed.
* platform/IntRect.cpp: Removed.
* platform/IntRect.h: Removed.
* platform/IntSize.h: Removed.
* platform/IntSizeHash.h: Removed.
* platform/Path.cpp: Removed.
* platform/Path.h: Removed.
* platform/Pen.cpp: Removed.
* platform/Pen.h: Removed.
* platform/cairo/AffineTransformCairo.cpp: Removed.
* platform/cairo/GraphicsContextCairo.cpp: Removed.
* platform/cairo/ImageCairo.cpp: Removed.
* platform/cairo/ImageSourceCairo.cpp: Removed.
* platform/cairo/cairo/AUTHORS: Removed.
* platform/cairo/cairo/COPYING: Removed.
* platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
* platform/cairo/cairo/COPYING-MPL-1.1: Removed.
* platform/cairo/cairo/INSTALL: Removed.
* platform/cairo/cairo/NEWS: Removed.
* platform/cairo/cairo/README: Removed.
* platform/cairo/cairo/TODO: Removed.
* platform/cairo/cairo/src/Makefile.in: Removed.
* platform/cairo/cairo/src/cairo-arc-private.h: Removed.
* platform/cairo/cairo/src/cairo-arc.c: Removed.
* platform/cairo/cairo/src/cairo-array.c: Removed.
* platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
* platform/cairo/cairo/src/cairo-atsui.h: Removed.
* platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
* platform/cairo/cairo/src/cairo-beos.h: Removed.
* platform/cairo/cairo/src/cairo-cache-private.h: Removed.
* platform/cairo/cairo/src/cairo-cache.c: Removed.
* platform/cairo/cairo/src/cairo-clip-private.h: Removed.
* platform/cairo/cairo/src/cairo-clip.c: Removed.
* platform/cairo/cairo/src/cairo-color.c: Removed.
* platform/cairo/cairo/src/cairo-debug.c: Removed.
* platform/cairo/cairo/src/cairo-debug.h: Removed.
* platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
* platform/cairo/cairo/src/cairo-directfb.h: Removed.
* platform/cairo/cairo/src/cairo-features.h: Removed.
* platform/cairo/cairo/src/cairo-features.h.in: Removed.
* platform/cairo/cairo/src/cairo-fixed.c: Removed.
* platform/cairo/cairo/src/cairo-font-options.c: Removed.
* platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
* platform/cairo/cairo/src/cairo-font-subset.c: Removed.
* platform/cairo/cairo/src/cairo-font.c: Removed.
* platform/cairo/cairo/src/cairo-ft-font.c: Removed.
* platform/cairo/cairo/src/cairo-ft-private.h: Removed.
* platform/cairo/cairo/src/cairo-ft.h: Removed.
* platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
* platform/cairo/cairo/src/cairo-glitz.h: Removed.
* platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
* platform/cairo/cairo/src/cairo-gstate.c: Removed.
* platform/cairo/cairo/src/cairo-hash-private.h: Removed.
* platform/cairo/cairo/src/cairo-hash.c: Removed.
* platform/cairo/cairo/src/cairo-hull.c: Removed.
* platform/cairo/cairo/src/cairo-image-surface.c: Removed.
* platform/cairo/cairo/src/cairo-matrix.c: Removed.
* platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
* platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
* platform/cairo/cairo/src/cairo-output-stream.c: Removed.
* platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
* platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
* platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
* platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
* platform/cairo/cairo/src/cairo-path-data.c: Removed.
* platform/cairo/cairo/src/cairo-path-fill.c: Removed.
* platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
* platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
* platform/cairo/cairo/src/cairo-path.c: Removed.
* platform/cairo/cairo/src/cairo-pattern.c: Removed.
* platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
* platform/cairo/cairo/src/cairo-pdf.h: Removed.
* platform/cairo/cairo/src/cairo-pen.c: Removed.
* platform/cairo/cairo/src/cairo-platform.h: Removed.
* platform/cairo/cairo/src/cairo-png.c: Removed.
* platform/cairo/cairo/src/cairo-polygon.c: Removed.
* platform/cairo/cairo/src/cairo-private.h: Removed.
* platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
* platform/cairo/cairo/src/cairo-ps.h: Removed.
* platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
* platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
* platform/cairo/cairo/src/cairo-quartz.h: Removed.
* platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
* platform/cairo/cairo/src/cairo-quartz2.h: Removed.
* platform/cairo/cairo/src/cairo-region.c: Removed.
* platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
* platform/cairo/cairo/src/cairo-slope.c: Removed.
* platform/cairo/cairo/src/cairo-spline.c: Removed.
* platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
* platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
* platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
* platform/cairo/cairo/src/cairo-surface.c: Removed.
* platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
* platform/cairo/cairo/src/cairo-svg.h: Removed.
* platform/cairo/cairo/src/cairo-traps.c: Removed.
* platform/cairo/cairo/src/cairo-unicode.c: Removed.
* platform/cairo/cairo/src/cairo-wideint.c: Removed.
* platform/cairo/cairo/src/cairo-wideint.h: Removed.
* platform/cairo/cairo/src/cairo-win32-font.c: Removed.
* platform/cairo/cairo/src/cairo-win32-private.h: Removed.
* platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
* platform/cairo/cairo/src/cairo-win32.h: Removed.
* platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
* platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
* platform/cairo/cairo/src/cairo-xcb.h: Removed.
* platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
* platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
* platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
* platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
* platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
* platform/cairo/cairo/src/cairo-xlib.h: Removed.
* platform/cairo/cairo/src/cairo.c: Removed.
* platform/cairo/cairo/src/cairo.h: Removed.
* platform/cairo/cairo/src/cairoint.h: Removed.
* platform/cairo/cairo/src/test-fallback-surface.c: Removed.
* platform/cairo/cairo/src/test-fallback-surface.h: Removed.
* platform/cairo/cairo/src/test-meta-surface.c: Removed.
* platform/cairo/cairo/src/test-meta-surface.h: Removed.
* platform/cairo/cairo/src/test-paginated-surface.c: Removed.
* platform/cairo/cairo/src/test-paginated-surface.h: Removed.
* platform/cairo/pixman/AUTHORS: Removed.
* platform/cairo/pixman/COPYING: Removed.
* platform/cairo/pixman/README: Removed.
* platform/cairo/pixman/src/Makefile.in: Removed.
* platform/cairo/pixman/src/fbcompose.c: Removed.
* platform/cairo/pixman/src/fbedge.c: Removed.
* platform/cairo/pixman/src/fbedgeimp.h: Removed.
* platform/cairo/pixman/src/fbmmx.c: Removed.
* platform/cairo/pixman/src/fbmmx.h: Removed.
* platform/cairo/pixman/src/fbpict.c: Removed.
* platform/cairo/pixman/src/fbpict.h: Removed.
* platform/cairo/pixman/src/fbtrap.c: Removed.
* platform/cairo/pixman/src/icblt.c: Removed.
* platform/cairo/pixman/src/icbltone.c: Removed.
* platform/cairo/pixman/src/iccolor.c: Removed.
* platform/cairo/pixman/src/icformat.c: Removed.
* platform/cairo/pixman/src/icimage.c: Removed.
* platform/cairo/pixman/src/icimage.h: Removed.
* platform/cairo/pixman/src/icint.h: Removed.
* platform/cairo/pixman/src/icpixels.c: Removed.
* platform/cairo/pixman/src/icrect.c: Removed.
* platform/cairo/pixman/src/icrop.h: Removed.
* platform/cairo/pixman/src/icstipple.c: Removed.
* platform/cairo/pixman/src/ictransform.c: Removed.
* platform/cairo/pixman/src/ictrap.c: Removed.
* platform/cairo/pixman/src/ictri.c: Removed.
* platform/cairo/pixman/src/icutil.c: Removed.
* platform/cairo/pixman/src/pixman-remap.h: Removed.
* platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
* platform/cairo/pixman/src/pixman.h: Removed.
* platform/cairo/pixman/src/pixregion.c: Removed.
* platform/cairo/pixman/src/pixregionint.h: Removed.
* platform/cairo/pixman/src/renderedge.c: Removed.
* platform/cairo/pixman/src/renderedge.h: Removed.
* platform/cairo/pixman/src/slim_internal.h: Removed.
* platform/cairo/rgb24-hacks.txt: Removed.
* platform/cairo/scale-removal.txt: Removed.
* platform/cg/AffineTransformCG.cpp: Removed.
* platform/cg/FloatPointCG.cpp: Removed.
* platform/cg/FloatRectCG.cpp: Removed.
* platform/cg/FloatSizeCG.cpp: Removed.
* platform/cg/GraphicsContextCG.cpp: Removed.
* platform/cg/GraphicsContextPlatformPrivate.h: Removed.
* platform/cg/ImageCG.cpp: Removed.
* platform/cg/ImageSourceCG.cpp: Removed.
* platform/cg/IntPointCG.cpp: Removed.
* platform/cg/IntRectCG.cpp: Removed.
* platform/cg/IntSizeCG.cpp: Removed.
* platform/cg/PDFDocumentImage.cpp: Removed.
* platform/cg/PDFDocumentImage.h: Removed.
* platform/cg/PathCG.cpp: Removed.
* platform/gdk/ImageGdk.cpp: Removed.
* platform/mac/ColorMac.mm: Removed.
* platform/mac/FloatPointMac.mm: Removed.
* platform/mac/FloatRectMac.mm: Removed.
* platform/mac/FloatSizeMac.mm: Removed.
* platform/mac/GraphicsContextMac.mm:
* platform/mac/IconMac.mm: Removed.
* platform/mac/ImageMac.mm: Removed.
* platform/mac/IntPointMac.mm: Removed.
* platform/mac/IntRectMac.mm: Removed.
* platform/mac/IntSizeMac.mm: Removed.
* platform/qt/AffineTransformQt.cpp: Removed.
* platform/qt/ColorQt.cpp: Removed.
* platform/qt/FloatPointQt.cpp: Removed.
* platform/qt/FloatRectQt.cpp: Removed.
* platform/qt/IconQt.cpp: Removed.
* platform/qt/ImageQt.cpp: Removed.
* platform/qt/ImageSourceQt.cpp: Removed.
* platform/qt/IntPointQt.cpp: Removed.
* platform/qt/IntRectQt.cpp: Removed.
* platform/qt/IntSizeQt.cpp: Removed.
* platform/qt/PathQt.cpp: Removed.
* platform/win/ImageWin.cpp: Removed.
* platform/win/IntPointWin.cpp: Removed.
* platform/win/IntRectWin.cpp: Removed.
* platform/win/IntSizeWin.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gdennis [Sat, 11 Nov 2006 13:10:33 +0000 (13:10 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc