WebKit-https.git
9 years agoFix build warning after r142017
commit-queue@webkit.org [Fri, 8 Feb 2013 00:27:31 +0000 (00:27 +0000)]
Fix build warning after r142017
https://bugs.webkit.org/show_bug.cgi?id=109119

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-07
Reviewed by Alexey Proskuryakov.

Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/parser/document-write-noscript.html fails for threaded HTML parser
abarth@webkit.org [Fri, 8 Feb 2013 00:24:31 +0000 (00:24 +0000)]
fast/parser/document-write-noscript.html fails for threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109237

Reviewed by Eric Seidel.

Source/WebCore:

If there are multiple calls to document.write in an external script, we
need to wait for them all to complete before invalidating the
speculative tokens. Instead of doing this when we unwind the
document.write call stack, we do this when we're about to resume
parsing after script execution.

Test: fast/parser/document-write-basic.html

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

LayoutTests:

This tests basic document.write functionality.  There doesn't appear to
be another fast/parser test that covers this basic case (although it's
convered in some more complicated test cases incidentally.)

* fast/parser/document-write-basic-expected.txt: Added.
* fast/parser/document-write-basic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build when compiling with css3-text and css3-conditional-rules feature flags...
commit-queue@webkit.org [Fri, 8 Feb 2013 00:18:14 +0000 (00:18 +0000)]
Fix build when compiling with css3-text and css3-conditional-rules feature flags enabled.
https://bugs.webkit.org/show_bug.cgi?id=109217

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-02-07
Reviewed by Benjamin Poulain.

* css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::collect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r140778): Calendar Picker doesn't open when the element has the required...
tkent@chromium.org [Fri, 8 Feb 2013 00:06:24 +0000 (00:06 +0000)]
REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=109136

Patch by Keishi Hattori <keishi@webkit.org> on 2013-02-07
Reviewed by Kent Tamura.

Source/WebCore:

Calendar picker was using the "Clear" button to calculate the window width.
Since it doesn't exist when the input element has a required attribute,
it was throwing an error. This patch fixes the width calculating logic.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html
       platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html

* Resources/pagepopups/calendarPicker.css:
(.today-clear-area):
* Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
the width. We don't want to use clear button because it doesn't exist
when a value is required.

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Flings should not bubble up to enclosing scrollables when main-thread...
tdanderson@chromium.org [Fri, 8 Feb 2013 00:03:46 +0000 (00:03 +0000)]
[chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling
https://bugs.webkit.org/show_bug.cgi?id=108719

Reviewed by Eric Seidel.

In the event of a main-thread touch fling, dispatch a series of
GestureScrollUpdateWithoutPropagation events defined in
https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
GestureScrollUpdate events) so that the fling does not
propagate to enclosing scrollables.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollBy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNon-scrollable divs and non-scrollable iframes can scroll with touch
tdanderson@chromium.org [Thu, 7 Feb 2013 23:58:15 +0000 (23:58 +0000)]
Non-scrollable divs and non-scrollable iframes can scroll with touch
https://bugs.webkit.org/show_bug.cgi?id=109087

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/events/touch/gesture/touch-gesture-noscroll-div.html
       fast/events/touch/gesture/touch-gesture-noscroll-iframe.html

When finding a candidate for a scrollable node in
EventHandler::handleGestureScrollUpdate(), select the document node
if it is reached before any scrollable element when walking up the DOM
tree. Also ensure that calling RenderLayer::scrollBy() for a document
node does not result in scrolling if the element is not scrollable.

* page/EventHandler.cpp:
(WebCore::closestScrollableNodeCandidate):
(WebCore::EventHandler::handleGestureScrollUpdate):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollBy):

LayoutTests:

Two new layout tests added to demonstrate that the changes to
RenderLayer::scrollBy() and closestScrollableNodeCandidate() in
EventHandler.cpp are both necessary to ensure that non-scrollable
divs and non-scrollable iframes cannot be scrolled with touch.

* fast/events/touch/gesture/touch-gesture-noscroll-div-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-noscroll-div.html: Added.
* fast/events/touch/gesture/touch-gesture-noscroll-iframe-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-noscroll-iframe.html: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-div-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntroduce SQLTransactionBackend and SQLTransactionBackendSync [Part 2].
mark.lam@apple.com [Thu, 7 Feb 2013 23:52:48 +0000 (23:52 +0000)]
Introduce SQLTransactionBackend and SQLTransactionBackendSync [Part 2].
https://bugs.webkit.org/show_bug.cgi?id=109109.

Reviewed by Anders Carlsson.

Adding back the new SQLTransaction and SQLTransactionSync files.

No new tests.

* Modules/webdatabase/SQLTransaction.cpp: Added.
(WebCore::SQLTransaction::create):
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::from):
* Modules/webdatabase/SQLTransaction.h: Added.
(SQLTransaction):
* Modules/webdatabase/SQLTransactionSync.cpp: Added.
(WebCore::SQLTransactionSync::create):
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::from):
* Modules/webdatabase/SQLTransactionSync.h: Added.
(SQLTransactionSync):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntroduce SQLTransactionBackend and SQLTransactionBackendSync.
mark.lam@apple.com [Thu, 7 Feb 2013 23:49:28 +0000 (23:49 +0000)]
Introduce SQLTransactionBackend and SQLTransactionBackendSync.
https://bugs.webkit.org/show_bug.cgi?id=109109.

Reviewed by Anders Carlsson.

- Renamed SQLTransaction and SQLTransactionSync to SQLTransactionBackend
  and SQLTransactionBackendSync respectively.
- Added back SQLTransaction and SQLTransactionSync as new files, and have
  their classes extends their respective backends. This is a stop gap
  measure to keep things working until the front-end and back-end can be
  properly split.
  Note: these files will be committed in a subsequent commit to ensure
  that the patching goes smoothly.
- Where needed, I made use of new SQLTransaction::from() and
  SQLTransactionSync::from() static methods that "get" the front-end
  transactions from the back-ends. This is also a stop gap measure to
  keep things working until the proper refactoring is complete.
- Fixed up pre-existing style checker violations that are now detected
  on code that were touched during my renaming.
- Added the back-end files to all the build files.

No new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/webdatabase/Database.cpp:
(WebCore::Database::scheduleTransactionStep):
* Modules/webdatabase/Database.h:
(Database):
* Modules/webdatabase/DatabaseBackend.h:
(DatabaseBackend):
* Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::DatabaseTransactionTask):
* Modules/webdatabase/DatabaseTask.h:
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::create):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::transaction):
(DatabaseBackendAsync::DatabaseTransactionTask):
* Modules/webdatabase/SQLTransaction.cpp: Removed.
* Modules/webdatabase/SQLTransaction.h: Removed.
* Modules/webdatabase/SQLTransactionBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLTransaction.cpp.
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::~SQLTransactionBackend):
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::enqueueStatement):
(WebCore::SQLTransactionBackend::debugStepName):
(WebCore::SQLTransactionBackend::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransactionBackend::performNextStep):
(WebCore::SQLTransactionBackend::performPendingCallback):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransactionBackend::acquireLock):
(WebCore::SQLTransactionBackend::lockAcquired):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::deliverTransactionCallback):
(WebCore::SQLTransactionBackend::scheduleToRunStatements):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::getNextStatement):
(WebCore::SQLTransactionBackend::runCurrentStatement):
(WebCore::SQLTransactionBackend::handleCurrentStatementError):
(WebCore::SQLTransactionBackend::deliverStatementCallback):
(WebCore::SQLTransactionBackend::deliverQuotaIncreaseCallback):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::deliverSuccessCallback):
(WebCore::SQLTransactionBackend::cleanupAfterSuccessCallback):
(WebCore::SQLTransactionBackend::handleTransactionError):
(WebCore::SQLTransactionBackend::deliverTransactionErrorCallback):
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
* Modules/webdatabase/SQLTransactionBackend.h: Copied from Source/WebCore/Modules/webdatabase/SQLTransaction.h.
(SQLTransactionBackend):
* Modules/webdatabase/SQLTransactionBackendSync.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLTransactionSync.cpp.
(WebCore::SQLTransactionBackendSync::SQLTransactionBackendSync):
(WebCore::SQLTransactionBackendSync::~SQLTransactionBackendSync):
(WebCore::SQLTransactionBackendSync::executeSQL):
(WebCore::SQLTransactionBackendSync::begin):
(WebCore::SQLTransactionBackendSync::execute):
(WebCore::SQLTransactionBackendSync::commit):
(WebCore::SQLTransactionBackendSync::rollback):
* Modules/webdatabase/SQLTransactionBackendSync.h: Copied from Source/WebCore/Modules/webdatabase/SQLTransactionSync.h.
(SQLTransactionBackendSync):
* Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
(WebCore::SQLTransactionCoordinator::processPendingTransactions):
(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):
* Modules/webdatabase/SQLTransactionCoordinator.h:
(SQLTransactionCoordinator):
(WebCore::SQLTransactionCoordinator::SQLTransactionCoordinator):
(CoordinationInfo):
* Modules/webdatabase/SQLTransactionSync.cpp: Removed.
* Modules/webdatabase/SQLTransactionSync.h: Removed.
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add a flag to enable native form validation message
tkent@chromium.org [Thu, 7 Feb 2013 23:45:35 +0000 (23:45 +0000)]
[Chromium] Add a flag to enable native form validation message
https://bugs.webkit.org/show_bug.cgi?id=109134

Reviewed by Adam Barth.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures): Add enableNativeValidationMessage and
isNativeValidationMessageEnabled.
* src/WebRuntimeFeatures.cpp:
(WebKit): Add nativeValidationMessageEnabled.
(WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
(WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
Fill Page::PageClients::validationMessageClient if the flag is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse new speech bubble artwork for captions menu button
dino@apple.com [Thu, 7 Feb 2013 23:42:12 +0000 (23:42 +0000)]
Use new speech bubble artwork for captions menu button
https://bugs.webkit.org/show_bug.cgi?id=109215

Reviewed by Eric Carlson.

Rather than call into RenderTheme to display this button, embed artwork
into the CSS. This means we can remove some uncalled methods in
RenderTheme.

* css/mediaControlsQuickTime.css:
(video::-webkit-media-controls-toggle-closed-captions-button): New background image using SVG.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint): Don't call the specific painter for the CC button.
* rendering/RenderTheme.h: Remove unused function.
* rendering/RenderThemeMac.h: Ditto.
* rendering/RenderThemeMac.mm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Shaders] Add the last blending step
michelangelo@webkit.org [Thu, 7 Feb 2013 23:32:53 +0000 (23:32 +0000)]
[CSS Shaders] Add the last blending step
https://bugs.webkit.org/show_bug.cgi?id=104012

Source/WebCore:

The resulting blended color in mix() is now weighted according to
the original element's backdrop alpha value.

Reviewed by Dean Jackson.

Test: css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html

* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):

LayoutTests:

Added a test to check the correct blending in presence of a transparent backdrop.

Reviewed by Dean Jackson.

* css3/filters/custom/custom-filter-blend-fractional-destination-alpha-expected.html: Added.
* css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html: Added.
* platform/mac/TestExpectations: This test is currently skipped on Mac for slight color
differences, please see the relevant bug: http://webkit.org/b/107487

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix two exports of WebCore symbols on iOS
benjamin@webkit.org [Thu, 7 Feb 2013 23:29:42 +0000 (23:29 +0000)]
Fix two exports of WebCore symbols on iOS
https://bugs.webkit.org/show_bug.cgi?id=109238

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by David Kilzer.

* WebCore.exp.in: Export wkCTFontTransformGlyphs but not
wkCGContextDrawsWithCorrectShadowOffsets on iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Another temporary EWS bot fix. It'll totally work this time.
roger_fong@apple.com [Thu, 7 Feb 2013 23:25:23 +0000 (23:25 +0000)]
Unreviewed. Another temporary EWS bot fix. It'll totally work this time.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Exclusions] Ignore ExclusionPolygon edges above minLogicalIntervalTop
commit-queue@webkit.org [Thu, 7 Feb 2013 23:20:27 +0000 (23:20 +0000)]
[CSS Exclusions] Ignore ExclusionPolygon edges above minLogicalIntervalTop
https://bugs.webkit.org/show_bug.cgi?id=107566

Patch by Hans Muller <hmuller@adobe.com> on 2013-02-07
Reviewed by David Hyatt.

Source/WebCore:

Improve ExclusionPolygon::firstIncludedIntervalLogicalTop() performance by only
creating offset edges for polygon edges that are below the horizontal minLogicalIntervalTop
line. In other words, don't bother creating offset edges that can't define the polygon's
first fit location.

Test: fast/exclusions/shape-inside/shape-inside-first-fit-004.html

* rendering/ExclusionPolygon.cpp:
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Don't create offset edges for polygon edges above minLogicalIntervalTop.

LayoutTests:

Added a simple polygonal shape-inside test where only a subset of the polygon edges
should contribute to each line's offset edges.

* fast/exclusions/shape-inside/shape-inside-first-fit-004-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-first-fit-004.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove logging of MediaPlayerPrivateAVFoundation Notifications.
jer.noble@apple.com [Thu, 7 Feb 2013 23:19:12 +0000 (23:19 +0000)]
Improve logging of MediaPlayerPrivateAVFoundation Notifications.
https://bugs.webkit.org/show_bug.cgi?id=109223

Reviewed by Eric Carlson.

Convert the existing Notification enum to an expandable macro. Then add a
Logging-only function which stringifies the enums.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore):
(WebCore::notificationName):
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd layout test verifying role, subrole, and role description for all HTML elements...
commit-queue@webkit.org [Thu, 7 Feb 2013 23:17:19 +0000 (23:17 +0000)]
Add layout test verifying role, subrole, and role description for all HTML elements and ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=109027

Patch by James Craig <jcraig@apple.com> on 2013-02-07
Reviewed by Chris Fleizach.

New layout test verifies AXRole, AXSubrole, and AXRoleDescription for all HTML elements and ARIA roles.

* platform/mac/accessibility/role-subrole-roledescription-expected.txt: Added.
* platform/mac/accessibility/role-subrole-roledescription.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoObjective-C API: testapi.mm should use ARC
mhahnenberg@apple.com [Thu, 7 Feb 2013 23:11:40 +0000 (23:11 +0000)]
Objective-C API: testapi.mm should use ARC
https://bugs.webkit.org/show_bug.cgi?id=107838

Reviewed by Mark Rowe.

Removing the changes to the Xcode project file and moving the equivalent flags into
the ToolExecutable xcconfig file.

* Configurations/ToolExecutable.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix an incorrect comment from r142163
benjamin@webkit.org [Thu, 7 Feb 2013 22:53:35 +0000 (22:53 +0000)]
Fix an incorrect comment from r142163

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07

* wtf/MainThread.h:
I accidentally copied PLATFORM(IOS) instead of USE(WEB_THREAD) for the #ifdef closing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix syntax error in runtests.py.
roger_fong@apple.com [Thu, 7 Feb 2013 22:52:40 +0000 (22:52 +0000)]
Unreviewed. Fix syntax error in runtests.py.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows] Unreviewed Visual Studio 2010 build fixes after r142179.
bfulgham@webkit.org [Thu, 7 Feb 2013 22:44:17 +0000 (22:44 +0000)]
[Windows] Unreviewed Visual Studio 2010 build fixes after r142179.

* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Correct changed symbols
* JavaScriptCore.vcxproj/JavaScriptCoreExports.def: Removed autogenerated file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTemporary fix for Win EWS bots.
roger_fong@apple.com [Thu, 7 Feb 2013 22:33:21 +0000 (22:33 +0000)]
Temporary fix for Win EWS bots.
Don't build DRT since it has already been built in the build step.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Cleanup command-line defines
mrobinson@webkit.org [Thu, 7 Feb 2013 22:08:08 +0000 (22:08 +0000)]
[GTK] Cleanup command-line defines
https://bugs.webkit.org/show_bug.cgi?id=109213

Reviewed by Xan Lopez.

.:

* GNUmakefile.am: Remove references to flags that are now provided
by autotoolsconfig.h
* configure.ac: Add new AC_DEFINE invocations for flags that were
before manually appended to the compiler CPPFLAGS and clump all
AC_DEFINE invocations together.

Source/WebCore:

* GNUmakefile.am: Remove references to flags that are now handled
via autotoolsconfig.h.

Source/WebKit/gtk:

* GNUmakefile.am: Remove references to flags that are now provided
by autotoolsconfig.h

Source/WebKit2:

* GNUmakefile.am:  Remove references to flags that are now
provided by autotoolsconfig.h.

Tools:

* TestWebKitAPI/config.h: Include the autotoolsconfig.h header to pick
up defines from autoconf.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogit.svn_revision doesn't fetch the same revision as svn.svn_revision
rniwa@webkit.org [Thu, 7 Feb 2013 22:04:02 +0000 (22:04 +0000)]
git.svn_revision doesn't fetch the same revision as svn.svn_revision
https://bugs.webkit.org/show_bug.cgi?id=108684

Reviewed by Dirk Pranke.

Always call git log on the checkout root.

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.svn_revision):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Binding Integrity crash in V8MediaStream::createWrapper
tsepez@chromium.org [Thu, 7 Feb 2013 21:58:03 +0000 (21:58 +0000)]
[V8] Binding Integrity crash in V8MediaStream::createWrapper
https://bugs.webkit.org/show_bug.cgi?id=109211

Reviewed by Adam Barth.

Patch suppresses a chrome crasher.

* Modules/mediastream/MediaStream.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] decrease in-band caption advance notice interval
eric.carlson@apple.com [Thu, 7 Feb 2013 21:55:41 +0000 (21:55 +0000)]
[Mac] decrease in-band caption advance notice interval
https://bugs.webkit.org/show_bug.cgi?id=109190

Reviewed by Simon Fraser.

No new tests, no observable change in behavior.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Request cues 2 seconds in advance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Patch for testing Win EWS bots.
roger_fong@apple.com [Thu, 7 Feb 2013 21:49:18 +0000 (21:49 +0000)]
Unreviewed. Patch for testing Win EWS bots.

* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 7 Feb 2013 21:44:17 +0000 (21:44 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding a failure expectation for a test in r142122.
* platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r142149.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r142165.
gavinp@chromium.org [Thu, 7 Feb 2013 21:39:02 +0000 (21:39 +0000)]
Unreviewed, rolling out r142165.
http://trac.webkit.org/changeset/142165
https://bugs.webkit.org/show_bug.cgi?id=108466

Broke linux_aura builds.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
* DumpRenderTree/chromium/TestRunner/public/WebTask.h:
(WebTaskList):
* DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestInterfaces):
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
* DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
* DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
* DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
* DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
* DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
* DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(MockGrammarCheck::checkGrammarOfString):
* DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(MockGrammarCheck):
* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(append):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):
* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
* DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
* DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
* DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
* DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
* DumpRenderTree/chromium/TestRunner/src/config.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK][AC] Clutter required version up to 1.12
commit-queue@webkit.org [Thu, 7 Feb 2013 21:37:09 +0000 (21:37 +0000)]
[GTK][AC] Clutter required version up to 1.12
https://bugs.webkit.org/show_bug.cgi?id=109037

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2013-02-07
Reviewed by Martin Robinson.

.:

The clutter requried version is changed to 1.12.

* configure.ac:

Source/WebCore:

Replace deprecated clutter apis with new ones.

No new tests, since this patch is minor refactoring.

* platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorSetAnchorPoint):
* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::idleDestroy):
(WebCore::GraphicsLayerClutter::updateSublayerList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove pauseAnimation/pauseTransition from TestRunner to Internals
benjamin@webkit.org [Thu, 7 Feb 2013 21:34:32 +0000 (21:34 +0000)]
Move pauseAnimation/pauseTransition from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=109107

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by Anders Carlsson.

Source/WebCore:

Tests: animations/animation-internals-api-multiple-keyframes.html
       animations/animation-internals-api.html

* testing/Internals.cpp:
(WebCore::Internals::pauseAnimationAtTimeOnElement):
(WebCore):
(WebCore::Internals::pauseTransitionAtTimeOnElement):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

* WebView/WebFrame.mm:
* WebView/WebFramePrivate.h:

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
* WebProcess/WebPage/WebFrame.cpp:
* WebProcess/WebPage/WebFrame.h:
(WebFrame):

Tools:

* DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
* DumpRenderTree/mac/TestRunnerMac.mm:
* DumpRenderTree/qt/TestRunnerQt.cpp:
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
* DumpRenderTree/win/TestRunnerWin.cpp:
* DumpRenderTree/wx/TestRunnerWx.cpp:
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
* WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Change the tests with the following:
-Use the methods on Internals instead of TestRunner.
-Adapt the calls to pass a particular element instead of an ID.
-Remove feature detection. Having Internals implies having the feature.

* animations/animation-hit-test-transform.html:
* animations/animation-hit-test.html:
* animations/animation-internals-api-expected.txt: Renamed from LayoutTests/animations/animation-drt-api-expected.txt.
* animations/animation-internals-api-multiple-keyframes-expected.txt: Renamed from LayoutTests/animations/animation-drt-api-multiple-keyframes-expected.txt.
* animations/animation-internals-api-multiple-keyframes.html: Renamed from LayoutTests/animations/animation-drt-api-multiple-keyframes.html.
* animations/animation-internals-api.html: Renamed from LayoutTests/animations/animation-drt-api.html.
* animations/change-keyframes-name.html:
* animations/change-transform-style-during-animation.html:
* animations/missing-from-to-transforms.html:
* animations/missing-from-to.html:
* animations/resources/animation-test-helpers.js:
(checkExpectedValue):
(startTest):
* css3/calc/transitions-dependent.html:
* fast/dom/shadow/transition-on-shadow-host-with-distributed-node.html:
* transitions/opacity-transition-zindex.html:
* transitions/resources/transition-test-helpers.js:
(expected):
* transitions/transition-drt-api-delay.html:
* transitions/transition-drt-api.html:
* transitions/transition-hit-test-transform.html:
* transitions/transition-hit-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r142155.
gavinp@chromium.org [Thu, 7 Feb 2013 21:26:41 +0000 (21:26 +0000)]
Unreviewed, rolling out r142155.
http://trac.webkit.org/changeset/142155
https://bugs.webkit.org/show_bug.cgi?id=82888

cr/win build broke.

* bindings/js/JSClipboardCustom.cpp:
(WebCore::JSClipboard::types):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
* dom/Clipboard.h:
(Clipboard):
* platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
* platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
* platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
* platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
* platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
* platform/efl/ClipboardEfl.h:
(ClipboardEfl):
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
* platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
* platform/mac/ClipboardMac.h:
(ClipboardMac):
* platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
* platform/qt/ClipboardQt.h:
(ClipboardQt):
* platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
* platform/win/ClipboardWin.h:
(ClipboardWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][EFL] Removal of non coordinated graphics code path from WK2 EFL
mikhail.pozdnyakov@intel.com [Thu, 7 Feb 2013 21:20:14 +0000 (21:20 +0000)]
[WK2][EFL] Removal of non coordinated graphics code path from WK2 EFL
https://bugs.webkit.org/show_bug.cgi?id=109165

Reviewed by Anders Carlsson.

Removed non coordinated graphics code path from WK2 EFL as it was not used by
anyone and caused a lot of preprocessor macros in the code making it less readable.

* UIProcess/API/efl/EvasGLContext.cpp:
* UIProcess/API/efl/EvasGLContext.h:
(WebKit::EvasGLContext::context):
* UIProcess/API/efl/EvasGLSurface.cpp:
* UIProcess/API/efl/EvasGLSurface.h:
(WebKit::EvasGLSurface::surface):

    Removed also 'inline' and 'const' keywords from functions declaration,
    as both EvasGLContext::context() and EvasGLSurface::surface()
    are defined inside their classes and return mutable pointer.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::transformFromScene):
(EwkView::transformToScreen):
(EwkView::coordinatedGraphicsScene):
(EwkView::displayTimerFired):
(EwkView::scheduleUpdateDisplay): Renamed from EwkView::update().
(EwkView::exitAcceleratedCompositingMode):
(EwkView::handleEvasObjectCalculate):
(EwkView::takeSnapshot):
* UIProcess/API/efl/EwkView.h:
(WebCore):
(EwkView):
* UIProcess/API/efl/SnapshotImageGL.cpp:
(getImageSurfaceFromFrameBuffer):
* UIProcess/API/efl/SnapshotImageGL.h:
* UIProcess/API/efl/ewk_view.cpp:
* UIProcess/efl/PageClientBase.cpp:
(WebKit::PageClientBase::setViewNeedsDisplay):
(WebKit::PageClientBase::updateAcceleratedCompositingMode):
* UIProcess/efl/PageClientBase.h:
(PageClientBase):
* UIProcess/efl/PageClientDefaultImpl.cpp:
(WebKit::PageClientDefaultImpl::didCommitLoad):
(WebKit::PageClientDefaultImpl::updateViewportSize):
(WebKit::PageClientDefaultImpl::didChangeViewportProperties):
(WebKit::PageClientDefaultImpl::didChangeContentsSize):
(WebKit::PageClientDefaultImpl::pageTransitionViewportReady):
* UIProcess/efl/PageClientDefaultImpl.h:
(PageClientDefaultImpl):
* UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::didCommitLoad):
(WebKit::PageClientLegacyImpl::updateViewportSize):
(WebKit::PageClientLegacyImpl::didChangeViewportProperties):
(WebKit::PageClientLegacyImpl::didChangeContentsSize):
(WebKit::PageClientLegacyImpl::pageDidRequestScroll):
(WebKit::PageClientLegacyImpl::didRenderFrame):
(WebKit::PageClientLegacyImpl::pageTransitionViewportReady):
* UIProcess/efl/PageClientLegacyImpl.h:
(PageClientLegacyImpl):
* UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
(WebKit::PageLoadClientEfl::PageLoadClientEfl):
* UIProcess/efl/PageLoadClientEfl.h:
(PageLoadClientEfl):
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
* UIProcess/efl/PageViewportControllerClientEfl.h:
* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for parsing of -webkit-background-blend-mode
commit-queue@webkit.org [Thu, 7 Feb 2013 21:13:31 +0000 (21:13 +0000)]
Add support for parsing of -webkit-background-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=108547

Patch by Rik Cabanier <cabanier@adobe.com> on 2013-02-07
Reviewed by David Hyatt.

Source/WebCore:

Added parsing and general CSS handling of -webkit-background-blend-mode per
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#background-blend-mode

Tests: css3/compositing/background-blend-mode-property-parsing.html
       css3/compositing/background-blend-mode-property.html

* css/CSSComputedStyleDeclaration.cpp: Built value for getComputedStyle.
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp: Parsed and stored value of -webkit-background-blend-mode.
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
* css/CSSProperty.cpp: Listed -webkit-background-blend-mode as a non-inherited property.
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in: Added -webkit-background-blend-mode as a CSS property.
* css/CSSToStyleMap.cpp: Mapped background blend mode from CSS value to enum.
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore):
* css/CSSToStyleMap.h: Added function declaration 'mapFillBlendMode'.
(CSSToStyleMap):
* css/StyleBuilder.cpp: Set up propery handler for -webkit-background-blend-mode.
(WebCore::StyleBuilder::StyleBuilder):
* rendering/style/FillLayer.cpp: Added code to store and retrieve the blend mode from a layer.
(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::fillUnsetProperties):
* rendering/style/FillLayer.h: Added function definitions to manage blend mode in a layer.
(WebCore::FillLayer::blendMode):
(WebCore::FillLayer::isBlendModeSet):
(WebCore::FillLayer::setBlendMode):
(WebCore::FillLayer::clearBlendMode):
(WebCore::FillLayer::initialFillBlendMode):
(FillLayer):

LayoutTests:

Added parsing and general CSS handling of -webkit-background-blend-mode per
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#background-blend-mode

* css3/compositing/background-blend-mode-property-expected.txt: Added.
* css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
* css3/compositing/background-blend-mode-property-parsing.html: Added.
* css3/compositing/background-blend-mode-property.html: Added.
* css3/compositing/script-tests/background-blend-mode-property-parsing.js: Added.
(jsWrapperClass):
(shouldBeType):
(testBlendModeRule):
* css3/compositing/script-tests/background-blend-mode-property.js: Added.
(testblendmode):

* css3/compositing/background-blend-mode-property-expected.txt: Added.
* css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
* css3/compositing/background-blend-mode-property-parsing.html: Added.
* css3/compositing/background-blend-mode-property.html: Added.
* css3/compositing/script-tests/background-blend-mode-property-parsing.js: Added.
(jsWrapperClass):
(shouldBeType):
(testBlendModeRule):
* css3/compositing/script-tests/background-blend-mode-property.js: Added.
(testblendmode):
* platform/chromium/css3/compositing/background-blend-mode-property-expected.txt: Added.
* platform/chromium/css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r142142.
gavinp@chromium.org [Thu, 7 Feb 2013 21:10:50 +0000 (21:10 +0000)]
Unreviewed, rolling out r142142.
http://trac.webkit.org/changeset/142142
https://bugs.webkit.org/show_bug.cgi?id=109154

Source/WebCore:

Mac expectations were not right. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):

LayoutTests:

Mac expectations were not right. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Feditor%2Ftext-editor-home-button.html

* inspector/editor/text-editor-home-button-expected.txt: Removed.
* inspector/editor/text-editor-home-button.html: Removed.
* platform/efl/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r142081.
gavinp@chromium.org [Thu, 7 Feb 2013 21:03:24 +0000 (21:03 +0000)]
Unreviewed, rolling out r142081.
http://trac.webkit.org/changeset/142081
https://bugs.webkit.org/show_bug.cgi?id=109146

The patch caused a crash in inspector-protocol/nmi-webaudio*.html .

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .

* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
* platform/PlatformMemoryInstrumentation.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] turn TestRunner library into a component build
jochen@chromium.org [Thu, 7 Feb 2013 20:58:25 +0000 (20:58 +0000)]
[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466

Reviewed by Adam Barth.

To achieve this, we need to drop all dependencies on WTF.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
* DumpRenderTree/chromium/TestRunner/public/WebTask.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
* DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
* DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
* DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
* DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
* DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
* DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(WebTestRunner):
(MockGrammarCheck):
* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
* DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
* DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
(isASCIIAlpha):
(isNotASCIIAlpha):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
* DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
* DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
* DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Exclusions] shape-inside does not properly handle padding or border
commit-queue@webkit.org [Thu, 7 Feb 2013 20:50:21 +0000 (20:50 +0000)]
[CSS Exclusions] shape-inside does not properly handle padding or border
https://bugs.webkit.org/show_bug.cgi?id=102715

Patch by Bear Travis <betravis@adobe.com> on 2013-02-07
Reviewed by David Hyatt.

Source/WebCore:

This patch positions the exclusion shape based on the value of the css box sizing
property. Geometry calculations happen in the shape coordinate space. For layout,
these coordinates are translated to the border-box coordinate system by adding
the appropriate offsets.

Test: fast/exclusions/shape-inside/shape-inside-box-sizing.html

* rendering/ExclusionShapeInfo.cpp:
(WebCore::::computedShape): Pass m_shapeLogicalWidth to the exclusion shape
geometry code.
* rendering/ExclusionShapeInfo.h:
(WebCore::ExclusionShapeInfo::setShapeSize): Adjust block layout dimensions to
shape dimensions when checking to see if the shape geometry must be recalculated.
(WebCore::ExclusionShapeInfo::shapeLogicalTop): Account for layout offsets.
(WebCore::ExclusionShapeInfo::shapeLogicalBottom): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalLeft): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalRight): Ditto.
(WebCore::ExclusionShapeInfo::logicalTopOffset): Return the offset from the logical
top of the border box to the logical top of the shape.
(WebCore::ExclusionShapeInfo::logicalLeftOffset): Return the offset from the logical
left of the border box to the logical left of the shape.
(ExclusionShapeInfo):
* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::computeSegmentsForLine): Adjust line top to
be in shape coordinates.
(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop): Ditto.
* rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds): Use consistent
coordinate system (border box) to test for whether a line overlaps a shape.
(WebCore::ExclusionShapeInsideInfo::logicalLineTop): Include the logical offset
from the border box.
(WebCore::ExclusionShapeInsideInfo::logicalLineBottom): Ditto.

LayoutTests:

Test that borders and padding are properly accounted for when laying out text in
a shape inside.

* fast/exclusions/shape-inside/shape-inside-bottom-edge.html: Modified to no longer
use padding.
* fast/exclusions/shape-inside/shape-inside-box-sizing-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-box-sizing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream iOS isWebThread() and isUIThread()
benjamin@webkit.org [Thu, 7 Feb 2013 20:35:09 +0000 (20:35 +0000)]
Upstream iOS isWebThread() and isUIThread()
https://bugs.webkit.org/show_bug.cgi?id=109130

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by Sam Weinig.

Source/WebCore:

* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject initialize]):
* platform/mac/SharedBufferMac.mm:
(+[WebCoreSharedBufferData initialize]):
#ifdef out the legacy initialization as it is not correct when
using a WebThread.

Source/WTF:

On iOS, it is sometimes necessary to differenciate the thread running WebCore,
and the thread running the UI. This patch upstream those functions.

* wtf/MainThread.cpp:
* wtf/MainThread.h:
Disable the legacy initializer as it is incorrect when using the WebThread to run WebCore.
(WTF::isWebThread):
(WTF::isUIThread):
Return true when the current thread is the Web/UI thread.

* wtf/mac/MainThreadMac.mm:
(WTF::isUIThread):
(WTF::isWebThread):

* wtf/text/AtomicString.cpp:
(WTF::AtomicStringTable::create):
Use the newly added methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG::ByteCodeParser should do surgical constant folding to reduce load on the optimiz...
fpizlo@apple.com [Thu, 7 Feb 2013 20:22:26 +0000 (20:22 +0000)]
DFG::ByteCodeParser should do surgical constant folding to reduce load on the optimization fixpoint
https://bugs.webkit.org/show_bug.cgi?id=109000

Reviewed by Oliver Hunt.

Previously our source parser's ASTBuilder did some surgical constant folding, but it
didn't cover some cases.  It was particularly incapable of doing constant folding for
cases where we do some minimal loop peeling in the bytecode generator - since it
didn't "see" those constants prior to the peeling.  Example:

for (var i = 0; i < 4; ++i)
    things;

This will get peeled just a bit by the bytecode generator, so that the "i < 4" is
duplicated both at the top of the loop and the bottom.  This means that we have a
constant comparison: "0 < 4", which the bytecode generator emits without any further
thought.

The DFG optimization fixpoint of course folds this and simplifies the CFG
accordingly, but this incurs a compile-time cost.  The purpose of this change is to
do some surgical constant folding in the DFG's bytecode parser, so that such
constructs reduce load on the CFG simplifier and the optimization fixpoint.  The goal
is not to cover all cases, since the DFG CFA and CFG simplifier have a powerful
sparse conditional constant propagation that we can always fall back on. Instead the
goal is to cover enough cases that for common small functions we don't have to
perform such transformations, thereby reducing compile times.

This also refactors m_inlineStackEntry->m_inlineCallFrame to be a handy method call
and also adds the notion of a TriState-based JSValue::pureToBoolean(). Both of these
things are used by the folder.

As well, care has been taken to make sure that the bytecode parser only does folding
that is statically provable, and that doesn't arise out of speculation. This means
we cannot fold on data flow that crosses inlining boundaries. On the other hand, the
folding that the bytecode parser uses doesn't require phantoming anything. Such is
the trade-off: for anything that we do need phantoming, we defer it to the
optimization fixpoint.

Slight SunSpider speed-up.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::flushArgumentsAndCapturedVariables):
(JSC::DFG::ByteCodeParser::toInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::inlineCallFrame):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::canFold):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::getScope):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
* dfg/DFGNode.h:
(JSC::DFG::Node::isStronglyProvedConstantIn):
(Node):
* runtime/JSCJSValue.h:
* runtime/JSCJSValueInlines.h:
(JSC::JSValue::pureToBoolean):
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: CPU pegged when inspecting LocalStorage that mutates.
vivek.vg@samsung.com [Thu, 7 Feb 2013 20:02:39 +0000 (20:02 +0000)]
Web Inspector: CPU pegged when inspecting LocalStorage that mutates.
https://bugs.webkit.org/show_bug.cgi?id=107937

Reviewed by Yury Semikhatsky.

The DOM storage agent will fire an event to the frontend based on the action
performed on the storage. Based on this action, the front-end will just add/update/remove
the entry in the view. This enhances the front-end responsiveness as the round trip
for fetching the storage entries has been eliminated.

Existing test: LayoutTests/inspector/storage-panel-dom-storage-update.html should verify the change

* inspector/Inspector.json:
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype._domStorageItemUpdated):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemsCleared):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemRemoved):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemAdded):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemUpdated):
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView):
(WebInspector.DOMStorageItemsView.prototype.wasShown):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemAdded):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemUpdated):
(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
(WebInspector.DOMStorageItemsView.prototype._editingCallback):
(WebInspector.DOMStorageItemsView.prototype._deleteCallback):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._showDOMStorage.get if):
(WebInspector.ResourcesPanel.prototype._showDOMStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake WebPageProxy and sub-objects MessageReceivers
weinig@apple.com [Thu, 7 Feb 2013 19:58:36 +0000 (19:58 +0000)]
Make WebPageProxy and sub-objects MessageReceivers
https://bugs.webkit.org/show_bug.cgi?id=108785

Reviewed by Anders Carlsson.

* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::~CoordinatedLayerTreeHostProxy):
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::~DrawingAreaProxy):
(WebKit::DrawingAreaProxy::contentsRect):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setVisibleContentsRect):
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):
* UIProcess/DrawingAreaProxyImpl.h:
* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy):
* UIProcess/WebFullScreenManagerProxy.h:
(WebFullScreenManagerProxy):
* UIProcess/WebFullScreenManagerProxy.messages.in:
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::invalidate):
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.messages.in:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::inspector):
(WebKit::WebPageProxy::fullScreenManager):
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
* UIProcess/mac/WebFullScreenManagerProxyMac.mm:
(WebKit::WebFullScreenManagerProxy::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[v8] move persistent::new and ::dispose into same class
commit-queue@webkit.org [Thu, 7 Feb 2013 19:48:39 +0000 (19:48 +0000)]
[v8] move persistent::new and ::dispose into same class
https://bugs.webkit.org/show_bug.cgi?id=109065

Patch by Dan Carney <dcarney@google.com> on 2013-02-07
Reviewed by Adam Barth.

No new tests. No change in functionality.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateSingleConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::createWrapper):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::createWrapper):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::createWrapper):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::V8TestEventConstructor::createWrapper):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::createWrapper):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::createWrapper):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::constructorCallback):
(WebCore::V8TestInterface::createWrapper):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::createWrapper):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::createWrapper):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::createWrapper):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::constructorCallback):
(WebCore::V8TestObj::createWrapper):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
(WebCore::V8TestOverloadedConstructors::constructor4Callback):
(WebCore::V8TestOverloadedConstructors::createWrapper):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):
* bindings/v8/DOMDataStore.cpp:
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapper):
(DOMDataStore):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::setWrapperInObject):
* bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::get):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::removeAndDispose):
(WebCore::DOMWrapperMap::defaultWeakCallback):
* bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::reportMemoryUsage):
(ScriptWrappable):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::weakCallback):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::associateObjectWithWrapper):
* bindings/v8/V8NPObject.cpp:
(WebCore::weakNPObjectCallback):
(WebCore::createV8ObjectForNPObject):
(WebCore::forgetV8ObjectForNPObject):
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initializeContextIfNeeded):
* bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperConfiguration):
(WebCore::WrapperConfiguration::configureWrapper):
(WebCore::buildWrapperConfiguration):
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallbackCustom):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallbackCustom):
* bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallbackCustom):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallbackCustom):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8IntentCustom.cpp:
(WebCore::V8Intent::constructorCallbackCustom):
* bindings/v8/custom/V8MessageChannelCustom.cpp:
(WebCore::V8MessageChannel::constructorCallbackCustom):
* bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallbackCustom):
* bindings/v8/custom/V8WebKitPointCustom.cpp:
(WebCore::V8WebKitPoint::constructorCallbackCustom):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Autotools] Remove uses of Automake FARSTREAM_(CFLAGS|LIBS) variables, USE_FARSTREAM...
zandobersek@gmail.com [Thu, 7 Feb 2013 19:31:52 +0000 (19:31 +0000)]
[Autotools] Remove uses of Automake FARSTREAM_(CFLAGS|LIBS) variables, USE_FARSTREAM conditional
https://bugs.webkit.org/show_bug.cgi?id=109198

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: The USE_FARSTREAM conditional is being removed while the WTF_USE_FARSTREAM
define is currently a no-op.
* configure.ac: Don't set the Automake conditional as it's currently not needed due
to checking for Farstream dependency being removed in r142005.

Source/WebCore:

* GNUmakefile.am: Remove FARSTREAM_CFLAGS variable, it's not set to anything.

Source/WebKit2:

* GNUmakefile.am: Remove the FARSTREAM_(CFLAGS|LIBS) variables, they're
not set to anything.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][EFL] Add WKView methods related to background drawing
kenneth@webkit.org [Thu, 7 Feb 2013 19:19:06 +0000 (19:19 +0000)]
[WK2][EFL] Add WKView methods related to background drawing
https://bugs.webkit.org/show_bug.cgi?id=109159

Reviewed by Anders Carlsson.

* UIProcess/API/C/efl/WKView.cpp:
(WKViewSetDrawsBackground):
(WKViewGetDrawsBackground):
(WKViewSetDrawsTransparentBackground):
(WKViewGetDrawsTransparentBackground):
 * UIProcess/efl/WebView.cpp:
(WebKit::WebView::setDrawsBackground):
(WebKit):
(WebKit::WebView::drawsBackground):
(WebKit::WebView::setDrawsTransparentBackground):
(WebKit::WebView::drawsTransparentBackground):
* UIProcess/efl/WebView.h:
(WebView):
       * UIProcess/API/C/efl/WKView.h:

    New methods added

* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::displayTimerFired):
(EwkView::handleEvasObjectColorSet):
* UIProcess/API/efl/EwkView.h:
(EwkView):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_draws_page_background_set):

    Remove the unneeded m_setDrawsBackground and replace
    it with the WKView setting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDo not check enum's casing for WebKit2 C API.
commit-queue@webkit.org [Thu, 7 Feb 2013 19:04:26 +0000 (19:04 +0000)]
Do not check enum's casing for WebKit2 C API.
https://bugs.webkit.org/show_bug.cgi?id=109128

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-02-07
Reviewed by Kenneth Rohde Christiansen.

Add "-readability/enum_casing" for WebKit2 C APIs because we use word
which starts with non-capital letter 'k' for types of enums.

* Scripts/webkitpy/style/checker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConsider replacing return type of Clipboard::types() from ListHashSet<String> to...
rgf748@motorola.com [Thu, 7 Feb 2013 19:00:56 +0000 (19:00 +0000)]
Consider replacing return type of Clipboard::types() from ListHashSet<String> to Vector<String>
https://bugs.webkit.org/show_bug.cgi?id=82888

Reviewed by Kentaro Hara.

As part of removing custom bindings of types Array Clipboard::types() needs to return
Vector<String> than ListHashSet<String>

No new tests. Existing test should pass with this change as no behavoural changes.

* bindings/js/JSClipboardCustom.cpp: Replace data type from ListHashSet<> to Vector<>.
(WebCore::JSClipboard::types):
* bindings/v8/custom/V8ClipboardCustom.cpp: Ditto.
(WebCore::V8Clipboard::typesAccessorGetter): Ditto.
* dom/Clipboard.h: Ditto.
* platform/blackberry/ClipboardBlackBerry.cpp: Ditto.
(WebCore::ClipboardBlackBerry::types):
* platform/blackberry/ClipboardBlackBerry.h: Ditto.
* platform/chromium/ChromiumDataObject.cpp: Ditto.
(WebCore::ChromiumDataObject::types):
* platform/chromium/ChromiumDataObject.h: Ditto.
* platform/chromium/ClipboardChromium.cpp: Ditto.
(WebCore::ClipboardChromium::types):
* platform/chromium/ClipboardChromium.h: Ditto.
* platform/efl/ClipboardEfl.cpp: Ditto.
(WebCore::ClipboardEfl::types):
* platform/efl/ClipboardEfl.h: Ditto.
* platform/gtk/ClipboardGtk.cpp: Ditto.
(WebCore::ClipboardGtk::types):
* platform/gtk/ClipboardGtk.h: Ditto.
* platform/mac/ClipboardMac.h: Ditto.
* platform/mac/ClipboardMac.mm: Ditto.
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
* platform/qt/ClipboardQt.cpp: Ditto.
(WebCore::ClipboardQt::types):
* platform/qt/ClipboardQt.h: Ditto.
* platform/win/ClipboardWin.cpp: Ditto.
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
* platform/win/ClipboardWin.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] StringCache::m_stringCache should be HashMap<StringImpl*, Persistent<String>>
haraken@chromium.org [Thu, 7 Feb 2013 18:57:09 +0000 (18:57 +0000)]
[V8] StringCache::m_stringCache should be HashMap<StringImpl*, Persistent<String>>
https://bugs.webkit.org/show_bug.cgi?id=109123

Reviewed by Adam Barth.

Currently StringCache::m_stringCache is implemented as
HashMap<StringImpl*, v8::String*>. Given that v8::String*
can change when a GC is triggered, it is dangerous to store a raw pointer.
We should use HashMap<StringImpl*, v8::Persistent<v8::String>> instead.

This is a possible fix for an IndexedDB crash (https://bugs.webkit.org/show_bug.cgi?id=105363),
although I'm not sure if this patch fixes the crash. (I couldn't reproduce the crash.)

No tests. This change highly depends on GC behavior and thus it is
difficult to make a reliable test case.

* bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):
* bindings/v8/V8ValueCache.h:
(StringCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] EWK2UnitTestBase.ewk_view_page_contents_get API test is sometimes failing
commit-queue@webkit.org [Thu, 7 Feb 2013 18:49:45 +0000 (18:49 +0000)]
[EFL][WK2] EWK2UnitTestBase.ewk_view_page_contents_get API test is sometimes failing
https://bugs.webkit.org/show_bug.cgi?id=108634

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-07
Reviewed by Alexey Proskuryakov.

Use more robust data validation in EWK2UnitTestBase.ewk_view_page_contents_get
so that the test passes consistently. The issue was that the header before the
data includes the current date. Depending on the date, the data may start at a
different index in the returned string. Instead of hardcoding the data start
index in the test, we now use String::contains().

* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(PageContentsCallback):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS 2.1 failure: floats-149 fails
robert@webkit.org [Thu, 7 Feb 2013 18:48:39 +0000 (18:48 +0000)]
CSS 2.1 failure: floats-149 fails
https://bugs.webkit.org/show_bug.cgi?id=95772

Reviewed by David Hyatt.

Source/WebCore:

Treat inlines that contain nothing but empty inlines as empty too so that they get a linebox.

Tests: fast/inline/inline-with-empty-inline-children.html
       css2.1/20110323/floats-149.htm

* rendering/InlineIterator.h:
(WebCore::isEmptyInline):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Now that empty inlines get a linebox any out-of-flow
objects inside an empty inline (on a line that is otherwise empty) won't get positioned while skipping
through leading whitespace.

LayoutTests:

* css2.1/20110323/floats-149-expected.html: Added.
* css2.1/20110323/floats-149.htm: Added.
* fast/inline/inline-with-empty-inline-children-expected.txt: Added.
* fast/inline/inline-with-empty-inline-children.html: Added.
* platform/chromium-win/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WinCairo] Compile fix after r141981
commit-queue@webkit.org [Thu, 7 Feb 2013 18:39:10 +0000 (18:39 +0000)]
[WinCairo] Compile fix after r141981
https://bugs.webkit.org/show_bug.cgi?id=109184

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-02-07
Reviewed by Brent Fulgham.

* platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Cookie database isn't loaded into memory in some rare cases
commit-queue@webkit.org [Thu, 7 Feb 2013 18:24:09 +0000 (18:24 +0000)]
[BlackBerry] Cookie database isn't loaded into memory in some rare cases
https://bugs.webkit.org/show_bug.cgi?id=109202
PR 286189

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-02-07
Reviewed by Yong Li.
Internally Reviewed by Konrad Piascik.

If a get/setCookie call is made before the database is loaded, or if there's some
kind of error that causes the loading of the database to fail in the constructor
of CookieManager, the browser will get into a state where it seems like cookie is
permanenty disabled.

Instead of logging the errors and redispatching the setCookie, we should do a force sync
to load the cookie database before continuing.

Since the bug is so difficult to reproduce (I never did so myself), I did the follow test
to make sure the code path is correct:
1) Make sure original implementation is retained - open and loading done in the constructor
2) Removed opening and loading in constructor, the new calls in get/setcookies loaded the db just fine (although with
an initial lag because we are blocking WKT while performing SQLite options).
3) Removed loading in constructor, the new calls loaded the db just fine.

* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::openAndLoadDatabaseSynchronously):
(WebCore):
* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
(CookieDatabaseBackingStore):
* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::getCookie):
(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore::CookieManager::getRawCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Shaders] Add WebKitCSSFilterRule to DOMWindow.idl
mvujovic@adobe.com [Thu, 7 Feb 2013 18:21:12 +0000 (18:21 +0000)]
[CSS Shaders] Add WebKitCSSFilterRule to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=109082

Source/WebCore:

Reviewed by Dean Jackson.

Add an entry for WebKitCSSFilterRuleConstructor in DOMWindow.idl.

Tests: css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid.html
       css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid.html

* page/DOMWindow.idl:

LayoutTests:

Move the at-rule parsing tests to the recently added folder named
"custom-with-at-rule-parsing".

Remove the "custom-filter" prefix from the test filenames to
match the new convention.

Update the tests to use the "shouldHaveConstructor" JS helper function instead of the
"shouldBeType" JS helper function. Among other things, using "shouldHaveConstructor" tests
that window.WebKitCSSFilterRule is defined. "shouldHaveConstructor" has the same
behavior in JSC and V8, unlike "shouldBeType". Therefore, remove the Chromium-specific text
expectation file that was previously needed for "shouldBeType".

Reviewed by Dean Jackson.

* css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid-expected.txt: Renamed from LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-invalid-expected.txt.
* css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid.html: Renamed from LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-invalid.html.
* css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid-expected.txt: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid.html: Renamed from LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-valid.html.
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-invalid.js: Renamed from LayoutTests/css3/filters/script-tests/custom-filter-parsing-at-rule-invalid.js.
(testInvalidFilterAtRule):
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-valid.js: Renamed from LayoutTests/css3/filters/script-tests/custom-filter-parsing-at-rule-valid.js.
(testFilterAtRule):
(testNestedRules):
(checkRule):
* css3/filters/custom/custom-filter-parsing-at-rule-valid-expected.txt: Removed.
* platform/chromium/css3/filters/custom/custom-filter-parsing-at-rule-valid-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Remove unused workspace field from NetworkUISourceCodeProvider
vsevik@chromium.org [Thu, 7 Feb 2013 18:14:54 +0000 (18:14 +0000)]
Web Inspector: Remove unused workspace field from NetworkUISourceCodeProvider
https://bugs.webkit.org/show_bug.cgi?id=109201

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider):
* inspector/front-end/inspector.js:

LayoutTests:

* inspector/debugger/network-uisourcecode-provider.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r142003): Duplicate "Unknown" strings in LocalizedStrings.cpp not distingu...
jberlin@webkit.org [Thu, 7 Feb 2013 18:12:06 +0000 (18:12 +0000)]
REGRESSION(r142003): Duplicate "Unknown" strings in LocalizedStrings.cpp not distinguished
by key
https://bugs.webkit.org/show_bug.cgi?id=109196

Reviewed by Eric Carlson.

* English.lproj/Localizable.strings:
Updated for the changes.
* platform/LocalizedStrings.cpp:
(WebCore::unknownFileSizeText):
Add a key.
(WebCore::textTrackNoLabelText):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInvalid code is generated for storing constants with baseindex addressing modes on...
zherczeg@webkit.org [Thu, 7 Feb 2013 18:04:04 +0000 (18:04 +0000)]
Invalid code is generated for storing constants with baseindex addressing modes on ARM traditional.
https://bugs.webkit.org/show_bug.cgi?id=109050

Reviewed by Oliver Hunt.

The S! scratch register is reused, but it should contain the constant value.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::baseIndexTransfer32):
(JSC::ARMAssembler::baseIndexTransfer16):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: linkifyResourceAsNode produced anchor should not prefer resources...
vsevik@chromium.org [Thu, 7 Feb 2013 18:03:17 +0000 (18:03 +0000)]
Web Inspector: linkifyResourceAsNode produced anchor should not prefer resources to scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=109197

Reviewed by Pavel Feldman.

Javascript syntax errors in console are now linkified so that they show sources panel by default.

* inspector/front-end/ResourceUtils.js:
(WebInspector.linkifyResourceAsNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Add settings checkbox for composited layer borders
commit-queue@webkit.org [Thu, 7 Feb 2013 17:55:17 +0000 (17:55 +0000)]
Web Inspector: Add settings checkbox for composited layer borders
https://bugs.webkit.org/show_bug.cgi?id=109096

Patch by Eberhard Graether <egraether@google.com> on 2013-02-07
Reviewed by Pavel Feldman.

This change adds a checkbox to show composited layer borders to the WebInspector's
rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The setting
is visible if InspectorClient::canShowDebugBorders() returns true.

Source/Platform:

* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
(WebKit::WebLayerTreeView::setShowDebugBorders):

Source/WebCore:

No new tests.

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::canShowDebugBorders):
(WebCore::InspectorClient::setShowDebugBorders):
(InspectorClient):
* inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canShowDebugBorders):
(WebCore):
(WebCore::InspectorPageAgent::setShowDebugBorders):
* inspector/InspectorPageAgent.h:
* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _showDebugBordersChanged):
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):

Source/WebKit/chromium:

* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowDebugBorders):
(WebKit):
(WebKit::InspectorClientImpl::setShowDebugBorders):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowDebugBorders):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r142141.
gavinp@chromium.org [Thu, 7 Feb 2013 17:51:49 +0000 (17:51 +0000)]
Unreviewed, rolling out r142141.
http://trac.webkit.org/changeset/142141
https://bugs.webkit.org/show_bug.cgi?id=108990

Reland r142112, will update Chromium expectations and create a
Chromium bug instead for the crash.

.:

* ManualTests/remove-fixed-position-but-keep-compositing.html: Added.

Source/WebCore:

* CMakeLists.txt:
* Target.pri:
* WebCore.pri:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create):
* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: Added.
(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::setLayerIsFixedToContainerLayer):
* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h: Added.
(WebCore):
(ScrollingCoordinatorCoordinatedGraphics):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setFixedToViewport):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

Source/WebKit2:

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: home button behaviour is wrong in DTE
commit-queue@webkit.org [Thu, 7 Feb 2013 17:46:41 +0000 (17:46 +0000)]
Web Inspector: home button behaviour is wrong in DTE
https://bugs.webkit.org/show_bug.cgi?id=109154

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Handle home key shortcut explicitly in TextEditorMainPanel.

New test: inspector/editor/text-editor-home-button.html

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
(WebInspector.TextEditorMainPanel.prototype._handleHomeKey):

LayoutTests:

Add layout test to verify home button behaviour. Exclude this test on
platforms that do not have eventSender object in test shell.

* inspector/editor/text-editor-home-button-expected.txt: Added.
* inspector/editor/text-editor-home-button.html: Added.
* platform/efl/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r142112.
gavinp@chromium.org [Thu, 7 Feb 2013 17:32:07 +0000 (17:32 +0000)]
Unreviewed, rolling out r142112.
http://trac.webkit.org/changeset/142112
https://bugs.webkit.org/show_bug.cgi?id=108990

The new test scrollingcoordinator/non-fast-scrollable-region-transformed- iframe.html crashes on Lion.

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=scrollingcoordinator%2Fnon-fast-scrollable-region-transformed-iframe.html

.:

* ManualTests/remove-fixed-position-but-keep-compositing.html: Removed.

Source/WebCore:

* CMakeLists.txt:
* Target.pri:
* WebCore.pri:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create):
* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: Removed.
* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h: Removed.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(WebCore::CoordinatedGraphicsLayer::setFixedToViewport):

Source/WebKit2:

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::updateOffsetFromViewportForSelf):
(WebKit):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::CoordinatedLayerTreeHost::syncFixedLayers):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScrollbars misplaced with accelerated compositing for overflow scroll
allan.jensen@digia.com [Thu, 7 Feb 2013 17:29:30 +0000 (17:29 +0000)]
Scrollbars misplaced with accelerated compositing for overflow scroll
https://bugs.webkit.org/show_bug.cgi?id=108625

Reviewed by Simon Fraser.

Source/WebCore:

Scrollbars require their own layer if overflow scroll is composited,
otherwise the scrollbars would be rendered on the content layer and
not fixed to the viewport.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresScrollCornerLayer):

LayoutTests:

Update the results for the one test that explicitly set accelerated compositing for overflow scroll,
and used to have bad results for non-chromium. The new baselines are almost identical to chomium baseline.

* platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
* platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't ASSERT things about uninitialized variables.
mkwst@chromium.org [Thu, 7 Feb 2013 17:18:47 +0000 (17:18 +0000)]
Don't ASSERT things about uninitialized variables.
https://bugs.webkit.org/show_bug.cgi?id=109187

Reviewed by Jochen Eisinger.

Rather than ASSERTing that an uninitialized ExceptionCode is non-zero
after some method executes, we should use the ASSERT_NO_EXCEPTION macro.

* editing/markup.cpp:
(WebCore::removeElementPreservingChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Regression] breakpoint condition not editable
commit-queue@webkit.org [Thu, 7 Feb 2013 17:17:26 +0000 (17:17 +0000)]
Web Inspector: [Regression] breakpoint condition not editable
https://bugs.webkit.org/show_bug.cgi?id=109183

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.

Improve TextEditorMainPanel.selection() method to return null if the
selection is set inside of decoration element.

No new tests.

* inspector/front-end/DOMExtension.js:
(Node.prototype.enclosingNodeOrSelfWithClass): Improve to add iteration boundary.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype.selection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Fix all flicker caused by empty/incomplete geometries.
jpetsovits@rim.com [Thu, 7 Feb 2013 16:58:17 +0000 (16:58 +0000)]
[BlackBerry] Fix all flicker caused by empty/incomplete geometries.
https://bugs.webkit.org/show_bug.cgi?id=108951
RIM PR 286925

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

The main idea for this patch is that whenever we adopt
a new backingstore geometry that doesn't contain any
rendered tiles, or VisibleZoom render jobs that need more
tiles to be rendered to be considered complete, we'll then
suspend blitting until there is valid content to show.

This main idea is codified as checks for empty buffers
in adoptAsFrontState(), and checks for the current state
of the render queue after rendering content in render().
However, as BackingStore objects with disabled surface pools
or pure use of accelerated compositing also swap geometries
in some circumstances, the use of suspend counters grows
increasingly fragile.

To make this patch more resilient against regressions,
the current suspend counter is complemented with several
explicit conditions for suspending screen updates,
and both subsequently combined into a single cached
boolean value telling the UI thread whether or not to
suspend. In the future, other suspend calls can be
migrated to this "state machine" design as well,
potentially phasing out the suspend counter altogether.

The immediate result is that there will be no flashing
of background color between page loads or after discarding
tiles on scale changes until the content has been rendered.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::suspendScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):
(BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):
(BlackBerry::WebKit::BackingStore::releaseOwnedBackingStoreMemory):
* Api/BackingStore_p.h:
(BackingStorePrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setVisible):
(BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][EFL][QT]REGRESSION(r142045): Scrolling is broken
mikhail.pozdnyakov@intel.com [Thu, 7 Feb 2013 16:46:49 +0000 (16:46 +0000)]
[WK2][EFL][QT]REGRESSION(r142045): Scrolling is broken
https://bugs.webkit.org/show_bug.cgi?id=109185

Reviewed by Kenneth Rohde Christiansen.

This patch is disabling paints clipping logic added at r142045 for the case
when the view should render the entire contents (case of using tiled backing store).

No new tests, covered by plenty of existing manual tests that allow scrolling
(for example fixed-position.html).

* platform/ScrollView.cpp:
(WebCore::ScrollView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Added platform specific expected files after r140693.
kadam@inf.u-szeged.hu [Thu, 7 Feb 2013 16:42:50 +0000 (16:42 +0000)]
[Qt] Unreviewed gardening. Added platform specific expected files after r140693.
https://bugs.webkit.org/show_bug.cgi?id=107567.

* platform/qt/TestExpectations:
* platform/qt/css2.1/t0505-c16-descendant-01-e-expected.png:
* platform/qt/css2.1/t0505-c16-descendant-01-e-expected.txt:
* platform/qt/editing/selection/extend-by-sentence-001-expected.png:
* platform/qt/editing/selection/extend-by-sentence-001-expected.txt:
* platform/qt/fast/inline/drawStyledEmptyInlines-expected.png:
* platform/qt/fast/inline/drawStyledEmptyInlines-expected.txt:
* platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
* platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
* platform/qt/fast/text/capitalize-empty-generated-string-expected.png:
* platform/qt/fast/text/capitalize-empty-generated-string-expected.txt:
* platform/qt/fast/text/whitespace/006-expected.png:
* platform/qt/fast/text/whitespace/006-expected.txt:
* platform/qt/fast/text/whitespace/007-expected.png:
* platform/qt/fast/text/whitespace/007-expected.txt:
* platform/qt/svg/batik/text/xmlSpace-expected.png:
* platform/qt/svg/batik/text/xmlSpace-expected.txt:
* platform/qt/svg/carto.net/combobox-expected.png:
* platform/qt/svg/carto.net/combobox-expected.txt:
* platform/qt/tables/mozilla/bugs/bug113235-3-expected.png:
* platform/qt/tables/mozilla/bugs/bug113235-3-expected.txt:
* platform/qt/tables/mozilla/bugs/bug1188-expected.png:
* platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
* platform/qt/tables/mozilla/bugs/bug1318-expected.png:
* platform/qt/tables/mozilla/bugs/bug1318-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed warning fix.
ossy@webkit.org [Thu, 7 Feb 2013 16:42:49 +0000 (16:42 +0000)]
Unreviewed warning fix.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildAndTestFactory.__init__):
(DownloadAndPerfTestWebKit2Factory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed typo fix after r142121.
ossy@webkit.org [Thu, 7 Feb 2013 16:42:27 +0000 (16:42 +0000)]
Unreviewed typo fix after r142121.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Show elements and sources sidebar panes in a tabbed pane when they...
pfeldman@chromium.org [Thu, 7 Feb 2013 16:39:21 +0000 (16:39 +0000)]
Web Inspector: Show elements and sources sidebar panes in a tabbed pane when they are below the main pane
https://bugs.webkit.org/show_bug.cgi?id=107552

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.

Removed the aspect ratio detection logic and implemented explicit user action "Split Horizontally" available
in Elements and Sources panels. When split horizontally the sidebar panes are organized into a tabbed pane.
This user action is behind an experimental flag.

No new tests.

* inspector/front-end/ContextMenu.js:
(WebInspector.ContextMenu.prototype.show):
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype.createProxy):
(WebInspector.DOMBreakpointsSidebarPane.prototype.onContentReady):
(WebInspector.DOMBreakpointsSidebarPane.Proxy):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.expanded):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.expand):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.collapse):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.onContentReady):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.wasShown):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype._reattachBody):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._populateContextMenu):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._clearInterface):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._contextMenuEventFired):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.prepareContent):
(WebInspector.SidebarPane.prototype.expanded):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.collapse):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype._setExpandCallback):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarPaneStack.prototype.activePaneId):
(WebInspector.SidebarPaneStack.prototype.setActivePaneId):
(WebInspector.SidebarPaneStack.prototype._setExpanded):
(WebInspector.SidebarPaneStack.prototype._onPaneExpanded):
(WebInspector.SidebarPaneStack.prototype._collapsePane):
(WebInspector.SidebarTabbedPane):
(WebInspector.SidebarTabbedPane.prototype.addPane):
(WebInspector.SidebarTabbedPane.prototype.activePaneId):
(WebInspector.SidebarTabbedPane.prototype.setActivePaneId):
(WebInspector.SidebarPaneGroup):
(WebInspector.SidebarPaneGroup.prototype.setStacked):
(WebInspector.SidebarPaneGroup.prototype.addPane):
(WebInspector.SidebarPaneGroup.prototype.attachToPanel):
(WebInspector.SidebarPaneGroup.prototype.populateContextMenu.toggleSplitDirection):
(WebInspector.SidebarPaneGroup.prototype.get _contextMenuEventFired):
(WebInspector.SidebarPaneGroup.prototype._onSplitDirectionSettingChanged):
* inspector/front-end/SidebarView.js:
(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype._updateSidebarElementStyle):
(WebInspector.SidebarView.prototype.setVertical):
(WebInspector.SidebarView.prototype.onResize):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.ComputedStyleSidebarPane.prototype.wasShown):
(WebInspector.ComputedStyleSidebarPane.prototype.prepareContent):
* inspector/front-end/inspector.css:
(.sidebar-pane .section .properties, .event-bar .event-properties):
(.pane-title):
(.sidebar-pane-toolbar):
(.sidebar-pane-toolbar > *):
(.sidebar-pane-toolbar > select):
(.sidebar-pane-toolbar > select:hover):
(.sidebar-pane-toolbar > select:active):
(.sidebar-pane-toolbar > select.select-settings):
(.sidebar-pane-toolbar > select.select-filter):
(.sidebar-pane-toolbar > select > option, .sidebar-pane-toolbar > select > hr):
(.sidebar-pane-toolbar > .pane-title-button):
(.sidebar-pane-toolbar > .pane-title-button:hover):
(.sidebar-pane-toolbar > .pane-title-button:active, .sidebar-pane-toolbar > .pane-title-button.toggled):
(.sidebar-pane-toolbar > .pane-title-button.add):
(.sidebar-pane-toolbar > .pane-title-button.element-state):
(.sidebar-pane-toolbar > .pane-title-button.refresh):
(.sidebar-pane):
(.sidebar-pane > .body):
(.sidebar-pane > .body .info):
(.sidebar-pane > .body .placard + .info):
(.sidebar-pane.visible > .body):
(.sidebar-pane > .body .breakpoint-condition):
(.sidebar-pane.visible:nth-last-of-type(1)):
(.sidebar-pane-subtitle):
(.sidebar-pane-subtitle input, .section .header input[type=checkbox]):
(.sidebar-pane .breakpoint-hit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] configure.ac requires a cleanup
zandobersek@gmail.com [Thu, 7 Feb 2013 16:38:34 +0000 (16:38 +0000)]
[GTK] configure.ac requires a cleanup
https://bugs.webkit.org/show_bug.cgi?id=99272

Reviewed by Martin Robinson.

Clean up configure.ac. While there is no strict style guideline determined
for this file the changes enforce the usual indentation of four spaces along
with line wrapping at 130 characters and grammar fixes/updates.

* configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r142111.
gavinp@chromium.org [Thu, 7 Feb 2013 16:37:27 +0000 (16:37 +0000)]
Unreviewed, rolling out r142111.
http://trac.webkit.org/changeset/142111
https://bugs.webkit.org/show_bug.cgi?id=108055

win7 bot didn't display Arabic, see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance-required-ar.html

Source/WebCore:

* Resources/pagepopups/calendarPicker.css:
(.today-clear-area .today-button):
* Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize):

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Removed.
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Removed.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Removed.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Removed.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Removed.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix build without 3D_GRAPHICS
caio.oliveira@openbossa.org [Thu, 7 Feb 2013 16:31:22 +0000 (16:31 +0000)]
[Qt] Fix build without 3D_GRAPHICS
https://bugs.webkit.org/show_bug.cgi?id=109194

Reviewed by Noam Rosenthal.

Now that Coordinated Graphics was moved to WebCore, we need to explicitly enable
it when we have 3D_GRAPHICS. This dependency was implicitly by the fact that
3D_GRAPHICS is a dependency of WebKit2 and Coordinated Graphics was only
available there. This should fix build for Qt SH4 Linux.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Regression] Map.size() returns negative values.
vsevik@chromium.org [Thu, 7 Feb 2013 16:30:20 +0000 (16:30 +0000)]
Web Inspector: [Regression] Map.size() returns negative values.
https://bugs.webkit.org/show_bug.cgi?id=109174

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/utilities.js:

LayoutTests:

* inspector/map-expected.txt:
* inspector/map.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: break details are only rendered upon first debugger pause.
pfeldman@chromium.org [Thu, 7 Feb 2013 16:25:43 +0000 (16:25 +0000)]
Web Inspector: break details are only rendered upon first debugger pause.
https://bugs.webkit.org/show_bug.cgi?id=109193

Reviewed by Vsevolod Vlasov.

* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r142118.
gavinp@chromium.org [Thu, 7 Feb 2013 16:22:49 +0000 (16:22 +0000)]
Unreviewed, rolling out r142118.
http://trac.webkit.org/changeset/142118
https://bugs.webkit.org/show_bug.cgi?id=109044

Broke SVG! Oh noes!

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::direction):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::mode):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
* dom/Document.cpp:
(WebCore::Document::setTitle):
* dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
* editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):
* editing/EditorCommand.cpp:
(WebCore::unionDOMRanges):
* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::removeNode):
(WebCore::ReplacementFragment::insertNodeBefore):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
* editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doUnapply):
* editing/TextIterator.cpp:
(WebCore::CharacterIterator::range):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::collapsedToBoundary):
* editing/htmlediting.cpp:
(WebCore::createTabSpanElement):
* editing/mac/EditorMac.mm:
(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):
* editing/markup.cpp:
(WebCore::createMarkup):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
(WebCore::createFragmentFromNodes):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText):
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
* html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::addRule):
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::dispatchDOMEvent):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::deleteFromDocument):
* page/DragController.cpp:
(WebCore::prepareClipboardForImageDrag):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::visiblePositionForIndex):
* rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):
(WebCore::SVGRenderStyle::initialStrokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeWidth):
* svg/SVGAnimatedLength.cpp:
(WebCore::sharedSVGLength):
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
* svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::textLengthAnimated):
* svg/animation/SVGSMILElement.cpp:
(WebCore::constructQualifiedName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QtTestBrowser should provide option to enable/disable Javascript
vivek.vg@samsung.com [Thu, 7 Feb 2013 16:04:21 +0000 (16:04 +0000)]
[Qt] QtTestBrowser should provide option to enable/disable Javascript
https://bugs.webkit.org/show_bug.cgi?id=107461

Reviewed by Jocelyn Turcotte.

Option to enable/disable Javascript would be handy option to test
certain functionalities of web pages with/without Javascript.

* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::toggleJavaScriptEnabled):
* QtTestBrowser/launcherwindow.h:
(LauncherWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove #if USE(V8) from IDBRequest.h
haraken@chromium.org [Thu, 7 Feb 2013 15:56:18 +0000 (15:56 +0000)]
Remove #if USE(V8) from IDBRequest.h
https://bugs.webkit.org/show_bug.cgi?id=109163

Reviewed by Andreas Kling.

The header included inside the #if USE(V8) macro is not used.
We can simply remove it.

No tests. No change in behavior.

* Modules/indexeddb/IDBRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGraphicsContext::drawImageBuffer is inefficient
schenney@chromium.org [Thu, 7 Feb 2013 15:53:50 +0000 (15:53 +0000)]
GraphicsContext::drawImageBuffer is inefficient
https://bugs.webkit.org/show_bug.cgi?id=104367

Reviewed by Dirk Schulze.

This patch converts all of the drawImage and drawImageBuffer
convenience methods (those that take parameters of various types) to
invoke the implementing method (that takes FloatRect src and dest)
directly, rather than through the next-most-convenient method as was
done previously. This will knock some layers off the stack compared
to the existing code, and may remove one or two constructor invocations.
This may be slightly more efficient, and also makes debugging simpler.

Also removes the unused drawImage method that takes and IntRect source
area and IntRect destination. It is not invoked anywhere in a standard
WebKit checkout.

No new tests. No change in functionality, just refactoring.

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage): Modify all the convenience versions to call
the implementing version directly.
(WebCore::GraphicsContext::drawImageBuffer): Modify all the convenience versions
to call the implementing version directly.
* platform/graphics/GraphicsContext.h:
(GraphicsContext): Remove IntRect, IntRect version of drawImage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConversion from localized numbers to HTML numbers should accept not only localized...
tkent@chromium.org [Thu, 7 Feb 2013 15:46:58 +0000 (15:46 +0000)]
Conversion from localized numbers to HTML numbers should accept not only localized numbers but also HTML numbers
https://bugs.webkit.org/show_bug.cgi?id=109160

Reviewed by Kentaro Hara.

Source/WebCore:

For example, A French user needs to specify a number to a number input
field. He might use a local decimal point, like 3,141592, or he might
use the standard decimal point like 3.141592. We had better accept both
of them.

We accepted both last year, but we changed the behavior so that we
accept only localized numbers because we had some cases where an input
string can be recognized as both of a localized number and the standard
number. e.g. 3.141 is 3141 in French locale and 3.141 in the
standard. Now we introduce a simple rule that we don't accept group
separator at all. So users won't confuse even if we accept both of
decimal points.

Test: fast/forms/number/number-l10n-input.html

* platform/text/PlatformLocale.cpp:
(WebCore::Locale::convertFromLocalizedNumber):
If the specified string contains invalid characters including group
separators, just return the specified string.

LayoutTests:

* fast/forms/number/number-l10n-input-expected.txt: Added.
* fast/forms/number/number-l10n-input.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add a WebKit2 Performance bot.
rakuco@webkit.org [Thu, 7 Feb 2013 15:35:27 +0000 (15:35 +0000)]
[EFL] Add a WebKit2 Performance bot.
https://bugs.webkit.org/show_bug.cgi?id=109188

Reviewed by Csaba Osztrogon√°c.

* BuildSlaveSupport/build.webkit.org-config/config.json: Add the
efl-linux-perf-1 slave (a 64-bit Release WK2 Perf bot), and make
the "EFL Linux 64-bit Release" bot trigger it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] CHHW - Characters that are using 32 bits encoding get trunked to 16bits
commit-queue@webkit.org [Thu, 7 Feb 2013 15:24:28 +0000 (15:24 +0000)]
[BlackBerry] CHHW - Characters that are using 32 bits encoding get trunked to 16bits
https://bugs.webkit.org/show_bug.cgi?id=109126
PR 292540

Source/WebCore:

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.

Change char code to 4 bytes.
Need to convert UTF32 key char to UTF16 before constructing a WTF::String.

* platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::unmodifiedCharacter):
(PlatformKeyboardEvent):
* platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):
(WebCore::adjustCharacterFromOS):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

Source/WebKit/blackberry:

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.
Internally reviewed by Mike Fenton.

Key char is UTF32 encoded, should be 4 bytes.

* Api/WebPage.cpp:
(BlackBerry::WebKit::handleScrolling):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
* WebKitSupport/InputHandler.h:
(InputHandler):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::shouldExtendSelectionInDirection):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
* WebKitSupport/SelectionHandler.h:
(SelectionHandler):

Tools:

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.

Change char code to 4 bytes.

* DumpRenderTree/blackberry/EventSender.cpp:
(keyDownCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] New baselines for GPU-accelerated reference filters tests. Unreviewed.
senorblanco@chromium.org [Thu, 7 Feb 2013 15:21:55 +0000 (15:21 +0000)]
[chromium] New baselines for GPU-accelerated reference filters tests.  Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=104289

* platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Added.
* platform/chromium-linux/css3/filters/effect-reference-ordering-hw-expected.png:
* platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt: Added.
* platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
* platform/chromium-mac/css3/filters/effect-reference-ordering-hw-expected.png:
* platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-win/css3/filters/effect-reference-ordering-hw-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReplace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro.
mkwst@chromium.org [Thu, 7 Feb 2013 15:14:05 +0000 (15:14 +0000)]
Replace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro.
https://bugs.webkit.org/show_bug.cgi?id=109044

Reviewed by Darin Adler.

The pattern:

    ExceptionCode ec = 0;
    methodThatGeneratesException(ec);
    ASSERT(!ec);

is more clearly and succinctly written as:

    methodThatGeneratesException(ASSERT_NO_EXCEPTION);

This patch replaces the occurances of the former that never touch 'ec'
again with the latter. It does the same for 'ASSERT(ec == 0);' (and, as
a drive-by, replaces 'ASSERT(ec == 0)' with 'ASSERT(!ec)' in places
where it does indeed matter that 'ec' get set properly.

No change in behavior should result from this refactoring.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::direction):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::mode):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
* dom/Document.cpp:
(WebCore::Document::setTitle):
* dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
* editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::createDeletionUI):
    Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
(WebCore::DeleteButtonController::show):
    Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
* editing/EditorCommand.cpp:
(WebCore::unionDOMRanges):
* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::removeNode):
(WebCore::ReplacementFragment::insertNodeBefore):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
* editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doUnapply):
* editing/TextIterator.cpp:
(WebCore::CharacterIterator::range):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::collapsedToBoundary):
* editing/htmlediting.cpp:
(WebCore::createTabSpanElement):
* editing/mac/EditorMac.mm:
(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):
* editing/markup.cpp:
(WebCore::createMarkup):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
(WebCore::createFragmentFromNodes):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
    Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
    Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText):
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
* html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::addRule):
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::dispatchDOMEvent):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::deleteFromDocument):
* page/DragController.cpp:
(WebCore::prepareClipboardForImageDrag):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::visiblePositionForIndex):
* rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):
(WebCore::SVGRenderStyle::initialStrokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeWidth):
* svg/SVGAnimatedLength.cpp:
(WebCore::sharedSVGLength):
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
* svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::textLengthAnimated):
* svg/animation/SVGSMILElement.cpp:
(WebCore::constructQualifiedName):
    Replaced inline ASSERT with ASSERT_NO_EXCEPTION.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Reader Mode: Opening two links quickly from reader mode causes browser...
commit-queue@webkit.org [Thu, 7 Feb 2013 15:08:22 +0000 (15:08 +0000)]
[BlackBerry] Reader Mode: Opening two links quickly from reader mode causes browser bad state
https://bugs.webkit.org/show_bug.cgi?id=109124

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.

RIM BUG 291246 Internally reviewed by YongLi.
Move the WebPageGroupLoadDeferrer object from ChromeClientBlackBerry::createWindow()
into WebPageClientImpl::createWindow() to make it more close to its protecting place.

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Send type details with IMF mask as part of focus gained.
mifenton@rim.com [Thu, 7 Feb 2013 15:07:03 +0000 (15:07 +0000)]
[BlackBerry] Send type details with IMF mask as part of focus gained.
https://bugs.webkit.org/show_bug.cgi?id=109086

Reviewed by Yong Li.

PR 292609.

Add masking options based on VKB type to the IMF mask.

Reviewed Internally by Nima Ghanavatian.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::addInputStyleMaskForKeyboardType):
(WebKit):
(BlackBerry::WebKit::InputHandler::setElementFocused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Export mimeType in NetworkJob
mary.wu@torchmobile.com.cn [Thu, 7 Feb 2013 15:05:26 +0000 (15:05 +0000)]
[BlackBerry] Export mimeType in NetworkJob
https://bugs.webkit.org/show_bug.cgi?id=109002

Reviewed by Yong Li.

NetworkJob will analysize resource mimetype and set it to resourceResponse,
we will pass it on to be used by other Streams like download stream.

RIM bug# 284408, internally reviewed by Liam Quinn.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::mimeType):
(WebCore):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: support JavaScript variable mutation in protocol and V8 bindings
commit-queue@webkit.org [Thu, 7 Feb 2013 15:00:13 +0000 (15:00 +0000)]
Web Inspector: support JavaScript variable mutation in protocol and V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=107829

Source/WebCore:

A new command is added to protocol description and the call is passed through
debugger agent through injected script and debugger script down to V8 mirror
API. JSC bindings got a thorw exception stub.

Only declarative JavaScript scopes are supported (local, closure, catch). Other
scopes (global, with) are not supported by V8 and not supported by protocol, because
manual approach (direct property assigment) is available for them in form of evaluate
commands and is more desirable because of a complex nature of operation (it can throw
exception in several cases such as exception in setter function).

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.

Test: inspector-protocol/debugger-setVariableValue.html

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::setFunctionVariableValue):
(WebCore):
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::setVariableValue):
(WebCore):
* bindings/v8/DebuggerScript.js:
(.):
* bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::setVariableValue):
(WebCore):
* bindings/v8/JavaScriptCallFrame.h:
(JavaScriptCallFrame):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setFunctionVariableValue):
(WebCore):
* bindings/v8/ScriptDebugServer.h:
(ScriptDebugServer):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::setFunctionVariableValueCallback):
(WebCore):
* bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::setVariableValueCallback):
(WebCore):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::setVariableValue):
(WebCore):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::setVariableValue):
(WebCore):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/JavaScriptCallFrame.idl:

LayoutTests:

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.

* inspector-protocol/debugger-setVariableValue-expected.txt: Added.
* inspector-protocol/debugger-setVariableValue.html: Added.
* inspector/console/command-line-api-expected.txt:
* platform/chromium/inspector-protocol/debugger-setVariableValue-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: reduce number of native memory instrumentation categories
yurys@chromium.org [Thu, 7 Feb 2013 14:56:30 +0000 (14:56 +0000)]
Web Inspector: reduce number of native memory instrumentation categories
https://bugs.webkit.org/show_bug.cgi?id=109146

Reviewed by Pavel Feldman.

Fix layout tests that started failing after r142081.

* inspector/profiler/memory-instrumentation-cached-images-expected.txt:
* inspector/profiler/memory-instrumentation-cached-images.html:
* inspector/profiler/memory-instrumentation-canvas-expected.txt:
* inspector/profiler/memory-instrumentation-canvas.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CoordinatedGraphics] Use ScrollingCoordinator to track fixed layers
caio.oliveira@openbossa.org [Thu, 7 Feb 2013 14:47:50 +0000 (14:47 +0000)]
[CoordinatedGraphics] Use ScrollingCoordinator to track fixed layers
https://bugs.webkit.org/show_bug.cgi?id=108990

.:

Reviewed by Noam Rosenthal.

Add a new test that allow us to remove the fixed positioning of a layer but still keeping
it compositing. Coordinated Graphics had a bug where the CoordinatedSceneGraph would still
count this layer as fixed position.

* ManualTests/remove-fixed-position-but-keep-compositing.html: Added.

Source/WebCore:

Reviewed by Noam Rosenthal.

WebCore keeps ScrollingCoordinator up-to-date about whether layers are fixed or not, so we
don't need to traverse the tree every frame to get this information.

The function ScrollingCoordinator::setLayerIsFixedToContainerLayer() is called when
RenderLayerBacking is updating its graphics layers.

The new code also works in new situations where the previous was broken: if a layer changed
from being fixed to not fixed (but still kept as a layer for other reasons), the layer will
be correctly updated. Previous implementation only had logic to mark layers as fixed, but
not the other way round. A manual test was added to illustrate the solved problem.

Testing was done with the existing manual tests that make use of "position:fixed". Automatic
tests are mostly not affected by this because usage of this information affects only the
UseFixedLayout mode, not used by default in WebKitTestRunner. Work to improve this situation
will be tracked in bug https://bugs.webkit.org/show_bug.cgi?id=109175.

* CMakeLists.txt:
* Target.pri:
* WebCore.pri:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create): create specific version of ScrollingCoordinator.
* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: Added.
(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::setLayerIsFixedToContainerLayer):
update layer information using existing hook in ScrollingCoordinator.
* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h: Added.
(WebCore):
(ScrollingCoordinatorCoordinatedGraphics):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setFixedToViewport): now that setting viewport is not
embedded in the synchronization work, we need to mark the layer so it is updated in the
next frame.
(WebCore):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState): remove call to syncFixedLayers().
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient): remove now unused syncFixedLayers() from client.
(CoordinatedGraphicsLayer):

Source/WebKit2:

Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Simon Fraser.

WebCore keeps ScrollingCoordinator up-to-date about whether layers are fixed or not, so we
don't need to traverse the tree every frame to get this information.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp: remove
syncFixedLayers() and its helper functions. Those were used to identify the fixed layers
and are not needed anymore.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl): enable the scrolling coordinator usage for
Coordinated Graphics.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: REGRESSION (r140778): Calendar Picker doesn't open when the element...
keishi@webkit.org [Thu, 7 Feb 2013 14:42:20 +0000 (14:42 +0000)]
Source/WebCore: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=109136

Reviewed by Kent Tamura.

Calendar picker was using the "Clear" button to calculate the window width.
Since it doesn't exist when the input element has a required attribute,
it was throwing an error. This patch fixes the width calculating logic.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html
       platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html

* Resources/pagepopups/calendarPicker.css:
(.today-clear-area):
* Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
the width. We don't want to use clear button because it doesn't exist
when a value is required.

LayoutTests: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=108055

Reviewed by Kent Tamura.

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Skip failing test.
kadam@inf.u-szeged.hu [Thu, 7 Feb 2013 14:32:30 +0000 (14:32 +0000)]
[Qt] Unreviewed gardening. Skip failing test.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r142090.
gavinp@chromium.org [Thu, 7 Feb 2013 14:20:04 +0000 (14:20 +0000)]
Unreviewed, rolling out r142090.
http://trac.webkit.org/changeset/142090
https://bugs.webkit.org/show_bug.cgi?id=108466

lots of selection expectations failures

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
* DumpRenderTree/chromium/TestRunner/public/WebTask.h:
(WebTaskList):
* DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestInterfaces):
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
* DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
* DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
* DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
* DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
* DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
* DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(MockGrammarCheck::checkGrammarOfString):
* DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(MockGrammarCheck):
* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(append):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):
* DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
* DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
* DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
* DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
* DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
* DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
* DumpRenderTree/chromium/TestRunner/src/config.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix. libWebCore.la needs to be relinked when
kov@webkit.org [Thu, 7 Feb 2013 14:14:29 +0000 (14:14 +0000)]
Unreviewed build fix. libWebCore.la needs to be relinked when
symbols.filter changes.

* GNUmakefile.am: add symbols.filter as a dependency for the
libWebCore.la library.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Closure compilation fixes
vsevik@chromium.org [Thu, 7 Feb 2013 13:56:05 +0000 (13:56 +0000)]
Web Inspector: Closure compilation fixes
https://bugs.webkit.org/show_bug.cgi?id=109131

Reviewed by Yury Semikhatsky.

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
* inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMappingImpl.prototype.uriPrefixForPathPrefix):
* inspector/front-end/IsolatedFileSystemModel.js:
(WebInspector.IsolatedFileSystemModel.prototype._fileSystemRemoved):
* inspector/front-end/SidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviwed gardening. Rebaselining and skipping new failures.
kadam@inf.u-szeged.hu [Thu, 7 Feb 2013 13:51:17 +0000 (13:51 +0000)]
[Qt] Unreviwed gardening. Rebaselining and skipping new failures.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-07

* platform/qt/TestExpectations:
* platform/qt/fast/dynamic/002-expected.txt:
* platform/qt/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Added.
* platform/qt/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix after r141196 for 32 bits autotools.
kov@webkit.org [Thu, 7 Feb 2013 13:48:46 +0000 (13:48 +0000)]
Unreviewed build fix after r141196 for 32 bits autotools.

* Source/autotools/symbols.filter: restore 32 bits version of the
WebCore::TextIterator::getLocationAndLengthFromRange(WebCore::Node*,
WebCore::Range const*, unsigned int&, unsigned int&) symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WebGL Conformance Tests state, renderbuffers, and reading folders.
gman@chromium.org [Thu, 7 Feb 2013 13:47:21 +0000 (13:47 +0000)]
Add WebGL Conformance Tests state, renderbuffers, and reading folders.
https://bugs.webkit.org/show_bug.cgi?id=109121

Reviewed by Kenneth Russell.

* webgl/conformance/reading/read-pixels-pack-alignment-expected.txt: Added.
* webgl/conformance/reading/read-pixels-pack-alignment.html: Added.
* webgl/conformance/renderbuffers/framebuffer-state-restoration-expected.txt: Added.
* webgl/conformance/renderbuffers/framebuffer-state-restoration.html: Added.
* webgl/conformance/renderbuffers/framebuffer-test-expected.txt: Added.
* webgl/conformance/renderbuffers/framebuffer-test.html: Added.
* webgl/conformance/renderbuffers/renderbuffer-initialization-expected.txt: Added.
* webgl/conformance/renderbuffers/renderbuffer-initialization.html: Added.
* webgl/conformance/state/gl-enable-enum-test-expected.txt: Added.
* webgl/conformance/state/gl-enable-enum-test.html: Added.
* webgl/conformance/state/gl-enum-tests-expected.txt: Added.
* webgl/conformance/state/gl-enum-tests.html: Added.
* webgl/conformance/state/gl-get-calls-expected.txt: Added.
* webgl/conformance/state/gl-get-calls.html: Added.
* webgl/conformance/state/gl-geterror-expected.txt: Added.
* webgl/conformance/state/gl-geterror.html: Added.
* webgl/conformance/state/gl-getstring-expected.txt: Added.
* webgl/conformance/state/gl-getstring.html: Added.
* webgl/resources/webgl_test_files/conformance/reading/00_test_list.txt: Added.
* webgl/resources/webgl_test_files/conformance/reading/read-pixels-pack-alignment.html: Added.
* webgl/resources/webgl_test_files/conformance/renderbuffers/00_test_list.txt: Added.
* webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-state-restoration.html: Added.
* webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-test.html: Added.
* webgl/resources/webgl_test_files/conformance/renderbuffers/renderbuffer-initialization.html: Added.
* webgl/resources/webgl_test_files/conformance/state/00_test_list.txt: Added.
* webgl/resources/webgl_test_files/conformance/state/gl-enable-enum-test.html: Added.
* webgl/resources/webgl_test_files/conformance/state/gl-enum-tests.html: Added.
* webgl/resources/webgl_test_files/conformance/state/gl-get-calls.html: Added.
* webgl/resources/webgl_test_files/conformance/state/gl-geterror.html: Added.
* webgl/resources/webgl_test_files/conformance/state/gl-getstring.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r142077.
haraken@chromium.org [Thu, 7 Feb 2013 13:37:24 +0000 (13:37 +0000)]
Unreviewed, rolling out r142077.
http://trac.webkit.org/changeset/142077
https://bugs.webkit.org/show_bug.cgi?id=108579

fast/filesystem/workers/file-writer-empty-blob.html is broken

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
* bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):
* bindings/v8/V8Binding.h:
(WebCore):
(WebCore::worldForEnteredContextIfIsolated):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
* bindings/v8/V8GCController.cpp:
(WebCore::WrapperVisitor::WrapperVisitor):
(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
* bindings/v8/V8GCController.h:
(V8GCController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WebGL Conformance Tests rendering folder.
gman@chromium.org [Thu, 7 Feb 2013 13:36:25 +0000 (13:36 +0000)]
Add WebGL Conformance Tests rendering folder.
https://bugs.webkit.org/show_bug.cgi?id=109122

Reviewed by Kenneth Russell.

* webgl/conformance/rendering/culling-expected.txt: Added.
* webgl/conformance/rendering/culling.html: Added.
* webgl/conformance/rendering/draw-arrays-out-of-bounds-expected.txt: Added.
* webgl/conformance/rendering/draw-arrays-out-of-bounds.html: Added.
* webgl/conformance/rendering/draw-elements-out-of-bounds-expected.txt: Added.
* webgl/conformance/rendering/draw-elements-out-of-bounds.html: Added.
* webgl/conformance/rendering/gl-clear-expected.txt: Added.
* webgl/conformance/rendering/gl-clear.html: Added.
* webgl/conformance/rendering/gl-drawelements-expected.txt: Added.
* webgl/conformance/rendering/gl-drawelements.html: Added.
* webgl/conformance/rendering/gl-scissor-fbo-test-expected.txt: Added.
* webgl/conformance/rendering/gl-scissor-fbo-test.html: Added.
* webgl/conformance/rendering/line-loop-tri-fan-expected.txt: Added.
* webgl/conformance/rendering/line-loop-tri-fan.html: Added.
* webgl/conformance/rendering/simple-expected.txt: Added.
* webgl/conformance/rendering/simple.html: Added.
* webgl/conformance/rendering/triangle-expected.txt: Added.
* webgl/conformance/rendering/triangle.html: Added.
* webgl/resources/webgl_test_files/conformance/rendering/00_test_list.txt: Added.
* webgl/resources/webgl_test_files/conformance/rendering/culling.html: Added.
* webgl/resources/webgl_test_files/conformance/rendering/draw-arrays-out-of-bounds.html: Added.
* webgl/resources/webgl_test_files/conformance/rendering/draw-elements-out-of-bounds.html: Added.
* webgl/resources/webgl_test_files/conformance/rendering/gl-clear.html: Added.
* webgl/resources/webgl_test_files/conformance/rendering/gl-drawelements.html: Added.
* webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-fbo-test.html: Added.
* webgl/resources/webgl_test_files/conformance/rendering/line-loop-tri-fan.html: Added.
* webgl/resources/webgl_test_files/conformance/rendering/simple.html: Added.
* webgl/resources/webgl_test_files/conformance/rendering/triangle.html: Added.
* webgl/resources/webgl_test_files/conformance/rendering/vertex-texture-fetch.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
senorblanco@chromium.org [Thu, 7 Feb 2013 13:20:27 +0000 (13:20 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142101 268f45cc-cd09-0410-ab3c-d52691b4dbfc