WebKit-https.git
13 years ago2009-11-09 Yaar Schnitman <yaar@chromium.src>
eric@webkit.org [Tue, 10 Nov 2009 07:46:39 +0000 (07:46 +0000)]
2009-11-09  Yaar Schnitman  <yaar@chromium.src>

        Reviewed by Dimitri Glazkov.

        Up-streaming Chromium API src files: WebData...WebElement

        https://bugs.webkit.org/show_bug.cgi?id=31276

        * src/WebData.cpp: Added.
        (WebKit::WebData::reset):
        (WebKit::WebData::assign):
        (WebKit::WebData::size):
        (WebKit::WebData::data):
        (WebKit::WebData::WebData):
        (WebKit::WebData::operator=):
        (WebKit::WebData::operator PassRefPtr<SharedBuffer>):
        * src/WebDataSourceImpl.cpp: Added.
        (WebKit::WebDataSourceImpl::create):
        (WebKit::WebDataSourceImpl::originalRequest):
        (WebKit::WebDataSourceImpl::request):
        (WebKit::WebDataSourceImpl::response):
        (WebKit::WebDataSourceImpl::hasUnreachableURL):
        (WebKit::WebDataSourceImpl::unreachableURL):
        (WebKit::WebDataSourceImpl::redirectChain):
        (WebKit::WebDataSourceImpl::pageTitle):
        (WebKit::WebDataSourceImpl::navigationType):
        (WebKit::WebDataSourceImpl::triggeringEventTime):
        (WebKit::WebDataSourceImpl::extraData):
        (WebKit::WebDataSourceImpl::setExtraData):
        (WebKit::WebDataSourceImpl::toWebNavigationType):
        (WebKit::WebDataSourceImpl::endOfRedirectChain):
        (WebKit::WebDataSourceImpl::clearRedirectChain):
        (WebKit::WebDataSourceImpl::appendRedirect):
        (WebKit::WebDataSourceImpl::setNextPluginLoadObserver):
        (WebKit::WebDataSourceImpl::WebDataSourceImpl):
        (WebKit::WebDataSourceImpl::~WebDataSourceImpl):
        * src/WebDataSourceImpl.h: Added.
        (WebKit::WebDataSourceImpl::fromDocumentLoader):
        (WebKit::WebDataSourceImpl::hasRedirectChain):
        (WebKit::WebDataSourceImpl::releasePluginLoadObserver):
        * src/WebDatabase.cpp: Added.
        (WebKit::WebDatabase::reset):
        (WebKit::WebDatabase::assign):
        (WebKit::WebDatabase::name):
        (WebKit::WebDatabase::displayName):
        (WebKit::WebDatabase::estimatedSize):
        (WebKit::WebDatabase::securityOrigin):
        (WebKit::WebDatabase::setObserver):
        (WebKit::WebDatabase::observer):
        (WebKit::WebDatabase::updateDatabaseSize):
        (WebKit::WebDatabase::WebDatabase):
        (WebKit::WebDatabase::operator=):
        (WebKit::WebDatabase::operator WTF::PassRefPtr<Database>):
        * src/WebDevToolsAgentPrivate.h: Added.
        * src/WebDragData.cpp: Added.
        (WebKit::WebDragData::initialize):
        (WebKit::WebDragData::reset):
        (WebKit::WebDragData::assign):
        (WebKit::WebDragData::url):
        (WebKit::WebDragData::setURL):
        (WebKit::WebDragData::urlTitle):
        (WebKit::WebDragData::setURLTitle):
        (WebKit::WebDragData::fileExtension):
        (WebKit::WebDragData::setFileExtension):
        (WebKit::WebDragData::hasFileNames):
        (WebKit::WebDragData::fileNames):
        (WebKit::WebDragData::setFileNames):
        (WebKit::WebDragData::appendToFileNames):
        (WebKit::WebDragData::plainText):
        (WebKit::WebDragData::setPlainText):
        (WebKit::WebDragData::htmlText):
        (WebKit::WebDragData::setHTMLText):
        (WebKit::WebDragData::htmlBaseURL):
        (WebKit::WebDragData::setHTMLBaseURL):
        (WebKit::WebDragData::fileContentFileName):
        (WebKit::WebDragData::setFileContentFileName):
        (WebKit::WebDragData::fileContent):
        (WebKit::WebDragData::setFileContent):
        (WebKit::WebDragData::WebDragData):
        (WebKit::WebDragData::operator=):
        (WebKit::WebDragData::operator WTF::PassRefPtr<WebCore::ChromiumDataObject>):
        (WebKit::WebDragData::ensureMutable):
        * src/WebElement.cpp: Added.
        (WebKit::WebElement::WebElement):
        (WebKit::WebElement::operator=):
        (WebKit::WebElement::operator WTF::PassRefPtr<Element>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 10 Nov 2009 07:23:39 +0000 (07:23 +0000)]
2009-11-09  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        SVG feDisplacementMap is not implemented
        [https://bugs.webkit.org/show_bug.cgi?id=31255]

        This is the implementation of the SVG filter effect
        feDisplacementMap.

        Test: svg/filters/feDisplacementMap.svg

        * svg/graphics/filters/SVGFEDisplacementMap.cpp:
        (WebCore::FEDisplacementMap::apply):

        Test for SVG filter effect feDisplacementMap.

        * platform/mac/svg/filters/feDisplacementMap-expected.checksum: Added.
        * platform/mac/svg/filters/feDisplacementMap-expected.png: Added.
        * platform/mac/svg/filters/feDisplacementMap-expected.txt: Added.
        * svg/filters/feDisplacementMap.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
eric@webkit.org [Tue, 10 Nov 2009 05:05:57 +0000 (05:05 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        WebPo*.h and WebRunetimeFeatures.h Chromium API headers.

        https://bugs.webkit.org/show_bug.cgi?id=28394

        * public/WebPoint.h: Added.
        (WebKit::WebPoint::WebPoint):
        (WebKit::WebPoint::operator=):
        (WebKit::WebPoint::operator WebCore::IntPoint):
        (WebKit::WebPoint::operator gfx::Point):
        (WebKit::operator==):
        (WebKit::operator!=):
        * public/WebPopupMenu.h: Added.
        * public/WebPopupMenuInfo.h: Added.
        (WebKit::WebPopupMenuInfo::Item::):
        * public/WebRuntimeFeatures.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
eric@webkit.org [Tue, 10 Nov 2009 04:58:26 +0000 (04:58 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        WebPa*.h and WebPl*.h Chromium API headers.

        https://bugs.webkit.org/show_bug.cgi?id=28394

        * public/WebPasswordAutocompleteListener.h: Added.
        (WebKit::WebPasswordAutocompleteListener::~WebPasswordAutocompleteListener):
        * public/WebPasswordFormData.h: Added.
        (WebKit::WebPasswordFormData::isValid):
        * public/WebPlugin.h: Added.
        (WebKit::WebPlugin::~WebPlugin):
        * public/WebPluginContainer.h: Added.
        (WebKit::WebPluginContainer::~WebPluginContainer):
        * public/WebPluginListBuilder.h: Added.
        * public/WebPluginParams.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Tue, 10 Nov 2009 04:50:39 +0000 (04:50 +0000)]
2009-11-09  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Up-streaming Chromium API src files: WebBindging ... WebCursorInfo

        https://bugs.webkit.org/show_bug.cgi?id=31276

        * src/WebBindings.cpp: Added.
        (WebKit::WebBindings::construct):
        (WebKit::WebBindings::createObject):
        (WebKit::WebBindings::enumerate):
        (WebKit::WebBindings::evaluate):
        (WebKit::WebBindings::evaluateHelper):
        (WebKit::WebBindings::getIntIdentifier):
        (WebKit::WebBindings::getProperty):
        (WebKit::WebBindings::getStringIdentifier):
        (WebKit::WebBindings::getStringIdentifiers):
        (WebKit::WebBindings::hasMethod):
        (WebKit::WebBindings::hasProperty):
        (WebKit::WebBindings::identifierIsString):
        (WebKit::WebBindings::intFromIdentifier):
        (WebKit::WebBindings::initializeVariantWithStringCopy):
        (WebKit::WebBindings::invoke):
        (WebKit::WebBindings::invokeDefault):
        (WebKit::WebBindings::releaseObject):
        (WebKit::WebBindings::releaseVariantValue):
        (WebKit::WebBindings::removeProperty):
        (WebKit::WebBindings::retainObject):
        (WebKit::WebBindings::setException):
        (WebKit::WebBindings::setProperty):
        (WebKit::WebBindings::unregisterObject):
        (WebKit::WebBindings::utf8FromIdentifier):
        (WebKit::WebBindings::extractIdentifierData):
        (WebKit::getEvent):
        (WebKit::getDragDataImpl):
        (WebKit::getRangeImpl):
        (WebKit::WebBindings::getDragData):
        (WebKit::WebBindings::isDragEvent):
        (WebKit::WebBindings::getRange):
        * src/WebCString.cpp: Added.
        (WebKit::WebCString::reset):
        (WebKit::WebCString::assign):
        (WebKit::WebCString::length):
        (WebKit::WebCString::data):
        (WebKit::WebCString::utf16):
        (WebKit::WebCString::fromUTF16):
        (WebKit::WebCString::WebCString):
        (WebKit::WebCString::operator=):
        (WebKit::WebCString::operator WebCore::CString):
        * src/WebCache.cpp: Added.
        (WebKit::ToResourceTypeStat):
        (WebKit::WebCache::setCapacities):
        (WebKit::WebCache::clear):
        (WebKit::WebCache::getUsageStats):
        (WebKit::WebCache::getResourceTypeStats):
        * src/WebColor.cpp: Added.
        (WebKit::toCSSValueKeyword):
        (WebKit::setNamedColors):
        * src/WebCrossOriginPreflightResultCache.cpp: Added.
        (WebKit::WebCrossOriginPreflightResultCache::clear):
        * src/WebCursorInfo.cpp: Added.
        (WebKit::WebCursorInfo::WebCursorInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Tue, 10 Nov 2009 04:43:08 +0000 (04:43 +0000)]
2009-11-09  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Up-streaming Chromium API src files: WebAccessibilty

        https://bugs.webkit.org/show_bug.cgi?id=31276

        * src/WebAccessibilityCache.cpp: Added.
        (WebKit::WebAccessibilityCache::enableAccessibility):
        * src/WebAccessibilityCacheImpl.cpp: Added.
        (WebKit::toAccessibilityObject):
        (WebKit::WebAccessibilityCache::create):
        (WebKit::WebAccessibilityCacheImpl::WeakHandle::create):
        (WebKit::WebAccessibilityCacheImpl::WeakHandle::WeakHandle):
        (WebKit::WebAccessibilityCacheImpl::WeakHandle::detach):
        (WebKit::WebAccessibilityCacheImpl::WebAccessibilityCacheImpl):
        (WebKit::WebAccessibilityCacheImpl::~WebAccessibilityCacheImpl):
        (WebKit::WebAccessibilityCacheImpl::initialize):
        (WebKit::WebAccessibilityCacheImpl::getObjectById):
        (WebKit::WebAccessibilityCacheImpl::isValidId):
        (WebKit::WebAccessibilityCacheImpl::remove):
        (WebKit::WebAccessibilityCacheImpl::clear):
        (WebKit::WebAccessibilityCacheImpl::addOrGetId):
        * src/WebAccessibilityCacheImpl.h: Added.
        (WebKit::WebAccessibilityCacheImpl::isInitialized):
        * src/WebAccessibilityObject.cpp: Added.
        (WebKit::WebAccessibilityObject::reset):
        (WebKit::WebAccessibilityObject::assign):
        (WebKit::WebAccessibilityObject::accessibilityDescription):
        (WebKit::WebAccessibilityObject::actionVerb):
        (WebKit::WebAccessibilityObject::canSetFocusAttribute):
        (WebKit::WebAccessibilityObject::childCount):
        (WebKit::WebAccessibilityObject::childAt):
        (WebKit::WebAccessibilityObject::firstChild):
        (WebKit::WebAccessibilityObject::focusedChild):
        (WebKit::WebAccessibilityObject::lastChild):
        (WebKit::WebAccessibilityObject::nextSibling):
        (WebKit::WebAccessibilityObject::parentObject):
        (WebKit::WebAccessibilityObject::previousSibling):
        (WebKit::WebAccessibilityObject::isAnchor):
        (WebKit::WebAccessibilityObject::isChecked):
        (WebKit::WebAccessibilityObject::isFocused):
        (WebKit::WebAccessibilityObject::isEnabled):
        (WebKit::WebAccessibilityObject::isHovered):
        (WebKit::WebAccessibilityObject::isIndeterminate):
        (WebKit::WebAccessibilityObject::isMultiSelect):
        (WebKit::WebAccessibilityObject::isOffScreen):
        (WebKit::WebAccessibilityObject::isPasswordField):
        (WebKit::WebAccessibilityObject::isPressed):
        (WebKit::WebAccessibilityObject::isReadOnly):
        (WebKit::WebAccessibilityObject::isVisited):
        (WebKit::WebAccessibilityObject::boundingBoxRect):
        (WebKit::WebAccessibilityObject::helpText):
        (WebKit::WebAccessibilityObject::hitTest):
        (WebKit::WebAccessibilityObject::keyboardShortcut):
        (WebKit::WebAccessibilityObject::performDefaultAction):
        (WebKit::WebAccessibilityObject::roleValue):
        (WebKit::WebAccessibilityObject::stringValue):
        (WebKit::WebAccessibilityObject::title):
        (WebKit::WebAccessibilityObject::WebAccessibilityObject):
        (WebKit::WebAccessibilityObject::operator=):
        (WebKit::WebAccessibilityObject::operator WTF::PassRefPtr<WebCore::AccessibilityObject>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake do-webcore-rename work with git.
oliver@apple.com [Tue, 10 Nov 2009 04:25:23 +0000 (04:25 +0000)]
Make do-webcore-rename work with git.

Reviewed by Geoff Garen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Tue, 10 Nov 2009 04:25:17 +0000 (04:25 +0000)]
2009-11-09  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstreaming Chromium API: Platform specific files

        https://bugs.webkit.org/show_bug.cgi?id=28394

        * public/gtk/WebFontInfo.h: Added.
        * public/gtk/WebInputEventFactory.h: Added.
        * public/gtk/WebScreenInfoFactory.h: Added.
        * public/linux/WebFontRendering.h: Added.
        * public/linux/WebSandboxSupport.h: Added.
        * public/mac/WebInputEventFactory.h: Added.
        * public/mac/WebScreenInfoFactory.h: Added.
        * public/win/WebInputEventFactory.h: Added.
        * public/win/WebSandboxSupport.h: Added.
        * public/win/WebScreenInfoFactory.h: Added.
        * public/win/WebThemeEngine.h: Added.
        * public/x11/WebScreenInfoFactory.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoImported the v8 DST cache.
ggaren@apple.com [Tue, 10 Nov 2009 04:14:34 +0000 (04:14 +0000)]
Imported the v8 DST cache.

Reviewed by Oliver Hunt.

SunSpider says 1.5% faster.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::resetDateCache): Reset the DST cache when resetting
other date data.

* runtime/JSGlobalData.h:
(JSC::DSTOffsetCache::DSTOffsetCache):
(JSC::DSTOffsetCache::reset): Added a struct for the DST cache.

* wtf/DateMath.cpp:
(WTF::calculateDSTOffsetSimple):
(WTF::calculateDSTOffset):
(WTF::parseDateFromNullTerminatedCharacters):
(JSC::getDSTOffset):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):
* wtf/DateMath.h: The imported code for probing and updating the cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-03 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 10 Nov 2009 04:06:40 +0000 (04:06 +0000)]
2009-11-03  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        wrong expected images after Bug 8736
        https://bugs.webkit.org/show_bug.cgi?id=31094

        * platform/mac/fast/borders/border-radius-huge-assert-expected.png:
        * platform/mac/fast/box-shadow/border-radius-big-expected.checksum:
        * platform/mac/fast/box-shadow/border-radius-big-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixed an edge case that could cause the engine not to notice a timezone
ggaren@apple.com [Tue, 10 Nov 2009 03:58:29 +0000 (03:58 +0000)]
Fixed an edge case that could cause the engine not to notice a timezone
change.

Reviewed by Oliver Hunt.

No test because this case would require manual intervention to change
the timezone during the test.

SunSpider reports no change.

* runtime/DateInstanceCache.h:
(JSC::DateInstanceCache::DateInstanceCache):
(JSC::DateInstanceCache::reset): Added a helper function for resetting
this cache. Also, shrank the cache, since we'll be resetting it often.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::resetDateCache): Include resetting the DateInstanceCache
in resetting Date data. (Otherwise, a cache hit could bypass a necessary
timezone update check.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSome manual inlining and constant propogation in Date code.
ggaren@apple.com [Tue, 10 Nov 2009 03:39:19 +0000 (03:39 +0000)]
Some manual inlining and constant propogation in Date code.

Reviewed by Sam Weinig.

SunSpider reports a 0.4% speedup on date-*, no overall speedup. Shark
says some previously evident stalls are now gone.

* runtime/DateConstructor.cpp:
(JSC::callDate):
* runtime/DateConversion.cpp:
(JSC::formatTime):
(JSC::formatTimeUTC): Split formatTime into UTC and non-UTC variants.

* runtime/DateConversion.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::calculateGregorianDateTime):
(JSC::DateInstance::calculateGregorianDateTimeUTC):
* runtime/DateInstance.h:
(JSC::DateInstance::gregorianDateTime):
(JSC::DateInstance::gregorianDateTimeUTC): Split gregorianDateTime into
a UTC and non-UTC variant, and split each variant into a fast inline
case and a slow out-of-line case.

* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear): Updated for the gregorianDateTime change above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
hamaji@chromium.org [Tue, 10 Nov 2009 03:35:34 +0000 (03:35 +0000)]
    Reviewed by Oliver Hunt.

        Can cache prototype lookups on uncacheable dictionaries.
        https://bugs.webkit.org/show_bug.cgi?id=31198

        Fixed wrong expectation file committed.

        * fast/js/dictionary-prototype-caching-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix: export a new symbol.
ggaren@apple.com [Tue, 10 Nov 2009 03:31:12 +0000 (03:31 +0000)]
Build fix: export a new symbol.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdded a tiny cache for Date parsing.
ggaren@apple.com [Tue, 10 Nov 2009 03:14:26 +0000 (03:14 +0000)]
Added a tiny cache for Date parsing.

Reviewed by Sam "Home Wrecker" Weinig.

SunSpider says 1.2% faster.

* runtime/DateConversion.cpp:
(JSC::parseDate): Try to reuse the last parsed Date, if present.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::resetDateCache):
* runtime/JSGlobalData.h: Added storage for last parsed Date. Refactored
this code to make resetting the date cache easier.

* runtime/JSGlobalObject.h:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Updated for
refactoring.

* wtf/DateMath.cpp:
(JSC::parseDateFromNullTerminatedCharacters):
* wtf/DateMath.h: Changed ExecState to be first parameter, as is the JSC custom.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCan cache prototype lookups on uncacheable dictionaries.
oliver@apple.com [Tue, 10 Nov 2009 02:19:04 +0000 (02:19 +0000)]
Can cache prototype lookups on uncacheable dictionaries.
https://bugs.webkit.org/show_bug.cgi?id=31198

Reviewed by Gavin Barraclough.

Replace fromDictionaryTransition with flattenDictionaryObject and
flattenDictionaryStructure.  This change is necessary as we need to
guarantee that our attempt to convert away from a dictionary structure
will definitely succeed, and in some cases this requires mutating the
object storage itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 10 Nov 2009 01:51:48 +0000 (01:51 +0000)]
2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Not reviewed, build fix.

        Remove extra character from r50701.

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Tue, 10 Nov 2009 01:46:10 +0000 (01:46 +0000)]
2009-11-09  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Add a comment about null strings and hash functions.
        https://bugs.webkit.org/show_bug.cgi?id=29118

        * platform/text/StringHash.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 10 Nov 2009 01:39:02 +0000 (01:39 +0000)]
2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Not reviewed, build fix.

        Revert r50695 because it broke QtWebKit (clean builds).

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Tue, 10 Nov 2009 01:24:59 +0000 (01:24 +0000)]
2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Darin Adler.

        Compiler warnings in InspectorResource.h
        https://bugs.webkit.org/show_bug.cgi?id=29231

        Fix compilation warnings by removing addition operation on an enum type.

        * inspector/InspectorResource.h:
        (WebCore::InspectorResource::):
        (WebCore::InspectorResource::Changes::hasChange):
        (WebCore::InspectorResource::Changes::set):
        (WebCore::InspectorResource::Changes::setAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Priit Laes <plaes@plaes.org>
eric@webkit.org [Tue, 10 Nov 2009 01:12:00 +0000 (01:12 +0000)]
2009-11-09  Priit Laes  <plaes@plaes.org>

        Reviewed by Oliver Hunt.

        [Gtk] Build from tarball fails with --enable-introspection
        https://bugs.webkit.org/show_bug.cgi?id=31261

        We need to enable gobject-introspection during distcheck otherwise
        some of the required files are missing in tarball.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore: <rdar://problem/7328395>
andersca@apple.com [Tue, 10 Nov 2009 00:46:37 +0000 (00:46 +0000)]
WebCore: <rdar://problem/7328395>
https://bugs.webkit.org/show_bug.cgi?id=31277

Reviewed by Darin Adler and Dan Bernstein.

When an object tag's style changes (for example when child nodes are added/removed),
reuse its Frame (if it has one) instead of creating multiple Frames.

Test: fast/dom/HTMLObjectElement/children-changed.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::requestObject):

LayoutTests: <rdar://problem/7328395>
https://bugs.webkit.org/show_bug.cgi?id=31277

Reviewed by Darin Adler and Dan Bernstein.

When an object tag's style changes (for example when child nodes are added/removed),
reuse its Frame (if it has one) instead of creating multiple Frames.

* fast/dom/HTMLObjectElement/children-changed-expected.txt: Added.
* fast/dom/HTMLObjectElement/children-changed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoChange struct ResourceRequest to class ResourceRequest per
levin@chromium.org [Mon, 9 Nov 2009 23:18:58 +0000 (23:18 +0000)]
Change struct ResourceRequest to class ResourceRequest per
http://trac.webkit.org/changeset/50625.

Reviewed by Dmitry Titov.

* public/WebURLRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 9 Nov 2009 22:41:29 +0000 (22:41 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstream remaining Chromium API WebN*.h headers.

        https://bugs.webkit.org/show_bug.cgi?id=28394

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Norbert Leser <norbert.leser@nokia.com>
eric@webkit.org [Mon, 9 Nov 2009 22:34:58 +0000 (22:34 +0000)]
2009-11-09  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Prepended $$PWD to GENERATED_SOURCES_DIR to avoid potential ambiguities when included from WebCore.pro.
        Some preprocessors consider this GENERATED_SOURCES_DIR relative to current invoking dir (e.g., ./WebCore),
        and not the working dir of JavaCriptCore.pri (i.e., ../JavaScriptCore/).

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 9 Nov 2009 22:34:02 +0000 (22:34 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstream Chromium API headers WebMessage through WebNavigation.

        https://bugs.webkit.org/show_bug.cgi?id=28394

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Norbert Leser <norbert.leser@nokia.com>
eric@webkit.org [Mon, 9 Nov 2009 22:27:22 +0000 (22:27 +0000)]
2009-11-09  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Moved macro MMP_RULES (LINKEROPTION) into symbian instead of symbian-sbsv2,
        since adjustment of RW-section base address will be needed for all new symbian
        tool chains, specifically for arm and gcc compilation targets.
        Also, change target address to 0xE00000 to be sufficient for all targets.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 22:19:38 +0000 (22:19 +0000)]
2009-11-09  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstreaming the Chromium WebKit API: WebScreenInfo to WebSharedWorkerRepo.

        https://bugs.webkit.org/show_bug.cgi?id=28394

        * public/WebScreenInfo.h: Added.
        (WebKit::WebScreenInfo::WebScreenInfo):
        * public/WebScriptController.h: Added.
        * public/WebScriptSource.h: Added.
        (WebKit::WebScriptSource::WebScriptSource):
        * public/WebSearchableFormData.h: Added.
        (WebKit::WebSearchableFormData::isValid):
        (WebKit::WebSearchableFormData::url):
        (WebKit::WebSearchableFormData::encoding):
        * public/WebSecurityOrigin.h: Added.
        (WebKit::WebSecurityOrigin::~WebSecurityOrigin):
        (WebKit::WebSecurityOrigin::WebSecurityOrigin):
        (WebKit::WebSecurityOrigin::operator=):
        (WebKit::WebSecurityOrigin::isNull):
        * public/WebSecurityPolicy.h: Added.
        * public/WebSettings.h: Added.
        (WebKit::WebSettings::~WebSettings):
        * public/WebSharedWorker.h: Added.
        (WebKit::WebSharedWorker::~WebSharedWorker):
        * public/WebSharedWorkerRepository.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 22:11:49 +0000 (22:11 +0000)]
2009-11-09  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Crash when inspecting
        WebCore\manual-tests\inspector\dom-mutation.html

        https://bugs.webkit.org/show_bug.cgi?id=31259

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::handleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 9 Nov 2009 22:08:48 +0000 (22:08 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstream Chromium API headers Webkit.h thru WebMediaPlayerClient.h.

        https://bugs.webkit.org/show_bug.cgi?id=28394

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 9 Nov 2009 22:00:56 +0000 (22:00 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstream rest of WebH*.h and WebI*.h Chromium API headers.

        https://bugs.webkit.org/show_bug.cgi?id=28394

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 21:55:01 +0000 (21:55 +0000)]
2009-11-09  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Eric Seidel.

        Upstreaming the Chromium WebKit API: WebSockets and WebStorage.

        https://bugs.webkit.org/show_bug.cgi?id=28394

        * public/WebSocketStreamError.h: Added.
        * public/WebSocketStreamHandle.h: Added.
        (WebKit::WebSocketStreamHandle::~WebSocketStreamHandle):
        * public/WebSocketStreamHandleClient.h: Added.
        * public/WebStorageArea.h: Added.
        (WebKit::WebStorageArea::~WebStorageArea):
        * public/WebStorageEventDispatcher.h: Added.
        (WebKit::WebStorageEventDispatcher::~WebStorageEventDispatcher):
        * public/WebStorageNamespace.h: Added.
        (WebKit::WebStorageNamespace::~WebStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 21:47:35 +0000 (21:47 +0000)]
2009-11-09  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstreaming the Chromium WebKit API: WebString and other basic objects.

        https://bugs.webkit.org/show_bug.cgi?id=28394

        * public/WebRange.h: Added.
        (WebKit::WebRange::~WebRange):
        (WebKit::WebRange::WebRange):
        (WebKit::WebRange::operator=):
        (WebKit::WebRange::isNull):
        * public/WebRect.h: Added.
        (WebKit::WebRect::isEmpty):
        (WebKit::WebRect::WebRect):
        (WebKit::WebRect::operator=):
        (WebKit::WebRect::operator WebCore::IntRect):
        (WebKit::WebRect::operator gfx::Rect):
        (WebKit::operator==):
        (WebKit::operator!=):
        * public/WebSize.h: Added.
        (WebKit::WebSize::isEmpty):
        (WebKit::WebSize::WebSize):
        (WebKit::WebSize::operator=):
        (WebKit::WebSize::operator WebCore::IntSize):
        (WebKit::WebSize::operator gfx::Size):
        (WebKit::operator==):
        (WebKit::operator!=):
        * public/WebString.h: Added.
        (WebKit::WebString::~WebString):
        (WebKit::WebString::WebString):
        (WebKit::WebString::operator=):
        (WebKit::WebString::isEmpty):
        (WebKit::WebString::isNull):
        (WebKit::WebString::operator string16):
        (WebKit::WebString::operator NullableString16):
        (WebKit::WebString::fromUTF8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 21:40:03 +0000 (21:40 +0000)]
2009-11-09  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Eric Seidel.

        Upstreaming the Chromium WebKit API: WebText*

        https://bugs.webkit.org/show_bug.cgi?id=28394

        * public/WebTextAffinity.h: Added.
        (WebKit::):
        * public/WebTextDirection.h: Added.
        (WebKit::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 9 Nov 2009 21:28:45 +0000 (21:28 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstream remainder of WebE*.h and WebF*.h Chromium API headers.

        https://bugs.webkit.org/show_bug.cgi?id=28394

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 9 Nov 2009 21:27:04 +0000 (21:27 +0000)]
2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Few classes have virtual functions but non-virtual destructor
        https://bugs.webkit.org/show_bug.cgi?id=31269

        No new tests as there is no functional change.

        * platform/qt/QWebPageClient.h:
        (QWebPageClient::~QWebPageClient): Add virtual destructor.
2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Few classes have virtual functions but non-virtual destructor
        https://bugs.webkit.org/show_bug.cgi?id=31269

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::~QGraphicsWebViewPrivate): Add virtual
        destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 9 Nov 2009 21:19:51 +0000 (21:19 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstream WebDevTools*.h and WebDrag*.h Chromium API headers.

        https://bugs.webkit.org/show_bug.cgi?id=28394

        * public/WebDevToolsAgent.h: Added.
        (WebKit::WebDevToolsAgent::~WebDevToolsAgent):
        * public/WebDevToolsAgentClient.h: Added.
        (WebKit::WebDevToolsAgentClient::~WebDevToolsAgentClient):
        * public/WebDevToolsFrontend.h: Added.
        (WebKit::WebDevToolsFrontend::~WebDevToolsFrontend):
        * public/WebDevToolsFrontendClient.h: Added.
        (WebKit::WebDevToolsFrontendClient::WebDevToolsFrontendClient):
        (WebKit::WebDevToolsFrontendClient::~WebDevToolsFrontendClient):
        * public/WebDragData.h: Added.
        (WebKit::WebDragData::~WebDragData):
        (WebKit::WebDragData::WebDragData):
        (WebKit::WebDragData::operator=):
        (WebKit::WebDragData::isNull):
        * public/WebDragOperation.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 21:14:20 +0000 (21:14 +0000)]
2009-11-09  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstreaming the Chromium WebKit API: WebURL and friends.

        https://bugs.webkit.org/show_bug.cgi?id=28394

        * public/WebURL.h: Added.
        (WebKit::WebURL::~WebURL):
        (WebKit::WebURL::WebURL):
        (WebKit::WebURL::operator=):
        (WebKit::WebURL::assign):
        (WebKit::WebURL::spec):
        (WebKit::WebURL::parsed):
        (WebKit::WebURL::isValid):
        (WebKit::WebURL::isEmpty):
        (WebKit::WebURL::isNull):
        (WebKit::WebURL::operator GURL):
        * public/WebURLError.h: Added.
        (WebKit::WebURLError::WebURLError):
        * public/WebURLLoader.h: Added.
        (WebKit::WebURLLoader::~WebURLLoader):
        * public/WebURLLoaderClient.h: Added.
        (WebKit::WebURLLoaderClient::~WebURLLoaderClient):
        * public/WebURLRequest.h: Added.
        (WebKit::WebURLRequest::):
        (WebKit::WebURLRequest::~WebURLRequest):
        (WebKit::WebURLRequest::WebURLRequest):
        (WebKit::WebURLRequest::operator=):
        * public/WebURLResponse.h: Added.
        (WebKit::WebURLResponse::~WebURLResponse):
        (WebKit::WebURLResponse::WebURLResponse):
        (WebKit::WebURLResponse::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 21:06:44 +0000 (21:06 +0000)]
2009-11-09  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstreaming the Chromium WebKit API: WebVector to WebWorkerClient

        https://bugs.webkit.org/show_bug.cgi?id=28394

        * public/WebVector.h: Added.
        (WebKit::WebVector::~WebVector):
        (WebKit::WebVector::WebVector):
        (WebKit::WebVector::operator=):
        (WebKit::WebVector::assign):
        (WebKit::WebVector::size):
        (WebKit::WebVector::isEmpty):
        (WebKit::WebVector::operator[]):
        (WebKit::WebVector::data):
        (WebKit::WebVector::swap):
        (WebKit::WebVector::initialize):
        (WebKit::WebVector::initializeFrom):
        (WebKit::WebVector::destroy):
        * public/WebView.h: Added.
        (WebKit::WebView::~WebView):
        * public/WebViewClient.h: Added.
        (WebKit::WebViewClient::createView):
        (WebKit::WebViewClient::createPopupMenu):
        (WebKit::WebViewClient::didAddMessageToConsole):
        (WebKit::WebViewClient::printPage):
        (WebKit::WebViewClient::notificationPresenter):
        (WebKit::WebViewClient::didStartLoading):
        (WebKit::WebViewClient::didStopLoading):
        (WebKit::WebViewClient::shouldBeginEditing):
        (WebKit::WebViewClient::shouldEndEditing):
        (WebKit::WebViewClient::shouldInsertNode):
        (WebKit::WebViewClient::shouldInsertText):
        (WebKit::WebViewClient::shouldChangeSelectedRange):
        (WebKit::WebViewClient::shouldDeleteRange):
        (WebKit::WebViewClient::shouldApplyStyle):
        (WebKit::WebViewClient::isSmartInsertDeleteEnabled):
        (WebKit::WebViewClient::isSelectTrailingWhitespaceEnabled):
        (WebKit::WebViewClient::setInputMethodEnabled):
        (WebKit::WebViewClient::didBeginEditing):
        (WebKit::WebViewClient::didChangeSelection):
        (WebKit::WebViewClient::didChangeContents):
        (WebKit::WebViewClient::didExecuteCommand):
        (WebKit::WebViewClient::didEndEditing):
        (WebKit::WebViewClient::handleCurrentKeyboardEvent):
        (WebKit::WebViewClient::spellCheck):
        (WebKit::WebViewClient::autoCorrectWord):
        (WebKit::WebViewClient::showSpellingUI):
        (WebKit::WebViewClient::isShowingSpellingUI):
        (WebKit::WebViewClient::updateSpellingUIWithMisspelledWord):
        (WebKit::WebViewClient::runFileChooser):
        (WebKit::WebViewClient::runModalAlertDialog):
        (WebKit::WebViewClient::runModalConfirmDialog):
        (WebKit::WebViewClient::runModalPromptDialog):
        (WebKit::WebViewClient::runModalBeforeUnloadDialog):
        (WebKit::WebViewClient::setStatusText):
        (WebKit::WebViewClient::setMouseOverURL):
        (WebKit::WebViewClient::setKeyboardFocusURL):
        (WebKit::WebViewClient::setToolTipText):
        (WebKit::WebViewClient::showContextMenu):
        (WebKit::WebViewClient::startDragging):
        (WebKit::WebViewClient::acceptsLoadDrops):
        (WebKit::WebViewClient::focusNext):
        (WebKit::WebViewClient::focusPrevious):
        (WebKit::WebViewClient::navigateBackForwardSoon):
        (WebKit::WebViewClient::historyBackListCount):
        (WebKit::WebViewClient::historyForwardListCount):
        (WebKit::WebViewClient::didAddHistoryItem):
        (WebKit::WebViewClient::focusAccessibilityObject):
        (WebKit::WebViewClient::didUpdateInspectorSettings):
        (WebKit::WebViewClient::queryAutofillSuggestions):
        (WebKit::WebViewClient::removeAutofillSuggestions):
        (WebKit::WebViewClient::~WebViewClient):
        * public/WebWidget.h: Added.
        (WebKit::WebWidget::~WebWidget):
        * public/WebWidgetClient.h: Added.
        (WebKit::WebWidgetClient::didInvalidateRect):
        (WebKit::WebWidgetClient::didScrollRect):
        (WebKit::WebWidgetClient::didFocus):
        (WebKit::WebWidgetClient::didBlur):
        (WebKit::WebWidgetClient::didChangeCursor):
        (WebKit::WebWidgetClient::closeWidgetSoon):
        (WebKit::WebWidgetClient::show):
        (WebKit::WebWidgetClient::runModal):
        (WebKit::WebWidgetClient::windowRect):
        (WebKit::WebWidgetClient::setWindowRect):
        (WebKit::WebWidgetClient::windowResizerRect):
        (WebKit::WebWidgetClient::rootWindowRect):
        (WebKit::WebWidgetClient::screenInfo):
        (WebKit::WebWidgetClient::~WebWidgetClient):
        * public/WebWorker.h: Added.
        (WebKit::WebWorker::~WebWorker):
        * public/WebWorkerClient.h: Added.
        (WebKit::WebWorkerClient::~WebWorkerClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 9 Nov 2009 20:55:58 +0000 (20:55 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstream WebData*.h Chromium API files.

        https://bugs.webkit.org/show_bug.cgi?id=28394

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Mon, 9 Nov 2009 20:46:06 +0000 (20:46 +0000)]
2009-11-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
        https://bugs.webkit.org/show_bug.cgi?id=31140

        Test that XHR request can set http headers with no value.

        * http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value-expected.txt: Added.
        * http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html: Added.
2009-11-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
        https://bugs.webkit.org/show_bug.cgi?id=31140

        QtNetwork interprets null string as request to remove the header, not add it.
        Replace null values with empty values before passing them to QtNetwork.

        Test: http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html

        * platform/network/qt/ResourceRequestQt.cpp:
        (WebCore::ResourceRequest::toNetworkRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 9 Nov 2009 20:43:30 +0000 (20:43 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstream the last of the Chromium API WebC*.h files.

        https://bugs.webkit.org/show_bug.cgi?id=28394

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 9 Nov 2009 20:32:38 +0000 (20:32 +0000)]
Reviewed by Kevin Ollivier.

[wx] Fix handling of alpha channel when using wxWidgets 2.9: it was
simply ignored before resulting in transparent areas being black in PNG
images for example.

https://bugs.webkit.org/show_bug.cgi?id=30823

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Mon, 9 Nov 2009 20:22:23 +0000 (20:22 +0000)]
2009-11-09  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        https://bugs.webkit.org/show_bug.cgi?id=30628
        Add an API to get all the attributes from a QWebElement.

        * Api/qwebelement.cpp:
        (QWebElement::attributesName):
        * Api/qwebelement.h:
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::listAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 9 Nov 2009 20:04:49 +0000 (20:04 +0000)]
2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
        https://bugs.webkit.org/show_bug.cgi?id=31040

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
        https://bugs.webkit.org/show_bug.cgi?id=31040

        No new tests as there is no functional change.

        * dom/Document.cpp:
        (WebCore::Document::recalcStyleSelector):
        * editing/TextIterator.cpp:
        (WebCore::pushFullyClippedState):
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::appendTrailingWhitespace):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        * loader/RedirectScheduler.cpp:
        (WebCore::RedirectScheduler::mustLockBackForwardList):
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
        * platform/graphics/qt/FontCacheQt.cpp:
        (WebCore::FontPlatformDataCacheKey::computeHash):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::handleRunInChild):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcHeight):
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::diff):
        * svg/SVGAnimateElement.cpp:
        (WebCore::parseNumberValueAndUnit):
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::startedActiveInterval):
        * svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::getCTM):
2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
        https://bugs.webkit.org/show_bug.cgi?id=31040

        * Api/qwebpage.cpp:
        (QWebPagePrivate::handleScrolling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 19:50:58 +0000 (19:50 +0000)]
2009-11-09  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dimitri Glazkov.

        Win chromium is slow to draw transparent texts
        https://bugs.webkit.org/show_bug.cgi?id=31258

        Clip graphics context to reduce calculation.

        No new tests because this change only affects performance.

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
        (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Carol Szabo <carol.szabo@nokia.com>
eric@webkit.org [Mon, 9 Nov 2009 19:43:17 +0000 (19:43 +0000)]
2009-11-09  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by Darin Adler.

        showTree(CounterNode*) generates too little info and has too many spaces.
        https://bugs.webkit.org/show_bug.cgi?id=31212

        No new tests as the change has no functional effect it is just for
        improved debugging.

        * rendering/CounterNode.cpp:
        (WebCore::showTreeAndMark):
        Changed to also show addresses of parent, next and previous
        siblings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Stuart Morgan <stuartmorgan@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 19:34:59 +0000 (19:34 +0000)]
2009-11-09  Stuart Morgan  <stuartmorgan@chromium.org>

        Reviewed by Darin Adler.

        Moves Mac implementation of setUseSecureKeyboardEntry to Frame.cpp and
        enables it PLATFORM(CHROMIUM) in addition to PLATFORM(MAC).

        https://bugs.webkit.org/show_bug.cgi?id=31083

        No new tests; implementation is unchanged.

        * page/Frame.cpp:
        (WebCore::Frame::setUseSecureKeyboardEntry):
        * page/mac/FrameMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 9 Nov 2009 19:32:53 +0000 (19:32 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        More WebC*.h upstreaming.

        https://bugs.webkit.org/show_bug.cgi?id=28394

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 9 Nov 2009 19:26:20 +0000 (19:26 +0000)]
2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Jan Alonzo.

        Make XP_UNIX tests consistent
        https://bugs.webkit.org/show_bug.cgi?id=31250

        No new tests as there is no functional change.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::setFrameRect): Test if XP_UNIX is defined
        instead of the value of the macro

        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded): Test if the XP_UNIX is
        defined instead of using the PLATFORM macro to be consistent
        (WebCore::PluginView::getValue): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 19:18:42 +0000 (19:18 +0000)]
2009-11-09  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstreaming the Chromium WebKit API: WebNode.h and friends are thin wrappers around WebCore::Nodes

        https://bugs.webkit.org/show_bug.cgi?id=28394

        * public/WebElement.h: Added.
        (WebKit::WebElement::WebElement):
        (WebKit::WebElement::operator=):
        (WebKit::WebElement::assign):
        * public/WebFormElement.h: Added.
        (WebKit::WebFormElement::~WebFormElement):
        (WebKit::WebFormElement::WebFormElement):
        (WebKit::WebFormElement::operator=):
        (WebKit::WebFormElement::assign):
        * public/WebInputElement.h: Added.
        (WebKit::WebInputElement::WebInputElement):
        (WebKit::WebInputElement::operator=):
        (WebKit::WebInputElement::assign):
        * public/WebNode.h: Added.
        (WebKit::WebNode::~WebNode):
        (WebKit::WebNode::WebNode):
        (WebKit::WebNode::operator=):
        (WebKit::WebNode::isNull):
        (WebKit::WebNode::toElement):
        (WebKit::WebNode::unwrap):
        (WebKit::WebNode::constUnwrap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 9 Nov 2009 19:08:37 +0000 (19:08 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        WebKit Chromium API upstreaming, WebBindings.h through WebColor.h.

        * public/WebBindings.h: Added.
        * public/WebCache.h: Added.
        * public/WebCanvas.h: Added.
        * public/WebClipboard.h: Added.
        (WebKit::WebClipboard::):
        (WebKit::WebClipboard::~WebClipboard):
        * public/WebColor.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 9 Nov 2009 18:48:22 +0000 (18:48 +0000)]
2009-11-09  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Starting upstreaming the Chromium WebKit API.  public/ contains header files only.

        https://bugs.webkit.org/show_bug.cgi?id=28394

        * ChangeLog: First!!
        * public: Added.
        * public/WebAccessibilityCache.h: Added.
        (WebKit::WebAccessibilityCache::WebAccessibilityCache):
        (WebKit::WebAccessibilityCache::~WebAccessibilityCache):
        * public/WebAccessibilityObject.h: Added.
        (WebKit::WebAccessibilityObject::~WebAccessibilityObject):
        (WebKit::WebAccessibilityObject::WebAccessibilityObject):
        (WebKit::WebAccessibilityObject::operator=):
        (WebKit::WebAccessibilityObject::isNull):
        * public/WebAccessibilityRole.h: Added.
        (WebKit::):
        * public/WebApplicationCacheHost.h: Added.
        (WebKit::WebApplicationCacheHost::):
        (WebKit::WebApplicationCacheHost::~WebApplicationCacheHost):
        * public/WebApplicationCacheHostClient.h: Added.
        (WebKit::WebApplicationCacheHostClient::~WebApplicationCacheHostClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Kevin Watters <kevinwatters@gmail.com>
eric@webkit.org [Mon, 9 Nov 2009 18:23:17 +0000 (18:23 +0000)]
2009-11-09  Kevin Watters  <kevinwatters@gmail.com>

        Reviewed by Darin Adler.

        Thunk to the main thread from ~Database to deref Database's m_document.

        If the Database was the Document's last referrer, then ~Document occurs on the
        Database thread, and ASSERT(!m_styleRecalcTimer.isActive()) hits a main thread
        ASSERT in debug builds.

        * storage/Database.cpp:
        (WebCore::derefDocument):
        (WebCore::Database::~Database):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Mark Mentovai <mark@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 17:54:30 +0000 (17:54 +0000)]
2009-11-09  Mark Mentovai  <mark@chromium.org>

        Reviewed by Dan Bernstein.

        rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
        REGRESSION (r48064): mint.com loses scrollbars after coming out of
        edit mode.

        rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
        REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.

        * fast/overflow/scrollbar-restored-expected.txt: Added.
        * fast/overflow/scrollbar-restored.html: Added.
2009-11-09  Mark Mentovai  <mark@chromium.org>

        Reviewed by Dan Bernstein.

        Track "can have scrollbar" state within FrameView independently of the
        individual scrollbar states in ScrollView.

        rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
        REGRESSION (r48064): mint.com loses scrollbars after coming out of
        edit mode.

        rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
        REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.

        Test: fast/overflow/scrollbar-restored.html

        * WebCore.base.exp:
        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        (WebCore::FrameView::resetScrollbars):
        (WebCore::FrameView::setCanHaveScrollbars):
        (WebCore::FrameView::updateCanHaveScrollbars):
        (WebCore::FrameView::layout):
        * page/FrameView.h:
        * platform/ScrollView.h:
2009-11-09  Mark Mentovai  <mark@chromium.org>

        Reviewed by Dan Bernstein.

        Track "can have scrollbar" state within FrameView independently of the
        individual scrollbar states in ScrollView.

        rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
        REGRESSION (r48064): mint.com loses scrollbars after coming out of
        edit mode.

        rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
        REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.

        Test: fast/overflow/scrollbar-restored.html

        * WebView/WebFrameView.mm:
        (-[WebFrameView _install]):
2009-11-09  Mark Mentovai  <mark@chromium.org>

        Reviewed by Dan Bernstein.

        Track "can have scrollbar" state within FrameView independently of the
        individual scrollbar states in ScrollView.

        rdar://problem/7215132, https://bugs.webkit.org/show_bug.cgi?id=29167
        REGRESSION (r48064): mint.com loses scrollbars after coming out of
        edit mode.

        rdar://problem/7314421, https://bugs.webkit.org/show_bug.cgi?id=30517
        REGRESSION (r48064): Extra scroll bars in GarageBand Lesson Store.

        Test: fast/overflow/scrollbar-restored.html

        * Api/qwebframe.cpp:
        (QWebFrame::setScrollBarPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Keishi Hattori <casey.hattori@gmail.com>
eric@webkit.org [Mon, 9 Nov 2009 17:44:56 +0000 (17:44 +0000)]
2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
        https://bugs.webkit.org/show_bug.cgi?id=31257

        * inspector/syntax-highlight-css-expected.txt:
        * inspector/syntax-highlight-css.html:
2009-11-09  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: CSS syntax highlighter doesn't recognize negative numbers
        https://bugs.webkit.org/show_bug.cgi?id=31257

        * inspector/front-end/SourceFrame.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 17:37:19 +0000 (17:37 +0000)]
2009-11-09  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Debugger shortcuts (F8, F10, F11) have no effect if the Console view is open
        https://bugs.webkit.org/show_bug.cgi?id=31252

        Route F1-F12 keypresses in the Console view to the current panel if there is one.

        Test: manual-tests/inspector/debugger-shortcuts-with-console-opened.html

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._promptKeyDown):
        * inspector/front-end/utilities.js:
        ():
        * manual-tests/inspector/debugger-shortcuts-with-console-opened.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Yael Aharon <yael.aharon@nokia.com>
kenneth@webkit.org [Mon, 9 Nov 2009 17:26:26 +0000 (17:26 +0000)]
2009-11-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Pass credentials provided by XMLHTTPRequest to the network request.
        https://bugs.webkit.org/show_bug.cgi?id=31208

        After r42483, the credentials are no longer passed to the network request
        in the URL of the request.
        Pass the credentials from XMLHTTPRequest to the network request, the same
        way that other ports do.

        After this patch LayoutTests/http/xmlhttprequest/basic-auth.html passes.

        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Benjamin Poulain <benjamin.poulain@nokia.com>
kenneth@webkit.org [Mon, 9 Nov 2009 17:22:39 +0000 (17:22 +0000)]
2009-11-09  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        https://bugs.webkit.org/show_bug.cgi?id=30772
        Add a non-const iterator to QWebElementCollection.
        Move the two attributes of the iterator to private.

        * Api/qwebelement.h:
        (const_iterator::begin):
        (const_iterator::end):
        (const_iterator::constBegin):
        (const_iterator::constEnd):
        (const_iterator::iterator::iterator):
        (const_iterator::iterator::operator*):
        (const_iterator::iterator::operator==):
        (const_iterator::iterator::operator!=):
        (const_iterator::iterator::operator<):
        (const_iterator::iterator::operator<=):
        (const_iterator::iterator::operator>):
        (const_iterator::iterator::operator>=):
        (const_iterator::iterator::operator++):
        (const_iterator::iterator::operator--):
        (const_iterator::iterator::operator+=):
        (const_iterator::iterator::operator-=):
        (const_iterator::iterator::operator+):
        (const_iterator::iterator::operator-):
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::nonConstIterator):
        (tst_QWebElement::constIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdding Kenneth to the reviewers list.
hausmann@webkit.org [Mon, 9 Nov 2009 16:12:43 +0000 (16:12 +0000)]
Adding Kenneth to the reviewers list.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Mon, 9 Nov 2009 15:38:30 +0000 (15:38 +0000)]
2009-11-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Christiansen.

        [Qt] Remove the sessionStorage setting (per Page)
        https://bugs.webkit.org/show_bug.cgi?id=31249

        This setting allows to run sessionStorage on/off on a per page
        basis. Remove this prematurely exposed API.

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
        (QWebSettings::QWebSettings):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::database):
        (tst_QWebPage::testOptionalJSObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed.
zoltan@webkit.org [Mon, 9 Nov 2009 15:34:23 +0000 (15:34 +0000)]
Unreviewed.

https://bugs.webkit.org/show_bug.cgi?id=31161

Roll back r50657 because it breaks the MAC builds.

* loader/ImageLoader.cpp:
* loader/ProgressTracker.cpp:
* loader/RedirectScheduler.cpp:
* loader/Request.h:
* loader/ThreadableLoaderClient.h:
* loader/WorkerThreadableLoader.h:
* loader/appcache/ApplicationCacheHost.h:
* loader/appcache/ApplicationCacheStorage.h:
* loader/icon/IconDatabaseClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAllow custom memory allocation control for the part of loader directory in WebCore
zoltan@webkit.org [Mon, 9 Nov 2009 15:22:01 +0000 (15:22 +0000)]
Allow custom memory allocation control for the part of loader directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31161

Reviewed by Darin Adler.

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and these are no need to be copyable:

class Request - WebCore/loader/loader.cpp:100
struct ScheduledRedirection - WebCore/loader/RedirectScheduler.cpp:164
class IconDatabaseClient - WebCore/loader/icon/IconDatabase.cpp:89
class ApplicationCacheStorage - WebCore/loader/appcache/ApplicationCacheStorage.cpp:1121
class ApplicationCacheHost -  WebCore/loader/DocumentLoader.cpp:151
class ImageEventSender - WebCore/loader/ImageLoader.cpp:54
struct ProgressItem - WebCore/loader/ProgressTracker.cpp:169

Inherits ThreadableLoaderClient class from Noncopyable because (its child class)
MainThreadBridge is instantiated by 'new' in
WebCore/loader/WorkerThreadableLoader.cpp:59 it is no need to be copyable.

ThreadableLoaderClient's inheriting has been changed to public.

* loader/ImageLoader.cpp:
* loader/ProgressTracker.cpp:
* loader/RedirectScheduler.cpp:
* loader/Request.h:
* loader/ThreadableLoaderClient.h:
* loader/WorkerThreadableLoader.h:
* loader/appcache/ApplicationCacheHost.h:
* loader/appcache/ApplicationCacheStorage.h:
* loader/icon/IconDatabaseClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] Remove the QWebPage:webInspectorTriggered signal.
hausmann@webkit.org [Mon, 9 Nov 2009 14:59:03 +0000 (14:59 +0000)]
[Qt] Remove the QWebPage:webInspectorTriggered signal.
User customization of the communication between QWebPage
and QWebInspector will be properly designed in the next version.
https://bugs.webkit.org/show_bug.cgi?id=30773

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-11-09
Reviewed by Simon Hausmann.

* Api/qwebinspector.cpp:
* Api/qwebpage.cpp:
(QWebPagePrivate::getOrCreateInspector):
(QWebPage::triggerAction):
* Api/qwebpage.h:
* QtLauncher/main.cpp:
(MainWindow::MainWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAllow custom memory allocation control for WebCore's DocLoader
zoltan@webkit.org [Mon, 9 Nov 2009 14:27:00 +0000 (14:27 +0000)]
Allow custom memory allocation control for WebCore's DocLoader
https://bugs.webkit.org/show_bug.cgi?id=31163

Reviewed by Darin Adler.

Inherits DocLoader class from Noncopyable because it is
instantiated by 'new' in WebCore/dom/Document.cpp:370 and
it is no need to be copyable.

* loader/DocLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAllow custom memory allocation control for WebCore's Tokenizer
zoltan@webkit.org [Mon, 9 Nov 2009 14:22:01 +0000 (14:22 +0000)]
Allow custom memory allocation control for WebCore's Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=31162

Reviewed by Darin Adler.

Inherits Tokenizer class from Noncopyable because (its child class)
ImageTokenizer instantiated by 'new' in WebCore/loader/ImageDocument.cpp:178
and it is no need to be copyable.

* dom/Tokenizer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAllow custom memory allocation control for WebCore's DeleteButtonController
zoltan@webkit.org [Mon, 9 Nov 2009 14:14:00 +0000 (14:14 +0000)]
Allow custom memory allocation control for WebCore's DeleteButtonController
https://bugs.webkit.org/show_bug.cgi?id=31105

Reviewed by Darin Adler.

Inherits DeleteButtonController class from Noncopyable because it is
instantiated by 'new' in WebCore/editing/Editor.cpp:919 and
it is no need to be copyable.

* editing/DeleteButtonController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdded a missing re-implementation of QGraphicsItem::inputMethodQuery().
vestbo@webkit.org [Mon, 9 Nov 2009 13:10:37 +0000 (13:10 +0000)]
Added a missing re-implementation of QGraphicsItem::inputMethodQuery().

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-05
Reviewed by Tor Arne Vestbø.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::inputMethodQuery):
* Api/qgraphicswebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoProvide a dummy re-implementation of QGraphicsLayoutItem::sizeHint(),
vestbo@webkit.org [Mon, 9 Nov 2009 13:09:39 +0000 (13:09 +0000)]
Provide a dummy re-implementation of QGraphicsLayoutItem::sizeHint(),
similar to QWebView.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::sizeHint):
* Api/qgraphicswebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemoved zoomFactoryChanged() signal and added
vestbo@webkit.org [Mon, 9 Nov 2009 13:08:31 +0000 (13:08 +0000)]
Removed zoomFactoryChanged() signal and added
linkClicked() to QGraphicsWebView, for consistency with
QWebView.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::setPage):
(QGraphicsWebView::setZoomFactor):
* Api/qgraphicswebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdded QGraphicsWebView::findText() for convenience and consistency
vestbo@webkit.org [Mon, 9 Nov 2009 13:07:46 +0000 (13:07 +0000)]
Added QGraphicsWebView::findText() for convenience and consistency
with QWebView.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::findText):
* Api/qgraphicswebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdded QGraphicsWebView::pageAction() and triggerPageAction(), for
vestbo@webkit.org [Mon, 9 Nov 2009 13:06:42 +0000 (13:06 +0000)]
Added QGraphicsWebView::pageAction() and triggerPageAction(), for
consistency with QWebView.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::pageAction):
(QGraphicsWebView::triggerPageAction):
* Api/qgraphicswebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemoved QGraphicsWebView::toHtml() after API review.
vestbo@webkit.org [Mon, 9 Nov 2009 12:35:40 +0000 (12:35 +0000)]
Removed QGraphicsWebView::toHtml() after API review.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

That's consistent with QWebView and also based on the assumption that
toHtml() is called less frequently than setHtml().

* Api/qgraphicswebview.cpp:
* Api/qgraphicswebview.h:
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::qgraphicswebview):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemoved the interactive property of QGraphicsWebView.
vestbo@webkit.org [Mon, 9 Nov 2009 12:31:27 +0000 (12:31 +0000)]
Removed the interactive property of QGraphicsWebView.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

There are clearly use-cases for this feature, but it will require
more work to make this fully work with an enum to have fine-grained
control over the interactivity levels. For now it is easy to achieve
in user-code what the boolean property did.

* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
(QGraphicsWebView::hoverMoveEvent):
(QGraphicsWebView::mouseMoveEvent):
(QGraphicsWebView::mousePressEvent):
(QGraphicsWebView::mouseReleaseEvent):
(QGraphicsWebView::mouseDoubleClickEvent):
(QGraphicsWebView::keyPressEvent):
(QGraphicsWebView::keyReleaseEvent):
(QGraphicsWebView::dragLeaveEvent):
(QGraphicsWebView::dragMoveEvent):
(QGraphicsWebView::dropEvent):
(QGraphicsWebView::wheelEvent):
(QGraphicsWebView::inputMethodEvent):
* Api/qgraphicswebview.h:
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::qgraphicswebview):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake the QGraphicsWebView constructor explicit.
vestbo@webkit.org [Mon, 9 Nov 2009 12:29:24 +0000 (12:29 +0000)]
Make the QGraphicsWebView constructor explicit.

Patch by Simon Hausmann <hausmann@webkit.org> on 2009-11-04
Reviewed by Tor Arne Vestbø.

* Api/qgraphicswebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRubber-stamped by Holger Hans Peter Freyther.
ossy@webkit.org [Mon, 9 Nov 2009 11:08:58 +0000 (11:08 +0000)]
Rubber-stamped by Holger Hans Peter Freyther.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-11-09
[Qt] Skip new japanese ruby annotation tests because of missing japanese font support.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed trivial fix.
ossy@webkit.org [Mon, 9 Nov 2009 10:12:01 +0000 (10:12 +0000)]
Unreviewed trivial fix.

Removed previously (r50589) deleted test case from skiplists.

* platform/gtk/Skipped: fast/events/drag-and-drop-none.html removed.
* platform/qt/Skipped: fast/events/drag-and-drop-none.html removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Mon, 9 Nov 2009 09:16:35 +0000 (09:16 +0000)]
2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Jan Alonzo.

        [GTK] Expose Page::tabKeyCyclesThroughElements in the API
        https://bugs.webkit.org/show_bug.cgi?id=30482

        Unskip fast/events/keypress-insert-tab.html as it now passes.

        * platform/gtk/Skipped:
2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Jan Alonzo.

        [GTK] Expose Page::tabKeyCyclesThroughElements in the API
        https://bugs.webkit.org/show_bug.cgi?id=30482

        Expose Page::tabKeyCyclesThroughElements as a property of
        WebKitWebView.

        No new tests; fast/events/keypress-insert-tab.html is no longer skipped.

        * platform/gtk/KeyEventGtk.cpp: Correct m_text for tab key presses.
        (WebCore::singleCharacterString):
2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Jan Alonzo.

        [GTK] Expose Page::tabKeyCyclesThroughElements in the API
        https://bugs.webkit.org/show_bug.cgi?id=30482

        Expose Page::tabKeyCyclesThroughElements as a property of
        WebKitWebSettings.

        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):
        (webkit_web_view_settings_notify):
2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Jan Alonzo.

        [GTK] Expose Page::tabKeyCyclesThroughElements in the API
        https://bugs.webkit.org/show_bug.cgi?id=30482

        LayoutTestControllerGtk now uses the exposed
        Page::tabKeyCyclesThroughElements API

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setTabKeyCyclesThroughElements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-09 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Mon, 9 Nov 2009 08:18:03 +0000 (08:18 +0000)]
2009-11-09  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25415
        [GTK][ATK] Please implement support for get_text_at_offset

        Fix a crasher that occurred with text which included newline
        chars in the markup.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (convertUniCharToUTF8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoThe XML tokenizer reports a parse error twice if it occurs before the document elemen...
zecke@webkit.org [Mon, 9 Nov 2009 07:34:17 +0000 (07:34 +0000)]
The XML tokenizer reports a parse error twice if it occurs before the document element is found.

https://bugs.webkit.org/show_bug.cgi?id=31144

XMLTokenizer::doEnd() uses an additional logic to report a parse failure in
documents that end prematurely but are not considered invalid by QXmlStream.
This is to stay compatible with the libxml2 implementation.
However, that code path would be also hit in situations when it should not,
i.e. the error would have already been caught and handled. As a result, the
same error would be reported twice.

No new tests, because the problem is already covered by
fast/parser/xml-declaration-missing-ending-mark.html.

Add the Qt-specific result for that test and unskip it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-08 Keishi Hattori <casey.hattori@gmail.com>
eric@webkit.org [Mon, 9 Nov 2009 06:39:32 +0000 (06:39 +0000)]
2009-11-08  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector should support copy() in the command line
        https://bugs.webkit.org/show_bug.cgi?id=31238

        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::copyText): Added.
        * inspector/InspectorBackend.h: Added copyText
        * inspector/InspectorBackend.idl: Added copyText
        * inspector/front-end/InjectedScript.js:
        (InjectedScript._copy): Added.
        (InjectedScript._ensureCommandLineAPIInstalled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-08 Drew Wilson <atwilson@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 06:00:02 +0000 (06:00 +0000)]
2009-11-08  Drew Wilson  <atwilson@chromium.org>

        Reviewed by Dimitri Glazkov.

        V8 WorkerContextExecutionProxy does not handle SharedWorkers
        https://bugs.webkit.org/show_bug.cgi?id=31226

        Now checks to see what type of context is active and creates the
        appropriate wrapper (DEDICATEDWORKERCONTEXT vs SHAREDWORKERCONTEXT).

        Added support for converting to SharedWorkers and SharedWorkerContexts.

        Test: Existing layout tests cover this case (start passing in Chrome).

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
        Now generates the right type of DOMWrapper for SharedWorkerContexts.
        (WebCore::WorkerContextExecutionProxy::convertToV8Object):
        Added support for SHAREDWORKERCONTEXT.
        (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
        Added support for SharedWorker and SharedWorkerContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-08 Johnny Ding <johnnyding.webkit@gmail.com>
eric@webkit.org [Mon, 9 Nov 2009 05:52:39 +0000 (05:52 +0000)]
2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=31224
        [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.

        * fast/dom/StyleSheet/get-stylesheet-byname-expected.txt: Added.
        * fast/dom/StyleSheet/get-stylesheet-byname.html: Added.
        * fast/dom/StyleSheet/script-tests: Added.
        * fast/dom/StyleSheet/script-tests/get-stylesheet-byname.js: Added.
2009-11-08  Johnny Ding  <johnnyding.webkit@gmail.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=31224
        [V8] Return StyleSheet object instead of HTMLStyleElement w/document.styleSheets named property getter.

        Test: fast/dom/StyleSheet/get-stylesheet-byname.html

        * bindings/v8/custom/V8StyleSheetListCustom.cpp:
        (WebCore::NAMED_PROPERTY_GETTER):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMade the full-screen video HUD appear when playback stops, such as when
mitz@apple.com [Mon, 9 Nov 2009 04:52:19 +0000 (04:52 +0000)]
Made the full-screen video HUD appear when playback stops, such as when
the end of the video is reached.

Reviewed by Eric Carlson.

* WebView/WebVideoFullscreenHUDWindowController.h: Cleaned up.
* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]): Updated
for the renaming of -updateRate to -updatePlayButton.
(-[WebVideoFullscreenHUDWindowController updatePlayButton]): Renamed
-updateRate to this.
(-[WebVideoFullscreenHUDWindowController updateRate]): This method now
responds to changes to the playback rate by updating the play button
and showing or hiding the HUD as necessary.
(-[WebVideoFullscreenHUDWindowController togglePlaying:]): Now only
toggles playing. UI updates are driven by -updateRate being called.
(-[WebVideoFullscreenHUDWindowController playing]): Cleaned up.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 9 Nov 2009 04:46:33 +0000 (04:46 +0000)]
2009-11-08  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: "Search again" on scripts panel switches
        to the script this search started with.

        https://bugs.webkit.org/show_bug.cgi?id=31243

        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.jumpToNextSearchResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago* wtf/DateMath.cpp:
levin@chromium.org [Mon, 9 Nov 2009 02:43:51 +0000 (02:43 +0000)]
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):
* wtf/DateMath.h:
(JSC::GregorianDateTime::GregorianDateTime):

Reviewed by NOBODY (speculative snow leopard and windows build fixes).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore: Hopefully, the last build fix.
levin@chromium.org [Mon, 9 Nov 2009 02:33:04 +0000 (02:33 +0000)]
JavaScriptCore: Hopefully, the last build fix.

Reviewed by NOBODY (chromium build fix).

Create better separation in DateMath about the JSC
and non-JSC portions. Also, only expose the non-JSC
version in the exports.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
(JSC::getUTCOffset):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):
* wtf/DateMath.h:
(JSC::gmtoffset):

JavaScriptGlue: Added the use jsc define for files that use
this config file and DateMath.h. This should
be able to go away when DateMath is properly
split into wtf and jsc portions which is this bug:
https://bugs.webkit.org/show_bug.cgi?id=31246

Reviewed by NOBODY (chromium build fix).

* config.h:

WebCore: * platform/network/HTTPParsers.cpp:
(WebCore::parseDate): Changed this to not
use a date parser that needs ExecState passed.

Reviewed by NOBODY (chromium build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-08 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Mon, 9 Nov 2009 01:28:20 +0000 (01:28 +0000)]
2009-11-08  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Simplify Icon interface.
        https://bugs.webkit.org/show_bug.cgi?id=31154

        - Remove Icon::createIconForFile().  createIconForFiles() covers
          createIconForFile()'s role.
        - Remove FileChooser::chooseIcon()
        - Change the parameter types of FileChooser constructor and the
          factory method, String -> const Vector<String>&, in order to
          support initialization with multiple files.
        - Remove the icon loading code in IconChromiumWin.cpp, which
          doesn't work because of the sandbox.

        No tests because it's just a refactoring.

        * platform/FileChooser.cpp:
        (WebCore::FileChooser::FileChooser):
        (WebCore::FileChooser::create):
        (WebCore::FileChooser::chooseFile):
        (WebCore::FileChooser::chooseFiles):
        * platform/FileChooser.h:
        * platform/graphics/Icon.h:
        * platform/graphics/chromium/IconChromiumLinux.cpp:
        * platform/graphics/chromium/IconChromiumMac.cpp:
        * platform/graphics/chromium/IconChromiumWin.cpp:
        (WebCore::Icon::createIconForFiles):
        * platform/graphics/gtk/IconGtk.cpp:
        (WebCore::Icon::createIconForFiles):
        * platform/graphics/haiku/IconHaiku.cpp:
        * platform/graphics/mac/IconMac.mm:
        (WebCore::Icon::createIconForFiles):
        * platform/graphics/qt/IconQt.cpp:
        (WebCore::Icon::createIconForFiles):
        * platform/graphics/win/IconWin.cpp:
        (WebCore::Icon::createIconForFiles):
        * platform/graphics/wx/IconWx.cpp:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::RenderFileUploadControl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-08 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 9 Nov 2009 01:18:08 +0000 (01:18 +0000)]
2009-11-08  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=31098

        Allows same-origin plugin-based content to load.

        Test: http/tests/security/xssAuditor/object-src-inject.html

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Modified to call XSSAuditor::isSameOriginResource.
        (WebCore::XSSAuditor::canLoadObject): Ditto.
        (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
        (WebCore::XSSAuditor::isSameOriginResource): Added.
        * page/XSSAuditor.h:
2009-11-08  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=31098

        Tests that the XSSAuditor prevents loading plugin-based content that is not
        from the same-origin as the enclosing page.

        * http/tests/security/xssAuditor/object-src-inject-expected.txt: Added.
        * http/tests/security/xssAuditor/object-src-inject.html: Added.
        * http/tests/security/xssAuditor/resources/echo-object-src.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed build fix for chromium.
levin@chromium.org [Sun, 8 Nov 2009 23:54:41 +0000 (23:54 +0000)]
Unreviewed build fix for chromium.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed build fix for chromium.
levin@chromium.org [Sun, 8 Nov 2009 23:42:20 +0000 (23:42 +0000)]
Unreviewed build fix for chromium.

Build fix for https://bugs.webkit.org/show_bug.cgi?id=31219
Clean up GraphicsContext's current concept of ColorSpace

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFor the change in DateMath.
levin@chromium.org [Sun, 8 Nov 2009 21:02:20 +0000 (21:02 +0000)]
For the change in DateMath.

Reviewed by NOBODY (chromium build fix).

* config.h:
* wtf/DateMath.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 8 Nov 2009 19:47:22 +0000 (19:47 +0000)]
2009-11-08  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: [REGRESSION] committing style edit
        clears elements panel selection.

        https://bugs.webkit.org/show_bug.cgi?id=31242

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.update):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.):
        (WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-08 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Sun, 8 Nov 2009 19:09:41 +0000 (19:09 +0000)]
2009-11-08  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Holger Freyther.

        Update texts in test description after test case change in r50579.
        https://bugs.webkit.org/show_bug.cgi?id=31122

        * editing/selection/shrink-selection-after-shift-pagedown-expected.txt:
        * editing/selection/shrink-selection-after-shift-pagedown.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Sun, 8 Nov 2009 19:01:51 +0000 (19:01 +0000)]
2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Holger Freyther.

        ResourceRequest to be class instead of struct
        https://bugs.webkit.org/show_bug.cgi?id=30670

        Started as a compilation fix for Symbian where the compiler makes a distinction between
        class and struct in function argument signatures.
        Changed all forward declarations of ResourceRequest to have class in the forward
        declaration instead of struct and changed the definition of ResourceRequest to be class
        and added access qualifiers where missing. Additionally two references of friend
        struct ResourceRequestBase changed to class instead.

        * history/HistoryItem.h:
        * inspector/InspectorController.h:
        * inspector/InspectorResource.h:
        * loader/DocumentThreadableLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.h:
        * loader/ResourceLoadNotifier.h:
        * loader/SubresourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        * loader/ThreadableLoader.h:
        * loader/WorkerThreadableLoader.h:
        * loader/appcache/ApplicationCache.h:
        * loader/appcache/ApplicationCacheHost.h:
        * platform/CrossThreadCopier.h:
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        * platform/network/ResourceRequestBase.h:
        * platform/network/cf/ResourceRequest.h:
        * platform/network/cf/ResourceRequestCFNet.h:
        * platform/network/chromium/ResourceRequest.h:
        * platform/network/curl/ResourceRequest.h:
        * platform/network/qt/ResourceRequest.h:
        * platform/network/soup/ResourceRequest.h:
        * xml/XMLHttpRequest.h:
2009-11-08  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Holger Freyther.

        ResourceRequest to be class instead of struct
        https://bugs.webkit.org/show_bug.cgi?id=30670

        Started as a compilation fix for Symbian where the compiler makes a distinction between
        class and struct in function argument signatures.
        Changed forward declaration of ResourceRequest to have class in the forward
        declaration instead of struct.

        * WebDownload.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2009-11-08 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Sun, 8 Nov 2009 18:51:22 +0000 (18:51 +0000)]
2009-11-08  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] Added support for key code 8 (backspace) in EventSenderQt.
        This helps to pass the test case below. Also replaced hardcoded
        code numbers with defined constants.
        https://bugs.webkit.org/show_bug.cgi?id=31185

        Test: editing/undo/undo-deleteWord.html

        * DumpRenderTree/qt/EventSenderQt.cpp:
        (EventSender::keyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
mitz@apple.com [Sun, 8 Nov 2009 17:32:07 +0000 (17:32 +0000)]
<rdar://problem/7363434> Crash inside RenderObject::localToAbsolute
below FrameView::layout
https://bugs.webkit.org/show_bug.cgi?id=31093

Reviewed by Simon Fraser.

WebCore:

Test: fast/block/positioning/relative-positioned-inline-container.html

In <http://trac.webkit.org/changeset/19148>, setStaticY() was changed
to mark the object for layout, doing so without marking its ancestors.
However, RenderBlock::skipLeadingWhitespace and
RenderBlock::skipTrailingWhitespace() call setStaticY() on a relative-
positioned inline container, causing it to be marked for layout without
ever going back to give it layout, and thus layout could end with a
dirty object still in the tree, leading to all sorts of badness.

The fix is to revert setStaticY() to not marking the object dirty, and
instead do it in the call sites that require it, which are in
RenderBlock and RenderFlexibleBox.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* rendering/RenderLayer.cpp:
* rendering/RenderLayer.h:
(WebCore::RenderLayer::setStaticY):

LayoutTests:

* fast/block/positioning/relative-positioned-inline-container-expected.checksum: Added.
* fast/block/positioning/relative-positioned-inline-container-expected.png: Added.
* fast/block/positioning/relative-positioned-inline-container-expected.txt: Added.
* fast/block/positioning/relative-positioned-inline-container.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt] [DRT] Fix wrong logic in LayoutTestController processWork
tonikitoo@webkit.org [Sun, 8 Nov 2009 17:26:01 +0000 (17:26 +0000)]
[Qt] [DRT] Fix wrong logic in LayoutTestController processWork
https://bugs.webkit.org/show_bug.cgi?id=31164

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-11-05
Reviewed by Holger Freyther.

Fixed wrong logic to assume WorkQueue is done in QT's DRT.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::processWork):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
tonikitoo@webkit.org [Sun, 8 Nov 2009 17:25:31 +0000 (17:25 +0000)]
[Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
https://bugs.webkit.org/show_bug.cgi?id=31158

Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-11-07
Reviewed by Holger Freyther.

By invoking a script queue'd by queueScript(), 'true' was beeing returned
always, which from WorkQueue prospective means that a load has been started
and the queue processing should stop and wait for the load to finish.
Spinning it off into a loading and a non-loading variants was the solution
adopted by Mac's DRT to work around this problem. The former keeps returning
'true' while the later executes the script synchronously and returns 'false'
making it possible to the WorkQueue to proceed right away.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::processWork):
(LayoutTestController::queueLoadingScript):
(LayoutTestController::queueNonLoadingScript):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/qt/WorkQueueItem.h:
(LoadingScriptItem::LoadingScriptItem):
(LoadingScriptItem::invoke):
(NonLoadingScriptItem::NonLoadingScriptItem):
(NonLoadingScriptItem::invoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoInvoke prepare-ChangeLog via an absolute path rather than assuming it can be found...
mrowe@apple.com [Sun, 8 Nov 2009 03:59:33 +0000 (03:59 +0000)]
Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.

Rubber-stamped by Cameron Zwarich.

* Scripts/commit-log-editor:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50620 268f45cc-cd09-0410-ab3c-d52691b4dbfc