WebKit-https.git
9 years agoAdd two more tiled scrolling tests
simon.fraser@apple.com [Thu, 25 Oct 2012 00:50:02 +0000 (00:50 +0000)]
Add two more tiled scrolling tests
https://bugs.webkit.org/show_bug.cgi?id=100314

Reviewed by Beth Dakin.

Two new tests for TileCache tile coverage after scrolling.

* platform/mac/tiled-drawing/tile-coverage-after-scroll-expected.txt: Added.
* platform/mac/tiled-drawing/tile-coverage-after-scroll.html: Added.
* platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt: Added.
* platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[SOUP] Provide logging for SocketStreamHandleSoup
commit-queue@webkit.org [Thu, 25 Oct 2012 00:49:44 +0000 (00:49 +0000)]
[SOUP] Provide logging for SocketStreamHandleSoup
https://bugs.webkit.org/show_bug.cgi?id=100215

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-10-24
Reviewed by Alexey Proskuryakov.

Add logging to SocketStreamHandleSoup to facilitate debugging.

* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated results for https://bugs.webkit.org/show_bug.cgi?id=100312
bdakin@apple.com [Thu, 25 Oct 2012 00:47:52 +0000 (00:47 +0000)]
Updated results for https://bugs.webkit.org/show_bug.cgi?id=100312
I checked in results that relied on some local changes in WK2.

* platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPass on exif orientation from ImageSource when using the open-source image decoders
thakis@chromium.org [Thu, 25 Oct 2012 00:42:51 +0000 (00:42 +0000)]
Pass on exif orientation from ImageSource when using the open-source image decoders
https://bugs.webkit.org/show_bug.cgi?id=100164

Reviewed by Eric Seidel.

The orientation is honored always for image documents, and optionally
for <img> elements if shouldRespectImageOrientation is set (off by
default). However, the feature needs port-specific modifications to
GraphicsContext (without this, webcore will use the rotated bounds but
draw the image as if it hadn't be rotated, resulting in squished
pixels), and most ports don't implement these yet -- so put
turning this on for image documents behind a port-specific #ifdef.

No observable behavior change. Once it's hooked up, it will be tested
by fast/images/exif-orientation.html.

* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::size):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):
* platform/graphics/chromium/DeferredImageDecoder.cpp:
(WebCore::DeferredImageDecoder::orientation):
(WebCore):
* platform/graphics/chromium/DeferredImageDecoder.h:
(DeferredImageDecoder):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::readImageOrientation):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip tiled drawing tests for WK1
simon.fraser@apple.com [Thu, 25 Oct 2012 00:36:44 +0000 (00:36 +0000)]
Skip tiled drawing tests for WK1
https://bugs.webkit.org/show_bug.cgi?id=100312

Reviewed by Beth Dakin.

Skip platform/mac/tiled-drawing tests in the main TestExpections file,
but re-enable it in the WK2 TestExpections file.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium-mac-mountainlion baselines.
dpranke@chromium.org [Thu, 25 Oct 2012 00:33:28 +0000 (00:33 +0000)]
Unreviewed, update chromium-mac-mountainlion baselines.

* platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.png: Copied from LayoutTests/platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png.
* platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.txt: Copied from LayoutTests/platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt.
* platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, expectations and baseline cleanup.
dpranke@chromium.org [Thu, 25 Oct 2012 00:24:20 +0000 (00:24 +0000)]
Unreviewed, expectations and baseline cleanup.

Remove some old baselines for a test that was converted to a reftest,
and remove entries for tests no longer failing on Chromium Mac ML.

* platform/chromium-mac-lion/fast/forms/date/date-reset-value-expected.png: Removed.
* platform/chromium-mac-mountainlion/TestExpectations:
* platform/chromium-mac-snowleopard/fast/forms/date/date-reset-value-expected.png: Removed.
* platform/chromium-mac/fast/forms/date/date-reset-value-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG compileBlahBlahByVal methods for Contiguous and ArrayStorage have only one caller...
fpizlo@apple.com [Thu, 25 Oct 2012 00:24:11 +0000 (00:24 +0000)]
DFG compileBlahBlahByVal methods for Contiguous and ArrayStorage have only one caller and should be removed
https://bugs.webkit.org/show_bug.cgi?id=100311

Reviewed by Mark Hahnenberg.

Just trying to simplify things before I make them more complicated again.

* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::temporaryRegisterForPutByVal):
* dfg/DFGSpeculativeJIT32_64.cpp:
(DFG):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(DFG):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=100169
bdakin@apple.com [Thu, 25 Oct 2012 00:19:35 +0000 (00:19 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=100169
We should make TileCache tiles the size of the tile coverage rect
when we can't do fast scrolling
-and-
<rdar://problem/12505021>

Reviewed by Simon Fraser.

Source/WebCore:

Some websites that don't do fast scrolling still scroll slower than
they do with tiled drawing disabled.
https://bugs.webkit.org/show_bug.cgi?id=99768 addressed some of this
performance problem, but there is still more ground to make up. This
patch addresses the remaining issue by making tiles the size of the
window when we can't do fast scrolling.

The constructor and create function no longer take a size parameter.
That's all fully controlled within TileCache now. m_tileSize is no
longer const.
* platform/graphics/ca/mac/TileCache.h:

Store the current default size as constants so that we can access it
in both the constructor and adjustTileSizeForCoverageRect().
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache):

This new function will set m_tileSize to the size of the tile
coverage rect if the tile coverage is limited to the visible area.
Otherwise, the tiles are set to be the default size.
(WebCore::TileCache::adjustTileSizeForCoverageRect):

Call adjustTileSizeForCoverageRect().
(WebCore::TileCache::revalidateTiles):

No need to send in a size anymore.
* platform/graphics/ca/mac/WebTileCacheLayer.h:
(WebCore):

LayoutTests:

New test.
* platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt: Added.
* platform/mac/tiled-drawing/tile-coverage-slow-scrolling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake it a compile error to send a sync message as async (and vice versa)
andersca@apple.com [Wed, 24 Oct 2012 23:59:39 +0000 (23:59 +0000)]
Make it a compile error to send a sync message as async (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=100285

Reviewed by Sam Weinig.

Add an "isSync" boolean to each generated message struct and add compile asserts to the message senders.

* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
* Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendSync):
* Scripts/webkit2/messages.py:
(message_to_struct_declaration):
* Scripts/webkit2/messages_unittest.py:
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::send):
(WebKit::WebProcessProxy::sendSync):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable auto termination of WebKit2 processes on mac
commit-queue@webkit.org [Wed, 24 Oct 2012 23:55:49 +0000 (23:55 +0000)]
Disable auto termination of WebKit2 processes on mac
https://bugs.webkit.org/show_bug.cgi?id=100176

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-10-24
Reviewed by Alexey Proskuryakov.

Disable WebKit2 auto termination by taking corresponding assertion
until UI process is enhanced to determine when it is safe to enable it.

* NetworkProcess/mac/NetworkProcessMainMac.mm:
(WebKit::NetworkProcessMain):
* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
* SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm:
(WebKit::SharedWorkerProcessMain):
* WebProcess/mac/WebProcessInitialization.mm:
(WebKit::InitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMathML tests trigger font cache assertions in debug bots
dbarton@mathscribe.com [Wed, 24 Oct 2012 23:49:54 +0000 (23:49 +0000)]
MathML tests trigger font cache assertions in debug bots
https://bugs.webkit.org/show_bug.cgi?id=100268

Reviewed by Eric Seidel.

Source/WebCore:

Add a FontCachePurgePreventer to fix this.

Tested by existing tests.

* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):

LayoutTests:

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt: truncate meter lines properly on windows
dpranke@chromium.org [Wed, 24 Oct 2012 23:46:23 +0000 (23:46 +0000)]
nrwt: truncate meter lines properly on windows
https://bugs.webkit.org/show_bug.cgi?id=100062

Reviewed by Tony Chang.

This change adds the code to figure out the terminal width
on windows (it was already there for Unixen) and moves it
to a platform-specific object.

* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.terminal_width):
* Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.total_bytes_memory):
(MockPlatformInfo):
(MockPlatformInfo.terminal_width):
* Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream.__init__):
(MeteredStream.number_of_columns):
(MeteredStream.flush):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.__init__):
(Printer._test_status_line):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate main frame scroll position immediately for programmatic scrolls
timothy_horton@apple.com [Wed, 24 Oct 2012 23:40:28 +0000 (23:40 +0000)]
Update main frame scroll position immediately for programmatic scrolls
https://bugs.webkit.org/show_bug.cgi?id=98074

Reviewed by Simon Fraser.

Immediately update the main frame scroll position after a programmatic scroll,
so that performing a scrollBy or scrollTo will be instantly reflected in
all of the scroll offset accessors.

No new tests; this will be tested by many scrolling tests once WebKitTestRunner
can use threaded scrolling.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Allow pushState and related history APIs to be disabled per context
mihaip@chromium.org [Wed, 24 Oct 2012 23:26:58 +0000 (23:26 +0000)]
[Chromium] Allow pushState and related history APIs to be disabled per context
https://bugs.webkit.org/show_bug.cgi?id=99780

Reviewed by Adam Barth.

Source/WebCore:

Chrome Apps do not support the history API (or navigation in general).
Since pushState is generally feature detected, it's cleanest to disable
it via a V8 per-context feature, so that applications can have the
appropriate fallback behavior (other history APIs are re-mapped to throw
exceptions, since history.back() and the link are not feature detected).

* dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::pushStateEnabled):
(WebCore):
* dom/ContextFeatures.h:
* dom/Document.cpp:
(WebCore::Document::enqueuePopstateEvent):
* page/History.idl:

Source/WebKit/chromium:

Add pushState context feature.

* public/WebPermissionClient.h:
(WebPermissionClient):
(WebKit::WebPermissionClient::allowPushState):
* src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: MediaStream API: Make sure all events are dispatched asynchronously
tommyw@google.com [Wed, 24 Oct 2012 23:24:05 +0000 (23:24 +0000)]
Source/WebCore: MediaStream API: Make sure all events are dispatched asynchronously
https://bugs.webkit.org/show_bug.cgi?id=100286

Reviewed by Adam Barth.

This is necessary to safeguard against if the UA uses synchronous UA->WebKit calls,
and the web application calls methods on the RTCPeerConnection in the event callbacks.

Test: fast/mediastream/RTCPeerConnection-events.html
Also tested by the chromium webrtc fuzz tests.

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::negotiationNeeded):
(WebCore::RTCPeerConnection::didGenerateIceCandidate):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):
(WebCore::RTCPeerConnection::didAddRemoteDataChannel):
(WebCore::RTCPeerConnection::changeReadyState):
(WebCore::RTCPeerConnection::changeIceState):
(WebCore):
(WebCore::RTCPeerConnection::scheduleDispatchEvent):
(WebCore::RTCPeerConnection::scheduledEventTimerFired):
* Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):

LayoutTests: MediaStream API: Make sure all RTCPeerConnection events are dispatched asynchronously
https://bugs.webkit.org/show_bug.cgi?id=100286

Reviewed by Adam Barth.

RTCPeerConnection::close is the only function that dispatches an event directly so only test that.

* fast/mediastream/RTCPeerConnection-events-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Remove screen-related functions from PlatformSupport
pilgrim@chromium.org [Wed, 24 Oct 2012 23:19:45 +0000 (23:19 +0000)]
[Chromium] Remove screen-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97474

Reviewed by Adam Barth.

Screen-related functions like screenHorizontalDPI that
used to be on PlatformSupport are now accessed through a new
PlatformPageClient attached to Widget in WebCore-land, which is
implemented by ChromeClientImpl in WebKit-land, which proxies
calls to WebWidgetClient, which is actually implemented in
Chromium-land.

Source/Platform:

* Platform.gypi:
* chromium/public/WebScreenInfo.h: Added.
(WebKit):
(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):

Source/WebCore:

* WebCore.gypi:
* platform/Widget.h:
* platform/chromium/PageClientChromium.h: Copied from Source/WebCore/platform/chromium/PlatformWidget.h.
(PageClientChromium):
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::toPlatformPageClient):
(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* public/WebScreenInfo.h:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::screenInfo):
(WebKit):
* src/ChromeClientImpl.h:
(WebKit):
(WebKit::ChromeClientImpl::platformPageClient):
(ChromeClientImpl):
* src/PlatformSupport.cpp:
(WebCore):
* src/WebPagePopupImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Chromium revision 163873 also made
leviw@chromium.org [Wed, 24 Oct 2012 23:18:32 +0000 (23:18 +0000)]
Unreviewed gardening. Chromium revision 163873 also made
platform/chromium/virtual/gpu/fast/canvas/canvas-incremental-repaint.html slow.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] WorkerContextExecutionProxy doesn't need to track events
abarth@webkit.org [Wed, 24 Oct 2012 23:17:36 +0000 (23:17 +0000)]
[V8] WorkerContextExecutionProxy doesn't need to track events
https://bugs.webkit.org/show_bug.cgi?id=100295

Reviewed by Eric Seidel.

This code was added when this code was originally upstreamed as part of
the Chromium port. There doesn't appear to be any reason why
WorkerContextExecutionProxy needs to keep a Vector of raw event
pointers. Those points are likely to become dangling, making the rest
of what this code does very sketchy.

* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::callListenerFunction):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::dispose):
* bindings/v8/WorkerContextExecutionProxy.h:
(WebCore::WorkerContextExecutionState::WorkerContextExecutionState):
(WorkerContextExecutionProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Shaders] The mesh should be specified using <column, row> order
commit-queue@webkit.org [Wed, 24 Oct 2012 23:01:30 +0000 (23:01 +0000)]
[CSS Shaders] The mesh should be specified using <column, row> order
https://bugs.webkit.org/show_bug.cgi?id=96285

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-24
Reviewed by Dean Jackson.

Source/WebCore:

Change StyleResolver and CSSComputedStyleDeclaration to handle the mesh parameters in
column, row order.

Test: css3/filters/custom/custom-filter-mesh-column-row-order.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
    Append the number of columns before the number of rows in the meshParameters
    CSSValueList.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperation):
    Store the second mesh parameter in meshRows instead of meshColumns.

LayoutTests:

Add a test verifying that WebKit interprets the CSS mesh values in column, row order.
Update existing tests for u_meshSize and u_tileSize to expect column, row order.

* css3/filters/custom/custom-filter-mesh-column-row-order-expected.html: Added.
* css3/filters/custom/custom-filter-mesh-column-row-order.html: Added.
* css3/filters/resources/checkerboard.vs: Added.
* css3/filters/resources/u-mesh-size.fs:
* css3/filters/resources/u-tile-size.fs:
* css3/filters/resources/varying-mix-color.fs: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotweak debug logging in webkit-patch optimize-baselines
dpranke@chromium.org [Wed, 24 Oct 2012 23:00:00 +0000 (23:00 +0000)]
tweak debug logging in webkit-patch optimize-baselines
https://bugs.webkit.org/show_bug.cgi?id=100294

Reviewed by Ojan Vafai.

This changes the logging to print out the baselines found
(and their checksums) even when we don't do anything.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer.optimize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] change CMAKE_<CCXX|C>_FLAGS_<RELEASE|DEBUG> from enviroment flags
commit-queue@webkit.org [Wed, 24 Oct 2012 22:49:03 +0000 (22:49 +0000)]
[BlackBerry] change CMAKE_<CCXX|C>_FLAGS_<RELEASE|DEBUG> from enviroment flags
https://bugs.webkit.org/show_bug.cgi?id=100256

Patch by Michael Carmody <mcarmody@rim.com> on 2012-10-24
Reviewed by Rob Buis.

This allow override of compile flags without having to edit CMake files.

* Source/cmake/OptionsBlackBerry.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed, land pixel results on Win/Mac for a new repaint test.
tony@chromium.org [Wed, 24 Oct 2012 22:45:13 +0000 (22:45 +0000)]
[chromium] Unreviewed, land pixel results on Win/Mac for a new repaint test.

* platform/chromium-mac/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
* platform/chromium-win/css3/flexbox/repaint-during-resize-no-flex-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/flexbox/repaint-during-resize-no-flex-expected.png.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoloaderRunLoop() should use synchronization instead of while loop
commit-queue@webkit.org [Wed, 24 Oct 2012 22:40:27 +0000 (22:40 +0000)]
loaderRunLoop() should use synchronization instead of while loop
https://bugs.webkit.org/show_bug.cgi?id=55402

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-10-24
Reviewed by Alexey Proskuryakov.

Originally, loaderRunLoop() sleeps until a thread has started and set
the loaderRunLoopObject static variable. This patch uses
ThreadCondition to synchronize instead of a while loop.

No new tests (No behavior change).

* platform/network/cf/LoaderRunLoopCF.cpp:
(WebCore::runLoaderThread):
(WebCore::loaderRunLoop):
* platform/network/cf/LoaderRunLoopCF.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncorrect keycodes for numpad /, -, +, .
commit-queue@webkit.org [Wed, 24 Oct 2012 22:36:28 +0000 (22:36 +0000)]
Incorrect keycodes for numpad /, -, +, .
https://bugs.webkit.org/show_bug.cgi?id=99188

Patch by Sailesh Agrawal <sail@chromium.org> on 2012-10-24
Reviewed by Tony Chang.

Source/WebCore:

In r57951 we switched to mapping keys by character code.
This regressed the numpad keys which no longer match the Windows virtual key codes.
This CL fixes this by never mapping numpad keys by character code.

Test: platform/mac/fast/events/numpad-keycode-mapping.html

* platform/mac/PlatformEventFactoryMac.mm:
(WebCore::windowsKeyCodeForKeyEvent):

Source/WebKit/chromium:

In r57951 we switched to mapping keys by character code.
This regressed the numpad keys which no longer match the Windows virtual key codes.
This CL fixes this by never mapping numpad keys by character code.

* src/mac/WebInputEventFactory.mm: Disallow mapping numpad keys by character code.
(WebKit::windowsKeyCodeForKeyEvent):
* tests/WebInputEventFactoryTestMac.mm: Test to verify that all numpad keys are correctly mapped.
(TEST):

Tools:

Add key mappings for all numpad keys.

* DumpRenderTree/mac/EventSendingController.mm:
(KeyMappingEntry):
(-[EventSendingController keyDown:withModifiers:withLocation:]): Added all numpad keys.

LayoutTests:

Added test to map numpad keys to windows virtual keycodes. This test is for the Mac port only. DumpRenderTree in the chromium-mac port doesn't use Mac keycodes so this can't be tested on that platform.

* platform/mac/fast/events/numpad-keycode-mapping-expected.txt: Added.
* platform/mac/fast/events/numpad-keycode-mapping.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: clean up references to Skipped files
dpranke@chromium.org [Wed, 24 Oct 2012 22:04:00 +0000 (22:04 +0000)]
webkitpy: clean up references to Skipped files
https://bugs.webkit.org/show_bug.cgi?id=100045

Reviewed by Ojan Vafai.

Since they are no longer used or needed ...

* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort._generate_all_test_configurations):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.skipped_layout_tests):
(Port.expectations_files):
(Port._wk2_port_name):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(MacTest.test_default_timeout_ms):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(test_expectations_files):
(test_expectations_files.platform_dirs):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNull-check the RenderView in ocument::windowScreenDidChange to fix a crash when savin...
simon.fraser@apple.com [Wed, 24 Oct 2012 22:01:03 +0000 (22:01 +0000)]
Null-check the RenderView in ocument::windowScreenDidChange to fix a crash when saving PDFs
https://bugs.webkit.org/show_bug.cgi?id=100141
<rdar://problem/12559147>

Reviewed by Tim Horton.

For PDF documents the RenderView is null, so null-check it to avoid a crash
when saving PDFs.

* dom/Document.cpp:
(WebCore::Document::windowScreenDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Marking the software compositing version of
leviw@chromium.org [Wed, 24 Oct 2012 22:00:32 +0000 (22:00 +0000)]
Unreviewed gardening. Marking the software compositing version of
compositing/tiling/backface-preserve-3d-tiled.html as failing as well.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Marking 2 more mathml tests as flaky crashers on debug.
leviw@chromium.org [Wed, 24 Oct 2012 21:58:30 +0000 (21:58 +0000)]
Unreviewed gardening. Marking 2 more mathml tests as flaky crashers on debug.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle two-finger tap gestures in the same way as long-press gestures
tdanderson@chromium.org [Wed, 24 Oct 2012 21:54:16 +0000 (21:54 +0000)]
Handle two-finger tap gestures in the same way as long-press gestures
https://bugs.webkit.org/show_bug.cgi?id=99947

Reviewed by Adam Barth.

Source/WebCore:

Currently a long-press gesture is used to dispatch a context menu (for platforms
defining CONTEXT_MENUS) or to select text (for Android). Additionally, for platforms
defining TOUCH_ADJUSTMENT, gesture target fuzzing is performed on the location and
touch area of the long-press gesture.

This CL will cause two-finger tap gestures to be handled in the same way as long-press
gestures. The location and touch area of a two-finger tap gesture will correspond to
the location and touch area of the first finger down; the location/area of the second
finger will be ignored.

Test: touchadjustment/touch-links-two-finger-tap.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureLongPress):
(WebCore):
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
(WebCore::EventHandler::handleGestureTwoFingerTap):
(WebCore::EventHandler::adjustGesturePosition):
* page/EventHandler.h:
(EventHandler):

Source/WebKit/chromium:

Set the area of a two-finger tap gesture to be the area of the enclosing
rectangle for the first finger down.

* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

LayoutTests:

New layout test for dispatching context menus on a two-finger tap
gesture when touch adjustment is enabled.

* touchadjustment/touch-links-two-finger-tap-expected.txt: Added.
* touchadjustment/touch-links-two-finger-tap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Get rid of Ewk_View private C API (Part 1)
commit-queue@webkit.org [Wed, 24 Oct 2012 21:51:56 +0000 (21:51 +0000)]
[EFL][WK2] Get rid of Ewk_View private C API (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=100230

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Remove part of the Ewk_View private C API and replace
it by C++ methods in EwkViewImpl class. Eventually,
all the private C functions will be removed but it
will be done in several patches.

* UIProcess/API/C/efl/WKView.cpp:
(WKViewGetPage):
* UIProcess/API/efl/EwkViewImpl.cpp:
(_ewk_view_commit):
(_ewk_view_preedit_changed):
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::smartData):
(EwkViewImpl::fromEvasObject):
(EwkViewImpl::wkPage):
(EwkViewImpl::setCursor):
(EwkViewImpl::redrawRegion):
(EwkViewImpl::informDownloadJobCancelled):
(EwkViewImpl::informDownloadJobFailed):
(EwkViewImpl::informDownloadJobFinished):
(EwkViewImpl::informDownloadJobRequested):
(EwkViewImpl::informNewFormSubmissionRequest):
(EwkViewImpl::enterFullScreen):
(EwkViewImpl::exitFullScreen):
(EwkViewImpl::setImageData):
(EwkViewImpl::informLoadError):
(EwkViewImpl::informLoadFinished):
(EwkViewImpl::informLoadProgress):
(EwkViewImpl::informProvisionalLoadFailed):
(EwkViewImpl::informLoadCommitted):
(EwkViewImpl::informProvisionalLoadRedirect):
(EwkViewImpl::informProvisionalLoadStarted):
(EwkViewImpl::informNavigationPolicyDecision):
(EwkViewImpl::informNewWindowPolicyDecision):
(EwkViewImpl::informResourceLoadStarted):
(EwkViewImpl::informResourceLoadResponse):
(EwkViewImpl::informResourceLoadFailed):
(EwkViewImpl::informResourceLoadFinished):
(EwkViewImpl::informResourceRequestSent):
(EwkViewImpl::informTitleChange):
(EwkViewImpl::informTooltipTextChange):
(EwkViewImpl::informTextFound):
(EwkViewImpl::size):
(EwkViewImpl::informIconChange):
(EwkViewImpl::informIntentRequest):
(EwkViewImpl::informIntentServiceRegistration):
(EwkViewImpl::createGLSurface):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::exitAcceleratedCompositingMode):
(EwkViewImpl::requestColorPicker):
(EwkViewImpl::dismissColorPicker):
(EwkViewImpl::informBackForwardListChange):
* UIProcess/API/efl/EwkViewImpl.h:
(WebCore):
(EwkViewImpl):
(EwkViewImpl::view):
(EwkViewImpl::page):
* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::viewImpl):
(WebKit):
(WebKit::PageClientImpl::createDrawingAreaProxy):
(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::isViewFocused):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::processDidCrash):
(WebKit::PageClientImpl::didRelaunchProcess):
(WebKit::PageClientImpl::toolTipChanged):
(WebKit::PageClientImpl::setCursor):
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::exitAcceleratedCompositingMode):
(WebKit::PageClientImpl::updateTextInputState):
(WebKit::PageClientImpl::handleDownloadRequest):
(WebKit::PageClientImpl::didChangeContentsSize):
* UIProcess/API/efl/PageClientImpl.h:
(WebKit::PageClientImpl::create):
(PageClientImpl):
* UIProcess/API/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::PageViewportControllerClientEfl):
(WebKit::PageViewportControllerClientEfl::drawingArea):
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
* UIProcess/API/efl/PageViewportControllerClientEfl.h:
(WebKit::PageViewportControllerClientEfl::create):
(PageViewportControllerClientEfl):
* UIProcess/API/efl/ewk_download_job.cpp:
(Ewk_Download_Job::Ewk_Download_Job):
(Ewk_Download_Job::viewImpl):
* UIProcess/API/efl/ewk_download_job_private.h:
(Ewk_Download_Job::create):
(Ewk_Download_Job):
* UIProcess/API/efl/ewk_view.cpp:
(pageViewMap):
(addToPageViewMap):
(removeFromPageViewMap):
(_ewk_view_on_favicon_changed):
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(mapToWebContent):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_on_show):
(_ewk_view_on_hide):
(_ewk_view_impl_del):
(_ewk_view_smart_del):
(_ewk_view_smart_calculate):
(_ewk_view_smart_color_set):
(_ewk_view_initialize):
(_ewk_view_add_with_smart):
(ewk_view_context_get):
(ewk_view_url_update):
(ewk_view_url_set):
(ewk_view_url_get):
(ewk_view_icon_url_get):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_settings_get):
(ewk_view_title_get):
(ewk_view_text_input_state_update):
(ewk_view_load_progress_get):
(ewk_view_scale_set):
(ewk_view_scale_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
(ewk_view_theme_set):
(ewk_view_theme_get):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_back_forward_list_get):
(ewk_view_html_string_load):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
(ewk_view_page_create):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
(ewk_view_text_matches_count):
(ewk_view_contents_size_changed):
(ewk_view_popup_menu_request):
(ewk_view_popup_menu_close):
(ewk_view_popup_menu_select):
(ewk_view_mouse_events_enabled_set):
(ewk_view_mouse_events_enabled_get):
(ewk_view_webprocess_crashed):
(ewk_view_color_picker_color_set):
(ewk_view_feed_touch_event):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):
(ewk_view_inspector_show):
(ewk_view_inspector_close):
* UIProcess/API/efl/ewk_view_private.h:
* UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::incorporateUpdate):
* UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::decideDestinationWithSuggestedFilename):
(WebKit::DownloadManagerEfl::didFail):
(WebKit::DownloadManagerEfl::didCancel):
(WebKit::DownloadManagerEfl::didFinish):
(WebKit::DownloadManagerEfl::registerDownload):
* UIProcess/efl/DownloadManagerEfl.h:
(DownloadManagerEfl):
* UIProcess/efl/FindClientEfl.cpp:
(WebKit::FindClientEfl::didFindString):
(WebKit::FindClientEfl::didFailToFindString):
(WebKit::FindClientEfl::FindClientEfl):
* UIProcess/efl/FindClientEfl.h:
(WebKit::FindClientEfl::create):
(FindClientEfl):
* UIProcess/efl/FormClientEfl.cpp:
(WebKit::FormClientEfl::willSubmitForm):
(WebKit::FormClientEfl::FormClientEfl):
* UIProcess/efl/FormClientEfl.h:
(WebKit::FormClientEfl::create):
(FormClientEfl):
* UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didReceiveTitleForFrame):
(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):
(WebKit::PageLoadClientEfl::didChangeProgress):
(WebKit::PageLoadClientEfl::didFinishLoadForFrame):
(WebKit::PageLoadClientEfl::didFailLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didStartProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didFailProvisionalLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
(WebKit::PageLoadClientEfl::didChangeBackForwardList):
(WebKit::PageLoadClientEfl::didSameDocumentNavigationForFrame):
(WebKit::PageLoadClientEfl::PageLoadClientEfl):
* UIProcess/efl/PageLoadClientEfl.h:
(WebKit::PageLoadClientEfl::create):
(PageLoadClientEfl):
(WebKit::PageLoadClientEfl::viewImpl):
* UIProcess/efl/PagePolicyClientEfl.cpp:
(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):
(WebKit::PagePolicyClientEfl::PagePolicyClientEfl):
* UIProcess/efl/PagePolicyClientEfl.h:
(WebKit::PagePolicyClientEfl::create):
(PagePolicyClientEfl):
* UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::closePage):
(WebKit::PageUIClientEfl::createNewPage):
(WebKit::PageUIClientEfl::runJavaScriptAlert):
(WebKit::PageUIClientEfl::runJavaScriptConfirm):
(WebKit::PageUIClientEfl::runJavaScriptPrompt):
(WebKit::PageUIClientEfl::showColorPicker):
(WebKit::PageUIClientEfl::hideColorPicker):
(WebKit::PageUIClientEfl::exceededDatabaseQuota):
(WebKit::PageUIClientEfl::focus):
(WebKit::PageUIClientEfl::unfocus):
(WebKit::PageUIClientEfl::takeFocus):
(WebKit::PageUIClientEfl::getWindowFrame):
(WebKit::PageUIClientEfl::setWindowFrame):
(WebKit::PageUIClientEfl::PageUIClientEfl):
* UIProcess/efl/PageUIClientEfl.h:
(WebKit::PageUIClientEfl::create):
(PageUIClientEfl):
* UIProcess/efl/ResourceLoadClientEfl.cpp:
(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):
(WebKit::ResourceLoadClientEfl::didFinishLoadForResource):
(WebKit::ResourceLoadClientEfl::didFailLoadForResource):
(WebKit::ResourceLoadClientEfl::ResourceLoadClientEfl):
(WebKit::ResourceLoadClientEfl::~ResourceLoadClientEfl):
* UIProcess/efl/ResourceLoadClientEfl.h:
(WebKit::ResourceLoadClientEfl::create):
(ResourceLoadClientEfl):
* UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::viewWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX:When aria-label is used, the text under an element is still appearing as the AXTitle
cfleizach@apple.com [Wed, 24 Oct 2012 21:48:16 +0000 (21:48 +0000)]
AX:When aria-label is used, the text under an element is still appearing as the AXTitle
https://bugs.webkit.org/show_bug.cgi?id=98167

Reviewed by Beth Dakin.

Source/WebCore:

According to WAI-ARIA text computation, the presence of aria-label and alternative text
should override the visible text within an element.

Test: platform/mac/accessibility/aria-label-overrides-visible-text.html

* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper accessibilityTitle]):

LayoutTests:

* platform/mac/accessibility/aria-label-overrides-visible-text-expected.txt: Added.
* platform/mac/accessibility/aria-label-overrides-visible-text.html: Added.
* platform/mac/accessibility/aria-labelledby-overrides-aria-label-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r132303 and r132312.
commit-queue@webkit.org [Wed, 24 Oct 2012 21:41:46 +0000 (21:41 +0000)]
Unreviewed, rolling out r132303 and r132312.
http://trac.webkit.org/changeset/132303
http://trac.webkit.org/changeset/132312
https://bugs.webkit.org/show_bug.cgi?id=100287

Triggering crashes on many popular websites (Requested by
leviw|gardening on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-24

Source/WebCore:

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::detectAtToken):
* css/CSSParser.h:
* css/CSSPropertySourceData.h:
* css/RuleSet.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
* css/RuleSet.h:
(RuleData):
(RuleSet):
* css/StyleResolver.cpp:
(WebCore::makeRuleSet):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::locateSharedStyle):
* css/StyleResolver.h:
(StyleResolver):
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
* css/StyleRule.h:
* css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::reportMemoryUsage):
* css/StyleScopeResolver.h:
(WebCore):
(StyleScopeResolver):
* css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):

LayoutTests:

* fast/dom/shadow/athost-atrules-expected.txt: Removed.
* fast/dom/shadow/athost-atrules.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a crash seen during the Inspector tests on the WebKit1 bots.
timothy@apple.com [Wed, 24 Oct 2012 21:37:19 +0000 (21:37 +0000)]
Fix a crash seen during the Inspector tests on the WebKit1 bots.

Reviewed by Filip Pizlo.

* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::bringToFront): Use the window from the WebView since m_windowController's window
is not the same when the Inspector is docked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Cursor property value identities should be preserved
jsbell@chromium.org [Wed, 24 Oct 2012 21:36:57 +0000 (21:36 +0000)]
IndexedDB: Cursor property value identities should be preserved
https://bugs.webkit.org/show_bug.cgi?id=100051

Reviewed by Tony Chang.

Source/WebCore:

Some W3C test submissions point out that subsequent accesses to cursor properties should
yield the same value until the cursor advances. We handled this with custom binding code for
IDBCursor.value but not IDBCursor.key or IDBCursor.primaryKey. The custom value code is
being removed in webkit.org/b/100034 in favor of returning ScriptValue and the same fix can
be applied to key/primaryKey.

Test: storage/indexeddb/cursor-properties.html

* Modules/indexeddb/IDBCursor.cpp: Compute/store/serve up ScriptValues instead of IDBKeys
(WebCore::IDBCursor::key):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::setValueReady):
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
(WebCore::IDBCursor::idbPrimaryKey): Expose this for callers that need access to the IDBKey
* Modules/indexeddb/IDBCursor.idl:
* Modules/indexeddb/IDBObjectStore.cpp: ... like this one.
(WebCore):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent): Pass along script context, for the conversion.
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::idbKeyToScriptValue): New method for explicit conversion.
(WebCore):
* bindings/v8/IDBBindingUtilities.h:
(WebCore):

LayoutTests:

Add tests to verify identity/read-only/mutability of cursor properties.

* storage/indexeddb/cursor-properties-expected.txt: Added.
* storage/indexeddb/cursor-properties.html: Added.
* storage/indexeddb/resources/cursor-properties.js: Added.
(test.request.onsuccess):
(test):
(onUpgradeNeeded):
(onOpenSuccess.request.onsuccess):
(onOpenSuccess):
(checkProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Updating slow expectations for two tests following a Chromium
leviw@chromium.org [Wed, 24 Oct 2012 21:34:16 +0000 (21:34 +0000)]
Unreviewed gardening. Updating slow expectations for two tests following a Chromium
change. See https://bugs.webkit.org/show_bug.cgi?id=100287

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=99202
ericu@chromium.org [Wed, 24 Oct 2012 21:08:01 +0000 (21:08 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=99202
[Chromium] shift-click fails to spawn new window with target=_blank

Reviewed by Adam Barth

No new tests in WebKit-land--see
https://codereview.chromium.org/11235048/ for tests that I'll submit
once this lands.

* src/ChromeClientImpl.cpp:
Change currentEventShouldCauseBackgroundTab to updatePolicyForEvent; we
were looking up the right policy, then throwing it away if it wasn't
forcing a background tab.
(WebKit::ChromeClientImpl::updatePolicyForEvent):
(WebKit::ChromeClientImpl::getNavigationPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocall to setNeedsLayout during RenderVideo::paintReplaced
fischman@chromium.org [Wed, 24 Oct 2012 21:07:02 +0000 (21:07 +0000)]
call to setNeedsLayout during RenderVideo::paintReplaced
https://bugs.webkit.org/show_bug.cgi?id=100265

Reviewed by Eric Carlson.

Removed unnecessary call and added new defensive guards to catch erroneous setNeedsLayout() calls
during paints earlier (so the offending calls are in the emitted stacktrace).

No new tests - new defensive checks are triggered by existing tests.

* page/FrameView.cpp:
(WebCore::FrameView::paintContents): forbid setNeedsLayout() during painting
* rendering/RenderObject.cpp:
(WebCore):
(WebCore::RenderObject::SetLayoutNeededForbiddenScope::SetLayoutNeededForbiddenScope):
(WebCore::RenderObject::SetLayoutNeededForbiddenScope::~SetLayoutNeededForbiddenScope):
* rendering/RenderObject.h:
(RenderObject):
(SetLayoutNeededForbiddenScope): added helper class for forbidding setNeedsLayout() in a scope.
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::paintReplaced): drop the offending & unnecessary call to updatePlayer().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] ActiveDOMObjectEpilogueVisitor is unnecessary and can be deleted
abarth@webkit.org [Wed, 24 Oct 2012 21:02:09 +0000 (21:02 +0000)]
[V8] ActiveDOMObjectEpilogueVisitor is unnecessary and can be deleted
https://bugs.webkit.org/show_bug.cgi?id=100208

Reviewed by Eric Seidel.

Rather than clearing and re-establishing the weak callback for
ActiveDOMObjects during every GC, this patch puts all the
ActiveDOMObjects with pending activity into an object group with a live
object, causing them not to be garbage collected.

In addition to simplifying this code, this patch makes the patch in
https://bugs.webkit.org/show_bug.cgi?id=100175 much easier because
V8GCController no longer needs to know how to configure the weak
callbacks for these objects.

* bindings/v8/V8GCController.cpp:
(WebCore::ActiveDOMObjectPrologueVisitor::ActiveDOMObjectPrologueVisitor):
(ActiveDOMObjectPrologueVisitor):
(WebCore::ActiveDOMObjectPrologueVisitor::visitDOMWrapper):
(WebCore::V8GCController::majorGCPrologue):
(WebCore::V8GCController::majorGCEpilogue):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::V8PerIsolateData):
* bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::liveRoot):
(V8PerIsolateData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a strategy for loader customization.
beidson@apple.com [Wed, 24 Oct 2012 20:49:23 +0000 (20:49 +0000)]
Add a strategy for loader customization.
https://bugs.webkit.org/show_bug.cgi?id=100278

Reviewed by Alexey Proskuryakov.

Source/WebCore:

It's empty for now and does nothing, just like the goggles.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::loaderStrategy):
(PlatformStrategies):
(WebCore::PlatformStrategies::PlatformStrategies):

Source/WebKit/efl:

* WebCoreSupport/PlatformStrategiesEfl.cpp:
(PlatformStrategiesEfl::createLoaderStrategy):
* WebCoreSupport/PlatformStrategiesEfl.h:
(PlatformStrategiesEfl):

Source/WebKit/gtk:

* WebCoreSupport/PlatformStrategiesGtk.cpp:
(PlatformStrategiesGtk::createLoaderStrategy):
* WebCoreSupport/PlatformStrategiesGtk.h:
(PlatformStrategiesGtk):

Source/WebKit/mac:

* WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::createLoaderStrategy):

Source/WebKit/qt:

* WebCoreSupport/PlatformStrategiesQt.cpp:
(PlatformStrategiesQt::createLoaderStrategy):
* WebCoreSupport/PlatformStrategiesQt.h:
(PlatformStrategiesQt):

Source/WebKit/win:

* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createLoaderStrategy):
* WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):

Source/WebKit/wince:

* WebCoreSupport/PlatformStrategiesWinCE.cpp:
(PlatformStrategiesWinCE::createLoaderStrategy):
* WebCoreSupport/PlatformStrategiesWinCE.h:
(PlatformStrategiesWinCE):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createLoaderStrategy):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSetting width of a flexitem causes the adjacent flex item to be displayed poorly.
tony@chromium.org [Wed, 24 Oct 2012 20:46:45 +0000 (20:46 +0000)]
Setting width of a flexitem causes the adjacent flex item to be displayed poorly.
https://bugs.webkit.org/show_bug.cgi?id=99925

Reviewed by Ojan Vafai.

Source/WebCore:

Make sure that we always repaint when moving a child. This is similar to what RenderDeprecatedFlexibleBox does.

Test: css3/flexbox/repaint-during-resize-no-flex.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::setFlowAwareLocationForChild): Move logic for repaining into the helper method
for setting the location of a child.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Remove code for repaint since it's now in setFlowAwareLocationForChild.
(WebCore::RenderFlexibleBox::adjustAlignmentForChild): Remove code for repaint since it's now in setFlowAwareLocationForChild.

LayoutTests:

Add a repaint test.  The render tree should be cross platform, but due to
slight color differences in the grey overlay, the png can't be shared.

* css3/flexbox/repaint-during-resize-no-flex-expected.txt: Added.
* css3/flexbox/repaint-during-resize-no-flex.html: Added.
* platform/chromium-linux/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix CALayer hiearchy when combining tiling with preserve-3d
simon.fraser@apple.com [Wed, 24 Oct 2012 20:36:02 +0000 (20:36 +0000)]
Fix CALayer hiearchy when combining tiling with preserve-3d
https://bugs.webkit.org/show_bug.cgi?id=100205

Reviewed by Dean Jackson.

Source/WebCore:

When an element has "transform-style: preserve-3d", its GraphicsLayerCA has a
m_structuralLayer which is a CATransformLayer. The primary CALayer which contains rendered
content becomes a sublayer of the CATransformLayer. If the element has backface-visibility:hidden,
it is the primary layer that is set to be single-sided.

In r131940 we started to use TileCaches in place of CATiledLayer. TileCaches work via
"customSublayers" returned from the PlatformCALayer, where the custom sublayer is
the tile cache container layer. However, the custom sublayers were being added as
children of the structural (CATransformLayer) layer, not of the primary (CALayer) layer,
thus they were not affected by the doubleSided property.

This change cleans up the confusing code in GraphicsLayerCA::updateSublayerList()
by maintaining two vectors of PlatformCALayers, one for sublayers of the structural
layer, and one for sublayers of the primary layer. It adds custom sublayers to
the latter list, so now the tile cache container layer becomes a sublayer of
the primary layer, so is affected by that layer's doubleSided property.

Test: compositing/tiling/backface-preserve-3d-tiled.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateSublayerList):

LayoutTests:

Pixel test that tests backface-visibility on a tile cache layer. Mark the test as
failing on Chromium.

* compositing/tiling/backface-preserve-3d-tiled-expected.png: Added.
* compositing/tiling/backface-preserve-3d-tiled-expected.txt: Added.
* compositing/tiling/backface-preserve-3d-tiled.html: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate mozilla's CheckedInt.h to the latest version
zmo@google.com [Wed, 24 Oct 2012 20:33:56 +0000 (20:33 +0000)]
Update mozilla's CheckedInt.h to the latest version
https://bugs.webkit.org/show_bug.cgi?id=100177

Reviewed by Kenneth Russell.

* html/canvas/CheckedInt.h: Sync with mozilla's copy with minumum modifications.
(detail):
(IsSupportedPass2):
(IsSupported):
(UnsignedType):
(IsSigned):
(TwiceBiggerType):
(PositionOfSignBit):
(MinValue):
(MaxValue):
(WebCore::detail::HasSignBit):
(WebCore::detail::BinaryComplement):
(WebCore::detail::IsInRange):
(WebCore::detail::IsAddValid):
(WebCore::detail::IsSubValid):
(WebCore::detail::IsMulValid):
(WebCore::detail::IsDivValid):
(WebCore::detail::OppositeIfSignedImpl::run):
(WebCore::detail::OppositeIfSigned):
(WebCore):
(CheckedInt):
(WebCore::CheckedInt::CheckedInt):
(WebCore::CheckedInt::value):
(WebCore::CheckedInt::isValid):
(WebCore::CheckedInt::operator -):
(WebCore::CheckedInt::operator ==):
(WebCore::CheckedInt::operator++):
(WebCore::CheckedInt::operator--):
(CastToCheckedIntImpl):
(WebCore::detail::CastToCheckedIntImpl::run):
(WebCore::castToCheckedInt):
(WebCore::operator ==):
* html/canvas/DataView.cpp: change valid() to isValid().
(WebCore::DataView::create):
* html/canvas/WebGLBuffer.cpp: Ditto.
(WebCore::WebGLBuffer::associateBufferDataImpl):
(WebCore::WebGLBuffer::associateBufferSubDataImpl):
* html/canvas/WebGLRenderingContext.cpp: Ditto.
(WebCore):
(WebCore::WebGLRenderingContext::drawArrays):
* platform/graphics/GraphicsContext3D.cpp: Ditto.
(WebCore::GraphicsContext3D::computeImageSizeInBytes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCoordinated Graphics: Enable threaded/IPC animations
noam.rosenthal@nokia.com [Wed, 24 Oct 2012 20:33:14 +0000 (20:33 +0000)]
Coordinated Graphics: Enable threaded/IPC animations
https://bugs.webkit.org/show_bug.cgi?id=93146

Reviewed by Caio Marcelo de Oliveira Filho.

In some cases there are pending changes in the layers, but no actual changes to the frame.
In that case we should unlock the animations.

* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size...
zhajiang@rim.com [Wed, 24 Oct 2012 20:31:05 +0000 (20:31 +0000)]
[BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size change [Part II]
https://bugs.webkit.org/show_bug.cgi?id=100259

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>.

PR: 219666
Revert "[BlackBerry] [FullScreen] entering/leaving fullscreen results in temporary glitches on the screen"
This rolls out r128772.
The patches relies on the viewport size change of the client side to
resume the screen and backing store updates. However, some client
sides don't need or wish to resize the WebKit viewport at all which
will result in upexpected screen and backing store suspensions.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size...
zhajiang@rim.com [Wed, 24 Oct 2012 20:30:39 +0000 (20:30 +0000)]
[BlackBerry][Fullscreen] Roll out changes to fullscreen which rely on viewport size change
https://bugs.webkit.org/show_bug.cgi?id=100259

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>.

PR: 219666
Roll out r130392 and r129909.
The patches rely on the viewport size change of the client side to
update the scale and scroll position of the video. However, some client
sides don't need or wish to resize the WebKit viewport at all.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt-on-Mac] GraphicsSurfaces should not create a global IOSurface handle
noam.rosenthal@nokia.com [Wed, 24 Oct 2012 20:20:59 +0000 (20:20 +0000)]
[Qt-on-Mac] GraphicsSurfaces should not create a global IOSurface handle
https://bugs.webkit.org/show_bug.cgi?id=89885

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use mach_port instead of global tokens for IOSurfaces.
Global IOSurfaces are accessible from other processes using their handle, while mach_ports
can only be shared directly via IPC.

Tested by existing WebGL tests.

* platform/graphics/surfaces/GraphicsSurfaceToken.h:
(GraphicsSurfaceToken):
* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):

Source/WebKit2:

Use mach_port instead of global tokens for IOSurfaces.
Global IOSurfaces are accessible from other processes, while mach_ports can only be shared
directly via IPC.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoimage-set doesn't round-trip properly with cssText
commit-queue@webkit.org [Wed, 24 Oct 2012 20:18:36 +0000 (20:18 +0000)]
image-set doesn't round-trip properly with cssText
https://bugs.webkit.org/show_bug.cgi?id=99725

Patch by Rick Byers <rbyers@chromium.org> on 2012-10-24
Reviewed by Beth Dakin.

Source/WebCore:

Fix serialization of -webkit-image-set rules to use the same format as
is used for parsing.

Test: fast/css/image-set-setting.html

* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::customCssText):
* css/CSSValueList.h:
(WebCore::CSSValueList::item): Add const overload

LayoutTests:

Update image-set-setting test to expect the css text to round-trip properly.

* fast/css/image-set-setting-expected.txt:
* fast/css/script-tests/image-set-setting.js:
(testComputedStyle):
(testImageSetRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBlackBerry fix for webgl-depth-texture.html
commit-queue@webkit.org [Wed, 24 Oct 2012 20:15:55 +0000 (20:15 +0000)]
BlackBerry fix for webgl-depth-texture.html
https://bugs.webkit.org/show_bug.cgi?id=100258

Patch by Jonathan Feldstein <jfeldstein@rim.com> on 2012-10-24
Reviewed by Yong Li.

Removed a platform specific define that is unnecessary.

* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd per destination ID message receivers
andersca@apple.com [Wed, 24 Oct 2012 19:31:16 +0000 (19:31 +0000)]
Add per destination ID message receivers
https://bugs.webkit.org/show_bug.cgi?id=100276

Reviewed by Andreas Kling.

Extend MessageReceiverMap to handle adding message receivers for a given destinationID/receiver name pair.
Use this to make every WebPage object a message receiver.

* Platform/CoreIPC/MessageReceiverMap.cpp:
(CoreIPC::MessageReceiverMap::addMessageReceiver):
(CoreIPC):
(CoreIPC::MessageReceiverMap::removeMessageReceiver):
(CoreIPC::MessageReceiverMap::invalidate):
(CoreIPC::MessageReceiverMap::dispatchMessage):
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):
* Platform/CoreIPC/MessageReceiverMap.h:
(MessageReceiverMap):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::addMessageReceiver):
(WebKit):
(WebKit::WebProcess::removeMessageReceiver):
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::didReceiveMessage):
* WebProcess/WebProcess.h:
(WebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCreate skia_webkit.gyp to improve rebaselining.
commit-queue@webkit.org [Wed, 24 Oct 2012 19:31:09 +0000 (19:31 +0000)]
Create skia_webkit.gyp to improve rebaselining.
https://bugs.webkit.org/show_bug.cgi?id=99759

Patch by Ben Wagner <bungeman@chromium.org> on 2012-10-24
Reviewed by Dirk Pranke.

This allows for code suppressions to be lifted atomically with new baselines.

* skia_webkit.gyp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHonor image orientation in GraphicsContextSkia
thakis@chromium.org [Wed, 24 Oct 2012 19:30:45 +0000 (19:30 +0000)]
Honor image orientation in GraphicsContextSkia
https://bugs.webkit.org/show_bug.cgi?id=100179

Reviewed by Stephen White.

Also fix a bug in ImageOrientation.h: Some of the values were
switched. They now match the description in the exif spec at
http://www.exif.org/Exif2-2.PDF page 18, and the notes at
http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/EXIF.html and
the picture at http://www.80sidea.com/archives/2316.

They showed up correctly in Safari because the orientation transform
was done after flipping Y. Let the flipping happen later. I verified
that flipping transformation order and fixing the exif enum cancelled
each other out, so this has no effect on the apple port.

Not hooked up yet, so no observable difference.

* platform/graphics/BitmapImage.h:
* platform/graphics/ImageOrientation.h:
(WebCore::ImageOrientation::usesWidthAsHeight):
(WebCore::ImageOrientation::fromEXIFValue):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::paintSkBitmap):
(WebCore::BitmapImage::draw):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Fixed Windows path for SharedWorkerStrategy.h - it's in workers/, not platform/.
ap@apple.com [Wed, 24 Oct 2012 19:17:06 +0000 (19:17 +0000)]
    Fixed Windows path for SharedWorkerStrategy.h - it's in workers/, not platform/.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 24 Oct 2012 19:10:35 +0000 (19:10 +0000)]
Unreviewed GTK gardening.

Rebaselining two Video Track tests after r132349.

* platform/gtk/media/track/track-cue-rendering-horizontal-expected.txt:
* platform/gtk/media/track/track-cue-rendering-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX: WebKit exposes abstract ARIA role range as AXSlider; should be generic AXGroup
cfleizach@apple.com [Wed, 24 Oct 2012 19:02:57 +0000 (19:02 +0000)]
AX: WebKit exposes abstract ARIA role range as AXSlider; should be generic AXGroup
https://bugs.webkit.org/show_bug.cgi?id=100204

Reviewed by Beth Dakin.

Source/WebCore:

Remove the "range" role as a valid ARIA role.

Test: platform/mac/accessibility/aria-slider-value.html

* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):

LayoutTests:

Remove the aria-range.html test because the same functionality is covered in aria-slider.html
Rename aria-range-value to aria-slider-value and use the non-abstract role slider instead (and
move that to the general accessibility platform).

* accessibility/aria-slider-value-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-range-value-expected.txt.
* accessibility/aria-slider-value.html: Copied from LayoutTests/platform/mac/accessibility/aria-range-value.html.
* platform/mac/accessibility/aria-range-expected.txt: Removed.
* platform/mac/accessibility/aria-range-value-expected.txt: Removed.
* platform/mac/accessibility/aria-range-value.html: Removed.
* platform/mac/accessibility/aria-range.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake the Inspector WKView/WebView become the first responder when bringToFront is...
timothy@apple.com [Wed, 24 Oct 2012 19:00:50 +0000 (19:00 +0000)]
Make the Inspector WKView/WebView become the first responder when bringToFront is called.

https://bugs.webkit.org/show_bug.cgi?id=100209

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::bringToFront): Make the Inspector WebView become the first responder.

Source/WebKit2:

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformBringToFront): Make the Inspector WKView become the first responder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTurn PageLoad tests into simple performancetests, commit #1
zoltan@webkit.org [Wed, 24 Oct 2012 18:48:08 +0000 (18:48 +0000)]
Turn PageLoad tests into simple performancetests, commit #1
https://bugs.webkit.org/show_bug.cgi?id=99899

Reviewed by Ryosuke Niwa.

We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.

This is the #1 commit of the whole patch.

* PageLoad/svg/files/az-lizard_benji_park_01.svg: Removed.
* PageLoad/svg/files/bamboo_01.svg: Removed.
* SVG/AzLizardBenjiPark.html: Added.
* SVG/Bamboo.html: Added.
* SVG/resources: Added.
* SVG/resources/AzLizardBenjiPark.svg: Copied from PerformanceTests/PageLoad/svg/files/az-lizard_benji_park_01.svg.
* SVG/resources/Bamboo.svg: Copied from PerformanceTests/PageLoad/svg/files/bamboo_01.svg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Marking fast/media/w3c/test_media_queries.html as slow on
leviw@chromium.org [Wed, 24 Oct 2012 18:28:45 +0000 (18:28 +0000)]
Unreviewed gardening. Marking fast/media/w3c/test_media_queries.html as slow on
Chromium debug bots following r132352. It may still timeout...

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] SVG repaint issues
fmalita@chromium.org [Wed, 24 Oct 2012 18:13:57 +0000 (18:13 +0000)]
[Chromium] SVG repaint issues
https://bugs.webkit.org/show_bug.cgi?id=99874

Reviewed by Levi Weintraub.

Source/WebCore:

RenderSVGRoot::paintReplaced() converts the container offsets to a relative transform,
but in doing so it ends up accumulating subpixel rounding deltas twice: first for
adjustedPaintOffset and second in localToParentTransform(). If coordinates are on
half-pixel boundaries, the 2x rounding delta yields a full pixel drift and we end up
painting at the wrong location.

This can be avoided by using localToBorderBoxTransform() directly, which (unlike
localToParentTransform()) doesn't perform rounding.

No new tests: existing pixel results cover this change after rebaseline.

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):

LayoutTests:

* platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
* platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
* platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
* platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayout tests to verify scaled composited layers have crisp text
danakj@chromium.org [Wed, 24 Oct 2012 18:10:28 +0000 (18:10 +0000)]
Layout tests to verify scaled composited layers have crisp text
https://bugs.webkit.org/show_bug.cgi?id=96940

Reviewed by Adrienne Walker.

Chromium bug: crbug.com/149943

* compositing/text-on-scaled-layer-expected.html: Added.
* compositing/text-on-scaled-layer.html: Added.
* compositing/text-on-scaled-surface-expected.html: Added.
* compositing/text-on-scaled-surface.html: Added.
* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixing the Chromium build after typo in r132367.
leviw@chromium.org [Wed, 24 Oct 2012 18:08:17 +0000 (18:08 +0000)]
Fixing the Chromium build after typo in r132367.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Respect image orientation in image dragging code
thakis@chromium.org [Wed, 24 Oct 2012 18:02:49 +0000 (18:02 +0000)]
[chromium] Respect image orientation in image dragging code
https://bugs.webkit.org/show_bug.cgi?id=100200

Reviewed by Tony Chang.

Based on the corresponding code in DragImageMac.mm.  The image
rotation code isn't hooked up yet, so no observable effect for now.

* platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::createDragImageFromImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCode cleanup after r132165
msaboff@apple.com [Wed, 24 Oct 2012 18:00:33 +0000 (18:00 +0000)]
Code cleanup after r132165
https://bugs.webkit.org/show_bug.cgi?id=100135

Reviewed by Geoffrey Garen.

Fixed up some unneccesary and inefficient constructs in MarkupTokenBase.h.

Code clean up without functional changes, therefore no new tests.

* xml/parser/MarkupTokenBase.h:
(WebCore::MarkupTokenBase::beginEndTag): Changed argument to be const Vector<LChar, 32>&.
(WebCore::MarkupTokenBase::appendToCharacter): Changed argument to be const Vector<LChar, 32>&.
(WebCore::MarkupTokenBase::appendToName): Elimintated inline.
(WebCore::MarkupTokenBase::name): Elimintated inline.
(WebCore::MarkupTokenBase::nameString): Elimintated inline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreveiewed gardening. Fixing linter, marking 2 mathml tests as flaky crashers on...
leviw@chromium.org [Wed, 24 Oct 2012 17:56:50 +0000 (17:56 +0000)]
Unreveiewed gardening. Fixing linter, marking 2 mathml tests as flaky crashers on debug,
and adding passing Lion expectations for a third mathml test.

* platform/chromium/TestExpectations:
* platform/chromium-mac-lion/mathml/presentation/fenced-expected.png: Modified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash when trying to write exception message to null console
commit-queue@webkit.org [Wed, 24 Oct 2012 17:55:30 +0000 (17:55 +0000)]
Crash when trying to write exception message to null console
https://bugs.webkit.org/show_bug.cgi?id=99658

Patch by Toni Barzic <tbarzic@chromium.org> on 2012-10-24
Reviewed by Adam Barth.

Source/WebCore:

DOMWindow::console may return NULL, so we should do a NULL check before adding message to it.
This may happen e.g. if a worker throws an exception just as the document is being replaced in the view.
The exception task could be processes after current window in the frame changes, and console in the document window is nulled.

Test: fast/workers/worker-exception-during-navigation.html

* dom/Document.cpp:
(WebCore::Document::addMessage):

LayoutTests:

The test creates bunch of workers that throw an exception as soon as they are loaded and then tries to change the current document.
The test passes if there is no crash.
Unfortuantely, the test is inherently flaky and may produce some false positive results (but should never fail if there is no bug).

* fast/workers/resources/worker-exception.js: Added.
* fast/workers/worker-exception-during-navigation-expected.txt: Added.
* fast/workers/worker-exception-during-navigation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Use include paths relative to Source/ in the TestRunner's public API
jochen@chromium.org [Wed, 24 Oct 2012 17:44:06 +0000 (17:44 +0000)]
[chromium] Use include paths relative to Source/ in the TestRunner's public API
https://bugs.webkit.org/show_bug.cgi?id=100079

Reviewed by Adam Barth.

For a inside-chromium build, we usually don't add the WebKit API paths
as include paths, so including files by name only does not work.

Eventually we might want to move to a model where all includes are
relative to Source/, so we're using that here already now.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/chromium/TestRunner/public/WebEventSender.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShow an error when there are no completed builds in the past 20 runs
ojan@chromium.org [Wed, 24 Oct 2012 17:36:32 +0000 (17:36 +0000)]
Show an error when there are no completed builds in the past 20 runs
https://bugs.webkit.org/show_bug.cgi?id=100266

Reviewed by Dimitri Glazkov.

Right now we get a cryptic JS error in the console when loading the gtk port. This at least gives an error in
the notification stream. We should probably tweak this UI to make it so we can make
errors in the notification stream stick out (e.g. make the text red).

We should also consider making the number of runs to load dynamic (e.g. if 20 runs don't work,
try 40).

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncorrect conditional use of LogFTP
commit-queue@webkit.org [Wed, 24 Oct 2012 17:29:50 +0000 (17:29 +0000)]
Incorrect conditional use of LogFTP
https://bugs.webkit.org/show_bug.cgi?id=100260

Patch by Cosmin Truta <ctruta@rim.com> on 2012-10-24
Reviewed by Alexey Proskuryakov.

Use LogFTP if !LOG_DISABLED, to allow toggling ASSERTIONS_DISABLED_DEFAULT
without breaking the build.

* html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocument::FTPDirectoryDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Add a strategy for shared workers
ap@apple.com [Wed, 24 Oct 2012 17:28:14 +0000 (17:28 +0000)]
    Add a strategy for shared workers
        https://bugs.webkit.org/show_bug.cgi?id=100165

        Reviewed by Brady Eidson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove a few more WebProcess sub-objects to be MessageReceivers
weinig@apple.com [Wed, 24 Oct 2012 17:22:19 +0000 (17:22 +0000)]
Move a few more WebProcess sub-objects to be MessageReceivers
https://bugs.webkit.org/show_bug.cgi?id=100186

Reviewed by Anders Carlsson.

* WebProcess/Battery/WebBatteryManager.cpp:
(WebKit::WebBatteryManager::WebBatteryManager):
* WebProcess/Battery/WebBatteryManager.h:
(WebBatteryManager):
* WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::WebIconDatabaseProxy):
(WebKit):
* WebProcess/IconDatabase/WebIconDatabaseProxy.h:
(WebIconDatabaseProxy):
* WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:
(WebKit::WebNetworkInfoManager::WebNetworkInfoManager):
* WebProcess/NetworkInfo/WebNetworkInfoManager.h:
(WebNetworkInfoManager):
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::WebNotificationManager):
* WebProcess/Notifications/WebNotificationManager.h:
(WebNotificationManager):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
* WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::WebSoupRequestManager):
* WebProcess/soup/WebSoupRequestManager.h:
(WebSoupRequestManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[MathML] Timeouts on linux after r132264
dbarton@mathscribe.com [Wed, 24 Oct 2012 17:20:41 +0000 (17:20 +0000)]
[MathML] Timeouts on linux after r132264
https://bugs.webkit.org/show_bug.cgi?id=100202

Reviewed by Eric Seidel.

Source/WebCore:

When building a stretched operator, such as a large parenthesis or bracket, we need to
check that the extension glyph's height is > 0, to avoid an infinite loop. The 0 height
can occur if the glyph is missing on the host system.

Tested by existing tests.

* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):

LayoutTests:

The failing tests no longer timeout.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Explicitly disable accelerated animations in DRT
vollick@chromium.org [Wed, 24 Oct 2012 17:02:11 +0000 (17:02 +0000)]
[chromium] Explicitly disable accelerated animations in DRT
https://bugs.webkit.org/show_bug.cgi?id=100241

Reviewed by Adrienne Walker.

Disable accelerated animations by default in DRT.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::setAcceleratedAnimationEnabled):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Typos in user-visible strings: "coordintate"
commit-queue@webkit.org [Wed, 24 Oct 2012 16:43:55 +0000 (16:43 +0000)]
[GTK] Typos in user-visible strings: "coordintate"
https://bugs.webkit.org/show_bug.cgi?id=100252

Patch by Priit Laes <plaes@plaes.org> on 2012-10-24
Reviewed by Martin Robinson.

s/coordintate/coordinate

* webkit/webkithittestresult.cpp:
(webkit_hit_test_result_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r131982): Skip SVG/SvgNestedUse.html performancetest since it is crashing
zoltan@webkit.org [Wed, 24 Oct 2012 16:23:22 +0000 (16:23 +0000)]
REGRESSION(r131982): Skip SVG/SvgNestedUse.html performancetest since it is crashing
https://bugs.webkit.org/show_bug.cgi?id=100262

Unreviewed.

Skip until proper fix.

* Skipped: Add SVG/SvgNestedUse.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoencode should take an ArgumentEncoder reference
andersca@apple.com [Wed, 24 Oct 2012 16:18:05 +0000 (16:18 +0000)]
encode should take an ArgumentEncoder reference
https://bugs.webkit.org/show_bug.cgi?id=100183

Reviewed by Jessie Berlin.

* Platform/CoreIPC/ArgumentCoder.h:
(CoreIPC::ArgumentCoder::encode):
* Platform/CoreIPC/Arguments.h:
(CoreIPC::Arguments0::encode):
(CoreIPC::Arguments1::encode):
(CoreIPC::Arguments2::encode):
(CoreIPC::Arguments3::encode):
(CoreIPC::Arguments4::encode):
(CoreIPC::Arguments5::encode):
(CoreIPC::Arguments6::encode):
(CoreIPC::Arguments7::encode):
(CoreIPC::Arguments8::encode):
(CoreIPC::Arguments10::encode):
* Platform/CoreIPC/Attachment.cpp:
(CoreIPC::Attachment::encode):
* Platform/CoreIPC/Attachment.h:
(Attachment):
* Platform/CoreIPC/DataReference.cpp:
(CoreIPC::DataReference::encode):
* Platform/CoreIPC/DataReference.h:
(DataReference):
* Platform/CoreIPC/StringReference.cpp:
(CoreIPC::StringReference::encode):
* Platform/CoreIPC/StringReference.h:
(StringReference):
* Platform/CoreIPC/mac/MachPort.h:
(CoreIPC::MachPort::encode):
* Platform/SharedMemory.h:
(Handle):
* Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::Handle::encode):
* PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::encode):
* PluginProcess/PluginCreationParameters.h:
(PluginCreationParameters):
* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
* Shared/DictionaryPopupInfo.h:
(DictionaryPopupInfo):
* Shared/EditorState.cpp:
(WebKit::EditorState::encode):
* Shared/EditorState.h:
(EditorState):
* Shared/FontInfo.cpp:
(WebKit::FontInfo::encode):
* Shared/FontInfo.h:
(FontInfo):
* Shared/LayerTreeContext.h:
(LayerTreeContext):
* Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode):
* Shared/Network/NetworkProcessCreationParameters.h:
(NetworkProcessCreationParameters):
* Shared/OriginAndDatabases.cpp:
(WebKit::OriginAndDatabases::encode):
* Shared/OriginAndDatabases.h:
(OriginAndDatabases):
* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
* Shared/PlatformPopupMenuData.h:
(PlatformPopupMenuData):
* Shared/Plugins/NPIdentifierData.cpp:
(WebKit::NPIdentifierData::encode):
* Shared/Plugins/NPIdentifierData.h:
(NPIdentifierData):
* Shared/Plugins/NPVariantData.cpp:
(WebKit::NPVariantData::encode):
* Shared/Plugins/NPVariantData.h:
(NPVariantData):
* Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::encode):
* Shared/Plugins/PluginProcessCreationParameters.h:
(PluginProcessCreationParameters):
* Shared/PrintInfo.cpp:
(WebKit::PrintInfo::encode):
* Shared/PrintInfo.h:
(PrintInfo):
* Shared/SandboxExtension.h:
(Handle):
(HandleArray):
* Shared/SecurityOriginData.cpp:
(WebKit::SecurityOriginData::encode):
* Shared/SecurityOriginData.h:
(SecurityOriginData):
* Shared/SessionState.cpp:
(WebKit::SessionState::encode):
* Shared/SessionState.h:
(SessionState):
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::Handle::encode):
* Shared/ShareableBitmap.h:
(Handle):
* Shared/SharedWorkerProcessCreationParameters.cpp:
(WebKit::SharedWorkerProcessCreationParameters::encode):
* Shared/SharedWorkerProcessCreationParameters.h:
(SharedWorkerProcessCreationParameters):
* Shared/StatisticsData.cpp:
(WebKit::StatisticsData::encode):
* Shared/StatisticsData.h:
(StatisticsData):
* Shared/StringPairVector.h:
(WebKit::StringPairVector::encode):
* Shared/UpdateInfo.cpp:
(WebKit::UpdateInfo::encode):
* Shared/UpdateInfo.h:
(UpdateInfo):
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
* Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::encode):
* Shared/WebContextMenuItemData.h:
(WebContextMenuItemData):
* Shared/WebEvent.cpp:
(WebKit::WebEvent::encode):
* Shared/WebEvent.h:
(WebEvent):
(WebMouseEvent):
(WebWheelEvent):
(WebKeyboardEvent):
(WebGestureEvent):
(WebPlatformTouchPoint):
(WebTouchEvent):
* Shared/WebGeolocationPosition.cpp:
(WebKit::WebGeolocationPosition::Data::encode):
* Shared/WebGeolocationPosition.h:
(Data):
* Shared/WebGestureEvent.cpp:
(WebKit::WebGestureEvent::encode):
* Shared/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::Data::encode):
* Shared/WebHitTestResult.h:
(Data):
* Shared/WebKeyboardEvent.cpp:
(WebKit::WebKeyboardEvent::encode):
* Shared/WebMouseEvent.cpp:
(WebKit::WebMouseEvent::encode):
* Shared/WebNavigationDataStore.h:
(WebKit::WebNavigationDataStore::encode):
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
* Shared/WebPageCreationParameters.h:
(WebPageCreationParameters):
* Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::encode):
* Shared/WebPageGroupData.h:
(WebPageGroupData):
* Shared/WebPopupItem.cpp:
(WebKit::WebPopupItem::encode):
* Shared/WebPopupItem.h:
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::encode):
* Shared/WebPreferencesStore.h:
(WebPreferencesStore):
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::encode):
* Shared/mac/AttributedString.h:
(AttributedString):
* Shared/mac/AttributedString.mm:
(WebKit::AttributedString::encode):
* Shared/mac/ColorSpaceData.h:
(ColorSpaceData):
* Shared/mac/ColorSpaceData.mm:
(WebKit::ColorSpaceData::encode):
* Shared/mac/LayerTreeContextMac.mm:
(WebKit::LayerTreeContext::encode):
* Shared/mac/PlatformCertificateInfo.h:
(PlatformCertificateInfo):
* Shared/mac/PlatformCertificateInfo.mm:
(WebKit::PlatformCertificateInfo::encode):
* Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::Handle::encode):
(WebKit::SandboxExtension::HandleArray::encode):
* Shared/mac/SecItemRequestData.cpp:
(WebKit::SecItemRequestData::encode):
* Shared/mac/SecItemRequestData.h:
* Shared/mac/SecItemResponseData.cpp:
(WebKit::SecItemResponseData::encode):
* Shared/mac/SecItemResponseData.h:
(SecItemResponseData):
* Shared/mac/SecKeychainItemRequestData.cpp:
(WebKit::SecKeychainItemRequestData::encode):
* Shared/mac/SecKeychainItemRequestData.h:
* Shared/mac/SecKeychainItemResponseData.cpp:
(WebKit::SecKeychainItemResponseData::encode):
* Shared/mac/SecKeychainItemResponseData.h:
(SecKeychainItemResponseData):
* UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::encode):
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageEncoder::encode):
* WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::encode):
* WebProcess/Plugins/Plugin.h:
(Parameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
commit-queue@webkit.org [Wed, 24 Oct 2012 15:30:28 +0000 (15:30 +0000)]
[BlackBerry] Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=100250

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-10-24
Reviewed by Rob Buis.

Source/WebKit:

Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
to prevent confusion.

PR 230196

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Rename GeolocationControllerClientBlackBerry to GeolocationClientBlackBerry
to prevent confusion.
PR 230196

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
* Api/WebPage_p.h:
(WebCore):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
* WebCoreSupport/GeolocationClientBlackBerry.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.cpp.
(frameOrigin):
(GeolocationClientBlackBerry::GeolocationClientBlackBerry):
(GeolocationClientBlackBerry::geolocationDestroyed):
(GeolocationClientBlackBerry::startUpdating):
(GeolocationClientBlackBerry::stopUpdating):
(GeolocationClientBlackBerry::lastPosition):
(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::cancelPermissionRequest):
(GeolocationClientBlackBerry::onLocationUpdate):
(GeolocationClientBlackBerry::onLocationError):
(GeolocationClientBlackBerry::onPermission):
(GeolocationClientBlackBerry::setEnableHighAccuracy):
* WebCoreSupport/GeolocationClientBlackBerry.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/GeolocationControllerClientBlackBerry.h.
(WebKit):
(WebCore):
(GeolocationClientBlackBerry):
(WebCore::GeolocationClientBlackBerry::tracker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Move the QQuickWebViewExperimental pointer to QQuickWebViewPrivate
jocelyn.turcotte@digia.com [Wed, 24 Oct 2012 15:28:37 +0000 (15:28 +0000)]
[Qt] Move the QQuickWebViewExperimental pointer to QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=100253

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

We'll need to avoid placing data in QQuickWebView to preserve
its binary compatibility once it's public.
Also make the QQuickWebViewExperimental constructor private.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewExperimental::QQuickWebViewExperimental):
(QQuickWebView::QQuickWebView):
(QQuickWebView::experimental):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):

Tools:

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
Use QQuickWebView::experimental rather than creating a new instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Extending existing ThreadUnsafe singletons in webkit to
commit-queue@webkit.org [Wed, 24 Oct 2012 15:28:27 +0000 (15:28 +0000)]
[BlackBerry] Extending existing ThreadUnsafe singletons in webkit to
Generic ThreadUnsafe Singleton
https://bugs.webkit.org/show_bug.cgi?id=100145

Patch by Parth Patel <parpatel@rim.com> on 2012-10-24
Reviewed by Rob Buis.

Extending the singletons to generic singleton and changing
getInstance() in IconDatabaseClientBlackBerry to instance()
to match the generic singleton template.

Reviewed Internally by Yong Li.

Source/WebCore:

Tests are not modified and added as there was no behavioural change.

* platform/blackberry/SharedTimerBlackBerry.cpp:
(SharedTimerBlackBerry):
(WebCore):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::initializeIconDataBase):
* WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
(WebCore):
* WebCoreSupport/IconDatabaseClientBlackBerry.h:
(IconDatabaseClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: NMI add instrumentation for ResourceBuffer. It gives us 10mb on gmail
loislo@chromium.org [Wed, 24 Oct 2012 15:08:24 +0000 (15:08 +0000)]
Web Inspector: NMI add instrumentation for ResourceBuffer. It gives us 10mb on gmail
https://bugs.webkit.org/show_bug.cgi?id=100254

Reviewed by Yury Semikhatsky.

* loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::reportMemoryUsage):
(WebCore):
* loader/ResourceBuffer.h:
(ResourceBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow ports to override text track rendering style
eric.carlson@apple.com [Wed, 24 Oct 2012 15:04:40 +0000 (15:04 +0000)]
Allow ports to override text track rendering style
https://bugs.webkit.org/show_bug.cgi?id=97800
<rdar://problem/12044964>

Unreviewed Build fix.

CGFloat is already a float in a 32-bit build so narrowPrecisionToFloat() is unnecessary

* page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::captionFontSizeScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] ./configure output for CSS Shaders is broken
commit-queue@webkit.org [Wed, 24 Oct 2012 14:51:47 +0000 (14:51 +0000)]
[GTK] ./configure output for CSS Shaders is broken
https://bugs.webkit.org/show_bug.cgi?id=100217

Patch by Priit Laes <plaes@plaes.org> on 2012-10-24
Reviewed by Martin Robinson.

Reformat CSS Filters / Shaders check to clean configure output.

* configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Ewk_Settings refactoring
commit-queue@webkit.org [Wed, 24 Oct 2012 14:42:54 +0000 (14:42 +0000)]
[EFL][WK2] Ewk_Settings refactoring
https://bugs.webkit.org/show_bug.cgi?id=100233

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Ewk_Settings private implementation is now C++ class which allows direct internal
access to WebKit::WebPreferences.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
* UIProcess/API/efl/ewk_settings.cpp:
(Ewk_Settings::preferences):
(ewk_settings_fullscreen_enabled_set):
(ewk_settings_fullscreen_enabled_get):
(ewk_settings_javascript_enabled_set):
(ewk_settings_javascript_enabled_get):
(ewk_settings_loads_images_automatically_set):
(ewk_settings_loads_images_automatically_get):
(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):
(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):
(ewk_settings_frame_flattening_enabled_set):
(ewk_settings_frame_flattening_enabled_get):
(ewk_settings_dns_prefetching_enabled_set):
(ewk_settings_dns_prefetching_enabled_get):
* UIProcess/API/efl/ewk_settings_private.h:
(WebKit):
(Ewk_Settings):
(Ewk_Settings::Ewk_Settings):
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][AC] Fix build break when AC is enabled
dominik.rottsches@intel.com [Wed, 24 Oct 2012 14:41:19 +0000 (14:41 +0000)]
[EFL][AC] Fix build break when AC is enabled
https://bugs.webkit.org/show_bug.cgi?id=100245

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Fix build break after r132337.

* UIProcess/API/efl/EwkViewImpl.h:
* UIProcess/API/efl/ewk_view.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS3 Media Queries - add resolution tests to W3C test suite
commit-queue@webkit.org [Wed, 24 Oct 2012 14:38:11 +0000 (14:38 +0000)]
CSS3 Media Queries - add resolution tests to W3C test suite
https://bugs.webkit.org/show_bug.cgi?id=100231

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Resolution media feature was implemented, therefore,
W3C tests are added back to the test suite.

* fast/media/w3c/test_media_queries-expected.txt:
* fast/media/w3c/test_media_queries.html:

Created platform specific expectations for the platforms that have RESOLUTION_MEDIA_QUERY disabled.

* platform/blackberry/fast/media/w3c/test_media_queries-expected.txt: Added.
* platform/chromium/fast/media/w3c/test_media_queries-expected.txt: Added.
* platform/gtk/fast/media/w3c/test_media_queries-expected.txt: Added.
* platform/mac/fast/media/w3c/test_media_queries-expected.txt: Added.
* platform/win/fast/media/w3c/test_media_queries-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 24 Oct 2012 14:34:18 +0000 (14:34 +0000)]
[EFL] Unreviewed gardening.

* platform/efl-wk1/TestExpectations: Marking shadow-dom failures after r132303
* platform/efl-wk2/TestExpectations: Marking focus failure after r132342 and drag-select failure between r132333-r132343.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] run-webkit-tests writes garbage on stderr when running on Xvfb
commit-queue@webkit.org [Wed, 24 Oct 2012 14:33:47 +0000 (14:33 +0000)]
[EFL] run-webkit-tests writes garbage on stderr when running on Xvfb
https://bugs.webkit.org/show_bug.cgi?id=100243

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

.:

Search for X11 development libraries (and thus Xext), necessary to
disable the X extensions error reporting.

* Source/cmake/OptionsEfl.cmake:

Source/WebKit2:

These errors generate noise on the reports and in some cases, like when
running perf tests, makes the test fail. By using Xext, we can add a
dummy handler to ignore these errors.

* PlatformEfl.cmake:
* WebProcess/efl/WebProcessMainEfl.cpp:
(dummyExtensionErrorHandler):
(WebKit::WebProcessMainEfl):

Tools:

These errors generate noise on the reports and in some cases, like when
running perf tests, makes the test fail. By using Xext, we can add a
dummy handler to ignore these errors.

We could have added this handler on the top level EWK API, but that
would be intrusive and could override handlers defined by the user.

* WebKitTestRunner/PlatformEfl.cmake:
* WebKitTestRunner/efl/main.cpp:
(dummyExtensionErrorHandler):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow ports to override text track rendering style
eric.carlson@apple.com [Wed, 24 Oct 2012 14:24:43 +0000 (14:24 +0000)]
Allow ports to override text track rendering style
https://bugs.webkit.org/show_bug.cgi?id=97800
<rdar://problem/12044964>

Reviewed by Maciej Stachowiak.

Source/WebCore:

* WebCore.exp.in: Export new WebkitSystemInterface functions.
* WebCore.xcodeproj/project.pbxproj: Add CaptionUserPreferences.h, CaptionUserPreferencesMac.mm,
    and CaptionUserPreferencesMac.h.

* css/mediaControls.css: Rearrange the caption CSS so it is possible to style the cue window,
    background, and text independently.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_disableCaptions with theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::attach): Register for caption preferences change callbacks.
(WebCore::HTMLMediaElement::detach): Unregister for caption preferences change callbacks.
(WebCore::HTMLMediaElement::userPrefersCaptions): Return theme->userPrefersCaptions().
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Consider userPrefersCaptions().
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Move the code that marks all tracks as
    un-configured to markCaptionAndSubtitleTracksAsUnconfigured so it can be reused.
(WebCore::HTMLMediaElement::captionPreferencesChanged): New, force a reevaluation of all text tracks.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): New, code moved from
    setClosedCaptionsVisible
* html/HTMLMediaElement.h: Inherit from CaptionPreferencesChangedListener.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Get rid of unnecessary member
    variable. Get caption font scale from theme instead of hard coding.
* html/shadow/MediaControlElements.h:

* html/track/TextTrack.cpp:
(WebCore::TextTrack::TextTrack): Change attributes from String to AtomicString.
(WebCore::TextTrack::isValidKindKeyword): Ditto.
(WebCore::TextTrack::setKind): Ditto.
(WebCore::TextTrack::setMode): Ditto.
(WebCore::TextTrack::mode): Ditto.
* html/track/TextTrack.h:
(WebCore::TextTrack::create): Ditto.
(WebCore::TextTrack::kind): Ditto.
(WebCore::TextTrack::label): Ditto.
(WebCore::TextTrack::setLabel): Ditto.
(WebCore::TextTrack::language): Ditto.
(WebCore::TextTrack::setLanguage): Ditto.

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::TextTrackCueBox): Set the shadow pseudo id.
(WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId): New, class method to return the
    shadow pseudo id so it can be used elsewhere.
(WebCore::TextTrackCueBox::shadowPseudoId): Call textTrackCueBoxShadowPseudoId.
(WebCore::TextTrackCue::pastNodesShadowPseudoId): New, class method to return the
    shadow pseudo id so it can be used elsewhere.
(WebCore::TextTrackCue::futureNodesShadowPseudoId): Ditto.
(WebCore::TextTrackCue::updateDisplayTree):
* html/track/TextTrackCue.h:

* page/CaptionUserPreferences.h: Added.
* page/CaptionUserPreferencesMac.h: Added.
* page/CaptionUserPreferencesMac.mm: Added.
(WebCore::userCaptionPreferencesChangedNotificationCallback):
(WebCore::CaptionUserPreferencesMac::CaptionUserPreferencesMac):
(WebCore::CaptionUserPreferencesMac::~CaptionUserPreferencesMac):
(WebCore::CaptionUserPreferencesMac::userHasCaptionPreferences): New, passthrough to WKSI function.
(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferencesMac::captionsWindowColor): Return Color with user's caption window color preference.
(WebCore::CaptionUserPreferencesMac::captionsBackgroundColor): Return Color with user's caption
    background color preference.
(WebCore::CaptionUserPreferencesMac::captionsTextColor): Return Color with user's caption text color preference.
(WebCore::CaptionUserPreferencesMac::captionsEdgeColorForTextColor): Return Color for text edge effect.
(WebCore::CaptionUserPreferencesMac::cssPropertyWithTextEdgeColor): Return String with CSS to set a text-shadow
    or webkit-text-stroke property.
(WebCore::CaptionUserPreferencesMac::cssColorProperty): Return a String with css to set a property
    with a color value.
(WebCore::CaptionUserPreferencesMac::captionsTextEdgeStyle): Return a String with css to style caption
    text with the user's preferred text edge stye.
(WebCore::CaptionUserPreferencesMac::captionsDefaultFont): Return a String with css to style caption
    text with the user's preferred font.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Return a String with css to style captions
    with the user's preferred style.
(WebCore::CaptionUserPreferencesMac::captionFontSizeScale): Return the user's preferred caption font scale.
(WebCore::CaptionUserPreferencesMac::captionPreferencesChanged): Notify listeners of caption preference change.
(WebCore::CaptionUserPreferencesMac::registerForCaptionPreferencesChangedCallbacks): Add a caption preferences
    changes listener.
(WebCore::CaptionUserPreferencesMac::unregisterForCaptionPreferencesChangedCallbacks): Remove a caption preferences
    changes listener.
(WebCore::CaptionUserPreferencesMac::updateCaptionStyleSheetOveride): New, if theme has a captions style sheet override,
    inject it into the current page group, otherwise remove injected sheet.

* page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences):
(WebCore::PageGroup::registerForCaptionPreferencesChangedCallbacks): New, passthrough to platform specific function
    of the same name.
(WebCore::PageGroup::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::PageGroup::userPrefersCaptions): Ditto.
(WebCore::PageGroup::userHasCaptionPreferences): Ditto.
(WebCore::PageGroup::captionFontSizeScale): Ditto.
* page/PageGroup.h:

* platform/mac/WebCoreSystemInterface.h: Updated.
* platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Initialize new WKSI function pointers.

Source/WebKit2:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Initialize new WKSI function pointers.

WebKitLibraries:

Update WKSI header with SPI for getting the user caption appearance preferences.

* WebKitSystemInterface.h:

LayoutTests:

* media/track/track-cue-rendering-expected.txt: Update results for caption css changes.
* media/track/track-cue-rendering.html:
* platform/chromium/TestExpectations: Skip tests that need to be rebaselined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Introduce workspace provider as a content providing backend for project.
vsevik@chromium.org [Wed, 24 Oct 2012 14:19:32 +0000 (14:19 +0000)]
Web Inspector: Introduce workspace provider as a content providing backend for project.
https://bugs.webkit.org/show_bug.cgi?id=100244

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced WorkspaceProvider interface as a content providing backend for project.
Added NetworkWorkspaceProvider as a network based (default) implementation.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping):
* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):
* inspector/front-end/NetworkWorkspaceProvider.js: Added.
(WebInspector.NetworkWorkspaceProvider):
(WebInspector.NetworkWorkspaceProvider.prototype.requestFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.setFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.searchInFileContent):
(WebInspector.NetworkWorkspaceProvider.prototype.addFile):
(WebInspector.NetworkWorkspaceProvider.prototype.removeFile):
(WebInspector.NetworkWorkspaceProvider.prototype.reset):
* inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping):
(_bindUISourceCode):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/Workspace.js:
(WebInspector.FileDescriptor):
(WebInspector.WorkspaceProvider):
(WebInspector.WorkspaceProvider.prototype.requestFileContent):
(WebInspector.WorkspaceProvider.prototype.searchInFileContent):
(WebInspector.WorkspaceProvider.prototype.addEventListener):
(WebInspector.WorkspaceProvider.prototype.removeEventListener):
(WebInspector.Project):
(WebInspector.Project.prototype.reset):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.addProject):
(WebInspector.Workspace.prototype.project):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:
* http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
* inspector/debugger/network-uisourcecode-provider.html:
* inspector/debugger/script-snippet-model.html:
* inspector/debugger/scripts-panel.html:
* inspector/uisourcecode-revisions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Styles pane: Don't select whole value when I select just a part
commit-queue@webkit.org [Wed, 24 Oct 2012 13:54:46 +0000 (13:54 +0000)]
Web Inspector: Styles pane: Don't select whole value when I select just a part
https://bugs.webkit.org/show_bug.cgi?id=100242

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-10-24
Reviewed by Alexander Pavlov.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: UiSourceCode should rely on the workspace as a content provider.
vsevik@chromium.org [Wed, 24 Oct 2012 13:44:56 +0000 (13:44 +0000)]
Web Inspector: UiSourceCode should rely on the workspace as a content provider.
https://bugs.webkit.org/show_bug.cgi?id=100216

Reviewed by Pavel Feldman.

Source/WebCore:

Workspace is now passed to UISourceCode to be used as a content provider.
Content providers are now stored in the workspace/project.
Next step would be to move content providers to workspace providers.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.breakpointStorageId):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.contentType):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.requestOriginalContent):
(WebInspector.UISourceCode.prototype._commitContent):
(WebInspector.UISourceCode.prototype.searchInContent):
* inspector/front-end/Workspace.js:
(WebInspector.WorkspaceController.prototype._mainFrameNavigated):
(WebInspector.Project):
(WebInspector.Project.prototype.addUISourceCode):
(WebInspector.Project.prototype.removeUISourceCode):
(WebInspector.Project.prototype.uiSourceCodes):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.addTemporaryUISourceCode):
(WebInspector.Workspace.prototype.removeTemporaryUISourceCode):
(WebInspector.Workspace.prototype.reset):

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/script-formatter-search.html:
* inspector/debugger/scripts-file-selector.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting.html:
* inspector/debugger/ui-source-code-display-name.html:
* inspector/debugger/ui-source-code.html:
* inspector/uisourcecode-revisions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Expose useful WebCore::Settings
allan.jensen@digia.com [Wed, 24 Oct 2012 13:41:28 +0000 (13:41 +0000)]
[Qt] Expose useful WebCore::Settings
https://bugs.webkit.org/show_bug.cgi?id=100239

Reviewed by Kenneth Rohde Christiansen.

Expose the two settings CaretBrowsingEnabled and NotificationsEnabled.

Source/WebKit/qt:

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
* Api/qwebsettings.h:

Source/WebKit2:

* UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::caretBrowsingEnabled):
(QWebPreferences::setCaretBrowsingEnabled):
(QWebPreferences::notificationsEnabled):
(QWebPreferences::setNotificationsEnabled):
* UIProcess/API/qt/qwebpreferences_p.h:
* UIProcess/API/qt/qwebpreferences_p_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix the GTK+ build.
carlosgc@webkit.org [Wed, 24 Oct 2012 13:34:40 +0000 (13:34 +0000)]
Unreviewed. Fix the GTK+ build.

* TestWebKitAPI/GNUmakefile.am: Add GTK_FLAGS to
libTestWebKitAPIMain and webcore cflags to TestGtk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement GraphicsSurface for Windows.
zeno.albisser@digia.com [Wed, 24 Oct 2012 13:18:49 +0000 (13:18 +0000)]
Implement GraphicsSurface for Windows.
https://bugs.webkit.org/show_bug.cgi?id=98147

Source/WebCore:

Reviewed by Kenneth Rohde Christiansen.

* Target.pri:
    Include GraphicsSurfaceWin.cpp in SOURCES on Windows.
* platform/graphics/surfaces/GraphicsSurface.h:
    Add typedef for PlatformGraphicsSurface on Windows.
* platform/graphics/surfaces/GraphicsSurfaceToken.h:
    Add typedef for BufferHandle on Windows.
(GraphicsSurfaceToken):
* platform/graphics/surfaces/win/GraphicsSurfaceWin.cpp: Added.
    The GraphicsSurface implementation on Windows relies on the
    availability of ANGLE and the EGL_ANGLE_query_surface_pointer extension.
    For Qt this requirements are implicitly satisfied, when Qt is built
    on Windows and QT_CONFIG contains OpenGLES2.
    The GraphicsSurface then renders a given texture onto an offscreen
    pixel buffer surface, queries the surface pointer using the
    EGL_ANGLE_query_surface_pointer extension, and transmits the received
    surface pointer (share handle) over IPC.
    On the UIProcess side, the surface pointer can then be resolved
    using eglCreatePbufferFromClientBuffer.
(WebCore):
(WebCore::loadShader):
    Initialize the shaders needed for drawing onto the GraphicsSurface.
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
    In case of the instance being on the WebProcess side,
    create an EGLContext that shares the texture objects with the provided
    share context. Also create two pixel buffer surfaces, one as front- and
    one as backbuffer.
    Query the surface pointers for the pixel buffer surfaces and initialize
    the GraphicsSurfaceToken that can be passed over IPC later.
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
    Release all aquired resources and destroy the pixel buffer surfaces.
    Also close the EGL-Display connection.
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
    Make the belonging context current on the back buffer surface
    and use drawTexture() to draw the provided texture onto the GraphicsSurface.
(WebCore::GraphicsSurfacePrivate::makeCurrent):
    Save the previously current context, then make the context belonging
    to the GraphicsSurface current.
(WebCore::GraphicsSurfacePrivate::doneCurrent):
    Restore the context that was current before calling makeCurrent().
(WebCore::GraphicsSurfacePrivate::swapBuffers):
    Swap front and back buffer surfaces and handles.
(WebCore::GraphicsSurfacePrivate::token):
(WebCore::GraphicsSurfacePrivate::frontBufferTextureID):
    This function is meant to be called from the UIProcess side.
    If no front buffer surface has been created before for the current
    front buffer handle, one will be created.
    Then eglBindTexImage will be used to actually bind the current
    front buffer surface to a texture as a source for drawing.
(WebCore::GraphicsSurfacePrivate::initialFrontBufferShareHandle):
(WebCore::GraphicsSurfacePrivate::frontBufferShareHandle):
(WebCore::GraphicsSurfacePrivate::backBufferShareHandle):
(WebCore::GraphicsSurfacePrivate::releaseFrontBufferTexture):
    Free the resources related to the front buffer surface.
    On the UIProcess side we never actually bind the back buffer.
(WebCore::GraphicsSurfacePrivate::initializeShaderProgram):
    Initialize and link the shader programs necessary for drawing
    onto the GraphicsSurface.
(WebCore::GraphicsSurfacePrivate::createSurfaceFromShareHandle):
    Creates a single pixel buffer surface from a share Handle.
    This function will be called on the UIProcess side,
    for the front buffer handle, whenever the buffers have been swapped.
(WebCore::GraphicsSurfacePrivate::drawTexture):
    The WebProcess uses this function to draw a given
    texture onto the GraphicsSurface's back buffer.
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
    Uses TextureMapperGL::drawTexture() to draw the front buffer texture
    to the TextureMapper on the UIProcess side.
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):

Source/WebKit2:

Add encode and decode implementation for GraphicsSurfaceToken on Windows.

Reviewed by Kenneth Rohde Christiansen.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):

Tools:

Reviewed by Kenneth Rohde Christiansen.

* qmake/mkspecs/features/features.prf:
        Activate GraphicsSurface on windows in case opengles2 (ANGLE)
        is available in QT_CONFIG.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] fast/repaint/delete-into-nested-block.html and fast/repaint/4776765.html...
rakuco@webkit.org [Wed, 24 Oct 2012 12:38:10 +0000 (12:38 +0000)]
[EFL][WK2] fast/repaint/delete-into-nested-block.html and fast/repaint/4776765.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=100010

Reviewed by Kenneth Rohde Christiansen.

Force the main view to receive focus even if Evas already
considers it to be focused.

It might happen that a different frame is focused by a page and
the focus change notification does not reach Evas. When another
test is run, the main frame is then not considered to be focused
by WebCore, and things such as focus rings are not drawn as
expected.

* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::focus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Hopefully finish rebaselining after r131941 and r131991.
rakuco@webkit.org [Wed, 24 Oct 2012 12:31:51 +0000 (12:31 +0000)]
[EFL] Hopefully finish rebaselining after r131941 and r131991.

* platform/efl/compositing/clip-change-expected.png: Added.
* platform/efl/compositing/geometry/foreground-offset-change-expected.png: Added.
* platform/efl/compositing/iframes/fixed-position-iframe-expected.png: Added.
* platform/efl/compositing/iframes/iframe-content-flipping-expected.png:
* platform/efl/compositing/iframes/repaint-after-losing-scrollbars-expected.png: Added.
* platform/efl/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
* platform/efl/compositing/iframes/scroll-grandchild-iframe-expected.png: Added.
* platform/efl/compositing/overflow/repaint-after-losing-scrollbars-expected.png:
* platform/efl/compositing/repaint/newly-composited-on-scroll-expected.png:
* platform/efl/compositing/repaint/newly-composited-repaint-rect-expected.png:
* platform/efl/compositing/repaint/shrink-layer-expected.png: Added.
* platform/efl/compositing/repaint/transform-style-change-expected.png: Added.
* platform/efl/compositing/rtl: Added.
* platform/efl/compositing/rtl/rtl-overflow-invalidation-expected.png: Added.
* platform/efl/compositing/video-page-visibility-expected.png:
* platform/efl/css3/flexbox/repaint-expected.png:
* platform/efl/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
* platform/efl/fast/canvas/canvas-composite-fill-repaint-expected.png:
* platform/efl/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.
* platform/efl/fast/canvas/canvas-incremental-repaint-expected.png: Added.
* platform/efl/fast/canvas/canvas-resize-after-paint-without-layout-expected.png:
* platform/efl/fast/canvas/setWidthResetAfterForcedRender-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 24 Oct 2012 12:17:39 +0000 (12:17 +0000)]
Unreviewed GTK gardening.

Adding crash expectations for tests that started crashing after r132286.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] ASSERTION FAILED: edje(): could not paint native HTML part due to missing...
commit-queue@webkit.org [Wed, 24 Oct 2012 12:16:07 +0000 (12:16 +0000)]
[EFL][WK2] ASSERTION FAILED: edje(): could not paint native HTML part due to missing theme
https://bugs.webkit.org/show_bug.cgi?id=100227

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-24
Reviewed by Kenneth Rohde Christiansen.

Browser crashes on loading any page due to missing theme after
the web process has crashed and recovered.

This patch reset the theme when the web process is recovered to
avoid a crash.

* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::didRelaunchProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r132333.
rakuco@webkit.org [Wed, 24 Oct 2012 12:05:32 +0000 (12:05 +0000)]
Unreviewed, rolling out r132333.
http://trac.webkit.org/changeset/132333
https://bugs.webkit.org/show_bug.cgi?id=100234

Crashes many tests on the EFL-WK2 bot. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-24

Source/WebKit2:

* Target.pri:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::updateTextCheckerState):

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
* WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::TestController::platformInitializeContext):

LayoutTests:

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Removed.
* platform/efl/editing/spelling/spelling-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Move Ewk_View_Private_Data out of ewk_view.cpp
commit-queue@webkit.org [Wed, 24 Oct 2012 12:02:28 +0000 (12:02 +0000)]
[EFL][WK2] Move Ewk_View_Private_Data out of ewk_view.cpp
https://bugs.webkit.org/show_bug.cgi?id=100228

Patch by Christophe Dumez  <christophe.dumez@intel.com> and Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-24
Reviewed by Gyuyoung Kim.

Move Ewk_View_Private_Data out of ewk_view.cpp and
rename it to EwkViewImpl. This is a first step towards
getting rid of C'ism in Ewk_View.

In a future, we will make EwkViewImpl a proper C++
class and get rid of the private ewk_view C API so
that WebKit code interacts with EwkViewImpl instead
of Evas_Object.

* PlatformEfl.cmake:
* UIProcess/API/efl/EwkViewImpl.cpp: Added.
(_ewk_view_commit):
(_ewk_view_preedit_changed):
(_ewk_view_imf_context_destroy):
(_ewk_view_imf_context_create):
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::~EwkViewImpl):
* UIProcess/API/efl/EwkViewImpl.h: Added.
(WebKit):
(EwkViewImpl):
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_priv_del):
(_ewk_view_smart_add):
* UIProcess/API/efl/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Crash when passing NULL instead of ewk_view instance
ryuan.choi@samsung.com [Wed, 24 Oct 2012 11:57:47 +0000 (11:57 +0000)]
[EFL][WK2] Crash when passing NULL instead of ewk_view instance
https://bugs.webkit.org/show_bug.cgi?id=100078

Reviewed by Gyuyoung Kim.

Although applications should pass valid ewk_view to call ewk_view_XXX,
ewk_view_XXX should not be crashed.

* UIProcess/API/efl/ewk_view.cpp:
Checked null and early exited from EWK_VIEW_TYPE_CHECK if error occured.
* UIProcess/API/efl/tests/test_ewk2_view.cpp: Added test case.
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132336 268f45cc-cd09-0410-ab3c-d52691b4dbfc