15 years agoTemporary measure to make it possible to use the Qt port until the official Qt
staikos [Tue, 23 Jan 2007 18:36:22 +0000 (18:36 +0000)]
Temporary measure to make it possible to use the Qt port until the official Qt
API is done

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCompile with a released Qt.
staikos [Tue, 23 Jan 2007 18:18:19 +0000 (18:18 +0000)]
Compile with a released Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Zack
lars [Tue, 23 Jan 2007 16:35:12 +0000 (16:35 +0000)]
    Reviewed by Zack

        Widget and ScrollView do not own the Qt widgets
        anymore. Make sure they can handle the case of
        a null QWidget and never delete them.

        Fix refcounting of FrameViews (they get created with a
        refcount of 1) and add a few safety checks to the

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoForgot to add this file to the build (fix the build for real)
zack [Tue, 23 Jan 2007 14:35:26 +0000 (14:35 +0000)]
Forgot to add this file to the build (fix the build for real)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdjust the DragClient to latest changes.
zack [Tue, 23 Jan 2007 13:39:37 +0000 (13:39 +0000)]
Adjust the DragClient to latest changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the Qt build
zack [Tue, 23 Jan 2007 10:32:58 +0000 (10:32 +0000)]
Fix the Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej
lars [Tue, 23 Jan 2007 10:28:38 +0000 (10:28 +0000)]
    Reviewed by Maciej

        Make the last remaining pieces of the FrameLoader platform
        independent. Move most of the code over to WebFrameLoaderClient.
        Some smaller cleanups in the WebFrameBridge, and moved some
        platform independent functionality over to the shared code
        in WebCore.

        Add support for Frames to the Qt build and fix some issues
        in the API classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-23 Oliver Hunt <oliver@apple.com>
oliver [Tue, 23 Jan 2007 09:15:55 +0000 (09:15 +0000)]
2007-01-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Qt build stubs for Drop logic

        * WebCoreSupport/DragClientQt.cpp: Added.
        * WebCoreSupport/DragClientQt.h: Added.
        * WebKitPart/WebKitPart.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-23 Oliver Hunt <oliver@apple.com>
oliver [Tue, 23 Jan 2007 09:14:51 +0000 (09:14 +0000)]
2007-01-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Drop logic bindings for WebKit

        * WebCoreSupport/WebDragClient.h: Added.
        * WebCoreSupport/WebDragClient.mm: Added.
          Standard client impl
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
          Updated to use DragController to track drag state

        * WebCoreSupport/WebPasteboardHelper.h: Added.
          A *temporary* Helper class to access NSPasteboard access and
          manipulation functions present in WebKit
        * WebCoreSupport/WebPasteboardHelper.mm: Added.
          See header comment
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDocumentInternal.h:
          Remove unnecessary protocol
        * WebView/WebFrameView.mm:
        (-[WebFrameView _setDocumentView:]):
          Updating to use DragController to track drag state
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
        (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
        (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
        (-[WebHTMLView draggedImage:endedAt:operation:]):
        (-[WebHTMLView _documentFragmentForPasteboard:]):
          Helper method to generate DocumentFragment from NSPasteboard without regressing
        (-[WebHTMLView _canProcessDragWithDraggingInfo:]):
          Updating to use DragController to track drag state
        (-[WebHTMLView _isMoveDrag:]):
        (-[WebHTMLView _isNSColorDrag:]):
        * WebView/WebHTMLViewInternal.h:
          Removing unnecessary fields and methods
        * WebView/WebView.mm:
        (-[WebViewPrivate dealloc]):
          Remove obsolete ASSERT
        (-[WebView _setInitiatedDrag:]):
          Now passes directly through to DragController
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        (-[WebView _loadingDragOperationForDraggingInfo:]):
        (-[WebView draggingEntered:]):
          Updated to use DragController
        (-[WebView draggingUpdated:]):
        (-[WebView draggingExited:]):
        (-[WebView performDragOperation:]):
        (-[WebView _hitTest:dragTypes:]):
        * WebView/WebViewInternal.h:
          remove unnecessary method def

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-23 Oliver Hunt <oliver@apple.com>
oliver [Tue, 23 Jan 2007 09:12:36 +0000 (09:12 +0000)]
2007-01-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Added DragController to handled drag and drop state and control logic.
        Currently this only handles logic for Dragging and Dropping, and is
        unable to initialise a drag itself.

        platform/DragData encapsulate the paltform Drag data (NSDraggingInfo on Mac,
        QMimeType in Qt).  This provides methods to pull data out the drag data as a String,
        a URL, a DocumentFragment (for rich content), or a Colour.

        * WebCore.exp:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/Clipboard.cpp: Added.
          move platform independent functions from ClipboardMac to Clipboard

        * dom/Clipboard.h:
          as above -- also removed virtual modifier from now
          platform independent methods

        * editing/Editor.cpp:
        * editing/Editor.h:
          adding calls through to EditorClient

        * page/DragActions.h: Added.
          Replicates a number of NS* enums in the WebCore namespace

        * page/DragClient.h: Added.
          Standard client interface for dragging UIDelegate

        * page/DragController.cpp: Added.
          Class to handle state and logic for dragging and dropping

        * page/DragController.h: Added.
          See above

        * page/Page.cpp:
          Update Page to have DragController

        * page/Page.h:

        * page/mac/DragControllerMac.mm: Added.
          Platform specific portions of the DragController

        * page/mac/EventHandlerMac.mm:
          Convert from NSDragOperation to WebCore::DragOperation

        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:
          Remove obsolete Drag functions

        * page/qt/DragControllerQt.cpp: Added.
          Basic stubs to maintain Qt  build

        * platform/DragData.cpp: Added.
        * platform/DragData.h: Added.
          DragData class to encapsulate platform drag data/event

        * platform/graphics/svg/SVGImage.cpp:
          Addition of dummy DragClient

        * platform/graphics/svg/SVGImageEmptyClients.h:

        * platform/mac/ClipboardMac.h:
        * platform/mac/ClipboardMac.mm:
         Moving platform independent logic to Clipboard, and updating
         platform specific methods to use appropriate accessors rather than
         directly manipulating data they no longer own

        * platform/mac/DragDataMac.mm: Added.
          Mac implementations of DragData methods.  A number of these use
          a Helper class that accesses WebKit functionality.  That functionality
          should be migrated to WebCore in the future.

        * platform/mac/PasteboardHelper.h: Added.
          Temporary, and Mac only, helper class to access WebKit functionality
          from WebCore

        * platform/qt/DragDataQt.cpp: Added.
         Basic stubs to maintain Qt build

        * rendering/HitTestResult.cpp:
         Correct HitTestResult copy contructor to copy localPoint

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-22 Mark Rowe <mrowe@apple.com>
bdash [Tue, 23 Jan 2007 04:00:54 +0000 (04:00 +0000)]
2007-01-22  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        Bug 11692: REGRESSION(r17352): Disappearing page title

        * dom/Document.cpp:
        (WebCore::Document::setTitle): If the title has already been set explicitly via JavaScript,
        ignore any changes to it due to encountering <title> tags.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Tue, 23 Jan 2007 01:36:22 +0000 (01:36 +0000)]

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12344
          NativeListBox: item hit testing does not account for top padding and border

        * fast/forms/listbox-selection-2-expected.checksum: Added.
        * fast/forms/listbox-selection-2-expected.png: Added.
        * fast/forms/listbox-selection-2-expected.txt: Added.
        * fast/forms/listbox-selection-2.html: Added.


        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12344
          NativeListBox: item hit testing does not account for top padding and border

        Test: fast/forms/listbox-selection-2.html

        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::numVisibleItems): Changed height() to contentHeight()
        since items are visible only in the content box.
        (WebCore::RenderListBox::listIndexAtOffset): Adjusted for vertical padding and
        borders. Changed to return -1 instead of the last item's index if the given offset
        is below the last item.
        (WebCore::RenderListBox::autoscroll): Adjusted for vertical padding and borders.
        (WebCore::RenderListBox::controlClipRect): Changed to return the content box since
        items should not spill into the padding box. This change is the reason the test
        generates pixel results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Tue, 23 Jan 2007 01:30:50 +0000 (01:30 +0000)]

        Reviewed by darin

        editing/pasteboard/4641033 layout test is broken (12328)

        The fixes not only make this test pass, but also fix a bug that
        was reflected in the results checked in for this test.  The caret
        was in the wrong position:
        * editing/pasteboard/4641033-expected.checksum:
        * editing/pasteboard/4641033-expected.png:
        * editing/pasteboard/4641033-expected.txt:
        * editing/pasteboard/4944770-1-expected.checksum: Added.
        * editing/pasteboard/4944770-1-expected.png: Added.
        * editing/pasteboard/4944770-1-expected.txt: Added.
        * editing/pasteboard/4944770-1.html: Added.
        * editing/pasteboard/4944770-2-expected.checksum: Added.
        * editing/pasteboard/4944770-2-expected.png: Added.
        * editing/pasteboard/4944770-2-expected.txt: Added.
        * editing/pasteboard/4944770-2.html: Added.
        * editing/pasteboard/4944770-expected.checksum: Added.
        * editing/pasteboard/4944770-expected.png: Added.
        * editing/pasteboard/4944770-expected.txt: Added.
        Equivalent render trees:
        * editing/execCommand/format-block-from-range-selection-expected.txt:
        * editing/pasteboard/drag-drop-modifies-page-expected.txt:
        * editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
        * editing/pasteboard/nested-blocks-with-text-area-expected.png:
        * editing/pasteboard/nested-blocks-with-text-area-expected.txt:
        * editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
        * editing/pasteboard/nested-blocks-with-text-field-expected.png:
        * editing/pasteboard/nested-blocks-with-text-field-expected.txt:


        Reviewed by darin

        editing/pasteboard/4641033 layout test is broken (12328)

        This layout test failure demonstrates three bugs:
        Smart replace shouldn't be turned on, but is because a word
        selection granularity from the previous test isn't cleared.
        Smart replace shouldn't add any spaces because the paste is performed
        in an empty paragraph.
        Smart replace spaces are added to the text of options inside
        the select element instead of before/after the select element.

        This patch fixes the second two problems.  During a
        ReplaceSelectionCommand, the VisiblePosition for the end of
        the inserted content is the last position in the last leaf
        inserted.  This is a problem when the last leaf is inside a
        select element, since VP creation is inconsistent there.
        Second, smart spaces were inserted inside the last leaf, not
        at the endOfInsertedContent.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::shouldMergeStart): Renamed
        m_lastNodeInserted to m_lastLeafInserted.  Use the
        start/endOfInsertedContent getters.
        (WebCore::ReplaceSelectionCommand::shouldMergeEnd): Ditto.
        (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Ditto.
        (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Ditto.
        (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Added.
        Special case for when the last leaf inserted is inside a select
        element: return the VisiblePosition after the select element.
        (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Added.
        (WebCore::ReplaceSelectionCommand::doApply): Did renaming.  Used
        the start/endOfInsertedContent getters.  Insert smart replace spaces
        into the right nodes.
        (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Renaming.
        (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
        (WebCore::ReplaceSelectionCommand::updateNodesInserted): Ditto.
        * editing/ReplaceSelectionCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
darin [Tue, 23 Jan 2007 00:40:55 +0000 (00:40 +0000)]
    Reviewed by Adam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12273
          REGRESSION: File input value invisible after removing and re-appending

        - made more of the file chooser code cross-platform

        - fixed an Objective-C garbage collection problem in FileChooser

        - tried to remove layering violations where FileChooser in the platform
          directory knows about the rendering and DOM trees (but wasn't able to
          do it entirely)

        * platform/FileChooser.cpp: Added.
        (WebCore::FileChooser::create): Changed parameters.
        (WebCore::FileChooser::chooseFile): Changed to call chooseIcon function.
        (WebCore::FileChooser::chooseIcon): Added.

        * platform/FileChooser.h: Added FileChooserClient so this file doesn't have
        to know about RenderFileUploadControl. Used RetainPtr instead of retain/release
        so this works properly with Objective-C GC. Replaced disconnectUploadControl
        with disconnectClient, which has a simple inline implementation. Moved the
        Document parameter from the constructor to openFileChooser, along with a comment
        about why it should not be there. Added a filename parameter to the constructor
        for the initial filename. Added a font parameter to basenameForWidth so we don't
        depend on having a pointer to the renderer. Removed the uploadControl() and
        document() functions since no one calls either of them.

        * platform/mac/FileChooserMac.mm: Removed code that is now cross-platform.
        (-[OpenPanelController beginSheetWithFrame:]): Added frame parameter, instead
        of storing a document pointer in the FileChooser.
        (WebCore::FileChooser::FileChooser): Updated for changed parameters. Also added
        code to choose the icon based on the initial filename. Pass the adopt parameter
        to the constructor of the RetainPtr.
        (WebCore::FileChooser::~FileChooser): Removed the release call, since the
        RetainPtr will take care of it. Added a call to disconnectFileChooser here.
        There's no need to disconnect at disconnectClient time, and that lets us have
        one more cross-platform function.
        (WebCore::FileChooser::openFileChooser): Added document parameter. Added code
        to get the frame from the document. And added a nil check since there's no
        ironclad guarantee the document won't have outlived its frame.
        (WebCore::FileChooser::basenameForWidth): Added font parameter. Use that instead
        of going at the upload control's style. The caller can handle that now.

        * rendering/RenderFileUploadControl.h: Removed unnecessary includes.
        Made class inherit privately from FileChooserClient. Changed constructor
        parameter to HTMLInputElement rather than Node. Made protected members be
        private instead, and made a couple function members const.
        * rendering/RenderFileUploadControl.cpp: Moved constants to the top of the file,
        but after the "using namespace"
        (WebCore::RenderFileUploadControl::RenderFileUploadControl): Updated for changes
        to the FileChooser::create function and the parameter types.
        (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed unneeded
        null check -- there's no case where the FileChooser fails to be created.
        (WebCore::RenderFileUploadControl::click): Pass document to openFileChooser.
        (WebCore::RenderFileUploadControl::updateFromElement): Tweaked code a bit by
        using updateFromElement and setValue instead of casting the renderer to a
        RenderButton and calling setText directly. Put setInputType call here.
        (WebCore::RenderFileUploadControl::maxFilenameWidth): Made const. Broke long line.
        (WebCore::RenderFileUploadControl::createButtonStyle): Made const.
        (WebCore::RenderFileUploadControl::paintObject): Moved buttonShadowHeight constant
        to the top of the file. Call isEmpty instead of checking width and height of
        IntRect for 0. Computed font to pass to FileChooser::basenameForWidth. Broke
        long lines.
        Moved the setInputType call to the caller; concept here is that this class is
        as simple as possible, rather than doing as much of the button job as possible.

        * WebCore.xcodeproj/project.pbxproj: Added FileChooser.cpp.
        * WebCore.pro: Ditto.
        * CMakeLists.txt: Ditto.
        * WebCoreSources.bkl: Ditto.

        * platform/gdk/TemporaryLinkStubs.cpp: Updated stubs.
        * platform/qt/FileChooserQt.cpp: Updated stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
bdakin [Mon, 22 Jan 2007 22:51:21 +0000 (22:51 +0000)]
    Reviewed by Darin.

        Darin and I looked into these tests that are adding an empty
        RenderText, and we think they just need new results. Here they are!

        * editing/execCommand/find-after-replace-expected.txt:
        * fast/css/beforeSelectorOnCodeElement-expected.txt:
        * fast/forms/control-restrict-line-height-expected.txt:
        * fast/forms/select-size-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Mon, 22 Jan 2007 21:37:34 +0000 (21:37 +0000)]

        Reviewed by Darin.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=12364
          REGRESSSION (NativeListBox): Selected option's background is not clipped to the list box

        * fast/forms/select-item-background-clip-expected.checksum: Added.
        * fast/forms/select-item-background-clip-expected.png: Added.
        * fast/forms/select-item-background-clip-expected.txt: Added.
        * fast/forms/select-item-background-clip.html: Added.


        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12364
          REGRESSSION (NativeListBox): Selected option's background is not clipped to the list box

        Test: fast/forms/select-item-background-clip.html

        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintItemBackground): Intersect the item's rect with
        the list box's clip rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * WebView/WebHTMLView.mm:
sullivan [Mon, 22 Jan 2007 21:28:37 +0000 (21:28 +0000)]
    * WebView/WebHTMLView.mm:
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
        Tiger build fix: remove unused variable for return value of dictionaryServiceWindowShow

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth.
darin [Mon, 22 Jan 2007 21:15:37 +0000 (21:15 +0000)]
    Reviewed by Beth.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12369
          REGRESSION (r19027): amazon.com home page crashes WebKit r19028 debug build

        I caused this a few hours ago. Oops!

        * rendering/RenderText.cpp: (WebCore::RenderText::setStyle):
        Compute whether the font changed before calling RenderObject::setStyle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam and Darin
sullivan [Mon, 22 Jan 2007 21:09:40 +0000 (21:09 +0000)]
    Reviewed by Adam and Darin

        - fixed <rdar://problem/4794320> "Look Up in Dictionary" does nothing in WebKit
        (need to adopt new API)

        * Misc/WebNSURLExtras.m:
        (-[NSString _web_isUserVisibleURL]):
        random typo correction in comment

        * English.lproj/StringsNotToBeLocalized.txt:
        updated for these changes

        * WebView/WebHTMLView.mm:
        new function to convert an AppKit screen point to a CG screen point
        (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
        on Leopard now uses new API. There's something of an impedance mismatch between
        this API and WebKit, but that was true for the SPI we were using in Tiger also.
        Bug 4945808 covers the ways in which this is not perfect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
bdakin [Mon, 22 Jan 2007 20:54:22 +0000 (20:54 +0000)]
    Reviewed by Maciej.

        Fix for <rdar://problem/4912129> REGRESSION: Crash occurs at
        WebCore::Frame::eventHandler() after clicking to dismiss a
        contextual menu on the page

        * page/EventHandler.cpp:
        (WebCore::EventHandler::stopAutoscrollTimer): Added nil-check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
darin [Mon, 22 Jan 2007 17:39:53 +0000 (17:39 +0000)]
    Reviewed by Mitz.

        - a couple tiny tweaks to make --reset-results work better

        * Scripts/run-webkit-tests: Always generate results when --reset-results is specified.
        Don't make a separate "new" entry while generating results when --reset-results
        is specified since new results are the norm in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Mon, 22 Jan 2007 17:28:57 +0000 (17:28 +0000)]

        Test by Andrew Wellington <proton@wiretapped.net>.
        Reviewed by Darin.

        - test for fix to http://bugs.webkit.org/show_bug.cgi?id=11197
          REGRESSION: Specifying a counter for a CODE tag's content style
          property on before or after causes a crash.

        * fast/css/beforeSelectorOnCodeElement-expected.checksum: Added.
        * fast/css/beforeSelectorOnCodeElement-expected.png: Added.
        * fast/css/beforeSelectorOnCodeElement-expected.txt: Added.
        * fast/css/beforeSelectorOnCodeElement.html: Added.

        Test by Mitz.
        Reviewed by Darin.

        - test for monospace problem mentioned in the above bug

        * fast/text/monospace-width-cache-expected.checksum: Added.
        * fast/text/monospace-width-cache-expected.png: Added.
        * fast/text/monospace-width-cache-expected.txt: Added.
        * fast/text/monospace-width-cache.html: Added.


        Reviewed by Mitz.

        Inspired by a much simpler patch by Andrew Wellington <proton@wiretapped.net>.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11197
          REGRESSION: Specifying a counter for a CODE tag's content style property
          on before or after causes a crash.

        Test: fast/css/beforeSelectorOnCodeElement.html

        - fix regression I recently introduced where the monospace cache could be
          used for text that was not ASCII, if text was changed after the style was set

        Test: fast/text/monospace-width-cache.html

        - streamline RenderText.h -- remove unneeded functions, make some needlessly
          virtual functions non-virtual, remove unneeded header includes, replace use
          of Font* with Font& for consistency with RenderStyle, use "text" consistently
          instead of "string"

        * rendering/RenderText.h: Removed unneeded include of "Text.h", declarations of
        SOFT_HYPHEN, DocumentMarker, InlineBox, Position, String. Got rid of friend
        declaration for InlineTextBox. Changed constructor to take a PassRefPtr since
        we do take owership of the passed-in text. Made deleteTextBoxes() private.
        Removed unneeded data(). Made override of length() private so people will use
        the faster textLength() instead. Renamed string() to text() so it matches up
        better with setText(). Same for stringLength(), originalString(), and
        setInternalString(), which are now textLength(), originalText(), and
        setTextInternal(). Renamed the old text() function to characters(), since it
        returns a pointer as StringImpl::characters does. Changed Font* to Font& everywhere.
        Renamed the internal calcMinMaxWidth() function to calcMinMaxWidthInternal() and
        made it non-virtual since it's not overriden anywhere. Also made the
        trimmedMinMaxWidth() function non-virtual. Made containsOnlyWhitespace() private.
        Removed both font() functions (one was needlessly virtual) and element().
        Renamed cacheWidths() to updateMonospaceCharacterWidth() and removed the
        shouldUseMonospaceCache() function. Renamed allAscii() to isAllASCII() and made
        it an inline function. Removed the m_allAsciiChecked flag and renamed the
        m_allAscii flag to m_isAllASCII.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::RenderText): Removed initialization of m_allAsciiChecked.
        Initialize m_isAllASCII. Changed all occurrences of m_str->length() and
        m_str->characters () to use the stringLength() and characters() inline functions
        (WebCore::RenderText::setStyle): Replaced the unconditional call to cacheWidths
        with a conditional call to updateMonospaceCharacterWidth. This speeds up the common
        case where style is changed without changing the font.
        (WebCore::RenderText::originalText): Changed code to not depend on overridden
        element() function with casts to a Text node -- this was one of only two call sites.
        Also renamed.
        (WebCore::RenderText::positionForCoordinates): Name change.
        (WebCore::RenderText::caretRect): Ditto.
        (WebCore::RenderText::updateMonospaceCharacterWidth): Renamed from cacheWidths and
        incorporate the check that was formerly in a separate shouldUseMonospaceCache
        (WebCore::RenderText::widthFromCache): Changed to take a Font& instead of Font*.
        Changed to take advantage of the fact that the string is known to be all ASCII in
        the m_monospaceCharacterWidth code path.
        (WebCore::RenderText::trimmedMinMaxWidth): Ditto. Also use style()->font() instead
        of font(false).
        (WebCore::RenderText::calcMinMaxWidth): Ditto. Also changed to use softHyphen instead
        of SOFT_HYPHEN.
        (WebCore::RenderText::containsOnlyWhitespace): More of the same.
        (WebCore::RenderText::setSelectionState): Ditto.
        (WebCore::RenderText::setTextWithOffset): Ditto.
        (WebCore::isInlineFlowOrEmptyText): Ditto.
        (WebCore::RenderText::setTextInternal): Updated for name changes. Also changed to
        set the m_isAllASCII flag every time, in the more-efficient way we use elsewhere
        (or'ing all the characters together), and to call updateMonospaceCharacterWidth
        if the "all ASCII"-ness of the text changes.
        (WebCore::RenderText::setText): Updated for name changes.
        (WebCore::RenderText::width): More like above.
        (WebCore::RenderText::selectionRect): Ditto.
        (WebCore::RenderText::caretMaxOffset): Ditto.
        (WebCore::RenderText::previousOffset): Ditto.
        (WebCore::RenderText::nextOffset): Ditto.

        * dom/Position.cpp:
        * dom/Range.cpp:
        * editing/CompositeEditCommand.cpp:
        * editing/DeleteSelectionCommand.cpp:
        * editing/VisiblePosition.cpp:
        * html/HTMLElement.cpp:
        Added now-needed include of "Text.h" which is no longer included by "RenderText.h".

        * editing/SelectionController.cpp:
        * editing/TextIterator.cpp:
        Update for name changes of stringLength(), string(), and originalString() to
        textLength(), text(), and originalText(), and to always use textLength() instead
        of length() when we have a RenderText* rather than a RenderObject*.
        * editing/visible_units.cpp:
        (WebCore::startOfParagraph): Ditto.
        (WebCore::endOfParagraph): Ditto.
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto. Also removed use of the
        RenderObject::font() function and replaced it with explicit access to the style.
        (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionRect): Ditto.
        (WebCore::InlineTextBox::isLineBreak): Ditto.
        (WebCore::InlineTextBox::paint): Ditto.
        (WebCore::InlineTextBox::selectionStartEnd): Ditto.
        (WebCore::InlineTextBox::paintSelection): Ditto.
        (WebCore::InlineTextBox::paintMarkedTextBackground): Ditto.
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto.
        (WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
        (WebCore::InlineTextBox::offsetForPosition): Ditto.
        (WebCore::InlineTextBox::positionForOffset): Ditto.
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::addChild): Ditto.
        * rendering/RenderCounter.cpp:
        (WebCore::RenderCounter::originalText): Ditto.
        (WebCore::RenderCounter::calcMinMaxWidth): Ditto.
        * rendering/RenderCounter.h: Ditto.
        * rendering/RenderTextFragment.cpp:
        (WebCore::RenderTextFragment::originalText): Ditto.
        * rendering/RenderTextFragment.h: Ditto.
        * rendering/SVGInlineFlowBox.cpp:
        (WebCore::placePositionedBoxesHorizontally): Ditto.
        (WebCore::placeBoxesVerticallyWithAbsBaseline): Ditto.
        * rendering/bidi.cpp:
        (WebCore::BidiIterator::increment): Ditto.
        (WebCore::BidiIterator::current): Ditto.
        (WebCore::BidiIterator::direction): Ditto.
        (WebCore::addRun): Ditto.
        (WebCore::checkMidpoints): Ditto.
        (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.
        (WebCore::RenderBlock::skipWhitespace): Ditto.
        (WebCore::RenderBlock::findNextLineBreak): Ditto.

        * rendering/RenderBR.h: Updated signature of width function which now takes a
        Font& instead of a Font*.

        * rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): Updated to no longer
        use the RenderObject::font() function, and added a comment about first-line, which
        is not handled properly here.

        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::text):
        * rendering/RenderTreeAsText.cpp: (WebCore::writeTextRun):
        Eliminated use of RenderText::data().

        * rendering/RenderObject.h: Removed RenderObject::font(). This had the bad effect of
        having everyone pass in a boolean rather than using the cleaner style() and
        firstLineStyle() functions in cases where there's no a firstLineStyle boolean.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::getVerticalPosition): Replaced use of RenderObject::font()
        with direct use of the style instead, which is arguably easier to understand anyway.
        (WebCore::RenderObject::baselinePosition): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by The Mitz.
weinig [Mon, 22 Jan 2007 14:38:28 +0000 (14:38 +0000)]
    Reviewed by The Mitz.

        Move JSHTMLSelectElementCustom.cpp from bindings to bindings/js
        where it belongs.

        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/JSHTMLSelectElementCustom.cpp: Removed.
        * bindings/js/JSHTMLSelectElementCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix Qt build
zack [Mon, 22 Jan 2007 10:54:23 +0000 (10:54 +0000)]
Fix Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Mon, 22 Jan 2007 05:23:25 +0000 (05:23 +0000)]
    Reviewed by Darin.

        REGRESSION: prototype.js logs error (HTMLFormElement) on webkit builds

        Added constructors for most HTML elements; started auto-generating HTMLSelectElement JS binding.

        Test: fast/dom/Window/element-constructors-on-window.html

        * DerivedSources.make: Generate JSHTMLSelectElement.
        * WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElement{Custom}.
        * bindings/js/JSHTMLElementWrapperFactory.cpp: Create a proper binding for SELECT.

        * bindings/js/kjs_html.cpp:
        * bindings/js/kjs_html.h:
        Removed everything related to SELECT. Renamed getHTMLOptionsCollection to toJS for autogenerated code
        to be happy, and rewrote it using cacheDOMObject.

        * bindings/scripts/CodeGeneratorJS.pm: Added HTMLElement to the list of types that cannot fail conversion.

        * html/HTMLAnchorElement.idl:
        * html/HTMLAppletElement.idl:
        * html/HTMLAreaElement.idl:
        * html/HTMLBRElement.idl:
        * html/HTMLBaseElement.idl:
        * html/HTMLBaseFontElement.idl:
        * html/HTMLBodyElement.idl:
        * html/HTMLButtonElement.idl:
        * html/HTMLCanvasElement.idl:
        * html/HTMLDListElement.idl:
        * html/HTMLDirectoryElement.idl:
        * html/HTMLDivElement.idl:
        * html/HTMLFieldSetElement.idl:
        * html/HTMLFontElement.idl:
        * html/HTMLFormElement.idl:
        * html/HTMLHRElement.idl:
        * html/HTMLHeadElement.idl:
        * html/HTMLHeadingElement.idl:
        * html/HTMLHtmlElement.idl:
        * html/HTMLImageElement.idl:
        * html/HTMLInputElement.idl:
        * html/HTMLIsIndexElement.idl:
        * html/HTMLLIElement.idl:
        * html/HTMLLabelElement.idl:
        * html/HTMLLegendElement.idl:
        * html/HTMLLinkElement.idl:
        * html/HTMLMapElement.idl:
        * html/HTMLMenuElement.idl:
        * html/HTMLMetaElement.idl:
        * html/HTMLModElement.idl:
        * html/HTMLOListElement.idl:
        * html/HTMLOptGroupElement.idl:
        * html/HTMLParagraphElement.idl:
        * html/HTMLParamElement.idl:
        * html/HTMLPreElement.idl:
        * html/HTMLQuoteElement.idl:
        * html/HTMLScriptElement.idl:
        * html/HTMLStyleElement.idl:
        * html/HTMLTextAreaElement.idl:
        * html/HTMLTitleElement.idl:
        * html/HTMLUListElement.idl:
        Generate constructors.

        * html/HTMLSelectElement.cpp:
        * html/HTMLSelectElement.h:
        Make length() return unsigned for auto-generated code to be happy.

        * html/HTMLSelectElement.idl: Adjusted to be usable for JS.

        * bindings/JSHTMLSelectElementCustom.cpp: Added. Implements remove().

        * page/DOMWindow.idl:
        Added properties for most elements' constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-21 Mark Rowe <mrowe@apple.com>
bdash [Mon, 22 Jan 2007 03:45:40 +0000 (03:45 +0000)]
2007-01-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        Bug 12357: Reproducible crash in WebCore::Settings::isJavaScriptEnabled in svg/custom/js-update-bounce.svg under guard-malloc

        * page/Frame.cpp:
        (WebCore::Frame::~Frame): Access the global object directly rather than via Window::retrieveWindow to prevent our reference to
        a deleted settings object being used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Mon, 22 Jan 2007 02:46:06 +0000 (02:46 +0000)]
    Reviewed by Maciej.

        - fix <rdar://problem/4930503> REGRESSION: Page changes title when
          command-clicking on named anchor link (12299)

        * loader/FrameLoader.cpp:
        Return if shouldContinue is false. This matches the other similar
        functions and prevents us from doing extra work in the "ignore" case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-21 Mark Rowe <mrowe@apple.com>
bdash [Mon, 22 Jan 2007 02:16:57 +0000 (02:16 +0000)]
2007-01-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin.

        Bug 12355: Reproducible crash in WebCore::parseNumber in svg/custom/js-update-bounce.svg under guard-malloc

        * ksvg2/svg/SVGParserUtilities.cpp:
        (WebCore::parseNumber): Parenthesize to prevent reading past end of buffer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Mon, 22 Jan 2007 01:33:02 +0000 (01:33 +0000)]

        Reviewed by Darin.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=12345
          REGRESSION: Disabled pop-up text is not grayed out

        * fast/forms/select-disabled-appearance-expected.checksum: Added.
        * fast/forms/select-disabled-appearance-expected.png: Added.
        * fast/forms/select-disabled-appearance-expected.txt: Added.
        * fast/forms/select-disabled-appearance.html: Added.


        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12345
          REGRESSION: Disabled pop-up text is not grayed out

        Test: fast/forms/select-disabled-appearance.html

        * rendering/RenderThemeMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix non-Mac builds
darin [Mon, 22 Jan 2007 01:17:16 +0000 (01:17 +0000)]
    - fix non-Mac builds

        * CMakeLists.txt: Added JSDocumentCustom.cpp.
        * WebCore.pro: Ditto.
        * WebCoreSources.bkl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Mon, 22 Jan 2007 01:09:03 +0000 (01:09 +0000)]

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12353
          REGRESSION: Crash on load (mutation event dispatch under the image element constructor deletes the element)

        * fast/dom/HTMLImageElement/constructor-mutation-event-dispatch-expected.txt: Added.
        * fast/dom/HTMLImageElement/constructor-mutation-event-dispatch.html: Added.


        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12353 <rdar://problem/4944599>
          REGRESSION: Crash on load (mutation event dispatch under the image element constructor deletes the element)

        Test: fast/dom/HTMLImageElement/constructor-mutation-event-dispatch.html

        * bindings/js/kjs_html.cpp:
        (KJS::ImageConstructorImp::construct): Protect the image element before setting
        its attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim H.
darin [Mon, 22 Jan 2007 00:53:27 +0000 (00:53 +0000)]
    Reviewed by Tim H.

        * WebInspector/webInspector/inspector.css: Use row-resize for the splitter cursor
        instead of move. It's a horizontal splitter resizer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Sun, 21 Jan 2007 23:42:37 +0000 (23:42 +0000)]

        Rolling out patch for http://bugs.webkit.org/show_bug.cgi?id=8360.

        * fast/layers/removed-by-scroll-handler-expected.checksum: Removed.
        * fast/layers/removed-by-scroll-handler-expected.png: Removed.
        * fast/layers/removed-by-scroll-handler-expected.txt: Removed.
        * fast/layers/removed-by-scroll-handler.html: Removed.


        Rolling out patch for http://bugs.webkit.org/show_bug.cgi?id=8360.

        * rendering/RenderLayer.cpp:
        * rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ddkilzer [Sun, 21 Jan 2007 22:07:22 +0000 (22:07 +0000)]

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12280
          select element not available by name through document.all
          (dropdown list not available on smarthome.com checkout)

        * fast/dom/document-all-select-expected.txt: Added.
        * fast/dom/document-all-select.html: Added.


        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12280
          select element not available by name through document.all
          (dropdown list not available on smarthome.com checkout)

        Test: fast/dom/document-all-select.html

        * html/HTMLCollection.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
weinig [Sun, 21 Jan 2007 21:03:54 +0000 (21:03 +0000)]
    Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=10805
          REGRESSION (r15720): manual-tests/onblur-remove.html failing

        * manual-tests/onblur-remove.html: Changed the test to not require pressing
        Enter, since the correct behavior for Enter is to send a blur event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Sun, 21 Jan 2007 20:51:34 +0000 (20:51 +0000)]

        Reviewed by Darin.

        Test for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

        * fast/dom/gc-10-expected.txt: Added.
        * fast/dom/gc-10.html: Added.
        * fast/dom/resources/gc-10-frame.html: Added.


        Reviewed by Darin.

        Fix for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

        JSDocuments are now responsible for marking the DOM wrappers associated with them, when they get marked.
        This fixes a JS object leak when a DOM wrapper has a reference to a JSDocument that is otherwise not reachable.

        Test: fast/dom/gc-10.html

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDocumentCustom.cpp: Added.
        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_binding.h:
        * dom/Document.idl:


        Reviewed by Darin.

        Test support for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

        This adds a getJSObjectCount test-accessible function to allow test scripts to track JSObject usage.

        * DumpRenderTree/GCController.h:
        * DumpRenderTree/GCController.mm:
        (+[GCController isSelectorExcludedFromWebScript:]):
        (-[GCController getJSObjectCount]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Sun, 21 Jan 2007 20:29:41 +0000 (20:29 +0000)]

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=10692
          REGRESSION (r14847): Unnecessary scrollbars with position:relative; and overflow:auto;

        * fast/overflow/position-relative-expected.checksum: Added.
        * fast/overflow/position-relative-expected.png: Added.
        * fast/overflow/position-relative-expected.txt: Added.
        * fast/overflow/position-relative.html: Added.


        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=10692
          REGRESSION (r14847): Unnecessary scrollbars with position:relative; and overflow:auto;

        Test: fast/overflow/position-relative.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::lowestPosition): Add the relative position offset only
        if 'includeSelf' is true.
        (WebCore::RenderBox::rightmostPosition): Ditto.
        (WebCore::RenderBox::leftmostPosition): Ditto.
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::lowestPosition): Ditto.
        (WebCore::RenderFlow::rightmostPosition): Ditto.
        (WebCore::RenderFlow::leftmostPosition): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Sun, 21 Jan 2007 17:19:03 +0000 (17:19 +0000)]

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=10472
          REGRESSION: "add" method of <select> object does not put the <option> object in the correct position

        * fast/dom/HTMLSelectElement/options-collection-detached-expected.txt: Added.
        * fast/dom/HTMLSelectElement/options-collection-detached.html: Added.


        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=10472
          REGRESSION: "add" method of <select> object does not put the <option> object in the correct position

        Test: fast/dom/HTMLSelectElement/options-collection-detached.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setRecalcListItems): Reset the options collection
        info if the <select> is not in the document. For in-document <select>s this
        happens anyway as a result of the DOM tree version increasing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Sun, 21 Jan 2007 17:05:13 +0000 (17:05 +0000)]

        Reviewed by Darin.

        - updated results for http://bugs.webkit.org/show_bug.cgi?id=12349
          NativeFileUpload: Button text is not grayed out when the control is disabled

        * fast/forms/file-input-disabled-expected.checksum:
        * fast/forms/file-input-disabled-expected.png:
        * fast/forms/file-input-disabled-expected.txt:


        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12349
          NativeFileUpload: Button text is not grayed out when the control is disabled

        Covered by fast/forms/file-input-disabled.html

        * css/html4.css: Changed selectors that had pseudo-classes after the -webkit-file-upload-button
        pseudo-element to have the pseudo-element at the end. Pseudo-elements must be at the end.
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::createButtonStyle): Changed to not overwrite the button's
        style with its parent's style. getPseudoStyle() handles inheritance properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
weinig [Sun, 21 Jan 2007 16:55:16 +0000 (16:55 +0000)]
    Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12343
          crash in css2.1/t1202-counter-09-b.html

        * platform/Font.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam and Mitz.
darin [Sun, 21 Jan 2007 16:20:07 +0000 (16:20 +0000)]
    Reviewed by Adam and Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12347
          REGRESSION: list box scrolling broken (fast/forms/listbox-selection.html)

        Covered by existing test: fast/forms/listbox-selection.html

        * rendering/RenderListBox.h: Added override of layout(), made selectionChanged()
        no longer an inline. Added private scrollToRevealSelection(),
        m_scrollToRevealSelectionAfterLayout, and m_inAutoscroll.
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::RenderListBox): Initialize new data members.
        (WebCore::RenderListBox::updateFromElement): Remove scrolling code.
        (WebCore::RenderListBox::selectionChanged): Moved from header. Calls repaint
        and then scrollToRevealSelection, but if we need layout, instead schedules
        scrollToRevealSelection to be done after layout.
        (WebCore::RenderListBox::layout): Added. After calling base class, calls
        scrollToRevealSelection if the m_scrollToRevealSelectionAfterLayout is set.
        (WebCore::RenderListBox::scrollToRevealSelection): Added. Code was originally
        in updateFromElement.
        (WebCore::RenderListBox::autoscroll): Set m_inAutoscroll so that the
        selectionChanged function knows not to scroll. Also removed the repaint()
        here because updateListBoxSelection() takes care of repainting by calling

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ddkilzer [Sun, 21 Jan 2007 13:07:55 +0000 (13:07 +0000)]

        Reviewed by NOBODY (no-svg build fix).

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseMoveEvent): Changed #if SVG_SUPPORT to #ifdef SVG_SUPPORT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Sun, 21 Jan 2007 00:44:31 +0000 (00:44 +0000)]

        Reviewed by Maciej.

        - test for http://bugs.webkit.org/show_bug.cgi?id=11115
          REGRESSION: Crash on Flickr after hitting cancel from adding a note

        * fast/forms/text-set-value-crash-expected.txt: Added.
        * fast/forms/text-set-value-crash.html: Added.


        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11115
          REGRESSION: Crash on Flickr after hitting cancel from adding a note

        Test: fast/forms/text-set-value-crash.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValue): Added a call to Document::updateRendering().
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::setValue): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Sun, 21 Jan 2007 00:35:32 +0000 (00:35 +0000)]

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=8360
          Repro crash when onscroll handler deletes the scrolled object

        * fast/layers/removed-by-scroll-handler-expected.checksum: Added.
        * fast/layers/removed-by-scroll-handler-expected.png: Added.
        * fast/layers/removed-by-scroll-handler-expected.txt: Added.
        * fast/layers/removed-by-scroll-handler.html: Added.


        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=8360
          Repro crash when onscroll handler deletes the scrolled object

        Test: fast/layers/removed-by-scroll-handler.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::dispatchScrollEvent): Added. Called when the timer
        fires and dispatches the scroll event to the layer's element.
        (WebCore::RenderLayer::scrollToOffset): Instead of dispatching the scroll
        event from this function, which is called during layout, schedule a 0-duration
        timer to dispatch the event after layout.
        * rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoForgot to include the new layout tests in the last commit.
zimmermann [Sat, 20 Jan 2007 23:45:15 +0000 (23:45 +0000)]
Forgot to include the new layout tests in the last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Sam.
zimmermann [Sat, 20 Jan 2007 23:40:07 +0000 (23:40 +0000)]
Reviewed by Sam.

Fix JS bindings for SVGAnimated{Boolean, Enumeration, Integer, Number, String}.

Dynamic SVG DOM updates (ie. "someUse.href.baseVal = '#rect'") with these types
didn't work. Existing gradient updating examples relied on calling setAttribute
after a SVG DOM update - that was the only reason it worked, added a new test
only using SVG DOM updates (js-update-stop.svg).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam.
rwlbuis [Sat, 20 Jan 2007 21:52:27 +0000 (21:52 +0000)]
    Reviewed by Sam.

        Respect <text> boundaries for svg text selecting

        Make sure the text selection for svg stays inside
        containing blocks.
        Added one manual test since html selection does not
        seem to work for SVG and selectSubString for SVG
        is not implemented yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated results because my recent check-in made list boxes
darin [Sat, 20 Jan 2007 15:03:43 +0000 (15:03 +0000)]
    - updated results because my recent check-in made list boxes
          one pixel taller

        * fast/forms/HTMLOptionElement_label05-expected.checksum:
        * fast/forms/HTMLOptionElement_label05-expected.png:
        * fast/forms/HTMLOptionElement_label05-expected.txt:
        * fast/forms/form-element-geometry-expected.checksum:
        * fast/forms/form-element-geometry-expected.png:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/listbox-clip-expected.checksum:
        * fast/forms/listbox-clip-expected.png:
        * fast/forms/listbox-clip-expected.txt:
        * fast/forms/listbox-width-change-expected.checksum:
        * fast/forms/listbox-width-change-expected.png:
        * fast/forms/listbox-width-change-expected.txt:
        * fast/forms/option-strip-whitespace-expected.checksum:
        * fast/forms/option-strip-whitespace-expected.png:
        * fast/forms/option-strip-whitespace-expected.txt:
        * fast/forms/select-change-popup-to-listbox-expected.checksum:
        * fast/forms/select-change-popup-to-listbox-expected.png:
        * fast/forms/select-change-popup-to-listbox-expected.txt:
        * fast/replaced/replaced-breaking-expected.checksum:
        * fast/replaced/replaced-breaking-expected.png:
        * fast/replaced/replaced-breaking-expected.txt:
        * fast/text/updateNewFont-expected.checksum:
        * fast/text/updateNewFont-expected.png:
        * fast/text/updateNewFont-expected.txt:

        - reset results since the ones I generated before were on Leopard

        * fast/forms/select-list-box-with-height-expected.checksum:
        * fast/forms/select-list-box-with-height-expected.png:

        - generated some missing pixel results

        * http/tests/navigation/anchor-basic-expected.checksum: Added.
        * http/tests/navigation/anchor-basic-expected.png: Added.
        * http/tests/navigation/anchor-frames-expected.checksum: Added.
        * http/tests/navigation/anchor-frames-expected.png: Added.
        * http/tests/navigation/anchor-goback-expected.checksum: Added.
        * http/tests/navigation/anchor-goback-expected.png: Added.
        * http/tests/navigation/anchor-subframeload-expected.checksum: Added.
        * http/tests/navigation/anchor-subframeload-expected.png: Added.
        * http/tests/navigation/error404-basic-expected.checksum: Added.
        * http/tests/navigation/error404-basic-expected.png: Added.
        * http/tests/navigation/error404-frames-expected.checksum: Added.
        * http/tests/navigation/error404-frames-expected.png: Added.
        * http/tests/navigation/error404-goback-expected.checksum: Added.
        * http/tests/navigation/error404-goback-expected.png: Added.
        * http/tests/navigation/error404-subframeload-expected.checksum: Added.
        * http/tests/navigation/error404-subframeload-expected.png: Added.
        * http/tests/navigation/javascriptlink-basic-expected.checksum: Added.
        * http/tests/navigation/javascriptlink-basic-expected.png: Added.
        * http/tests/navigation/javascriptlink-frames-expected.checksum: Added.
        * http/tests/navigation/javascriptlink-frames-expected.png: Added.
        * http/tests/navigation/javascriptlink-goback-expected.checksum: Added.
        * http/tests/navigation/javascriptlink-goback-expected.png: Added.
        * http/tests/navigation/javascriptlink-subframeload-expected.checksum: Added.
        * http/tests/navigation/javascriptlink-subframeload-expected.png: Added.
        * http/tests/navigation/metaredirect-basic-expected.checksum: Added.
        * http/tests/navigation/metaredirect-basic-expected.png: Added.
        * http/tests/navigation/metaredirect-frames-expected.checksum: Added.
        * http/tests/navigation/metaredirect-frames-expected.png: Added.
        * http/tests/navigation/metaredirect-goback-expected.checksum: Added.
        * http/tests/navigation/metaredirect-goback-expected.png: Added.
        * http/tests/navigation/metaredirect-subframeload-expected.checksum: Added.
        * http/tests/navigation/metaredirect-subframeload-expected.png: Added.
        * http/tests/navigation/post-basic-expected.checksum: Added.
        * http/tests/navigation/post-basic-expected.png: Added.
        * http/tests/navigation/post-frames-expected.checksum: Added.
        * http/tests/navigation/post-frames-expected.png: Added.
        * http/tests/navigation/post-goback1-expected.checksum: Added.
        * http/tests/navigation/post-goback1-expected.png: Added.
        * http/tests/navigation/post-goback2-expected.checksum: Added.
        * http/tests/navigation/post-goback2-expected.png: Added.
        * http/tests/navigation/postredirect-basic-expected.checksum: Added.
        * http/tests/navigation/postredirect-basic-expected.png: Added.
        * http/tests/navigation/postredirect-frames-expected.checksum: Added.
        * http/tests/navigation/postredirect-frames-expected.png: Added.
        * http/tests/navigation/postredirect-goback1-expected.checksum: Added.
        * http/tests/navigation/postredirect-goback1-expected.png: Added.
        * http/tests/navigation/postredirect-goback2-expected.checksum: Added.
        * http/tests/navigation/postredirect-goback2-expected.png: Added.
        * http/tests/navigation/redirect302-basic-expected.checksum: Added.
        * http/tests/navigation/redirect302-basic-expected.png: Added.
        * http/tests/navigation/redirect302-frames-expected.checksum: Added.
        * http/tests/navigation/redirect302-frames-expected.png: Added.
        * http/tests/navigation/redirect302-goback-expected.checksum: Added.
        * http/tests/navigation/redirect302-goback-expected.png: Added.
        * http/tests/navigation/redirect302-subframeload-expected.checksum: Added.
        * http/tests/navigation/redirect302-subframeload-expected.png: Added.
        * http/tests/navigation/relativeanchor-basic-expected.checksum: Added.
        * http/tests/navigation/relativeanchor-basic-expected.png: Added.
        * http/tests/navigation/relativeanchor-frames-expected.checksum: Added.
        * http/tests/navigation/relativeanchor-frames-expected.png: Added.
        * http/tests/navigation/relativeanchor-goback-expected.checksum: Added.
        * http/tests/navigation/relativeanchor-goback-expected.png: Added.
        * http/tests/navigation/slowmetaredirect-basic-expected.checksum: Added.
        * http/tests/navigation/slowmetaredirect-basic-expected.png: Added.
        * http/tests/navigation/slowtimerredirect-basic-expected.checksum: Added.
        * http/tests/navigation/slowtimerredirect-basic-expected.png: Added.
        * http/tests/navigation/success200-basic-expected.checksum: Added.
        * http/tests/navigation/success200-basic-expected.png: Added.
        * http/tests/navigation/success200-frames-expected.checksum: Added.
        * http/tests/navigation/success200-frames-expected.png: Added.
        * http/tests/navigation/success200-frames-loadsame-expected.checksum: Added.
        * http/tests/navigation/success200-frames-loadsame-expected.png: Added.
        * http/tests/navigation/success200-goback-expected.checksum: Added.
        * http/tests/navigation/success200-goback-expected.png: Added.
        * http/tests/navigation/success200-loadsame-expected.checksum: Added.
        * http/tests/navigation/success200-loadsame-expected.png: Added.
        * http/tests/navigation/success200-reload-expected.checksum: Added.
        * http/tests/navigation/success200-reload-expected.png: Added.
        * http/tests/navigation/success200-subframeload-expected.checksum: Added.
        * http/tests/navigation/success200-subframeload-expected.png: Added.
        * http/tests/navigation/timerredirect-basic-expected.checksum: Added.
        * http/tests/navigation/timerredirect-basic-expected.png: Added.
        * http/tests/navigation/timerredirect-frames-expected.checksum: Added.
        * http/tests/navigation/timerredirect-frames-expected.png: Added.
        * http/tests/navigation/timerredirect-goback-expected.checksum: Added.
        * http/tests/navigation/timerredirect-goback-expected.png: Added.
        * http/tests/navigation/timerredirect-subframeload-expected.checksum: Added.
        * http/tests/navigation/timerredirect-subframeload-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-20 Mark Rowe <mrowe@apple.com>
bdash [Sat, 20 Jan 2007 09:14:20 +0000 (09:14 +0000)]
2007-01-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Track the output of run-javascriptcore-tests,
        catch single regressions, and don't generate tests results for new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubberstamped by Maciej.
aroben [Sat, 20 Jan 2007 08:45:52 +0000 (08:45 +0000)]
    Rubberstamped by Maciej.

        * Scripts/run-webkit-tests: Change the default behavior back to
        generating results for new tests (this can be disabled with

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Sat, 20 Jan 2007 00:40:52 +0000 (00:40 +0000)]

        Reviewed by Hyatt.

        Test for <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

        * fast/forms/select-size-expected.checksum: Added.
        * fast/forms/select-size-expected.png: Added.
        * fast/forms/select-size-expected.txt: Added.
        * fast/forms/select-size.html: Added.


        Reviewed by Hyatt.

        Fix for: <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

        Update the size attribute value for select elements to match the numeric value.  This is a special case since this
        attribute is used to determine which control to use.  We want to make sure that the size attribute is valid when we match
        CSS rules.

        Test: fast/forms/select-size.html

        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): If the attribute string value is not the
          same as its integer value, then update the attribute value to match the integer.
        * dom/Attribute.h: Made setValue and setPrefix public.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth.
aroben [Sat, 20 Jan 2007 00:32:01 +0000 (00:32 +0000)]
    Reviewed by Beth.

        Fix <rdar://problem/4942294> REGRESSION: "Spelling and Grammar",
        "Font", "Speech", and "Writing Direction" are missing from contextual

        * WebCoreSupport/WebContextMenuClient.mm:
        (fixMenusForOldClients): Change our new SPI tags to
        WebMenuItemTagOther because old clients aren't expecting the new tags.
        (fixMenusFromOldClients): Use each menu item's title to figure out its
        correct tag again.
        (WebContextMenuClient::getCustomMenuFromDefaultItems): Call
        fixMenusForOldClients before calling up to the delegate.
        * WebView/WebUIDelegatePrivate.h: Define WEBMENUITEMTAG_SPI_START so
        that we can use it in WebContextMenuClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sullivan [Sat, 20 Jan 2007 00:02:03 +0000 (00:02 +0000)]

        Reviewed by Darin

        - WebCore part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to
          type a character before username/password autofill kicks in

        * loader/FrameLoaderClient.h:
        new dispatchDidFinishDocumentLoad call

        * loader/FrameLoader.cpp:
        call dispatchDidFinishDocumentLoad

        * platform/graphics/svg/SVGImageEmptyClients.h:
        empty implementation for dispatchDidFinishDocumentLoad


        Reviewed by Darin

        - WebKit part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to
          type a character before username/password autofill kicks in

        Added new webView:didFinishDocumentLoadForFrame: SPI and wired it up

        * WebView/WebViewPrivate.h:
        declare new delegate method

        * WebCoreSupport/WebFrameLoaderClient.h:
        declare dispatchDidFinishDocumentLoad()

        * WebCoreSupport/WebFrameLoaderClient.mm:
        new method, calls new delegate method

        * DefaultDelegates/WebDefaultFrameLoadDelegate.m:
        (-[WebDefaultFrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
        empty default implementation of new delegate method


        Added stubs for new callbacks, to try to avoid breaking the Qt port.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        * WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Fri, 19 Jan 2007 23:48:58 +0000 (23:48 +0000)]

        Reviewed by Hyatt.

        Test for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at http://macreviewzone.com/index.php

        * fast/forms/control-restrict-line-height-expected.checksum: Added.
        * fast/forms/control-restrict-line-height-expected.png: Added.
        * fast/forms/control-restrict-line-height-expected.txt: Added.
        * fast/forms/control-restrict-line-height.html: Added.


        Reviewed by Hyatt.

        Fix for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at http://macreviewzone.com/index.php

        Test: fast/forms/control-restrict-line-height.html

        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize): Don't honor line-height for controls that
          have restricted font size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
andersca [Fri, 19 Jan 2007 23:18:20 +0000 (23:18 +0000)]
    Reviewed by John Sullivan.

        REGRESSION(r18910): Crash in WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
        Move code from initWithFrame in here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix date.
darin [Fri, 19 Jan 2007 23:15:51 +0000 (23:15 +0000)]
Fix date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix bug number.
darin [Fri, 19 Jan 2007 23:15:21 +0000 (23:15 +0000)]
Fix bug number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Fri, 19 Jan 2007 23:12:20 +0000 (23:12 +0000)]

        Reviewed by Adele.

        - test for html4.css problem where we had a missing semicolon and thus missed
          parsing a style rule

        * fast/forms/radio-no-theme-padding-expected.txt: Added.
        * fast/forms/radio-no-theme-padding.html: Added.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12008
          <rdar://problem/4901834> REGRESSION(NativeListBox): Focus is not placed on
          SELECT after mousing down on OPTION

        * fast/forms/select-list-box-mouse-focus-expected.txt: Added.
        * fast/forms/select-list-box-mouse-focus.html: Added.

        - test for http://bugs.webkit.org/show_bug.cgi?id=11999
          <rdar://problem/4940442> REGRESSION: Incomplete listing in TVListings window (11999)

        Note: Only the pixel test shows the failure in the old version.

        Note: I generated the pixel results on Leopard -- may need to be
        regenated on Tiger.

        * fast/forms/select-list-box-with-height-expected.checksum: Added.
        * fast/forms/select-list-box-with-height-expected.png: Added.
        * fast/forms/select-list-box-with-height-expected.txt: Added.
        * fast/forms/select-list-box-with-height.html: Added.


        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11999
          <rdar://problem/4940442> REGRESSION: Incomplete listing in TVListings window (11999)
          Fix was to use the actual size of the renderer in the RenderListBox
          case, instead of always using the size specified by the select element.

        Test: fast/forms/select-list-box-with-height.html

        - fix http://bugs.webkit.org/show_bug.cgi?id=12008
          <rdar://problem/4901834> REGRESSION(NativeListBox): Focus is not placed on
          SELECT after mousing down on OPTION

        Test: fast/forms/select-list-box-mouse-focus.html

        - fix bug where auto-scrolling was not working in list box select elements

        No test yet.

        - fix a missing semicolon in the radio/checkbox section of html4.css

        Test: fast/forms/radio-no-theme-padding.html

        - fix bug where the scroll bars for select elements were pixel-type scroll
          bars even though the scrolling is line at a time scrolling

        No test.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::selectAll): Removed an explicit call
        to repaint, since the RenderListBox now does that in selectionChanged.
        (WebCore::HTMLSelectElement::notifyOptionSelected): Call the new
        selectionChanged instead of the old setSelectionChanged.
        (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Added a call
        to focus. Removed an explicit call to repaint and added a call to the
        new setMouseDownMayStartAutoscroll function in EventHandler. Removed an
        explicit call to repaint as above.
        (WebCore::HTMLSelectElement::updateListBoxSelection): Call the new
        selectionChanged instead of the old setSelectionChanged.

        * page/EventHandler.h: Added setMouseDownMayStartAutoscroll, needed
        because the existing code to set that flag won't get triggered when
        the select element's default event handler handles the event.

        * rendering/RenderListBox.h: Made ScrollbarClient a private base class.
        Removed setSelectionChanged and m_selectionChanged. Added selectionChanged,
        which is really just a synonym for repaint for now. Moved valueChanged,
        the ScrollbarClient function implementations, and itemHeight into the
        private part of the class. Added numVisibleItems() and listHeight() to
        the private section. Changed m_vBar to be a RefPtr.

        * rendering/RenderListBox.cpp: Removed unneeded includes. Moved all
        the constants to the top of the file.
        (WebCore::RenderListBox::RenderListBox): Removed initialization of
        m_selectionChanged because it was removed and of m_vBar because it's
        now a RefPtr which is automaticall initialized.
        (WebCore::RenderListBox::~RenderListBox): Removed the explicit deref of
        m_vBar because it's a RefPtr. Added null checking for FrameView.
        (WebCore::RenderListBox::updateFromElement): Use numItems().
        (WebCore::RenderListBox::calcMinMaxWidth): Added null checking for
        FrameView and used RefPtr for the newly-created scroll bar.
        (WebCore::RenderListBox::size): Tweaked formatting. Also renamed the
        misleading minDefaultSize to maxDefaultSize, since it's a maximum.
        (WebCore::RenderListBox::numVisibleItems): Added. Used in many places
        where size() was used before. This computes the number of rows we have
        room for. We don't need a row space after the last row, and this takes
        that into account.
        (WebCore::RenderListBox::numItems): Tweaked to remove the local variable.
        (WebCore::RenderListBox::listHeight): Added. Total height of all the rows
        and spaces between them.
        (WebCore::RenderListBox::calcHeight): Changed to call itemHeight for the
        row height, and to subtract the last row spacing off since we don't need
        a space after the last row. Changed the scroll bar setup to make it
        correspond to row numbers, not pixel numbers.
        (WebCore::RenderListBox::baselinePosition): Moved the comment to the
        constant declaration at the top of the file.
        (WebCore::RenderListBox::itemBoundingBoxRect): Simplified by using
        the itemHeight() function.
        (WebCore::RenderListBox::paintObject): Changed to use numItems and
        to use numVisibleItems instead of size.
        (WebCore::RenderListBox::isPointInScrollbar): Added get() call since
        m_vBar is now a RefPtr.
        (WebCore::RenderListBox::listIndexAtOffset): Changed to use numItems(),
        itemHeight(), and rearranged a min/max combo so it starts with the low,
        then the value, then the high value for pinning.
        (WebCore::RenderListBox::autoscroll): Use numVisibleItems() instead of
        (WebCore::RenderListBox::stopAutoscroll): Removed an unneeded nil check
        of the element.
        (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Changed
        to use numItems() and to use numVisibleItems() instead of size().
        Also changed scroll bar code to work more simply now that the scroll
        bar is row-based.
        (WebCore::RenderListBox::listIndexIsVisible): Changed to use
        numVisibleItems() instead of size().
        (WebCore::RenderListBox::valueChanged): Simplified since the scrollbar
        is now row-based. Also removed an unnecessary null check.
        (WebCore::RenderListBox::itemHeight): Updated for name change from
        optionsSpacingMiddle to rowSpacing.
        (WebCore::RenderListBox::scrollHeight): Changed to use listHeight().
        (WebCore::RenderListBox::setScrollTop): Simplified, and removed the code
        that does nothing if the computed list index is visible (which did not
        make sense for this function and seemed a cut and paste error from the
        scrollToReveal function). The scrollbar part is simpler now that it's
        (WebCore::RenderListBox::windowClipRect): Changed to use document()->view()
        so we don't have to include RenderView.h.

        * css/html4.css: Added a semicolon I noticed was missing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
bdakin [Fri, 19 Jan 2007 21:57:23 +0000 (21:57 +0000)]
        Reviewed by Maciej and Darin.

        Fix for <rdar://problem/4702420> REGRESSION: Null characters need
        to be stripped from text nodes (townhall.com)

        This was a regression from the fix for <rdar://problem/3727939>
        Safari strips \0 characters from HTML tags making them valid, which
        was fixed with r12652. We still need to strip null characters in
        text nodes.

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::write): No behavior change here, this is
        just to make Darin happy.
        (WebCore::HTMLTokenizer::processToken): Call into StringImpl's new
        createStrippingNull function instead of the normal StringImpl
        * platform/StringImpl.cpp:
        (WebCore::StringImpl::createStrippingNull): Strip null.
        * platform/StringImpl.h:

        Reviewed by Maciej and Darin.

        New layout tests and some updates results for the fix for <rdar://
        problem/4702420> REGRESSION: Null characters need to be stripped
        from text nodes (townhall.com)

        * fast/dom/stripNullFromTextNodes-expected.checksum: Added.
        * fast/dom/stripNullFromTextNodes-expected.png: Added.
        * fast/dom/stripNullFromTextNodes-expected.txt: Added.
        * fast/dom/stripNullFromTextNodes.html: Added.
        * fast/js/null-char-in-string-expected.txt: New results.
        * fast/text/stripNullFromText-expected.checksum: Added.
        * fast/text/stripNullFromText-expected.png: Added.
        * fast/text/stripNullFromText-expected.txt: Added.
        * fast/text/stripNullFromText.html: Added.
        * tables/mozilla/images/adforce_imgis_com-expected.txt: New
        * tables/mozilla_expected_failures/images/adforce_imgis_com-
        expected.checksum: Removed. This is the same test as the one above.
        The same test was in two places.
        * tables/mozilla_expected_failures/images/adforce_imgis_com-
        expected.png: Removed.
        * tables/mozilla_expected_failures/images/adforce_imgis_com-
        expected.txt: Removed.
        * tables/mozilla_expected_failures/images/adforce_imgis_com.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ddkilzer [Fri, 19 Jan 2007 21:16:30 +0000 (21:16 +0000)]

        Reviewed by NOBODY (no-svg build fix).

        * ksvg2/svg/SVGMPathElement.cpp: Added #ifdef SVG_SUPPORT/#endif guards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Yet another build fix.
andersca [Fri, 19 Jan 2007 18:25:13 +0000 (18:25 +0000)]
    Yet another build fix.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Try fixing the QT build.
andersca [Fri, 19 Jan 2007 17:59:42 +0000 (17:59 +0000)]
    Try fixing the QT build.

        * WebCoreSupport/ChromeClientQt.cpp:
        * WebCoreSupport/ChromeClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
andersca [Fri, 19 Jan 2007 17:52:06 +0000 (17:52 +0000)]
    Build fix.

        * platform/graphics/svg/SVGImageEmptyClients.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Fri, 19 Jan 2007 17:28:36 +0000 (17:28 +0000)]

        Reviewed by Adam.

        Move JavaScript alert and status bar functions to the chrome.

        * bindings/js/kjs_window.cpp:
        * page/Chrome.cpp:
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/Frame.cpp:
        * page/Frame.h:
        * page/mac/FrameMac.h:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:


        Reviewed by Adam.

        Move functions from the bridge to the chrome client.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        * WebCoreSupport/WebFrameBridge.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the build
zack [Fri, 19 Jan 2007 16:02:22 +0000 (16:02 +0000)]
Fix the build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-19 Eric Seidel <eric@webkit.org>
eseidel [Fri, 19 Jan 2007 14:27:53 +0000 (14:27 +0000)]
2007-01-19  Eric Seidel  <eric@webkit.org>

        Reviewed by rwlbuis.

        More cleanup to SVGAnimated* classes.

        No tests possible (only code cleanup)

        * ksvg2/svg/SVGAnimateMotionElement.cpp:
        * ksvg2/svg/SVGAnimateMotionElement.h:
        * ksvg2/svg/SVGAnimationElement.cpp:
        * ksvg2/svg/SVGAnimationElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoNot reviewed.
zimmermann [Fri, 19 Jan 2007 14:09:26 +0000 (14:09 +0000)]
Not reviewed.
Remove accidently commited debug output. Shame on me :-)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Eric.
zimmermann [Fri, 19 Jan 2007 14:03:41 +0000 (14:03 +0000)]
Reviewed by Eric.

Rewrite <use> support with a real-shadow tree (as the spec demands), and implement SVGElementInstance.
AFAIK we're the first implementing this SVG feature - after ASV3 (!).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-19 Eric Seidel <eric@webkit.org>
eseidel [Fri, 19 Jan 2007 13:42:39 +0000 (13:42 +0000)]
2007-01-19  Eric Seidel  <eric@webkit.org>

        Reviewed by rwlbuis.

        Add support for SVGMPathElement parsing.

        No test cases possible (SVGAnimateMotion doesn't work yet)

        * WebCore.xcodeproj/project.pbxproj:
        * ksvg2/svg/SVGAnimateMotionElement.cpp:
        * ksvg2/svg/SVGMPathElement.cpp: Added.
        * ksvg2/svg/SVGMPathElement.h: Added.
        * ksvg2/svg/SVGNumberList.cpp:
        (WebCore::SVGNumberList::parse): fix typo in comment
        * ksvg2/svg/svgtags.in: add back mpath

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-19 Eric Seidel <eric@webkit.org>
eseidel [Fri, 19 Jan 2007 12:59:22 +0000 (12:59 +0000)]
2007-01-19  Eric Seidel  <eric@webkit.org>

        Reviewed by rwlbuis.

        Implement better parsing for keyTimes, keySplines and keyPoints.

        Unfortunately none of this code is used much yet, thus isn't very testable.

        * ksvg2/svg/SVGAnimateMotionElement.cpp:
        * ksvg2/svg/SVGAnimationElement.cpp:
        * ksvg2/svg/SVGAnimationElement.h:
        * ksvg2/svg/SVGNumberList.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
lars [Fri, 19 Jan 2007 10:09:26 +0000 (10:09 +0000)]
    Reviewed by Adam Roben.

        run-webkit-tests does now not generate new results by default anymore.
        You'll have to pass the --new-tests flag to it to force it to do so.

        This is required to make it possible to have tests running on multiple
        platforms peacefully together.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
aroben [Fri, 19 Jan 2007 06:49:12 +0000 (06:49 +0000)]

        Reviewed by Beth.

        Fix: <rdar://problem/4939672> REGRESSION: With text selected that is
        not a link, the "Remove Link" contextual menu item remains active

        * platform/ContextMenuItem.h: Added enabled method.
        * platform/qt/ContextMenuItemQt.cpp:
        (WebCore::ContextMenuItem::enabled): Implemented.
        * platform/mac/ContextMenuItemMac.mm:
        (WebCore::ContextMenuItem::enabled): Ditto.
        * platform/mac/ContextMenuMac.mm:
        (-[WebCoreMenuTarget validateMenuItem:]): Implemented to fulfill the
        NSMenuValidation protocol.


        Reviewed by Beth.

        Fix <rdar://problem/4939672> REGRESSION: With text selected that is
        not a link, the "Remove Link" contextual menu item remains active

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView menuForEvent:]): Leave autoenabling of menu items on so
        that clients can implement validateMenuItem:.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
bdakin [Fri, 19 Jan 2007 06:28:01 +0000 (06:28 +0000)]
    Reviewed by Adele.

        Fix for <rdar://problem/4939558> REGRESSION: "Search in Google",
        "Search in Spotlight" and "Look up in Dictionary" are missing
        initially from the contextual menu

        The bug here is that we select the we were selecting the word after
        the context menu event was dispatched and after the context menu
        was built up.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::sendContextMenuEvent): Select the word
        before dispatching the event. It is safe to remove the check for
        swallowEvent since WebCore context menus ensure that we always
        swallow the event anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-18 Mark Rowe <mrowe@apple.com>
bdash [Fri, 19 Jan 2007 05:11:14 +0000 (05:11 +0000)]
2007-01-18  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim H.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=7926
        Bug 7926: Crash using -callWebScriptMethod to access offsetTop property

        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]): Bail out early if function value is an immediate,
        or if the function object is not callable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-18 Sam Weinig <sam@webkit.org>
bdash [Fri, 19 Jan 2007 03:34:57 +0000 (03:34 +0000)]
2007-01-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11853
        REGRESSION (r17352): Whitespace in <title> is rendered

        * loader/DocumentLoader.cpp:
        (WebCore::canonicalizedTitle): Changed to also collapse internal
        whitespace.  This required removing an optimization that is no
        longer possible.
        * manual-tests/title-internal-whitespace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-18 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 19 Jan 2007 01:23:23 +0000 (01:23 +0000)]
2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12039
          Assertion failure in WebCore::Font::primaryFont

        Test: fast/text/font-initial.html

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Give 'font: initial' the
        Standard generic family. This makes the FontDescription different from
        that of the initial font of a GraphicsContext, ensuring that the latter
        will not be used.

2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12039
          Assertion failure in WebCore::Font::primaryFont

        * fast/text/font-initial-expected.checksum: Added.
        * fast/text/font-initial-expected.png: Added.
        * fast/text/font-initial-expected.txt: Added.
        * fast/text/font-initial.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-19 Nicholas Shanks <contact@nickshanks.com>
bdash [Fri, 19 Jan 2007 01:19:23 +0000 (01:19 +0000)]
2007-01-19  Nicholas Shanks  <contact@nickshanks.com>

        Reviewed by Maciej.

        Change doctype for webkit.org/blog/ admin interface to HTML 4.01.

        * blog/wp-admin/admin-header.php:
        * blog/wp-login.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-18 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 19 Jan 2007 01:14:37 +0000 (01:14 +0000)]
2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11451
          REGRESSION: Dell.com does not render correctly in ToT (stylesheet not loaded)

        Test: http/tests/misc/css-accept-any-type.html

        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): Changed the accept header
        for stylesheets to "text/css,*/*;q=0.1" to match Firefox, accepting CSS served
        as any type.

2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=11451
          REGRESSION: Dell.com does not render correctly in ToT (stylesheet not loaded)

        * http/tests/misc/css-accept-any-type-expected.txt: Added.
        * http/tests/misc/css-accept-any-type.html: Added.
        * http/tests/misc/resources/stylesheet.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-18 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 19 Jan 2007 01:11:49 +0000 (01:11 +0000)]
2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11271
        REGRESSION (r12358): Text in display: table unselectable

        Test: editing/selection/display-table-text.html

        * editing/htmlediting.cpp:
        (WebCore::isTableElement): Changed to return false for text nodes.

2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=11271
        REGRESSION (r12358): Text in display: table unselectable

        * editing/selection/display-table-text-expected.checksum: Added.
        * editing/selection/display-table-text-expected.png: Added.
        * editing/selection/display-table-text-expected.txt: Added.
        * editing/selection/display-table-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele
beidson [Fri, 19 Jan 2007 01:10:39 +0000 (01:10 +0000)]
    Reviewed by Adele

        <rdar://problem/4917290> -
        Null deref in WebFrameLoaderClient::restoreScrollPositionAndViewState()
        after regaining network connection

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::restoreScrollPositionAndViewState): Bail early with a null currentItem, preventing
        a crash in release builds.  Leave the ASSERT to help find other cases where this might happen in debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-18 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 19 Jan 2007 01:08:03 +0000 (01:08 +0000)]
2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=6218
          CSS1: WebTextRenderer caches and re-uses fallback renderers that are based on family lists

        This patch takes character-to-glyph mapping out of FontData and instead makes
        each Font keep its own mapping, using a shared set of glyph page fallback trees.

        For each page number there is (at most) one tree. A path from the root to a
        node in the tree corresponds to a fallback list of FontDatas. The node points to
        a page (which may be shared with other nodes) that maps each character in its range
        to a glyph in the first FontData in the fallback list that has it, or to 0 if none of
        the FontDatas has a glyph for that character. A special kind of node, that can
        only occur as a leaf, corresponds to using system fallback fonts after the list
        has been exhausted. This prevents system fallback from polluting non-leaf

        Nodes and pages are initialized lazily and employ "copy on write".

        * CMakeLists.txt:
        * WebCore.pro:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * platform/Font.cpp:
        (WebCore::WidthIterator::WidthIterator): Removed substituteFontData.
        (WebCore::WidthIterator::advance): Moved all character-to-glyph mapping logic out
        of here and replaced it with a call to Font::glyphDataForCharacter().
        (WebCore::Font::glyphDataForCharacter): Added. This method performs the lookup in the
        page fallback trees, triggering lazy initialization as needed, and caching pointers to
        the retrieved page tree nodes in the font.
        (WebCore::Font::floatWidthForSimpleText): Removed substituteFont argument.
        * platform/Font.h:
        * platform/FontData.cpp:
        * platform/FontData.h:
        (WebCore::FontData::missingGlyphData): Added. Returns the "missing glyph" GlyphData for
        this FontData.
        * platform/GlyphMap.cpp: Removed.
        * platform/GlyphMap.h: Removed.
        * platform/GlyphPageTreeNode.cpp: Renamed GlyphMap.cpp to this.
        (WebCore::GlyphPageTreeNode::getRoot): Added. Returns the root of the page fallback tree for
        the given page number.
        (WebCore::GlyphPageTreeNode::initializePage): Added. Helper method that initializes the page
        pointer of a node, possibly to a pointer to another node's page or to 0.
        (WebCore::GlyphPageTreeNode::getChild): Added.
        * platform/GlyphPageTreeNode.h: Renamed GlyphMap.h to this.
        (WebCore::GlyphPageTreeNode::isSystemFallback): Added. Returns whether the node corresponds
        to the system providing fallback fonts, which is done on a character-by-character basis.
        * platform/gdk/GlyphMapGdk.cpp: Removed.
        * platform/gdk/GlyphPageTreeNodeGdk.cpp: Renamed GlyphMapGdk.cpp to this.
        * platform/mac/FontDataMac.mm:
        * platform/mac/FontMac.mm:
        * platform/mac/GlyphMapMac.cpp: Removed.
        * platform/mac/GlyphPageTreeNodeMac.cpp: Renamed GlypMapMac.cpp to this.
        (WebCore::GlyphPage::fill): Changed to return false if the font has no glyphs in the page.
        * platform/qt/GlyphMapQt.cpp: Removed.
        * platform/qt/GlyphPageTreeNodeQt.cpp: Renamed GlyphMapQt.cpp to this.
        * platform/win/GlyphMapWin.cpp: Removed.
        * platform/win/GlyphPageTreeNodeWin.cpp: Renamed GlyphMapWin to this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-18 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 19 Jan 2007 01:03:05 +0000 (01:03 +0000)]
2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=9952
          REGRESSION: Repro crash when dragging an image from the window to the address bar

        * page/FrameView.cpp:
        (WebCore::FrameView::~FrameView): Removed the call to Document::detach(). If this
        view is the current view, then the Frame should have already detached the document.
        Added an assertion that this is the case. If this view is not the current view,
        then it cannot access its document, but the page cache should have detached it already.
        Similarly, changed to call RenderPart::setWidget() only if this is the current view
        in the frame.
        (WebCore::FrameView::adjustViewSize): Added an assertion that this view is the current
        view in the frame.
        (WebCore::FrameView::layout): Ditto.
        (WebCore::FrameView::scheduleRelayout): Ditto.
        (WebCore::FrameView::scheduleRelayoutOfSubtree): Ditto.
        (WebCore::FrameView::windowClipRect): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-18 Eric Seidel <eric@webkit.org>
eseidel [Fri, 19 Jan 2007 01:00:41 +0000 (01:00 +0000)]
2007-01-18  Eric Seidel  <eric@webkit.org>

        Reviewed by bdash.

        No test needed, removed bogus debug-only ASSERT.

        * rendering/RenderSVGContainer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-01-18 Sanjay Madhav <sanjay12@gmail.com>
bdash [Fri, 19 Jan 2007 01:00:40 +0000 (01:00 +0000)]
2007-01-18  Sanjay Madhav  <sanjay12@gmail.com>

        Reviewed by Darin.

        Add JavaScriptCore define to help with tracing of when objects are marked.

        * kjs/object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build Fix
aliceli1 [Fri, 19 Jan 2007 00:54:44 +0000 (00:54 +0000)]
    Build Fix

        * platform/mac/PasteboardMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
aliceli1 [Fri, 19 Jan 2007 00:01:00 +0000 (00:01 +0000)]
    Reviewed by Mark Rowe.

        Fixes the leaks from my last patch, except for the first change below which is a missing delegate call for Mail purposes

        * editing/Editor.cpp:
        * platform/Pasteboard.h:
        * platform/mac/PasteboardMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John.
kdecker [Thu, 18 Jan 2007 22:20:31 +0000 (22:20 +0000)]
    Reviewed by John.

        <rdar://problem/4939511> WebKit should set the CG clip path for plug-ins that draw using CoreGraphics

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView drawRect:]):  Set the CG clip path to the plug-in dirty rect. This allows plug-ins to obtain their
        dirty rect using functions like CGContextGetClipBoundingBox().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemoved accidentally-duplicated entries.
sullivan [Thu, 18 Jan 2007 21:38:14 +0000 (21:38 +0000)]
Removed accidentally-duplicated entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin
sullivan [Thu, 18 Jan 2007 21:33:02 +0000 (21:33 +0000)]
    Reviewed by Darin

        - Tests for:
          <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word
          <rdar://problem/4462420> REGRESSION: Mail hangs during Replace All if the replacement string contains the search string

        * editing/spelling/spelling-expected.checksum: Added.
        * editing/spelling/spelling-expected.png: Added.
        * editing/spelling/spelling-expected.txt: Added.
        * editing/spelling/spelling.html: Added.
        * editing/execCommand/find-after-replace-expected.checksum: Added.
        * editing/execCommand/find-after-replace-expected.png: Added.
        * editing/execCommand/find-after-replace-expected.txt: Added.
        * editing/execCommand/find-after-replace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make sure layer autoscrolling puts the event coordinates into the layer's...
hyatt [Thu, 18 Jan 2007 21:14:26 +0000 (21:14 +0000)]
    Make sure layer autoscrolling puts the event coordinates into the layer's coordinate space before
        calling hitTest on it.  Fixes "flashy" selection in textareas.

        Reviewed by darin

        * rendering/RenderLayer.cpp:
        * rendering/RenderTextControl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca [Thu, 18 Jan 2007 21:09:12 +0000 (21:09 +0000)]
    Reviewed by Adam.

        Get rid of ResourceLoaderMac.mm and make willCacheResponse platform-independent.

        * loader/ResourceLoader.cpp:
        * loader/ResourceLoader.h:
        * loader/mac/ResourceLoaderMac.mm: Removed.
        * platform/network/ResourceHandleClient.h:
        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
darin [Thu, 18 Jan 2007 20:44:26 +0000 (20:44 +0000)]
    Reviewed by John Sullivan.

        * Scripts/run-webkit-tests: Fix handling of configuration so it
        does the right thing when no explicit configuration is passed in.
        The old code assumed that the result of setConfiguration() was the
        configuration, but it's undefined when no configuration is
        explicitly passed in. The correct function to use is
        configuration(), and I also streamlined the code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John.
mjs [Thu, 18 Jan 2007 19:13:14 +0000 (19:13 +0000)]
    Reviewed by John.

        - fixed <rdar://problem/4887416> REGRESSION (SearchField): Assertion failure in HTMLInputElement::setValueFromRenderer when editing via drag and drop (11846)

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Don't insert extra paragraph separators to avoid
        nesting blocks in plaintext mode, since that's not an issue under normal circumstances.
        * html/HTMLInputElement.h:
        * manual-tests/drag-move-in-search-field.html: Added.
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::subtreeHasChanged): constrain the value; we'd
        rather truncate it than end up with an illegal value here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoparallel build fix
hausmann [Thu, 18 Jan 2007 17:07:00 +0000 (17:07 +0000)]
parallel build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Thu, 18 Jan 2007 16:39:43 +0000 (16:39 +0000)]

        Reviewed by Darin and Mitz.

        - Test for http://bugs.webkit.org/show_bug.cgi?id=12305
          REGRESSION: Images do not load in video sections on CNN.com homepage

        * fast/dom/HTMLImageElement/image-lowsrc-getset-expected.txt: Added.
        * fast/dom/HTMLImageElement/image-lowsrc-getset.html: Added.


        Reviewed by Darin and Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12305
          REGRESSION: Images do not load in video sections on CNN.com homepage

        <rdar://problem/4931480> REGRESSION: Images do not load in video sections on CNN.com homepage (12305)

        Test: fast/dom/HTMLImageElement/image-lowsrc-getset.html

        * html/HTMLAttributeNames.in: Added lowsrc.
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::isURLAttribute): Added lowsrc.
        (WebCore::HTMLImageElement::lowsrc): Added.
        (WebCore::HTMLImageElement::setLowsrc): Added.
        * html/HTMLImageElement.h: Added lowsrc and setLowsrc.
        * html/HTMLImageElement.idl: Added lowsrc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agofix make clean in the qt build to remove all generated files
hausmann [Thu, 18 Jan 2007 13:00:27 +0000 (13:00 +0000)]
fix make clean in the qt build to remove all generated files

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplementing some load progress tracking in the Qt port.
zack [Thu, 18 Jan 2007 10:04:38 +0000 (10:04 +0000)]
Implementing some load progress tracking in the Qt port.
Reviewed by Lars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
aliceli1 [Thu, 18 Jan 2007 07:47:03 +0000 (07:47 +0000)]

        Reviewed by Harrison.

        Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste

        Migration of some editing code from WebHTMView to WebCore::Editor
        resulted in not calling pasteboardTypesForSelection, which Mail was
        overriding for the special purpose of adding a type to the
        pasteboard after WebKit did.  This patch adds 2 separate code paths
        for Tiger and Leopard.  On Tiger we give in and call the WebView's
        pasteboardTypesForSelection.  On Leopard we call a delegate after
        the pasteboard types are set.

        * bridge/EditorClient.h:
        * editing/Editor.h:
        * platform/Pasteboard.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        * platform/mac/PasteboardMac.mm:


        Reviewed by Harrison.

        Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste

        Migration of some editing code from WebHTMView to WebCore::Editor
        resulted in not calling pasteboardTypesForSelection, which Mail was
        overriding for the special purpose of adding a type to the
        pasteboard after WebKit did.  This patch adds 2 separate code paths
        for Tiger and Leopard.  On Tiger we give in and call the WebView's
        pasteboardTypesForSelection.  On Leopard we call a delegate after
        the pasteboard types are set.

        * DefaultDelegates/WebDefaultEditingDelegate.m:
        (-[WebDefaultEditingDelegate webView:didSetSelectionTypesForPasteboard:]):
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        * WebView/WebEditingDelegate.h:


        Added these stubs to keep the Qt build from failing.

        * WebCoreSupport/EditorClientQt.cpp:
        * WebCoreSupport/EditorClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sullivan [Thu, 18 Jan 2007 04:32:33 +0000 (04:32 +0000)]

        Reviewed by Darin

        - WebCore part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during
          Replace All if the replacement string contains the search string

        * page/Frame.h:
        * page/Frame.cpp:
        new startInSelection parameter -- if true, search starts looking in selection; if false,
        search starts looking after the selection

        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:startInSelection:]):
        new startInSelection parameter, passed through to Frame::findString()

        * editing/JSEditor.cpp:
        pass false for new findString parameter, to match old behavior


        Reviewed by Darin

        - WebKit part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during
          Replace All if the replacement string contains the search string

        * Misc/WebKitVersionChecks.h:
        Added extern "C" so this can be used from .mm files. I don't need this change anymore for
        this fix, but it's still worth fixing now so it doesn't bite anyone later.

        * WebView/WebDocumentPrivate.h:
        Invented new private protocol WebDocumentIncrementalSearching, that has one method. The one
        method is just like the one WebDocumentSearching method, but with an additional parameter.
        We hope to eliminate this dependence on protocols someday, but adding another one as SPI
        seems like it won't make anything worse.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]):
        now calls through to new method that has one additional parameter, passing NO to match old behavior
        (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        pass new parameter to bridge

        * WebView/WebPDFView.h:
        Declare conformance to WebDocumentIncrementalSearching protocol

        * WebView/WebPDFView.mm:
        (-[WebPDFView searchFor:direction:caseSensitive:wrap:]):
        now calls through to new method that has one additional parameter, passing NO to match old behavior
        (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection

        * WebView/WebViewPrivate.h:
        Declare new searchFor:direction:caseSensitive:wrap:startInSelection: method, just like existing
        method but with one additional parameter

        * WebView/WebView.mm:
        (-[WebView searchFor:direction:caseSensitive:wrap:]):
        now calls through to new method that has one additional parameter, passing NO to match old behavior
        (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemoved an internal change I had I wasn't supposed to commit. *sigh*
beidson [Thu, 18 Jan 2007 04:00:35 +0000 (04:00 +0000)]
Removed an internal change I had I wasn't supposed to commit.  *sigh*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18927 268f45cc-cd09-0410-ab3c-d52691b4dbfc