WebKit-https.git
11 years ago2010-08-07 Sheriff Bot <webkit.review.bot@gmail.com>
abecsi@webkit.org [Sat, 7 Aug 2010 12:22:02 +0000 (12:22 +0000)]
2010-08-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r64904.
        http://trac.webkit.org/changeset/64904
        https://bugs.webkit.org/show_bug.cgi?id=43671

        Broke the Qt Windows builders. (Requested by bbandix on
        #webkit).

        * WebCore.pri:
        * WebCore.pro:
        * features.pri: Removed.
2010-08-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r64904.
        http://trac.webkit.org/changeset/64904
        https://bugs.webkit.org/show_bug.cgi?id=43671

        Broke the Qt Windows builders. (Requested by bbandix on
        #webkit).

        * WebKit.pro:
2010-08-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r64904.
        http://trac.webkit.org/changeset/64904
        https://bugs.webkit.org/show_bug.cgi?id=43671

        Broke the Qt Windows builders. (Requested by bbandix on
        #webkit).

        * WebKit2.pri: Removed.
        * WebKit2.pro:
        * WebProcess.pro: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-07 Balazs Kelemen <kb@inf.u-szeged.hu>
abecsi@webkit.org [Sat, 7 Aug 2010 11:47:55 +0000 (11:47 +0000)]
2010-08-07  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Eric Seidel.

        NPAPI headers should be included through npruntime_internal.h

        https://bugs.webkit.org/show_bug.cgi?id=43620

        * DerivedSources.pro:
        * WebProcess/Plugins/NPJSObject.h:
        * WebProcess/Plugins/NPRuntimeUtilities.h:
        * WebProcess/Plugins/Netscape/NetscapePluginStream.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-07 Balazs Kelemen <kb@inf.u-szeged.hu>
abecsi@webkit.org [Sat, 7 Aug 2010 11:44:03 +0000 (11:44 +0000)]
2010-08-07  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Eric Seidel.

        [Qt] Build WebKit2 into a static lib

        https://bugs.webkit.org/show_bug.cgi?id=43621

        Just build changes so no new tests.

        * WebCore.pri: Moved feature detection logic into features.pri since we need this in WebKit2.pro as well.
        * WebCore.pro: Moved the specification of the WebKit2 build to WebKit2.pro. Link against the static lib.
        * features.pri: Added.
2010-08-07  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Eric Seidel.

        [Qt] Build WebKit2 into a static lib

        https://bugs.webkit.org/show_bug.cgi?id=43621

        * WebKit.pro: Moved WebKit2 into the subdirs before WebCore since WebCore links against the WebKit2 lib.
2010-08-07  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Eric Seidel.

        [Qt] Build WebKit2 into a static lib

        https://bugs.webkit.org/show_bug.cgi?id=43621

        * WebKit2.pri: Added. Defined addWebKit2Lib function that defines how to link against the static lib.
        * WebKit2.pro:  Build specification for the WebKit2 framework.
        * WebProcess.pro: Copied from WebKit2/WebKit2.pro. Build specification for the WebProcess binary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, test expectation update.
tkent@chromium.org [Sat, 7 Aug 2010 09:32:18 +0000 (09:32 +0000)]
Unreviewed, test expectation update.

* platform/chromium/drt_expectations.txt:
 Update DRT expectation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 7 Aug 2010 09:28:58 +0000 (09:28 +0000)]
2010-08-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Remove workarounds in two dynamic-updates scripts, that now work without it.

        * svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-result-attr.js:
        * svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-07 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 7 Aug 2010 09:25:48 +0000 (09:25 +0000)]
2010-08-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Daniel Bates.

        Pattern fill with image not rendered after reload
        https://bugs.webkit.org/show_bug.cgi?id=41596

        Fixed by a one-liner. Instead of just invalidating it's own resources, images also have to update
        resources in the ancestor chain, if imageChanged() has been called (for example, a slow loading image)

        Test: http/tests/misc/slow-loading-image-in-pattern.html

        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::imageChanged):

2010-08-07  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Daniel Bates.

        Pattern fill with image not rendered after reload
        https://bugs.webkit.org/show_bug.cgi?id=41596

        Added test verifying that resources are properly updated, if an image child element has changed.

        * http/tests/misc/slow-loading-image-in-pattern.html: Added.
        * platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
        * platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
        * platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Sat, 7 Aug 2010 09:17:33 +0000 (09:17 +0000)]
2010-08-07  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium-win/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
          Rebaseline for r64890.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-07 Alex Nicolaou <anicolao@chromium.org>
zimmermann@webkit.org [Sat, 7 Aug 2010 07:13:12 +0000 (07:13 +0000)]
2010-08-07  Alex Nicolaou  <anicolao@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Remove obsolete baselines for win-xp and win-vista, all windows platforms are the same for this test
        https://bugs.webkit.org/show_bug.cgi?id=43669

        * platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum: Removed.
        * platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.
        * platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum: Removed.
        * platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sat, 7 Aug 2010 06:27:28 +0000 (06:27 +0000)]
2010-08-06  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Generalize SVGPathParser to allow more than just strings as input source
        https://bugs.webkit.org/show_bug.cgi?id=43618

        Generalize SVGPathParser, by allowing different parsing sources than just strings.
        For now only a SVGPathStringSource is available, parsing from bytestreams follows soon.
        Each client that wants to parse strings, like Path or SVGPathSegList objects, only
        needs to use the new central SVGPathParserFactory, which glues consumer and sources together.
        Moved the SVGPathSegType enum from SVGPathSeg class in WebCore namespace, for
        easier access throughout the SVG code.

        Doesn't affect any tests.

        * Android.mk:
        * CMakeLists.txt
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj
        * svg/SVGAllInOne.cpp:
        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
        * svg/SVGGlyphElement.cpp:
        (WebCore::parsePathData):
        * svg/SVGPathBuilder.cpp:
        (WebCore::SVGPathBuilder::SVGPathBuilder):
        (WebCore::SVGPathBuilder::moveTo):
        (WebCore::SVGPathBuilder::lineTo):
        (WebCore::SVGPathBuilder::curveToCubic):
        (WebCore::SVGPathBuilder::closePath):
        * svg/SVGPathBuilder.h:
        (WebCore::SVGPathBuilder::setCurrentPath):
        (WebCore::SVGPathBuilder::arcTo):
        * svg/SVGPathConsumer.h:
        * svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::parseMappedAttribute):
        * svg/SVGPathParser.cpp:
        (WebCore::SVGPathParser::SVGPathParser):
        (WebCore::SVGPathParser::parseClosePathSegment):
        (WebCore::SVGPathParser::parseMoveToSegment):
        (WebCore::SVGPathParser::parseLineToSegment):
        (WebCore::SVGPathParser::parseLineToHorizontalSegment):
        (WebCore::SVGPathParser::parseLineToVerticalSegment):
        (WebCore::SVGPathParser::parseCurveToCubicSegment):
        (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment):
        (WebCore::SVGPathParser::parseCurveToQuadraticSegment):
        (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment):
        (WebCore::SVGPathParser::parseArcToSegment):
        (WebCore::SVGPathParser::parsePathDataFromSource):
        (WebCore::SVGPathParser::decomposeArcToCubic):
        * svg/SVGPathParser.h:
        (WebCore::SVGPathParser::setCurrentConsumer):
        * svg/SVGPathParserFactory.cpp: Added.
        (WebCore::globalSVGPathBuilder):
        (WebCore::globalSVGPathSegListBuilder):
        (WebCore::globalSVGPathParser):
        (WebCore::SVGPathParserFactory::self):
        (WebCore::SVGPathParserFactory::SVGPathParserFactory):
        (WebCore::SVGPathParserFactory::~SVGPathParserFactory):
        (WebCore::SVGPathParserFactory::buildPathFromString):
        (WebCore::SVGPathParserFactory::buildSVGPathSegListFromString):
        * svg/SVGPathParserFactory.h: Added.
        * svg/SVGPathSeg.h:
        (WebCore::):
        (WebCore::SVGPathSeg::~SVGPathSeg):
        (WebCore::SVGPathSeg::):
        (WebCore::SVGPathSeg::pathSegType):
        (WebCore::SVGPathSeg::pathSegTypeAsLetter):
        (WebCore::SVGPathSeg::toString):
        (WebCore::SVGPathSeg::associatedAttributeName):
        (WebCore::SVGPathSeg::SVGPathSeg):
        (WebCore::SVGPathSegSingleCoord::SVGPathSegSingleCoord):
        (WebCore::SVGPathSegSingleCoord::setX):
        (WebCore::SVGPathSegSingleCoord::x):
        (WebCore::SVGPathSegSingleCoord::setY):
        (WebCore::SVGPathSegSingleCoord::y):
        (WebCore::SVGPathSegSingleCoord::toString):
        * svg/SVGPathSegList.cpp:
        (WebCore::SVGPathSegList::getPathSegAtLength):
        (WebCore::SVGPathSegList::toPathData):
        (WebCore::SVGPathSegList::createAnimated):
        * svg/SVGPathSegListBuilder.cpp:
        (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder):
        (WebCore::SVGPathSegListBuilder::moveTo):
        (WebCore::SVGPathSegListBuilder::lineTo):
        (WebCore::SVGPathSegListBuilder::curveToCubic):
        (WebCore::SVGPathSegListBuilder::curveToCubicSmooth):
        (WebCore::SVGPathSegListBuilder::curveToQuadratic):
        (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth):
        (WebCore::SVGPathSegListBuilder::arcTo):
        * svg/SVGPathSegListBuilder.h:
        (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList):
        * svg/SVGPathSource.h: Added.
        (WebCore::SVGPathSource::~SVGPathSource):
        (WebCore::SVGPathSource::SVGPathSource):
        * svg/SVGPathStringSource.cpp: Added.
        (WebCore::SVGPathStringSource::SVGPathStringSource):
        (WebCore::SVGPathStringSource::~SVGPathStringSource):
        (WebCore::SVGPathStringSource::endOfStream):
        (WebCore::SVGPathStringSource::parseFloat):
        (WebCore::SVGPathStringSource::parseFlag):
        (WebCore::SVGPathStringSource::skipSpaces):
        (WebCore::SVGPathStringSource::parseSVGSegmentType):
        (WebCore::SVGPathStringSource::hasRemainingCoordinatesInCurrentCommand):
        * svg/SVGPathStringSource.h: Added.
        (WebCore::SVGPathStringSource::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 7 Aug 2010 06:20:21 +0000 (06:20 +0000)]
2010-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add missing files from last commit - per Alex request.

        * platform/chromium-win/svg/custom/mask-colorspace-expected.checksum: Added.
        * platform/chromium-win/svg/custom/mask-colorspace-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Alex Nicolaou <anicolao@chromium.org>
abarth@webkit.org [Sat, 7 Aug 2010 05:03:10 +0000 (05:03 +0000)]
2010-08-06  Alex Nicolaou  <anicolao@chromium.org>

        Reviewed by Darin Adler.

        recent colorspace changes have fixed svg/custom/grayscale-gradient-mask.svg
        https://bugs.webkit.org/show_bug.cgi?id=43104

        New baselines for windows and linux for two tests affected by the bug fix
        for https://bugs.webkit.org/show_bug.cgi?id=42228 where I failed to rebaseline
        them properly at that time.

        * platform/chromium-linux/svg/custom/grayscale-gradient-mask-expected.checksum:
        * platform/chromium-win/svg/custom/grayscale-gradient-mask-expected.checksum:
        * platform/chromium-win/svg/custom/grayscale-gradient-mask-expected.png:
        * platform/chromium-win/svg/custom/mask-colorspace-expected.checksum: Added.
        * platform/chromium-win/svg/custom/mask-colorspace-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Alex Nicolaou <anicolao@chromium.org>
abarth@webkit.org [Sat, 7 Aug 2010 04:27:34 +0000 (04:27 +0000)]
2010-08-06  Alex Nicolaou  <anicolao@chromium.org>

        Reviewed by Dirk Schulze.

        can't see anything wrong with the output for circle-in-mask-with-shadow.svg
        https://bugs.webkit.org/show_bug.cgi?id=43106

        This test has been affected by recent colorspace changes but the diffs are
        so slight as to be very difficult to detect. I'm reasonably confident
        these new baselines are OK.

        * platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.checksum:
        * platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
        * platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.checksum:
        * platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Alex Nicolaou <anicolao@chromium.org>
abarth@webkit.org [Sat, 7 Aug 2010 04:11:20 +0000 (04:11 +0000)]
2010-08-06  Alex Nicolaou  <anicolao@chromium.org>

        Reviewed by Darin Adler.

        rebaseline masking-intro-01-f.svg - diffs are in the antialiasing
        https://bugs.webkit.org/show_bug.cgi?id=43107

        After some investigation, the antialiasing diffs were
        definitely verified to be due to the colorspace change
        made for https://bugs.webkit.org/show_bug.cgi?id=42228
        and I'm reasonably confident that these rebaselined
        outputs are good.

        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Robert Hogan <robert@webkit.org>
abarth@webkit.org [Sat, 7 Aug 2010 03:37:40 +0000 (03:37 +0000)]
2010-08-06  Robert Hogan  <robert@webkit.org>

        Reviewed by Adam Barth.

        Define setPrivateBrowsingEnabled()
        https://bugs.webkit.org/show_bug.cgi?id=42283

        Define the scope of 'private browsing' in WebKit
        See also https://bugs.webkit.org/show_bug.cgi?id=41801

        * page/Settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 7 Aug 2010 03:30:25 +0000 (03:30 +0000)]
2010-08-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Ojan Vafai.

        dump-as-markup should work in Firefox
        https://bugs.webkit.org/show_bug.cgi?id=43606

        Apparently Firefox lacks this API.

        * resources/dump-as-markup.js:
        (Markup._getMarkupForTextNode):
        (Markup._getSelectionMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 7 Aug 2010 03:09:20 +0000 (03:09 +0000)]
2010-08-06  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium/DRT] One more tweak to the expectation overrides to pacify the bot.

        * platform/chromium/drt_expectations.txt: Removed duplicate expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 7 Aug 2010 01:56:07 +0000 (01:56 +0000)]
2010-08-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION (r64712): YouTube video pages have contents of <noembed> elements overlapping the video description
        https://bugs.webkit.org/show_bug.cgi?id=43605

        Show test progression.  We missed this regression when analyzing the
        expectation diffs because the DOM was correct and was a progression.

        * fast/dom/no-elements-expected.txt:
        * platform/mac/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
2010-08-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION (r64712): YouTube video pages have contents of <noembed> elements overlapping the video description
        https://bugs.webkit.org/show_bug.cgi?id=43605

        The old parser used to drop <noembed> on the floor.  We're supposed to
        add it to the DOM, but we don't want to create a renderer for it.

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::rendererIsNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Tony Gentilcore <tonyg@chromium.org>
abarth@webkit.org [Sat, 7 Aug 2010 01:30:16 +0000 (01:30 +0000)]
2010-08-06  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Fix style violations in Document
        https://bugs.webkit.org/show_bug.cgi?id=43657

        No new tests because no new functionality.

        * dom/Document.cpp:
        (WebCore::acceptsEditingFocus):
        (WebCore::Document::Document):
        (WebCore::Document::importNode):
        (WebCore::Document::adoptNode):
        (WebCore::Document::getElementById):
        (WebCore::Document::readyState):
        (WebCore::Document::createTreeWalker):
        (WebCore::Document::shouldScheduleLayout):
        (WebCore::Document::nextFocusableNode):
        (WebCore::Document::previousFocusableNode):
        (WebCore::Document::nodeAbsIndex):
        (WebCore::Document::nodeWithAbsIndex):
        (WebCore::Document::childTypeAllowed):
        (WebCore::Document::canReplaceChild):
        (WebCore::Document::recalcStyleSelector):
        (WebCore::Document::setFocusedNode):
        (WebCore::Document::attachNodeIterator):
        (WebCore::Document::detachNodeIterator):
        (WebCore::Document::parseQualifiedName):
        (WebCore::Document::getImageMap):
        (WebCore::Document::setInPageCache):
        (WebCore::Document::addMarker):
        (WebCore::Document::copyMarkers):
        (WebCore::Document::shiftMarkers):
        (WebCore::Document::setMarkersActive):
        (WebCore::Document::parentDocument):
        (WebCore::Document::topDocument):
        (WebCore::FormElementKeyHash::hash):
        (WebCore::Document::initSecurityContext):
        * dom/Document.h:
        (WebCore::Document::incDOMTreeVersion):
        (WebCore::Document::domTreeVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKitTestRunner needs to be able to set the font smoothing type
jhoneycutt@apple.com [Sat, 7 Aug 2010 00:34:39 +0000 (00:34 +0000)]
WebKitTestRunner needs to be able to set the font smoothing type
https://bugs.webkit.org/show_bug.cgi?id=43406

Reviewed by Adam Roben.

WebKit2:

* Shared/FontSmoothingLevel.h: Added.
(WebKit::):

* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
Initialize fontSmoothingLevel.
(WebKit::WebPreferencesStore::swap):
Copy fontSmoothingLevel.

* Shared/WebPreferencesStore.h:
(WebKit::WebPreferencesStore::encode):
Encode fontSmoothingLevel.
(WebKit::WebPreferencesStore::decode):
Decode it.

* UIProcess/API/C/WKPreferencesPrivate.cpp: Added.
(WKPreferencesSetFontSmoothingLevel):
Get the font smoothing level from the WKFontSmoothingLevel, and call
WebPreferences::setFontSmoothingLevel().
(WKPreferencesGetFontSmoothingLevel):
Get the font smoothing level from WebPreferences, and translate it to a
WKFontSmoothingLevel.

* UIProcess/API/C/WKPreferencesPrivate.h: Added.
Declare the font smoothing levels, and declare functions to get and set
the level.

* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setFontSmoothingLevel):
Set fontSmoothingLevel and call update().
(WebKit::WebPreferences::fontSmoothingLevel):
Return the level.

* UIProcess/WebPreferences.h:
Declare getter and setter for fontSmoothingLevel.

* WebKit2.xcodeproj/project.pbxproj:
Add new files to project.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::preferencesDidChange):
Call platformPreferencesDidChange().

* WebProcess/WebPage/WebPage.h:
Declare platformPreferencesDidChange().

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformPreferencesDidChange):
Stubbed.

* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformPreferencesDidChange):
Stubbed.

* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::platformPreferencesDidChange):
On CG platforms, call wkSetFontSmoothingLevel(). This matches the code
in old WebKit's WebPreferences. Set the font rendering mode to either
normal (CG) or alternative (GDI) based on the font smoothing level. This
matches what was done in old WebKit's WebView.

* win/WebKit2.vcproj:
Add FontSmoothingLevel.h and WKPreferencesPrivate.{h,cpp} to project.

* win/WebKit2Generated.make:
Copy WKPreferencesPrivate.h.

WebKitTools:

* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::resetPreferencesToConsistentValues):
Set the font smoothing level to
kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 7 Aug 2010 00:07:46 +0000 (00:07 +0000)]
2010-08-06  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium/DRT] Adjust expectations after my unexpectedly awful search-and-replace performance.

        * platform/chromium/drt_expectations.txt: Un-bungled test names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 6 Aug 2010 23:47:54 +0000 (23:47 +0000)]
2010-08-06  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed, release Qt build fix.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::containsPaintedContent): Guard call to toRenderVideo()
        with #if ENABLE(VIDEO).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 6 Aug 2010 23:35:55 +0000 (23:35 +0000)]
2010-08-06  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        HTML5 "video" tag with poster frame defined "flashes" right before movie displays
        https://bugs.webkit.org/show_bug.cgi?id=37591
        <rdar://problem/5650561>

        If a video element has a poster frame, display it until the playback is requested or the movie's
        time is changed.

        Test: compositing/video/video-poster.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_displayMode.
        (WebCore::HTMLMediaElement::prepareForLoad): Set m_displayMode to Unknown.
        (WebCore::HTMLMediaElement::loadResource): Call updateDisplayState to let it set configure
        the poster, if necessary.
        (WebCore::HTMLMediaElement::noneSupported): updatePosterImage -> updateDisplayState.
        (WebCore::HTMLMediaElement::setNetworkState): Ditto.
        (WebCore::HTMLMediaElement::setReadyState): Ditto.
        (WebCore::HTMLMediaElement::finishSeek): Set display mode to Video so a video frame will be
        displayed if a poster is currently visible.
        (WebCore::HTMLMediaElement::mediaPlayerRepaint): updatePosterImage -> updateDisplayState.
        (WebCore::HTMLMediaElement::updatePlayState): Set display mode to Video.
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::displayMode): New.
        (WebCore::HTMLMediaElement::setDisplayMode): Ditto.
        (WebCore::HTMLMediaElement::updateDisplayState): Ditto.

        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::HTMLVideoElement): Remove m_shouldDisplayPosterImage.
        (WebCore::HTMLVideoElement::attach): Call shouldDisplayPosterImage instead of checking
        m_shouldDisplayPosterImage directly.
        (WebCore::HTMLVideoElement::detach): Ditto.
        (WebCore::HTMLVideoElement::parseMappedAttribute): Set m_displayMode to Unknown before calling
        updateDisplayState so shouldDisplayPosterImage() will return the correct result. Remove the
        PLUGIN_PROXY_FOR_VIDEO code, it is now in updateDisplayState.
        (WebCore::HTMLVideoElement::setDisplayMode): Renamed from updatePosterImage and rework logic
        so we tell the media engine it is OK to display video frames when there is no poster, or
        once the media engine has something to display and the movie has started or seeked.
        (WebCore::HTMLVideoElement::updateDisplayState): New, manage display mode based on poster
        attribute.
        * html/HTMLVideoElement.h:
        (WebCore::HTMLVideoElement::shouldDisplayPosterImage):

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::prepareForRendering): New, call media engine's prepareForRendering.
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::prepareForRendering):

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_isAllowedToRender.
        (WebCore::MediaPlayerPrivate::setUpVideoRendering):
        (WebCore::MediaPlayerPrivate::isReadyForVideoSetup): Renamed from isReadyForRendering.
        (WebCore::MediaPlayerPrivate::prepareForRendering): New, set m_isAllowedToRender and
        inform the client that render tree should be updated so we correctly switch from showing
        the poster, which often doens't use a layer, to showing video frames, which do.
        (WebCore::MediaPlayerPrivate::updateStates): Don't call setUpVideoRendering until
        isReadyForVideoSetup() returns true.
        (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): isReadyForRendering -> isReadyForVideoSetup

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::containsPaintedContent): Only consider video when displaying
        video frames so a poster won't force compositing mode.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::requiresCompositingForVideo): Ditto.

        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::shouldDisplayVideo): New, return true when not displaying a poster.
        * rendering/RenderVideo.h:

2010-08-06  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        HTML5 "video" tag with poster frame defined "flashes" right before movie displays
        https://bugs.webkit.org/show_bug.cgi?id=37591
        <rdar://problem/5650561>

        If a video element has a poster frame, display it until the playback is requested or the movie's
        time is changed. Test this by ensuring that an element with a poster doesn't have layers while
        and element with one does.

        * compositing/video/video-poster-expected.txt: Added.
        * compositing/video/video-poster.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Fri, 6 Aug 2010 23:35:49 +0000 (23:35 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 6 Aug 2010 23:29:27 +0000 (23:29 +0000)]
2010-08-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Accelerated 2d canvases should get compositing layers
        https://bugs.webkit.org/show_bug.cgi?id=43362

        Allows for 2d canvas rendering contexts to use a GraphicsContext3D for
        accelerated rendering.  The rendering context holds the GraphicsContext3D
        alive and exposes it to the compositor.  The 3d context itself is passed
        down through the GraphicsContext to use for actual rendering:
        https://bug-43362-attachments.webkit.org/attachment.cgi?id=63557

        This approach will let us simultaneously prototype accelerated techniques
        for canvas 2d and revise the design of canvas elements without destabilizing
        all ports.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext):
        (WebCore::HTMLCanvasElement::willDraw):
        (WebCore::HTMLCanvasElement::makeRenderingResultsAvailable):
        * html/canvas/CanvasRenderingContext.h:
        (WebCore::CanvasRenderingContext::paintRenderingResultsToCanvas):
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
        (WebCore::CanvasRenderingContext2D::isAccelerated):
        (WebCore::CanvasRenderingContext2D::reset):
        (WebCore::CanvasRenderingContext2D::willDraw):
        (WebCore::CanvasRenderingContext2D::paintRenderingResultsToCanvas):
        * html/canvas/CanvasRenderingContext2D.h:
        (WebCore::CanvasRenderingContext2D::graphicsContext3D):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
        * html/canvas/WebGLRenderingContext.h:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::syncSoftwareCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 6 Aug 2010 23:23:58 +0000 (23:23 +0000)]
2010-08-06  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium/DRT] Update expectation overrides for Windows.

        * platform/chromium/drt_expectations.txt: Added a bunch of failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fixes.
andersca@apple.com [Fri, 6 Aug 2010 23:15:55 +0000 (23:15 +0000)]
Build fixes.

* Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):
* Shared/qt/UpdateChunk.cpp:
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
* Shared/qt/UpdateChunk.h:
* Shared/win/UpdateChunk.cpp:
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
* Shared/win/UpdateChunk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix a missed variable rename.
jhoneycutt@apple.com [Fri, 6 Aug 2010 23:07:27 +0000 (23:07 +0000)]
Fix a missed variable rename.

Unreviewed.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChange all ArgumentEncoder and ArgumentDecoder references to pointers
andersca@apple.com [Fri, 6 Aug 2010 23:04:20 +0000 (23:04 +0000)]
Change all ArgumentEncoder and ArgumentDecoder references to pointers
https://bugs.webkit.org/show_bug.cgi?id=43651

Reviewed by Sam Weinig.

* Platform/CoreIPC/ArgumentCoder.h:
* Platform/CoreIPC/ArgumentDecoder.h:
* Platform/CoreIPC/Arguments.h:
* Platform/CoreIPC/Attachment.cpp:
* Platform/CoreIPC/Attachment.h:
* Platform/CoreIPC/mac/MachPort.h:
* Platform/SharedMemory.h:
* Platform/mac/SharedMemoryMac.cpp:
* Shared/DrawingAreaBase.cpp:
* Shared/DrawingAreaBase.h:
* Shared/WebEvent.h:
* Shared/WebNavigationDataStore.h:
* Shared/WebPreferencesStore.h:
* Shared/mac/UpdateChunk.cpp:
* Shared/mac/UpdateChunk.h:
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.h:
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
* UIProcess/LayerBackedDrawingAreaProxy.h:
* UIProcess/WebContext.cpp:
* UIProcess/WebContext.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
* WebProcess/WebPage/LayerBackedDrawingArea.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebProcess.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agomac-wk2/Skipped should be used on Windows when running regression tests
jhoneycutt@apple.com [Fri, 6 Aug 2010 22:59:11 +0000 (22:59 +0000)]
mac-wk2/Skipped should be used on Windows when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=43494

Reviewed by Adam Roben.

WebKitTools:

* Scripts/old-run-webkit-tests:
If the platform is win-wk2, also read the mac-wk2 skipped list.

LayoutTests:

* platform/win-wk2/Skipped:
Remove the tests copied from the mac-wk2 skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDon't try to allocate a vector unless we know the buffer can contain it
andersca@apple.com [Fri, 6 Aug 2010 22:39:28 +0000 (22:39 +0000)]
Don't try to allocate a vector unless we know the buffer can contain it
https://bugs.webkit.org/show_bug.cgi?id=43647

Reviewed by Sam Weinig.

* Platform/CoreIPC/ArgumentCoders.h:
(CoreIPC::):
Check that the argument decoder buffer actually can hold all the vector elements.

* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughtToContain):
Align the current position to the given alignment, add the size and check if the position is
past the end of the buffer.

* Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughtToContain):
Get the size and alignment and call the other bufferIsLargeEnoughtToContain overload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 6 Aug 2010 22:20:36 +0000 (22:20 +0000)]
2010-08-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Chris Fleizach.

        Make AX Code use more specific RenderObject subclass types
        https://bugs.webkit.org/show_bug.cgi?id=43632

        No functional change, thus no tests.

        * accessibility/AXObjectCache.cpp:
        (WebCore::nodeHasRole):
         - Make this take a String instead of AtomicString, to avoid
           thrashing the atomic string hash.
           It would be better to take a const char* here, except
           one caller passes nullAtom.
        (WebCore::createFromRenderer):
         - Split this out from getOrCreate to make it simpler.
         - No longer needs to deal with setting a "result"
           pointer and can instead just return.
         - I've also made this function use RenderBoxModelObject*
           where appropriate.
        (WebCore::AXObjectCache::getOrCreate):
        * accessibility/AXObjectCache.h:
        * accessibility/AccessibilityImageMapLink.cpp:
        (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
         - Fix style.
        * accessibility/AccessibilityMenuList.cpp:
        (WebCore::AccessibilityMenuList::AccessibilityMenuList):
         - Use a more specific type.
        (WebCore::AccessibilityMenuList::renderer):
        * accessibility/AccessibilityMenuList.h:
        (WebCore::AccessibilityMenuList::create):
        * accessibility/AccessibilityMenuListPopup.cpp:
         - Need RenderMenuList.h since renderer() is a RenderMenuList*
        * accessibility/AccessibilityObject.cpp:
        (WebCore::renderListItemContainerForNode):
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::renderBoxModelObject):
         - New helper function, similar to Node::renderBoxModelObject()
        (WebCore::isInlineWithContinuation):
        (WebCore::AccessibilityRenderObject::isNativeImage):
        (WebCore::AccessibilityRenderObject::isAttachment):
        (WebCore::AccessibilityRenderObject::isMultiSelectable):
        (WebCore::AccessibilityRenderObject::isReadOnly):
        (WebCore::AccessibilityRenderObject::isFieldset):
        (WebCore::AccessibilityRenderObject::actionElement):
        (WebCore::AccessibilityRenderObject::stringValue):
        (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
        (WebCore::AccessibilityRenderObject::setValue):
        (WebCore::AccessibilityRenderObject::widget):
        (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
        (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
        (WebCore::AccessibilityRenderObject::renderObjectIsObservable):
        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
        (WebCore::AccessibilityRenderObject::addChildren):
        (WebCore::msaaRoleForRenderer):
        * accessibility/AccessibilityRenderObject.h:
        * accessibility/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
        * accessibility/AccessibilityTable.h:
         - Remove unneeded "using namespace std".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Fri, 6 Aug 2010 22:07:50 +0000 (22:07 +0000)]
2010-08-06  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Factor an AsyncScriptRunner out of Document
        https://bugs.webkit.org/show_bug.cgi?id=43633

        This copies the existing implementation exactly. In the future
        this will use PendingScript which handles ref counting without
        the need for those manual ref()/deref()s. This is also currently
        a trivial class, but a little more logic will be added to it to
        support <script async>.

        No new tests because no new functionality.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/AsyncScriptRunner.cpp: Added.
        (WebCore::AsyncScriptRunner::AsyncScriptRunner):
        (WebCore::AsyncScriptRunner::~AsyncScriptRunner):
        (WebCore::AsyncScriptRunner::executeScriptSoon):
        (WebCore::AsyncScriptRunner::suspend):
        (WebCore::AsyncScriptRunner::resume):
        (WebCore::AsyncScriptRunner::timerFired):
        * dom/AsyncScriptRunner.h: Added.
        (WebCore::AsyncScriptRunner::create):
        (WebCore::AsyncScriptRunner::hasPendingScripts):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        * dom/Document.h:
        (WebCore::Document::asyncScriptRunner):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::notifyFinished):
        * page/PageGroupLoadDeferrer.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 6 Aug 2010 21:58:55 +0000 (21:58 +0000)]
2010-08-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Implement GLES2Canvas/Texture in terms of GraphicsContext3D instead of direct OpenGL calls
        https://bugs.webkit.org/show_bug.cgi?id=43608

        This converts all OpenGL calls in GLES2(Canvas|Texture) to calls on the corresponding GraphicsContext3D
        API, due to feedback on https://bugs.webkit.org/show_bug.cgi?id=43362.  Nearly all the changes are
        applying the regex s/gl([A-Z])/m_context->%1</ and removing unnecessary makeCurrent() calls.
        Other changes hilighted below.

        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::affineTo3x3):
        (WebCore::GLES2Canvas::GLES2Canvas):
        (WebCore::GLES2Canvas::~GLES2Canvas):
        (WebCore::GLES2Canvas::clearRect):
        (WebCore::GLES2Canvas::fillRect):
        (WebCore::GLES2Canvas::drawTexturedRect):
        (WebCore::GLES2Canvas::applyCompositeOperator):
        (WebCore::GLES2Canvas::getQuadVertices):
        (WebCore::GLES2Canvas::getQuadIndices):
            - use new typed XXArray classes for buffer uploads
        (WebCore::loadShader):
        (WebCore::GLES2Canvas::getSimpleProgram):
        (WebCore::GLES2Canvas::getTexProgram):
        (WebCore::GLES2Canvas::createTexture):
        (WebCore::GLES2Canvas::checkGLError):
        * platform/graphics/chromium/GLES2Canvas.h:
        (WebCore::GLES2Canvas::context):
        * platform/graphics/chromium/GLES2Texture.cpp:
        (WebCore::GLES2Texture::GLES2Texture):
        (WebCore::GLES2Texture::~GLES2Texture):
        (WebCore::GLES2Texture::create):
        (WebCore::convertFormat):
        (WebCore::GLES2Texture::load):
        (WebCore::GLES2Texture::bind):
        * platform/graphics/chromium/GLES2Texture.h:
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::fillRect):
            - add a missing restore() call to the H/W path
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::drawBitmapGLES2):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::setGraphicsContext3D):
        (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
            - avoid applying CTM to uploads
        (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
        * platform/graphics/skia/PlatformContextSkia.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDetect invalid CoreIPC messages and call didReceiveInvalidMessage
andersca@apple.com [Fri, 6 Aug 2010 21:52:03 +0000 (21:52 +0000)]
Detect invalid CoreIPC messages and call didReceiveInvalidMessage
https://bugs.webkit.org/show_bug.cgi?id=43643
<rdar://problem/7891069>

Reviewed by Adam Roben.

* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::alignBufferPosition):
If we can't correctly align the buffer position, mark the decoder as invalid.

* Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::isInvalid):
Check if the argument decoder is valid.

(CoreIPC::ArgumentDecoder::markInvalid):
Mark the argument decoder as invalid, by setting its buffer position past its end position.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchMessages):
Check if m_client is null before dispatching messages. If an argument decoder was marked invalid, call
Connection::Client::didReceiveInvalidMessage.

* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::Message::releaseArguments):
Rename destroy to releaseArguments and make it return a PassOwnPtr.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::~WebProcessProxy):
Call releaseArguments instead of destroy.

(WebKit::WebProcessProxy::didReceiveInvalidMessage):
Kill the web process and invalidate its connection.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveInvalidMessage):
Don't do anything, if the UI process is sending invalid messages there's not much we can do.

* WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 6 Aug 2010 21:49:20 +0000 (21:49 +0000)]
2010-08-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Composited canvas should be treated the same by the compositor and not be WebGL specific
        https://bugs.webkit.org/show_bug.cgi?id=43589

        Initializes the platformLayer as a CanvasLayerChromium, not a WebGLLayerChromium.
        The layer itself isn't WebGL-specific.

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::initialize):
        (WebCore::GraphicsContext3DInternal::platformLayer):
        (WebCore::GraphicsContext3D::platformLayer):
2010-08-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Composited canvas should be treated the same by the compositor and not be WebGL specific
        https://bugs.webkit.org/show_bug.cgi?id=43589

        This treats all GraphicsContext3D-backed layers the same instead of special casing WebGL.
        The cross-platform change is to rename GraphicsLayer::setContentsToWebGL() to
        GraphicsLayer::setContentsToCanvas() and to rename all implementations.

        This patch also renames the chromium class used for accelerating these layers.

        Cross platform changes:
        * WebCore.gypi:
        * platform/graphics/GraphicsLayer.h:
        (WebCore::GraphicsLayer::setContentsToCanvas):
            Rename the function on the base class. GraphicsLayerCA and GraphicsLayerChromium implement this.
        * rendering/RenderLayerBacking.cpp:
        (WebCore::isAcceleratedCanvas):
            Helper function to see if a renderer is associated with an accelerated compositing layer.
        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
        (WebCore::RenderLayerBacking::containsPaintedContent):
        (WebCore::RenderLayerBacking::rendererContentChanged):
       Chromium specific changes:
        * platform/graphics/chromium/CanvasLayerChromium.cpp: Added.
        (WebCore::CanvasLayerChromium::create):
        (WebCore::CanvasLayerChromium::CanvasLayerChromium):
        (WebCore::CanvasLayerChromium::textureId):
        (WebCore::CanvasLayerChromium::updateTextureContents):
        (WebCore::CanvasLayerChromium::setContext):
        * platform/graphics/chromium/CanvasLayerChromium.h: Added.
        (WebCore::CanvasLayerChromium::drawsContent):
        (WebCore::CanvasLayerChromium::ownsTexture):
        (WebCore::CanvasLayerChromium::shaderProgramId):
        (WebCore::CanvasLayerChromium::setShaderProgramId):
        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
        (WebCore::GraphicsLayerChromium::setContentsToCanvas):
        * platform/graphics/chromium/GraphicsLayerChromium.h:
        (WebCore::GraphicsLayerChromium::):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::drawLayer):
        (WebCore::LayerRendererChromium::initializeSharedGLObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::):
        * platform/graphics/chromium/WebGLLayerChromium.cpp: Removed.
        * platform/graphics/chromium/WebGLLayerChromium.h: Removed.
        Mac specific changes:
        * platform/graphics/mac/GraphicsLayerCA.h:
        (WebCore::GraphicsLayerCA::):
        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
        (WebCore::GraphicsLayerCA::updateContentsCanvasLayer):
        (WebCore::GraphicsLayerCA::setContentsToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 6 Aug 2010 21:45:55 +0000 (21:45 +0000)]
2010-08-06  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Eric Seidel.

        Add PluginView::bindingInstance() to PluginViewNone
        https://bugs.webkit.org/show_bug.cgi?id=42936

        * bindings/js/ScriptControllerEfl.cpp:
        (WebCore::ScriptController::createScriptInstanceForWidget): Removed workaround.
        * plugins/PluginViewNone.cpp: Added property svn:eol-style.
        (WebCore::PluginView::bindingInstance): Added missing method and use it on WinCE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Yongjun Zhang <yongjun_zhang@apple.com>
joepeck@webkit.org [Fri, 6 Aug 2010 21:22:35 +0000 (21:22 +0000)]
2010-08-06  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by Eric Seidel.

        add "const" to WebChromeClient::webView().
        https://bugs.webkit.org/show_bug.cgi?id=43631

        Change WebChromeClient::webView() to be const because ChromeClient::didReceiveViewportArguments
        is const method now, and calling webView() inside port-specific didReceiveViewportArguments
        implementation fails compiling if webView() is not const.

        * WebCoreSupport/WebChromeClient.h:
        (WebChromeClient::webView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd CoreIPC::MessageReceiver class
andersca@apple.com [Fri, 6 Aug 2010 20:40:51 +0000 (20:40 +0000)]
Add CoreIPC::MessageReceiver class
https://bugs.webkit.org/show_bug.cgi?id=43637

Reviewed by Adam Roben.

* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::MessageReceiver::~MessageReceiver):
Add MessageReceiver class and make Client inherit from it.

(CoreIPC::Connection::MessageReceiver::didReceiveSyncMessage):
Change didReceiveSyncMessage from being a pure virtual member function and make it
assert by default instead.

* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
Remove ChunkedUpdateDrawingAreaProxy::didReceiveSyncMessage.

* Shared/DrawingAreaBase.h:
Include "Connection.h" instead.

* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::didReceiveSyncMessage):
Change didReceiveSyncMessage from being a pure virtual member function and make it
assert by default instead.

* WebProcess/WebProcess.cpp:
* WebProcess/WebProcess.h:
Remove didReceiveSyncMessage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Rafael Antognolli <antognolli@profusion.mobi>
leandro@webkit.org [Fri, 6 Aug 2010 20:20:50 +0000 (20:20 +0000)]
2010-08-06  Rafael Antognolli  <antognolli@profusion.mobi>

        [EFL] Build fix.

        * CMakeLists.txt: add runtime/CGHandle.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Fri, 6 Aug 2010 19:59:07 +0000 (19:59 +0000)]
2010-08-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Use new "package" name also for the directory where the inspector
        support files are installed.

        * GNUmakefile.am:

WebKit/gtk

2010-08-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Use the new paths, and also fix the path for localizedStrings.

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::openInspectorFrontend):
        (WebKit::InspectorFrontendClient::localizedStringsURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix chromium build break.
jianli@chromium.org [Fri, 6 Aug 2010 19:27:36 +0000 (19:27 +0000)]
Fix chromium build break.

* inspector/InspectorDebuggerAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 6 Aug 2010 19:21:18 +0000 (19:21 +0000)]
2010-08-06  Dirk Schulze  <krit@webkit.org>

        Not reviewed. Sort XCode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRoll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
weinig@apple.com [Fri, 6 Aug 2010 18:54:12 +0000 (18:54 +0000)]
Roll out trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
Unreviewed.

Patch by Jessie Berlin <jberlin@apple.com> on 2010-08-06
* UIProcess/PageClient.h:
* UIProcess/VisitedLinkProvider.h:
* UIProcess/WebContextInjectedBundleClient.h:
* UIProcess/WebFrameProxy.h:
* UIProcess/WebHistoryClient.h:
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPolicyClient.h:
* UIProcess/WebProcessProxy.h:
* UIProcess/WebUIClient.h:
* UIProcess/win/WebView.h:
* WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
* WebProcess/Plugins/NPRuntimeObjectMap.h:
* WebProcess/Plugins/Netscape/NetscapePluginStream.h:
* WebProcess/Plugins/PluginController.h:
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebProcess.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Jessie Berlin <jberlin@apple.com>
jberlin@webkit.org [Fri, 6 Aug 2010 18:49:23 +0000 (18:49 +0000)]
2010-08-06  Jessie Berlin  <jberlin@apple.com>

        Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
        Unreviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate chromium test results.
jianli@chromium.org [Fri, 6 Aug 2010 18:21:58 +0000 (18:21 +0000)]
Update chromium test results.

* platform/chromium-linux/svg/custom/path-zero-strokewidth-expected.checksum: Added.
* platform/chromium-linux/svg/custom/path-zero-strokewidth-expected.png: Added.
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/svg/custom/path-zero-strokewidth-expected.checksum: Added.
* platform/chromium-win/svg/custom/path-zero-strokewidth-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-04 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 6 Aug 2010 18:03:51 +0000 (18:03 +0000)]
2010-08-04  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        WebGLBuffer::associateBufferData(ArrayBufferView* array) copies incorrect data for sliced views
        https://bugs.webkit.org/show_bug.cgi?id=42124

        * html/canvas/WebGLBuffer.cpp:
        (WebCore::WebGLBuffer::associateBufferDataImpl): Helper function that's called by all associateBufferData().
        (WebCore::WebGLBuffer::associateBufferData): Call associateBufferDataImpl().
        (WebCore::WebGLBuffer::associateBufferSubDataImpl): Helper function that's called by all associateBufferSubData().
        (WebCore::WebGLBuffer::associateBufferSubData): Call associateBufferSubDataImpl().
        * html/canvas/WebGLBuffer.h: Declare helper functions.
2010-08-04  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        WebGLBuffer::associateBufferData(ArrayBufferView* array) copies incorrect data for sliced views
        https://bugs.webkit.org/show_bug.cgi?id=42124

        * fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Adding test case for bufferData and bufferSubData with ArrayBufferView input.
        * fast/canvas/webgl/draw-elements-out-of-bounds.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 6 Aug 2010 17:58:05 +0000 (17:58 +0000)]
2010-08-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        noembed should respect whether plugins are enabled
        https://bugs.webkit.org/show_bug.cgi?id=43611

        This instruction isn't in the HTML5 spec, but it seems like the right
        thing to do.  I suspect this is because the spec doesn't understand
        that plugins can be disabled.

        I'm not sure how we can test this in DumpRenderTree, but I'm open to
        suggestions.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::adjustedLexerState):
        (WebCore::HTMLTreeBuilder::processStartTagForInBody):
        (WebCore::HTMLTreeBuilder::processStartTagForInHead):
        (WebCore::HTMLTreeBuilder::scriptEnabled):
        (WebCore::HTMLTreeBuilder::pluginsEnabled):
        * html/HTMLTreeBuilder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Fri, 6 Aug 2010 17:35:57 +0000 (17:35 +0000)]
2010-08-06  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Factor out PendingScript and protect its members
        https://bugs.webkit.org/show_bug.cgi?id=43391

        This will be shared by AsyncScriptRunner.

        No new tests because no new functionality.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/PendingScript.cpp: Added.
        (WebCore::PendingScript::~PendingScript):
        (WebCore::PendingScript::element):
        (WebCore::PendingScript::releaseElementAndClear):
        (WebCore::PendingScript::setCachedScript):
        (WebCore::PendingScript::cachedScript):
        * dom/PendingScript.h: Added.
        (WebCore::PendingScript::PendingScript):
        (WebCore::PendingScript::startingLineNumber):
        (WebCore::PendingScript::watchingForLoad):
        (WebCore::PendingScript::setWatchingForLoad):
        (WebCore::PendingScript::hasElement):
        (WebCore::PendingScript::adoptElement):
        (WebCore::PendingScript::notifyFinished):
        * html/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::sourceFromPendingScript):
        (WebCore::HTMLScriptRunner::haveParsingBlockingScript):
        (WebCore::HTMLScriptRunner::requestScript):
        * html/HTMLScriptRunner.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Jessie Berlin <jberlin@apple.com>
jberlin@webkit.org [Fri, 6 Aug 2010 16:51:49 +0000 (16:51 +0000)]
2010-08-06  Jessie Berlin  <jberlin@apple.com>

        Windows Build Fix (continued). Unreviewed.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
commit-queue@webkit.org [Fri, 6 Aug 2010 16:43:25 +0000 (16:43 +0000)]
2010-08-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Darin Adler.

        Change permission to access methods in XMLDocumentParser.h
        https://bugs.webkit.org/show_bug.cgi?id=43180

        Change permission to access wellFormed(), lineNumber() and columnNumber()
        in XMLDocumentParser.h. Because, the methods are used by WML.

        * dom/XMLDocumentParser.h:
        (WebCore::XMLDocumentParser::wellFormed): Change accebility permission.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Jessie Berlin <jberlin@apple.com>
jberlin@webkit.org [Fri, 6 Aug 2010 16:09:49 +0000 (16:09 +0000)]
2010-08-06  Jessie Berlin  <jberlin@apple.com>

        Windows Build Fix. Unreviewed.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        Add GCHandle.h and GCHandle.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 ryuan choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Fri, 6 Aug 2010 16:02:23 +0000 (16:02 +0000)]
2010-08-06  ryuan choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Regression (64763) build fix for efl.
        https://bugs.webkit.org/show_bug.cgi?id=43597

        change ENABLE_BLOB_SLICE to ENABLE_BLOB for fixing build break

        * cmake/OptionsEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 6 Aug 2010 15:59:55 +0000 (15:59 +0000)]
2010-08-06  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Support for image drags
        https://bugs.webkit.org/show_bug.cgi?id=40788

        Unskip and add baselines for tests that are now passing with image drag support.

        * platform/gtk/Skipped:
        * platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Added.
        * platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
        * platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt: Added.
        * platform/gtk/fast/events/standalone-image-drag-to-editable-expected.txt: Added.
2010-08-06  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Support for image drags
        https://bugs.webkit.org/show_bug.cgi?id=40788

        Add image drag-and-drop support for WebKit GTK+.

        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::ClipboardGtk::setDragImage): Filled this stub.
        (WebCore::ClipboardGtk::setDragImageElement): Filled this stub.
        (WebCore::ClipboardGtk::createDragImage): Filled this stub.
        (WebCore::ClipboardGtk::declareAndWriteDragImage): Write the image URL, markup, and image itself to the data object member.
        * platform/gtk/ClipboardGtk.h: Brought method declarations into line with the parent class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 6 Aug 2010 15:30:59 +0000 (15:30 +0000)]
2010-08-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium: disable device motion by default.

        https://bugs.webkit.org/show_bug.cgi?id=43623

        * public/WebRuntimeFeatures.h:
        * src/WebRuntimeFeatures.cpp:
        (WebKit::WebRuntimeFeatures::enableDeviceMotion):
        (WebKit::WebRuntimeFeatures::isDeviceMotionEnabled):
        (WebKit::WebRuntimeFeatures::enableDeviceOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 6 Aug 2010 14:59:17 +0000 (14:59 +0000)]
2010-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline win specific getComputedStyle* results, after r64832.

        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Nathan Lawrence <nlawrence@apple.com>
commit-queue@webkit.org [Fri, 6 Aug 2010 14:55:54 +0000 (14:55 +0000)]
2010-08-06  Nathan Lawrence  <nlawrence@apple.com>

        Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=43207

        WeakGCPtr's should instead of directly pointing to the GC'd object
        should be directed to an array of pointers that can be updated for
        movable objects.

        * Android.mk:
        * GNUmakefile.am:
        * JavaScriptCore.exp:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/Collector.cpp:
        (JSC::Heap::destroy):
        (JSC::Heap::allocateBlock):
        (JSC::Heap::freeBlock):
        (JSC::Heap::updateWeakGCHandles):
        (JSC::WeakGCHandlePool::update):
        (JSC::Heap::addWeakGCHandle):
        (JSC::Heap::markRoots):
        * runtime/Collector.h:
        (JSC::Heap::weakGCHandlePool):
        * runtime/GCHandle.cpp: Added.
        (JSC::WeakGCHandle::pool):
        (JSC::WeakGCHandlePool::WeakGCHandlePool):
        (JSC::WeakGCHandlePool::allocate):
        (JSC::WeakGCHandlePool::free):
        (JSC::WeakGCHandlePool::operator new):
        * runtime/GCHandle.h: Added.
        (JSC::WeakGCHandle::isValidPtr):
        (JSC::WeakGCHandle::isPtr):
        (JSC::WeakGCHandle::isNext):
        (JSC::WeakGCHandle::invalidate):
        (JSC::WeakGCHandle::get):
        (JSC::WeakGCHandle::set):
        (JSC::WeakGCHandle::getNextInFreeList):
        (JSC::WeakGCHandle::setNextInFreeList):
        (JSC::WeakGCHandlePool::isFull):
        * runtime/WeakGCPtr.h:
        (JSC::WeakGCPtr::WeakGCPtr):
        (JSC::WeakGCPtr::~WeakGCPtr):
        (JSC::WeakGCPtr::get):
        (JSC::WeakGCPtr::clear):
        (JSC::WeakGCPtr::assign):
        (JSC::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 6 Aug 2010 14:44:52 +0000 (14:44 +0000)]
2010-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline gtk specific getComputedStyle-basic.html result, after r64832.

        * platform/gtk/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 6 Aug 2010 14:00:41 +0000 (14:00 +0000)]
2010-08-06  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract debugger implementation into InspectorDebuggerAgent
        https://bugs.webkit.org/show_bug.cgi?id=42340

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::resume):
        (WebCore::InspectorController::loadBreakpoints):
        (WebCore::InspectorController::saveBreakpoints):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::debuggerAgent):
        * inspector/InspectorDebuggerAgent.cpp: Added.
        (WebCore::md5Base16):
        (WebCore::formatBreakpointId):
        (WebCore::InspectorDebuggerAgent::create):
        (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
        (WebCore::InspectorDebuggerAgent::isDebuggerAlwaysEnabled):
        (WebCore::InspectorDebuggerAgent::activateBreakpoints):
        (WebCore::InspectorDebuggerAgent::deactivateBreakpoints):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        (WebCore::InspectorDebuggerAgent::removeBreakpoint):
        (WebCore::InspectorDebuggerAgent::editScriptSource):
        (WebCore::InspectorDebuggerAgent::getScriptSource):
        (WebCore::InspectorDebuggerAgent::pause):
        (WebCore::InspectorDebuggerAgent::resume):
        (WebCore::InspectorDebuggerAgent::stepOverStatement):
        (WebCore::InspectorDebuggerAgent::stepIntoStatement):
        (WebCore::InspectorDebuggerAgent::stepOutOfFunction):
        (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
        (WebCore::InspectorDebuggerAgent::clearForPageNavigation):
        (WebCore::InspectorDebuggerAgent::currentCallFrames):
        (WebCore::InspectorDebuggerAgent::loadBreakpoints):
        (WebCore::InspectorDebuggerAgent::saveBreakpoints):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        (WebCore::InspectorDebuggerAgent::failedToParseSource):
        (WebCore::InspectorDebuggerAgent::didPause):
        (WebCore::InspectorDebuggerAgent::didContinue):
        (WebCore::InspectorDebuggerAgent::remoteFrontend):
        * inspector/InspectorDebuggerAgent.h: Added.
        * inspector/InspectorFrontend.cpp:
        * inspector/InspectorFrontend.h:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Dean Jackson <dino@apple.com>
dino@apple.com [Fri, 6 Aug 2010 13:38:04 +0000 (13:38 +0000)]
2010-08-06  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser and Steve Block.

        https://bugs.webkit.org/show_bug.cgi?id=42865
        Implement DeviceMotionEvent

        Implement the DeviceMotionEvent interface as defined
        in http://dev.w3.org/geo/api/spec-source-orientation.html
        This is currently an empty implementation, in that there is
        no motion client connected - the platform implementations
        will need to do that.

        Tests: fast/dom/DeviceMotion/create-event.html
               fast/dom/DeviceMotion/optional-event-properties.html
               fast/dom/DeviceMotion/window-property.html

        * Android.derived.jscbindings.mk:
        * Android.derived.v8bindings.mk:
        * Android.jscbindings.mk:
        * Android.mk:
        * Android.v8bindings.mk:
        * CMakeLists.txt:
        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
          - Add new files for DeviceMotionEvent build support
        * bindings/generic/RuntimeEnabledFeatures.cpp:
        * bindings/generic/RuntimeEnabledFeatures.h:
          - new runtime flags for device motion
        * bindings/js/JSDeviceMotionEventCustom.cpp: Added.
        * bindings/v8/custom/V8DeviceMotionEventCustom.cpp: Added.
          - Custom JS binding to translate property access through
            to the DeviceMotionData object that the Event holds
        * bindings/js/JSEventCustom.cpp:
          - Include the custom code for DeviceMotionEvent
        * dom/DeviceMotionClient.h: Added.
          - Pure virtual client for DeviceMotion access
        * dom/DeviceMotionController.cpp: Added.
        * dom/DeviceMotionController.h: Added.
          - Controller class that manages event dispatch
        * dom/DeviceMotionData.cpp: Added.
        * dom/DeviceMotionData.h: Added.
          - Representation of the data that comes from a device motion
            client that is then used within the event.
        * dom/DeviceMotionEvent.cpp: Added.
        * dom/DeviceMotionEvent.h: Added.
        * dom/DeviceMotionEvent.idl: Added.
          - The actual event implementation
        * dom/Document.cpp:
        (WebCore::Document::createEvent):
          - Update createEvent to allow "devicemotion" events
        * dom/Event.cpp:
        * dom/Event.h:
          - isDeviceMotionEvent virtual method
        * dom/EventNames.h:
          - new "devicemotion" event type
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::addEventListener):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
          - allow creation of "devicemotion" events and pass registration
            through to the Page's deviceMotionController object
        * page/Page.cpp:
        * page/Page.h:
          - new PageClient for deviceMotionController

          Layout Tests:

          * fast/dom/Window/window-properties-device-orientation-expected.txt:
          * fast/dom/Window/window-properties-device-orientation.html:
          * fast/dom/Window/window-properties.html:

          Add some tests for the DeviceMotionEvent interface.

          * fast/dom/DeviceMotion/create-event-expected.txt: Added.
          * fast/dom/DeviceMotion/create-event.html: Added.
          * fast/dom/DeviceMotion/optional-event-properties-expected.txt: Added.
          * fast/dom/DeviceMotion/optional-event-properties.html: Added.
          * fast/dom/DeviceMotion/script-tests/TEMPLATE.html: Added.
          * fast/dom/DeviceMotion/script-tests/create-event.js: Added.
          * fast/dom/DeviceMotion/script-tests/optional-event-properties.js: Added.
          * fast/dom/DeviceMotion/script-tests/window-property.js: Added.
          * fast/dom/DeviceMotion/window-property-expected.txt: Added.
          * fast/dom/DeviceMotion/window-property.html: Added.

          Make sure these are skipped on Mac, Win, GTK and QT.

          * platform/gtk/Skipped:
          * platform/mac/Skipped:
          * platform/qt/Skipped:
          * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Kavita Kanetkar <kkanetkar@chromium.org>
commit-queue@webkit.org [Fri, 6 Aug 2010 13:29:40 +0000 (13:29 +0000)]
2010-08-06  Kavita Kanetkar  <kkanetkar@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: Remove "Online/Offline" icon for Chrome's appcache devtools UI.
        https://bugs.webkit.org/show_bug.cgi?id=43450

        * inspector/front-end/ApplicationCacheItemsView.js:
        (WebInspector.ApplicationCacheItemsView):
        (WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems):
        (WebInspector.ApplicationCacheItemsView.prototype.updateNetworkState):
        * inspector/front-end/Settings.js:
2010-08-06  Kavita Kanetkar  <kkanetkar@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: Remove "Online/Offline" icon for Chrome's appcache devtools UI.
        https://bugs.webkit.org/show_bug.cgi?id=43450

        * src/js/DevTools.js:
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 6 Aug 2010 13:22:31 +0000 (13:22 +0000)]
2010-08-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Should revoke scheduled tasks
        https://bugs.webkit.org/show_bug.cgi?id=43560

        * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
        (DRTDevToolsAgent::reset): Calls RevokeAll().
        * DumpRenderTree/chromium/DRTDevToolsAgent.h:
        * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
        (DRTDevToolsClient::reset): Calls RevokeAll().
        * DumpRenderTree/chromium/DRTDevToolsClient.h:
        * DumpRenderTree/chromium/EventSender.cpp:
        (EventSender::reset): Calls RevokeAll().
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::reset): Calls RevokeAll().
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix warnings about difference in symbol visiblity on Mac OS X
vestbo@webkit.org [Fri, 6 Aug 2010 13:07:39 +0000 (13:07 +0000)]
[Qt] Fix warnings about difference in symbol visiblity on Mac OS X

Reviewed by Antonio Gomes.

* jsc.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Fix the DRT build on Mac OS X
vestbo@webkit.org [Fri, 6 Aug 2010 13:07:21 +0000 (13:07 +0000)]
[Qt] Fix the DRT build on Mac OS X

Reviewed by Antonio Gomes.

* DumpRenderTree/qt/DumpRenderTree.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 6 Aug 2010 12:59:31 +0000 (12:59 +0000)]
2010-08-06  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Rolling out 64835, 64836 and 64839.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, fix the "GTK Linux 64-bit Debug" bot.
dumi@chromium.org [Fri, 6 Aug 2010 12:25:50 +0000 (12:25 +0000)]
Unreviewed, fix the "GTK Linux 64-bit Debug" bot.

CodeGeneratorGObject.pm doesn't know yet how to auto-generate
callbacks, so we should not auto-generate functions that take
callbacks as parameters. This shouldn't break anything, because
all these functions were marked as ["Custom"] until now, and this
code generator skipped those functions anyway.

* bindings/scripts/CodeGeneratorGObject.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 6 Aug 2010 12:13:28 +0000 (12:13 +0000)]
2010-08-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        <noscript> is not allowed inside <p>
        https://bugs.webkit.org/show_bug.cgi?id=43440

        Add a test that we now we parse this example correctly.

        * html5lib/resources/webkit02.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 6 Aug 2010 12:04:29 +0000 (12:04 +0000)]
2010-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed, forgot to land these new results in my last commit.

        SVG - stroke-width:0 bug with stroke other than "none"
        https://bugs.webkit.org/show_bug.cgi?id=42387

        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, "Qt Linux Realese minimal" build fix.
dumi@chromium.org [Fri, 6 Aug 2010 12:00:27 +0000 (12:00 +0000)]
Unreviewed, "Qt Linux Realese minimal" build fix.

* bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Auto-generate all HTML5 DB bindings.
dumi@chromium.org [Fri, 6 Aug 2010 11:47:10 +0000 (11:47 +0000)]
WebCore: Auto-generate all HTML5 DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=43382

Reviewed by Adam Barth.

* Android.jscbindings.mk: Remove {JS|V8}Database{Sync}Custom.cpp
and the custom implementations of openDatabas{Sync}().
* Android.v8bindings.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDatabaseCustom.cpp: Removed.
* bindings/js/JSDatabaseSyncCustom.cpp: Removed.
* bindings/js/JSWorkerContextCustom.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8DatabaseCustom.cpp: Removed.
* bindings/v8/custom/V8DatabaseSyncCustom.cpp: Removed.
* bindings/v8/custom/V8WorkerContextCustom.cpp:

* bindings/scripts/CodeGeneratorJS.pm: Change the code generators
to check that a value was passed for each non-optional argument,
and that the value can be converted to the argument type.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::~JSTestCallback):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::serializedValueCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithCallbackArgCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::):
(WebCore::ConfigureV8TestObjTemplate):
* bindings/v8/V8Binding.h:
(WebCore::String):
(WebCore::AtomicString):

* page/DOMWindow.idl: Minor changes required by the auto-generated
bindings.
* storage/Database.cpp:
(WebCore::Database::transaction):
(WebCore::Database::readTransaction):
(WebCore::Database::runTransaction):
* storage/Database.h:
* storage/Database.idl:
* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::transaction):
(WebCore::DatabaseSync::readTransaction):
(WebCore::DatabaseSync::runTransaction):
* storage/DatabaseSync.h:
* storage/DatabaseSync.idl:
* workers/WorkerContext.idl:

LayoutTests: Cosmetic changes to two tests.
https://bugs.webkit.org/show_bug.cgi?id=43382

Reviewed by Adam Barth.

* fast/workers/storage/open-database-inputs-sync-expected.txt:
* fast/workers/storage/resources/open-database-inputs-sync.js:
* storage/null-callbacks.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 6 Aug 2010 11:43:42 +0000 (11:43 +0000)]
2010-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Sort XCode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 6 Aug 2010 11:41:41 +0000 (11:41 +0000)]
2010-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Skip another hyphens* test to turn Leopard green again.

        fast/text/hyphen* tests have different results on Leopard
        https://bugs.webkit.org/show_bug.cgi?id=43296

        * platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 6 Aug 2010 11:30:49 +0000 (11:30 +0000)]
2010-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix warning, breaking win build.

        * svg/SVGLength.cpp:
        (WebCore::SVGLength::toCSSPrimitiveValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix crashing Leopard and Gtk bots.
ap@apple.com [Fri, 6 Aug 2010 11:23:29 +0000 (11:23 +0000)]
    Fix crashing Leopard and Gtk bots.

        * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
        Don't register ISO8859-16, because older versions of ICU don't support ISO-8859-16, causing
        crashes when we try to register an alias. Also, we don't need it, because Firefox doesn't
        support this particular alias (it supports ISO8859-1 to ISO8859-15, but only supports the
        main name for ISO-8859-16).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 6 Aug 2010 11:21:20 +0000 (11:21 +0000)]
2010-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVG - stroke-width:0 bug with stroke other than "none"
        https://bugs.webkit.org/show_bug.cgi?id=42387

        Stop storing refcounted CSSValue/CSSValueList objects in SVGRenderStyle, replacing them with SVGLength types.
        Allows us to directly specify default values for stroke-dashoffset/width in the SVGRenderStyle, fixing a problem
        with stroke-width animations when resetting to the original stored baseVal, exposed in svg/W3C-1.1/animate-elem-40-t.svg
        Originally discovered by Fady Samuel.

        Test: svg/custom/path-zero-strokewidth.svg

        * css/SVGCSSComputedStyleDeclaration.cpp:
        (WebCore::strokeDashArrayToCSSValueList): New helper function converting from Vector<SVGLength> to CSSValueList.
        (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Convert SVGLength values to CSSPrimitiveValues.
        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty): Convert CSSPrimitiveValues to SVGLength objects, for SVGRenderStyle storage.
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Just grab strokeWidth SVGLength value from SVGRenderSTyle, no need to call cssPrimitiveToLength anymore.
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::strokeBoundingBox): Ditto.
        * rendering/SVGCharacterLayoutInfo.cpp:
        (WebCore::calculateBaselineShift): Ditto (for baseline-shift).
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::buildLayoutInformation): Ditto (for kerning).
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::applyStrokeStyleToContext): Ditto (for stroke-width/stroke-dashoffset/stroke-dasharray).
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeStyle): Ditto.
        * rendering/SVGTextLayoutUtilities.cpp:
        (WebCore::calculateCSSKerning): Ditto.
        * rendering/SVGTextLayoutUtilities.h:
        * rendering/style/SVGRenderStyle.cpp: Remove no longer needed cssPrimitiveToLength function.
        * rendering/style/SVGRenderStyle.h: Stop storing RefPtr<CSSValue> / RefPtr<CSSValueList> but use SVGLength/Vector<SVGLength>.
        (WebCore::SVGRenderStyle::initialStrokeDashArray): Allows us to specify correct default values, instead of null pointers.
        (WebCore::SVGRenderStyle::initialBaselineShiftValue): Specify 0px default value.
        (WebCore::SVGRenderStyle::initialKerning): Ditto.
        (WebCore::SVGRenderStyle::initialStrokeDashOffset): Ditto.
        (WebCore::SVGRenderStyle::initialStrokeWidth): Specify 1px default value.
        (WebCore::SVGRenderStyle::setStrokeDashArray): Takes a Vector<SVGLength> now, not a PassRefPtr<CSSValueList>.
        (WebCore::SVGRenderStyle::setStrokeWidth): Takes a SVGLength now, not a PassRefPtr<CSSValue>.
        (WebCore::SVGRenderStyle::setStrokeDashOffset): Ditto.
        (WebCore::SVGRenderStyle::setKerning): Ditto.
        (WebCore::SVGRenderStyle::setStopColor): Pass Color as const-reference.
        (WebCore::SVGRenderStyle::setFloodColor): Ditto.
        (WebCore::SVGRenderStyle::setLightingColor): Ditto.
        (WebCore::SVGRenderStyle::setBaselineShiftValue): Takes a SVGLength now, not a PassRefPtr<CSSValue>.
        (WebCore::SVGRenderStyle::setShadow): Reformat, had wrong style.
        (WebCore::SVGRenderStyle::setClipperResource): Pass String as const-reference.
        (WebCore::SVGRenderStyle::setFilterResource): Ditto.
        (WebCore::SVGRenderStyle::setMaskerResource): Ditto.
        (WebCore::SVGRenderStyle::setMarkerStartResource): Ditto.
        (WebCore::SVGRenderStyle::setMarkerMidResource): Ditto.
        (WebCore::SVGRenderStyle::setMarkerEndResource): Ditto.
        (WebCore::SVGRenderStyle::strokeDashArray): Return Vector<SVGLength>.
        (WebCore::SVGRenderStyle::strokeWidth): Return SVGLength.
        (WebCore::SVGRenderStyle::strokeDashOffset): Ditto.
        (WebCore::SVGRenderStyle::kerning): Ditto.
        (WebCore::SVGRenderStyle::baselineShiftValue): Ditto.
        * rendering/style/SVGRenderStyleDefs.cpp:
        (WebCore::StyleStrokeData::StyleStrokeData): Changed initialization order, to group stroke properties.
        * rendering/style/SVGRenderStyleDefs.h: Store SVGLength values instead of reference counted CSS objects.
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::SVGLength): Add copy constructor.
        (WebCore::SVGLength::operator==): Add comparision operator.
        (WebCore::SVGLength::operator!=): Ditto.
        (WebCore::SVGLength::fromCSSPrimitiveValue): New static helper function to convert from a CSSPrimitiveValue.
        (WebCore::SVGLength::toCSSPrimitiveValue): New static helper function to convert to a CSSPrimitiveValue.
        * svg/SVGLength.h: Reindent.

2010-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVG - stroke-width:0 bug with stroke other than "none"
        https://bugs.webkit.org/show_bug.cgi?id=42387

        * platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum: Updated result, as fill="freeze" and stroke-width now works as expected.
        * platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Ditto.
        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: kerning reports 0, stroke-dashoffset 0, stroke-width 1 instead of empty values.
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Updated result, as fill="freeze" and stroke-width now works as expected.
        * platform/mac/svg/custom/path-zero-strokewidth-expected.checksum: Added.
        * platform/mac/svg/custom/path-zero-strokewidth-expected.png: Added.
        * platform/mac/svg/custom/path-zero-strokewidth-expected.txt: Added.
        * svg/css/getComputedStyle-basic-expected.txt: An empty stroke-dasharray reports "none", as defined in the spec now.
        * svg/custom/path-zero-strokewidth.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Luiz Agostini <luiz.agostini@openbossa.org>
commit-queue@webkit.org [Fri, 6 Aug 2010 11:15:40 +0000 (11:15 +0000)]
2010-08-06  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Move Qt's popup menu implementation from WebCore to WebKit layer
        https://bugs.webkit.org/show_bug.cgi?id=43427

        After PopupMenu changes in bug 42592 class QtAbstractWebPopup became unecessary and
        there is no need to keep any Qt specific code for popup menus in WebCore/platform/qt.

        PopupMenuQt has been moved from WebCore/platform/qt to WebKit/qt/WebCoreSupport and
        assumed the responsibilities of QtAbstractWebPopup. SearchPopupMenuQt has been moved
        to WebKit/qt/WebCoreSupport as well.

        All classes that previously inherited from QtAbstractWebPopup now inherit from
        QWebSelectMethod and QtPlatformPlugin's method createSelectInputMethod now returns an
        instance of class QWebSelectMethod instead of QtAbstractWebPopup.

        * WebCore.pro:
        * platform/qt/PopupMenuQt.cpp: Removed.
        * platform/qt/PopupMenuQt.h: Removed.
        * platform/qt/QtAbstractWebPopup.cpp: Removed.
        * platform/qt/QtAbstractWebPopup.h: Removed.
        * platform/qt/SearchPopupMenuQt.cpp: Removed.
        * platform/qt/SearchPopupMenuQt.h: Removed.
2010-08-06  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Move Qt's popup menu implementation from WebCore to WebKit layer
        https://bugs.webkit.org/show_bug.cgi?id=43427

        After PopupMenu changes in bug 42592 class QtAbstractWebPopup became unecessary and
        there is no need to keep any Qt specific code for popup menus in WebCore/platform/qt.

        PopupMenuQt has been moved from WebCore/platform/qt to WebKit/qt/WebCoreSupport and
        assumed the responsibilities of QtAbstractWebPopup. SearchPopupMenuQt has been moved
        to WebKit/qt/WebCoreSupport as well.

        All classes that previously inherited from QtAbstractWebPopup now inherit from
        QWebSelectMethod and QtPlatformPlugin's method createSelectInputMethod now returns an
        instance of class QWebSelectMethod instead of QtAbstractWebPopup.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::createSelectPopup):
        (WebCore::ChromeClientQt::createPopupMenu):
        (WebCore::ChromeClientQt::createSearchPopupMenu):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/PopupMenuQt.cpp: Added.
        (SelectData::SelectData):
        (SelectData::itemText):
        (SelectData::itemToolTip):
        (SelectData::itemIsEnabled):
        (SelectData::itemCount):
        (SelectData::itemIsSelected):
        (SelectData::multiple):
        (SelectData::itemType):
        (WebCore::PopupMenuQt::PopupMenuQt):
        (WebCore::PopupMenuQt::~PopupMenuQt):
        (WebCore::PopupMenuQt::disconnectClient):
        (WebCore::PopupMenuQt::show):
        (WebCore::PopupMenuQt::didHide):
        (WebCore::PopupMenuQt::hide):
        (WebCore::PopupMenuQt::updateFromElement):
        (WebCore::PopupMenuQt::selectItem):
        * WebCoreSupport/PopupMenuQt.h: Added.
        * WebCoreSupport/QtFallbackWebPopup.cpp:
        (WebCore::QtFallbackWebPopupCombo::hidePopup):
        (WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
        (WebCore::QtFallbackWebPopup::show):
        (WebCore::QtFallbackWebPopup::populate):
        (WebCore::QtFallbackWebPopup::activeChanged):
        (WebCore::QtFallbackWebPopup::pageClient):
        * WebCoreSupport/QtFallbackWebPopup.h:
        (WebCore::QtFallbackWebPopup::setGeometry):
        (WebCore::QtFallbackWebPopup::geometry):
        (WebCore::QtFallbackWebPopup::setFont):
        (WebCore::QtFallbackWebPopup::font):
        * WebCoreSupport/QtMaemoWebPopup.cpp:
        (WebCore::Maemo5Popup::populateList):
        (WebCore::QtMaemoWebPopup::QtMaemoWebPopup):
        (WebCore::QtMaemoWebPopup::createSingleSelectionPopup):
        (WebCore::QtMaemoWebPopup::createMultipleSelectionPopup):
        (WebCore::QtMaemoWebPopup::createPopup):
        (WebCore::QtMaemoWebPopup::show):
        (WebCore::QtMaemoWebPopup::popupClosed):
        (WebCore::QtMaemoWebPopup::itemClicked):
        (WebCore::Maemo5SingleSelectionPopup::Maemo5SingleSelectionPopup):
        (WebCore::Maemo5MultipleSelectionPopup::Maemo5MultipleSelectionPopup):
        * WebCoreSupport/QtMaemoWebPopup.h:
        (WebCore::Maemo5Popup::Maemo5Popup):
        * WebCoreSupport/QtPlatformPlugin.cpp:
        (WebCore::QtPlatformPlugin::createSelectInputMethod):
        * WebCoreSupport/QtPlatformPlugin.h:
        * WebCoreSupport/SearchPopupMenuQt.cpp: Added.
        (WebCore::SearchPopupMenuQt::SearchPopupMenuQt):
        (WebCore::SearchPopupMenuQt::popupMenu):
        (WebCore::SearchPopupMenuQt::saveRecentSearches):
        (WebCore::SearchPopupMenuQt::loadRecentSearches):
        (WebCore::SearchPopupMenuQt::enabled):
        * WebCoreSupport/SearchPopupMenuQt.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Fri, 6 Aug 2010 10:37:41 +0000 (10:37 +0000)]
2010-08-05  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Initial bindings and plumbing for IDBCursor.
        https://bugs.webkit.org/show_bug.cgi?id=41888

        Test: storage/indexeddb/idb-opencursor.html

        * storage/indexeddb/open-cursor-expected.txt: Added.
        * storage/indexeddb/open-cursor.html: Added.
        * storage/indexeddb/script-tests/open-cursor.js: Added.
        (cursorSuccess):
        (openCursor):
        (populateObjectStore):
        (createObjectStoreSuccess):
        (openSuccess):
        (test):
2010-08-05  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Initial bindings and plumbing for IDBCursor.
        https://bugs.webkit.org/show_bug.cgi?id=41888

        Test: storage/indexeddb/idb-opencursor.html

        * Android.derived.jscbindings.mk:
        * Android.derived.v8bindings.mk:
        * Android.mk:
        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/v8/custom/V8IDBAnyCustom.cpp:
        (WebCore::toV8):
        * storage/IDBAny.cpp:
        (WebCore::IDBAny::idbCursor):
        (WebCore::IDBAny::set):
        * storage/IDBAny.h:
        (WebCore::IDBAny::):
        * storage/IDBCallbacks.h:
        * storage/IDBCursor.cpp: Added.
        (WebCore::IDBCursor::IDBCursor):
        (WebCore::IDBCursor::~IDBCursor):
        (WebCore::IDBCursor::direction):
        (WebCore::IDBCursor::key):
        (WebCore::IDBCursor::value):
        (WebCore::IDBCursor::update):
        (WebCore::IDBCursor::continueFunction):
        (WebCore::IDBCursor::remove):
        * storage/IDBCursor.h: Added.
        (WebCore::IDBCursor::):
        (WebCore::IDBCursor::create):
        * storage/IDBCursor.idl: Added.
        * storage/IDBCursorBackendImpl.cpp: Added.
        (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
        (WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl):
        (WebCore::IDBCursorBackendImpl::direction):
        (WebCore::IDBCursorBackendImpl::key):
        (WebCore::IDBCursorBackendImpl::value):
        (WebCore::IDBCursorBackendImpl::update):
        (WebCore::IDBCursorBackendImpl::continueFunction):
        (WebCore::IDBCursorBackendImpl::remove):
        * storage/IDBCursorBackendImpl.h: Added.
        (WebCore::IDBCursorBackendImpl::create):
        * storage/IDBCursorBackendInterface.h: Added.
        (WebCore::IDBCursorBackendInterface::~IDBCursorBackendInterface):
        * storage/IDBObjectStore.cpp:
        (WebCore::IDBObjectStore::openCursor):
        * storage/IDBObjectStore.h:
        * storage/IDBObjectStore.idl:
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::openCursor):
        * storage/IDBObjectStoreBackendImpl.h:
        * storage/IDBObjectStoreBackendInterface.h:
        * storage/IDBRequest.cpp:
        (WebCore::IDBRequest::onSuccess):
        (WebCore::IDBRequest::timerFired):
        * storage/IDBRequest.h:
2010-08-05  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Initial bindings and plumbing for IDBCursor.
        https://bugs.webkit.org/show_bug.cgi?id=41888

        Test: storage/indexeddb/idb-opencursor.html

        * WebKit.gyp:
        * public/WebIDBCallbacks.h:
        (WebKit::WebIDBCallbacks::onSuccess):
        * public/WebIDBCursor.h: Added.
        (WebKit::WebIDBCursor::~WebIDBCursor):
        (WebKit::WebIDBCursor::direction):
        (WebKit::WebIDBCursor::key):
        (WebKit::WebIDBCursor::value):
        (WebKit::WebIDBCursor::update):
        (WebKit::WebIDBCursor::continueFunction):
        (WebKit::WebIDBCursor::remove):
        * public/WebIDBKeyRange.h: Added.
        (WebKit::WebIDBKeyRange::~WebIDBKeyRange):
        (WebKit::WebIDBKeyRange::WebIDBKeyRange):
        * public/WebIDBObjectStore.h:
        (WebKit::WebIDBObjectStore::openCursor):
        * src/IDBCallbacksProxy.cpp:
        (WebCore::IDBCallbacksProxy::onSuccess):
        * src/IDBCallbacksProxy.h:
        * src/IDBCursorBackendProxy.cpp: Added.
        (WebCore::IDBCursorBackendProxy::create):
        (WebCore::IDBCursorBackendProxy::IDBCursorBackendProxy):
        (WebCore::IDBCursorBackendProxy::~IDBCursorBackendProxy):
        (WebCore::IDBCursorBackendProxy::direction):
        (WebCore::IDBCursorBackendProxy::key):
        (WebCore::IDBCursorBackendProxy::value):
        (WebCore::IDBCursorBackendProxy::update):
        (WebCore::IDBCursorBackendProxy::continueFunction):
        (WebCore::IDBCursorBackendProxy::remove):
        * src/IDBCursorBackendProxy.h: Added.
        * src/IDBObjectStoreProxy.cpp:
        (WebCore::IDBObjectStoreProxy::openCursor):
        * src/IDBObjectStoreProxy.h:
        * src/WebIDBCallbacksImpl.cpp:
        (WebCore::WebIDBCallbacksImpl::onSuccess):
        * src/WebIDBCallbacksImpl.h:
        * src/WebIDBCursorImpl.cpp: Added.
        (WebKit::WebIDBCursorImpl::WebIDBCursorImpl):
        (WebKit::WebIDBCursorImpl::~WebIDBCursorImpl):
        (WebKit::WebIDBCursorImpl::direction):
        (WebKit::WebIDBCursorImpl::key):
        (WebKit::WebIDBCursorImpl::value):
        (WebKit::WebIDBCursorImpl::update):
        (WebKit::WebIDBCursorImpl::continueFunction):
        (WebKit::WebIDBCursorImpl::remove):
        * src/WebIDBCursorImpl.h: Added.
        * src/WebIDBKeyRange.cpp: Added.
        (WebKit::WebIDBKeyRange::WebIDBKeyRange):
        (WebKit::WebIDBKeyRange::assign):
        (WebKit::WebIDBKeyRange::reset):
        (WebKit::WebIDBKeyRange::left):
        (WebKit::WebIDBKeyRange::right):
        (WebKit::WebIDBKeyRange::flags):
        * src/WebIDBObjectStoreImpl.cpp:
        (WebKit::WebIDBObjectStoreImpl::openCursor):
        * src/WebIDBObjectStoreImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRefactor identifier parsing in lexer
zherczeg@webkit.org [Fri, 6 Aug 2010 10:33:10 +0000 (10:33 +0000)]
Refactor identifier parsing in lexer
https://bugs.webkit.org/show_bug.cgi?id=41845

Reviewed by Darin Adler.

The code is refactored to avoid gotos. The new code
has the same performance as the old one.

SunSpider --parse-only: no change (from 34.0ms to 33.6ms)
SunSpider: no change (from 523.2ms to 523.5ms)

* parser/Lexer.cpp:
(JSC::Lexer::parseIdent):
(JSC::Lexer::lex):
* parser/Lexer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Andrei Popescu <andreip@google.com>
andreip@google.com [Fri, 6 Aug 2010 10:16:41 +0000 (10:16 +0000)]
2010-08-06  Andrei Popescu  <andreip@google.com>

        Unreviewed, release build fix.

        Leopard relase build is broken due to absolute path to JSIDBTransaction.cpp file present in XCode project file.
        https://bugs.webkit.org/show_bug.cgi?id=43616

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Fri, 6 Aug 2010 10:00:10 +0000 (10:00 +0000)]
2010-08-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Add support for the Android viewport meta tag extensions.
        http://webkit.org/b/43567

        * Api/qwebpage.h:
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::didReceiveViewportArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Andrei Popescu <andreip@dhcp-172-16-14-12.lon.corp.google.com>
andreip@google.com [Fri, 6 Aug 2010 09:42:22 +0000 (09:42 +0000)]
2010-08-05  Andrei Popescu  <andreip@dhcp-172-16-14-12.lon.corp.google.com>

        Reviewed by Jeremy Orlow.

        [IndexedDB] IndexedDB is missing the Transaction interface.
        https://bugs.webkit.org/show_bug.cgi?id=42970

        Add IDBTransaction boilerplate.

        No new tests, not functional yet.

        * Android.derived.jscbindings.mk:
        * Android.derived.v8bindings.mk:
        * Android.mk:
        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/EventNames.h:
        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::transaction):
        * storage/IDBDatabase.h:
        * storage/IDBDatabase.idl:
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::IDBDatabaseBackendImpl::transaction):
        * storage/IDBDatabaseBackendImpl.h:
        * storage/IDBDatabaseBackendInterface.h:
        * storage/IDBRequest.cpp:
        (WebCore::IDBRequest::IDBRequest):
        (WebCore::IDBRequest::canSuspend):
        (WebCore::IDBRequest::timerFired):
        (WebCore::IDBRequest::onEventCommon):
        * storage/IDBRequest.h:
        * storage/IDBTransaction.cpp: Added.
        (WebCore::IDBTransaction::IDBTransaction):
        (WebCore::IDBTransaction::~IDBTransaction):
        (WebCore::IDBTransaction::mode):
        (WebCore::IDBTransaction::db):
        (WebCore::IDBTransaction::objectStore):
        (WebCore::IDBTransaction::abort):
        (WebCore::IDBTransaction::scriptExecutionContext):
        (WebCore::IDBTransaction::canSuspend):
        (WebCore::IDBTransaction::eventTargetData):
        (WebCore::IDBTransaction::ensureEventTargetData):
        * storage/IDBTransaction.h: Added.
        (WebCore::IDBTransaction::create):
        (WebCore::IDBTransaction::):
        (WebCore::IDBTransaction::toIDBTransaction):
        (WebCore::IDBTransaction::refEventTarget):
        (WebCore::IDBTransaction::derefEventTarget):
        * storage/IDBTransaction.idl: Added.
        * storage/IDBTransactionBackendInterface.h: Added.
        (WebCore::IDBTransactionBackendInterface::~IDBTransactionBackendInterface):
2010-08-05  Andrei Popescu  <andreip@dhcp-172-16-14-12.lon.corp.google.com>

        Reviewed by Jeremy Orlow.

        [IndexedDB] IndexedDB is missing the Transaction interface.
        https://bugs.webkit.org/show_bug.cgi?id=42970

        Add IDBTransaction boilerplate.

        * src/IDBDatabaseProxy.cpp:
        (WebCore::IDBDatabaseProxy::transaction):
        * src/IDBDatabaseProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Fri, 6 Aug 2010 08:45:03 +0000 (08:45 +0000)]
2010-08-06  Rafael Antognolli  <antognolli@profusion.mobi>

        Unreviewed build fix.

        [EFL] Regression (64735) build fix for efl.
        https://bugs.webkit.org/show_bug.cgi?id=43564

        Removing bindings/js/ScriptArray.cpp from the WebCore_SOURCES.
        No new features, so no new tests.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Fri, 6 Aug 2010 08:42:43 +0000 (08:42 +0000)]
2010-08-06  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Pavel Feldman.

        Rietvield's upload.py moved to a different location.
        https://bugs.webkit.org/show_bug.cgi?id=43613

        * Scripts/webkitpy/thirdparty/__init__.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 6 Aug 2010 08:15:13 +0000 (08:15 +0000)]
2010-08-06  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: Chromium test expectations rebaseline.

        * platform/chromium-linux/fast/text/stripNullFromText-expected.checksum:
        * platform/chromium-linux/fast/text/stripNullFromText-expected.png: Added.
        * platform/chromium-linux/fast/text/stripNullFromText-expected.txt:
        * platform/chromium-linux/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Added.
        * platform/chromium-mac/fast/text/stripNullFromText-expected.checksum:
        * platform/chromium-mac/fast/text/stripNullFromText-expected.png:
        * platform/chromium-mac/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
        * platform/chromium-win/fast/text/stripNullFromText-expected.checksum:
        * platform/chromium-win/fast/text/stripNullFromText-expected.png:
        * platform/chromium-win/fast/text/stripNullFromText-expected.txt:
        * platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix http/tests/webarchive/test-css-url-encoding-shift-jis.html
ap@apple.com [Fri, 6 Aug 2010 06:50:41 +0000 (06:50 +0000)]
    Fix http/tests/webarchive/test-css-url-encoding-shift-jis.html

        For some reason, I didn't see the failure locally, but bots complain.

        * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
        Register "shift-jis" (with dash instead of underscore). At least Firefox supports it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Ben Murdoch <benm@google.com>
benm@google.com [Fri, 6 Aug 2010 05:57:08 +0000 (05:57 +0000)]
2010-08-05  Ben Murdoch  <benm@google.com>

        Reviewed by Simon Fraser.

        Form button input elements lacking text in some cases after switching from visibility:collapse to visibility:visible
        https://bugs.webkit.org/show_bug.cgi?id=38050

        * fast/css/visibility-collapse-form-buttons-expected.txt: Added.
        * fast/css/visibility-collapse-form-buttons.html: Added.
2010-08-05  Ben Murdoch  <benm@google.com>

        Reviewed by Simon Fraser.

        Form button input elements lacking text in some cases after switching from
        visibility:collapse to visibility:visible
        https://bugs.webkit.org/show_bug.cgi?id=38050

        A relayout is required after toggling visibility from collapse to another value.

        Test: fast/css/visibility-collapse-form-buttons.html

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::diff): If we're toggling from visibility:collapse to another
            visibility value (or vice versa) then we need to trigger a relayout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoThe ARM JIT does not support JSValue32_64 with RVCT
loki@webkit.org [Fri, 6 Aug 2010 05:50:51 +0000 (05:50 +0000)]
The ARM JIT does not support JSValue32_64 with RVCT
https://bugs.webkit.org/show_bug.cgi?id=43411

Reviewed by Gavin Barraclough.

JSValue32_64 is enabled for RVCT by default.

* create_jit_stubs:
* jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Fri, 6 Aug 2010 05:36:28 +0000 (05:36 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=43554
        Way too many encoding aliases are treated as valid

        <rdar://problem/7863399> Garbage characters displayed in some yesky.com pages.

        <rdar://problem/7859068> Garbage characters displayed for most text at ceping.zhaopin.com

        Test: http/tests/misc/bad-charset-alias.html

        * loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForCSSCharset):
        Fix encoding name length computation. Previously, a trailing quote was ignored by
        TextEncodingRegistry.

        * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
        Added dashes to alias names that didn't have them. Added aliases prompted by regression tests.

        * platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::registerEncodingNames):
        Don't register 8859-1, other browsers do not support this encoding name.

        * platform/text/TextEncoding.cpp: (WebCore::Latin1Encoding):
        "Latin-1" is not a real encoding name, it's not known to Firefox or IE.

        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::TextEncodingNameHash::equal): Changed to no longer ignore non-alphanumeric characters.
        There is a good chance that we'll be missing support for some necessary alias names, but other
        browsers don't ignore any characters when matching names.
        (WebCore::TextEncodingNameHash::hash): Ditto.
        (WebCore::checkExistingName): Re-formatted a line.
        (WebCore::isUndesiredAlias): Added a filter to reject "8859_1" and any names containing commas.
        (WebCore::addToTextEncodingNameMap): Used it.
        (WebCore::atomicCanonicalTextEncodingName): Changed to no longer ignore non-alphanumeric characters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Simon Hausmann <simon.hausmann@nokia.com>
commit-queue@webkit.org [Fri, 6 Aug 2010 05:08:34 +0000 (05:08 +0000)]
2010-08-05  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Temporary files should not be created in the current directory
        https://bugs.webkit.org/show_bug.cgi?id=43562

        Don't create temporary files in the current directory, use QDir::tempPath()
        instead, as suggested by the QTemporaryFile documentation.

        * platform/qt/FileSystemQt.cpp:
        (WebCore::openTemporaryFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 W. James MacLean <wjmaclean@chromium.org>
commit-queue@webkit.org [Fri, 6 Aug 2010 04:50:29 +0000 (04:50 +0000)]
2010-08-05  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Nikolas Zimmermann.

        SVG - numeric overflow for very large elements
        https://bugs.webkit.org/show_bug.cgi?id=25645

        Rebaselining results for gtk/win platforms.
        Skip pattern-excessive-malloc.svg on GTK for now.

        * platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
        * platform/gtk/Skipped: Modified.
        * platform/win/svg/custom/massive-coordinates-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Fran├žois Sausset <sausset@gmail.com>
commit-queue@webkit.org [Fri, 6 Aug 2010 04:11:02 +0000 (04:11 +0000)]
2010-08-05  Fran├žois Sausset  <sausset@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Make STIX font the default one to render MathML
        https://bugs.webkit.org/show_bug.cgi?id=41961

        * css/mathml.css:
        (math):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Cosmin Truta <ctruta@chromium.org>
commit-queue@webkit.org [Fri, 6 Aug 2010 03:47:41 +0000 (03:47 +0000)]
2010-08-05  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Eric Seidel.

        Apply a stylistic fix to the patch 62640.
        https://bug-41175-attachments.webkit.org/attachment.cgi?id=62640
        https://bugs.webkit.org/show_bug.cgi?id=41175

        * WebCore/platform/graphics/skia/ImageBufferSkia.cpp:
        (getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Fri, 6 Aug 2010 02:51:19 +0000 (02:51 +0000)]
2010-08-05  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Roben.

        Make SearchPopupMenuWin more portable
        https://bugs.webkit.org/show_bug.cgi?id=43527

        Add #if PLATFORM(CF) around CoreFoundation code.

        * platform/win/SearchPopupMenuWin.cpp:
        (WebCore::SearchPopupMenuWin::enabled):
        (WebCore::SearchPopupMenuWin::saveRecentSearches):
        (WebCore::SearchPopupMenuWin::loadRecentSearches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Jessie Berlin <jberlin@apple.com>
jberlin@webkit.org [Fri, 6 Aug 2010 02:17:56 +0000 (02:17 +0000)]
2010-08-05  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Jon Honeycutt.

        Bug 43593 - WebView::backingStore should check if m_backingStoreBitmap is NULL.
        https://bugs.webkit.org/show_bug.cgi?id=43593

        * WebView.cpp:
        (WebView::backingStore):
        If m_backingStoreBitmap is NULL, return E_FAIL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 6 Aug 2010 01:54:40 +0000 (01:54 +0000)]
2010-08-05  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r63653.
        http://trac.webkit.org/changeset/63653
        https://bugs.webkit.org/show_bug.cgi?id=43592

        regressed multiple background-images (Requested by smfr on
        #webkit).

        * manual-tests/css3-background-layer-count.html: Removed.
        * rendering/style/FillLayer.cpp:
        (WebCore::FillLayer::fillUnsetProperties):
        (WebCore::FillLayer::cullEmptyLayers):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::adjustBackgroundLayers):
        (WebCore::InheritedFlags::adjustMaskLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix some leaks seen on the buildbot.
mrowe@apple.com [Fri, 6 Aug 2010 01:38:15 +0000 (01:38 +0000)]
Fix some leaks seen on the buildbot.

Reviewed by Jon Honeycutt.

* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::paintToCanvas): Adopt the newly-created CoreGraphics objects rather than sharing ownership
and over-incrementing their reference count. Also cleaned up the bizarre wrapping used for function arguments while I was
touching this code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 6 Aug 2010 01:23:00 +0000 (01:23 +0000)]
2010-08-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        dumpAsMarkup conversion: deleting/delete-4038408-fix.html, deleting/delete-br-011.html, and execCommand/format-block-from-range-selection.html
        https://bugs.webkit.org/show_bug.cgi?id=43580

        Converted deleting/delete-4038408-fix.html, deleting/delete-br-011.html, and execCommand/format-block-from-range-selection.html
        to a dumpAsMarkup test because all the tests were testing the correctness of the resultant DOM tree.
        In addition, removed editing delegates from execCommand/format-block-from-range-selection.html because it's not relevant to the test.

        * editing/deleting/delete-4038408-fix-expected.txt: Added.
        * editing/deleting/delete-4038408-fix.html: Converted.
        * editing/deleting/delete-br-011-expected.txt: Added.
        * editing/deleting/delete-br-011.html: Converted.
        * editing/execCommand/format-block-from-range-selection-expected.txt: Added.
        * editing/execCommand/format-block-from-range-selection.html: Converted.
        * platform/chromium-linux/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
        * platform/chromium-linux/editing/deleting/delete-4038408-fix-expected.png: Removed.
        * platform/chromium-linux/editing/deleting/delete-br-011-expected.checksum: Removed.
        * platform/chromium-linux/editing/deleting/delete-br-011-expected.png: Removed.
        * platform/chromium-linux/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
        * platform/chromium-linux/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
        * platform/chromium-win/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
        * platform/chromium-win/editing/deleting/delete-4038408-fix-expected.png: Removed.
        * platform/chromium-win/editing/deleting/delete-4038408-fix-expected.txt: Removed.
        * platform/chromium-win/editing/deleting/delete-br-011-expected.checksum: Removed.
        * platform/chromium-win/editing/deleting/delete-br-011-expected.png: Removed.
        * platform/chromium-win/editing/deleting/delete-br-011-expected.txt: Removed.
        * platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
        * platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
        * platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
        * platform/mac-leopard/editing/deleting/delete-4038408-fix-expected.png: Removed.
        * platform/mac/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
        * platform/mac/editing/deleting/delete-4038408-fix-expected.png: Removed.
        * platform/mac/editing/deleting/delete-4038408-fix-expected.txt: Removed.
        * platform/mac/editing/deleting/delete-br-011-expected.checksum: Removed.
        * platform/mac/editing/deleting/delete-br-011-expected.png: Removed.
        * platform/mac/editing/deleting/delete-br-011-expected.txt: Removed.
        * platform/mac/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
        * platform/mac/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
        * platform/mac/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
        * platform/qt/editing/deleting/delete-4038408-fix-expected.txt: Removed.
        * platform/qt/editing/deleting/delete-br-011-expected.txt: Removed.
        * platform/qt/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 6 Aug 2010 01:09:55 +0000 (01:09 +0000)]
2010-08-05  James Robinson  <jamesr@chromium.org>

        Rubber stamped by Eric Seidel.

        [SVG] SVGPathSeg.cpp needs an #if ENABLE(SVG) guard
        https://bugs.webkit.org/show_bug.cgi?id=43599

        Matches the rest of the .cpp files in this directory.

        * svg/SVGPathSeg.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 6 Aug 2010 00:56:40 +0000 (00:56 +0000)]
2010-08-05  Adam Barth  <abarth@webkit.org>

        Update Qt result showing that we strip nulls in this case.

        * platform/qt/fast/text/stripNullFromText-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Fri, 6 Aug 2010 00:46:10 +0000 (00:46 +0000)]
2010-08-05  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Kent Tamura.

        Calling setCustomValidity should trigger a layout
        https://bugs.webkit.org/show_bug.cgi?id=43582

        * fast/forms/setCustomValidity-expected.txt: Added.
        * fast/forms/setCustomValidity.html: Added.
2010-08-05  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Kent Tamura.

        Calling setCustomValidity should trigger a layout
        https://bugs.webkit.org/show_bug.cgi?id=43582

        Test: fast/forms/setCustomValidity.html

        * html/ValidityState.cpp:
        (WebCore::ValidityState::setCustomErrorMessage): Call setNeedsValidityCheck to tell the system that the validity might have changed.
        * html/ValidityState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-08-05 Chao-ying Fu <fu@mips.com>
commit-queue@webkit.org [Fri, 6 Aug 2010 00:41:26 +0000 (00:41 +0000)]
2010-08-05  Chao-ying Fu  <fu@mips.com>

        Reviewed by Darin Adler.

        Define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER for MIPS
        https://bugs.webkit.org/show_bug.cgi?id=43514

        MIPS needs to define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER, so that
        RenderArena::allocate() can return 8-byte aligned memory to avoid
        exceptions on sdc1/ldc1.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@64804 268f45cc-cd09-0410-ab3c-d52691b4dbfc