WebKit-https.git
15 years agoFixed Bugzilla references in ChangeLogs for my previous commit.
ap [Sun, 1 Oct 2006 08:37:29 +0000 (08:37 +0000)]
Fixed Bugzilla references in ChangeLogs for my previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej and Darin.
ap [Sun, 1 Oct 2006 08:35:29 +0000 (08:35 +0000)]
    Reviewed by Maciej and Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=4372
        JavaScript document.write page form does not submit in Safari

        Test: fast/forms/document-write.html

        * page/Frame.cpp:
        (WebCore::Frame::submitForm): Don't check for parsing().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
ap [Sun, 1 Oct 2006 08:13:04 +0000 (08:13 +0000)]
    Build fix.

        * bridge/mac/FrameViewMac.mm: Add missing #imports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRefactor the code that sends the mouse down to scrollbars.
hyatt [Sun, 1 Oct 2006 07:26:55 +0000 (07:26 +0000)]
Refactor the code that sends the mouse down to scrollbars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
weinig [Sat, 30 Sep 2006 23:33:25 +0000 (23:33 +0000)]
    Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
        Add more SVG Objective-C DOM bindings

        - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
          DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
          DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
          DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
          DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument,
          DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMSVG.h:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * ksvg2/svg/SVGAElement.idl:
        * ksvg2/svg/SVGAnimateColorElement.idl:
        * ksvg2/svg/SVGAnimateElement.idl:
        * ksvg2/svg/SVGAnimateTransformElement.idl:
        * ksvg2/svg/SVGAnimatedPathData.idl:
        * ksvg2/svg/SVGAnimatedPoints.idl:
        * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
        * ksvg2/svg/SVGAnimationElement.idl:
        * ksvg2/svg/SVGCircleElement.idl:
        * ksvg2/svg/SVGClipPathElement.idl:
        * ksvg2/svg/SVGColor.idl:
        * ksvg2/svg/SVGCursorElement.idl:
        * ksvg2/svg/SVGDefsElement.idl:
        * ksvg2/svg/SVGDescElement.idl:
        * ksvg2/svg/SVGDocument.idl:
        * ksvg2/svg/SVGEllipseElement.idl:
        * ksvg2/svg/SVGPointList.idl:
        * ksvg2/svg/SVGPreserveAspectRatio.idl:
        * ksvg2/svg/SVGRect.idl:
        * ksvg2/svg/SVGSVGElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
mjs [Sat, 30 Sep 2006 23:18:59 +0000 (23:18 +0000)]
    Reviewed by Adele.

        - fix build

        * platform/FloatRect.h:
        (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
        but more appropriate for path-type stuff.
        * platform/cg/PathCG.cpp:
        (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Sat, 30 Sep 2006 21:14:44 +0000 (21:14 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11011
        External CSS is parsed as iso-8859-1 even though the main document is utf-8

        Test: fast/encoding/css-charset-default.xhtml

        * loader/CachedResourceClient.h:
        (WebCore::CachedResourceClient::setCSSStyleSheet):
        (WebCore::CachedResourceClient::setXSLStyleSheet):
        Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
        takes an additional charset parameter, to be passed to CSSStyleSheet constructor.

        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::setCSSStyleSheet):
        (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
        * css/CSSImportRule.h:

        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::CSSStyleSheet):
        * css/CSSStyleSheet.h:
        Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
        member. Changed some String parameters to const String&.

        * css/StyleSheet.cpp:
        (WebCore::StyleSheet::StyleSheet):
        * css/StyleSheet.h:
        Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.

        * css/StyleSheetList.cpp:
        (WebCore::StyleSheetList::length):
        (WebCore::StyleSheetList::item):
        * css/StyleSheetList.h:
        Special-casing implicit stylesheets seemed to be dead code, removed.

        * dom/Document.cpp:
        (WebCore::Document::setCSSStyleSheet):
        (WebCore::Document::recalcStyleSelector):
        * dom/Document.h:
        Renamed setStyleSheet() to setCSSStyleSheet().

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
        (WebCore::ProcessingInstruction::setCSSStyleSheet):
        (WebCore::ProcessingInstruction::setXSLStyleSheet):
        (WebCore::ProcessingInstruction::parseStyleSheet):
        * dom/ProcessingInstruction.h:

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute
        is not specified.
        (WebCore::HTMLLinkElement::setCSSStyleSheet):
        * html/HTMLLinkElement.h:

        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::childrenChanged):
        * ksvg2/svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::childrenChanged):
        Inherit URL and charset from the document.

        * loader/Cache.cpp:
        (WebCore::Cache::requestCSSStyleSheet):
        * loader/Cache.h:
        Adjust for setStyleSheet() renaming.

        * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::ref):
        (WebCore::CachedCSSStyleSheet::deref):
        (WebCore::CachedCSSStyleSheet::checkNotify):
        Pass the encoding to setCSSStyleSheet().

        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::ref):
        (WebCore::CachedXSLStyleSheet::checkNotify):
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::requestCSSStyleSheet):
        * loader/DocLoader.h:
        * page/Frame.cpp:
        (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
        (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::setXSLStyleSheet):
        (WebCore::XSLImportRule::loadSheet):
        * xml/XSLImportRule.h:
        Adjust for setStyleSheet() renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by eseidel.
rwlbuis [Sat, 30 Sep 2006 17:08:39 +0000 (17:08 +0000)]
    Reviewed by eseidel.

        http://bugs.webkit.org/show_bug.cgi?id=11096
        Hit testing for polylines fails

        Fix Path::contains so it handles filled, non-closed paths too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix win32.
hyatt [Sat, 30 Sep 2006 10:11:11 +0000 (10:11 +0000)]
Fix win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRevert minimum font size pref back to 1.
hyatt [Sat, 30 Sep 2006 09:49:30 +0000 (09:49 +0000)]
Revert minimum font size pref back to 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix win32 bustage caused by a typo.
hyatt [Sat, 30 Sep 2006 09:48:24 +0000 (09:48 +0000)]
Fix win32 bustage caused by a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix mac bustage in FrameMac.mm and FrameViewMac.mm
hyatt [Sat, 30 Sep 2006 09:46:07 +0000 (09:46 +0000)]
Fix mac bustage in FrameMac.mm and FrameViewMac.mm

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoEvent refactoring.
hyatt [Sat, 30 Sep 2006 09:30:31 +0000 (09:30 +0000)]
Event refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
adele [Sat, 30 Sep 2006 05:42:00 +0000 (05:42 +0000)]
    Reviewed by Adele.

        Fixes windows bustage:
        http://bugs.webkit.org/show_bug.cgi?id=11093

        * platform/win/PlatformScrollBar.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (PlatformScrollBar::PlatformScrollBar):
        (ScrollBar::ScrollBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Bug 11041: fast/dom/isindex-001 needs new results
thatcher [Sat, 30 Sep 2006 03:25:38 +0000 (03:25 +0000)]
    Bug 11041: fast/dom/isindex-001 needs new results
        http://bugs.webkit.org/show_bug.cgi?id=11041

        * fast/dom/isindex-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Change the default minimum font size pref to 0 in order to allow
hyatt [Sat, 30 Sep 2006 01:57:48 +0000 (01:57 +0000)]
    Change the default minimum font size pref to 0 in order to allow
        font-size:0 to work.

        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
hyatt [Sat, 30 Sep 2006 01:55:05 +0000 (01:55 +0000)]
    Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
        in RenderObject::NodeInfo (and then propagating that Widget to
        MouseEventWithHitTestResults).

        This allows RenderListBox and RenderBlock to do the same thing when the
        mouse is over the scrollbar.

        Also land fix to support font-size: 0.

        Reviewed by mjs (scrollbar), eric (font-size)

        * dom/Document.cpp:
        (WebCore::Document::prepareMouseEvent):
        * page/Frame.cpp:
        (WebCore::Frame::passWidgetMouseDownEventToWidget):
        * page/FrameView.cpp:
        (WebCore::selectCursor):
        (WebCore::FrameView::handleMouseMoveEvent):
        (WebCore::FrameView::dispatchMouseEvent):
        * page/MouseEventWithHitTestResults.cpp:
        (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
        * page/MouseEventWithHitTestResults.h:
        (WebCore::MouseEventWithHitTestResults::scrollbar):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isPointInScrollbar):
        (WebCore::RenderBlock::nodeAtPoint):
        * rendering/RenderBlock.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTest):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::getHiddenBehavior):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::RenderListBox):
        (WebCore::RenderListBox::~RenderListBox):
        (WebCore::RenderListBox::isPointInScrollbar):
        * rendering/RenderListBox.h:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::NodeInfo::NodeInfo):
        (WebCore::RenderObject::NodeInfo::scrollbar):
        (WebCore::RenderObject::NodeInfo::setScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
adele [Sat, 30 Sep 2006 01:50:56 +0000 (01:50 +0000)]
    Reviewed by Adele.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::convertToContainingWindow):
        (WebCore::ScrollView::convertFromContainingWindow):
        * platform/win/WidgetWin.cpp:
        (WebCore::Widget::convertToContainingWindow):
        (WebCore::Widget::convertFromContainingWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Updated with new argument for PlatformScrollBar.
adele [Sat, 30 Sep 2006 01:44:59 +0000 (01:44 +0000)]
    Updated with new argument for PlatformScrollBar.

        * platform/win/TemporaryLinkStubs.cpp:
        (PlatformScrollBar::PlatformScrollBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix.
thatcher [Sat, 30 Sep 2006 00:06:25 +0000 (00:06 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
adele [Fri, 29 Sep 2006 23:59:27 +0000 (23:59 +0000)]
    Reviewed by Hyatt.

        Fixing build bustage with cast to int.

        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fixing accidental include.
adele [Fri, 29 Sep 2006 23:45:55 +0000 (23:45 +0000)]
    Fixing accidental include.

        * rendering/RenderListBox.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdding RenderListBox files.
adele [Fri, 29 Sep 2006 23:41:23 +0000 (23:41 +0000)]
Adding RenderListBox files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixing typo. No problem in the ned. Just the end.
bdakin [Fri, 29 Sep 2006 23:15:37 +0000 (23:15 +0000)]
Fixing typo. No problem in the ned. Just the end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
adele [Fri, 29 Sep 2006 23:13:49 +0000 (23:13 +0000)]
    Reviewed by Adam.

        Initial implementation of engine-based list box control.

        * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp

        * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
        * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
        (WebCore::FrameMac::FrameMac):
        (WebCore::FrameMac::handleMousePressEvent):
        (WebCore::FrameMac::handleMouseMoveEvent):
        (WebCore::FrameMac::mouseDown):

        * page/Frame.cpp:
        (WebCore::Frame::handleMouseMoveEvent):
        (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
        (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
        (WebCore::Frame::autoscrollTimerFired): ditto.
        (WebCore::Frame::stopAutoscrollTimer): ditto.
        (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
        * page/Frame.h:
        * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.

        * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
        (WebCore::FrameViewPrivate::reset):
        (WebCore::FrameView::currentMousePosition):
        (WebCore::FrameView::handleMousePressEvent):
        (WebCore::FrameView::handleMouseDoubleClickEvent):
        (WebCore::selectCursor):
        (WebCore::FrameView::handleMouseMoveEvent):
        (WebCore::FrameView::handleMouseReleaseEvent):
        * page/FrameView.h:

        * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
        * platform/ScrollBar.h:
        (WebCore::):
        (WebCore::ScrollBar::controlSize):
        * platform/mac/PlatformScrollBar.h:
        * platform/mac/PlatformScrollBarMac.mm:
        (NSControlSizeForScrollBarControlSize):
        (-[WebCoreScrollBar initWithPlatformScrollBar:]):
        (WebCore::PlatformScrollBar::PlatformScrollBar):

        * rendering/RenderBlock.h:
        * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
        * rendering/RenderLayer.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::shouldAutoscroll):
        (WebCore::RenderObject::autoscroll):
        * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):

        * css/html4.css: Added properties for new list boxes.

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
        (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
        * html/HTMLOptionElement.h: Added disabled method.

        * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
        (WebCore::HTMLSelectElement::recalcStyle):
        (WebCore::HTMLSelectElement::lastSelectedListIndex):
        (WebCore::HTMLSelectElement::deselectItems):
        (WebCore::HTMLSelectElement::setSelectedIndex):
        (WebCore::HTMLSelectElement::isKeyboardFocusable):
        (WebCore::HTMLSelectElement::isMouseFocusable):
        (WebCore::HTMLSelectElement::createRenderer):
        (WebCore::HTMLSelectElement::recalcListItems):
        (WebCore::HTMLSelectElement::setRecalcListItems):
        (WebCore::HTMLSelectElement::reset):
        (WebCore::HTMLSelectElement::notifyOptionSelected):
        (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
        (WebCore::HTMLSelectElement::nextSelectableListIndex):
        (WebCore::HTMLSelectElement::previousSelectableListIndex):
        * html/HTMLSelectElement.h:

        * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::paintBorderOnly):
        (WebCore::RenderTheme::paintDecorations):
        (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
        (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
        (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
        (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
        (WebCore::RenderTheme::isControlStyled):
        (WebCore::RenderTheme::supportsFocusRing):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):

        * rendering/RenderListBox.cpp: Added.
        (WebCore::RenderListBox::RenderListBox):
        (WebCore::RenderListBox::~RenderListBox):
        (WebCore::RenderListBox::setStyle):
        (WebCore::RenderListBox::updateFromElement):
        (WebCore::RenderListBox::calcMinMaxWidth):
        (WebCore::RenderListBox::size):
        (WebCore::RenderListBox::numItems):
        (WebCore::RenderListBox::calcHeight):
        (WebCore::RenderListBox::baselinePosition):
        (WebCore::RenderListBox::itemBoundingBoxRect):
        (WebCore::RenderListBox::paintObject):
        (WebCore::RenderListBox::paintScrollbar):
        (WebCore::RenderListBox::paintItemForeground):
        (WebCore::RenderListBox::paintItemBackground):
        (WebCore::RenderListBox::scrollBarTarget):
        (WebCore::RenderListBox::isPointInScrollbar):
        (WebCore::RenderListBox::optionAtPoint):
        (WebCore::RenderListBox::autoscroll):
        (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
        (WebCore::RenderListBox::scroll):
        (WebCore::RenderListBox::valueChanged):
        * rendering/RenderListBox.h: Added.
        (WebCore::RenderListBox::isListBox):
        (WebCore::RenderListBox::selectionChanged):
        (WebCore::RenderListBox::setSelectionChanged):
        (WebCore::RenderListBox::canHaveChildren):
        (WebCore::RenderListBox::renderName):
        (WebCore::RenderListBox::setOptionsChanged):
        (WebCore::RenderListBox::shouldAutoscroll):
        (WebCore::RenderListBox::listIndexIsVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
bdakin [Fri, 29 Sep 2006 23:10:27 +0000 (23:10 +0000)]
    Reviewed by Darin.

        We had a bug where html4.css was ignoring Media Queries. In the ned
        the problem was that we were trying to send a char* to the
        MediaQueryEvaluator constructor that expects a String, but the
        char* got interpreted as a bool, the wrong constructor was called,
        and the media type was never set.

        No test case possible since this only affects html4.css

        * css/MediaQueryEvaluator.cpp: New constructor that expects takes a
        char*
        (WebCore::MediaQueryEvaluator):
        * css/MediaQueryEvaluator.h: Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ggaren [Fri, 29 Sep 2006 22:57:04 +0000 (22:57 +0000)]
LayoutTests:

        Reviewed by John, Maciej.

        Added test for whether a frame element reports its src attribute as a
        complete, rather than relative, URL.

        * fast/frames/frame-src-attribute-expected.txt: Added.
        * fast/frames/frame-src-attribute.html: Added.
        * fast/frames/resources/frame-src-attribute-subframe.html: Added.

WebCore:

        Reviewed by John, Maciej.

        Integrated some frame and iframe code. I'm trying to fix up frame ownership
        and loading. Reducing the number of different code paths involved
        seemed like a good first step.

        As a side effect, I fixed a bug where FRAME elements would report their
        src attributes as relative, rather than compelete, URLs. (IFRAME elements
        had the correct complete URL behavior.)

        * html/HTMLFrameElement.cpp:
        (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
        (WebCore::HTMLFrameElement::openURL):
            (1) Removed checks that requestFrame does for us
            (2) Added isURLAllowed check, to have one clear bottleneck for it
            (3) Added viewsource check, to have one clear bottleneck for it
        (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
        method, instead of finding our content frame in our own unique way.
        (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
        since openURL does this for us now.
        (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
        This is what FF does, and it made no sense to have different behaviors
        for FRAME and IFRAME elements.
        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
        code.
        * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
        HTMLFrameElement now does everything we need.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
rwlbuis [Fri, 29 Sep 2006 22:33:52 +0000 (22:33 +0000)]
    Reviewed by Hyatt.

        Fix Qt/Linux build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:24:15 +0000 (22:24 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:22:31 +0000 (22:22 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:21:53 +0000 (22:21 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:21:13 +0000 (22:21 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:20:06 +0000 (22:20 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:17:46 +0000 (22:17 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:16:47 +0000 (22:16 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:14:50 +0000 (22:14 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:12:15 +0000 (22:12 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:08:31 +0000 (22:08 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim H.
weinig [Fri, 29 Sep 2006 20:29:16 +0000 (20:29 +0000)]
    Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11082
        Simplify Internal methods for the auto-generated Objective-C DOM code

        - Auto-generate the internal methods for more Objective-C classes.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        * bindings/objc/DOMCSS.mm:
        (-[DOMStyleSheet WebCore::]):
        (+[DOMStyleSheet _styleSheetWith:WebCore::]):
        (-[DOMCSSRule WebCore::]):
        (-[DOMCSSRule _initWithCSSRule:WebCore::]):
        (+[DOMCSSRule _CSSRuleWith:WebCore::]):
        (-[DOMCSSValue WebCore::]):
        (-[DOMCSSValue _initWithCSSValue:WebCore::]):
        (+[DOMCSSValue _CSSValueWith:WebCore::]):
        * bindings/objc/DOMHTMLAppletElement.mm:
        (-[DOMHTMLAppletElement WebCore::]):
        (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
        * bindings/objc/DOMHTMLEmbedElement.mm:
        (-[DOMHTMLEmbedElement WebCore::]):
        (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMInternal.mm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * css/CSSCharsetRule.idl:
        * css/CSSFontFaceRule.idl:
        * css/CSSImportRule.idl:
        * css/CSSMediaRule.idl:
        * css/CSSPageRule.idl:
        * css/CSSPrimitiveValue.idl:
        * css/CSSStyleRule.idl:
        * css/CSSStyleSheet.idl:
        * css/CSSUnknownRule.idl:
        * css/CSSValueList.idl:
        * dom/KeyboardEvent.idl:
        * dom/MouseEvent.idl:
        * dom/MutationEvent.idl:
        * dom/NodeIterator.idl:
        * dom/OverflowEvent.idl:
        * dom/UIEvent.idl:
        * dom/WheelEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
harrison [Fri, 29 Sep 2006 16:57:38 +0000 (16:57 +0000)]
LayoutTests:

        Reviewed by John Sullivan.

        <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
        <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

        * fast/text/attributed-substring-from-range-001-expected.txt: Added.
        * fast/text/attributed-substring-from-range-001.html: Added.

        Check attributed string results when starting or ending at a br element.

WebCore:

        Reviewed by John Sullivan.

        <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
        <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

        Test added
        * fast/text/attributed-substring-from-range-001.html

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::attributedString):
        Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
        Also, add validation of the range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
thatcher [Fri, 29 Sep 2006 16:10:44 +0000 (16:10 +0000)]
    Reviewed by Maciej.

        Switch the inspector over to use border-image with styled buttons and selects.

        * WebInspector/WebInspector.m:
        (-[NSWindow window]):
        (-[NSWindow setWebFrame:]):
        (-[WebInspector _updateRoot]):
        * WebInspector/webInspector/Images/button.png: Added.
        * WebInspector/webInspector/Images/buttonDivider.png: Added.
        * WebInspector/webInspector/Images/buttonPressed.png: Added.
        * WebInspector/webInspector/Images/popup.png: Added.
        * WebInspector/webInspector/Images/popupFill.png: Removed.
        * WebInspector/webInspector/Images/popupFillPressed.png: Removed.
        * WebInspector/webInspector/Images/popupLeft.png: Removed.
        * WebInspector/webInspector/Images/popupLeftPressed.png: Removed.
        * WebInspector/webInspector/Images/popupPressed.png: Added.
        * WebInspector/webInspector/Images/popupRight.png: Removed.
        * WebInspector/webInspector/Images/popupRightPressed.png: Removed.
        * WebInspector/webInspector/Images/squareButtonRight.png: Removed.
        * WebInspector/webInspector/Images/squareButtonRightPressed.png: Removed.
        * WebInspector/webInspector/inspector.css:
        * WebInspector/webInspector/inspector.html:
        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoI commited old expected results, this one is correct.
rwlbuis [Fri, 29 Sep 2006 15:27:49 +0000 (15:27 +0000)]
I commited old expected results, this one is correct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd the ability to set the click count after the fact on a mouse event.
hyatt [Fri, 29 Sep 2006 08:40:25 +0000 (08:40 +0000)]
Add the ability to set the click count after the fact on a mouse event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
rwlbuis [Fri, 29 Sep 2006 08:30:12 +0000 (08:30 +0000)]
    Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
        InsertRule can not handle @import statements

        Allow @import as part of a css rule.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-28 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 29 Sep 2006 02:07:24 +0000 (02:07 +0000)]
2006-09-28  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Maciej.

        Use $(ConfigSuffix) set via vsprops files to add _debug
        to end of debug filenames.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/debug.vsprops: Added.
        * JavaScriptCore.vcproj/dftables/dftables.vcproj:
        * JavaScriptCore.vcproj/release.vsprops: Added.
        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
hyatt [Fri, 29 Sep 2006 00:39:48 +0000 (00:39 +0000)]
    Switch over the Mac-specific uses of viewportToContents/contentsToViewport.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::eventMayStartDrag):
        (WebCore::FrameMac::dragHysteresisExceeded):
        (WebCore::FrameMac::mouseDown):
        (WebCore::FrameMac::shouldDragAutoNode):
        (WebCore::FrameMac::sendContextMenuEvent):
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge _visiblePositionForPoint:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoEliminate viewportToContents and contentsToViewport
hyatt [Fri, 29 Sep 2006 00:17:01 +0000 (00:17 +0000)]
Eliminate viewportToContents and contentsToViewport

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix by adding missing files for CommandByName
aliceli1 [Thu, 28 Sep 2006 23:32:36 +0000 (23:32 +0000)]
    Build fix by adding missing files for CommandByName

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Adding CommandByName files to the vcproj
aliceli1 [Thu, 28 Sep 2006 22:47:41 +0000 (22:47 +0000)]
    Adding CommandByName files to the vcproj

        * WebCore.vcproj/WebCore/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago fixing the windows build
aliceli1 [Thu, 28 Sep 2006 22:23:34 +0000 (22:23 +0000)]
    fixing the windows build

        * COM/WebView.cpp:
        (WebView::mouseMoved):
        (WebView::mouseDown):
        (WebView::mouseUp):
        (WebView::mouseDoubleClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@16626 268f45cc-cd09-0410...
aliceli1 [Thu, 28 Sep 2006 21:39:47 +0000 (21:39 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
aroben [Thu, 28 Sep 2006 21:33:07 +0000 (21:33 +0000)]
    Reviewed by Adele.

        Remove no-longer-used PopUpButton.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
        * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
PopUpButtonMac.mm
        * platform/PopUpButton.h: Removed.
        * platform/mac/PopUpButtonMac.mm: Removed.
        * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
        * rendering/DeprecatedRenderSelect.cpp: Change #include of
PopUpButton.h to ListBox.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Suggested by Darin.
harrison [Thu, 28 Sep 2006 21:28:49 +0000 (21:28 +0000)]
    Suggested by Darin.

        Moved an extern declaration from inside a method to the top of the file.

        * DumpRenderTree/EventSendingController.m:
        (-[EventSendingController clearKillRing]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin [Thu, 28 Sep 2006 21:07:39 +0000 (21:07 +0000)]
JavaScriptCore:

        Reviewed by Alice.

        - support for change that should fix <rdar://problem/4733044>
          REGRESSION: XML iBench shows 10% perf. regression (copying
          strings while decoding)

        * wtf/Vector.h: Changed VectorBuffer so that the general case
        contains an instance of the 0 case, since deriving from it
        was violating the Liskov Substitution Principle.
        (WTF::VectorBuffer::releaseBuffer): Added. Releases the buffer so it can
        be adopted by another data structure that uses the FastMalloc.h allocator.
        Returns 0 if the internal buffer was being used.
        (WTF::Vector::releaseBuffer): Added. Releases the buffer as above or creates
        a new one in the case where the internal buffer was being used.

WebCore:

        Reviewed by Alice.

        - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
          10% perf. regression (copying strings while decoding)

        Use Vector<UChar> instead of String when building up the decoded string in
        the ICU and Mac decoders. Using String leads to O(n^2) behavior because
        String grows the buffer every single time that append is called. Using
        Vector::append instead of String::append also avoids constructing a string
        each time just to append and a questionable copy that is done inside the
        String::append function which also contributed to the slowness.

        * platform/PlatformString.h:
        * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
        Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
        allocation.
        * platform/StringImpl.h:
        * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.

        * platform/StreamingTextDecoder.h:
        * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
        Change to use a Vector<UChar> instead of a String, since vectors have better
        resizing performance (they store a separate capacity).

        * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
        * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
        Change to use Vector<UChar> instead of String and then create a string at
        the end of the process using the new adopt function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoExplicitly specify stabs for Debug and Production.
thatcher [Thu, 28 Sep 2006 21:05:56 +0000 (21:05 +0000)]
Explicitly specify stabs for Debug and Production.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
harrison [Thu, 28 Sep 2006 20:25:15 +0000 (20:25 +0000)]
LayoutTests:

        Reviewed by Justin.

        Call clearKillRing() so we are guaranteed to start with empty kill ring.

        * editing/pasteboard/emacs-cntl-y-001.html:

WebKitTools:

        Reviewed by Justin.

        Add clearKillRing so we can test emacs support with empty kill ring.

        * DumpRenderTree/EventSendingController.m:
        (+[EventSendingController isSelectorExcludedFromWebScript:]):
        (+[EventSendingController webScriptNameForSelector:]):
        (-[EventSendingController clearKillRing]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim H.
weinig [Thu, 28 Sep 2006 18:33:45 +0000 (18:33 +0000)]
    Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11057
        Auto-generate more SVG Objective-C bindings

        - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean,
          DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
          DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
          DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
          DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
          DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests,
          and DOMSVGTransformable.

        - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
          parent interfaces and the SVG animated classes.

        - Corrects CodeGenerator.pm to only skip the first parent for the main
          interface.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMSVG.h:
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * ksvg2/svg/SVGAnimatedAngle.idl:
        * ksvg2/svg/SVGAnimatedBoolean.idl:
        * ksvg2/svg/SVGAnimatedEnumeration.idl:
        * ksvg2/svg/SVGAnimatedInteger.idl:
        * ksvg2/svg/SVGAnimatedLength.idl:
        * ksvg2/svg/SVGAnimatedLengthList.idl:
        * ksvg2/svg/SVGAnimatedNumber.idl:
        * ksvg2/svg/SVGAnimatedPathData.idl:
        * ksvg2/svg/SVGAnimatedString.idl:
        * ksvg2/svg/SVGAnimatedTransformList.idl:
        * ksvg2/svg/SVGExternalResourcesRequired.idl:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
        * ksvg2/svg/SVGFitToViewBox.idl:
        * ksvg2/svg/SVGLangSpace.idl:
        * ksvg2/svg/SVGLocatable.idl:
        * ksvg2/svg/SVGMetadataElement.idl:
        * ksvg2/svg/SVGStringList.idl:
        * ksvg2/svg/SVGStylable.idl:
        * ksvg2/svg/SVGStyleElement.idl:
        * ksvg2/svg/SVGTests.idl:
        * ksvg2/svg/SVGTransformable.idl:
        * ksvg2/svg/SVGURIReference.idl:
        * ksvg2/svg/SVGUnitTypes.idl:
        * ksvg2/svg/SVGZoomAndPan.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz Pettel!!!
beidson [Thu, 28 Sep 2006 18:24:01 +0000 (18:24 +0000)]
    Reviewed by Mitz Pettel!!!

        Change the error code check for common functions from SQLResultOk to SQLResultDone

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::forgetPageURLQuery):
        (WebCore::IconDatabase::setIconIDForPageURLQuery):
        (WebCore::IconDatabase::addIconForIconURLQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
mjs [Thu, 28 Sep 2006 09:13:03 +0000 (09:13 +0000)]
    Reviewed by Geoff.

        - change garbage collection to happen at increments proportional to number of live objects, not always
        every 1000 allocations

        * kjs/collector.cpp:
        (KJS::Collector::allocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
mjs [Thu, 28 Sep 2006 09:11:30 +0000 (09:11 +0000)]
    Reviewed by Mitz.

        - fixed REGRESSION (r16606): javascriptCore Crash on website load

        Plus style fixes.

            - fixed some possible off-by-one bugs
            - use indexing, not iterators, for Vectors
            - store Vector by pointer instead of by value to avoid blowing out FunctionImp size

        * kjs/function.cpp:
        (KJS::FunctionImp::addParameter):
        (KJS::FunctionImp::parameterString):
        (KJS::FunctionImp::processParameters):
        (KJS::FunctionImp::lengthGetter):
        (KJS::FunctionImp::getParameterName):
        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoDump the use of MapWindowPoints on Win32 and just let the outermost HWND be the viewp...
hyatt [Thu, 28 Sep 2006 08:49:38 +0000 (08:49 +0000)]
Dump the use of MapWindowPoints on Win32 and just let the outermost HWND be the viewport point of reference for events and such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in...
hyatt [Thu, 28 Sep 2006 06:46:35 +0000 (06:46 +0000)]
    Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
        selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
        scrollbars to provide hover feedback if needed.

        Reviewed by Eric

        * page/FrameView.cpp:
        (WebCore::selectCursor):
        (WebCore::FrameView::handleMouseMoveEvent):
        * platform/ScrollBar.h:
        (WebCore::ScrollBar::mouseMoved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-27 Steve Falkenburg <sfalken@apple.com>
sfalken [Thu, 28 Sep 2006 06:32:47 +0000 (06:32 +0000)]
2006-09-27  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Maciej.

        More build tweaks

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/dstroot-to-sdk.cmd: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-27 MorganL <morganl.webkit@yahoo.com>
aroben [Thu, 28 Sep 2006 04:56:19 +0000 (04:56 +0000)]
2006-09-27  MorganL  <morganl.webkit@yahoo.com>

        Reviewed by Maciej and Adam, landed by Adam

Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=11072
        Windows build is busted

        * platform/win/TemporaryLinkStubs.cpp:
        (ScrollView::paint):
        (ScrollView::themeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * kjs/function.cpp:
sullivan [Thu, 28 Sep 2006 04:35:29 +0000 (04:35 +0000)]
    * kjs/function.cpp:
        (KJS::FunctionImp::getParameterName):
        removed assertion that displeased gcc 4.0.1 (build 5420):
        ASSERT(static_cast<size_t>(index) == index);

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by GGaren.
kmccullo [Thu, 28 Sep 2006 02:00:32 +0000 (02:00 +0000)]
    Reviewed by GGaren.

        Cleanup of previous fix which was to address Radar: 4752492

        * kjs/function.cpp:
        (KJS::FunctionImp::addParameter):
        (KJS::FunctionImp::parameterString):
        (KJS::FunctionImp::processParameters):
        (KJS::FunctionImp::lengthGetter):
        (KJS::FunctionImp::getParameterName):
        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
kmccullo [Thu, 28 Sep 2006 00:58:52 +0000 (00:58 +0000)]
    Reviewed by Adele.

        Fixes a GC stack overflow crash.
        The change is to move from a linked list implementation of Parameters to a Vector.
        The problem with the linked list is that each one creates it's own stack frame when being destroyed and in extreme cases this caused the stack to overflow.

        * kjs/function.cpp:
        (KJS::Parameter::Parameter):
        (KJS::FunctionImp::addParameter):
        (KJS::FunctionImp::parameterString):
        (KJS::FunctionImp::processParameters):
        (KJS::FunctionImp::lengthGetter):
        (KJS::FunctionImp::getParameterName):
        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-27 Steve Falkenburg <sfalken@apple.com>
sfalken [Thu, 28 Sep 2006 00:54:24 +0000 (00:54 +0000)]
2006-09-27  Steve Falkenburg  <sfalken@apple.com>

        Fix last path fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-27 Eric Seidel <eric@eseidel.com>
eseidel [Wed, 27 Sep 2006 23:48:09 +0000 (23:48 +0000)]
2006-09-27  Eric Seidel  <eric@eseidel.com>

        Reviewed by mitz.

        paths with no fill specified default to black but do not recieve paint-related mouse events
        http://bugzilla.opendarwin.org/show_bug.cgi?id=11069
        The default fill was being applied at the wrong place in the rendering chain, causing this problem.

        Test: svg/custom/hover-default-fill.svg

        * kcanvas/RenderPath.cpp:
        (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
        * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (WebCore::KSVGPainterFactory::isFilled): remove null check
        (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
        (WebCore::KSVGPainterFactory::isStroked): remove null check
        (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
        * ksvg2/svg/SVGPaint.cpp:
        (WebCore::SVGPaint::defaultFill): added.
        (WebCore::SVGPaint::defaultStroke): added.
        * ksvg2/svg/SVGPaint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by thatcher
justing [Wed, 27 Sep 2006 22:54:05 +0000 (22:54 +0000)]
    Reviewed by thatcher

        <rdar://problem/4044271>
        Writing Direction menu doesn't reflect the current writing direction (9773)

        * English.lproj/Localizable.strings: Added "Right to Left" and "Left to Right"
        * WebView/WebHTMLView.m:
        (-[NSArray validateUserInterfaceItem:]): Validate menu items that perform
        toggleBaseWritingDirection and changeBaseWritingDirection.
        Disable the menu item that changes the writing direction to NSWritingDirectionNautral
        because NSWritingDirectionNatural's behavior can't be implemented with CSS.
        Take control of the title of the menu item that performs toggleBaseWritingDirection:
        instead of checking/unchecking it, otherwise we wouldn't know what a check means.
        (-[NSArray changeBaseWritingDirection:]): ASSERT that the requested writing
        direction is not NSWritingDirectionNatural, since we've disabled the
        menu item that performs it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-27 Steve Falkenburg <sfalken@apple.com>
sfalken [Wed, 27 Sep 2006 22:00:25 +0000 (22:00 +0000)]
2006-09-27  Steve Falkenburg  <sfalken@apple.com>

        Set path before build.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by eseidel.
rwlbuis [Wed, 27 Sep 2006 20:29:10 +0000 (20:29 +0000)]
    Reviewed by eseidel.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=11015
        SVG handles em units incorrectly

        Calculate viewport coordinates at layout time, since
        at this point the font size is known and lengths depending
        on font sizes can be calculated correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoDebug configs should link to debug runtime.
seangies [Wed, 27 Sep 2006 19:51:21 +0000 (19:51 +0000)]
Debug configs should link to debug runtime.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-27 Eric Seidel <eric@eseidel.com>
eseidel [Wed, 27 Sep 2006 19:29:34 +0000 (19:29 +0000)]
2006-09-27  Eric Seidel  <eric@eseidel.com>

        Reviewed by darin.

        Change our invalid-fill error behavior to match Opera (and soon Firefox)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=11017

        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (WebCore::KSVGPainterFactory::isFilled):
        (WebCore::KSVGPainterFactory::fillPaintServer):
        (WebCore::KSVGPainterFactory::isStroked):
        (WebCore::KSVGPainterFactory::strokePaintServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix
beidson [Wed, 27 Sep 2006 19:07:26 +0000 (19:07 +0000)]
    Build fix

        * loader/icon/IconDatabase.cpp:
        (WebCore::readySQLStatement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
gramps [Wed, 27 Sep 2006 18:46:10 +0000 (18:46 +0000)]
    Reviewed by Adam Roben.

        Changed line ending from DOS to UNIX format so it doesn't die running
        on my machine. ;)

        * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKit:
beidson [Wed, 27 Sep 2006 18:20:08 +0000 (18:20 +0000)]
WebKit:

        Reviewed by Maciej, landed by Brady

        Update URL request associated with provisional data source on redirect.
        Notify IWebFrameLoadDelegate of redirects for the provisional load.
        Notify IWebFrameLoadDelegate of a provisional load being commited.

        * COM/WebDataSource.cpp:
        (WebDataSource::replaceRequest):
        * COM/WebDataSource.h:
        * COM/WebFrame.cpp:
        (WebFrame::receivedRedirect):
        (WebFrame::receivedResponse):
        (WebFrame::receivedData):

WebKitTools:

        Reviewed by Maciej, landed by Brady

        Fix URL bar updating.

        * Spinneret/Spinneret/Spinneret.h:
        (SpinneretWebHost::didStartProvisionalLoadForFrame):
        (SpinneretWebHost::didCommitLoadForFrame):
        (SpinneretWebHost::didFinishLoadForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson [Wed, 27 Sep 2006 17:59:28 +0000 (17:59 +0000)]
WebCore:
        Reviewed by Adam

        In very specific circumstances, prepared SQLStatements can become invalid without
        any warning.  This checks for that state and re-prepares the statement and also
        adds more aggressive error-checking everywhere these statements are used.

        * loader/icon/IconDatabase.cpp:
        (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
        (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
        (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
        (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
        (WebCore::IconDatabase::forgetPageURLQuery): Ditto
        (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
        (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
        (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
        (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
        * loader/icon/SQLStatement.cpp:
        (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
        * loader/icon/SQLStatement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Steve.
darin [Wed, 27 Sep 2006 00:56:36 +0000 (00:56 +0000)]
    Reviewed by Steve.

        - clean up options for font code path

        * platform/Font.h:
        * platform/Font.cpp:
        (WebCore::Font::setCodePath): Added. Replaces boolean version.
        (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.

        * platform/mac/WebCoreTextRenderer.mm:
        (WebCoreSetAlwaysUseATSU): Change to call setCodePath.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sullivan [Tue, 26 Sep 2006 23:44:23 +0000 (23:44 +0000)]
WebCore:

        Reviewed by Darin

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
        Added limit parameter, passed down to Frame

        * page/Frame.h:
        * page/Frame.cpp:
        (WebCore::Frame::markAllMatchesForText):
        Added limit parameter. Stop the search if it hits limit.

WebKit:

        Reviewed by Darin

        * WebView/WebHTMLViewPrivate.h:
        * WebView/WebHTMLView.m:
        (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
        Added limit parameter, passed over the bridge. Stop the search if it hits limit.

        * WebView/WebViewPrivate.h:
        * WebView/WebView.m:
        (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
        Added limit parameter, passed to WebHTMLView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemoved #if's.
seangies [Tue, 26 Sep 2006 23:26:51 +0000 (23:26 +0000)]
Removed #if's.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Tue, 26 Sep 2006 19:56:27 +0000 (19:56 +0000)]
LayoutTests:

        Reviewed by john

        <rdar://problem/4747695>
        Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent

        * editing/deleting/list-item-1-expected.checksum: Added.
        * editing/deleting/list-item-1-expected.png: Added.
        * editing/deleting/list-item-1-expected.txt: Added.
        * editing/deleting/list-item-1.html: Added.
        * editing/execCommand/remove-list-item-1-expected.checksum: Added.
        * editing/execCommand/remove-list-item-1-expected.png: Added.
        * editing/execCommand/remove-list-item-1-expected.txt: Added.
        * editing/execCommand/remove-list-item-1.html: Added.

WebCore:

        Reviewed by john

        <rdar://problem/4747695>
        Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
        to select special elements that are fully selected after expansion
        moves to positions that are visually distinct from the originals.
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply): If the content of the list
        item will be moved into another list, put it in a list item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
harrison [Tue, 26 Sep 2006 19:19:32 +0000 (19:19 +0000)]
LayoutTests:

        Reviewed by John and TimH.

        <rdar://problem/4743256> Seed: Ctrl-Y key binding does nothing when kill ring is empty

        * editing/pasteboard/emacs-cntl-y-001-expected.checksum: Added.
        * editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
        * editing/pasteboard/emacs-cntl-y-001-expected.txt: Added.
        * editing/pasteboard/emacs-cntl-y-001.html: Added.

WebKit:

        Reviewed by John and TimH.

        <rdar://problem/4743256> Seed: Ctrl-Y key binding does nothing when kill ring is empty

        Use deleteBackward: when the killring string is empty. Was always using insertText:,
        but that ends up early-returning if the string to insert is empty.

        * WebView/WebHTMLView.m:
        (-[NSArray yank:]):
        (-[NSArray yankAndSelect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ggaren [Tue, 26 Sep 2006 17:12:45 +0000 (17:12 +0000)]
    Reviewed by Darin.

        Temporary work-around for frame lifetime issue.

        * page/Frame.cpp:
        (WebCore::Frame::clear):
        (WebCore::Frame::disconnectOwnerElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim H.
weinig [Tue, 26 Sep 2006 13:44:54 +0000 (13:44 +0000)]
    Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11038
        Auto-generate DOMSVGElement for the Objective-C bindings

        - Auto-generates DOMSVGElement.

        - Make SVGExceptions work like all the other ExceptionCode
          extensions (Range, XPath, etc.) by adding SVGExceptionOffset
          and SVGExceptionMax.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_binding.cpp:
        (KJS::):
        (KJS::setDOMException):
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMInternal.mm:
        (raiseDOMException):
        * bindings/objc/DOMSVG.h:
        * bindings/objc/DOMSVGExecption.h: Added.
        * ksvg2/ksvg.h:
        * ksvg2/svg/SVGElement.cpp:
        (WebCore::SVGElement::setId):
        (WebCore::SVGElement::setXmlbase):
        * ksvg2/svg/SVGElement.h:
        * ksvg2/svg/SVGElement.idl:
        * ksvg2/svg/SVGException.h: Added.
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-26 Eric Seidel <eric@eseidel.com>
eseidel [Tue, 26 Sep 2006 13:26:33 +0000 (13:26 +0000)]
2006-09-26  Eric Seidel  <eric@eseidel.com>

        Reviewed by anders.

        * projects/svg/status.xml: update status to reflect current state of SVG development

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-26 Eric Seidel <eric@eseidel.com>
eseidel [Tue, 26 Sep 2006 13:08:23 +0000 (13:08 +0000)]
2006-09-26  Eric Seidel  <eric@eseidel.com>

        Reviewed by Tim H.

        viewbox parser does not allow <tab> as a delimiter
        http://bugzilla.opendarwin.org/show_bug.cgi?id=11014

        Test: svg/hixie/viewbox/003.xml

        * ksvg2/svg/svgpathparser.cpp:
        (WebCore::isWhitespace): new function
        (WebCore::skipOptionalSpaces):
        (WebCore::skipOptionalSpacesOrComma):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-26 Eric Seidel <eric@eseidel.com>
eseidel [Tue, 26 Sep 2006 12:56:30 +0000 (12:56 +0000)]
2006-09-26  Eric Seidel  <eric@eseidel.com>

        Reviewed by Tim H.

        SVGDocument::createElement does not create elements in the SVG namespace
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10932

        Test: svg/custom/createelement.svg

        * ksvg2/svg/SVGDocument.cpp:
        (WebCore::SVGDocument::createElement):
        * ksvg2/svg/SVGDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-26 Eric Seidel <eric@eseidel.com>
eseidel [Tue, 26 Sep 2006 12:50:16 +0000 (12:50 +0000)]
2006-09-26  Eric Seidel  <eric@eseidel.com>

        Reviewed by Tim H.

        RenderPath::nodeAtPoint does not respect stroke width
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10829

        Test: svg/custom/stroke-width-click.svg

        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        (WebCore::RenderPath::strokeContains):
        * kcanvas/device/quartz/QuartzSupport.h:
        * kcanvas/device/quartz/QuartzSupport.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemove stray LayoutTests directory.
eseidel [Tue, 26 Sep 2006 12:41:03 +0000 (12:41 +0000)]
Remove stray LayoutTests directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-26 Eric Seidel <eric@eseidel.com>
eseidel [Tue, 26 Sep 2006 12:33:30 +0000 (12:33 +0000)]
2006-09-26  Eric Seidel  <eric@eseidel.com>

        Reviewed by mitz.

        Bring animation back to life
        http://bugzilla.opendarwin.org/show_bug.cgi?id=11021

        Register/unregister SVGSVGElements as time containers on insertion/removal.
        Replace uses of DeprecatedString with String in SVGAnimationElement
        Various whitespace clean-up.

        * ksvg2/misc/KSVGTimeScheduler.cpp:
        (WebCore::SVGTimer::notifyAll):
        * ksvg2/misc/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::startAnimations):
        (WebCore::SVGDocumentExtensions::pauseAnimations):
        (WebCore::SVGDocumentExtensions::unpauseAnimations):
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::handleTimerEvent):
        (WebCore::SVGAnimateTransformElement::parseTransformValue):
        * ksvg2/svg/SVGAnimateTransformElement.h:
        * ksvg2/svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::SVGAnimationElement):
        (WebCore::SVGAnimationElement::parseMappedAttribute):
        (WebCore::SVGAnimationElement::parseClockValue):
        (WebCore::SVGAnimationElement::targetAttribute):
        (WebCore::SVGAnimationElement::setTargetAttribute):
        (WebCore::SVGAnimationElement::attributeName):
        * ksvg2/svg/SVGAnimationElement.h:
        (WebCore::SVGAnimationElement::rendererIsNeeded):
        * ksvg2/svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::getScreenCTM):
        (WebCore::SVGSVGElement::createRenderer):
        (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
        (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
        * ksvg2/svg/SVGSVGElement.h:
        * ksvg2/svg/SVGSetElement.cpp:
        (WebCore::SVGSetElement::handleTimerEvent):
        * ksvg2/svg/SVGURIReference.cpp:
        (WebCore::SVGURIReference::getTarget):
        * ksvg2/svg/SVGURIReference.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-26 Graham Dennis <graham.dennis@gmail.com>
bdash [Tue, 26 Sep 2006 11:27:54 +0000 (11:27 +0000)]
2006-09-26  Graham Dennis  <graham.dennis@gmail.com>

        Reviewed by mitzpettel.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=11020
        No-SVG build broken since r16549

        Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT

        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * page/FrameView.cpp:
        (WebCore::selectCursor):
        * platform/qt/GraphicsContextQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix win32 build bustage with StringImpl's toDouble method.
hyatt [Tue, 26 Sep 2006 11:11:40 +0000 (11:11 +0000)]
Fix win32 build bustage with StringImpl's toDouble method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLand groundwork for handling theme changes.
hyatt [Tue, 26 Sep 2006 08:30:20 +0000 (08:30 +0000)]
Land groundwork for handling theme changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-26 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 26 Sep 2006 07:36:49 +0000 (07:36 +0000)]
2006-09-26  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10820
        Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()

        (Originally written by Eric Seidel).

        * bindings/js/kjs_window.cpp:
        (KJS::floatFeature):
        * ksvg2/svg/SVGAngle.cpp:
        (SVGAngle::setValueAsString):
        * ksvg2/svg/SVGAnimationElement.cpp:
        (SVGAnimationElement::parseMappedAttribute):
        * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
        (SVGComponentTransferFunctionElement::parseMappedAttribute):
        * ksvg2/svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::parseMappedAttribute):
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        (SVGFEDisplacementMapElement::parseMappedAttribute):
        * ksvg2/svg/SVGFELightElement.cpp:
        (SVGFELightElement::parseMappedAttribute):
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        (WebCore::SVGFEOffsetElement::parseMappedAttribute):
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        (SVGFESpecularLightingElement::parseMappedAttribute):
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
        * ksvg2/svg/SVGStopElement.cpp:
        (SVGStopElement::parseMappedAttribute):
        * platform/AtomicString.h:
        (WebCore::AtomicString::toDouble):
        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::toDouble):
        * platform/StringImpl.cpp:
        (WebCore::StringImpl::toDouble):
        * platform/StringImpl.h:
        * rendering/DeprecatedSlider.cpp:
        (WebCore::DeprecatedSlider::updateFromElement):
        * xml/XPathGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Omernick and Tim Hatcher.
harrison [Tue, 26 Sep 2006 01:14:46 +0000 (01:14 +0000)]
    Reviewed by Tim Omernick and Tim Hatcher.

        <rdar://problem/4717965> Text Field text parameterized attributes should work
        <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityAttributeValue:]):
        Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.

        (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
        Cleaned up. Added text field and text area parameterzed attributes.

        (-[WebCoreAXObject doAXLineForTextMarker:]):
        Fixed to be zero-based and to deal with the first position properly.

        (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
        Minor formatting.

        (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
        (-[WebCoreAXObject indexForTextMarker:]):
        (-[WebCoreAXObject textMarkerRangeForRange:]):
        (-[WebCoreAXObject rangeForTextMarkerRange:]):
        New utility methods.

        (-[WebCoreAXObject doAXLineForIndex:]):
        (-[WebCoreAXObject doAXRangeForLine:]):
        (-[WebCoreAXObject doAXStringForRange:]):
        (-[WebCoreAXObject doAXRangeForPosition:]):
        (-[WebCoreAXObject doAXRangeForIndex:]):
        (-[WebCoreAXObject doAXBoundsForRange:]):
        (-[WebCoreAXObject doAXAttributedStringForRange:]):
        (-[WebCoreAXObject doAXRTFForRange:]):
        (-[WebCoreAXObject doAXStyleRangeForIndex:]):
        Implement text field and text area parameterized attributes.

        (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
        Added text field and text area parameterzed attributes.

        * rendering/RenderTextControl.h:
        Made indexForVisiblePosition() and visiblePositionForIndex() public.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
aroben [Tue, 26 Sep 2006 00:57:13 +0000 (00:57 +0000)]
    Reviewed by Brady.

        Build fixes.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
        * platform/ResourceLoader.h: Store whether a particular job
        has received a response within the ResourceLoader object itself, since
        it's possible that we will enter the InternetReadFileExA while loop
        twice for the same job.
        * platform/ResourceLoaderInternal.h: Add private instance variable to
        store whether we've received a response.
        (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
        * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
        directives.
        * platform/win/ResourceLoaderWin.cpp:
        (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
        whether it has received a response instead of assuming it hasn't.
        (WebCore::ResourceLoader::setHasReceivedResponse): Added.
        (WebCore::ResourceLoader::hasReceivedResponse): Added.
        * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
        setProportion
        (ScrollBar::setProportion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Requested by ggaren
beidson [Tue, 26 Sep 2006 00:33:09 +0000 (00:33 +0000)]
    Requested by ggaren

        Disabled IconDatabase logging by default

        * platform/Logging.cpp:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-09-25 Steve Falkenburg <sfalken@apple.com>
sfalken [Mon, 25 Sep 2006 23:43:46 +0000 (23:43 +0000)]
2006-09-25  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Jeff Jenkins.

        Tweak CF types.

        * platform/cf/ResourceLoaderCFNet.cpp:
        (WebCore::willCacheResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Mon, 25 Sep 2006 21:59:43 +0000 (21:59 +0000)]
LayoutTests:

        Reviewed by john

        * editing/execCommand/indent-empty-root-expected.checksum: Added.
        * editing/execCommand/indent-empty-root-expected.png: Added.
        * editing/execCommand/indent-empty-root-expected.txt: Added.
        * editing/execCommand/indent-empty-root.html: Added.

WebCore:

        Reviewed by john

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=11002>
        Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::indentRegion): Special case
        an empty root editable element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16563 268f45cc-cd09-0410-ab3c-d52691b4dbfc