aroben [Thu, 9 Nov 2006 20:51:39 +0000 (20:51 +0000)]
LayoutTests:
Reviewed by Geoff.
New test to keep the mistake I made in r17680 from happening again.
* fast/block/margin-collapse/negative-margins-expected.checksum: Added.
* fast/block/margin-collapse/negative-margins-expected.png: Added.
* fast/block/margin-collapse/negative-margins-expected.txt: Added.
* fast/block/margin-collapse/negative-margins.html: Added.
WebCore:
Reviewed by Geoff.
Fix the change in behavior I caused in r17680 with my build fix.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::maxTopMargin):
(WebCore::RenderObject::maxBottomMargin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 9 Nov 2006 19:48:13 +0000 (19:48 +0000)]
WebCore:
Reviewed by Adam, Oliver.
Move more functions to Editor.
* bridge/EditorClient.h:
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
* bridge/mac/WebCoreFrameBridge.h:
* editing/EditCommand.cpp:
(WebCore::EditCommand::apply):
(WebCore::EditCommand::unapply):
(WebCore::EditCommand::reapply):
* editing/Editor.cpp:
(WebCore::Editor::respondToChangedContents):
(WebCore::dispatchEditableContentChangedEvents):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
* editing/Editor.h:
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::typingAddedToOpenCommand):
* page/Frame.cpp:
* page/Frame.h:
WebKit:
Reviewed by Adam, Oliver.
Update for changes to WebCore. Pass a specific WebFrame to WebEditorClient
instead of just passing the WebView.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::WebEditorClient):
(WebEditorClient::setWebFrame):
(WebEditorClient::isContinuousSpellCheckingEnabled):
(WebEditorClient::spellCheckerDocumentTag):
(WebEditorClient::shouldDeleteRange):
(WebEditorClient::shouldShowDeleteInterface):
(WebEditorClient::shouldApplyStyle):
(WebEditorClient::shouldBeginEditing):
(WebEditorClient::shouldEndEditing):
(WebEditorClient::didBeginEditing):
(WebEditorClient::respondToChangedContents):
(WebEditorClient::didEndEditing):
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
(-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Nov 2006 16:31:08 +0000 (16:31 +0000)]
* rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Thu, 9 Nov 2006 16:17:18 +0000 (16:17 +0000)]
Reviewed by Beth Dakin.
Fixed <rdar://problem/
4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
All existing layout tests pass
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::deleteRow):
check lastSection before deleting row
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Nov 2006 15:41:25 +0000 (15:41 +0000)]
- improved version of last night's build fix (should not do using namespace in a header)
* rendering/RenderObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::maxTopMargin):
(WebCore::RenderObject::maxBottomMargin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 9 Nov 2006 06:49:17 +0000 (06:49 +0000)]
Reviewed by Geoff.
- added ResourceError class and didFailWithError client method
* WebCore.xcodeproj/project.pbxproj:
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::didFailWithError):
(WebCore::IconLoader::didFinishLoading):
* loader/icon/IconLoader.h:
* loader/loader.cpp:
(WebCore::Loader::receivedAllData):
(WebCore::Loader::didFailWithError):
* loader/loader.h:
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::didCancel):
* platform/cf/RetainPtr.h:
(WebCore::):
(WebCore::adoptCFReference):
(WebCore::RetainPtr::RetainPtr):
(WebCore::::adopt):
* platform/network/ResourceError.cpp: Added.
* platform/network/ResourceError.h: Added.
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::domain):
(WebCore::ResourceError::errorCode):
(WebCore::ResourceError::failingURL):
(WebCore::ResourceError::localizedDescription):
(WebCore::ResourceError::unpackPlatformErrorIfNeeded):
* platform/network/ResourceHandle.cpp:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didFailWithError):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::didFail):
(WebCore::ResourceHandle::cancel):
* platform/network/mac/ResourceErrorMac.mm: Added.
(-[NSError WebCore]):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::reportError):
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::didFailWithError):
(WebCore::XMLHttpRequest::didFinishLoading):
* xml/xmlhttprequest.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 9 Nov 2006 06:39:26 +0000 (06:39 +0000)]
2006-11-08 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Maciej.
Linux\Gdk fixes.
* platform/gdk/ChromeClientGdk.h:
(WebCore::ChromeClientGdk::~ChromeClientGdk):
* platform/gdk/CursorGdk.cpp:
(WebCore::Cursor::Cursor):
(WebCore::moveCursor):
* platform/gdk/FrameGdk.cpp:
(WebCore::FrameGdk::FrameGdk):
(WebCore::FrameGdk::submitForm):
(WebCore::FrameGdk::urlSelected):
* platform/gdk/PageGdk.cpp:
* platform/gdk/ScreenClientGdk.h: Added.
(WebCore::ScreenClientGdk::~ScreenClientGdk):
* platform/gdk/ScreenGdk.cpp:
(WebCore::ScreenClientGdk::depth):
(WebCore::ScreenClientGdk::depthPerComponent):
(WebCore::ScreenClientGdk::isMonochrome):
(WebCore::ScreenClientGdk::rect):
(WebCore::ScreenClientGdk::usableRect):
* platform/gdk/TemporaryLinkStubs.cpp:
(FrameGdk::historyURL):
(ChromeClientGdk::windowRect):
(ChromeClientGdk::setWindowRect):
(ChromeClientGdk::pageRect):
(ChromeClientGdk::scaleFactor):
(ChromeClientGdk::focus):
(ChromeClientGdk::unfocus):
(ChromeClientGdk::createWindow):
(ChromeClientGdk::createModalDialog):
(ChromeClientGdk::show):
(ChromeClientGdk::canRunModal):
(ChromeClientGdk::runModal):
(ChromeClientGdk::setToolbarsVisible):
(ChromeClientGdk::toolbarsVisible):
(ChromeClientGdk::setStatusbarVisible):
(ChromeClientGdk::statusbarVisible):
(ChromeClientGdk::setScrollbarsVisible):
(ChromeClientGdk::scrollbarsVisible):
(ChromeClientGdk::setMenubarVisible):
(ChromeClientGdk::menubarVisible):
(ChromeClientGdk::setResizable):
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::client):
* platform/network/gdk/ResourceHandleManager.cpp:
(WebCore::writeCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::remove):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 9 Nov 2006 05:58:27 +0000 (05:58 +0000)]
Build fix.
* rendering/RenderObject.h:
(WebCore::RenderObject::maxTopMargin):
(WebCore::RenderObject::maxBottomMargin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 9 Nov 2006 05:18:01 +0000 (05:18 +0000)]
Reviewed by Anders Carlsson.
Made Screen a good platform citizen by removing its reference to Page. This
made a class unnecessary, so all screen fuctions are stand-alone now.
* bindings/js/kjs_window.cpp: Removed unnecessary subtractions
when computing the screen's available dimensions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 9 Nov 2006 03:55:58 +0000 (03:55 +0000)]
Reviewed by Mitz.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
Cleanup RenderObject
* rendering/RenderObject.cpp:
(WebCore::RenderObject::operator delete):
(WebCore::RenderObject::createObject):
(WebCore::RenderObjectCounter::~RenderObjectCounter):
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::isDescendantOf):
(WebCore::RenderObject::isRoot):
(WebCore::RenderObject::addChild):
(WebCore::RenderObject::removeChildNode):
(WebCore::RenderObject::removeChild):
(WebCore::RenderObject::appendChildNode):
(WebCore::RenderObject::insertChildNode):
(WebCore::RenderObject::nextInPreOrder):
(WebCore::RenderObject::nextInPreOrderAfterChildren):
(WebCore::RenderObject::previousInPreOrder):
(WebCore::RenderObject::isEditable):
(WebCore::RenderObject::nextEditable):
(WebCore::RenderObject::previousEditable):
(WebCore::RenderObject::firstLeafChild):
(WebCore::RenderObject::lastLeafChild):
(WebCore::RenderObject::addLayers):
(WebCore::RenderObject::removeLayers):
(WebCore::RenderObject::moveLayers):
(WebCore::RenderObject::findNextLayer):
(WebCore::RenderObject::enclosingLayer):
(WebCore::RenderObject::updateFirstLetter):
(WebCore::RenderObject::offsetParent):
(WebCore::RenderObject::scroll):
(WebCore::RenderObject::hasStaticX):
(WebCore::RenderObject::setNeedsLayout):
(WebCore::RenderObject::setChildNeedsLayout):
(WebCore::RenderObject::markContainingBlocksForLayout):
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::containingBlockWidth):
(WebCore::RenderObject::containingBlockHeight):
(WebCore::RenderObject::mustRepaintBackgroundOrBorder):
(WebCore::RenderObject::drawBorderArc):
(WebCore::RenderObject::drawBorder):
(WebCore::RenderObject::paintBorderImage):
(WebCore::RenderObject::paintBorder):
(WebCore::RenderObject::absoluteRects):
(WebCore::RenderObject::addPDFURLRect):
(WebCore::RenderObject::addFocusRingRects):
(WebCore::RenderObject::paintOutline):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::repaintObjectsBeforeLayout):
(WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
(WebCore::RenderObject::information):
(WebCore::RenderObject::dump):
(WebCore::selectStartNode):
(WebCore::RenderObject::shouldSelect):
(WebCore::RenderObject::draggableNode):
(WebCore::RenderObject::createAnonymousBlock):
(WebCore::RenderObject::handleDynamicFloatPositionChange):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::setStyleInternal):
(WebCore::RenderObject::updateBackgroundImages):
(WebCore::RenderObject::absolutePosition):
(WebCore::RenderObject::caretRect):
(WebCore::RenderObject::paddingTop):
(WebCore::RenderObject::paddingBottom):
(WebCore::RenderObject::paddingLeft):
(WebCore::RenderObject::paddingRight):
(WebCore::RenderObject::tabWidth):
(WebCore::RenderObject::container):
(WebCore::RenderObject::removeFromObjectLists):
(WebCore::RenderObject::destroy):
(WebCore::RenderObject::arenaDelete):
(WebCore::RenderObject::hitTest):
(WebCore::RenderObject::setInnerNode):
(WebCore::RenderObject::nodeAtPoint):
(WebCore::RenderObject::verticalPositionHint):
(WebCore::RenderObject::getVerticalPosition):
(WebCore::RenderObject::lineHeight):
(WebCore::RenderObject::invalidateVerticalPositions):
(WebCore::RenderObject::recalcMinMaxWidths):
(WebCore::RenderObject::scheduleRelayout):
(WebCore::RenderObject::setInlineBoxWrapper):
(WebCore::RenderObject::firstLineStyle):
(WebCore::RenderObject::getPseudoStyle):
(WebCore::RenderObject::getTextDecorationColors):
(WebCore::RenderObject::addDashboardRegions):
(WebCore::RenderObject::collectDashboardRegions):
(WebCore::RenderObject::avoidsFloats):
(WebCore::RenderObject::findCounter):
(WebCore::RenderObject::backslashAsCurrencySymbol):
(WebCore::RenderObject::imageChanged):
(WebCore::RenderObject::previousOffset):
(WebCore::RenderObject::nextOffset):
(WebCore::RenderObject::inlineBox):
* rendering/RenderObject.h:
(WebCore::):
(WebCore::RenderObject::renderName):
(WebCore::RenderObject::parent):
(WebCore::RenderObject::previousSibling):
(WebCore::RenderObject::nextSibling):
(WebCore::RenderObject::firstChild):
(WebCore::RenderObject::lastChild):
(WebCore::RenderObject::getOverflowClipRect):
(WebCore::RenderObject::getClipRect):
(WebCore::RenderObject::getBaselineOfFirstLineBox):
(WebCore::RenderObject::setEdited):
(WebCore::RenderObject::setStaticX):
(WebCore::RenderObject::setStaticY):
(WebCore::RenderObject::setPreviousSibling):
(WebCore::RenderObject::setNextSibling):
(WebCore::RenderObject::setParent):
(WebCore::RenderObject::isInlineBlockOrInlineTable):
(WebCore::RenderObject::isRenderView):
(WebCore::RenderObject::childrenInline):
(WebCore::RenderObject::setChildrenInline):
(WebCore::RenderObject::isAnonymousBlock):
(WebCore::RenderObject::isDragging):
(WebCore::RenderObject::needsLayout):
(WebCore::RenderObject::setMinMaxKnown):
(WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc):
(WebCore::RenderObject::setPositioned):
(WebCore::RenderObject::setRelPositioned):
(WebCore::RenderObject::setFloating):
(WebCore::RenderObject::setInline):
(WebCore::RenderObject::setShouldPaintBackgroundOrBorder):
(WebCore::RenderObject::setReplaced):
(WebCore::RenderObject::PaintInfo::PaintInfo):
(WebCore::RenderObject::paintBackgroundExtended):
(WebCore::RenderObject::calcWidth):
(WebCore::RenderObject::updateFromElement):
(WebCore::RenderObject::RepaintInfo::RepaintInfo):
(WebCore::RenderObject::setOverrideSize):
(WebCore::RenderObject::setPos):
(WebCore::RenderObject::setWidth):
(WebCore::RenderObject::setHeight):
(WebCore::RenderObject::absolutePositionForContent):
(WebCore::RenderObject::overflowHeight):
(WebCore::RenderObject::overflowWidth):
(WebCore::RenderObject::setOverflowHeight):
(WebCore::RenderObject::setOverflowWidth):
(WebCore::RenderObject::overflowLeft):
(WebCore::RenderObject::overflowTop):
(WebCore::RenderObject::overflowRect):
(WebCore::RenderObject::stopAutoscroll):
(WebCore::RenderObject::collapsedMarginTop):
(WebCore::RenderObject::collapsedMarginBottom):
(WebCore::RenderObject::maxTopMargin):
(WebCore::RenderObject::maxBottomMargin):
(WebCore::RenderObject::):
(WebCore::RenderObject::setTable):
(WebCore::RenderObject::isFloatingOrPositioned):
(WebCore::RenderObject::containsFloat):
(WebCore::RenderObject::setSelectionState):
(WebCore::RenderObject::SelectionInfo::SelectionInfo):
(WebCore::RenderObject::lowestPosition):
(WebCore::RenderObject::rightmostPosition):
(WebCore::RenderObject::leftmostPosition):
(WebCore::RenderObject::calcVerticalMargins):
(WebCore::RenderObject::font):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Nov 2006 02:00:10 +0000 (02:00 +0000)]
LayoutTests:
Reviewed by Anders.
- added test for option-tab
* fast/events/option-tab.html: Added.
* fast/events/option-tab-expected.txt: Added.
WebCore:
Reviewed by Anders.
- added event parameters to focus-related functions so we can
implement the "option-tab to all links" behavior without relying
on a global "current event" -- also makes it work with DOM events
* page/Frame.h: Removed unneeded includes. Moved some functions
that were misplaced into the appropriate sections.
* page/Frame.cpp:
(WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from
PlatformKeyboardEvent to the DOM keyboard event class.
(WebCore::Frame::tabsToLinks): Added event parameter.
(WebCore::Frame::tabsToAllControls): Ditto.
(WebCore::scanForForm): Fixed code that incorrectly assumes
that an iframe is an HTMLFrameElement (no longer true since Geoff
changed the class hierarchy a bit).
(WebCore::Frame::hitTestResultAtPoint): Ditto.
* bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions
that were misplaced into the appropriate sections.
* bridge/mac/FrameMac.mm:
(WebCore::selectorForKeyEvent): Changed to use a DOM event instead of
a PlatformKeyboardEvent.
(WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent()
and pass event into next/previousFocusNode.
(WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from
the AppKit current event, if it's a keyboard event. Really just a hack that's
needed to preserve some code we can remove once we deal with the last NSView-
based form control.
(WebCore::isKeyboardOptionTab): Added.
(WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the
option (alt) key is down.
(WebCore::FrameMac::tabsToAllControls): Ditto.
(WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just
call resetMultipleFormSubmissionProtection() explicitly instead.
(WebCore::FrameMac::mouseDown): Ditto.
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly
assumes that an iframe is an HTMLFrameElement (no longer true since Geoff
changed the class hierarchy a bit).
(-[WebCoreAXObject accessibilityPerformAction:]): Changed call to
prepareForUserAction() to call resetMultipleFormSubmissionProtection()
explicitly instead.
* page/FrameView.h:
* page/FrameView.cpp:
(WebCore::FrameView::advanceFocus): Changed function to take an
event parameter, and decide the direction based on the shift key
modifier instead of a passed-in boolean.
* dom/Document.h:
* dom/Document.cpp:
(WebCore::Document::nextFocusNode): Added event parameter.
(WebCore::Document::previousFocusNode): Ditto.
* dom/Node.h:
* dom/Node.cpp:
(WebCore::Node::isKeyboardFocusable): Ditto.
* html/HTMLAnchorElement.h:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
* html/HTMLGenericFormElement.h:
* html/HTMLGenericFormElement.cpp:
(WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
* html/HTMLInputElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
(WebCore::HTMLInputElement::defaultEventHandler): Ditto.
* html/HTMLSelectElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
* html/HTMLTextAreaElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
* dom/EventTargetNode.cpp:
(WebCore::EventTargetNode::defaultEventHandler): Pass event to the
advanceFocus function.
* platform/TextField.h:
* platform/mac/TextFieldMac.mm: Removed the non-search field code.
* platform/mac/WebCoreTextField.h:
* platform/mac/WebCoreTextField.mm: Removed the non-search field code.
(-[WebCoreTextFieldController controlTextDidChange:]): Removed the
call to FrameMac::handleKeyboardOptionTabInView, which is no longer
needed since the default handler in HTMLInputElement takes care of
option-tab.
* platform/mac/SliderMac.mm:
(-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent()
and pass event into tabsToAllControls.
(Slider::focusPolicy): Ditto.
* rendering/RenderLineEdit.cpp:
(WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code.
(WebCore::RenderLineEdit::updateFromElement): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17674
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Nov 2006 01:33:55 +0000 (01:33 +0000)]
Reviewed by Anders.
- same change as below, only tested this time
* DumpRenderTree/DumpRenderTree.m: (main): Explicitly turn "tab to links"
mode off. I think we need to do this because WebPreferences saves things
for us automatically. It would be good to turn that off for DumpRenderTree,
but for now lets handle this like the other preferences (set it explicitly
each time).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17673
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Nov 2006 01:21:14 +0000 (01:21 +0000)]
Reviewed by Anders.
* DumpRenderTree/DumpRenderTree.m: (main): Get rid of code to turn on
"tab to links" mode. No current tests depend on this, and there's a new
test I want to land that depends on the default setting.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17672
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Thu, 9 Nov 2006 01:16:10 +0000 (01:16 +0000)]
Reviewed by Dave Harrison, Oliver, and Darin
(oh my! where was superkevin on this one?)
<rdar://problem/
4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)
More "free nil checking" we lost in the transition from ObjC to C++
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17671
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 9 Nov 2006 00:51:35 +0000 (00:51 +0000)]
WebCore:
Reviewed by Adam.
Move more code into editor.
* WebCore.exp:
* bridge/EditorClient.h:
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
* bridge/mac/WebCoreFrameBridge.h:
* dom/Document.cpp:
(WebCore::Document::relinquishesEditingFocus):
(WebCore::Document::acceptsEditingFocus):
(WebCore::Document::didBeginEditing):
(WebCore::Document::didEndEditing):
* editing/Editor.cpp:
(WebCore::Editor::indent):
(WebCore::Editor::outdent):
* editing/Editor.h:
* page/Frame.cpp:
* page/Frame.h:
WebKit:
Reviewed by Adam.
Move more code into editor.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldBeginEditing):
(WebEditorClient::shouldEndEditing):
(WebEditorClient::didBeginEditing):
(WebEditorClient::didEndEditing):
* WebCoreSupport/WebFrameBridge.mm:
* WebView/WebHTMLView.m:
(-[NSArray indent:]):
(-[NSArray outdent:]):
* WebView/WebView.mm:
* WebView/WebViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 8 Nov 2006 22:58:31 +0000 (22:58 +0000)]
WebCore:
Reviewed by Adam.
Add ability to HitTestResult to ask if the inner non-shared node is
content editable.
* WebCore.exp: Export HitTestResult::isContentEditable()
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isContentEditable):
* rendering/HitTestResult.h:
WebKit:
Reviewed by Adam.
Add WebElementIsContentEditableKey to the WebElementDictionary, and
use it!
* DefaultDelegates/WebDefaultContextMenuDelegate.m:
(-[WebDefaultUIDelegate
webView:contextMenuItemsForElement:defaultMenuItems:]): Use new
WebElementIsContentEditableKey.
* Misc/WebElementDictionary.m:
(+[WebElementDictionary initializeLookupTable]):
(-[WebElementDictionary _isContentEditable]): Call into
HitTestResult::isContentEditable()
* WebView/WebView.mm: Add new key.
* WebView/WebViewPrivate.h: Add new key.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 8 Nov 2006 22:50:00 +0000 (22:50 +0000)]
Build fix.
* WebCore.xcodeproj/project.pbxproj:
Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 8 Nov 2006 22:24:26 +0000 (22:24 +0000)]
Reviewed by Darin.
<rdar://problem/
4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
<rdar://problem/
4804317> Would like SPI to get bounding box for a DOM range without having to change the selection
Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.
* bindings/objc/DOM.mm:
(WebCore::kit):
(-[DOMNode lineBoxRects]):
(-[DOMRange boundingBox]):
(-[DOMRange lineBoxRects]):
* bindings/objc/DOMPrivate.h:
* dom/Range.cpp:
(WebCore::Range::boundingBox):
(WebCore::Range::addLineBoxRects):
* dom/Range.h:
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::addLineBoxRects):
* rendering/RenderContainer.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addLineBoxRects):
* rendering/RenderObject.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::addLineBoxRects):
* rendering/RenderText.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17667
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 8 Nov 2006 21:57:47 +0000 (21:57 +0000)]
WebCore:
Reviewed by Oliver.
Move methods from the bridge and frame into editor.
* WebCore.exp:
* bridge/EditorClient.h:
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
* editing/Editor.cpp:
(WebCore::Editor::removeFormattingAndStyle):
(WebCore::Editor::applyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::applyStyleToSelection):
(WebCore::Editor::applyParagraphStyleToSelection):
(WebCore::Editor::toggleBold):
(WebCore::Editor::toggleItalic):
(WebCore::Editor::selectionStartHasStyle):
* editing/Editor.h:
* editing/JSEditor.cpp:
* page/Frame.cpp:
* page/Frame.h:
WebKit:
Reviewed by Oliver.
Call into the WebCore editor object directly.
* MigrateHeaders.make:
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldDeleteRange):
(WebEditorClient::shouldShowDeleteInterface):
(WebEditorClient::shouldApplyStyle):
* WebView/WebFrame.mm:
(core):
(kit):
* WebView/WebFrameInternal.h:
* WebView/WebHTMLView.m:
(-[NSArray _applyStyleToSelection:withUndoAction:]):
(-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
(-[NSArray _toggleBold]):
(-[NSArray _toggleItalic]):
(-[NSArray _changeCSSColorUsingSelector:inRange:]):
(-[NSArray underline:]):
(-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
* WebView/WebView.mm:
(-[WebView applyStyle:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17666
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 8 Nov 2006 21:30:12 +0000 (21:30 +0000)]
Reviewed by Oliver.
<rdar://problem/
4825370>
REGRESSION: Selecting "Look Up In Dictionary" from contextual menu fails to open the Dictionary app
* WebView/WebHTMLView.m:
(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
Initialize the framework pointer to 0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17665
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan [Wed, 8 Nov 2006 21:20:26 +0000 (21:20 +0000)]
2006-11-08 Ada Chan <adachan@apple.com>
Reviewed by darin.
Added a method to delete all the keys in a HashMap.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17664
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 8 Nov 2006 20:14:14 +0000 (20:14 +0000)]
Reviewed by Beth.
Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
be able to dispatch user events even when off-screen, so we have to support
off-screen windows when handling mouse events.
* platform/Screen.h:
* platform/mac/PlatformMouseEventMac.mm:
(WebCore::globalPoint): Grab the best screen instead of the screen you're
on, since you might be off-screen.
* platform/mac/ScreenMac.mm:
(WebCore::screenForWindow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17663
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 8 Nov 2006 17:32:23 +0000 (17:32 +0000)]
- fix bug caused by last-minute change to my check-in last night
that is causing layout tests to hang
* dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
* loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn
a null string into an empty string before calling completeURL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17662
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 8 Nov 2006 10:02:03 +0000 (10:02 +0000)]
LayoutTests:
Reviewed by Maciej
Added test to cover bug http://bugs.webkit.org/show_bug.cgi?id=11450
-Confirm there is no assert when nuking a frame with an active XMLHttpRequest load
-Confirm the correct state-change notifications for the request are dispatched
* http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt: Added.
* http/tests/xmlhttprequest/frame-load-cancelled-abort.html: Added.
* http/tests/xmlhttprequest/resources/endlessxml.php: Added.
* http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Added.
WebCore:
Reviewed by Maciej
If the request has already been aborted, bail out of didFinishLoading()
immediately. This prevents state change notifications that aren't
needed.
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::didFinishLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 8 Nov 2006 09:51:30 +0000 (09:51 +0000)]
- another attempt to fix Qt build
* loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 8 Nov 2006 09:48:44 +0000 (09:48 +0000)]
Reviewed by Geoff.
- stray bits of my FrameLoader patch that I left out by accident
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer()
inside the FrameLoader class.
(WebCore::FrameLoader::requestFrame): Use less DeprecatedString.
(WebCore::FrameLoader::clear): Stop the redirection timer.
(WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the
entire function in an if statement. Use less DeprecatedString.
(WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator.
(WebCore::FrameLoader::scheduleRefresh): Ditto.
(WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer()
inside the FrameLoader class.
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::load): Ditto.
(WebCore::FrameLoader::loadResourceSynchronously): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 8 Nov 2006 09:45:40 +0000 (09:45 +0000)]
Reviewed by Geoff.
* fast/forms/submit-nil-value-field-assert.html: Update test so it
no longer relies on incorrect "submit form right away during JavaScript
execution" behavior.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 8 Nov 2006 08:19:19 +0000 (08:19 +0000)]
Reviewed by Geoff.
This test needs new results from my last check-in. I thought this
change was already in my tree, but I guess not. Whoops!
* fast/dom/delete-contents-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 8 Nov 2006 07:48:12 +0000 (07:48 +0000)]
WebCore:
Reviewed by Hyatt.
Another go at fix for <rdar://problem/
4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com
The fix from yesterday caused a layout test regression which
exposed an existing bug. The existing bug was that we allowed text
nodes to stay in the head tag, but other browsers move them to the
body. The previous fix also caused a performance regression, which
was seemingly easy to fix by moving the new clause in
HTMLParser::handleError() to be below the HTMLElement case.
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to
be the child of the document.
* html/HTMLHeadElement.cpp:
(WebCore::HTMLHeadElement::childAllowed): Do not allow non-
whitespace text nodes to be children of the head.
* html/HTMLHeadElement.h:
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleError): Error case for comment nodes.
* page/FrameView.cpp:
(WebCore::FrameView::handleMousePressEvent): Safety-net null check
for the original crash.
Layout Tests:
Reviewed by Hyatt.
Test cases for <rdar://problem/
4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com
And for the found-bug of moving text nodes within the head to the
body.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 8 Nov 2006 07:24:38 +0000 (07:24 +0000)]
- another attempt to fix Qt build
* loader/icon/IconLoader.h: Added missing include.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 8 Nov 2006 07:04:27 +0000 (07:04 +0000)]
WebCore:
Reviewed by Tim Hatcher.
Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.
Moved Screen back from page/ to platform/ because it's a platform
abstraction again.
Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
since the two were always used together.
Changed pixel depth queries to query the deepest screen. Darin mentioned
that it might have been a feature, not a bug, to use the main/menubar screen
regardless of the screen you were on. For scaling and flipping that's not
the case, but for querying pixel depth I think it is. You want to know
about the highest pixel depth your content may display on.
Tests still pass.
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* page/Page.cpp:
(WebCore::Page::Page):
* page/Page.h:
* page/Screen.cpp: Removed.
* page/Screen.h: Removed.
* page/ScreenClient.h: Removed.
* platform/mac/PlatformMouseEventMac.mm:
(WebCore::globalPoint):
* platform/mac/ScreenMac.mm:
(WebCore::window):
(WebCore::bestScreen):
(WebCore::Screen::depth):
(WebCore::Screen::depthPerComponent):
(WebCore::Screen::isMonochrome):
(WebCore::Screen::rect):
(WebCore::Screen::usableRect):
(WebCore::toUserSpace):
(WebCore::toDeviceSpace):
WebKit:
Reviewed by Geoff.
- udpated for changes to move from Frame/FrameMac to FrameLoader
* DefaultDelegates/WebDefaultContextMenuDelegate.m:
(-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
* Misc/WebNSAttributedStringExtras.m:
(+[NSAttributedString _web_attributedStringFromRange:]):
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView requestWithURLCString:]):
* Plugins/WebNetscapePluginEmbeddedView.m:
(-[WebNetscapePluginEmbeddedView didStart]):
* Plugins/WebNetscapePluginStream.mm:
* Plugins/WebPluginController.mm:
(-[WebPluginController pluginView:receivedResponse:]):
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::provisionalLoadStarted):
* WebView/WebFrame.mm:
(-[WebFrame _canCachePage]):
(+[WebFrame _timeOfLastCompletedLoad]):
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _reloadForPluginChanges]):
(-[WebFrame stopLoading]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 8 Nov 2006 05:58:56 +0000 (05:58 +0000)]
- try to fix Qt build
* CMakeLists.txt: Updated for some file changes.
* WebCoreSources.bkl: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 8 Nov 2006 05:52:27 +0000 (05:52 +0000)]
WebCore:
Reviewed by Geoff.
- moved loader code from Frame/FrameMac to FrameLoader
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSXSLTProcessor.h:
* bindings/js/kjs_events.cpp:
(KJS::JSLazyEventListener::parseCode):
* bindings/js/kjs_html.cpp:
(KJS::JSHTMLDocument::putValueProperty):
* bindings/js/kjs_navigator.cpp:
(KJS::Navigator::getValueProperty):
* bindings/js/kjs_proxy.cpp:
(WebCore::KJSProxy::initScriptIfNeeded):
* bindings/js/kjs_window.cpp:
(KJS::Screen::Screen):
(KJS::createNewWindow):
(KJS::Window::getValueProperty):
(KJS::Window::put):
(KJS::Window::isSafeScript):
(KJS::WindowFunc::callAsFunction):
(KJS::ScheduledAction::execute):
(KJS::Location::getValueProperty):
(KJS::Location::put):
(KJS::Location::toString):
(KJS::LocationFunc::callAsFunction):
(KJS::History::getValueProperty):
(KJS::HistoryFunc::callAsFunction):
* bindings/objc/DOM.mm:
(+[DOMNode _nodeWith:WebCore::]):
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::~FrameMac):
(WebCore::FrameMac::setView):
(WebCore::FrameMac::setStatusBarText):
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge close]):
(-[WebCoreFrameBridge addData:]):
(-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
(-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
(-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
(-[WebCoreFrameBridge baseURL]):
(-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
(-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
(-[WebCoreFrameBridge canProvideDocumentSource]):
(-[WebCoreFrameBridge receivedData:textEncodingName:]):
* css/cssparser.cpp:
(WebCore::CSSParser::parseContent):
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):
* dom/DOMImplementation.h:
* dom/Document.cpp:
(WebCore::Document::readyState):
(WebCore::Document::updateTitle):
(WebCore::Document::open):
(WebCore::Document::close):
(WebCore::Document::implicitClose):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::referrer):
(WebCore::Document::finishedParsing):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::endElementNs):
(WebCore::ignorableWhitespaceHandler):
(WebCore::XMLTokenizer::notifyFinished):
* editing/TextIterator.cpp:
(WebCore::TextIterator::rangeFromLocationAndLength):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::defaultEventHandler):
* html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::process):
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::lastModified):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formData):
(WebCore::HTMLFormElement::submit):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAllowed):
(WebCore::HTMLFrameElementBase::openURL):
(WebCore::HTMLFrameElementBase::willRemove):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValueFromRenderer):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleError):
(WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
* html/HTMLPreElement.idl:
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseMappedAttribute):
(WebCore::HTMLScriptElement::insertedIntoDocument):
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::scriptExecution):
(WebCore::HTMLTokenizer::parseTag):
(WebCore::HTMLTokenizer::write):
(WebCore::HTMLTokenizer::stopParsing):
(WebCore::HTMLTokenizer::timerFired):
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(WebCore::KCanvasFilterQuartz::prepareFilter):
* ksvg2/svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
* ksvg2/svg/SVGElement.cpp:
(WebCore::SVGElement::sendSVGLoadEventIfPossible):
* loader/DocLoader.cpp:
(WebCore::DocLoader::setLoadInProgress):
* loader/FrameLoader.cpp:
(WebCore::FormSubmission::FormSubmission):
(WebCore::ScheduledRedirection::):
(WebCore::ScheduledRedirection::ScheduledRedirection):
(WebCore::cancelAll):
(WebCore::getString):
(WebCore::isBackForwardLoadType):
(WebCore::numRequests):
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::~FrameLoader):
(WebCore::FrameLoader::createWindow):
(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::requestFrame):
(WebCore::FrameLoader::loadSubframe):
(WebCore::FrameLoader::submitFormAgain):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::stop):
(WebCore::FrameLoader::closeURL):
(WebCore::FrameLoader::cancelRedirection):
(WebCore::FrameLoader::iconURL):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::didExplicitOpen):
(WebCore::FrameLoader::replaceContentsWithScriptResult):
(WebCore::FrameLoader::executeScript):
(WebCore::FrameLoader::cancelAndClear):
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::responseMIMEType):
(WebCore::FrameLoader::setResponseMIMEType):
(WebCore::FrameLoader::begin):
(WebCore::FrameLoader::write):
(WebCore::FrameLoader::end):
(WebCore::FrameLoader::endIfNotLoading):
(WebCore::FrameLoader::startIconLoader):
(WebCore::FrameLoader::commitIconURLToIconDatabase):
(WebCore::FrameLoader::gotoAnchor):
(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::loadDone):
(WebCore::FrameLoader::checkCompleted):
(WebCore::FrameLoader::checkEmitLoadEvent):
(WebCore::FrameLoader::baseURL):
(WebCore::FrameLoader::baseTarget):
(WebCore::FrameLoader::completeURL):
(WebCore::FrameLoader::scheduleRedirection):
(WebCore::FrameLoader::scheduleLocationChange):
(WebCore::FrameLoader::scheduleRefresh):
(WebCore::FrameLoader::isScheduledLocationChangePending):
(WebCore::FrameLoader::scheduleHistoryNavigation):
(WebCore::FrameLoader::redirectionTimerFired):
(WebCore::FrameLoader::encoding):
(WebCore::FrameLoader::requestObject):
(WebCore::FrameLoader::shouldUsePlugin):
(WebCore::FrameLoader::loadPlugin):
(WebCore::FrameLoader::clearRecordedFormValues):
(WebCore::FrameLoader::recordFormValue):
(WebCore::FrameLoader::parentCompleted):
(WebCore::FrameLoader::outgoingReferrer):
(WebCore::FrameLoader::lastModified):
(WebCore::FrameLoader::opener):
(WebCore::FrameLoader::setOpener):
(WebCore::FrameLoader::openedByJavaScript):
(WebCore::FrameLoader::setOpenedByJavaScript):
(WebCore::FrameLoader::handleFallbackContent):
(WebCore::FrameLoader::provisionalLoadStarted):
(WebCore::FrameLoader::userGestureHint):
(WebCore::FrameLoader::didNotOpenURL):
(WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
(WebCore::FrameLoader::setEncoding):
(WebCore::FrameLoader::addData):
(WebCore::FrameLoader::canCachePage):
(WebCore::FrameLoader::updatePolicyBaseURL):
(WebCore::FrameLoader::setPolicyBaseURL):
(WebCore::FrameLoader::scrollToAnchor):
(WebCore::FrameLoader::isComplete):
(WebCore::FrameLoader::isLoadingMainResource):
(WebCore::FrameLoader::url):
(WebCore::FrameLoader::startRedirectionTimer):
(WebCore::FrameLoader::stopRedirectionTimer):
(WebCore::FrameLoader::updateBaseURLForEmptyDocument):
(WebCore::FrameLoader::completed):
(WebCore::FrameLoader::started):
(WebCore::FrameLoader::containsPlugins):
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::setupForReplace):
(WebCore::FrameLoader::setupForReplaceByMIMEType):
(WebCore::FrameLoader::finalSetupForReplace):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::canTarget):
(WebCore::FrameLoader::stopLoadingPlugIns):
(WebCore::FrameLoader::stopLoadingSubresources):
(WebCore::FrameLoader::stopLoadingSubframes):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::cancelMainResourceLoad):
(WebCore::FrameLoader::cancelPendingArchiveLoad):
(WebCore::FrameLoader::activeDocumentLoader):
(WebCore::FrameLoader::addPlugInStreamLoader):
(WebCore::FrameLoader::removePlugInStreamLoader):
(WebCore::FrameLoader::hasMainResourceLoader):
(WebCore::FrameLoader::isLoadingSubresources):
(WebCore::FrameLoader::isLoadingPlugIns):
(WebCore::FrameLoader::isLoading):
(WebCore::FrameLoader::addSubresourceLoader):
(WebCore::FrameLoader::removeSubresourceLoader):
(WebCore::FrameLoader::releaseMainResourceLoader):
(WebCore::FrameLoader::setDocumentLoader):
(WebCore::FrameLoader::documentLoader):
(WebCore::FrameLoader::setPolicyDocumentLoader):
(WebCore::FrameLoader::provisionalDocumentLoader):
(WebCore::FrameLoader::setProvisionalDocumentLoader):
(WebCore::FrameLoader::state):
(WebCore::FrameLoader::timeOfLastCompletedLoad):
(WebCore::FrameLoader::setState):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::markLoadComplete):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::privateBrowsingEnabled):
(WebCore::FrameLoader::clientRedirectCancelledOrFinished):
(WebCore::FrameLoader::clientRedirected):
(WebCore::FrameLoader::shouldReload):
(WebCore::FrameLoader::closeOldDataSources):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::isStopping):
(WebCore::FrameLoader::finishedLoading):
(WebCore::FrameLoader::URL):
(WebCore::FrameLoader::isArchiveLoadPending):
(WebCore::FrameLoader::isHostedByObjectElement):
(WebCore::FrameLoader::isLoadingMainFrame):
(WebCore::FrameLoader::canShowMIMEType):
(WebCore::FrameLoader::representationExistsForURLScheme):
(WebCore::FrameLoader::generatedMIMETypeForURLScheme):
(WebCore::FrameLoader::cancelContentPolicyCheck):
(WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebCore::FrameLoader::finishedLoadingDocument):
(WebCore::FrameLoader::isReplacing):
(WebCore::FrameLoader::setReplacing):
(WebCore::FrameLoader::revertToProvisional):
(WebCore::FrameLoader::subframeIsLoading):
(WebCore::FrameLoader::willChangeTitle):
(WebCore::FrameLoader::loadType):
(WebCore::FrameLoader::stopPolicyCheck):
(WebCore::FrameLoader::continueAfterContentPolicy):
(WebCore::FrameLoader::continueAfterWillSubmitForm):
(WebCore::FrameLoader::didFirstLayout):
(WebCore::FrameLoader::frameLoadCompleted):
(WebCore::FrameLoader::firstLayoutDone):
(WebCore::FrameLoader::isQuickRedirectComing):
(WebCore::FrameLoader::closeDocument):
(WebCore::FrameLoader::detachChildren):
(WebCore::FrameLoader::checkLoadComplete):
(WebCore::FrameLoader::numPendingOrLoadingRequests):
(WebCore::FrameLoader::setClient):
(WebCore::FrameLoader::client):
(WebCore::FrameLoader::userAgent):
(WebCore::FrameLoader::createEmptyDocument):
(WebCore::FrameLoader::tokenizerProcessedData):
(WebCore::FrameLoader::didTellBridgeAboutLoad):
(WebCore::FrameLoader::haveToldBridgeAboutLoad):
(WebCore::FrameLoader::handledOnloadEvents):
(WebCore::FrameLoader::frameDetached):
(WebCore::FrameLoader::setTitle):
(WebCore::FrameLoaderClient::~FrameLoaderClient):
* loader/FrameLoader.h:
(WebCore::):
* loader/FrameLoaderClient.h:
* loader/PluginDocument.cpp:
(WebCore::PluginTokenizer::createDocumentStructure):
(WebCore::PluginTokenizer::writeRawData):
* loader/ResourceLoader.h:
* loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::checkForHeadCharset):
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
(WebCore::IconLoader::finishLoading):
* loader/loader.cpp:
(WebCore::Loader::didReceiveResponse):
* loader/mac/DocumentLoaderMac.mm:
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::setPrimaryLoadComplete):
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::startLoading):
(WebCore::FrameLoader::cancelMainResourceLoad):
(WebCore::FrameLoader::receivedMainResourceError):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::loadResourceSynchronously):
(WebCore::FrameLoader::createFrame):
(WebCore::FrameLoader::objectContentType):
(WebCore::nsArray):
(WebCore::FrameLoader::createPlugin):
(WebCore::FrameLoader::redirectDataToPlugin):
(WebCore::FrameLoader::createJavaAppletWidget):
(WebCore::FrameLoader::partClearedInBegin):
(WebCore::FrameLoader::saveDocumentState):
(WebCore::FrameLoader::restoreDocumentState):
(WebCore::FrameLoader::overrideMediaType):
(WebCore::FrameLoader::mainResourceData):
(WebCore::FrameLoader::canGoBackOrForward):
(WebCore::FrameLoader::originalRequestURL):
(WebCore::FrameLoader::getHistoryLength):
(WebCore::FrameLoader::goBackOrForward):
(WebCore::FrameLoader::historyURL):
(WebCore::FrameLoader::didFinishLoad):
* loader/mac/LoaderFunctionsMac.mm:
(WebCore::ServeSynchronousRequest):
(WebCore::CheckCacheObjectStatus):
* loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::cancel):
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::create):
* loader/qt/FrameLoaderQt.cpp: Added.
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::setTitle):
(WebCore::FrameLoader::createFrame):
(WebCore::FrameLoader::objectContentType):
(WebCore::FrameLoader::createPlugin):
(WebCore::FrameLoader::createJavaAppletWidget):
(WebCore::FrameLoader::originalRequestURL):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::document):
* page/Frame.cpp:
(WebCore::Frame::~Frame):
(WebCore::Frame::reparseConfiguration):
(WebCore::Frame::shouldDragAutoNode):
(WebCore::Frame::prepareForUserAction):
(WebCore::FramePrivate::FramePrivate):
(WebCore::FramePrivate::~FramePrivate):
* page/Frame.h:
* page/FramePrivate.h:
* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::mediaType):
* page/FrameView.h:
* page/PageState.cpp:
(WebCore::PageState::PageState):
(WebCore::PageState::restoreJavaScriptState):
* platform/mac/CookieJar.mm:
(WebCore::setCookies):
* platform/mac/TextCodecMac.cpp:
* platform/mac/WebFontCache.mm:
(+[WebFontCache fontWithFamily:traits:size:]):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
* platform/qt/FrameQt.cpp:
* platform/qt/FrameQt.h:
* rendering/RenderApplet.cpp:
(WebCore::RenderApplet::createWidgetIfNecessary):
* rendering/RenderBlock.h:
* rendering/RenderPartObject.cpp:
(WebCore::isURLAllowed):
(WebCore::RenderPartObject::updateWidget):
* xml/DOMParser.cpp:
(WebCore::DOMParser::parseFromString):
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::getResponseXML):
WebKit:
Reviewed by Geoff.
- udpated for changes to move from Frame/FrameMac to FrameLoader
* DefaultDelegates/WebDefaultContextMenuDelegate.m:
(-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
* Misc/WebNSAttributedStringExtras.m:
(+[NSAttributedString _web_attributedStringFromRange:]):
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView requestWithURLCString:]):
* Plugins/WebNetscapePluginEmbeddedView.m:
(-[WebNetscapePluginEmbeddedView didStart]):
* Plugins/WebNetscapePluginStream.mm:
* Plugins/WebPluginController.mm:
(-[WebPluginController pluginView:receivedResponse:]):
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::provisionalLoadStarted):
* WebView/WebFrame.mm:
(-[WebFrame _canCachePage]):
(+[WebFrame _timeOfLastCompletedLoad]):
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _reloadForPluginChanges]):
(-[WebFrame stopLoading]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 8 Nov 2006 03:05:31 +0000 (03:05 +0000)]
WebCore:
Reviewed by Geoff.
Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::registerCommandForUndoOrRedo):
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
(-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
(-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]):
(-[WebCoreFrameBridge selectionGranularity]):
(-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
(-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
(-[WebCoreFrameBridge setTypingStyle:withUndoAction:]):
(-[WebCoreFrameBridge applyStyle:withUndoAction:]):
(-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
* editing/SelectionController.cpp:
(WebCore::SelectionController::setModifyBias):
(WebCore::SelectionController::modify):
* editing/SelectionController.h:
(WebCore::SelectionController::):
* editing/TextGranularity.h:
WebKit:
Reviewed by Geoff.
Use the WebCore editing enums.
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge undoNameForEditAction:]):
* WebView/WebHTMLView.m:
(-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
(-[WebHTMLView _deleteSelection]):
(-[WebHTMLView moveBackward:]):
(-[WebHTMLView moveBackwardAndModifySelection:]):
(-[WebHTMLView moveDown:]):
(-[WebHTMLView moveDownAndModifySelection:]):
(-[WebHTMLView moveForward:]):
(-[WebHTMLView moveForwardAndModifySelection:]):
(-[WebHTMLView moveLeft:]):
(-[WebHTMLView moveLeftAndModifySelection:]):
(-[WebHTMLView moveRight:]):
(-[WebHTMLView moveRightAndModifySelection:]):
(-[WebHTMLView moveToBeginningOfDocument:]):
(-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]):
(-[WebHTMLView moveToBeginningOfSentence:]):
(-[WebHTMLView moveToBeginningOfSentenceAndModifySelection:]):
(-[WebHTMLView moveToBeginningOfLine:]):
(-[WebHTMLView moveToBeginningOfLineAndModifySelection:]):
(-[WebHTMLView moveToBeginningOfParagraph:]):
(-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]):
(-[WebHTMLView moveToEndOfDocument:]):
(-[WebHTMLView moveToEndOfDocumentAndModifySelection:]):
(-[WebHTMLView moveToEndOfSentence:]):
(-[WebHTMLView moveToEndOfSentenceAndModifySelection:]):
(-[WebHTMLView moveToEndOfLine:]):
(-[WebHTMLView moveToEndOfLineAndModifySelection:]):
(-[WebHTMLView moveToEndOfParagraph:]):
(-[WebHTMLView moveToEndOfParagraphAndModifySelection:]):
(-[WebHTMLView moveParagraphBackwardAndModifySelection:]):
(-[WebHTMLView moveParagraphForwardAndModifySelection:]):
(-[WebHTMLView moveUp:]):
(-[WebHTMLView moveUpAndModifySelection:]):
(-[WebHTMLView moveWordBackward:]):
(-[WebHTMLView moveWordBackwardAndModifySelection:]):
(-[WebHTMLView moveWordForward:]):
(-[WebHTMLView moveWordForwardAndModifySelection:]):
(-[WebHTMLView moveWordLeft:]):
(-[WebHTMLView moveWordLeftAndModifySelection:]):
(-[WebHTMLView moveWordRight:]):
(-[WebHTMLView moveWordRightAndModifySelection:]):
(-[WebHTMLView pageUp:]):
(-[WebHTMLView pageDown:]):
(-[WebHTMLView pageUpAndModifySelection:]):
(-[WebHTMLView pageDownAndModifySelection:]):
(-[WebHTMLView _expandSelectionToGranularity:]):
(-[WebHTMLView selectParagraph:]):
(-[WebHTMLView selectLine:]):
(-[WebHTMLView selectSentence:]):
(-[WebHTMLView selectWord:]):
(-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
(-[WebHTMLView _applyParagraphStyleToSelection:withUndoAction:]):
(-[WebHTMLView _toggleBold]):
(-[WebHTMLView _toggleItalic]):
(-[WebHTMLView pasteFont:]):
(-[WebHTMLView changeFont:]):
(-[WebHTMLView changeAttributes:]):
(-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
(-[WebHTMLView changeColor:]):
(-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]):
(-[WebHTMLView alignCenter:]):
(-[WebHTMLView alignJustified:]):
(-[WebHTMLView alignLeft:]):
(-[WebHTMLView alignRight:]):
(-[WebHTMLView _deleteWithDirection:SelectionController::granularity:killRing:isTypingAction:]):
(-[WebHTMLView deleteForward:]):
(-[WebHTMLView deleteBackward:]):
(-[WebHTMLView deleteWordForward:]):
(-[WebHTMLView deleteWordBackward:]):
(-[WebHTMLView deleteToBeginningOfLine:]):
(-[WebHTMLView deleteToEndOfLine:]):
(-[WebHTMLView deleteToBeginningOfParagraph:]):
(-[WebHTMLView deleteToEndOfParagraph:]):
(-[WebHTMLView subscript:]):
(-[WebHTMLView superscript:]):
(-[WebHTMLView unscript:]):
(-[WebHTMLView underline:]):
(-[WebHTMLView deleteToMark:]):
(-[WebHTMLView toggleBaseWritingDirection:]):
(-[WebHTMLView changeBaseWritingDirection:]):
(-[WebHTMLView _canSmartCopyOrDelete]):
(-[WebTextCompleteController doCompletion]):
(-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
* WebView/WebView.mm:
(-[WebView setTypingStyle:]):
(-[WebView applyStyle:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 8 Nov 2006 00:52:18 +0000 (00:52 +0000)]
Reviewed by Maciej
Changed the check for "top level frame" to something much more valid
* page/Frame.cpp:
(WebCore::Frame::endIfNotLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 7 Nov 2006 23:52:02 +0000 (23:52 +0000)]
2006-11-07 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
Initialize cachedPrototype to 0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 7 Nov 2006 22:44:31 +0000 (22:44 +0000)]
Updated.
* editing/pasteboard/
4076267-2-expected.checksum:
* editing/pasteboard/
4076267-2-expected.png:
* editing/pasteboard/
4076267-2-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Tue, 7 Nov 2006 22:24:28 +0000 (22:24 +0000)]
Reviewed by Hyatt (yesterday).
Here is part of my patch from yesterday that is safe to roll back
in. It will make the BuildBot happy.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::spellingToolTip): Null-check
m_innerNonSharedNode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 7 Nov 2006 21:07:51 +0000 (21:07 +0000)]
* loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse):
Comment grammar fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 7 Nov 2006 21:05:01 +0000 (21:05 +0000)]
LayoutTests:
Rolled out change for <rdar://problem/
4820814>.
Beth's planning on landing a new change for it soon, but in the mean time
we need layout tests succeeding again.
WebCore:
Rolled out change for <rdar://problem/
4820814>.
Beth's planning on landing a new change for it soon, but in the mean time
we need layout tests succeeding again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 7 Nov 2006 20:41:03 +0000 (20:41 +0000)]
Reviewed by Brady.
- fix <rdar://problem/
4752069> 9A274: World of Warcraft Launcher
crashes on launch in WebCore::ResourceLoader::start
No layout test, because this depends on cached icons, although there's
perhaps a way to write a test for it with some further ingenuity.
* loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable
to make explicit the fact that it can't be successfully copied.
Remove notifyIconChanged function and put the contents in the caller.
This eliminates the need for IconLoaderMac.mm. Added finishedLoading
and clearLoadingState functions to share code. Removed m_url, since the
resource handle already stores the URL. Renamed m_resourceLoader to
m_handle to reflect the class's name change. Removed the 4096-byte
inline buffer from m_data, since the malloc savings is not sufficient
to offset the additional memory use. Removed m_httpStatusCode because
we can instead cancel the load when we get a status code that reflects
failure. Added m_loadIsInProgress boolean because we need to detect
loads that complete during the ResourceHandle::create function call.
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress.
Don't initialize m_httpStatusCode.
(WebCore::IconLoader::~IconLoader): Updated for name change.
(WebCore::IconLoader::startLoading): Added code to use the
m_loadIsInProgress flag to detect if the load completed while inside
the ResourceHandle::create function. Removed code to set m_url.
(WebCore::IconLoader::stopLoading): Call clearLoadingState to share
more code.
(WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle
and finish loading if the HTTP status code indicates failure.
(WebCore::IconLoader::didReceiveData): Removed assertion that checks
the ResourceHandle, since we can't do that any more.
(WebCore::IconLoader::didFinishLoading): Changed to call finishLoading
so we can share code with the new didReceiveResponse code path.
(WebCore::IconLoader::finishLoading): Moved code here from the
didFinishLoading callback. Pass a URL when calling
commitIconURLToIconDatabase. Call notifyIconChanged directly here
instead of using a separate function. Call clearLoadingState to
share more code with stopLoading.
(WebCore::IconLoader::clearLoadingState): Added.
* loader/mac/IconLoaderMac.mm: Removed.
* WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 7 Nov 2006 19:32:52 +0000 (19:32 +0000)]
LayoutTests:
Reviewed by Darin.
<rdar://problem/
4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)
* editing/pasteboard/
3976872-expected.txt:
* editing/pasteboard/
4076267-2-expected.txt:
* editing/pasteboard/
4076267-3-expected.txt:
* editing/pasteboard/
4076267-expected.txt:
* editing/pasteboard/8145-1-expected.txt:
* editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
* editing/pasteboard/paste-match-style-001-expected.txt:
* editing/pasteboard/paste-match-style-002-expected.txt:
* editing/pasteboard/paste-text-019-expected.txt:
* editing/pasteboard/pasting-tabs-expected.txt:
WebCore:
Reviewed by Darin.
<rdar://problem/
4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)
* editing/pasteboard/
3976872-expected.txt:
* editing/pasteboard/
4076267-2-expected.txt:
* editing/pasteboard/
4076267-3-expected.txt:
* editing/pasteboard/
4076267-expected.txt:
* editing/pasteboard/8145-1-expected.txt:
* editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
* editing/pasteboard/paste-match-style-001-expected.txt:
* editing/pasteboard/paste-match-style-002-expected.txt:
* editing/pasteboard/paste-text-019-expected.txt:
* editing/pasteboard/pasting-tabs-expected.txt:
Updated because pasting text with no newlines does not use intermediate div.
* editing/markup.cpp:
(WebCore::fillContainerFromString):
First parameter is now a Container so a fragment can be passed.
(WebCore::createFragmentFromText):
A string with no newlines gets added inline, rather than being put into a paragraph.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 7 Nov 2006 18:39:02 +0000 (18:39 +0000)]
2006-11-07 Mitz Pettel <mitz@webkit.org>
Reviewed by Beth.
Test for http://bugs.webkit.org/show_bug.cgi?id=11505
REGRESSION: Null pointer deref in HitTestResult::spellingToolTip() (assertion failure in Node::document)
The null check was added as part for the fix for <rdar://problem/
4820814>,
however the test that was committed with the fix avoids the case of a null
m_innerNonSharedNode, which this test covers.
* fast/css-generated-content/spellingToolTip-assert-expected.checksum: Added.
* fast/css-generated-content/spellingToolTip-assert-expected.png: Added.
* fast/css-generated-content/spellingToolTip-assert-expected.txt: Added.
* fast/css-generated-content/spellingToolTip-assert.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 7 Nov 2006 10:47:15 +0000 (10:47 +0000)]
2006-11-07 Mark Rowe <bdash@webkit.org>
Reviewed by Dave Hyatt.
* projects/javascript/index.html: Update link to non-existent JavaScript Bugzilla
component to the correct JavaScriptCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Tue, 7 Nov 2006 07:15:00 +0000 (07:15 +0000)]
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/
4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com
The bug here is that the source of the iframe is only a comment,
and we were not properly constructing the frame because it was
sort-of empty but not.
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if
it is a comment node.
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleError): if n is a comment node and
there is no head, we create a head, insert in the document, and add
the comment node as a child. This is what Firefox does too.
* page/FrameView.cpp:
(WebCore::FrameView::handleMousePressEvent): Safe-guard for the
fix. It is possible to get a mouse event without a target node, so
we null check it. (Of course, in the case of this bug, it should
not have been null, but it is a good thing to check for anyway.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::spellingToolTip): Null-check
m_innerNonSharedNode.
Layout Tests:
Reviewed by Hyatt.
Test for <rdar://problem/
4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com
* fast/frames/onlyCommentInIFrame-expected.checksum: Added.
* fast/frames/onlyCommentInIFrame-expected.png: Added.
* fast/frames/onlyCommentInIFrame-expected.txt: Added.
* fast/frames/onlyCommentInIFrame.html: Added.
* fast/frames/resources/comment.html: Added.
* fast/frames/resources/commentX.xhtml: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 7 Nov 2006 05:42:41 +0000 (05:42 +0000)]
New results. The originals were incorrect.
* svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum:
* svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
* svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
* svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum:
* svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
* svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
* svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum:
* svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
* svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
* svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum:
* svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
* svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 7 Nov 2006 03:32:31 +0000 (03:32 +0000)]
LayoutTests:
Reviewed by harrison
* editing/execCommand/
4641880-1-expected.checksum: Added.
* editing/execCommand/
4641880-1-expected.png: Added.
* editing/execCommand/
4641880-1-expected.txt: Added.
* editing/execCommand/
4641880-1.html: Added.
* editing/execCommand/
4641880-2-expected.checksum: Added.
* editing/execCommand/
4641880-2-expected.png: Added.
* editing/execCommand/
4641880-2-expected.txt: Added.
* editing/execCommand/
4641880-2.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/
4641880>
Setting bullets to existing text grabs subsequent paragraph
When a selection ends at the start of a paragraph, we rarely paint
the selection gap before that paragraph, because there often is no gap.
In a case like this, it's not obvious to the user that the selection
ends "inside" that paragraph, so it would be confusing if
InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.
* editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::doApply): Moved the check for editability of
the selection to a more appropriate place. Change the endingSelection
if it ends at the start of a paragraph.
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::doApply): Ditto.
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 7 Nov 2006 03:25:16 +0000 (03:25 +0000)]
Reviewed by Sarge
<rdar://problem/
4822911> - ASSERTION was a little overzealous.
Toned it down a bit.
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::didFinishLoading): Toned down assertion
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 7 Nov 2006 01:09:19 +0000 (01:09 +0000)]
2006-11-06 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Maciej.
Remove warning about garbage after #else. #else clause applies for all
non-mac platforms, not only win.
* kjs/date_object.cpp:
2006-11-06 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Maciej.
Linux\Gdk build fixes.
* loader/icon/IconDatabase.cpp:
* loader/icon/SQLStatement.h:
* platform/gdk/ChromeClientGdk.h: Added.
(WebCore::ChromeClientGdk::~ChromeClientGdk):
* platform/gdk/CursorGdk.cpp:
(WebCore::pointerCursor):
* platform/gdk/FrameGdk.cpp:
(WebCore::doScroll):
(WebCore::FrameGdk::FrameGdk):
(WebCore::FrameGdk::submitForm):
(WebCore::FrameGdk::urlSelected):
(WebCore::FrameGdk::openURL):
(WebCore::FrameGdk::handleGdkEvent):
* platform/gdk/FrameGdk.h:
(WebCore::FrameGdk::client):
* platform/gdk/RenderPopupMenuGdk.cpp:
(WebCore::PopupMenu::updateFromElement):
* platform/gdk/ScreenGdk.cpp:
* platform/gdk/TemporaryLinkStubs.cpp:
(Slider::focusPolicy):
(WebCore::ServeSynchronousRequest):
(FrameGdk::goBackOrForward):
(FrameGdk::getHistoryLength):
(FrameGdk::historyURL):
(ChromeClientGdk::canRunModal):
(ChromeClientGdk::runModal):
(WebCore::systemBeep):
(WebCore::CachedResource::setPlatformResponse):
(Path::transform):
(ResourceLoader::loadsBlocked):
(IconLoader::notifyIconChanged):
* platform/network/gdk/ResourceHandleManager.cpp:
(WebCore::writeCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::remove):
(WebCore::ResourceHandleManager::add):
2006-11-06 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Maciej.
Linux\gdk build fixes.
* GdkLauncher/main.cpp:
(LauncherFrameGdk::LauncherFrameGdk):
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 7 Nov 2006 01:08:37 +0000 (01:08 +0000)]
64-bit build fix, take two.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 7 Nov 2006 01:04:05 +0000 (01:04 +0000)]
Build fix for 64-bit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 7 Nov 2006 00:56:34 +0000 (00:56 +0000)]
Reviewed by Darin.
Accidentally rolled out this change when removing the WebPageBridge. Now
putting it back.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 7 Nov 2006 00:30:15 +0000 (00:30 +0000)]
build fix.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 6 Nov 2006 23:56:59 +0000 (23:56 +0000)]
WebCore:
Reviewed by Maciej, Anders, Darin.
Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
Fixed a minor where WebCore would always assume it was displayed on the
monitor containing the menubar. window.open and window.showModalDialog
are now cross-platform.
Layout tests, manual-tests/show-modal-dialog, and manual-tests/
window-open-features-parsing all pass. I verified the new screen functionality
by running in DRT, and checking whether WebCore knew it was off-screen.
Some refactoring remains, as all were not pleased by this design. I see
in my future another patch.
* bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a
client, to encapsulate asking the platform questions about the screen occupied by
the page. (Previously, we always assumed we were on screen 0, which was a bug.)
* bridge/mac/WebCoreFrameBridge.mm:
(createMouseEventFromDraggingInfo): Reversed argument order, to match other
functions.
(-[WebCoreFrameBridge dragSourceMovedTo:]): ditto
(-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
* bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
* bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
* bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
* bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
* manual-tests/window-open-features-parsing.html: Updated for accuracy.
(In this case, neither size nor position is specified, so you should
get the default window size and position.)
* page/Screen.cpp: Added. Includes screen-related helper functions used
in WebCore and WebKit.
* platform/PlatformMouseEvent.h: Exported common code so it doesn't have
to be duplicated. Renamed "position" to "point" since both were used,
and "point" seemed clearer.
* platform/Screen.h: Removed. Dead Code.
* platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge
initialization.
WebKit:
Reviewed by Maciej, Darin, Anders.
Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
(WebChromeClient::pageRect): It may seem weird for the page to ask the Chrome/ChromeClient
about its own dimensions. The idea here is that we're asking the Chrome how
much space it has devoted to the page. We have API for this (-webViewContentRect), but
it was documented incorrectly (even Safari used it wrong), so we don't use
it anymore. Once we fix our API/documentation, we can return to making a
delegate callback to ask for the page's size.
(WebChromeClient::createWindow): Changed to take a FrameLoadRequest with
an appropriate referrer, instead of making up its own.
(WebChromeClient::createModalDialog): Changed to take a FrameLoadRequest with
an appropriate referrer, instead of broken out parcels.
* WebCoreSupport/WebPageBridge.h: Removed. Dead Code.
* WebCoreSupport/WebPageBridge.mm: Removed. Dead Code.
* WebCoreSupport/WebScreenClient.h: Added.
* WebCoreSupport/WebScreenClient.mm: Added.
* WebView/WebView.mm: Added NULL checks for new _private->page, since
it's not NULL-safe like the bridge was, and it gets cleared before
dealloc.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gdennis [Mon, 6 Nov 2006 22:44:23 +0000 (22:44 +0000)]
WebCore:
Reviewed by Tim Hatcher.
Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
No layout tests added as this must be tested manually by the test
WebCore/manual-tests/contenteditable-link.html
* WebCore.exp: Exported HitTestResult::isLiveLink().
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::defaultEventHandler):
(WebCore::HTMLAnchorElement::isLiveLink):
* html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable
to track shift key status.
* manual-tests/contenteditable-link.html: Added description about link
dragging behaviour.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isLiveLink): Added.
* rendering/HitTestResult.h:
WebKit:
Reviewed by Tim Hatcher.
Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
* DefaultDelegates/WebDefaultUIDelegate.m:
(-[NSApplication webView:dragSourceActionMaskForPoint:]): Logic moved to
WebHTMLView's _mayStartDragAtEventLocation
* Misc/WebElementDictionary.m: added isLiveLink
(+[WebElementDictionary initializeLookupTable]):
(-[WebElementDictionary _isLiveLink]):
* WebView/WebHTMLView.m:
(-[WebHTMLView _mayStartDragAtEventLocation:]): Editable links should
only be followed if isLiveLink is true
(-[WebHTMLView _isMoveDrag:]): A drag of a live editable link is not
a move
(-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]):
(-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
* WebView/WebView.mm: added WebElementLinkIsLiveKey
* WebView/WebViewPrivate.h: ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 6 Nov 2006 21:23:27 +0000 (21:23 +0000)]
Reviewed by Anders.
Update the site with new wiki and Trac links.
* blog/wp-content/themes/webkit/sidebar.php:
* building/build.html:
* index.html:
* nav.inc:
* projects/svg/index.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 6 Nov 2006 21:03:30 +0000 (21:03 +0000)]
Reviewed by Oliver
Fixes <rdar://problem/
4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
For now, we have to not load favicons when we have no Document - linking directly
to PDFs being the common case
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading): Check for the document and return if none
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Mon, 6 Nov 2006 19:27:10 +0000 (19:27 +0000)]
2006-11-06 Oliver Hunt <oliver@apple.com>
Reviewed by Mitz.
* svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
* svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
* svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
* svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled: Removed.
* svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
* svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
* svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
* svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled: Removed.
* svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
* svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
* svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
* svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled: Removed.
* svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
* svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
* svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
* svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 6 Nov 2006 19:05:10 +0000 (19:05 +0000)]
Reviewed by Dave Harrison
<rdar://problem/
4801066>
Added a critical null frameLoader() check
* loader/mac/MainResourceLoaderMac.mm:
(WebCore::MainResourceLoader::loadNow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Mon, 6 Nov 2006 18:08:52 +0000 (18:08 +0000)]
LayoutTests:
Reviewed by Darin.
<rdar://problem/
4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned
* editing/deleting/delete-br-012-expected.checksum: Added.
* editing/deleting/delete-br-012-expected.png: Added.
* editing/deleting/delete-br-012-expected.txt: Added.
* editing/deleting/delete-br-012.html: Added.
WebCore:
Reviewed by Darin.
<rdar://problem/
4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned
Test:
* editing/deleting/delete-br-012.html
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
Update m_endingPosition when preventing merge.
Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 6 Nov 2006 17:47:10 +0000 (17:47 +0000)]
Build fix, approved in principle by Tim H.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Disable deprecated warnings for main.c (TestNetscapePlugin),
as it now uses QuickDraw to convert mouse event coordinates.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 6 Nov 2006 17:08:16 +0000 (17:08 +0000)]
Reviewed by Maciej.
Bug 11525: [Drosera] function menu doesn't understand object.method = function() {} syntax
http://bugs.webkit.org/show_bug.cgi?id=11525
* Drosera/debugger.js: imporved the function name code
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 6 Nov 2006 14:19:49 +0000 (14:19 +0000)]
Reviewed by Sam Weinig.
Fix a layout test failure that happened with additional fonts installed - replace a fancy
Unicode character with a plain asterisk.
* css2.1/t0905-c414-flt-00-d-expected.checksum:
* css2.1/t0905-c414-flt-00-d-expected.png:
* css2.1/t0905-c414-flt-00-d-expected.txt:
* css2.1/t0905-c414-flt-00-d.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 6 Nov 2006 13:08:47 +0000 (13:08 +0000)]
Reviewed by Maciej.
Make sure that alerts and delegate output made after notifyDone() are ignored, rather than
being attributed to the next test.
WebKitTools:
* DumpRenderTree/EditingDelegate.m:
(-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
(-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
(-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
(-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
(-[EditingDelegate webView:shouldDeleteDOMRange:]):
(-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
(-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
(-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
(-[EditingDelegate webViewDidBeginEditing:]):
(-[EditingDelegate webViewDidChange:]):
(-[EditingDelegate webViewDidEndEditing:]):
(-[EditingDelegate webViewDidChangeTypingStyle:]):
(-[EditingDelegate webViewDidChangeSelection:]):
* DumpRenderTree/UIDelegate.m:
(-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:]):
LayoutTests:
Removed leftover results from the previous test.
* editing/selection/drag-to-contenteditable-iframe-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 6 Nov 2006 13:03:25 +0000 (13:03 +0000)]
2006-11-07 Mark Rowe <bdash@webkit.org>
http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
Correctly updated tests results.
* fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
* fast/dom/HTMLMetaElement/meta-attributes.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 6 Nov 2006 12:54:30 +0000 (12:54 +0000)]
2006-11-06 Mark Rowe <bdash@webkit.org>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
Update DOMNode::toString to always use className rather than preferring nodeName.
* bindings/js/kjs_dom.cpp:
(KJS::DOMNode::toString): Match the format returned by valueOf.
2006-11-06 Mark Rowe <bdash@webkit.org>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg
Updated test results for change from nodeName to className in DOMNode::toString.
* fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
* fast/dom/prototype-chain-expected.txt:
* fast/dom/replace-first-child-expected.txt:
* fast/events/mouseclick-target-and-positioning-expected.txt:
* fast/forms/input-appearance-preventDefault-expected.checksum:
* fast/forms/input-appearance-preventDefault-expected.png:
* fast/forms/input-appearance-preventDefault-expected.txt:
* fast/loader/loadInProgress-expected.txt:
* fast/tokenizer/external-script-document-write-expected.checksum:
* fast/tokenizer/external-script-document-write-expected.png:
* fast/tokenizer/external-script-document-write-expected.txt:
* traversal/stay-within-root-expected.checksum:
* traversal/stay-within-root-expected.png:
* traversal/stay-within-root-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 6 Nov 2006 11:08:35 +0000 (11:08 +0000)]
2006-11-06 Mark Rowe <bdash@webkit.org>
Reviewed by Alexey.
Fix "Undefined subroutine &main::WEXITSTATUS" when build-dumprendertree fails.
* Scripts/run-webkit-tests: import the POSIX module.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 6 Nov 2006 10:57:28 +0000 (10:57 +0000)]
Clean build fix after r17607: removed obselete header include.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Mon, 6 Nov 2006 09:16:32 +0000 (09:16 +0000)]
2006-11-06 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej.
Fix RTL text in SVG to have correct positioning
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::placeBoxesHorizontally):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 6 Nov 2006 08:43:00 +0000 (08:43 +0000)]
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11517
REGRESSION: Flash clicks/interactivity not working properly
WebCore:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::handleMouseMoveEvent):
(WebCore::FrameMac::handleMouseReleaseEvent):
Restore parts of event dispatching that were removed when fixing
bug 7323 - just bypass those for subframes.
WebKitTools:
Teach TestNetscapePlugin to log events passed to it. To enable, set eventLoggingEnabled to true:
<embed name="plg" type="application/x-webkit-test-netscape" width=100 height=100></embed>
<script>
plg.eventLoggingEnabled = true;
// use eventSender to simulate events...
</script>
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
(pluginGetProperty):
(pluginSetProperty):
(pluginAllocate):
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
(NPP_HandleEvent):
LayoutTests:
* plugins/mouse-events-expected.txt: Added.
* plugins/mouse-events.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 6 Nov 2006 08:30:01 +0000 (08:30 +0000)]
2006-11-06 Mark Rowe <bdash@webkit.org>
Reviewed by the wonderful Mitz Pettel.
http://bugs.webkit.org/show_bug.cgi?id=11524
Bug 11524: REGRESSION(r9842): Array.prototype.join should use ToString operator rather than calling toString on each element
* kjs/array_object.cpp:
(ArrayProtoFunc::callAsFunction): Use ToString operator on each element rather than calling their toString method.
2006-11-06 Mark Rowe <bdash@webkit.org>
Reviewed by the wonderful Mitz Pettel.
Test for http://bugs.webkit.org/show_bug.cgi?id=11524
Bug 11524: REGRESSION(r9842): Array.prototype.join should use ToString operator rather than calling toString on each element
* fast/js/array-join-bug-11524-expected.txt: Added.
* fast/js/array-join-bug-11524.html: Added.
* fast/js/resources/array-join-bug-11524.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 6 Nov 2006 06:05:51 +0000 (06:05 +0000)]
- quick attempt to fix the no-SVG build
* platform/graphics/svg/SVGResource.cpp:
* platform/graphics/svg/SVGResource.h:
* platform/graphics/svg/SVGResourceClipper.cpp:
* platform/graphics/svg/SVGResourceClipper.h:
* platform/graphics/svg/SVGResourceImage.h:
* platform/graphics/svg/SVGResourceMarker.cpp:
* platform/graphics/svg/SVGResourceMarker.h:
* platform/graphics/svg/SVGResourceMasker.cpp:
* platform/graphics/svg/SVGResourceMasker.h:
* platform/graphics/svg/cg/SVGResourceMaskerCg.h:
* platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
* platform/graphics/svg/qt/SVGResourceImageQt.cpp:
* platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
Added #ifdef SVG_SUPPORT to these files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 6 Nov 2006 03:15:17 +0000 (03:15 +0000)]
Reviewed & landed by Maciej.
Fixes http://bugs.webkit.org/show_bug.cgi?id=11265
* platform/win/ResourceLoaderWin.cpp:
(WebCore::transferJobStatusCallback):
(WebCore::ResourceLoader::start):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 6 Nov 2006 02:55:59 +0000 (02:55 +0000)]
WebCore:
Reviewed by Oliver.
- moved FormData and FormDataStream to platform/network directory
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/WebCoreFrameBridge.mm:
* loader/FormData.cpp: Removed.
* loader/FormData.h: Removed.
* loader/mac/FormDataStream.h: Removed.
* loader/mac/FormDataStream.m: Removed.
* loader/mac/FrameLoaderMac.mm:
* loader/mac/SubresourceLoaderMac.mm:
* platform/network/mac/FormDataStreamMac.h: Added.
* platform/network/mac/FormDataStreamMac.mm: Added.
* platform/network/mac/ResourceRequestMac.mm:
WebKit:
Reviewed by Oliver.
- removed unneeded (and obsolete) header includes
* WebCoreSupport/WebFrameBridge.mm:
* WebView/WebFrame.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sun, 5 Nov 2006 23:52:09 +0000 (23:52 +0000)]
2006-11-05 Steve Falkenburg <sfalken@apple.com>
Fix build breaks
* loader/DocumentLoader.h:
* platform/win/ScreenWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 5 Nov 2006 23:14:12 +0000 (23:14 +0000)]
- WebKit part of Frame.h check-in (forgot to land it)
* WebCoreSupport/WebFrameBridge.h:
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge textViewWasFirstResponderAtMouseDownTime:]):
(-[WebFrameBridge shouldInterruptJavaScript]):
(-[WebFrameBridge saveDocumentState:]):
(-[WebFrameBridge previousKeyViewOutsideWebFrameViews]):
(-[WebFrameBridge valueForKey:keys:values:]):
(-[WebFrameBridge getObjectCacheSize]):
(-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
(-[WebFrameBridge mayStartDragAtEventLocation:]):
(-[WebFrameBridge canGoBackOrForward:]):
(-[WebFrameBridge goBackOrForward:]):
(-[WebFrameBridge print]):
(-[WebFrameBridge getAppletInView:]):
(-[WebFrameBridge pollForAppletInView:]):
(-[WebFrameBridge respondToChangedContents]):
(-[WebFrameBridge respondToChangedSelection]):
(-[WebFrameBridge setIsSelected:forView:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 5 Nov 2006 22:02:23 +0000 (22:02 +0000)]
Reviewed by Geoff.
- more preparation for splitting up Frame into sub-pieces
- removed unnecessary includes from Frame.h
* page/Frame.h: Removed unneeded includes and forward declarations.
Added additional forward declarations. Removed the constant
NoXPosForVerticalArrowNavigation, now moved inside SelectionController.
Created sections of functions to be moved into Chrome, Editor,
EventHandler, FrameLoader, SelectionController, and the Platform
directory, as well as marking one function for deletion.
* page/FramePrivate.h: Removed the definition of the constructor and
destructor and removed unnecessary includes.
* page/FrameView.h: Removed unneeded forward declarations and friend
declarations. Created a section of functions and data to be moved into
EventHandler.
* bridge/mac/FrameMac.h: Removed unneeded forward declarations.
Created sections of functions and data to be moved into Chrome,
Editor, EventHandler, FrameLoader, and the Platform directory.
* bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment.
Removed unused methods areScrollbarsVisible,
nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
* page/Frame.cpp:
(WebCore::Frame::begin): Added an overload, so Frame.h doesn't have
to include KURL.h just for the KURL default constructor.
(WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h.
(WebCore::FramePrivate::~FramePrivate): Ditto.
* page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf
booleans, scrollbarMoved and cleared funcitons.
(WebCore::FrameView::clear): Moved the code from the cleared
function in here.
(WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
* bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated
for changes to header.
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection):
(WebCore::SelectionController::xPosForVerticalArrowNavigation):
Moved NoXPosForVerticalArrowNavigation into this file.
* bindings/js/kjs_events.cpp:
* bindings/js/kjs_html.cpp:
* bindings/js/kjs_window.cpp:
* bridge/mac/WebCoreAXObject.mm:
* bridge/mac/WebCoreFrameBridge.mm:
* css/cssstyleselector.cpp:
* dom/Document.cpp:
* dom/Element.cpp:
* dom/EventTargetNode.cpp:
* dom/MouseRelatedEvent.cpp:
* dom/XMLTokenizer.cpp:
* html/HTMLBaseElement.cpp:
* html/HTMLDocument.cpp:
* html/HTMLEmbedElement.cpp:
* html/HTMLFrameElementBase.cpp:
* html/HTMLGenericFormElement.cpp:
* html/HTMLObjectElement.cpp:
* html/HTMLTokenizer.cpp:
* loader/mac/FrameLoaderMac.mm:
* page/PageState.cpp:
* rendering/RenderApplet.cpp:
* rendering/RenderBlock.cpp:
* rendering/RenderLayer.cpp:
* rendering/RenderObject.cpp:
* rendering/RenderPartObject.cpp:
* rendering/RenderTreeAsText.cpp:
* xml/XSLTProcessor.cpp:
Added includes as needed to keep compiling, since there are fewer
includes in Frame.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sun, 5 Nov 2006 08:36:54 +0000 (08:36 +0000)]
Reviewed by Dave Harrison.
http://bugs.webkit.org/show_bug.cgi?id=11402
REGRESSION: onChange does not work anymore for 1st item in popup
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::HTMLSelectElement):
(WebCore::HTMLSelectElement::reset):
Set m_lastOnChangeIndex to -1.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 5 Nov 2006 06:16:36 +0000 (06:16 +0000)]
2006-11-04 David Smith <catfish.man@gmail.com>
Reviewed by Tim H.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11521
Bug 11521: [Drosera] Breakpoint editor UI behaves incorrectly when multiple editors are open
* Drosera/debugger.js: Use .// instead of // so that it doesn't root the search at the document.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 5 Nov 2006 06:14:48 +0000 (06:14 +0000)]
2006-11-04 David Smith <catfish.man@gmail.com>
Reviewed by Tim H.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11513
Bug 11513: [Drosera] Function popup fails to appear when clicking supposedly valid areas.
* Drosera/debugger.css: Stick a min-width on the menu to keep it from becoming smaller than the control.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 5 Nov 2006 06:12:21 +0000 (06:12 +0000)]
2006-11-04 David Smith <catfish.man@gmail.com>
Reviewed by Tim H.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11512
Bug 11512: [Drosera] Scrolling via keyboard breaks after clicking in function popup.
* Drosera/debugger.js: blur() the function popup when we're done with it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 5 Nov 2006 01:16:31 +0000 (01:16 +0000)]
s
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 5 Nov 2006 01:16:10 +0000 (01:16 +0000)]
Reviewed by Ander.
- fix http://bugs.webkit.org/show_bug.cgi?id=11453
REGRESSION: Status bar always shows cancelled opening the page
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel.
Since the subresource owns the resource handle, there's no need to cancel.
This arrangement is only temporary, anyway, since Maciej will soon change
things so that the subresource loader uses the resource handle and the
resource handle doesn't know anything about the subresource loader.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 5 Nov 2006 01:06:47 +0000 (01:06 +0000)]
WebCore:
Reviewed by Maciej.
- converted more of the loader machinery to work with cross-platform
data structures instead of Macintosh-specific ones
converted most uses of NSURL to KURL and NSEvent to DOM Event in
loader classes
moved download function out of FrameLoader.h to avoid reference to
NSURLConnection
added DOM Event parameters to various functions so that the handlers
can use the DOM Event instead of the global "current NSEvent";
includes Frame::submitForm, HTMLFormElement::prepareSubmit,
HTMLFormElement::submit, FrameLoader::load
moved the setMainFrame call that hands ownership to the Page
into one of the Frame constructors, and removed it from all
the clients
removed const from Event parameter to the urlSelected function
(we rarely use const with DOM elements)
removed some redundant includes and declarations from various
header files
removed NSURL parameter from userAgent function -- if we need it we
can add it back, but converting from NSURL to KURL and back is
inefficient enough that it's best to have it out for now (since it's
been unused for years) -- if we add it back, we can choose an
appropriate parameter type that's always inexpensive to pass
did some basic cleanup in the IconLoader class, including removing
an unnecessary loop that added icon data a byte at a time
renamed safeLoad to load, since it's no different from the other
FrameLoader load functions, safety-wise
fixed some code that was trying to distinguish null frame name from
empty string frame name -- both should be handled the same, but callers
were doing it by checking for empty and turning it into null (in a way
that was causing extra round trips between NSString and WebCore::String)
corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
and got rid of case-insensitive compares of methods
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/kjs_navigator.cpp:
(KJS::Navigator::getValueProperty):
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::submitForm):
(WebCore::FrameMac::urlSelected):
(WebCore::FrameMac::userAgent):
* bridge/mac/FrameViewMac.mm:
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject rendererForView:]):
* bridge/mac/WebCorePageBridge.h:
* bridge/mac/WebCorePageBridge.mm:
* bridge/mac/WebCoreSettings.mm:
* bridge/win/FrameWin.cpp:
(WebCore::FrameWin::urlSelected):
(WebCore::FrameWin::submitForm):
* bridge/win/FrameWin.h:
* dom/MouseRelatedEvent.cpp:
* dom/MouseRelatedEvent.h:
* dom/UIEvent.cpp:
(WebCore::UIEvent::~UIEvent):
* dom/UIEvent.h:
* dom/UIEventWithKeyState.h:
* dom/XMLTokenizer.cpp:
(WebCore::openFunc):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::defaultEventHandler):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::defaultEventHandler):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submitClick):
(WebCore::HTMLFormElement::prepareSubmit):
(WebCore::HTMLFormElement::submit):
* html/HTMLFormElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
* loader/DocumentLoader.h:
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/NavigationAction.h:
(WebCore::NavigationAction::event):
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::create):
(WebCore::IconLoader::startLoading):
(WebCore::IconLoader::didReceiveData):
(WebCore::IconLoader::didFinishLoading):
* loader/icon/IconLoader.h:
* loader/loader.cpp:
* loader/mac/DocumentLoaderMac.mm:
(WebCore::DocumentLoader::URL):
(WebCore::DocumentLoader::unreachableURL):
(WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
(WebCore::DocumentLoader::URLForHistory):
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::willSendRequest):
(WebCore::FrameLoader::clientRedirected):
(WebCore::FrameLoader::shouldReload):
(WebCore::FrameLoader::notifyIconChanged):
(WebCore::FrameLoader::URL):
(WebCore::FrameLoader::reloadAllowingStaleData):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::didChangeTitle):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::post):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/mac/IconLoaderMac.mm:
(WebCore::IconLoader::notifyIconChanged):
* loader/mac/LoaderFunctionsMac.mm:
* loader/mac/MainResourceLoaderMac.mm:
(WebCore::shouldLoadAsEmptyDocument):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
* loader/mac/NavigationActionMac.mm:
(WebCore::navigationType):
(WebCore::NavigationAction::NavigationAction):
* loader/mac/ResourceLoaderMac.mm:
* loader/mac/SubresourceLoaderMac.mm:
* page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::urlSelected):
(WebCore::Frame::submitFormAgain):
(WebCore::Frame::submitForm):
(WebCore::Frame::endIfNotLoading):
(WebCore::Frame::hitTestResultAtPoint):
* page/Frame.h:
* page/FramePrivate.h:
* platform/gdk/FrameGdk.cpp:
(WebCore::FrameGdk::FrameGdk):
(WebCore::FrameGdk::submitForm):
(WebCore::FrameGdk::urlSelected):
* platform/gdk/FrameGdk.h:
* platform/mac/TextFieldMac.mm:
* platform/network/HTTPHeaderMap.h:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/mac/ResourceHandleMac.mm:
* platform/network/mac/ResourceResponseMac.h:
* platform/network/mac/ResourceResponseMac.mm:
(-[NSURLResponse WebCore]):
* platform/network/win/ResourceHandleWin.cpp:
* platform/qt/FrameQt.cpp:
(WebCore::FrameQt::submitForm):
(WebCore::FrameQt::urlSelected):
* platform/qt/FrameQt.h:
* rendering/RenderLineEdit.cpp:
(WebCore::RenderLineEdit::returnPressed):
* xml/XSLTProcessor.cpp:
(WebCore::docLoaderFunc):
* xml/xmlhttprequest.cpp:
WebKit:
Reviewed by Maciej.
- converted more of the loader machinery to work with cross-platform
data structures instead of Macintosh-specific ones
store the computed user agent string as a WebCore::String instead
of an NSString to avoid overhead converting it every time we get it
* COM/WebFrame.cpp:
(WebFrame::initWithName):
* ChangeLog:
* Misc/WebElementDictionary.m:
(-[WebElementDictionary _image]):
(-[WebElementDictionary _targetWebFrame]):
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchWillPerformClientRedirect):
(WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
(WebFrameLoaderClient::setTitle):
(WebFrameLoaderClient::userAgent):
(WebFrameLoaderClient::actionDictionary):
* WebCoreSupport/WebPageBridge.mm:
(WebCore::if):
* WebView/WebDataSource.mm:
(-[WebDataSource _URL]):
(-[WebDataSource _URLForHistory]):
(-[WebDataSource unreachableURL]):
* WebView/WebHTMLView.m:
(-[WebHTMLView elementAtPoint:allowShadowContent:]):
* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):
(-[WebPDFView _path]):
* WebView/WebView.mm:
(-[WebViewPrivate init]):
(-[WebViewPrivate dealloc]):
(-[WebViewPrivate finalize]):
(-[WebView _preferencesChangedNotification:]):
(-[WebView _cachedResponseForURL:]):
(-[WebView setApplicationNameForUserAgent:]):
(-[WebView setCustomUserAgent:]):
(-[WebView customUserAgent]):
(-[WebView userAgentForURL:]):
(-[WebView _computeUserAgent]):
(-[WebView WebCore::]):
* WebView/WebViewInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 5 Nov 2006 01:02:03 +0000 (01:02 +0000)]
2006-11-04 Mark Rowe <bdash@webkit.org>
Reviewed by Darin.
Fix use of uninitialized value in pattern match.
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 5 Nov 2006 00:15:59 +0000 (00:15 +0000)]
Reviewed by Adele.
- replaced receivedRedirect with new willSendRequest delegate
- removed most mac-specific loader functions
- use ResourceResponse more in loader code
* WebCore.xcodeproj/project.pbxproj: Add new files.
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted
for CachedResource method renames.
(-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
Ditto.
* loader/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::checkNotify): simplified
based on ResourceResponse
* loader/CachedImage.cpp:
(WebCore::CachedImage::createImage): adapt for ResourceResponse
* loader/CachedResource.cpp:
(WebCore::CachedResource::CachedResource): store a ResourceResponse;
platform response is now called platformResponse and expiration date
is removed.
(WebCore::CachedResource::~CachedResource): ditto
(WebCore::CachedResource::isExpired): ditto
* loader/CachedResource.h:
(WebCore::CachedResource::platformResponse): ditto
(WebCore::CachedResource::setResponse): ditto
(WebCore::CachedResource::canDelete): ditto
* loader/LoaderFunctions.h:
* loader/loader.cpp:
(WebCore::Loader::receivedResponse): Adjusted for renames.
(WebCore::Loader::didReceiveResponse): Store whole ResourceResponse
in the CachedResource.
* loader/loader.h:
* loader/mac/FormDataStream.h:
* loader/mac/FormDataStream.m:
(WebCore::getStreamFormDatas): Rearranged things so it's
possible to get a FormData back out of a form data stream.
(WebCore::formCreate): ditto
(WebCore::formFinalize): ditto
(WebCore::httpBodyFromStream): ditto
* loader/mac/ImageDocumentMac.mm:
(WebCore::finishImageLoad): s/response/platformResponse/
* loader/mac/LoaderFunctionsMac.mm:
(WebCore::CheckCacheObjectStatus): ditto
(WebCore::CachedResource::setPlatformResponse): ditto
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::willSendRequest): send redirect
to client appropriately
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::willSendRequest): new entry
point for SubresourceLoader, dispatch to client.
* platform/network/ResourceRequest.h:
(WebCore::ResourceRequest::allowHTTPCookies): implemented
(WebCore::ResourceRequest::setAllowHTTPCookies): ditto
* platform/network/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse): initialize expiration
date(!)
* platform/network/cf/FormDataStreamCFNet.cpp: Added.
(WebCore::getStreamFormDatas): Added this, ported from NSURL version.
(WebCore::openNextStream): ditto
(WebCore::formCreate): ditto
(WebCore::formFinalize): ditto
(WebCore::formCanRead): ditto
(WebCore::formEventCallback): ditto
(WebCore::setHTTPBody): ditto
(WebCore::httpBodyFromStream): ditto
* platform/network/cf/FormDataStreamCFNet.h: Added.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest): implemented
(WebCore::ResourceHandle::start): use new ResourceRequest stuff
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::getResourceResponse): do nothing for a null response
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
* platform/network/mac/ResourceRequestMac.h: Added.
* platform/network/mac/ResourceRequestMac.mm: Added.
(WebCore::getResourceRequest): Added way to convert an NSURLRequest
to a ResourceRequest.
(WebCore::nsURLRequest): Opposite of the above.
* platform/network/cf/ResourceRequestCFNet.h: Added.
* platform/network/cf/ResourceRequestCFNet.cpp: Added.
(WebCore::getResourceRequest): Added way to convert an CFURLRequest
to a ResourceRequest.
(WebCore::cfURLRequest): Opposite of the above.
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect,
adjusted.
* xml/xmlhttprequest.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 4 Nov 2006 17:54:30 +0000 (17:54 +0000)]
Change suggested by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=11514
REGRESSION (r17438): Repro crash when opening a web archive
* bridge/mac/WebCorePageState.mm:
(-[WebCorePageState dealloc]): Add null check.
(-[WebCorePageState finalize]): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 4 Nov 2006 17:53:32 +0000 (17:53 +0000)]
Reviewed by Tim Hatcher.
* Scripts/webkitdirs.pm: Don't try to use the Xcode build setting if it's project-relative.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 4 Nov 2006 15:51:53 +0000 (15:51 +0000)]
2006-11-04 Bertrand Guiheneuf <guiheneuf@gmail.com>
Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
http://bugs.webkit.org/show_bug.cgi?id=11433
Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
WebCore:
* WebCore.vcproj/WebCore/WebCore.vcproj:
Added platform/graphics platform/network and platform/network/win to headers search paths
Created platform/graphics and platform/network filters in hierarchy
Moved GraphicsContext and GraphicsTypes to their respective filters
Added EditorClient.h
Added FrameLoader* files in loader/
Added HitTest* files in rendering/
Added Editor.* files in editing/
Added DeleteButton.* and DeleteButtonController.* in editing/
* bridge/win/ChromeClientWin.h: Added.
(WebCore::ChromeClientWin::~ChromeClientWin):
* bridge/win/EditorClientWin.h: Added.
(WebCore::EditorClientWin::~EditorClientWin):
* bridge/win/FrameWin.cpp:
(WebCore::FrameWin::FrameWin):
(WebCore::FrameWin::urlSelected):
(WebCore::FrameWin::submitForm):
(WebCore::FrameWin::createNewWindow):
* bridge/win/FrameWin.h:
Added EditorClient parameter to constructor
Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest()
Removed openURL() and openURLRequest from class definition
* bridge/win/PageWin.cpp:
* platform/AffineTransform.h:
* platform/cairo/AffineTransformCairo.cpp: Added.
(WebCore::AffineTransform::AffineTransform):
(WebCore::AffineTransform::setMatrix):
(WebCore::AffineTransform::map):
(WebCore::AffineTransform::mapRect):
(WebCore::AffineTransform::isIdentity):
(WebCore::AffineTransform::m11):
(WebCore::AffineTransform::m12):
(WebCore::AffineTransform::m21):
(WebCore::AffineTransform::m22):
(WebCore::AffineTransform::dx):
(WebCore::AffineTransform::dy):
(WebCore::AffineTransform::reset):
(WebCore::AffineTransform::scale):
(WebCore::AffineTransform::rotate):
(WebCore::AffineTransform::translate):
(WebCore::AffineTransform::shear):
(WebCore::AffineTransform::det):
(WebCore::AffineTransform::invert):
(WebCore::AffineTransform::operator cairo_matrix_t):
(WebCore::AffineTransform::operator== ):
(WebCore::AffineTransform::operator*= ):
(WebCore::AffineTransform::operator* ):
* platform/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
* platform/network/win/ResourceHandleWin.cpp:
(WebCore::ResourceHandle::onHandleCreated):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::fileLoadTimer):
(WebCore::ResourceHandle::cancel):
* platform/win/TemporaryLinkStubs.cpp:
(WebCore::FrameWin::goBackOrForward):
(WebCore::FrameWin::getHistoryLength):
(WebCore::FrameWin::historyURL):
(WebCore::ServeSynchronousRequest):
(WebCore::ChromeClientWin::canRunModal):
(WebCore::ChromeClientWin::runModal):
(WebCore::EditorClientWin::shouldDeleteRange):
(WebCore::EditorClientWin::shouldShowDeleteInterface):
(WebCore::EditorClientWin::isContinuousSpellCheckingEnabled):
(WebCore::EditorClientWin::isGrammarCheckingEnabled):
(WebCore::EditorClientWin::spellCheckerDocumentTag):
(WebCore::Path::transform):
(WebCore::PopupMenu::updateFromElement):
(WebCore::ResourceLoader::loadsBlocked):
(WebCore::systemBeep):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintButton):
(WebCore::RenderThemeWin::paintTextField):
WebKit:
* COM/WebFrame.cpp:
(WebFrame::initWithName):
(WebFrame::loadDataSource):
(WebFrame::receivedRedirect):
(WebFrame::receivedResponse):
(WebFrame::didReceiveData):
(WebFrame::receivedAllData):
Use resource handles now. Do not start doc loader by hand anymore.
Handle didReceiveData() callback instead of receivedData() which
is deprecated in implementation of ResourceHandleClient
* COM/WebFrame.h:
* COM/WebView.cpp:
Applied ResourceLoader --> ResourceHandle renaming
* WebKit.vcproj/WebKit.rc:
Got rid of MFC dependencies (build fix for VCExpress).
* WebKit.vcproj/WebKit.vcproj:
Added platform/graphics platform/network and platform/network/win
to headers search paths
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 4 Nov 2006 07:53:19 +0000 (07:53 +0000)]
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11448
⟨ and ⟩ entities are mapped to the incorrect Unicode codepoint
WebCore:
* html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.
LayoutTests:
* fast/parser/entities-in-xhtml-expected.checksum: Removed.
* fast/parser/entities-in-xhtml-expected.png: Removed.
Converted to plain text, the large table in the test didn't nearly fit anyway.
* fast/parser/entities-in-xhtml-expected.txt:
* fast/parser/entities-in-xhtml.xhtml:
Made the test self-consistent again by using actual numeric values for ⟨ and ⟩.
* fast/parser/entities-in-html-expected.txt: Added.
* fast/parser/entities-in-html.html: Added.
An HTML copy of the same test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 4 Nov 2006 06:14:57 +0000 (06:14 +0000)]
2006-11-03 David Smith <catfish.man@gmail.com>
Reviewed by Tim H.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11510
Bug 11510: [Drosera] Doubleclicking the attach table should attach to the clicked item.
* Drosera/DebuggerApplication.m:
(-[DebuggerApplication showAttachPanel:]): Set the doubleAction for the table view
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 4 Nov 2006 05:33:45 +0000 (05:33 +0000)]
2006-11-03 Mark Rowe <bdash@webkit.org>
Reviewed by Oliver.
Update Windows and Qt project files for file removals in r17585.
* CMakeLists.txt:
* WebCore.vcproj/WebCore/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sat, 4 Nov 2006 05:10:46 +0000 (05:10 +0000)]
2006-11-03 Zack Rusin <zack@kde.org>
Reviewed by Maciej.
The patch fixes text field drawing on the Qt platform.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintTextField): Use the style to correctly
render the text field
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sat, 4 Nov 2006 04:20:39 +0000 (04:20 +0000)]
2006-11-03 Steve Falkenburg <sfalken@apple.com>
Fix build
* kjs/JSImmediate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Sat, 4 Nov 2006 00:41:22 +0000 (00:41 +0000)]
2006-11-03 Oliver Hunt <oliver@apple.com>
Reviewed by Tim.
Correct incorrect call to SetCursor
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::userResize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Sat, 4 Nov 2006 00:35:26 +0000 (00:35 +0000)]
Reviewed by Oliver.
Removed DeprecatedRenderSelect and ListBox classes.
* WebCore.xcodeproj/project.pbxproj:
* css/html4.css:
* html/HTMLOptionElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::recalcStyle):
(WebCore::HTMLSelectElement::isKeyboardFocusable):
(WebCore::HTMLSelectElement::isMouseFocusable):
(WebCore::HTMLSelectElement::createRenderer):
(WebCore::HTMLSelectElement::setRecalcListItems):
(WebCore::HTMLSelectElement::notifyOptionSelected):
(WebCore::HTMLSelectElement::defaultEventHandler):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::updateListBoxSelection):
* html/HTMLSelectElement.h:
* platform/ListBox.h: Removed.
* platform/mac/FontCacheMac.mm:
* platform/mac/ListBoxMac.mm: Removed.
* platform/win/TemporaryLinkStubs.cpp:
* rendering/DeprecatedRenderSelect.cpp: Removed.
* rendering/DeprecatedRenderSelect.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 4 Nov 2006 00:20:12 +0000 (00:20 +0000)]
Not reviewed, fix for accidental commit.
- rolled back more of the accidentall commit that I forgot.
* platform/network/mac/ResourceRequestMac.h: Removed.
* platform/network/mac/ResourceRequestMac.mm: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 4 Nov 2006 00:09:46 +0000 (00:09 +0000)]
Reviewed by Tim H.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=9596
Bug 9596: [Drosera] add a function popup to the source pane
* Drosera/debugger.css: Added styles for function popup
* Drosera/debugger.html: Added function popup button and select
* Drosera/debugger.js: Added function popup functionality
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 3 Nov 2006 22:28:20 +0000 (22:28 +0000)]
Not reviewed, fix for accidental commit.
- roll back some network changes accidentally committed with a previous patch.
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge getData:andResponse:forURL:]):
(-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
* loader/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::checkNotify):
* loader/CachedImage.cpp:
(WebCore::CachedImage::createImage):
* loader/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::setExpireDate):
(WebCore::CachedResource::isExpired):
* loader/CachedResource.h:
(WebCore::CachedResource::response):
* loader/LoaderFunctions.h:
* loader/loader.cpp:
(WebCore::Loader::receivedResponse):
(WebCore::Loader::didReceivedResponse):
* loader/loader.h:
* loader/mac/FormDataStream.h:
* loader/mac/FormDataStream.m:
(WebCore::formCreate):
(WebCore::formFinalize):
* loader/mac/ImageDocumentMac.mm:
(WebCore::finishImageLoad):
* loader/mac/LoaderFunctionsMac.mm:
(WebCore::CheckCacheObjectStatus):
(WebCore::CachedResource::setResponse):
* loader/mac/SubresourceLoaderMac.mm:
(WebCore::SubresourceLoader::willSendRequest):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::receivedRedirect):
* platform/network/ResourceRequest.h:
* platform/network/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::redirectedToURL):
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::receivedRedirect):
* xml/xmlhttprequest.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 3 Nov 2006 22:15:21 +0000 (22:15 +0000)]
2006-11-03 Anders Carlsson <acarlsson@apple.com>
Rubber-stamped by Oliver.
Remove these, they have been merged with SVGRenderTreeAsText.
* rendering/SVGRenderAsText.cpp: Removed.
* rendering/SVGRenderAsText.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log