aroben [Fri, 25 Aug 2006 16:46:35 +0000 (16:46 +0000)]
Reviewed/landed by Adam.
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10559
Confirm to WebKit style guide - last fixes :-)
* platform/ResourceLoaderClient.h:
* platform/qt/ComboBoxQt.cpp:
* platform/qt/FrameQt.cpp:
(WebCore::doScroll):
(WebCore::FrameQt::FrameQt):
(WebCore::FrameQt::openURL):
(WebCore::FrameQt::submitForm):
(WebCore::FrameQt::setTitle):
(WebCore::FrameQt::passSubframeEventToSubframe):
(WebCore::FrameQt::registerCommandForUndo):
(WebCore::FrameQt::registerCommandForRedo):
(WebCore::FrameQt::keyEvent):
(WebCore::FrameQt::setFrameGeometry):
* platform/qt/GlyphMapQt.cpp:
(WebCore::GlyphMap::fillPage):
* platform/qt/GraphicsContextQt.cpp:
(WebCore::toQtCompositionMode):
(WebCore::toQtLineCap):
(WebCore::toQtLineJoin):
(WebCore::TextShadow::TextShadow):
(WebCore::GraphicsContextPlatformPrivate::p):
* platform/qt/ImageQt.cpp:
(WebCore::FrameData::clear):
(WebCore::Image::supportsType):
* platform/qt/IntSizeQt.cpp:
* platform/qt/LineEditQt.cpp:
* platform/qt/ListBoxQt.cpp:
* platform/qt/PageQt.cpp:
(WebCore::Page::windowRect):
* platform/qt/PathQt.cpp:
(WebCore::Path::~Path):
* platform/qt/ResourceLoaderCurl.cpp:
(WebCore::ResourceLoader::assembleResponseHeaders):
(WebCore::ResourceLoader::retrieveCharset):
(WebCore::ResourceLoader::receivedResponse):
* platform/qt/ResourceLoaderManager.cpp:
(WebCore::headerCallback):
(WebCore::ResourceLoaderManager::downloadTimerCallback):
(WebCore::ResourceLoaderManager::add):
* platform/qt/ScreenQt.cpp:
(WebCore::screenRect):
(WebCore::usableScreenRect):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::~ScrollView):
(WebCore::ScrollView::setParentWidget):
(WebCore::ScrollView::addChild):
* platform/qt/SharedTimerQt.cpp:
(WebCore::setSharedTimerFiredFunction):
* platform/qt/SharedTimerQt.h:
(WebCore::SharedTimerQt::SharedTimerQt):
(WebCore::SharedTimerQt::fire):
* platform/qt/SystemTimeQt.cpp:
(WebCore::currentTime):
* platform/qt/TextEditQt.cpp:
(WebCore::PlatformTextEdit::setParentWidget):
(WebCore::PlatformTextEdit::text):
(WebCore::PlatformTextEdit::sizeWithColumnsAndRows):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 25 Aug 2006 04:04:37 +0000 (04:04 +0000)]
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10444
Navigation links overlap the Spam Karma 2 footer
* blog/wp-content/themes/webkit/style.css: Hide the footer altogether.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 25 Aug 2006 00:41:15 +0000 (00:41 +0000)]
Reviewed by Darin.
* WebView/WebFrame.m:
(-[WebFrame _updateBackground]): reworded the comment about scroll view and setDrawsBackground:YES
* WebView/WebView.m:
(-[WebViewPrivate dealloc]): release the background color
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Fri, 25 Aug 2006 00:32:30 +0000 (00:32 +0000)]
Reviewed by Justin.
Follow up for...
<rdar://problem/
4471481> Represent misspellings in AXAttributedStringForTextMarkerRange
Fix bug I introduced in r15959.
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityAttributeValue:]):
Use topDocument in case we are in a subframe (we want the start/end of the overall page).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Thu, 24 Aug 2006 23:50:43 +0000 (23:50 +0000)]
Reviewed by Alice
Fixed my previous checkin, which was pruning the users entire icon db on startup everytime
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::retainIconForPageURL): Bind the PageURL to argument 1, as SQL bindings
are indexed to 1, not 0
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 24 Aug 2006 23:32:11 +0000 (23:32 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 24 Aug 2006 23:09:34 +0000 (23:09 +0000)]
WebCore:
Reviewed by Hyatt.
Allow changing the background color WebCore draws under transparent page backgrounds.
No automated way to test. All tests pass, no performance regression.
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge setBaseBackgroundColor:]):
* page/FrameView.cpp:
(WebCore::FrameViewPrivate::FrameViewPrivate):
(WebCore::FrameView::baseBackgroundColor):
(WebCore::FrameView::setBaseBackgroundColor):
* page/FrameView.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBackgroundExtended):
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
WebKit:
Reviewed by Hyatt.
WebView API to allow changing the background color that draws under transparent page backgrounds.
* WebView/WebFrame.m:
(-[WebFrame _makeDocumentView]):
(-[WebFrame _updateBackground]):
* WebView/WebFrameInternal.h:
* WebView/WebFrameView.m:
(-[WebFrameView drawRect:]):
* WebView/WebView.m:
(-[WebView setBackgroundColor:]):
(-[WebView backgroundColor]):
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView setDrawsBackground:]):
* WebView/WebViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 24 Aug 2006 22:07:45 +0000 (22:07 +0000)]
LayoutTests:
Reviewed by Justin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10169
REGRESSION: NativeTextArea: Text dragged from <input type=text> to textarea disappears
* fast/forms/drag-into-textarea-expected.txt: Added.
* fast/forms/drag-into-textarea.html: Added.
WebCore:
Reviewed by Justin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10169
REGRESSION: NativeTextArea: Text dragged from <input type=text> to textarea disappears
- eliminate the EditCommandPtr class from editing; use PassRefPtr and RefPtr instead
- other editing-related cleanup
Test: fast/forms/drag-into-textarea.html
* bridge/mac/FrameMac.h: Changed EditCommandPtr parameters to use PassRefPtr<EditCommand> instead.
* bridge/win/FrameWin.h: Ditto.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::registerCommandForUndoOrRedo): Ditto.
(WebCore::FrameMac::registerCommandForUndo): Ditto.
(WebCore::FrameMac::registerCommandForRedo): Ditto.
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
Use applyCommand instead of EditCommandPtr. Also remove now-unneeded document parameter.
(-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]): Ditto.
(-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): Ditto.
* editing/AppendNodeCommand.h: Removed document parameter from constructor. Changed new child
parameter to be a PassRefPtr. Reversed order of child and parent parameters.
* editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::AppendNodeCommand): Ditto.
(WebCore::AppendNodeCommand::doApply): Ditto.
(WebCore::AppendNodeCommand::doUnapply): Ditto.
* editing/ApplyStyleCommand.h: Removed document parameter from constructor.
* editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): Ditto.
* editing/BreakBlockquoteCommand.h: Removed unneeded include of DeprecatedPtrList.h.
* editing/BreakBlockquoteCommand.cpp: Moved the include of DeprecatedPtrList.h here.
(WebCore::BreakBlockquoteCommand::doApply): Changed code to construct a Selection explicitly
since setEndingSelection is no longer overloaded for Position.
* editing/CompositeEditCommand.h: Added isFirstCommand function. Changed m_cmds from
a DeprecatedValueList<EditCommandPtr> to a Vector<RefPtr<EditCommand>> and renamed it
m_commands and made both doUnapply and doReapply private.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::doUnapply): Rewrote to use m_commands.
(WebCore::CompositeEditCommand::doReapply): Ditto.
(WebCore::CompositeEditCommand::applyCommandToComposite): Removed code to explicitly set up
starting and ending selection -- now done inside setParent. Rewrote to use m_commands.
(WebCore::CompositeEditCommand::applyStyle): Changed to not use EditCommandPtr.
(WebCore::CompositeEditCommand::applyStyledElement): Ditto.
(WebCore::CompositeEditCommand::removeStyledElement): Ditto.
(WebCore::CompositeEditCommand::insertParagraphSeparator): Ditto.
(WebCore::CompositeEditCommand::insertNodeBefore): Ditto.
(WebCore::CompositeEditCommand::appendNode): Ditto.
(WebCore::CompositeEditCommand::removeNode): Ditto.
(WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto.
(WebCore::CompositeEditCommand::splitTextNode): Ditto.
(WebCore::CompositeEditCommand::splitElement): Ditto.
(WebCore::CompositeEditCommand::mergeIdenticalElements): Ditto.
(WebCore::CompositeEditCommand::wrapContentsInDummySpan): Ditto.
(WebCore::CompositeEditCommand::splitTextNodeContainingElement): Ditto.
(WebCore::CompositeEditCommand::joinTextNodes): Ditto.
(WebCore::CompositeEditCommand::inputText): Ditto.
(WebCore::CompositeEditCommand::insertTextIntoNode): Ditto.
(WebCore::CompositeEditCommand::deleteTextFromNode): Ditto.
(WebCore::CompositeEditCommand::replaceTextInNode): Ditto.
(WebCore::CompositeEditCommand::deleteSelection): Ditto.
(WebCore::CompositeEditCommand::removeCSSProperty): Ditto.
(WebCore::CompositeEditCommand::removeNodeAttribute): Ditto. Also fixed a bug where the code
would not remove an empty attribute -- will not come up in practice, but wrong in theory.
(WebCore::CompositeEditCommand::setNodeAttribute): Changed to not use EditCommandPtr.
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Ditto.
(WebCore::CompositeEditCommand::deleteInsignificantText): Rewrote to use a for loop.
(WebCore::CompositeEditCommand::moveParagraphs): Changed to not use EditCommandPtr.
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Changed code to construct a
Selection explicitly since setEndingSelection is no longer overloaded for Position.
(WebCore::createBlockPlaceholderElement): Collapsed this code so that the
block placeholder class string is no longer spread across multiple functions.
Perhaps we can get rid of this altogether at some point.
* editing/DeleteFromTextNodeCommand.h: Removed unneeded document parameter from one constructor.
Also removed unneeded destructor.
* editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): Ditto.
* editing/DeleteSelectionCommand.h: Removed unneeded document parameter from one constructor.
* editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Ditto.
* editing/EditCommand.h: Removed ECommandState, isCompositeStep(), parent(), state(), setState(),
and most overloads of setStartingSelection() and setEndingSelection(). Made document() protected
and non-virtual. Made setStartingSelection() setEndingSelection(), and styleAtPosition() protected.
Made doApply(), doUnapply(), and doReapply() private. Added startingRootEditableElement(),
endingRootEditableElement(), m_startingRootEditableElement, and m_endingRootEditableElement, which
are needed so we can determine which editable elements an editing operation affects. Changed setParent()
and m_parent to use CompositeEditCommand instead of EditCommand. Removed EditCommandPtr. Added
applyCommand() function that's convenient to use on a newly-created command.
* editing/EditCommand.cpp:
(WebCore::EditCommand::EditCommand): Removed initialization for m_state, and added it for starting
and ending root editable elements.
(WebCore::EditCommand::apply): Simplified check for top level by just checking m_parent. Removed
code to assert and set m_start. Eliminated use of EditCommandPtr.
(WebCore::EditCommand::unapply): Ditto.
(WebCore::EditCommand::reapply): Ditto.
(WebCore::EditCommand::setStartingSelection): Changed to set root editable element too. Also made this
not change the starting selection of the parent unless this is the first command in the parent -- didn't
make sense the way it was.
(WebCore::EditCommand::setEndingSelection): Changed to set root editable element too.
(WebCore::EditCommand::setParent): Added code to set the starting and ending selection on the child
based on the ending selection of the parent, formerly done by callers.
(WebCore::applyCommand): Added.
* editing/FormatBlockCommand.h: Tweaked formatting.
* editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::FormatBlockCommand): Ditto.
* editing/InsertLineBreakCommand.h: Ditto.
* editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::splitTreeToNode): Removed use of EditCommandPtr.
(WebCore::IndentOutdentCommand::outdentParagraph): Updated for change to list type enum.
(WebCore::IndentOutdentCommand::outdentRegion): Removed use of EditCommandPtr.
* editing/InsertIntoTextNodeCommand.h: Removed unneeded document parameter to constructor.
* editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Ditto.
* editing/InsertListCommand.h: Renamed EListType to EList, and took the "Type" suffix off
the constants.
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::InsertListCommand): Ditto.
(WebCore::InsertListCommand::doApply): Ditto.
* editing/InsertNodeBeforeCommand.h: Removed unneeded document parameter from constructor
and changed the parameter of the node to insert to a PassRefPtr.
* editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Ditto.
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): Remvoed use of EditCommandPtr.
* editing/InsertTextCommand.h: Changed insertTab to take const Position&.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input): Ditto.
(WebCore::InsertTextCommand::insertTab): Ditto.
* editing/JSEditor.h: Tweaked formatting and names.
* editing/JSEditor.cpp: Ditto. Also changed places that use EditCommandPtr.
* editing/JoinTextNodesCommand.h: Removed unneeeded document pointer
* editing/JoinTextNodesCommand.cpp:
(WebCore::JoinTextNodesCommand::JoinTextNodesCommand): Ditto.
* editing/MergeIdenticalElementsCommand.h: Ditto.
* editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): Ditto.
* editing/ModifySelectionListLevel.h: Changed EListType to be named Type and be a member of
IncreaseSelectionListLevelCommand. Also changed m_listElement to be a RefPtr<Node>.
* editing/ModifySelectionListLevel.cpp:
(WebCore::getStartEndListChildren): Changed parameters to be references instead of pointers.
(WebCore::IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand):
Changed to use Type instead of EListType.
(WebCore::canIncreaseListLevel): Changed parameters to be references instead of pointers.
(WebCore::IncreaseSelectionListLevelCommand::doApply): Updated for change to canIncreaseListLevel.
(WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel): Ditto.
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType):
Changed to not use EditCommandPtr.
(WebCore::canDecreaseListLevel): Changed parameters to be references instead of pointers.
(WebCore::DecreaseSelectionListLevelCommand::doApply): Updated for change to canDecreaseListLevel.
(WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel): Ditto.
(WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel): Changed to not use
EditCommandPtr.
* editing/MoveSelectionCommand.h: Removed unnecessary document parameter and changed the fragment
parameter to be a PassRefPtr.
* editing/MoveSelectionCommand.cpp:
(WebCore::MoveSelectionCommand::MoveSelectionCommand): Ditto.
(WebCore::MoveSelectionCommand::doApply): Got rid of use of EditCommandPtr.
* editing/RebalanceWhitespaceCommand.h: Removed unnecessary document parameter.
* editing/RebalanceWhitespaceCommand.cpp:
(WebCore::RebalanceWhitespaceCommand::RebalanceWhitespaceCommand): Ditto.
(WebCore::RebalanceWhitespaceCommand::doApply): Got rid of use of EditCommandPtr.
* editing/RemoveCSSPropertyCommand.h: Tweaked formatting.
* editing/RemoveNodeAttributeCommand.h: Removed unnecessary document parameter.
* editing/RemoveNodeAttributeCommand.cpp:
(WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand): Ditto.
* editing/RemoveNodeCommand.h: Removed unnecessary document parameter.
* editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::RemoveNodeCommand): Ditto.
* editing/RemoveNodePreservingChildrenCommand.h: Removed unnecessary document parameter.
* editing/RemoveNodePreservingChildrenCommand.cpp:
(WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): Ditto.
* editing/ReplaceSelectionCommand.h: Change fragment parameter to a PassRefPtr.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment): Ditto.
(WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Ditto.
(WebCore::ReplaceSelectionCommand::doApply): Ditto.
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
* editing/Selection.h: Changed SEL_DEFAULT_AFFINITY to be a constant rather than
a macro. Added constructors that take visible positions. Changed setBase and
setExtent to take const Position& for better efficiency.
* editing/Selection.cpp:
(WebCore::Selection::Selection): Removed unnecessary double initialization of m_state
and m_baseIsFirst in existing constructors. Added VisiblePosition-based constructors.
* editing/SetNodeAttributeCommand.h: Removed unnneeded document parameter.
* editing/SetNodeAttributeCommand.cpp:
(WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand): Ditto.
* editing/SplitElementCommand.h: Removed unnneeded document parameter.
* editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::SplitElementCommand): Ditto.
* editing/SplitTextNodeCommand.h: Removed unnneeded document parameter.
* editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::SplitTextNodeCommand): Ditto.
* editing/SplitTextNodeContainingElementCommand.h: Removed unnneeded document parameter.
* editing/SplitTextNodeContainingElementCommand.cpp:
(WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand): Ditto.
* editing/TypingCommand.h: Replaced uses of EditCommandPtr with EditCommand*.
Renamed openForMoveTyping() with isOpenForMoreTyping().
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Updated to remove use of EditCommandPtr.
(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
(WebCore::TypingCommand::insertText): Ditto.
(WebCore::TypingCommand::insertLineBreak): Ditto.
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): Ditto.
(WebCore::TypingCommand::insertParagraphSeparator): Ditto.
(WebCore::TypingCommand::isOpenForMoreTypingCommand): Ditto.
(WebCore::TypingCommand::closeTyping): Ditto.
(WebCore::TypingCommand::typingAddedToOpenCommand): Ditto.
(WebCore::TypingCommand::insertTextRunWithoutNewlines): Ditto.
* editing/WrapContentsInDummySpanCommand.h: Removed unnneeded document parameter.
* editing/WrapContentsInDummySpanCommand.cpp:
(WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand): Ditto.
* editing/htmlediting.h: Changed type of NON_BREAKING_SPACE to UChar instead of
unsigned short.
* page/Frame.h: Changed lastEditCommand() to return an EditCommand* and changed
appliedEditing(), unappliedEditing(), reappliedEditing(), registerCommandForUndo(),
and registerCommandForRedo() to take PassRefPtr<EditCommand>.
* page/FramePrivate.h: Changed m_lastEditCommand to be a RefPtr<EditCommand>.
* page/Frame.cpp:
(WebCore::Frame::didOpenURL): Fixed for change to m_lastEditCommand.
(WebCore::Frame::setFocusNodeIfNeeded): Call the rootEditableElement function
from Selection to simplify the code.
(WebCore::Frame::selectAll): Ditto.
(WebCore::Frame::lastEditCommand): Updated for change to m_lastEditCommand.
(WebCore::dispatchEditableContentChangedEvents): Added. This sends an event to
both of the root editable elements involved in a change -- the start selection
might be in a different element than the end selection.
(WebCore::Frame::appliedEditing): Changed to call dispatchEditableContentChangedEvents,
and to do it before setting the ending selection. Also update to use PassRefPtr instead
of EditCommandPtr and change the order of setting m_lastEditCommand since passing it
to registerCommandForUndo will take ownership and set it to 0.
(WebCore::Frame::unappliedEditing): Ditto.
(WebCore::Frame::reappliedEditing): Ditto.
(WebCore::Frame::computeAndSetTypingStyle): Updated for removal of EditCommandPtr.
(WebCore::Frame::applyStyle): Ditto.
(WebCore::Frame::applyParagraphStyle): Ditto.
* platform/gdk/FrameGdk.h: Updated for above changes.
* platform/gdk/TemporaryLinkStubs.cpp: Updated for above changes.
* platform/win/TemporaryLinkStubs.cpp: Updated for above changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Thu, 24 Aug 2006 20:18:25 +0000 (20:18 +0000)]
Reviewed by Eric. Landed by rwlbuis.
Add QtLauncher (was testunity before), which provides a
standalone "browser" to test the Qt platform stuff.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Thu, 24 Aug 2006 20:10:00 +0000 (20:10 +0000)]
Reviewed by Alice
<rdar://problem/
4697973> - Unacceptable delay on startup
<rdar://problem/
4690949> - Need to correctly prune unretained pageurls and icons on startup
This patch was started by me and finished by Mark Rowe - we now special case all retains during
startup into one huge sql transaction. Also we track PageURL retains instead of IconURLs so pruning works right.
Testing with reasonable sets of bookmarks/history (3000), startup time is neglibile. Testing with a huge set of
bookmarks (40,000), startup has a noticable delay, but reasonable, and is inline with shipping safari which also
has a noticeable delay.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::open): adding an initialStartupTransaction and pageRetainStatement
(WebCore::IconDatabase::close): do cleanup on the initialStartupSQL stuff
(WebCore::IconDatabase::retainIconForPageURL): Track initial PageURL retains in the temporary table
(WebCore::IconDatabase::releaseIconForPageURL): Ditto
(WebCore::IconDatabase::retainIconURL): We no longer special case this on startup
(WebCore::IconDatabase::releaseIconURL): We no longer special case this on startup
(WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Handle the big transaction correctly and quickly
(WebCore::IconDatabase::syncDatabase): Change the timing log message
* loader/icon/IconDatabase.h:
* loader/icon/SQLStatement.cpp:
(WebCore::SQLStatement::bindText16): Added this - for reusing commonly used statements by just rebinding parameters.
* loader/icon/SQLStatement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 24 Aug 2006 19:56:53 +0000 (19:56 +0000)]
Reviewed by Darin.
Fix for Mail stationary. Selecting a stationary item would cause this exception.
*** -[WebSubresourceLoader copyWithZone:]: selector not recognized
Uncaught exception - *** -[WebSubresourceLoader copyWithZone:]: selector not recognized
* Loader/WebFrameLoader.m:
(-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
Use _webkit_setObject:forUncopiedKey: when addign the resource to pendingArchivedResources.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Thu, 24 Aug 2006 19:54:43 +0000 (19:54 +0000)]
This file was listed in a previous ChangeLog, but not actually committed, fixing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 24 Aug 2006 18:50:55 +0000 (18:50 +0000)]
Reviewed/landed by Adam.
Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support
* CMakeLists.txt:
Remove KCanvasMatrix.cpp because it no longer exists
Remove platform/qt/test
* platform/FloatSize.h:
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
* platform/image-decoders/gif/GIFImageDecoder.cpp:
* platform/image-decoders/gif/GIFImageReader.cpp:
* platform/image-decoders/ico/ICOImageDecoder.cpp:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
* platform/image-decoders/png/PNGImageDecoder.cpp:
* platform/image-decoders/xbm/XBMImageDecoder.cpp:
Added PLATFORM(QT) hooks in the image-decoders/, as they also need
to work for Qt, not only for Cairo.
* platform/qt/qt-encodings.txt: Added (required for build).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 24 Aug 2006 18:35:44 +0000 (18:35 +0000)]
Fixing a typo from last patch.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 24 Aug 2006 18:32:46 +0000 (18:32 +0000)]
Reviewed/landed by Adam.
Final cleanup to conform to WebKit coding style!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 24 Aug 2006 17:02:38 +0000 (17:02 +0000)]
2006-08-24 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by Anders.
Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support
* CMakeLists.txt:
* platform/qt/FrameQt.cpp: Added.
(WebCore::doScroll):
(WebCore::FrameView::isFrameView):
(WebCore::FrameQt::FrameQt):
(WebCore::FrameQt::init):
(WebCore::FrameQt::~FrameQt):
(WebCore::FrameQt::openURL):
(WebCore::FrameQt::submitForm):
(WebCore::FrameQt::urlSelected):
(WebCore::FrameQt::userAgent):
(WebCore::FrameQt::runJavaScriptAlert):
(WebCore::FrameQt::runJavaScriptConfirm):
(WebCore::FrameQt::locationbarVisible):
(WebCore::FrameQt::setTitle):
(WebCore::FrameQt::createFrame):
(WebCore::FrameQt::passWheelEventToChildWidget):
(WebCore::FrameQt::passSubframeEventToSubframe):
(WebCore::FrameQt::objectContentType):
(WebCore::FrameQt::createPlugin):
(WebCore::FrameQt::passMouseDownEventToWidget):
(WebCore::FrameQt::menubarVisible):
(WebCore::FrameQt::personalbarVisible):
(WebCore::FrameQt::statusbarVisible):
(WebCore::FrameQt::toolbarVisible):
(WebCore::FrameQt::createEmptyDocument):
(WebCore::FrameQt::markedTextRange):
(WebCore::FrameQt::incomingReferrer):
(WebCore::FrameQt::mimeTypeForFileName):
(WebCore::FrameQt::markMisspellingsInAdjacentWords):
(WebCore::FrameQt::markMisspellings):
(WebCore::FrameQt::lastEventIsMouseUp):
(WebCore::FrameQt::saveDocumentState):
(WebCore::FrameQt::restoreDocumentState):
(WebCore::FrameQt::openURLRequest):
(WebCore::FrameQt::scheduleClose):
(WebCore::FrameQt::unfocusWindow):
(WebCore::FrameQt::focusWindow):
(WebCore::FrameQt::overrideMediaType):
(WebCore::FrameQt::addMessageToConsole):
(WebCore::FrameQt::runJavaScriptPrompt):
(WebCore::FrameQt::getEmbedInstanceForWidget):
(WebCore::FrameQt::getObjectInstanceForWidget):
(WebCore::FrameQt::getAppletInstanceForWidget):
(WebCore::FrameQt::registerCommandForUndo):
(WebCore::FrameQt::registerCommandForRedo):
(WebCore::FrameQt::clearUndoRedoOperations):
(WebCore::FrameQt::issueUndoCommand):
(WebCore::FrameQt::issueRedoCommand):
(WebCore::FrameQt::issueCutCommand):
(WebCore::FrameQt::issueCopyCommand):
(WebCore::FrameQt::issuePasteCommand):
(WebCore::FrameQt::issuePasteAndMatchStyleCommand):
(WebCore::FrameQt::issueTransposeCommand):
(WebCore::FrameQt::respondToChangedSelection):
(WebCore::FrameQt::respondToChangedContents):
(WebCore::FrameQt::shouldChangeSelection):
(WebCore::FrameQt::partClearedInBegin):
(WebCore::FrameQt::canGoBackOrForward):
(WebCore::FrameQt::handledOnloadEvents):
(WebCore::FrameQt::canPaste):
(WebCore::FrameQt::canRedo):
(WebCore::FrameQt::canUndo):
(WebCore::FrameQt::print):
(WebCore::FrameQt::shouldInterruptJavaScript):
(WebCore::FrameQt::keyEvent):
(WebCore::FrameQt::receivedResponse):
(WebCore::FrameQt::receivedData):
(WebCore::FrameQt::receivedAllData):
(WebCore::FrameQt::setFrameGeometry):
* platform/qt/FrameQt.h: Added.
* platform/qt/ScrollViewCanvasQt.cpp: Added.
(WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
(WebCore::ScrollViewCanvasQt::paintEvent):
(WebCore::ScrollViewCanvasQt::sizeHint):
(WebCore::ScrollViewCanvasQt::mouseMoveEvent):
(WebCore::ScrollViewCanvasQt::mousePressEvent):
(WebCore::ScrollViewCanvasQt::mouseReleaseEvent):
(WebCore::ScrollViewCanvasQt::keyPressEvent):
(WebCore::ScrollViewCanvasQt::keyReleaseEvent):
(WebCore::ScrollViewCanvasQt::handleKeyEvent):
* platform/qt/ScrollViewCanvasQt.h: Added.
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::setParentWidget):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 24 Aug 2006 16:49:19 +0000 (16:49 +0000)]
Reviewed by ap.
Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support
* platform/qt/FontCacheQt.cpp: Added.
(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::createFontPlatformData):
* platform/qt/FontDataQt.cpp: Added.
(WebCore::FontData::platformInit):
(WebCore::FontData::platformDestroy):
(WebCore::FontData::smallCapsFontData):
(WebCore::FontData::containsCharacters):
(WebCore::FontData::determinePitch):
(WebCore::FontData::platformWidthForGlyph):
* platform/qt/FontPlatformData.h: Added.
* platform/qt/FontPlatformDataQt.cpp: Added.
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::isFixedPitch):
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
* platform/qt/FontQt.cpp: Added.
(WebCore::Font::operator QFont):
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
* platform/qt/GlyphMapQt.cpp: Added.
(WebCore::GlyphMap::fillPage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Thu, 24 Aug 2006 16:40:04 +0000 (16:40 +0000)]
LayoutTests:
Updated expected results for this change:
<rdar://problem/
4522205> Represent controls in AXAttributedStringForTextMarkerRange
* editing/selection/anchor-focus1-expected.txt:
* editing/selection/anchor-focus2-expected.txt:
* editing/selection/anchor-focus3-expected.txt:
* editing/selection/move-begin-end-expected.txt:
* fast/dom/Element/onclick-case-expected.txt:
* fast/dom/HTMLInputElement/size-as-number-expected.txt:
* fast/dom/document-all-input-expected.txt:
* fast/dom/option-properties-expected.txt:
* fast/events/objc-keyboard-event-creation-expected.txt:
* fast/events/onsubmit-bubbling-expected.txt:
* fast/forms/access-key-expected.txt:
* fast/forms/activate-and-disabled-elements-expected.txt:
* fast/forms/button-in-forms-collection-expected.txt:
* fast/forms/check-box-enter-key-expected.txt:
* fast/forms/cursor-position-expected.txt:
* fast/forms/display-none-in-onchange-keyboard-expected.txt:
* fast/forms/domstring-replace-crash-expected.txt:
* fast/forms/double-focus-expected.txt:
* fast/forms/element-by-name-expected.txt:
* fast/forms/empty-get-expected.txt:
* fast/forms/focus-expected.txt:
* fast/forms/form-get-multipart-expected.txt:
* fast/forms/form-get-multipart2-expected.txt:
* fast/forms/form-get-multipart3-expected.txt:
* fast/forms/form-post-urlencoded-expected.txt:
* fast/forms/input-appearance-elementFromPoint-expected.txt:
* fast/forms/input-appearance-maxlength-expected.txt:
* fast/forms/input-changing-value-expected.txt:
* fast/forms/input-delete-expected.txt:
* fast/forms/input-selection-hidden-expected.txt:
* fast/forms/input-selection-restore-expected.txt:
* fast/forms/input-text-enter-expected.txt:
* fast/forms/input-truncate-newline-expected.txt:
* fast/forms/legend-access-key-expected.txt:
* fast/forms/onchange-enter-submit-expected.txt:
* fast/forms/onselect-textarea-expected.txt:
* fast/forms/onselect-textfield-expected.txt:
* fast/forms/paste-into-textarea-expected.txt:
* fast/forms/plaintext-mode-1-expected.txt:
* fast/forms/select-remove-option-expected.txt:
* fast/forms/select-replace-option-expected.txt:
* fast/forms/select-reset-expected.txt:
* fast/forms/selection-functions-expected.txt:
* fast/forms/text-field-setvalue-crash-expected.txt:
* fast/forms/textarea-crlf-expected.txt:
* fast/forms/textarea-scrolled-endline-caret-expected.txt:
* fast/forms/textarea-setvalue-submit-expected.txt:
* fast/forms/textfield-focus-out-expected.txt:
WebCore:
Reinstate r15966 because layout test changes are correct.
<rdar://problem/
4522205> Represent controls in AXAttributedStringForTextMarkerRange
* editing/TextIterator.cpp:
(WebCore::TextIterator::advance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 24 Aug 2006 16:25:13 +0000 (16:25 +0000)]
Reviewed by ap.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support (Part II)
Adapt the KCanvas Qt device to Rob's KCanvasMatrix removal.
Use AffineTransform everywhere instead.
* kcanvas/device/qt/KRenderingDeviceQt.cpp:
(WebCore::KRenderingDeviceContextQt::KRenderingDeviceContextQt):
(WebCore::KRenderingDeviceContextQt::concatCTM):
(WebCore::KRenderingDeviceContextQt::ctm):
* kcanvas/device/qt/KRenderingDeviceQt.h:
* kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
(WebCore::KRenderingPaintServerLinearGradientQt::setup):
(WebCore::KRenderingPaintServerRadialGradientQt::setup):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 24 Aug 2006 16:19:20 +0000 (16:19 +0000)]
Reviewed, tweaked and landed by ap
http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support (Part II)
* CMakeLists.txt: Adjust to Anders' build fixes.
* wtf/Platform.h: Fix define for the Qt platform (we don't use/need Cairo.)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Thu, 24 Aug 2006 10:04:16 +0000 (10:04 +0000)]
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10524
svg transform: comma delimiting breaks display
Properly parse transforms which use ',' as seperators.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 24 Aug 2006 07:12:02 +0000 (07:12 +0000)]
Reviewed by Adele.
- fix assertion which I accidentally changed to one that sometimes fails
http://bugzilla.opendarwin.org/show_bug.cgi?id=10531
* Loader/WebDocumentLoadState.m:
(-[WebDocumentLoadState dealloc]):
* WebView/WebDataSource.m:
(-[WebDataSourcePrivate dealloc]):
(-[WebDataSource dealloc]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 24 Aug 2006 06:22:13 +0000 (06:22 +0000)]
Reviewed by Brady.
- move WebFrame code that creates WebDataSources down to WebFrameLoader, in preparation
for WebFrameLoader just holding on to WebDocumentLoadState
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _loadRequest:archive:]):
(-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
(-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
(-[WebFrameLoader reload]):
* WebView/WebFrame.m:
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
(-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
(-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
(-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]):
(-[WebFrame loadRequest:]):
(-[WebFrame loadArchive:]):
(-[WebFrame reload]):
* WebView/WebFrameInternal.h:
* WebView/WebFramePrivate.h:
* WebView/WebView.m:
(-[WebView setCustomTextEncodingName:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Thu, 24 Aug 2006 05:59:33 +0000 (05:59 +0000)]
Reviewed by Maciej
First pass at pruning unused WebIconDatabase code. Focus on removing methods that simply
have no place in the new DB at all. A few renames and a few important FIXMEs result, but no
functionality changes.
* Loader/WebIconLoader.m:
(-[WebIconLoader didFinishLoading]): Call to WebIconDatabase instead of directly to the bridge
* Misc/WebIconDatabase.h:
* Misc/WebIconDatabase.m:
(-[WebIconDatabase init]):
(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconURLForURL:]):
(-[WebIconDatabase defaultIconWithSize:]):
(-[WebIconDatabase retainIconForURL:]):
(-[WebIconDatabase releaseIconForURL:]):
(-[WebIconDatabase removeAllIcons]):
(-[WebIconDatabase _setIconData:forIconURL:]):
(-[WebIconDatabase _setHaveNoIconForIconURL:]):
(-[WebIconDatabase _setIconURL:forURL:]):
(-[WebIconDatabase _hasEntryForIconURL:]):
(-[WebIconDatabase _applicationWillTerminate:]):
(-[WebIconDatabase _resetCachedWebPreferences:]):
* Misc/WebIconDatabasePrivate.h: Changed setIcon: to setIconData:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 24 Aug 2006 04:15:07 +0000 (04:15 +0000)]
Reviewed by Adele.
- started factoring most of the guts of WebDataSource into a new class
WebDocumentLoadState is decoupled from the rest of WebKit and will
be moved down to WebCore. I only moved one of the data fields of
WebDataSource for now.
* Loader/WebDocumentLoadState.h: Added.
* Loader/WebDocumentLoadState.m: Added.
(-[WebDocumentLoadState initWithRequest:]): New class.
(-[WebDocumentLoadState dealloc]):
(-[WebDocumentLoadState setFrameLoader:]):
(-[WebDocumentLoadState setMainResourceData:]):
(-[WebDocumentLoadState mainResourceData]):
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _setDataSource:]): Remove redundant _setWebFrame: call,
it would have been called already by this point.
(-[WebFrameLoader _setProvisionalDataSource:]): ditto.
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebDataSource.m:
(-[WebDataSourcePrivate dealloc]):
(-[WebDataSource _setWebFrame:]):
(-[WebDataSource _setPrimaryLoadComplete:]):
(-[WebDataSource initWithRequest:]):
(-[WebDataSource data]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 24 Aug 2006 01:28:20 +0000 (01:28 +0000)]
Reviewed by Adele.
- refactoring of WebDataSource in preparation for moving a bunch of it to a new class
- minimize WebDataSourceInternal.h to be only methods called from outside WebDataSource
- reduce Private category implementation to be only the SPI methods
- make new Internal and FileInternal categories which contain the
remainder (depending on whether they are called from outside of
WebDataSource)
* WebView/WebDataSource.m:
(-[WebDataSource _setMainDocumentError:]):
(addTypesFromClass):
(+[WebDataSource _representationClassForMIMEType:]):
(-[WebDataSource _commitIfReady]):
(-[WebDataSource _commitLoadWithData:]):
(-[WebDataSource _doesProgressiveLoadWithMIMEType:]):
(-[WebDataSource _addResponse:]):
(-[WebDataSource _revertToProvisionalState]):
(-[WebDataSource _mainDocumentError]):
(-[WebDataSource _addSubframeArchives:]):
(-[WebDataSource _fileWrapperForURL:]):
(+[WebDataSource _repTypesAllowImageTypeOmission:]):
(-[WebDataSource _decidePolicyForMIMEType:decisionListener:]):
(-[WebDataSource _finishedLoading]):
(-[WebDataSource _setResponse:]):
(-[WebDataSource _setRequest:]):
(-[WebDataSource _setupForReplaceByMIMEType:]):
(-[WebDataSource _receivedMainResourceError:complete:]):
(-[WebDataSource _mainReceivedError:complete:]):
(-[WebDataSource _defersCallbacks]):
(-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]):
(-[WebDataSource _didFailLoadingWithError:forResource:]):
(-[WebDataSource _didFinishLoadingForResource:]):
(-[WebDataSource _didReceiveData:contentLength:forResource:]):
(-[WebDataSource _didReceiveResponse:forResource:]):
(-[WebDataSource _didCancelAuthenticationChallenge:forResource:]):
(-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]):
(-[WebDataSource _willSendRequest:forResource:redirectResponse:]):
(-[WebDataSource _identifierForInitialRequest:]):
(-[WebDataSource _archivedSubresourceForURL:]):
(-[WebDataSource _startLoading]):
(-[WebDataSource _stopRecordingResponses]):
(-[WebDataSource _loadingStartedTime]):
(-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]):
(-[WebDataSource _documentFragmentWithArchive:]):
(-[WebDataSource _documentFragmentWithImageResource:]):
(-[WebDataSource _imageElementWithImageResource:]):
(-[WebDataSource _title]):
(-[WebDataSource _isStopping]):
(-[WebDataSource _setWebFrame:]):
(-[WebDataSource _URL]):
(-[WebDataSource _loadFromPageCache:]):
(-[WebDataSource _popSubframeArchiveWithName:]):
(-[WebDataSource _setIsClientRedirect:]):
(-[WebDataSource _setURL:]):
(-[WebDataSource _setLastCheckedRequest:]):
(-[WebDataSource _defersCallbacksChanged]):
(-[WebDataSource _lastCheckedRequest]):
(-[WebDataSource _stopLoading]):
(-[WebDataSource _bridge]):
(-[WebDataSource _webView]):
(-[WebDataSource _triggeringAction]):
(-[WebDataSource _setTriggeringAction:]):
(-[WebDataSource __adoptRequest:]):
(-[WebDataSource _isDocumentHTML]):
(-[WebDataSource _stopLoadingWithError:]):
(-[WebDataSource _setPrimaryLoadComplete:]):
(-[WebDataSource _responses]):
(-[WebDataSource _makeRepresentation]):
(-[WebDataSource _isClientRedirect]):
(-[WebDataSource _originalRequest]):
(-[WebDataSource _URLForHistory]):
(-[WebDataSource _addToUnarchiveState:]):
(-[WebDataSource _setOverrideEncoding:]):
(-[WebDataSource _setIconURL:]):
(-[WebDataSource _setIconURL:withType:]):
(-[WebDataSource _overrideEncoding]):
(-[WebDataSource _setTitle:]):
* WebView/WebDataSourceInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 24 Aug 2006 01:01:04 +0000 (01:01 +0000)]
Fix Mac bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 24 Aug 2006 00:38:57 +0000 (00:38 +0000)]
Reviewed by Maciej.
- added an assert to make it slightly easier to debug the common case of
calling document() on a node of 0
* dom/Node.h: (WebCore::Node::document): ASSERT(this).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 24 Aug 2006 00:04:12 +0000 (00:04 +0000)]
Fix Platform.h to include #defines for graphics features.
Reviewed by darin
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 24 Aug 2006 00:02:51 +0000 (00:02 +0000)]
Refactor Cairo and CoreGraphics to use platform ifdefs. This patch
separates the graphics engines from their respective platforms and replaces
#ifdef PLATFORM(MAC) and PLATFORM(WIN) with PLATFORM(CG) and PLATFORM(CAIRO).
Reviewed by darin
* WebCore.xcodeproj/project.pbxproj:
* platform/AffineTransform.h:
* platform/Color.h:
* platform/Cursor.h:
* platform/FloatPoint.h:
* platform/FloatRect.h:
* platform/FloatSize.h:
* platform/Font.h:
* platform/FontData.h:
* platform/GlyphBuffer.h:
(WebCore::GlyphBuffer::glyphAt):
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::add):
* platform/GraphicsContext.h:
* platform/Image.h:
* platform/ImageSource.h:
* platform/IntPoint.h:
* platform/IntRect.h:
* platform/IntSize.h:
* platform/ResourceLoader.h:
* platform/ResourceLoaderClient.h:
* platform/Widget.h:
* platform/cairo/GraphicsContextCairo.cpp:
* platform/cairo/ImageCairo.cpp:
* platform/cairo/ImageSourceCairo.cpp:
* platform/cg/AffineTransformCG.cpp:
* platform/cg/FloatPointCG.cpp: Added.
* platform/cg/FloatRectCG.cpp: Added.
* platform/cg/FloatSizeCG.cpp: Added.
* platform/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::setFocusRingClip):
(WebCore::GraphicsContext::clearFocusRingClip):
(WebCore::GraphicsContext::platformContext):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
* platform/cg/GraphicsContextPlatformPrivate.h: Added.
(WebCore::GraphicsContextPlatformPrivate:::m_cgContext):
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
* platform/cg/ImageCG.cpp: Added.
(WebCore::Image::drawTiled):
* platform/cg/ImageSourceCG.cpp: Added.
* platform/cg/IntPointCG.cpp: Added.
* platform/cg/IntRectCG.cpp: Added.
* platform/cg/IntSizeCG.cpp: Added.
* platform/cg/PDFDocumentImage.cpp: Added.
(WebCore::PDFDocumentImage::adjustCTM):
* platform/cg/PDFDocumentImage.h: Added.
* platform/cg/PathCG.cpp:
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
* platform/image-decoders/gif/GIFImageDecoder.cpp:
* platform/image-decoders/gif/GIFImageReader.cpp:
* platform/image-decoders/ico/ICOImageDecoder.cpp:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
* platform/image-decoders/png/PNGImageDecoder.cpp:
* platform/image-decoders/xbm/XBMImageDecoder.cpp:
* platform/mac/FloatPointMac.mm:
* platform/mac/FloatRectMac.mm:
* platform/mac/FloatSizeMac.mm:
* platform/mac/GraphicsContextMac.mm:
* platform/mac/ImageMac.mm:
* platform/mac/ImageSourceMac.cpp: Removed.
* platform/mac/IntPointMac.mm:
* platform/mac/IntRectMac.mm:
* platform/mac/IntSizeMac.mm:
* platform/mac/PDFDocumentImage.h: Removed.
* platform/mac/PDFDocumentImage.mm: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 23 Aug 2006 23:46:33 +0000 (23:46 +0000)]
I forgot to check in these expected results yesterday.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 23 Aug 2006 21:36:58 +0000 (21:36 +0000)]
Remove the ifdef for platform scrollbars vs. engine scrollbars until
engine scrollbars actually exist.
* platform/ScrollBar.h:
(WebCore::ScrollBar::hasPlatformScrollBars):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 23 Aug 2006 21:33:18 +0000 (21:33 +0000)]
Reviewed by harrison
Removed the poorly named next/previousVisiblePosition
and use next/previousCandidate and next/previousVisuallyDistinctCandidate.
Removed the unused VisiblePosition::maxOffset()
* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::next):
(WebCore::VisiblePosition::previous):
(WebCore::VisiblePosition::canonicalPosition):
* editing/VisiblePosition.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 23 Aug 2006 21:06:59 +0000 (21:06 +0000)]
Reviewed by John Sullivan
/me crosses fingers
Flip the switch to the new Icon Database
Massive code pruning is coming up
* WebKitPrefix.h: Flipped the switch
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Wed, 23 Aug 2006 21:04:08 +0000 (21:04 +0000)]
Reviewed by Alexey. Landed by rwlbuis.
Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support (Part II)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15994
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 23 Aug 2006 20:48:13 +0000 (20:48 +0000)]
Reviewed by Beth
Since I just pushed the default URL icon from WebKit to WebCore, but
WebKit was still using its version of the default icon, this patch makes it
use the WebCore version
* Misc/WebIconDatabase.m:
(-[WebIconDatabase defaultIconWithSize:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15993
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 23 Aug 2006 19:31:44 +0000 (19:31 +0000)]
Reviewed by Adele
Moved default URL icon from WebKit to WebCore
* Resources/urlIcon.tiff: Added.
* WebCore.xcodeproj/project.pbxproj:
* loader/icon/IconDataCache.cpp:
(WebCore::IconDataCache::loadImageFromResource):
* loader/icon/IconDataCache.h:
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::defaultIcon):
* loader/icon/IconDatabase.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15992
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 23 Aug 2006 18:08:45 +0000 (18:08 +0000)]
Reviewed by Darin, Adele.
Some popup refactoring/cleanup.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::defaultEventHandler):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::~RenderMenuList):
(WebCore::RenderMenuList::showPopup):
(WebCore::RenderMenuList::hidePopup):
* rendering/RenderMenuList.h:
(WebCore::RenderMenuList::popup):
(WebCore::RenderMenuList::popupIsVisible):
* rendering/RenderPopupMenu.h:
* rendering/RenderPopupMenuMac.h:
(WebCore::RenderPopupMenuMac::hidePopup):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15991
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 23 Aug 2006 17:44:10 +0000 (17:44 +0000)]
2006-08-23 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
Make the bindings compile without CoreFoundation.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* bindings/c/c_instance.cpp:
* bindings/c/c_utility.cpp:
(KJS::Bindings::convertUTF8ToUTF16):
* bindings/npapi.h:
* bindings/runtime.cpp:
(KJS::Bindings::Instance::createBindingForLanguageInstance):
(KJS::Bindings::Instance::createLanguageInstanceForValue):
* bindings/runtime_root.cpp:
* bindings/runtime_root.h:
* kjs/interpreter.cpp:
(KJS::Interpreter::createLanguageInstanceForValue):
* kjs/interpreter.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15990
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Wed, 23 Aug 2006 16:18:18 +0000 (16:18 +0000)]
Reviewed by Anders. Landed by rwlbuis.
Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support
Note: StringQt.cpp is not part of the original patch, but was
mistakenly omitted from earlier 10467 patch.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 23 Aug 2006 07:29:45 +0000 (07:29 +0000)]
Reviewed by Maciej
Added escapeSQLString() - a helper to escape strings to be used in textual SQL queries
* WebCore.xcodeproj/project.pbxproj: Reordered some files
* loader/icon/IconDataCache.cpp: Use the new escapeSQLString()
(WebCore::IconDataCache::writeToDatabase):
* loader/icon/IconDatabase.cpp: Use the new escapeSQLString() throughout
(WebCore::IconDatabase::retainIconURL):
(WebCore::IconDatabase::releaseIconURL):
(WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
(WebCore::IconDatabase::establishIconIDForIconURL):
(WebCore::imageDataForIconURLQuery):
(WebCore::timeStampForIconURLQuery):
(WebCore::iconURLForPageURLQuery):
(WebCore::forgetPageURLQuery):
(WebCore::setIconIDForPageURLQuery):
(WebCore::getIconIDForIconURLQuery):
(WebCore::addIconForIconURLQuery):
(WebCore::hasIconForIconURLQuery):
* loader/icon/SQLDatabase.h:
(WebCore::escapeSQLString): Added
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 23 Aug 2006 06:59:52 +0000 (06:59 +0000)]
Reviewed by Brady.
- remove "loading" flag from WebDataSource and code that manages it; it is redundat.
* Loader/WebFrameLoader.m:
(-[WebFrameLoader addPlugInStreamLoader:]):
(-[WebFrameLoader removePlugInStreamLoader:]):
(-[WebFrameLoader addSubresourceLoader:]):
(-[WebFrameLoader removeSubresourceLoader:]):
* WebView/WebDataSource.m:
(-[WebDataSourcePrivate dealloc]):
(-[WebDataSource _setPrimaryLoadComplete:]):
(-[WebDataSource _stopLoading]):
(-[WebDataSource _prepareForLoadStart]):
(-[WebDataSource _startLoading]):
(-[WebDataSource isLoading]):
* WebView/WebDataSourceInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15986
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 23 Aug 2006 06:50:38 +0000 (06:50 +0000)]
Reviewed by Brady.
- assorted style cleanup of icon loader code:
- wrapped all implementation files in namespace WebCore {} instead of "using namespace WebCore;" at top
- split headers to be one per class, to match impl files
- made files that are purely local in IconDatabase.cpp static
- make each impl file include config.h as first header (and no config.h includes in other headers)
- avoid multiple copies of Vector<unsigned char> for image data
* WebCore.xcodeproj/project.pbxproj:
* loader/icon/IconDataCache.cpp:
* loader/icon/IconDataCache.h: Added.
(WebCore::):
(WebCore::IconDataCache::getTimestamp):
(WebCore::IconDataCache::setTimestamp):
(WebCore::IconDataCache::getIconURL):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::imageDataForIconURL):
(WebCore::IconDatabase::iconForPageURL):
(WebCore::pageURLTableIsEmptyQuery):
(WebCore::imageDataForIconURLQuery):
(WebCore::timeStampForIconURLQuery):
(WebCore::iconURLForPageURLQuery):
(WebCore::forgetPageURLQuery):
(WebCore::setIconIDForPageURLQuery):
(WebCore::getIconIDForIconURLQuery):
(WebCore::addIconForIconURLQuery):
(WebCore::hasIconForIconURLQuery):
* loader/icon/IconDatabase.h:
* loader/icon/SQLDatabase.cpp:
* loader/icon/SQLDatabase.h:
* loader/icon/SQLStatement.cpp:
(WebCore::SQLStatement::getColumnBlobAsVector):
* loader/icon/SQLStatement.h: Added.
(WebCore::SQLStatement::isPrepared):
(WebCore::SQLStatement::prepareAndStep):
(WebCore::SQLStatement::lastError):
(WebCore::SQLStatement::lastErrorMsg):
* loader/icon/SQLTransaction.cpp:
* loader/icon/SQLTransaction.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
trey [Wed, 23 Aug 2006 06:05:06 +0000 (06:05 +0000)]
Reviewed by NOBODY
This test update was missing from the patch I posted, and ggarren just checked in.
* fast/overflow/scrollRevealButton-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15984
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 23 Aug 2006 06:01:09 +0000 (06:01 +0000)]
Reviewed by Maciej
The role of the SiteIcon is now the original intention - to be a cache of data relating to an Icon
As such, I'm renaming it to IconDataCache.
Also, the IconDatabase has to manually set the image data on the IconDataCache and also sets the
TimeStamp when an icon is created or the data is changed.
IconDataCache now has a method to write itself *to* a given database, instead of read itself from one.
IconDatabase schema changes to have the timestamp set manually instead of via a trigger.
The overall purpose of this change is to cache the timestamp, killing off a very common SQL query.
* WebCore.xcodeproj/project.pbxproj: Renamed a file
* loader/icon/IconDataCache.cpp: Added.
(IconDataCache::IconDataCache):
(IconDataCache::getImage): Now either returns the stored image, or 0 - no attempt to grab data
(IconDataCache::manuallySetImageData): Delete the old image and create the new one
(IconDataCache::writeToDatabase): Write the current iconURL, data, and timestamp to the given DB
(IconDataCache::imageDataStatus): Determine if an IconDataCache is new without data versus actually having null data
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::createDatabaseTables): Changed DB schema to version 5 (hopefully the final version)
(WebCore::IconDatabase::iconForPageURL):
(WebCore::IconDatabase::isIconExpiredForIconURL): Uses the timestamp in the IconDataCache object instead of always querying
(WebCore::IconDatabase::getOrCreateIconDataCache): Added, to handle creation of new IconDataCache when appropriate
(WebCore::IconDatabase::setIconDataForIconURL): Puts data in SiteIcon then marks it for a future write
(WebCore::IconDatabase::syncDatabase): Now syncs SiteIconsPendingUpdate
* loader/icon/IconDatabase.h:
(WebCore::IconDataCache::getTimestamp):
(WebCore::IconDataCache::setTimestamp):
* loader/icon/SiteIcon.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 23 Aug 2006 05:49:04 +0000 (05:49 +0000)]
LayoutTests:
Reviewed by Eric.
- test for <rdar://problem/
4683948> REGRESSION: Assertion failure in [FrameProgressEntry addChild:forDataSource:] (fandango.com)
(I both added a WebKit assertion that would fail under this test, and then did a fix to make it not fire)
* fast/loader/start-load-in-unload-expected.txt: Added.
* fast/loader/start-load-in-unload.html: Added.
WebKit:
Reviewed by Eric.
<rdar://problem/
4683948> REGRESSION: Assertion failure in [FrameProgressEntry addChild:forDataSource:] (fandango.com)
* Loader/WebFrameLoader.m:
(-[WebFrameLoader addSubresourceLoader:]): Add a WebKit-level assertion that should fire when this bad
situation occurs.
* Loader/WebSubresourceLoader.m:
(+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): Prevent
the situation from occuring.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 23 Aug 2006 05:37:03 +0000 (05:37 +0000)]
Fix for broken tests.
- made newly added CGI scripts executable
* http/tests/navigation/resources/error404.pl:
* http/tests/navigation/resources/frameset.pl:
* http/tests/navigation/resources/postresult.pl:
* http/tests/navigation/resources/redirect302.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 23 Aug 2006 02:32:35 +0000 (02:32 +0000)]
Forgot to check this in in the previous commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 23 Aug 2006 00:47:01 +0000 (00:47 +0000)]
LayoutTests:
Reviewed by harrison
<http://bugzilla.opendarwin.org/show_bug.cgi?id=10449>
REGRESSION(r15918): drag-into-marker.html failing
* editing/pasteboard/paste-list-001-expected.txt:
* fast/lists/drag-into-marker.html: Added.
* fast/lists/drag-into-marker.html-disabled: Removed.
WebCore:
Reviewed by harrison
<http://bugzilla.opendarwin.org/show_bug.cgi?id=10449>
REGRESSION(r15918): drag-into-marker.html failing
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Don't avoid nesting
in a list item.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 23 Aug 2006 00:42:04 +0000 (00:42 +0000)]
Reviewed by Kevin
Added a check in getTIFFRepresentation to not proceed if the frame count is zero
This is an error condition that was handled gracefully before - in certain circumstances
the call to CGImageDestinationCreateWithData will spam the Console if it is passed null/empty data
or invalid data. This small change bails out before that call if that call will definitely fail
* platform/mac/ImageMac.mm:
(WebCore::Image::getTIFFRepresentation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Wed, 23 Aug 2006 00:23:50 +0000 (00:23 +0000)]
Backed out my last change (r15966) because it broke lots of layout tests.
* editing/TextIterator.cpp:
(WebCore::TextIterator::advance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 23 Aug 2006 00:09:28 +0000 (00:09 +0000)]
WebCore:
Reviewed by Anders.
- added some SPI indirections to support the following in WebKit/Loader:
- pull more WebDataSource code into WebFrameLoader
- make WebMainResourceLoader not depend on WebKit or on SPI
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
WebKit:
Reviewed by Anders.
- pull more WebDataSource code into WebFrameLoader
- make WebMainResourceLoader not depend on WebKit or on SPI
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
(-[WebFrameLoader _updateIconDatabaseWithURL:]):
(-[WebFrameLoader _notifyIconChanged:]):
(-[WebFrameLoader _iconLoaderReceivedPageIcon:]):
(-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
(-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
(-[WebFrameLoader cancelContentPolicy]):
* Loader/WebIconLoader.m:
(-[WebIconLoader didFinishLoading]):
* Loader/WebLoader.m:
(-[NSURLProtocol loadWithRequest:]):
(-[NSURLProtocol setDefersCallbacks:]):
* Loader/WebMainResourceLoader.h:
* Loader/WebMainResourceLoader.m:
(-[WebMainResourceLoader initWithFrameLoader:]):
(-[WebMainResourceLoader dealloc]):
(-[WebMainResourceLoader cancelWithError:]):
(-[WebMainResourceLoader continueAfterNavigationPolicy:formState:]):
(-[WebMainResourceLoader willSendRequest:redirectResponse:]):
(-[WebMainResourceLoader continueAfterContentPolicy:]):
(-[WebMainResourceLoader checkContentPolicy]):
(-[WebMainResourceLoader didReceiveResponse:]):
* Plugins/WebPluginContainerCheck.m:
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
* WebView/WebDataSource.m:
(-[WebDataSource _loadIcon]):
(-[WebDataSource _cancelledError]):
(+[WebDataSource _repTypesAllowImageTypeOmission:]):
(+[WebDataSource _representationClassForMIMEType:]):
(-[WebDataSource _commitLoadWithData:]):
(-[WebDataSource _isDocumentHTML]):
* WebView/WebDataSourceInternal.h:
* WebView/WebFramePrivate.h:
* WebView/WebPolicyDelegate.m:
* WebView/WebPolicyDelegatePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 22 Aug 2006 22:59:18 +0000 (22:59 +0000)]
LayoutTests:
Reviewed by harrison
<rdar://problem/
4052343&
4052343&
4426622> Mail hung on paste text
Bugs exposed:
* editing/pasteboard/paste-
4039777-fix-expected.checksum:
* editing/pasteboard/paste-
4039777-fix-expected.png:
* editing/pasteboard/paste-
4039777-fix-expected.txt:
* editing/deleting/delete-
3857753-fix-expected.txt:
* editing/pasteboard/styled-element-markup-expected.checksum:
* editing/pasteboard/styled-element-markup-expected.png:
* editing/pasteboard/styled-element-markup-expected.txt:
* editing/execCommand/insertHTML-expected.checksum:
* editing/execCommand/insertHTML-expected.png:
* editing/execCommand/insertHTML-expected.txt:
* editing/execCommand/insertHTML.html:
Removed some empty style spans, font tags are replaced by style spans
in a couple of cases:
* editing/deleting/merge-different-styles-expected.txt:
* editing/deleting/pruning-after-merge-1-expected.txt:
* editing/deleting/pruning-after-merge-2-expected.txt:
* editing/inserting/insert-
3786362-fix-expected.txt:
* editing/pasteboard/block-wrappers-necessary-expected.txt:
* editing/pasteboard/display-block-on-spans-expected.txt:
* editing/pasteboard/merge-end-table-expected.txt:
* editing/pasteboard/paste-
4035648-fix-expected.txt:
* editing/pasteboard/paste-line-endings-001-expected.txt:
* editing/pasteboard/paste-line-endings-006-expected.txt:
* editing/pasteboard/paste-list-001-expected.txt:
* editing/pasteboard/paste-pre-001-expected.txt:
* editing/pasteboard/paste-pre-002-expected.txt:
* editing/pasteboard/paste-table-001-expected.txt:
* editing/pasteboard/paste-table-002-expected.txt:
* editing/pasteboard/paste-text-001-expected.txt:
* editing/pasteboard/paste-text-002-expected.txt:
* editing/pasteboard/paste-text-003-expected.txt:
* editing/pasteboard/paste-text-004-expected.txt:
* editing/pasteboard/paste-text-005-expected.txt:
* editing/pasteboard/paste-text-006-expected.txt:
* editing/pasteboard/paste-text-011-expected.txt:
* editing/pasteboard/paste-text-012-expected.txt:
* editing/pasteboard/paste-text-013-expected.txt:
* editing/pasteboard/paste-text-014-expected.txt:
* editing/pasteboard/paste-text-015-expected.txt:
* editing/pasteboard/paste-text-016-expected.txt:
* editing/pasteboard/paste-text-017-expected.txt:
* editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
* editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
* editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
* editing/pasteboard/styled-element-markup.html:
* editing/pasteboard/testcase-9507-expected.txt:
* editing/style/smoosh-styles-001-expected.txt:
* editing/style/smoosh-styles-002-expected.txt:
WebCore:
Reviewed by harrison
<rdar://problem/
4052343&
4052343&
4426622> Mail hung on paste text
* editing/ReplaceSelectionCommand.cpp:
(WebCore::isInterchangeNewlineNode):
(WebCore::isInterchangeConvertedSpaceSpan):
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplaceSelectionCommand::removeRedundantStyles): Compute the redundant inheritable styles and
remove them and remove style nodes and style spans which were only contributing redundant styles.
(WebCore::ReplaceSelectionCommand::doApply):
* editing/ReplaceSelectionCommand.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 22 Aug 2006 21:05:47 +0000 (21:05 +0000)]
2006-08-22 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
Move the npruntime code over to using HashMap and the runtime_root code over to using
HashMap and HashCountedSet.
* bindings/NP_jsobject.cpp:
* bindings/c/c_utility.cpp:
(KJS::Bindings::identifierFromNPIdentifier):
* bindings/c/c_utility.h:
* bindings/jni/jni_jsobject.cpp:
(JavaJSObject::invoke):
* bindings/npruntime.cpp:
(getStringIdentifierMap):
(getIntIdentifierMap):
(_NPN_GetStringIdentifier):
(_NPN_GetIntIdentifier):
* bindings/runtime_root.cpp:
(getReferencesByRootMap):
(getReferencesSet):
(KJS::Bindings::findReferenceSet):
(KJS::Bindings::rootForImp):
(KJS::Bindings::rootForInterpreter):
(KJS::Bindings::addNativeReference):
(KJS::Bindings::removeNativeReference):
(RootObject::removeAllNativeReferences):
* bindings/runtime_root.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 22 Aug 2006 20:59:19 +0000 (20:59 +0000)]
Reviewed by Darin.
<rdar://problem/
4077676> Inline hole line adheres to the Japanese characters in inline hole
This happens because the underline is always 2 pixels thick, and placed 3 pixels above the bottom of the text box.
Test case added:
* manual-tests/inline-input-marking.html: Added.
Check that underlining of the inline input hole does not obscure the glyphs.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintMarkedTextUnderline):
Position underline at bottom of text box.
Height of underline is reduced to 1 px when font's descent is less than or equal to 2 px.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 22 Aug 2006 20:23:08 +0000 (20:23 +0000)]
LayoutTests:
Reviewed by ggaren.
Introducing a small test suite for bugs related to various navigation techniques,
e.g., back/forward, reload, various redirect flavors, POST, POST-then-redirect,
within-page anchors. Most of the tests are done with and without an enclosing frameset.
The tests verify the content of the final page (which may include restored form
state), scroll location (also sometimes restored), and the full content of the
back-forward list.
* fast/overflow/scrollRevealButton-expected.txt:
Updated to include scroll location that is now emitted.
* http/tests/navigation/anchor-basic-expected.txt: Added.
* http/tests/navigation/anchor-basic.html: Added.
* http/tests/navigation/anchor-frames-expected.txt: Added.
* http/tests/navigation/anchor-frames.html: Added.
* http/tests/navigation/anchor-goback-expected.txt: Added.
* http/tests/navigation/anchor-goback.html: Added.
* http/tests/navigation/anchor-subframeload-expected.txt: Added.
* http/tests/navigation/anchor-subframeload.html: Added.
* http/tests/navigation/error404-basic-expected.txt: Added.
* http/tests/navigation/error404-basic.html: Added.
* http/tests/navigation/error404-frames-expected.txt: Added.
* http/tests/navigation/error404-frames.html: Added.
* http/tests/navigation/error404-goback-expected.txt: Added.
* http/tests/navigation/error404-goback.html: Added.
* http/tests/navigation/error404-subframeload-expected.txt: Added.
* http/tests/navigation/error404-subframeload.html: Added.
* http/tests/navigation/javascriptlink-basic-expected.txt: Added.
* http/tests/navigation/javascriptlink-basic.html: Added.
* http/tests/navigation/javascriptlink-frames-expected.txt: Added.
* http/tests/navigation/javascriptlink-frames.html: Added.
* http/tests/navigation/javascriptlink-goback-expected.txt: Added.
* http/tests/navigation/javascriptlink-goback.html: Added.
* http/tests/navigation/javascriptlink-subframeload-expected.txt: Added.
* http/tests/navigation/javascriptlink-subframeload.html: Added.
* http/tests/navigation/metaredirect-basic-expected.txt: Added.
* http/tests/navigation/metaredirect-basic.html: Added.
* http/tests/navigation/metaredirect-frames-expected.txt: Added.
* http/tests/navigation/metaredirect-frames.html: Added.
* http/tests/navigation/metaredirect-goback-expected.txt: Added.
* http/tests/navigation/metaredirect-goback.html: Added.
* http/tests/navigation/metaredirect-subframeload-expected.txt: Added.
* http/tests/navigation/metaredirect-subframeload.html: Added.
* http/tests/navigation/post-basic-expected.txt: Added.
* http/tests/navigation/post-basic.html: Added.
* http/tests/navigation/post-frames-expected.txt: Added.
* http/tests/navigation/post-frames-goback1.html-disabled: Added.
* http/tests/navigation/post-frames.html: Added.
* http/tests/navigation/post-goback1-expected.txt: Added.
* http/tests/navigation/post-goback1.html: Added.
* http/tests/navigation/post-goback2-expected.txt: Added.
* http/tests/navigation/post-goback2.html: Added.
* http/tests/navigation/postredirect-basic-expected.txt: Added.
* http/tests/navigation/postredirect-basic.html: Added.
* http/tests/navigation/postredirect-frames-expected.txt: Added.
* http/tests/navigation/postredirect-frames-goback1.html-disabled: Added.
* http/tests/navigation/postredirect-frames.html: Added.
* http/tests/navigation/postredirect-goback1-expected.txt: Added.
* http/tests/navigation/postredirect-goback1.html: Added.
* http/tests/navigation/postredirect-goback2-expected.txt: Added.
* http/tests/navigation/postredirect-goback2.html: Added.
* http/tests/navigation/redirect302-basic-expected.txt: Added.
* http/tests/navigation/redirect302-basic.html: Added.
* http/tests/navigation/redirect302-frames-expected.txt: Added.
* http/tests/navigation/redirect302-frames.html: Added.
* http/tests/navigation/redirect302-goback-expected.txt: Added.
* http/tests/navigation/redirect302-goback.html: Added.
* http/tests/navigation/redirect302-subframeload-expected.txt: Added.
* http/tests/navigation/redirect302-subframeload.html: Added.
* http/tests/navigation/relativeanchor-basic-expected.txt: Added.
* http/tests/navigation/relativeanchor-basic.html: Added.
* http/tests/navigation/relativeanchor-frames-expected.txt: Added.
* http/tests/navigation/relativeanchor-frames.html: Added.
* http/tests/navigation/relativeanchor-goback-expected.txt: Added.
* http/tests/navigation/relativeanchor-goback.html: Added.
* http/tests/navigation/resources/error404.pl: Added.
* http/tests/navigation/resources/frameset.pl: Added.
* http/tests/navigation/resources/javascriptlink.html: Added.
* http/tests/navigation/resources/metaredirect.html: Added.
* http/tests/navigation/resources/otherpage.html: Added.
* http/tests/navigation/resources/postresult.pl: Added.
* http/tests/navigation/resources/redirect302.pl: Added.
* http/tests/navigation/resources/slowmetaredirect.html: Added.
* http/tests/navigation/resources/slowtimerredirect.html: Added.
* http/tests/navigation/resources/success200.html: Added.
* http/tests/navigation/resources/testcode.js: Added.
* http/tests/navigation/resources/timerredirect.html: Added.
* http/tests/navigation/slowmetaredirect-basic-expected.txt: Added.
* http/tests/navigation/slowmetaredirect-basic.html: Added.
* http/tests/navigation/slowtimerredirect-basic-expected.txt: Added.
* http/tests/navigation/slowtimerredirect-basic.html: Added.
* http/tests/navigation/success200-basic-expected.txt: Added.
* http/tests/navigation/success200-basic.html: Added.
* http/tests/navigation/success200-frames-expected.txt: Added.
* http/tests/navigation/success200-frames-goback.html-disabled: Added.
* http/tests/navigation/success200-frames-loadsame-expected.txt: Added.
* http/tests/navigation/success200-frames-loadsame.html: Added.
* http/tests/navigation/success200-frames-reload.html-disabled: Added.
* http/tests/navigation/success200-frames.html: Added.
* http/tests/navigation/success200-goback-expected.txt: Added.
* http/tests/navigation/success200-goback.html: Added.
* http/tests/navigation/success200-loadsame-expected.txt: Added.
* http/tests/navigation/success200-loadsame.html: Added.
* http/tests/navigation/success200-reload-expected.txt: Added.
* http/tests/navigation/success200-reload.html: Added.
* http/tests/navigation/success200-subframeload-expected.txt: Added.
* http/tests/navigation/success200-subframeload-goback.html-disabled: Added.
* http/tests/navigation/success200-subframeload.html: Added.
* http/tests/navigation/timerredirect-basic-expected.txt: Added.
* http/tests/navigation/timerredirect-basic.html: Added.
* http/tests/navigation/timerredirect-frames-expected.txt: Added.
* http/tests/navigation/timerredirect-frames.html: Added.
* http/tests/navigation/timerredirect-goback-expected.txt: Added.
* http/tests/navigation/timerredirect-goback.html: Added.
* http/tests/navigation/timerredirect-subframeload-expected.txt: Added.
* http/tests/navigation/timerredirect-subframeload.html: Added.
WebKitTools:
Reviewed by ggaren.
Added support for a new set of browser navigation tests. The main feature
is the ability for a test to queue up a set of future actions that will
happen after that first page is loaded. This is used to simulate a sequence
of user actions such as filling out forms, loading additional pages or
going back. In addition we can now dump out the state of the back/forward
list, and the scroll position is dumped if not at 0,0.
* DumpRenderTree/DumpRenderTree.m:
(main): Init new state
(compareHistoryItems): New utility to support sorting.
(dumpHistoryItem): Write out a WebHistoryItem and kids.
(dumpFrameScrollPosition): Write out the scroll position.
(dump): Optionally write b/f list or scroll position.
(-[WaitUntilDoneDelegate processWork:]): Perform queued work.
(-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]):
Kick off any queued actions. Fixed for the case of loads started in
a subframe instead of the root frame.
(-[WaitUntilDoneDelegate webView:didStartProvisionalLoadForFrame:]):
Grab the topmost frame that is being loaded. Do this as early as possible,
instead of in didCommitLoadForFrame.
(-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]):
Noting a load has started now happens in previous method.
(+[LayoutTestController isSelectorExcludedFromWebScript:]): Boilerplate
(+[LayoutTestController webScriptNameForSelector:]): Boilerplate
(-[LayoutTestController notifyDone]): readyToDump var is subsumed by
topFrameLoading
(-[LayoutTestController dumpBackForwardList]): New impl, just set a bit.
(-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
Add new work to the queue.
(-[LayoutTestController _doLoad:target:]): Do a queued load.
(-[LayoutTestController _doBackOrForwardNav:]): Do a queued back/forward.
(-[LayoutTestController scheduleBackNav:]): Ways for scripts to queue actions
(-[LayoutTestController scheduleForwardNav:]):
(-[LayoutTestController scheduleReload]):
(-[LayoutTestController scheduleScript:]):
(-[LayoutTestController scheduleLoad:target:]):
(runTest): Clear new state for each test. Renamed from "dumpRenderTree"
since it's not one of the functions that does any dumping.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 22 Aug 2006 19:45:25 +0000 (19:45 +0000)]
2006-08-22 Anders Carlsson <acarlsson@apple.com>
Reviewed by Geoff.
Switch over the NPAPI and Java bindings to using HashMaps instead of dictionaries.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bindings/c/c_class.cpp:
(KJS::Bindings::CClass::CClass):
(KJS::Bindings::CClass::~CClass):
(KJS::Bindings::CClass::classForIsA):
(KJS::Bindings::CClass::methodsNamed):
(KJS::Bindings::CClass::fieldNamed):
* bindings/c/c_class.h:
* bindings/jni/jni_class.cpp:
(JavaClass::JavaClass):
(JavaClass::~JavaClass):
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):
* bindings/jni/jni_class.h:
* bindings/objc/objc_class.h:
* bindings/objc/objc_class.mm:
(KJS::Bindings::deleteMethod):
(KJS::Bindings::deleteField):
(KJS::Bindings::):
(KJS::Bindings::ObjcClass::methodsNamed):
(KJS::Bindings::ObjcClass::fieldNamed):
* bindings/runtime.cpp:
* bindings/runtime.h:
* bindings/runtime_object.cpp:
(RuntimeObjectImp::fieldGetter):
(RuntimeObjectImp::getOwnPropertySlot):
(RuntimeObjectImp::put):
(RuntimeObjectImp::canPut):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Tue, 22 Aug 2006 18:56:33 +0000 (18:56 +0000)]
Reviewed by Eric.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10402
REPRO: SVG crashes inside gradient code
Make sure we do not try to update the canvas resource/gradient paintserver when it is not yet built.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 22 Aug 2006 17:28:07 +0000 (17:28 +0000)]
Reviewed by John.
<rdar://problem/
4523606> Represent heading elements in AXAttributedStringForTextMarkerRange
* bridge/mac/WebCoreAXObject.mm:
(headingLevel):
(-[WebCoreAXObject headingLevel]):
(-[WebCoreAXObject isHeading]):
New. Heading level is per the tag (h1 == 1, h2 == 2, etc.)
(-[WebCoreAXObject role]):
(-[WebCoreAXObject roleDescription]):
Add role and roleDescription for headings.
(-[WebCoreAXObject value]):
Value is the headingLevel.
(AXAttributeStringSetHeadingLevel):
(AXAttributedStringAppendText):
Put text's heading level (if applicable) in the attributes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 22 Aug 2006 17:24:54 +0000 (17:24 +0000)]
Reviewed by John.
<rdar://problem/
4522205> Represent controls in AXAttributedStringForTextMarkerRange
Treat controls as replaced elements, so that AXAttributedStringForTextMarkerRange will, too.
* editing/TextIterator.cpp:
(WebCore::TextIterator::advance):
Include controls.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 22 Aug 2006 12:47:26 +0000 (12:47 +0000)]
Reviewed by Maciej.
<rdar://problem/
4407336> Some non-text elements return AXTextMarkerRangeForUIElement with equal start and end marker
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject textMarkerRange]):
Use 0 and maxDeepOffset(), instead of caretMinOffset() and caretMaxRenderedOffset().
Check for VisiblePositions being equal. If so, adjust end one to its next().
That happens with, e.g., buttons.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Tue, 22 Aug 2006 11:13:21 +0000 (11:13 +0000)]
Reviewed by Eric.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10491
KCanvasMatrix removal
Remove KCanvasMatrix from project, using AffineTransform instead.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Tue, 22 Aug 2006 08:20:13 +0000 (08:20 +0000)]
Reviewed by Eric.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10405
REPRO: SVG Maze crashes in RenderPath code
Do not render a path when it is empty so maze15.svg does not crash anymore.
Also get rid of a runtime warning issued by CGContextGetPathBoundingBox.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 22 Aug 2006 07:22:00 +0000 (07:22 +0000)]
Reviewed by Brady.
- move more code from WebDataSource to WebFrameLoader
Also marked a few more methods in WebDataSource as likely MOVABLE in a future round, since they do not
use any of WebDataSource's private data.
* Loader/WebFrameLoader.h:
* Loader/WebFrameLoader.m:
(-[WebFrameLoader addPlugInStreamLoader:]):
(-[WebFrameLoader removePlugInStreamLoader:]):
(-[WebFrameLoader addSubresourceLoader:]):
(-[WebFrameLoader removeSubresourceLoader:]):
(-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
(-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
(-[WebFrameLoader _didReceiveResponse:forResource:]):
(-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
(-[WebFrameLoader _didFinishLoadingForResource:]):
(-[WebFrameLoader _didFailLoadingWithError:forResource:]):
(-[WebFrameLoader _privateBrowsingEnabled]):
(-[WebFrameLoader _finishedLoadingResource]):
(-[WebFrameLoader _receivedError:]):
(-[WebFrameLoader _finishedLoading]):
* Loader/WebMainResourceLoader.m:
(-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
(-[WebMainResourceLoader didFinishLoading]):
* Loader/WebNetscapePlugInStreamLoader.m:
(-[WebNetscapePlugInStreamLoader didFinishLoading]):
(-[WebNetscapePlugInStreamLoader didFailWithError:]):
(-[WebNetscapePlugInStreamLoader cancelWithError:]):
* Loader/WebSubresourceLoader.m:
(+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
(-[WebSubresourceLoader signalFinish]):
(-[WebSubresourceLoader didFailWithError:]):
(-[WebSubresourceLoader cancel]):
* Plugins/WebNetscapePluginStream.m:
(-[WebNetscapePluginStream start]):
* WebView/WebDataSource.m:
(-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]):
(-[WebDataSource _updateIconDatabaseWithURL:]):
(-[WebDataSource _loadIcon]):
(-[WebDataSource _setPrimaryLoadComplete:]):
(-[WebDataSource _cancelledError]):
(+[WebDataSource _repTypesAllowImageTypeOmission:]):
(+[WebDataSource _representationClassForMIMEType:]):
(-[WebDataSource _commitLoadWithData:]):
(-[WebDataSource _receivedMainResourceError:complete:]):
(-[WebDataSource _iconLoaderReceivedPageIcon:]):
(-[WebDataSource _isDocumentHTML]):
* WebView/WebDataSourceInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 22 Aug 2006 07:08:01 +0000 (07:08 +0000)]
Reviewed by Maciej
<rdar://
4690949> - New IconDB: Need to prune unretained icons on startup
Added a flag to track whether or not the initial pruning has taken place on startup
If that flag is not set, IconURL retain counts will be tracked in a temporary db table
in addition to the in-memory hash. Then when the timer fires after initial retains
are complete, we prune those icons not in the retain table, prune dangling PageURL
references, delete the temporary table, and set the flag - and carry on as normal
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase): initialize the flag
(WebCore::IconDatabase::open): changed the schema of the temporary table
(WebCore::IconDatabase::retainIconURL): store the icon retain to the temp table if starting up
(WebCore::IconDatabase::releaseIconURL): ditto
(WebCore::IconDatabase::pruneUnretainedIconsOnStartup): remove all icons *not* in the retain table, then
wipe all the PageURLs who no longer point to a valid IconURL
* loader/icon/IconDatabase.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 22 Aug 2006 04:32:02 +0000 (04:32 +0000)]
Reviewed by Eric.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10419
XSLTProcessor transformToFragment fails because of an XML declaration
Test: fast/xsl/transformToFragment-XML-declaration.html
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::transformToString): Always inhibit XML declaration printout.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 22 Aug 2006 00:51:35 +0000 (00:51 +0000)]
Reviewed by Justin.
<rdar://problem/
4471481> Represent misspellings in AXAttributedStringForTextMarkerRange
Added support for the NSAccessibilityMisspelledTextAttribute.
Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...
<rdar://problem/
4256882> Need automated testing support for accessibility APIs
* bridge/mac/WebCoreAXObject.mm:
Lots of trivial formatting in many methods.
(-[WebCoreAXObject accessibilityAttributeValue:]):
Fixed AXStartTextMarker and AXEndTextMarker to use startOfDocument and endOfDocument, instead of
of positionForCoordinates. I had seen erroneous endOfDocument results while testing the spelling
attribute.
(WebCore::AXAttributeStringSetSpelling):
New. Adds the NSAccessibilityMisspelledTextAttribute for misspelled words.
(-[WebCoreAXObject AXAttributedStringAppendText:]):
Added call to AXAttributeStringSetSpelling.
* editing/visible_units.cpp:
(WebCore::startOfDocument):
(WebCore::endOfDocument):
Added for AXStartTextMarker/AXEndTextMarker fix, these forms of the familiar functions take a Node*,
so a previously existing VisiblePosition is not required.
* editing/visible_units.h:
Declare new forms of startOfDocument and endOfDocument.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 22 Aug 2006 00:16:49 +0000 (00:16 +0000)]
Reviewed by Darin.
Bug 9302: WebKit nightly download image says ~2.5 MB when
universal binaries make it ~5.0 MB
http://bugzilla.opendarwin.org/show_bug.cgi?id=9302
* images/download.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 21 Aug 2006 23:35:19 +0000 (23:35 +0000)]
Stamped by Maciej.
Changes many opendarwin.org links to the proper webkit.org version.
* blog/wp-content/themes/webkit/sidebar.php:
* blog/wp-content/themes/webkit/style.css:
* building/build.html:
* coding/contributing.html:
* contact.html:
* index.html:
* nav.inc:
* projects/compat/hitlist.html:
* projects/css/index.html:
* projects/editing/index.html:
* projects/forms/index.html:
* projects/html/index.html:
* projects/javascript/index.html:
* projects/svg/index.html:
* projects/svg/svg-status.xsl:
* projects/xslt/index.html:
* quality/bugpriorities.html:
* quality/bugzilla.html:
* quality/leakhunting.html:
* quality/lifecycle.html:
* quality/reporting.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 21 Aug 2006 23:26:15 +0000 (23:26 +0000)]
Reviewed by Eric.
Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support
* platform/qt/TemporaryLinkStubs.cpp: Added.
(JavaAppletWidget::JavaAppletWidget):
(Font::selectionRectForComplexText):
(Font::offsetForPositionForComplexText):
(WebCore::refreshPlugins):
(WebCore::focusRingColor):
(Image::drawTiled):
(WebCore::TextField::selectAll):
(WebCore::TextField::addSearchResult):
(WebCore::TextField::selectionStart):
(WebCore::TextField::hasSelectedText):
(WebCore::TextField::selectedText):
(WebCore::TextField::setAutoSaveName):
(WebCore::TextField::checksDescendantsForFocus):
(WebCore::TextField::setSelection):
(WebCore::TextField::setMaxResults):
(WebCore::TextField::edited):
(WebCore::TextField::focusPolicy):
(WebCore::TextField::TextField):
(WebCore::TextField::~TextField):
(WebCore::TextField::setFont):
(WebCore::TextField::setAlignment):
(WebCore::TextField::setWritingDirection):
(WebCore::TextField::maxLength):
(WebCore::TextField::setMaxLength):
(WebCore::TextField::text):
(WebCore::TextField::setText):
(WebCore::TextField::cursorPosition):
(WebCore::TextField::setCursorPosition):
(WebCore::TextField::setEdited):
(WebCore::TextField::setReadOnly):
(WebCore::TextField::setPlaceholderString):
(WebCore::TextField::setColors):
(WebCore::TextField::sizeForCharacterWidth):
(WebCore::TextField::baselinePosition):
(WebCore::TextField::setLiveSearch):
(WebCore::Slider::Slider):
(WebCore::Slider::sizeHint):
(WebCore::Slider::~Slider):
(WebCore::Slider::setValue):
(WebCore::Slider::setMaxValue):
(WebCore::Slider::setMinValue):
(WebCore::Slider::setFont):
(WebCore::Slider::value):
(WebCore::Slider::focusPolicy):
(WebCore::ScrollBar::ScrollBar):
(WebCore::ScrollBar::setSteps):
(WebCore::ScrollBar::scroll):
(WebCore::ScrollBar::setValue):
(WebCore::ScrollBar::setKnobProportion):
(WebCore::PlatformScrollBar::PlatformScrollBar):
(WebCore::PlatformScrollBar::~PlatformScrollBar):
(WebCore::PlatformScrollBar::width):
(WebCore::PlatformScrollBar::height):
(WebCore::PlatformScrollBar::setEnabled):
(WebCore::PlatformScrollBar::paint):
(WebCore::PlatformScrollBar::setScrollBarValue):
(WebCore::PlatformScrollBar::setKnobProportion):
(WebCore::PlatformScrollBar::setRect):
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
(WebCore::CheckCacheObjectStatus):
(WebCore::CheckIfReloading):
(WebCore::ServeSynchronousRequest):
(WebCore::historyContains):
(WebCore::submitButtonDefaultLabel):
(WebCore::inputElementAltText):
(WebCore::resetButtonDefaultLabel):
(WebCore::defaultLanguage):
(WebCore::findNextSentenceFromIndex):
(WebCore::findSentenceBoundary):
(WebCore::findNextWordFromIndex):
(WebCore::findWordBoundary):
(Frame::setNeedsReapplyStyles):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::searchableIndexIntroduction):
(WebCore::setFocusRingColorChangeFunction):
(FrameView::updateBorder):
(loadResourceIntoArray):
(PlugInInfoStore::createPluginInfoForPluginAtIndex):
(PlugInInfoStore::pluginCount):
(WebCore::PlugInInfoStore::supportsMIMEType):
(FileButton::FileButton):
(FileButton::click):
(FileButton::sizeForCharacterWidth):
(FileButton::focusPolicy):
(FileButton::frameGeometry):
(FileButton::setFilename):
(FileButton::baselinePosition):
(FileButton::setFrameGeometry):
(FileButton::setDisabled):
(WebCore::supportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 21 Aug 2006 23:15:15 +0000 (23:15 +0000)]
Reviewed by Maciej.
Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support
* platform/qt/CursorQt.cpp: Added.
(WebCore::Cursor::Cursor):
(WebCore::Cursor::~Cursor):
(WebCore::Cursor::operator=):
(WebCore::Cursors::Cursors::self):
(WebCore::moveCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
* platform/qt/RenderThemeQt.cpp: Added.
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::supportsHover):
(WebCore::RenderThemeQt::paintCheckbox):
(WebCore::RenderThemeQt::paintRadio):
(WebCore::theme):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::controlSupportsTints):
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::createPopupMenu):
(WebCore::RenderThemeQt::addIntrinsicMargins):
(WebCore::RenderThemeQt::stylePainterAndWidgetForPaintInfo):
(WebCore::RenderThemeQt::setCheckboxSize):
(WebCore::RenderThemeQt::setRadioSize):
(WebCore::RenderThemeQt::supportsFocus):
(WebCore::RenderThemeQt::applyTheme):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::paintButton):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::paintTextField):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 21 Aug 2006 23:04:03 +0000 (23:04 +0000)]
Reviewed by Maciej.
Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WebKit should have Qt platform support
* platform/qt/SharedTimerQt.cpp: Added.
(WebCore:setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireTime):
(WebCore::stopSharedTimer):
* platform/qt/SharedTimerQt.h: Added.
(WebCore::SharedTimerQt::SharedTimerQt):
(WebCore::SharedTimerQt::~SharedTimerQt):
(WebCore::SharedTimerQt::inst):
(WebCore::SharedTimerQt::fire):
* platform/qt/SystemTimeQt.cpp: Added.
(WebCore::currentTime):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 21 Aug 2006 21:05:23 +0000 (21:05 +0000)]
WebCore:
Reviewed by John
-Defers writing to the database via a timer and handles starting the timer
intelligently
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::open): Don't start the update timer by default
(WebCore::IconDatabase::close): Call syncDatabase()
(WebCore::IconDatabase::setPrivateBrowsingEnabled): Call syncDatabase()
(WebCore::IconDatabase::setIconURLForPageURL): Setup the cached url, but defer the DB call
(WebCore::IconDatabase::setIconURLForPageURLInDatabase): Actually commit the url to the DB
(WebCore::IconDatabase::pruneUnretainedIconsOnStartup):
(WebCore::IconDatabase::updateDatabase): The updateTimer calls this, which just calls syncDatabase()
(WebCore::IconDatabase::syncDatabase): Add and remove pending pageURLs and iconURLs, and stop the updateTimer
* loader/icon/IconDatabase.h:
WebKit:
Reviewed by John
Quick ICONDEBUG flag fix
* Misc/WebIconDatabase.m:
(-[WebIconDatabase _applicationWillTerminate:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 21 Aug 2006 17:43:55 +0000 (17:43 +0000)]
2006-08-21 Vladimir Olexa <vladimir.olexa@gmail.com>
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6252
JavaScript 1.6 Array.lastIndexOf
Test: fast/js/array-lastIndexOf.html
* kjs/array_object.cpp:
(ArrayProtoFunc::callAsFunction): Added a LastIndexOf case.
* kjs/array_object.h:
(KJS::ArrayProtoFunc::): Added LastIndexOf to enum.
* tests/mozilla/expected.html: Two more tests now pass.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 21 Aug 2006 16:55:02 +0000 (16:55 +0000)]
Reviewed by Eric.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10429
XSLTProcessor.transformToFragment crashes if the owner document is empty
Test: fast/js/xslt-fragment-in-empty-doc.html
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::XMLTokenizer): Don't iterate over the element stack if it's empty.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 21 Aug 2006 08:55:42 +0000 (08:55 +0000)]
Reviewed by Anders
-Renamed an internal only method for clarity
-Tweaked WebDataSource for notification purposes with the new expiring icons
-Fixed a bug with the ICONDEBUG flag
* Misc/WebIconDatabase.m:
(-[WebIconDatabase init]):
(-[WebIconDatabase iconForURL:withSize:cache:]): #ifdef bug fixed
(-[WebIconDatabase _hasEntryForIconURL:]): Renamed for clarity
* Misc/WebIconDatabasePrivate.h:
* WebView/WebDataSource.m:
(-[WebDataSource _updateIconDatabaseWithURL:]):
(-[WebDataSource _notifyIconChanged:]):
(-[WebDataSource _loadIcon]):
(-[WebDataSource _iconLoaderReceivedPageIcon:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 21 Aug 2006 08:55:20 +0000 (08:55 +0000)]
Reviewed by Anders
-Added timer-based, deferred deletion of database records - PageURLs and Icons handled seperately
In the near future, we'll also have timer-based deferred *addition* of database records
-Keep retain/release counts in a hash instead of a DB table
-Keep only one hash record for the SiteIcons
-Renamed some methods for clarity
* bridge/mac/WebCoreIconDatabaseBridge.h: Renamed method for clarity
* bridge/mac/WebCoreIconDatabaseBridge.mm: Ditto
(-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]): Ditto
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::open): Added new timer setup
(WebCore::IconDatabase::iconForPageURL): Only work with one hash of the SiteIcons
(WebCore::IconDatabase::retainIconForPageURL): Keep count in a hash
(WebCore::IconDatabase::releaseIconForPageURL): Keep count in a hash, use deferred deletion
(WebCore::IconDatabase::retainIconURL): Added
(WebCore::IconDatabase::releaseIconURL): Added
(WebCore::IconDatabase::forgetPageURL): Added
(WebCore::IconDatabase::isIconURLRetained): New and improved simplicity
(WebCore::IconDatabase::setIconDataForIconURL): Cleanup
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Renamed
(WebCore::IconDatabase::pruneIconsPendingDeletion): Added
(WebCore::IconDatabase::hasEntryForIconURL): Renamed for clarity
* loader/icon/IconDatabase.h: Added multiple stuffs
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 21 Aug 2006 07:51:41 +0000 (07:51 +0000)]
Reviewed by Maciej's rubberstamp
Removed stale file references from the Xcode.proj
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 21 Aug 2006 00:01:52 +0000 (00:01 +0000)]
Reviewed by Brady.
- pull a bit of WebDataSource code into WebFrameLoader
* Loader/WebFrameLoader.m:
(-[WebFrameLoader _receivedError:]):
(-[WebFrameLoader webFrame]):
(-[WebFrameLoader _handleFallbackContent]):
(+[WebFrameLoader _canShowMIMEType:]):
(+[WebFrameLoader _representationExistsForURLScheme:]):
(+[WebFrameLoader _generatedMIMETypeForURLScheme:]):
* WebView/WebDataSource.m:
* WebView/WebDataSourceInternal.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Sun, 20 Aug 2006 22:27:28 +0000 (22:27 +0000)]
JavaScriptCore:
Reviewed by Maciej. Landed by rwlbuis.
Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WebKit should have Qt platform support
Removing obsolete QConstString/QString constructors in kjs code.
WebCore:
Reviewed by Maciej. Landed by rwlbuis.
Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WebKit should have Qt platform support
Removing HelperQt.h usage by creating appropriate operators
constructor in some of the platform classes, as suggested by Darin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Sat, 19 Aug 2006 05:35:27 +0000 (05:35 +0000)]
2006-08-18 Steve Falkenburg <sfalken@apple.com>
Rubber stamped by adele.
Fix call to WebFormDelegate's textFieldDidBeginEditing.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::subtreeHasChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 23:26:51 +0000 (23:26 +0000)]
Reviewed by Eric. Landed by rwlbuis.
Next chunk of the implementation for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 23:20:27 +0000 (23:20 +0000)]
Reviewed by Eric. Landed by rwlbuis.
Next chunk of the implementation for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 22:47:37 +0000 (22:47 +0000)]
Reviewed by Eric. Landed by rwlbuis.
First chunk of the implementation for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 22:16:42 +0000 (22:16 +0000)]
Reviewed by Eric. Landed by rwlbuis.
First chunk of the implementation for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 19:33:48 +0000 (19:33 +0000)]
I hope I got this finally right, learning all the time :|
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 19:26:47 +0000 (19:26 +0000)]
Accidently doubly applied patch for:
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
Sorry for any inconvenience!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 19:11:41 +0000 (19:11 +0000)]
Reviewed by Eric. Landed by rwlbuis.
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10470
The Qt platform needs a KCanvas device.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 18:53:25 +0000 (18:53 +0000)]
Reviewed by Maciej. Landed by rwlbuis.
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WTF Changes needed for Qt platform code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 13:03:33 +0000 (13:03 +0000)]
Fixing my mistakes with landing of:
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10466
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 11:58:13 +0000 (11:58 +0000)]
I forgot to commit this as part of:
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10464
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 11:45:29 +0000 (11:45 +0000)]
Reviewed by Eric. Landed by rwlbuis.
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10466
WebKit should have Qt platform support.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 11:21:58 +0000 (11:21 +0000)]
Reviewed by Eric. Landed by rwlbuis.
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10465
General WebKit Linux build fixes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Fri, 18 Aug 2006 11:04:01 +0000 (11:04 +0000)]
Reviewed by Eric. Landed by rwlbuis.
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10464
Offer a cmake build system for Qt platform.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Thu, 17 Aug 2006 23:05:43 +0000 (23:05 +0000)]
Reviewed by John Sullivan.
<rdar://problem/
4671069> REGRESSION: Popup buttons in web pages aren't exposed as AXPopupButtons
Accessorized RenderMenuList objects.
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject mouseButtonListener]):
Trivial formatting.
(-[WebCoreAXObject actionElement]):
Return the HTMLSelectElement.
(-[WebCoreAXObject firstChild]):
(-[WebCoreAXObject lastChild]):
(-[WebCoreAXObject previousSibling]):
(-[WebCoreAXObject nextSibling]):
(-[WebCoreAXObject parentObject]):
(-[WebCoreAXObject parentObjectUnignored]):
(-[WebCoreAXObject isAttachment]):
(-[WebCoreAXObject attachmentView]):
Trivial formatting.
(-[WebCoreAXObject role]):
Return NSAccessibilityPopUpButtonRole.
(-[WebCoreAXObject subrole]):
Trivial formatting.
(-[WebCoreAXObject roleDescription]):
Return NSAccessibilityPopUpButtonRole.
(-[WebCoreAXObject textUnderElement]):
Trivial formatting.
(-[WebCoreAXObject value]):
Return the RenderMenuList::text().
(-[WebCoreAXObject position]):
Trivial formatting.
(-[WebCoreAXObject accessibilityIsIgnored]):
- Ignore popup menu items because AppKit does.
- Remove redundant check for buttonTag (earlier isControl() check suffices).
(-[WebCoreAXObject accessibilityAttributeNames]):
(-[WebCoreAXObject accessibilityActionNames]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
Trivial formatting.
(-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
Removed old debugging code that is no longer needed.
Trivial formatting.
(-[WebCoreAXObject doAXSentenceTextMarkerRangeForTextMarker:]):
(-[WebCoreAXObject doAXParagraphTextMarkerRangeForTextMarker:]):
(-[WebCoreAXObject removeAXObjectID]):
Trivial formatting.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::accessKeyAction):
Call click() instead of focus().
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::text):
Added for easy access to popup's current text.
* rendering/RenderMenuList.h:
(WebCore::RenderMenuList::isMenuList):
* rendering/RenderObject.h:
(WebCore::RenderObject::isMenuList):
Added so popups can be identified.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 17 Aug 2006 22:23:18 +0000 (22:23 +0000)]
Reviewed by Kevin Decker.
<rdar://problem/
4606857> WebKit: WebPreferencesChangedNotification not exported in 64-bit
* WebKit.LP64.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 17 Aug 2006 20:37:49 +0000 (20:37 +0000)]
2006-08-17 Anders Carlsson <acarlsson@apple.com>
Reviewed by Maciej.
* bindings/npapi.h:
Fix ifdef.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Thu, 17 Aug 2006 20:06:43 +0000 (20:06 +0000)]
Reviewed by Maciej.
<rdar://problem/
4527201> REGRESSION: AXTextMarkerRangeForUnorderedTextMarkers returns out of order range
Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...
<rdar://problem/
4256882> Need automated testing support for accessibility APIs
* bridge/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::visiblePositionForTextMarker):
Validate the marker by comparing the node and offset to those of the resulting VisiblePosition.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 17 Aug 2006 19:58:53 +0000 (19:58 +0000)]
Reviewed by Kevin Decker.
<rdar://problem/
4633896> -[WebView close] should clear all delegates and call setHostWindow:nil
<rdar://problem/
4649759> Crash when selecting View Source menu using Chinese (-[WebView _close])
Check to make sure _private is not null. A WebView can be dealloced before _private is setup.
Set the _private->closed flag at the beginning of _close to prevent reentry.
Set the host window and all the delegates to nil in _close.
* WebView/WebView.m:
(-[WebView _close]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 16 Aug 2006 22:59:38 +0000 (22:59 +0000)]
Reviewed by thatcher
Equivalent render tree:
* fast/events/ondragenter-expected.checksum:
* fast/events/ondragenter-expected.txt:
Patch exposed a bug (10449):
* fast/lists/drag-into-marker.html: Removed.
* fast/lists/drag-into-marker.html-disabled: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@15924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log