WebKit-https.git
13 years ago2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 9 Jun 2008 04:47:05 +0000 (04:47 +0000)]
2008-06-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 17932: "ASSERTION FAILED: type != Continue" with do/while and try/finally
        <https://bugs.webkit.org/show_bug.cgi?id=17932>

        This bug was fixed by SquirrelFish, but we should add a test, as well
        as tests for related issues found while developing SquirrelFish.

        * fast/js/continue-break-multiple-labels-expected.txt:
        * fast/js/continue-break-multiple-labels.html:
        * fast/js/resources/continue-break-multiple-labels.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
abarth@webkit.org [Mon, 9 Jun 2008 04:37:49 +0000 (04:37 +0000)]
WebCore:

2008-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Inherit document.URL from parent's document.URL, not document.baseURI.

        https://bugs.webkit.org/show_bug.cgi?id=19257

        Tests: http/tests/security/cookies/assign-document-url.html
               http/tests/security/cookies/base-about-blank.html
               http/tests/security/cookies/base-tag.html
               http/tests/security/cookies/basic.html

        * dom/Document.cpp:
        (WebCore::Document::open):

LayoutTests:

2008-06-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Alder.

        Add a number of tests for document.cookie access.

        https://bugs.webkit.org/show_bug.cgi?id=19257

        * http/tests/security/cookies: Added.
        * http/tests/security/cookies/assign-document-url-expected.txt: Added.
        * http/tests/security/cookies/assign-document-url.html: Added.
        * http/tests/security/cookies/base-about-blank-expected.txt: Added.
        * http/tests/security/cookies/base-about-blank.html: Added.
        * http/tests/security/cookies/base-tag-expected.txt: Added.
        * http/tests/security/cookies/base-tag.html: Added.
        * http/tests/security/cookies/basic-expected.txt: Added.
        * http/tests/security/cookies/basic.html: Added.
        * http/tests/security/cookies/resources: Added.
        * http/tests/security/cookies/resources/set-a-cookie.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Darin Adler.
kevino@webkit.org [Mon, 9 Jun 2008 03:39:46 +0000 (03:39 +0000)]
Reviewed by Darin Adler.

Fix font asserts in wx port. Our computeHash function should generate the same hash for two identical fonts which are different objects, which it wasn't doing before.

https://bugs.webkit.org/show_bug.cgi?id=19310

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Mon, 9 Jun 2008 02:12:21 +0000 (02:12 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()

        Test: fast/multicol/content-height-zero-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutColumns): Changed to not keep creating
        overflow columns that have zero height, because they do not help with
        fitting content in.

LayoutTests:

        - test for <rdar://problem/5961977> Crash in RenderBlock::layoutColumns()

        Reviewed by Darin Adler.

        * fast/multicol/content-height-zero-crash-expected.txt: Added.
        * fast/multicol/content-height-zero-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 9 Jun 2008 00:57:28 +0000 (00:57 +0000)]
2008-06-08  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin.

        Bug 19346: REGRESSION: Mootools 1.2 Class inheritance broken in post-SquirrelFish merge
        <https://bugs.webkit.org/show_bug.cgi?id=19346>

        A check for whether a function's caller is eval code accidentally included
        the case where the caller's caller is native code. Add a CodeType field to
        CodeBlock and use this for the eval caller test instead.

        JavaScriptCore:

        * VM/CodeBlock.h:
        (KJS::CodeBlock::CodeBlock):
        (KJS::ProgramCodeBlock::ProgramCodeBlock):
        (KJS::EvalCodeBlock::EvalCodeBlock):
        * VM/Machine.cpp:
        (KJS::getCallerFunctionOffset):
        * kjs/nodes.cpp:
        (KJS::FunctionBodyNode::generateCode):
        (KJS::ProgramNode::generateCode):

        LayoutTests:

        * fast/js/function-dot-arguments-and-caller-expected.txt:
        * fast/js/function-dot-arguments-and-caller.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 18837: Database panel fails to display tables if any value is NULL
aroben@apple.com [Sun, 8 Jun 2008 20:57:48 +0000 (20:57 +0000)]
    Fix Bug 18837: Database panel fails to display tables if any value is NULL

        <https://bugs.webkit.org/show_bug.cgi?id=18837>

        Reviewed by Darin Adler.

        Test: manual-tests/inspector/display-sql-null.html

        * manual-tests/inspector/display-sql-null.html: Added.
        * page/inspector/DatabasesPanel.js:
        (WebInspector.DatabasesPanel.prototype.dataGridForResult): Convert all
        objects to strings before operating on them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 19438: Transaction errors are never displayed in database query view
aroben@apple.com [Sun, 8 Jun 2008 20:57:11 +0000 (20:57 +0000)]
    Fix Bug 19438: Transaction errors are never displayed in database query view

        <https://bugs.webkit.org/show_bug.cgi?id=19438>

        Reviewed by Darin Adler.

        Test: manual-tests/inspector/display-sql-transaction-error.html

        * manual-tests/inspector/display-sql-transaction-error.html: Added.
        * page/inspector/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView.prototype._enterKeyPressed): Use
        _executeSqlError as the error callback for executeSql.
        (WebInspector.DatabaseQueryView.prototype._queryError): Changed to
        only take two parameters. This matches what we'll be passed if
        db.transaction fails.
        (WebInspector.DatabaseQueryView.prototype._executeSqlError): Added.
        Calls through to _queryError.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-08 Dirk Schulze <vbs85@gmx.de>
darin@apple.com [Sun, 8 Jun 2008 20:36:24 +0000 (20:36 +0000)]
2008-06-08  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=18840
        [CAIRO] Clipping-support for SVG

        Support for clipping in SVG/Cairo and fixes transformation of paths.

        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::transform):
        * svg/graphics/cairo/SVGResourceClipperCairo.cpp:
        (WebCore::SVGResourceClipper::applyClip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-08 Dirk Schulze <vbs85@gmx.de>
darin@apple.com [Sun, 8 Jun 2008 20:33:27 +0000 (20:33 +0000)]
2008-06-08  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=18663
        Add text-stroke support to Cairo.

        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 20:30:50 +0000 (20:30 +0000)]
WebCore:

2008-06-08  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=16489
        WebKit does not support ElementTraversal specification

        Tests: fast/dom/Element/element-traversal.html

        * dom/Element.cpp:
        (WebCore::Element::firstElementChild):
        (WebCore::Element::lastElementChild):
        (WebCore::Element::previousElementSibling):
        (WebCore::Element::nextElementSibling):
        (WebCore::Element::childElementCount):
        * dom/Element.h:
        * dom/Element.idl:

LayoutTests:

2008-06-08  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Darin.

        test cases for https://bugs.webkit.org/show_bug.cgi?id=16489
        WebKit does not support ElementTraversal specification

        * fast/dom/Element/element-traversal-expected.txt: Added.
        * fast/dom/Element/element-traversal.html: Added.
        * fast/dom/Element/resources/element-traversal.js: Added.

        * fast/dom/domListEnumeration-expected.txt: Updated since Element now has 5
        new properties. It would be good to rewrite this test so it doesn't have to
        be updated every time we add a property to Node or Element.
        * fast/dom/resources/domListEnumeration.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 20:01:19 +0000 (20:01 +0000)]
WebCore:

2008-06-08  Bradley Meck  <genisis329@gmail.com>

        Reviewed by Darin.

        - fix https://bugs.webkit.org/show_bug.cgi?id=17051
          safari should treat "url()" as a valid CSS value

        Test: fast/css/invalid-cursor-property-crash.html

        Changed check for empty url() to be a check for null since url() is valid
        CSS even if it is empty.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseBorderImage):

LayoutTests:

2008-06-08  Bradley Meck  <genisis329@gmail.com>

        Reviewed and tweaked by Darin.

        - test for https://bugs.webkit.org/show_bug.cgi?id=17051
          safari should treat "url()" as a valid CSS value

        We should really add some more tests for this. One text-only test each for the
        four different sites that handle URLs (cursor image, list style image, fill image,
        border image) that were fixed. Currently this covers only the cursor image.

        * fast/css/invalid-cursor-property-crash.html: Updated test to expect the
        url() to be expanded into the URL of the document itself. The text of the test
        is now a bit misleading, but it still tests that it's not a crash, and now it
        also doubles as a check that url() is handled properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 19:41:25 +0000 (19:41 +0000)]
WebCore:

2008-06-08  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Darin.

        Bug 18041: DOMNodeRemoved events are sent twice

        Test: fast/dom/Node/DOMNodeRemovedEvent.html

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::removeChild):

LayoutTests:

2008-06-08  Vincent Ricard  <magic@magicninja.org>

        Reviewed by Darin.

        Test case for
        Bug 18041: DOMNodeRemoved events are sent twice

        * fast/dom/Node/DOMNodeRemovedEvent-expected.txt: Added.
        * fast/dom/Node/DOMNodeRemovedEvent.html: Added.
        * fast/dom/Node/resources/DOMNodeRemovedEvent.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 19:31:59 +0000 (19:31 +0000)]
WebCore:

2008-06-08  Tony Chang  <idealisms@gmail.com>

        Reviewed by Eric Seidel.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18167
          there should be no text-drag delay on any platform except for Mac

        Move the drag text delay value into the platform specific files.

        Test: editing/selection/drag-text-delay.html

        * page/EventHandler.cpp:
        * page/EventHandler.h:
        * page/gtk/EventHandlerGtk.cpp:
        * page/mac/EventHandlerMac.mm:
        * page/qt/EventHandlerQt.cpp:
        * page/win/EventHandlerWin.cpp:
        * page/wx/EventHandlerWx.cpp:

LayoutTests:

2008-06-08  Tony Chang  <idealisms@gmail.com>

        Reviewed by Eric Seidel.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18167
          there should be no text-drag delay on any platform except for Mac

        Also updated two tests which depend on the drag text delay to be greater
        than 0 by making them no longer select text before the mouse down.

        * editing/selection/drag-text-delay-expected.txt: Added.
        * editing/selection/drag-text-delay.html: Added.
        * platform/mac/editing/selection/drag-text-delay-expected.txt: Added.

        * fast/events/autoscroll.html:
        * fast/forms/input-readonly-autoscroll.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Sun, 8 Jun 2008 19:21:35 +0000 (19:21 +0000)]
WebCore:

2008-06-08  Rob Buis  <buis@kde.org>

        Reviewed by Darin.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18512
          getPresentationAttribute returns a shared object

        Test: svg/custom/getPresentationAttribute-modify.svg

        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::getPresentationAttribute): Unshare the mapped style
        declaration if it is shared before returning the presentation attribute.

LayoutTests:

2008-06-08  Rob Buis  <buis@kde.org>

        Reviewed by Darin.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18512
          getPresentationAttribute returns a shared object

        * svg/custom/getPresentationAttribute-modify-expected.txt: Added.
        * svg/custom/getPresentationAttribute-modify.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-08 Eric Roman <minatoar@gmail.com>
darin@apple.com [Sun, 8 Jun 2008 19:08:53 +0000 (19:08 +0000)]
2008-06-08  Eric Roman  <minatoar@gmail.com>

        Reviewed by Adam Roben.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18550
          cross-frame-access-call.html doesn't really test window.open(), since popups are blocked

        * http/tests/security/cross-frame-access-call.html: Enable popups for this layout test.
        The test checks that window.open is returns undefined (same-domain enforcement), however
        unless popups are enabled it returns undefined regardless.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-08 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 8 Jun 2008 19:04:23 +0000 (19:04 +0000)]
2008-06-08  Alp Toker  <alp@nuanti.com>

        autotools/GTK+ build system cleanup. Don't include WebKit API in the
        WebCore build as it's no longer needed since r34426.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-08 Jonathan Haas <myrdred@gmail.com>
darin@apple.com [Sun, 8 Jun 2008 18:39:44 +0000 (18:39 +0000)]
2008-06-08  Jonathan Haas <myrdred@gmail.com>

        Reviewed by Eric Seidel.
        Tweaked by Darin while landing to make it compile.

        - fix http://bugs.webkit.org/show_bug.cgi?id=19128
          SVG fonts don't work with medial Arabic characters

        Haven't figured out a way to make an automated test for this.

        * svg/SVGGlyphElement.h: Made arabicForm unsigned so it fits into
        its 3-bit field. Did the same for orientation's 2-bit field.

        * svg/SVGFont.cpp: Did a bit of minor tweaking.
        (WebCore::isCompatibleArabicForm): Added a cast to avoid a warning
        since the type is now different.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-08 Eric Carlson <eric.carlson@apple.com>
darin@apple.com [Sun, 8 Jun 2008 18:22:45 +0000 (18:22 +0000)]
2008-06-08  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Antti.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19299
          <rdar://problem/5969392>

        Generate the media MIME type list dynamically.

        * platform/graphics/win/QTMovieWin.cpp:
        (initializeSupportedTypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-08 Christian Persch <chpe@gnome.org>
darin@apple.com [Sun, 8 Jun 2008 18:16:38 +0000 (18:16 +0000)]
2008-06-08  Christian Persch  <chpe@gnome.org>

        Reviewed by Darin.

        - https://bugs.webkit.org/show_bug.cgi?id=19309
          uninitialised variable in PluginView

        * plugins/PluginView.cpp:
        (WebCore::PluginView::PluginView): Initialise the NPP's pdata member to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-08 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 8 Jun 2008 18:07:11 +0000 (18:07 +0000)]
2008-06-08  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - https://bugs.webkit.org/show_bug.cgi?id=19435
          fix warning in PluginDebug.h

        * plugins/PluginDebug.h: Don't compile the errorStrings array if LOG_DISABLED is set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
mitz@apple.com [Sun, 8 Jun 2008 17:44:41 +0000 (17:44 +0000)]
    Reviewed by Adam Roben.

        - update trac URL in PrettyPatch

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-08 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 8 Jun 2008 16:10:16 +0000 (16:10 +0000)]
2008-06-08  Alp Toker  <alp@nuanti.com>

        Rubber-stamped by Mark Rowe.

        Bring back -fstrict-aliasing for JavaScriptCore which was removed in
        r31821, since aliasing issues have now been fixed.

        Use -O3, not -O2 for the JavaScriptCore build.

        * GNUmakefile.am:
        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-08 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 8 Jun 2008 16:01:54 +0000 (16:01 +0000)]
2008-06-08  Darin Adler  <darin@apple.com>

        * Scripts/make-js-test-wrappers: Added another exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Sun, 8 Jun 2008 05:56:27 +0000 (05:56 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19431
          <rdar://problem/5994060> REGRESSION (r32406): tabs retain hover color after mouse out

        Covered by fast/css/remove-shorthand.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::initShorthandMap): Fixed a typo which mapped the background
        shorthand to the mask properties.

LayoutTests:

        Reviewed by Dave Hyatt.

        - updated test for https://bugs.webkit.org/show_bug.cgi?id=19431
          <rdar://problem/5994060> REGRESSION (r32406): tabs retain hover color after mouse out

        * fast/css/remove-shorthand-expected.txt:
        * fast/css/remove-shorthand.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 8 Jun 2008 03:50:33 +0000 (03:50 +0000)]
2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Dan Bernstein.

        Bug 17928: testkjs shouldn't require "-f"
        <https://bugs.webkit.org/show_bug.cgi?id=17928>

        * kjs/testkjs.cpp:
        (printUsageStatement):
        (parseArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-07 Brent Fulgham <bfulgham@gmail.com>
jmalonzo@webkit.org [Sun, 8 Jun 2008 01:57:54 +0000 (01:57 +0000)]
2008-06-07  Brent Fulgham  <bfulgham@gmail.com>

        Cairo build fix for r34432

        * html/CanvasPattern.cpp:
        (WebCore::CanvasPattern::CanvasPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-07 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 8 Jun 2008 01:44:07 +0000 (01:44 +0000)]
2008-06-07  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Confirmed by Christian Dywan.

        Gtk build fix for r34432

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_history_item_add):
        (_WebKitWebHistoryItemPrivate::webkit_history_item_remove):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new):
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data):
        (WebKit::core):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-07 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 8 Jun 2008 01:12:16 +0000 (01:12 +0000)]
2008-06-07  Darin Adler  <darin@apple.com>

        - try to fix build after HistoryItem changes

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): Use HistoryItem::create.
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): Ditto. I also
        believe this fixes a memory leak in the old version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 8 Jun 2008 00:20:11 +0000 (00:20 +0000)]
2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Timothy.

        Remove the --squirrelfish option from SunSpider, as it is no longer needed.

        SunSpider:

        * sunspider:
        * tests/LIST-SQUIRRELFISH: Removed.

        WebKitTools:

        * Scripts/run-sunspider:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Sat, 7 Jun 2008 22:51:37 +0000 (22:51 +0000)]
WebCore:

2008-06-07  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - work on https://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::toHTMLCanvasStyle):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
        (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
        * bindings/js/JSNodeFilterCondition.h:
        (WebCore::JSNodeFilterCondition::create):
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::toNodeFilter):
        * bindings/js/JSSVGLazyEventListener.h:
        (WebCore::JSSVGLazyEventListener::create):
        * bindings/js/JSSVGMatrixCustom.cpp:
        (WebCore::JSSVGMatrix::multiply):
        (WebCore::JSSVGMatrix::inverse):
        (WebCore::JSSVGMatrix::translate):
        (WebCore::JSSVGMatrix::scale):
        (WebCore::JSSVGMatrix::scaleNonUniform):
        (WebCore::JSSVGMatrix::rotate):
        (WebCore::JSSVGMatrix::rotateFromVector):
        (WebCore::JSSVGMatrix::flipX):
        (WebCore::JSSVGMatrix::flipY):
        (WebCore::JSSVGMatrix::skewX):
        (WebCore::JSSVGMatrix::skewY):
        * bindings/js/JSSVGPODTypeWrapper.h:
        (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create):
        (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite):
        (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create):
        (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly):
        (WebCore::JSSVGPODTypeWrapperCreatorForList::create):
        (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList):
        (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper):
        (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
        * bindings/js/JSSVGPointListCustom.cpp:
        (WebCore::commonExit):
        (WebCore::commonExitReadOnly):
        (WebCore::JSSVGPointList::initialize):
        (WebCore::JSSVGPointList::getItem):
        (WebCore::JSSVGPointList::insertItemBefore):
        (WebCore::JSSVGPointList::replaceItem):
        (WebCore::JSSVGPointList::removeItem):
        (WebCore::JSSVGPointList::appendItem):
        * bindings/js/JSSVGTransformListCustom.cpp:
        (WebCore::JSSVGTransformList::initialize):
        (WebCore::JSSVGTransformList::getItem):
        (WebCore::JSSVGTransformList::insertItemBefore):
        (WebCore::JSSVGTransformList::replaceItem):
        (WebCore::JSSVGTransformList::removeItem):
        (WebCore::JSSVGTransformList::appendItem):
        * bindings/js/kjs_binding.cpp:
        (WebCore::setDOMException):
        * bindings/js/kjs_events.h:
        (WebCore::JSUnprotectedEventListener::create):
        (WebCore::JSEventListener::create):
        (WebCore::JSLazyEventListener::create):
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::createHTMLEventHandler):
        (WebCore::KJSProxy::createSVGEventHandler):
        * bindings/objc/DOM.mm:
        (WebCore::ObjCNodeFilterCondition::create):
        (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition):
        (WebCore::ObjCNodeFilterCondition::acceptNode):
        (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
        (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForNinePieceImage):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSFontFace.h:
        (WebCore::CSSFontFace::create):
        (WebCore::CSSFontFace::CSSFontFace):
        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseCounterContent):
        (WebCore::CSSParser::parseShape):
        (WebCore::BorderImageParseContext::commitBorderImage):
        * css/CSSSegmentedFontFace.cpp:
        (WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
        * css/CSSSegmentedFontFace.h:
        (WebCore::CSSSegmentedFontFace::create):
        * css/Counter.h:
        (WebCore::Counter::create):
        (WebCore::Counter::Counter):
        * css/DashboardRegion.h:
        (WebCore::DashboardRegion::create):
        (WebCore::DashboardRegion::DashboardRegion):
        * css/Rect.h:
        (WebCore::Rect::create):
        (WebCore::Rect::Rect):
        * dom/ChildNodeList.h:
        (WebCore::ChildNodeList::create):
        * dom/ClassNodeList.h:
        (WebCore::ClassNodeList::create):
        * dom/Clipboard.h:
        * dom/DOMCoreException.h:
        (WebCore::DOMCoreException::create):
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::instance):
        * dom/DOMImplementation.h:
        (WebCore::DOMImplementation::DOMImplementation):
        * dom/Document.cpp:
        (WebCore::Document::addWindowEventListener):
        (WebCore::Document::removeWindowEventListener):
        (WebCore::Document::setDecoder):
        (WebCore::Document::images):
        (WebCore::Document::applets):
        (WebCore::Document::embeds):
        (WebCore::Document::plugins):
        (WebCore::Document::objects):
        (WebCore::Document::scripts):
        (WebCore::Document::links):
        (WebCore::Document::forms):
        (WebCore::Document::anchors):
        (WebCore::Document::all):
        (WebCore::Document::windowNamedItems):
        (WebCore::Document::documentNamedItems):
        * dom/Document.h:
        * dom/DynamicNodeList.h:
        * dom/EventException.h:
        (WebCore::EventException::create):
        (WebCore::EventException::EventException):
        * dom/EventListener.h:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::addEventListener):
        (WebCore::EventTarget::removeEventListener):
        * dom/ExceptionBase.cpp:
        (WebCore::ExceptionBase::ExceptionBase):
        * dom/ExceptionBase.h:
        * dom/NameNodeList.h:
        (WebCore::NameNodeList::create):
        * dom/Node.cpp:
        (WebCore::Node::childNodes):
        (WebCore::Node::getElementsByTagNameNS):
        (WebCore::Node::getElementsByName):
        (WebCore::Node::getElementsByClassName):
        (WebCore::Node::querySelectorAll):
        * dom/NodeFilterCondition.h:
        * dom/NodeList.h:
        * dom/RangeException.h:
        (WebCore::RangeException::create):
        (WebCore::RangeException::RangeException):
        * dom/RegisteredEventListener.h:
        (WebCore::RegisteredEventListener::create):
        * dom/SelectorNodeList.cpp:
        (WebCore::createSelectorNodeList):
        * dom/SelectorNodeList.h:
        * dom/StaticNodeList.cpp:
        (WebCore::StaticNodeList::StaticNodeList):
        * dom/StaticNodeList.h:
        (WebCore::StaticNodeList::adopt):
        * dom/TagNodeList.h:
        (WebCore::TagNodeList::create):
        * history/HistoryItem.cpp:
        (WebCore::defaultNotifyHistoryItemChanged):
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::copy):
        * history/HistoryItem.h:
        (WebCore::HistoryItem::create):
        * html/CanvasGradient.h:
        * html/CanvasPattern.cpp:
        (WebCore::CanvasPattern::CanvasPattern):
        * html/CanvasPattern.h:
        (WebCore::CanvasPattern::create):
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::State::State):
        (WebCore::CanvasRenderingContext2D::setStrokeColor):
        (WebCore::CanvasRenderingContext2D::setFillColor):
        (WebCore::CanvasRenderingContext2D::createPattern):
        * html/CanvasStyle.cpp:
        (WebCore::CanvasStyle::CanvasStyle):
        * html/CanvasStyle.h:
        (WebCore::CanvasStyle::create):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::HTMLCollection):
        (WebCore::HTMLCollection::create):
        * html/HTMLCollection.h:
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::children):
        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::create):
        * html/HTMLFormCollection.h:
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::elements):
        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::areas):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::load):
        (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged):
        (WebCore::HTMLMediaElement::willSaveToCache):
        * html/HTMLNameCollection.h:
        (WebCore::HTMLNameCollection::create):
        * html/HTMLOptionsCollection.cpp:
        (WebCore::HTMLOptionsCollection::create):
        * html/HTMLOptionsCollection.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::options):
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::rows):
        (WebCore::HTMLTableElement::tBodies):
        * html/HTMLTableRowElement.cpp:
        (WebCore::HTMLTableRowElement::cells):
        * html/HTMLTableRowsCollection.cpp:
        (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
        (WebCore::HTMLTableRowsCollection::create):
        * html/HTMLTableRowsCollection.h:
        * html/HTMLTableSectionElement.cpp:
        (WebCore::HTMLTableSectionElement::rows):
        * html/MediaError.h:
        (WebCore::MediaError::create):
        (WebCore::MediaError::MediaError):
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
        * loader/CachedFont.cpp:
        (WebCore::CachedFont::ensureSVGFontData):
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::write):
        (WebCore::FrameLoader::createHistoryItem):
        * loader/ImageDocument.cpp:
        (WebCore::ImageEventListener::create):
        (WebCore::ImageEventListener::ImageEventListener):
        (WebCore::ImageDocument::createDocumentStructure):
        * loader/TextResourceDecoder.h:
        (WebCore::TextResourceDecoder::create):
        * page/Page.cpp:
        (WebCore::Page::userStyleSheet):
        * svg/SVGException.h:
        (WebCore::SVGException::create):
        (WebCore::SVGException::SVGException):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::ConditionEventListener::create):
        (WebCore::ConditionEventListener::ConditionEventListener):
        (WebCore::SVGSMILElement::connectConditions):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::didReceiveData):
        * xml/XMLHttpRequestException.h:
        (WebCore::XMLHttpRequestException::create):
        (WebCore::XMLHttpRequestException::XMLHttpRequestException):
        * xml/XPathException.h:
        (WebCore::XPathException::create):
        (WebCore::XPathException::XPathException):
        * xml/XPathResult.cpp:
        (WebCore::InvalidatingEventListener::create):
        (WebCore::InvalidatingEventListener::InvalidatingEventListener):
        (WebCore::XPathResult::XPathResult):
        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource):

WebKit/mac:

2008-06-07  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - work on https://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem init]):
        (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
        (-[WebHistoryItem initWithURL:target:parent:title:]):
        (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
        * WebView/WebView.mm:
        (+[WebView _decodeData:]):

WebKit/win:

2008-06-07  Darin Adler  <darin@apple.com>

        Reviewed by Mitz.

        - work on https://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        * WebHistoryItem.cpp:
        (WebHistoryItem::createInstance):
        (WebHistoryItem::initFromDictionaryRepresentation):
        (WebHistoryItem::initWithURLString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-07 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 7 Jun 2008 22:49:37 +0000 (22:49 +0000)]
2008-06-07  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix random failures of XSS tests by using window.postMessage().

        * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
        * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html:
        * http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame.html:
        * http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame.html:
        * http/tests/security/resources/cross-frame-access.js:
        * http/tests/security/resources/cross-frame-iframe-with-explicit-domain-set.html:
        * http/tests/security/resources/cross-frame-iframe.html:
        * platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam Weinig.
mitz@apple.com [Sat, 7 Jun 2008 22:37:28 +0000 (22:37 +0000)]
    Reviewed by Sam Weinig.

        - pixel test for https://bugs.webkit.org/show_bug.cgi?id=19279
          REGRESSION (r32660): Text not redrawn correctly when selection changes

        * fast/text/selection-painted-separately.html: Added.
        * platform/mac/fast/text/selection-painted-separately-expected.checksum: Added.
        * platform/mac/fast/text/selection-painted-separately-expected.png: Added.
        * platform/mac/fast/text/selection-painted-separately-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 7 Jun 2008 21:56:42 +0000 (21:56 +0000)]
2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Eric.

        Bug 17548: JavaScriptCore print(a, b) differs from Spidermonkey Behavior
        <https://bugs.webkit.org/show_bug.cgi?id=17548>

        * kjs/testkjs.cpp:
        (functionPrint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 7 Jun 2008 19:32:42 +0000 (19:32 +0000)]
2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Sam.

        Bug 17547: JavaScriptCore print() differs from Spidermonkey Behavior
        <https://bugs.webkit.org/show_bug.cgi?id=17547>

        * kjs/testkjs.cpp:
        (functionPrint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 7 Jun 2008 19:02:00 +0000 (19:02 +0000)]
2008-06-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam.

        Tests for https://bugs.webkit.org/show_bug.cgi?id=17911

        * http/tests/security/resources/iframe-for-synchronous-form.html: Added.
        * http/tests/security/xss-DENIED-synchronous-form-expected.txt: Added.
        * http/tests/security/xss-DENIED-synchronous-form.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove PLATFORM ifdefs from ContextMenu.cpp
christian@webkit.org [Sat, 7 Jun 2008 18:07:07 +0000 (18:07 +0000)]
Remove PLATFORM ifdefs from ContextMenu.cpp

https://bugs.webkit.org/show_bug.cgi?id=17324

Reviewed by Alp Toker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago More build fixes.
ap@webkit.org [Sat, 7 Jun 2008 10:59:39 +0000 (10:59 +0000)]
    More build fixes.

        * kjs/JSGlobalData.cpp: Fixed an included file name for case-sensitive file systems, fixed
        JSGlobalData::threadInstance() for non-multithreaded builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix - actually adding JSGlobalData.cpp to non-Mac builds!
ap@webkit.org [Sat, 7 Jun 2008 10:41:00 +0000 (10:41 +0000)]
    Build fix - actually adding JSGlobalData.cpp to non-Mac builds!

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:36:10 +0000 (10:36 +0000)]
    Reviewed by ap.

        Still more CSSParser cleanup
        - use c++ style member initializers in CSSParser()
        - change m_styleElement to m_styleSheet and make it a CSSStyleSheet
        - finally add my copyright to the files I've been cleaning

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::setupParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::createCharsetRule):
        (WebCore::CSSParser::createImportRule):
        (WebCore::CSSParser::createMediaRule):
        (WebCore::CSSParser::createStyleRule):
        * css/CSSParser.h:
        * css/SVGCSSParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:35:41 +0000 (10:35 +0000)]
    Reviewed by ap.

        More CSSParser cleanup
        - rename CSSParser::id to m_id
        - rename CSSParser::data to m_data
        - fix a few whitespace and argument name issues

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParser::setupParser):
        (WebCore::CSSParser::parseValue):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:35:10 +0000 (10:35 +0000)]
    Reviewed by ap.

        Rename CSSParser::strict to m_strict

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseBackgroundColor):
        (WebCore::CSSParser::parseFillPositionXY):
        (WebCore::CSSParser::parseFillSize):
        (WebCore::CSSParser::parseTransitionDuration):
        (WebCore::CSSParser::parseTransitionRepeatCount):
        (WebCore::CSSParser::parseTimingFunctionValue):
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseShape):
        (WebCore::CSSParser::parseFont):
        (WebCore::CSSParser::parseColorFromValue):
        (WebCore::CSSParser::parseShadow):
        (WebCore::CSSParser::parseReflect):
        (WebCore::CSSParser::parseBorderImage):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:34:39 +0000 (10:34 +0000)]
    Reviewed by ap.

        Rename CSSParser::defaultNamespace to m_defaultNamespace

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseSheet):
        * css/CSSParser.h:
        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::addNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:34:06 +0000 (10:34 +0000)]
    Reviewed by ap.

        Rename CSSParser::important to m_important

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseFontFaceUnicodeRange):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:33:31 +0000 (10:33 +0000)]
    Reviewed by ap.

        Yet another cleanup patch for CSSParser
        Rename CSSParser::valueList to m_valueList

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParser::checkForOrphanedUnits):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFillShorthand):
        (WebCore::CSSParser::parseTransitionShorthand):
        (WebCore::CSSParser::parseShorthand):
        (WebCore::CSSParser::parse4Values):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseFillPositionXY):
        (WebCore::CSSParser::parseFillPosition):
        (WebCore::CSSParser::parseFillSize):
        (WebCore::CSSParser::parseFillProperty):
        (WebCore::CSSParser::parseTransitionProperty):
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseShape):
        (WebCore::CSSParser::parseFont):
        (WebCore::CSSParser::parseFontFamily):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseFontFaceUnicodeRange):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseShadow):
        (WebCore::CSSParser::parseReflect):
        (WebCore::BorderImageParseContext::commitBorderImage):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::parseCounter):
        (WebCore::CSSParser::parseGradient):
        (WebCore::CSSParser::parseCanvas):
        (WebCore::CSSParser::parseTransform):
        (WebCore::CSSParser::parseTransformOrigin):
        * css/CSSParser.h:
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):
        (WebCore::CSSParser::parseSVGStrokeDasharray):
        (WebCore::CSSParser::parseSVGPaint):
        (WebCore::CSSParser::parseSVGColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ap.
eric@webkit.org [Sat, 7 Jun 2008 10:32:57 +0000 (10:32 +0000)]
    Reviewed by ap.

        More cleanup to CSSParser, rename mediaQuery to m_mediaQuery
        Remove CSSParser::current and CSSParser::currentParser and use
        the magic of YYLEX_PARAM instead.

        * css/CSSParser.cpp:
        (WebCore::enterGeneratedParser):
        (WebCore::CSSParser::parseSheet):
        (WebCore::CSSParser::parseRule):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::parseMediaQuery):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Try to fix Gtk/gcc 4.3 build.
ap@webkit.org [Sat, 7 Jun 2008 10:20:31 +0000 (10:20 +0000)]
    Try to fix Gtk/gcc 4.3 build.

        * kjs/JSGlobalData.h: Include ustring.h instead of forward-declaring UString::Rep.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
jchaffraix@webkit.org [Sat, 7 Jun 2008 09:57:10 +0000 (09:57 +0000)]
WebCore:

2008-06-07  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Part of bug 19200: *.in files should embed more information
        https://bugs.webkit.org/show_bug.cgi?id=19200

        - Added XML attributes' parsing.

        - Moved (most) capitalization and audio hacks in the *.in files.

        * dom/make_names.pl:
        * html/HTMLTagNames.in:
        * svg/svgtags.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-07 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
mitz@apple.com [Sat, 7 Jun 2008 08:20:58 +0000 (08:20 +0000)]
2008-06-07  Pierre-Luc Beaudoin  <pierre-luc.beaudoin@collabora.co.uk>

        With the help of Jonathon Jongsma.

        Reviewed by Dan Bernstein.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19279
        REGRESSION (r32660): Text not redrawn correctly when selection changes

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        Add a condition for when ePos <= sPos

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 7 Jun 2008 07:58:38 +0000 (07:58 +0000)]
2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 17663: Wrong sequencing of argument list evaluation
        <https://bugs.webkit.org/show_bug.cgi?id=17663>

        SquirrelFish fixed this bug, but we should add a test.

        LayoutTests:

        * fast/js/order-of-operations-expected.txt:
        * fast/js/resources/order-of-operations.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Sat, 7 Jun 2008 06:03:24 +0000 (06:03 +0000)]
    Reviewed by Darin.

        Combine per-thread objects into one, to make it easier to support legacy clients (for
        which they shouldn't be really per-thread).

        No change on SunSpider total.

        * JavaScriptCore.xcodeproj/project.pbxproj: Added JSGlobalData.{h,cpp}

        * kjs/JSGlobalData.cpp: Added.
        (KJS::JSGlobalData::JSGlobalData):
        (KJS::JSGlobalData::~JSGlobalData):
        (KJS::JSGlobalData::threadInstance):
        * kjs/JSGlobalData.h: Added.
        This class encapsulates all data that should be per-thread (or shared between legacy clients).
        It will also keep a Heap pointer, but right now, Heap (Collector) methods are all static.

        * kjs/identifier.h:
        (KJS::Identifier::Identifier):
        Added a constructor explicitly taking JSGlobalData to access IdentifierTable. Actually,
        all of them should, but this will be a separate patch.

        * kjs/identifier.cpp:
        (KJS::IdentifierTable::literalTable):
        (KJS::createIdentifierTable):
        (KJS::deleteIdentifierTable):
        (KJS::Identifier::add):
        (KJS::Identifier::addSlowCase):
        Combined IdentifierTable and LiteralIdentifierTable into a single class for simplicity.

        * kjs/grammar.y: kjsyyparse now takes JSGlobalData, not just a Lexer.

        * kjs/nodes.cpp:
        (KJS::Node::Node):
        (KJS::EvalFunctionCallNode::emitCode):
        (KJS::ScopeNode::ScopeNode):
        Changed to access Lexer and Parser via JSGlobalData::threadInstance(). This is also a
        temporary measure, they will need to use JSGlobalData explicitly.

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::CodeGenerator):
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (KJS::callEval):
        * kjs/CommonIdentifiers.cpp:
        (KJS::CommonIdentifiers::CommonIdentifiers):
        * kjs/CommonIdentifiers.h:
        * kjs/DebuggerCallFrame.cpp:
        (KJS::DebuggerCallFrame::evaluate):
        * kjs/ExecState.cpp:
        (KJS::ExecState::ExecState):
        * kjs/ExecState.h:
        (KJS::ExecState::globalData):
        (KJS::ExecState::identifierTable):
        (KJS::ExecState::propertyNames):
        (KJS::ExecState::emptyList):
        (KJS::ExecState::lexer):
        (KJS::ExecState::parser):
        (KJS::ExecState::arrayTable):
        (KJS::ExecState::dateTable):
        (KJS::ExecState::mathTable):
        (KJS::ExecState::numberTable):
        (KJS::ExecState::RegExpImpTable):
        (KJS::ExecState::RegExpObjectImpTable):
        (KJS::ExecState::stringTable):
        * kjs/InitializeThreading.cpp:
        (KJS::initializeThreadingOnce):
        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::init):
        * kjs/JSGlobalObject.h:
        (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
        (KJS::JSGlobalObject::head):
        (KJS::JSGlobalObject::globalData):
        * kjs/Parser.cpp:
        (KJS::Parser::parse):
        * kjs/Parser.h:
        * kjs/function.cpp:
        (KJS::FunctionImp::getParameterName):
        (KJS::IndexToNameMap::unMap):
        (KJS::globalFuncEval):
        * kjs/function_object.cpp:
        (KJS::FunctionObjectImp::construct):
        * kjs/interpreter.cpp:
        (KJS::Interpreter::checkSyntax):
        (KJS::Interpreter::evaluate):
        * kjs/lexer.cpp:
        (kjsyylex):
        * kjs/lexer.h:
        * kjs/testkjs.cpp:
        (prettyPrintScript):
        Updated for the above changes. Most of threadInstance uses here will need to be replaced with
        explicitly passed pointers to support legacy JSC clients.

        * JavaScriptCore.exp: Removed KJS::parser().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-06 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 7 Jun 2008 04:51:02 +0000 (04:51 +0000)]
2008-06-06  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Bug 19424: Add support for logging opcode pair counts
        <https://bugs.webkit.org/show_bug.cgi?id=19424>

        JavaScriptCore:

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):
        * VM/Opcode.cpp:
        (KJS::OpcodeStats::OpcodeStats):
        (KJS::compareOpcodeIndices):
        (KJS::compareOpcodePairIndices):
        (KJS::OpcodeStats::~OpcodeStats):
        (KJS::OpcodeStats::recordInstruction):
        (KJS::OpcodeStats::resetLastInstruction):
        * VM/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
jchaffraix@webkit.org [Sat, 7 Jun 2008 02:11:30 +0000 (02:11 +0000)]
WebCore:

2008-06-06  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Part of bug 19200: *.in files should embed more information
        https://bugs.webkit.org/show_bug.cgi?id=19200

        - Switched *.in files to XML format.

        - Added (simple) parsing facilities in make_names.pl using the XML::Tiny Perl parser.

        - Updated the build systems to include bindings/scripts when executing make_names.pl
        (for XMLTiny dependency).

        - Cleaned-up make_names.pl a little.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * bindings/scripts/XMLTiny.pm: Added.
        * dom/make_names.pl:
        * html/HTMLAttributeNames.in:
        * html/HTMLTagNames.in:
        * svg/svgattrs.in:
        * svg/svgtags.in:
        * svg/xlinkattrs.in:
        * xml/xmlattrs.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-06 Robert Blaut <webkit@blaut.biz>
mrowe@apple.com [Fri, 6 Jun 2008 22:51:19 +0000 (22:51 +0000)]
2008-06-06  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19407
        CSS3 Selector Test: *= ~= ^= $= should all accept the empty string, but match nothing

        Test: fast/css/begin-end-contain-selector-empty-value.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

2008-06-06  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Darin Adler.

        Test for https://bugs.webkit.org/show_bug.cgi?id=19407
        CSS3 Selector Test: *= ~= ^= $= should all accept the empty string, but match nothing.

        * fast/css/begin-end-contain-selector-empty-value.html: Added.
        * platform/mac/fast/css/begin-end-contain-selector-empty-value-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by mitz.
eric@webkit.org [Fri, 6 Jun 2008 22:09:40 +0000 (22:09 +0000)]
    Reviewed by mitz.

        More cleanup of CSSParser.
        Rename CSSParser::numParsedProperties and maxNumParsedProperites to m_*

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::addProperty):
        (WebCore::CSSParser::rollbackLastProperties):
        (WebCore::CSSParser::clearProperties):
        (WebCore::CSSParser::parse4Values):
        (WebCore::CSSParser::createStyleRule):
        (WebCore::CSSParser::createFontFaceRule):
        * css/CSSParser.h:
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by mitz.
eric@webkit.org [Fri, 6 Jun 2008 22:03:41 +0000 (22:03 +0000)]
    Reviewed by mitz.

        More cleanup of CSSParser.
        Rename CSSParser::parsedProperties to m_parsedProperties.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseColor):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::addProperty):
        (WebCore::CSSParser::rollbackLastProperties):
        (WebCore::CSSParser::clearProperties):
        (WebCore::CSSParser::parse4Values):
        (WebCore::CSSParser::createStyleRule):
        (WebCore::CSSParser::createFontFaceRule):
        * css/CSSParser.h:
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by mitz.
eric@webkit.org [Fri, 6 Jun 2008 21:49:16 +0000 (21:49 +0000)]
    Reviewed by mitz.

        Start the cleanup of CSSParser.
        Rename CSSParser::styleElement to CSSParser::m_styleElement

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::document):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillImage):
        (WebCore::CSSParser::parseFontFaceSrc):
        (WebCore::CSSParser::parseBorderImage):
        (WebCore::CSSParser::createCharsetRule):
        (WebCore::CSSParser::createImportRule):
        (WebCore::CSSParser::createMediaRule):
        (WebCore::CSSParser::createStyleRule):
        * css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by adele. Landed by eseidel.
eric@webkit.org [Fri, 6 Jun 2008 21:07:06 +0000 (21:07 +0000)]
    Reviewed by adele.  Landed by eseidel.

        https://bugs.webkit.org/show_bug.cgi?id=18337

        Calls listBoxOnChange() in typeAheadFind() when the <select> tag is a listBox.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::typeAheadFind):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justin.garcia@apple.com [Fri, 6 Jun 2008 20:39:49 +0000 (20:39 +0000)]
WebCore:

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break

        Serialization of font-family:-webkit-monospace when it came from a
        CSSMutableStyleDeclaration would wrap the value in single quotes but
        serialization of the same property value pair from a CSSComputedStyleDeclaration
        wouldn't, which kept code that checked for and removed non-redundant styles from
        style spans from working correctly.

        A redundant style left on a style span would not normally create a rendering
        difference, but it did in this case because an element with
        font-family:-webkit-monospace does not appear to inherit font-size.
        Added a FIXME about how we might need to keep font-size on a style span if its
        non-redundant styles include font-family:-webkit-monospace, although I couldn't
        create a test case to produce this scenario.

        * css/FontFamilyValue.cpp:
        (WebCore::isValidCSSIdentifier): Don't return false if the String starts
        with a '-'.  This function now appears identical to isCSSTokenizerIdentifier,
        so perhaps we should use a single function.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::handleStyleSpans): Added FIXME.  Removed the
        creation of two Strings that were never used.

LayoutTests:

2008-06-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/5890684> REGRESSION(r23969): Deleting a line break changes the style of text after the break

        * editing/deleting/5890684-expected.txt: Added.
        * editing/deleting/5890684.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justin.garcia@apple.com [Fri, 6 Jun 2008 17:06:57 +0000 (17:06 +0000)]
WebCore:

2008-06-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <https://bugs.webkit.org/show_bug.cgi?id=19087>
        Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): applyStyle
        can destroy insertedPlaceholder if it needs to move it, but it will set an
        endingSelection() at [movedPlaceholder, 0] if it does so.  Re-fetch insertedPlaceholder
        if that happens.  The long term solution for these crashes is to make moveParagraphs
        not copy/destroy/move content, and to make VisiblePositions update themselves on DOM
        mutations.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::indentRegion): Early return to avoid crashes like this
        in the future, but ASSERT to catch them in debug builds.

LayoutTests:

2008-06-06  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <https://bugs.webkit.org/show_bug.cgi?id=19087>
        Editing crash in IndentOutdentCommand::prepareBlockquoteLevelForInsertion, ASSERT in debug mode

        * editing/execCommand/19087-expected.txt: Added.
        * editing/execCommand/19087.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-06 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 6 Jun 2008 16:48:54 +0000 (16:48 +0000)]
2008-06-06  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        <rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
        profiler.
        - Change the remaining functions that do not take arguments, from using
        recursion to using iteration.

        * JavaScriptCore.exp:
        * profiler/Profile.cpp:
        (KJS::stopProfiling):
        (KJS::restoreAll):
        (KJS::Profile::stopProfiling): Use foreach instead of recursion.
        (KJS::Profile::restoreAll): Ditto.
        * profiler/Profile.h:
        * profiler/ProfileNode.cpp: Remove recursion.
        (KJS::ProfileNode::stopProfiling):
        (KJS::ProfileNode::restore):
        * profiler/ProfileNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
jchaffraix@webkit.org [Fri, 6 Jun 2008 14:48:59 +0000 (14:48 +0000)]
LayoutTests:

2008-06-06  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Alexey.

        xmlhttprequest-onProgress-open-should-zero-length.html supposes that the onprogress event
        is dispatched 3 times to test that the position is reset when XMLHttpRequest.open() is
        called.
        The test was failing because CoreFoundation keeps the data if they are not big enough
        (which led to only 1 progress event dispatched).

        We now generate a big response instead of a small one.

        Warning: this test is not guaranteed to succeed as we cannot guarantee that the server
                 will send responses' sizes that are close for 2 different requests to the same
                 resource.

        * http/tests/xmlhttprequest/resources/big-response.php: Added.
        * http/tests/xmlhttprequest/resources/five-tiny-chunk-one-second-delay.php: Removed.

        * http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt: Added a
        warning about the possible failure of the test.
        * http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Greater and GreaterEq nodes to emit code in the correct order.
oliver@apple.com [Fri, 6 Jun 2008 05:09:27 +0000 (05:09 +0000)]
Fix Greater and GreaterEq nodes to emit code in the correct order.

Reviewed by Alexey.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justin.garcia@apple.com [Fri, 6 Jun 2008 04:44:08 +0000 (04:44 +0000)]
WebCore:

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric.

        <https://bugs.webkit.org/show_bug.cgi?id=19403>
        ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call

        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply): If the selection was all
        formatting (like an empty list) the format-less text will be empty.
        Early return to avoid the ASSERT that fires if input(...) is called
        with an empty String.

LayoutTests:

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric.

        <https://bugs.webkit.org/show_bug.cgi?id=19403>
        ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call

        * editing/execCommand/19403-expected.txt: Added.
        * editing/execCommand/19403.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Alp Toker <alp@nuanti.com>
alp@webkit.org [Fri, 6 Jun 2008 01:43:37 +0000 (01:43 +0000)]
2008-06-05  Alp Toker  <alp@nuanti.com>

        Add 'Since' documentation for API versioning functions.

        * webkit/webkitversion.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Alp Toker <alp@nuanti.com>
alp@webkit.org [Fri, 6 Jun 2008 01:09:31 +0000 (01:09 +0000)]
2008-06-05  Alp Toker  <alp@nuanti.com>

        Build fix for r34387.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 6 Jun 2008 01:00:16 +0000 (01:00 +0000)]
2008-06-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Alp Toker.

        Fix whitespaces.

        * kjs/collector.cpp:
        (KJS::getPlatformThreadRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 6 Jun 2008 00:50:29 +0000 (00:50 +0000)]
2008-06-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin.

        Support compiling JavaScriptCore for ARM.

        * kjs/collector.cpp:
        (KJS::getPlatformThreadRegisters):
        (KJS::otherThreadStackPointer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoOops, accidentally commited ChangeLog only.
antti@apple.com [Fri, 6 Jun 2008 00:49:37 +0000 (00:49 +0000)]
Oops, accidentally commited ChangeLog only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 6 Jun 2008 00:47:26 +0000 (00:47 +0000)]
2008-06-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin.

        Support compiling JavaScriptCore for ARM.

        * kjs/collector.cpp:
        (KJS::getPlatformThreadRegisters):
        (KJS::otherThreadStackPointer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 6 Jun 2008 00:33:28 +0000 (00:33 +0000)]
2008-06-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Jon.

        - Name changes.

        * JavaScriptCore.exp:
        * profiler/Profile.cpp:
        (KJS::Profile::Profile):
        (KJS::Profile::stopProfiling):
        (KJS::Profile::didExecute):
        (KJS::Profile::forEach):
        (KJS::Profile::debugPrintData):
        (KJS::Profile::debugPrintDataSampleStyle):
        * profiler/Profile.h:
        (KJS::Profile::callTree):
        (KJS::Profile::totalTime):
        (KJS::Profile::sortTotalTimeDescending):
        (KJS::Profile::sortTotalTimeAscending):
        (KJS::Profile::sortSelfTimeDescending):
        (KJS::Profile::sortSelfTimeAscending):
        (KJS::Profile::sortCallsDescending):
        (KJS::Profile::sortCallsAscending):
        (KJS::Profile::sortFunctionNameDescending):
        (KJS::Profile::sortFunctionNameAscending):
        (KJS::Profile::focus):
        (KJS::Profile::exclude):
        (KJS::Profile::restoreAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 6 Jun 2008 00:28:57 +0000 (00:28 +0000)]
2008-06-05  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Stephanie Lewis.

        Added the -fno-move-loop-invariants flag to the pcre_exec.cpp build, to
        tell GCC not to perform loop invariant motion, since GCC's loop
        invariant motion doesn't do very well with computed goto code.

        SunSpider reports no change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justin.garcia@apple.com [Fri, 6 Jun 2008 00:20:36 +0000 (00:20 +0000)]
WebCore:

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric.

        <https://bugs.webkit.org/show_bug.cgi?id=19089> Editing ASSERT in Range::compareBoundaryPoints

        ApplyStyleCommand::applyInlineStyle does some work and then checks to see
        if the start offset of the Range it's operating on is now past the caretMaxOffset
        of the start container.  If it is, applyInlineStyle updates the position to
        [startContainer->traverseNextNode(), 0] and then operates on that new start
        position.

        caretMaxOffset was incorrect for horizontal rules.  It should be 1 and it was 0.  So,
        if the horizontal rule was the last node in the document, applyInlineStyle would update
        its start position to [0, 0] and then try to operate on that position, assuming it was
        non-null, leading to the ASSERT.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::caretMaxOffset):

LayoutTests:

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Eric.

        <https://bugs.webkit.org/show_bug.cgi?id=19089> Editing ASSERT in Range::compareBoundaryPoints

        * editing/execCommand/19089-expected.txt: Added.
        * editing/execCommand/19089.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/5947396> AccessibilityListBoxOptions should return their string as...
cfleizach@apple.com [Thu, 5 Jun 2008 23:19:55 +0000 (23:19 +0000)]
<rdar://problem/5947396> AccessibilityListBoxOptions should return their string as AXValue, not AXTitle

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 5 Jun 2008 23:13:24 +0000 (23:13 +0000)]
2008-06-05  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Stephanie Lewis.

        Added the -fno-tree-pre flag to the Machine.cpp build, to tell GCC not
        to perform Partial Redundancy Elimination (PRE) on trees in Machine.cpp,
        since GCC's PRE doesn't do very well with computed goto code.

        SunSpider reports a .7% speedup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoPlease add a version to the Gtk port
christian@webkit.org [Thu, 5 Jun 2008 22:50:40 +0000 (22:50 +0000)]
Please add a version to the Gtk port
https://bugs.webkit.org/show_bug.cgi?id=14141

Reviewed by Alp Toker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 5 Jun 2008 22:40:23 +0000 (22:40 +0000)]
2008-06-05  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Stephanie Lewis (or maybe the other way around).

        Minor change to PCRE to help out certain compilers.

        SunSpider reports no change, maybe a small speedup.

        * pcre/pcre_exec.cpp:
        (match): Use instructionPtr++ a little less, to avoid confusing the
        optimizer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
justin.garcia@apple.com [Thu, 5 Jun 2008 22:34:19 +0000 (22:34 +0000)]
WebCore:

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Harrison.

        <rdar://problem/5658933> GoogleDocs: Crash indenting a particular selection twice
        <rdar://problem/5831310> CrashTracer: [USER] 4 crashes in Mail at WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion
        <rdar://problem/5480141> GoogleDocs: Attempting to indent content in <td> closes <table> element

        A crash would occur when indenting a selection that started just before a table
        and ended inside that table.  With a selection like this, we'd indent the entire
        table, then try and indent paragraphs inside it, but the stored position for the
        next paragraph to indent was inside content that had been removed from the document
        during the first Indent.

        Fixed the crash adjusting the selection to perform the indent on to prepare it
        for paragraph iteration using selectionForParagraphIteration.  We do this adjustment
        for paragraph iteration in InsertList as well.

        Also, indenting paragraphs inside table cells would break table structure because
        we were splitting the DOM all the way up to the root editable element to insert
        a blockquote.  Fixed this by only splitting up to the enclosing table cell.  This
        matches FF.  Lastly, fixed a bug where indenting several paragraphs inside different
        table cells would move all the selected text into the same table cell. FF still has
        this bug.

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::indentRegion):

LayoutTests:

2008-06-05  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Harrison.

        <rdar://problem/5658933> GoogleDocs: Crash indenting a particular selection twice

        * editing/execCommand/5658933-1-expected.txt: Added.
        * editing/execCommand/5658933-1.html: Added.
        * editing/execCommand/5658933-2-expected.txt: Added.
        * editing/execCommand/5658933-2.html: Added.
        * editing/execCommand/5658933-3-expected.txt: Added.
        * editing/execCommand/5658933-3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/5979998> AXList controls should have AXSelectedChildren and its child...
cfleizach@apple.com [Thu, 5 Jun 2008 22:17:56 +0000 (22:17 +0000)]
<rdar://problem/5979998> AXList controls should have AXSelectedChildren and its children's AXSelected attribute writable

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by mjs.
eric@webkit.org [Thu, 5 Jun 2008 22:01:34 +0000 (22:01 +0000)]
    Reviewed by mjs.

        Get rid of Uninitialized Memory Reads (UMRs) in the XPath::Value copy constructor.

        No functional changes, thus no tests.

        * xml/XPathValue.h:
        (WebCore::XPath::Value::Value): initialize all values in each constructor

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-04 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 5 Jun 2008 20:51:32 +0000 (20:51 +0000)]
2008-06-04  David Hyatt  <hyatt@apple.com>

        Fix for <rdar://problem/5957994> Height doesn't animate

        Improve the behavior when transitions are dynamically changed.  Make sure to leave older transitions
        running and let them obsolete themselves when they finish.

        Reviewed by Dan Bernstein

        Added WebCore/manual-tests/transitions2.html (must be tested manually)

        * manual-tests/transitions.html:
        * manual-tests/transitions2.html: Added.
        * page/AnimationController.cpp:
        (WebCore::ImplicitAnimation::property):
        (WebCore::ImplicitAnimation::setFinished):
        (WebCore::ImplicitAnimation::markedForDeath):
        (WebCore::ImplicitAnimation::setMarkedForDeath):
        (WebCore::ImplicitAnimation::ImplicitAnimation):
        (WebCore::ImplicitAnimation::reset):
        (WebCore::ImplicitAnimation::animate):
        (WebCore::CompositeImplicitAnimation::animate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by hyatt.
eric@webkit.org [Thu, 5 Jun 2008 20:33:42 +0000 (20:33 +0000)]
    Reviewed by hyatt.

        No functional changes, thus no tests.

        * platform/graphics/Color.h: remove unnecessary bitfield use

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Re-landing an independent part of a previously rolled out threading patch.
ap@webkit.org [Thu, 5 Jun 2008 20:03:43 +0000 (20:03 +0000)]
    Re-landing an independent part of a previously rolled out threading patch.

        * wtf/ThreadSpecific.h: Make sure to initialize POD thread-specific varaibles, too
        (replaced "new T" with "new T()").

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
antti@apple.com [Thu, 5 Jun 2008 19:56:44 +0000 (19:56 +0000)]
WebCore:

2008-06-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Dave Hyatt.

        Make hasFeature() return true for the animation stuff.

        * dom/DOMImplementation.cpp:
        (WebCore::isSVG11Feature):

LayoutTests:

2008-06-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Dave Hyatt.

        Make hasFeature() return true for the animation stuff.

        * svg/custom/svg-features-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 5 Jun 2008 17:54:59 +0000 (17:54 +0000)]
2008-06-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Hyatt.

        - force inlining of a template function that only has one call site per specialization
        1.3% speedup on SunSpider

        * kjs/collector.cpp:
        (KJS::Collector::heapAllocate): This template function is only
        called from allocate() and allocateNumber() (once per
        specialization) and the extra call overhead for GC allocation
        shows up, so force inlining.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Thu, 5 Jun 2008 16:55:13 +0000 (16:55 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19397
          REGRESSION (3.1-TOT): Box-shadow renders weird when rotating a div with border radius

        Test: fast/transforms/shadows.html

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setPlatformShadow): In Core Graphics, shadow
        dimensions are always in device space. Account for that, and apply the
        current context transform to shadow offset, and multiply the blur radius
        by the inverse of the operator norm of the inverse transform (which is
        the radius of the circle inscribed in the transformed unit circle).
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintBoxShadow): Added 1px separation between
        the edge of the filled shape and the edge of the clipped-out shape,
        because in a transformed context, due to antialiasing, the fill can
        bleed into the clip if they touch.

LayoutTests:

        Reviewed by Darin Adler.

        - pixel test for https://bugs.webkit.org/show_bug.cgi?id=19397
          REGRESSION (3.1-TOT): Box-shadow renders weird when rotating a div with border radius

        * fast/transforms/shadows.html: Added.
        * platform/mac/fast/transforms/shadows-expected.checksum: Added.
        * platform/mac/fast/transforms/shadows-expected.png: Added.
        * platform/mac/fast/transforms/shadows-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 5 Jun 2008 11:45:46 +0000 (11:45 +0000)]
2008-06-05  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Update layout tests on Mac based on the changes to html4.css
        in r34299. The missing backgroundClip and outlineClip in the
        new results is strange, but visually it looks the same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Thu, 5 Jun 2008 10:36:03 +0000 (10:36 +0000)]
2008-06-05  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Prevent cycles when converting from DOM objects to
        QVariant, due to cycles in the DOM tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 5 Jun 2008 10:30:06 +0000 (10:30 +0000)]
2008-06-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Alexey and Oliver.

        - remove profiler fetch hack
        I measure an 0.5% progression from this, others show a wash. It seems not needed any more.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-05 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 5 Jun 2008 09:19:48 +0000 (09:19 +0000)]
2008-06-05  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej.

        Bug 19400: subscript operator does not protect base when necessary
        <https://bugs.webkit.org/show_bug.cgi?id=19400>

        Use a temporary for the base in BracketAccessorNode if the subscript
        might possibly modify it.

        JavaScriptCore:

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (KJS::BracketAccessorNode::emitCode):
        * kjs/nodes.h:
        (KJS::BracketAccessorNode::):

        LayoutTests:

        * fast/js/codegen-temporaries-expected.txt:
        * fast/js/resources/codegen-temporaries.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 5 Jun 2008 05:36:55 +0000 (05:36 +0000)]
2008-06-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Big cleanup of formatting and whitespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-04 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 5 Jun 2008 04:39:09 +0000 (04:39 +0000)]
2008-06-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Add an option to dump statistics on executed instructions.

        JavaScriptCore:

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):
        * VM/Opcode.cpp:
        (KJS::):
        (KJS::OpcodeStats::~OpcodeStats):
        (KJS::OpcodeStats::recordInstruction):
        * VM/Opcode.h:

        WebKitTools:

        * Scripts/check-for-global-initializers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 5 Jun 2008 01:03:35 +0000 (01:03 +0000)]
2008-06-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        Get rid of DeprecatedPtrList from StyleSheetList.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        * css/StyleSheetList.cpp:
        (WebCore::StyleSheetList::~StyleSheetList):
        (WebCore::StyleSheetList::length):
        (WebCore::StyleSheetList::item):
        * css/StyleSheetList.h:
        (WebCore::StyleSheetList::swap):
        * dom/Document.cpp:
        (WebCore::Document::recalcStyleSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 5 Jun 2008 00:31:18 +0000 (00:31 +0000)]
2008-06-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Convert more classes over to start out with a ref count of 1.

        * css/CSSImageGeneratorValue.cpp:
        (WebCore::CSSImageGeneratorValue::generatedImage):
        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::cachedImage):
        * css/CSSMediaRule.cpp:
        (WebCore::CSSMediaRule::CSSMediaRule):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseFillSize):
        (WebCore::CSSParser::parseCounter):
        (WebCore::CSSParser::createRuleList):
        * css/CSSRuleList.cpp:
        (WebCore::CSSRuleList::CSSRuleList):
        * css/CSSRuleList.h:
        (WebCore::CSSRuleList::create):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchRules):
        (WebCore::CSSStyleSelector::styleRulesForElement):
        * css/CSSStyleSelector.h:
        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::cssRules):
        (WebCore::CSSStyleSheet::addSubresourceURLStrings):
        * css/CSSStyleSheet.h:
        (WebCore::CSSStyleSheet::rules):
        * css/Pair.h:
        (WebCore::Pair::create):
        (WebCore::Pair::Pair):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::buffered):
        (WebCore::HTMLMediaElement::played):
        (WebCore::HTMLMediaElement::seekable):
        * html/TimeRanges.cpp:
        (TimeRanges::TimeRanges):
        * html/TimeRanges.h:
        (WebCore::TimeRanges::create):
        (WebCore::TimeRanges::TimeRanges):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::addCursor):
        (WebCore::RenderStyle::clearCursorList):
        * rendering/style/RenderStyle.h:
        (WebCore::StyleImage::~StyleImage):
        (WebCore::StyleImage::StyleImage):
        (WebCore::StyleCachedImage::create):
        (WebCore::StyleCachedImage::StyleCachedImage):
        (WebCore::StyleGeneratedImage::create):
        (WebCore::StyleGeneratedImage::StyleGeneratedImage):
        (WebCore::CursorList::create):
        (WebCore::CursorList::CursorList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/5983804> Editable web areas do not properly report the AXFocused...
cfleizach@apple.com [Wed, 4 Jun 2008 23:45:57 +0000 (23:45 +0000)]
<rdar://problem/5983804> Editable web areas do not properly report the AXFocused attribute

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-03 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Wed, 4 Jun 2008 22:04:32 +0000 (22:04 +0000)]
2008-06-03  Beth Dakin  <bdakin@apple.com>

        Reviewed by Adele.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19381 WebKit
        Crashing Constantly on Gmail with accessibility turned on

        There was a missing null-check!

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::roleValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-04 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 4 Jun 2008 21:12:16 +0000 (21:12 +0000)]
2008-06-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Convert more classes to start with a ref count of 1.

        * bindings/js/JSCustomVoidCallback.cpp:
        (WebCore::toVoidCallback):
        * bindings/js/JSCustomVoidCallback.h:
        (WebCore::JSCustomVoidCallback::create):
        * css/StyleSheetList.cpp:
        (WebCore::StyleSheetList::StyleSheetList):
        * css/StyleSheetList.h:
        (WebCore::StyleSheetList::create):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::createNodeIterator):
        (WebCore::Document::createTreeWalker):
        * dom/NodeIterator.h:
        (WebCore::NodeIterator::create):
        * dom/Traversal.cpp:
        (WebCore::Traversal::Traversal):
        * dom/Traversal.h:
        * dom/TreeWalker.h:
        (WebCore::TreeWalker::create):
        * history/CachedPage.cpp:
        (WebCore::CachedPage::create):
        (WebCore::CachedPage::CachedPage):
        * html/CanvasGradient.cpp:
        (WebCore::CanvasGradient::CanvasGradient):
        * html/CanvasGradient.h:
        (WebCore::CanvasGradient::create):
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
        (WebCore::CanvasRenderingContext2D::createLinearGradient):
        (WebCore::CanvasRenderingContext2D::createRadialGradient):
        * html/CanvasRenderingContext2D.h:
        (WebCore::CanvasRenderingContext2D::create):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext):
        * html/VoidCallback.h:
        (WebCore::VoidCallback::VoidCallback):
        * loader/FormState.cpp:
        (WebCore::FormState::create):
        (WebCore::FormState::FormState):
        * platform/text/RegularExpression.cpp:
        (WebCore::RegularExpression::Private::create):
        (WebCore::RegularExpression::Private::Private):
        (WebCore::RegularExpression::RegularExpression):
        * storage/SQLResultSet.cpp:
        (WebCore::SQLResultSet::SQLResultSet):
        * storage/SQLResultSetRowList.h:
        (WebCore::SQLResultSetRowList::create):
        (WebCore::SQLResultSetRowList::SQLResultSetRowList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Wed, 4 Jun 2008 20:47:24 +0000 (20:47 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5962118> Crash in RenderBlock::calcColumnWidth()

        Test: fast/multicol/gap-non-negative.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Changed to not allow negative
        values for column-gap, per
        <http://www.w3.org/TR/2001/WD-css3-multicol-20010118/#column-gap>.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5962118> Crash in RenderBlock::calcColumnWidth()

        * fast/multicol/gap-non-negative-expected.txt: Added.
        * fast/multicol/gap-non-negative.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Wed, 4 Jun 2008 20:45:46 +0000 (20:45 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5962270> Crash in WebCore::RenderTableCell::computeAbsoluteRepaintRect()

        Test: fast/reflections/table-cell.html

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::computeAbsoluteRepaintRect): Null-check
        parent().
        (WebCore::RenderTableCell::absolutePosition): Ditto.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test for <rdar://problem/5962270> Crash in WebCore::RenderTableCell::computeAbsoluteRepaintRect()

        * fast/reflections/table-cell.html: Added.
        * platform/mac/fast/reflections/table-cell-expected.checksum: Added.
        * platform/mac/fast/reflections/table-cell-expected.png: Added.
        * platform/mac/fast/reflections/table-cell-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdded index.html files to specification directories so
dino@apple.com [Wed, 4 Jun 2008 20:00:48 +0000 (20:00 +0000)]
Added index.html files to specification directories so
things are easier to find.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-06-04 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 4 Jun 2008 18:53:10 +0000 (18:53 +0000)]
2008-06-04  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        <rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
        profiler.
        - This patch removes the use of recursion for the sort functions.

        * JavaScriptCore.exp: Change the signatures of the functions being
        exported.
        * profiler/Profile.cpp:
        (KJS::Profile::sort): This generic function will accept any of the
        static sort functions and apply them to the whole tree.
        * profiler/Profile.h: All of the sorting functions now call the new
        sort() function.
        (KJS::Profile::sortTotalTimeDescending):
        (KJS::Profile::sortTotalTimeAscending):
        (KJS::Profile::sortSelfTimeDescending):
        (KJS::Profile::sortSelfTimeAscending):
        (KJS::Profile::sortCallsDescending):
        (KJS::Profile::sortCallsAscending):
        (KJS::Profile::sortFunctionNameDescending):
        (KJS::Profile::sortFunctionNameAscending):
        * profiler/ProfileNode.cpp:
        (KJS::ProfileNode::ProfileNode): m_head used to point to the head node
        if this was the head node.  It now points to null to make iteration easy
        (KJS::ProfileNode::willExecute): Now must check if m_head is null, this
        check used to happend in the constructor.
        (KJS::ProfileNode::stopProfiling): Again the check is slightly different
        to determine if this is the head.
        (KJS::ProfileNode::traverseNextNode): This function returns the next
        node in post order.
        (KJS::ProfileNode::sort): This generic function will sort according to
        the comparator passed in, then reset the children pointers to macth the
        new order.
        * profiler/ProfileNode.h: The sorting function were removed from the
        definition file and instead use the new generic sort() function
        (KJS::ProfileNode::totalPercent): because the head can now be empty we
        need to check here too for the head node.
        (KJS::ProfileNode::selfPercent): Ditto
        (KJS::ProfileNode::firstChild): This function is necessary for the
        iterative algorithm in Profile.cpp.
        (KJS::ProfileNode::sortTotalTimeDescending):
        (KJS::ProfileNode::sortTotalTimeAscending):
        (KJS::ProfileNode::sortSelfTimeDescending):
        (KJS::ProfileNode::sortSelfTimeAscending):
        (KJS::ProfileNode::sortCallsDescending):
        (KJS::ProfileNode::sortCallsAscending):
        (KJS::ProfileNode::sortFunctionNameDescending):
        (KJS::ProfileNode::sortFunctionNameAscending):
        (KJS::ProfileNode::childrenBegin):
        (KJS::ProfileNode::childrenEnd):
        (KJS::ProfileNode::totalTimeDescendingComparator):
        (KJS::ProfileNode::totalTimeAscendingComparator):
        (KJS::ProfileNode::selfTimeDescendingComparator):
        (KJS::ProfileNode::selfTimeAscendingComparator):
        (KJS::ProfileNode::callsDescendingComparator):
        (KJS::ProfileNode::callsAscendingComparator):
        (KJS::ProfileNode::functionNameDescendingComparator):
        (KJS::ProfileNode::functionNameAscendingComparator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34362 268f45cc-cd09-0410-ab3c-d52691b4dbfc