14 years ago Reviewed by Adam.
timothy@apple.com [Sun, 28 Oct 2007 06:45:10 +0000 (06:45 +0000)]
    Reviewed by Adam.

        Bug 15727: Resizing the resource sidebar doesn't scale the font preview or network timeline

        Add one window resize listener and call the new resize function on the currentPanel.
        Also call the currentPanel's resize function when resizing the sidebar.

        * page/inspector/DocumentPanel.js: Implement resize and call updateTreeSelection() when
          the panel is shown and when resizing the DOM sidebar.
        * page/inspector/FontPanel.js: Implement resize.
        * page/inspector/NetworkPanel.js: Ditto.
        * page/inspector/inspector.js: Add a window resize listener.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
mjs [Sun, 28 Oct 2007 06:31:37 +0000 (06:31 +0000)]
    Reviewed by Oliver.

        - update for HashTable changes

        * bindings/js/JSSVGPODTypeWrapper.h:
        * dom/Document.h:
        * dom/QualifiedName.cpp:
        * dom/StyledElement.cpp:
        * ksvg2/svg/SVGAnimatedTemplate.h:
        * platform/FontCache.cpp:
        * platform/StringHash.h:
        * platform/TextEncodingRegistry.cpp:
        * platform/graphics/IntSizeHash.h:
        * plugins/win/PluginPackageWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-28 Alp Toker <alp@atoker.com>
alp [Sun, 28 Oct 2007 05:34:25 +0000 (05:34 +0000)]
2007-10-28  Alp Toker  <alp@atoker.com>

        Reviewed by Adam Roben.

        [GTK] caretBlinkFrequency is hard-coded in Frame.cpp

        Abstract caretBlinkFrequency to RenderTheme.

        * page/Frame.cpp:
        * platform/gtk/RenderThemeGtk.cpp:
        * platform/gtk/RenderThemeGtk.h:
        * rendering/RenderTheme.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-28 Lars Lindner <lars.lindner@gmail.com>
alp [Sun, 28 Oct 2007 05:22:51 +0000 (05:22 +0000)]
2007-10-28  Lars Lindner  <lars.lindner@gmail.com>

        Reviewed by Alp.

        [gtk] widget does not take focus on mouse click

        Grab widget focus in mouse press callback.

        * Api/webkitgtkpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Updated Windows Skipped file for currently failing tests
aroben [Sun, 28 Oct 2007 05:02:19 +0000 (05:02 +0000)]
    Updated Windows Skipped file for currently failing tests

        Reviewed by NOBODY.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix HTMLDocument12.xhtml on Leopard/Windows
aroben [Sun, 28 Oct 2007 04:38:01 +0000 (04:38 +0000)]
     Fix HTMLDocument12.xhtml on Leopard/Windows

         <rdar://5313535> and <rdar://5539816>

         The test succeeds on Leopard and Windows, but fails on Tiger. For some
         reason, failing expected results had been checked in to
         platform/mac-leopard. The test seems to be passing now, so I moved the
         failing results to platform/mac-tiger.

         Reviewed by Maciej and Sam.

         * platform/mac-leopard/dom/xhtml/level2/html/HTMLDocument12-expected.txt: Removed.
         * platform/mac-tiger/dom/xhtml/level2/html/HTMLDocument12-expected.txt:
         Moved from platform/mac-leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
timothy@apple.com [Sun, 28 Oct 2007 04:24:31 +0000 (04:24 +0000)]
    Reviewed by Adam.

        Don't print the line number in the Inspector Console if it is Zero.

        * page/inspector/ConsolePanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Sun, 28 Oct 2007 03:31:47 +0000 (03:31 +0000)]
    Reviewed by Eric.

        - fix ASCIICType.h for some Windows compiles

        * wtf/ASCIICType.h: Check the compiler, not the OS, since it's the
        compiler/library that has the wchar_t that is just a typedef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Hit with the rubber-stamp of Timothy Hatcher.
weinig [Sun, 28 Oct 2007 03:12:44 +0000 (03:12 +0000)]
    Hit with the rubber-stamp of Timothy Hatcher.

        Tests for window.console's functions.

        * fast/dom/Window/console-functions-expected.txt: Added.
        * fast/dom/Window/console-functions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
weinig [Sun, 28 Oct 2007 02:52:54 +0000 (02:52 +0000)]
    Reviewed by Tim Hatcher.

        Speculative fix for an intermittently failing test

        * fast/dom/Window/resources/opened-window.html: Added.
        * fast/dom/Window/window-early-properties.html: Use onload for opened
        window and use a local file instead of a data: URL to avoid same origin
        check issues.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig [Sun, 28 Oct 2007 02:11:55 +0000 (02:11 +0000)]

        Reviewed by Adam Roben.

        Fix http://bugs.webkit.org/show_bug.cgi?id=14953
        Implement window.console in WebCore

        - Adds a window.console object that has 4 methods (log, info, warn, and error)
          that send messages to the Chrome.  This moves functionality that was in the
          app down into WebCore.

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/scripts/CodeGeneratorJS.pm: Add extended attribute
        to mark attributes as [Replacable] which indicates they can
        overridden when set.
        * page/Chrome.cpp:
        (WebCore::Chrome::addMessageToConsole): Allow all messages to go
        up to the ChromeClient.
        * page/Console.cpp: Added.
        * page/Console.h: Added.
        * page/Console.idl: Added.
        * page/DOMWindow.cpp:
        * page/DOMWindow.h:
        * page/DOMWindow.idl:


        Reviewed by Adam Roben.

        Update tests for http://bugs.webkit.org/show_bug.cgi?id=14953
        Implement window.console in WebCore

        * fast/dom/Window/window-properties-expected.txt:
        * http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate results
pewtermoose [Sun, 28 Oct 2007 00:47:42 +0000 (00:47 +0000)]
Update results

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Speculative fix for an intermittently failing test
aroben [Sun, 28 Oct 2007 00:02:59 +0000 (00:02 +0000)]
     Speculative fix for an intermittently failing test

         Reviewed by Sam and Eric.

         * http/tests/local/style-access-before-stylesheet-loaded.html: Use

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-27 Eric Seidel <eric@webkit.org>
eseidel [Sat, 27 Oct 2007 23:53:45 +0000 (23:53 +0000)]
2007-10-27  Eric Seidel  <eric@webkit.org>

        Reviewed by aroben.

        Remove legacy createFilterEffect function (causing extra filter tests to fail on windows)

        No functional changes, thus no tests.

        * ksvg2/svg/SVGFEBlendElement.cpp:
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        * ksvg2/svg/SVGFEComponentTransferElement.cpp:
        * ksvg2/svg/SVGFECompositeElement.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        * ksvg2/svg/SVGFEFloodElement.cpp:
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        * ksvg2/svg/SVGFEImageElement.cpp:
        * ksvg2/svg/SVGFEMergeElement.cpp:
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        * ksvg2/svg/SVGFETileElement.cpp:
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        * platform/graphics/svg/SVGResourceFilter.h:
        * platform/graphics/svg/cg/SVGResourceFilterCg.cpp:
        * platform/graphics/svg/cg/SVGResourceFilterCg.mm:
        * platform/graphics/svg/qt/SVGResourceFilterQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add some more failing tests to the Windows Skipped file
aroben [Sat, 27 Oct 2007 23:31:30 +0000 (23:31 +0000)]
    Add some more failing tests to the Windows Skipped file

        Reviewed by NOBODY.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
kmccullo [Sat, 27 Oct 2007 23:26:58 +0000 (23:26 +0000)]
    Reviewed by Adam.

        - Stubbed out IWebScriptCallFrame for Drosera.

        * Interfaces/IWebScriptCallFrame.idl: Added function declarations.
        * WebKit.vcproj/WebKit.vcproj: Added .h/.cpp files to the project.
        * WebScriptCallFrame.cpp: Added.
        * WebScriptCallFrame.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz [Sat, 27 Oct 2007 23:25:24 +0000 (23:25 +0000)]

        Reviewed by Darin Adler.

        - fix a crash when opening Zenoss server history view

        Test: fast/table/colgroup-relative.html

        * rendering/LayoutState.cpp:
        (WebCore::LayoutState::LayoutState): Added a hasLayer() check before
        accessing layer().


        Reviewed by Darin Adler.

        - test for <rdar://problem/5530657>

        * fast/table/colgroup-relative-expected.txt: Added.
        * fast/table/colgroup-relative.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - BuildFix
kmccullo [Sat, 27 Oct 2007 22:45:04 +0000 (22:45 +0000)]
    - BuildFix
        - Forgot to change the build step when I changed the filename.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
ggaren [Sat, 27 Oct 2007 19:20:25 +0000 (19:20 +0000)]
    Reviewed by Darin Adler.

        Fixed the rest of "ASSERTION FAILED: _hash in KJS::UString::Rep::

        * kjs/identifier.cpp: Fixed more cases where an Identifier didn't get a
        hash value. Also changed O(n) strlen to O(1) check for empty string.

        * kjs/ustring.cpp: Changed O(n) strlens to O(1) checks for empty string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Sat, 27 Oct 2007 19:10:40 +0000 (19:10 +0000)]
    Reviewed by Eric.

        - a couple of Windows fixes

        * wtf/MathExtras.h: (wtf_pow): Add a special case for MSVC, which has
        a "pow" function that does not properly handle the case where arg1 is
        NaN and arg2 is 0.

        * kjs/math_object.cpp: (MathFuncImp::callAsFunction): Don't explicity
        specify "::pow" -- just "pow" is fine.

        * wtf/ASCIICType.h: Check the compiler, not the OS, since it's the
        compiler/library that has the wchar_t that is just a typedef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-27 Julien <julien.chaffraix@gmail.com>
ap [Sat, 27 Oct 2007 18:51:25 +0000 (18:51 +0000)]
2007-10-27  Julien  <julien.chaffraix@gmail.com>

        Reviewed by Alexey.

        XMLHttpRequest should set readyState to 0 after abort()

        Test: http/tests/xmlhttprequest/xmlhttprequest-abort-readyState.html

        * xml/XMLHttpRequest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
mitz [Sat, 27 Oct 2007 16:54:19 +0000 (16:54 +0000)]

        Reviewed by Dave Hyatt.

        - fix rotated border images by using a temporary subimage containing
          only the part we want to tile

        Test: fast/borders/border-image-rotate-transform.html

        * platform/graphics/cg/ImageCG.cpp:


        Reviewed by Dave Hyatt.

        - rotated border image test

        * fast/borders/border-image-rotate-transform.html: Added.
        * platform/mac/fast/borders/border-image-rotate-transform-expected.checksum: Added.
        * platform/mac/fast/borders/border-image-rotate-transform-expected.png: Added.
        * platform/mac/fast/borders/border-image-rotate-transform-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Sat, 27 Oct 2007 14:48:34 +0000 (14:48 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15711
          force JSImmediate to be inlined for roughly 1.2% SunSpider speedup

        * kjs/JSImmediate.h: Put ALWAYS_INLINE on everything.

        * kjs/object.h: Removed redundant includes.
        * kjs/value.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-27 Mark Ambachtsheer <mark.a@apple.com>
mrowe@apple.com [Sat, 27 Oct 2007 10:46:23 +0000 (10:46 +0000)]
2007-10-27  Mark Ambachtsheer  <mark.a@apple.com>

        Reviewed by Darin.

        Fix for bug 15710, When QD plugins draw to an offscreen bitmap and the plugin is not at
        (0, 0) the clipping rectangle is not correct.
        Added the origin to the window clip rectangle coordinates to account for plugins that
        don't originate at (0,0); affects code for offscreen GWorlds only.

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-27 Jan Michael Alonzo <jmalonzo@unpluggable.com>
alp [Sat, 27 Oct 2007 10:39:34 +0000 (10:39 +0000)]
2007-10-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Alp.

        [GTK] Refactor gtk/RenderThemeGtk and implement a few more methods

        Refactor/enhance GTK RenderTheme

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::supportsFocus): added TextArea, Menulist, Radio, and Checkbox Appearances
        (WebCore::RenderThemeGtk::supportsFocusRing): call supportsFocus() to check if focus on appearance is supported
        (WebCore::RenderThemeGtk::controlSupportsTints): copied from Qt and Safari ports
        (WebCore::RenderThemeGtk::baselinePosition): copied from Qt and Safari ports
        (WebCore::RenderThemeGtk::paintCheckbox): moved painting in paintButton
        (WebCore::RenderThemeGtk::paintRadio): moved painting in paintButton
        (WebCore::RenderThemeGtk::paintButton): paint the different buttons here, checking for the right appearance before doing so
        (WebCore::RenderThemeGtk::paintMenuList): use 0 instead of NULLs
        * platform/gtk/RenderThemeGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark.
mjs [Sat, 27 Oct 2007 10:23:39 +0000 (10:23 +0000)]
    Reviewed by Mark.

        - fixed "ASSERTION FAILED: _hash in KJS::UString::Rep::computedHash()"

        * kjs/identifier.cpp:
        (KJS::Identifier::addSlowCase): Ensure that empty Identifiers have a hash computed,
        now that we count on all Identifiers already having one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Sat, 27 Oct 2007 08:40:23 +0000 (08:40 +0000)]
    Reviewed by Darin.

        XMLHttpRequest does not support charset "x-user-defined", which can
        facilitate loading of binary data

        Test: http/tests/xmlhttprequest/binary-x-user-defined.html

        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/TextCodecUserDefined.cpp: Added.
        * platform/TextCodecUserDefined.h: Added.
        * platform/TextEncodingRegistry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Sat, 27 Oct 2007 08:16:26 +0000 (08:16 +0000)]
    Reviewed by Darin.

        Setting innerHTML to blank string in application/xhtml+xml mode
        throws DOM Exception 7

        Test: fast/dom/blank-innerHTML.xhtml

        * dom/XMLTokenizer.cpp:
        (WebCore::parseXMLDocumentFragment): Bail out early if the input string is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-27 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Sat, 27 Oct 2007 08:11:42 +0000 (08:11 +0000)]
2007-10-27  Mark Rowe  <mrowe@apple.com>

        Silence a warning.

        * kjs/SymbolTable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-27 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Sat, 27 Oct 2007 08:08:30 +0000 (08:08 +0000)]
2007-10-27  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Enable dragging the left sidebar using the separator.
weinig [Sat, 27 Oct 2007 04:42:18 +0000 (04:42 +0000)]
    Enable dragging the left sidebar using the separator.

        Reviewed by Anders (unless Mitz says otherwise).

        * page/inspector/DocumentPanel.js:
        * page/inspector/inspector.css:
        * page/inspector/inspector.html:
        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix an off by one error when resizing the Inspector find window.
weinig [Sat, 27 Oct 2007 03:40:26 +0000 (03:40 +0000)]
    Fix an off by one error when resizing the Inspector find window.

        Reviewed by Hyatt.

        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-26 Jon Honeycutt <jhoneycutt@apple.com>
honeycutt [Sat, 27 Oct 2007 02:56:17 +0000 (02:56 +0000)]
2007-10-26  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Adam.

        Fix fallout from r26072, which leads to all plugin streams for local
        resources being cancelled

        * loader/win/NetscapePlugInStreamLoaderWin.cpp:
        (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Ensure this
        is an HTTP response before checking the HTTP response code

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for http://bugs.webkit.org/show_bug.cgi?id=15719, transformed box doesn...
hyatt [Sat, 27 Oct 2007 02:50:56 +0000 (02:50 +0000)]
    Fix for bugs.webkit.org/show_bug.cgi?id=15719, transformed box doesn't repaint properly
        when only translation changes.

        Move the updating of the transform to in between the old repaint and the new repaint.

        Reviewed by mitz


        * rendering/RenderLayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamp by Adam.
kmccullo [Sat, 27 Oct 2007 01:45:46 +0000 (01:45 +0000)]
   Rubber stamp by Adam.

        - Renamed JSStringRefCOM to JSStringRefBSTR since it he only thing the
        files contain are functions that operate on BSTRs.

        * API/JSStringRefBSTR.cpp: Copied from API/JSStringRefCOM.cpp.
        * API/JSStringRefBSTR.h: Copied from API/JSStringRefCOM.h.
        * API/JSStringRefCOM.cpp: Removed.
        * API/JSStringRefCOM.h: Removed.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
kmccullo [Sat, 27 Oct 2007 01:38:57 +0000 (01:38 +0000)]
    Reviewed by Adam.

        - Implemented the WebScriptDebugListener functions now that the
        WebScriptDebugServer exists

        * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
        * Drosera/win/ServerConnection.h: Removed unused arguments from the
        members arguments list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
kmccullo [Sat, 27 Oct 2007 01:37:04 +0000 (01:37 +0000)]
    Reviewed by Adam.

        - Made JSStringCreateWithBSTR capable of handling null BSTRs.

        * API/JSStringRefCOM.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix.
weinig [Sat, 27 Oct 2007 01:01:20 +0000 (01:01 +0000)]
    Windows build fix.

        * kjs/SymbolTable.h: Add header gaurd.
        * kjs/nodes.h: #include "SymbolTable.h"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Suggested by Anders Carlsson.
ggaren [Fri, 26 Oct 2007 23:33:03 +0000 (23:33 +0000)]
    Suggested by Anders Carlsson.

        Fixed tyop.

        * kjs/function.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Suggested by Darin Adler.
ggaren [Fri, 26 Oct 2007 23:31:14 +0000 (23:31 +0000)]
    Suggested by Darin Adler.

        Use computedHash(), which is safer than just directly accessing _hash.

        * kjs/lookup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-26 Jon Honeycutt <jhoneycutt@apple.com>
honeycutt [Fri, 26 Oct 2007 23:07:19 +0000 (23:07 +0000)]
2007-10-26  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        <rdar://5557379> Crash in Silverlight when opening microsoft.com

        The crash is within Silverlight, and the latest version of the plugin
        does not exhibit this crash, so just avoid loading this version of the

        * plugins/win/PluginDatabaseWin.cpp: Added isPluginBlacklisted() and
        constants silverlightPluginMinRequiredVersionMSDWORD and
        silverlightPluginMinRequiredVersionLSDWORD. Their values are taken from
        the version info of Silverlight 1.0.20926.0, which is a version known
        not to exhibit this crash
        (WebCore::PluginDatabaseWin::isPluginBlacklisted): Determine whether
        this plugin is blacklisted
        * plugins/win/PluginDatabaseWin.h:
        * plugins/win/PluginPackageWin.cpp:
        (WebCore::PluginPackageWin::PluginPackageWin): Initialize m_fileVersion*
        (WebCore::PluginPackageWin::storeFileVersion): Read version info for
        the plugin, and store the file version
        (WebCore::PluginPackageWin::fetchInfo): After determining the name,
        description, and file version, determine whether this plug-in is
        blacklisted. If so, return false so this plug-in isn't loaded
        * plugins/win/PluginPackageWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix: svn add SymbolTable.h
ggaren [Fri, 26 Oct 2007 22:59:25 +0000 (22:59 +0000)]
    Build fix: svn add SymbolTable.h

        * kjs/SymbolTable.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix: export SymbolTable.h to WebCore.
ggaren [Fri, 26 Oct 2007 22:54:46 +0000 (22:54 +0000)]
    Build fix: export SymbolTable.h to WebCore.

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Comment tweak suggested by Maciej.
ggaren [Fri, 26 Oct 2007 22:47:33 +0000 (22:47 +0000)]
    Comment tweak suggested by Maciej.

        * kjs/function.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej Stachowiak.
ggaren [Fri, 26 Oct 2007 22:45:34 +0000 (22:45 +0000)]
    Reviewed by Maciej Stachowiak.

        Tweaked property maps to remove 2 branches. 2.5% speedup on SunSpider.

        * kjs/property_map.cpp: Use a special no branch accessor to the UString's
        hash value. Also, return immediately instead of branching to the end
        of the loop if the value is not found.

        * kjs/ustring.h:
        (KJS::UString::Rep::computedHash): Special no branch accessor to the
        UString's hash value. Used when the caller knows that the hash value
        has already been computed. (For example, if the caller got the UString
        from an Identifier.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej Stachowiak.
ggaren [Fri, 26 Oct 2007 22:43:03 +0000 (22:43 +0000)]
    Reviewed by Maciej Stachowiak.

        Switched ActivationImp to using a symbol table. For now, though, all
        clients take the slow path.

        Net .6% speedup on SunSpider.

            - ActivationImp now mallocs in its constructor
            - Local variable hits use an extra level of indirection to retrieve
            - Local variable misses do two lookups

            - Fast initialization of local variables upon function entry

        * JavaScriptCore.xcodeproj/project.pbxproj: Added SymbolTable.h

        * kjs/function.cpp:
        (KJS::ActivationImp::ActivationImp): Malloc a private structure to hold
        data that won't fit in a JSCell.
        (KJS::ActivationImp::argumentsGetter): Use slow symbol table path for
        (KJS::ActivationImp::getOwnPropertySlot): ditto
        (KJS::ActivationImp::deleteProperty): ditto
        (KJS::ActivationImp::put): ditto
        (KJS::ActivationImp::createArgumentsObject): ditto

        (KJS::ActivationImp::mark): Call JSObject::mark first so that one of
        our properties doesn't try to recursively mark us. (This caused a crash
        in earlier testing. Not sure why we haven't run into it before.)

        * kjs/nodes.cpp: Functions now build a symbol table the first time
        they're called.

        * kjs/nodes.h:

        * wtf/Forward.h: Added Vector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele Peterson.
weinig [Fri, 26 Oct 2007 21:44:49 +0000 (21:44 +0000)]
    Reviewed by Adele Peterson.

        Fix for <rdar://problem/5421754>
        m_frameName member variable in HTMLPlugInElement unnecessary

        - Refactor the willRemove() method down into HTMLFrameOwnerElement now that
          we no longer need to use the m_frameName variable.

        * html/HTMLFrameElementBase.cpp:
        * html/HTMLFrameElementBase.h:
        * html/HTMLFrameOwnerElement.cpp:
        * html/HTMLFrameOwnerElement.h:
        * html/HTMLPlugInElement.cpp:
        * html/HTMLPlugInElement.h:
        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - Corrected function name mistake in this changelog.
kmccullo [Fri, 26 Oct 2007 21:28:41 +0000 (21:28 +0000)]
    - Corrected function name mistake in this changelog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
kmccullo [Fri, 26 Oct 2007 21:19:44 +0000 (21:19 +0000)]

        Reviewed by Sam and Steve.

        - Added convenience methods for converting between BSTR and JSStringRefs

        * API/JSStringRefCOM.cpp: Added.
        * API/JSStringRefCOM.h: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:


        Reviewed by Sam and Steve.

        - Added convenience methods for converting between BSTR and JSSTringRefs
        - Added WebKit_debug.def to the project.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit.vcproj:
        * WebKit.vcproj/WebKit_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReverting an unintentional added symbol
adele [Fri, 26 Oct 2007 21:03:24 +0000 (21:03 +0000)]
Reverting an unintentional added symbol

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Export _wkDrawCapsLockIndicator.
adele [Fri, 26 Oct 2007 20:55:58 +0000 (20:55 +0000)]
    Export _wkDrawCapsLockIndicator.

        * WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
adele [Fri, 26 Oct 2007 20:28:24 +0000 (20:28 +0000)]
    Reviewed by Tim Hatcher.

        Updating header too for WKDrawCapsLockIndicator.

        * WebKitSystemInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Fri, 26 Oct 2007 19:52:42 +0000 (19:52 +0000)]

        Reviewed by Oliver.

        Adding WebKitSystemInterface support for the caps lock indicator

        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:


        Reviewed by Oliver.

        Adding WebKitSystemInterface support for the caps lock indicator

        * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):


        Reviewed by Oliver.

        Adding wkDrawCapsLockIndicator in preparation for fixing the caps lock indicator.

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
tristan [Fri, 26 Oct 2007 19:22:11 +0000 (19:22 +0000)]

        Reviewed by Darin Adler.

        <rdar://problem/5555053> REGRESSION:9A581: Window disappears when opening http://research.microsoft.com/users/darkok/
        The problem was caused by checkin r24654. This change moved explicit bounds checking into adjustWindowRect
        but failed to account for bounds checking (instead replaced with bounds clipping).  This caused issues
        when NaN was used. This patch goes one step further and does NaN checking to prevent the possibility of
        setting window bounds to NaN before an update occurs.

        Test: fast/dom/Window/window-resize-nan.html

        * bindings/js/kjs_window.cpp:
        Added a new parameter, pendingChanges, which takes pending changes to the window
        rect, and if they are valid (not NaN) sets them on window.

        Adjusted uses of adjustWindowRect to take new update parameter.


        Reviewed by Darin Adler.

        Added new test cases to handle non-number input to window adjusting
        functions like resizeTo, resizeBy, moveTo, and moveBy for

        * fast/dom/Window/window-resize-nan-expected.txt: Added.
        * fast/dom/Window/window-resize-nan.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
weinig [Fri, 26 Oct 2007 18:39:43 +0000 (18:39 +0000)]
    Reviewed by Tim Hatcher.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=15175
        Cannot copy text of errors from Web Inspector from Console view

        * page/inspector/inspector.css: add -webkit-user-select: text for console messages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
weinig [Fri, 26 Oct 2007 18:17:04 +0000 (18:17 +0000)]
    Reviewed by Tim Hatcher.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=15446
        Web Inspector find window is not resizable

        - Adds ability to resize the find window.
        - Fixes bug that messed up the find window when resizing the left sidebar.

        * page/inspector/inspector.css:
        * page/inspector/inspector.html:
        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Update m_current index after we've removed an item:
adachan [Fri, 26 Oct 2007 16:34:53 +0000 (16:34 +0000)]
    Update m_current index after we've removed an item:
        - if item removed is before m_current, decrement m_current
        - if the current item is removed, make sure m_current is within bounds.

        Reviewed by Darin.

        * history/BackForwardList.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
ddkilzer [Fri, 26 Oct 2007 15:38:48 +0000 (15:38 +0000)]
    prepare-ChangeLog and update-webkit create needless ChangeLog conflicts

        Reviewed by Darin.

        The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
        a patch of the local changes and applying it with a fuzz level of 3 to the new file.
        If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
        file.  Note that it may also be used as a stand-alone script.

        * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
        * Scripts/resolve-ChangeLogs: Added.
        * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRestore the semicolon.
mrowe@apple.com [Fri, 26 Oct 2007 13:34:39 +0000 (13:34 +0000)]
Restore the semicolon.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 13:31:15 +0000 (13:31 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Windows build fix.

        * kjs/collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 12:22:37 +0000 (12:22 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Build fix.  Add missing #include of Platform.h.

        * Api/qwebhistoryinterface.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 12:07:39 +0000 (12:07 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Debug build fix.

        * bindings/js/kjs_proxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake the JSC GC use a separate heap for JSNumbers to get a 0.7-1.4% progression in...
oliver [Fri, 26 Oct 2007 12:06:33 +0000 (12:06 +0000)]
Make the JSC GC use a separate heap for JSNumbers to get a 0.7-1.4% progression in SunSpider.

Reviewed by Maciej

        * kjs/CollectorHeapIntrospector.cpp:
        * kjs/CollectorHeapIntrospector.h:
        * kjs/collector.cpp:
        * kjs/collector.h:
        * kjs/internal.h:
        (KJS::NumberImp::operator new):
          Force numbers to be allocated in the secondary heap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago No review, build fix.
mjs [Fri, 26 Oct 2007 11:53:15 +0000 (11:53 +0000)]
    No review, build fix.

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]):
        (-[WebScriptObject setException:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber Stamped by Mark.
mjs [Fri, 26 Oct 2007 11:50:21 +0000 (11:50 +0000)]
    Rubber Stamped by Mark.

        - fix build

        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame scopeChain]):
        (-[WebCoreScriptCallFrame functionName]):
        (-[WebCoreScriptCallFrame evaluateWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber Stamped by Oliver.
mjs [Fri, 26 Oct 2007 11:48:08 +0000 (11:48 +0000)]
    Rubber Stamped by Oliver.

        - fix build

        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame scopeChain]):
        (-[WebCoreScriptCallFrame functionName]):
        (-[WebCoreScriptCallFrame evaluateWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
mjs [Fri, 26 Oct 2007 11:46:13 +0000 (11:46 +0000)]
    Reviewed by Oliver.

        - encourage GCC a little harder to inline a few hot functions for 1.5% improvement on SunSpider.

        * kjs/value.h:
        * wtf/PassRefPtr.h:
        * wtf/RefPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix ChangeLog ordering.
mrowe@apple.com [Fri, 26 Oct 2007 10:45:37 +0000 (10:45 +0000)]
Fix ChangeLog ordering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 10:44:24 +0000 (10:44 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * kjs/ExecState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Windows build fix.
mjs [Fri, 26 Oct 2007 10:36:45 +0000 (10:36 +0000)]
    Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 09:38:51 +0000 (09:38 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 09:38:31 +0000 (09:38 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * JavaScriptCore.pri:
        * kjs/ExecState.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
mjs [Fri, 26 Oct 2007 08:32:40 +0000 (08:32 +0000)]

        Reviewed by Oliver.

        - moved Context class into ExecState.{h,cpp} in preparation for merging
        ExecState and Context classes.

        * kjs/ExecState.h: Moved CodeType enum and Context class here in
        preparation for merging ExecState and Context.
        * kjs/ExecState.cpp: Moved Context class here from Context.cpp.
        * kjs/context.h: Removed.
        * kjs/Context.cpp: Removed.
        * kjs/function.h: Removed CodeType enum.
        * kjs/LabelStack.h: Added. Pulled LabelStack class out of internal.h.
        * kjs/internal.h: Removed LabelStack.
        * JavaScriptCore.xcodeproj/project.pbxproj: Added new file, removed ones that are gone.
        * kjs/collector.cpp: Fixed includes.
        * kjs/function.cpp: ditto
        * kjs/internal.cpp: ditto
        * kjs/interpreter.cpp: ditto
        * kjs/lookup.h: ditto
        * kjs/nodes.cpp: ditto


        Reviewed by Oliver.

        - update for JavaScriptCore header changes

        * bindings/objc/WebScriptObject.mm:
        * bridge/mac/WebCoreScriptDebugger.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 08:13:26 +0000 (08:13 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Windows build fix.

        * kjs/string_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Fri, 26 Oct 2007 07:51:25 +0000 (07:51 +0000)]

        Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15703
          fix numeric functions -- improve correctness and speed

        Gives about 1% gain on SunSpider.

        * kjs/value.h: Added toIntegerPreserveNan, removed toUInt16.
        (KJS::JSValue::toInt32): Changed to call getTruncatedInt32 in a way that works
        with both immediate and number values.
        (KJS::JSValue::toUInt32): Ditto.
        * kjs/value.cpp:
        (KJS::JSValue::toInteger): Moved the logic from roundValue here, with a couple
        differences. One is that it now correctly returns 0 for NaN, and another is that
        there's no special case for 0 or infinity, since the general case already handles
        those correctly.
        (KJS::JSValue::toIntegerPreserveNaN): Added. Like toInteger, but without the
        check for NaN.
        (KJS::JSValue::toInt32SlowCase): Call toNumber instead of roundValue. The
        truncation done by the typecast already does the necessary truncation that
        roundValue was doing.
        (KJS::JSValue::toUInt32SlowCase): Ditto.
        (KJS::JSValue::toUInt16): Removed.

        * kjs/internal.h: Removed roundValue.
        * kjs/internal.cpp: Ditto.

        * kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction): Remove unneeded
        code to handle NaN in Array.slice; toInteger now never returns NaN as specified.

        * kjs/date_object.cpp:
        (KJS::fillStructuresUsingTimeArgs): Replaced call to roundValue with a call to
        toNumber as specified.
        (KJS::DateProtoFunc::callAsFunction): In SetTime case, replaced call to roundValue
        with a call to toNumber and timeClip as specified.
        (KJS::DateObjectImp::construct): Removed unnecessary checks of numArgs in cases
        where the default behavior of toInt32 (returning 0) was already correct. Replaced
        call to roundValue with a call to toNumber as specified.
        (KJS::DateObjectFuncImp::callAsFunction): Ditto.

        * kjs/math_object.cpp: (MathFuncImp::callAsFunction): Removed unnecessary special
        cases for the pow function that the library already handles correctly.

        * kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Changed ToString to
        call toIntegerPreserveNaN, so we can continue to handle the NaN case differently.
        The real toInteger now returns 0 for NaN. Took out unneeded special case in
        ToFixed for undefined; was only needed because our toInteger was wrong. Same
        thing in ToExponential. Changed ToPrecision to call toIntegerPreserveNaN.

        * kjs/string_object.cpp:
        (KJS::StringProtoFunc::callAsFunction): Took out CharAt and CharCodeAt special
        cases for undefined that were only needed because toInteger was wrong. Same in
        IndexOf, and was able to remove some special cases. In LastIndexOf, used
        toIntegerPreserveNaN, but was able to remove some special cases there too.
        Changed Substr implementation to preserve correct behavior with the change
        to toInteger and match the specification. Also made sure we weren't converting
        an out of range double to an int.
        (KJS::StringObjectFuncImp::callAsFunction): Changed constructor to just use
        toUInt32, because truncating toUInt32 to 16 bits is the same thing and there's
        no reason to have toUInt16 as a second, less-optimized function that's only
        called at this one call site.

        * wtf/MathExtras.h: Added trunc function for Windows.


        Reviewed by Maciej.

        - test changes for http://bugs.webkit.org/show_bug.cgi?id=15703
          fix numeric functions -- improve correctness and speed

        * fast/js/resources/char-at.js: Updated test to expect that we get the first
        character if we pass NaN to charAt and charCodeAt; it's what the specification
        asks for and matches other browsers too.
        * fast/js/char-at-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 06:58:35 +0000 (06:58 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Update expected results.

        * platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej Stachowiak.
ggaren [Fri, 26 Oct 2007 06:55:36 +0000 (06:55 +0000)]
    Reviewed by Maciej Stachowiak.

        Tweaked the inner hashtable lookup loop to remove a branch in the "not
        found" case. .5% speedup on SunSpider.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/HashTable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-26 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 06:55:16 +0000 (06:55 +0000)]
2007-10-26  Mark Rowe  <mrowe@apple.com>

        Qt build fix.  r27084 added a destructor implementation for LayoutTestController
        to the Qt port on the assumption that it was an implementation of the cross-platform
        LayoutTestController class.  It is not, so it did not need to be changed.

        * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-25 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 26 Oct 2007 06:36:35 +0000 (06:36 +0000)]
2007-10-25  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        Fix builds with code coverage enabled.

        * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe.
darin [Fri, 26 Oct 2007 06:19:07 +0000 (06:19 +0000)]
    Reviewed by Mark Rowe.

        * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
        * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agobuild Fix
slewis [Fri, 26 Oct 2007 05:01:12 +0000 (05:01 +0000)]
build Fix

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
mjs [Fri, 26 Oct 2007 03:58:18 +0000 (03:58 +0000)]
    Reviewed by Oliver.

        - fold together toPrimitive() and toNumber() conversions for 0.5% gain on SunSpider

        * kjs/nodes.cpp:
        (KJS::SubNode::evaluate): Subtract directly, since toPrimitive() is not
        adding any value over toNumber() here.
        (KJS::valueForReadModifyAssignment): Ditto.
        (KJS::lessThan): Use new getPrimitiveNumber() method to avoid some virtual calls
        and branches.
        (KJS::lessThanEq): Ditto.
        * JavaScriptCore.exp: Export new functions as needed.
        * kjs/value.h:
        (KJS::JSValue::toPrimitive): Fixed formatting.
        (KJS::JSValue::getPrimitiveNumber): New method - this simultaneously converts
        to number and tells you whether a toPrimitive() conversion with a Number hint
        would have given a string.
        * kjs/internal.cpp:
        (KJS::StringImp::getPrimitiveNumber): Implemented.
        (KJS::NumberImp::getPrimitiveNumber): ditto
        (KJS::GetterSetterImp::getPrimitiveNumber): ditto
        (KJS::StringImp::toPrimitive): Fixed formatting.
        (KJS::NumberImp::toPrimitive): ditto
        (KJS::GetterSetterImp::toPrimitive): ditto
        * kjs/internal.h:
        * kjs/object.cpp:
        (KJS::JSObject::getPrimitiveNumber): Implemented.
        * kjs/object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWeak link against WebCore so DumpRenderTree can be bundled with production roots.
slewis [Fri, 26 Oct 2007 03:42:35 +0000 (03:42 +0000)]
Weak link against WebCore so DumpRenderTree can be bundled with production roots.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
aliceli1 [Fri, 26 Oct 2007 03:09:18 +0000 (03:09 +0000)]
    Reviewed by Adam.

        Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows

        Moving destructor into platform-specific files
        * DumpRenderTree/LayoutTestController.cpp:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/qt/jsobjects.cpp:

        LayoutTestController wasn't being destroyed
        * DumpRenderTree/win/DumpRenderTree.cpp:

        Added declspec
        * DumpRenderTree/win/EditingDelegate.h:

        Reset certain values on the webview (or related delegate) that might
        have changed while running a test
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-26 Alp Toker <alp@atoker.com>
alp [Fri, 26 Oct 2007 02:46:56 +0000 (02:46 +0000)]
2007-10-26  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        [GTK] Paging does not work when widget is added to a GtkScrolledWindow

        Eliminate MagicGtkScrollConstant in favour of the same calculations as
        GtkTextView for step and page increments. This also makes paging work,
        as the page increment was previously always 0.

        * platform/gtk/ScrollViewGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the windows build for real
weinig [Fri, 26 Oct 2007 01:44:40 +0000 (01:44 +0000)]
Fix the windows build for real

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
weinig [Fri, 26 Oct 2007 01:11:27 +0000 (01:11 +0000)]
    Reviewed by Adam Roben.

        Make debug builds run again.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add wkSetPatternBaseCTM.
aroben [Fri, 26 Oct 2007 01:09:08 +0000 (01:09 +0000)]
    Add wkSetPatternBaseCTM.

        Reviewed by NOBODY.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
weinig [Fri, 26 Oct 2007 01:09:00 +0000 (01:09 +0000)]

        Reviewed by Adam Roben.

        Remove JSStringRefCFHack from windows as it is no longer needed.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:


        Reviewed by Adam Roben.

        Remove JSStringRefCFHack.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Steve Falkenburg.
weinig [Fri, 26 Oct 2007 00:10:07 +0000 (00:10 +0000)]
    Reviewed by Steve Falkenburg.

        Fix for <rdar://problem/5463608>
        Port WebKit cache model code (Windows needs a big disk cache, smarter memory cache)

        * Interfaces/IWebPreferences.idl:
        Deprecate pageCacheSize and objectCacheSize and add cacheModel/setCacheModel.

        * Interfaces/IWebPreferencesPrivate.idl:
        Add automaticallyDetectsCacheModel/setAutomaticallyDetectsCacheModel

        * WebFrame.cpp:
        Implement based on the mac version.

        * WebKit.vcproj/WebKit.vcproj:
        * WebKitSystemBits.cpp: Added.
        (WebMemorySize): Moved and renamed from WebPreferences.cpp
        (WebVolumeFreeSize): Added.
        * WebKitSystemBits.h: Added.
        * WebPreferenceKeysPrivate.h: Added WebKitCacheModelPreferenceKey.

        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings): Added default for cacheModel.
        (WebPreferences::initWithIdentifier): Post a preferences change notification.
        (WebPreferences::pageCacheSize): Deprecated.
        (WebPreferences::objectCacheSize): Deprecated.
        (WebPreferences::cacheModel): Added.
        (WebPreferences::setCacheModel): Added.
        (WebPreferences::setAutomaticallyDetectsCacheModel): Added.
        (WebPreferences::automaticallyDetectsCacheModel): Added.
        (WebPreferences::willAddToWebView): Added.
        (WebPreferences::didRemoveFromWebView): Added.
        * WebPreferences.h:

        * WebView.cpp:
        This singleton class updates static properties for all webviews when
        preferenceChange or preferenceRemoved notifications are fired for
        any WebPreference.
        * WebView.h:
        Match the macs behavior by using explicit postings of notifications to
        update the preferences.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make sunspider-compare-results work with relative paths
aroben [Thu, 25 Oct 2007 23:38:21 +0000 (23:38 +0000)]
    Make sunspider-compare-results work with relative paths

        Reviewed by Sam.

        * Scripts/sunspider-compare-results: Convert arguments to absolute
        paths before we chdir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix unbalanced save/restore on Leopard only.
hyatt [Thu, 25 Oct 2007 23:33:41 +0000 (23:33 +0000)]
Fix unbalanced save/restore on Leopard only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Strip carriage returns from results
aroben [Thu, 25 Oct 2007 23:23:28 +0000 (23:23 +0000)]
    Strip carriage returns from results

        Carriage returns were screwing up sunspider-compare-results on

        Rubberstamped by Oliver.

        * sunspider:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Dave Hyatt and Sam Weinig.
mitz [Thu, 25 Oct 2007 23:17:48 +0000 (23:17 +0000)]
    Reviewed by Dave Hyatt and Sam Weinig.

        Build fix

        * platform/graphics/cg/ImageCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix the windows build.
weinig [Thu, 25 Oct 2007 23:16:45 +0000 (23:16 +0000)]
    Fix the windows build.

        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver Hunt.
ggaren [Thu, 25 Oct 2007 22:29:55 +0000 (22:29 +0000)]
    Reviewed by Oliver Hunt.

        Rolled out my last patch. It turns out that I needed 2 words, not 1,
        so it didn't help.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add WKSetPatternBaseCTM.
thatcher [Thu, 25 Oct 2007 22:23:54 +0000 (22:23 +0000)]
    Add WKSetPatternBaseCTM.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove the empty WebKitQt folders.
thatcher [Thu, 25 Oct 2007 22:13:41 +0000 (22:13 +0000)]
Remove the empty WebKitQt folders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-23 Jan Michael Alonzo <jmalonzo@unpluggable.com>
alp [Thu, 25 Oct 2007 21:56:17 +0000 (21:56 +0000)]
2007-10-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Alp.

        [GTK] Implement WebCore::Widget::isEnabled/setEnabled

        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::setEnabled): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver Hunt.
ggaren [Thu, 25 Oct 2007 21:37:45 +0000 (21:37 +0000)]
    Reviewed by Oliver Hunt.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=15694
        Shrink the size of an activation object by 1 word

        This is in preparation for adding a symbol table to the activation

        The basic strategy here is to rely on the mutual exclusion between
        the arguments object pointer and the function pointer (you only need
        the latter in order to create the former), and store them in the same
        place. The LazyArgumentsObject class encapsulates this strategy.

        Also inlined the ArgumentsImp constructor, for good measure.

        SunSpider reports no regression. Regression tests pass.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/Context.cpp:
        * kjs/function.cpp:
        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27068 268f45cc-cd09-0410-ab3c-d52691b4dbfc