WebKit-https.git
12 years agoUnreviewed, Chromium build fix. Missing "," after entry for BeforeLoadEvent.idl.
jparent@chromium.org [Mon, 5 Oct 2009 22:07:38 +0000 (22:07 +0000)]
Unreviewed, Chromium build fix.  Missing "," after entry for BeforeLoadEvent.idl.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-05
* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate layout tests to account for the new beforeload event object.
hyatt@apple.com [Mon, 5 Oct 2009 22:04:54 +0000 (22:04 +0000)]
Update layout tests to account for the new beforeload event object.

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Qt bustage.
hyatt@apple.com [Mon, 5 Oct 2009 21:28:46 +0000 (21:28 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a beforeload event that will be fired before subresources load. (It isn't fired...
hyatt@apple.com [Mon, 5 Oct 2009 21:16:12 +0000 (21:16 +0000)]
Add a beforeload event that will be fired before subresources load. (It isn't fired yet.)  The event
has one field, the URL that is going to be requested.  Setting preventDefault will stop the load
from occurring.

Reviewed by Sam Weinig.

* DerivedSources.cpp:
* DerivedSources.make:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/BeforeLoadEvent.h: Added.
(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::initBeforeLoadEvent):
(WebCore::BeforeLoadEvent::url):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):
* dom/BeforeLoadEvent.idl: Added.
* dom/EventNames.h:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Priit Laes <plaes@plaes.org>
eric@webkit.org [Mon, 5 Oct 2009 21:07:50 +0000 (21:07 +0000)]
2009-10-05  Priit Laes  <plaes@plaes.org>

        Reviewed by Gustavo Noronha.

        Add Gentoo-specific paths for searching browser plugins.
        https://bugs.webkit.org/show_bug.cgi?id=30088

        * plugins/PluginDatabase.cpp:
        (WebCore::PluginDatabase::defaultPluginDirectories):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add functionality to pause/throttle CSS transitions/animations in a WebView
cmarrin@apple.com [Mon, 5 Oct 2009 20:46:55 +0000 (20:46 +0000)]
    Add functionality to pause/throttle CSS transitions/animations in a WebView
        https://bugs.webkit.org/show_bug.cgi?id=29942

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Mon, 5 Oct 2009 20:44:26 +0000 (20:44 +0000)]
Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Remove test that I forgot in earlier commit.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Vadim Zeitlin <vadim@wxwidgets.org>
eric@webkit.org [Mon, 5 Oct 2009 20:23:13 +0000 (20:23 +0000)]
2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>

        Added --wx-compiler-prefix waf option to allow building wxWebKit with
        wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".

        * wx/build/settings.py:
        * wx/build/wxpresets.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubberstamped by Anders Carlsson.
kdecker@apple.com [Mon, 5 Oct 2009 20:06:47 +0000 (20:06 +0000)]
    Rubberstamped by Anders Carlsson.

        * WebCore.base.exp: Update export of HaltablePlugin/PluginHalterClient.
        * WebCore.xcodeproj/project.pbxproj: Likewise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 5 Oct 2009 19:07:59 +0000 (19:07 +0000)]
2009-10-05  Eric Seidel  <eric@webkit.org>

        No review, rolling out r49104.
        http://trac.webkit.org/changeset/49104

        * fast/forms/ValidityState-rangeOverflow-number-expected.txt: Removed.
        * fast/forms/ValidityState-rangeOverflow-number.html: Removed.
        * fast/forms/ValidityState-rangeOverflow-range-expected.txt: Removed.
        * fast/forms/ValidityState-rangeOverflow-range.html: Removed.
        * fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Removed.
        * fast/forms/ValidityState-rangeUnderflow-number.html: Removed.
        * fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Removed.
        * fast/forms/ValidityState-rangeUnderflow-range.html: Removed.
        * fast/forms/input-minmax-expected.txt: Removed.
        * fast/forms/input-minmax.html: Removed.
        * fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Removed.
        * fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Removed.
        * fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Removed.
        * fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Removed.
        * fast/forms/script-tests/input-minmax.js: Removed.
2009-10-05  Eric Seidel  <eric@webkit.org>

        No review, rolling out r49104.
        http://trac.webkit.org/changeset/49104

        * html/HTMLInputElement.cpp:
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl:
        * html/ValidityState.cpp:
        * html/ValidityState.h:
        (WebCore::ValidityState::rangeUnderflow):
        (WebCore::ValidityState::rangeOverflow):
        * rendering/RenderSlider.cpp:
        (WebCore::SliderRange::SliderRange):
        (WebCore::SliderRange::valueFromElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
kdecker@apple.com [Mon, 5 Oct 2009 18:57:25 +0000 (18:57 +0000)]
    Reviewed by Sam Weinig.

        <rdar://problem/7273363> Plug-ins should use PluginHalter

        * Plugins/WebBaseNetscapePluginView.h: Add WebHaltablePlugin forward declare and _haltable ivar.
        * Plugins/WebBaseNetscapePluginView.mm:
        (WebHaltablePlugin::WebHaltablePlugin): Added.
        (WebHaltablePlugin::halt): New method that stops a plug-in.
        (WebHaltablePlugin::restart): New method that starts a plug-in.
        (WebHaltablePlugin::node): Added. Provides the DOMNode corresponding to the plug-in in WebBaseNetscapePluginView.
        (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
        Initialize new _haltable ivar.
        (-[WebBaseNetscapePluginView start]): Call the page's didStartPlugin() upon starting a plug-in.
        (-[WebBaseNetscapePluginView stop]): Call the page's didStopPlugin() upon stopping a plug-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Mon, 5 Oct 2009 18:23:23 +0000 (18:23 +0000)]
2009-10-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Tests to check if validation-related CSS selectors are applied immediately.
        https://bugs.webkit.org/show_bug.cgi?id=28868

        * fast/forms/input-live-pseudo-selectors-expected.txt: Added.
        * fast/forms/input-live-pseudo-selectors.html: Added.
        * fast/forms/resources/input-live-pseudo-selectors.js: Added.
        * fast/forms/resources/live-pseudo-selectors.css: Added.
        * fast/forms/resources/textarea-live-pseudo-selectors.js: Added.
        * fast/forms/textarea-live-pseudo-selectors-expected.txt: Added.
        * fast/forms/textarea-live-pseudo-selectors.html: Added.
2009-10-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Update style immediately when validation-related values are updated.
        https://bugs.webkit.org/show_bug.cgi?id=28868

        In order to apply :valid, :invalid, :optional or :required lively,
          - call setNeedsStyleRecalc() when properties which can change
            willValidate state are updated, and
             (Parent form element, name, disabled, readonly)
          - call updateValidity() when properties which can change validity
            state are updated. (value, pattern, required)

        Tests: fast/forms/input-live-pseudo-selectors.html
               fast/forms/textarea-live-pseudo-selectors.html

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::HTMLFormControlElement):
        (WebCore::HTMLFormControlElement::parseMappedAttribute):
        (WebCore::HTMLFormControlElement::required):
        (WebCore::HTMLFormControlElement::updateValidity):
        * html/HTMLFormControlElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType):
        (WebCore::HTMLInputElement::parseMappedAttribute):
        (WebCore::HTMLInputElement::setValue):
        (WebCore::HTMLInputElement::setValueFromRenderer):
        (WebCore::HTMLInputElement::setFileListFromRenderer):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::setValue):
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::subtreeHasChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Mon, 5 Oct 2009 18:14:50 +0000 (18:14 +0000)]
2009-10-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Implement min/max attributes, ValidityState.rangeUnderflow and
        ValidityState.rangeOverflow for <input type=number> and <input type=range>
        https://bugs.webkit.org/show_bug.cgi?id=29069

        * fast/forms/ValidityState-rangeOverflow-number-expected.txt: Added.
        * fast/forms/ValidityState-rangeOverflow-number.html: Added.
        * fast/forms/ValidityState-rangeOverflow-range-expected.txt: Added.
        * fast/forms/ValidityState-rangeOverflow-range.html: Added.
        * fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Added.
        * fast/forms/ValidityState-rangeUnderflow-number.html: Added.
        * fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Added.
        * fast/forms/ValidityState-rangeUnderflow-range.html: Added.
        * fast/forms/input-minmax-expected.txt: Added.
        * fast/forms/input-minmax.html: Added.
        * fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Added.
        * fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Added.
        * fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Added.
        * fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Added.
        * fast/forms/script-tests/input-minmax.js: Added.
2009-10-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Implement min/max attributes, ValidityState.rangeUnderflow and
        ValidityState.rangeOverflow for <input type=number> and <input type=range>
        https://bugs.webkit.org/show_bug.cgi?id=29069

        Tests: fast/forms/ValidityState-rangeOverflow-number.html
               fast/forms/ValidityState-rangeOverflow-range.html
               fast/forms/ValidityState-rangeUnderflow-number.html
               fast/forms/ValidityState-rangeUnderflow-range.html
               fast/forms/input-minmax.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::rangeUnderflow):
        (WebCore::HTMLInputElement::rangeOverflow):
        (WebCore::HTMLInputElement::rangeMinimum):
        (WebCore::HTMLInputElement::rangeMaximum):
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl:
        * html/ValidityState.cpp:
        (WebCore::ValidityState::rangeUnderflow):
        (WebCore::ValidityState::rangeOverflow):
        * html/ValidityState.h:
        * rendering/RenderSlider.cpp:
        (WebCore::SliderRange::SliderRange):
        (WebCore::SliderRange::valueFromElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Mon, 5 Oct 2009 18:05:36 +0000 (18:05 +0000)]
2009-10-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Tests for -webkit-appearance:list-button
        https://bugs.webkit.org/show_bug.cgi?id=27794

        * platform/mac/fast/forms/input-list-button-size-expected.txt: Added.
        * platform/mac/fast/forms/input-list-button-size.html: Added.
2009-10-05  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        Introduces
         - new CSS pseudo selector: "-webkit-input-list-button"
         - new CSS apperance type: "list-button"
         - new ControlPart value: "ListButtonPart"
        for the UI of the list attribute of the input element, and adds
        implementation to draw ListButtonPart on Mac.
        The code is guarded by ENABLE(DATALIST).

        https://bugs.webkit.org/show_bug.cgi?id=27794

        Test: platform/mac/fast/forms/input-list-button-size.html

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
        * css/CSSValueKeywords.in:
        * css/html.css:
        * html/HTMLInputElement.cpp:
        * platform/ThemeTypes.h:
        (WebCore::):
        * platform/mac/ThemeMac.mm:
        (WebCore::listButtonSizes):
        (WebCore::button):
        (WebCore::paintButton):
        (WebCore::ThemeMac::controlSize):
        (WebCore::ThemeMac::minimumControlSize):
        (WebCore::ThemeMac::controlBorder):
        (WebCore::ThemeMac::paint):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle):
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::paintBorderOnly):
        (WebCore::RenderTheme::paintDecorations):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustRepaintRect):
        * rendering/style/RenderStyleConstants.h:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Mon, 5 Oct 2009 18:00:33 +0000 (18:00 +0000)]
Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Add documentation to the ErrorPageExtension.

* Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Mon, 5 Oct 2009 17:39:53 +0000 (17:39 +0000)]
2009-10-05  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Timothy Hatcher.

        Fixes <https://bugs.webkit.org/show_bug.cgi?id=30065>
        nodeTitleInfo should be placed in ElementsTreeOutline.

        Move nodeTitleInfo into ElementsTreeOutline.js from utilities.js.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement):
        (WebInspector.ElementsTreeElement.prototype._updateTitle):
        (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
        * inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Inform the application when a new request is created
yael.aharon@nokia.com [Mon, 5 Oct 2009 17:36:41 +0000 (17:36 +0000)]
[Qt] Inform the application when a new request is created
https://bugs.webkit.org/show_bug.cgi?id=29975

Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

WebCore:

Emit a signal each time a request is created, with the request and the frame
that created it.

WebKit/qt:

Add a signal to QWebPage, to inform the application when a request is created.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Ben Murdoch <benm@google.com>
eric@webkit.org [Mon, 5 Oct 2009 17:30:35 +0000 (17:30 +0000)]
2009-10-05  Ben Murdoch  <benm@google.com>

        Reviewed by Darin Adler.

        Add an ASSERT in updateGuidVersionMap.
        https://bugs.webkit.org/show_bug.cgi?id=30077

        * storage/Database.cpp:
        (WebCore::updateGuidVersionMap): ASSERT that the guidMutex() is locked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 5 Oct 2009 17:15:35 +0000 (17:15 +0000)]
2009-10-05  Nate Chapin  <japhet@chromium.org>

        Reviewed by Eric Seidel.

        Allow V8 to throw an exception in _NPN_SetException without worrying about context
        if we don't have enough information to find the correct context.

        https://bugs.webkit.org/show_bug.cgi?id=30026

        Part of the fix for Chromium's failure of LayouTests/plugins/netscape-throw-exception.html.

        * bindings/v8/NPV8Object.cpp:
        (_NPN_SetException): Don't suppress the exception if we can't find the relevant context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Mikhail Naganov <mnaganov@chromium.org>
pfeldman@chromium.org [Mon, 5 Oct 2009 16:03:16 +0000 (16:03 +0000)]
2009-10-01  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Place "Close" button in docked mode on the same side as the window "Close" button in detached mode.

        https://bugs.webkit.org/show_bug.cgi?id=29961

        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoErrorPageExtension: Add a pointer to the QWebFrame that had
kenneth@webkit.org [Mon, 5 Oct 2009 15:11:11 +0000 (15:11 +0000)]
ErrorPageExtension: Add a pointer to the QWebFrame that had
an error.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Reviewed by Simon Hausmann.

* Api/qwebpage.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::callErrorPageExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDo not empty the offline web appcache when clearing
kenneth@webkit.org [Mon, 5 Oct 2009 15:01:33 +0000 (15:01 +0000)]
Do not empty the offline web appcache when clearing
memory caches. That one is not in memory, but stored
in sqlite.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-05
Reviewed by Tor Arne Vestbø.

* Api/qwebsettings.cpp:
(QWebSettings::clearMemoryCaches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Re-enable fast/table/008.html
kenneth@webkit.org [Mon, 5 Oct 2009 14:36:11 +0000 (14:36 +0000)]
[Qt] Re-enable fast/table/008.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Add expected files for passing fast/table tests.
kenneth@webkit.org [Mon, 5 Oct 2009 14:08:59 +0000 (14:08 +0000)]
[Qt] Add expected files for passing fast/table tests.

Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-05
Reviewed by Ariya Hidayat.

* platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt: Added.
* platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt: Added.
* platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.txt: Added.
* platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Added.
* platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt: Added.
* platform/qt/fast/table/fixed-table-with-small-percent-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: [Qt] Added pure virtual QWebPageClient::pluginParent()
hausmann@webkit.org [Mon, 5 Oct 2009 14:03:12 +0000 (14:03 +0000)]
WebCore: [Qt] Added pure virtual QWebPageClient::pluginParent()

Patch by J-P Nurmi <jpnurmi@gmail.com> on 2009-10-05
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29710

* platform/qt/QWebPageClient.h:

WebKit/qt: Added QGraphicsWidget-plugins support to FrameLoaderClientQt.

Patch by J-P Nurmi <jpnurmi@gmail.com> on 2009-10-05
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29710

* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::pluginParent):
* Api/qwebview.cpp:
(QWebViewPrivate::pluginParent):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::):
(WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 5 Oct 2009 14:03:07 +0000 (14:03 +0000)]
2009-10-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: add testing harness for Web Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=30010

WebKit:
        * WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
        * WebInspector/WebInspector.mm:
        (-[WebInspector evaluateInFrontend:callId:script:]):
        * WebInspector/WebInspectorPrivate.h: Added.
WebKit/win:
        * Interfaces/IWebInspectorPrivate.idl: Added.
        * Interfaces/IWebViewPrivate.idl:
        * Interfaces/WebKit.idl:
        * WebInspector.cpp:
        (WebInspector::evaluateInFrontend):
        * WebInspector.h:
        * WebView.cpp:
        (WebView::inspectorPrivate):
        * WebView.h:
WebKitTools:
        * DumpRenderTree/LayoutTestController.cpp:
        (showWebInspectorCallback):
        (closeWebInspectorCallback):
        (evaluateInWebInspectorCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):
        (LayoutTestController::evaluateInWebInspector):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):
        (LayoutTestController::evaluateInWebInspector):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):
        (LayoutTestController::evaluateInWebInspector):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::showWebInspector):
        (LayoutTestController::closeWebInspector):
        (LayoutTestController::evaluateInWebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Mon, 5 Oct 2009 13:25:07 +0000 (13:25 +0000)]
2009-10-05  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Disable TCmalloc for Windows port at the present, because MinGW
        hasn't got built-in pthread library.

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Jakub Wieczorek <faw217@gmail.com>
vestbo@webkit.org [Mon, 5 Oct 2009 10:57:23 +0000 (10:57 +0000)]
2009-10-05  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] windowsKeyCodeForKeyEvent() returns a wrong value for the F10 key.
        https://bugs.webkit.org/show_bug.cgi?id=30042

        * platform/qt/PlatformKeyboardEventQt.cpp:
        (WebCore::windowsKeyCodeForKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPass arguments to system() as a string instead of array
vestbo@webkit.org [Mon, 5 Oct 2009 10:48:57 +0000 (10:48 +0000)]
Pass arguments to system() as a string instead of array

Reviewed by Ariya Hidayat.

When passed as an array entries with a space fail to translate
to two arguments to the child process, so instead of manually
splitting all the entries in @buildArgs we pass the whole thing
as a string instead.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove mediaControls extras for the Qt port into WebCore/css like other ports
vestbo@webkit.org [Mon, 5 Oct 2009 09:31:11 +0000 (09:31 +0000)]
Move mediaControls extras for the Qt port into WebCore/css like other ports

https://bugs.webkit.org/show_bug.cgi?id=30013

Reviewed by Eric Carlson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-05 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Mon, 5 Oct 2009 09:17:58 +0000 (09:17 +0000)]
2009-10-05  Fumitoshi Ukai  <ukai@chromium.org>

        Unreviewed build fix for ENABLE(WEB_SOCKETS) and v8.

        V8ObjectEventListener.h has been removed at r48978

        * bindings/v8/custom/V8WebSocketCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 5 Oct 2009 09:06:05 +0000 (09:06 +0000)]
2009-10-04  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector console stops working while JS in IFRAME is paused.

        https://bugs.webkit.org/show_bug.cgi?id=29958

        * inspector/front-end/InjectedScript.js:
        (InjectedScript._evaluateOn):
        (InjectedScript.addInspectedNode):
        (InjectedScript._ensureCommandLineAPIInstalled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 5 Oct 2009 08:56:17 +0000 (08:56 +0000)]
2009-10-04  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Introduce inspected object groups for console
        and watch evaluation results so that they could be released
        explicitly.

        https://bugs.webkit.org/show_bug.cgi?id=29891

        * bindings/js/JSInspectorBackendCustom.cpp:
        (WebCore::JSInspectorBackend::wrapObject):
        * bindings/v8/custom/V8InspectorBackendCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::wrapObject):
        (WebCore::InspectorBackend::releaseWrapperObjectGroup):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::clearConsoleMessages):
        (WebCore::InspectorController::resetScriptObjects):
        (WebCore::InspectorController::wrapObject):
        (WebCore::InspectorController::unwrapObject):
        (WebCore::InspectorController::releaseWrapperObjectGroup):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addMessageToConsole):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
        (WebInspector.ConsoleView.prototype.doEvalInWindow):
        (WebInspector.ConsoleView.prototype._enterKeyPressed):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.evaluate):
        (InjectedScript._evaluateAndWrap):
        (InjectedScript.evaluateInCallFrame):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
        (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSidebarPane):
        (WebInspector.WatchExpressionsSection.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRename WebCore/css/mediaControlsQT.css and MediaControllerThemeQT
vestbo@webkit.org [Mon, 5 Oct 2009 08:42:57 +0000 (08:42 +0000)]
Rename WebCore/css/mediaControlsQT.css and MediaControllerThemeQT

https://bugs.webkit.org/show_bug.cgi?id=30013

Reviewed by Eric Carlson.

The QT suffix has been expanded to QuickTime, to not cause confusion
and name-crashes with similar files in the Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-04 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Mon, 5 Oct 2009 05:27:08 +0000 (05:27 +0000)]
2009-10-04  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Timothy Hatcher.

        Fixes <https://bugs.webkit.org/show_bug.cgi?id=30064>
        Syntax Highlighting CSS shouldn't be duplicated.

        Refactor syntax highlighting CSS into a new file, add it to the
        projects, and have SourceFrame.js and inspector.html include the
        new CSS file.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._loaded):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspectorSyntaxHighlight.css: Added.
        * inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-04 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Mon, 5 Oct 2009 04:16:40 +0000 (04:16 +0000)]
2009-10-04  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Timothy Hatcher.

        Fixes <https://bugs.webkit.org/show_bug.cgi?id=30062>
        Inspector should syntax highlight JS/CSS in elements view.

        Add syntax highlighting of CSS and JavaScript tags to the elements panel.
        Copied CSS rules from SourceFrame.js to inspector.css, and have the text nodes
        in utilities.js call the CSS or JS Syntax highlighters if their parent is a script
        or style tag.

        * inspector/front-end/inspector.css:
        * inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-04 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Mon, 5 Oct 2009 02:52:24 +0000 (02:52 +0000)]
2009-10-04  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel

        Enable Web Sockets in chromium build.
        https://bugs.webkit.org/show_bug.cgi?id=29917

        * WebCore.gyp/WebCore.gyp:

2009-10-04  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel

        Enable Web Sockets in chromium build.
        https://bugs.webkit.org/show_bug.cgi?id=29917

        * chromium/features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Cameron Zwarich.
kdecker@apple.com [Sun, 4 Oct 2009 23:43:59 +0000 (23:43 +0000)]
    Reviewed by Cameron Zwarich.

        * WebView/WebPreferenceKeysPrivate.h: Added new key.
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]): Leave plug-in halting disabled by default.
        (-[WebPreferences pluginHalterEnabled]): Added.
        (-[WebPreferences setPluginHalterEnabled:]): Ditto.
        * WebView/WebPreferencesPrivate.h: Added above new methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-04 Carol Szabo <carol.szabo@nokia.com>
eric@webkit.org [Sun, 4 Oct 2009 21:12:25 +0000 (21:12 +0000)]
2009-10-04  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by David Levin.

        check-webkit-style misses whitespace errors for operators:
        <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
        https://bugs.webkit.org/show_bug.cgi?id=30021

        * Scripts/modules/cpp_style.py:
        Added the operators mentioned above to the same list as == and !=.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
xan@webkit.org [Sun, 4 Oct 2009 20:01:19 +0000 (20:01 +0000)]
WebCore:

2009-10-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by NOBODY (OOPS!).

        [GTK] performs a POST when refreshing a view that was obtained with a GET
        https://bugs.webkit.org/show_bug.cgi?id=29761

        Update the HTTP method in the request stored by willSendRequest
        after a redirect, since it could have changed.

        Test: http/tests/navigation/postredirect-reload.html

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):

LayoutTests:

2009-10-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by NOBODY (OOPS!).

        [GTK] performs a POST when refreshing a view that was obtained with a GET
        https://bugs.webkit.org/show_bug.cgi?id=29761

        New test that checks that a reload after a redirect to a page with
        a GET method from one with a POST method will use GET and not
        POST.

        * http/tests/navigation/postredirect-reload-expected.txt: Added.
        * http/tests/navigation/postredirect-reload.html: Added.
        * http/tests/navigation/resources/postresult.pl:
        * http/tests/navigation/resources/reloadresult.pl: Added.
        * http/tests/navigation/resources/redirect-reload.html: Added.
        * http/tests/navigation/resources/success200.html:
        * http/tests/navigation/resources/testcode.js:
        (submitFormWithPostRedirectReload):
        (runRedirectReloadTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRevert previous patch, as the newly added test breaks other tests.
xan@webkit.org [Sun, 4 Oct 2009 18:14:08 +0000 (18:14 +0000)]
Revert previous patch, as the newly added test breaks other tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
xan@webkit.org [Sun, 4 Oct 2009 17:17:30 +0000 (17:17 +0000)]
WebCore:

2009-10-04  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] performs a POST when refreshing a view that was obtained with a GET
        https://bugs.webkit.org/show_bug.cgi?id=29761

        Update the HTTP method in the request stored by willSendRequest
        after a redirect, since it could have changed.

        Test: http/tests/navigation/postredirect-reload.html

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):

LayoutTests:

2009-10-04  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] performs a POST when refreshing a view that was obtained with a GET
        https://bugs.webkit.org/show_bug.cgi?id=29761

        New test that checks that a reload after a redirect to a page with
        a GET method from one with a POST method will use GET and not
        POST.

        * http/tests/navigation/postredirect-reload-expected.txt: Added.
        * http/tests/navigation/postredirect-reload.html: Added.
        * http/tests/navigation/resources/postresult.pl:
        * http/tests/navigation/resources/reloadresult.pl: Added.
        * http/tests/navigation/resources/success200.html:
        * http/tests/navigation/resources/testcode.js:
        (submitFormWithPostRedirectReload):
        (runRedirectReloadTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-04 Vitaly Repeshko <vitalyr@chromium.org>
eric@webkit.org [Sun, 4 Oct 2009 17:12:37 +0000 (17:12 +0000)]
2009-10-04  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Adam Barth.

        [V8] Fixed Function leak in V8LazyEventListener.
        (Should fix the remaning leak in
        https://bugs.webkit.org/show_bug.cgi?id=29093).
        V8LazyEventListeners used to create FunctionTemplates for each
        wrapped listener which in turn created Functions that were cached
        forever in V8 Context. Now there is at most one such Function per
        Context.
        https://bugs.webkit.org/show_bug.cgi?id=30060

        Added new hidden property name to store toString result:
        * bindings/v8/V8HiddenPropertyName.cpp:
        * bindings/v8/V8HiddenPropertyName.h:

        Switched to static FunctionTemplate:
        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListenerToString):
        (WebCore::V8LazyEventListener::prepareListenerObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-03 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 4 Oct 2009 03:46:54 +0000 (03:46 +0000)]
2009-10-03  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        CSS Source View Should be Syntax Highlighted
        https://bugs.webkit.org/show_bug.cgi?id=14359

          Support for WebKit's CSS Variables @variables and var()

        * inspector/front-end/SourceFrame.js:
        (WebInspector.CSSSourceSyntaxHighligher):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-03 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 4 Oct 2009 03:14:18 +0000 (03:14 +0000)]
2009-10-03  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Inspector should remember preferences for docked/undocked etc
        https://bugs.webkit.org/show_bug.cgi?id=29089

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._toggleLargerResources): toggle the preference
        * inspector/front-end/inspector.js:
        (WebInspector._loadPreferences): factored out loading preferences
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-03 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 4 Oct 2009 02:50:05 +0000 (02:50 +0000)]
2009-10-03  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        CSS Source View Should be Syntax Highlighted
        https://bugs.webkit.org/show_bug.cgi?id=14359

          Trigger the Syntax Highlighter for CSS files.

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript):
        (WebInspector.SourceFrame.prototype.syntaxHighlightCSS):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype._contentLoaded):

          Factored out the Syntax Highlighting procedure into a "Class"
          Added CSSSourceSyntaxHighlighter and JavaScriptSourceSyntaxHighlighter

        (WebInspector.SourceSyntaxHighligher):
        (WebInspector.SourceSyntaxHighligher.prototype.createSpan):
        (WebInspector.SourceSyntaxHighligher.prototype.process.processChunk):
        (WebInspector.SourceSyntaxHighligher.prototype.process):
        (WebInspector.CSSSourceSyntaxHighligher): the CSS Highlighter
        (WebInspector.JavaScriptSourceSyntaxHighligher): the JS Highlighter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 4 Oct 2009 00:41:43 +0000 (00:41 +0000)]
2009-10-03  Adam Barth  <abarth@webkit.org>

        Unreview build fix.  I wish I had a try server...

        * Api/qwebpage.cpp:
        (QWebPagePrivate::updateAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 4 Oct 2009 00:36:35 +0000 (00:36 +0000)]
2009-10-03  Adam Barth  <abarth@webkit.org>

        More build fixing.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_go_back_or_forward):
        (webkit_web_view_can_go_back_or_forward):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 4 Oct 2009 00:26:19 +0000 (00:26 +0000)]
2009-10-03  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_go_back_or_forward):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 4 Oct 2009 00:17:08 +0000 (00:17 +0000)]
2009-10-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Factor back-forward list methods out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30037

        This change moves these back-forward related methods from FrameLoader
        to Page.  It's possible we should move these methods into some kind of
        "page controller" object, but we can figure that out in a future patch.

        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/RedirectScheduler.cpp:
        (WebCore::RedirectScheduler::timerFired):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::close):
        * page/History.cpp:
        (WebCore::History::length):
        * page/Page.cpp:
        (WebCore::Page::canGoBackOrForward):
        (WebCore::Page::goBackOrForward):
        (WebCore::Page::getHistoryLength):
        * page/Page.h:
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
        (WebCore::ContextMenu::checkOrEnableIfNeeded):
2009-10-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Factor PageController out of FrameLoader and Page
        https://bugs.webkit.org/show_bug.cgi?id=30037

        * webkit/webkitwebview.cpp:
        (webkit_web_view_can_go_back_or_forward):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-03 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Sat, 3 Oct 2009 20:50:18 +0000 (20:50 +0000)]
2009-10-03  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Remove 5 tests from the Skipped list that pass after the addition
        of layoutTestController.overridePreference().

        https://bugs.webkit.org/show_bug.cgi?id=29970

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoved the concept of a "fast access cutoff" in arrays, because it
ggaren@apple.com [Sat, 3 Oct 2009 17:01:14 +0000 (17:01 +0000)]
Removed the concept of a "fast access cutoff" in arrays, because it
punished some patterns of array access too much, and made things too
complex for inlining in some cases.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-02
Reviewed by Sam Weinig.

1.3% speedup on SunSpider.

* jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
* jit/JITStubs.cpp:
* jit/JITStubs.h:
(JSC::): Check m_vectorLength instead of m_fastAccessCutoff when
getting / putting from / to an array. Inline putting past the end of
the array.

* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::checkConsistency):
* runtime/JSArray.h:
(JSC::JSArray::canGetIndex):
(JSC::JSArray::canSetIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::markChildrenDirect): Removed m_fastAccessCutoff, and
replaced with checks for JSValue() to detect reads and writes from / to
uninitialized parts of the array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 3 Oct 2009 10:27:48 +0000 (10:27 +0000)]
2009-10-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: prepare InspectorController for being used from layout tests.
        This change adds evaluateForTestInFrontend method with the callback that
        allows evaluating arbitrary code in the frontend context.

        https://bugs.webkit.org/show_bug.cgi?id=30008

        * WebCore.Inspector.exp:
        * WebCore.order:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::didEvaluateForTestInFrontend):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::evaluateForTestInFrontend):
        (WebCore::InspectorController::didEvaluateForTestInFrontend):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::evaluateForTestInFrontend):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/inspector.js:
        (WebInspector.evaluateForTestInFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 3 Oct 2009 06:31:40 +0000 (06:31 +0000)]
2009-10-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Node search mode is not getting reset on element selection.

        https://bugs.webkit.org/show_bug.cgi?id=30016

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Sat, 3 Oct 2009 05:24:48 +0000 (05:24 +0000)]
2009-10-02  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Timothy Hatcher.

        Fixes <https://bugs.webkit.org/show_bug.cgi?id=30036>
        Should be able to resize Cookie Columns.

        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype.update.callback):
        (WebInspector.CookieItemsView.prototype.update):
        (WebInspector.CookieItemsView.prototype.resize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fix.
sfalken@apple.com [Sat, 3 Oct 2009 05:10:00 +0000 (05:10 +0000)]
Windows build fix.
Re-apply lost changes to auto-version.sh.

* win/tools/scripts/auto-version.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake WebCore::PluginView participate in plug-in halting.
jhoneycutt@apple.com [Sat, 3 Oct 2009 02:51:49 +0000 (02:51 +0000)]
Make WebCore::PluginView participate in plug-in halting.

Reviewed by Sam Weinig.

WebCore:

Have plug-ins opt in to automatic halting.

Reviewed by NOBODY (OOPS!).

* platform/graphics/BitmapImage.h:
Declare a create() function that takes an HBITMAP.

* platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::create):
Use GetObject() to fill out a DIBSECTION structure for the given
HBITMAP. Call CGBitmapContextCreate() to create a CG context from the
bits of the bitmap. Create a CG image from the context, and pass this
when creating a new BitmapImage.

* plugins/PluginView.cpp:
(WebCore::PluginView::start):
If we successfully started, tell our parent frame's Page.
(WebCore::PluginView::stop):
Tell our parent frame's Page that we stopped.
(WebCore::PluginView::node):

* plugins/PluginView.h:
Inherit from HaltablePlugin.
(WebCore::PluginView::setPlatformPluginWidget):
On platforms where the platform plug-in widget is the WebCore::Widget's
platform widget, have setPlatformPluginWidget() call
setPlatformWidget().

* plugins/PluginViewNone.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::platformDestroy):
After destroying the window, set the platform plug-in widget to 0 to
ensure that Widget isn't holding a stale handle.
(WebCore::PluginView::halt):
Have our element's RenderWidget display a screenshot of the plug-in,
then stop the plug-in and destroy it.
(WebCore::PluginView::restart):
Clear the RenderWidget's substitute image, then start the plug-in.

* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::showSubstituteImage):
Set m_substituteImage to the passed image, and repaint.
(WebCore::RenderWidget::paint):
If we have a substitute image, paint that instead of allowing the
widget to paint itself.

* rendering/RenderWidget.h:
Declare showSubstituteImage(). Added a member to store the substitute
image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Oct 2009 02:10:28 +0000 (02:10 +0000)]
2009-10-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Move PolicyCheck out of FrameLoader.{h,cpp}
        https://bugs.webkit.org/show_bug.cgi?id=30035

        Purely code motion (and adding a destructor).

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/PolicyCheck.cpp:
        * loader/PolicyCheck.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed.
jparent@chromium.org [Sat, 3 Oct 2009 01:47:18 +0000 (01:47 +0000)]
Unreviewed.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-02
Adding myself and Ojan Vafai as committers, because we are committers.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r49044 as it breaks many tests.
mrowe@apple.com [Sat, 3 Oct 2009 00:47:32 +0000 (00:47 +0000)]
Roll out r49044 as it breaks many tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Jonni Rainisto <jonni.rainisto@nokia.com>
eric@webkit.org [Fri, 2 Oct 2009 23:35:31 +0000 (23:35 +0000)]
2009-10-02  Jonni Rainisto  <jonni.rainisto@nokia.com>

        Reviewed by Darin Adler.

        Math.random() gives too low values on Win32 when _CRT_RAND_S is not defined
        https://bugs.webkit.org/show_bug.cgi?id=29956

        * wtf/RandomNumber.cpp:
        (WTF::randomNumber): Added PLATFORM(WIN_OS) to handle 15bit rand()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Yuta Kitamura <yutak@chromium.org>
eric@webkit.org [Fri, 2 Oct 2009 23:27:31 +0000 (23:27 +0000)]
2009-10-02  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Darin Adler.

        Update pixel test image for fast/table/vertical-align-baseline.html.

        Expected render tree dump for this test was modified in r40146
        <http://trac.webkit.org/changeset/40146>, but the image was not updated with it.

        * platform/mac/fast/table/vertical-align-baseline-expected.checksum:
        * platform/mac/fast/table/vertical-align-baseline-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Fri, 2 Oct 2009 23:20:05 +0000 (23:20 +0000)]
2009-10-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Add NPNVToolkit value quirk in plugins for nspluginwrapper.
        Plugin error message was:
        ERROR: failed to initialize brower-side RPC events listener
        https://bugs.webkit.org/show_bug.cgi?id=25053

        (WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue):
        (WebCore::PluginPackage::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Fri, 2 Oct 2009 23:12:18 +0000 (23:12 +0000)]
2009-10-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] X sync our XEmbed container window creation before sending the
        xid to plugins.
        https://bugs.webkit.org/show_bug.cgi?id=25053

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 2 Oct 2009 23:02:45 +0000 (23:02 +0000)]
2009-10-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Setting zero size on a container of a video element doesn't hide the controller
        https://bugs.webkit.org/show_bug.cgi?id=30031

        Fix a logic error in enclosingCompositingLayer() when mixing normal flow and
        positioned layers. This resulted in enclosingCompositingLayer() giving back a different
        answer to the logic used to actually parent compositing layers, so layer positions
        and layer hierarchy would be out of agreement.

        Test: compositing/geometry/clipped-video-controller.html

        * rendering/RenderLayer.cpp:
        (WebCore::compositingContainer):
        (WebCore::RenderLayer::enclosingCompositingLayer):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::setCompositingParent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Fri, 2 Oct 2009 22:49:29 +0000 (22:49 +0000)]
2009-10-02  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        - Move the following methods of HTMLInputElement and HTMLTextAreaElement
          to HTMLTextFormControlElement.
           setSelectionStart()
           setSelectionEnd()
           select()
           setSelectionRange()
           selectionStart()
           selectionEnd()
           selection()

        - Introduce cachedSelectionStart() and cachedSelectionEnd().

        - Unify HTMLInputElement::isTextFieldWithRenderer() and
         HTMLTextAreaElement::rendererAfterUpdateLayout() into textRendererAfterUpdateLayout().

        - Unify a part of parseMappedAttribute() of HTMLInputElement and HTMLTextAreaElement.

        https://bugs.webkit.org/show_bug.cgi?id=29782

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLTextFormControlElement::textRendererAfterUpdateLayout):
        (WebCore::HTMLTextFormControlElement::setSelectionStart):
        (WebCore::HTMLTextFormControlElement::setSelectionEnd):
        (WebCore::HTMLTextFormControlElement::select):
        (WebCore::HTMLTextFormControlElement::setSelectionRange):
        (WebCore::HTMLTextFormControlElement::selectionStart):
        (WebCore::HTMLTextFormControlElement::selectionEnd):
        (WebCore::HTMLTextFormControlElement::selection):
        (WebCore::HTMLTextFormControlElement::parseMappedAttribute):
        * html/HTMLFormControlElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute):
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::select):
        (WebCore::HTMLInputElement::cachedSelectionStart):
        (WebCore::HTMLInputElement::cachedSelectionEnd):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::parseMappedAttribute):
        * html/HTMLTextAreaElement.h:
        (WebCore::HTMLTextAreaElement::cachedSelectionStart):
        (WebCore::HTMLTextAreaElement::cachedSelectionEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>
eric@webkit.org [Fri, 2 Oct 2009 22:40:59 +0000 (22:40 +0000)]
2009-10-02  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Disconnect event listeners on navigation.
        Fixes http://crbug.com/23597.
        https://bugs.webkit.org/show_bug.cgi?id=30027

        Added V8ListenerGuard that is shared by listeners and proxy. On
        navigation proxy sets a flag in the guard turning off listeners.

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::V8AbstractEventListener):
        * bindings/v8/V8AbstractEventListener.h:
        (WebCore::V8ListenerGuard::create):
        (WebCore::V8ListenerGuard::isDisconnected):
        (WebCore::V8ListenerGuard::disconnectListeners):
        (WebCore::V8ListenerGuard::V8ListenerGuard):
        (WebCore::V8AbstractEventListener::disconnected):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getEventListener):
        * bindings/v8/V8EventListenerList.h:
        (WebCore::V8EventListenerList::findOrCreateWrapper):
        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::V8LazyEventListener):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::V8Proxy):
        (WebCore::V8Proxy::disconnectFrame):
        (WebCore::V8Proxy::disconnectEventListeners):
        (WebCore::V8Proxy::clearForNavigation):
        * bindings/v8/V8Proxy.h:
        (WebCore::V8Proxy::listenerGuard):
        * bindings/v8/V8WorkerContextEventListener.cpp:
        (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
        * bindings/v8/V8WorkerContextEventListener.h:
        (WebCore::V8WorkerContextEventListener::create):
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
        (WebCore::WorkerContextExecutionProxy::dispose):
        (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
        * bindings/v8/WorkerContextExecutionProxy.h:
        * bindings/v8/custom/V8CustomEventListener.cpp:
        (WebCore::V8EventListener::V8EventListener):
        * bindings/v8/custom/V8CustomEventListener.h:
        (WebCore::V8EventListener::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Kenneth Russell <kbr@google.com>
eric@webkit.org [Fri, 2 Oct 2009 22:33:40 +0000 (22:33 +0000)]
2009-10-02  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        [chromium] Fix WebGL build after CustomGetter constructor changes
        https://bugs.webkit.org/show_bug.cgi?id=30020

        * page/DOMWindow.idl:
        Changed CustomGetter to JSCCustomGetter for CanvasArray constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Patrick Mueller <Patrick_Mueller@us.ibm.com>
eric@webkit.org [Fri, 2 Oct 2009 22:23:36 +0000 (22:23 +0000)]
2009-10-02  Patrick Mueller  <Patrick_Mueller@us.ibm.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: text in a "Request Payload" section disappears on selection
        https://bugs.webkit.org/show_bug.cgi?id=29967

        No new tests.

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.prototype._refreshRequestPayload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>
eric@webkit.org [Fri, 2 Oct 2009 22:15:23 +0000 (22:15 +0000)]
2009-10-02  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Dimitri Glazkov.

        Test that having infinite recursion in XMLHttpRequest event handler does not crash.
        https://bugs.webkit.org/show_bug.cgi?id=29974

        * fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.
        * fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html: Added.
2009-10-02  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Recursion guard for V8Proxy::callFunction.
        Fixes http://crbug.com/23278.
        https://bugs.webkit.org/show_bug.cgi?id=29974

        Test: fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::callFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClean up the QNetworkReplyHandler to only apply HTTP headers
kenneth@webkit.org [Fri, 2 Oct 2009 21:59:21 +0000 (21:59 +0000)]
Clean up the QNetworkReplyHandler to only apply HTTP headers
for protocols in the HTTP family.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Victor Wang <victorw@chromium.org>
japhet@chromium.org [Fri, 2 Oct 2009 21:55:41 +0000 (21:55 +0000)]
2009-10-02  Victor Wang  <victorw@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=29619

        Patch http://trac.webkit.org/changeset/35290 adds win support for
        JPEG and GIF for toDataURL encoding canvases and the test was
        rewritten to not output the encoded image data, it should pass
        on Win now.

        * platform/win/Skipped:
        * platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit side of <rdar://problem/7179166>
andersca@apple.com [Fri, 2 Oct 2009 21:53:33 +0000 (21:53 +0000)]
WebKit side of <rdar://problem/7179166>

Reviewed by Kevin Decker and Dan Bernstein.

* Plugins/Hosted/NetscapePluginInstanceProxy.h:
Add an m_pluginIsWaitingForDraw member variable.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Initialize m_pluginIsWaitingForDraw.

(WebKit::NetscapePluginInstanceProxy::invalidateRect):
Set m_pluginIsWaitingForDraw to true.

(WebKit::NetscapePluginInstanceProxy::didDraw):
If m_pluginIsWaitingForDraw is true, call _WKPHPluginInstanceDidDraw.

* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView drawRect:]):
Call didDraw.

* Plugins/Hosted/WebKitPluginHost.defs:
Add PHPluginInstanceDidDraw.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Fri, 2 Oct 2009 21:49:56 +0000 (21:49 +0000)]
2009-10-02  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Jon Honeycutt.

        Fix test breakages by adding null checks, and putting inspector code in
        ENABLE(INSPECTOR).

        * dom/Document.cpp:
        (WebCore::Document::finishedParsing):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove error check into sendResponseIfNeeded() as suggested
kenneth@webkit.org [Fri, 2 Oct 2009 21:39:24 +0000 (21:39 +0000)]
Move error check into sendResponseIfNeeded() as suggested
by Eric Seidel. Also, remove some dead code.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Assertion failure in CompositeEditCommand::moveParagraphs() and crash in...
adele@apple.com [Fri, 2 Oct 2009 21:34:03 +0000 (21:34 +0000)]
WebCore: Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
<rdar://problem/7148712>
https://bugs.webkit.org/show_bug.cgi?id=28992

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.

Test: editing/selection/replace-selection-crash.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Handle properly the case of
the destination position matching the end of the paragraph to move.

LayoutTests: Added test case.
<rdar://problem/7148712> Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
https://bugs.webkit.org/show_bug.cgi?id=28992

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.

* editing/selection/replace-selection-crash-expected.txt: Added.
* editing/selection/replace-selection-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 2 Oct 2009 21:15:41 +0000 (21:15 +0000)]
2009-10-02  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        Implement per-storage-area quotas for LocalStorage
        https://bugs.webkit.org/show_bug.cgi?id=29991

        I put 90% of the code in StorageMap since the decision to allow an update is
        closely tied to quota tracking.  The quota is set via a page's Settings class.
        Like with the local storage path and whether it's enabled, it's assumed that
        all pages in the same group will have the same settings.  The setting defaults
        to 5mb which is what the spec suggests, but it can easily be changed to
        anything else--including StorageMap::noQuota.  Any values in LocalStorage are
        grandfathered in regarudless of quota, so importItem only tracks (and will
        never block) imports.

        I believe this change is a good transition to more complex quota management.
        For example, if we wanted to track quotas in the SQLite DB, then we'd just add
        a function to the StorageMap that sets the quota.  This would be fine since all
        use of LocalStorage is blocked on the import completing, so you'd never hit a
        quota error in the mean time.  Also, if embedders wanted to ask the user
        whether to expand the quota whenever it's hit (before deciding whether or not
        to raise an exception), a callback via the chrome client should be fairly easy.
        That said, I think it's best to add these features in steps rather than one
        huge patch.  (Both of these are on my TODO list, btw.)

        Included is a layout test that verifies the behavior.  It assumes the default
        quota is 5mb (since that's what Settings defaults to).

        Test: storage/domstorage/localstorage/quota.html

        * page/PageGroup.cpp:
        (WebCore::PageGroup::localStorage):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setLocalStorageQuota):
        * page/Settings.h:
        (WebCore::Settings::localStorageQuota):
        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::create):
        (WebCore::StorageAreaImpl::StorageAreaImpl):
        (WebCore::StorageAreaImpl::setItem):
        (WebCore::StorageAreaImpl::clear):
        * storage/StorageAreaImpl.h:
        * storage/StorageMap.cpp:
        (WebCore::StorageMap::create):
        (WebCore::StorageMap::StorageMap):
        (WebCore::StorageMap::copy):
        (WebCore::StorageMap::setItem):
        (WebCore::StorageMap::removeItem):
        (WebCore::StorageMap::importItem):
        * storage/StorageMap.h:
        (WebCore::StorageMap::quota):
        * storage/StorageNamespace.cpp:
        (WebCore::StorageNamespace::localStorageNamespace):
        * storage/StorageNamespace.h:
        * storage/StorageNamespaceImpl.cpp:
        (WebCore::StorageNamespaceImpl::localStorageNamespace):
        (WebCore::StorageNamespaceImpl::sessionStorageNamespace):
        (WebCore::StorageNamespaceImpl::StorageNamespaceImpl):
        (WebCore::StorageNamespaceImpl::copy):
        (WebCore::StorageNamespaceImpl::storageArea):
        * storage/StorageNamespaceImpl.h:
2009-10-02  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        Implement per-storage-area quotas for LocalStorage
        https://bugs.webkit.org/show_bug.cgi?id=29991

        I put 90% of the code in StorageMap since the decision to allow an update is
        closely tied to quota tracking.  The quota is set via a page's Settings class.
        Like with the local storage path and whether it's enabled, it's assumed that
        all pages in the same group will have the same settings.  The setting defaults
        to 5mb which is what the spec suggests, but it can easily be changed to
        anything else--including StorageMap::noQuota.  Any values in LocalStorage are
        grandfathered in regarudless of quota, so importItem only tracks (and will
        never block) imports.

        I believe this change is a good transition to more complex quota management.
        For example, if we wanted to track quotas in the SQLite DB, then we'd just add
        a function to the StorageMap that sets the quota.  This would be fine since all
        use of LocalStorage is blocked on the import completing, so you'd never hit a
        quota error in the mean time.  Also, if embedders wanted to ask the user
        whether to expand the quota whenever it's hit (before deciding whether or not
        to raise an exception), a callback via the chrome client should be fairly easy.
        That said, I think it's best to add these features in steps rather than one
        huge patch.  (Both of these are on my TODO list, btw.)

        Included is a layout test that verifies the behavior.  It assumes the default
        quota is 5mb (since that's what Settings defaults to).

        * storage/domstorage/localstorage/quota-expected.txt: Added.
        * storage/domstorage/localstorage/quota.html: Added.
        * storage/domstorage/script-tests/quota.js: Added.
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 2 Oct 2009 20:09:02 +0000 (20:09 +0000)]
2009-10-02  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Database Inspector crashes Safari when table has more than 21 columns
        https://bugs.webkit.org/show_bug.cgi?id=29924

        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.dataGridForResult): adjust the minimum column width percentage to be flexible for many columns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Windows bustage.
hyatt@apple.com [Fri, 2 Oct 2009 20:07:34 +0000 (20:07 +0000)]
Fix Windows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Windows bustage.
hyatt@apple.com [Fri, 2 Oct 2009 20:07:15 +0000 (20:07 +0000)]
Fix Windows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Fri, 2 Oct 2009 20:01:46 +0000 (20:01 +0000)]
2009-10-02  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Timothy Hatcher.

        Fixes <http://webkit.org/b/14370>.
        Inspector's timeline should record when certain DOM events fired.

        This patch adds calls into the Web Inspector when the main frame
        fires an load event, and when the document fires its DOMContent
        event. Once these values are passed in, they are sent to the Web Inspector
        as a timing change, and these are denoted by vertical lines in the resources
        panel (blue for DOM Content, red for load event).

        * English.lproj/localizedStrings.js: Added tooltip text.
        * dom/Document.cpp:
        (WebCore::Document::finishedParsing): Added an Inspector callback for DOM Content.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::mainResourceFiredDOMContentEvent): Tell the main resource it got the event.
        (WebCore::InspectorController::mainResourceFiredLoadEvent): Ditto.
        * inspector/InspectorController.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::InspectorResource): Added new variables.
        (WebCore::InspectorResource::updateScriptObject): Send new variables to inspector.js.
        (WebCore::InspectorResource::markDOMContentEventTime): Send a TimingChange event.
        (WebCore::InspectorResource::markLoadEventTime): Ditto.
        * inspector/InspectorResource.h:
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.get mainResourceLoadTime):
        (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime):
        (WebInspector.ResourcesPanel.prototype.get mainResourceDOMContentTime):
        (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime):
        (WebInspector.ResourcesPanel.prototype.reset):
        (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Draw dividers for event timings.
        (WebInspector.ResourceTimeCalculator.prototype.computePercentageFromEventTime):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent): Add an Inspector callback for the Load event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix Windows bustage.
hyatt@apple.com [Fri, 2 Oct 2009 20:00:13 +0000 (20:00 +0000)]
Fix Windows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate DUmpRenderTree to account for new API.
hyatt@apple.com [Fri, 2 Oct 2009 19:57:51 +0000 (19:57 +0000)]
Update DUmpRenderTree to account for new API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd support for blacklist patterns to user stylesheets and scripts in addition to...
hyatt@apple.com [Fri, 2 Oct 2009 19:42:39 +0000 (19:42 +0000)]
Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns.

Reviewed by Adam Roben.

WebCore:

* WebCore.base.exp:
* dom/Document.cpp:
(WebCore::Document::pageGroupUserSheets):
* page/Frame.cpp:
(WebCore::Frame::injectUserScriptsForWorld):
* page/PageGroup.cpp:
(WebCore::PageGroup::addUserScript):
(WebCore::PageGroup::addUserStyleSheet):
(WebCore::PageGroup::removeUserContentWithURLForWorld):
(WebCore::PageGroup::removeUserContentForWorld):
* page/PageGroup.h:
* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::matchesPatterns):
* page/UserContentURLPattern.h:
* page/UserScript.h:
(WebCore::UserScript::UserScript):
(WebCore::UserScript::whitelist):
(WebCore::UserScript::blacklist):
* page/UserStyleSheet.h:
(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::whitelist):
(WebCore::UserStyleSheet::blacklist):

WebKit/mac:

* WebView/WebView.mm:
(toStringVector):
(+[WebView _addUserScriptToGroup:source:url:worldID:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:source:url:worldID:whitelist:blacklist:]):
* WebView/WebViewPrivate.h:

WebKit/win:

* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
* WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Fri, 2 Oct 2009 18:41:39 +0000 (18:41 +0000)]
2009-10-02  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Added gyp_webkit that does a subset of the things gyp_chromium does
        plus some specialization for an upstream chromium build.

        https://bugs.webkit.org/show_bug.cgi?id=29986

        * chromium/DEPS: Points to gyp_webkit instead of gyp_chromium.
        * chromium/gyp_webkit: A new python file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 2 Oct 2009 18:08:14 +0000 (18:08 +0000)]
2009-10-02  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adam Roben.

        <rdar://problem/7271334>
        Rename MediaControllerThemeQT to MediaControllerThemeQuickTime

        * WebKitSystemInterface.h:
        MediaControllerThemeQT -> MediaControllerThemeQuickTime

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRolled back in r49004 with the debug 64bit build fixed
ggaren@apple.com [Fri, 2 Oct 2009 18:06:49 +0000 (18:06 +0000)]
Rolled back in r49004 with the debug 64bit build fixed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Fri, 2 Oct 2009 18:02:48 +0000 (18:02 +0000)]
2009-10-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        Build fix when SVG is not enabled
        https://bugs.webkit.org/show_bug.cgi?id=30011

        Move TextRenderingMode related functions out from
        the ENABLE(SVG) guard.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator TextRenderingMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Fri, 2 Oct 2009 17:57:37 +0000 (17:57 +0000)]
2009-10-02  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Adam Roben.

        svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
        this will help the patch merging process when TryBots are used.

        * Scripts/svn-create-patch:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago WebGL crashes with recent CanvasArray change
cmarrin@apple.com [Fri, 2 Oct 2009 17:49:33 +0000 (17:49 +0000)]
    WebGL crashes with recent CanvasArray change
        https://bugs.webkit.org/show_bug.cgi?id=30018

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<https://bugs.webkit.org/show_bug.cgi?id=29989>
sfalken@apple.com [Fri, 2 Oct 2009 17:22:33 +0000 (17:22 +0000)]
<https://bugs.webkit.org/show_bug.cgi?id=29989>
Safari version number shouldn't be exposed in WebKit code

Reviewed by Mark Rowe.

For a WebKit version of 532.3.4:
Product version is: 5.32.3.4 (was 4.0.3.0)
File version is: 5.32.3.4 (was 4.532.3.4)

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc:

WebCore:

* WebCore.vcproj/QTMovieWin.rc:

WebKit/win:

* WebKit.vcproj/WebKit.rc:

WebKitLibraries:

* win/tools/scripts/PRODUCTVERSION: Removed.
* win/tools/scripts/auto-version.sh: Re-worked script to remove references to PRODUCTVERSION.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoEnable two point radial gradients in Chromium/Skia.
senorblanco@chromium.org [Fri, 2 Oct 2009 17:19:44 +0000 (17:19 +0000)]
Enable two point radial gradients in Chromium/Skia.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=30017

Covered by the following tests:

LayoutTests/svg/W3C-SVG-1.1/pservers-grad-13-b.svg
LayoutTests/fast/backgrounds/svg-as-background-3.html
LayoutTests/fast/gradients/generated-gradients.html
LayoutTests/fast/gradients/simple-gradients.html

* platform/graphics/skia/GradientSkia.cpp:
(WebCore::Gradient::platformGradient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Fri, 2 Oct 2009 16:14:49 +0000 (16:14 +0000)]
2009-10-02  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement layoutTestController.overridePreference().
        https://bugs.webkit.org/show_bug.cgi?id=29970

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::WebPage::WebPage):
        (WebCore::WebPage::resetSettings):
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::setPrivateBrowsingEnabled):
        (LayoutTestController::setPopupBlockingEnabled):
        (LayoutTestController::overridePreference):
        * DumpRenderTree/qt/jsobjects.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Norbert Leser <norbert.leser@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 2 Oct 2009 15:49:27 +0000 (15:49 +0000)]
2009-10-02  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Simon Hausmann.

        Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
        Otherwise, it is inconsistent with class declaration of QCursor.

        * Api/qgraphicswebview.cpp:
        * Api/qwebview.cpp:

2009-10-02  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Simon Hausmann.

        Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
        Otherwise, it is inconsistent with class declaration of QCursor.

        No new tests.

        * platform/qt/QWebPageClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt on Mac OS X build.
vestbo@webkit.org [Fri, 2 Oct 2009 15:40:52 +0000 (15:40 +0000)]
Fix the Qt on Mac OS X build.

Rubber-stamped by Simon Hausmann.

* wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Fri, 2 Oct 2009 11:32:40 +0000 (11:32 +0000)]
2009-10-02  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] missing support for anamorphic PAR video size
        https://bugs.webkit.org/show_bug.cgi?id=29717

        cleanup of caps handling in the video sink

        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_set_caps):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago.: Disable a few more harmless MSVC warnings.
hausmann@webkit.org [Fri, 2 Oct 2009 11:18:06 +0000 (11:18 +0000)]
.: Disable a few more harmless MSVC warnings.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

* WebKit.pri:

WebCore: Fix compiler warnings about unused function arguments.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

* bridge/qt/qt_class.h:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
* dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::initializeParserContext):
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::getCachedFontPlatformData):
* platform/graphics/qt/FontFallbackListQt.cpp:
(WebCore::FontFallbackList::setPlatformFont):
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setURLForRect):
* platform/graphics/qt/IconQt.cpp:
(WebCore::Icon::createIconForFiles):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::frameBufferAtIndex):
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::setEndTime):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::containsCharacters):
* platform/graphics/qt/StillImageQt.h:
(WebCore::StillImage::destroyDecodedData):
* platform/network/qt/DnsPrefetchHelper.h:
(WebCore::DnsPrefetchHelper::lookedUp):
* platform/qt/ContextMenuQt.cpp:
(WebCore::ContextMenu::setPlatformDescription):
* platform/qt/DragDataQt.cpp:
(WebCore::DragData::asURL):
* platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenu::populate):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::supportsFocusRing):
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMediaSeekBackButton):
(WebCore::RenderThemeQt::paintMediaSeekForwardButton):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::platformAddChild):
* platform/qt/SearchPopupMenuQt.cpp:
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
* platform/qt/TemporaryLinkStubs.cpp:
(WebCore::signedPublicKeyAndChallengeString):
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::paint):
* xml/XSLStyleSheetQt.cpp:
(WebCore::XSLStyleSheet::loadChildSheet):
(WebCore::XSLStyleSheet::setParentStyleSheet):
* xml/XSLTProcessorQt.cpp:
(WebCore::XSLTMessageHandler::handleMessage):
(WebCore::XSLTProcessor::transformToString):

WebKit/qt: Fix compiler warnings about unused function arguments.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

* Api/qwebframe.cpp:
(QWebFrame::scrollBarMinimum):
* Api/qwebpage.cpp:
(QWebPagePrivate::focusInEvent):
(QWebPagePrivate::focusOutEvent):
(QWebPagePrivate::leaveEvent):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::triggerAction):
(QWebPage::acceptNavigationRequest):
(QWebPage::chooseFile):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::mouseDidMoveOverElement):
(WebCore::ChromeClientQt::reachedMaxAppCacheSize):
* WebCoreSupport/ContextMenuClientQt.cpp:
(WebCore::ContextMenuClientQt::downloadURL):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
(WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
(WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
(WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
(WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):
(WebCore::FrameLoaderClientQt::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientQt::createJavaAppletWidget):
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::setAttachedWindowHeight):
(WebCore::InspectorClientQt::highlight):
(WebCore::InspectorClientQt::removeSetting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Ben Murdoch <benm@google.com>
eric@webkit.org [Fri, 2 Oct 2009 11:14:58 +0000 (11:14 +0000)]
2009-10-02  Ben Murdoch  <benm@google.com>

        Reviewed by David Kilzer.

        Stale database version persists through browser refresh (changeVersion doesn't work)
        https://bugs.webkit.org/show_bug.cgi?id=27836

        Scale the cairo surface of the video sink depending on the
        pixel-aspect-ratio of the video buffer to paint. Also
        destruct/re-create the surface when setSize() is called with a new
        size.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::naturalSize):
        (WebCore::MediaPlayerPrivate::setSize):
        (WebCore::MediaPlayerPrivate::paint):
        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_idle_func):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoStale database version persists through browser refresh (changeVersion doesn't work)
benm@google.com [Fri, 2 Oct 2009 10:19:45 +0000 (10:19 +0000)]
Stale database version persists through browser refresh (changeVersion doesn't work)
https://bugs.webkit.org/show_bug.cgi?id=27836

WebCore:

Reviewed by David Kilzer.

Tests: storage/change-version-handle-reuse.html
       storage/change-version.html

* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL): Implement the V8 binding for database.changeVersion().
(WebCore::createTransaction): Fix a bug that was checking the wrong argument index to save the success callback.
* storage/Database.cpp:
(WebCore::updateGuidVersionMap): Safely update the Guid/version hash map.
(WebCore::Database::~Database): Remove code that removes the database from the guid->database and guid->version maps.
(WebCore::Database::setVersionInDatabase): Add a comment to explain some behaviour.
(WebCore::Database::close): Move the code that updates the maps from the destructor to here.
(WebCore::Database::performOpenAndVerify): Call updateGuidVersionMap instead of setting the hash map directly.
(WebCore::Database::setExpectedVersion): Update the in memory guid->version map when we want to update the database version.

LayoutTests:

Reviewed by  David Kilzer.

* storage/change-version-expected.txt: Added.
* storage/change-version-handle-reuse-expected.txt: Added.
* storage/change-version-handle-reuse.html: Added.
* storage/change-version.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPartial WINSCW build fix.
hausmann@webkit.org [Fri, 2 Oct 2009 08:34:11 +0000 (08:34 +0000)]
Partial WINSCW build fix.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-10-02
Reviewed by Simon Hausmann.

Add parentheses around the function pointer declaration, similar to the
second hunk in r48825.

* loader/CachedResourceHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49017 268f45cc-cd09-0410-ab3c-d52691b4dbfc