WebKit-https.git
11 years agoMove the shared LineBreakIteratorPool from ThreadGlobalData into its own ThreadSpecific
mitz@apple.com [Sat, 6 Aug 2011 17:00:48 +0000 (17:00 +0000)]
Move the shared LineBreakIteratorPool from ThreadGlobalData into its own ThreadSpecific
https://bugs.webkit.org/show_bug.cgi?id=65809

Reviewed by Darin Adler and Sam Weinig.

* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::destroy): Removed code to clear the m_lineBreakIteratorPool member
variable, which was removed.
* platform/ThreadGlobalData.h: Removed lineBreakIteratorPool() and associated member variable.
* platform/text/LineBreakIteratorPoolICU.h:
(WebCore::LineBreakIteratorPool::sharedPool): Changed to return a thread-specific pool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPotential Leaks - RetainPtr<> over retaining Create'd objects
joepeck@webkit.org [Sat, 6 Aug 2011 16:17:14 +0000 (16:17 +0000)]
Potential Leaks - RetainPtr<> over retaining Create'd objects
https://bugs.webkit.org/show_bug.cgi?id=65806

Reviewed by Darin Adler.

Fix a possible leak by adopting an allocation instead of retaining it.

Source/WebCore:

* platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
* plugins/mac/PluginPackageMac.cpp:
(WebCore::stringListFromResourceId):
(WebCore::PluginPackage::fetchInfo):

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView previousValidKeyView]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (r91540): Favicons are not loaded
commit-queue@webkit.org [Sat, 6 Aug 2011 15:57:09 +0000 (15:57 +0000)]
REGRESSION (r91540): Favicons are not loaded
https://bugs.webkit.org/show_bug.cgi?id=65692

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-08-06
Reviewed by Darin Adler.

The policy that evaluates whether a page can have icon or not should not
need to be reimplemented each time a new IconDatabaseBase is derived,
so it was moved to WebCore's scope.

* loader/icon/IconController.cpp:
(WebCore::IconController::startLoader):
* loader/icon/IconDatabase.cpp:
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseBase.cpp:
(WebCore::documentCanHaveIcon):
* loader/icon/IconDatabaseBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 6 Aug 2011 15:23:59 +0000 (15:23 +0000)]
2011-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
        https://bugs.webkit.org/show_bug.cgi?id=63186

        It turns out r92545 only partly resolved flakiness on non-mac platforms (especially gtk)
        - try reentering event loop after zooming, by calling notifyDone() using a 0ms timeout.

        Rubber-stamped by Antti Koivisto.

        * svg/zoom/resources/testPageZoom.js:
        (.setTimeout.): Reenter event loop after calling zoomPageIn/Out, before calling layoutTestController.notifyDone().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoShould use C++-style cast in CSSParser.cpp
bashi@chromium.org [Sat, 6 Aug 2011 10:02:38 +0000 (10:02 +0000)]
Should use C++-style cast in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=65807

Replaces C-style cast with C++style cast.

Reviewed by Shinichiro Hamaji.

No new tests because no behavior change.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseColorFromValue):
(WebCore::CSSParser::parseFontFeatureTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 6 Aug 2011 09:40:43 +0000 (09:40 +0000)]
2011-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        More gardening: Fix mac-leopard/mac-wk2 failing SVG tests.

        Not reviewed.

        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
        * platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
        * platform/mac-wk2/svg/W3C-SVG-1.1: Added.
        * platform/mac-wk2/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
        * platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
        * platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
        * platform/mac-wk2/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 6 Aug 2011 09:27:19 +0000 (09:27 +0000)]
2011-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Win gardening: Rebaseline four svg tests that only needed an update, win7/winxp svg results are clean again.

        Not reviewed.

        * platform/win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
        * platform/win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
        * platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
        * platform/win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
        * platform/win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 6 Aug 2011 09:19:44 +0000 (09:19 +0000)]
2011-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Follow-up for r92545.

        Rebaseline some tests on gtk/qt and win.

        * platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
        * platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
        * platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
        * platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
        * platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
        * platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 6 Aug 2011 08:25:44 +0000 (08:25 +0000)]
2011-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
        https://bugs.webkit.org/show_bug.cgi?id=64974

        svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
        https://bugs.webkit.org/show_bug.cgi?id=63186

        Reviewed by Zoltan Herczeg.

        Rollout r89484, which disabled some svg/zoom/page tests, to see whether the flakiness is gone now.
        Add several new tests in svg/as-object - covering bug 64974.

        * platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
        * platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
        * platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
        * platform/mac/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
        * platform/mac/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
        * platform/mac/svg/as-object/embedded-svg-size-changes-expected.png: Added.
        * platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Added.
        * platform/mac/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.txt: Added.
        * platform/mac/svg/as-object/nested-embedded-svg-size-changes-expected.png: Added.
        * platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Added.
        * platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt: Added.
        * platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Added.
        * platform/mac/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt: Added.
        * svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html: Added.
        * svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html: Added.
        * svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
        * svg/as-object/embedded-svg-immediate-offsetWidth-query.html: Added.
        * svg/as-object/embedded-svg-size-changes-expected.txt: Added.
        * svg/as-object/embedded-svg-size-changes-no-layout-triggers.html: Added.
        * svg/as-object/embedded-svg-size-changes.html: Added.
        * svg/as-object/nested-embedded-svg-size-changes-expected.txt: Added.
        * svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html: Added.
        * svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html: Added.
        * svg/as-object/nested-embedded-svg-size-changes.html: Added.
        * svg/as-object/resources: Added.
        * svg/as-object/resources/embedded-svg-size-changes-no-layout-triggers.svg: Added.
        * svg/as-object/resources/embedded-svg-size-changes.svg: Added.
        * svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-1.html: Added.
        * svg/as-object/resources/nested-embedded-svg-size-changes-target-no-layout-triggers-2.html: Added.
        * svg/as-object/resources/nested-embedded-svg-size-changes-target.html: Added.
        * svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled.
        * svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Removed.
        * svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled.
        * svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Removed.
        * svg/zoom/page/zoom-svg-through-object-with-auto-size.html: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled.
        * svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled: Removed.
        * svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled.
        * svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Removed.
        * svg/zoom/page/zoom-svg-through-object-with-override-size.html: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled.
        * svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Removed.
        * svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Copied from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled.
        * svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Removed.

2011-08-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
        https://bugs.webkit.org/show_bug.cgi?id=64974

        svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
        https://bugs.webkit.org/show_bug.cgi?id=63186

        Reviewed by Zoltan Herczeg.

        Fix host <-> embedded document size negotiation race. The currently implemented solution relied on a specific
        order of paint/layout calls, which is broken. Consider rendering a document containing an object/iframe/embed
        referencing an external SVG file. When FrameView::layout() is called (associated with the outermost RenderView
        of the host document), it lays out the whole document, and afterwards performPostLayoutTasks() is called.
        This method then asks the Frames contentRenderer to update its widget positions. This triggers a call
        of the embedded documents FrameView::layout() method, which now lays out the embedded SVG documents tree
        through RenderSVGRoot::layout.

        And here's the bug: The size of the object/iframe replaced element, which hosts the embedded document
        may depend on the intrinsic size of the SVG. We tried to mark the embedded documents _ownerRenderer_ (the RenderPart)
        as "needs layout and pref width recalc" right from RenderSVGRoot::layout() and hoped that this would cause the whole
        document to be laid out again, now that the size of the embedded SVG document is known.

        As soon as the SVG document is laid out, the host document will be painted (flush deferred repaints) and an assertion
        ASSERTS(!needsLayout()) will be fired, as we modified the setNeedsLayout() state after the host document layout finished,
        right before painting.

        A proper fix is to only keep track in RenderSVGRoot whether it needs to negotiate the size with the host document, but
        not modify the layout state of the host document in any way. Let FrameView handle the size negotiation right in
        FrameView::layout().

        Consider following document:
        <body><iframe src="some.svg"></body>

        After initial loading & parsing of the document, a FrameView exists for the main frame, and a sub-FrameView
        for the <iframe>. The external SVG document, may not be loaded yet at this point. That means when RenderIFrame::layout()
        tries to figure out its size (computeLogicalWidth/Height) - the RenderSVGRoot renderer of the external document hasn't
        been created yet (as the external document hasn't received data yet) - so it falls back to eg. 300x150 CSS default size
        (in the simplest case, where width/height are both auto).

        Suppose the external document now finished loading, the RenderSVGRoot is created and a global relayout is triggered
        starting from the main FrameView. As we already laid out the document once, needsLayout() is false for the main FrameView,
        so _only_ the child frame view that contains the RenderSVGRoot is now laid out, for the first time.

        After layout is done, the SVG document is fully laid out, though the RenderPart which embedded the SVG does NOT notice
        the SVG has been laid out, so it still carries the default 300x150 size (and needsLayout=false!).

        The fix is to retrigger layout of the parent frame view by marking the owner renderer of the frame view as "needs layout
        and pref widths recalc" and immediatiely performing a synchronous update of the layout. It's important to do it sync,
        as scripts depend on the result of the size negotiation (covered extensively with the new tests in svg/as-object).

        Reenable svg/zoom/page/zoom-svg-through-object* tests to see whether the flakiness is gone.

        Tests: svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html
               svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html
               svg/as-object/embedded-svg-immediate-offsetWidth-query.html
               svg/as-object/embedded-svg-size-changes-no-layout-triggers.html
               svg/as-object/embedded-svg-size-changes.html
               svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html
               svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html
               svg/as-object/nested-embedded-svg-size-changes.html
               svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
               svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
               svg/zoom/page/zoom-svg-through-object-with-auto-size.html
               svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
               svg/zoom/page/zoom-svg-through-object-with-override-size.html
               svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml

        * page/FrameView.cpp:
        (WebCore::FrameView::layout): Call forceLayoutParentViewIfNeeded() after layout finished.
        (WebCore::FrameView::forceLayoutParentViewIfNeeded): Added helper method.
        (WebCore::FrameView::embeddedContentBox): Moved from RenderPart to a more central place.
        * page/FrameView.h:
        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::embeddedContentBox): Moved to FrameView.
        * rendering/svg/RenderSVGRoot.cpp: Rename m_didNegotiateSize to m_needsSizeNegotiationWithHostDocument.
        (WebCore::RenderSVGRoot::RenderSVGRoot):
        (WebCore::RenderSVGRoot::layout): Only figure out if we need neggotiation, don't actually do anything, let FrameView handle this.
        * rendering/svg/RenderSVGRoot.h: Remove incorrect negotiateSizeWithHostDocumentIfNeeded() logic.
        (WebCore::RenderSVGRoot::needsSizeNegotiationWithHostDocument): Added getter for m_needsSizeNegotiationWithHostDocument.
        (WebCore::RenderSVGRoot::scheduledSizeNegotiationWithHostDocument): Added safe way to clear m_needsSizeNegotiationWithHostDocument (asserts if it was false before).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Chromium] Remove HaltablePlugin references from gyp project files
commit-queue@webkit.org [Sat, 6 Aug 2011 04:14:02 +0000 (04:14 +0000)]
[Chromium] Remove HaltablePlugin references from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=65808

HaltablePlugin and related classes were removed in r92492.  Remove any
reference to the deleted files from the gyp project files.

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-05
Reviewed by Adam Barth.

* WebCore.gypi: remove HaltablePlugin.h reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRenamed fast/blockflow to fast/writing-mode.
mitz@apple.com [Sat, 6 Aug 2011 03:49:48 +0000 (03:49 +0000)]
Renamed fast/blockflow to fast/writing-mode.

Rubber-stamped by Sam Weinig.

* fast/blockflow: Removed.
* fast/writing-mode: Copied from fast/blockflow.
* platform/chromium-linux/fast/blockflow: Removed.
* platform/chromium-linux/fast/writing-mode: Copied from platform/chromium-linux/fast/blockflow.
* platform/chromium-mac-leopard/fast/blockflow: Removed.
* platform/chromium-mac-leopard/fast/writing-mode: Copied from platform/chromium-mac-leopard/fast/blockflow.
* platform/chromium-mac/fast/blockflow: Removed.
* platform/chromium-mac/fast/writing-mode: Copied from platform/chromium-mac/fast/blockflow.
* platform/chromium-win-vista/fast/blockflow: Removed.
* platform/chromium-win-vista/fast/writing-mode: Copied from platform/chromium-win-vista/fast/blockflow.
* platform/chromium-win-xp/fast/blockflow: Removed.
* platform/chromium-win-xp/fast/writing-mode: Copied from platform/chromium-win-xp/fast/blockflow.
* platform/chromium-win/fast/blockflow: Removed.
* platform/chromium-win/fast/writing-mode: Copied from platform/chromium-win/fast/blockflow.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/blockflow: Removed.
* platform/gtk/fast/writing-mode: Copied from platform/gtk/fast/blockflow.
* platform/mac-leopard/fast/blockflow: Removed.
* platform/mac-leopard/fast/writing-mode: Copied from platform/mac-leopard/fast/blockflow.
* platform/mac-wk2/fast/blockflow: Removed.
* platform/mac-wk2/fast/writing-mode: Copied from platform/mac-wk2/fast/blockflow.
* platform/mac/Skipped:
* platform/mac/fast/blockflow: Removed.
* platform/mac/fast/writing-mode: Copied from platform/mac/fast/blockflow.
* platform/qt-mac/Skipped:
* platform/qt/Skipped:
* platform/qt/fast/blockflow: Removed.
* platform/qt/fast/writing-mode: Copied from platform/qt/fast/blockflow.
* platform/win/fast/blockflow: Removed.
* platform/win/fast/writing-mode: Copied from platform/win/fast/blockflow.
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAttempt to fix the build after r92538.
mrowe@apple.com [Sat, 6 Aug 2011 03:09:23 +0000 (03:09 +0000)]
Attempt to fix the build after r92538.

Like all of the recent "track"-related work the new files in r92538 appear to have
been added to completely random places in the Xcode project. However, this time
the file paths were marked as being relative to their containing group resulting in
Xcode being unable to find the files on disk.

I've attempted to clean up all of the "track"-related mess in the Xcode project.
The location of the files in the project now reflect their locations on disk, and
are all correctly marked as being relative to their containing group as is our
convention.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=64613
commit-queue@webkit.org [Sat, 6 Aug 2011 02:25:57 +0000 (02:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=64613
Use supported framebuffer renderbuffer mode; chromium command buffer
allows DEPTH and STENCIL but not DEPTH_STENCIL.

Patch by Tom Hudson <tomhudson@google.com> on 2011-08-05
Reviewed by James Robinson.

No new tests because was caught by extant tests, albeit only when
accelerated drawing and forced compositing were both turned on.

* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoString replace with the empty string means string removal
barraclough@apple.com [Sat, 6 Aug 2011 02:17:55 +0000 (02:17 +0000)]
String replace with the empty string means string removal
https://bugs.webkit.org/show_bug.cgi?id=65799

Reviewed by Sam Weinig.

Optimization for String.prototype.replace([RegExp], ""), this improves v8-regexp by ~3%.

* runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstrings):
(JSC::stringProtoFuncReplace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agor92330 has been rolled out so its rebaseline needs to be reverted as well
rniwa@webkit.org [Sat, 6 Aug 2011 02:07:55 +0000 (02:07 +0000)]
r92330 has been rolled out so its rebaseline needs to be reverted as well
https://bugs.webkit.org/show_bug.cgi?id=65805

* platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt: Added.
* platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt: Added.
* platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdding a WebVTTParser for <track>.
commit-queue@webkit.org [Sat, 6 Aug 2011 02:00:52 +0000 (02:00 +0000)]
Adding a WebVTTParser for <track>.
https://bugs.webkit.org/show_bug.cgi?id=62882

Patch by Anna Cavender <annacc@chromium.org> on 2011-08-05
Reviewed by Eric Carlson.

Feature is hidden behind VIDEO_TRACK feature define, which is turned off, but
new tests have been added in media/track/ (and are skipped).

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* html/TextTrackCue.cpp:
* html/TextTrackCue.h:
* platform/track/CueParser.cpp:
* platform/track/CueParser.h:
* platform/track/CueParserPrivate.h:
* platform/track/WebVTTParser.cpp: Added.
* platform/track/WebVTTParser.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, rolling out r92330.
commit-queue@webkit.org [Sat, 6 Aug 2011 01:47:07 +0000 (01:47 +0000)]
Unreviewed, rolling out r92330.
http://trac.webkit.org/changeset/92330
https://bugs.webkit.org/show_bug.cgi?id=65804

caused various regressions in paste (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-05

Source/WebCore:

* editing/ReplaceSelectionCommand.cpp:
(WebCore::isInlineNodeWithStyle):
(WebCore::ReplaceSelectionCommand::doApply):
* editing/markup.cpp:
(WebCore::ancestorToRetainStructureAndAppearance):
* editing/markup.h:

LayoutTests:

* editing/pasteboard/5065605-expected.txt:
* editing/pasteboard/copy-paste-text-in-h1-expected.txt: Removed.
* editing/pasteboard/copy-paste-text-in-h1.html: Removed.
* editing/pasteboard/display-block-on-spans-expected.txt:
* editing/pasteboard/paste-pre-001-expected.txt:
* editing/pasteboard/paste-pre-002-expected.txt:
* editing/pasteboard/paste-text-011-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Chromium] Remove JSZombie references from gyp project files.
commit-queue@webkit.org [Sat, 6 Aug 2011 01:45:51 +0000 (01:45 +0000)]
[Chromium] Remove JSZombie references from gyp project files.
https://bugs.webkit.org/show_bug.cgi?id=65798

JSC runtime/JSZombie.{cpp,h} were removed in r92046.  Remove references to these
file names from the gyp projects.

Patch by Noel Gordon <noel.gordon@gmail.com> on 2011-08-05
Reviewed by Darin Adler.

* JavaScriptCore.gypi: zombies be gone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, rolling out r92477.
tkent@chromium.org [Sat, 6 Aug 2011 01:06:43 +0000 (01:06 +0000)]
Unreviewed, rolling out r92477.
http://trac.webkit.org/changeset/92477
https://bugs.webkit.org/show_bug.cgi?id=62619

Layering violation. We should not use WebCore/dom/ in
WebCore/platform/.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* html/ColorInputType.cpp:
(WebCore::ColorInputType::valueChanged):
* html/ColorInputType.h:
* html/FileInputType.cpp:
(WebCore::FileInputType::chrome):
* html/FileInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::detach):
* html/InputType.cpp:
* html/InputType.h:
* loader/EmptyClients.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
* page/Chrome.cpp:
* page/Chrome.h:
* page/ChromeClient.h:
* platform/ColorChooser.cpp: Removed.
* platform/ColorChooser.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTry to fix Qt Mac build.
darin@apple.com [Sat, 6 Aug 2011 00:47:03 +0000 (00:47 +0000)]
Try to fix Qt Mac build.

* plugins/mac/PluginViewMac.mm: Removed PluginHalter functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSkip a failing test added by r92526 to Qt's skipped list.
rniwa@webkit.org [Sat, 6 Aug 2011 00:41:15 +0000 (00:41 +0000)]
Skip a failing test added by r92526 to Qt's skipped list.
The failure is tracked by the bug 65801.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLeak in CFNetwork Loader RetainPtr<> should Adopt a Copy allocation
joepeck@webkit.org [Sat, 6 Aug 2011 00:24:50 +0000 (00:24 +0000)]
Leak in CFNetwork Loader RetainPtr<> should Adopt a Copy allocation
https://bugs.webkit.org/show_bug.cgi?id=65789

Reviewed by David Kilzer.

Fix a leak by adopting an allocation instead of retaining it.

* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::httpBodyFromRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoIntroduced fast path for border rendering when all visible sides are solid, same...
commit-queue@webkit.org [Sat, 6 Aug 2011 00:15:53 +0000 (00:15 +0000)]
Introduced fast path for border rendering when all visible sides are solid, same rgba color but not all visible
https://bugs.webkit.org/show_bug.cgi?id=65762

Patch by Ben Wells <benwells@chromium.org> on 2011-08-05
Reviewed by Simon Fraser.

No intended change in behaviour, no new tests.

* rendering/RenderBoxModelObject.cpp:
(WebCore::calculateSideRect):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed build fix on 32-bit Mac.
bashi@chromium.org [Sat, 6 Aug 2011 00:06:37 +0000 (00:06 +0000)]
Unreviewed build fix on 32-bit Mac.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-05

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFeatureTag): Added a cast to int.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSkip test eeza-Pro-vertical-metrics-adjustment.html in chromium.
jianli@chromium.org [Fri, 5 Aug 2011 23:53:35 +0000 (23:53 +0000)]
Skip test eeza-Pro-vertical-metrics-adjustment.html in chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpwards cursor movement incorrect when previous block ends with <br>
rniwa@webkit.org [Fri, 5 Aug 2011 23:41:51 +0000 (23:41 +0000)]
Upwards cursor movement incorrect when previous block ends with <br>
https://bugs.webkit.org/show_bug.cgi?id=33247

Reviewed by Tony Chang.

Source/WebCore:

The bug was caused by previousLinePosition's trying to obtain the root line box at the position
after the previous line's br. This obviously fails because the the position after br is considered
as a part of the next line.

Fixed the bug by obtaining root inline boxes using position at the minimum caret offset as supposed
to maximum caret offset. The code was initially introduced by r32508 to fix arrow key movement in RTL text
but the test added by the revision continues to pass after this change. Furthermore, this change makes
new code consistent with nextLinePosition.

Also reverted the change added by r55613 because it is no longer needed.

Tests: editing/execCommand/move-selection-back-line-rtl.html
       editing/execCommand/move-selection-back-line-strict.html

* editing/visible_units.cpp:
(WebCore::previousLinePosition):

LayoutTests:

Added tests to ensure WebKit lets user move caret up in strict mode and in RTL content
when the previous line ends with a br.

* editing/execCommand/move-selection-back-line-rtl-expected.txt: Copied from
LayoutTests/editing/execCommand/move-selection-back-line-expected.txt.
* editing/execCommand/move-selection-back-line-rtl.html: Copied from
LayoutTests/editing/execCommand/move-selection-back-line.html.
* editing/execCommand/move-selection-back-line-strict-expected.txt: Copied from
LayoutTests/editing/execCommand/move-selection-back-line-expected.txt.
* editing/execCommand/move-selection-back-line-strict.html: Copied from
LayoutTests/editing/execCommand/move-selection-back-line.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<http://webkit.org/b/65785> ThreadRestrictionVerifier needs a mode where an object
mrowe@apple.com [Fri, 5 Aug 2011 22:36:51 +0000 (22:36 +0000)]
<webkit.org/b/65785> ThreadRestrictionVerifier needs a mode where an object
is tied to a particular dispatch queue

A RefCounted object can be opted in to this mode by calling setDispatchQueueForVerifier
with the dispatch queue it will be tied to. This will cause ThreadRestrictionVerifier
to ensure that all operations are performed on the given dispatch queue.

Reviewed by Anders Carlsson.

* wtf/RefCounted.h:
(WTF::RefCountedBase::setDispatchQueueForVerifier):
* wtf/ThreadRestrictionVerifier.h:
(WTF::ThreadRestrictionVerifier::ThreadRestrictionVerifier):
(WTF::ThreadRestrictionVerifier::~ThreadRestrictionVerifier):
(WTF::ThreadRestrictionVerifier::setDispatchQueueMode):
(WTF::ThreadRestrictionVerifier::setShared):
(WTF::ThreadRestrictionVerifier::isSafeToUse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Accelerated canvas breaks when moving canvases or resources between Pages
commit-queue@webkit.org [Fri, 5 Aug 2011 22:14:37 +0000 (22:14 +0000)]
[chromium] Accelerated canvas breaks when moving canvases or resources between Pages
https://bugs.webkit.org/show_bug.cgi?id=65402

Patch by James Robinson <jamesr@chromium.org> on 2011-08-05
Reviewed by Stephen White.

Source/WebCore:

Use one shared GraphicsContext3D for the whole process instead of one per Page as canvases can move between
pages and directly draw into contexts in different pages.  Also switches DrawingBufferChromium over to use a
directly shared the color attachment instead of copying it to a separate texture and removes the now-unnecessary
DrawingBuffer::didReset() call and WillPublishCallback mechanism.

* page/Page.cpp:
(WebCore::Page::sharedGraphicsContext3D):
* page/Page.h:
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
(WebCore::Canvas2DLayerChromium::textureId):
(WebCore::Canvas2DLayerChromium::setDrawingBuffer):
* platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::CanvasLayerChromium):
* platform/graphics/chromium/CanvasLayerChromium.h:
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::publishToPlatformLayer):
* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
* platform/graphics/chromium/WebGLLayerChromium.h:

Source/WebKit/chromium:

Remove plumbing for copyTextureToParentTexture extension, it's no longer used or needed.

* public/WebGraphicsContext3D.h:
* src/Extensions3DChromium.cpp:
* src/GraphicsContext3DChromium.cpp:
* src/GraphicsContext3DInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd more Lion specific test results and add more tests to the skipped list.
andersca@apple.com [Fri, 5 Aug 2011 22:08:24 +0000 (22:08 +0000)]
Add more Lion specific test results and add more tests to the skipped list.

* platform/mac-lion/Skipped:
* platform/mac-snowleopard/fast/dom: Added.
* platform/mac-snowleopard/fast/dom/52776-expected.png: Copied from platform/mac/fast/dom/52776-expected.png.
* platform/mac-snowleopard/fast/dom/52776-expected.txt: Copied from platform/mac/fast/dom/52776-expected.txt.
* platform/mac-snowleopard/fast/loader: Added.
* platform/mac-snowleopard/fast/preloader: Added.
* platform/mac-snowleopard/fast/preloader/document-write-2-expected.txt: Copied from fast/preloader/document-write-2-expected.txt.
* platform/mac-snowleopard/fast/preloader/document-write-expected.txt: Copied from fast/preloader/document-write-expected.txt.
* platform/mac-snowleopard/fast/preloader/script-expected.txt: Copied from fast/preloader/script-expected.txt.
* platform/mac/fast/dom/52776-expected.png:
* platform/mac/fast/dom/52776-expected.txt:
* platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
* platform/mac/fast/loader/file-url-mimetypes-expected.txt:
* platform/mac/fast/preloader: Added.
* platform/mac/fast/preloader/document-write-2-expected.txt: Added.
* platform/mac/fast/preloader/document-write-expected.txt: Added.
* platform/mac/fast/preloader/script-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSkip canvas-putImageData.html in chromium.
jianli@chromium.org [Fri, 5 Aug 2011 22:02:08 +0000 (22:02 +0000)]
Skip canvas-putImageData.html in chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix unit test breakage by plumbing convert_404_to_None in MockWeb.
dglazkov@chromium.org [Fri, 5 Aug 2011 21:33:32 +0000 (21:33 +0000)]
Fix unit test breakage by plumbing convert_404_to_None in MockWeb.

* Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoGarden-o-matic updateexpectations needs a unit test.
dglazkov@chromium.org [Fri, 5 Aug 2011 21:09:48 +0000 (21:09 +0000)]
Garden-o-matic updateexpectations needs a unit test.
https://bugs.webkit.org/show_bug.cgi?id=65780

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFuture proof an Objective-C test
andersca@apple.com [Fri, 5 Aug 2011 21:07:50 +0000 (21:07 +0000)]
Future proof an Objective-C test
https://bugs.webkit.org/show_bug.cgi?id=65788

Tools:

Reviewed by Dan Bernstein.

Add isObjectInstanceOf to ObjCController.

* DumpRenderTree/mac/ObjCController.m:
(+[ObjCController isSelectorExcludedFromWebScript:]):
(+[ObjCController webScriptNameForSelector:]):
(-[ObjCController isObject:instanceOf:]):

LayoutTests:

Don't check explicitly for class names; just check that the objects are instances of the right classes.

* platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
* platform/mac/fast/dom/wrapper-classes-objc.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a Lion specific test for fast/repaint/canvas-putImageData.html
andersca@apple.com [Fri, 5 Aug 2011 20:29:04 +0000 (20:29 +0000)]
Add a Lion specific test for fast/repaint/canvas-putImageData.html

* platform/mac-snowleopard/fast/repaint: Added.
* platform/mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt: Copied from fast/repaint/canvas-putImageData-expected.txt.
* platform/mac/fast/repaint/canvas-putImageData-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoActually commit the file.
andersca@apple.com [Fri, 5 Aug 2011 20:20:25 +0000 (20:20 +0000)]
Actually commit the file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Chromium build.
andersca@apple.com [Fri, 5 Aug 2011 20:19:56 +0000 (20:19 +0000)]
Fix Chromium build.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoInline allocation of function objects
oliver@apple.com [Fri, 5 Aug 2011 20:03:19 +0000 (20:03 +0000)]
Inline allocation of function objects
https://bugs.webkit.org/show_bug.cgi?id=65779

Reviewed by Gavin Barraclough.

Inline allocation and initilisation of function objects
in generated code.  This ended up being a 60-70% improvement
in function allocation performance.  This improvement shows
up as a ~2% improvement in 32bit sunspider and V8, but is a
wash on 64-bit.

We currently don't inline the allocation of named function
expressions, as that requires being able to gc allocate a
variable object.

* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
(JSC::JIT::emitStoreCell):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
(JSC::JIT::emitAllocateJSFinalObject):
(JSC::JIT::emitAllocateJSFunction):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emitSlow_op_new_func):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emitSlow_op_new_func_exp):
* jit/JITOpcodes32_64.cpp:
    Removed duplicate implementation of op_new_func and op_new_func_exp
* runtime/JSFunction.h:
(JSC::JSFunction::offsetOfScopeChain):
(JSC::JSFunction::offsetOfExecutable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agotrac.js needs unittests
abarth@webkit.org [Fri, 5 Aug 2011 19:55:49 +0000 (19:55 +0000)]
trac.js needs unittests
https://bugs.webkit.org/show_bug.cgi?id=65673

Reviewed by Dimitri Glazkov.

This tests also have somewhat large fixtures.  I've trimmed the example
XML down a bunch while still hitting interesting cases in the parsing.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd more Lion specific test results.
andersca@apple.com [Fri, 5 Aug 2011 19:49:38 +0000 (19:49 +0000)]
Add more Lion specific test results.

* platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.png: Copied from platform/mac/fast/text/capitalize-boundaries-expected.png.
* platform/mac-snowleopard/fast/text/capitalize-boundaries-expected.txt: Copied from platform/mac/fast/text/capitalize-boundaries-expected.txt.
* platform/mac-snowleopard/fast/text/complex-text-opacity-expected.png: Copied from platform/mac/fast/text/complex-text-opacity-expected.png.
* platform/mac-snowleopard/fast/text/complex-text-opacity-expected.txt: Copied from platform/mac/fast/text/complex-text-opacity-expected.txt.
* platform/mac-snowleopard/fast/text/international: Added.
* platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Copied from platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt.
* platform/mac-snowleopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Copied from platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html.
* platform/mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.png: Copied from platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
* platform/mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
* platform/mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Copied from platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png.
* platform/mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Copied from platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt.
* platform/mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.png: Copied from platform/mac/fast/text/international/bidi-CS-after-AN-expected.png.
* platform/mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.txt: Copied from platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt.
* platform/mac-snowleopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Copied from platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png.
* platform/mac-snowleopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Copied from platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt.
* platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Copied from platform/mac/fast/text/international/bidi-neutral-run-expected.png.
* platform/mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Copied from platform/mac/fast/text/international/bidi-neutral-run-expected.txt.
* platform/mac-snowleopard/fast/text/international/bold-bengali-expected.png: Copied from platform/mac/fast/text/international/bold-bengali-expected.png.
* platform/mac-snowleopard/fast/text/international/bold-bengali-expected.txt: Copied from platform/mac/fast/text/international/bold-bengali-expected.txt.
* platform/mac-snowleopard/fast/text/international/khmer-selection-expected.png: Copied from platform/mac/fast/text/international/khmer-selection-expected.png.
* platform/mac-snowleopard/fast/text/international/khmer-selection-expected.txt: Copied from platform/mac/fast/text/international/khmer-selection-expected.txt.
* platform/mac/fast/text/capitalize-boundaries-expected.png:
* platform/mac/fast/text/capitalize-boundaries-expected.txt:
* platform/mac/fast/text/complex-text-opacity-expected.png:
* platform/mac/fast/text/complex-text-opacity-expected.txt:
* platform/mac/fast/text/hyphenate-locale-expected.txt:
* platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
* platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-run-expected.png:
* platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
* platform/mac/fast/text/international/bold-bengali-expected.png:
* platform/mac/fast/text/international/bold-bengali-expected.txt:
* platform/mac/fast/text/international/khmer-selection-expected.png:
* platform/mac/fast/text/international/khmer-selection-expected.txt:
* platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png:
* platform/mac/fast/text/justify-ideograph-leading-expansion-expected.txt:
* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd two fast/text tests to the skipped list.
andersca@apple.com [Fri, 5 Aug 2011 19:41:36 +0000 (19:41 +0000)]
Add two fast/text tests to the skipped list.

* platform/mac-lion/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd Lion specific test results for css1 and css2.1.
andersca@apple.com [Fri, 5 Aug 2011 19:24:07 +0000 (19:24 +0000)]
Add Lion specific test results for css1 and css2.1.

* platform/mac-snowleopard/css1: Added.
* platform/mac-snowleopard/css1/font_properties: Added.
* platform/mac-snowleopard/css1/font_properties/font-expected.png: Copied from platform/mac/css1/font_properties/font-expected.png.
* platform/mac-snowleopard/css1/font_properties/font-expected.txt: Copied from platform/mac/css1/font_properties/font-expected.txt.
* platform/mac-snowleopard/css2.1: Added.
* platform/mac-snowleopard/css2.1/t1202-counter-09-b-expected.png: Copied from platform/mac/css2.1/t1202-counter-09-b-expected.png.
* platform/mac-snowleopard/css2.1/t1202-counter-09-b-expected.txt: Copied from platform/mac/css2.1/t1202-counter-09-b-expected.txt.
* platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.png: Copied from platform/mac/css2.1/t1202-counters-09-b-expected.png.
* platform/mac-snowleopard/css2.1/t1202-counters-09-b-expected.txt: Copied from platform/mac/css2.1/t1202-counters-09-b-expected.txt.
* platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.png: Copied from platform/mac/css2.1/t1508-c527-font-05-b-expected.png.
* platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.txt: Copied from platform/mac/css2.1/t1508-c527-font-05-b-expected.txt.
* platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.png: Copied from platform/mac/css2.1/t1508-c527-font-10-c-expected.png.
* platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.txt: Copied from platform/mac/css2.1/t1508-c527-font-10-c-expected.txt.
* platform/mac/css1/font_properties/font-expected.png:
* platform/mac/css1/font_properties/font-expected.txt:
* platform/mac/css2.1/t1202-counter-09-b-expected.png:
* platform/mac/css2.1/t1202-counter-09-b-expected.txt:
* platform/mac/css2.1/t1202-counters-09-b-expected.png:
* platform/mac/css2.1/t1202-counters-09-b-expected.txt:
* platform/mac/css2.1/t1508-c527-font-05-b-expected.png:
* platform/mac/css2.1/t1508-c527-font-05-b-expected.txt:
* platform/mac/css2.1/t1508-c527-font-10-c-expected.png:
* platform/mac/css2.1/t1508-c527-font-10-c-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
abarth@webkit.org [Fri, 5 Aug 2011 18:50:37 +0000 (18:50 +0000)]
Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
https://bugs.webkit.org/show_bug.cgi?id=65759

Reviewed by Dimitri Glazkov.

rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
architecture, is poorly tested, and has a bunch of quirks.  This patch
rebuilds the core functionality of rebaseline-chromium-webkit-tests on
top of more modern infrastructure.  In the process, we get more code
re-use and better testing.

Once we're satisfied with this new implementation, we can delete the
old implementation.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
* Scripts/webkitpy/common/net/web.py:
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/tool/commands/rebaseline.py:
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove PluginHalter
andersca@apple.com [Fri, 5 Aug 2011 18:44:45 +0000 (18:44 +0000)]
Remove PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=65729

Reviewed by Darin Adler.

Source/WebCore:

Remove plug-in halter and associated classes.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.exp.in:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/EmptyClients.h:
* page/HaltablePlugin.h: Removed.
* page/Page.cpp:
(WebCore::Page::Page):
* page/Page.h:
* page/PluginHalter.cpp: Removed.
* page/PluginHalter.h: Removed.
* page/PluginHalterClient.h: Removed.
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::PluginView::stop):
(WebCore::PluginView::PluginView):
* plugins/PluginView.h:
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
* rendering/RenderWidget.h:

Source/WebKit:

Remove deleted files from Xcode project.

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Remove plug-in halter and associated classes.

* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView stop]):
* WebCoreSupport/WebPluginHalterClient.h: Removed.
* WebCoreSupport/WebPluginHalterClient.mm: Removed.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _preferencesChanged:]):
* WebView/WebViewPrivate.h:

Source/WebKit/win:

Remove plug-in halter and associated classes.

* Interfaces/IWebPluginHalterDelegate.idl: Removed.
* Interfaces/IWebPreferencesPrivate.idl:
* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:
* WebCoreSupport/WebPluginHalterClient.cpp: Removed.
* WebCoreSupport/WebPluginHalterClient.h: Removed.
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
* WebPreferences.h:
* WebView.cpp:
(WebView::close):
(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):
(WebView::unused1):
(WebView::unused2):
(WebView::unused3):
(WebView::unused4):
(WebView::unused5):
* WebView.h:

Source/WebKit/wx:

Don't include PluginHalterClient.h, it's been removed.

* WebView.cpp:

Tools:

Remove call to set the allowed plug-in run time.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Anders Carlsson.
darin@apple.com [Fri, 5 Aug 2011 18:23:27 +0000 (18:23 +0000)]
Reviewed by Anders Carlsson.

[WebKit2] Fix code paths that can leave frame view paint behavior in the wrong state
https://bugs.webkit.org/show_bug.cgi?id=63779

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent): Unrelated cleanup. Removed unneeded local variable.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotInViewCoordinates): Rearranged code so that the call to
setPaintBehavior is after the early exit. Also got rid of unneeded save/restore since
the function uses a graphics context that it then throws away.
(WebKit::WebPage::scaledSnapshotInDocumentCoordinates): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, skip those tests still failing on chromium due to incomplete
jianli@chromium.org [Fri, 5 Aug 2011 18:04:29 +0000 (18:04 +0000)]
Unreviewed, skip those tests still failing on chromium due to incomplete
baseline caused by r92466.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoIntroduce a new ResourceRequest::TargetType for XHRs
jochen@chromium.org [Fri, 5 Aug 2011 18:02:07 +0000 (18:02 +0000)]
Introduce a new ResourceRequest::TargetType for XHRs
https://bugs.webkit.org/show_bug.cgi?id=65544

Reviewed by Darin Fisher.

Source/WebCore:

* platform/network/chromium/ResourceRequest.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

* public/WebURLRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION(r92433): media/video-src-change.html fails
rniwa@webkit.org [Fri, 5 Aug 2011 17:13:00 +0000 (17:13 +0000)]
REGRESSION(r92433): media/video-src-change.html fails
https://bugs.webkit.org/show_bug.cgi?id=65771

Reviewed by Dimitri Glazkov.

Give the listener as the second argument to removeEventListener.

* media/video-src-change.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agocompositing/video/video-background-color.html test does not produce correct output
rniwa@webkit.org [Fri, 5 Aug 2011 16:56:48 +0000 (16:56 +0000)]
compositing/video/video-background-color.html test does not produce correct output
https://bugs.webkit.org/show_bug.cgi?id=55519

Unreviewed.

Chromium doesn't support video codecs that support alpha, so stop
running (and failing) a test that depends on codecs supporting alpha.

Patch by Ami Fischman <fischman@chromium.org> on 2011-08-05

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed build fix for Qt-Minimal buildbot
ademar.reis@openbossa.org [Fri, 5 Aug 2011 15:40:10 +0000 (15:40 +0000)]
Unreviewed build fix for Qt-Minimal buildbot

Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
is disabled.

Rubber-stamped by Holger Freyther.

* QtTestBrowser/cookiejar.cpp:
(TestBrowserCookieJar::TestBrowserCookieJar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agodir=auto needs to work on value of input and textarea elements
yael.aharon@nokia.com [Fri, 5 Aug 2011 14:36:33 +0000 (14:36 +0000)]
dir=auto needs to work on value of input and textarea elements
https://bugs.webkit.org/show_bug.cgi?id=65428

Reviewed by Darin Adler.

Source/WebCore:

Changed the directionality algorithm to evaluate the value of input elements and textarea elements when
they have the attribute dir-auto Set.
Also skip these elements when evaluating the directionality of their ancestors.

HTMLTextAreaElement::childrenChanged is not called when a user types into the textarea, so call
calculateAndAdjustDirectionality() explicitly from HTMLTextAreaElement::subtreeHasChanged().

HTMLInputElement::childrenChanged is not called when a user types into the textarea, so call
calculateAndAdjustDirectionality() explicitly from HTMLTextAreaElement::subtreeHasChanged().

Tests: fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control.html
       fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html
       fast/dom/HTMLElement/attr-dir-auto-text-form-control.html

* html/HTMLElement.cpp:
(WebCore::HTMLElement::directionality):
* html/HTMLElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::subtreeHasChanged):

LayoutTests:

* fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control-expected.txt: Added.
* fast/dom/HTMLElement/attr-dir-auto-changed-text-form-control.html: Added.
* fast/dom/HTMLElement/attr-dir-auto-text-form-control-child-expected.txt: Added.
* fast/dom/HTMLElement/attr-dir-auto-text-form-control-child.html: Added.
* fast/dom/HTMLElement/attr-dir-auto-text-form-control-expected.txt: Added.
* fast/dom/HTMLElement/attr-dir-auto-text-form-control.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPatch by Dawit Alemayehu <adawit@kde.org> on 2011-08-05
commit-queue@webkit.org [Fri, 5 Aug 2011 14:17:23 +0000 (14:17 +0000)]
Patch by Dawit Alemayehu <adawit@kde.org> on 2011-08-05
Reviewed by Andreas Kling.

Reverted commit r87797, http://trac.webkit.org/changeset/87797, because it
causes the regression reported under bug# 63582.

[Qt] REGRESSION(r87797): Broke KDEWebKit's custom QNAM.
https://bugs.webkit.org/show_bug.cgi?id=63582

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::setFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] QtTestBrowser: Add support for saving cookies on disk
ademar.reis@openbossa.org [Fri, 5 Aug 2011 14:03:41 +0000 (14:03 +0000)]
[Qt] QtTestBrowser: Add support for saving cookies on disk
https://bugs.webkit.org/show_bug.cgi?id=65328

Simple cookiejar that saves cookies on disk.

Added menu options to clear cookies (Edit->Clear cookies) and
disable disk cookies (Settings->[ ]Save Cookies on Disk).

Option -no-disk-cookies is also available.

Reviewed by Andreas Kling.

* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/cookiejar.cpp: Added.
* QtTestBrowser/cookiejar.h: Added.
* QtTestBrowser/launcherwindow.cpp:
* QtTestBrowser/launcherwindow.h:
* QtTestBrowser/main.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImplement <input type=color> UI behavior WebCore part
keishi@webkit.org [Fri, 5 Aug 2011 13:45:21 +0000 (13:45 +0000)]
Implement <input type=color> UI behavior WebCore part
https://bugs.webkit.org/show_bug.cgi?id=62619

Reviewed by Kent Tamura.

* WebCore.exp.in: Added __ZN7WebCore12ColorChooser7chooserEv and
__ZNK7WebCore12ColorChooser13colorSelectedERKNS_5ColorE
* WebCore.xcodeproj/project.pbxproj: Added ColorChooser.{h,cpp}
* html/ColorInputType.cpp:
(WebCore::ColorInputType::~ColorInputType): Added. Close color chooser. ex. when type attribute changes.
(WebCore::ColorInputType::valueAsColor): Added.
(WebCore::ColorInputType::setValueAsColor): Added.
(WebCore::ColorInputType::valueChanged): Update selected color in color chooser too.
(WebCore::ColorInputType::handleClickEvent): Opens color chooser.
(WebCore::ColorInputType::handleDOMActivateEvent): Called when element.click(). Open color chooser only
when it was initiated by a user interaction.
(WebCore::ColorInputType::detach): Close color chooser. Called when input element or its ancestors have "display:none"
or is removed from DOM.
(WebCore::ColorInputType::colorSelected): Callback from color chooser.
(WebCore::ColorInputType::closeColorChooserIfClientIsInDocument): Close color chooser if element is in
document. Called when the page navigates away.
(WebCore::ColorInputType::closeColorChooserIfCurrentClient): Close color chooser if this input type is the current client of ColorChooser.
* html/ColorInputType.h:
* html/FileInputType.cpp:
* html/FileInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::detach): Calls InputType::detach
* html/InputType.cpp:
(WebCore::InputType::chrome): Added. Used in FileInputType and ColorInputType.
(WebCore::InputType::detach): ColorInputType overrides this.
* html/InputType.h:
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::openColorChooser): Added.
(WebCore::EmptyChromeClient::closeColorChooser): Added.
(WebCore::EmptyChromeClient::setSelectedColorInColorChooser): Added.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted): Close color chooser when
navigating away from the page.
* page/Chrome.cpp:
(WebCore::Chrome::openColorChooser): Added. Opens the color chooser.
(WebCore::Chrome::closeColorChooser): Added. Tries to close the color chooser. Might not close if the
listener of the color chooser is another part of the browser or another render process.
(WebCore::Chrome::setSelectedColorInColorChooser): Added. Sets the selected color in the color chooser.
Again, might not be executed if the listener of the color chooser is another part of the browser or another render process.
* page/Chrome.h:
* page/ChromeClient.h:
* platform/ColorChooser.cpp: Added.
(WebCore::ColorChooserClient::~ColorChooserClient): Disconnects itself from the ColorChooser.
(WebCore::ColorChooser::chooser): Get shared instance of ColorChooser.
(WebCore::ColorChooser::chooser): Get shared instance of ColorChooser.
(WebCore::ColorChooser::connectClient): Connects a ColorChooserClient that receives the colorSelected callbacks.
(WebCore::ColorChooser::disconnectClient): Disconnects the connectClient.
(WebCore::ColorChooser::closeColorChooserIfClientIsInDocument): Close the color chooser if the client is
inside the document.
(WebCore::ColorChooser::colorSelected): Called from color chooser listener.
* platform/ColorChooser.h: Added.
(WebCore::ColorChooser::client): Added. Returns the current connected client.
(WebCore::ColorChooser::ColorChooser): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWeb Inspector: check that detaching frame has been attached before removing it from...
yurys@chromium.org [Fri, 5 Aug 2011 13:16:14 +0000 (13:16 +0000)]
Web Inspector: check that detaching frame has been attached before removing it from the console selector
https://bugs.webkit.org/show_bug.cgi?id=65686

Reviewed by Pavel Feldman.

* inspector/front-end/JavaScriptContextManager.js:
(WebInspector.JavaScriptContextManager.prototype._frameDetached):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSort WebCore.xcodeproj
keishi@webkit.org [Fri, 5 Aug 2011 12:18:19 +0000 (12:18 +0000)]
Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt]Web Inspector: REGRESSION(r91928): It made 2 tests fail
vsevik@chromium.org [Fri, 5 Aug 2011 11:39:24 +0000 (11:39 +0000)]
[Qt]Web Inspector: REGRESSION(r91928): It made 2 tests fail
https://bugs.webkit.org/show_bug.cgi?id=65364

Unreviewed: unskipping tests now that the test was fixed.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[EFL] Move API documentation of ewk files to the headers
commit-queue@webkit.org [Fri, 5 Aug 2011 10:16:57 +0000 (10:16 +0000)]
[EFL] Move API documentation of ewk files to the headers
https://bugs.webkit.org/show_bug.cgi?id=65373

There are two arguments for this:
1. Developers using webkit-efl from packages probably won't have the C/CPP files with them
   and the doxygen documentation can be generated from the headers without the need
   for the whole source files.
2. It will be consistent with structures descriptions.

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-05
Reviewed by Kent Tamura.

* ewk/ewk_auth.cpp:
* ewk/ewk_auth.h:
* ewk/ewk_contextmenu.cpp:
* ewk/ewk_contextmenu.h:
* ewk/ewk_cookies.cpp:
* ewk/ewk_cookies.h:
* ewk/ewk_frame.cpp:
* ewk/ewk_frame.h:
* ewk/ewk_history.cpp:
* ewk/ewk_history.h:
* ewk/ewk_main.cpp:
* ewk/ewk_main.h:
* ewk/ewk_network.cpp:
* ewk/ewk_network.h:
* ewk/ewk_settings.cpp:
* ewk/ewk_settings.h:
* ewk/ewk_window_features.cpp:
* ewk/ewk_window_features.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Skip 2 crashy tests on Qt SnowLeopard Intel Release bot to make a green world,
zoltan@webkit.org [Fri, 5 Aug 2011 09:40:36 +0000 (09:40 +0000)]
[Qt] Skip 2 crashy tests on Qt SnowLeopard Intel Release bot to make a green world,

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWeb Inspector: constrain maximum depth for returnByValue objects
yurys@chromium.org [Fri, 5 Aug 2011 09:37:02 +0000 (09:37 +0000)]
Web Inspector: constrain maximum depth for returnByValue objects
https://bugs.webkit.org/show_bug.cgi?id=65761

Source/WebCore:

Set maximum depth to 20 for objects returned by value as a result of evaluations.

Reviewed by Pavel Feldman.

* bindings/js/ScriptValue.cpp:
(WebCore::jsToInspectorValue):
(WebCore::ScriptValue::toInspectorValue):
* bindings/v8/ScriptValue.cpp:
(WebCore::v8ToInspectorValue):
(WebCore::ScriptValue::toInspectorValue):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::makeCall):
* inspector/InspectorValues.h:

LayoutTests:

Reviewed by Pavel Feldman.

* inspector/protocol/runtime-agent-expected.txt:
* inspector/protocol/runtime-agent.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Add http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
zoltan@webkit.org [Fri, 5 Aug 2011 09:30:58 +0000 (09:30 +0000)]
[Qt] Add http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
to Skiplist because it makes ARMv5 Linux Qt Release weepy.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove LegacyDefaultOptionalArguments flag from appcache IDL files
commit-queue@webkit.org [Fri, 5 Aug 2011 08:57:55 +0000 (08:57 +0000)]
Remove LegacyDefaultOptionalArguments flag from appcache IDL files
https://bugs.webkit.org/show_bug.cgi?id=65752

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* loader/appcache/DOMApplicationCache.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoIndexedDB: Stop using free-lists for database/object store/index ids.
hans@chromium.org [Fri, 5 Aug 2011 08:42:56 +0000 (08:42 +0000)]
IndexedDB: Stop using free-lists for database/object store/index ids.
https://bugs.webkit.org/show_bug.cgi?id=65678

Reviewed by Tony Chang.

Don't use free-lists for database/object store/index ids,
just assign increasing numbers.

It turns out that deleting an object store and creating a new one with
the same id would cause the delete markers from the old object store to
slow down lookups into the new one. Therefore we should generate
a new id every time. Running out of ids (64 bits for databases and
object stores, 32 bits for indices) is not realistic.

Also make functions that generate new ids report errors, and make the
callers of those functions check the return values.

We must still delete free-lists when deleting an object store, and we
must keep the code for encoding/decoding/comparison of free-list keys
since users might have them in their databases.

This is just a performance optimization, so no new tests.

* storage/IDBLevelDBBackingStore.cpp:
(WebCore::getNewDatabaseId):
(WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
(WebCore::getNewObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::getNewIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Ossyize fast/forms/enter-clicks-buttons.html because
zoltan@webkit.org [Fri, 5 Aug 2011 08:37:46 +0000 (08:37 +0000)]
[Qt] Ossyize fast/forms/enter-clicks-buttons.html because
it makes Qt SnowLeopard Intel Release bot bleeding after r92375.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Rebaseline following r92255.
commit-queue@webkit.org [Fri, 5 Aug 2011 08:33:51 +0000 (08:33 +0000)]
[chromium] Rebaseline following r92255.
https://bugs.webkit.org/show_bug.cgi?id=65736

Patch by David Reveman <reveman@chromium.org> on 2011-08-05
Reviewed by James Robinson.

* platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
* platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transition-expected.png:
* platform/chromium-gpu-linux/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-gpu-linux/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-gpu-linux/media/video-transformed-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/tiny-layer-rotated-expected.png:
* platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-gpu-mac/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/ancestor-overflow-change-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-gpu-mac/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
* platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transition-expected.png:
* platform/chromium-gpu-mac/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-gpu-mac/media/video-transformed-expected.png:
* platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/backface-visibility-transformed-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/tiny-layer-rotated-expected.png:
* platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
* platform/chromium-gpu-win/compositing/geometry/ancestor-overflow-change-expected.png:
* platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
* platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png:
* platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
* platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png:
* platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-gpu-win/media/video-transformed-expected.png:
* platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/backface-visibility-transformed-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/tiny-layer-rotated-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLayout Test fast/xsl/xslt-import-depth.xml is failing
hamaji@chromium.org [Fri, 5 Aug 2011 08:28:52 +0000 (08:28 +0000)]
Layout Test fast/xsl/xslt-import-depth.xml is failing
https://bugs.webkit.org/show_bug.cgi?id=65758

Chromium test_expectations.txt update

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLayout Test fast/xsl/import-after-comment.xml is failing
hamaji@chromium.org [Fri, 5 Aug 2011 08:24:59 +0000 (08:24 +0000)]
Layout Test fast/xsl/import-after-comment.xml is failing
https://bugs.webkit.org/show_bug.cgi?id=65757

Chromium test_expectations.txt update

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed: change an instance of isImportRule() that was overlooked in commit 92448.
rolandsteiner@chromium.org [Fri, 5 Aug 2011 08:21:47 +0000 (08:21 +0000)]
Unreviewed: change an instance of isImportRule() that was overlooked in commit 92448.

No new tests. (No functional change)

* xml/XSLImportRule.h:
(WebCore::XSLImportRule::isImportRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove LegacyDefaultOptionalArguments flag from remaining SVG IDL files
commit-queue@webkit.org [Fri, 5 Aug 2011 08:19:03 +0000 (08:19 +0000)]
Remove LegacyDefaultOptionalArguments flag from remaining SVG IDL files
https://bugs.webkit.org/show_bug.cgi?id=65751

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* svg/SVGElementInstance.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWeb Inspector: do not delay scroll event handling - scroll is already async.
commit-queue@webkit.org [Fri, 5 Aug 2011 07:51:18 +0000 (07:51 +0000)]
Web Inspector: do not delay scroll event handling - scroll is already async.
https://bugs.webkit.org/show_bug.cgi?id=65693

Patch by Pavel Feldman <pfeldman@google.com> on 2011-08-05
Reviewed by Yury Semikhatsky.

* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._syncScroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLayout Test fast/loader/ping-error.html is failing
hamaji@chromium.org [Fri, 5 Aug 2011 07:48:48 +0000 (07:48 +0000)]
Layout Test fast/loader/ping-error.html is failing
https://bugs.webkit.org/show_bug.cgi?id=65754

Chromium test_expectations.txt update

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove LegacyDefaultOptionalArguments flag from web audio API
commit-queue@webkit.org [Fri, 5 Aug 2011 07:45:19 +0000 (07:45 +0000)]
Remove LegacyDefaultOptionalArguments flag from web audio API
https://bugs.webkit.org/show_bug.cgi?id=65750

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* webaudio/AudioBufferSourceNode.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove LegacyDefaultOptionalArguments flag from Web Workers
commit-queue@webkit.org [Fri, 5 Aug 2011 07:43:54 +0000 (07:43 +0000)]
Remove LegacyDefaultOptionalArguments flag from Web Workers
https://bugs.webkit.org/show_bug.cgi?id=65746

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* workers/AbstractWorker.idl:
* workers/DedicatedWorkerContext.idl:
* workers/Worker.idl:
* workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoParsing CSS3 font-feature-settings property
bashi@chromium.org [Fri, 5 Aug 2011 07:34:58 +0000 (07:34 +0000)]
Parsing CSS3 font-feature-settings property
https://bugs.webkit.org/show_bug.cgi?id=63618

Source/WebCore:

Introduces CSS3 font-feature-settings property as -webkit-font-feature-settings.  This change only contains parsing part.  Parsed information are stored in FontDescription class.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-05
Reviewed by Shinichiro Hamaji.

Test: css3/font-feature-settings-parsing.html

* CMakeLists.txt: Added FontFeatureValue.{h,cpp} and FontFeatureSettings.{h,cpp}.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added CSSPropertyWebkitFontFeatureSettings.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Added parsing code for -webkit-font-feature-settings.
(WebCore::CSSParser::parseFontFeatureTag): Added.
(WebCore::CSSParser::parseFontFeatureSettings): Added.
* css/CSSParser.h: Added parseFontFeatureSettings().
* css/CSSPropertyNames.in: Added -webkit-font-feature-settings.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyDeclarations): Modified a compile assert to follow adding -webkit-font-feature-settings.
(WebCore::CSSStyleSelector::applyProperty): Added a case clause for CSSPropertyWebkitFontFeatureSettings.
* css/CSSValue.h:
(WebCore::CSSValue::isFontFeatureValue): Added.
* css/CSSValueKeywords.in: Added 'on' and 'off' keywords.
* css/FontFeatureValue.cpp: Added.
(WebCore::FontFeatureValue::FontFeatureValue):
(WebCore::FontFeatureValue::value):
(WebCore::FontFeatureValue::cssText):
* css/FontFeatureValue.h: Added.
(WebCore::FontFeatureValue::create):
(WebCore::FontFeatureValue::tag):
(WebCore::FontFeatureValue::isFontFeatureValue):
* platform/graphics/FontDescription.cpp:
(WebCore::FontDescription::makeNormalFeatureSettings): Added.
* platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription): Added m_featureSettings member variable.
(WebCore::FontDescription::featureSettings): Added.
(WebCore::FontDescription::setFeatureSettings): Added.
(WebCore::FontDescription::operator==): Modified to take into account m_featureSettings
* platform/graphics/FontFeatureSettings.cpp: Added.
(WebCore::FontFeature::FontFeature):
(WebCore::FontFeature::operator=):
(WebCore::FontFeature::operator==):
(WebCore::FontFeatureSettings::FontFeatureSettings):
* platform/graphics/FontFeatureSettings.h: Added.
(WebCore::FontFeature::tag):
(WebCore::FontFeature::value):
(WebCore::FontFeatureSettings::create):
(WebCore::FontFeatureSettings::append):
(WebCore::FontFeatureSettings::size):
(WebCore::FontFeatureSettings::operator[]):
(WebCore::FontFeatureSettings::at):

LayoutTests:

Add parsing test case for -webkit-font-feature-settings property.

Patch by Kenichi Ishibashi <bashi@chromium.org> on 2011-08-05
Reviewed by Shinichiro Hamaji.

* css3/font-feature-settings-parsing-expected.txt: Added.
* css3/font-feature-settings-parsing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove LegacyDefaultOptionalArguments flag from websockets
commit-queue@webkit.org [Fri, 5 Aug 2011 07:32:14 +0000 (07:32 +0000)]
Remove LegacyDefaultOptionalArguments flag from websockets
https://bugs.webkit.org/show_bug.cgi?id=65749

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* websockets/WebSocket.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAttempt to heal media/video-can-play-type.html and media/video-src-change.html.
abarth@webkit.org [Fri, 5 Aug 2011 07:30:29 +0000 (07:30 +0000)]
Attempt to heal media/video-can-play-type.html and media/video-src-change.html.

* html/HTMLMediaElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove LegacyDefaultOptionalArguments flag from notifications IDL files
commit-queue@webkit.org [Fri, 5 Aug 2011 07:18:23 +0000 (07:18 +0000)]
Remove LegacyDefaultOptionalArguments flag from notifications IDL files
https://bugs.webkit.org/show_bug.cgi?id=65747

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-05
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* notifications/Notification.idl:
* notifications/NotificationCenter.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, rolling out r92439.
commit-queue@webkit.org [Fri, 5 Aug 2011 07:00:47 +0000 (07:00 +0000)]
Unreviewed, rolling out r92439.
http://trac.webkit.org/changeset/92439
https://bugs.webkit.org/show_bug.cgi?id=65753

Caused 9 tests to fail on Qt (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-05

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::implicitOpen):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::detachChildren):

LayoutTests:

* loader/document-destruction-within-unload-expected.txt: Removed.
* loader/document-destruction-within-unload.html: Removed.
* loader/resources/document-destruction-within-unload-iframe.html: Removed.
* loader/resources/document-destruction-within-unload.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChromium test expectation update after r92341.
rniwa@webkit.org [Fri, 5 Aug 2011 06:58:13 +0000 (06:58 +0000)]
Chromium test expectation update after r92341.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUse RenderedPosition instead of getInlineBoxAndOffset in Editor and AccessibilityObject
rniwa@webkit.org [Fri, 5 Aug 2011 06:26:20 +0000 (06:26 +0000)]
Use RenderedPosition instead of getInlineBoxAndOffset in Editor and AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=65647

Reviewed by Hajime Morita.

Encapsulated the use of getInlineBoxAndOffset in Editor.cpp and AccessibilityObject.cpp by RenderedPosition.

Also added rendererFromPosition that returns the renderer of deprecatedNode but using a proper Position interface.

* accessibility/AccessibilityObject.cpp:
(WebCore::updateAXLineStartForVisiblePosition):
* editing/Editor.cpp:
(WebCore::Editor::firstRectForRange):
* editing/RenderedPosition.cpp:
(WebCore::rendererFromPosition):
(WebCore::RenderedPosition::RenderedPosition):
(WebCore::RenderedPosition::absoluteRect):
* editing/RenderedPosition.h:
(WebCore::RenderedPosition::absoluteRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake ScopedEventQueue enqueue an EventDispatchMediator, instead of an Event.
hayato@chromium.org [Fri, 5 Aug 2011 06:14:11 +0000 (06:14 +0000)]
Make ScopedEventQueue enqueue an EventDispatchMediator, instead of an Event.
https://bugs.webkit.org/show_bug.cgi?id=65613

Reviewed by Dimitri Glazkov.

No changes to functionality so no new tests.

* dom/Event.h:
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchScopedEvent):
* dom/EventDispatcher.h:
* dom/Node.cpp:
(WebCore::Node::dispatchScopedEvent):
(WebCore::Node::dispatchScopedEventDispatchMediator):
* dom/Node.h:
* dom/ScopedEventQueue.cpp:
(WebCore::ScopedEventQueue::~ScopedEventQueue):
(WebCore::ScopedEventQueue::enqueueEventDispatchMediator):
(WebCore::ScopedEventQueue::dispatchAllEvents):
(WebCore::ScopedEventQueue::dispatchEvent):
* dom/ScopedEventQueue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed build fix. gcc 4.5 can't figure out that the 'data' variables are always...
jamesr@google.com [Fri, 5 Aug 2011 06:05:51 +0000 (06:05 +0000)]
Unreviewed build fix.  gcc 4.5 can't figure out that the 'data' variables are always initialized in these functions.

* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::jsArrayToFloatArray):
(WebCore::jsArrayToIntArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImprove const-correctness in CSS code: type information methods
rolandsteiner@chromium.org [Fri, 5 Aug 2011 06:04:52 +0000 (06:04 +0000)]
Improve const-correctness in CSS code: type information methods
https://bugs.webkit.org/show_bug.cgi?id=65506

Reviewed by Simon Fraser.

Make "is...()" functions (e.g., "isStyleRule()") const.
Also, change CSSRule's type() function to return CSSRuleType.

No new tests. (no change in semantics)

* css/CSSCharsetRule.h:
(WebCore::CSSCharsetRule::isCharsetRule):
(WebCore::CSSCharsetRule::type):
* css/CSSFontFaceRule.h:
(WebCore::CSSFontFaceRule::isFontFaceRule):
(WebCore::CSSFontFaceRule::type):
* css/CSSImportRule.h:
(WebCore::CSSImportRule::isImportRule):
(WebCore::CSSImportRule::type):
* css/CSSMediaRule.h:
(WebCore::CSSMediaRule::isMediaRule):
(WebCore::CSSMediaRule::type):
* css/CSSPageRule.h:
(WebCore::CSSPageRule::isPageRule):
(WebCore::CSSPageRule::type):
* css/CSSRule.h:
(WebCore::CSSRule::isRule):
* css/CSSStyleRule.h:
(WebCore::CSSStyleRule::isStyleRule):
(WebCore::CSSStyleRule::type):
* css/CSSUnknownRule.h:
(WebCore::CSSUnknownRule::type):
* css/StyleBase.h:
(WebCore::StyleBase::isCharsetRule):
(WebCore::StyleBase::isFontFaceRule):
(WebCore::StyleBase::isImportRule):
(WebCore::StyleBase::isKeyframeRule):
(WebCore::StyleBase::isKeyframesRule):
(WebCore::StyleBase::isMediaRule):
(WebCore::StyleBase::isPageRule):
(WebCore::StyleBase::isRule):
(WebCore::StyleBase::isStyleRule):
* css/WebKitCSSKeyframeRule.h:
(WebCore::WebKitCSSKeyframeRule::isKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::type):
* css/WebKitCSSKeyframesRule.h:
(WebCore::WebKitCSSKeyframesRule::isKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove LegacyDefaultOptionalArguments flag from plugin IDL files
commit-queue@webkit.org [Fri, 5 Aug 2011 05:42:19 +0000 (05:42 +0000)]
Remove LegacyDefaultOptionalArguments flag from plugin IDL files
https://bugs.webkit.org/show_bug.cgi?id=65745

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove LegacyDefaultOptionalArguments flag from XML/XSL IDL files
commit-queue@webkit.org [Fri, 5 Aug 2011 05:37:24 +0000 (05:37 +0000)]
Remove LegacyDefaultOptionalArguments flag from XML/XSL IDL files
https://bugs.webkit.org/show_bug.cgi?id=65740

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* xml/DOMParser.idl:
* xml/XMLSerializer.idl:
* xml/XPathEvaluator.idl:
* xml/XPathExpression.idl:
* xml/XPathNSResolver.idl:
* xml/XPathResult.idl:
* xml/XSLTProcessor.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Fri, 5 Aug 2011 05:27:38 +0000 (05:27 +0000)]
Unreviewed.  Rolled DEPS.

Patch by James Robinson <jamesr@chromium.org> on 2011-08-04

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a performance test for floating elements layout algorithm
commit-queue@webkit.org [Fri, 5 Aug 2011 04:51:00 +0000 (04:51 +0000)]
Add a performance test for floating elements layout algorithm
https://bugs.webkit.org/show_bug.cgi?id=65741

The test creating lots of small floats and randomly changes
the width of one element at a time. It measures how often it can do that.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-04
Reviewed by Adam Barth.

* Layout/floats.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove LegacyDefaultOptionalArguments flag from canvas IDL files
commit-queue@webkit.org [Fri, 5 Aug 2011 03:50:17 +0000 (03:50 +0000)]
Remove LegacyDefaultOptionalArguments flag from canvas IDL files
https://bugs.webkit.org/show_bug.cgi?id=65737

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* html/canvas/CanvasGradient.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agomodel.js needs some unit testing
abarth@webkit.org [Fri, 5 Aug 2011 03:26:02 +0000 (03:26 +0000)]
model.js needs some unit testing
https://bugs.webkit.org/show_bug.cgi?id=65730

Reviewed by Dimitri Glazkov.

These tests do not cover all the functions exported by the model
module.  We'll need to add the remaining ones in the future.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Ryosuke Niwa.
morrita@google.com [Fri, 5 Aug 2011 03:25:53 +0000 (03:25 +0000)]
Reviewed by Ryosuke Niwa.

DocumentMarker: Type specific details should be separately held by other object.
https://bugs.webkit.org/show_bug.cgi?id=59855

- Introduced DocumentMarkerDetails abstract class and two its subclasses
  DocumentMarkerDescription and DocumentMarkerActiveMatch,

- Replacing DocumentMarker::m_description and
  DocumentMarker::m_activeMatch with these new details classes.

No new tests. No behavior change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/DocumentMarker.cpp: Added.
(WebCore::emptyDescription):
(WebCore::DocumentMarkerDetails::DocumentMarkerDetails):
(WebCore::DocumentMarkerDetails::~DocumentMarkerDetails):
(WebCore::DocumentMarkerDescription::description):
(WebCore::DocumentMarkerDescription::isDescription):
(WebCore::DocumentMarkerDescription::DocumentMarkerDescription):
(WebCore::DocumentMarkerDescription::createUnlessEmpty):
(WebCore::DocumentMarkerDescription::compatibleTypes):
(WebCore::DocumentMarkerTextMatch::activeMatch):
(WebCore::DocumentMarkerTextMatch::isTextMatch):
(WebCore::DocumentMarkerTextMatch::DocumentMarkerTextMatch):
(WebCore::DocumentMarkerTextMatch::instanceFor):
(WebCore::DocumentMarkerTextMatch::compatibleTypes):
(WebCore::DocumentMarker::DocumentMarker):
(WebCore::DocumentMarker::shiftOffsets):
(WebCore::DocumentMarker::setActiveMatch):
(WebCore::DocumentMarker::description):
(WebCore::DocumentMarker::activeMatch):
* dom/DocumentMarker.h:
(WebCore::DocumentMarker::details):
(WebCore::DocumentMarker::clearDetails):
(WebCore::DocumentMarkerDetails::isDescription):
(WebCore::DocumentMarkerDetails::isTextMatch):
(WebCore::DocumentMarkerDetails::isAllowedFor):
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAnother speculative fix for the "svn revision on Windows" problem.
abarth@webkit.org [Fri, 5 Aug 2011 01:45:39 +0000 (01:45 +0000)]
Another speculative fix for the "svn revision on Windows" problem.

* Scripts/webkitpy/common/checkout/scm/git.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBad interaction between document destruction and unload events
commit-queue@webkit.org [Fri, 5 Aug 2011 01:32:24 +0000 (01:32 +0000)]
Bad interaction between document destruction and unload events
https://bugs.webkit.org/show_bug.cgi?id=64741

Patch by Scott Graham <scottmg@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

Source/WebCore:

Three different errors triggered by this test case. The case to
consider is a subdocument with an onunload on an element, that
destroys the parent document during the onunload. One fix was a
lifetime issue fixed by a protecting RefPtr, and another was an
additional cancel of event triggers. The main fix was that during the
transition to commited state, the documentLoader is being replaced by
the provisionalDocumentLoader. But, because during firing events in
the subdocument the parent is destroyed, that subevent caused the
provisionalDocumentLoader to be detached from its frame. By marking
the page as being in committed state before the parent documentLoader
is set, this is avoided.

Test: loader/document-destruction-within-unload.html

* dom/Document.cpp:
(WebCore::Document::implicitOpen):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::detachChildren):

LayoutTests:

* loader/document-destruction-within-unload-expected.txt: Added.
* loader/document-destruction-within-unload.html: Added.
* loader/resources/document-destruction-within-unload-iframe.html: Added.
* loader/resources/document-destruction-within-unload.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-08-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 5 Aug 2011 01:07:04 +0000 (01:07 +0000)]
2011-08-04  Simon Fraser  <simon.fraser@apple.com>

        Add code to determine whether a Range in inside fixed position content
        https://bugs.webkit.org/show_bug.cgi?id=65720

        Reviewed by Sam Weinig.

        Propagate the 'wasFixed' flag out from various methods that
        are used when computing the collection of rects or quads
        for a range. Use the flag in Range to computer whether
        the Range is entirely within, partially within, or outside
        of fixed-position content.

        * WebCore.exp.in:
        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::boundingBoxRect):
        * dom/Range.cpp:
        (WebCore::Range::textRects):
        (WebCore::Range::textQuads):
        * dom/Range.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::absoluteQuads):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absoluteQuads):
        * rendering/RenderBox.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::absoluteQuads):
        * rendering/RenderInline.h:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::absoluteQuads):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::absoluteRectsForRange):
        (WebCore::RenderText::absoluteQuads):
        (WebCore::RenderText::absoluteQuadsForRange):
        * rendering/RenderText.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::absoluteQuads):
        * rendering/RenderView.h:
        * rendering/svg/RenderSVGHiddenContainer.cpp:
        (WebCore::RenderSVGHiddenContainer::absoluteQuads):
        * rendering/svg/RenderSVGHiddenContainer.h:
        * rendering/svg/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::absoluteQuads):
        * rendering/svg/RenderSVGInline.h:
        * rendering/svg/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::absoluteQuads):
        * rendering/svg/RenderSVGModelObject.h:
        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::absoluteQuads):
        * rendering/svg/RenderSVGText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCStringBuffer should have thread safety checks turned on.
levin@chromium.org [Fri, 5 Aug 2011 00:51:19 +0000 (00:51 +0000)]
CStringBuffer should have thread safety checks turned on.
https://bugs.webkit.org/show_bug.cgi?id=58093

Reviewed by Dmitry Titov.

Source/JavaScriptCore:

* wtf/text/CString.h:
(WTF::CStringBuffer::CStringBuffer): Removed the ifdef that
turned this off for Chromium.

Source/WebKit/chromium:

* DEPS: Roll far enough to pick up the latest WebKit::initialize
fix for Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove LegacyDefaultOptionalArguments flag from Document.idl
commit-queue@webkit.org [Fri, 5 Aug 2011 00:39:28 +0000 (00:39 +0000)]
Remove LegacyDefaultOptionalArguments flag from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=65717

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* dom/Document.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-08-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 5 Aug 2011 00:26:51 +0000 (00:26 +0000)]
2011-08-04  Simon Fraser  <simon.fraser@apple.com>

        Fix release build failure with last commit.

        * rendering/RenderView.cpp:
        (WebCore::RenderView::mapLocalToContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2011-08-04 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 5 Aug 2011 00:19:41 +0000 (00:19 +0000)]
2011-08-04  Simon Fraser  <simon.fraser@apple.com>

        Add code to determine whether a Range in inside fixed position content
        https://bugs.webkit.org/show_bug.cgi?id=65720

        Reviewed by Dan Bernstein.

        Add an out param for various coordinate mapping functions
        that tells us whether the point or rectangle being
        mapped is inside fixed-position content.

        This brings back some of the changes from r89754.

        No behavior changes, so no tests.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::mapLocalToContainer):
        * rendering/RenderBox.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::mapLocalToContainer):
        * rendering/RenderInline.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::mapLocalToContainer):
        (WebCore::RenderObject::localToContainerQuad):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::localToAbsoluteQuad):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::mapLocalToContainer):
        * rendering/RenderView.h:
        * rendering/svg/RenderSVGForeignObject.cpp:
        (WebCore::RenderSVGForeignObject::mapLocalToContainer):
        * rendering/svg/RenderSVGForeignObject.h:
        * rendering/svg/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::mapLocalToContainer):
        * rendering/svg/RenderSVGInline.h:
        * rendering/svg/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::mapLocalToContainer):
        * rendering/svg/RenderSVGModelObject.h:
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::mapLocalToContainer):
        * rendering/svg/RenderSVGRoot.h:
        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::mapLocalToContainer):
        * rendering/svg/RenderSVGText.h:
        * rendering/svg/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::mapLocalToContainer):
        * rendering/svg/SVGRenderSupport.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove LegacyDefaultOptionalArguments flag from DOM-related files except Document.idl
commit-queue@webkit.org [Fri, 5 Aug 2011 00:03:14 +0000 (00:03 +0000)]
Remove LegacyDefaultOptionalArguments flag from DOM-related files except Document.idl
https://bugs.webkit.org/show_bug.cgi?id=65715

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-08-04
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* dom/CharacterData.idl:
* dom/ClientRectList.idl:
* dom/Clipboard.idl:
* dom/DOMImplementation.idl:
* dom/DOMStringList.idl:
* dom/DataTransferItem.idl:
* dom/DataTransferItems.idl:
* dom/DocumentFragment.idl:
* dom/Element.idl:
* dom/EventListener.idl:
* dom/EventTarget.idl:
* dom/MediaStream.idl:
* dom/MediaStreamList.idl:
* dom/MediaStreamTrackList.idl:
* dom/MessagePort.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeFilter.idl:
* dom/NodeList.idl:
* dom/Range.idl:
* dom/RequestAnimationFrameCallback.idl:
* dom/StringCallback.idl:
* dom/Text.idl:
* dom/TouchList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFuture-proof Xcode configuration settings.
mrowe@apple.com [Thu, 4 Aug 2011 23:58:48 +0000 (23:58 +0000)]
Future-proof Xcode configuration settings.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/JavaScriptCore.xcconfig:
* Configurations/Version.xcconfig:

Source/JavaScriptGlue:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig:
* Configurations/DebugRelease.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebCore.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKit.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebKit2.xcconfig:

Tools:

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
* MiniBrowser/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/CompilerVersion.xcconfig:
* MiniBrowser/Configurations/DebugRelease.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
* TestWebKitAPI/Configurations/DebugRelease.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
* WebKitTestRunner/Configurations/DebugRelease.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoA few purely stylistic modifications to visible_units.cpp
commit-queue@webkit.org [Thu, 4 Aug 2011 23:56:24 +0000 (23:56 +0000)]
A few purely stylistic modifications to visible_units.cpp
https://bugs.webkit.org/show_bug.cgi?id=65723

Patch by Van Lam <vanlam@google.com> on 2011-08-04
Reviewed by Ryosuke Niwa.

Renamed greatestValueUnder to greatestOffsetUnder, positionIsInsideBox
to positionIsInBoxButNotOnBoundary (to avoid confusion with
positionIsInBox, which is just a getInlineBoxAndOffset check).
Removed use of invalidOffset as an error value in greatestOffsetUnder
and smallestOffsetAbove since semantically it should only be used to
check if it makes sense to compare offsets in a single box.

* editing/visible_units.cpp:
(WebCore::greatestOffsetUnder):
(WebCore::smallestOffsetAbove):
(WebCore::positionIsInBoxButNotOnBoundary):
(WebCore::leftWordPositionAcrossBoundary):
(WebCore::rightWordPositionAcrossBoundary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[chromium] Implement a global resource limit for DrawingBuffer to limit the amount...
commit-queue@webkit.org [Thu, 4 Aug 2011 23:46:59 +0000 (23:46 +0000)]
[chromium] Implement a global resource limit for DrawingBuffer to limit the amount of GPU memory used by 2d canvas backing stores
https://bugs.webkit.org/show_bug.cgi?id=65655

Patch by James Robinson <jamesr@chromium.org> on 2011-08-04
Reviewed by Kenneth Russell.

* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::setResourceLimit):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92430 268f45cc-cd09-0410-ab3c-d52691b4dbfc