WebKit-https.git
11 years agoFixing Chromium's POSIX VFS implementation, by adding the required
dumi@chromium.org [Thu, 12 Nov 2009 05:58:28 +0000 (05:58 +0000)]
Fixing Chromium's POSIX VFS implementation, by adding the required
"used file descriptors" logic.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=31275

* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Thu, 12 Nov 2009 05:46:22 +0000 (05:46 +0000)]
2009-11-11  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31326

        Makes the output for test fast/events/drag-and-drop.html pretty.
        Now, it is easier to read for a human to read understand the results.

        * fast/events/drag-and-drop-expected.txt: Rebased result.
        * fast/events/drag-and-drop.html: Modified to make the output pretty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoneed to implement aria tree roles
cfleizach@apple.com [Thu, 12 Nov 2009 05:26:01 +0000 (05:26 +0000)]
need to implement aria tree roles
https://bugs.webkit.org/show_bug.cgi?id=31284

Reviewed by Oliver Hunt.

WebCore:

Tests: platform/mac/accessibility/aria-multiselectable.html
       platform/mac/accessibility/aria-tree.html

* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::accessibilityIsIgnored):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaTreeItemContent):
(WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
* accessibility/AccessibilityObject.h:
(WebCore::):
(WebCore::AccessibilityObject::isTree):
(WebCore::AccessibilityObject::isTreeItem):
(WebCore::AccessibilityObject::setIsExpanded):
(WebCore::AccessibilityObject::canSetExpandedAttribute):
(WebCore::AccessibilityObject::hierarchicalLevel):
(WebCore::AccessibilityObject::setSelectedRows):
(WebCore::AccessibilityObject::performDefaultAction):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::hierarchicalLevel):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::isExpanded):
(WebCore::AccessibilityRenderObject::setElementAttributeValue):
(WebCore::AccessibilityRenderObject::elementAttributeValue):
(WebCore::AccessibilityRenderObject::setIsExpanded):
(WebCore::AccessibilityRenderObject::isSelected):
(WebCore::AccessibilityRenderObject::setSelected):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::createARIARoleMap):
(WebCore::AccessibilityRenderObject::canSetExpandedAttribute):
(WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::selectedChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(RoleEntry::):
(-[AccessibilityObjectWrapper subrole]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[AccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
* html/HTMLAttributeNames.in:

WebKitTools:

* DumpRenderTree/AccessibilityUIElement.cpp:
(disclosedRowAtIndexCallback):
(selectedRowAtIndexCallback):
(isEqualCallback):
(isAttributeSettableCallback):
(isActionSupportedCallback):
(disclosedByRowCallback):
(hierarchicalLevelCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement::isEqual):
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::disclosedByRow):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::hierarchicalLevel):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::disclosedByRow):

LayoutTests:

* accessibility/aria-readonly-expected.txt:
* accessibility/aria-readonly.html:
* platform/mac/accessibility/aria-multiselectable-expected.txt: Added.
* platform/mac/accessibility/aria-multiselectable.html: Added.
* platform/mac/accessibility/aria-tree-expected.txt: Added.
* platform/mac/accessibility/aria-tree.html: Added.
* platform/mac/accessibility/content-editable-expected.txt:
* platform/mac/accessibility/radio-button-group-members-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix after @r50760 with ENABLE_FILTERS.
bfulgham@webkit.org [Thu, 12 Nov 2009 04:31:31 +0000 (04:31 +0000)]
Build fix after @r50760 with ENABLE_FILTERS.

* platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::apply): Supply ColorSpace to fillRect.
* svg/graphics/filters/SVGFEFlood.cpp: Supply ColorSpace argument
  to fillRect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 12 Nov 2009 04:19:07 +0000 (04:19 +0000)]
2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        svn-apply can not handle git binary diffs
        https://bugs.webkit.org/show_bug.cgi?id=26830

        Support "literal" type git binary diffs.

        * Scripts/VCSUtils.pm:
        * Scripts/modules/scm_unittest.py:
        * Scripts/svn-apply:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 12 Nov 2009 04:17:59 +0000 (04:17 +0000)]
2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix WebSocket frame parser of frame_type with high-order bit set.
        https://bugs.webkit.org/show_bug.cgi?id=30668

        * websocket/tests/frame-length-longer-than-buffer-expected.txt: Added.
        * websocket/tests/frame-length-longer-than-buffer.html: Added.
        * websocket/tests/frame-length-longer-than-buffer_wsh.py: Added.
        * websocket/tests/frame-length-skip-expected.txt: Added.
        * websocket/tests/frame-length-skip.html: Added.
        * websocket/tests/frame-length-skip_wsh.py: Added.
        * websocket/tests/script-tests/frame-length-longer-than-buffer.js: Added.
        * websocket/tests/script-tests/frame-length-skip.js: Added.
2009-11-11  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix WebSocket frame parser of frame_type with high-order bit set.
        https://bugs.webkit.org/show_bug.cgi?id=30668

        If buffer is smaller than frame's length, it should break the loop
        instead of reading next byte.

        Tests: websocket/tests/frame-length-longer-than-buffer.html
               websocket/tests/frame-length-skip.html

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPut tests into skiplist added in r50830 and r50839 because
ossy@webkit.org [Thu, 12 Nov 2009 03:38:29 +0000 (03:38 +0000)]
Put tests into skiplist added in r50830 and r50839 because
layoutTestController.showWebInspector() is unimplemented now.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Various doc fixes
tonikitoo@webkit.org [Thu, 12 Nov 2009 03:20:34 +0000 (03:20 +0000)]
[Qt] Various doc fixes
https://bugs.webkit.org/show_bug.cgi?id=31358

Reviewed by Kenneth Christiansen.

Fixed wrong documentation: item's dimensions do fit to Web page
content by default.

Kenneth agreed to land this as a followup patch to the
just landed documentation patch.

* Api/qgraphicswebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Yusuke Sato <yusukes@chromium.org>
eric@webkit.org [Thu, 12 Nov 2009 03:20:15 +0000 (03:20 +0000)]
2009-11-11  Yusuke Sato  <yusukes@chromium.org>

        Reviewed by Adam Barth.

        [chromium] Remove t2embed.dll functions from FontCustomPlatformData.cpp for Chromium
        https://bugs.webkit.org/show_bug.cgi?id=31345

        Remove dependency on t2embed.dll so that Chromium for Windows can start even if t2embed.dll cannot be accessed.

        * platform/graphics/chromium/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Remove TTDeleteEmbeddedFont() call. Always use RemoveFontMemResourceEx().
        (WebCore::FontCustomPlatformData::fontPlatformData): Remove TTGetNewFontName() call.
        (WebCore::createFontCustomPlatformData): Remove TTLoadEmbeddedFont() call. Always use AddFontMemResourceEx() via renameAndActivateFont() in opentype/OpenTypeUtility.h. Remove EOTStream class as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Various doc fixes
tonikitoo@webkit.org [Thu, 12 Nov 2009 03:20:11 +0000 (03:20 +0000)]
[Qt] Various doc fixes
https://bugs.webkit.org/show_bug.cgi?id=31323

Patch by David Boddie <dboddie@trolltech.com> on 2009-11-11
Reviewed by Kenneth Christiansen.

Fixed and synchronized QWebView related documentation.

* Api/qgraphicswebview.cpp:
* Api/qwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Dirk Pranke <dpranke@chromium.org>
eric@webkit.org [Thu, 12 Nov 2009 03:02:12 +0000 (03:02 +0000)]
2009-11-11  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dmitry Titov.

        Rewrite the test to run on a wider variety of screen configurations
        (and pixel depths).

        https://bugs.webkit.org/show_bug.cgi?id=31373

        * fast/dom/Window/window-screen-properties-expected.txt:
        * fast/dom/Window/window-screen-properties.html:
        * platform/win/fast/dom/Window/window-screen-properties-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix. No review needed.
bdakin@apple.com [Thu, 12 Nov 2009 02:31:19 +0000 (02:31 +0000)]
Build fix. No review needed.

* WebKitGraphics.cpp:
(WebDrawText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix. No review needed.
bdakin@apple.com [Thu, 12 Nov 2009 02:30:15 +0000 (02:30 +0000)]
Build fix. No review needed.

* platform/graphics/gtk/FontGtk.cpp:
(WebCore::Font::drawComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix. No review needed.
bdakin@apple.com [Thu, 12 Nov 2009 02:19:15 +0000 (02:19 +0000)]
Build fix. No review needed.

* platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix. No review needed.
bdakin@apple.com [Thu, 12 Nov 2009 02:13:11 +0000 (02:13 +0000)]
Windows build fix. No review needed.

* platform/graphics/win/FontCGWin.cpp:
(WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
bdakin@apple.com [Thu, 12 Nov 2009 01:51:00 +0000 (01:51 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=31382
Make -webkit-color-correction work with shadows

Reviewed by Simon Fraser.

From canvas, just send DeviceColorSpace to setShadow() for now.
Will fix soon when I address https://bugs.webkit.org/show_bug.cgi?id=31319
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::applyShadow):

setShadow() and setPlatformShadow() now take a ColorSpace.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setShadow):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::createCGColorWithColorSpace): New helper to create a
color in a ColorSpace.
(WebCore::setCGFillColor): Call new helper.
(WebCore::setCGStrokeColor): Call new helper.
(WebCore::GraphicsContext::setPlatformShadow): Call new helper.
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::setPlatformShadow):

Send appropriate ColorSpace to setShadow().
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintTextDecorations):
* rendering/InlineTextBox.cpp:
(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paintDecoration):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
* rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintCharacters):
* rendering/SVGRenderSupport.cpp:
(WebCore::SVGRenderBase::prepareToRenderSVGContent):

Attempt to keep ports building.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::setPlatformShadow):

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=31382
Make -webkit-color-correction work with shadows

Reviewed by Simon Fraser.

* fast/css/color-correction-on-box-shadow.html: Added.
* fast/css/color-correction-on-text-shadow.html: Added.
* platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum: Added.
* platform/mac/fast/css/color-correction-on-box-shadow-expected.png: Added.
* platform/mac/fast/css/color-correction-on-box-shadow-expected.txt: Added.
* platform/mac/fast/css/color-correction-on-text-shadow-expected.checksum: Added.
* platform/mac/fast/css/color-correction-on-text-shadow-expected.png: Added.
* platform/mac/fast/css/color-correction-on-text-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 12 Nov 2009 01:46:24 +0000 (01:46 +0000)]
2009-11-11  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Print the file text of a file upload control in DumpRenderTree for ease of tests.
        https://bugs.webkit.org/show_bug.cgi?id=31195

        * platform/mac-leopard/fast/forms/file-input-disabled-expected.txt:
        * platform/mac/fast/forms/box-shadow-override-expected.txt:
        * platform/mac/fast/forms/file-input-direction-expected.txt:
        * platform/mac/fast/forms/file-input-disabled-expected.txt:
        * platform/mac/fast/forms/form-element-geometry-expected.txt:
        * platform/mac/fast/forms/hidden-input-file-expected.txt:
        * platform/mac/fast/forms/input-appearance-height-expected.txt:
        * platform/mac/fast/forms/input-value-expected.txt:
        * platform/win/fast/forms/box-shadow-override-expected.txt:
        * platform/win/fast/forms/file-input-disabled-expected.txt:
        * platform/win/fast/forms/input-appearance-height-expected.txt:
        * platform/win/fast/forms/input-value-expected.txt:
2009-11-11  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Print the file text of a file upload control in DumpRenderTree for ease of tests.
        https://bugs.webkit.org/show_bug.cgi?id=31195

        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject):
        (WebCore::RenderFileUploadControl::fileTextValue):
        * rendering/RenderFileUploadControl.h:
        (WebCore::RenderFileUploadControl::isFileUploadControl):
        (WebCore::toRenderFileUploadControl):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isFileUploadControl):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::operator<<):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDOM Wrappers for some nodes may not be marked.
barraclough@apple.com [Thu, 12 Nov 2009 01:00:24 +0000 (01:00 +0000)]
DOM Wrappers for some nodes may not be marked.
https://bugs.webkit.org/show_bug.cgi?id=31380

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-11
Reviewed by Sam Weinig.

Some markChildren methods are calling getCachedDOMNodeWrapper, which will find
the wrapper for the current world only.  This means that wrappers may be GC'ed
prematurely, and properties lost.

Move to a model more like markDOMObjectWrapper, mark wrappers for all worlds.

* bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::markChildren):
* bindings/js/JSDOMBinding.cpp:
(WebCore::markDOMNodeWrapper):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::markChildren):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::markChildren):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::markChildren):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::markChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Build fix. Will be cleaned up in subsequent patch once we know exaclt...
jorlow@chromium.org [Thu, 12 Nov 2009 00:55:14 +0000 (00:55 +0000)]
Not reviewed.  Build fix.  Will be cleaned up in subsequent patch once we know exaclty what's going on.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-11-11
* src/WebBindings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Ben Murdoch <benm@google.com>
eric@webkit.org [Thu, 12 Nov 2009 00:39:29 +0000 (00:39 +0000)]
2009-11-11  Ben Murdoch  <benm@google.com>

        Reviewed by Darin Adler.

        bindings/js/ScriptObject.cpp is missing and ENABLE(INSPECTOR) guard.
        https://bugs.webkit.org/show_bug.cgi?id=31384

        No functionality change so no tests required.

        * bindings/js/ScriptObject.cpp: Add ENABLE(INSPECTOR) guard around the JSInspectorBackend.h include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed, removing duplicate entry for myself in committers.py.
dimich@chromium.org [Thu, 12 Nov 2009 00:19:50 +0000 (00:19 +0000)]
Not reviewed, removing duplicate entry for myself in committers.py.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoThe Big De-Inlining. 450k code size reduction (32-bit x86.)
snej@chromium.org [Thu, 12 Nov 2009 00:11:22 +0000 (00:11 +0000)]
The Big De-Inlining. 450k code size reduction (32-bit x86.)
- Various inline functions in V8Binding.h made non-inline.
- Some renaming for consistency.
- New function createRawTemplate().
https://bugs.webkit.org/show_bug.cgi?id=31383

Reviewed by Dimitri Glazkov.

* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Binding.cpp:
(WebCore::v8DOMWrapperToNative):
(WebCore::v8ValueToWebCoreString):
(WebCore::v8ValueToAtomicWebCoreString):
(WebCore::toInt32):
(WebCore::toWebCoreString):
(WebCore::toWebCoreStringWithNullCheck):
(WebCore::toAtomicWebCoreStringWithNullCheck):
(WebCore::toWebCoreStringWithNullOrUndefinedCheck):
(WebCore::isUndefinedOrNull):
(WebCore::v8Boolean):
(WebCore::v8UndetectableString):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
(WebCore::v8StringOrFalse):
(WebCore::v8StringToWebCoreString):
(WebCore::v8ExternalString):
(WebCore::createRawTemplate):  New function.
* bindings/v8/V8Binding.h:
(WebCore::v8DOMWrapperTo):
(WebCore::v8DOMWrapperToNode):
(WebCore::v8StringToWebCoreString):
(WebCore::v8StringToAtomicWebCoreString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Erik Arvidsson <arv@chromium.org>
eric@webkit.org [Wed, 11 Nov 2009 23:56:07 +0000 (23:56 +0000)]
2009-11-11  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Dmitri Titov.

        Fix layout test to not call onload on the wrong window after image has
        been dropped onto the iframe.
        https://bugs.webkit.org/show_bug.cgi?id=30893

        * editing/selection/drag-to-contenteditable-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMore V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
snej@chromium.org [Wed, 11 Nov 2009 22:54:31 +0000 (22:54 +0000)]
More V8 de-inlining (outlining?) Abstracted a chunk of boilerplate code from every
event-listener setter into a new subroutine transferHiddenDependency().
https://bugs.webkit.org/show_bug.cgi?id=31377

Reviewed by Dimitri Glazkov.

* bindings/scripts/CodeGeneratorV8.pm:  Replace boilerplate with call to transferHiddenDependency().
* bindings/v8/V8Utilities.cpp:
(WebCore::transferHiddenDependency):  New.
* bindings/v8/V8Utilities.h:  Declaration of transferHiddenDependency.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
bweinstein@apple.com [Wed, 11 Nov 2009 22:49:26 +0000 (22:49 +0000)]
WebCore: If we are on Windows, don't try and get the kCGColorSpaceSRGB ColorSpace,
because there is a CG bug preventing this from working.

Reviewed by Beth Dakin.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::sRGBColorSpaceRef):

LayoutTests: Unskip the webkit-color-correction tests because the workaround of using
the deviceRGBColorSpace allows the tests to pass on Windows.

Reviewed by Beth Dakin.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler and Mark Rowe.
ap@apple.com [Wed, 11 Nov 2009 22:07:53 +0000 (22:07 +0000)]
    Reviewed by Darin Adler and Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=31200
        Tests in http/tests/security/mixedContent start to fail when new tests are added

        * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSkip the webkit-color-correction tests because they crash on Windows
bweinstein@apple.com [Wed, 11 Nov 2009 21:57:40 +0000 (21:57 +0000)]
Skip the webkit-color-correction tests because they crash on Windows
due to a CoreGraphics bug.

Reviewed by Darin Adler.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 11 Nov 2009 21:37:08 +0000 (21:37 +0000)]
2009-11-11  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Check that if Storage panel exists before calling its methods

        https://bugs.webkit.org/show_bug.cgi?id=31343

        * inspector/front-end/inspector.js:
        (WebInspector.addDatabase):
        (WebInspector.addCookieDomain):
        (WebInspector.addDOMStorage):
        (WebInspector.updateDOMStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Eric Z. Ayers <zundel@google.com>
eric@webkit.org [Wed, 11 Nov 2009 21:35:43 +0000 (21:35 +0000)]
2009-11-11  Eric Z. Ayers  <zundel@google.com>

        Reviewed by Pavel Feldman.

        Timeline tests for records generated for
        Layout, Paint, ParseHTML, MarkTimeline, and Style Recalculation

        https://bugs.webkit.org/show_bug.cgi?id=31361

        * inspector/timeline-layout-expected.txt: Added.
        * inspector/timeline-layout.html: Added.
        * inspector/timeline-mark-timeline-expected.txt: Added.
        * inspector/timeline-mark-timeline.html: Added.
        * inspector/timeline-paint-expected.txt: Added.
        * inspector/timeline-paint.html: Added.
        * inspector/timeline-parse-html-expected.txt: Added.
        * inspector/timeline-parse-html.html: Added.
        * inspector/timeline-recalculate-styles-expected.txt: Added.
        * inspector/timeline-recalculate-styles.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Drew Wilson <atwilson@chromium.org>
eric@webkit.org [Wed, 11 Nov 2009 21:23:01 +0000 (21:23 +0000)]
2009-11-11  Drew Wilson  <atwilson@chromium.org>

        Reviewed by Dimitri Glazkov.

        SharedWorkerRepository.connect() does not call WebSharedWorkerRepository
        https://bugs.webkit.org/show_bug.cgi?id=31371

        Test: Unit tests can be enabled downstream when this lands.

        * src/SharedWorkerRepository.cpp:
        (WebCore::SharedWorkerRepository::connect):
        Added missing call to WebSharedWorkerRepository.addSharedWorker().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCreate, and display a window for the inspector, for inspector tests.
kov@webkit.org [Wed, 11 Nov 2009 21:10:58 +0000 (21:10 +0000)]
Create, and display a window for the inspector, for inspector tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Wed, 11 Nov 2009 21:10:11 +0000 (21:10 +0000)]
2009-11-11  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tiny path fixes in Chromium API includes.

        https://bugs.webkit.org/show_bug.cgi?id=31369

        * public/linux/WebSandboxSupport.h: Fixed path.
        * src/WebBindings.cpp: Fixed path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDe-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
snej@chromium.org [Wed, 11 Nov 2009 21:09:49 +0000 (21:09 +0000)]
De-inline convertNodeToV8Object(), which expands to a lot of asm code and is inlined 136
times in the generated V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=31368

Reviewed by Dimitri Glazkov.

* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertNodeToV8Object):  Moved body here from .h file
* bindings/v8/V8DOMWrapper.h:  Removed inline method body.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Display the correct summary in the web inspector for the shorthands
jberlin@webkit.org [Wed, 11 Nov 2009 20:20:45 +0000 (20:20 +0000)]
WebCore: Display the correct summary in the web inspector for the shorthands
border-color, border-width, border-style, margin, and padding.
https://bugs.webkit.org/show_bug.cgi?id=7987

Reviewed by Timothy Hatcher.

Test: fast/css/shorthands-four-values.html

* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::get4Values):
Display the summary information in the same way the shorthand would be
specified in a css rule.

LayoutTests:

* fast/css/shorthands-four-values-expected.txt: Added.
* fast/css/shorthands-four-values.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Wed, 11 Nov 2009 20:00:05 +0000 (20:00 +0000)]
2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Alexey Proskuryakov.

        Refactor multiple JavaScriptCore threads
        https://bugs.webkit.org/show_bug.cgi?id=31328

        Remove the id field from the PlatformThread structure
        as it is not used.

        * runtime/Collector.cpp:
        (JSC::getCurrentPlatformThread):
        (JSC::suspendThread):
        (JSC::resumeThread):
        (JSC::getPlatformThreadRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/qt: Unreviewed buildbot fix.
kenneth@webkit.org [Wed, 11 Nov 2009 19:57:02 +0000 (19:57 +0000)]
WebKit/qt: Unreviewed buildbot fix.

Export a method to the DRT to know if the document has a
document element.

* Api/qwebframe.cpp:
(qt_drt_hasDocumentElement):

WebKitTools: Unreviewed Qt buildbot fix.

My previous fix was wrong, so revert that change and fix it by
returning when the document of the frame has no document element.
Idea is borrowed from mac and win DRT.

* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::dumpFramesAsText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake V8 bindings return NULL handles instead of calling v8::Undefined(). This has...
snej@chromium.org [Wed, 11 Nov 2009 19:53:19 +0000 (19:53 +0000)]
Make V8 bindings return NULL handles instead of calling v8::Undefined(). This has equivalent
meaning to the caller, saves code, and appears to save a few cycles at runtime too.
https://bugs.webkit.org/show_bug.cgi?id=31367

Reviewed by Dimitri Glazkov.

* bindings/scripts/CodeGeneratorV8.pm: Change "v8::Undefined()" to "v8::Handle<v8::Value>()"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Eric Z. Ayers <zundel@google.com>
eric@webkit.org [Wed, 11 Nov 2009 19:51:11 +0000 (19:51 +0000)]
2009-11-11  Eric Z. Ayers  <zundel@google.com>

        Reviewed by Pavel Feldman.

        Added a test of an externally loaded script tag for Inspector
        timeline records.
        Fixed identity comparisons.

        https://bugs.webkit.org/show_bug.cgi?id=31365

        * inspector/timeline-script-tag-1.html:
        * inspector/timeline-script-tag-2-expected.txt: Added.
        * inspector/timeline-script-tag-2.html: Added.
        * inspector/timeline-script-tag-2.js: Added.
        * inspector/timeline-test.js:
        ():
        (timelineAgentTypeToString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 11 Nov 2009 19:46:44 +0000 (19:46 +0000)]
2009-11-11  Eric Seidel  <eric@webkit.org>

        Reviewed byg Kenneth Rohde Christiansen.

        Update Kenneth's committer record to include the email he
        uses on lists.webkit.org.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 11 Nov 2009 19:23:07 +0000 (19:23 +0000)]
2009-11-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Gustavo Noronha Silva.

        Several committers use separate email addresses for bugzilla and svn.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=31364

        Update records for existing committers to include email addresses
        used in svn.webkit.org and lists.webkit.org.
        Most committers use the same email address in all 3 places, but some use
        separate addresses.  committers.py needs record of each of these addresses.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Kenneth Christiansen.
tonikitoo@webkit.org [Wed, 11 Nov 2009 19:21:52 +0000 (19:21 +0000)]
Rubber-stamped by Kenneth Christiansen.

Grouping some of the current skipped plugin tests that fail
due to the same reason: no support for objective-c functions.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoOptimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.
snej@chromium.org [Wed, 11 Nov 2009 19:19:50 +0000 (19:19 +0000)]
Optimize V8 getDOMNodeMap(), a hot function in Dromaeo DOM tests, by increasing inlining.

Reviewed by Dimitri Glazkov.

* bindings/v8/DOMData.cpp:
(WebCore::DOMData::getCurrent):  Moved getCurrentMainThread to MainThreadDOMData::getCurrent
    so it can be inlined by its caller.
* bindings/v8/DOMData.h:
* bindings/v8/MainThreadDOMData.cpp:
(WebCore::MainThreadDOMData::getCurrent):  Moved here from DOMData.cpp.
(WebCore::MainThreadDOMData::getMainThreadStore):  Added UNLIKELY macro to improve codegen.
(WebCore::MainThreadDOMData::getCurrentMainThreadStore):  Combination of getCurrentMainThread
    and getStore, which inline both calls together.
* bindings/v8/MainThreadDOMData.h:
(WebCore::MainThreadDOMData::getStore):  Broke out nonvirtual getMainThreadStore for inlineability.
* bindings/v8/V8DOMMap.cpp:
(WebCore::getDOMNodeMap):  Call new getCurrentMainThreadStore, which is faster.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Wed, 11 Nov 2009 19:04:59 +0000 (19:04 +0000)]
2009-11-11  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31334

        We should skip the test case /fast/events/drag-and-drop-fire-drag-dragover.html
        on both the Qt and GTK builds since there are issues with drag-and-drop support
        in these builds.

        For Qt: https://bugs.webkit.org/show_bug.cgi?id=31332
        For GTK: https://bugs.webkit.org/show_bug.cgi?id=30576

        * platform/gtk/Skipped: Skip test case /fast/events/drag-and-drop-fire-drag-dragover.html
        since there are issues with drag-and-drop support in both GTK and Qt.
        * platform/qt/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoIf the frame has no innerText don't append it, and
kenneth@webkit.org [Wed, 11 Nov 2009 18:45:11 +0000 (18:45 +0000)]
If the frame has no innerText don't append it, and
do not add a newline which breaks some cross platform
results.

Reviewed by Simon Hausmann.

* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::dumpFramesAsText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix a crash in the layout test plugins/document-open.html
kenneth@webkit.org [Wed, 11 Nov 2009 18:44:58 +0000 (18:44 +0000)]
Fix a crash in the layout test plugins/document-open.html

Reviewed by Simon Hausmann.

* Api/qwebframe.cpp:
(QWebFrame::toPlainText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Liang QI <liang.qi@nokia.com>
eric@webkit.org [Wed, 11 Nov 2009 18:43:55 +0000 (18:43 +0000)]
2009-11-11  Liang QI  <liang.qi@nokia.com>

        [Qt] Fix tst_qwebpage and tst_qwebframe compilation on Symbian.

        * tests/qwebframe/qwebframe.pro:
        * tests/qwebframe/tst_qwebframe.cpp:
        * tests/qwebpage/qwebpage.pro:
        * tests/qwebpage/tst_qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 11 Nov 2009 18:39:58 +0000 (18:39 +0000)]
2009-11-11  Eric Seidel  <eric@webkit.org>

        No review, adding second email address for an existing committer.

        Add Yong Li's second bugzilla account to his committer record.
        See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 11 Nov 2009 18:36:47 +0000 (18:36 +0000)]
2009-11-11  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        http://trac.webkit.org/changeset/50811 removed some methods from
        platform/network/SocketStreamHandleClient.h, so remove them
        here too.

        https://bugs.webkit.org/show_bug.cgi?id=31360

        * public/WebSocketStreamHandleClient.h:
        * src/SocketStreamHandle.cpp:
        (WebCore::SocketStreamHandleInternal::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 11 Nov 2009 18:32:02 +0000 (18:32 +0000)]
2009-11-11  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Add methods to KURLGoogle.cpp declared in http://trac.webkit.org/changeset/50784 but not defined when using KURLGoogle.

        https://bugs.webkit.org/show_bug.cgi?id=31357

        * platform/KURLGoogle.cpp:
        (WebCore::isSchemeFirstChar):
        (WebCore::isSchemeChar):
        (WebCore::KURL::hasPort):
        (WebCore::KURL::removePort):
        (WebCore::protocolIsValid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Regression: Preserve the parent of plugin objects when using
hausmann@webkit.org [Wed, 11 Nov 2009 18:31:33 +0000 (18:31 +0000)]
[Qt] Regression: Preserve the parent of plugin objects when using
QtWebKit with only a QWebPage.

Reviewed by Tor Arne Vestbø.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin): Don't reparent
plugins to 0.
* tests/qwebpage/tst_qwebpage.cpp:
(PluginCounterPage::PluginCounterPage): Initialize m_pluginParent to 0.
(PluginCounterPage::~PluginCounterPage): Delete the plugin parent later
(after the page)
(PluginTracerPage::createPlugin): Assign a dummy parent to the plugin.
(PluginTracerPage::PluginTracerPage): Set up the plugin parent.
(tst_QWebPage::createViewlessPlugin): Verify that for viewless pages the
plugin parent remains unchanged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 David Boddie <dboddie@trolltech.com>
eric@webkit.org [Wed, 11 Nov 2009 18:21:37 +0000 (18:21 +0000)]
2009-11-11  David Boddie  <dboddie@trolltech.com>

        [Qt] Doc: Added internal or hidden placeholder documentation.

        * Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix, no reviewed.
bfulgham@webkit.org [Wed, 11 Nov 2009 18:15:16 +0000 (18:15 +0000)]
Build fix, no reviewed.

Correct setPlatformFillColor and setPlatformStrokeColor calls
to match new ColorSpace-supporting signatures.

* platform/graphics/win/GraphicsContextCairoWin.cpp:  Add the
  color space to the set[...]Color calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Martin Smith <msmith@trolltech.com>
eric@webkit.org [Wed, 11 Nov 2009 18:14:15 +0000 (18:14 +0000)]
2009-11-11  Martin Smith  <msmith@trolltech.com>

        [Qt] doc: Changed Trolltech to Nokia

        * Api/qwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 11 Nov 2009 18:06:17 +0000 (18:06 +0000)]
2009-11-11  Nate Chapin  <japhet@chromium.org>

        Reviewed by Eric Seidel.

        Remove some additional references to dragSourceMovedTo() not
        needed after http://trac.webkit.org/changeset/50786.

        https://bugs.webkit.org/show_bug.cgi?id=31354

        * public/WebView.h:
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Yuta Kitamura <yutak@chromium.org>
eric@webkit.org [Wed, 11 Nov 2009 17:51:01 +0000 (17:51 +0000)]
2009-11-11  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Eric Seidel.

        Convert LayoutTests/fast/inline/dirtyLinesForInline.html into dumpAsText.

        This test checks if the browser crashes after some operations. It doesn't test
        any other interesting features, so we can safely make it a dumpAsText test.

        https://bugs.webkit.org/show_bug.cgi?id=31335

        * fast/inline/dirtyLinesForInline-expected.txt: Added.
        * fast/inline/dirtyLinesForInline.html: Added dumpAsText().
        * platform/mac/fast/inline/dirtyLinesForInline-expected.checksum: Removed.
        * platform/mac/fast/inline/dirtyLinesForInline-expected.png: Removed.
        * platform/mac/fast/inline/dirtyLinesForInline-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImplement missing functionality in the Gtk/Qt TestNetscapePlugin.
kenneth@webkit.org [Wed, 11 Nov 2009 17:33:25 +0000 (17:33 +0000)]
Implement missing functionality in the Gtk/Qt TestNetscapePlugin.

Reviewed by Simon Hausmann.

* DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_instance):
(webkit_test_plugin_destroy_instance):
(webkit_test_plugin_destroy_stream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
ap@apple.com [Wed, 11 Nov 2009 17:22:52 +0000 (17:22 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=31327
        Clean up SocketStreamHandleClient interface

        No change in behavior.

        * platform/network/SocketStreamHandleClient.h: Removed willOpenStream and willSendData.
        (WebCore::SocketStreamHandleClient::willOpenStream): Removed. This is currently not used by
        the only client (WebSocketChannel), and it's not clear what this callback's semantics
        should be.
        (WebCore::SocketStreamHandleClient::willSendData): Ditto.
        (WebCore::SocketStreamHandleClient::receivedCancellation): Removed, because it was misplaced.
        For ResourceHandle, this method is called when the user cancels authentication sheet,
        not when something happens with the stream.

        * websockets/WebSocketChannel.h: Some WebSocketChannel methods were virtual without any
        reason. Also, added didReceiveAuthenticationChallenge/didCancelAuthenticationChallenge.

        * websockets/WebSocketChannel.cpp: Adjusted for the above change. Authentication-related
        callbacks have no real implementation yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAllow custom memory allocation control for the part of page directory in WebCore
zoltan@webkit.org [Wed, 11 Nov 2009 17:06:13 +0000 (17:06 +0000)]
Allow custom memory allocation control for the part of page directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31350

Reviewed by Eric Seidel.

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and these are no need to be copyable:

class DragController         - instantiated at: WebCore/page/Page.cpp:107
class FocusController        - instantiated at: WebCore/page/Page.cpp:109
class Settings               - instantiated at: WebCore/page/Page.cpp:116
class PluginHalter           - instantiated at: WebCore/page/Page.cpp:160
struct ScheduledEvent        - instantiated at: WebCore/page/FrameView.cpp:1275
class UserScript             - instantiated at: WebCore/page/PageGroup.cpp:208
struct EventHandlerDragState - instantiated at: WebCore/page/EventHandler.cpp:182
class XSSAuditor             - instantiated at: WebCore/bindings/js/ScriptController.cpp:70
class UserStyleSheet         - instantiated at: WebCore/page/PageGroup.cpp:222

Inherits PropertyWrapperBase class from Noncopyable because (its child class)
PropertyWrapper is instantiated by 'new' in
WebCore/page/animation/AnimationBase.cpp:564 it is no need to be copyable.

* page/DragController.h:
* page/EventHandler.h:
* page/FocusController.h:
* page/FrameView.cpp:
* page/PluginHalter.h:
* page/Settings.h:
* page/UserScript.h:
* page/UserStyleSheet.h:
* page/XSSAuditor.h:
* page/animation/AnimationBase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Eric Z. Ayers <zundel@google.com>
eric@webkit.org [Wed, 11 Nov 2009 17:05:30 +0000 (17:05 +0000)]
2009-11-11  Eric Z. Ayers  <zundel@google.com>

        Reviewed by Timothy Hatcher.

        Adds a test that dumps the timeline data for a simple script tag.

        https://bugs.webkit.org/show_bug.cgi?id=31204

        * inspector/inspector-test.js:
        (onload):
        * inspector/timeline-script-tag-1-expected.txt: Added.
        * inspector/timeline-script-tag-1.html: Added.
        * inspector/timeline-test.js: Added.
        (retrieveTimelineData):
        ():
        (dumpTimelineRecords):
        (printTimelineRecordProperties):
        (isNonDeterministicProp):
        (printProps):
        (isTimelineOverheadRecord):
        (markTimelineRecordAsOverhead):
        (timelineAgentTypeToString):
        (frontend_startTimelineProfiler.window.WebInspector.addRecordToTimeline):
        (frontend_startTimelineProfiler):
        (frontend_getTimelineResults):
        (frontend_setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 11 Nov 2009 17:03:11 +0000 (17:03 +0000)]
2009-11-11  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Remove WebViewImpl::dragSourceMovedTo(), as it is no longer
        needed after http://trac.webkit.org/changeset/50786.

        https://bugs.webkit.org/show_bug.cgi?id=31354

        * src/WebViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoQt build fix on Mac OS X
vestbo@webkit.org [Wed, 11 Nov 2009 16:02:17 +0000 (16:02 +0000)]
Qt build fix on Mac OS X

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Wed, 11 Nov 2009 14:45:38 +0000 (14:45 +0000)]
2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        https://bugs.webkit.org/show_bug.cgi?id=31323
        Fix a few compiler warnings

        No new tests as there is no new functionality.

        * editing/htmlediting.cpp:
        (WebCore::isRenderedAsNonInlineTableImageOrHR): Use explicit
        parentheses to silence gcc 4.4 -Wparentheses warnings
2009-11-11  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        https://bugs.webkit.org/show_bug.cgi?id=31323
        Fix a few compiler warnings

        * tests/qwebframe/tst_qwebframe.cpp: Add extra brackets
        to make it explicit where the else case belongs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Force -graphicssystem raster and -style windows when running DRT
vestbo@webkit.org [Wed, 11 Nov 2009 14:19:07 +0000 (14:19 +0000)]
[Qt] Force -graphicssystem raster and -style windows when running DRT

Reviewed by Simon Hausmann.

* DumpRenderTree/qt/main.cpp:
* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Set m_hasPendingGeometryChange to true by default, so that
kenneth@webkit.org [Wed, 11 Nov 2009 14:11:16 +0000 (14:11 +0000)]
WebCore: Set m_hasPendingGeometryChange to true by default, so that
at least one call to NPP_SetWindow is executed, which is
needed by the DRT plugin testing framework.

Reviewed by Mark Rowe.

* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):

WebKitTools: Implement the functionality needed by plugins/window-open.html

Reviewed by Mark Rowe.

* DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_instance):
(webkit_test_plugin_set_window):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Wed, 11 Nov 2009 14:00:12 +0000 (14:00 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=31348
[Qt] Remove unnecessary LUT creator from WebCore.pro

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCompute correct library paths for Qt
vestbo@webkit.org [Wed, 11 Nov 2009 13:31:48 +0000 (13:31 +0000)]
Compute correct library paths for Qt

Reviewed by Simon Hausmann.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Introduce a function for querying the input method status
hausmann@webkit.org [Wed, 11 Nov 2009 13:19:35 +0000 (13:19 +0000)]
WebCore: Introduce a function for querying the input method status
in QWebPageClient.

Reviewed by Tor Arne Vestbø.

* platform/qt/QWebPageClient.h:

WebKit/qt: Fix enabling of software input panel when activating editable elements
in QGraphicsWebView.

Reviewed by Tor Arne Vestbø.

* Api/qgraphicswebview.cpp:
(QGraphicsWebViewPrivate::inputMethodEnabled): Implement method to
query for input method support.
* Api/qwebpage.cpp:
(QWebPageWidgetClient::inputMethodEnabled): Ditto for QWidget.
(QWebPagePrivate::handleSoftwareInputPanel): Don't use view() to
test for input method support. Instead query using QWebPageClient
and send the SIPR event to the ownerWidget() instead of the view().
The latter is null for QGraphicsWebView.
* tests/qwebpage/tst_qwebpage.cpp:
(EventSpy::EventSpy):
(EventSpy::eventFilter):
(tst_QWebPage::inputMethods): Modify the test to verify that SIPR
events are dispatched when activating focusable content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed. Skipping new tests.
kov@webkit.org [Wed, 11 Nov 2009 12:57:30 +0000 (12:57 +0000)]
Unreviewed. Skipping new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Holger Freyther.
kov@webkit.org [Wed, 11 Nov 2009 12:44:02 +0000 (12:44 +0000)]
Reviewed by Holger Freyther.

Should not print javascript console messages to stdout
https://bugs.webkit.org/show_bug.cgi?id=31346

* webkit/webkitwebview.cpp:
(webkit_web_view_real_console_message): Print console messages to
stderr instead, using the recommended method (a g_log variant).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Benjamin Otte <otte@gnome.org>
eric@webkit.org [Wed, 11 Nov 2009 11:24:56 +0000 (11:24 +0000)]
2009-11-11  Benjamin Otte  <otte@gnome.org>

        Reviewed by Jan Alonzo.

        [GTK] Black artifacts in youtube.com/html5

        Paint the video to the given size. It's the job of the callers to keep
        track of aspect ratio. RenderVideo.cpp does it for the <video>
        element.
        https://bugs.webkit.org/show_bug.cgi?id=30925

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Wed, 11 Nov 2009 11:17:20 +0000 (11:17 +0000)]
2009-11-11  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=30901
        [Gtk] Need to de-lint the Atk a11y code

        Cleaned up some missed capitalization style-guideline violations.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Wed, 11 Nov 2009 09:38:36 +0000 (09:38 +0000)]
2009-11-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Make the default style background color valid.
        Currently the color is transparent but invalid, this causes
        list boxes in QtWebKit to be drawn with a black background
        since r49242.
        https://bugs.webkit.org/show_bug.cgi?id=31295

        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::initialBackgroundColor):
        * rendering/style/StyleBackgroundData.cpp:
        (WebCore::StyleBackgroundData::StyleBackgroundData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Wed, 11 Nov 2009 09:23:18 +0000 (09:23 +0000)]
2009-11-11  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Levin.

        Add a test for web socket handshake error.

        https://bugs.webkit.org/show_bug.cgi?id=31336

        * websocket/tests/handshake-error-expected.txt: Added.
        * websocket/tests/handshake-error.html: Added.
        * websocket/tests/handshake-error_wsh.py: Added.
        * websocket/tests/script-tests/handshake-error.js: Added.
        (endTest):
        (ws.onopen):
        (ws.onmessage):
        (ws.onclose):
        (timeOutCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Yuzo Fujishima <yuzo@google.com>
eric@webkit.org [Wed, 11 Nov 2009 08:45:09 +0000 (08:45 +0000)]
2009-11-11  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by David Levin.

        Add a simple web socket test. This tests basic features of Web Socket.
        This also serves as an example of Web Socket tests.

        https://bugs.webkit.org/show_bug.cgi?id=27492

        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * websocket/tests/resources/simple.js: Added.
        (ws.onopen):
        (ws.onmessage):
        (ws.onclose):
        (timeOutCallback):
        * websocket/tests/simple-expected.txt: Added.
        * websocket/tests/simple.html: Added.
        * websocket/tests/simple_wsh.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-11 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Wed, 11 Nov 2009 08:36:58 +0000 (08:36 +0000)]
2009-11-11  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=30221
        [GTK] fails to load media embedded in iframe element

        * platform/gtk/Skipped: Unskip fixed tests.
2009-11-11  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=30221
        [GTK] fails to load media embedded in iframe element

        The FrameLoader can show Media if the audio/video support is
        enabled at compile time.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::canShowMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSimplify the ownership model for worlds - rather than having a pair of weak references
barraclough@apple.com [Wed, 11 Nov 2009 07:56:52 +0000 (07:56 +0000)]
Simplify the ownership model for worlds - rather than having a pair of weak references
between DOMWrapperWorld and ScriptController/ScriptCachedFrameData, give the latter an
ref pointer to the former.  This reduces complexity & cost of the caching entries in the
back forward cache.

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-10
Reviewed by Geoff Garen.

* WebCore.base.exp:
* bindings/js/JSDOMBinding.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
* bindings/js/JSDOMBinding.h:
(WebCore::DOMWrapperWorld::forgetDocument):
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):
* bindings/js/ScriptCachedFrameData.h:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):
* bindings/js/ScriptController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLinux build fix: Added an #include for UINT_MAX.
ggaren@apple.com [Wed, 11 Nov 2009 07:30:06 +0000 (07:30 +0000)]
Linux build fix: Added an #include for UINT_MAX.

* runtime/WeakRandom.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptGlue build fix: Marked a file 'private' instead of 'project'.
ggaren@apple.com [Wed, 11 Nov 2009 07:27:43 +0000 (07:27 +0000)]
JavaScriptGlue build fix: Marked a file 'private' instead of 'project'.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFaster Math.random, based on GameRand.
ggaren@apple.com [Wed, 11 Nov 2009 07:22:30 +0000 (07:22 +0000)]
Faster Math.random, based on GameRand.

Reviewed by Gavin "avGni arBalroguch" Barraclough.

SunSpider says 1.4% faster.

* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Added the header to the project.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h: Use an object to track random number generation
state, initialized to the current time.

* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
(JSC::mathProtoFuncRandom): Use the new hotness.

* runtime/WeakRandom.h: Added.
(JSC::WeakRandom::WeakRandom):
(JSC::WeakRandom::get):
(JSC::WeakRandom::advance): The new hotness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRe-baselined layout test results for Windows for tests in fast/ruby.
rolandsteiner@chromium.org [Wed, 11 Nov 2009 05:51:02 +0000 (05:51 +0000)]
Re-baselined layout test results for Windows for tests in fast/ruby.
(see https://bugs.webkit.org/show_bug.cgi?id=28420)

Reviewed by Eric Seidel.

* platform/win/fast/ruby: Added.
* platform/win/fast/ruby/ruby-empty-rt-expected.checksum: Added.
* platform/win/fast/ruby/ruby-empty-rt-expected.png: Added.
* platform/win/fast/ruby/ruby-empty-rt-expected.txt: Added.
* platform/win/fast/ruby/ruby-length-expected.checksum: Added.
* platform/win/fast/ruby/ruby-length-expected.png: Added.
* platform/win/fast/ruby/ruby-length-expected.txt: Added.
* platform/win/fast/ruby/ruby-run-break-expected.checksum: Added.
* platform/win/fast/ruby/ruby-run-break-expected.png: Added.
* platform/win/fast/ruby/ruby-run-break-expected.txt: Added.
* platform/win/fast/ruby/ruby-runs-expected.checksum: Added.
* platform/win/fast/ruby/ruby-runs-expected.png: Added.
* platform/win/fast/ruby/ruby-runs-expected.txt: Added.
* platform/win/fast/ruby/ruby-runs-spans-expected.checksum: Added.
* platform/win/fast/ruby/ruby-runs-spans-expected.png: Added.
* platform/win/fast/ruby/ruby-runs-spans-expected.txt: Added.
* platform/win/fast/ruby/ruby-simple-expected.checksum: Added.
* platform/win/fast/ruby/ruby-simple-expected.png: Added.
* platform/win/fast/ruby/ruby-simple-expected.txt: Added.
* platform/win/fast/ruby/ruby-simple-rp-expected.checksum: Added.
* platform/win/fast/ruby/ruby-simple-rp-expected.png: Added.
* platform/win/fast/ruby/ruby-simple-rp-expected.txt: Added.
* platform/win/fast/ruby/ruby-trailing-expected.checksum: Added.
* platform/win/fast/ruby/ruby-trailing-expected.png: Added.
* platform/win/fast/ruby/ruby-trailing-expected.txt: Added.
* platform/win/fast/ruby/rubyDOM-insert-rt-expected.checksum: Added.
* platform/win/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
* platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
* platform/win/fast/ruby/rubyDOM-insert-text1-expected.checksum: Added.
* platform/win/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
* platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
* platform/win/fast/ruby/rubyDOM-insert-text2-expected.checksum: Added.
* platform/win/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
* platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt: Added.
* platform/win/fast/ruby/rubyDOM-insert-text3-expected.checksum: Added.
* platform/win/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
* platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
* platform/win/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Added.
* platform/win/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
* platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
* platform/win/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Added.
* platform/win/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
* platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt: Added.
* platform/win/fast/ruby/rubyDOM-remove-text1-expected.checksum: Added.
* platform/win/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
* platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
* platform/win/fast/ruby/rubyDOM-remove-text2-expected.checksum: Added.
* platform/win/fast/ruby/rubyDOM-remove-text2-expected.png: Added.
* platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-10 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 11 Nov 2009 03:08:27 +0000 (03:08 +0000)]
2009-11-10  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        rename counter to makeCounterNode in RenderCounter.cpp
        https://bugs.webkit.org/show_bug.cgi?id=31289

        No new test because this is just a small refactoring.

        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
        (WebCore::makeCounterNode):
        (WebCore::RenderCounter::originalText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-10 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Wed, 11 Nov 2009 02:52:23 +0000 (02:52 +0000)]
2009-11-10  Daniel Bates  <dbates@webkit.org>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=30754

        Patch 2 of 2.

        Removed method EventHandler::dragSourceMovedTo, since it is no longer
        needed. This method fired a drag event whenever the mouse moved, but
        section 7.9.4 of the HTML 5 spec. defines the drag-and-drop processing
        model independent of when the mouse moves. See "Among other changes..."
        in the change log for patch 1 for more details.

        * WebCore.DragSupport.exp:
        * page/EventHandler.cpp: Removed method EventHandler::dragSourceMovedTo.
        (WebCore::EventHandler::handleDrag): Updated comment about reentrancy issue.
        * page/EventHandler.h:

2009-11-10  Daniel Bates  <dbates@webkit.org>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=30754

        Removed method draggedImage:movedTo:

        * WebView/WebFrame.mm:
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:

2009-11-10  Daniel Bates  <dbates@webkit.org>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=30754

        Modified WebDropSource::QueryContinueDrag so as to not call EventHandler::dragSourceMovedTo.

        * WebDropSource.cpp:
        (WebDropSource::QueryContinueDrag): Removed call to EventHandler::dragSourceMovedTo.

2009-11-10  Daniel Bates  <dbates@webkit.org>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=30754

        Patch 1 of 2.

        As per Section 7.9.4 of the HTML 5 spec. <http://dev.w3.org/html5/spec/Overview.html#drag-and-drop-processing-model>,
        the drag event should always fire before the dragover event.

        In fixing this bug, this patch also makes our drag processing model
        conform to the HTML 5 spec.

        Among the changes, this patch ensures that the drag event isn't fired outside
        of the drag-and-drop processing loop, WebCore::EventHandler::updateDragAndDrop.
        Currently, the drag event is fired whenever the mouse button is down and the OS
        detects the mouse moved. But, as per the spec, the drag event should
        fire approx. every 350ms so long as the mouse button is down.

        Test: fast/events/drag-and-drop-fire-drag-dragover.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::clear):
        (WebCore::EventHandler::canHandleDragAndDropForTarget): Formerly named handleDragAndDropForTarget.
        Modified to determine when we are in the correct instance of EventHandler to service the drag
        and drop operation.
        (WebCore::EventHandler::updateDragAndDrop): Moved code from WebCore::EventHandler::dragSourceMovedTo
        into this method.
        (WebCore::EventHandler::cancelDragAndDrop):
        (WebCore::EventHandler::performDragAndDrop):
        (WebCore::EventHandler::clearDragState):
        * page/EventHandler.h: Added field m_shouldOnlyFireDragOverEvent to determine whether
        we should fire both drag and dragover events or only the dragover event.

2009-11-10  Daniel Bates  <dbates@webkit.org>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=30754

        Tests that the drag event always fires before the dragover event.

        Also, re-bases the result for test fast/events/drag-in-frames.html, since
        we now conform to the HTML 5 spec.

        * fast/events/drag-and-drop-fire-drag-dragover-expected.txt: Added.
        * fast/events/drag-and-drop-fire-drag-dragover.html: Added.
        * fast/events/drag-in-frames-expected.txt: Rebased result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-10 Vitaly Repeshko <vitalyr@chromium.org>
eric@webkit.org [Wed, 11 Nov 2009 02:15:19 +0000 (02:15 +0000)]
2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
        https://bugs.webkit.org/show_bug.cgi?id=31301

        * fast/xpath/xpath-detached-iframe-resolver-crash-expected.txt: Added.
        * fast/xpath/xpath-detached-iframe-resolver-crash.html: Added.
2009-11-10  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
        https://bugs.webkit.org/show_bug.cgi?id=31301

        Tested by new fast/xpath/xpath-detached-iframe-resolver-crash.html.

        Allowed passing V8Proxy for the calling JS context:
        * bindings/v8/V8DOMWrapper.h:
        (WebCore::V8DOMWrapper::getXPathNSResolver):
        * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
        (WebCore::V8CustomXPathNSResolver::create):
        (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
        (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
        * bindings/v8/custom/V8CustomXPathNSResolver.h:
        * bindings/v8/custom/V8DocumentCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-10 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Wed, 11 Nov 2009 02:07:18 +0000 (02:07 +0000)]
2009-11-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Timothy Hatcher.

        Implement URL decomposition IDL attributes for HTMLAnchorElement.
        https://bugs.webkit.org/show_bug.cgi?id=29972

        Testcases for setting and getting different parts of the URL.

        * fast/dom/HTMLAnchorElement: Added.
        * fast/dom/HTMLAnchorElement/script-tests: Added.
        * fast/dom/HTMLAnchorElement/script-tests/TEMPLATE.html: Added.
        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js: Added.
        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js: Added.
        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js: Added.
        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js: Added.
        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-port.js: Added.
        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js: Added.
        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-hash.html: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-host.html: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-port.html: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt: Added.
        * fast/dom/HTMLAnchorElement/set-href-attribute-search.html: Added.
2009-11-10  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Timothy Hatcher.

        Implement URL decomposition IDL attributes for HTMLAnchorElement.
        https://bugs.webkit.org/show_bug.cgi?id=29972.

        Add methods for setting different parts of the URL in href attribute.

        Tests: fast/dom/HTMLAnchorElement/set-href-attribute-hash.html
               fast/dom/HTMLAnchorElement/set-href-attribute-host.html
               fast/dom/HTMLAnchorElement/set-href-attribute-hostname.html
               fast/dom/HTMLAnchorElement/set-href-attribute-pathname.html
               fast/dom/HTMLAnchorElement/set-href-attribute-port.html
               fast/dom/HTMLAnchorElement/set-href-attribute-protocol.html
               fast/dom/HTMLAnchorElement/set-href-attribute-search.html

        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::setPort):
        * html/HTMLAnchorElement.cpp:
        (WebCore::parsePortFromStringPosition):
        (WebCore::HTMLAnchorElement::setHash):
        (WebCore::HTMLAnchorElement::setHost):
        (WebCore::HTMLAnchorElement::setHostname):
        (WebCore::HTMLAnchorElement::setPathname):
        (WebCore::HTMLAnchorElement::setPort):
        (WebCore::HTMLAnchorElement::setProtocol):
        (WebCore::HTMLAnchorElement::setSearch):
        * html/HTMLAnchorElement.h:
        * html/HTMLAnchorElement.idl:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::iconURL):
        * platform/KURL.cpp:
        (WebCore::KURL::removePort):
        (WebCore::KURL::setPort):
        (WebCore::KURL::prettyURL):
        (WebCore::protocolIsValid):
        * platform/KURL.h:
        (WebCore::KURL::canSetHostOrPort):
        (WebCore::KURL::canSetPathname):
        (WebCore::KURL::hasPort):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail...
mrowe@apple.com [Wed, 11 Nov 2009 01:29:33 +0000 (01:29 +0000)]
<webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added

Reviewed by Sam Weinig.

The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
about the validity of the self-signed certificates used in the regression tests.  We would then add the
host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
that had enabled frame load delegate logging this would result in extra log messages being generated,
causing the test to fail.

We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
tests.

* DumpRenderTree/mac/DumpRenderTree.mm:
(dumpRenderTree):
* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate getComputedStyle results for Windows to add -webkit-color-correction.
bweinstein@apple.com [Wed, 11 Nov 2009 01:24:42 +0000 (01:24 +0000)]
Update getComputedStyle results for Windows to add -webkit-color-correction.

* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-10 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 11 Nov 2009 01:14:43 +0000 (01:14 +0000)]
2009-11-10  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium build fix for http://trac.webkit.org/changeset/50760.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::paintBorder):
        (WebCore::PopupListBox::paint):
        (WebCore::PopupListBox::paintRow):
        * platform/graphics/chromium/TransparencyWin.cpp:
        (WebCore::TransparencyWin::setupLayerForWhiteLayer):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::setPlatformFillColor):
        (WebCore::GraphicsContext::setPlatformStrokeColor):
        * rendering/RenderMediaControlsChromium.cpp:
        (WebCore::paintMediaSlider):
        (WebCore::paintMediaVolumeSlider):
        (WebCore::paintMediaTimelineContainer):
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::paintMenuListButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-11-10 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Wed, 11 Nov 2009 00:56:22 +0000 (00:56 +0000)]
2009-11-10  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Modified WebKit.gyp to build the webkit api.

        https://bugs.webkit.org/show_bug.cgi?id=31320

        * README: Added.
        * WebKit.gyp: Added.
        * webkit.gyp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMade a small change to my test then didn't update the results before landing.
beidson@apple.com [Wed, 11 Nov 2009 00:46:08 +0000 (00:46 +0000)]
Made a small change to my test then didn't update the results before landing.

Reviewed by NOBODY (Fix my own layout-test snafu)

* http/tests/webarchive/cross-origin-stylesheet-crash-expected.webarchive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRepro crash saving pcmag.com article as a webarchive.
beidson@apple.com [Tue, 10 Nov 2009 23:36:44 +0000 (23:36 +0000)]
Repro crash saving pcmag.com article as a webarchive.
<rdar://problem/7381219> and https://webkit.org/b/31322

Reviewed by Sam Weinig.

WebCore:

Test: http/tests/webarchive/cross-origin-stylesheet-crash.html

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addSubresourceStyleURLs): Walk the stylesheet itself instead
  of creating a CSSRuleList (and subjecting ourselves to the security origin check)

LayoutTests:

* http/tests/webarchive/cross-origin-stylesheet-crash.html: Added.
* http/tests/webarchive/cross-origin-stylesheet-crash-expected.webarchive: Added.
* http/tests/webarchive/resources/localhost-stylesheet.css: Added.
* platform/gtk/Skipped: Add this test to the gtk Skipped list which tracks all individual skipped tests
  instead of directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Tue, 10 Nov 2009 23:31:59 +0000 (23:31 +0000)]
Reviewed by Kevin Ollivier.

Add sanity checks to RunScript to ensure it doesn't run when the document hasn't yet
loaded nor when JavaScript is disabled.

https://bugs.webkit.org/show_bug.cgi?id=31309

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAttempt 2 to fix Tiger build. No review needed.
bdakin@apple.com [Tue, 10 Nov 2009 23:16:43 +0000 (23:16 +0000)]
Attempt 2 to fix Tiger build. No review needed.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::deviceRGBColorSpaceRef):
(WebCore::sRGBColorSpaceRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Changes needed after r50760.
kevino@webkit.org [Tue, 10 Nov 2009 23:16:05 +0000 (23:16 +0000)]
wx build fix. Changes needed after r50760.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Qt build fix.
ap@apple.com [Tue, 10 Nov 2009 23:03:36 +0000 (23:03 +0000)]
    Qt build fix.

        * platform/network/ResourceHandle.h: Only inherit from AuthenticationClient on platforms
        that use ResourceHandle as a delegate (Mac, CFNetwork, Curl).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTiger build fix. No review needed.
bdakin@apple.com [Tue, 10 Nov 2009 22:52:47 +0000 (22:52 +0000)]
Tiger build fix. No review needed.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::sRGBColorSpaceRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dan Bernstein.
ap@apple.com [Tue, 10 Nov 2009 22:38:08 +0000 (22:38 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=31312
        Decouple authentication panel callbacks from ResourceHandle

        No change in functionality.

        SocketStreamHandle also needs to request credentials, so it's not appropriate to store
        ResourceHandle as delegate.

WebCore:
        * WebCore.vcproj/WebCore.vcproj:
        * platform/network/AuthenticationClient.h: Added.
        Added a new interface for listening to authentication panel notifications.

        * WebCore.xcodeproj/project.pbxproj: Added AuthenticationClient.h. Let Visual Studio do what
        it wants with the project file.

        (WebCore::AuthenticationClient::ref): Using our usual method of exposing refcounting on an
        interface class.
        (WebCore::AuthenticationClient::deref): Ditto.

        * platform/network/ResourceHandle.h:
        (WebCore::ResourceHandle::refAuthenticationClient): Ditto.
        (WebCore::ResourceHandle::derefAuthenticationClient): Ditto.

        * platform/network/cf/AuthenticationCF.cpp:
        (WebCore::AuthenticationChallenge::AuthenticationChallenge):
        (WebCore::AuthenticationChallenge::platformCompare):
        * platform/network/cf/AuthenticationChallenge.h:
        (WebCore::AuthenticationChallenge::authenticationClient):
        * platform/network/chromium/AuthenticationChallenge.h:
        (WebCore::AuthenticationChallenge::authenticationClient):
        * platform/network/curl/AuthenticationChallenge.h:
        (WebCore::AuthenticationChallenge::authenticationClient):
        Keeping a reference to AuthenticationClient, not to ResourceHandle.

WebKit:
        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
        * WebURLAuthenticationChallenge.cpp:
        (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
        (WebURLAuthenticationChallenge::sender):
        * WebURLAuthenticationChallengeSender.cpp:
        (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
        (WebURLAuthenticationChallengeSender::createInstance):
        (WebURLAuthenticationChallengeSender::authenticationClient):
        * WebURLAuthenticationChallengeSender.h:
        * WebURLAuthenticationChallengeSenderCFNet.cpp:
        (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):
        (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):
        (WebURLAuthenticationChallengeSender::useCredential):
        Adjusted for WebCore changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Second attempted gtk build fix. No review needed.
bdakin@apple.com [Tue, 10 Nov 2009 22:35:53 +0000 (22:35 +0000)]
   Second attempted gtk build fix. No review needed.

* html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::applyStrokeColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Tue, 10 Nov 2009 22:28:31 +0000 (22:28 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Anders Carlsson.
bweinstein@apple.com [Tue, 10 Nov 2009 22:22:32 +0000 (22:22 +0000)]
Rubber-stamped by Anders Carlsson.

Add timing out test to Windows Skipped list.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix back/forwards cache with JSC isolated worlds.
barraclough@apple.com [Tue, 10 Nov 2009 22:21:54 +0000 (22:21 +0000)]
Fix back/forwards cache with JSC isolated worlds.
https://bugs.webkit.org/show_bug.cgi?id=31310
<rdar://problem/7328111> Cached back navigation doesn't restore global object in extension isolated world

Patch by Gavin Barraclough <barraclough@apple.com> on 2009-11-10
Reviewed by Geoff Garen.

Store the global object for all worlds, not just the normal world.
Also maintain bidirectional weak references between the ScriptCachedFrameData and the DOMWrapperWorld,
so we can forget global objects if a world goes away.

* bindings/js/JSDOMBinding.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
* bindings/js/JSDOMBinding.h:
(WebCore::DOMWrapperWorld::rememberScriptCachedFrameData):
(WebCore::DOMWrapperWorld::forgetScriptCachedFrameData):
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::forgetWorld):
(WebCore::ScriptCachedFrameData::domWindow):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):
* bindings/js/ScriptCachedFrameData.h:
* bindings/js/ScriptController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50767 268f45cc-cd09-0410-ab3c-d52691b4dbfc