WebKit-https.git
8 years ago[GTK] remove bashism from configure
zandobersek@gmail.com [Thu, 20 Jun 2013 19:32:36 +0000 (19:32 +0000)]
[GTK] remove bashism from configure
https://bugs.webkit.org/show_bug.cgi?id=117796

Reviewed by Gustavo Noronha Silva.

* Source/autotools/FindDependencies.m4: Perform string appending by redeclaring the base string to the value
of the base string followed by the string that's being appended. This replaces the use of the '+=' operator
that works under bash but is not supported by other shells.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark compositing/repaint/positioned-movement.html as flaky on Mountain Lion Debug
benjamin@webkit.org [Thu, 20 Jun 2013 19:16:31 +0000 (19:16 +0000)]
Mark compositing/repaint/positioned-movement.html as flaky on Mountain Lion Debug

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-20

* platform/mac-wk2/TestExpectations:
The test fails regularly in Debug on Mountain Lion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] REGRESSION(r151737): fast/replaced/width100percent-image.html fails
robert@webkit.org [Thu, 20 Jun 2013 19:10:08 +0000 (19:10 +0000)]
[Qt][WK2] REGRESSION(r151737): fast/replaced/width100percent-image.html fails
https://bugs.webkit.org/show_bug.cgi?id=117824

Unreviewed, rebaselining.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
* platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r151451): Text not vertically centered correctly on icloud.com
robert@webkit.org [Thu, 20 Jun 2013 18:58:42 +0000 (18:58 +0000)]
REGRESSION (r151451): Text not vertically centered correctly on icloud.com
https://bugs.webkit.org/show_bug.cgi?id=117744

Reviewed by David Hyatt.

Source/WebCore:

The positioned height and width computation adds in the element's border and padding so
don't add it to the intrinsic height and preferred widths of text controls that are
absolutely positioned.

Test: fast/replaced/height-of-positioned-text-control.html

* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

* fast/forms/onselect-textfield-expected.txt:
* fast/replaced/height-of-positioned-text-control-expected.html: Added.
* fast/replaced/height-of-positioned-text-control.html: Added.
* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
* platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
* platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
* platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt:
* platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake Windows makefile copy build output to a different folder.
roger_fong@apple.com [Thu, 20 Jun 2013 18:55:36 +0000 (18:55 +0000)]
Make Windows makefile copy build output to a different folder.
<rdar://problem/14219184>.

* WTF.vcxproj/WTF.make:
* JavaScriptCore.vcxproj/JavaScriptCore.make:
* WebCore.vcxproj/WebCore.make:
* WebKit.vcxproj/WebKit.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImproper deallocation of JSManagedValue causes crashes during autorelease pool draining
mhahnenberg@apple.com [Thu, 20 Jun 2013 18:36:27 +0000 (18:36 +0000)]
Improper deallocation of JSManagedValue causes crashes during autorelease pool draining
https://bugs.webkit.org/show_bug.cgi?id=117840

Reviewed by Geoffrey Garen.

Improperly managing a JSManagedValue can cause a crash when the JSC::Weak inside the
JSManagedValue is destroyed upon deallocation. We would rather have improperly maintained
JSManagedValues cause memory leaks than take down the whole app.

The fix is to use the callback to the JSC::Weak on the destruction of the VM so that we
can safely null it out. This will prevent ~Weak from crashing.

* API/JSManagedValue.mm:
(-[JSManagedValue JSC::JSC::]):
(JSManagedValueHandleOwner::finalize):
* API/tests/testapi.mm: Added a test that crashed prior to this fix due to a leaked
managed reference. Also fixed a small style nit I noticed in another test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll-on in-band captions are displayed bottom-to-top rather than top-to-bottom.
jer.noble@apple.com [Thu, 20 Jun 2013 18:24:08 +0000 (18:24 +0000)]
Roll-on in-band captions are displayed bottom-to-top rather than top-to-bottom.
https://bugs.webkit.org/show_bug.cgi?id=117811

Reviewed by Eric Carlson.

When comparing Generic cues, we should check that their type is Generic, not WebVTT.

* html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::isOrderedBefore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
commit-queue@webkit.org [Thu, 20 Jun 2013 18:07:48 +0000 (18:07 +0000)]
[CMake][CSS Shaders] Add WebCore files for CSS Shaders to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=117711

Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-20
Reviewed by Laszlo Gombos.

No new tests, no CMake platforms currently enable this functionality.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup usage of CSSPropertyID and CSSValueID inside WebKit.
alexis@webkit.org [Thu, 20 Jun 2013 18:04:52 +0000 (18:04 +0000)]
Cleanup usage of CSSPropertyID and CSSValueID inside WebKit.
https://bugs.webkit.org/show_bug.cgi?id=117829

Reviewed by Andreas Kling.

A lot of call sites were using integers to represent them. While it's
not incorrect per se, it's not ideal for various reason such as type
safety or to remove ambiguity.

This patch eradicate the wrong usage by not letting any integer based
API for getting CSSValueIDs or CSSPropertyIDs from CSSPrimitiveValues.

Instead we use new but typed functions to construct the values as well
as getting them. Two customs and internal types were added to CSSPrimitiveValue
to handle correctly the new APIs.

It's good to note that in order to preserve compatibility on the
CSSPrimitiveValue type whenever CSSPrimitiveValue handles a CSSValueID
or a CSSPropertyID the return type for the public API will be CSS_IDENT
despite it is a separate internal type.

No new tests: refactor, existing tests should cover.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyMatches):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSGradientValue.cpp:
(WebCore::positionFromValue):
(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::customCssText):
(WebCore::CSSRadialGradientValue::createGradient):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseSystemColor):
(WebCore::isFillPositionKeyword):
(WebCore::CSSParser::parse4ValuesFillPosition):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isBlendMode):
(WebCore::CSSParser::isCompositeOperator):
* css/CSSParser.h:
* css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::propertyName):
(WebCore::valueName):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isValueID):
(WebCore::CSSPrimitiveValue::createIdentifier):
(WebCore::CSSPrimitiveValue::createParserOperator):
(WebCore::CSSPrimitiveValue::getPropertyID):
(WebCore::CSSPrimitiveValue::getValueID):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CSSReflectionDirection):
(WebCore::CSSPrimitiveValue::operator ColumnSpan):
(WebCore::CSSPrimitiveValue::operator PrintColorAdjust):
(WebCore::CSSPrimitiveValue::operator EBorderStyle):
(WebCore::CSSPrimitiveValue::operator OutlineIsAuto):
(WebCore::CSSPrimitiveValue::operator CompositeOperator):
(WebCore::CSSPrimitiveValue::operator ControlPart):
(WebCore::CSSPrimitiveValue::operator EBackfaceVisibility):
(WebCore::CSSPrimitiveValue::operator EFillAttachment):
(WebCore::CSSPrimitiveValue::operator EFillBox):
(WebCore::CSSPrimitiveValue::operator EFillRepeat):
(WebCore::CSSPrimitiveValue::operator EBoxPack):
(WebCore::CSSPrimitiveValue::operator EBoxAlignment):
(WebCore::CSSPrimitiveValue::operator EBoxDecorationBreak):
(WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin):
(WebCore::CSSPrimitiveValue::operator EBoxSizing):
(WebCore::CSSPrimitiveValue::operator EBoxDirection):
(WebCore::CSSPrimitiveValue::operator EBoxLines):
(WebCore::CSSPrimitiveValue::operator EBoxOrient):
(WebCore::CSSPrimitiveValue::operator ECaptionSide):
(WebCore::CSSPrimitiveValue::operator EClear):
(WebCore::CSSPrimitiveValue::operator ECursor):
(WebCore::CSSPrimitiveValue::operator CursorVisibility):
(WebCore::CSSPrimitiveValue::operator EDisplay):
(WebCore::CSSPrimitiveValue::operator EEmptyCell):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EFlexDirection):
(WebCore::CSSPrimitiveValue::operator EAlignContent):
(WebCore::CSSPrimitiveValue::operator EFlexWrap):
(WebCore::CSSPrimitiveValue::operator EFloat):
(WebCore::CSSPrimitiveValue::operator LineBreak):
(WebCore::CSSPrimitiveValue::operator EListStylePosition):
(WebCore::CSSPrimitiveValue::operator EListStyleType):
(WebCore::CSSPrimitiveValue::operator EMarginCollapse):
(WebCore::CSSPrimitiveValue::operator EMarqueeBehavior):
(WebCore::CSSPrimitiveValue::operator RegionFragment):
(WebCore::CSSPrimitiveValue::operator EMarqueeDirection):
(WebCore::CSSPrimitiveValue::operator ENBSPMode):
(WebCore::CSSPrimitiveValue::operator EOverflow):
(WebCore::CSSPrimitiveValue::operator EPageBreak):
(WebCore::CSSPrimitiveValue::operator EPosition):
(WebCore::CSSPrimitiveValue::operator EResize):
(WebCore::CSSPrimitiveValue::operator ETableLayout):
(WebCore::CSSPrimitiveValue::operator ETextAlign):
(WebCore::CSSPrimitiveValue::operator TextAlignLast):
(WebCore::CSSPrimitiveValue::operator TextJustify):
(WebCore::CSSPrimitiveValue::operator TextDecoration):
(WebCore::CSSPrimitiveValue::operator TextDecorationStyle):
(WebCore::CSSPrimitiveValue::operator TextUnderlinePosition):
(WebCore::CSSPrimitiveValue::operator ETextSecurity):
(WebCore::CSSPrimitiveValue::operator ETextTransform):
(WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
(WebCore::CSSPrimitiveValue::operator EUserDrag):
(WebCore::CSSPrimitiveValue::operator EUserModify):
(WebCore::CSSPrimitiveValue::operator EUserSelect):
(WebCore::CSSPrimitiveValue::operator EVerticalAlign):
(WebCore::CSSPrimitiveValue::operator EVisibility):
(WebCore::CSSPrimitiveValue::operator EWhiteSpace):
(WebCore::CSSPrimitiveValue::operator EWordBreak):
(WebCore::CSSPrimitiveValue::operator EOverflowWrap):
(WebCore::CSSPrimitiveValue::operator TextDirection):
(WebCore::CSSPrimitiveValue::operator WritingMode):
(WebCore::CSSPrimitiveValue::operator TextCombine):
(WebCore::CSSPrimitiveValue::operator RubyPosition):
(WebCore::CSSPrimitiveValue::operator TextEmphasisPosition):
(WebCore::CSSPrimitiveValue::operator TextOverflow):
(WebCore::CSSPrimitiveValue::operator TextEmphasisFill):
(WebCore::CSSPrimitiveValue::operator TextEmphasisMark):
(WebCore::CSSPrimitiveValue::operator TextOrientation):
(WebCore::CSSPrimitiveValue::operator EPointerEvents):
(WebCore::CSSPrimitiveValue::operator FontDescription::Kerning):
(WebCore::CSSPrimitiveValue::operator FontSmoothingMode):
(WebCore::CSSPrimitiveValue::operator FontWeight):
(WebCore::CSSPrimitiveValue::operator FontItalic):
(WebCore::CSSPrimitiveValue::operator FontSmallCaps):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
(WebCore::CSSPrimitiveValue::operator ColorSpace):
(WebCore::CSSPrimitiveValue::operator Hyphens):
(WebCore::CSSPrimitiveValue::operator LineSnap):
(WebCore::CSSPrimitiveValue::operator LineAlign):
(WebCore::CSSPrimitiveValue::operator Order):
(WebCore::CSSPrimitiveValue::operator ESpeak):
(WebCore::CSSPrimitiveValue::operator BlendMode):
(WebCore::CSSPrimitiveValue::operator LineCap):
(WebCore::CSSPrimitiveValue::operator LineJoin):
(WebCore::CSSPrimitiveValue::operator WindRule):
(WebCore::CSSPrimitiveValue::operator EAlignmentBaseline):
(WebCore::CSSPrimitiveValue::operator EBorderCollapse):
(WebCore::CSSPrimitiveValue::operator EBorderFit):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
(WebCore::CSSPrimitiveValue::operator ETransformStyle3D):
(WebCore::CSSPrimitiveValue::operator ColumnAxis):
(WebCore::CSSPrimitiveValue::operator ColumnProgression):
(WebCore::CSSPrimitiveValue::operator WrapFlow):
(WebCore::CSSPrimitiveValue::operator WrapThrough):
(WebCore::CSSPrimitiveValue::operator GridAutoFlow):
(WebCore::CSSPrimitiveValue::convertToLength):
(WebCore::CSSPrimitiveValue::operator EBufferedRendering):
(WebCore::CSSPrimitiveValue::operator EColorInterpolation):
(WebCore::CSSPrimitiveValue::operator EColorRendering):
(WebCore::CSSPrimitiveValue::operator EDominantBaseline):
(WebCore::CSSPrimitiveValue::operator EShapeRendering):
(WebCore::CSSPrimitiveValue::operator ETextAnchor):
(WebCore::CSSPrimitiveValue::operator SVGWritingMode):
(WebCore::CSSPrimitiveValue::operator EVectorEffect):
(WebCore::CSSPrimitiveValue::operator EMaskType):
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
* css/Counter.h:
(WebCore::Counter::listStyleIdent):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::getPageSizeFromName):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
* css/MediaQueryEvaluator.cpp:
(WebCore::orientationMediaFeatureEval):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
* css/StyleResolver.cpp:
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::colorForCSSValue):
(WebCore::StyleResolver::colorFromPrimitiveValueIsDerivedFromElement):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
* css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
* editing/ApplyStyleCommand.cpp:
(WebCore::toIdentifier):
* editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::create):
(WebCore::HTMLElementEquivalent::HTMLElementEquivalent):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::HTMLTextDecorationEquivalent::create):
(WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::fontWeightIsBold):
(WebCore::legacyFontSizeFromCSSValue):
(WebCore::isTransparentColorValue):
* editing/EditingStyle.h:
* editing/markup.cpp:
(WebCore::propertyMissingOrEqualToNone):
* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::systemFont):
* platform/blackberry/RenderThemeBlackBerry.h:
(WebCore::RenderThemeBlackBerry::systemFont):
* platform/blackberry/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::systemFont):
* platform/blackberry/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::systemFont):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::systemFont):
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::systemColor):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::systemColor):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::systemColor):
* platform/qt/RenderThemeQt.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::systemColor):
* rendering/RenderTheme.h:
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemFont):
(WebCore::RenderThemeMac::systemColor):
* rendering/RenderThemeSafari.h:
(WebCore::RenderThemeSafari::systemFont):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::systemFont):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::systemFont):
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWin::systemColor):
* rendering/RenderThemeWin.h:
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::systemFont):
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWinCE::systemColor):
* rendering/RenderThemeWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
commit-queue@webkit.org [Thu, 20 Jun 2013 17:14:32 +0000 (17:14 +0000)]
[BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
https://bugs.webkit.org/show_bug.cgi?id=117827

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-06-20
Reviewed by Rob Buis.

Source/WebKit/blackberry:

Add DumpRenderTreeClient::willSendRequestForFrame() to handle
dispatchWillSendRequest() in DRT.

Fixes tests
fast/loader/onload-willSendRequest-null-for-script.html and
fast/loader/willSendRequest-null-for-preload.html.

* Api/DumpRenderTreeClient.h:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):

Tools:

Reset the passed in request if willSendRequestReturnsNull() is
true or willSendRequestReturnsNullOnRedirect() is true and it's a
redirection.

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
* DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCommit queue shouldn't reopen unrelated bugs because of flakiness
ossy@webkit.org [Thu, 20 Jun 2013 16:59:54 +0000 (16:59 +0000)]
Commit queue shouldn't reopen unrelated bugs because of flakiness
https://bugs.webkit.org/show_bug.cgi?id=117503

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/tool/bot/flakytestreporter.py:
(_follow_duplicate_chain):
(_update_bug_for_flaky_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: List Items should support a default action
bfulgham@apple.com [Thu, 20 Jun 2013 16:16:02 +0000 (16:16 +0000)]
AX: List Items should support a default action
https://bugs.webkit.org/show_bug.cgi?id=117812

Reviewed by Chris Fleizach.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::actionVerb): Provide a "select" verb
for use in ListItemRole objects.
* platform/LocalizedStrings.cpp:
(WebCore::AXListItemActionVerb): Added.
* platform/LocalizedStrings.h:
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::AXListItemActionVerb):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXListItemActionVerb):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXListItemActionVerb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Regions] Add new regionOversetChange event
commit-queue@webkit.org [Thu, 20 Jun 2013 16:13:11 +0000 (16:13 +0000)]
[CSS Regions] Add new regionOversetChange event
https://bugs.webkit.org/show_bug.cgi?id=117508

Source/WebCore:

Added regionOversetChange event and tests for it. The overset value of the region has been moved to the ElementRareData
object instead of the RenderRegion object. This was needed for the case when a reattach is performed (for instance by changing
the display type of the region's containing block) and the RenderRegion object is destroyed. When computing the overset again,
there would be no "previous" value to compare it to and decide whether the regionOversetChange event must be dispatched.

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-20
Reviewed by Antti Koivisto.

Tests:  fast/regions/webkit-named-flow-event-add-to-flow.html:
        fast/regions/webkit-named-flow-event-auto-height.html:
        fast/regions/webkit-named-flow-event-crash.html:
        fast/regions/webkit-named-flow-event-no-regions.html:
        fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Added.
        fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html: Added.
        fast/regions/webkit-named-flow-event-remove-from-dom.html:
        fast/regions/webkit-named-flow-event-remove-from-flow.html:
        fast/regions/webkit-named-flow-event-target.html:
        fast/regions/webkit-named-flow-event-to-null.html:
        fast/regions/webkit-named-flow-event.html:

* GNUmakefile.list.am:
* Target.pri:
* WebCore.xcodeproj/project.pbxproj:
* dom/Element.cpp:
(WebCore::Element::setRegionOversetState):
(WebCore::Element::regionOversetState):
(WebCore::Element::webkitRegionOverset):
* dom/Element.h:
* dom/ElementRareData.cpp:
* dom/ElementRareData.h:
(WebCore::ElementRareData::regionOversetState):
(WebCore::ElementRareData::setRegionOversetState):
(WebCore::ElementRareData::ElementRareData):
* dom/EventNames.h:
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore::WebKitNamedFlow::dispatchRegionOversetChangeEvent):
* dom/WebKitNamedFlow.h:
(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::scheduleFor):
(WebCore::ChangeRegionOversetTask::unschedule):
(WebCore::ChangeRegionOversetTask::reset):
(WebCore::ChangeRegionOversetTask::onTimer):
* rendering/RegionOversetState.h: Added.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeOversetStateForRegions):
* rendering/RenderFlowThread.h:
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):
(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):
* rendering/RenderNamedFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):
* rendering/RenderRegion.h:

LayoutTests:

Changed regionLayoutUpdate tests to regionOversetChange and added new tests for regionOversetChange.

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-20
Reviewed by Antti Koivisto.

* fast/regions/webkit-named-flow-event-add-to-flow-expected.txt:
* fast/regions/webkit-named-flow-event-add-to-flow.html:
* fast/regions/webkit-named-flow-event-auto-height-expected.txt:
* fast/regions/webkit-named-flow-event-auto-height.html: Added.
* fast/regions/webkit-named-flow-event-crash-expected.txt:
* fast/regions/webkit-named-flow-event-crash.html:
* fast/regions/webkit-named-flow-event-expected.txt:
* fast/regions/webkit-named-flow-event-no-regions-expected.txt:
* fast/regions/webkit-named-flow-event-no-regions.html:
* fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change-expected.txt:
* fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Added.
* fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change-expected.txt:
* fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html: Added.
* fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt:
* fast/regions/webkit-named-flow-event-remove-from-dom.html:
* fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt:
* fast/regions/webkit-named-flow-event-remove-from-flow.html:
* fast/regions/webkit-named-flow-event-target-expected.txt:
* fast/regions/webkit-named-flow-event-target.html:
* fast/regions/webkit-named-flow-event-to-null-expected.txt:
* fast/regions/webkit-named-flow-event-to-null.html:
* fast/regions/webkit-named-flow-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: aria-required is not exposed on all expected roles
commit-queue@webkit.org [Thu, 20 Jun 2013 16:08:05 +0000 (16:08 +0000)]
AX: aria-required is not exposed on all expected roles
https://bugs.webkit.org/show_bug.cgi?id=115123

Patch by James Craig <james@cookiecrook.com> on 2013-06-20
Reviewed by Chris Fleizach.

aria-required is now exposed on more roles. Updated existing test file.

Source/WebCore:

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute):
* accessibility/AccessibilityNodeObject.h:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::supportsRequiredAttribute):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):

LayoutTests:

* platform/mac/accessibility/aria-required-expected.txt:
* platform/mac/accessibility/aria-required.html:
* platform/mac/accessibility/radio-button-group-members-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Update text checker documentation.
g.czajkowski@samsung.com [Thu, 20 Jun 2013 14:11:19 +0000 (14:11 +0000)]
[EFL][WK2] Update text checker documentation.
https://bugs.webkit.org/show_bug.cgi?id=117828

Reviewed by Christophe Dumez.

* UIProcess/API/efl/ewk_text_checker.h:
The client is not responsible for destroying the memory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Use console.timeStamp instead of console.markTimeline
commit-queue@webkit.org [Thu, 20 Jun 2013 13:21:56 +0000 (13:21 +0000)]
Web Inspector: Use console.timeStamp instead of console.markTimeline
https://bugs.webkit.org/show_bug.cgi?id=117810

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-06-20
Reviewed by Joseph Pecoraro.

Source/WebCore:

Webkit supports both console.timeStamp and console.markTimeline.
And they do the exact same thing.
This patch gets rid of console.markTimeline for Chrome/Firebug compatibility.

No new functionality, no new tests.

* WebCore.order:
* page/Console.cpp:
* page/Console.h:
* page/Console.idl:

LayoutTests:

Use 'console.timeStamp' instead of 'console.markTimeline' in LayoutTests.
And remove inspector/timeline/timeline-mark-timeline.html.

* inspector/console/console-messages-stack-traces-expected.txt:
* inspector/console/console-messages-stack-traces.html:
* inspector/timeline/timeline-mark-timeline-expected.txt: Removed.
* inspector/timeline/timeline-mark-timeline.html: Removed.
* inspector/timeline/timeline-timer-fired-from-eval-call-site.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Thu, 20 Jun 2013 08:22:10 +0000 (08:22 +0000)]
[Qt] Unreviewed gardening.

Rebselining after r151761, see bug 115372.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-parent-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/horizontal-bt-overflow-same-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/vertical-overflow-child-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/vertical-overflow-parent-expected.txt: Added.
* platform/qt-5.0-wk2/fast/repaint/vertical-overflow-same-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agobackground-color and text-decoration are not preserved when merging paragraphs
g.czajkowski@samsung.com [Thu, 20 Jun 2013 07:39:43 +0000 (07:39 +0000)]
background-color and text-decoration are not preserved when merging paragraphs
https://bugs.webkit.org/show_bug.cgi?id=116215

Reviewed by Ryosuke Niwa.

Source/WebCore:

In mergeInlineAndImplicitStyleOfElement(), style from matched rules are retrieved.
If they contain either background-color or text-decoration they will be removed
by removeNonEditingProperties() due to copyEditingProperties() implicit
'OnlyInheritableEditingProperties' parameter.
We have already had similar issue at https://bugs.webkit.org/show_bug.cgi?id=53196

Tests: editing/deleting/merge-div-from-span-with-style.html
       editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html
       editing/deleting/merge-paragraph-from-span-with-style.html

* editing/EditingStyle.cpp:
(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
Add EditingStyle:: due to move EditingPropertiesToInclude to EditingStyle.h.

(WebCore::toEditingProperties):
Add a helper to easy convert PropertiesToInclude to EditingPropertiesToInclude,
needed in mergeInlineAndImplicitStyleOfElement().

(WebCore::EditingStyle::removeAllButEditingProperties):
Add a parameter to choose which editing properties should be preserved while
removing all properties (OnlyInheritableEditingProperties implicite).

(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
Call removeAllButEditingProperties with parameter.

* editing/EditingStyle.h:
Move EditingPropertiesType to the header as it's needed by removeAllButEditingProperties().
Change EditingPropertiesType to EditingPropertiesToInclude to be consistent with
PropertiesToInclude.
Change removeNonEditingProperties() to removeAllButEditingProperties().

LayoutTests:

Added tests for verifying merge of paragraph/div from span with non-inline styles.

* editing/deleting/merge-div-from-span-with-style-expected.txt: Added.
* editing/deleting/merge-div-from-span-with-style.html: Added.
* editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration-expected.txt: Added.
* editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration.html: Added.
* editing/deleting/merge-paragraph-from-span-with-style-expected.txt: Added.
* editing/deleting/merge-paragraph-from-span-with-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe order of the generated supplemental code is not guaranteed
ch.dumez@sisa.samsung.com [Thu, 20 Jun 2013 05:44:42 +0000 (05:44 +0000)]
The order of the generated supplemental code is not guaranteed
https://bugs.webkit.org/show_bug.cgi?id=117820

Reviewed by Kentaro Hara.

Sort the supplemental idl files before generating the code so that it is
generated in a consistent order.

No new tests, covered by existing bindings tests.

* bindings/scripts/generate-bindings.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r151769.
commit-queue@webkit.org [Thu, 20 Jun 2013 05:39:01 +0000 (05:39 +0000)]
Unreviewed, rolling out r151769.
http://trac.webkit.org/changeset/151769
https://bugs.webkit.org/show_bug.cgi?id=117821

Broke windows build due to missing GL/glext.h header.
(Requested by bfulgham on #webkit).

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded WebGL files to Windows build without enabling them.
commit-queue@webkit.org [Thu, 20 Jun 2013 05:06:01 +0000 (05:06 +0000)]
Added WebGL files to Windows build without enabling them.
https://bugs.webkit.org/show_bug.cgi?id=117809

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2013-06-19
Reviewed by Brent Fulgham.

* WebCore.vcxproj/WebCore.vcxproj: Added WebGL source files.
* WebCore.vcxproj/WebCore.vcxproj.filters: Added platform\graphics\opengl and platform\graphics\gpu filters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build should include WebGL generated files if WebGL is enabled.
achristensen@apple.com [Thu, 20 Jun 2013 05:04:28 +0000 (05:04 +0000)]
Windows build should include WebGL generated files if WebGL is enabled.
https://bugs.webkit.org/show_bug.cgi?id=117802

Reviewed by Brent Fulgham.

Added WebGL generated files to Windows build if WebGL is enabled.
* DerivedSources.cpp:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExpose plug-ins CFBundleShortVersionString in the WKPluginInformation dictionary
weinig@apple.com [Thu, 20 Jun 2013 04:30:32 +0000 (04:30 +0000)]
Expose plug-ins CFBundleShortVersionString in the WKPluginInformation dictionary
https://bugs.webkit.org/show_bug.cgi?id=117816

Reviewed by Geoffrey Garen.

- Adds a new key for the WKPluginInformation dictionary: WKPluginInformationBundleShortVersionKey().

* Shared/API/c/WKPluginInformation.cpp:
(WKPluginInformationBundleShortVersionKey):
* Shared/API/c/WKPluginInformation.h:
* Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::pluginInformationBundleShortVersionKey):
* Shared/Plugins/Netscape/PluginInformation.h:
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::getPluginInfo):
* Shared/Plugins/Netscape/mac/PluginInformationMac.mm:
(WebKit::getPlatformPluginModuleInformation):
* Shared/Plugins/PluginModuleInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding a Mac pixel result.
bdakin@apple.com [Thu, 20 Jun 2013 04:22:50 +0000 (04:22 +0000)]
Adding a Mac pixel result.

* platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Unreviewed AX test expecation gardening.
bfulgham@apple.com [Thu, 20 Jun 2013 04:20:20 +0000 (04:20 +0000)]
[Windows] Unreviewed AX test expecation gardening.

* platform/win/accessibility/aria-labelledby-on-input-expected.txt: Added.
* platform/win/accessibility/aria-list-and-listitem-expected.txt: Added.
* platform/win/accessibility/aria-roles-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] AX: Expand notification support.
bfulgham@apple.com [Thu, 20 Jun 2013 04:14:43 +0000 (04:14 +0000)]
[Windows] AX: Expand notification support.
https://bugs.webkit.org/show_bug.cgi?id=117761

Reviewed by Anders Carlsson.

* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::isPressActionSupported): Provide implementation.
(AccessibilityUIElement::press): Provide implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnskip feSpecularLight-premultiplied.svg on Mountain Lion
benjamin@webkit.org [Thu, 20 Jun 2013 02:35:58 +0000 (02:35 +0000)]
Unskip feSpecularLight-premultiplied.svg on Mountain Lion

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-19

* platform/mac/TestExpectations:
The test is failing on Lion exclusively.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [Mac] Common crashes when playing media
ap@apple.com [Thu, 20 Jun 2013 02:18:07 +0000 (02:18 +0000)]
    [Mac] Common crashes when playing media
        https://bugs.webkit.org/show_bug.cgi?id=117813
        <rdar://problem/13837412>

        Reviewed by Eric Carlson.

        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
        (-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):
        This method may be called from a secondary thread, but it does things that are
        not thread safe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncomplete repaint of input elements in writing-mode overflow
commit-queue@webkit.org [Thu, 20 Jun 2013 01:06:22 +0000 (01:06 +0000)]
Incomplete repaint of input elements in writing-mode overflow
https://bugs.webkit.org/show_bug.cgi?id=110246

Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-06-19
Reviewed by Simon Fraser.

Source/WebCore:

We calculate repaint rect using unflipped rect.
However, RenderBox::applyCachedClipAndScrollOffsetForRepaint() which is called from repaint rect calculation
wants that its argument rect is flipped.
The reason is:
- paintRect.move(-scrolledContentOffset()); cannot scroll if the rect is unflipped.
- It cannot clip using intersect.
Passing unflipped rect to applyCachedClipAndScrollOffsetForRepaint() cause invalid clipping.
Therefore, this patch flipped the rect at the first part of the function and unflipped it at the last part of the function.

Scroll bar rect is absolute rect, so it is flipped rect.
RenderLayer::invalidateScrollbarRect() pass the rect to repaintRectangle() which expects an argument rect is unflipped.
This cause part of overlapping scroll bar doesn't fade out.
Therefore, this patch flipped the rect and pass it to repaintRectangle().

Tests: fast/repaint/horizontal-bt-overflow-child.html
       fast/repaint/horizontal-bt-overflow-parent.html
       fast/repaint/horizontal-bt-overflow-same.html
       fast/repaint/vertical-overflow-child.html
       fast/repaint/vertical-overflow-parent.html
       fast/repaint/vertical-overflow-same.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::invalidateScrollbarRect):

LayoutTests:

* fast/repaint/horizontal-bt-overflow-child-expected.txt: Added.
* fast/repaint/horizontal-bt-overflow-child.html: Added.
* fast/repaint/horizontal-bt-overflow-parent-expected.txt: Added.
* fast/repaint/horizontal-bt-overflow-parent.html: Added.
* fast/repaint/horizontal-bt-overflow-same-expected.txt: Added.
* fast/repaint/horizontal-bt-overflow-same.html: Added.
* fast/repaint/vertical-overflow-child-expected.txt: Added.
* fast/repaint/vertical-overflow-child.html: Added.
* fast/repaint/vertical-overflow-parent-expected.txt: Added.
* fast/repaint/vertical-overflow-parent.html: Added.
* fast/repaint/vertical-overflow-same-expected.txt: Added.
* fast/repaint/vertical-overflow-same.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/14197983> Rename functions from Bug 117667 and add safeguards for...
timothy_horton@apple.com [Thu, 20 Jun 2013 00:10:38 +0000 (00:10 +0000)]
<rdar://problem/14197983> Rename functions from Bug 117667 and add safeguards for !ENABLE(VIDEO) platforms (117765)
https://bugs.webkit.org/show_bug.cgi?id=117765

Patch by Ruth Fong <ruth_fong@apple.com>.
Reviewed by Brady Eidson.

* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultGetMediaType): Updated to use mediaType().

* WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::mediaType): Updated.
Renamed getMediaType() to mediaType() and now handles !ENABLE(VIDEO) platforms.

* WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnskip two canvas tests that only fail on Lion
benjamin@webkit.org [Wed, 19 Jun 2013 23:37:38 +0000 (23:37 +0000)]
Unskip two canvas tests that only fail on Lion

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-19

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline 24bit-22khz-resample on Mac
benjamin@webkit.org [Wed, 19 Jun 2013 23:17:14 +0000 (23:17 +0000)]
Rebaseline 24bit-22khz-resample on Mac

The result did not match the expectation after a system update.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-19

* platform/mac-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav:
Comparing the files, they have the exact same length, sample rate, bit per sample and binary size.
I cannot ear a difference in the files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse the PlatformEvent timestamp when creating a DOM Event
benjamin@webkit.org [Wed, 19 Jun 2013 22:41:17 +0000 (22:41 +0000)]
Use the PlatformEvent timestamp when creating a DOM Event
https://bugs.webkit.org/show_bug.cgi?id=117179

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-19
Reviewed by Darin Adler.

Source/WebCore:

Previously, the platform event's timestamp was ignored by WebCore and each
new event would get a new timestamp by calling WTF::currentTime().

The problem is there can be a significant delay between the input event and
it being dispatched to JavaScript. Computing the velocity/acceleration of the cursor
is impossible since the delay vary from event to events.
On WebKit2, the delay per event typically vary between 0 and 30ms.

This patch changes the Event creation code to use the timer passed by the underlying platform event.

* WebCore.exp.in:
* dom/Event.cpp:
(WebCore::Event::Event):
* dom/Event.h:
* dom/GestureEvent.cpp:
(WebCore::GestureEvent::create):
(WebCore::GestureEvent::GestureEvent):
* dom/GestureEvent.h:
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
* dom/KeyboardEvent.h:
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
* dom/MouseEvent.h:
* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
* dom/MouseRelatedEvent.h:
* dom/TouchEvent.cpp:
(WebCore::TouchEvent::TouchEvent):
* dom/UIEvent.cpp:
(WebCore::UIEvent::UIEvent):
* dom/UIEvent.h:
* dom/UIEventWithKeyState.h:
(WebCore::UIEventWithKeyState::UIEventWithKeyState):
* dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
* dom/WheelEvent.h:
(WebCore::WheelEvent::create):
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
* platform/mac/PlatformEventFactoryMac.mm:
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebCore::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

Source/WebKit/mac:

* WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Source/WebKit2:

* Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebGestureEvent):

Tools:

* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::keyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed reviewer name
ggaren@apple.com [Wed, 19 Jun 2013 22:28:34 +0000 (22:28 +0000)]
Fixed reviewer name

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the SegmentedVector inline segment to shrink CodeBlock by 6X
ggaren@apple.com [Wed, 19 Jun 2013 22:27:47 +0000 (22:27 +0000)]
Remove the SegmentedVector inline segment to shrink CodeBlock by 6X
https://bugs.webkit.org/show_bug.cgi?id=117808

Reviewed by Geoffrey Garen.

SegmentedVector allocation isn't super hot, but we do tend to have many
live SegmentedVectors at runtime, particularly in CodeBlocks, so the
right tradeoff is to allocate segments out-of-line as needed.

This reduces startup memory usage @ google.com by about 6MB.

No regression on SunSpider.

* wtf/SegmentedVector.h:
(WTF::SegmentedVector::SegmentedVector):
(WTF::SegmentedVector::at):
(WTF::SegmentedVector::append):
(WTF::SegmentedVector::removeLast):
(WTF::SegmentedVector::clear):
(WTF::SegmentedVector::deleteAllSegments): No more inline segment.

(WTF::SegmentedVector::ensureSegmentsFor): This code used to assume
that there was always a 0 segment, so the math would underflow if there
were no 0 segment. I udpated the math to account for having no segments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake sure to use CSSValueID and CSSPropertyID rather than integers
alexis@webkit.org [Wed, 19 Jun 2013 22:07:23 +0000 (22:07 +0000)]
Make sure to use CSSValueID and CSSPropertyID rather than integers
https://bugs.webkit.org/show_bug.cgi?id=117481

Reviewed by Benjamin Poulain.

This will ensure that types are enforced when passing arguments in various
css functions. Having a compile time check make sure that no mistakes
will be done over the type.

The parser was also patched to directly use CSSValueID over integers.
This patch also fixes various call sites abusing the usage of integers.
This is part 1 of 2.

No new tests : existing ones should cover.

* WebCore.xcodeproj/project.pbxproj: copy CSSValueKeywords.h as it could be used in WebKit/ for example.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForRepeatRule):
(WebCore::cssIdentifierForFontSizeKeyword):
(WebCore::identifierForFamily):
(WebCore::valueForFamily):
* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseLineHeight):
(WebCore::CSSParser::parseFontSize):
(WebCore::CSSParser::createFontWeightValueKeyword):
(WebCore::CSSParser::parseFontWeight):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::rewriteSpecifiers):
* css/CSSParser.h:
* css/CSSParserValues.h:
* css/CSSPrimitiveValue.h:
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createIdentifierValue):
* css/CSSValuePool.h:
* css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::setProperty):
* css/StylePropertySet.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addPropertyToPresentationAttributeStyle):
* dom/StyledElement.h:
* editing/EditingStyle.cpp:
(WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue):
(WebCore::EditingStyle::prepareToApplyAt):
* editing/EditorCommand.cpp:
(WebCore::executeApplyStyle):
(WebCore::executeFontSize):
* html/HTMLElement.cpp:
(WebCore::unicodeBidiAttributeForDirAuto):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
* html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::cssValueFromFontSizeNumber):
(WebCore::HTMLFontElement::collectStyleForPresentationAttribute):
* html/HTMLFontElement.h:
* html/HTMLTableElement.cpp:
(WebCore::leakBorderStyle):
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::getCSSWritingDirection):
(WebCore::TextTrackCue::getCSSWritingMode):
* html/track/TextTrackCue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Correct style on last patch.
bfulgham@apple.com [Wed, 19 Jun 2013 20:54:40 +0000 (20:54 +0000)]
[Windows] Correct style on last patch.

Reviewed by Tim Horton.

* WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Unreviewed build correction.
bfulgham@apple.com [Wed, 19 Jun 2013 20:51:36 +0000 (20:51 +0000)]
[Windows] Unreviewed build correction.

* WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::ensurePrivateBrowsingSession): Make sure returned generic
type is a CFStringRef before casting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix for Apple Windows port.
roger_fong@apple.com [Wed, 19 Jun 2013 20:37:40 +0000 (20:37 +0000)]
Unreviewed build fix for Apple Windows port.

* WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a few missed renames from Exclusions -> Shapes
commit-queue@webkit.org [Wed, 19 Jun 2013 20:11:26 +0000 (20:11 +0000)]
Fix a few missed renames from Exclusions -> Shapes
https://bugs.webkit.org/show_bug.cgi?id=117803

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-06-19
Reviewed by David Hyatt.

In the great CSS Exclusions to CSS Shapes rename, a few instances were
missed. This fixes those instances.

No new tests, no behavior change, just renames.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateRegionsAndShapesBeforeChildLayout):
(WebCore::RenderBlock::updateRegionsAndShapesAfterChildLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
* rendering/RenderBlock.h:
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: Cannot open Silverlight preferences via context menu
andersca@apple.com [Wed, 19 Jun 2013 20:05:33 +0000 (20:05 +0000)]
REGRESSION: Cannot open Silverlight preferences via context menu
https://bugs.webkit.org/show_bug.cgi?id=117806
<rdar://problem/14166644>

Reviewed by Beth Dakin.

Hook the LSOpenCFURLRef function and make the UI process open the URL if it's the URL for the
Silverlight Preferences application. This is what we do for the Flash updater.

* PluginProcess/PluginProcess.h:
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::openCFURLRef):
(WebKit::initializeShim):
(WebKit::PluginProcess::openURL):
* PluginProcess/mac/PluginProcessShim.h:
* PluginProcess/mac/PluginProcessShim.mm:
(WebKit::shimLSOpenCFURLRef):
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.messages.in:
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::isSilverlightPreferencesURL):
(WebKit::shouldOpenURL):
(WebKit::PluginProcessProxy::openURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncorrect use of jsCast in a finalizer
oliver@apple.com [Wed, 19 Jun 2013 19:45:01 +0000 (19:45 +0000)]
Incorrect use of jsCast in a finalizer
https://bugs.webkit.org/show_bug.cgi?id=117807

Reviewed by Geoffrey Garen.

We can't use jsCast in a finalizer as it checks an object's structure,
and the structure may already have been swept by that point.  Use a
static_cast instead.

* bridge/runtime_array.cpp:
(JSC::RuntimeArray::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline results on GTK and EFL after r151737
robert@webkit.org [Wed, 19 Jun 2013 18:54:32 +0000 (18:54 +0000)]
Rebaseline results on GTK and EFL after r151737

Unreviewed, gardening.

* platform/efl/fast/css/word-space-extra-expected.txt:
* platform/efl/fast/replaced/width100percent-image-expected.png:
* platform/efl/fast/replaced/width100percent-image-expected.txt:
* platform/efl/fast/replaced/width100percent-menulist-expected.png:
* platform/efl/fast/replaced/width100percent-menulist-expected.txt:
* platform/efl/fast/replaced/width100percent-searchfield-expected.png:
* platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
* platform/efl/fast/replaced/width100percent-textarea-expected.png:
* platform/efl/fast/replaced/width100percent-textarea-expected.txt:
* platform/efl/fast/replaced/width100percent-textfield-expected.png:
* platform/efl/fast/replaced/width100percent-textfield-expected.txt:
* platform/efl/tables/mozilla/bugs/bug57828-expected.png:
* platform/efl/tables/mozilla/bugs/bug57828-expected.txt:
* platform/gtk/fast/css/word-space-extra-expected.txt:
* platform/gtk/fast/replaced/width100percent-image-expected.png:
* platform/gtk/fast/replaced/width100percent-image-expected.txt:
* platform/gtk/fast/replaced/width100percent-menulist-expected.png:
* platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
* platform/gtk/fast/replaced/width100percent-searchfield-expected.png:
* platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
* platform/gtk/fast/replaced/width100percent-textarea-expected.png:
* platform/gtk/fast/replaced/width100percent-textarea-expected.txt:
* platform/gtk/fast/replaced/width100percent-textfield-expected.png:
* platform/gtk/fast/replaced/width100percent-textfield-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug57828-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago../WebCore: [Windows] AX: Extend notification handling
bfulgham@apple.com [Wed, 19 Jun 2013 18:45:59 +0000 (18:45 +0000)]
../WebCore: [Windows] AX: Extend notification handling
https://bugs.webkit.org/show_bug.cgi?id=117761.

Reviewed by Anders Carlsson.

accessibility/press-works-on-control-types.html

* accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Add handlers for more event notifications.
* accessibility/win/AccessibilityObjectWrapperWin.cpp:
(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue): Protect against null
pointer dereference found during testing.
* dom/Document.cpp:
(WebCore::Document::implicitClose): Execute notification handler for Windows as well as Mac.
* page/FrameView.cpp:
(WebCore::FrameView::layout): Ditto.

../WebKit/win: [Windows] AX: Extend notification support.
https://bugs.webkit.org/show_bug.cgi?id=117761

Reviewed by Anders Carlsson.

* AccessibleDocument.cpp:
(AccessibleDocument::state): Improve handling of focus state.
* AccessibleDocument.h: Provide signature for new state override.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Webfont rendering is broken.
commit-queue@webkit.org [Wed, 19 Jun 2013 18:17:26 +0000 (18:17 +0000)]
[WinCairo] Webfont rendering is broken.
https://bugs.webkit.org/show_bug.cgi?id=117695

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-19
Reviewed by Brent Fulgham.

The native font handle created from webfont data is invalid.
In much the same way it's done in WinApple, we first need to install the webfont,
create a native font handle from the new font name,
and pass the font handle to the FontPlatformData object, where it's needed to get the glyphs.

* platform/graphics/FontPlatformData.h: Added HFONT parameter to constructor.
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Release installed webfont.
(WebCore::FontCustomPlatformData::fontPlatformData): Create valid HFONT handle for webfont.
(WebCore::createUniqueFontName): Added method to create webfont name.
(WebCore::createFontCustomPlatformData): Install font from webfont data.
* platform/graphics/win/FontCustomPlatformDataCairo.h: Removed.
* platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Added HFONT parameter to constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Does not compile.
commit-queue@webkit.org [Wed, 19 Jun 2013 18:05:50 +0000 (18:05 +0000)]
[WinCairo] Does not compile.
https://bugs.webkit.org/show_bug.cgi?id=117798

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-19
Reviewed by Brent Fulgham.

Add USE(CFNETWORK) guards.

* WebCoreSupport/WebFrameNetworkingContext.cpp: Add USE(CFNETWORK) guard.
(WebFrameNetworkingContext::ensurePrivateBrowsingSession): Change USE(CF_NETWORK) to USE(CFNETWORK).
* WebCoreSupport/WebFrameNetworkingContext.h: Add USE(CFNETWORK) guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement WebIDL implements
ch.dumez@sisa.samsung.com [Wed, 19 Jun 2013 17:40:25 +0000 (17:40 +0000)]
Implement WebIDL implements
https://bugs.webkit.org/show_bug.cgi?id=117785

Reviewed by Kentaro Hara.

Add support for Web IDL 'implements' statements to the bindings generator:
http://www.w3.org/TR/WebIDL/#dfn-implements-statement

Introduce ChildNode IDL interface and have Element, DocumentType and
CharacterData implement it, to match the specification:
http://dom.spec.whatwg.org/#childnode

There is no change in behavior, merely refactoring to match the
specification by leveraging support for Web IDL implements statements.

No new tests, no behavior change.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* bindings/scripts/generate-bindings.pl:
* bindings/scripts/preprocess-idls.pl:
(GeneratePartialInterface):
(getImplementersFromIDL):
* bindings/scripts/test/CPP/WebDOMTestImplements.cpp: Added.
* bindings/scripts/test/CPP/WebDOMTestImplements.h: Added.
* bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
(WebDOMTestInterface::implementsStr1):
(WebDOMTestInterface::implementsStr2):
(WebDOMTestInterface::setImplementsStr2):
(WebDOMTestInterface::implementsNode):
(WebDOMTestInterface::setImplementsNode):
(WebDOMTestInterface::implementsMethod1):
(WebDOMTestInterface::implementsMethod4):
* bindings/scripts/test/CPP/WebDOMTestInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestImplements.cpp: Added.
* bindings/scripts/test/GObject/WebKitDOMTestImplements.h: Added.
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
(webkit_dom_test_interface_class_init):
(webkit_dom_test_interface_implements_method1):
(webkit_dom_test_interface_implements_method2):
(webkit_dom_test_interface_implements_method4):
(webkit_dom_test_interface_get_implements_str1):
(webkit_dom_test_interface_get_implements_str2):
(webkit_dom_test_interface_set_implements_str2):
(webkit_dom_test_interface_get_implements_node):
(webkit_dom_test_interface_set_implements_node):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
* bindings/scripts/test/JS/JSTestImplements.cpp: Added.
* bindings/scripts/test/JS/JSTestImplements.h: Added.
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorImplementsStaticAttr):
(WebCore::jsTestInterfaceImplementsStr1):
(WebCore::jsTestInterfaceImplementsStr2):
(WebCore::jsTestInterfaceImplementsStr3):
(WebCore::jsTestInterfaceImplementsNode):
(WebCore::setJSTestInterfaceConstructorImplementsStaticAttr):
(WebCore::setJSTestInterfaceImplementsStr2):
(WebCore::setJSTestInterfaceImplementsStr3):
(WebCore::setJSTestInterfaceImplementsNode):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod1):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod3):
(WebCore::jsTestInterfaceConstructorFunctionImplementsMethod4):
(WebCore::jsTestInterfaceIMPLEMENTSCONSTANT1):
(WebCore::jsTestInterfaceIMPLEMENTSCONSTANT2):
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/ObjC/DOMTestImplements.cpp: Added.
* bindings/scripts/test/ObjC/DOMTestImplements.h: Added.
* bindings/scripts/test/ObjC/DOMTestInterface.h:
* bindings/scripts/test/ObjC/DOMTestInterface.mm:
(-[DOMTestInterface implementsStr1]):
(-[DOMTestInterface implementsStr2]):
(-[DOMTestInterface setImplementsStr2:]):
(-[DOMTestInterface implementsStr3]):
(-[DOMTestInterface setImplementsStr3:]):
(-[DOMTestInterface implementsNode]):
(-[DOMTestInterface setImplementsNode:]):
(-[DOMTestInterface implementsMethod1]):
(-[DOMTestInterface implementsMethod2:objArg:]):
(-[DOMTestInterface implementsMethod3]):
(-[DOMTestInterface implementsMethod4]):
* bindings/scripts/test/TestImplements.idl: Added.
* dom/CharacterData.idl:
* dom/ChildNode.idl: Copied from Source/WebCore/dom/DocumentType.idl.
* dom/DocumentType.idl:
* dom/Element.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBUILD FIX (r151663): Fix build for iOS WebKit
ddkilzer@apple.com [Wed, 19 Jun 2013 17:33:01 +0000 (17:33 +0000)]
BUILD FIX (r151663): Fix build for iOS WebKit

* wtf/text/AtomicStringTable.cpp: Include MainThread.h.
(WTF::AtomicStringTable::create): Use AtomicStringTable::destroy
instead of non-existent destroyAtomicStringTable function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Copying array or object output does not contain values
graouts@apple.com [Wed, 19 Jun 2013 17:29:58 +0000 (17:29 +0000)]
Web Inspector: Copying array or object output does not contain values
https://bugs.webkit.org/show_bug.cgi?id=117669

ConsoleCommandResult was overriding toClipboardString() but wasn't using the complex code
in ConsoleMessageImpl's toClipboardString() to provide a nicely formatted output for objects.
We now use a "clipboarPrefixString" property to customize the prefix used in the clipboard
and, additionally, only use that prefix if we're copying more than a single message since it's
the only situation where it's useful to have the ">" or "<" prefix shown. Console messages with
a log level always print the level and when saving the console log using Cmd+S, all messages
contain their prefix as well.

Reviewed by Timothy Hatcher.

* UserInterface/ConsoleCommand.js:
(WebInspector.ConsoleCommand.prototype.toClipboardString):
Handle the new isPrefixOptional argument.

* UserInterface/ConsoleCommandResult.js:
(WebInspector.ConsoleCommandResult.prototype.get clipboarPrefixString):
Provide a custom "< " prefix and set "enforcesClipboardPrefixString" to false such that
the prefix isn't printed out in situations when it may not.

* UserInterface/ConsoleMessageImpl.js:
Set "enforcesClipboardPrefixString" to true since we always want to log the log level
prefix in all situations.

(WebInspector.ConsoleMessageImpl.prototype.get clipboarPrefixString):
Implement this new getter to return our clipboard string such that subclasses may
customize it.

(WebInspector.ConsoleMessageImpl.prototype.toClipboardString):
Take into account both isPrefixOptional and the "enforcesClipboardPrefixString" property
to only log the prefix if necessary.

* UserInterface/LogContentView.js:
(WebInspector.LogContentView.prototype._formatMessagesAsData):
Make the logging of prefix optional when we have a single message selected and we're
not saving via Cmd+S.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncorrect computation of shrink-to-fit width for block with white-space:nowrap and...
robert@webkit.org [Wed, 19 Jun 2013 17:20:46 +0000 (17:20 +0000)]
Incorrect computation of shrink-to-fit width for block with white-space:nowrap and floating children
https://bugs.webkit.org/show_bug.cgi?id=114879

Source/WebCore:

Reviewed by David Hyatt.
Per http://www.w3.org/TR/CSS21/visudet.html#Computing_widths_and_margins when width is auto then floating non-replaced,
absolute non-replaced, and inline-block non-replaced elements should use shrink-to-fit width. This trumps any no-wrap property
on the element so if we are shrinking to fit ensure our minimum width respects all possible line breaks.

Test: fast/block/shrink-to-fit-width-container-with-floating-children.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeIntrinsicLogicalWidths):

LayoutTests:

Reviewed by David Hyatt.

* fast/block/shrink-to-fit-width-container-with-floating-children-expected.txt: Added.
* fast/block/shrink-to-fit-width-container-with-floating-children.html: Added.
* platform/qt/fast/css/word-space-extra-expected.txt:
* platform/qt/fast/replaced/width100percent-image-expected.txt:
* platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
* platform/qt/fast/replaced/width100percent-textfield-expected.txt:
* platform/qt/tables/mozilla/bugs/bug57828-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDo not require JS*Custom.h header if [CustomPutFunction] / [CustomNamedSetter] is...
ch.dumez@sisa.samsung.com [Wed, 19 Jun 2013 17:12:23 +0000 (17:12 +0000)]
Do not require JS*Custom.h header if [CustomPutFunction] / [CustomNamedSetter] is used
https://bugs.webkit.org/show_bug.cgi?id=117795

Reviewed by Kentaro Hara.

Fix the JS bindings generator so that it stops including JS*Custom.h header whenever
[CustomPutFunction] or [CustomNamedSetter] IDL extended attributes are used. We don't
really need this custom header and this forces the developer to create dummy custom
headers so that it builds.

If the developer really needs such custom header to be included, he can still use
[JSCustomHeader] IDL extended attribute to do so.

This patch also remove the dummy custom headers that were created but are no longer
required to build.

No new tests, no behavior change. Already covered by the following bindings test:
TestInterface.idl

* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMStringMapCustom.h: Removed.
* bindings/js/JSHTMLAppletElementCustom.cpp:
* bindings/js/JSHTMLAppletElementCustom.h: Removed.
* bindings/js/JSHTMLEmbedElementCustom.cpp:
* bindings/js/JSHTMLEmbedElementCustom.h: Removed.
* bindings/js/JSHTMLObjectElementCustom.cpp:
* bindings/js/JSHTMLObjectElementCustom.h: Removed.
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/JSHistoryCustom.h: Removed.
* bindings/js/JSLocationCustom.cpp:
* bindings/js/JSLocationCustom.h: Removed.
* bindings/js/JSStorageCustom.cpp:
* bindings/js/JSStorageCustom.h: Removed.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Prevent loss of tile buffers in BackingStorePrivate::render()
commit-queue@webkit.org [Wed, 19 Jun 2013 15:30:25 +0000 (15:30 +0000)]
[BlackBerry] Prevent loss of tile buffers in BackingStorePrivate::render()
https://bugs.webkit.org/show_bug.cgi?id=117799
https://jira.bbqnx.net/browse/BRWSR-11712
JIRA413289

Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-06-19
Reviewed by Carlos Garcia Campos.

Discovered by Xuefei Ren.

If, in rare cases, renderContents() returns false,
the for() loop in render() will take a tile buffer from
the surface pool but due to aborting the iteration early,
won't put it into the new tile map. In order to prevent
losing the buffer, we need to put it back into the
surface pool before continuing.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Several tests crash due to an assert when creating an ImageBuffer
commit-queue@webkit.org [Wed, 19 Jun 2013 15:23:32 +0000 (15:23 +0000)]
[BlackBerry] Several tests crash due to an assert when creating an ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=117793

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-06-19
Reviewed by Rob Buis.

JIRA 388741

Fixes a crash in several layout tests due to an assert when
creating an ImageBuffer with an empty size.

* platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::ImageBuffer::ImageBuffer): Return early if the given
size is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] [texmap] the bytesPerLine is wrong when updating the texture
commit-queue@webkit.org [Wed, 19 Jun 2013 15:03:56 +0000 (15:03 +0000)]
[GStreamer] [texmap] the bytesPerLine is wrong when updating the texture
https://bugs.webkit.org/show_bug.cgi?id=117551

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-06-19
Reviewed by Philippe Normand.

Source/WebCore:

The bytesPerLine (or stride) is wrong when updating the texture
content. This is because the naturalSize() is not updated to the
current buffer. This patch extracts the current value of the size and
the stride.

No tests required.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):

LayoutTests:

* platform/gtk-wk2/TestExpectations:
enabled media/video-display-aspect-ratio.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed rebaselining after 151705.
zarvai@inf.u-szeged.hu [Wed, 19 Jun 2013 14:23:34 +0000 (14:23 +0000)]
[Qt] Unreviewed rebaselining after 151705.

* platform/qt/http/tests/cache/partitioned-cache-expected.txt: Added.
* platform/qt/http/tests/cache/partitioned-cache-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdjust internal size on gstreamer source element when receiving data if necessary
commit-queue@webkit.org [Wed, 19 Jun 2013 13:22:59 +0000 (13:22 +0000)]
Adjust internal size on gstreamer source element when receiving data if necessary
https://bugs.webkit.org/show_bug.cgi?id=116534

Patch by Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk> on 2013-06-19
Reviewed by Philippe Normand.

If the size received in didReceiveResponse is smaller than the actual size of the received data
update the internal size and the appsrc size to the proper value.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] TestExpectation sorting on Qt WK2.
zarvai@inf.u-szeged.hu [Wed, 19 Jun 2013 13:10:21 +0000 (13:10 +0000)]
[Qt] TestExpectation sorting on Qt WK2.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-19
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Implement unit test callback: onSettingChange.
commit-queue@webkit.org [Wed, 19 Jun 2013 10:53:48 +0000 (10:53 +0000)]
[EFL][WK2] Implement unit test callback: onSettingChange.
https://bugs.webkit.org/show_bug.cgi?id=117728

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-06-19
Reviewed by Christophe Dumez.

It is finally possible to implement missing unit tests as WebKit2-EFL
has delivered sub menu (r150254).
Add two unit tests for checking onSettingChange callback behaviour,
when toggling "Check Spelling While Typing" in context menu.

Changed types inside callbacksExecutionStats struct from bit field to bool,
because casting from bit field to &bool is invalid (in using waitUntilTrue method).

* UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(resetCallbacksExecutionStats):
(onSettingChange):
(findContextMenuItem):
Get determined option from context menu.

(checkCorrectnessOfSpellingItems):
Changed the name of onContextMenuShow method to be consistent with new methods.

(toogleCheckSpellingWhileTyping):
Select "Check Spelling While Typing" in context menu to test whether
onSettingChange is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] Potential race condition when getting the video sink caps.
commit-queue@webkit.org [Wed, 19 Jun 2013 09:14:02 +0000 (09:14 +0000)]
[GStreamer] Potential race condition when getting the video sink caps.
https://bugs.webkit.org/show_bug.cgi?id=117736

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-06-19
Reviewed by Philippe Normand.

There is a potential race condition with the pad setting caps, as the
buffer and the caps won't match when renegotiation happens, and might
cause a crash.

This patch keeps an instance of the current caps in the video sink,
and it is accessible through a getter method. Hence the player can ask
for the current caps without running into a race condition.

No new tests. No change in behaviour.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
(WebCore::MediaPlayerPrivateGStreamerBase::currentVideoSinkCaps):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkGetProperty):
(webkitVideoSinkStop):
(webkitVideoSinkSetCaps):
(webkit_video_sink_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVibration can be canceled even if page visibility status is hidden
kihong.kwon@samsung.com [Wed, 19 Jun 2013 08:07:40 +0000 (08:07 +0000)]
Vibration can be canceled even if page visibility status is hidden
https://bugs.webkit.org/show_bug.cgi?id=117333

Reviewed by Gyuyoung Kim.

Source/WebCore:

vibration can be canceled in the onvisibilitychange listener even if page visibility is changed to hidden status.
Therefore cancelVibration needs to work when page visibility is hidden.

Tests: vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html

* Modules/vibration/NavigatorVibration.cpp:
(WebCore::NavigatorVibration::vibrate):
* Modules/vibration/Vibration.h:
(WebCore::Vibration::isVibrating):
* testing/Internals.cpp:
(WebCore::Internals::isVibrating):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

Add a test case for cancel vibration after page visibility is changed to hidden status.
In addition, move navigator-vibration.html to vibration directory.

* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* vibration/cancelVibration-after-pagevisibility-changed-to-hidden-expected.txt: Added.
* vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html: Added.
* vibration/navigator-vibration-expected.txt: Renamed from LayoutTests/fast/dom/navigator-vibration-expected.txt.
* vibration/navigator-vibration.html: Renamed from LayoutTests/fast/dom/navigator-vibration.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][SOUP] Migrate SoupRequestManager to GTask
carlosgc@webkit.org [Wed, 19 Jun 2013 07:33:50 +0000 (07:33 +0000)]
[GTK][SOUP] Migrate SoupRequestManager to GTask
https://bugs.webkit.org/show_bug.cgi?id=117157

Reviewed by Gustavo Noronha Silva.

GSimpleAsyncResult has been deprecated in favour of GTask.

* WebProcess/soup/WebKitSoupRequestGeneric.cpp:
(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):
* WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::WebSoupRequestAsyncData::releaseTask):
(WebKit::WebSoupRequestManager::didHandleURIRequest):
(WebKit::WebSoupRequestManager::didFailURIRequest):
(WebKit::WebSoupRequestManager::send):
(WebKit::WebSoupRequestManager::finish):
* WebProcess/soup/WebSoupRequestManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Migrate WebKitFaviconDatabase to GTask
carlosgc@webkit.org [Wed, 19 Jun 2013 07:24:36 +0000 (07:24 +0000)]
[GTK] Migrate WebKitFaviconDatabase to GTask
https://bugs.webkit.org/show_bug.cgi?id=117156

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(processPendingIconsForPageURL):
(webkit_favicon_database_get_favicon):
(webkit_favicon_database_get_favicon_finish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Migrate WebKitWebView to GTask
carlosgc@webkit.org [Wed, 19 Jun 2013 07:19:15 +0000 (07:19 +0000)]
[GTK] Migrate WebKitWebView to GTask
https://bugs.webkit.org/show_bug.cgi?id=117154

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitWebView.cpp:
(didValidateCommand):
(webkit_web_view_can_execute_editing_command):
(webkit_web_view_can_execute_editing_command_finish):
(webkitWebViewRunJavaScriptCallback):
(webkit_web_view_run_javascript):
(webkit_web_view_run_javascript_finish):
(resourcesStreamReadCallback):
(webkit_web_view_run_javascript_from_gresource):
(webkit_web_view_run_javascript_from_gresource_finish):
(fileReplaceContentsCallback):
(getContentsAsMHTMLDataCallback):
(webkit_web_view_save):
(webkit_web_view_save_finish):
(webkit_web_view_save_to_file):
(webkit_web_view_save_to_file_finish):
(webKitWebViewDidReceiveSnapshot):
(webkit_web_view_get_snapshot):
(webkit_web_view_get_snapshot_finish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Migrate WebKitCookieManager to GTask
carlosgc@webkit.org [Wed, 19 Jun 2013 07:13:26 +0000 (07:13 +0000)]
[GTK] Migrate WebKitCookieManager to GTask
https://bugs.webkit.org/show_bug.cgi?id=117150

Reviewed by Gustavo Noronha Silva.

Don't use helper structs for async data since the cancellable is
now accessible from the GTask.

* UIProcess/API/gtk/WebKitCookieManager.cpp:
(webkitCookieManagerGetAcceptPolicyCallback):
(webkit_cookie_manager_get_accept_policy):
(webkit_cookie_manager_get_accept_policy_finish):
(webkitCookieManagerGetDomainsWithCookiesCallback):
(webkit_cookie_manager_get_domains_with_cookies):
(webkit_cookie_manager_get_domains_with_cookies_finish):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
lforschler@apple.com [Wed, 19 Jun 2013 05:10:13 +0000 (05:10 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, EFL gardening. Added new baselines for some of editing/delete
gyuyoung.kim@samsung.com [Wed, 19 Jun 2013 04:37:28 +0000 (04:37 +0000)]
Unreviewed, EFL gardening. Added new baselines for some of editing/delete
tests after system upgrade.

* platform/efl/TestExpectations:
* platform/efl/editing/deleting/smart-delete-003-expected.png: Added.
* platform/efl/editing/deleting/smart-delete-003-expected.txt: Added.
* platform/efl/editing/deleting/smart-delete-004-expected.png: Added.
* platform/efl/editing/deleting/smart-delete-004-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInput type range slider is not updated when min or max are changed
rniwa@webkit.org [Wed, 19 Jun 2013 04:11:32 +0000 (04:11 +0000)]
Input type range slider is not updated when min or max are changed
https://bugs.webkit.org/show_bug.cgi?id=117778

Reviewed by Kent Tamura.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/089c7a0ba2d85b9b59632c2603fbc6472b310be1.

Test: fast/forms/range/range-change-min-max.html

* html/RangeInputType.cpp:
(WebCore::RangeInputType::minOrMaxAttributeChanged):

LayoutTests:

* fast/forms/range/range-change-min-max-expected.html: Added.
* fast/forms/range/range-change-min-max.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove two superfluous overrides of supportsFocus
rniwa@webkit.org [Wed, 19 Jun 2013 03:31:58 +0000 (03:31 +0000)]
Remove two superfluous overrides of supportsFocus
https://bugs.webkit.org/show_bug.cgi?id=117770

Reviewed by Benjamin Poulain.

Merge https://chromium.googlesource.com/chromium/blink/+/4228964a63e3a889a40efce0d01866629fdcd9b9.

* html/HTMLOptGroupElement.cpp:
* html/HTMLOptGroupElement.h:
* html/HTMLOptionElement.cpp:
* html/HTMLOptionElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Media elements never fail to load
benjamin@webkit.org [Wed, 19 Jun 2013 02:02:15 +0000 (02:02 +0000)]
[WK2] Media elements never fail to load
https://bugs.webkit.org/show_bug.cgi?id=117767

Mark the media tests as failing for now.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-18

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove style of null checks in FrameView::setFrameRect
darin@apple.com [Wed, 19 Jun 2013 01:51:44 +0000 (01:51 +0000)]
Improve style of null checks in FrameView::setFrameRect
https://bugs.webkit.org/show_bug.cgi?id=117681

Reviewed by Sam Weinig.

* page/FrameView.cpp:
(WebCore::FrameView::setFrameRect): Used nested if statements and local variables
to tighten this code up a little.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove IDL extended attributes to their correct location
ch.dumez@sisa.samsung.com [Wed, 19 Jun 2013 01:45:39 +0000 (01:45 +0000)]
Move IDL extended attributes to their correct location
https://bugs.webkit.org/show_bug.cgi?id=117732

Reviewed by Kentaro Hara.

Move IDL extended attributes to their correct location according to the
latest Web IDL specification. We used to be inconsistent in the positioning
of the extended attributes. This simplifies a lot the code of the IDL parser
and makes our IDL files more standard.

Based on Blink r148345 by Kentaro Hara <haraken@chromium.org>.

No new tests, no behavior change.

* Modules/encryptedmedia/MediaKeyMessageEvent.idl:
* Modules/notifications/Notification.idl:
* Modules/speech/SpeechSynthesisVoice.idl:
* bindings/scripts/IDLParser.pm:
(parseDefinitions):
(parseInterfaceMembers):
(parseInterfaceMember):
(parseDictionaryMembers):
(parseAttributeOrOperationOrIterator):
(parseAttribute):
* css/CSSFontFaceLoadEvent.idl:
* dom/Document.idl:
* dom/Element.idl:
* dom/Node.idl:
* html/HTMLBodyElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLFrameSetElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLSelectElement.idl:
* html/HTMLSourceElement.idl:
* page/DOMWindow.idl:
* svg/SVGElementInstance.idl:
* svg/SVGScriptElement.idl:
* testing/TypeConversions.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLet the script to update the Localizable.strings file do the reordering it wants...
jberlin@webkit.org [Wed, 19 Jun 2013 01:32:22 +0000 (01:32 +0000)]
Let the script to update the Localizable.strings file do the reordering it wants to do.

Rubber-stamped by Anders Carlsson.

* English.lproj/Localizable.strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Unreviewed gardening -- show missing AccessibilityNodeObject source
bfulgham@apple.com [Wed, 19 Jun 2013 01:15:12 +0000 (01:15 +0000)]
[Windows] Unreviewed gardening -- show missing AccessibilityNodeObject source
files in Visual Studio.

* WebCore.vcxproj/WebCore.vcxproj: Add missing files.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWorking on coverage script, added xml to json data extraction script.
achristensen@apple.com [Wed, 19 Jun 2013 01:12:48 +0000 (01:12 +0000)]
Working on coverage script, added xml to json data extraction script.
https://bugs.webkit.org/show_bug.cgi?id=117648

This is part of a new test code coverage analysis tool.  This compiles WebKit to generate
coverage data, runs the tests, and collects all of the data in json format.

Reviewed by Stephanie Lewis.

* Scripts/generate-coverage-data:
(parseGcovrOutput):
(getFileHitsAndBranches):
(addLineCounts):
(createResultName):
* Scripts/webkitpy/tool/gcovr: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix after r151699.
ryuan.choi@samsung.com [Wed, 19 Jun 2013 00:51:57 +0000 (00:51 +0000)]
Unreviewed build fix after r151699.

* TestWebKitAPI/CMakeLists.txt:
* WebKitTestRunner/CMakeLists.txt:
Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGoing to google.com/trends causes a crash
oliver@apple.com [Wed, 19 Jun 2013 00:36:01 +0000 (00:36 +0000)]
Going to google.com/trends causes a crash
https://bugs.webkit.org/show_bug.cgi?id=117602

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

When handling op_throw, etc we need to flush the variables and arguments
for the entire inline stack, not just the top frame.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flushAllArgumentsAndCapturedVariablesInInlineStack):
(JSC::DFG::ByteCodeParser::parseBlock):

LayoutTests:

Make sure we correctly initialise the appropriate argument registers,
and make sure we perform the tearoff correctly.

* fast/js/inline-arguments-tear-off-expected.txt: Added.
* fast/js/inline-arguments-tear-off.html: Added.
* fast/js/script-tests/inline-arguments-tear-off.js: Added.
(g):
(f):
(doStuff):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix a typo that may be causing some test failures.
roger_fong@apple.com [Wed, 19 Jun 2013 00:12:07 +0000 (00:12 +0000)]
Unreviewed. Fix a typo that may be causing some test failures.

* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r151513.
commit-queue@webkit.org [Tue, 18 Jun 2013 23:39:44 +0000 (23:39 +0000)]
Unreviewed, rolling out r151513.
http://trac.webkit.org/changeset/151513
https://bugs.webkit.org/show_bug.cgi?id=117763

It causes assertions in debug (Requested by benjaminp on
#webkit).

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace tools32 folder with tools and update WebKit Windows solution accordingly.
roger_fong@apple.com [Tue, 18 Jun 2013 23:16:34 +0000 (23:16 +0000)]
Replace tools32 folder with tools and update WebKit Windows solution accordingly.
<rdar://problem/14118143>.

Rubberstamped by Brent Fulgham.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline after system update
benjamin@webkit.org [Tue, 18 Jun 2013 22:50:08 +0000 (22:50 +0000)]
Rebaseline after system update

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-18

* http/tests/cache/partitioned-cache-expected.txt:
* http/tests/cache/partitioned-cache-iframe-expected.txt:
System fix, the tests pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Infrequent uncaught exception with debugger popovers breaks inspector
commit-queue@webkit.org [Tue, 18 Jun 2013 22:44:24 +0000 (22:44 +0000)]
Web Inspector: Infrequent uncaught exception with debugger popovers breaks inspector
https://bugs.webkit.org/show_bug.cgi?id=117755

Create the ZERO_SIZE and ZERO_RECT objects after we've setup the Size
and Rect prototypes, so they get the expected methods. We then need to
handle the ZERO_RECT case better, and not attempt to draw a background
in a canvas with a 0 size, which would produce an exception.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-06-18
Reviewed by Timothy Hatcher.

* UserInterface/Geometry.js:
* UserInterface/Popover.js:
(WebInspector.Popover.prototype._update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Shapes] Remove lineOverflowsFromShapeInside boolean from RenderBlock::layoutRuns...
zoltan@webkit.org [Tue, 18 Jun 2013 22:31:57 +0000 (22:31 +0000)]
[CSS Shapes] Remove lineOverflowsFromShapeInside boolean from RenderBlock::layoutRunsAndFloatsInRange function
https://bugs.webkit.org/show_bug.cgi?id=117757

Reviewed by David Hyatt.

We don't need keep lineOverflowsFromShapeInside boolean in RenderBlock::layoutRunsAndFloatsInRange and in its
helpers because it's easy to decide whether we are in an shape content overflow state or not, so I got rid of
lineOverflowsFromShapeInside's occurences and updated the affected functions.

Covered by existing overflow tests in fast/exclusions/shape-inside and fast/regions/shape-inside.

* rendering/RenderBlock.h: Update helper's definition.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::pushShapeContentOverflowBelowTheContentBox): Add condition when overflow is already positioned.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Remove lineOverflowsFromShapeInside.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread):  Remove lineOverflowsFromShapeInside.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):  Remove lineOverflowsFromShapeInside.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowidthMediaFeatureEval ends up with null FrameView during iframe unload.
commit-queue@webkit.org [Tue, 18 Jun 2013 22:03:07 +0000 (22:03 +0000)]
widthMediaFeatureEval ends up with null FrameView during iframe unload.
https://bugs.webkit.org/show_bug.cgi?id=117754

Patch by Zalan Bujtas <zalan@apple.com> on 2013-06-18
Reviewed by Geoffrey Garen.

Ensure that MediaQueryEvaluator checks against NULL FrameView.

While frames are being unloaded, the Frame object does not necessarily have valid
FrameView anymore. Layout on the main frame can end up querying media values on such child
frames, while detaching.

Source/WebCore:

Test: fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery.html

* css/MediaQueryEvaluator.cpp:
(WebCore::orientationMediaFeatureEval):
(WebCore::aspect_ratioMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
(WebCore::MediaQueryEvaluator::eval):

LayoutTests:

* fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery-expected.txt: Added.
* fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery.html: Added.
* fast/frames/resources/child-iframe-forces-parent-layout-on-unload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake it possible to set a minimum height for auto-layout
andersca@apple.com [Tue, 18 Jun 2013 22:01:37 +0000 (22:01 +0000)]
Make it possible to set a minimum height for auto-layout
https://bugs.webkit.org/show_bug.cgi?id=117758
<rdar://problem/12849080>

Reviewed by Tim Horton.

Change a bunch of minimumLayoutWidth declarations to minimumLayoutSize and add a new minimumLayoutSize property.
If minimumLayoutSize.height is greater than zero, use it to set the minimum layout size on the frame view.

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _setIntrinsicContentSize:]):
(-[WKView minimumLayoutWidth]):
(-[WKView setMinimumLayoutWidth:]):
(-[WKView minimumWidthForAutoLayout]):
(-[WKView setMinimumWidthForAutoLayout:]):
(-[WKView minimumSizeForAutoLayout]):
(-[WKView setMinimumSizeForAutoLayout:]):
* UIProcess/API/mac/WKViewPrivate.h:
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::minimumLayoutSizeDidChange):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setMinimumLayoutSize):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::minimumLayoutSize):
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::minimumLayoutSizeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
(WebKit::TiledCoreAnimationDrawingAreaProxy::intrinsicContentSizeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setMinimumLayoutSize):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::minimumLayoutSize):
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosandbox violation when Flash runs for the first time
commit-queue@webkit.org [Tue, 18 Jun 2013 21:53:22 +0000 (21:53 +0000)]
sandbox violation when Flash runs for the first time
https://bugs.webkit.org/show_bug.cgi?id=117753
<rdar://problem/14165466>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-18
Reviewed by Alexey Proskuryakov.

Allow flash to try and change the ownership of directories it has just created.

* Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExpose a getMediaType method in WebKit
bdakin@apple.com [Tue, 18 Jun 2013 21:39:33 +0000 (21:39 +0000)]
Expose a getMediaType method in WebKit
https://bugs.webkit.org/show_bug.cgi?id=117667

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-18
Reviewed by Brady Eidson.

Source/WebCore:

* WebCore.exp.in: Updated to add a symbol for
HitTestResult::mediaIsVideo method
and alphabetize the list of exposed methods.

Source/WebKit2:

* GNUmakefile.list.am:
* Target.pri:
Updated to include the added header file InjectedBundleHitTestResultMediaType.h

* UIProcess/API/C/WKAPICast.h:
(WebKit::toBundleHitTestResultMediaType):
(WebKit::toAPI):
Added methods to convert between BundleHitTestResultMediaType
and WKBundleHitTestResultMediaType.

* WebKit2.xcodeproj/project.pbxproj: Updated to include
InjectedBundleHitTestResultMediaType.h in the WebKit2 project.

* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultGetMediaType): Exposes the method getMediaType and
hooks into InjectedBundleHitTestResult::getMediaType.

* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:

* WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::getMediaType): Added to return
what type, if any, a media element is.

* WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:

* WebProcess/InjectedBundle/InjectedBundleHitTestResultMediaType.h: Added
to contain new BundleHitTestResultMediaType enums.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused bool argument from ReplacementFragment's constructor
rniwa@webkit.org [Tue, 18 Jun 2013 21:34:52 +0000 (21:34 +0000)]
Remove unused bool argument from ReplacementFragment's constructor
https://bugs.webkit.org/show_bug.cgi?id=117752

Reviewed by Antti Koivisto.

Merge https://chromium.googlesource.com/chromium/blink/+/265586d9f154a9dff657511d09926429b8e1b53d.

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplaceSelectionCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot all subtitle tracks are SDH
eric.carlson@apple.com [Tue, 18 Jun 2013 21:29:12 +0000 (21:29 +0000)]
Not all subtitle tracks are SDH
https://bugs.webkit.org/show_bug.cgi?id=117738

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, existing tests updated.

* html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::isSDH): New.

* html/track/InbandTextTrack.h: Add isSDH override.
* html/track/TextTrack.h:

* page/CaptionUserPreferencesMac.mm:
(WebCore::trackDisplayName): Only add "SDH" label if a track claims to be SDH.

* platform/graphics/InbandTextTrackPrivate.h:
(WebCore::InbandTextTrackPrivate::isSDH): New.

* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::isSDH): Return true if track has both "transcribes
    spoken dialog for accessibility" and "describes music and sound for accessibility"
    characteristics.

LayoutTests:

* media/video-controls-captions-trackmenu-localized.html:
* media/video-controls-captions-trackmenu-sorted.html:
* platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
* platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSimplify FormKeyGenerator::willDeleteForm
rniwa@webkit.org [Tue, 18 Jun 2013 21:25:53 +0000 (21:25 +0000)]
Simplify FormKeyGenerator::willDeleteForm
https://bugs.webkit.org/show_bug.cgi?id=117751

Reviewed by Antti Koivisto.

Merge https://chromium.googlesource.com/chromium/blink/+/c6399efb9da863eb1d1fc98b17ef925998b985ac

* html/FormController.cpp:
(WebCore::FormKeyGenerator::willDeleteForm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r147602): Search text field doesn't render selection when it has some...
rniwa@webkit.org [Tue, 18 Jun 2013 21:25:07 +0000 (21:25 +0000)]
REGRESSION(r147602): Search text field doesn't render selection when it has some :focus rules
https://bugs.webkit.org/show_bug.cgi?id=117747

Reviewed by Kent Tamura.

.:

* ManualTests/search-select-all-with-focus-style.html: Added.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/7ff656c8239ce3b125246abcc8b149a603fcff28

r147612 added setNeedsLayout(true, MarkOnlyThis) for
TextControlInnerTextElement renderer. It's ok for input[type=text]
because RenderTextControlSingleLine also has needsLayout flag, and it
has only the inner text renderer as a child.

As for input[type=search], it doesn't work. Renderer structure for
input[type=search] is:

RenderTextControlSingleLine
└Renderer for TextControlInnerContainer
  └Renderer for TextControlInnerElement
    └Renderer for TextControlInnerTextElement

After r147612, there is a case that only RenderTextControlSingleLine
and TextControlInnerTextElement renderer have needsLayout flag, and
others don't.  It won't trigger layout for
TextControlInnerTextElement renderer.

We should set needsLayout flags of TextControlInnerContainer renderer
and TextControlInnerElement renderer by MarkContainingBlockChain.

Manual Tests: search-select-all-with-focus-style.html
(I tried but couldn't make a test that works in DRT)

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempted build fix for non-Mac.
dino@apple.com [Tue, 18 Jun 2013 20:40:09 +0000 (20:40 +0000)]
Attempted build fix for non-Mac.

* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::nonSyntheticItalicFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSynthesized vertical italics on rotated glyphs are transformed incorrectly
dino@apple.com [Tue, 18 Jun 2013 20:28:58 +0000 (20:28 +0000)]
Synthesized vertical italics on rotated glyphs are transformed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=117726

Reviewed by Enrica Casucci.

Source/WebCore:

If a font does not have italic glyphs, and is in a vertical flow, then
the synthesis of italics was skewing in the wrong direction. While here,
ensure that no CJK text will get italics in vertical layout.

This is a topic under discussion in the CSS Working Group. The resolution
at the June 2013 face-to-face was that:
- italics in Japanese (and Chinese) text are rare in vertical layout
- most people wanted Latin text to italicize in the direction of the line flow

The final behaviour was left undefined, but we consider the change here
to be sufficient for now. In all cases, the best solution is to avoid
synthesized italics by specifying a font that includes such forms.

Tests: fast/text/international/synthesized-italic-vertical-latin.html
       fast/text/international/synthesized-italic-vertical.html

* platform/graphics/FontGlyphs.cpp:
(WebCore::glyphDataAndPageForCJKCharacterWithoutSyntheticItalic): New function
    that makes a new glyph data pair that is marked as NOT using a synthesized italic.
(WebCore::FontGlyphs::glyphDataAndPageForCharacter): If this is a CJK character and
    has a synthesized oblique, then run it through the function above to make a new glyph data pair.
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::nonSyntheticItalicFontData): Creates/returns a new SimpleFontData that will
    not synthesize italics.
* platform/graphics/SimpleFontData.h: New method nonSyntheticItalicFontData.
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs): This is the actual bug fix. If you are in a vertical flow, the
    skew direction should be downwards, not leftwards.

LayoutTests:

Two new tests. One ensures that CJK characters do not get italics
when vertical. The other ensures that Latin text does get italics in
a font that is not synthesized, but unfortunately has to be a pixel test.
The latter is skipped on non-Mac since they don't support
synthesized obliques in FontPlatformData.

* fast/text/international/synthesized-italic-vertical-expected.html: Added.
* fast/text/international/synthesized-italic-vertical-latin.html: Added.
* fast/text/international/synthesized-italic-vertical.html: Added.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Added.
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Build fix for Mac and Win
roger_fong@apple.com [Tue, 18 Jun 2013 20:28:26 +0000 (20:28 +0000)]
Unreviewed. Build fix for Mac and Win

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRe-implement WebFrameNetworkingContext.
roger_fong@apple.com [Tue, 18 Jun 2013 20:14:32 +0000 (20:14 +0000)]
Re-implement WebFrameNetworkingContext.
<rdar://problem/13174821>.

Reviewed by Alexey Proskuryakov.

* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h: Added.
(WebKit::WebFrameNetworkingContext::create):
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: Added.
(WebKit::WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebKit::WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebKit::WebFrameNetworkingContext::sourceApplicationAuditData):
(WebKit::WebFrameNetworkingContext::blockedError):
(WebKit::WebFrameNetworkingContext::storageSession):
* WebCoreSupport/WebFrameNetworkingContext.h: Added.
(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebFrameNetworkingContext::userAgent):
* WebCoreSupport/WebFrameNetworkingContext.mm: Added.
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebFrameNetworkingContext::sourceApplicationAuditData):
(WebFrameNetworkingContext::blockedError):
(WebFrameNetworkingContext::storageSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago <rdar://problem/13174821> Remove files with an incorrect license.
ap@apple.com [Tue, 18 Jun 2013 20:05:08 +0000 (20:05 +0000)]
    <rdar://problem/13174821> Remove files with an incorrect license.

        Rubber-stamped by Maciej Stachowiak.

        This will break the build, stay tuned for a fix coming soon.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPackedIntVector: check template arguments at compile time
mikhail.pozdnyakov@intel.com [Tue, 18 Jun 2013 19:58:32 +0000 (19:58 +0000)]
PackedIntVector: check template arguments at compile time
https://bugs.webkit.org/show_bug.cgi?id=117737

Use 'COMPILE_ASSERT' instead of 'ASSERT' in PackedIntVector class
constructor.

Reviewed by Sam Weinig.

* wtf/PackedIntVector.h:
(WTF::PackedIntVector::PackedIntVector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIf the tree outline is processing a selection currently, then don't change the selection.
timothy@apple.com [Tue, 18 Jun 2013 19:38:01 +0000 (19:38 +0000)]
If the tree outline is processing a selection currently, then don't change the selection.

This is needed to allow breakpoints tree elements to be selected without jumping back to
selecting the resource tree element.

https://bugs.webkit.org/show_bug.cgi?id=117746

Reviewed by Joseph Pecoraro.

* UserInterface/Main.js:
(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
* UserInterface/TreeOutline.js:
(TreeElement.prototype.select):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate breakpoints to match Xcode 5.
timothy@apple.com [Tue, 18 Jun 2013 18:49:28 +0000 (18:49 +0000)]
Update breakpoints to match Xcode 5.

This updates the breakpoint images, line colors, and moves breakpoints toggle button
to the Debugger sidebar navigation bar.

https://bugs.webkit.org/show_bug.cgi?id=117723

Reviewed by Joseph Pecoraro.

* Localizations/en.lproj/localizedStrings.js: Updated.
* UserInterface/DebuggerSidebarPanel.css: Removed custom toggle button rules.
* UserInterface/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._breakpointsToggleButtonClicked):
* UserInterface/Images/Breakpoint.png: Updated.
* UserInterface/Images/Breakpoints.pdf: Added.
* UserInterface/Images/Breakpoint@2x.png: Updated.
* UserInterface/Images/BreakpointButton.pdf: Updated.
* UserInterface/Images/BreakpointInactive.png: Updated.
* UserInterface/Images/BreakpointInactive@2x.png: Updated.
* UserInterface/Images/BreakpointInactiveButton.pdf: Updated.
* UserInterface/Images/InstructionPointer.png: Updated.
* UserInterface/Images/InstructionPointer@2x.png: Updated.
* UserInterface/SourceCodeTextEditor.css:
(.source-code.text-editor > .CodeMirror .error): Updated background-color and removed box-shadow.
(.source-code.text-editor > .CodeMirror .warning): Ditto.
* UserInterface/TextEditor.css:
(.text-editor > .CodeMirror .has-breakpoint .CodeMirror-linenumber::before): Changed left position to 0.
(.text-editor > .CodeMirror .execution-line .CodeMirror-linenumber::after): Updated position.
(.text-editor > .CodeMirror .execution-line): Updated background-color and removed box-shadow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe page title of technical-articles.html is incorrect.
commit-queue@webkit.org [Tue, 18 Jun 2013 17:51:42 +0000 (17:51 +0000)]
The page title of technical-articles.html is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=117727

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-06-18
Reviewed by Ryosuke Niwa.

Changed the page title of technical-articles.html to "WebKit Technical Articles".

* coding/technical-articles.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r151549.
commit-queue@webkit.org [Tue, 18 Jun 2013 17:38:07 +0000 (17:38 +0000)]
Unreviewed, rolling out r151549.
http://trac.webkit.org/changeset/151549
https://bugs.webkit.org/show_bug.cgi?id=117741

broke selection in the web inspector source after scrolling
(Requested by smfr on #webkit).

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderLayerModelObject.cpp:
* rendering/RenderLayerModelObject.h:

LayoutTests:

* fast/repaint/change-overflow-and-display-of-relative-expected.txt: Removed.
* fast/repaint/change-overflow-and-display-of-relative.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151685 268f45cc-cd09-0410-ab3c-d52691b4dbfc