WebKit-https.git
14 years ago2007-01-20 Mark Rowe <mrowe@apple.com>
bdash [Sat, 20 Jan 2007 09:14:20 +0000 (09:14 +0000)]
2007-01-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Track the output of run-javascriptcore-tests,
        catch single regressions, and don't generate tests results for new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubberstamped by Maciej.
aroben [Sat, 20 Jan 2007 08:45:52 +0000 (08:45 +0000)]
    Rubberstamped by Maciej.

        * Scripts/run-webkit-tests: Change the default behavior back to
        generating results for new tests (this can be disabled with
        --no-new-test-results)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Sat, 20 Jan 2007 00:40:52 +0000 (00:40 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Test for <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

        * fast/forms/select-size-expected.checksum: Added.
        * fast/forms/select-size-expected.png: Added.
        * fast/forms/select-size-expected.txt: Added.
        * fast/forms/select-size.html: Added.

WebCore:

        Reviewed by Hyatt.

        Fix for: <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

        Update the size attribute value for select elements to match the numeric value.  This is a special case since this
        attribute is used to determine which control to use.  We want to make sure that the size attribute is valid when we match
        CSS rules.

        Test: fast/forms/select-size.html

        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): If the attribute string value is not the
          same as its integer value, then update the attribute value to match the integer.
        * dom/Attribute.h: Made setValue and setPrefix public.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth.
aroben [Sat, 20 Jan 2007 00:32:01 +0000 (00:32 +0000)]
    Reviewed by Beth.

        Fix <rdar://problem/4942294> REGRESSION: "Spelling and Grammar",
        "Font", "Speech", and "Writing Direction" are missing from contextual
        menu

        * WebCoreSupport/WebContextMenuClient.mm:
        (fixMenusForOldClients): Change our new SPI tags to
        WebMenuItemTagOther because old clients aren't expecting the new tags.
        (fixMenusFromOldClients): Use each menu item's title to figure out its
        correct tag again.
        (WebContextMenuClient::getCustomMenuFromDefaultItems): Call
        fixMenusForOldClients before calling up to the delegate.
        * WebView/WebUIDelegatePrivate.h: Define WEBMENUITEMTAG_SPI_START so
        that we can use it in WebContextMenuClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
sullivan [Sat, 20 Jan 2007 00:02:03 +0000 (00:02 +0000)]
WebCore:

        Reviewed by Darin

        - WebCore part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to
          type a character before username/password autofill kicks in

        * loader/FrameLoaderClient.h:
        new dispatchDidFinishDocumentLoad call

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedParsing):
        call dispatchDidFinishDocumentLoad

        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishDocumentLoad):
        empty implementation for dispatchDidFinishDocumentLoad

WebKit:

        Reviewed by Darin

        - WebKit part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to
          type a character before username/password autofill kicks in

        Added new webView:didFinishDocumentLoadForFrame: SPI and wired it up

        * WebView/WebViewPrivate.h:
        declare new delegate method

        * WebCoreSupport/WebFrameLoaderClient.h:
        declare dispatchDidFinishDocumentLoad()

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
        new method, calls new delegate method

        * DefaultDelegates/WebDefaultFrameLoadDelegate.m:
        (-[WebDefaultFrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
        empty default implementation of new delegate method

WebKitQt:

        Added stubs for new callbacks, to try to avoid breaking the Qt port.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):
        * WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Fri, 19 Jan 2007 23:48:58 +0000 (23:48 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Test for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at http://macreviewzone.com/index.php

        * fast/forms/control-restrict-line-height-expected.checksum: Added.
        * fast/forms/control-restrict-line-height-expected.png: Added.
        * fast/forms/control-restrict-line-height-expected.txt: Added.
        * fast/forms/control-restrict-line-height.html: Added.

WebCore:

        Reviewed by Hyatt.

        Fix for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at http://macreviewzone.com/index.php

        Test: fast/forms/control-restrict-line-height.html

        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize): Don't honor line-height for controls that
          have restricted font size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
andersca [Fri, 19 Jan 2007 23:18:20 +0000 (23:18 +0000)]
    Reviewed by John Sullivan.

        http://bugs.webkit.org/show_bug.cgi?id=12308
        REGRESSION(r18910): Crash in WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
        Move code from initWithFrame in here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix date.
darin [Fri, 19 Jan 2007 23:15:51 +0000 (23:15 +0000)]
Fix date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix bug number.
darin [Fri, 19 Jan 2007 23:15:21 +0000 (23:15 +0000)]
Fix bug number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Fri, 19 Jan 2007 23:12:20 +0000 (23:12 +0000)]
LayoutTests:

        Reviewed by Adele.

        - test for html4.css problem where we had a missing semicolon and thus missed
          parsing a style rule

        * fast/forms/radio-no-theme-padding-expected.txt: Added.
        * fast/forms/radio-no-theme-padding.html: Added.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12008
          <rdar://problem/4901834> REGRESSION(NativeListBox): Focus is not placed on
          SELECT after mousing down on OPTION

        * fast/forms/select-list-box-mouse-focus-expected.txt: Added.
        * fast/forms/select-list-box-mouse-focus.html: Added.

        - test for http://bugs.webkit.org/show_bug.cgi?id=11999
          <rdar://problem/4940442> REGRESSION: Incomplete listing in TVListings window (11999)

        Note: Only the pixel test shows the failure in the old version.

        Note: I generated the pixel results on Leopard -- may need to be
        regenated on Tiger.

        * fast/forms/select-list-box-with-height-expected.checksum: Added.
        * fast/forms/select-list-box-with-height-expected.png: Added.
        * fast/forms/select-list-box-with-height-expected.txt: Added.
        * fast/forms/select-list-box-with-height.html: Added.

WebCore:

        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11999
          <rdar://problem/4940442> REGRESSION: Incomplete listing in TVListings window (11999)
          Fix was to use the actual size of the renderer in the RenderListBox
          case, instead of always using the size specified by the select element.

        Test: fast/forms/select-list-box-with-height.html

        - fix http://bugs.webkit.org/show_bug.cgi?id=12008
          <rdar://problem/4901834> REGRESSION(NativeListBox): Focus is not placed on
          SELECT after mousing down on OPTION

        Test: fast/forms/select-list-box-mouse-focus.html

        - fix bug where auto-scrolling was not working in list box select elements

        No test yet.

        - fix a missing semicolon in the radio/checkbox section of html4.css

        Test: fast/forms/radio-no-theme-padding.html

        - fix bug where the scroll bars for select elements were pixel-type scroll
          bars even though the scrolling is line at a time scrolling

        No test.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::selectAll): Removed an explicit call
        to repaint, since the RenderListBox now does that in selectionChanged.
        (WebCore::HTMLSelectElement::notifyOptionSelected): Call the new
        selectionChanged instead of the old setSelectionChanged.
        (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Added a call
        to focus. Removed an explicit call to repaint and added a call to the
        new setMouseDownMayStartAutoscroll function in EventHandler. Removed an
        explicit call to repaint as above.
        (WebCore::HTMLSelectElement::updateListBoxSelection): Call the new
        selectionChanged instead of the old setSelectionChanged.

        * page/EventHandler.h: Added setMouseDownMayStartAutoscroll, needed
        because the existing code to set that flag won't get triggered when
        the select element's default event handler handles the event.

        * rendering/RenderListBox.h: Made ScrollbarClient a private base class.
        Removed setSelectionChanged and m_selectionChanged. Added selectionChanged,
        which is really just a synonym for repaint for now. Moved valueChanged,
        the ScrollbarClient function implementations, and itemHeight into the
        private part of the class. Added numVisibleItems() and listHeight() to
        the private section. Changed m_vBar to be a RefPtr.

        * rendering/RenderListBox.cpp: Removed unneeded includes. Moved all
        the constants to the top of the file.
        (WebCore::RenderListBox::RenderListBox): Removed initialization of
        m_selectionChanged because it was removed and of m_vBar because it's
        now a RefPtr which is automaticall initialized.
        (WebCore::RenderListBox::~RenderListBox): Removed the explicit deref of
        m_vBar because it's a RefPtr. Added null checking for FrameView.
        (WebCore::RenderListBox::updateFromElement): Use numItems().
        (WebCore::RenderListBox::calcMinMaxWidth): Added null checking for
        FrameView and used RefPtr for the newly-created scroll bar.
        (WebCore::RenderListBox::size): Tweaked formatting. Also renamed the
        misleading minDefaultSize to maxDefaultSize, since it's a maximum.
        (WebCore::RenderListBox::numVisibleItems): Added. Used in many places
        where size() was used before. This computes the number of rows we have
        room for. We don't need a row space after the last row, and this takes
        that into account.
        (WebCore::RenderListBox::numItems): Tweaked to remove the local variable.
        (WebCore::RenderListBox::listHeight): Added. Total height of all the rows
        and spaces between them.
        (WebCore::RenderListBox::calcHeight): Changed to call itemHeight for the
        row height, and to subtract the last row spacing off since we don't need
        a space after the last row. Changed the scroll bar setup to make it
        correspond to row numbers, not pixel numbers.
        (WebCore::RenderListBox::baselinePosition): Moved the comment to the
        constant declaration at the top of the file.
        (WebCore::RenderListBox::itemBoundingBoxRect): Simplified by using
        the itemHeight() function.
        (WebCore::RenderListBox::paintObject): Changed to use numItems and
        to use numVisibleItems instead of size.
        (WebCore::RenderListBox::isPointInScrollbar): Added get() call since
        m_vBar is now a RefPtr.
        (WebCore::RenderListBox::listIndexAtOffset): Changed to use numItems(),
        itemHeight(), and rearranged a min/max combo so it starts with the low,
        then the value, then the high value for pinning.
        (WebCore::RenderListBox::autoscroll): Use numVisibleItems() instead of
        size().
        (WebCore::RenderListBox::stopAutoscroll): Removed an unneeded nil check
        of the element.
        (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Changed
        to use numItems() and to use numVisibleItems() instead of size().
        Also changed scroll bar code to work more simply now that the scroll
        bar is row-based.
        (WebCore::RenderListBox::listIndexIsVisible): Changed to use
        numVisibleItems() instead of size().
        (WebCore::RenderListBox::valueChanged): Simplified since the scrollbar
        is now row-based. Also removed an unnecessary null check.
        (WebCore::RenderListBox::itemHeight): Updated for name change from
        optionsSpacingMiddle to rowSpacing.
        (WebCore::RenderListBox::scrollHeight): Changed to use listHeight().
        (WebCore::RenderListBox::setScrollTop): Simplified, and removed the code
        that does nothing if the computed list index is visible (which did not
        make sense for this function and seemed a cut and paste error from the
        scrollToReveal function). The scrollbar part is simpler now that it's
        row-based.
        (WebCore::RenderListBox::windowClipRect): Changed to use document()->view()
        so we don't have to include RenderView.h.

        * css/html4.css: Added a semicolon I noticed was missing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
bdakin [Fri, 19 Jan 2007 21:57:23 +0000 (21:57 +0000)]
WebCore:
        Reviewed by Maciej and Darin.

        Fix for <rdar://problem/4702420> REGRESSION: Null characters need
        to be stripped from text nodes (townhall.com)

        This was a regression from the fix for <rdar://problem/3727939>
        Safari strips \0 characters from HTML tags making them valid, which
        was fixed with r12652. We still need to strip null characters in
        text nodes.

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::write): No behavior change here, this is
        just to make Darin happy.
        (WebCore::HTMLTokenizer::processToken): Call into StringImpl's new
        createStrippingNull function instead of the normal StringImpl
        constructor.
        * platform/StringImpl.cpp:
        (WebCore::StringImpl::createStrippingNull): Strip null.
        * platform/StringImpl.h:

LayoutTests:
        Reviewed by Maciej and Darin.

        New layout tests and some updates results for the fix for <rdar://
        problem/4702420> REGRESSION: Null characters need to be stripped
        from text nodes (townhall.com)

        * fast/dom/stripNullFromTextNodes-expected.checksum: Added.
        * fast/dom/stripNullFromTextNodes-expected.png: Added.
        * fast/dom/stripNullFromTextNodes-expected.txt: Added.
        * fast/dom/stripNullFromTextNodes.html: Added.
        * fast/js/null-char-in-string-expected.txt: New results.
        * fast/text/stripNullFromText-expected.checksum: Added.
        * fast/text/stripNullFromText-expected.png: Added.
        * fast/text/stripNullFromText-expected.txt: Added.
        * fast/text/stripNullFromText.html: Added.
        * tables/mozilla/images/adforce_imgis_com-expected.txt: New
        results.
        * tables/mozilla_expected_failures/images/adforce_imgis_com-
        expected.checksum: Removed. This is the same test as the one above.
        The same test was in two places.
        * tables/mozilla_expected_failures/images/adforce_imgis_com-
        expected.png: Removed.
        * tables/mozilla_expected_failures/images/adforce_imgis_com-
        expected.txt: Removed.
        * tables/mozilla_expected_failures/images/adforce_imgis_com.html:
        Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
ddkilzer [Fri, 19 Jan 2007 21:16:30 +0000 (21:16 +0000)]
WebCore:

        Reviewed by NOBODY (no-svg build fix).

        * ksvg2/svg/SVGMPathElement.cpp: Added #ifdef SVG_SUPPORT/#endif guards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Yet another build fix.
andersca [Fri, 19 Jan 2007 18:25:13 +0000 (18:25 +0000)]
    Yet another build fix.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::setStatusbarText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Try fixing the QT build.
andersca [Fri, 19 Jan 2007 17:59:42 +0000 (17:59 +0000)]
    Try fixing the QT build.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::runJavaScriptAlert):
        (WebCore::ChromeClientQt::runJavaScriptConfirm):
        (WebCore::ChromeClientQt::runJavaScriptPrompt):
        (WebCore::ChromeClientQt::setStatusbarText):
        * WebCoreSupport/ChromeClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
andersca [Fri, 19 Jan 2007 17:52:06 +0000 (17:52 +0000)]
    Build fix.

        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyChromeClient::setStatusbarText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Fri, 19 Jan 2007 17:28:36 +0000 (17:28 +0000)]
WebCore:

        Reviewed by Adam.

        Move JavaScript alert and status bar functions to the chrome.

        * bindings/js/kjs_window.cpp:
        (KJS::WindowFunc::callAsFunction):
        * page/Chrome.cpp:
        (WebCore::Chrome::runJavaScriptAlert):
        (WebCore::Chrome::runJavaScriptConfirm):
        (WebCore::Chrome::runJavaScriptPrompt):
        (WebCore::Chrome::setStatusBarText):
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/Frame.cpp:
        (WebCore::Frame::setJSStatusBarText):
        (WebCore::Frame::setJSDefaultStatusBarText):
        * page/Frame.h:
        * page/mac/FrameMac.h:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyChromeClient::runJavaScriptAlert):
        (WebCore::SVGEmptyChromeClient::runJavaScriptConfirm):
        (WebCore::SVGEmptyChromeClient::runJavaScriptPrompt):
        (WebCore::SVGEmptyChromeClient::setStatusBarText):

WebKit:

        Reviewed by Adam.

        Move functions from the bridge to the chrome client.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::runJavaScriptAlert):
        (WebChromeClient::runJavaScriptConfirm):
        (WebChromeClient::runJavaScriptPrompt):
        (WebChromeClient::setStatusBarText):
        * WebCoreSupport/WebFrameBridge.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the build
zack [Fri, 19 Jan 2007 16:02:22 +0000 (16:02 +0000)]
Fix the build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-19 Eric Seidel <eric@webkit.org>
eseidel [Fri, 19 Jan 2007 14:27:53 +0000 (14:27 +0000)]
2007-01-19  Eric Seidel  <eric@webkit.org>

        Reviewed by rwlbuis.

        More cleanup to SVGAnimated* classes.

        No tests possible (only code cleanup)

        * ksvg2/svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
        * ksvg2/svg/SVGAnimateMotionElement.h:
        * ksvg2/svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::parseBeginOrEndValue):
        (WebCore::SVGAnimationElement::parseMappedAttribute):
        (WebCore::SVGAnimationElement::parseClockValue):
        (WebCore::SVGAnimationElement::isIndefinite):
        * ksvg2/svg/SVGAnimationElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoNot reviewed.
zimmermann [Fri, 19 Jan 2007 14:09:26 +0000 (14:09 +0000)]
Not reviewed.
Remove accidently commited debug output. Shame on me :-)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Eric.
zimmermann [Fri, 19 Jan 2007 14:03:41 +0000 (14:03 +0000)]
Reviewed by Eric.

Rewrite <use> support with a real-shadow tree (as the spec demands), and implement SVGElementInstance.
AFAIK we're the first implementing this SVG feature - after ASV3 (!).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-19 Eric Seidel <eric@webkit.org>
eseidel [Fri, 19 Jan 2007 13:42:39 +0000 (13:42 +0000)]
2007-01-19  Eric Seidel  <eric@webkit.org>

        Reviewed by rwlbuis.

        Add support for SVGMPathElement parsing.

        No test cases possible (SVGAnimateMotion doesn't work yet)

        * WebCore.xcodeproj/project.pbxproj:
        * ksvg2/svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::animationPath):
        * ksvg2/svg/SVGMPathElement.cpp: Added.
        (WebCore::SVGMPathElement::SVGMPathElement):
        (WebCore::SVGMPathElement::~SVGMPathElement):
        (WebCore::SVGMPathElement::parseMappedAttribute):
        (WebCore::SVGMPathElement::pathElement):
        * ksvg2/svg/SVGMPathElement.h: Added.
        * ksvg2/svg/SVGNumberList.cpp:
        (WebCore::SVGNumberList::parse): fix typo in comment
        * ksvg2/svg/svgtags.in: add back mpath

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-19 Eric Seidel <eric@webkit.org>
eseidel [Fri, 19 Jan 2007 12:59:22 +0000 (12:59 +0000)]
2007-01-19  Eric Seidel  <eric@webkit.org>

        Reviewed by rwlbuis.

        Implement better parsing for keyTimes, keySplines and keyPoints.

        Unfortunately none of this code is used much yet, thus isn't very testable.

        * ksvg2/svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
        * ksvg2/svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::parseKeyNumbers):
        (WebCore::parseKeySplines):
        (WebCore::SVGAnimationElement::parseMappedAttribute):
        * ksvg2/svg/SVGAnimationElement.h:
        * ksvg2/svg/SVGNumberList.cpp:
        (WebCore::SVGNumberList::parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam Roben.
lars [Fri, 19 Jan 2007 10:09:26 +0000 (10:09 +0000)]
    Reviewed by Adam Roben.

        run-webkit-tests does now not generate new results by default anymore.
        You'll have to pass the --new-tests flag to it to force it to do so.

        This is required to make it possible to have tests running on multiple
        platforms peacefully together.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
aroben [Fri, 19 Jan 2007 06:49:12 +0000 (06:49 +0000)]
WebCore:

        Reviewed by Beth.

        Fix: <rdar://problem/4939672> REGRESSION: With text selected that is
        not a link, the "Remove Link" contextual menu item remains active

        * platform/ContextMenuItem.h: Added enabled method.
        * platform/qt/ContextMenuItemQt.cpp:
        (WebCore::ContextMenuItem::enabled): Implemented.
        * platform/mac/ContextMenuItemMac.mm:
        (WebCore::ContextMenuItem::enabled): Ditto.
        * platform/mac/ContextMenuMac.mm:
        (-[WebCoreMenuTarget validateMenuItem:]): Implemented to fulfill the
        NSMenuValidation protocol.

WebKit:

        Reviewed by Beth.

        Fix <rdar://problem/4939672> REGRESSION: With text selected that is
        not a link, the "Remove Link" contextual menu item remains active

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView menuForEvent:]): Leave autoenabling of menu items on so
        that clients can implement validateMenuItem:.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
bdakin [Fri, 19 Jan 2007 06:28:01 +0000 (06:28 +0000)]
    Reviewed by Adele.

        Fix for <rdar://problem/4939558> REGRESSION: "Search in Google",
        "Search in Spotlight" and "Look up in Dictionary" are missing
        initially from the contextual menu

        The bug here is that we select the we were selecting the word after
        the context menu event was dispatched and after the context menu
        was built up.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::sendContextMenuEvent): Select the word
        before dispatching the event. It is safe to remove the check for
        swallowEvent since WebCore context menus ensure that we always
        swallow the event anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-18 Mark Rowe <mrowe@apple.com>
bdash [Fri, 19 Jan 2007 05:11:14 +0000 (05:11 +0000)]
2007-01-18  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim H.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=7926
        Bug 7926: Crash using -callWebScriptMethod to access offsetTop property

        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]): Bail out early if function value is an immediate,
        or if the function object is not callable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-18 Sam Weinig <sam@webkit.org>
bdash [Fri, 19 Jan 2007 03:34:57 +0000 (03:34 +0000)]
2007-01-18  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11853
        REGRESSION (r17352): Whitespace in <title> is rendered

        * loader/DocumentLoader.cpp:
        (WebCore::canonicalizedTitle): Changed to also collapse internal
        whitespace.  This required removing an optimization that is no
        longer possible.
        * manual-tests/title-internal-whitespace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-18 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 19 Jan 2007 01:23:23 +0000 (01:23 +0000)]
2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12039
          Assertion failure in WebCore::Font::primaryFont

        Test: fast/text/font-initial.html

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Give 'font: initial' the
        Standard generic family. This makes the FontDescription different from
        that of the initial font of a GraphicsContext, ensuring that the latter
        will not be used.

2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12039
          Assertion failure in WebCore::Font::primaryFont

        * fast/text/font-initial-expected.checksum: Added.
        * fast/text/font-initial-expected.png: Added.
        * fast/text/font-initial-expected.txt: Added.
        * fast/text/font-initial.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-19 Nicholas Shanks <contact@nickshanks.com>
bdash [Fri, 19 Jan 2007 01:19:23 +0000 (01:19 +0000)]
2007-01-19  Nicholas Shanks  <contact@nickshanks.com>

        Reviewed by Maciej.

        Change doctype for webkit.org/blog/ admin interface to HTML 4.01.

        * blog/wp-admin/admin-header.php:
        * blog/wp-login.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-18 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 19 Jan 2007 01:14:37 +0000 (01:14 +0000)]
2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11451
          REGRESSION: Dell.com does not render correctly in ToT (stylesheet not loaded)

        Test: http/tests/misc/css-accept-any-type.html

        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): Changed the accept header
        for stylesheets to "text/css,*/*;q=0.1" to match Firefox, accepting CSS served
        as any type.

2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=11451
          REGRESSION: Dell.com does not render correctly in ToT (stylesheet not loaded)

        * http/tests/misc/css-accept-any-type-expected.txt: Added.
        * http/tests/misc/css-accept-any-type.html: Added.
        * http/tests/misc/resources/stylesheet.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-18 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 19 Jan 2007 01:11:49 +0000 (01:11 +0000)]
2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11271
        REGRESSION (r12358): Text in display: table unselectable

        Test: editing/selection/display-table-text.html

        * editing/htmlediting.cpp:
        (WebCore::isTableElement): Changed to return false for text nodes.

2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=11271
        REGRESSION (r12358): Text in display: table unselectable

        * editing/selection/display-table-text-expected.checksum: Added.
        * editing/selection/display-table-text-expected.png: Added.
        * editing/selection/display-table-text-expected.txt: Added.
        * editing/selection/display-table-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele
beidson [Fri, 19 Jan 2007 01:10:39 +0000 (01:10 +0000)]
    Reviewed by Adele

        <rdar://problem/4917290> -
        Null deref in WebFrameLoaderClient::restoreScrollPositionAndViewState()
        after regaining network connection

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::restoreScrollPositionAndViewState): Bail early with a null currentItem, preventing
        a crash in release builds.  Leave the ASSERT to help find other cases where this might happen in debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-18 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 19 Jan 2007 01:08:03 +0000 (01:08 +0000)]
2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=6218
          CSS1: WebTextRenderer caches and re-uses fallback renderers that are based on family lists

        This patch takes character-to-glyph mapping out of FontData and instead makes
        each Font keep its own mapping, using a shared set of glyph page fallback trees.

        For each page number there is (at most) one tree. A path from the root to a
        node in the tree corresponds to a fallback list of FontDatas. The node points to
        a page (which may be shared with other nodes) that maps each character in its range
        to a glyph in the first FontData in the fallback list that has it, or to 0 if none of
        the FontDatas has a glyph for that character. A special kind of node, that can
        only occur as a leaf, corresponds to using system fallback fonts after the list
        has been exhausted. This prevents system fallback from polluting non-leaf
        nodes.

        Nodes and pages are initialized lazily and employ "copy on write".

        * CMakeLists.txt:
        * WebCore.pro:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * platform/Font.cpp:
        (WebCore::WidthIterator::WidthIterator): Removed substituteFontData.
        (WebCore::WidthIterator::advance): Moved all character-to-glyph mapping logic out
        of here and replaced it with a call to Font::glyphDataForCharacter().
        (WebCore::Font::Font):
        (WebCore::Font::operator=):
        (WebCore::Font::glyphDataForCharacter): Added. This method performs the lookup in the
        page fallback trees, triggering lazy initialization as needed, and caching pointers to
        the retrieved page tree nodes in the font.
        (WebCore::Font::update):
        (WebCore::Font::drawSimpleText):
        (WebCore::Font::floatWidth):
        (WebCore::Font::floatWidthForSimpleText): Removed substituteFont argument.
        (WebCore::Font::offsetForPositionForSimpleText):
        * platform/Font.h:
        * platform/FontData.cpp:
        (WebCore::FontData::FontData):
        * platform/FontData.h:
        (WebCore::FontData::missingGlyphData): Added. Returns the "missing glyph" GlyphData for
        this FontData.
        * platform/GlyphMap.cpp: Removed.
        * platform/GlyphMap.h: Removed.
        * platform/GlyphPageTreeNode.cpp: Renamed GlyphMap.cpp to this.
        (WebCore::GlyphPageTreeNode::getRoot): Added. Returns the root of the page fallback tree for
        the given page number.
        (WebCore::GlyphPageTreeNode::initializePage): Added. Helper method that initializes the page
        pointer of a node, possibly to a pointer to another node's page or to 0.
        (WebCore::GlyphPageTreeNode::getChild): Added.
        * platform/GlyphPageTreeNode.h: Renamed GlyphMap.h to this.
        (WebCore::GlyphPage::glyphDataForCharacter):
        (WebCore::GlyphPage::setGlyphDataForCharacter):
        (WebCore::GlyphPage::setGlyphDataForIndex):
        (WebCore::GlyphPageTreeNode::GlyphPageTreeNode):
        (WebCore::GlyphPageTreeNode::getRootChild):
        (WebCore::GlyphPageTreeNode::parent):
        (WebCore::GlyphPageTreeNode::page):
        (WebCore::GlyphPageTreeNode::level):
        (WebCore::GlyphPageTreeNode::isSystemFallback): Added. Returns whether the node corresponds
        to the system providing fallback fonts, which is done on a character-by-character basis.
        * platform/gdk/GlyphMapGdk.cpp: Removed.
        * platform/gdk/GlyphPageTreeNodeGdk.cpp: Renamed GlyphMapGdk.cpp to this.
        (WebCore::GlyphPage::fill):
        * platform/mac/FontDataMac.mm:
        (WebCore::FontData::platformInit):
        * platform/mac/FontMac.mm:
        (WebCore::Font::Font):
        * platform/mac/GlyphMapMac.cpp: Removed.
        * platform/mac/GlyphPageTreeNodeMac.cpp: Renamed GlypMapMac.cpp to this.
        (WebCore::GlyphPage::fill): Changed to return false if the font has no glyphs in the page.
        * platform/qt/GlyphMapQt.cpp: Removed.
        * platform/qt/GlyphPageTreeNodeQt.cpp: Renamed GlyphMapQt.cpp to this.
        (WebCore::GlyphPage::fill):
        * platform/win/GlyphMapWin.cpp: Removed.
        * platform/win/GlyphPageTreeNodeWin.cpp: Renamed GlyphMapWin to this.
        (WebCore::GlyphPage::fill):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-18 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 19 Jan 2007 01:03:05 +0000 (01:03 +0000)]
2007-01-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=9952
          REGRESSION: Repro crash when dragging an image from the window to the address bar

        * page/FrameView.cpp:
        (WebCore::FrameView::~FrameView): Removed the call to Document::detach(). If this
        view is the current view, then the Frame should have already detached the document.
        Added an assertion that this is the case. If this view is not the current view,
        then it cannot access its document, but the page cache should have detached it already.
        Similarly, changed to call RenderPart::setWidget() only if this is the current view
        in the frame.
        (WebCore::FrameView::adjustViewSize): Added an assertion that this view is the current
        view in the frame.
        (WebCore::FrameView::layout): Ditto.
        (WebCore::FrameView::scheduleRelayout): Ditto.
        (WebCore::FrameView::scheduleRelayoutOfSubtree): Ditto.
        (WebCore::FrameView::windowClipRect): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-18 Eric Seidel <eric@webkit.org>
eseidel [Fri, 19 Jan 2007 01:00:41 +0000 (01:00 +0000)]
2007-01-18  Eric Seidel  <eric@webkit.org>

        Reviewed by bdash.

        No test needed, removed bogus debug-only ASSERT.

        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-18 Sanjay Madhav <sanjay12@gmail.com>
bdash [Fri, 19 Jan 2007 01:00:40 +0000 (01:00 +0000)]
2007-01-18  Sanjay Madhav  <sanjay12@gmail.com>

        Reviewed by Darin.

        Add JavaScriptCore define to help with tracing of when objects are marked.

        * kjs/object.cpp:
        (KJS::JSObject::mark):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build Fix
aliceli1 [Fri, 19 Jan 2007 00:54:44 +0000 (00:54 +0000)]
    Build Fix

        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe.
aliceli1 [Fri, 19 Jan 2007 00:01:00 +0000 (00:01 +0000)]
    Reviewed by Mark Rowe.

        Fixes the leaks from my last patch, except for the first change below which is a missing delegate call for Mail purposes

        * editing/Editor.cpp:
        (WebCore::Editor::cut):
        * platform/Pasteboard.h:
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::Pasteboard):
        (WebCore::Pasteboard::clear):
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
kdecker [Thu, 18 Jan 2007 22:20:31 +0000 (22:20 +0000)]
    Reviewed by John.

        <rdar://problem/4939511> WebKit should set the CG clip path for plug-ins that draw using CoreGraphics

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView drawRect:]):  Set the CG clip path to the plug-in dirty rect. This allows plug-ins to obtain their
        dirty rect using functions like CGContextGetClipBoundingBox().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemoved accidentally-duplicated entries.
sullivan [Thu, 18 Jan 2007 21:38:14 +0000 (21:38 +0000)]
Removed accidentally-duplicated entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin
sullivan [Thu, 18 Jan 2007 21:33:02 +0000 (21:33 +0000)]
    Reviewed by Darin

        - Tests for:
          <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word
          <rdar://problem/4462420> REGRESSION: Mail hangs during Replace All if the replacement string contains the search string

        * editing/spelling/spelling-expected.checksum: Added.
        * editing/spelling/spelling-expected.png: Added.
        * editing/spelling/spelling-expected.txt: Added.
        * editing/spelling/spelling.html: Added.
        * editing/execCommand/find-after-replace-expected.checksum: Added.
        * editing/execCommand/find-after-replace-expected.png: Added.
        * editing/execCommand/find-after-replace-expected.txt: Added.
        * editing/execCommand/find-after-replace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make sure layer autoscrolling puts the event coordinates into the layer's...
hyatt [Thu, 18 Jan 2007 21:14:26 +0000 (21:14 +0000)]
    Make sure layer autoscrolling puts the event coordinates into the layer's coordinate space before
        calling hitTest on it.  Fixes "flashy" selection in textareas.

        Reviewed by darin

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::autoscroll):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
andersca [Thu, 18 Jan 2007 21:09:12 +0000 (21:09 +0000)]
    Reviewed by Adam.

        Get rid of ResourceLoaderMac.mm and make willCacheResponse platform-independent.

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::willCacheResponse):
        * loader/ResourceLoader.h:
        * loader/mac/ResourceLoaderMac.mm: Removed.
        * platform/network/ResourceHandleClient.h:
        (WebCore::):
        (WebCore::ResourceHandleClient::willCacheResponse):
        (WebCore::ResourceHandleClient::willStopBufferingData):
        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
darin [Thu, 18 Jan 2007 20:44:26 +0000 (20:44 +0000)]
    Reviewed by John Sullivan.

        * Scripts/run-webkit-tests: Fix handling of configuration so it
        does the right thing when no explicit configuration is passed in.
        The old code assumed that the result of setConfiguration() was the
        configuration, but it's undefined when no configuration is
        explicitly passed in. The correct function to use is
        configuration(), and I also streamlined the code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
mjs [Thu, 18 Jan 2007 19:13:14 +0000 (19:13 +0000)]
    Reviewed by John.

        - fixed <rdar://problem/4887416> REGRESSION (SearchField): Assertion failure in HTMLInputElement::setValueFromRenderer when editing via drag and drop (11846)
        http://bugs.webkit.org/show_bug.cgi?id=11846

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Don't insert extra paragraph separators to avoid
        nesting blocks in plaintext mode, since that's not an issue under normal circumstances.
        * html/HTMLInputElement.h:
        * manual-tests/drag-move-in-search-field.html: Added.
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::subtreeHasChanged): constrain the value; we'd
        rather truncate it than end up with an illegal value here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoparallel build fix
hausmann [Thu, 18 Jan 2007 17:07:00 +0000 (17:07 +0000)]
parallel build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Thu, 18 Jan 2007 16:39:43 +0000 (16:39 +0000)]
LayoutTests:

        Reviewed by Darin and Mitz.

        - Test for http://bugs.webkit.org/show_bug.cgi?id=12305
          REGRESSION: Images do not load in video sections on CNN.com homepage

        * fast/dom/HTMLImageElement/image-lowsrc-getset-expected.txt: Added.
        * fast/dom/HTMLImageElement/image-lowsrc-getset.html: Added.

WebCore:

        Reviewed by Darin and Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12305
          REGRESSION: Images do not load in video sections on CNN.com homepage

        <rdar://problem/4931480> REGRESSION: Images do not load in video sections on CNN.com homepage (12305)

        Test: fast/dom/HTMLImageElement/image-lowsrc-getset.html

        * html/HTMLAttributeNames.in: Added lowsrc.
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::isURLAttribute): Added lowsrc.
        (WebCore::HTMLImageElement::lowsrc): Added.
        (WebCore::HTMLImageElement::setLowsrc): Added.
        * html/HTMLImageElement.h: Added lowsrc and setLowsrc.
        * html/HTMLImageElement.idl: Added lowsrc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agofix make clean in the qt build to remove all generated files
hausmann [Thu, 18 Jan 2007 13:00:27 +0000 (13:00 +0000)]
fix make clean in the qt build to remove all generated files

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplementing some load progress tracking in the Qt port.
zack [Thu, 18 Jan 2007 10:04:38 +0000 (10:04 +0000)]
Implementing some load progress tracking in the Qt port.
Reviewed by Lars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
aliceli1 [Thu, 18 Jan 2007 07:47:03 +0000 (07:47 +0000)]
WebCore:

        Reviewed by Harrison.

        Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste

        Migration of some editing code from WebHTMView to WebCore::Editor
        resulted in not calling pasteboardTypesForSelection, which Mail was
        overriding for the special purpose of adding a type to the
        pasteboard after WebKit did.  This patch adds 2 separate code paths
        for Tiger and Leopard.  On Tiger we give in and call the WebView's
        pasteboardTypesForSelection.  On Leopard we call a delegate after
        the pasteboard types are set.

        * bridge/EditorClient.h:
        * editing/Editor.h:
        * platform/Pasteboard.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyEditorClient::didSetSelectionTypesForPasteboard):
        (WebCore::SVGEmptyEditorClient::pasteboardTypesForSelection):
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::Pasteboard):
        (WebCore::Pasteboard::clear):
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):

WebKit:

        Reviewed by Harrison.

        Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste

        Migration of some editing code from WebHTMView to WebCore::Editor
        resulted in not calling pasteboardTypesForSelection, which Mail was
        overriding for the special purpose of adding a type to the
        pasteboard after WebKit did.  This patch adds 2 separate code paths
        for Tiger and Leopard.  On Tiger we give in and call the WebView's
        pasteboardTypesForSelection.  On Leopard we call a delegate after
        the pasteboard types are set.

        * DefaultDelegates/WebDefaultEditingDelegate.m:
        (-[WebDefaultEditingDelegate webView:didSetSelectionTypesForPasteboard:]):
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::didSetSelectionTypesForPasteboard):
        (WebEditorClient::pasteboardTypesForSelection):
        * WebView/WebEditingDelegate.h:

WebKitQt:

        Added these stubs to keep the Qt build from failing.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::didSetSelectionTypesForPasteboard):
        * WebCoreSupport/EditorClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
sullivan [Thu, 18 Jan 2007 04:32:33 +0000 (04:32 +0000)]
WebCore:

        Reviewed by Darin

        - WebCore part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during
          Replace All if the replacement string contains the search string

        * page/Frame.h:
        * page/Frame.cpp:
        (WebCore::Frame::findString):
        new startInSelection parameter -- if true, search starts looking in selection; if false,
        search starts looking after the selection

        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:startInSelection:]):
        new startInSelection parameter, passed through to Frame::findString()

        * editing/JSEditor.cpp:
        pass false for new findString parameter, to match old behavior

WebKit:

        Reviewed by Darin

        - WebKit part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during
          Replace All if the replacement string contains the search string

        * Misc/WebKitVersionChecks.h:
        Added extern "C" so this can be used from .mm files. I don't need this change anymore for
        this fix, but it's still worth fixing now so it doesn't bite anyone later.

        * WebView/WebDocumentPrivate.h:
        Invented new private protocol WebDocumentIncrementalSearching, that has one method. The one
        method is just like the one WebDocumentSearching method, but with an additional parameter.
        We hope to eliminate this dependence on protocols someday, but adding another one as SPI
        seems like it won't make anything worse.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]):
        now calls through to new method that has one additional parameter, passing NO to match old behavior
        (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        pass new parameter to bridge

        * WebView/WebPDFView.h:
        Declare conformance to WebDocumentIncrementalSearching protocol

        * WebView/WebPDFView.mm:
        (-[WebPDFView searchFor:direction:caseSensitive:wrap:]):
        now calls through to new method that has one additional parameter, passing NO to match old behavior
        (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection
        parameter

        * WebView/WebViewPrivate.h:
        Declare new searchFor:direction:caseSensitive:wrap:startInSelection: method, just like existing
        method but with one additional parameter

        * WebView/WebView.mm:
        (-[WebView searchFor:direction:caseSensitive:wrap:]):
        now calls through to new method that has one additional parameter, passing NO to match old behavior
        (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]):
        new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection
        parameter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemoved an internal change I had I wasn't supposed to commit. *sigh*
beidson [Thu, 18 Jan 2007 04:00:35 +0000 (04:00 +0000)]
Removed an internal change I had I wasn't supposed to commit.  *sigh*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Deth Bakin and Brian Dash
beidson [Thu, 18 Jan 2007 03:58:11 +0000 (03:58 +0000)]
    Reviewed by Deth Bakin and Brian Dash

        Drop Panther Support (?!?) and change the comment explaining some SPI forward decls

        * Misc/WebDownload.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdding comment.
bdakin [Thu, 18 Jan 2007 02:32:32 +0000 (02:32 +0000)]
Adding comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Thu, 18 Jan 2007 02:30:54 +0000 (02:30 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/4920488>
        REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link)

        * editing/execCommand/4920488-expected.checksum: Added.
        * editing/execCommand/4920488-expected.png: Added.
        * editing/execCommand/4920488-expected.txt: Added.
        * editing/execCommand/4920488.html: Added.
        * fast/dom/Range/compareBoundaryPoints-1-expected.txt: Added.
        * fast/dom/Range/compareBoundaryPoints-1.html: Added.

WebCore:

        Reviewed by darin

        <rdar://problem/4920488>
        REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link)

        * dom/Range.cpp:
        (WebCore::Range::commonAncestorContainer): Return null if the nodes
        don't have a common ancestor.  As a side effect, the public
        commonAncestorContainer now sets an exception if the Range starts
        in one document and ends in another, or starts or ends in a tree
        that's been removed from the document.  The spec doesn't cover
        this and there is no precedent in other browsers for this case because
        they don't allow invalid Ranges (you can create one with WebCore
        by removing a node that contains the start/end of a Range).
        (WebCore::Range::compareBoundaryPoints): If the the two positions
        are in nodes that have no common ancestor, return null.  This doesn't
        change the behavior of the public compareBoundaryPoints: it already
        throws an exception if the two positions are in nodes that don't have
        a common ancestor.  This follows the spec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago The one word was typed by me, but only after debugging for a long time with...
sullivan [Thu, 18 Jan 2007 01:49:30 +0000 (01:49 +0000)]
    The one word was typed by me, but only after debugging for a long time with Darin.

        - fixed <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word

        * editing/TextIterator.cpp:
        (WebCore::WordAwareIterator::WordAwareIterator):
        We were creating a TextIterator with the default kind, but WordAwareIterator is designed to work
        in concert with CharacterIterator, so they need to use the same kind. CharacterIterator uses
        kind RUNFINDER, so WordAwareIterator needs to do so also.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady.
adele [Thu, 18 Jan 2007 01:09:24 +0000 (01:09 +0000)]
    Reviewed by Brady.

        Fix for <rdar://problem/4900895> REGRESSION: onChange doesn't always fire for popups that have had value changed by JS

        No test case since you need to open up the menu to fire onChange.

        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex):
          Keep track of m_lastOnChangeIndex even when we're not firing onChange.  Since
          the selected index has changed, we still want the m_lastOnChangeIndex to be up to date when we compare
          it later.  This matches our behavior in Safari 2.0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin and John.
adele [Thu, 18 Jan 2007 00:15:10 +0000 (00:15 +0000)]
    Reviewed by Darin and John.

        - Fix for <rdar://problem/4816550> REGRESSION: autoscrolling doesn't work after double-click

        * page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Set swallowEvent bool instead
          of returning early for double and triple clicks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-17 Eric Seidel <eric@webkit.org>
eseidel [Wed, 17 Jan 2007 23:17:41 +0000 (23:17 +0000)]
2007-01-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Brady.

        Update results after SVG container hit testing changes.

        * svg/custom/pointer-events-text-expected.checksum:
        * svg/custom/pointer-events-text-expected.png:
        * svg/custom/pointer-events-text-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
darin [Wed, 17 Jan 2007 23:13:48 +0000 (23:13 +0000)]
    Reviewed by Hyatt.

        * rendering/RenderObject.h: Removed unused nextEditable and previousEditable.
        * rendering/RenderObject.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin [Wed, 17 Jan 2007 22:50:58 +0000 (22:50 +0000)]
WebCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12278
          <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278)

        * WebCore.exp: Added HitTestResult::imageRect,
        removed HitTestResult::boundingBox.

        * rendering/HitTestResult.h:
        * rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect):
        Added. Returns the content rectangle of the image.

        * rendering/RenderObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::absolutePosition): Made const.
        (WebCore::RenderObject::contentBox): Added.
        (WebCore::RenderObject::absoluteContentBox): Added.

        * rendering/RenderBox.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absolutePosition): Made const.

        * rendering/RenderTableCell.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::absolutePosition): Made const.

        * rendering/RenderView.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::absolutePosition): Made const.

WebKit:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12278
          <rdar://problem/4928705> REGRESSION(r13070): Dragged image size includes padding (12278)

        * Misc/WebElementDictionary.mm: (-[WebElementDictionary _imageRect]):
        Call HitTestResult::imageRect, not HitTestResult::boundingBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix my last commit to actually work in all cases.
lars [Wed, 17 Jan 2007 22:15:31 +0000 (22:15 +0000)]
Fix my last commit to actually work in all cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mitz.
adele [Wed, 17 Jan 2007 22:05:31 +0000 (22:05 +0000)]
    Reviewed by Mitz.

        Updating this new layout test so that it actually crashes before the last fix.

        * fast/css/pseudostyle-anonymous-text.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Wed, 17 Jan 2007 21:50:42 +0000 (21:50 +0000)]
LayoutTests:

        Reviewed by Beth.

        Test for http://bugs.webkit.org/show_bug.cgi?id=10139
        <rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle

        * fast/css/pseudostyle-anonymous-text-expected.txt: Added.
        * fast/css/pseudostyle-anonymous-text.html: Added.

WebCore:

        Reviewed by Beth.

        Fix for  http://bugs.webkit.org/show_bug.cgi?id=10139
        <rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle

        Test: fast/css/pseudostyle-anonymous-text.html

        * rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Nil check the node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej
lars [Wed, 17 Jan 2007 21:19:21 +0000 (21:19 +0000)]
    Reviewed by Maciej

        Make sure DumpRenderTree exits when run-webkit-tests
        is done.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Wed, 17 Jan 2007 21:01:34 +0000 (21:01 +0000)]
LayoutTests:

        Reviewed by Anders and John.

        Test for http://bugs.webkit.org/show_bug.cgi?id=11278
        <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options

        * fast/forms/menulist-width-change-expected.checksum: Added.
        * fast/forms/menulist-width-change-expected.png: Added.
        * fast/forms/menulist-width-change-expected.txt: Added.
        * fast/forms/menulist-width-change.html: Added.

WebCore:

        Reviewed by Anders and John.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=11278
        <rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options

        Test: fast/forms/menulist-width-change.html

        * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement):
          When the options change, call setNeedsLayoutAndMinMaxRecalc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
ap [Wed, 17 Jan 2007 19:34:43 +0000 (19:34 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=12268
        Give object prototypes their own names

JavaScriptCore:
        * kjs/lookup.h: Append "Prototype" to ClassName in KJS_IMPLEMENT_PROTOTYPE.

WebCore:
        * bindings/scripts/CodeGeneratorJS.pm: Append "Proto" to interface name for the prototype's ClassInfo.

        * bindings/js/JSHTMLInputElementBase.cpp:
        (WebCore::JSHTMLInputElementBasePrototypeFunction::callAsFunction):
        (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
        * bindings/js/JSHTMLInputElementBase.h:
        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
        (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
        (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
        * bindings/js/JSXMLHttpRequest.h:
        * bindings/js/JSXSLTProcessor.cpp:
        (KJS::JSXSLTProcessor::JSXSLTProcessor):
        (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
        (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
        * bindings/js/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::DOMCSSStyleDeclaration):
        (KJS::DOMCSSStyleDeclarationPrototypeFunction::callAsFunction):
        (KJS::DOMMediaList::DOMMediaList):
        (KJS::KJS::DOMMediaListPrototypeFunction::callAsFunction):
        (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet):
        (KJS::DOMCSSStyleSheetPrototypeFunction::callAsFunction):
        (KJS::DOMCSSValue::DOMCSSValue):
        (KJS::DOMCSSValuePrototypeFunction::callAsFunction):
        * bindings/js/kjs_css.h:
        * bindings/js/kjs_dom.cpp:
        (KJS::DOMNode::DOMNode):
        (KJS::DOMNodePrototypeFunction::callAsFunction):
        (KJS::DOMEventTargetNode::DOMEventTargetNode):
        (KJS::DOMEventTargetNodePrototypeFunction::callAsFunction):
        (KJS::DOMNamedNodeMap::DOMNamedNodeMap):
        (KJS::DOMNamedNodeMapPrototypeFunction::callAsFunction):
        * bindings/js/kjs_dom.h:
        * bindings/js/kjs_domnode.h:
        * bindings/js/kjs_events.cpp:
        (KJS::DOMEvent::DOMEvent):
        (KJS::DOMEventPrototypeFunction::callAsFunction):
        (KJS::Clipboard::Clipboard):
        (KJS::ClipboardPrototypeFunction::callAsFunction):
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLDocumentPrototypeFunction::callAsFunction):
        (KJS::):
        (KJS::JSHTMLDocument::JSHTMLDocument):
        (KJS::JSHTMLElementPrototypeFunction::callAsFunction):
        (KJS::JSHTMLElement::JSHTMLElement):
        (KJS::JSHTMLCollection::JSHTMLCollection):
        (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):
        * bindings/js/kjs_html.h:
        * bindings/js/kjs_navigator.cpp:
        * bindings/js/kjs_traversal.cpp:
        (KJS::DOMNodeFilter::DOMNodeFilter):
        (KJS::DOMNodeFilterPrototypeFunction::callAsFunction):
        * bindings/js/kjs_window.cpp:
        (KJS::Window::clear):
        Changed Proto to Prototype, and ProtoFunc to PrototypeFunction.

LayoutTests:
        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/prototype-chain-expected.txt:
        * fast/events/event-view-toString-expected.txt:
        * fast/events/mouseclick-target-and-positioning-expected.txt:
        * fast/tokenizer/external-script-document-write-expected.checksum:
        * fast/tokenizer/external-script-document-write-expected.png:
        * fast/tokenizer/external-script-document-write-expected.txt:
        Updated the results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Zack and Darin
lars [Wed, 17 Jan 2007 19:04:39 +0000 (19:04 +0000)]
    Reviewed by Zack and Darin

        Fix the Qt build again after the latest Image changes.
        Also make some of the methods implemented in ImageCG
        crossplatform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
andersca [Wed, 17 Jan 2007 18:45:57 +0000 (18:45 +0000)]
    Reviewed by John Sullivan.

        Move all code in WebNetscapePluginEmbeddedView down to WebBaseNetscapePluginView.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
        (-[WebBaseNetscapePluginView didStart]):
        (-[WebBaseNetscapePluginView dataSource]):
        (-[WebBaseNetscapePluginView dealloc]):
        (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
        (-[WebBaseNetscapePluginView pluginView:receivedData:]):
        (-[WebBaseNetscapePluginView pluginView:receivedError:]):
        (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]):
        (-[WebBaseNetscapePluginView _redeliverStream]):
        * Plugins/WebNetscapePluginEmbeddedView.h:
        * Plugins/WebNetscapePluginEmbeddedView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - quick attempt to fix the Qt build
darin [Wed, 17 Jan 2007 17:08:05 +0000 (17:08 +0000)]
    - quick attempt to fix the Qt build

        * platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::drawTiled):
        Remove obsolete parameters from this stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-17 Eric Seidel <eric@webkit.org>
eseidel [Wed, 17 Jan 2007 14:59:18 +0000 (14:59 +0000)]
2007-01-17  Eric Seidel  <eric@webkit.org>

        Reviewed by rwlbuis.

        Test: svg/custom/inner-svg-hit-test.svg

        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::nodeAtPoint): never allow containers to be hit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Zack
lars [Wed, 17 Jan 2007 13:18:33 +0000 (13:18 +0000)]
    Reviewed by Zack

        Don't call receivedResponse twice for file: URLs.
        Never call back into the ResourceHandleClient once
        cancel() has been called on the ResourceHandle.

        Remove the inheritance from Shared<XxxClient> in the
        client classes.

        Answer asynchronously to most of the Policy checking methods
        in FrameLoaderClientQt to avoid some crashes in the loader.

        Small fixes in DumpRenderTree, so we don't by
        accident dump twice for the same test.

        Exclude one more test as it currently causes DumpRenderTree to
        hang forever.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-17 Eric Seidel <eric@webkit.org>
eseidel [Wed, 17 Jan 2007 12:21:12 +0000 (12:21 +0000)]
2007-01-17  Eric Seidel  <eric@webkit.org>

        No review, build fix only.

        * platform/graphics/cg/ImageCG.cpp: correct drawPatternCombined to drawPattern
        (WebCore::Image::drawPattern):
        (WebCore::Image::drawTiled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-17 Eric Seidel <eric@webkit.org>
eseidel [Wed, 17 Jan 2007 12:10:06 +0000 (12:10 +0000)]
2007-01-17  Eric Seidel  <eric@webkit.org>

        Reviewed by mitz and rwlbuis.

        SVGs do not work as background images:
        http://bugs.webkit.org/show_bug.cgi?id=12096

        Tests updated:
        - fast/images/svg-as-background.svg: now passes
        - fast/images/svg-as-tiled-background.svg: now passes

        * platform/graphics/BitmapImage.h:
        (WebCore::BitmapImage::nativeImageForCurrentFrame):
        (WebCore::BitmapImage::mayFillWithSolidColor):
        (WebCore::BitmapImage::solidColor):
        * platform/graphics/Image.h:
        (WebCore::Image::mayFillWithSolidColor):
        (WebCore::Image::solidColor):
        (WebCore::Image::nativeImageForCurrentFrame):
        (WebCore::Image::startAnimation):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::Image::drawPatternCallback):
        (WebCore::Image::drawPatternCombined):
        (WebCore::caculatePatternScale):
        (WebCore::Image::drawTiled):
        * platform/graphics/cg/PDFDocumentImage.cpp:
        * platform/graphics/cg/PDFDocumentImage.h:
        * platform/graphics/svg/SVGImage.cpp:
        (WebCore::SVGImage::nativeImageForCurrentFrame):
        * platform/graphics/svg/SVGImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Wed, 17 Jan 2007 10:11:50 +0000 (10:11 +0000)]
    Reviewed by Eric.

        <rdar://problem/4887781> Seed: Repro Safari crash in -[WebHTMLRepresentation receivedData:withDataSource:] (music.aol.com)

        * WebView/WebDataSource.mm:
        (-[WebDataSource _receivedData:]): Protect self against destruction partway through this method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric
rwlbuis [Wed, 17 Jan 2007 09:58:20 +0000 (09:58 +0000)]
    Reviewed by Eric

        Add proper condition for rx attribute negative check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add a message handler to DumpRenderTree that will
lars [Wed, 17 Jan 2007 09:14:51 +0000 (09:14 +0000)]
    Add a message handler to DumpRenderTree that will
        suppress all debug output coming from qDebug() statements.
        Like this we can get rid of all the noise coming
        from the notImplemented() macro when running the
        layout tests. You can get it back by adding -v to
        DumpRenderTree's command line.

        Changed run-webkit-tests slightly, so we by default
        don't fail anymore when our output differs from what
        is generated on the Mac. Added a --strict option, so
        that we can still see this cases and fix them one by one.

        change all notImplemented() macros to use qDebug
        instead of fprintf(stder, ...)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
beidson [Wed, 17 Jan 2007 08:13:36 +0000 (08:13 +0000)]
WebCore:
        Reviewed by Oliver

        A few enhancements to the HTTP Auth architecture

        * platform/network/ProtectionSpace.cpp:
        (WebCore::ProtectionSpace::isProxy):
        (WebCore::ProtectionSpace::receivesCredentialSecurely):
        * platform/network/ProtectionSpace.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
aliceli1 [Wed, 17 Jan 2007 04:37:25 +0000 (04:37 +0000)]
WebCore:

        Reviewed by harrison.

        Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/EditorClient.h:
        * editing/Editor.cpp:
        (WebCore::Editor::copy):
        (WebCore::Editor::didWriteSelectionToPasteboard):
        * editing/Editor.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyEditorClient::didWriteSelectionToPasteboard):

WebKit:

        Reviewed by harrison.

        Fixed <rdar://problem/4921134> WebKit needs extensible cut/copy to allow additional types to be written to pasteboard

        * DefaultDelegates/WebDefaultEditingDelegate.m:
        (-[WebDefaultEditingDelegate webView:didWriteSelectionToPasteboard:]):
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::didWriteSelectionToPasteboard):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebEditingDelegate.h:

WebKitQt:

        Added these stubs to keep the Qt build from failing.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::didWriteSelectionToPasteboard):
        * WebCoreSupport/EditorClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Wed, 17 Jan 2007 01:10:30 +0000 (01:10 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4747450>
        Gmail Editor: Caret doesn't always position itself after list marker
        <rdar://problem/4917055>
        GMail Editor: A hang can occur when attempting to apply list styling to selected indented text

        Added:
        * editing/execCommand/4747450-expected.checksum: Added.
        * editing/execCommand/4747450-expected.png: Added.
        * editing/execCommand/4747450-expected.txt: Added.
        * editing/execCommand/4747450.html: Added.
        * editing/execCommand/4917055-expected.txt: Added.
        * editing/execCommand/4917055.html: Added.
        Fixed:
        * editing/execCommand/create-list-with-hr-expected.checksum:
        * editing/execCommand/create-list-with-hr-expected.png:
        * editing/execCommand/create-list-with-hr-expected.txt:

WebCore:

        Reviewed by harrison

        <rdar://problem/4747450>
        Gmail Editor: Caret doesn't always position itself after list marker
        <rdar://problem/4917055>
        GMail Editor: A hang can occur when attempting to apply list styling to selected indented text

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::rangeFromLocationAndLength): Use VisiblePositions
        to compute the end of a run for emitted '\n's, because it's often wrong
        in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - quick lame attempt to get Qt compiling again
darin [Wed, 17 Jan 2007 00:40:28 +0000 (00:40 +0000)]
    - quick lame attempt to get Qt compiling again

        * platform/qt/ContextMenuQt.cpp: Removed show() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-17 Nicholas Shanks <contact@nickshanks.com>
bdash [Wed, 17 Jan 2007 00:07:55 +0000 (00:07 +0000)]
2007-01-17  Nicholas Shanks  <contact@nickshanks.com>

        Reviewed by Darin.

        * platform/network/ResourceRequest.h:
        (WebCore::ResourceRequest::setHTTPAccept): Correct argument name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoClean up merge conflict spew.
bdakin [Tue, 16 Jan 2007 21:55:42 +0000 (21:55 +0000)]
Clean up merge conflict spew.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
bdakin [Tue, 16 Jan 2007 21:40:54 +0000 (21:40 +0000)]
    Reviewed by Adam.

        Get rid of show() and hide() since they don't do anything.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent):
        * platform/ContextMenu.h:
        * platform/mac/ContextMenuMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
ggaren [Tue, 16 Jan 2007 21:07:54 +0000 (21:07 +0000)]
    Reviewed by Darin Adler.

        Added re-entrency checking to GC allocation and collection. It is an error
        to allocate or collect from within a collection. We've had at least one
        case of each bug in the past.

        Added a comment to the API header, explaining that API clients must not
        make this mistake, either.

        Layout tests and JS tests pass.

        * API/JSObjectRef.h:
        * kjs/collector.cpp:
        (KJS::GCLock::GCLock):
        (KJS::GCLock::~GCLock):
        (KJS::Collector::allocate):
        (KJS::Collector::collect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - updated one more test results affected by Rob's coordinates patch
darin [Tue, 16 Jan 2007 15:38:28 +0000 (15:38 +0000)]
    - updated one more test results affected by Rob's coordinates patch

        * svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum: Regenerated.
        * svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Ditto.
        * svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Added the start of a public API to the Qt build
lars [Tue, 16 Jan 2007 15:03:44 +0000 (15:03 +0000)]
    Added the start of a public API to the Qt build
        of WebKit. Currently we have QWebPage and QWebFrame
        with a few small methods.

        Converted the QtLauncher and DumpRenderTree
        to use the new public API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Zack
lars [Tue, 16 Jan 2007 12:25:39 +0000 (12:25 +0000)]
    Reviewed by Zack

        Looks like ResourceHandle _has_ to do everything
        asynchronously if we don't want to run into
        lots of trouble in the loader.

        Implement support data: URLs.

        Remove some unused Qt only code in ResourceHandleClient.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-16 Eric Seidel <eric@webkit.org>
eseidel [Tue, 16 Jan 2007 11:40:10 +0000 (11:40 +0000)]
2007-01-16  Eric Seidel  <eric@webkit.org>

        Reviewed by mitz.

        Refactor drawTiled implementations in preparation for combining them.
        Removed unused RoundTile code path.

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::drawPattern):
        (WebCore::BitmapImage::drawTiled):
        (WebCore::caculatePatternScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe.
darin [Tue, 16 Jan 2007 08:14:29 +0000 (08:14 +0000)]
    Reviewed by Mark Rowe.

        - removed unused field from loader

        * loader/loader.cpp:
        (WebCore::Loader::numRequests):
        (WebCore::Loader::cancelRequests):
        * loader/loader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
rwlbuis [Tue, 16 Jan 2007 07:50:20 +0000 (07:50 +0000)]
    Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=12272
        SVG picture is clipped (edges not visible)

        Expose css dpi constant and use it for svg, making
        1in amount to 96 pixels like for html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej
beidson [Tue, 16 Jan 2007 07:23:27 +0000 (07:23 +0000)]
    Reviewed by Maciej

        * coding/coding-style.html: Added switch/case indentation rules

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
beidson [Tue, 16 Jan 2007 06:39:59 +0000 (06:39 +0000)]
WebCore:
        Reviewed by Adam

        CFNet additions

        * platform/network/AuthenticationChallenge.cpp:
        (WebCore::operator==):
        * platform/network/AuthenticationChallenge.h:
        (WebCore::AuthenticationChallenge::sourceHandle):
        (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
        * platform/network/ResourceError.h:
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-15 Eric Seidel <eric@webkit.org>
eseidel [Tue, 16 Jan 2007 05:25:48 +0000 (05:25 +0000)]
2007-01-15  Eric Seidel  <eric@webkit.org>

        Reviewed by hyatt.

        Don't map attributes in namespaces other than null to CSS properties.

        Test: svg/custom/attribute-namespace-check.svg

        * ksvg2/svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Tue, 16 Jan 2007 04:46:59 +0000 (04:46 +0000)]
    Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=11112
          add a drop shadow to the hand cursor used for links

        * Resources/linkCursor.png: Added a drop shadow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Tue, 16 Jan 2007 04:43:39 +0000 (04:43 +0000)]
LayoutTests:

        - test for http://bugs.webkit.org/show_bug.cgi?id=12190
          REGRESSION: Placeholder text does not reflect dynamic updates

        * fast/forms/placeholder-set-attribute-expected.checksum: Added.
        * fast/forms/placeholder-set-attribute-expected.png: Added.
        * fast/forms/placeholder-set-attribute-expected.txt: Added.
        * fast/forms/placeholder-set-attribute.html: Added.

WebCore:

        Reviewed by Adam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12190
          REGRESSION: Placeholder text does not reflect dynamic updates

        Test: fast/forms/placeholder-set-attribute.html

        * html/HTMLTextFieldInnerElement.cpp:
        (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
        Call onSearch on the element since I removed it from the renderer.

        * rendering/RenderTextControl.h: Added explicit virtual keywords for overrides
        of virtual functions. Removed the unneeded onSearch function. Made the inheritance
        from PopupMenuClient be private, and made the overrides all private. Replaced the
        showPlaceholderIfNeeded and hidePlaceholderIfNeeded functions with updatePlaceholder.
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::createResultsButtonStyle): Added an assertion.
        (WebCore::RenderTextControl::updatePlaceholder): Added. Replaces the two
        functions, showPlaceholderIfNeeded and hidePlaceholderIfNeeded.
        (WebCore::RenderTextControl::updateFromElement): Added call to
        updatePlaceholder before updating the value. Also improved the structure
        of the function and corrected incorrect use of copy and replace.
        (WebCore::RenderTextControl::updateCancelButtonVisibility): Added an
        assertion and removed an unneeded local variable.
        (WebCore::RenderTextControl::subtreeHasChanged): Removed an unneeded
        null check and virtual function calls.
        (WebCore::RenderTextControl::forwardEvent): Replaced calls to the old
        functions with calls to updatePlaceholder.
        (WebCore::RenderTextControl::selectionChanged): Changed code to dispatch
        the select event directly -- I plan to remove the onSelect function, which
        was only called here.
        (WebCore::RenderTextControl::autosaveName): Removed too-specific cast and
        local variable.
        (WebCore::RenderTextControl::addSearchResult): Added assertion and changed
        variable name for clarity.
        (WebCore::RenderTextControl::valueChanged): Changed code to check for empty
        autosave name instead of null for consistency with other call sites that
        manage the autosave name. Also changed the code that dispatches an event
        to call onSearch on the input element so we don't need our own function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-15 Eric Seidel <eric@webkit.org>
eseidel [Tue, 16 Jan 2007 04:01:57 +0000 (04:01 +0000)]
2007-01-15  Eric Seidel  <eric@webkit.org>

        Reviewed by hyatt.

        Fix SVGStyledElement::parseMappedAttribute to only map SVG-allowed CSS properties
        (i.e. width is no longer mapped to CSS for SVG)
        Add SVGStyledElement::mapToEntry to allow RenderStyle-sharing
        http://bugs.webkit.org/show_bug.cgi?id=12060

        * dom/MappedAttributeEntry.h:
        (WebCore::):
        * ksvg2/svg/SVGStyledElement.cpp:
        (WebCore::cssPropertyIdForName): new helper
        (WebCore::mapAttributeToCSSProperty): new helper
        (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): new helper
        (WebCore::SVGStyledElement::mapToEntry): added.
        (WebCore::SVGStyledElement::parseMappedAttribute): use cssPropertyIdForSVGAttributeName
        * ksvg2/svg/SVGStyledElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Tue, 16 Jan 2007 00:53:51 +0000 (00:53 +0000)]
LayoutTests:

        Reviewed by mjs

        <rdar://problem/4810960>
        Gmail Editor: window.focus() called on keyDown (9640)

        * editing/input/attributed-substring-from-range-lines.html-disabled:
        * fast/events/keydown-1-expected.checksum: Added.
        * fast/events/keydown-1-expected.png: Added.
        * fast/events/keydown-1-expected.txt: Added.
        * fast/events/keydown-1.html: Added.

WebKit:

        Reviewed by mjs

        <rdar://problem/4810960>
        Gmail Editor: window.focus() called on keyDown (9640)

        The window's keydown event handler was being called
        instead of the editable subframe's if there was a key binding
        for the key event.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView performKeyEquivalent:]): Don't send the event
        to WebCore unless this WebHTMLView is the firstResponder.

WebKitTools:

        Reviewed by mjs

        <rdar://problem/4810960>
        Gmail Editor: window.focus() called on keyDown (9640)

        * DumpRenderTree/EventSendingController.m: Send the keyDown event
        to the firstResponder, not the event's locationInWindow.  A
        key press's locationInWindow is meaningless and just a dummy
        coordinate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-15 Eric Seidel <eric@webkit.org>
eseidel [Tue, 16 Jan 2007 00:49:43 +0000 (00:49 +0000)]
2007-01-15  Eric Seidel  <eric@webkit.org>

        Reviewed by bdash.

        Update header guards to follow new style guidelines using new clean-header-guards script.

        * bindings/js/JSHTMLElementWrapperFactory.h:
        * bindings/js/JSHTMLInputElementBase.h:
        * bindings/js/JSHTMLOptionElementConstructor.h:
        * bindings/js/JSSVGElementWrapperFactory.h:
        * bindings/js/JSSVGPODTypeWrapper.h:
        * bindings/js/JSXMLHttpRequest.h:
        * bindings/js/JSXSLTProcessor.h:
        * bindings/js/kjs_binding.h:
        * bindings/js/kjs_css.h:
        * bindings/js/kjs_dom.h:
        * bindings/js/kjs_domnode.h:
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_html.h:
        * bindings/js/kjs_navigator.h:
        * bindings/js/kjs_proxy.h:
        * bindings/js/kjs_traversal.h:
        * bindings/js/kjs_window.h:
        * bridge/EditorClient.h:
        * bridge/History.h:
        * css/CSSStyleSheet.h:
        * css/CSSValue.h:
        * css/CSSValueList.h:
        * css/DashboardRegion.h:
        * css/FontFamilyValue.h:
        * css/FontValue.h:
        * css/MediaFeatureNames.h:
        * css/MediaList.h:
        * css/Pair.h:
        * css/RectImpl.h:
        * css/ShadowValue.h:
        * css/StyleBase.h:
        * css/StyleList.h:
        * css/StyleSheet.h:
        * css/StyleSheetList.h:
        * css/cssstyleselector.h:
        * dom/BeforeTextInsertedEvent.h:
        * dom/CDATASection.h:
        * dom/CharacterData.h:
        * dom/ChildNodeList.h:
        * dom/Comment.h:
        * dom/DOMImplementation.h:
        * dom/DocPtr.h:
        * dom/Document.h:
        * dom/DocumentFragment.h:
        * dom/DocumentMarker.h:
        * dom/DocumentType.h:
        * dom/EditingText.h:
        * dom/Entity.h:
        * dom/EntityReference.h:
        * dom/EventNames.h:
        * dom/EventTargetNode.h:
        * dom/NameNodeList.h:
        * dom/NamedNodeMap.h:
        * dom/Node.h:
        * dom/NodeList.h:
        * dom/Notation.h:
        * dom/Position.h:
        * dom/ProcessingInstruction.h:
        * dom/Range.h:
        * dom/StyleElement.h:
        * dom/Text.h:
        * editing/AppendNodeCommand.h:
        * editing/ApplyStyleCommand.h:
        * editing/BreakBlockquoteCommand.h:
        * editing/CommandByName.h:
        * editing/CompositeEditCommand.h:
        * editing/DeleteButton.h:
        * editing/DeleteButtonController.h:
        * editing/DeleteFromTextNodeCommand.h:
        * editing/DeleteSelectionCommand.h:
        * editing/InsertIntoTextNodeCommand.h:
        * editing/InsertLineBreakCommand.h:
        * editing/InsertNodeBeforeCommand.h:
        * editing/InsertParagraphSeparatorCommand.h:
        * editing/InsertTextCommand.h:
        * editing/JoinTextNodesCommand.h:
        * editing/MergeIdenticalElementsCommand.h:
        * editing/ModifySelectionListLevel.h:
        * editing/MoveSelectionCommand.h:
        * editing/RemoveCSSPropertyCommand.h:
        * editing/RemoveNodeAttributeCommand.h:
        * editing/RemoveNodeCommand.h:
        * editing/RemoveNodePreservingChildrenCommand.h:
        * editing/ReplaceSelectionCommand.h:
        * editing/SetNodeAttributeCommand.h:
        * editing/SplitElementCommand.h:
        * editing/SplitTextNodeCommand.h:
        * editing/SplitTextNodeContainingElementCommand.h:
        * editing/TextGranularity.h:
        * editing/TypingCommand.h:
        * editing/WrapContentsInDummySpanCommand.h:
        * history/BackForwardList.h:
        * history/HistoryItem.h:
        * history/HistoryItemTimer.h:
        * history/PageCache.h:
        * html/CanvasGradient.h:
        * html/CanvasPattern.h:
        * html/CanvasRenderingContext2D.h:
        * html/CanvasStyle.h:
        * html/FormDataList.h:
        * html/HTMLAnchorElement.h:
        * html/HTMLAppletElement.h:
        * html/HTMLAreaElement.h:
        * html/HTMLBRElement.h:
        * html/HTMLBaseElement.h:
        * html/HTMLBaseFontElement.h:
        * html/HTMLBlockquoteElement.h:
        * html/HTMLBodyElement.h:
        * html/HTMLButtonElement.h:
        * html/HTMLCanvasElement.h:
        * html/HTMLCollection.h:
        * html/HTMLDListElement.h:
        * html/HTMLDirectoryElement.h:
        * html/HTMLDivElement.h:
        * html/HTMLElement.h:
        * html/HTMLElementFactory.h:
        * html/HTMLEmbedElement.h:
        * html/HTMLFieldSetElement.h:
        * html/HTMLFontElement.h:
        * html/HTMLFormCollection.h:
        * html/HTMLFormElement.h:
        * html/HTMLFrameSetElement.h:
        * html/HTMLGenericFormElement.h:
        * html/HTMLHRElement.h:
        * html/HTMLHeadElement.h:
        * html/HTMLHeadingElement.h:
        * html/HTMLHtmlElement.h:
        * html/HTMLImageElement.h:
        * html/HTMLImageLoader.h:
        * html/HTMLInputElement.h:
        * html/HTMLIsIndexElement.h:
        * html/HTMLKeygenElement.h:
        * html/HTMLLIElement.h:
        * html/HTMLLabelElement.h:
        * html/HTMLLegendElement.h:
        * html/HTMLLinkElement.h:
        * html/HTMLMapElement.h:
        * html/HTMLMarqueeElement.h:
        * html/HTMLMenuElement.h:
        * html/HTMLMetaElement.h:
        * html/HTMLModElement.h:
        * html/HTMLNameCollection.h:
        * html/HTMLOListElement.h:
        * html/HTMLObjectElement.h:
        * html/HTMLOptGroupElement.h:
        * html/HTMLOptionElement.h:
        * html/HTMLOptionsCollection.h:
        * html/HTMLParagraphElement.h:
        * html/HTMLParamElement.h:
        * html/HTMLParser.h:
        * html/HTMLPlugInElement.h:
        * html/HTMLPreElement.h:
        * html/HTMLQuoteElement.h:
        * html/HTMLScriptElement.h:
        * html/HTMLSelectElement.h:
        * html/HTMLStyleElement.h:
        * html/HTMLTableCaptionElement.h:
        * html/HTMLTableCellElement.h:
        * html/HTMLTableColElement.h:
        * html/HTMLTableElement.h:
        * html/HTMLTablePartElement.h:
        * html/HTMLTableRowElement.h:
        * html/HTMLTableSectionElement.h:
        * html/HTMLTextAreaElement.h:
        * html/HTMLTextFieldInnerElement.h:
        * html/HTMLTitleElement.h:
        * html/HTMLUListElement.h:
        * ksvg2/css/SVGRenderStyle.h:
        * ksvg2/css/SVGRenderStyleDefs.h:
        * ksvg2/events/JSSVGLazyEventListener.h:
        * ksvg2/events/SVGZoomEvent.h:
        * ksvg2/misc/KCanvasRenderingStyle.h:
        * ksvg2/misc/PointerEventsHitRules.h:
        * ksvg2/misc/SVGDocumentExtensions.h:
        * ksvg2/misc/SVGImageLoader.h:
        * ksvg2/misc/TimeScheduler.h:
        * ksvg2/svg/GradientAttributes.h:
        * ksvg2/svg/LinearGradientAttributes.h:
        * ksvg2/svg/PatternAttributes.h:
        * ksvg2/svg/RadialGradientAttributes.h:
        * ksvg2/svg/SVGAElement.h:
        * ksvg2/svg/SVGAngle.h:
        * ksvg2/svg/SVGAnimateColorElement.h:
        * ksvg2/svg/SVGAnimateElement.h:
        * ksvg2/svg/SVGAnimateMotionElement.h:
        * ksvg2/svg/SVGAnimateTransformElement.h:
        * ksvg2/svg/SVGAnimatedPathData.h:
        * ksvg2/svg/SVGAnimatedPoints.h:
        * ksvg2/svg/SVGAnimatedTemplate.h:
        * ksvg2/svg/SVGAnimationElement.h:
        * ksvg2/svg/SVGCircleElement.h:
        * ksvg2/svg/SVGClipPathElement.h:
        * ksvg2/svg/SVGColor.h:
        * ksvg2/svg/SVGComponentTransferFunctionElement.h:
        * ksvg2/svg/SVGCursorElement.h:
        * ksvg2/svg/SVGDOMImplementation.h:
        * ksvg2/svg/SVGDefsElement.h:
        * ksvg2/svg/SVGDescElement.h:
        * ksvg2/svg/SVGDocument.h:
        * ksvg2/svg/SVGElement.h:
        * ksvg2/svg/SVGElementInstance.h:
        * ksvg2/svg/SVGElementInstanceList.h:
        * ksvg2/svg/SVGEllipseElement.h:
        * ksvg2/svg/SVGExternalResourcesRequired.h:
        * ksvg2/svg/SVGFEBlendElement.h:
        * ksvg2/svg/SVGFEColorMatrixElement.h:
        * ksvg2/svg/SVGFEComponentTransferElement.h:
        * ksvg2/svg/SVGFECompositeElement.h:
        * ksvg2/svg/SVGFEDiffuseLightingElement.h:
        * ksvg2/svg/SVGFEDisplacementMapElement.h:
        * ksvg2/svg/SVGFEDistantLightElement.h:
        * ksvg2/svg/SVGFEFloodElement.h:
        * ksvg2/svg/SVGFEFuncAElement.h:
        * ksvg2/svg/SVGFEFuncBElement.h:
        * ksvg2/svg/SVGFEFuncGElement.h:
        * ksvg2/svg/SVGFEFuncRElement.h:
        * ksvg2/svg/SVGFEGaussianBlurElement.h:
        * ksvg2/svg/SVGFEImageElement.h:
        * ksvg2/svg/SVGFELightElement.h:
        * ksvg2/svg/SVGFEMergeElement.h:
        * ksvg2/svg/SVGFEMergeNodeElement.h:
        * ksvg2/svg/SVGFEOffsetElement.h:
        * ksvg2/svg/SVGFEPointLightElement.h:
        * ksvg2/svg/SVGFESpecularLightingElement.h:
        * ksvg2/svg/SVGFESpotLightElement.h:
        * ksvg2/svg/SVGFETileElement.h:
        * ksvg2/svg/SVGFETurbulenceElement.h:
        * ksvg2/svg/SVGFilterElement.h:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
        * ksvg2/svg/SVGFitToViewBox.h:
        * ksvg2/svg/SVGForeignObjectElement.h:
        * ksvg2/svg/SVGGElement.h:
        * ksvg2/svg/SVGGradientElement.h:
        * ksvg2/svg/SVGImageElement.h:
        * ksvg2/svg/SVGLangSpace.h:
        * ksvg2/svg/SVGLength.h:
        * ksvg2/svg/SVGLengthList.h:
        * ksvg2/svg/SVGLineElement.h:
        * ksvg2/svg/SVGLinearGradientElement.h:
        * ksvg2/svg/SVGList.h:
        * ksvg2/svg/SVGListTraits.h:
        * ksvg2/svg/SVGLocatable.h:
        * ksvg2/svg/SVGMarkerElement.h:
        * ksvg2/svg/SVGMaskElement.h:
        * ksvg2/svg/SVGMetadataElement.h:
        * ksvg2/svg/SVGNumberList.h:
        * ksvg2/svg/SVGPaint.h:
        * ksvg2/svg/SVGParserUtilities.h:
        * ksvg2/svg/SVGPathElement.h:
        * ksvg2/svg/SVGPathSeg.h:
        * ksvg2/svg/SVGPathSegArc.h:
        * ksvg2/svg/SVGPathSegClosePath.h:
        * ksvg2/svg/SVGPathSegCurvetoCubic.h:
        * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
        * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
        * ksvg2/svg/SVGPathSegLineto.h:
        * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
        * ksvg2/svg/SVGPathSegLinetoVertical.h:
        * ksvg2/svg/SVGPathSegList.h:
        * ksvg2/svg/SVGPathSegMoveto.h:
        * ksvg2/svg/SVGPatternElement.h:
        * ksvg2/svg/SVGPointList.h:
        * ksvg2/svg/SVGPolyElement.h:
        * ksvg2/svg/SVGPolygonElement.h:
        * ksvg2/svg/SVGPolylineElement.h:
        * ksvg2/svg/SVGPreserveAspectRatio.h:
        * ksvg2/svg/SVGRadialGradientElement.h:
        * ksvg2/svg/SVGRectElement.h:
        * ksvg2/svg/SVGRenderingIntent.h:
        * ksvg2/svg/SVGSVGElement.h:
        * ksvg2/svg/SVGScriptElement.h:
        * ksvg2/svg/SVGSetElement.h:
        * ksvg2/svg/SVGStopElement.h:
        * ksvg2/svg/SVGStringList.h:
        * ksvg2/svg/SVGStylable.h:
        * ksvg2/svg/SVGStyleElement.h:
        * ksvg2/svg/SVGStyledElement.h:
        * ksvg2/svg/SVGStyledLocatableElement.h:
        * ksvg2/svg/SVGStyledTransformableElement.h:
        * ksvg2/svg/SVGSwitchElement.h:
        * ksvg2/svg/SVGSymbolElement.h:
        * ksvg2/svg/SVGTRefElement.h:
        * ksvg2/svg/SVGTSpanElement.h:
        * ksvg2/svg/SVGTests.h:
        * ksvg2/svg/SVGTextContentElement.h:
        * ksvg2/svg/SVGTextElement.h:
        * ksvg2/svg/SVGTextPositioningElement.h:
        * ksvg2/svg/SVGTitleElement.h:
        * ksvg2/svg/SVGTransform.h:
        * ksvg2/svg/SVGTransformList.h:
        * ksvg2/svg/SVGTransformable.h:
        * ksvg2/svg/SVGURIReference.h:
        * ksvg2/svg/SVGUnitTypes.h:
        * ksvg2/svg/SVGUseElement.h:
        * ksvg2/svg/SVGViewElement.h:
        * ksvg2/svg/SVGZoomAndPan.h:
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedImage.h:
        * loader/CachedXSLStyleSheet.h:
        * loader/DocumentLoader.h:
        * loader/Request.h:
        * loader/SubresourceLoader.h:
        * loader/icon/IconDataCache.h:
        * loader/icon/IconDatabase.h:
        * loader/icon/IconLoader.h:
        * loader/icon/SQLDatabase.h:
        * loader/icon/SQLStatement.h:
        * loader/icon/SQLTransaction.h:
        * page/Frame.h:
        * page/FrameLoadRequest.h:
        * page/FrameTree.h:
        * page/FrameView.h:
        * page/PageState.h:
        * page/Plugin.h:
        * page/qt/FrameQt.h:
        * page/qt/FrameQtClient.h:
        * platform/Arena.h:
        * platform/ArrayImpl.h:
        * platform/Cursor.h:
        * platform/DeprecatedArray.h:
        * platform/DeprecatedCString.h:
        * platform/FileChooser.h:
        * platform/Font.h:
        * platform/FontCache.h:
        * platform/FontData.h:
        * platform/FontDescription.h:
        * platform/FontFamily.h:
        * platform/GlyphBuffer.h:
        * platform/GlyphMap.h:
        * platform/GlyphWidthMap.h:
        * platform/Logging.h:
        * platform/Pasteboard.h:
        * platform/PlatformString.h:
        * platform/PlugInInfoStore.h:
        * platform/PopupMenu.h:
        * platform/PopupMenuClient.h:
        * platform/ScrollBar.h:
        * platform/ScrollView.h:
        * platform/SearchPopupMenu.h:
        * platform/Shared.h:
        * platform/Sound.h:
        * platform/SystemTime.h:
        * platform/Timer.h:
        * platform/Widget.h:
        * platform/cf/RetainPtr.h:
        * platform/gdk/ChromeClientGdk.h:
        * platform/gdk/FontPlatformData.h:
        * platform/gdk/FrameGdk.h:
        * platform/gdk/KeyboardCodes.h:
        * platform/gdk/RenderPopupMenuGdk.h:
        * platform/gdk/RenderThemeGdk.h:
        * platform/graphics/BitmapImage.h:
        * platform/graphics/Color.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatPoint3D.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/Icon.h:
        * platform/graphics/Image.h:
        * platform/graphics/ImageAnimationObserver.h:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/ImageSource.h:
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/IntSizeHash.h:
        * platform/graphics/PathTraversalState.h:
        * platform/graphics/Pen.h:
        * platform/graphics/qt/ImageDecoderQt.h:
        * platform/graphics/svg/SVGImage.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        * platform/graphics/svg/SVGPaintServer.h:
        * platform/graphics/svg/SVGPaintServerGradient.h:
        * platform/graphics/svg/SVGPaintServerLinearGradient.h:
        * platform/graphics/svg/SVGPaintServerPattern.h:
        * platform/graphics/svg/SVGPaintServerRadialGradient.h:
        * platform/graphics/svg/SVGPaintServerSolid.h:
        * platform/graphics/svg/SVGResource.h:
        * platform/graphics/svg/SVGResourceClipper.h:
        * platform/graphics/svg/SVGResourceFilter.h:
        * platform/graphics/svg/SVGResourceMarker.h:
        * platform/graphics/svg/SVGResourceMasker.h:
        * platform/graphics/svg/cg/CgSupport.h:
        * platform/graphics/svg/filters/SVGDistantLightSource.h:
        * platform/graphics/svg/filters/SVGFEBlend.h:
        * platform/graphics/svg/filters/SVGFEColorMatrix.h:
        * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
        * platform/graphics/svg/filters/SVGFEComposite.h:
        * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
        * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
        * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
        * platform/graphics/svg/filters/SVGFEFlood.h:
        * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
        * platform/graphics/svg/filters/SVGFEImage.h:
        * platform/graphics/svg/filters/SVGFEMerge.h:
        * platform/graphics/svg/filters/SVGFEMorphology.h:
        * platform/graphics/svg/filters/SVGFEOffset.h:
        * platform/graphics/svg/filters/SVGFESpecularLighting.h:
        * platform/graphics/svg/filters/SVGFETile.h:
        * platform/graphics/svg/filters/SVGFETurbulence.h:
        * platform/graphics/svg/filters/SVGFilterEffect.h:
        * platform/graphics/svg/filters/SVGLightSource.h:
        * platform/graphics/svg/filters/SVGPointLightSource.h:
        * platform/graphics/svg/filters/SVGSpotLightSource.h:
        * platform/mac/FontPlatformData.h:
        * platform/mac/PlatformScrollBar.h:
        * platform/network/AuthenticationChallenge.h:
        * platform/network/Credential.h:
        * platform/network/HTTPHeaderMap.h:
        * platform/network/ProtectionSpace.h:
        * platform/network/ResourceError.h:
        * platform/network/ResourceRequest.h:
        * platform/network/ResourceResponse.h:
        * platform/network/cf/FormDataStreamCFNet.h:
        * platform/network/cf/ResourceRequestCFNet.h:
        * platform/network/cf/ResourceResponseCFNet.h:
        * platform/network/gdk/ResourceHandleManager.h:
        * platform/network/mac/AuthenticationMac.h:
        * platform/network/mac/FormDataStreamMac.h:
        * platform/network/qt/ResourceHandleManagerKDE.h:
        * platform/network/qt/ResourceHandleManagerQt.h:
        * platform/network/win/ResourceHandleWin.h:
        * platform/qt/FontPlatformData.h:
        * platform/qt/KeyboardCodes.h:
        * platform/qt/PlatformScrollBar.h:
        * platform/qt/ScrollViewCanvasQt.h:
        * platform/qt/SharedTimerQt.h:
        * platform/win/FontPlatformData.h:
        * platform/win/PlatformScrollBar.h:
        * rendering/AutoTableLayout.h:
        * rendering/HitTestRequest.h:
        * rendering/HitTestResult.h:
        * rendering/InlineBox.h:
        * rendering/InlineFlowBox.h:
        * rendering/Length.h:
        * rendering/ListMarkerBox.h:
        * rendering/RenderBox.h:
        * rendering/RenderMenuList.h:
        * rendering/RenderPart.h:
        * rendering/RenderPartObject.h:
        * rendering/RenderPath.h:
        * rendering/RenderReplaced.h:
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGInline.h:
        * rendering/RenderSVGInlineText.h:
        * rendering/RenderSVGTSpan.h:
        * rendering/RenderSVGText.h:
        * rendering/RenderStyle.h:
        * rendering/RenderTableCol.h:
        * rendering/RenderThemeWin.h:
        * rendering/bidi.h:
        * xml/DOMParser.h:
        * xml/XPathEvaluator.h:
        * xml/XPathExpression.h:
        * xml/XPathExpressionNode.h:
        * xml/XPathFunctions.h:
        * xml/XPathNSResolver.h:
        * xml/XPathNamespace.h:
        * xml/XPathParser.h:
        * xml/XPathPath.h:
        * xml/XPathPredicate.h:
        * xml/XPathResult.h:
        * xml/XPathStep.h:
        * xml/XPathUtil.h:
        * xml/XPathValue.h:
        * xml/XPathVariableReference.h:
        * xml/XSLImportRule.h:
        * xml/XSLStyleSheet.h:
        * xml/XSLTProcessor.h:
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-01-15 Eric Seidel <eric@webkit.org>
eseidel [Tue, 16 Jan 2007 00:47:02 +0000 (00:47 +0000)]
2007-01-15  Eric Seidel  <eric@webkit.org>

        Reviewed by bdash.

        Add a script to keep our header guards squeaky clean.

        * Scripts/clean-header-guards: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18873 268f45cc-cd09-0410-ab3c-d52691b4dbfc