WebKit-https.git
9 years ago[chromium] Push culled tiles that are prepainted
commit-queue@webkit.org [Tue, 20 Mar 2012 03:10:45 +0000 (03:10 +0000)]
[chromium] Push culled tiles that are prepainted
https://bugs.webkit.org/show_bug.cgi?id=81552

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/WebCore:

If a tile was culled during paint, but then prepainted in the following
idle paint pass, it was still marked as culled (and thus dirty) and not
pushed to the impl side.

Renames tile->m_updateCulled to tile->m_updated. This value is true if
the tile is updated any time during a commit, and remains false if it
is culled every time the layer is painted.

Unit test: TiledLayerChromiumTest.pushIdlePaintedOccludedTiles

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::updateCompositorResources):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):

Source/WebKit/chromium:

* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81617 fast/repaint/canvas-putImageData.html...
slewis@apple.com [Tue, 20 Mar 2012 03:09:08 +0000 (03:09 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81617 fast/repaint/canvas-putImageData.html fails on the Lion bots

Unreviewed.

Check in new expected (failing?) results.

* platform/mac/fast/repaint/canvas-putImageData-expected.txt: Added.
* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaselining float-in-float-hit-testing and 056 in response
keishi@webkit.org [Tue, 20 Mar 2012 03:08:21 +0000 (03:08 +0000)]
[chromium] Rebaselining float-in-float-hit-testing and 056 in response
to r111281.

* platform/chromium-mac/fast/block/float/float-in-float-hit-testing-expected.txt: Added.
* platform/chromium-mac/fast/block/margin-collapse/056-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA bunch of media tests failing on Lion Intel Debug WebKit1 and WebKit2 testers.
jberlin@webkit.org [Tue, 20 Mar 2012 03:05:35 +0000 (03:05 +0000)]
A bunch of media tests failing on Lion Intel Debug WebKit1 and WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81623

Rebaseline failing mac and mac-wk2 media tests.

* platform/mac-wk2/media/no-auto-play-in-sandbox-expected.txt: Added.
* platform/mac-wk2/media/video-playing-and-pause-expected.txt:
* platform/mac/media/audio-controls-rendering-expected.png:
* platform/mac/media/controls-after-reload-expected.png:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-layout-direction-expected.png:
* platform/mac/media/controls-strict-expected.png:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/media-controls-clone-expected.png:
* platform/mac/media/video-colorspace-yuv420-expected.png: Added.
* platform/mac/media/video-colorspace-yuv422-expected.png: Added.
* platform/mac/media/video-controls-rendering-expected.png:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.png:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-layer-crash-expected.png:
* platform/mac/media/video-no-audio-expected.png:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.png:
* platform/mac/media/video-playing-and-pause-expected.txt:
* platform/mac/media/video-size-intrinsic-scale-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows build.
andersca@apple.com [Tue, 20 Mar 2012 03:02:12 +0000 (03:02 +0000)]
Fix Windows build.

* FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerDeviceScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Snow Leopard build.
andersca@apple.com [Tue, 20 Mar 2012 02:57:33 +0000 (02:57 +0000)]
Fix Snow Leopard build.

* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::createTileLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium compile fix - put all TRACE_*s in their own scope explicitly.
jamesr@google.com [Tue, 20 Mar 2012 02:54:16 +0000 (02:54 +0000)]
Unreviewed chromium compile fix - put all TRACE_*s in their own scope explicitly.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html...
timothy_horton@apple.com [Tue, 20 Mar 2012 02:52:47 +0000 (02:52 +0000)]
[WK2] http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html fails after r97360
https://bugs.webkit.org/show_bug.cgi?id=70245

Unreviewed; skip failing http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html on mac-wk2.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81610 fast/regions fail on Lion bots
slewis@apple.com [Tue, 20 Mar 2012 02:47:11 +0000 (02:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81610 fast/regions fail on Lion bots

Unreviewed.

Check in new expected (failing?) results.

* platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoclean up gitignore
tony@chromium.org [Tue, 20 Mar 2012 02:45:48 +0000 (02:45 +0000)]
clean up gitignore
https://bugs.webkit.org/show_bug.cgi?id=81594

Reviewed by James Robinson.

* .gitignore: .suo files are per-user files used by VS2010. .ninja
files are no longer generated in the tree-- they are generated in the
build directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81608 fast/multicol/span/span-as-immediate...
slewis@apple.com [Tue, 20 Mar 2012 02:44:25 +0000 (02:44 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81608 fast/multicol/span/span-as-immediate‚Ķ fail on Lion bots

Unreviewed.

Check in new expected (failing?) results.

* platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] http/tests/navigation/https-in-page-cache.html times out on mac-wk2
timothy_horton@apple.com [Tue, 20 Mar 2012 02:40:32 +0000 (02:40 +0000)]
[WK2] http/tests/navigation/https-in-page-cache.html times out on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=81622

Unreviewed; skip failing http/tests/navigation/https-in-page-cache.html on mac-wk2.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebKit/gtk: [GTK] Allow running run-gtk-tests during 'make dist'
mrobinson@webkit.org [Tue, 20 Mar 2012 02:34:53 +0000 (02:34 +0000)]
Source/WebKit/gtk: [GTK] Allow running run-gtk-tests during 'make dist'
https://bugs.webkit.org/show_bug.cgi?id=81415

Reviewed by Philippe Normand.

* GNUmakefile.am: Remove 'make check' rules from the makefile
Instead this functionality is now in the Tools makefile.

Tools: [GTK] Allow running run-gtk-tests during 'make distcheck'
https://bugs.webkit.org/show_bug.cgi?id=81415

Reviewed by Philippe Normand.

Modify the build and run-gtk-tests so that it can run during 'make distcheck'

* GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
main command run during 'make check.'
* Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
a requirement to run it. If jhbuild isn't around it will simply not start the
SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
main loop and simply use the main loop in a synchronous method to start SPI
daemons. Did a bunch of general cleanup around these tasks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] http/tests/navigation/anchor-frames-gbk.html fails
timothy_horton@apple.com [Tue, 20 Mar 2012 02:30:24 +0000 (02:30 +0000)]
[WK2] http/tests/navigation/anchor-frames-gbk.html fails
https://bugs.webkit.org/show_bug.cgi?id=76896
<rdar://problem/11078978>

Unreviewed; skip failing http/tests/navigation/anchor-frames-gbk.html on mac-wk2.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] return true/false on GestureFlingCancel if a fling was stopped
commit-queue@webkit.org [Tue, 20 Mar 2012 02:28:14 +0000 (02:28 +0000)]
[chromium] return true/false on GestureFlingCancel if a fling was stopped
https://bugs.webkit.org/show_bug.cgi?id=81563

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agojhbuild: Use the multiprocessing module to get the number of CPUs.
kubo@profusion.mobi [Tue, 20 Mar 2012 02:27:13 +0000 (02:27 +0000)]
jhbuild: Use the multiprocessing module to get the number of CPUs.
https://bugs.webkit.org/show_bug.cgi?id=81585

Reviewed by Martin Robinson.

Now that support for Python 2.5 has been dropped, we can safely
use multiprocessing.cpu_count() to obtain the current number of
CPUs in the system instead of running a webkitperl script for
that.

* efl/common.py:
(top_level_path):
* efl/jhbuildrc:
* gtk/common.py:
(build_path):
* gtk/jhbuildrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Adding support for GL_EXT_discard_framebuffer.
commit-queue@webkit.org [Tue, 20 Mar 2012 02:25:55 +0000 (02:25 +0000)]
[chromium] Adding support for GL_EXT_discard_framebuffer.
https://bugs.webkit.org/show_bug.cgi?id=81383

Patch by Michal Mocny <mmocny@google.com> on 2012-03-19
Reviewed by James Robinson.

Source/Platform:

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::discardFramebufferEXT):
(WebKit::WebGraphicsContext3D::ensureFramebufferCHROMIUM):

Source/WebCore:

* platform/graphics/chromium/Extensions3DChromium.h:

Source/WebKit/chromium:

* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
* src/GraphicsContext3DChromium.cpp:
(WebCore):
* src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* tests/FakeWebGraphicsContext3D.h:
(WebKit::FakeWebGraphicsContext3D::discardFramebufferEXT):
(WebKit::FakeWebGraphicsContext3D::ensureFramebufferCHROMIUM):
(FakeWebGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWe should only add a live event listener once, not once per TestSelector.
ojan@chromium.org [Tue, 20 Mar 2012 02:20:01 +0000 (02:20 +0000)]
We should only add a live event listener once, not once per TestSelector.
Adding one per TestSelector would cause accordion('option', 'active') to
incorrectly be "false" if you examine multiple sets of tests.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor ContainerNode::replaceChild to match other mutation methods and share code
adamk@chromium.org [Tue, 20 Mar 2012 02:19:08 +0000 (02:19 +0000)]
Refactor ContainerNode::replaceChild to match other mutation methods and share code
https://bugs.webkit.org/show_bug.cgi?id=81579

Reviewed by Ojan Vafai.

A future change will make use of the consistency among insertBefore/appendChild/replaceChild
to handle insertion of DocumentFragments more cleanly.

No new tests, no change in behavior.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild): Use collectTargetNodes rather than walking through DocumentFragment children.
Insert before rather than inserting after. Dispatch to other methods to update parent/sibling pointers.
(WebCore::ContainerNode::appendChild): Call appendChildToContainer to update parent/sibling pointers.
(WebCore::ContainerNode::parserAddChild): Use type inference in call to appendChildToContainer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttp/tests/misc/acid3.html fails on mac-lion-wk2
timothy_horton@apple.com [Tue, 20 Mar 2012 02:19:01 +0000 (02:19 +0000)]
http/tests/misc/acid3.html fails on mac-lion-wk2
https://bugs.webkit.org/show_bug.cgi?id=81621
<rdar://problem/11078942>

Unreviewed; check in failing results for mac-wk2.

* platform/mac-wk2/http/tests/misc/acid3-expected.png: Added.
* platform/mac-wk2/http/tests/misc/acid3-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Times in the cc should be expressed in seconds.
commit-queue@webkit.org [Tue, 20 Mar 2012 02:15:48 +0000 (02:15 +0000)]
[chromium] Times in the cc should be expressed in seconds.
https://bugs.webkit.org/show_bug.cgi?id=80514

Patch by Ian Vollick <vollick@chromium.org> on 2012-03-19
Reviewed by James Robinson.

Source/WebCore:

Updated timer tests to use seconds.

* platform/TouchFlingPlatformGestureCurve.h:
(TouchFlingPlatformGestureCurve):
* platform/graphics/chromium/cc/CCActiveGestureAnimation.cpp:
(WebCore::CCActiveGestureAnimation::animate):
* platform/graphics/chromium/cc/CCActiveGestureAnimation.h:
(CCActiveGestureAnimation):
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
(WebCore::CCDelayBasedTimeSource::create):
(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource):
(WebCore::CCDelayBasedTimeSource::setActive):
(WebCore::CCDelayBasedTimeSource::onTimerFired):
(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):
(WebCore):
(WebCore::CCDelayBasedTimeSource::postNextTickTask):
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
(CCDelayBasedTimeSource):
* platform/graphics/chromium/cc/CCGestureCurve.h:
(CCGestureCurve):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WTF):
(WebCore::CCThreadProxy::beginContextRecreation):
(WebCore::CCThreadProxy::tryToRecreateContext):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
* platform/graphics/chromium/cc/CCTimer.cpp:
(WebCore::CCTimer::startOneShot):
* platform/graphics/chromium/cc/CCTimer.h:
(CCTimer):

Source/WebKit/chromium:

* tests/CCDelayBasedTimeSourceTest.cpp:
(WebKitTests::TEST):
* tests/CCFrameRateControllerTest.cpp:
(WebKitTests::TEST):
* tests/CCSchedulerTestCommon.h:
(WebKitTests::FakeCCThread::pendingDelayMs):
(WebKitTests::FakeCCDelayBasedTimeSource::create):
(WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicallyIncreasingTime):
(WebKitTests::FakeCCDelayBasedTimeSource::monotonicallyIncreasingTime):
(WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource):
(FakeCCDelayBasedTimeSource):
* tests/CCTimerTest.cpp:
(WebKitTests::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typo introduced in r111293.
dpranke@chromium.org [Tue, 20 Mar 2012 02:10:44 +0000 (02:10 +0000)]
Fix typo introduced in r111293.

Unreviewed, build fix.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._check_for_driver_crash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSimplify SmallStrings
benjamin@webkit.org [Tue, 20 Mar 2012 02:09:38 +0000 (02:09 +0000)]
Simplify SmallStrings
https://bugs.webkit.org/show_bug.cgi?id=81445

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-19
Reviewed by Gavin Barraclough.

SmallStrings had two methods that should not be public: count() and clear().

The method clear() is effectively replaced by finalizeSmallStrings(). The body
of the method was moved to the constructor since the code is obvious.

The method count() is unused.

* runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings):
* runtime/SmallStrings.h:
(SmallStrings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] WebKitTestRunner needs to print frame load delegate information
timothy_horton@apple.com [Tue, 20 Mar 2012 02:04:35 +0000 (02:04 +0000)]
[WK2] WebKitTestRunner needs to print frame load delegate information
https://bugs.webkit.org/show_bug.cgi?id=42705

Skip http/tests/loading/state-object-security-exception.html until WKTR prints frame load delegate information.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/dom/Window/window-properties.html failing on Lion Intel Debug WebKit1 and WebKit2
jberlin@webkit.org [Tue, 20 Mar 2012 02:01:50 +0000 (02:01 +0000)]
fast/dom/Window/window-properties.html failing on Lion Intel Debug WebKit1 and WebKit2
testers.
https://bugs.webkit.org/show_bug.cgi?id=81612

Update the expected (failing?) results to get the bots green.

* platform/mac/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/harness/page-cache-crash-on-data-urls.html and fast/harness/use-page-cache.html...
jberlin@webkit.org [Tue, 20 Mar 2012 02:01:43 +0000 (02:01 +0000)]
fast/harness/page-cache-crash-on-data-urls.html and fast/harness/use-page-cache.html fail on
Lion Intel Debug WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81616

Skip the flakey one and add expected failing results for the other.

* platform/mac-wk2/fast/harness/use-page-cache-expected.txt: Added.
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop messing with the AppKit grow box on platforms that don't support it
weinig@apple.com [Tue, 20 Mar 2012 01:45:52 +0000 (01:45 +0000)]
Stop messing with the AppKit grow box on platforms that don't support it
<rdar://problem/10752048>
https://bugs.webkit.org/show_bug.cgi?id=81614

Reviewed by Dan Bernstein.

* UIProcess/API/mac/WKView.mm:
(-[WKView viewWillMoveToWindow:]):
(-[WKView _didChangeScrollbarsForMainFrame]):
Snow Leopard was the last Mac OS to need a grow box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Support layoutTestController.dumpProgressFinishedCallback() in WKTR
timothy_horton@apple.com [Tue, 20 Mar 2012 01:41:15 +0000 (01:41 +0000)]
[WK2] Support layoutTestController.dumpProgressFinishedCallback() in WKTR
https://bugs.webkit.org/show_bug.cgi?id=81613

Unreviewed; skip http/tests/loading/progress-finished-callback.html on mac-wk2.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: get ServerProcess out of the reportcrash business
dpranke@chromium.org [Tue, 20 Mar 2012 01:33:01 +0000 (01:33 +0000)]
webkitpy: get ServerProcess out of the reportcrash business
https://bugs.webkit.org/show_bug.cgi?id=81600

Reviewed by Adam Barth.

ServerProcess was half-aware that ReportCrash might run
sometimes, and that the process ServerProcess was talking to
might have its own crashing subprocesses; neither of these
things really worked right and it made the logic convoluted, so
this change makes handling crashes completely separate from the
server_process code, so that it can focus on just I/O to the
subprocess.

There should be no functional changes resulting from this patch.

* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._reset):
(ServerProcess._handle_possible_interrupt):
(ServerProcess.write):
(ServerProcess.read_stdout):
(ServerProcess.has_crashed):
(ServerProcess._read):
(ServerProcess.stop):
* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TrivialMockPort.check_for_leaks):
(TestServerProcess.test_broken_pipe):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._read_image_diff):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
(WebKitDriver._read_block):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(MockServerProcess.__init__):
(MockServerProcess):
(MockServerProcess.has_crashed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed new mac baselines for fast/css/font-family-pictograph and fast/css/pseudo...
timothy_horton@apple.com [Tue, 20 Mar 2012 01:29:42 +0000 (01:29 +0000)]
Unreviewed new mac baselines for fast/css/font-family-pictograph and fast/css/pseudo-first-line-border-width.

* platform/mac/fast/css/font-family-pictograph-expected.png: Added.
* platform/mac/fast/css/font-family-pictograph-expected.txt:
* platform/mac/fast/css/pseudo-first-line-border-width-expected.png: Added.
* platform/mac/fast/css/pseudo-first-line-border-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: crashlog parsing is broken
dpranke@chromium.org [Tue, 20 Mar 2012 01:28:48 +0000 (01:28 +0000)]
webkitpy: crashlog parsing is broken
https://bugs.webkit.org/show_bug.cgi?id=81586

Reviewed by Adam Barth.

Seeking on a file opened through codecs() appears to not work
correctly (at least on SL).

The code was more complicated than it needed to be, so I have
revamped it to just read a full crashlog at once and then look
for matches.

I have also added the ability to optionally propagate
errors back (which can be helpful to debug races when ReportCrash is
still running and you need to see that you couldn't open some
files, rather than just ignoring them).

* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.find_newest_log):
(CrashLogs._find_newest_log_darwin):
* Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.test_find_log_darwin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/loader/window-properties-restored-from-page-cache.html timing out on Lion Intel...
jberlin@webkit.org [Tue, 20 Mar 2012 01:28:28 +0000 (01:28 +0000)]
fast/loader/window-properties-restored-from-page-cache.html timing out on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81609

Skip it to get the bots green.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: clean up some port._filesystem references to not reference private members
dpranke@chromium.org [Tue, 20 Mar 2012 01:25:54 +0000 (01:25 +0000)]
webkitpy: clean up some port._filesystem references to not reference private members
https://bugs.webkit.org/show_bug.cgi?id=81595

Reviewed by Eric Seidel.

There should be no functional changes in this patch, just some
refactoring. Also, fixes a minor nit in write_image_diff_files(()

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.__init__):
(SingleTestRunner._run_compare_test):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._save_baseline_data):
(SingleTestRunner._handle_error):
(SingleTestRunner._run_reftest):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
(TestResultWriter.__init__):
(TestResultWriter._make_output_directory):
(TestResultWriter.output_filename):
(TestResultWriter._output_testname):
(TestResultWriter.write_output_files):
(TestResultWriter.write_stderr):
(TestResultWriter.write_crash_report):
(TestResultWriter.create_text_diff_and_write_result):
(TestResultWriter.write_image_diff_files):
(copy_file):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_reftest_diff_image):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: fix nit - incorrect reference to DRT in test_expectations.py
dpranke@chromium.org [Tue, 20 Mar 2012 01:22:45 +0000 (01:22 +0000)]
webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
https://bugs.webkit.org/show_bug.cgi?id=81598

Reviewed by Eric Seidel.

"DumpRenderTree" shouldn't be hard-coded here, since some other
process may actually be crashing (WebKitTestRunner, WebProcess, etc.)

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: allow instance data in TestFailure objects
dpranke@chromium.org [Tue, 20 Mar 2012 01:21:16 +0000 (01:21 +0000)]
webkitpy: allow instance data in TestFailure objects
https://bugs.webkit.org/show_bug.cgi?id=81580

Reviewed by Tony Chang.

Current TestFailures are basically enums, but it would be nice,
especially for crashes, if they contained the name and pid of
the process that crashed.

* Scripts/webkitpy/layout_tests/models/test_failures.py:
(TestFailure.message):
(FailureTimeout.message):
(FailureCrash):
(FailureCrash.__init__):
(FailureCrash.message):
(FailureMissingResult.message):
(FailureTextMismatch.message):
(FailureMissingImageHash.message):
(FailureMissingImage.message):
(FailureImageHashMismatch.message):
(FailureImageHashIncorrect.message):
(FailureReftestMismatch.message):
(FailureReftestMismatchDidNotOccur.message):
(FailureReftestNoImagesGenerated.message):
(FailureMissingAudio.message):
(FailureAudioMismatch.message):
* Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
(TestFailuresTest.test_equals):
(TestFailuresTest):
(TestFailuresTest.test_crashes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA bunch of jquery tests are timing out on the Lion Intel Debug WebKit2 testers.
jberlin@webkit.org [Tue, 20 Mar 2012 01:16:20 +0000 (01:16 +0000)]
A bunch of jquery tests are timing out on the Lion Intel Debug WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81606

Skip them to get the bots green.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Stop deriving WebCompositor from WebCompositorInputHandler
nduca@chromium.org [Tue, 20 Mar 2012 01:13:38 +0000 (01:13 +0000)]
[chromium] Stop deriving WebCompositor from WebCompositorInputHandler
https://bugs.webkit.org/show_bug.cgi?id=80586

Reviewed by Darin Fisher.

* public/WebCompositor.h:
(WebKit):
* public/WebCompositorInputHandler.h:
(WebCompositorInputHandler):
* public/WebWidgetClient.h:
(WebWidgetClient):
(WebKit::WebWidgetClient::didActivateCompositor):
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandler::fromIdentifier):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA bunch of media tests time out on the Lion Intel Debug WebKit1 and WebKit2 testers.
jberlin@webkit.org [Tue, 20 Mar 2012 01:06:21 +0000 (01:06 +0000)]
A bunch of media tests time out on the Lion Intel Debug WebKit1 and WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81604

Skip them to get the bots green.

* platform/mac/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed new mac baseline for compositing/repaint/become-overlay-composited-layer...
timothy_horton@apple.com [Tue, 20 Mar 2012 01:02:37 +0000 (01:02 +0000)]
Unreviewed new mac baseline for compositing/repaint/become-overlay-composited-layer.html.

* platform/mac/compositing/repaint/become-overlay-composited-layer-expected.png:
* platform/mac/compositing/repaint/become-overlay-composited-layer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed skip of canvas/philip/tests/2d.path.arc.scale.1.html as an addition to...
timothy_horton@apple.com [Tue, 20 Mar 2012 00:53:57 +0000 (00:53 +0000)]
Unreviewed skip of canvas/philip/tests/2d.path.arc.scale.1.html as an addition to trac.webkit.org/changeset/111278

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed mac baselines for some fast/block tests after http://trac.webkit.org/chang...
timothy_horton@apple.com [Tue, 20 Mar 2012 00:47:52 +0000 (00:47 +0000)]
Unreviewed mac baselines for some fast/block tests after trac.webkit.org/changeset/97596

* platform/mac/fast/block/float/float-in-float-hit-testing-expected.png:
* platform/mac/fast/block/float/float-in-float-hit-testing-expected.txt:
* platform/mac/fast/block/margin-collapse/056-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA bunch of inspector tests time out on Lion Intel Debug WebKit2 testers.
jberlin@webkit.org [Tue, 20 Mar 2012 00:40:38 +0000 (00:40 +0000)]
A bunch of inspector tests time out on Lion Intel Debug WebKit2 testers.
https://bugs.webkit.org/show_bug.cgi?id=81601

Skip them on WK2 to get the bots green.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRelative-height block SVG root not layed out on container height change
commit-queue@webkit.org [Tue, 20 Mar 2012 00:37:32 +0000 (00:37 +0000)]
Relative-height block SVG root not layed out on container height change
https://bugs.webkit.org/show_bug.cgi?id=81513

Patch by Florin Malita <fmalita@google.com> on 2012-03-19
Reviewed by Dirk Schulze.

Source/WebCore:

Tests: svg/custom/svg-percent-scale-block-expected.html
       svg/custom/svg-percent-scale-block.html

A couple of places still have style()->logical{Min,Max,}Height percent checks,
which do not work for SVG elements. This patch adds a virtual hasRelativeLogicalHeight()
RenderBox method to replace the explicit style checks.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren):
Use virtual hasRelativeLogicalHeight() instead of logical height style checks.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::hasRelativeLogicalHeight):
(WebCore):
* rendering/RenderBox.h:
(RenderBox):
Add virtual hasRelativeLogicalHeight().

* rendering/RenderView.cpp:
(WebCore::RenderView::layout):
Use virtual hasRelativeLogicalHeight() instead of logical height style checks, if possible.

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::hasRelativeLogicalHeight):
(WebCore):
* rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot):
Add hasRelativeLogicalHeight() override.

LayoutTests:

* svg/custom/svg-percent-scale-block-expected.html: Added.
* svg/custom/svg-percent-scale-block.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFour fast/canvas tests are flaky (fail on bots, not locally, or vice versa)
timothy_horton@apple.com [Tue, 20 Mar 2012 00:33:00 +0000 (00:33 +0000)]
Four fast/canvas tests are flaky (fail on bots, not locally, or vice versa)
https://bugs.webkit.org/show_bug.cgi?id=81599
<rdar://problem/11078302>

Unreviewed skip of four flaky tests:

fast/canvas/canvas-createPattern-fillRect-shadow.html
fast/canvas/canvas-draw-canvas-on-canvas-shadow.html
fast/canvas/canvas-fillRect-gradient-shadow.html
fast/canvas/set-colors.html

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAssertion failure in RenderBlock::addChildIgnoringAnonymousColumnBlocks when running...
jer.noble@apple.com [Tue, 20 Mar 2012 00:20:41 +0000 (00:20 +0000)]
Assertion failure in RenderBlock::addChildIgnoringAnonymousColumnBlocks when running fullscreen/full-screen-twice-crash.html
causing "crashes" on the Lion Intel Debug WebKit2 test bots.
https://bugs.webkit.org/show_bug.cgi?id=81171

Reviewed by Dan Bernstein.

No new tests; fixes fullscreen/* tests when running in WebKitTestRunner (WebKit2).

Add a special-case check if the parent anonymous container is a full screen renderer or placeholder.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: create sandbox extensions for files that are dropped in an input control.
enrica@apple.com [Tue, 20 Mar 2012 00:12:22 +0000 (00:12 +0000)]
WebKit2: create sandbox extensions for files that are dropped in an input control.
https://bugs.webkit.org/show_bug.cgi?id=81153
<rdar://problem/11031207>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Now the pasteboard access is performed only in the UI process, it is
necessary to create sandbox extensions for each file that is dropped into
an input type=file element. The extensions are created at the time the files
are dropped and consumed immediately.

* page/DragActions.h: Added new drag action to be used by the WebDragClient.
* page/DragController.cpp:
(WebCore::DragController::concludeEditDrag): Added call to the drag client with the new action.

Source/WebKit/mac:

* WebCoreSupport/WebDragClient.mm:
(WebDragClient::willPerformDragDestinationAction): Avoid calling the delegate with the new drag action.
We want to avoid any unwanted side effects for the WebKit clients.

Source/WebKit2:

Now the pasteboard access is performed only in the UI process, it is
necessary to create sandbox extensions for each file that is dropped into
an input type=file element. The extensions are created at the time the files
are dropped and consumed immediately.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction): Added template that takes 8 arguments.
* Shared/SandboxExtension.h:
(HandleArray): Added new class to handle an array of sandbox extension handles.
(WebKit::SandboxExtension::HandleArray::HandleArray):
(WebKit::SandboxExtension::HandleArray::~HandleArray):
(WebKit::SandboxExtension::HandleArray::resize):
(WebKit::SandboxExtension::HandleArray::operator[]):
(WebKit::SandboxExtension::HandleArray::size):
(WebKit::SandboxExtension::HandleArray::encode):
(WebKit::SandboxExtension::HandleArray::decode):
* Shared/mac/SandboxExtensionMac.mm: Added new class implementation.
(WebKit::SandboxExtension::HandleArray::HandleArray):
(WebKit::SandboxExtension::HandleArray::~HandleArray):
(WebKit::SandboxExtension::HandleArray::resize):
(WebKit::SandboxExtension::HandleArray::operator[]):
(WebKit::SandboxExtension::HandleArray::size):
(WebKit::SandboxExtension::HandleArray::encode):
(WebKit::SandboxExtension::HandleArray::decode):
* UIProcess/API/mac/WKView.mm:
(createSandboxExtensionsForFileUpload):
(-[WKView performDragOperation:]): Added logic to create the sandbox extensions for each
file/directory being dropped.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDrag):
(WebKit::WebPageProxy::performDragControllerAction): Added the handle array parameter.
* UIProcess/WebPageProxy.h:
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleDropEvent):
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::Drop):
* WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::willPerformDragDestinationAction): Added handling of the new DragActionUpload.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::getPathnamesForType): Implemented using message to the UI process.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::performUploadDragDestinationAction): Added method that consumes the received extensions.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Chromium Win
eric@webkit.org [Tue, 20 Mar 2012 00:08:56 +0000 (00:08 +0000)]
Fix Chromium Win
https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.

* platform/graphics/chromium/TransparencyWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the chromium world.
eric@webkit.org [Tue, 20 Mar 2012 00:02:08 +0000 (00:02 +0000)]
Fix the chromium world.
https://bugs.webkit.org/show_bug.cgi?id=81281

Unreviewed build fix.

* rendering/RenderThemeChromiumSkia.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG can no longer compile V8-v4/regexp in debug mode
fpizlo@apple.com [Mon, 19 Mar 2012 23:59:12 +0000 (23:59 +0000)]
DFG can no longer compile V8-v4/regexp in debug mode
https://bugs.webkit.org/show_bug.cgi?id=81592

Reviewed by Gavin Barraclough.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
beidson@apple.com [Mon, 19 Mar 2012 23:59:07 +0000 (23:59 +0000)]
<rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
Crash in 3rd party WebKit apps under XHR/Cache code

Reviewed by Antti Koivisto.

Source/WebCore:

No new layout tests.
TestWebKitAPI test MemoryCachePruneWithinResourceLoadDelegate included

A CachedResource representing an XHR was being deleted by cache pruning during a delegate callback.
This worked until http://trac.webkit.org/changeset/98380

* history/PageCache.cpp:
(WebCore::PageCache::releaseAutoreleasedPagesNow): Only trigger pruning after the page cache
  autorelease if it was enabled before.

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::loadResource): Disable pruning before loading the resource and
  re-enable it afterwards if necessary.

* loader/cache/MemoryCache.h:
(WebCore::MemoryCache::pruneEnabled):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
* TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
(-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
(-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
(-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows build.
andersca@apple.com [Mon, 19 Mar 2012 23:46:13 +0000 (23:46 +0000)]
Fix Windows build.

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDeviceScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Implement fling-by-wheel on compositor thread
jamesr@google.com [Mon, 19 Mar 2012 23:45:10 +0000 (23:45 +0000)]
[chromium] Implement fling-by-wheel on compositor thread
https://bugs.webkit.org/show_bug.cgi?id=81462

Reviewed by Adrienne Walker.

Source/WebCore:

Adds compositor thread support for a fling type implemented as a sequence of wheel scrolls. Covered by new tests
in WebCompositorInputHandlerImplTests.

* platform/graphics/chromium/cc/CCInputHandler.h:
(CCInputHandler):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::scheduleAnimation):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):

Source/WebKit/chromium:

Implement fling-by-wheel and beef up existing unit test coverage considerably by using gmock instead of mocking
by hand.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
(WebKit):
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::animate):
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
* tests/WebCompositorInputHandlerImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPrediction propagation for UInt32ToNumber incorrectly assumes that outs outcome does not
fpizlo@apple.com [Mon, 19 Mar 2012 23:36:59 +0000 (23:36 +0000)]
Prediction propagation for UInt32ToNumber incorrectly assumes that outs outcome does not
change throughout the fixpoint
https://bugs.webkit.org/show_bug.cgi?id=81583

Reviewed by Michael Saboff.

* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [mac/chromium] Change platform code to use pixelSnappedRect methods
eae@chromium.org [Mon, 19 Mar 2012 23:33:53 +0000 (23:33 +0000)]
Source/WebCore: [mac/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

Change platform code to use Node::getPixelSnappedRect,
pixelSnappedBoundingBoxRect and pixelSnappedAbsoluteClippedOverflowRect
to avoid exposing subpixel types to the platform layer.

No new tests.

* WebCore.exp.in:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::pixelSnappedAbsoluteClippedOverflowRect):
Add pixelSnapped version of absoluteClippedOverflowRect

(WebCore):
* rendering/RenderObject.h:
(RenderObject):

Source/WebKit/chromium: [mac/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::applyAutofillSuggestions):
(WebKit::WebViewImpl::refreshAutofillPopup):

Source/WebKit/mac: [mac/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
* WebView/WebFrame.mm:
(-[WebFrame _getVisibleRect:]):
(-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
* WebView/WebView.mm:
(-[WebView _dashboardRegions]):
(-[WebView trackedRepaintRects]):

Source/WebKit/qt: [mac/qt/chromium] Change platform code to use pixelSnappedRect methods
https://bugs.webkit.org/show_bug.cgi?id=81016

Reviewed by Eric Seidel.

* Api/qwebelement.cpp:
(QWebElement::geometry):
(QWebElement::render):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
beidson@apple.com [Mon, 19 Mar 2012 23:20:56 +0000 (23:20 +0000)]
<rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format

Reviewed by Enrica Casucci.

Source/WebCore:

r107435 started saving/restoring URLs as strings.
We need to go back to setting the URL on the pasteboard using AppKit URL pasteboard APIs.

WebKit API test: ContextMenuCanCopyURL
No WebKit2 API test possible at this time.

* platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::setURL):

Tools:

Bring up a context menu on a link, copy the link, then verify the pasteboard contents
are in the correct format.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
* TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
(-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::contextMenuCopyLink):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake the TileCache work with HiDPI again
andersca@apple.com [Mon, 19 Mar 2012 23:11:15 +0000 (23:11 +0000)]
Make the TileCache work with HiDPI again
https://bugs.webkit.org/show_bug.cgi?id=81569
<rdar://problem/11031542>

Reviewed by Sam Weinig.

Set the contentsScale of the individual tile layers to be the same as the device scale factor.
Also, take into account the fact that the value passed to TileCache::setScale is the product of the
page scale factor and the device scale factor, so divide it by the device scale factor before storing
it in m_scale.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerDeviceScaleFactor):
(WebCore):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
* platform/graphics/ca/PlatformCALayerClient.h:
(PlatformCALayerClient):
* platform/graphics/ca/mac/TileCache.h:
(TileCache):
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache):
(WebCore::TileCache::setScale):
(WebCore::TileCache::createTileLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShadow DOM is not enabled on Mac, so skip the whole directory instead of skipping...
jberlin@webkit.org [Mon, 19 Mar 2012 23:02:32 +0000 (23:02 +0000)]
Shadow DOM is not enabled on Mac, so skip the whole directory instead of skipping the tests
one by one.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGC should not attempt to clear LLInt instruction inline caches for code blocks that...
fpizlo@apple.com [Mon, 19 Mar 2012 23:01:57 +0000 (23:01 +0000)]
GC should not attempt to clear LLInt instruction inline caches for code blocks that are in
the process of being generated
https://bugs.webkit.org/show_bug.cgi?id=81565

Reviewed by Oliver Hunt.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash due to layer tree information not updated when moving run-in children.
inferno@chromium.org [Mon, 19 Mar 2012 22:53:57 +0000 (22:53 +0000)]
Crash due to layer tree information not updated when moving run-in children.
https://bugs.webkit.org/show_bug.cgi?id=81265

Reviewed by Julien Chaffraix.

Source/WebCore:

We need to do a full removal as the run-in child is getting inserted into
the neighbouring block and |blockRunIn| is going to be destroyed later
in the function.

Test: fast/runin/run-in-layer-not-removed-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::handleRunInChild):

LayoutTests:

* fast/runin/run-in-layer-not-removed-crash-expected.txt: Added.
* fast/runin/run-in-layer-not-removed-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake the selected item in the accordion a link to the flakiness dashboard
ojan@chromium.org [Mon, 19 Mar 2012 22:52:42 +0000 (22:52 +0000)]
Make the selected item in the accordion a link to the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=81571

Reviewed by Dimitri Glazkov.

Also, make it so that you can select the text of the link, instead of the current behavior
of acting as if you had clicked on the accordion header.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNRWT runs some tests that are skipped with -i command line option
dpranke@chromium.org [Mon, 19 Mar 2012 22:42:53 +0000 (22:42 +0000)]
NRWT runs some tests that are skipped with -i command line option
https://bugs.webkit.org/show_bug.cgi?id=81535

Reviewed by Ojan Vafai.

This change modifies the interaction of Skipped files and
test_expectations files so that entries in Skipped files (and
the -i command line) override *everything* in the expectations
file.

Specifically, a directory in a Skipped file will cause all of
the tests in the dir to be skipped even if individual tests in
the dir are listed in the test_expectations.txt.

Skipped files also override anything in an overrides files.

This seems to make more intuitive sense, since if you list
something in the Skips file (and even more specify it on the
command line) you probably want it to be universally applied.

Theoretically we could add more precedence levels and have full
paths in an expectations file override dirs in a Skipped file
(but not the command line), but I don't know yet that that level
of complexity is justified.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.__init__):
(TestExpectations._add_skipped_tests):
(TestExpectations._add_test):
(TestExpectations._add_expectations):
(TestExpectations._add_expectation_line):
(TestExpectations._already_seen_better_match):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_more_specific_override_resets_skip):
(SkippedTests):
(SkippedTests.get_exp):
(SkippedTests.assert_exp):
(SkippedTests.test_skipped_tests_work):
(SkippedTests.test_duplicate_skipped_test_fails_lint):
(SkippedTests.test_skipped_file_overrides_expectations):
(SkippedTests.test_skipped_dir_overrides_expectations):
(SkippedTests.test_skipped_file_overrides_overrides):
(SkippedTests.test_skipped_dir_overrides_overrides):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove misleading double-if
commit-queue@webkit.org [Mon, 19 Mar 2012 22:27:24 +0000 (22:27 +0000)]
[chromium] Remove misleading double-if
https://bugs.webkit.org/show_bug.cgi?id=81557

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Simple code cleanup, no functionality change.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] speed up text selection for large selections
commit-queue@webkit.org [Mon, 19 Mar 2012 22:17:27 +0000 (22:17 +0000)]
[BlackBerry] speed up text selection for large selections
https://bugs.webkit.org/show_bug.cgi?id=81536

When selecting large disjoint areas of text the cost
of calculating the IntRectRegion union becomes very
expensive. Simply placing all of the text quads into
the IntRectRegion is faster despite the larger memory
footprint and the additional calculations at render
time.

Patch by Tyler Abbott <tabbott@rim.com> on 2012-03-19
Reviewed by Rob Buis.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::getConsolidatedRegionOfTextQuadsForSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix WTF header include discipline in Chromium WebKit
eric@webkit.org [Mon, 19 Mar 2012 22:16:48 +0000 (22:16 +0000)]
Fix WTF header include discipline in Chromium WebKit
https://bugs.webkit.org/show_bug.cgi?id=81281

Reviewed by James Robinson.

Source/JavaScriptCore:

* JavaScriptCore.gyp/JavaScriptCore.gyp:
* wtf/unicode/icu/CollatorICU.cpp:

Source/WebCore:

I also fixed some bad include dicipline for other ports
as well.  Those changes are not yet necessary for those ports
to keep building, but soon should be as those authors
remove all the extra WTF includes from WebCore and other non-WTF projects.

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
* bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
* bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
* bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
* bindings/scripts/test/ObjC/DOMFloat64Array.mm:
* bindings/v8/NPV8Object.cpp:
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/SerializedScriptValue.h:
* bindings/v8/V8Binding.cpp:
* bindings/v8/V8Binding.h:
* bindings/v8/V8DOMWrapper.cpp:
* bindings/v8/V8Utilities.cpp:
* bindings/v8/custom/V8ArrayBufferCustom.cpp:
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
* bindings/v8/custom/V8AudioContextCustom.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
* bindings/v8/custom/V8Float32ArrayCustom.cpp:
* bindings/v8/custom/V8Float64ArrayCustom.cpp:
* bindings/v8/custom/V8Int16ArrayCustom.cpp:
* bindings/v8/custom/V8Int32ArrayCustom.cpp:
* bindings/v8/custom/V8Int8ArrayCustom.cpp:
* bindings/v8/custom/V8MessagePortCustom.cpp:
* bindings/v8/custom/V8Uint16ArrayCustom.cpp:
* bindings/v8/custom/V8Uint32ArrayCustom.cpp:
* bindings/v8/custom/V8Uint8ArrayCustom.cpp:
* bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
* bindings/v8/custom/V8WorkerCustom.cpp:
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
* bridge/qt/qt_runtime.cpp:
* editing/gtk/FrameSelectionGtk.cpp:
* loader/archive/mhtml/MHTMLArchive.cpp:
* platform/ScrollAnimatorNone.cpp:
* platform/blackberry/CookieMap.h:
* platform/blackberry/CookieParser.h:
* platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
* platform/chromium/DragImageChromiumSkia.cpp:
* platform/chromium/PlatformCursor.h:
* platform/chromium/PlatformSupport.h:
* platform/chromium/PopupMenuPrivate.h:
* platform/chromium/TraceEvent.h:
* platform/chromium/WidgetChromium.cpp:
* platform/efl/RefPtrEfl.h:
* platform/graphics/cairo/RefPtrCairo.h:
* platform/graphics/chromium/RateLimiter.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
* platform/graphics/efl/IconEfl.cpp:
* platform/graphics/gstreamer/GStreamerGWorld.h:
* platform/graphics/gtk/IconGtk.cpp:
* platform/graphics/skia/PlatformContextSkia.h:
* platform/graphics/texmap/TextureMapperBackingStore.h:
* platform/graphics/texmap/TextureMapperLayer.cpp:
* platform/graphics/wx/TransformationMatrixWx.cpp:
* platform/gtk/PlatformMouseEventGtk.cpp:
* platform/leveldb/LevelDBSlice.h:
* platform/mediastream/MediaStreamCenter.cpp:
* platform/network/soup/SocketStreamHandleSoup.cpp:
* platform/network/win/ResourceHandleWin.cpp:
* platform/qt/RenderThemeQtMobile.cpp:
* platform/wx/MouseEventWx.cpp:
* platform/wx/wxcode/win/fontprops.cpp:

Source/WebKit/chromium:

* src/CompositionUnderlineBuilder.h:
* src/CompositionUnderlineVectorBuilder.h:
* src/FrameLoaderClientImpl.cpp:
* src/WebArrayBuffer.cpp:
* src/WebArrayBufferView.cpp:
* src/WebBindings.cpp:
* src/WebColorName.cpp:
* src/WebGeolocationClientMock.cpp:
* src/WebPageSerializer.cpp:
* src/WebSocketImpl.cpp:
* src/WebViewImpl.cpp:
* tests/FrameTestHelpers.cpp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add new layout test for text match marker
commit-queue@webkit.org [Mon, 19 Mar 2012 22:03:19 +0000 (22:03 +0000)]
[BlackBerry] Add new layout test for text match marker
https://bugs.webkit.org/show_bug.cgi?id=81531

Tools:

Make the LayoutTestControllerBlackBerry::findString to test the
BlackBerry port implementation.

Patch by Andy Chen <andchen@rim.com> on 2012-03-19
Reviewed by Rob Buis.

* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::findString):

LayoutTests:

Patch by Andy Chen <andchen@rim.com> on 2012-03-19
Reviewed by Rob Buis.

Add a new layout test for text match marker for BlackBerry port

* platform/blackberry/editing/text-iterator/findString-markers-expected.txt: Added.
* platform/blackberry/editing/text-iterator/findString-markers.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agor109204 updated the chromium expected results for
jberlin@webkit.org [Mon, 19 Mar 2012 21:54:37 +0000 (21:54 +0000)]
r109204 updated the chromium expected results for
inspector/timeline/timeline-animation-frame.html and timeline-paint.html, but did not update
the cross-platform results.

Update the cross-platform results.

* inspector/timeline/timeline-animation-frame-expected.txt:
* inspector/timeline/timeline-paint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG NodeUse should be called Edge and NodeReferenceBlob should be called AdjacencyList
fpizlo@apple.com [Mon, 19 Mar 2012 21:44:23 +0000 (21:44 +0000)]
DFG NodeUse should be called Edge and NodeReferenceBlob should be called AdjacencyList
https://bugs.webkit.org/show_bug.cgi?id=81556

Rubber stamped by Gavin Barraclough.

* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::forNode):
* dfg/DFGAdjacencyList.h: Copied from Source/JavaScriptCore/dfg/DFGNodeReferenceBlob.h.
(JSC::DFG::AdjacencyList::AdjacencyList):
(JSC::DFG::AdjacencyList::child):
(JSC::DFG::AdjacencyList::setChild):
(JSC::DFG::AdjacencyList::child1):
(JSC::DFG::AdjacencyList::child2):
(JSC::DFG::AdjacencyList::child3):
(JSC::DFG::AdjacencyList::setChild1):
(JSC::DFG::AdjacencyList::setChild2):
(JSC::DFG::AdjacencyList::setChild3):
(JSC::DFG::AdjacencyList::child1Unchecked):
(JSC::DFG::AdjacencyList::initialize):
(AdjacencyList):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::processPhiStack):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::performSubstitution):
* dfg/DFGEdge.h: Copied from Source/JavaScriptCore/dfg/DFGNodeUse.h.
(DFG):
(JSC::DFG::Edge::Edge):
(JSC::DFG::Edge::operator==):
(JSC::DFG::Edge::operator!=):
(Edge):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::operator[]):
(JSC::DFG::Graph::at):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):
(Graph):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::getPrediction):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child1Unchecked):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(Node):
* dfg/DFGNodeFlags.cpp:
(JSC::DFG::arithNodeFlagsAsString):
* dfg/DFGNodeFlags.h:
(DFG):
(JSC::DFG::nodeUsedAsNumber):
* dfg/DFGNodeReferenceBlob.h: Removed.
* dfg/DFGNodeUse.h: Removed.
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultArithFlags):
(JSC::DFG::PredictionPropagationPhase::vote):
(JSC::DFG::PredictionPropagationPhase::fixupNode):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::use):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::at):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Invalidate/update evicted tiles during commit
commit-queue@webkit.org [Mon, 19 Mar 2012 21:37:00 +0000 (21:37 +0000)]
[chromium] Invalidate/update evicted tiles during commit
https://bugs.webkit.org/show_bug.cgi?id=81529

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/WebCore:

A previous change caused a regression where evicted (invalid) tiles
were no longer marked as dirty and updated. The regress was caused
in https://bugs.webkit.org/show_bug.cgi?id=81175 and is fixed here.

Unit test: TiledLayerChromiumTest.pushDeletedTiles

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::copyAndClearDirty):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):

Source/WebKit/chromium:

* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove PLATFORM(TORCHMOBILE) ifdef from MainResourceLoader.cpp
abarth@webkit.org [Mon, 19 Mar 2012 21:35:16 +0000 (21:35 +0000)]
Remove PLATFORM(TORCHMOBILE) ifdef from MainResourceLoader.cpp
https://bugs.webkit.org/show_bug.cgi?id=81549

Reviewed by Eric Seidel.

This appears to be the only PLATFORM(TORCHMOBILE) ifdef in WebCore.  I
don't believe this ifdef is needed anymore.

* loader/MainResourceLoader.cpp:
(WebCore::shouldLoadAsEmptyDocument):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoObject.freeze broken on latest Nightly
barraclough@apple.com [Mon, 19 Mar 2012 21:34:25 +0000 (21:34 +0000)]
Object.freeze broken on latest Nightly
https://bugs.webkit.org/show_bug.cgi?id=80577

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* runtime/Arguments.cpp:
(JSC::Arguments::defineOwnProperty):
    - defineOwnProperty was checking for correct behaviour, provided that length/callee hadn't
    been overrridden. instead, just reify length/callee & rely on JSObject::defineOwnProperty.
* runtime/JSFunction.cpp:
(JSC::JSFunction::defineOwnProperty):
    - for arguments/caller/length properties, defineOwnProperty was incorrectly asserting that
    the object must be extensible; this is incorrect since these properties should already exist
    on the object. In addition, it was asserting that the arguments/caller values must match the
    corresponding magic data properties, but for strict mode function this is incorrect. Instead,
    just reify the arguments/caller accessor & defer to JSObject::defineOwnProperty.

LayoutTests:

* fast/js/preventExtensions-expected.txt:
* fast/js/script-tests/preventExtensions.js:
(shouldBeTrue):
(shouldBeFalse.shouldBeFalse.preventExtensionsFreezeIsFrozen):
    - Added test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r111207.
commit-queue@webkit.org [Mon, 19 Mar 2012 21:30:47 +0000 (21:30 +0000)]
Unreviewed, rolling out r111207.
http://trac.webkit.org/changeset/111207
https://bugs.webkit.org/show_bug.cgi?id=81561

Causing chromium unit test failure (Requested by reveman on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-19

Source/Platform:

* chromium/public/WebGraphicsContext3D.h:

Source/WebCore:

* platform/graphics/chromium/Extensions3DChromium.h:
(Extensions3DChromium):

Source/WebKit/chromium:

* src/Extensions3DChromium.cpp:
* src/GraphicsContext3DChromium.cpp:
(WebCore):
* src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* tests/FakeWebGraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] MediaStream API (JSEP): Introducing WebMediaHints and WebIceOptions
tommyw@google.com [Mon, 19 Mar 2012 21:27:06 +0000 (21:27 +0000)]
[chromium] MediaStream API (JSEP): Introducing WebMediaHints and WebIceOptions
https://bugs.webkit.org/show_bug.cgi?id=81341

Reviewed by Darin Fisher.

Simple WebKit representations of the WebCore/platform versions.

* WebKit.gyp:
* public/platform/WebICEOptions.h: Added.
(WebCore):
(WebKit):
(WebICEOptions):
(WebKit::WebICEOptions::WebICEOptions):
(WebKit::WebICEOptions::~WebICEOptions):
(WebKit::WebICEOptions::operator=):
(WebKit::WebICEOptions::isNull):
* public/platform/WebMediaHints.h: Added.
(WebCore):
(WebKit):
(WebMediaHints):
(WebKit::WebMediaHints::WebMediaHints):
(WebKit::WebMediaHints::~WebMediaHints):
(WebKit::WebMediaHints::operator=):
(WebKit::WebMediaHints::isNull):
* src/WebICEOptions.cpp: Added.
(WebKit):
(WebKit::WebICEOptions::WebICEOptions):
(WebKit::WebICEOptions::assign):
(WebKit::WebICEOptions::reset):
(WebKit::WebICEOptions::candidateTypeToUse):
* src/WebMediaHints.cpp: Added.
(WebKit):
(WebKit::WebMediaHints::WebMediaHints):
(WebKit::WebMediaHints::assign):
(WebKit::WebMediaHints::reset):
(WebKit::WebMediaHints::audio):
(WebKit::WebMediaHints::video):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNPRuntime support for out-of-process plug-ins.
jberlin@webkit.org [Mon, 19 Mar 2012 21:26:19 +0000 (21:26 +0000)]
NPRuntime support for out-of-process plug-ins.
https://bugs.webkit.org/show_bug.cgi?id=48346

This issue was marked as fixed on 2011-01-11, but the tests that required that support were
never taken off the WK2 Skipped list.

Update the WK2 Skipped list to not skip the passing tests, and move the ones that still fail
to a separate section of the list.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unnecessary CALayer overrides from WebTileCacheLayer
andersca@apple.com [Mon, 19 Mar 2012 21:24:50 +0000 (21:24 +0000)]
Remove unnecessary CALayer overrides from WebTileCacheLayer
https://bugs.webkit.org/show_bug.cgi?id=81562

Reviewed by Dan Bernstein.

* platform/graphics/ca/mac/TileCache.h:
(TileCache):
* platform/graphics/ca/mac/WebTileCacheLayer.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLLInt get_by_pname slow path incorrectly assumes that the operands are not constants
fpizlo@apple.com [Mon, 19 Mar 2012 21:18:18 +0000 (21:18 +0000)]
LLInt get_by_pname slow path incorrectly assumes that the operands are not constants
https://bugs.webkit.org/show_bug.cgi?id=81559

Reviewed by Michael Saboff.

* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect usage of LayoutUnits in page code in preparation for turning on subpixel...
eae@chromium.org [Mon, 19 Mar 2012 21:05:07 +0000 (21:05 +0000)]
Correct usage of LayoutUnits in page code in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=81538

Reviewed by Eric Seidel.

Fix usage of LayoutUnits and conversions between types in page code.

No new tests.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
Explicitly cast long to int. InspectorInstrumentation requires a long and
FractionalLayoutUnit has no constructor that takes long.

* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEventForKey):
Pixel snap overflow rect as selection rects are integer based.

* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
Pixel snap repaint rects when computing update rect as all scrolling is
done on integer bounds.

* page/GestureTapHighlighter.cpp:
Change rects vector to IntRect as addFocusRingRects operates on IntRects.

* page/Page.cpp:
(WebCore::Page::addRelevantRepaintedObject):
(WebCore::Page::addRelevantUnpaintedObject):
Change paint methods to take a LayoutRect paint rect.

* page/SpatialNavigation.cpp:
(WebCore::distanceDataForNode):
Change distance calculation to use floats instead of converting to float
at the end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't show WONTFIX tests in garden-o-matic
ojan@chromium.org [Mon, 19 Mar 2012 21:00:38 +0000 (21:00 +0000)]
Don't show WONTFIX tests in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=81554

Reviewed by Dimitri Glazkov.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81553
hyatt@apple.com [Mon, 19 Mar 2012 20:59:10 +0000 (20:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81553

[New Multicolumn] Stub out classes to represent sets of column region boxes.

RenderRegionSet is an abstract class representing a set of contiguous anonymous
same-size regions.

RenderMultiColumnSet derives from RenderRegionSet and represents a set of contiguous
columns. It will also handle unique column behavior like column rule painting.

Eventually there will be a RenderPageSet derived class for printing/pages, but
that will come later after I finish rebuilding multi-column layout.

Reviewed by Dan Bernstein.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderMultiColumnSet.cpp: Added.
(WebCore):
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::renderName):
* rendering/RenderMultiColumnSet.h: Added.
(WebCore):
(RenderMultiColumnSet):
* rendering/RenderRegionSet.cpp: Added.
(WebCore):
(WebCore::RenderRegionSet::RenderRegionSet):
* rendering/RenderRegionSet.h: Added.
(WebCore):
(RenderRegionSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd playback state for AudioBufferSourceNode and add number of active nodes
commit-queue@webkit.org [Mon, 19 Mar 2012 20:54:50 +0000 (20:54 +0000)]
Add playback state for AudioBufferSourceNode and add number of active nodes
https://bugs.webkit.org/show_bug.cgi?id=79701

Source/WebCore:

Add a playback state to AudioBufferSourceNode so that the user can
tell if the node is scheduled, playing, or finished.

For an AudioContext, add a count of the number of
AudioBufferSourceNode's that are active (playing audio).

Deleted m_isPlaying and m_hasFinished. For the record, m_isPlaying
is the same as a playbackState of SCHEDULED_STATE or PLAYING_STATE.
m_hasFinished is equivalent to a playbackState of FINISHED_STATE.

Patch by Raymond Toy <rtoy@google.com> on 2012-03-19
Reviewed by Chris Rogers.

Test: webaudio/audiobuffersource-playbackState.html

* webaudio/AudioBufferSourceNode.cpp:
(WebCore):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
initialize playbackState, remove m_isPlaying, m_hasFinished.
(WebCore::AudioBufferSourceNode::process): Update playbackState
(WebCore::AudioBufferSourceNode::finish): Update playbackState
(WebCore::AudioBufferSourceNode::noteOn): Update playbackState
(WebCore::AudioBufferSourceNode::noteGrainOn): Update playbackState
(WebCore::AudioBufferSourceNode::noteOff): Use playbackState
* webaudio/AudioBufferSourceNode.h:
(AudioBufferSourceNode): Define states, remove m_isPlaying, m_hasFinished.
(WebCore::AudioBufferSourceNode::playbackState): Added.
* webaudio/AudioBufferSourceNode.idl: Define constants for the
playback state, add attribute playbackState.
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::activeSourceCount): Added.
(WebCore::AudioContext::incrementActiveSourceCount): Added.
(WebCore::AudioContext::decrementActiveSourceCount): Added.
* webaudio/AudioContext.h:
(AudioContext):
* webaudio/AudioContext.idl: Add attribute activeSourceCount.

LayoutTests:

Patch by Raymond Toy <rtoy@google.com> on 2012-03-19
Reviewed by Chris Rogers.

* webaudio/audiobuffersource-playbackState-expected.txt: Added.
* webaudio/audiobuffersource-playbackState.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r109014.
commit-queue@webkit.org [Mon, 19 Mar 2012 20:43:13 +0000 (20:43 +0000)]
Unreviewed, rolling out r109014.
http://trac.webkit.org/changeset/109014
https://bugs.webkit.org/show_bug.cgi?id=81551

Causing crashes (Requested by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-19

Source/WebCore:

* rendering/style/RenderStyle.h:

LayoutTests:

* css3/flexbox/inline-flexbox-expected.html: Removed.
* css3/flexbox/inline-flexbox.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Make WebFrameLoaderClient::createFrame more like WebKit1 version.
ap@apple.com [Mon, 19 Mar 2012 20:41:59 +0000 (20:41 +0000)]
    Make WebFrameLoaderClient::createFrame more like WebKit1 version.
        https://bugs.webkit.org/show_bug.cgi?id=81550

        Covered by existing tests.

        Reviewed by Jessie Berlin.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Implement OSAllocator::commit/decommit in the correct way
commit-queue@webkit.org [Mon, 19 Mar 2012 20:39:15 +0000 (20:39 +0000)]
[BlackBerry] Implement OSAllocator::commit/decommit in the correct way
https://bugs.webkit.org/show_bug.cgi?id=77013

We should use mmap(PROT_NONE, MAP_LAZY) instead of posix_madvise() to
implement memory decommitting for QNX.

Patch by Yong Li <yoli@rim.com> on 2012-03-19
Reviewed by Rob Buis.

* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoplatform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKi...
cfleizach@apple.com [Mon, 19 Mar 2012 20:29:41 +0000 (20:29 +0000)]
platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81530

Reviewed by Jessie Berlin.

Tools:

Add rowAtIndex to WebKitTestRunner.

* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::rowAtIndex):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR):
(WTR::AccessibilityUIElement::rowAtIndex):

LayoutTests:

* platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoediting/input/reveal-edit-on-input-vertically.html and
jberlin@webkit.org [Mon, 19 Mar 2012 20:28:39 +0000 (20:28 +0000)]
editing/input/reveal-edit-on-input-vertically.html and
editing/input/reveal-contenteditable-on-input-vertically.html timing out on Lion Intel Debug
WebKit2 testers

Add those tests to the WK2 Skipped list.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, remove headers that no longer exist or moved in WebCore.gypi.
tony@chromium.org [Mon, 19 Mar 2012 20:26:06 +0000 (20:26 +0000)]
Unreviewed, remove headers that no longer exist or moved in WebCore.gypi.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSSRegions]Implement NamedFlow::contentNodes attribute
mihnea@adobe.com [Mon, 19 Mar 2012 20:24:14 +0000 (20:24 +0000)]
[CSSRegions]Implement NamedFlow::contentNodes attribute
https://bugs.webkit.org/show_bug.cgi?id=80134

Reviewed by David Hyatt.

The named flow content nodes collection contains those nodes with webkitFlowInto property set to 'flow'.
In the list, the nodes are placed in document order. Nodes with display:none are also part of the list.
The list of nodes is returned as a static node list.

Source/WebCore:

Test: fast/regions/webkit-named-flow-content-nodes.html

* dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::detach):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::contentNodes):
(WebCore):
(WebCore::WebKitNamedFlow::registerContentNode):
* dom/WebKitNamedFlow.h:
(WebCore):
(WebKitNamedFlow):
(WebCore::WebKitNamedFlow::unregisterContentNode):
* dom/WebKitNamedFlow.idl:

LayoutTests:

* fast/regions/webkit-named-flow-content-nodes-expected.txt: Added.
* fast/regions/webkit-named-flow-content-nodes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange garden-o-matic All Failures tab to Expected Failures
ojan@chromium.org [Mon, 19 Mar 2012 20:23:12 +0000 (20:23 +0000)]
Change garden-o-matic All Failures tab to Expected Failures
https://bugs.webkit.org/show_bug.cgi?id=81540

Reviewed by Dimitri Glazkov.

Also, fix some broken unittests that had just gotten stale.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvolverNode should not incur processing latency
commit-queue@webkit.org [Mon, 19 Mar 2012 20:19:46 +0000 (20:19 +0000)]
ConvolverNode should not incur processing latency
https://bugs.webkit.org/show_bug.cgi?id=75564

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-19
Reviewed by Chris Rogers.

Source/WebCore:

Add the DirectConvolver instead of FFTConvolver for the processing of the leading portion of impulse response.

* WebCore.gypi:
* platform/audio/DirectConvolver.cpp: Added.
(WebCore):
(WebCore::DirectConvolver::DirectConvolver):
(WebCore::DirectConvolver::process):
(WebCore::DirectConvolver::reset):
* platform/audio/DirectConvolver.h: Added.
(WebCore):
(DirectConvolver):
(WebCore::DirectConvolver::convolveSize):
* platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::ReverbConvolver):
* platform/audio/ReverbConvolver.h:
* platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):
(WebCore::ReverbConvolverStage::process):
(WebCore::ReverbConvolverStage::reset):
* platform/audio/ReverbConvolverStage.h:
(WebCore):
(ReverbConvolverStage):

LayoutTests:

No need to check the initial silent part because the latency issue of ConvolverNode is fixed.

* webaudio/convolution-mono-mono-expected.txt:
* webaudio/resources/convolution-testing.js:
(checkTriangularPulse):
(checkTail1):
(checkConvolvedResult.return.var):
(checkConvolvedResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Find in page highlights get out of place when scrolling
andersca@apple.com [Mon, 19 Mar 2012 20:13:40 +0000 (20:13 +0000)]
Source/WebCore: Find in page highlights get out of place when scrolling
https://bugs.webkit.org/show_bug.cgi?id=81543

Reviewed by Sam Weinig.

Remove a now unused function from GraphicsLayer.

* platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):

Source/WebKit2: Find in page highlights get out of place when scrolling
https://bugs.webkit.org/show_bug.cgi?id=81543
<rdar://problem/10932590>

Reviewed by Sam Weinig.

When we have a page overlay layer, always force a full repaint of it whenever the page changes.
If this turns out to be a real performance problem (measurements suggest that it isn't), we could once
again try to figure out when a full page repaint is needed. Doing so could probably be more expensive than
simply repainting the page, given that a page overlay consists of a bunch of rect-fills mostly.

Also turn on accelerated drawing for the page overlay layer, since that cut CPU usage in half when scrolling
on a page that had a find overlay visible.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Test cleanup - don't create transactions w/in transaction callback
jsbell@chromium.org [Mon, 19 Mar 2012 20:12:24 +0000 (20:12 +0000)]
IndexedDB: Test cleanup - don't create transactions w/in transaction callback
https://bugs.webkit.org/show_bug.cgi?id=81532

The spec precludes creating transactions within a synchronous transaction callback;
for the current implementation, that's only the success callback for a setVersion()
call. This isn't enforced yet - see http://webkit.org/b/80547

Reviewed by Tony Chang.

* storage/indexeddb/create-and-remove-object-store.html: Split out oncomplete handler.
* storage/indexeddb/create-object-store-options.html: Split out oncomplete handler.
* storage/indexeddb/factory-deletedatabase.html: Listen on complete event.
* storage/indexeddb/mozilla/autoincrement-indexes.html: Split out oncomplete handler.
* storage/indexeddb/mozilla/clear.html: Listen on complete event.
* storage/indexeddb/mozilla/indexes.html: Split out oncomplete handler.
* storage/indexeddb/mozilla/readonly-transactions.html: Split out oncomplete handler.
* storage/indexeddb/mozilla/readwrite-transactions.html: Split out oncomplete handler.
* storage/indexeddb/noblobs.html: Pass function reference, don't call function.
* storage/indexeddb/objectstore-clear.html: Split out oncomplete handler.
* storage/indexeddb/objectstore-removeobjectstore.html: Listen on complete event.
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html: Split out oncomplete handler.
* storage/indexeddb/transaction-abort-with-js-recursion.html: Split out oncomplete handler.
* storage/indexeddb/transaction-crash-on-abort.html: Split out oncomplete handler.
* storage/indexeddb/two-version-changes.html: Split out oncomplete handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Marking fast/text/international/font-fallback-to-common-script.html as...
leviw@chromium.org [Mon, 19 Mar 2012 20:09:55 +0000 (20:09 +0000)]
[Chromium] Marking fast/text/international/font-fallback-to-common-script.html as flaky for image
tests on all flavors of Chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed - revent a couple of files accidentally committed.
barraclough@apple.com [Mon, 19 Mar 2012 19:59:03 +0000 (19:59 +0000)]
Unreviewed - revent a couple of files accidentally committed.

* runtime/Arguments.cpp:
(JSC::Arguments::defineOwnProperty):
* runtime/JSFunction.cpp:
(JSC::JSFunction::defineOwnProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMarking css3/images/cross-fade-invalidation.html as flaky for image tests on Chromium...
leviw@chromium.org [Mon, 19 Mar 2012 19:58:44 +0000 (19:58 +0000)]
Marking css3/images/cross-fade-invalidation.html as flaky for image tests on Chromium Snowleopard.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agor98413 updated the platform/mac-wk2/plugins/contents-scale-factor test without updati...
jberlin@webkit.org [Mon, 19 Mar 2012 19:49:52 +0000 (19:49 +0000)]
r98413 updated the platform/mac-wk2/plugins/contents-scale-factor test without updating the
expected results.

Update the expected results.

* platform/mac-wk2/plugins/contents-scale-factor-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] DRT crashes at shutdown.
commit-queue@webkit.org [Mon, 19 Mar 2012 19:46:09 +0000 (19:46 +0000)]
[chromium] DRT crashes at shutdown.
https://bugs.webkit.org/show_bug.cgi?id=81504

Patch by Hao Zheng <zhenghao@chromium.org> on 2012-03-19
Reviewed by James Robinson.

WebCompositor must be destroyed after WebView is properly destroyed,
or some compositor objects like CCLayerTreeHost may not be destroyed.
However, it is really hard to make the destruction order correct
explicitly in ~TestShell. So move it out to DumpRenderTree.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::~TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhen Find overlay first appears and the page scrolls, the scrolling happens through...
andersca@apple.com [Mon, 19 Mar 2012 19:43:35 +0000 (19:43 +0000)]
When Find overlay first appears and the page scrolls, the scrolling happens through a fade
https://bugs.webkit.org/show_bug.cgi?id=81539
<rdar://problem/11031093>

Reviewed by Dan Bernstein.

Disable implicit animations when adding the page overlay layer to its superlayer.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] fast/events/touch/gesture/pad-gesture-fling.html fails on release builds
leviw@chromium.org [Mon, 19 Mar 2012 19:41:17 +0000 (19:41 +0000)]
[chromium] fast/events/touch/gesture/pad-gesture-fling.html fails on release builds
https://bugs.webkit.org/show_bug.cgi?id=81537

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81534
hyatt@apple.com [Mon, 19 Mar 2012 19:28:39 +0000 (19:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81534

[New Multicolumn] Make the multi-column block re-layout its children when the column width/count change.
Cache the count/width on the multi-column block for easy access.

Reviewed by Antti Koivisto.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::recomputeLogicalWidth):
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderBlock.h:
Virtualize the code that recomputes the logical width for a block and sets relayoutChildren to true,
so that column code can subclass the method to also check for changes in the column width/count.

* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::computeColumnCountAndWidth):
The column count/width determination algorithm in one method on the RenderMultiColumnBlock. It's a copy
of the code from RenderBlock (which will be going away eventually).

(WebCore::RenderMultiColumnBlock::recomputeLogicalWidth):
* rendering/RenderMultiColumnBlock.h:
(RenderMultiColumnBlock):
Subclassed method to also check for changes in the column width to set relayoutChildren to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Updating WebGraphicsContext3D MemoryAllocation callback to accept a struct...
commit-queue@webkit.org [Mon, 19 Mar 2012 19:19:12 +0000 (19:19 +0000)]
[chromium] Updating WebGraphicsContext3D MemoryAllocation callback to accept a struct with have backbuffer suggestion.
https://bugs.webkit.org/show_bug.cgi?id=81279

Patch by Michal Mocny <mmocny@google.com> on 2012-03-19
Reviewed by James Robinson.

Source/Platform:

Adding a suggestHaveBackbuffer hint to the WebGraphicsContext3D memory allocation callback.

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::onMemoryAllocationChanged):
* chromium/public/WebGraphicsMemoryAllocation.h: Added.
(WebKit):
(WebGraphicsMemoryAllocation):
(WebKit::WebGraphicsMemoryAllocation::WebGraphicsMemoryAllocation):

Source/WebCore:

* platform/graphics/chromium/Extensions3DChromium.h:
(GpuMemoryAllocationCHROMIUM):
(WebCore::Extensions3DChromium::GpuMemoryAllocationCHROMIUM::GpuMemoryAllocationCHROMIUM):
(GpuMemoryAllocationChangedCallbackCHROMIUM):

Source/WebKit/chromium:

* src/GraphicsContext3DChromium.cpp:
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoadd dpranke to webkitpy watchlist
dpranke@chromium.org [Mon, 19 Mar 2012 19:14:03 +0000 (19:14 +0000)]
add dpranke to webkitpy watchlist
https://bugs.webkit.org/show_bug.cgi?id=81433

Reviewed by Benjamin Poulain.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111215 268f45cc-cd09-0410-ab3c-d52691b4dbfc