weinig [Thu, 31 Aug 2006 17:20:14 +0000 (17:20 +0000)]
WebCore:
Reviewed by Tim H.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10653
Auto-generate another 20 Objective-C DOM HTML bindings
Auto-generates DOMHTMLBRElement, DOMHTMLButtonElement, DOMHTMLDListElement,
DOMHTMLDirectoryElement, DOMHTMLDivElement, DOMHTMLFieldSetElement,
DOMHTMLHeadingElement, DOMHTMLInputElement, DOMHTMLLIElement, DOMHTMLLabelElement,
DOMHTMLLegendElement, DOMHTMLMenuElement, DOMHTMLOListElement, DOMHTMLOptGroupElement,
DOMHTMLParagraphElement, DOMHTMLPreElement, DOMHTMLQuoteElement, DOMHTMLSelectElement,
DOMHTMLTextAreaElement, and DOMHTMLUListElement.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
* bindings/objc/DOMExtensions.h:
* bindings/objc/DOMHTML.h:
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement altDisplayString]):
(-[DOMHTMLInputElement absoluteImageURL]):
(-[DOMHTMLInputElement WebCore::]):
(-[DOMHTMLInputElement _rectOnScreen]):
(-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
(-[DOMHTMLInputElement _selectedRange]):
(-[DOMHTMLInputElement _setAutofilled:]):
* bindings/objc/DOMHTMLInternal.h:
* bindings/objc/DOMPrivate.h:
* bindings/scripts/CodeGeneratorObjC.pm:
WebKit:
Reviewed by Tim H.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10653
Auto-generate another 20 Objective-C DOM HTML bindings
* MigrateHeaders.make:
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 31 Aug 2006 16:31:30 +0000 (16:31 +0000)]
WebCore:
Reviewed by John Sullivan.
Removing use of SPI in favor of Carbon API to enable and disable secure event input.
* WebCore.exp: Removed wkSecureEventInput and wkSetSecureEventInput.
* platform/mac/WebCoreSystemInterface.h: ditto.
* platform/mac/WebCoreSystemInterface.mm: ditto.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::setSecureKeyboardEntry): Uses EnableSecureEventInput and DisableSecureEventInput.
(WebCore::FrameMac::secureKeyboardEntry): Uses IsSecureEventInputEnabled.
WebKit:
Reviewed by John Sullivan.
Removed wkSecureEventInput and wkSetSecureEventInput, since this can be done with API.
* WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
WebKitLibraries:
Reviewed by John Sullivan.
Removed wkSecureEventInput and wkSetSecureEventInput, since this can be done with API.
* WebKitSystemInterface.h:
* libWebKitSystemInterface.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Thu, 31 Aug 2006 16:25:26 +0000 (16:25 +0000)]
Reviewed by Tim Omernick
- fixed <rdar://problem/
4711200> Loading history would be faster if it bypassed
NSURL API for local files
* History/WebHistory.m:
(-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
Load file URLs using [NSDictionary dictionaryWithContentsOfFile:]. I also cleaned up some minor
style issues in this method, and I removed the support for old NSArray-style history files (which we
stopped using before Safari 1.0).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16144
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Thu, 31 Aug 2006 06:22:07 +0000 (06:22 +0000)]
Reviewed by "common sense" (and Maciej)
Fixed two logging typos
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::syncDatabase):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 31 Aug 2006 02:09:49 +0000 (02:09 +0000)]
Adding missing nil check for focus node.
* page/Frame.cpp: (WebCore::Frame::setIsActive):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 31 Aug 2006 01:50:51 +0000 (01:50 +0000)]
WebCore:
Reviewed by Hyatt.
WebCore part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields
* WebCore.exp: Added wkSetSecureEventInput and wkSecureEventInput.
* platform/mac/WebCoreSystemInterface.h: ditto.
* platform/mac/WebCoreSystemInterface.mm: ditto.
* page/Frame.cpp: (WebCore::Frame::setIsActive): Enables and disables secure keyboard entry based on whether the frame becomes active.
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::setSecureKeyboardEntry): Added. Calls wkSetSecureEventInput.
(WebCore::FrameMac::secureKeyboardEntry): Added. Calls wkSecureEventInput.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::dispatchFocusEvent): For password fields, enable secure keyboard entry.
(WebCore::HTMLInputElement::dispatchBlurEvent): For password fields, disable secure keyboard entry.
* page/Frame.h:
(WebCore::Frame::setSecureKeyboardEntry):
(WebCore::Frame::secureKeyboardEntry):
WebKit:
Reviewed by Hyatt.
WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields
* WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
WebKitLibraries:
Reviewed by Hyatt.
Updated for http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields
* WebKitSystemInterface.h: Added WKSetSecureEventInput and WKSecureEventInput;
* libWebKitSystemInterface.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 31 Aug 2006 01:15:41 +0000 (01:15 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 31 Aug 2006 00:20:18 +0000 (00:20 +0000)]
Reviewed by Tim Hatcher.
- eliminated the need for UsesPassRefPtr in IDL files
- got rid of the category mechanism for ObjC generated DOM headers
(after discussions with Tim H where we decided it's not needed)
- simplified use of macro inside ObjC generated code
* ForwardingHeaders/wtf/GetPtr.h: Added.
* bindings/scripts/CodeGeneratorObjC.pm: Removed code to handle
categories. Eliminated use of DOM_cast since that's for the protection
of human programmers -- the script won't make mistakes that it needs
to catch. Changed macro to always be named IMPL instead of incorporating
the class name. Use WTF::getPtr to extract the pointer, and removed the
code that uses .get() to extract the pointer in the PassRefPtr case.
* dom/Attr.idl: Removed all uses of UsesPassRefPtr and ObjCCatagory.
* dom/DOMImplementation.idl: Ditto.
* dom/Document.idl: Ditto.
* dom/Element.idl: Ditto.
* dom/NamedNodeMap.idl: Ditto.
* html/HTMLDocument.idl: Ditto.
* html/HTMLElement.idl: Ditto.
* html/HTMLFormElement.idl: Ditto.
* html/HTMLMapElement.idl: Ditto.
* html/HTMLSelectElement.idl: Ditto.
* html/HTMLTableElement.idl: Ditto.
* html/HTMLTableRowElement.idl: Ditto.
* html/HTMLTableSectionElement.idl: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 31 Aug 2006 00:12:08 +0000 (00:12 +0000)]
Reviewed by Tim Hatcher.
- add WTF::getPtr, a function template that makes it possible to write
generic code that gets a raw pointer out of any of our pointer types
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/GetPtr.h: Added.
* wtf/ListRefPtr.h: (WTF::getPtr): Added.
* wtf/OwnArrayPtr.h: (WTF::getPtr): Added.
* wtf/OwnPtr.h: (WTF::getPtr): Added.
* wtf/PassRefPtr.h: (WTF::getPtr): Added.
* wtf/RefPtr.h: (WTF::getPtr): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 30 Aug 2006 23:32:07 +0000 (23:32 +0000)]
WebCore:
Reviewed by John
<rdar://problem/
4707718> - Instead of faking the user out with an in-memory icon database if their
~/Library/Safari/Icons is unwritable, we'll actually fail to open the icon database and the app will
run as if it was disabled via a preference.
Also took the opportunity to change some ASSERTS() to reasonable behavior
* bridge/mac/WebCoreIconDatabaseBridge.mm:
(-[WebCoreIconDatabaseBridge openSharedDatabaseWithPath:]): NSLog on failure so the user has a chance to figure
out there's a problem.
(-[WebCoreIconDatabaseBridge closeSharedDatabase]):
(-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): From here on, just replaced ASSERTS() with reasonable behavior
(-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
(-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
(-[WebCoreIconDatabaseBridge retainIconForURL:]):
(-[WebCoreIconDatabaseBridge releaseIconForURL:]):
(-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
(-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
(-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
(-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::open): If we fail to open, return false
(WebCore::IconDatabase::~IconDatabase): cleanup better
* loader/icon/IconDatabase.h:
WebKit:
Reviewed by John
<rdar://problem/
4707718> Change behavior so if the WebCore::IconDatabase can't open, WebKit releases the bridge and
continues on as if the IconDatabase is disabled.
* Misc/WebIconDatabase.m:
(-[WebIconDatabase init]): Release the bridge on failure to open
* WebCoreSupport/WebIconDatabaseBridge.m:
(+[WebIconDatabaseBridge sharedBridgeInstance]): Moved static shared instance out as a global
(-[WebIconDatabaseBridge dealloc]): Clear pointer to the shared instance
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 30 Aug 2006 23:27:45 +0000 (23:27 +0000)]
Reviewed by Darin.
Simplify the header copies from WebCore and JavaScriptCore.
Headers that need to be migrated from the other projects need
to be added to MigrateHeaders.make.
* MigrateHeaders.make: Added.
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Wed, 30 Aug 2006 22:09:16 +0000 (22:09 +0000)]
Reviewed by John Sullivan.
<rdar://problem/
4708007> REGRESSION: text field inside a webpage no longer has settable AXValueAttribute
<rdar://problem/
4707479> REGRESSION: controls inside a webpage no longer have settable AXFocusedAttribute
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject canSetFocusAttribute]):
(-[WebCoreAXObject canSetValueAttribute]):
New utility methods. Text fields and buttons are focusable.
Text fields can have their value set. We need not make
popupbutton value settable because AppKit does not.
(-[WebCoreAXObject accessibilityIsAttributeSettable:]):
Call new utility methods.
(-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
Set focus for text field or button.
Set value for text field.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 30 Aug 2006 21:46:29 +0000 (21:46 +0000)]
Fix for bugs 9000 and 10606. Add code to suppress painting when
a FOUC situation would otherwise occur. There will still typically be
a flash to white, but at least the wrong content won't show.
Reviewed by darin
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::stylesheetLoaded):
(WebCore::Document::updateStyleSelector):
* dom/Document.h:
(WebCore::Document::haveStylesheetsLoaded):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::isSubframe):
(WebCore::RenderLayer::hitTest):
* rendering/RenderView.cpp:
(WebCore::RenderView::repaintViewRectangle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 30 Aug 2006 21:19:57 +0000 (21:19 +0000)]
Fix build for Drosera.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Wed, 30 Aug 2006 20:47:21 +0000 (20:47 +0000)]
2006-08-31 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Eric. Landed by rwlbuis.
Apply Rob's fixes in RenderPathQt too -> unbreak build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 30 Aug 2006 20:36:11 +0000 (20:36 +0000)]
WebCore:
Reviewed by Tim H.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10640
Auto-generate 10 more Objective-C DOM HTML bindings
Auto-generates DOMHTMLBaseElement, DOMHTMLBodyElement, DOMHTMLHeadElement,
DOMHTMLHtmlElement, DOMHTMLIsIndexElement, DOMHTMLLinkElement,
DOMHTMLMetaElement, DOMHTMLStyleElement and DOMHTMLTitleElement.
Splits DOMHTMLDocument into it's own files.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
* bindings/objc/DOMExtensions.h:
* bindings/objc/DOMHTML.h:
* bindings/objc/DOMHTML.mm:
* bindings/objc/DOMHTMLDocument.h: Added.
* bindings/objc/DOMHTMLDocument.mm: Added.
(-[DOMHTMLDocument WebCore::]):
(-[DOMHTMLDocument title]):
(-[DOMHTMLDocument setTitle:]):
(-[DOMHTMLDocument referrer]):
(-[DOMHTMLDocument domain]):
(-[DOMHTMLDocument URL]):
(-[DOMHTMLDocument body]):
(-[DOMHTMLDocument setBody:]):
(-[DOMHTMLDocument images]):
(-[DOMHTMLDocument applets]):
(-[DOMHTMLDocument links]):
(-[DOMHTMLDocument forms]):
(-[DOMHTMLDocument anchors]):
(-[DOMHTMLDocument cookie]):
(-[DOMHTMLDocument setCookie:]):
(-[DOMHTMLDocument open]):
(-[DOMHTMLDocument close]):
(-[DOMHTMLDocument write:]):
(-[DOMHTMLDocument writeln:]):
(-[DOMHTMLDocument getElementById:]):
(-[DOMHTMLDocument getElementsByName:]):
(-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]):
(-[DOMHTMLDocument createDocumentFragmentWithText:]):
* bindings/objc/DOMHTMLInternal.h:
* bindings/scripts/CodeGeneratorObjC.pm:
* html/HTMLDocument.idl:
WebKit:
Reviewed by Tim H.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10640
Auto-generate 10 more Objective-C DOM HTML bindings
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 30 Aug 2006 20:24:32 +0000 (20:24 +0000)]
2006-08-30 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by eseidel.
Use QColor <-> Color conversion operator, instead of faking it.
* platform/qt/FontQt.cpp:
(WebCore::Font::drawGlyphs):
* platform/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Wed, 30 Aug 2006 20:20:38 +0000 (20:20 +0000)]
Reviewed by Eric.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10586
pointer-events has issues when things are not stroked/filled
Add a param to fillContains/strokeContains to indicate
whether we still want hit testing when there is no fill/stroke.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 30 Aug 2006 20:00:37 +0000 (20:00 +0000)]
LayoutTests:
Reviewed by harrison
<rdar://problem/
4700297>
REGRESSION: After replacing a misspelled word in a sentence, the selection extends to end of current line
Fixed:
* editing/pasteboard/smart-paste-002-expected.checksum:
* editing/pasteboard/smart-paste-002-expected.png:
* editing/pasteboard/smart-paste-002-expected.txt:
Added to demonstrate fix:
* editing/pasteboard/
4700297-expected.checksum: Added.
* editing/pasteboard/
4700297-expected.png: Added.
* editing/pasteboard/
4700297-expected.txt: Added.
* editing/pasteboard/
4700297.html: Added.
Removed a superfluous style span:
* editing/deleting/pruning-after-merge-1-expected.txt:
* editing/pasteboard/interchange-newline-1-expected.txt:
* editing/pasteboard/paste-text-019-expected.checksum:
* editing/pasteboard/paste-text-019-expected.png:
* editing/pasteboard/paste-text-019-expected.txt:
* editing/selection/drag-to-contenteditable-iframe-expected.txt:
Accidently checked in bad results yesterday:
* editing/pasteboard/copy-paste-bidi-expected.txt:
Equivalent render tree:
* editing/pasteboard/smart-paste-001-expected.txt:
WebCore:
Reviewed by harrison
<rdar://problem/
4700297>
REGRESSION: After replacing a misspelled word in a sentence, the selection extends to end of current line
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Rebalance whitespace
around insertionPos before insertion because the content might
cause a collapse, e.g. inserting <div>foo</div> at hello^ world.
* editing/htmlediting.cpp:
(WebCore::rebalanceWhitespaceInTextNode): Rebalance with all nbsps
for simplicity, we can produce sequences of regular spaces and
nbsps on serialization (10636).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 30 Aug 2006 19:37:39 +0000 (19:37 +0000)]
2006-08-30 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by eseidel.
The old solution was slow & does not work correctly.
Move the QString -> DeprecatedString conversion into
DeprectedString.cpp, to be able to access allocateHandle().
* platform/DeprecatedString.cpp:
(WebCore::DeprecatedString::DeprecatedString):
* platform/qt/StringQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 30 Aug 2006 19:16:01 +0000 (19:16 +0000)]
Reviewed/landed by Adam.
Implement containsCharacters() / determinePitch() functions.
* platform/qt/FontDataQt.cpp:
(WebCore::FontData::containsCharacters):
(WebCore::FontData::determinePitch):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 30 Aug 2006 18:58:52 +0000 (18:58 +0000)]
Reviewed by Darin's rubberstamp
We apparently have a fancy delateAllValues() helper for HashMap/Sets - I'll use that instead
* WebCore.xcodeproj/project.pbxproj:
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::removeAllIcons):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 30 Aug 2006 18:48:52 +0000 (18:48 +0000)]
Reviewed by ggaren.
- Verification of exceptions thrown in a plugin. Test for bug 10114.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/ObjCPlugin.m:
(+[ObjCPlugin isSelectorExcludedFromWebScript:]):
(+[ObjCPlugin webScriptNameForSelector:]):
(-[ObjCPlugin throwIfArgumentIsNotHello:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 30 Aug 2006 18:45:07 +0000 (18:45 +0000)]
JavaScriptCore:
Reviewed, tweaked by ggaren.
- Added storage and accessor functions for ExecState as a fix for
http://bugzilla.opendarwin.org/show_bug.cgi?id=10114
* kjs/ExecState.cpp:
(KJS::ExecState::ExecState):
* kjs/ExecState.h:
* kjs/context.h:
(KJS::Context::setExecState):
(KJS::Context::execState):
LayoutTests:
Reviewed by ggaren.
- Updated test to check for exceptions thrown in a plug-in. This is
a test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10114.
* plugins/bindings-test-expected.txt:
* plugins/bindings-test.html:
WebCore:
Reviewed, tweaked by ggaren.
- Changed to use ExecState on current context rather than global.
Part of the fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10114
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject throwException:]):
(-[WebScriptObject setException:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 30 Aug 2006 18:32:40 +0000 (18:32 +0000)]
WebCore:
Reviewed by Darin.
- WebCore part of fix for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10576
Disallow copy from new password fields
* page/Frame.cpp: (WebCore::Frame::mayCopy): Added. Checks to see if the selection is within a password field.
* page/Frame.h: Added mayCopy.
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::handleMouseMoveEvent): Checks mayCopy before starting a drag.
(WebCore::FrameMac::mayDHTMLCut): Renamed to match the bridge method. This also checks mayCopy now.
(WebCore::FrameMac::mayDHTMLCopy): ditto.
(WebCore::FrameMac::tryDHTMLCut): ditto.
(WebCore::FrameMac::tryDHTMLCopy): ditto.
(WebCore::FrameMac::mayDHTMLPaste): Renamed to match the bridge function.
(WebCore::FrameMac::tryDHTMLPaste): ditto.
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge mayCopy]): Calls the renamed method on frame.
(-[WebCoreFrameBridge mayDHTMLCut]): ditto.
(-[WebCoreFrameBridge mayDHTMLCopy]): ditto.
(-[WebCoreFrameBridge mayDHTMLPaste]): ditto.
(-[WebCoreFrameBridge tryDHTMLCut]): ditto.
(-[WebCoreFrameBridge tryDHTMLCopy]): ditto.
(-[WebCoreFrameBridge tryDHTMLPaste]): ditto.
* css/html4.css: Added !important to the -webkit-text-security property for password fields.
WebKit:
Reviewed by Darin.
WebKit part of fix for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10576
Disallow copy from new password fields
* WebView/WebHTMLView.m:
(-[WebHTMLView _canCopy]): Now also calls across the bridge to ask if it mayCopy.
(-[WebHTMLView _canCut]): Calls _canCopy now.
(-[NSArray validateUserInterfaceItem:]): Calls _canCut when validating the "Cut" menu item.
This used to call _canDelete (which used to be the same as _canCut), but now _canCut also checks _canCopy.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 30 Aug 2006 18:29:55 +0000 (18:29 +0000)]
JavaScriptCore:
Reviewed by Tim H.
Commit KDE related tweaks, to be able to
differentiate between a Qt-only or a KDE build.
* CMakeLists.txt: Install wtf-unity library.
* wtf/Platform.h: Add define for the KDE platform.
WebCore:
Reviewed by Tim H.
Commit KDE related tweaks, to be able to
differentiate between a Qt-only or a KDE build.
* CMakeLists.txt: Move global variables up to trunk/CMakeLists.txt.
Also rename USE_WEBKIT_SVG_SUPPORT to WEBKIT_USE_SVG_SUPPORT.
WebKitTools:
Reviewed by Tim H.
Commit KDE related tweaks, to be able to
differentiate between a Qt-only or a KDE build.
* DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Add ksvg2/ includes.
* QtLauncher/CMakeLists.txt: Add ksvg2/ includes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 30 Aug 2006 18:24:18 +0000 (18:24 +0000)]
Rubber-stamped by Brady.
Fix for the generated headers to make the build work
during "installhdrs" builds. Also export DOM headers
using the #import <WebCore/DOM*.h> syntax.
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorObjC.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 30 Aug 2006 16:50:36 +0000 (16:50 +0000)]
Reviewed by Eric and Tim H.
Bug 10634: -webView:dragDestinationActionMaskForDraggingInfo: is ignored
http://bugzilla.opendarwin.org/show_bug.cgi?id=10634
Remove the check for canShowFile: from _web_bestURL: since
it shouldn't be concerned with whether or not the view
can show the URL, merely return the most appropriate URL.
* Misc/WebNSPasteboardExtras.m:
(-[NSPasteboard _web_bestURL]):
* Misc/WebNSViewExtras.m:
(-[NSView _web_dragOperationForDraggingInfo:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 30 Aug 2006 08:11:17 +0000 (08:11 +0000)]
WebCore:
Reviewed by Kevin Decker (Sarge)
<rdar://problem/
4678414> - New IconDB needs to delete icons when asked
<rdar://problem/
4707718> - If user's Icon directory is unwritable, Safari will crash at startup
* bridge/mac/WebCoreIconDatabaseBridge.h:
* bridge/mac/WebCoreIconDatabaseBridge.mm:
(-[WebCoreIconDatabaseBridge removeAllIcons]): Added
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::open): If DB file is not writeable, create an in-memory DB for this session
(WebCore::IconDatabase::close): Use new deleteAllPreparedStatements()
(WebCore::IconDatabase::removeAllIcons): Actually implemented
(WebCore::IconDatabase::deleteAllPreparedStatements): Added for convinience/consistency
(WebCore::IconDatabase::setPrivateBrowsingEnabled): Use new SQLDatabase::clearAllTables()
* loader/icon/IconDatabase.h:
* loader/icon/SQLDatabase.cpp:
(WebCore::SQLDatabase::clearAllTables): Moved this from IconDatabase as it actually belongs here
(WebCore::SQLDatabase::vacuum): Added
* loader/icon/SQLDatabase.h:
(WebCore::SQLDatabase::path): changed name from getPath()
WebKit:
Reviewed by Kevin Decker (Sarge)
<rdar://problem/
4678414> - New IconDB needs to delete icons when asked
* Misc/WebIconDatabase.m:
(-[WebIconDatabase removeAllIcons]): Call through to WebCore to remove icons, then send notification
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Wed, 30 Aug 2006 05:07:28 +0000 (05:07 +0000)]
WebCore:
Reviewed by Alice
Added a truth value to setIconURLForPageURL so WebKit can avoid sending a notification
This is a win on the iBench
* bridge/mac/WebCoreIconDatabaseBridge.h:
* bridge/mac/WebCoreIconDatabaseBridge.mm:
(-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::setIconURLForPageURL):
* loader/icon/IconDatabase.h:
WebKit:
Reviewed by Alice
Added a truth value check for to setIconURL:forURL so WebKit can avoid sending a notification
This is a win on the iBench
* Misc/WebIconDatabase.m:
(-[WebIconDatabase _setIconURL:forURL:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16110
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Wed, 30 Aug 2006 04:59:30 +0000 (04:59 +0000)]
Reviewed by Brady.
Fixed <rdar://problem/
4702021> REGRESSION: WebClip and Weather widgets shift downward vertically on screen after I drag them out from dashboard configure bar
* platform/mac/ScreenMac.mm:
(WebCore::flipScreenRect):
reverted the one line in this method back to what it was before r15765. This changed caused window.screenY to be incorrect.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 30 Aug 2006 00:48:40 +0000 (00:48 +0000)]
LayoutTests:
Reviewed by Hyatt.
- test for <rdar://problem/
4701494> REGRESSION: Scrollbar on EPSN widget doesn't scroll (also affects Widgets widget, web inspector)
* fast/css/computed-style-negative-top-expected.txt: Added.
* fast/css/computed-style-negative-top.html: Added.
WebCore:
Reviewed by Hyatt.
- fix <rdar://problem/
4701494> REGRESSION: Scrollbar on EPSN widget doesn't scroll (also affects Widgets widget, web inspector)
The bug was that we would return "none" for computed style properties when they were
exactly "-1px".
Test: fast/css/computed-style-negative-top.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForLength): Moved special case for "undefined length" out of here.
(WebCore::valueForMaxLength): Moved it into here.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Use valueForMaxLength
only for max-height and max-width.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 29 Aug 2006 23:35:57 +0000 (23:35 +0000)]
2006-08-29 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by eseidel.
Add path-related SVG JavaScript bindings to generation.
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 29 Aug 2006 23:19:33 +0000 (23:19 +0000)]
2006-08-29 Eric Seidel <eric@eseidel.com>
Reviewed by kevin.
Re-enable path-related SVG JavaScript bindings.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10623
Split all SVGPathSeg*.idl files into Abs and Rel pieces.
Move all SVGPath*.idl files into ksvg2/svg
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorJS.pm: Special case Abs and Rel header includes
* ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathElement.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathSeg.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathSegArc.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathSegLineto.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathSegList.idl: Removed.
* ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl: Removed.
* ksvg2/ksvg.h: move SVGPathSegment enum
* ksvg2/svg/SVGPathElement.cpp: move SVGPathSegment enum
(WebCore::SVGPathElement::toPathData):
* ksvg2/svg/SVGPathSeg.cpp:
(WebCore::SVGPathSeg::SVGPathSeg):
* ksvg2/svg/SVGPathSeg.h:
(WebCore::SVGPathSeg::):
* ksvg2/svg/SVGPathSegArcAbs.idl: Added.
* ksvg2/svg/SVGPathSegArcRel.idl: Added.
* ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl: Added.
* ksvg2/svg/SVGPathSegCurvetoCubicRel.idl: Added.
* ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl: Added.
* ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl: Added.
* ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl: Added.
* ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl: Added.
* ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl: Added.
* ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl: Added.
* ksvg2/svg/SVGPathSegLinetoAbs.idl: Added.
* ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl: Added.
* ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl: Added.
* ksvg2/svg/SVGPathSegLinetoRel.idl: Added.
* ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl: Added.
* ksvg2/svg/SVGPathSegLinetoVerticalRel.idl: Added.
* ksvg2/svg/SVGPathSegMovetoAbs.idl: Added.
* ksvg2/svg/SVGPathSegMovetoRel.idl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 29 Aug 2006 23:13:34 +0000 (23:13 +0000)]
Forgot this
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 29 Aug 2006 22:52:30 +0000 (22:52 +0000)]
Reviewed by Tim Hatcher.
* Scripts/gdb-safari: Set DYLD_FRAMEWORK_PATH inside gdb instead of setting it in gdb's environment
to work around what seems to be a bug in some versions of gdb.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 29 Aug 2006 22:49:41 +0000 (22:49 +0000)]
2006-08-28 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Eric, landed by Anders.
Fixes one chunk of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
Finish Unity merging. Remove libcurl usage, in favour of KIO.
This makes the regression testing fly! IO processing is way faster now.
* CMakeLists.txt:
* platform/ResourceLoaderInternal.h:
(WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
* platform/qt/FrameQt.cpp:
(WebCore::FrameQt::openURL):
(WebCore::FrameQt::submitForm):
(WebCore::FrameQt::urlSelected):
(WebCore::FrameQt::createEmptyDocument):
(WebCore::FrameQt::receivedData):
(WebCore::FrameQt::receivedAllData):
* platform/qt/FrameQt.h:
* platform/qt/ResourceLoaderCurl.cpp: Removed.
* platform/qt/ResourceLoaderManager.cpp:
(WebCore::ResourceLoaderManager::ResourceLoaderManager):
(WebCore::ResourceLoaderManager::~ResourceLoaderManager):
(WebCore::ResourceLoaderManager::self):
(WebCore::ResourceLoaderManager::slotData):
(WebCore::ResourceLoaderManager::slotMimetype):
(WebCore::ResourceLoaderManager::slotResult):
(WebCore::ResourceLoaderManager::remove):
(WebCore::ResourceLoaderManager::add):
* platform/qt/ResourceLoaderManager.h:
* platform/qt/ResourceLoaderQt.cpp: Added.
(WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
(WebCore::ResourceLoader::~ResourceLoader):
(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::cancel):
(WebCore::ResourceLoader::assembleResponseHeaders):
(WebCore::ResourceLoader::retrieveCharset):
(WebCore::ResourceLoader::receivedResponse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 29 Aug 2006 22:37:27 +0000 (22:37 +0000)]
Reviewed by Tim Hatchers rubber stamp
Removed some accidentally left-in console spew during the conversion to the new DB
* Misc/WebIconDatabase.m:
(objectFromPathForKey): Nuked some NSLogs
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Tue, 29 Aug 2006 22:14:42 +0000 (22:14 +0000)]
Reviewed by Darin Adler.
<rdar://problem/
4688618> REGRESSION(10.4.7-9A241): JMol java applet fails in Safari not Firefox
No layout test for now because Java doesn't work in DumpRenderTree.
* Plugins/WebPluginDatabase.m:
(-[WebPluginDatabase refresh]):
Add each plug-in MIME type to registeredMIMETypes, even if we don't register a document view class for the
MIME type. This fixes -[WebPluginDatabase isMIMETypeRegistered:] and thus fallback content for Java applets
(we were always rendering fallback content, if any, for Java applets).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16101
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 29 Aug 2006 21:58:08 +0000 (21:58 +0000)]
Reviewed by Eric.
Bug 10632: Objective-C DOM should use the @property syntax for DOM attributes
http://bugzilla.opendarwin.org/show_bug.cgi?id=10632
Generate @property when MACOSX_DEPLOYMENT_TARGET is >= 10.5.
This is backwards compatible with the getter/setter methods.
Generate setter arguments with a "new" prefix to avoid the property
name conflict warning. Also removes some whitespace and the comments
that we added to the headers. This makes the headers look like what we ship now.
* bindings/objc/DOMCSS.mm:
(-[DOMDocument getComputedStyle::]): renamed a local variable to avoid the property name conflict.
(-[DOMDocument getMatchedCSSRules::]): ditto.
* bindings/scripts/CodeGeneratorObjC.pm: generate @property in the headers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16100
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 29 Aug 2006 21:40:29 +0000 (21:40 +0000)]
2006-08-30 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by Anders.
Fix time calculation, by using a correct calculation. Calling time()
returns a number of seconds, aka. an integer. Fix it by using gettimeofday().
Patch originally proposed by Ronan Meneu <rmeneu@origyn.fr>
* platform/qt/SystemTimeQt.cpp:
(WebCore::currentTime):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16099
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 29 Aug 2006 20:33:54 +0000 (20:33 +0000)]
WebCore:
Reviewed by Tim H.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10628
Auto-generate the remaining Objective-C DOM bindings
Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
and DOMHTMLOptionsCollection, and lays groundwork for the rest of the
HTML DOM bindings by adding/fixing the appropriate IDL's and updating
the CodeGeneratorObjC.pm build script.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
* bindings/objc/DOMExtensions.h:
* bindings/objc/DOMHTML.h:
* bindings/objc/DOMHTML.mm:
* bindings/objc/DOMHTMLInternal.h:
* bindings/scripts/CodeGeneratorObjC.pm:
* html/HTMLAnchorElement.idl:
* html/HTMLAreaElement.idl:
* html/HTMLBaseFontElement.idl:
* html/HTMLBodyElement.idl:
* html/HTMLButtonElement.idl:
* html/HTMLCollection.idl: Added.
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/HTMLFormElement.idl:
* html/HTMLFrameElement.idl: Added.
* html/HTMLFrameSetElement.idl: Added.
* html/HTMLIFrameElement.idl: Added.
* html/HTMLImageElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLLabelElement.idl:
* html/HTMLLegendElement.idl:
* html/HTMLLinkElement.idl:
* html/HTMLMapElement.idl:
* html/HTMLObjectElement.idl: Added.
* html/HTMLOptionsCollection.idl:
* html/HTMLPreElement.idl:
* html/HTMLSelectElement.idl: Added.
* html/HTMLStyleElement.idl:
* html/HTMLTableCaptionElement.idl: Added.
* html/HTMLTableCellElement.idl: Added.
* html/HTMLTableColElement.idl: Added.
* html/HTMLTableElement.idl: Added.
* html/HTMLTableRowElement.idl: Added.
* html/HTMLTableSectionElement.idl: Added.
* html/HTMLTextAreaElement.idl:
WebKit:
Reviewed by Tim H.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10628
Auto-generate the remaining Objective-C DOM bindings
Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
and DOMHTMLOptionsCollection.
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 29 Aug 2006 20:05:09 +0000 (20:05 +0000)]
2006-08-29 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by ap.
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10629.
Drawing convex polygons is broken in the Qt platform.
* platform/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawConvexPolygon):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 29 Aug 2006 19:16:12 +0000 (19:16 +0000)]
Reviewed by Eric.
Implementing font hashing properly, fixes weird crashes in HashMap.
* platform/qt/FontPlatformData.h:
* platform/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::hash):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 29 Aug 2006 19:11:39 +0000 (19:11 +0000)]
Reviewed by ggaren.
Fix scrollbars to reappear after the first layouting.
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::suppressScrollBars):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 29 Aug 2006 18:58:58 +0000 (18:58 +0000)]
2006-08-29 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin and Geoff.
Move the CF String functions to separate files in platform/cf.
Also, move the files in platform/cfnet to platform/cf.
* WebCore.xcodeproj/project.pbxproj:
* platform/PlatformString.h:
* platform/StringImpl.h:
* platform/cf/StringCF.cpp: Added.
(WebCore::String::String):
* platform/cf/StringImplCF.cpp: Added.
(WebCore::StringImpl::createCFString):
* platform/cfnet/KURLCFNet.cpp: Removed.
* platform/cfnet/ResourceLoaderCFNet.cpp: Removed.
* platform/mac/StringImplMac.mm:
* platform/mac/StringMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 29 Aug 2006 18:56:12 +0000 (18:56 +0000)]
Rolling out a change I included by accident in my last commit.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::passMouseDownEventToWidget):
* platform/mac/SharedTimerMac.cpp:
(WebCore::setSharedTimerFireTime):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Tue, 29 Aug 2006 17:25:51 +0000 (17:25 +0000)]
Reviewed by Darin
Short of a few small snippets that still need to be pushed to WebCore, this
is a final prune of WebIconDatabase. WebFileDatabase and WebLRUFileList are gone
and the small remaining snippets of WebFileDatabase code that were still important
are now in static functions in WebIconDatabase.m
* Loader/WebIconLoader.m:
(-[WebIconLoader didFinishLoading]): Removed the flag
* Misc/WebFileDatabase.h: Removed.
* Misc/WebFileDatabase.m: Removed.
* Misc/WebIconDatabase.m:
(+[WebIconDatabase sharedIconDatabase]):
(-[WebIconDatabase init]):
(-[WebIconDatabase iconForURL:withSize:cache:]):
(-[WebIconDatabase iconURLForURL:]):
(-[WebIconDatabase defaultIconWithSize:]):
(-[WebIconDatabase retainIconForURL:]):
(-[WebIconDatabase releaseIconForURL:]):
(-[WebIconDatabase _isEnabled]):
(-[WebIconDatabase _setIconData:forIconURL:]):
(-[WebIconDatabase _setHaveNoIconForIconURL:]):
(-[WebIconDatabase _setIconURL:forURL:]):
(-[WebIconDatabase _hasEntryForIconURL:]):
(-[WebIconDatabase _applicationWillTerminate:]):
(-[WebIconDatabase _resetCachedWebPreferences:]):
(uniqueFilePathForKey): Added from WebFileDatabase
(objectFromPathForKey): Added from WebFileDatabase
(iconDataFromPathForIconURL):
(-[WebIconDatabase _convertToWebCoreFormat]): Make use of static functions and local variables
instead of using WebFileDatabase and WebIconDatabase variables that are now obsolete
* Misc/WebIconDatabasePrivate.h: Removed alot of obsoleted members
* Misc/WebLRUFileList.h: Removed.
* Misc/WebLRUFileList.m: Removed.
* WebKit.xcodeproj/project.pbxproj: Deleted 4 files
* WebKitPrefix.h: Removed ICONDEBUG
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 29 Aug 2006 01:13:33 +0000 (01:13 +0000)]
Reviewed by Maciej.
Added support for experimental CFNetwork-based loader (not turned on yet).
While I was there, I did the following platform cleanup:
- Windows now uses USE(WININET) instead of PLATFORM(WIN_OS), to match the
USE(CFNETWORK) idiom.
- Removed some #includes of windows.h in platform-independent headers.
- Changed #ifdef __APPLE__ to PLATFORM(MAC)
- Fixed some build bustage, including case-sensitive filesystem bustage.
* loader/loader.cpp:
(WebCore::Loader::receivedAllData):
* platform/Cursor.h:
* platform/KURL.h:
* platform/ResourceLoader.h:
* platform/ResourceLoaderClient.h:
* platform/ResourceLoaderInternal.h:
(WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
* platform/cfnet/KURLCFNet.cpp: Added.
(WebCore::KURL::createCFURL):
* platform/cfnet/ResourceLoaderCFNet.cpp: Added.
(WebCore::willSendRequest):
(WebCore::didReceiveChallenge):
(WebCore::didCancelChallenge):
(WebCore::didReceiveResponse):
(WebCore::didReceiveData):
(WebCore::didFinishLoading):
(WebCore::didFail):
(WebCore::willCacheResponse):
(WebCore::addHeadersFromString):
(WebCore::ResourceLoaderInternal::~ResourceLoaderInternal):
(WebCore::ResourceLoader::~ResourceLoader):
(WebCore::arrayFromFormData):
(WebCore::emptyPerform):
(WebCore::runLoaderThread):
(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::cancel):
* platform/win/CursorWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 29 Aug 2006 00:35:05 +0000 (00:35 +0000)]
LayoutTests:
Reviewed by harrison
* editing/inserting/redo-expected.checksum: Added.
* editing/inserting/redo-expected.png: Added.
* editing/inserting/redo-expected.txt: Added.
* editing/inserting/redo.html: Added.
* editing/pasteboard/copy-paste-bidi-expected.txt:
WebCore:
Reviewed by harrison
<rdar://problem/
4700341>
REGRESSION: In new mail message, caret isn't placed at end of line after redoing typing
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Added a FIXME.
* page/Frame.cpp:
(WebCore::Frame::reappliedEditing): Restore the endingSelection(), not the startingSelection().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Tue, 29 Aug 2006 00:30:05 +0000 (00:30 +0000)]
Reviewed by Darin Adler.
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView createPluginScriptableObject]):
Removed a bogus typecast.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Mon, 28 Aug 2006 23:18:36 +0000 (23:18 +0000)]
WebCore:
Reviewed by John Sullivan.
Part of <rdar://problem/
4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
<http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox
No test cases added, since this is essentially a leak fix.
A brief history of NPP_GetValue(), NPObjects, and reference counting.
Earlier versions of WebKit incorrectly interpreted the NPRuntime reference counting rules. We failed to take
into account the fact that plug-ins are required to retain NPObjects before returning them. This creates several
classes of interesting plug-ins:
1) Plug-ins tested in WebKit and other browsers. These plug-ins may have WebKit-specific workarounds to not retain
the returned NPObject, thus avoiding the memory leak in WebKit.
2) Plug-ins tested only in other browsers. These plug-ins must already retain their NPObjects, since other browsers
implemented the NPRuntime retain/release rules correctly. These plug-ins likely work in WebKit, but probably leak
NPObjects since WebKit adds its own retain in addition to the plug-in's retain.
3) Plug-ins tested only in WebKit, that fail to retain their NPObjects before returning them.
Such plug-ins are guaranteed to crash in other browsers due to the missing expected retain. These plug-ins
work in older WebKits because WebKit did not expect the plug-in to retain the NPObject. Now that our retain
rules match other browsers, these plug-ins may crash due to the difference in retain/release behavior. We could
potentially detect that situation and correct it here, but I consider it a bug that the plug-in did not follow the
documented NPRuntime reference counting rules. Furthermore, it is extremely unlikely that someone would develop
a Netscape plug-in and test it *only* in WebKit. The entire purpose of creating a Netscape plugin is so that it
works in all browsers!
4) Plug-ins tested only in WebKit, that properly retain their NPObjects before returning them.
These plug-ins probably work in other browsers, and leak their NPObjects in older WebKits because of WebKit's
extra retain. A developer of this type of plug-in is probably unaware of the NPObject leak. A more savvy developer
would create a plug-in that fits into category #1.
I am changing our NPP_GetValue() behavior to match Firefox and other browsers -- the plug-in is now expected to retain the
returned NPObject, and the browser is expected to release it when done. This means that plug-ins in category #3 need to be
changed so that they don't crash in Safari. However, such plug-ins already crash in every other browser, so I do not feel that
this needs to be handled specifically by WebKit.
* bridge/mac/FrameMac.mm:
Changed -pluginScriptableObject to -createPluginScriptableObject to make clearer the contract that the method must return a
retained NPObject. Also changed it to return an actual NPObject* instead of a void*. There is only one caller of this method,
and only one implementor. Using void* here is a needless abstraction. It's an NPObject*! Admit it!
(WebCore::getInstanceForView):
Release the NPObject after creating the bindings instance. This is the actual bug fix.
WebKit:
Reviewed by John Sullivan.
Part of <rdar://problem/
4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
<http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView createPluginScriptableObject]):
Renamed this method (see corresponding WebCore ChangeLog entry for an explanation).
Style changes.
WebKitTools:
Reviewed by John Sullivan.
Part of <rdar://problem/
4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
<http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox
* DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
(NPP_GetValue):
WebKit's NPP_GetValue() reference counting behavior has been changed to match Firefox. NPObject return values
are expected to be retained by the plug-in, and released by the caller.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aliceli1 [Mon, 28 Aug 2006 20:43:36 +0000 (20:43 +0000)]
LayoutTests:
Reviewed by Geoff.
Added tests for <rdar://problem/
4548537> Document.domain and other attributes are blank for an iframe created with document.write
* http/tests/misc/iframe-domain-test-expected.txt: Added.
* http/tests/misc/iframe-domain-test.html: Added.
WebCore:
Reviewed by Geoff.
Fixed <rdar://problem/
4548537> Document.domain and other attributes are blank for an iframe created with document.write
* dom/Document.cpp:
(WebCore::Document::open):
set the document's url to the parent's url and re-located the code that does this to occur before calling the frame's didExplicitOpen()
* page/Frame.cpp:
(WebCore::Frame::didExplicitOpen):
set the frame's url to the document's url
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 28 Aug 2006 19:00:47 +0000 (19:00 +0000)]
Reviewed by Adele and Adam
Added an optimization to return early if there's no replacements to be made
* platform/StringImpl.cpp:
(WebCore::StringImpl::replace):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 28 Aug 2006 18:49:55 +0000 (18:49 +0000)]
2006-08-28 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by ap.
Fixes one chunk of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
Provide stub implementation of RenderPopupMenuQt.
* CMakeLists.txt:
* platform/qt/RenderPopupMenuQt.cpp: Added.
(WebCore::RenderPopupMenuQt::RenderPopupMenuQt):
(WebCore::RenderPopupMenuQt::~RenderPopupMenuQt):
(WebCore::RenderPopupMenuQt::clear):
(WebCore::RenderPopupMenuQt::populate):
(WebCore::RenderPopupMenuQt::showPopup):
(WebCore::RenderPopupMenuQt::hidePopup):
(WebCore::RenderPopupMenuQt::addSeparator):
(WebCore::RenderPopupMenuQt::addGroupLabel):
(WebCore::RenderPopupMenuQt::addOption):
* platform/qt/RenderPopupMenuQt.h: Added.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::createPopupMenu):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 28 Aug 2006 18:40:39 +0000 (18:40 +0000)]
2006-08-28 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by ap.
Fixes one chunk of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
Offer QString -> DeprecatedString conversion.
* platform/DeprecatedString.h:
* platform/qt/StringQt.cpp:
(WebCore::DeprecatedString::DeprecatedString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 28 Aug 2006 18:37:49 +0000 (18:37 +0000)]
2006-08-28 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Tim Hatcher.
Fixes one chunk of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
WebCore:
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::systemFont):
Remove annoying notImplemented() usage in systemFont()
WebKitTools:
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::checkLoaded): Faster polling for isLoaded() in
Qt's DumpRenderTree.
* Scripts/run-webkit-tests:
Use -expected-qt.txt etc.. output in run-webkit-test if isQt().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 28 Aug 2006 18:25:42 +0000 (18:25 +0000)]
Reviewed by Geoff.
* kjs/list.h: Use explicit in constructor (as appropriate).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 28 Aug 2006 18:22:49 +0000 (18:22 +0000)]
Reviewed by Tim Hatcher.
* Scripts/build-drosera: Fix behavior when there are multiple options.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 28 Aug 2006 18:22:32 +0000 (18:22 +0000)]
Reviewed by Tim Hatcher's rubberstamp
Rolled out my last change (16070 - pruning WebFileDatabase code) as it caused a difficult-to-track down
failure in layout tests on a release build.
* Misc/WebFileDatabase.h:
* Misc/WebFileDatabase.m:
(+[WebFileDatabaseOp opWithCode:key:object:]):
(-[WebFileDatabaseOp initWithCode:key:object:]):
(-[WebFileDatabaseOp opcode]):
(-[WebFileDatabaseOp key]):
(-[WebFileDatabaseOp object]):
(-[WebFileDatabaseOp perform:]):
(-[WebFileDatabaseOp dealloc]):
(SetThreadPriority):
(-[WebFileDatabase _createLRUList:]):
(-[WebFileDatabase _truncateToSizeLimit:]):
(+[WebFileDatabase _syncLoop:]):
(databaseInit):
(-[WebFileDatabase setTimer]):
(-[WebFileDatabase setObject:forKey:]):
(-[WebFileDatabase removeObjectForKey:]):
(-[WebFileDatabase removeAllObjects]):
(-[WebFileDatabase objectForKey:]):
(-[WebFileDatabase performSetObject:forKey:]):
(-[WebFileDatabase performRemoveObjectForKey:]):
(-[WebFileDatabase open]):
(-[WebFileDatabase close]):
(-[WebFileDatabase lazySync:]):
(-[WebFileDatabase sync]):
(-[WebFileDatabase sizeLimit]):
(-[WebFileDatabase count]):
(-[WebFileDatabase usage]):
(-[WebFileDatabase setSizeLimit:]):
* Misc/WebIconDatabase.m:
(-[WebIconDatabase _createFileDatabase]):
(-[WebIconDatabase _loadIconDictionaries]):
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 28 Aug 2006 18:18:55 +0000 (18:18 +0000)]
Reviewed by Tim Hatcher.
* WebInspector/webInspector/inspector.js: Add "resize: none" to the list of
default values for CSS properties so it will be omitted from most displays
of computed style.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Mon, 28 Aug 2006 15:54:41 +0000 (15:54 +0000)]
Reviewed by Darin.
<rdar://problem/
3942647> Support AXStyleTextMarkerRangeForTextMarker parameterized attribute
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
Add AXStyleTextMarkerRangeForTextMarker.
(startOfStyleRange):
(endOfStyleRange):
Return first/last VisiblePosition in range having the same style has the specified VisiblePosition.
(-[WebCoreAXObject doAXStyleTextMarkerRangeForTextMarker:]):
Return AXTextMarkerRange for startOfStyleRange/endOfStyleRange of the specified AXTextMarker.
(-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
Call doAXStyleTextMarkerRangeForTextMarker for AXStyleTextMarkerRangeForTextMarker.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Mon, 28 Aug 2006 15:46:05 +0000 (15:46 +0000)]
Reviewed by Darin.
<rdar://problem/
4517383> Hide all images used for spacing purpose in AX
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityIsIgnored]):
Check for one-dimensional image
Check whether rendered image was stretched from one-dimensional file image
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 28 Aug 2006 09:18:58 +0000 (09:18 +0000)]
Reviewed by Maciej
Major prune of unnecessary WebFileDatabase code. In the end, what
useful code that remains in WebFileDatabase will likely be moved directly
into WebIconDatabase
* Misc/WebFileDatabase.h:
* Misc/WebFileDatabase.m:
(-[WebFileDatabase initWithPath:]):
(-[WebFileDatabase objectForKey:]):
(-[WebFileDatabase open]):
(-[WebFileDatabase close]):
* Misc/WebIconDatabase.m:
(-[WebIconDatabase _createFileDatabase]):
(-[WebIconDatabase _loadIconDictionaries]):
* Misc/WebLRUFileList.h: Removed.
* Misc/WebLRUFileList.m: Removed.
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Mon, 28 Aug 2006 05:59:56 +0000 (05:59 +0000)]
Reviewed by Maciej
Rewrote StringImpl::replace(UChar, StringImpl*)
* platform/StringImpl.cpp:
(WebCore::StringImpl::replace):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 28 Aug 2006 03:33:34 +0000 (03:33 +0000)]
WebCore:
Reviewed by Tim H.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=4624
WebCore needs autogenerated Obj-C DOM bindings
First round of auto-generated Objective C DOM bindings, starting
with the DOM Core.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
(-[DOMNode description]):
(-[DOMNode KJS::Bindings::]):
(-[DOMNode dispatchEvent:]):
(-[DOMNamedNodeMap _initWithNamedNodeMap:]):
(+[DOMNamedNodeMap _namedNodeMapWith:]):
(-[DOMNodeList _initWithNodeList:]):
(+[DOMNodeList _nodeListWith:]):
(-[DOMImplementation _initWithDOMImplementation:]):
(+[DOMImplementation _DOMImplementationWith:]):
(-[DOMImplementation _DOMImplementation]):
(+[DOMDocumentFragment _documentFragmentWith:]):
(-[DOMDocumentFragment _fragment]):
(-[DOMDocument createCSSStyleDeclaration]):
(+[DOMDocument _documentWith:]):
(-[DOMDocument _document]):
(-[DOMDocument _ownerElement]):
(+[DOMAttr _attrWith:]):
(-[DOMAttr _attr]):
(+[DOMDocumentType _documentTypeWith:WebCore::]):
(-[DOMDocumentType WebCore::]):
(+[DOMText _textWith:WebCore::]):
(+[DOMComment _commentWith:WebCore::]):
(+[DOMCDATASection _CDATASectionWith:WebCore::]):
(+[DOMProcessingInstruction _processingInstructionWith:WebCore::]):
(+[DOMEntityReference _entityReferenceWith:WebCore::]):
* bindings/objc/DOMCSS.h:
* bindings/objc/DOMCSS.mm:
* bindings/objc/DOMCore.h:
* bindings/objc/DOMEvents.h:
* bindings/objc/DOMEvents.mm:
* bindings/objc/DOMExtensions.h:
* bindings/objc/DOMHTML.mm:
(+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
* bindings/objc/DOMHTMLInternal.h:
* bindings/objc/DOMImplementationFront.h:
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMNode.h: Added.
* bindings/objc/DOMNode.mm: Added.
(-[DOMNode dealloc]):
(-[DOMNode finalize]):
(-[DOMNode nodeName]):
(-[DOMNode nodeValue]):
(-[DOMNode setNodeValue:]):
(-[DOMNode nodeType]):
(-[DOMNode parentNode]):
(-[DOMNode childNodes]):
(-[DOMNode firstChild]):
(-[DOMNode lastChild]):
(-[DOMNode previousSibling]):
(-[DOMNode nextSibling]):
(-[DOMNode attributes]):
(-[DOMNode ownerDocument]):
(-[DOMNode insertBefore::]):
(-[DOMNode replaceChild::]):
(-[DOMNode removeChild:]):
(-[DOMNode appendChild:]):
(-[DOMNode hasChildNodes]):
(-[DOMNode cloneNode:]):
(-[DOMNode normalize]):
(-[DOMNode isSupported::]):
(-[DOMNode namespaceURI]):
(-[DOMNode prefix]):
(-[DOMNode setPrefix:]):
(-[DOMNode localName]):
(-[DOMNode hasAttributes]):
(-[DOMNode isSameNode:]):
(-[DOMNode isEqualNode:]):
(-[DOMNode isDefaultNamespace:]):
(-[DOMNode lookupPrefix:]):
(-[DOMNode lookupNamespaceURI:]):
(-[DOMNode textContent]):
(-[DOMNode setTextContent:]):
(-[DOMNode boundingBox]):
(-[DOMNode lineBoxRects]):
* bindings/objc/DOMObject.h: Added.
* bindings/objc/DOMObject.mm: Added.
(-[DOMObject init]):
(-[DOMObject dealloc]):
(-[DOMObject finalize]):
(-[DOMObject copyWithZone:]):
(-[DOMObject sheet]):
* bindings/objc/DOMPrivate.h:
* bindings/objc/DOMRange.h:
* bindings/objc/DOMStylesheets.h:
* bindings/objc/DOMTraversal.h:
* bindings/objc/DOMViews.h:
* bindings/objc/DOMViews.mm:
* bindings/objc/DOMXPath.h:
* bindings/objc/DOMXPath.mm:
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm: Added.
* dom/Attr.idl:
* dom/CDATASection.idl: Added.
* dom/Comment.idl: Added.
* dom/DOMImplementation.idl:
* dom/Document.idl:
* dom/Element.idl:
* dom/EntityReference.idl: Added.
* dom/NamedNodeMap.idl: Added.
* dom/NodeList.idl: Added.
* dom/ProcessingInstruction.idl:
WebKit:
Reviewed by Tim H.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=4624
WebCore needs autogenerated Obj-C DOM bindings
First round of auto-generated Objective C DOM bindings, starting
with the DOM Core.
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 28 Aug 2006 00:26:37 +0000 (00:26 +0000)]
Reviewed by Anders.
Drosera will be built when you type make.
* Drosera/Makefile: Added.
* Makefile: Added.
* Makefile.shared: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sun, 27 Aug 2006 23:12:17 +0000 (23:12 +0000)]
Reviewed by Tim H.
Fix crash in LayoutTests/css1/font_properties/font.html,
by implementing FontData::smallCapsFontData.
* platform/qt/FontDataQt.cpp:
(WebCore::FontData::platformDestroy):
(WebCore::FontData::smallCapsFontData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sun, 27 Aug 2006 22:57:38 +0000 (22:57 +0000)]
Reviewed by Maciej
Plugged a leak in StringImpl::replace()
* platform/StringImpl.cpp:
(WebCore::StringImpl::replace):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 27 Aug 2006 22:29:23 +0000 (22:29 +0000)]
2006-08-27 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by Anders.
Remove most annoying notImplemented() usages and
implement some missing ScrollViewQt functions.
Much nicer output when invoking run-webkit-tests.
* platform/qt/FrameQt.cpp:
(WebCore::FrameQt::saveDocumentState):
(WebCore::FrameQt::restoreDocumentState):
(WebCore::FrameQt::clearUndoRedoOperations):
(WebCore::FrameQt::partClearedInBegin):
* platform/qt/ResourceLoaderManager.cpp:
(WebCore::headerCallback):
(WebCore::ResourceLoaderManager::downloadTimerCallback):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::updateContents):
(WebCore::ScrollView::suppressScrollBars):
(WebCore::ScrollView::setStaticBackground):
(WebCore::ScrollView::addChild):
(WebCore::ScrollView::removeChild):
* platform/qt/TemporaryLinkStubs.cpp:
(WebCore::historyContains):
(WebCore::CheckCacheObjectStatus):
(WebCore::CheckIfReloading):
(loadResourceIntoArray):
(WebCore::PlugInInfoStore::supportsMIMEType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 27 Aug 2006 22:18:36 +0000 (22:18 +0000)]
Forgot this too (doh!)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 27 Aug 2006 22:07:09 +0000 (22:07 +0000)]
Didn't mean to commit this!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 27 Aug 2006 22:03:46 +0000 (22:03 +0000)]
2006-08-27 Anders Carlsson <acarlsson@apple.com>
Forgot to add these.
* DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added.
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::~DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::readStdin):
(WebCore::DumpRenderTree::checkLoaded):
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
* DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added.
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 27 Aug 2006 21:53:16 +0000 (21:53 +0000)]
2006-08-27 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Eric, landed by Anders.
Add DumpRenderTree support for Qt/Linux.
* DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added.
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::~DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::readStdin):
(WebCore::DumpRenderTree::checkLoaded):
* DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
* DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added.
(main):
* Scripts/build-dumprendertree:
* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 27 Aug 2006 21:47:03 +0000 (21:47 +0000)]
2006-08-27 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by Anders.
Fix Qt build (add SVGMetaDataElement.cpp to build system)
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sun, 27 Aug 2006 21:40:51 +0000 (21:40 +0000)]
2006-08-27 Eric Seidel <eric@eseidel.com>
Reviewed by andersca.
No logic changes. Just cleanup.
* ksvg2/svg/SVGAngle.cpp:
(SVGAngle::SVGAngle):
(SVGAngle::unitType):
(SVGAngle::valueAsString):
(SVGAngle::newValueSpecifiedUnits):
(SVGAngle::convertToSpecifiedUnits):
* ksvg2/svg/SVGAngle.h:
* ksvg2/svg/SVGLength.cpp:
(WebCore::SVGLength::unitType):
(WebCore::SVGLength::newValueSpecifiedUnits):
(WebCore::SVGLength::convertToSpecifiedUnits):
(WebCore::SVGLength::updateValue):
(WebCore::SVGLength::updateValueInSpecifiedUnits):
* ksvg2/svg/SVGLength.h:
* platform/BitmapImage.cpp: Removed.
* platform/BitmapImage.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sun, 27 Aug 2006 21:30:25 +0000 (21:30 +0000)]
God, that ChangeLog entry was bad...
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sun, 27 Aug 2006 21:28:40 +0000 (21:28 +0000)]
Reviewed by Anders
-Changed all of the commonly used queries to keep around pre-prepared statements and bind
their arguments instead of constructing a messy.
-Changed some code in pruneUnretainedIconsOnStartup regarding transactions
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase): Initializers
(WebCore::IconDatabase::close): Wipe all the preprepared statements
(WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Better handling of transactions
(WebCore::readySQLStatement): Make sure a preprepared statement is ready to go for a fooQuery()
(WebCore::IconDatabase::pageURLTableIsEmptyQuery): Added a comment
(WebCore::IconDatabase::imageDataForIconURLQuery): Use preprepared statement + binding
(WebCore::IconDatabase::timeStampForIconURLQuery): ditto
(WebCore::IconDatabase::iconURLForPageURLQuery): ditto
(WebCore::IconDatabase::forgetPageURLQuery): ditto
(WebCore::IconDatabase::setIconIDForPageURLQuery): ditto
(WebCore::IconDatabase::getIconIDForIconURLQuery): ditto
(WebCore::IconDatabase::addIconForIconURLQuery): ditto
(WebCore::IconDatabase::hasIconForIconURLQuery): ditto
* loader/icon/IconDatabase.h: Added fooQuery() and *m_fooStatements
* loader/icon/SQLStatement.h:
(WebCore::SQLStatement::database): Added
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Sun, 27 Aug 2006 19:27:34 +0000 (19:27 +0000)]
Reviewed by Eric. Landed by rwlbuis.
Fix switch logic.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Sun, 27 Aug 2006 10:47:15 +0000 (10:47 +0000)]
Reviewed by Eric.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10557
KCanvasPath should be replace by platform/Path
Refactoring out the KCanvasPath class.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sun, 27 Aug 2006 07:09:16 +0000 (07:09 +0000)]
2006-08-26 Eric Seidel <eric@eseidel.com>
Reviewed by hyatt.
pointer-events attribute does not work.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10415
* kcanvas/RenderPath.cpp:
(WebCore::RenderPath::pointerEventsHitRules): new function to contain pointer-events hit logic
(WebCore::RenderPath::nodeAtPoint): respect pointer-events property
* kcanvas/RenderPath.h:
(WebCore::RenderPath::PointerEventsHitRules::PointerEventsHitRules):
* ksvg2/css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* ksvg2/svg/SVGPaint.cpp: Fix this to use a real enum value
(WebCore::SVGPaint::SVGPaint):
(WebCore::SVGPaint::paintType):
(WebCore::SVGPaint::uri):
(WebCore::SVGPaint::setUri):
(WebCore::SVGPaint::setPaint):
* ksvg2/svg/SVGPaint.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Sat, 26 Aug 2006 22:45:36 +0000 (22:45 +0000)]
Reviewed by Eric.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10558
SVG should have support for <metadata> element
Add support for metadata tag.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 26 Aug 2006 09:51:46 +0000 (09:51 +0000)]
Reviewed by Eric.
Daily Qt build fixes :-)
* platform/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawConvexPolygon):
* platform/qt/ImageQt.cpp:
(WebCore::Image::initPlatformData):
(WebCore::Image::invalidatePlatformData):
(WebCore::Image::loadPlatformResource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16051
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 26 Aug 2006 08:11:39 +0000 (08:11 +0000)]
Fix the ifdef in Path.h to be CG.
* platform/Path.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16050
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 26 Aug 2006 07:48:51 +0000 (07:48 +0000)]
Fix Mac build bustage (lots of float/int confusion). I am not sure
whether rounding was desired or not... this is just a band-aid to get
the build working again.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 26 Aug 2006 06:49:35 +0000 (06:49 +0000)]
More refactoring of image to disentangle graphics (e.g., Cairo) from
platform (e.g., Windows).
* WebCore.vcproj/WebCore/WebCore.vcproj:
Add ImageWin to project.
* loader/Cache.cpp:
(WebCore::Cache::init):
* loader/icon/IconDataCache.cpp:
(WebCore::IconDataCache::loadImageFromResource):
Renamed loadResource to loadPlatformResource to try to make it more clear
that this call is implemented on each OS (and not by graphics libraries).
* platform/Image.cpp:
(WebCore::Image::Image):
(WebCore::Image::~Image):
(WebCore::Image::invalidateData):
(WebCore::Image::size):
(WebCore::Image::setData):
(WebCore::Image::setNativeData):
Fix up the PDF code to not be considered platform data any more, since
PDF rendering is not for a specific OS.
Renamed the methods that set OS-specific data (like NSImage) to PlatformData
instead of NativeData.
* platform/Image.h:
Shifted the PDF members into CG defines. Made CGImageRef a CG define.
Renamed methods to reflect that they are OS-specific and not
graphics-library-specific.
* platform/cairo/ImageCairo.cpp:
Removed the platform data methods. Other platforms besides Windows that
use Cairo will need to account for this change by adding these methods
to their OS Image***.cpp file.
* platform/cg/ImageCG.cpp:
(WebCore::Image::drawTiled):
Add FIXMEs to the wkpattern stuff.
* platform/cg/PDFDocumentImage.cpp:
Shouldn't have #imports in .cpp.
* platform/mac/ImageMac.mm:
(WebCore::Image::initPlatformData):
(WebCore::Image::invalidatePlatformData):
(WebCore::Image::loadPlatformResource):
(WebCore::Image::getTIFFRepresentation):
Add the platform data initializers to the Mac Image file. Move the
TIFF representation there as well, since this is only used by Mac code.
* platform/win/ImageWin.cpp: Added.
(WebCore::Image::initPlatformData):
(WebCore::Image::invalidatePlatformData):
(WebCore::Image::loadPlatformResource):
(WebCore::Image::supportsType):
Similar work for Windows. Add stubs for possible future HBITMAP returns
in the platform data methods.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintResizeControl):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintResizeControl):
loadResource -> loadPlatformResource
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sat, 26 Aug 2006 01:59:04 +0000 (01:59 +0000)]
Rubber-stamped by Adele.
Fixed build.
* platform/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawConvexPolygon):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 26 Aug 2006 00:37:05 +0000 (00:37 +0000)]
Reviewed by Tim Hatcher
Fixed up some leaks on [WebIconDatabase init]
* Misc/WebIconDatabase.m:
(-[WebIconDatabase init]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Sat, 26 Aug 2006 00:33:22 +0000 (00:33 +0000)]
LayoutTests:
Updated results for addition of -webkit-text-security.
* fast/css/computed-style-expected.txt:
WebCore:
Patch by Francisco, Reviewed by me.
Preparation for switch to new text field implementation of password field.
Added -webkit-text-security property.
Tests: updated fast/css/computed-style-expected.txt
* css/CSSPropertyNames.in: Added -webkit-text-security.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added cases for textSecurity.
* css/cssparser.cpp: (WebCore::CSSParser::parseValue): ditto.
* css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
* css/html4.css: Added style for password field to use -webkit-text-security.
* html/HTMLInputElement.cpp: Check appearance property to decide which renderer to use.
(WebCore::HTMLInputElement::selectionStart):
(WebCore::HTMLInputElement::selectionEnd):
(WebCore::HTMLInputElement::setSelectionStart):
(WebCore::HTMLInputElement::setSelectionEnd):
(WebCore::HTMLInputElement::select):
(WebCore::HTMLInputElement::setSelectionRange):
(WebCore::HTMLInputElement::createRenderer):
* html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField): Added check for password.
* platform/StringImpl.cpp: (WebCore::StringImpl::secure): Added. Converts a string to replace
characters with one character, like a bullet.
* platform/StringImpl.h:
* rendering/RenderStyle.cpp:
(WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData): Initialize textSecurity.
(WebCore::RenderStyle::diff): Added case for textSecurity.
* rendering/RenderStyle.h:
(WebCore::):
(WebCore::RenderStyle::textSecurity): Added.
(WebCore::RenderStyle::setTextSecurity): Added.
(WebCore::RenderStyle::initialTextSecurity): Added.
* rendering/RenderText.cpp:
(WebCore::RenderText::setStyle): Added case for textSecurity.
(WebCore::RenderText::setText): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Fri, 25 Aug 2006 23:44:05 +0000 (23:44 +0000)]
LayoutTests:
Reviewed by Hyatt.
New tests and updated tests for styled selects.
* fast/borders/borderRadiusInvalidColor-expected.checksum: Added.
* fast/borders/borderRadiusInvalidColor-expected.png: Added.
* fast/borders/borderRadiusInvalidColor-expected.txt: Added.
* fast/borders/borderRadiusInvalidColor.html: Added.
* fast/forms/select-baseline-expected.checksum: Added.
* fast/forms/select-baseline-expected.png: Added.
* fast/forms/select-baseline-expected.txt: Added.
* fast/forms/select-baseline.html: Added.
* editing/pasteboard/
4641033-expected.txt:
* editing/selection/replaced-boundaries-3-expected.txt:
* editing/selection/select-box-expected.txt:
* fast/block/margin-collapse/103-expected.txt:
* fast/forms/001-expected.checksum:
* fast/forms/001-expected.png:
* fast/forms/001-expected.txt:
* fast/forms/003-expected.txt:
* fast/forms/004-expected.txt:
* fast/forms/HTMLOptionElement_label01-expected.txt:
* fast/forms/HTMLOptionElement_label02-expected.txt:
* fast/forms/HTMLOptionElement_label03-expected.txt:
* fast/forms/HTMLOptionElement_label04-expected.txt:
* fast/forms/HTMLOptionElement_label06-expected.txt:
* fast/forms/HTMLOptionElement_label07-expected.txt:
* fast/forms/form-element-geometry-expected.checksum:
* fast/forms/form-element-geometry-expected.png:
* fast/forms/form-element-geometry-expected.txt:
* fast/forms/option-script-expected.txt:
* fast/forms/option-text-clip-expected.txt:
* fast/forms/select-change-listbox-to-popup-expected.txt:
* fast/forms/select-selected-expected.txt:
* fast/forms/select-style-expected.txt:
* fast/forms/select-visual-hebrew-expected.txt:
* fast/invalid/014-expected.txt:
* fast/parser/document-write-option-expected.txt:
* fast/replaced/width100percent-expected.txt:
* http/tests/navigation/anchor-basic-expected.txt:
* http/tests/navigation/anchor-frames-expected.txt:
* http/tests/navigation/anchor-goback-expected.txt:
* http/tests/navigation/anchor-subframeload-expected.txt:
* http/tests/navigation/javascriptlink-basic-expected.txt:
* http/tests/navigation/javascriptlink-frames-expected.txt:
* http/tests/navigation/javascriptlink-goback-expected.txt:
* http/tests/navigation/javascriptlink-subframeload-expected.txt:
* http/tests/navigation/metaredirect-basic-expected.txt:
* http/tests/navigation/metaredirect-frames-expected.txt:
* http/tests/navigation/metaredirect-goback-expected.txt:
* http/tests/navigation/metaredirect-subframeload-expected.txt:
* http/tests/navigation/post-goback2-expected.txt:
* http/tests/navigation/postredirect-goback2-expected.txt:
* http/tests/navigation/redirect302-basic-expected.txt:
* http/tests/navigation/redirect302-frames-expected.txt:
* http/tests/navigation/redirect302-goback-expected.txt:
* http/tests/navigation/redirect302-subframeload-expected.txt:
* http/tests/navigation/relativeanchor-basic-expected.txt:
* http/tests/navigation/relativeanchor-frames-expected.txt:
* http/tests/navigation/relativeanchor-goback-expected.txt:
* http/tests/navigation/slowmetaredirect-basic-expected.txt:
* http/tests/navigation/slowtimerredirect-basic-expected.txt:
* http/tests/navigation/success200-basic-expected.txt:
* http/tests/navigation/success200-frames-expected.txt:
* http/tests/navigation/success200-frames-loadsame-expected.txt:
* http/tests/navigation/success200-goback-expected.txt:
* http/tests/navigation/success200-loadsame-expected.txt:
* http/tests/navigation/success200-reload-expected.txt:
* http/tests/navigation/success200-subframeload-expected.txt:
* http/tests/navigation/timerredirect-basic-expected.txt:
* http/tests/navigation/timerredirect-frames-expected.txt:
* http/tests/navigation/timerredirect-goback-expected.txt:
* http/tests/navigation/timerredirect-subframeload-expected.txt:
* tables/mozilla/bugs/bug1188-expected.txt:
* tables/mozilla/bugs/bug18359-expected.txt:
* tables/mozilla/bugs/bug2479-3-expected.txt:
* tables/mozilla/bugs/bug2479-4-expected.txt:
* tables/mozilla/bugs/bug29326-expected.txt:
* tables/mozilla/bugs/bug33855-expected.txt:
* tables/mozilla/bugs/bug4382-expected.txt:
* tables/mozilla/bugs/bug96334-expected.txt:
* tables/mozilla/core/margins-expected.txt:
* tables/mozilla/dom/tableDom-expected.txt:
* tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
WebCore:
Reviewed by Hyatt.
Enable styling for popup menus. Also fixed baseline calculation for buttons and selects.
Tests: fast/forms/select-baseline.html
fast/borders/borderRadiusInvalidColor.html
updated: fast/forms/select-style-expected.txt and more...
* css/html4.css: Added style rules for styled select elements.
* platform/GraphicsContext.h: Added argument for antialiasing.
* platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawConvexPolygon): ditto.
* platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawConvexPolygon): ditto.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawBorderArc): Added textColor argument so this can be used when the border color is invalid.
(WebCore::RenderObject::drawBorder): Removed invalidisInvert since its dead code
(any callers that set this to true were already ensuring that their color was valid).
Updated drawConvexPolygon call to use FloatPoints instead of IntPoints.
(WebCore::RenderObject::paintBorder): Updated to remove invalidisInvert argument from drawBorder call.
(WebCore::RenderObject::paintOutline): ditto.
* rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintOutlineForLine): ditto.
* rendering/RenderObject.h: Updated arguments for drawBorder and drawBorderArc.
* rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfLastLineBox): Changed isRootLineBox argument to true when setting line height.
Added case for when there's no children to check for hasLineIfEmpty.
* rendering/RenderBlock.h:
* rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Changed isRootLineBox argument to true when setting line height.
* rendering/RenderButton.h: (WebCore::RenderButton::hasLineIfEmpty): Added so buttons always get a line height.
* rendering/RenderMenuList.h: (WebCore::RenderMenuList::hasLineIfEmpty): ditto.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox): Added code to check hasLineIfEmpty to give flex boxes line height.
(WebCore::RenderFlexibleBox::layoutVerticalBox): ditto.
* css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Moved the appearance adjustment code into adjust style.
* rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Lets the theme paint "decorations", like the arrow control and gradients
immediately after painting the background.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle): This now checks whether the control is styled, and adjusts the appearance property appropriately.
For styled selects, instead of setting the appearance to none, which is what we do for other styled controls, we set the appearance
to MenulistButtonAppearance, which indicates that we will draw the arrow controls and button appearance in the engine.
(WebCore::RenderTheme::paintDecorations): Added. Paints MenulistButtonAppearance in a different function,
so the arrow control will draw at the right time (after the background).
(WebCore::RenderTheme::paint): Added case for MenulistButtonAppearance.
(WebCore::RenderTheme::paintBorderOnly): ditto.
(WebCore::RenderTheme::isControlContainer): Removed cases for MenuListAppearance and MenulistButtonAppearance since the baseline is no longer provided by the theme.
(WebCore::RenderTheme::adjustMenuListButtonStyle): Added.
* rendering/RenderTheme.h: (WebCore::RenderTheme::paintMenuListButton): Added.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::isControlStyled): Removed code that made selects unstyle-able.
(WebCore::RenderThemeMac::baselinePosition): Removed cases for MenuListAppearance and MenulistButtonAppearance.
(WebCore::RenderThemeMac::popupButtonPadding): Added top and bottom padding so empty popups have the right baseline.
(WebCore::TopGradientInterpolate): Added.
(WebCore::BottomGradientInterpolate): Added.
(WebCore::MainGradientInterpolate): Added.
(WebCore::RenderThemeMac::paintMenuListButtonGradients): Added. Draws gradients for styled popup menu button appearance.
(WebCore::RenderThemeMac::paintMenuListButton): Calls paintMenuListButtonGradients, and draws arrow control.
(WebCore::RenderThemeMac::adjustMenuListButtonStyle): Added to set padding and border radius to account for the arrow control size and font size.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 25 Aug 2006 22:57:07 +0000 (22:57 +0000)]
Reviewed by Adam
Changed some time()-related code to be more platform independent
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::isIconExpiredForIconURL):
(WebCore::IconDatabase::getOrCreateIconDataCache):
(WebCore::IconDatabase::setIconDataForIconURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Fri, 25 Aug 2006 22:25:54 +0000 (22:25 +0000)]
Reviewed by Geoff.
<rdar://problem/
4416432> Radio buttons and Checkboxes in AXWebAreas don't fill in their AXTitle attribute
* bridge/mac/WebCoreAXObject.mm:
(labelForElement):
New. Returns the HTMLLabelElement, if any, for the specified Element.
(-[WebCoreAXObject title]):
For input elements, return the innerHTML() of the labelForElement().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Fri, 25 Aug 2006 21:28:33 +0000 (21:28 +0000)]
Reviewed by Tim Hatcher
Changed some debugging-only code to be more platform independent
* WebCore.xcodeproj/project.pbxproj:
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::pruneUnretainedIconsOnStartup):
(WebCore::IconDatabase::syncDatabase):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 25 Aug 2006 18:23:47 +0000 (18:23 +0000)]
Reviewed/landed by Adam.
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10561
Qt platform build fixes.
* platform/qt/FrameQt.h:
* platform/qt/ScreenQt.cpp:
(WebCore::qwidgetForPage):
(WebCore::screenRect):
(WebCore::screenDepth):
(WebCore::usableScreenRect):
* platform/qt/TemporaryLinkStubs.cpp:
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
* platform/qt/WidgetQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 25 Aug 2006 16:51:15 +0000 (16:51 +0000)]
Reviewed/landed by Adam.
Finally fix font caching. WebKit+Qt now works
out of the box without any further patches :-)
* platform/qt/FontDataQt.cpp:
(WebCore::FontData::platformDestroy):
* platform/qt/FontPlatformData.h:
* platform/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::isFixedPitch):
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::fontPtr):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 25 Aug 2006 16:46:35 +0000 (16:46 +0000)]
Reviewed/landed by Adam.
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10559
Confirm to WebKit style guide - last fixes :-)
* platform/ResourceLoaderClient.h:
* platform/qt/ComboBoxQt.cpp:
* platform/qt/FrameQt.cpp:
(WebCore::doScroll):
(WebCore::FrameQt::FrameQt):
(WebCore::FrameQt::openURL):
(WebCore::FrameQt::submitForm):
(WebCore::FrameQt::setTitle):
(WebCore::FrameQt::passSubframeEventToSubframe):
(WebCore::FrameQt::registerCommandForUndo):
(WebCore::FrameQt::registerCommandForRedo):
(WebCore::FrameQt::keyEvent):
(WebCore::FrameQt::setFrameGeometry):
* platform/qt/GlyphMapQt.cpp:
(WebCore::GlyphMap::fillPage):
* platform/qt/GraphicsContextQt.cpp:
(WebCore::toQtCompositionMode):
(WebCore::toQtLineCap):
(WebCore::toQtLineJoin):
(WebCore::TextShadow::TextShadow):
(WebCore::GraphicsContextPlatformPrivate::p):
* platform/qt/ImageQt.cpp:
(WebCore::FrameData::clear):
(WebCore::Image::supportsType):
* platform/qt/IntSizeQt.cpp:
* platform/qt/LineEditQt.cpp:
* platform/qt/ListBoxQt.cpp:
* platform/qt/PageQt.cpp:
(WebCore::Page::windowRect):
* platform/qt/PathQt.cpp:
(WebCore::Path::~Path):
* platform/qt/ResourceLoaderCurl.cpp:
(WebCore::ResourceLoader::assembleResponseHeaders):
(WebCore::ResourceLoader::retrieveCharset):
(WebCore::ResourceLoader::receivedResponse):
* platform/qt/ResourceLoaderManager.cpp:
(WebCore::headerCallback):
(WebCore::ResourceLoaderManager::downloadTimerCallback):
(WebCore::ResourceLoaderManager::add):
* platform/qt/ScreenQt.cpp:
(WebCore::screenRect):
(WebCore::usableScreenRect):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::~ScrollView):
(WebCore::ScrollView::setParentWidget):
(WebCore::ScrollView::addChild):
* platform/qt/SharedTimerQt.cpp:
(WebCore::setSharedTimerFiredFunction):
* platform/qt/SharedTimerQt.h:
(WebCore::SharedTimerQt::SharedTimerQt):
(WebCore::SharedTimerQt::fire):
* platform/qt/SystemTimeQt.cpp:
(WebCore::currentTime):
* platform/qt/TextEditQt.cpp:
(WebCore::PlatformTextEdit::setParentWidget):
(WebCore::PlatformTextEdit::text):
(WebCore::PlatformTextEdit::sizeWithColumnsAndRows):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 25 Aug 2006 04:04:37 +0000 (04:04 +0000)]
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10444
Navigation links overlap the Spam Karma 2 footer
* blog/wp-content/themes/webkit/style.css: Hide the footer altogether.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 25 Aug 2006 00:41:15 +0000 (00:41 +0000)]
Reviewed by Darin.
* WebView/WebFrame.m:
(-[WebFrame _updateBackground]): reworded the comment about scroll view and setDrawsBackground:YES
* WebView/WebView.m:
(-[WebViewPrivate dealloc]): release the background color
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Fri, 25 Aug 2006 00:32:30 +0000 (00:32 +0000)]
Reviewed by Justin.
Follow up for...
<rdar://problem/
4471481> Represent misspellings in AXAttributedStringForTextMarkerRange
Fix bug I introduced in r15959.
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityAttributeValue:]):
Use topDocument in case we are in a subframe (we want the start/end of the overall page).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Thu, 24 Aug 2006 23:50:43 +0000 (23:50 +0000)]
Reviewed by Alice
Fixed my previous checkin, which was pruning the users entire icon db on startup everytime
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::retainIconForPageURL): Bind the PageURL to argument 1, as SQL bindings
are indexed to 1, not 0
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log