commit-queue@webkit.org [Fri, 11 Aug 2017 03:06:56 +0000 (03:06 +0000)]
Web Inspector: Add three.js in preparation for layer visualization.
https://bugs.webkit.org/show_bug.cgi?id=174798
Patch by Ross Kirsling <ross.kirsling@sony.com> on 2017-08-10
Reviewed by Brian Burg.
* UserInterface/External/three.js/LICENSE: Added.
* UserInterface/External/three.js/OrbitControls.js: Added.
* UserInterface/External/three.js/three.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 11 Aug 2017 02:59:06 +0000 (02:59 +0000)]
Rename the source files for the WTF persistent coders.
https://bugs.webkit.org/show_bug.cgi?id=175441
Reviewed by Tim Horton.
Source/WebCore:
* platform/network/NetworkLoadMetrics.h:
Source/WebKit:
* NetworkProcess/cache/NetworkCacheCoders.h:
* NetworkProcess/cache/NetworkCacheKey.cpp:
* NetworkProcess/cache/NetworkCacheKey.h:
* UIProcess/API/APIContentRuleListStore.cpp:
Source/WTF:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/persistence/PersistentCoder.h: Renamed from Source/WTF/wtf/persistence/Coder.h.
* wtf/persistence/PersistentCoders.cpp: Renamed from Source/WTF/wtf/persistence/Coders.cpp.
* wtf/persistence/PersistentCoders.h: Renamed from Source/WTF/wtf/persistence/Coders.h.
* wtf/persistence/PersistentDecoder.cpp: Renamed from Source/WTF/wtf/persistence/Decoder.cpp.
* wtf/persistence/PersistentDecoder.h: Renamed from Source/WTF/wtf/persistence/Decoder.h.
* wtf/persistence/PersistentEncoder.cpp: Renamed from Source/WTF/wtf/persistence/Encoder.cpp.
* wtf/persistence/PersistentEncoder.h: Renamed from Source/WTF/wtf/persistence/Encoder.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
don.olmstead@sony.com [Fri, 11 Aug 2017 02:17:10 +0000 (02:17 +0000)]
Unreviewed, adding Ross Kirsling to contributors.json\n\n* Scripts/webkitpy/common/config/contributors.json:\n
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wilander@apple.com [Fri, 11 Aug 2017 01:47:03 +0000 (01:47 +0000)]
Resource Load Statistics: Increase grandfathering time to 7 days
https://bugs.webkit.org/show_bug.cgi?id=175414
<rdar://problem/
33818046>
Reviewed by Brent Fulgham.
* UIProcess/WebResourceLoadStatisticsStore.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
n_wang@apple.com [Fri, 11 Aug 2017 01:41:56 +0000 (01:41 +0000)]
Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=175272
<rdar://problem/
33756962>
Since accessibilityPress is async, we shouldn't rely on the timeout.
Reviewed by Chris Fleizach.
* accessibility/press-target-uses-text-descendant-node.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
utatane.tea@gmail.com [Fri, 11 Aug 2017 00:41:53 +0000 (00:41 +0000)]
Make ThreadGlobalData RefCounted for web thread
https://bugs.webkit.org/show_bug.cgi?id=175439
Reviewed by Mark Lam.
When the web thread is enabled, we share ThreadGlobalData between the web thread and the main thread.
The problem happens when the main thread is dying. It could start deallocating TLS and the web
thread may see the destructed ThreadGlobalData.
Even though, the current implementation is safe because the main thread do not perform TLS deallocation
in the Darwin environment. But this is not true in Windows. And we should not rely on this condition
that depends on the platforms.
In this patch, we make ThreadGlobalData ThreadSafeRefCounted. This type verbosely describes that
ThreadGlobalData could be shared between threads when the web thread enabled. And make the life time
management simple instead of relying on the platform dependent TLS implementation.
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):
* platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::cachedResourceRequestInitiators): Deleted.
(WebCore::ThreadGlobalData::eventNames): Deleted.
(WebCore::ThreadGlobalData::threadTimers): Deleted.
(WebCore::ThreadGlobalData::qualifiedNameCache): Deleted.
(WebCore::ThreadGlobalData::cachedConverterICU): Deleted.
(WebCore::ThreadGlobalData::cachedConverterTEC): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wilander@apple.com [Fri, 11 Aug 2017 00:41:09 +0000 (00:41 +0000)]
Resource Load Statistics: Add significant figures to telemetry calls
https://bugs.webkit.org/show_bug.cgi?id=175442
<rdar://problem/
33834834>
Reviewed by Brent Fulgham.
With this change, logged values are allowed to have 3 significant figures
as opposed to today's 0 which is wrong.
* UIProcess/WebResourceLoadStatisticsTelemetry.cpp:
(WebKit::submitTopList):
(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
utatane.tea@gmail.com [Fri, 11 Aug 2017 00:36:24 +0000 (00:36 +0000)]
Unreviewed, attempt to fix build failure with VC2017
Source/WTF:
* wtf/PriorityQueue.h:
Tools:
* TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
(TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
utatane.tea@gmail.com [Fri, 11 Aug 2017 00:36:23 +0000 (00:36 +0000)]
[JSC] Use @toNumber in builtins
https://bugs.webkit.org/show_bug.cgi?id=172692
Reviewed by Sam Weinig.
Use @toNumber bytecode intrinsic. It emits op_to_number, which efficiently converts
a given argument to a number.
* Modules/streams/ReadableByteStreamInternals.js:
(privateInitializeReadableByteStreamController):
(readableByteStreamControllerRespond):
* Modules/streams/StreamInternals.js:
(validateAndNormalizeQueuingStrategy):
(enqueueValueWithSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
utatane.tea@gmail.com [Fri, 11 Aug 2017 00:29:03 +0000 (00:29 +0000)]
Unreviewed, suppress warnings on GCC
* TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
(TestWebKitAPI::CheckedArithmeticTester::run):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 10 Aug 2017 23:57:47 +0000 (23:57 +0000)]
[Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
https://bugs.webkit.org/show_bug.cgi?id=173223
Reviewed by Tim Horton.
The rebuilds were happening due to a difference in the compiler options that the IDE and
xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
Advanced when a Custom Absolute path is selected.
* Scripts/webkitdirs.pm:
(determineBaseProductDir):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
utatane.tea@gmail.com [Thu, 10 Aug 2017 23:42:14 +0000 (23:42 +0000)]
Run more WTF tests
https://bugs.webkit.org/show_bug.cgi?id=174970
Reviewed by Michael Catanzaro.
Source/WTF:
CHAR_BIT is not defined.
* wtf/LEBDecoder.h:
Tools:
Some of WTF tests are not executed in non Apple ports while they are generic ones.
This patch adds these tests to non-Apple port TestWebKitAPI.
Currently, we do not add Signals.cpp since it depends on signal functionality.
* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
(isHigherPriority):
(TEST):
* TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
(TEST):
* TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
(TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mark.lam@apple.com [Thu, 10 Aug 2017 23:00:06 +0000 (23:00 +0000)]
Apply the UNLIKELY macro to some unlikely things.
https://bugs.webkit.org/show_bug.cgi?id=175440
<rdar://problem/
33834767>
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::jettison):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::disassemble):
* dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalizeCommon):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::compileOSRExit):
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
* ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeCommon):
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::compileWithoutLinking):
(JSC::JIT::link):
* runtime/ScriptExecutable.cpp:
(JSC::ScriptExecutable::installCode):
* runtime/VM.cpp:
(JSC::VM::VM):
Source/WebKit:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getBytecodeProfile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryanhaddad@apple.com [Thu, 10 Aug 2017 22:57:33 +0000 (22:57 +0000)]
Unreviewed test gardening for High Sierra.
* platform/mac-highsierra/css1/basic/inheritance-expected.txt: Added.
* platform/mac-highsierra/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Added.
* platform/mac-highsierra/css2.1/t0805-c5522-brdr-02-e-expected.txt: Added.
* platform/mac-highsierra/css3/selectors3/html/css3-modsel-18-expected.txt: Added.
* platform/mac-highsierra/css3/selectors3/xhtml/css3-modsel-18-expected.txt: Added.
* platform/mac-highsierra/css3/selectors3/xml/css3-modsel-18-expected.txt: Added.
* platform/mac-highsierra/fast/block/basic/001-expected.txt: Added.
* platform/mac-highsierra/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
* platform/mac-highsierra/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
* platform/mac-highsierra/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
* platform/mac-highsierra/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
* platform/mac-highsierra/fast/css/css3-nth-child-expected.txt: Added.
* platform/mac-highsierra/fast/css/text-overflow-input-expected.txt: Added.
* platform/mac-highsierra/fast/dom/34176-expected.txt: Added.
* platform/mac-highsierra/fast/dom/clone-node-dynamic-style-expected.txt: Added.
* platform/mac-highsierra/fast/forms/basic-inputs-expected.txt: Added.
* platform/mac-highsierra/fast/forms/input-value-expected.txt: Added.
* platform/mac-highsierra/fast/forms/plaintext-mode-2-expected.txt: Added.
* platform/mac-highsierra/fast/invalid/003-expected.txt: Added.
* platform/mac-highsierra/fast/invalid/004-expected.txt: Added.
* platform/mac-highsierra/fast/invalid/nestedh3s-expected.txt: Added.
* platform/mac-highsierra/fast/selectors/018-expected.txt: Added.
* platform/mac-highsierra/fast/table/frame-and-rules-expected.txt: Added.
* platform/mac-highsierra/fast/text/atsui-multiple-renderers-expected.txt: Added.
* platform/mac-highsierra/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.
* platform/mac-highsierra/fast/text/font-weights-expected.txt: Added.
* platform/mac-highsierra/fast/text/font-weights-zh-expected.txt: Added.
* platform/mac-highsierra/fast/text/indic-expected.txt: Added.
* platform/mac-highsierra/fast/text/international/complex-character-based-fallback-expected.txt:
* platform/mac-highsierra/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
* platform/mac-highsierra/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
* platform/mac-highsierra/svg/batik/text/textStyles-expected.txt: Added.
* platform/mac-highsierra/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
* platform/mac-highsierra/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Thu, 10 Aug 2017 22:42:29 +0000 (22:42 +0000)]
Turn on support for Beacon API by default in STP
https://bugs.webkit.org/show_bug.cgi?id=175445
<rdar://problem/
33836379>
Reviewed by Youenn Fablet.
* Shared/WebPreferencesDefinitions.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
n_wang@apple.com [Thu, 10 Aug 2017 22:15:49 +0000 (22:15 +0000)]
AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/
33782159>
Reviewed by Chris Fleizach.
Source/WebCore:
The issue here is that we manualy set the parent object of the AccessibilitySVGRoot object
and there are chances that the parent doesn't detach it properly during the parent's destroying
process. Accessing the stale parent object will lead to a crash.
Fixed this by making the parent object a weak pointer so we don't access an invalid memory.
Test: accessibility/add-children-pseudo-element.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
* accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::createWeakPtr):
* accessibility/AccessibilitySVGRoot.cpp:
(WebCore::AccessibilitySVGRoot::AccessibilitySVGRoot):
(WebCore::AccessibilitySVGRoot::setParent):
(WebCore::AccessibilitySVGRoot::parentObject const):
* accessibility/AccessibilitySVGRoot.h:
LayoutTests:
* accessibility/add-children-pseudo-element-expected.txt: Added.
* accessibility/add-children-pseudo-element.html: Added.
* accessibility/resources/svg-circle.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryanhaddad@apple.com [Thu, 10 Aug 2017 22:08:34 +0000 (22:08 +0000)]
Fix iOS simulator build after change "[WTF] Move TextStream into WTF"
https://bugs.webkit.org/show_bug.cgi?id=175211
Patch by Ross Kirsling <ross.kirsling@sony.com> on 2017-08-10
Reviewed by Myles C. Maxfield.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scrollByContentOffset:]):
(-[WKWebView _navigationGestureDidBegin]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Thu, 10 Aug 2017 21:51:15 +0000 (21:51 +0000)]
[Beacon] Do connect-src CSP check on redirects as well
https://bugs.webkit.org/show_bug.cgi?id=175410
<rdar://problem/
33815470>
Reviewed by Youenn Fablet.
Source/WebCore:
Pass ContentSecurityPolicy object to createPingHandle so that we can send
enough data to the NetworkProcess so do CSP checks for Ping loads such
as Beacon. For the IPC, we serialize the ContentSecurityPolicy's response
headers. Those headers are now cached in ContentSecurityPolicy for
performance reasons. CSP headers are rarely updated in practice but
sendBeacon() may get called repeatedly for a given document.
Tests: http/wpt/beacon/connect-src-beacon-redirect-allowed.sub.html
http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html
* loader/LoaderStrategy.h:
* loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):
* loader/PingLoader.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
* page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::responseHeaders const):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
* page/csp/ContentSecurityPolicy.h:
* page/csp/ContentSecurityPolicyResponseHeaders.h:
(WebCore::ContentSecurityPolicyResponseHeaders::encode const):
(WebCore::ContentSecurityPolicyResponseHeaders::decode):
Source/WebKit:
Pass CSP Response headers to the NetworkProcess via NetworkResourceLoadParameters
when doing a PingLoad. This allows PingLoad to do CSP checks (in particular
connect-src ones) in case the ping load gets redirected. Those checks need to be
done on the NetworkProcess side at this point because there is no guarantee the
WebContent process is still around.
To do the CSP checks, PingLoad lazily reconstructs a ContentSecurityPolicy object
from the CSP response headers.
* NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::contentSecurityPolicy):
* NetworkProcess/PingLoad.h:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::createPingHandle):
* WebProcess/Network/WebLoaderStrategy.h:
Source/WebKitLegacy:
Update createPingHandle() to take in ContentSecurityPolicy
object in but no behavior change for WK1.
* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::createPingHandle):
* WebCoreSupport/WebResourceLoadScheduler.h:
LayoutTests:
Add layout test coverage.
* http/wpt/beacon/connect-src-beacon-redirect-allowed.sub-expected.txt: Added.
* http/wpt/beacon/connect-src-beacon-redirect-allowed.sub.html: Added.
* http/wpt/beacon/connect-src-beacon-redirect-blocked.sub-expected.txt: Added.
* http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
utatane.tea@gmail.com [Thu, 10 Aug 2017 21:19:51 +0000 (21:19 +0000)]
[WTF] ThreadSpecific should not introduce additional indirection
https://bugs.webkit.org/show_bug.cgi?id=175187
Reviewed by Mark Lam.
Source/JavaScriptCore:
* runtime/Identifier.cpp:
Source/WebCore:
We drop ThreadSpecific::replace feature which is only used by
Web thread. Instead, we use ThreadSpecific<std::unique_ptr<T>> here.
While this std::unique_ptr<T> shares one instance between main thread
and web thread, this is the same to the current implementation. It is
safe because the web thread never finishes.
And for non-web thread implementation, we just use ThreadSpecific<T>,
since it is the most efficient.
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):
We also drop StringImpl::empty() call since it is not necessary now:
StringImpl::empty data is statically initialized by using constexpr.
* platform/ThreadGlobalData.h:
We make it FAST_ALLOCATED since it is previously allocated by fast malloc
in ThreadSpecific.
Source/WTF:
ThreadSpecific sets Data* to the TLS. And Data holds T*, which
is fast allocated actual data. But ideally, we should store T
instance directly in Data instead of introducing an additional
indirection.
This patch adds storage in Data in order to embed the instance of T. The constructor
for Data will invoke the constructor for T on the embedded storage. We also drop
ThreadSpecific::replace which is only used by the web thread to set its thread specific
ThreadGlobalData to the one shared from the main thread. The existing implementation
relies on the main thread and the web thread never exiting in order for the shared
ThreadGlobalData to stay alive. We can achieve the same semantics by using a
ThreadSpecific<std::unique_ptr<T>> to hold the ThreadGlobalData instance instead.
* wtf/ThreadSpecific.h:
(WTF::ThreadSpecific::Data::construct):
(WTF::ThreadSpecific::Data::Data):
We make it fast allocated since we previously allocated ThreadSpecific T data by fastMalloc.
(WTF::ThreadSpecific::Data::~Data):
(WTF::ThreadSpecific::Data::storagePointer const):
(WTF::canBeGCThread>::get):
We also drop RELEASE_ASSERT from ::get(). We already inserted this assert to setAndConstruct(),
so when creating the member to this TLS, we execute this release assert. So it is
not necessary to execute this assertion every time we get data from this TLS.
(WTF::canBeGCThread>::set):
(WTF::canBeGCThread>::destroy):
(WTF::canBeGCThread>::setAndConstruct):
(WTF::T):
(WTF::canBeGCThread>::replace): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 10 Aug 2017 20:49:01 +0000 (20:49 +0000)]
Remove obsolete link from webkit-queues status page
https://bugs.webkit.org/show_bug.cgi?id=175337
Patch by obinna obike <oobike@apple.com> on 2017-08-10
Reviewed by Aakash Jain.
* QueueStatusServer/templates/recentstatus.html:
Removed the link to the ews-watcher server.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jbedard@apple.com [Thu, 10 Aug 2017 20:47:16 +0000 (20:47 +0000)]
Mark webgl/webgl-box-shadow.html and webgl/webgl-border.html as failing for ios-device.
https://bugs.webkit.org/show_bug.cgi?id=175437
Unreviewed test gardening.
* platform/ios-device/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bburg@apple.com [Thu, 10 Aug 2017 20:34:40 +0000 (20:34 +0000)]
WKPreferences should conform to NSCopying
https://bugs.webkit.org/show_bug.cgi?id=175303
<rdar://problem/
33764939>
Reviewed by Dan Bernstein.
Source/WebKit:
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Add conformance in the private header, as there is not consensus that this
needs to be API.
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences copyWithZone:]):
Copy the wrapped WebPreferences instance and return its wrapper.
Tools:
Add unit test to make sure a WKPreference and its copy are
not aliased to each other or affect each other's properties.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
(TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Thu, 10 Aug 2017 19:39:28 +0000 (19:39 +0000)]
Fix a silly typo in Compiler.h
* wtf/Compiler.h:
Heature, indeed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mcatanzaro@igalia.com [Thu, 10 Aug 2017 19:31:53 +0000 (19:31 +0000)]
REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
https://bugs.webkit.org/show_bug.cgi?id=175426
Reviewed by Carlos Alberto Lopez Perez.
.:
* Source/cmake/FindGeoClue2.cmake:
Source/WebCore:
Also stop using GEOCLUE_LIBRARIES and GEOCLUE_INCLUDE_DIRS, since they are empty. Apparently
we have not actually been using the client library at all this whole time, only the D-Bus
interface.
* PlatformGTK.cmake:
Source/WebKit:
* PlatformGTK.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 10 Aug 2017 19:28:26 +0000 (19:28 +0000)]
Add ServiceWorkerJob.
https://bugs.webkit.org/show_bug.cgi?id=175241
Reviewed by Tim Horton.
Source/WebCore:
Test: http/tests/workers/service/basic-register.html
This patch does a few things:
- Adds the spec concept of a ServiceWorkerJob (in the WebProcess, at least)
- Adds a ServiceWorkerProvider interface for WebKit to implement
- Actually creates a job for service worker registration and "schedules" it,
though it always immediately errors out the promise.
Actually queuing jobs and executing asynchronously is coming up soon.
* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::sessionID const):
* dom/Document.h:
* workers/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::~ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::jobDidFinish):
* workers/ServiceWorkerContainer.h:
* workers/ServiceWorkerJob.cpp: Added.
(WebCore::ServiceWorkerJob::ServiceWorkerJob):
(WebCore::ServiceWorkerJob::~ServiceWorkerJob):
(WebCore::ServiceWorkerJob::failedWithException):
* workers/ServiceWorkerJob.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.
(WebCore::ServiceWorkerJob::createRegisterJob):
(WebCore::ServiceWorkerJob::identifier const):
* workers/ServiceWorkerJobClient.h: Added.
(WebCore::ServiceWorkerJobClient::~ServiceWorkerJobClient):
* workers/ServiceWorkerProvider.cpp: Added.
(WebCore::ServiceWorkerProvider::singleton):
(WebCore::ServiceWorkerProvider::setSharedProvider):
* workers/ServiceWorkerProvider.h: Added.
* workers/ServiceWorkerRegistrationOptions.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.
* workers/ServiceWorkerRegistrationParameters.cpp: Added.
* workers/ServiceWorkerRegistrationParameters.h: Added.
Source/WebKit:
* CMakeLists.txt:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Storage/WebServiceWorkerProvider.cpp: Added.
(WebKit::WebServiceWorkerProvider::singleton):
(WebKit::WebServiceWorkerProvider::WebServiceWorkerProvider):
(WebKit::WebServiceWorkerProvider::scheduleJob):
* WebProcess/Storage/WebServiceWorkerProvider.h: Added.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
LayoutTests:
Verifies that the "serviceWorker.register()" job we currently schedule fails as expected.
* http/tests/workers/service/basic-register-expected.txt: Added.
* http/tests/workers/service/basic-register.html: Added.
* http/tests/workers/service/resources/basic-register.js: Added.
* http/tests/workers/service/resources/empty-worker.js: Added.
* platform/mac-wk1/TestExpectations:
* platform/win/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Thu, 10 Aug 2017 19:05:51 +0000 (19:05 +0000)]
Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
https://bugs.webkit.org/show_bug.cgi?id=175436
<rdar://problem/
33667497>
Reviewed by Simon Fraser.
Source/JavaScriptCore:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter):
Source/WebCore:
* platform/audio/cocoa/MediaSessionManagerCocoa.cpp:
(PlatformMediaSessionManager::updateSessionState):
* platform/graphics/cocoa/WebCoreDecompressionSession.mm:
(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):
Source/WebKit:
* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData):
Tools:
* TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
(TestWebKitAPI::TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Thu, 10 Aug 2017 18:57:22 +0000 (18:57 +0000)]
Fix duplicated code from r220534.
Unreviewed cleanup.
* Scripts/bisect-builds:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jiewen_tan@apple.com [Thu, 10 Aug 2017 18:47:56 +0000 (18:47 +0000)]
[WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
https://bugs.webkit.org/show_bug.cgi?id=175344
<rdar://problem/
28507240>
Reviewed by Alexey Proskuryakov.
Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
Finally enable the existing tests for iOS.
* TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
* TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 10 Aug 2017 18:27:01 +0000 (18:27 +0000)]
Unreviewed, rolling out r220463.
https://bugs.webkit.org/show_bug.cgi?id=175435
unaccepted fix (Requested by n_wang on #webkit).
Reverted changeset:
"AX: crash at
WebCore::AccessibilityObject::supportsARIALiveRegion() const +
24"
https://bugs.webkit.org/show_bug.cgi?id=175340
http://trac.webkit.org/changeset/220463
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Thu, 10 Aug 2017 18:22:01 +0000 (18:22 +0000)]
Write a tool to bisect WebKit builds
https://bugs.webkit.org/show_bug.cgi?id=174596
Reviewed by Dean Johnson and Kocsen Chung.
* Scripts/bisect-builds: Added.
(bisect_builds): main bisection algorithm
(download_archive):download an archive from S3 using existing tools
(extract_archive):extract an archive using existing tools
(find_le):Find rightmost value less than or equal to x
(find_ge):Find leftmost item greater than or equal to x
(get_api_url):generate url for the rest api/database
(get_indices_from_revisions):convert revisions to list indexes for bisection
(get_sorted_revisions):retrieve sorted revision list
(get_s3_location_for_revision):calculate the S3 archive storage location
(parse_args):parse command line arguments
(pick_next_build):compute the next build to bisect
(prompt_did_reproduce):prompt user for direction for bisection
(set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
(test_archive):Platform specific logic to test downloaded archive
(minified_platforms):return a list of minified platforms in the database
(unminified_platforms):return a list of full platforms in the database
(is_supported_platform):check if platform is supported
(validate_options):validate command line options
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Thu, 10 Aug 2017 18:17:07 +0000 (18:17 +0000)]
Remove bisect-builds script.
https://bugs.webkit.org/show_bug.cgi?id=175433
Reviewed by Aakash Jain.
* Scripts/bisect-builds: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mcatanzaro@igalia.com [Thu, 10 Aug 2017 17:04:46 +0000 (17:04 +0000)]
Remove ENABLE_GAMEPAD_DEPRECATED
https://bugs.webkit.org/show_bug.cgi?id=175361
Reviewed by Carlos Garcia Campos.
.:
* Source/cmake/FindGUdev.cmake: Removed.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* PlatformGTK.cmake:
* PlatformWPE.cmake:
* platform/Linux.cmake: Removed.
* platform/gamepad/deprecated/Gamepads.h: Removed.
* platform/gamepad/glib/GamepadsGlib.cpp: Removed.
* platform/gamepad/linux/GamepadDeviceLinux.cpp: Removed.
* platform/gamepad/linux/GamepadDeviceLinux.h: Removed.
Source/WebCore/PAL:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit:
* Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WTF:
* wtf/FeatureDefines.h:
Tools:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mmaxfield@apple.com [Thu, 10 Aug 2017 16:59:28 +0000 (16:59 +0000)]
Addressing post-review comments after r219173.
https://bugs.webkit.org/show_bug.cgi?id=174149
Unreviewed.
* css/CSSFontStyleValue.h:
* editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryanhaddad@apple.com [Thu, 10 Aug 2017 16:53:08 +0000 (16:53 +0000)]
Update TestExpectations for imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors.html.
https://bugs.webkit.org/show_bug.cgi?id=170698
Unreviewed test gardening.
* TestExpectations: Skip test on debug because it times out on every run.
* platform/ios/TestExpectations: Mark as flaky on Release.
* platform/mac/TestExpectations: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
clopez@igalia.com [Thu, 10 Aug 2017 16:33:31 +0000 (16:33 +0000)]
REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
https://bugs.webkit.org/show_bug.cgi?id=175426
Reviewed by Carlos Garcia Campos.
.:
Fix the pkg-config file name.
We really require geoclue-2.0 and not libgeoclue-2.0.
* Source/cmake/FindGeoClue2.cmake:
Tools:
* gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 10 Aug 2017 15:44:39 +0000 (15:44 +0000)]
Try to fix windows build.
* style/StyleUpdate.h:
(WebCore::Style::TextUpdate::TextUpdate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Thu, 10 Aug 2017 12:25:07 +0000 (12:25 +0000)]
[GTK] Don't use --whole-archive linking flags for the WebKit2 target libraries
https://bugs.webkit.org/show_bug.cgi?id=175416
Reviewed by Carlos Garcia Campos.
* PlatformGTK.cmake: Drop the ADD_WHOLE_ARCHIVE_TO_LIBRARIES instruction
for the WebKit2 target. This unnecessarily bundles complete archive
files both into the main .so library as well as single executables that
are linked against the WebKit2 target.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 10 Aug 2017 12:01:56 +0000 (12:01 +0000)]
Add Ms2ger as contributor.
https://bugs.webkit.org/show_bug.cgi?id=175325
Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-10
Reviewed by Carlos Alberto Lopez Perez.
* Scripts/webkitpy/common/config/contributors.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 10 Aug 2017 11:02:33 +0000 (11:02 +0000)]
[GTK] Crashes in WebCore::PasteboardHelper::fillSelectionData when source file of drag is unavailable
https://bugs.webkit.org/show_bug.cgi?id=174161
Reviewed by Xabier Rodriguez-Calvar.
In r219385 we changed the early return in fillSelectionData() to check the selection data length instead of the
data pointer. However, the gtk_selection_data_get_length() can return -1, so we need to check also if the value
less than 0. The case of setting an empty string could be valid depending on the target type, so it's better to
return early only when data lenght is less than 0 and handle the 0 length case in each target.
* platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillSelectionData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
magomez@igalia.com [Thu, 10 Aug 2017 10:44:57 +0000 (10:44 +0000)]
Unreviewed GTK+ gardening. Update expectations of several tests failing at r220516.
* platform/gtk/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 10 Aug 2017 10:20:53 +0000 (10:20 +0000)]
Text renderer updates should be done by RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=175417
Reviewed by Andreas Kling.
All render tree mutations should be done by RenderTreeUpdater. Currently
Text::updateRendererAfterContentChange calls RenderText::setTextWithOffset directly.
* dom/Document.cpp:
(WebCore::Document::updateTextRenderer):
Add range argument.
* dom/Document.h:
* dom/Text.cpp:
(WebCore::Text::updateRendererAfterContentChange):
Remove call to setTextWithOffset and pass the range to updateTextRenderer
* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateTextRenderer):
Call setTextWithOffset here.
* style/RenderTreeUpdater.h:
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveComposedTree):
* style/StyleUpdate.cpp:
(WebCore::Style::Update::textUpdate const):
(WebCore::Style::Update::addText):
Add TextUpdate struct similar to ElementUpdate to pass the range to the RenderTreeUpdater.
* style/StyleUpdate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Thu, 10 Aug 2017 08:37:36 +0000 (08:37 +0000)]
Unreviewed GTK+ build fix for ENABLE_GLES2=ON.
* platform/graphics/texmap/TextureMapperGLHeaders.h:
Define various GL constants that are not provided in GLES2 headers
but are only leveraged in OpenGL calls if at runtime the underlying
OpenGL is GLES2-capable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Thu, 10 Aug 2017 07:39:39 +0000 (07:39 +0000)]
[TexMap] Remove GraphicsContext3D usage from BitmapTexturePool
https://bugs.webkit.org/show_bug.cgi?id=175319
Reviewed by Carlos Garcia Campos.
Drop the GraphicsContext3D reference in BitmapTexturePool now
that the BitmapTextureGL doesn't require it anymore.
No new tests -- no change in behavior.
* platform/graphics/texmap/BitmapTexturePool.cpp:
(WebCore::BitmapTexturePool::BitmapTexturePool):
* platform/graphics/texmap/BitmapTexturePool.h:
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::TextureMapperGL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Thu, 10 Aug 2017 07:20:16 +0000 (07:20 +0000)]
[TexMap] Drop GraphicsContext3D usage from BitmapTextureGL
https://bugs.webkit.org/show_bug.cgi?id=175317
Reviewed by Carlos Garcia Campos.
Have BitmapTextureGL use direct OpenGL API entrypoints and constants
instead of leveraging the GraphicsContext3D class. Any GraphicsContext3D
object passed to BitmapTextureGL would assume rendering to the GL context
that's current on that thread, translating method invocations to the
OpenGL API. We can do this by ourselves and benefit by avoiding allocating
GraphicsContext3D resources like the ANGLE compiler that are by most useful
for WebGL.
BitmapTextureGL::create() call sites are adjusted to stop passing a
GraphicsContext3D reference. BitmapTextureGL::bindAsSurface() doesn't need
a replacement for the passed-in GraphicsContext3D object since that object
originated from the TextureMapperGL instance, whose GraphicsContext3D is by
default of the render-to-current-context nature. Other changes are direct
translations of GraphicsContext3D methods to OpenGL API calls, or of
GraphicsContext3D values to OpenGL API constants.
No new tests -- no change in behavior.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
* platform/graphics/texmap/BitmapTextureGL.cpp:
Also remove an unnecessary GraphicsContext.h header inclusion.
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bindAsSurface):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::copyFromExternalTexture):
* platform/graphics/texmap/BitmapTextureGL.h:
(WebCore::BitmapTextureGL::create):
(WebCore::BitmapTextureGL::textureTarget const):
(WebCore::BitmapTextureGL::internalFormat const):
* platform/graphics/texmap/BitmapTexturePool.cpp:
(WebCore::BitmapTexturePool::createTexture):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::createTexture):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dewei_zhu@apple.com [Thu, 10 Aug 2017 06:01:56 +0000 (06:01 +0000)]
Fix run-benchmark after r220483.
https://bugs.webkit.org/show_bug.cgi?id=175415
<rdar://problem/
33803003>
Reviewed by Ryosuke Niwa.
Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
* Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
(WebServerBenchmarkRunner._run_one_test):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mcatanzaro@igalia.com [Thu, 10 Aug 2017 05:58:26 +0000 (05:58 +0000)]
[GTK] Remove support for geoclue1
https://bugs.webkit.org/show_bug.cgi?id=164205
Reviewed by Carlos Garcia Campos.
.:
* Source/cmake/FindGeoClue.cmake: Removed.
* Source/cmake/OptionsGTK.cmake:
Source/WebCore:
* PlatformGTK.cmake:
* platform/geoclue/GeolocationProviderGeoclue.h:
* platform/geoclue/GeolocationProviderGeoclue1.cpp: Removed.
* platform/geoclue/GeolocationProviderGeoclue2.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Thu, 10 Aug 2017 04:19:34 +0000 (04:19 +0000)]
Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
https://bugs.webkit.org/show_bug.cgi?id=175401
Reviewed by Brady Eidson.
Source/WebKit:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetBeaconAPIEnabled):
(WKPreferencesGetBeaconAPIEnabled):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* config.h:
Source/WebKitLegacy/mac:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences beaconAPIEnabled]): Deleted.
(-[WebPreferences setBeaconAPIEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Tools:
* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
LayoutTests:
* platform/mac-elcapitan-wk2/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt.
* platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.
* platform/mac-wk1/TestExpectations:
* platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/mac-wk1/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
* platform/win/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt.
* platform/win/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 10 Aug 2017 04:13:08 +0000 (04:13 +0000)]
[PAL] Move spi/cocoa and spi/cg directories into PAL
https://bugs.webkit.org/show_bug.cgi?id=175175
Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-08-09
Reviewed by Myles C. Maxfield.
Source/WebCore:
* Modules/applepay/cocoa/PaymentCocoa.mm:
* Modules/applepay/cocoa/PaymentContactCocoa.mm:
* Modules/applepay/cocoa/PaymentMerchantSessionCocoa.mm:
* Modules/applepay/cocoa/PaymentMethodCocoa.mm:
* PlatformAppleWin.cmake:
* WebCore.xcodeproj/project.pbxproj:
* editing/cocoa/EditorCocoa.mm:
* editing/cocoa/HTMLConverter.mm:
* editing/ios/EditorIOS.mm:
* page/cocoa/ResourceUsageThreadCocoa.mm:
* page/mac/TextIndicatorWindow.mm:
* platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:
* platform/cocoa/DataDetectorsCoreSoftLink.h:
* platform/cocoa/MIMETypeRegistryCocoa.mm:
* platform/cocoa/NetworkExtensionContentFilter.mm:
* platform/cocoa/ParentalControlsContentFilter.mm:
* platform/cocoa/SleepDisablerCocoa.cpp:
* platform/graphics/Font.cpp:
* platform/graphics/Font.h:
* platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:
* platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
* platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:
* platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:
* platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
* platform/graphics/cg/ColorCG.cpp:
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/ImageBufferCG.cpp:
* platform/graphics/cg/ImageBufferDataCG.cpp:
* platform/graphics/cg/ImageDecoderCG.cpp:
* platform/graphics/cg/NativeImageCG.cpp:
* platform/graphics/cocoa/FontCacheCoreText.cpp:
* platform/graphics/cocoa/FontCascadeCocoa.mm:
* platform/graphics/cocoa/FontCocoa.mm:
* platform/graphics/cocoa/FontDescriptionCocoa.cpp:
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
* platform/graphics/cocoa/IOSurface.mm:
* platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
* platform/graphics/cocoa/WebActionDisablingCALayerDelegate.h:
* platform/graphics/ios/FontAntialiasingStateSaver.h:
* platform/graphics/ios/FontCacheIOS.mm:
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
* platform/graphics/mac/FontCacheMac.mm:
* platform/graphics/mac/GlyphPageMac.cpp:
* platform/graphics/win/FontCacheWin.cpp:
* platform/ios/LegacyTileCache.mm:
* platform/ios/LegacyTileGrid.mm:
* platform/ios/LegacyTileGridTile.mm:
* platform/ios/PlaybackSessionInterfaceAVKit.mm:
* platform/ios/QuickLook.mm:
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
* platform/ios/WebAVPlayerController.h:
* platform/ios/WebAVPlayerController.mm:
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
* platform/ios/wak/WKGraphics.mm:
* platform/mac/DragImageMac.mm:
* platform/mac/PlatformScreenMac.mm:
* platform/mac/PlaybackSessionInterfaceMac.mm:
* platform/mac/ThemeMac.mm:
* platform/mac/VideoFullscreenInterfaceMac.mm:
* platform/mac/WebPlaybackControlsManager.h:
* platform/mac/WebVideoFullscreenHUDWindowController.mm:
* platform/network/cocoa/CookieStorageObserver.mm:
* platform/network/cocoa/NetworkLoadMetrics.mm:
* platform/network/mac/AuthenticationMac.mm:
* platform/network/mac/ResourceHandleMac.mm:
* platform/spi/ios/DataDetectorsUISPI.h:
* platform/spi/mac/DataDetectorsSPI.h:
* platform/spi/mac/NSViewSPI.h:
* rendering/RenderThemeCocoa.mm:
* rendering/RenderThemeIOS.mm:
* rendering/RenderThemeMac.mm:
Source/WebCore/PAL:
* PAL.xcodeproj/project.pbxproj:
* pal/PlatformAppleWin.cmake:
* pal/spi/cg/CoreGraphicsSPI.h: Renamed from Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h.
(CGFloatMin):
* pal/spi/cg/ImageIOSPI.h: Renamed from Source/WebCore/platform/spi/cg/ImageIOSPI.h.
* pal/spi/cocoa/AVKitSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/AVKitSPI.h.
(-[AVTouchBarPlaybackControlsControlling NS_ENUM]):
* pal/spi/cocoa/CFNSURLConnectionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CFNSURLConnectionSPI.h.
* pal/spi/cocoa/CoreTextSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CoreTextSPI.h.
* pal/spi/cocoa/DataDetectorsCoreSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h.
* pal/spi/cocoa/IOPMLibSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOPMLibSPI.h.
* pal/spi/cocoa/IOPSLibSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOPSLibSPI.h.
* pal/spi/cocoa/IOReturnSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOReturnSPI.h.
* pal/spi/cocoa/IOSurfaceSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOSurfaceSPI.h.
* pal/spi/cocoa/IOTypesSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOTypesSPI.h.
* pal/spi/cocoa/LinkPresentationSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h.
* pal/spi/cocoa/MachVMSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/MachVMSPI.h.
* pal/spi/cocoa/NEFilterSourceSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h.
* pal/spi/cocoa/NSAttributedStringSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSAttributedStringSPI.h.
* pal/spi/cocoa/NSButtonCellSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSButtonCellSPI.h.
* pal/spi/cocoa/NSCalendarDateSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSCalendarDateSPI.h.
* pal/spi/cocoa/NSColorSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSColorSPI.h.
* pal/spi/cocoa/NSExtensionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSExtensionSPI.h.
* pal/spi/cocoa/NSFileManagerSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSFileManagerSPI.h.
* pal/spi/cocoa/NSStringSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSStringSPI.h.
* pal/spi/cocoa/NSTouchBarSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSTouchBarSPI.h.
* pal/spi/cocoa/NSURLConnectionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLConnectionSPI.h.
* pal/spi/cocoa/NSURLDownloadSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLDownloadSPI.h.
* pal/spi/cocoa/NSURLFileTypeMappingsSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLFileTypeMappingsSPI.h.
* pal/spi/cocoa/PassKitSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/PassKitSPI.h.
(NS_ERROR_ENUM):
* pal/spi/cocoa/QuartzCoreSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h.
* pal/spi/cocoa/ServersSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/ServersSPI.h.
* pal/spi/cocoa/WebFilterEvaluatorSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/WebFilterEvaluatorSPI.h.
* pal/spi/cocoa/pthreadSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/pthreadSPI.h.
Source/WebKit:
* NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm:
* NetworkProcess/Downloads/mac/DownloadMac.mm:
* Platform/cocoa/SharedMemoryCocoa.cpp:
* Platform/mac/LayerHostingContext.mm:
* Shared/Cocoa/DataDetectionResult.mm:
* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
* Shared/cf/CookieStorageUtilsCF.mm:
* Shared/ios/InteractionInformationAtPosition.mm:
* Shared/mac/HangDetectionDisablerMac.mm:
* Shared/mac/RemoteLayerBackingStore.mm:
* Shared/mac/RemoteLayerTreePropertyApplier.mm:
* UIProcess/API/Cocoa/WKWebView.mm:
* UIProcess/API/mac/WKView.mm:
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
* UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
* UIProcess/ios/ViewGestureControllerIOS.mm:
* UIProcess/ios/WKContentView.mm:
* UIProcess/ios/WKContentViewInteraction.mm:
* UIProcess/ios/WKPDFPageNumberIndicator.mm:
* UIProcess/ios/WKScrollView.mm:
* UIProcess/mac/RemoteLayerTreeHost.mm:
* UIProcess/mac/ServicesController.mm:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
* UIProcess/mac/ViewGestureControllerMac.mm:
* UIProcess/mac/ViewSnapshotStore.mm:
* UIProcess/mac/WKViewLayoutStrategy.mm:
* WebProcess/Plugins/PDF/PDFPlugin.mm:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
* WebProcess/cocoa/WebProcessCocoa.mm:
Source/WebKitLegacy/ios:
* Misc/WebNSStringExtrasIOS.m:
* WebCoreSupport/WebFixedPositionContent.mm:
Source/WebKitLegacy/mac:
* History/WebHistory.mm:
* Misc/WebDownload.mm:
* Misc/WebKitNSStringExtras.mm:
* Plugins/Hosted/NetscapePluginHostManager.mm:
* Plugins/WebPluginDatabase.mm:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebInspector/WebNodeHighlight.mm:
* WebView/WebHTMLView.mm:
* WebView/WebIndicateLayer.mm:
* WebView/WebView.mm:
* WebView/WebViewData.h:
Tools:
* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
* DumpRenderTree/mac/DumpRenderTree.mm:
* TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_path_rules_specifier):
Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
* Scripts/webkitpy/style/checkers/cpp.py:
(check_braces):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_braces.CF_OPTIONS):
(WebKitStyleTest.test_braces):
Prevent CF_OPTIONS() from being handled as funtion definition.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wilander@apple.com [Thu, 10 Aug 2017 03:21:04 +0000 (03:21 +0000)]
Resource Load Statistics: Increase grandfathering time to 3 days
https://bugs.webkit.org/show_bug.cgi?id=175414
<rdar://problem/
33818046>
Reviewed by Brent Fulgham.
* UIProcess/WebResourceLoadStatisticsStore.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 10 Aug 2017 02:11:47 +0000 (02:11 +0000)]
Invalidate PlaybackSessionManager in same fashion as VideoFullscreenManager.
https://bugs.webkit.org/show_bug.cgi?id=175399
rdar://problem/
33663344
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-09
Reviewed by Eric Carlson.
Invalidate PlaybackSessionManager when WebPage is destructed.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::~WebPage):
* WebProcess/cocoa/PlaybackSessionManager.h:
* WebProcess/cocoa/PlaybackSessionManager.mm:
(WebKit::PlaybackSessionManager::~PlaybackSessionManager):
(WebKit::PlaybackSessionManager::invalidate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
don.olmstead@sony.com [Thu, 10 Aug 2017 01:15:14 +0000 (01:15 +0000)]
[WTF] Move TextStream into WTF
https://bugs.webkit.org/show_bug.cgi?id=175211
Reviewed by Myles C. Maxfield.
Source/WebCore:
No new tests. No change in behavior.
* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/ComposedTreeIterator.cpp:
* dom/Position.cpp:
* dom/Position.h:
* dom/Range.cpp:
(WebCore::operator<<):
* dom/Range.h:
* dom/ViewportArguments.cpp:
* dom/ViewportArguments.h:
* editing/VisiblePosition.cpp:
* editing/VisiblePosition.h:
* editing/VisibleSelection.cpp:
* editing/VisibleSelection.h:
* html/HTMLVideoElement.cpp:
* html/canvas/CanvasRenderingContext2D.cpp:
* page/FrameView.cpp:
* page/ViewportConfiguration.cpp:
* page/ViewportConfiguration.h:
* page/WheelEventDeltaFilter.cpp:
* page/animation/CSSPropertyAnimation.cpp:
* page/scrolling/AsyncScrollingCoordinator.cpp:
* page/scrolling/ScrollingConstraints.cpp:
* page/scrolling/ScrollingConstraints.h:
* page/scrolling/ScrollingCoordinator.cpp:
* page/scrolling/ScrollingCoordinator.h:
* page/scrolling/ScrollingStateFixedNode.cpp:
* page/scrolling/ScrollingStateFixedNode.h:
* page/scrolling/ScrollingStateFrameScrollingNode.cpp:
* page/scrolling/ScrollingStateFrameScrollingNode.h:
* page/scrolling/ScrollingStateNode.cpp:
* page/scrolling/ScrollingStateNode.h:
* page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
* page/scrolling/ScrollingStateOverflowScrollingNode.h:
* page/scrolling/ScrollingStateScrollingNode.cpp:
* page/scrolling/ScrollingStateScrollingNode.h:
* page/scrolling/ScrollingStateStickyNode.cpp:
* page/scrolling/ScrollingStateStickyNode.h:
* page/scrolling/ScrollingTree.cpp:
* page/scrolling/ScrollingTreeFrameScrollingNode.cpp:
* page/scrolling/ScrollingTreeFrameScrollingNode.h:
* page/scrolling/ScrollingTreeNode.cpp:
* page/scrolling/ScrollingTreeNode.h:
* page/scrolling/ScrollingTreeScrollingNode.cpp:
* page/scrolling/ScrollingTreeScrollingNode.h:
* page/scrolling/mac/ScrollingTreeFixedNode.h:
* page/scrolling/mac/ScrollingTreeFixedNode.mm:
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
* page/scrolling/mac/ScrollingTreeStickyNode.h:
* page/scrolling/mac/ScrollingTreeStickyNode.mm:
* platform/CalculationValue.cpp:
* platform/CalculationValue.h:
* platform/LayoutUnit.cpp:
* platform/LayoutUnit.h:
* platform/Length.cpp:
* platform/Length.h:
* platform/LengthBox.cpp:
* platform/LengthBox.h:
* platform/LengthPoint.cpp:
* platform/LengthPoint.h:
* platform/LengthSize.cpp:
* platform/LengthSize.h:
* platform/LogMacros.h:
* platform/ScrollView.cpp:
* platform/ScrollableArea.cpp:
* platform/animation/TimingFunction.cpp:
* platform/animation/TimingFunction.h:
* platform/graphics/BitmapImage.cpp:
* platform/graphics/BitmapImage.h:
* platform/graphics/Color.cpp:
* platform/graphics/Color.h:
* platform/graphics/CrossfadeGeneratedImage.cpp:
* platform/graphics/CrossfadeGeneratedImage.h:
* platform/graphics/FloatPoint.cpp:
* platform/graphics/FloatPoint.h:
* platform/graphics/FloatPoint3D.cpp:
* platform/graphics/FloatPoint3D.h:
* platform/graphics/FloatRect.cpp:
* platform/graphics/FloatRect.h:
* platform/graphics/FloatRoundedRect.cpp:
* platform/graphics/FloatRoundedRect.h:
* platform/graphics/FloatSize.cpp:
* platform/graphics/FloatSize.h:
* platform/graphics/FontTaggedSettings.cpp:
* platform/graphics/FontTaggedSettings.h:
* platform/graphics/GradientImage.cpp:
(WebCore::GradientImage::dump const):
* platform/graphics/GradientImage.h:
* platform/graphics/GraphicsContext.cpp:
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsLayer.cpp:
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::dumpAdditionalProperties const):
* platform/graphics/GraphicsTypes.cpp:
* platform/graphics/GraphicsTypes.h:
* platform/graphics/Image.cpp:
* platform/graphics/Image.h:
* platform/graphics/ImageSource.h:
* platform/graphics/IntPoint.cpp:
* platform/graphics/IntPoint.h:
* platform/graphics/IntRect.cpp:
* platform/graphics/IntRect.h:
* platform/graphics/IntSize.cpp:
* platform/graphics/IntSize.h:
* platform/graphics/LayoutPoint.cpp:
* platform/graphics/LayoutPoint.h:
* platform/graphics/LayoutRect.cpp:
* platform/graphics/LayoutRect.h:
* platform/graphics/LayoutSize.cpp:
* platform/graphics/LayoutSize.h:
* platform/graphics/NamedImageGeneratedImage.cpp:
* platform/graphics/NamedImageGeneratedImage.h:
* platform/graphics/Path.cpp:
* platform/graphics/Path.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCAAnimation.cpp:
* platform/graphics/ca/PlatformCAAnimation.h:
* platform/graphics/ca/PlatformCALayer.cpp:
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/TileController.cpp:
* platform/graphics/ca/TileGrid.cpp:
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/PDFDocumentImage.cpp:
* platform/graphics/cg/PDFDocumentImage.h:
* platform/graphics/cocoa/IOSurface.h:
* platform/graphics/cocoa/IOSurface.mm:
* platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::description const):
* platform/graphics/displaylists/DisplayList.h:
* platform/graphics/displaylists/DisplayListItems.cpp:
* platform/graphics/displaylists/DisplayListItems.h:
* platform/graphics/displaylists/DisplayListRecorder.cpp:
* platform/graphics/displaylists/DisplayListReplayer.cpp:
* platform/graphics/filters/DistantLightSource.cpp:
* platform/graphics/filters/DistantLightSource.h:
* platform/graphics/filters/FEBlend.cpp:
* platform/graphics/filters/FEBlend.h:
* platform/graphics/filters/FEColorMatrix.cpp:
* platform/graphics/filters/FEColorMatrix.h:
* platform/graphics/filters/FEComponentTransfer.cpp:
* platform/graphics/filters/FEComponentTransfer.h:
* platform/graphics/filters/FEComposite.cpp:
* platform/graphics/filters/FEComposite.h:
* platform/graphics/filters/FEConvolveMatrix.cpp:
* platform/graphics/filters/FEConvolveMatrix.h:
* platform/graphics/filters/FEDiffuseLighting.cpp:
* platform/graphics/filters/FEDiffuseLighting.h:
* platform/graphics/filters/FEDisplacementMap.cpp:
* platform/graphics/filters/FEDisplacementMap.h:
* platform/graphics/filters/FEDropShadow.cpp:
* platform/graphics/filters/FEDropShadow.h:
* platform/graphics/filters/FEFlood.cpp:
* platform/graphics/filters/FEFlood.h:
* platform/graphics/filters/FEGaussianBlur.cpp:
* platform/graphics/filters/FEGaussianBlur.h:
* platform/graphics/filters/FEMerge.cpp:
* platform/graphics/filters/FEMerge.h:
* platform/graphics/filters/FEMorphology.cpp:
* platform/graphics/filters/FEMorphology.h:
* platform/graphics/filters/FEOffset.cpp:
* platform/graphics/filters/FEOffset.h:
* platform/graphics/filters/FESpecularLighting.cpp:
* platform/graphics/filters/FESpecularLighting.h:
* platform/graphics/filters/FETile.cpp:
* platform/graphics/filters/FETile.h:
* platform/graphics/filters/FETurbulence.cpp:
* platform/graphics/filters/FETurbulence.h:
* platform/graphics/filters/FilterEffect.cpp:
* platform/graphics/filters/FilterEffect.h:
* platform/graphics/filters/FilterOperation.cpp:
* platform/graphics/filters/FilterOperation.h:
* platform/graphics/filters/FilterOperations.cpp:
* platform/graphics/filters/FilterOperations.h:
* platform/graphics/filters/LightSource.h:
* platform/graphics/filters/PointLightSource.cpp:
* platform/graphics/filters/PointLightSource.h:
* platform/graphics/filters/SourceAlpha.cpp:
* platform/graphics/filters/SourceAlpha.h:
* platform/graphics/filters/SourceGraphic.cpp:
* platform/graphics/filters/SourceGraphic.h:
* platform/graphics/filters/SpotLightSource.cpp:
* platform/graphics/filters/SpotLightSource.h:
* platform/graphics/transforms/AffineTransform.cpp:
* platform/graphics/transforms/AffineTransform.h:
* platform/graphics/transforms/IdentityTransformOperation.h:
* platform/graphics/transforms/Matrix3DTransformOperation.cpp:
* platform/graphics/transforms/Matrix3DTransformOperation.h:
* platform/graphics/transforms/MatrixTransformOperation.cpp:
* platform/graphics/transforms/MatrixTransformOperation.h:
* platform/graphics/transforms/PerspectiveTransformOperation.cpp:
* platform/graphics/transforms/PerspectiveTransformOperation.h:
* platform/graphics/transforms/RotateTransformOperation.cpp:
* platform/graphics/transforms/RotateTransformOperation.h:
* platform/graphics/transforms/ScaleTransformOperation.cpp:
* platform/graphics/transforms/ScaleTransformOperation.h:
* platform/graphics/transforms/SkewTransformOperation.cpp:
* platform/graphics/transforms/SkewTransformOperation.h:
* platform/graphics/transforms/TransformOperation.cpp:
* platform/graphics/transforms/TransformOperation.h:
* platform/graphics/transforms/TransformOperations.cpp:
* platform/graphics/transforms/TransformOperations.h:
* platform/graphics/transforms/TransformationMatrix.cpp:
* platform/graphics/transforms/TransformationMatrix.h:
* platform/graphics/transforms/TranslateTransformOperation.cpp:
* platform/graphics/transforms/TranslateTransformOperation.h:
* platform/ios/SelectionRect.cpp:
(WebCore::operator<<):
* platform/ios/SelectionRect.h:
* platform/mac/ScrollAnimatorMac.mm:
* platform/text/TextAllInOne.cpp:
* rendering/InlineBox.cpp:
* rendering/InlineBox.h:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::outputLineTreeAndMark const):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
* rendering/InlineTextBox.h:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::outputLineTreeAndMark const):
* rendering/RenderBlockFlow.h:
* rendering/RenderLayer.cpp:
* rendering/RenderLayerCompositor.cpp:
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
* rendering/RenderTreeAsText.cpp:
* rendering/RenderTreeAsText.h:
* rendering/ScrollAlignment.cpp:
* rendering/ScrollAlignment.h:
* rendering/SimpleLineLayoutCoverage.cpp:
* rendering/SimpleLineLayoutFunctions.cpp:
* rendering/SimpleLineLayoutFunctions.h:
* rendering/style/FillLayer.cpp:
* rendering/style/FillLayer.h:
* rendering/style/NinePieceImage.cpp:
* rendering/style/NinePieceImage.h:
* rendering/style/RenderStyleConstants.cpp:
* rendering/style/RenderStyleConstants.h:
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
* rendering/svg/SVGRenderTreeAsText.h:
(WebCore::operator<<):
* svg/SVGLengthValue.cpp:
* svg/SVGLengthValue.h:
* svg/graphics/SVGImage.cpp:
* svg/graphics/SVGImage.h:
* svg/graphics/filters/SVGFEImage.cpp:
* svg/graphics/filters/SVGFEImage.h:
Source/WebKit:
* Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
* Shared/VisibleContentRectUpdateInfo.cpp:
* Shared/VisibleContentRectUpdateInfo.h:
* Shared/mac/RemoteLayerTreeTransaction.mm:
* UIProcess/API/Cocoa/WKWebView.mm:
* UIProcess/ios/WKContentView.mm:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(WebKit::operator<<):
* UIProcess/ios/WebPageProxyIOS.mm:
* WebProcess/WebPage/ios/WebPageIOS.mm:
* WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
* WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
Source/WTF:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/text/TextStream.cpp: Renamed from Source/WebCore/platform/text/TextStream.cpp.
(WTF::TextStream::writeIndent):
* wtf/text/TextStream.h: Renamed from Source/WebCore/platform/text/TextStream.h.
(WTF::TextStream::FormatNumberRespectingIntegers::FormatNumberRespectingIntegers):
Tools:
* TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mmaxfield@apple.com [Thu, 10 Aug 2017 01:12:07 +0000 (01:12 +0000)]
font-fallback-font-family.html is failing on perf bots
https://bugs.webkit.org/show_bug.cgi?id=174989
Unreviewed.
* Layout/resources/font-fallback-font-family.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 10 Aug 2017 01:07:09 +0000 (01:07 +0000)]
Part 3 of: Rename DatabaseProcess to StorageProcess
https://bugs.webkit.org/show_bug.cgi?id=175034
Reviewed by Brady Eidson.
Source/WebKit:
We tried renaming com.apple.WebKit.Databases to com.apple.WebKit.Storage in r219986, but
this prevented trunk WebKit from running on iOS 11 devices. This is because launchd keeps a
codesigned cache of XPC services, and refuses to launch services that aren't in the cache.
It's not possibe for us to rebuild the cache with the new service name (only Apple's
production build system can do this), and disabling the cache or opting WebKit's XPC
services out of the cache might have a negative impact on our performance testing.
For now we'll retain the name "com.apple.WebKit.Databases" on iOS 11 devices to work around
this issue. If we find a way to allow the new service to run without impacting performance,
we can revert this change.
We will rename the service to "com.apple.WebKit.Storage" on macOS and iOS Simulator, and in
a follow-up patch we'll use the new service name on post-iOS 11 device builds.
* Configurations/BaseTarget.xcconfig: Defined WK_STORAGE_SERVICE_PRODUCT_NAME to be
com.apple.WebKit.Databases by default, and overrode it to com.apple.WebKit.Storage on macOS
and iOS Simulator.
* Configurations/StorageService.xcconfig: Changed PRODUCT_NAME to $(WK_STORAGE_SERVICE_PRODUCT_NAME).
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName): Changed to return "com.apple.WebKit.Storage" on macOS and
iOS Simulator platforms.
* WebKit.xcodeproj/project.pbxproj: Updated the "Copy XPC services for engineering builds"
build phase to use WK_STORAGE_SERVICE_PRODUCT_NAME.
Tools:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::databaseProcessName): Updated to return
"com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ticaiolima@gmail.com [Thu, 10 Aug 2017 00:42:24 +0000 (00:42 +0000)]
[JSC] Create JSSet constructor that accepts it's size as parameter
https://bugs.webkit.org/show_bug.cgi?id=173297
Reviewed by Saam Barati.
This patch is adding a new constructor to JSSet that gives its
expected initial size. It is important to avoid re-hashing and mutiple
allocations when we know the final size of JSSet, such as in
CodeBlock::setConstantIdentifierSetRegisters.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setConstantIdentifierSetRegisters):
* runtime/HashMapImpl.h:
(JSC::HashMapImpl::HashMapImpl):
* runtime/JSSet.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryanhaddad@apple.com [Thu, 10 Aug 2017 00:35:58 +0000 (00:35 +0000)]
Unreviewed, rolling out r220466, r220477, and r220487.
https://bugs.webkit.org/show_bug.cgi?id=175411
This change broke existing API tests and follow up fixes did
not resolve all the issues. (Requested by ryanhaddad on
#webkit).
Reverted changesets:
https://bugs.webkit.org/show_bug.cgi?id=175244
http://trac.webkit.org/changeset/220466
"WTF::Function does not allow for reference / non-default
constructible return types"
https://bugs.webkit.org/show_bug.cgi?id=175244
http://trac.webkit.org/changeset/220477
https://bugs.webkit.org/show_bug.cgi?id=175244
http://trac.webkit.org/changeset/220487
Patch by Commit Queue <commit-queue@webkit.org> on 2017-08-09
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mcatanzaro@igalia.com [Wed, 9 Aug 2017 23:32:14 +0000 (23:32 +0000)]
[CMake] Remove unused find modules
https://bugs.webkit.org/show_bug.cgi?id=175363
Reviewed by Carlos Alberto Lopez Perez.
* Source/cmake/FindCFLite.cmake: Removed.
* Source/cmake/FindClang.cmake: Removed.
* Source/cmake/FindDBus.cmake: Removed.
* Source/cmake/FindDirectX.cmake: Removed.
* Source/cmake/FindEspeak.cmake: Removed.
* Source/cmake/FindQuickTimeSDK.cmake: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Wed, 9 Aug 2017 23:23:58 +0000 (23:23 +0000)]
[Beacon][NetworkSession] Support CORS-preflighting on redirects
https://bugs.webkit.org/show_bug.cgi?id=175386
<rdar://problem/
33801370>
Reviewed by Youenn Fablet.
Source/WebCore:
Export a couple of WebCore symbols so I can use them in WebKit2.
Tests: http/wpt/beacon/cors/cors-preflight-redirect-failure.html
http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin.html
http/wpt/beacon/cors/cors-preflight-redirect-success.html
* loader/CrossOriginAccessControl.h:
* page/SecurityOrigin.h:
Source/WebKit:
Add support to Beacon for doing CORS-preflighting upon redirect to a different
domain.
* NetworkProcess/NetworkCORSPreflightChecker.h:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::loadRequest):
(WebKit::PingLoad::securityOrigin const):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::needsCORSPreflight const):
(WebKit::PingLoad::doCORSPreflight):
* NetworkProcess/PingLoad.h:
LayoutTests:
Add layout test coverage.
* http/wpt/beacon/cors/cors-preflight-redirect-failure-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-failure.html: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin.html: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-success-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-success.html: Added.
* http/wpt/beacon/resources/beacon-preflight.py:
(main):
* http/wpt/beacon/resources/redirect.py: Added.
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 9 Aug 2017 23:18:13 +0000 (23:18 +0000)]
Use MPAVRoutingController instead of deprecated versions.
https://bugs.webkit.org/show_bug.cgi?id=175063
Source/WebCore:
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-09
Reviewed by Tim Horton.
No new tests because no behavior change. This uses a different platform class to present
an interface.
Remove deprecated MPAudioVideoRoutingPopoverController and MPAVRoutingSheet
Add MPMediaControlsViewController.
* platform/spi/ios/MediaPlayerSPI.h:
Source/WebKit:
rdar://problem/
33301230
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-09
Reviewed by Tim Horton.
Remove dependence on deprecated classes MPAVRoutingSheet and MPAudioVideoRoutingPopoverController.
* UIProcess/ios/forms/WKAirPlayRoutePicker.h:
* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(-[WKAirPlayRoutePicker dealloc]):
(-[WKAirPlayRoutePicker show:fromRect:]):
(-[WKAirPlayRoutePicker popoverControllerDidDismissPopover:]): Deleted.
(-[WKAirPlayRoutePicker _presentAirPlayPopoverAnimated:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker _windowWillRotate:]): Deleted.
(-[WKAirPlayRoutePicker _windowDidRotate:]): Deleted.
(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Wed, 9 Aug 2017 23:03:10 +0000 (23:03 +0000)]
Unreviewed, deflake http/wpt/beacon/keepalive-after-navigation.html
Temporarily restore previous timeout on this test to address flakiness on the
bots until I can rewrite it.
* http/wpt/beacon/keepalive-after-navigation.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Wed, 9 Aug 2017 23:01:05 +0000 (23:01 +0000)]
Import beacon/headers/header-content-type.html from upstream WPT
https://bugs.webkit.org/show_bug.cgi?id=175395
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
* web-platform-tests/beacon/headers/header-content-type-expected.txt:
* web-platform-tests/beacon/headers/header-content-type.html:
LayoutTests:
Drop local test that has been upstreamed to WPT.
* http/wpt/beacon/headers/header-content-type-same-origin-expected.txt: Removed.
* http/wpt/beacon/headers/header-content-type-same-origin.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Wed, 9 Aug 2017 22:59:32 +0000 (22:59 +0000)]
Unreviewed build fix.
Added missing files.
* RexBench/Octane2/benchmark.js: Added.
(Octane2RegExpBenchmark):
(Octane2RegExpBenchmark.prototype.setup.):
(Octane2RegExpBenchmark.prototype.setup.Math.random):
(Octane2RegExpBenchmark.prototype.setup):
(Octane2RegExpBenchmark.prototype.runOnce):
(Octane2RegExpBenchmark.prototype.tearDown):
* RexBench/SunSpider/benchmark.js: Added.
(RegexDNABenchmark):
(RegexDNABenchmark.prototype.runOnce):
(RegexDNABenchmark.prototype.validate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mmaxfield@apple.com [Wed, 9 Aug 2017 22:42:59 +0000 (22:42 +0000)]
Mark font-display as in development
https://bugs.webkit.org/show_bug.cgi?id=175387
Unreviewed.
* features.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 9 Aug 2017 22:40:53 +0000 (22:40 +0000)]
Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
Remove one addition of null Function test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
n_wang@apple.com [Wed, 9 Aug 2017 22:36:04 +0000 (22:36 +0000)]
LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=175194
Reviewed by Chris Fleizach.
In the test we have no way to control which iframe will be loaded first.
Output the logs at the end of the test so that they are in order.
* accessibility/presentation-role-iframe.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Wed, 9 Aug 2017 22:33:27 +0000 (22:33 +0000)]
Rex Bench doesn't work from the command line
https://bugs.webkit.org/show_bug.cgi?id=175349
Reviewed by Saam Barati.
Fixed cli.js to have the same set of benchmarks and .js files as the web
page driver.
Refactored the way benchmarks are run using a new Benchmark base class. That
class will run the benchmark as well. Eliminated the various runBenchmark()
functions that were used for individual tests. This refactoring was threaded
into the web page driver as well. Changed the iteration counts on many of the
individual benchmarks. Also changed the inner loop count for the flight
planner test.
Eliminated Octane2/base.js as it isn't needed to run Octane2/RegExp with the
new test harness. Eliminated other dead code in Octane2/regexp.js.
* RexBench/Basic/benchmark.js:
(BasicBenchmark):
(BasicBenchmark.prototype.runIteration): Deleted.
(runBenchmark): Deleted.
* RexBench/FlightPlanner/benchmark.js:
(FlightPlannerBenchmark):
(FlightPlannerBenchmark.prototype.runOnce):
(this.performance.performance.now.currentTime): Deleted.
(else.this.preciseTime.currentTime): Deleted.
(else.currentTime): Deleted.
(FlightPlannerBenchmark.prototype.runIteration): Deleted.
(FlightPlannerBenchmark.prototype.checkResults): Deleted.
(runBenchmark): Deleted.
* RexBench/Octane2/base.js: Removed.
* RexBench/Octane2/regexp.js:
* RexBench/basic_benchmark.js:
* RexBench/benchmark.js: Added.
(this.performance.performance.now.currentTime):
(else.this.preciseTime.currentTime):
(else.currentTime):
(Benchmark):
(Benchmark.prototype.runIterations):
(Benchmark.prototype.setup):
(Benchmark.prototype.runOnce):
(Benchmark.prototype.validate):
(Benchmark.prototype.tearDown):
* RexBench/cli.js:
* RexBench/flightplan_benchmark.js:
* RexBench/flightplan_unicode_benchmark.js:
* RexBench/octane2_benchmark.js:
* RexBench/stats.js:
(Stats.prototype.toString.return.span.0.span.span):
* RexBench/sunspider_benchmark.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 9 Aug 2017 22:08:35 +0000 (22:08 +0000)]
Unreviewed, rolling out r219334.
https://bugs.webkit.org/show_bug.cgi?id=175398
Caused bug 175023 (Requested by ap on #webkit).
Reverted changeset:
"[SVG] Leak in SVGAnimatedListPropertyTearOff"
https://bugs.webkit.org/show_bug.cgi?id=172545
http://trac.webkit.org/changeset/219334
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jbedard@apple.com [Wed, 9 Aug 2017 21:58:18 +0000 (21:58 +0000)]
Allow nested timeouts in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=175390
<rdar://problem/
33803003>
Reviewed by David Kilzer.
We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
the executive to detect and recover from any issues connecting with devices.
* Scripts/webkitpy/benchmark_runner/utils.py:
(TimeoutError): Deleted.
(timeout): Deleted.
* Scripts/webkitpy/common/timeout_context.py: Added.
(Timeout): A timeout context designed to be nested.
(Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
(Timeout.TimeoutData.__init__):
(Timeout.default_handler): Timeout handler used if none is specified.
(Timeout.current): Access data about the most urgent timeout.
(Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
(Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
(Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
urgent timeout data.
(Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
most urgent timeout data, if such data exists.
* Scripts/webkitpy/common/timeout_context_unittest.py: Added.
(TimeoutContextTests):
(TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
(TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
(TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
(TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
over a less urgent outer timeout.
(TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
over a less urgent inner timeout.
(TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
(TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
(TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
(TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
(TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
* Scripts/webkitpy/port/simulator_process.py:
(SimulatorProcess._start): Use Timeout class.
* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
(SimulatedDevice.launch_app): Ditto.
(SimulatedDevice.launch_app._install_timeout): Deleted.
* Scripts/webkitpy/xcode/simulator.py:
(Simulator.wait_until_device_is_booted):Use Timeout class.
(Simulator.wait_until_device_is_in_state): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caitp@igalia.com [Wed, 9 Aug 2017 21:34:20 +0000 (21:34 +0000)]
Early error on ANY operator before new.target
https://bugs.webkit.org/show_bug.cgi?id=157970
Reviewed by Saam Barati.
Instead of throwing if any unary operator precedes new.target, only
throw if the unary operator updates the reference.
The following become legal in JSC:
```
!new.target
~new.target
typeof new.target
delete new.target
void new.target
```
All of which are legal in v8 and SpiderMonkey in strict and sloppy mode
JSTests:
* stress/new-target-syntax-errors.js:
* stress/new-target.js:
Source/JavaScriptCore:
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseUnaryExpression):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 9 Aug 2017 21:03:03 +0000 (21:03 +0000)]
[Repaint from Layout Removal] Move layer repaint rects into a map
https://bugs.webkit.org/show_bug.cgi?id=175393
Reviewed by Zalan Bujtas.
Move the two repaint rects held by RenderLayer into a RenderLayerModelObject -> RepaintLayoutRects hash map.
RepaintLayoutRects is a new struct that holds both rects.
Eventually more objects than just self painting layers will be caching repaint rects, so this takes a first
step towards having a common cache for these repaint rects. In addition this change saves memory, since
layers that aren't self-painting no longer have empty repaint rects taking up space in RenderLayer.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::repaintRectIncludingNonCompositingDescendants):
(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::clearRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::scrollTo):
* rendering/RenderLayer.h:
* rendering/RenderLayerModelObject.cpp:
(WebCore::RepaintLayoutRects::RepaintLayoutRects):
(WebCore::RenderLayerModelObject::willBeDestroyed):
(WebCore::RenderLayerModelObject::destroyLayer):
(WebCore::RenderLayerModelObject::styleDidChange):
(WebCore::RenderLayerModelObject::hasRepaintLayoutRects):
(WebCore::RenderLayerModelObject::setRepaintLayoutRects):
(WebCore::RenderLayerModelObject::clearRepaintLayoutRects):
(WebCore::RenderLayerModelObject::repaintLayoutRects):
(WebCore::RenderLayerModelObject::computeRepaintLayoutRects):
* rendering/RenderLayerModelObject.h:
(WebCore::RepaintLayoutRects::RepaintLayoutRects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 9 Aug 2017 21:02:23 +0000 (21:02 +0000)]
Update reviewer
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 9 Aug 2017 20:57:51 +0000 (20:57 +0000)]
WTF::Function does not allow for reference / non-default constructible return types
https://bugs.webkit.org/show_bug.cgi?id=175244
Patch by Sam Weinig <sam@webkit.org> on 2017-08-09
Reviewed by Sam Weinig.
Source/JavaScriptCore:
* runtime/ArrayBuffer.cpp:
(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.
Source/WebCore:
* bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.
Source/WebKit:
* UIProcess/WebResourceLoadStatisticsStore.h:
Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.
Source/WTF:
When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.
This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.
* wtf/Function.h:
(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Wed, 9 Aug 2017 20:28:01 +0000 (20:28 +0000)]
Import CSS-UI-3 Web Platform Tests
https://bugs.webkit.org/show_bug.cgi?id=175294
Reviewed by Zalan Bujtas.
LayoutTests/imported/w3c:
* resources/import-expectations.json:
* resources/resource-files.json:
* web-platform-tests/css/css-ui-3/OWNERS: Added.
* web-platform-tests/css/css-ui-3/box-sizing-001-expected.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-001.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-003-expected.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-003.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-005-expected.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-005.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-007-expected.html: Added.
* web-platform-tests/css/css-ui-3/box-sizing-007.html: Added.
[truncated]
LayoutTests:
Mark tests that we currently failure.
* TestExpectations:
* platform/ios/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 9 Aug 2017 20:25:57 +0000 (20:25 +0000)]
Teach ScriptExecutionContexts about their SessionID.
https://bugs.webkit.org/show_bug.cgi?id=175391
Reviewed by Andy Estes.
No new tests (No current change in behavior).
Turns out that Workers need to know their SessionID for future feature development.
So let's teach it to them.
* dom/ScriptExecutionContext.h: Expose a pure virtual SessionID accessor.
* dom/Document.cpp:
(WebCore::Document::sessionID const):
* dom/Document.h:
* page/SessionID.cpp:
(WebCore::SessionID::isolatedCopy const):
* page/SessionID.h:
* workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):
* workers/DedicatedWorkerGlobalScope.h:
* workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):
* workers/DedicatedWorkerThread.h:
* workers/Worker.cpp:
(WebCore::Worker::notifyFinished):
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
* workers/WorkerGlobalScope.h:
* workers/WorkerGlobalScopeProxy.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
* workers/WorkerMessagingProxy.h:
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):
* workers/WorkerThread.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jlewis3@apple.com [Wed, 9 Aug 2017 20:08:01 +0000 (20:08 +0000)]
Marked http/tests/media/video-buffered-range-contains-currentTime.html as flaky on High Sierra
<rdar://problem/
33555759>
Unreviewed test gardening.
* platform/mac-highsierra-wk2/TestExpectations:
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wenson_hsieh@apple.com [Wed, 9 Aug 2017 19:15:37 +0000 (19:15 +0000)]
[iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
https://bugs.webkit.org/show_bug.cgi?id=175392
<rdar://problem/
33783207>
Reviewed by Tim Horton and Megan Gardner.
Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No change in behavior.
* Configurations/FeatureDefines.xcconfig:
Source/WebCore/PAL:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit:
* Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
* Configurations/FeatureDefines.xcconfig:
Tools:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 9 Aug 2017 19:13:51 +0000 (19:13 +0000)]
Old subtitle track is not deleted on 'src' attribute change event
https://bugs.webkit.org/show_bug.cgi?id=175031
Patch by Kirill Ovchinnikov <kirill.ovchinnikov@lge.com> on 2017-08-09
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/text-track-src-change.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackReadyStateChanged):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::loadTimerFired):
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::clearTextDisplayContainer):
* html/shadow/MediaControls.h:
LayoutTests:
* media/track/text-track-src-change-expected.txt: Added.
* media/track/text-track-src-change.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 9 Aug 2017 18:31:24 +0000 (18:31 +0000)]
Make JSC_validateExceptionChecks=1 succeed on JSTests/stress/v8-deltablue-strict.js.
https://bugs.webkit.org/show_bug.cgi?id=175358
Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-09
Reviewed by Mark Lam.
* jit/JITOperations.cpp:
* runtime/JSObjectInlines.h:
(JSC::JSObject::putInlineForJSObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 9 Aug 2017 18:05:24 +0000 (18:05 +0000)]
ServiceWorker experimental feature should not be on by default (definitely not ready).
https://bugs.webkit.org/show_bug.cgi?id=175389
Rubberstamped by Andy Estes.
* Shared/WebPreferencesDefinitions.h: false, not DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 9 Aug 2017 18:03:11 +0000 (18:03 +0000)]
Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
* TestWebKitAPI/Tests/WTF/Function.cpp:
Remove tests of null Functions, as they are no longer supported.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryanhaddad@apple.com [Wed, 9 Aug 2017 17:58:12 +0000 (17:58 +0000)]
Unreviewed, rolling out r220457.
This change introduced API test failures.
Reverted changeset:
"WTF::Function does not allow for reference / non-default
constructible return types"
https://bugs.webkit.org/show_bug.cgi?id=175244
http://trac.webkit.org/changeset/220457
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
don.olmstead@sony.com [Wed, 9 Aug 2017 17:53:09 +0000 (17:53 +0000)]
[WinCairo] Fix build after rev 220399
https://bugs.webkit.org/show_bug.cgi?id=175360
Reviewed by Žan Doberšek.
No new tests. No change in behavior.
* platform/graphics/texmap/TextureMapperGLHeaders.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
n_wang@apple.com [Wed, 9 Aug 2017 17:52:36 +0000 (17:52 +0000)]
AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/
33782159>
Reviewed by Chris Fleizach.
Source/WebCore:
When adding a psuedo element child to a RenderBlockFlow element, there might be a chance where
the element has already been layed out but we are still holding onto its stale children. Fixed it
by notifying AX correctly when inserting/removing children during layout.
Test: accessibility/add-children-pseudo-element.html
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObject):
LayoutTests:
* accessibility/add-children-pseudo-element-expected.txt: Added.
* accessibility/add-children-pseudo-element.html: Added.
* accessibility/resources/svg-circle.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
nvasilyev@apple.com [Wed, 9 Aug 2017 17:46:27 +0000 (17:46 +0000)]
Web Inspector: Styles: Add pre-populated data to spreadsheet-style view
https://bugs.webkit.org/show_bug.cgi?id=174838
<rdar://problem/
33523220>
Reviewed by Matt Baker.
This patch adds static content to the experimental RulesStyleSpreadsheetDetailsPanel.
The static content will be replaced with actual data in the follow up patches.
* UserInterface/Main.html:
* UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.css: Added.
(.style-spreadsheet .style-rule):
(.style-spreadsheet .selector-line):
(.style-spreadsheet .selector):
(.style-spreadsheet :matches(.selector .matched, .selector:focus)):
(.style-spreadsheet .name):
(.style-spreadsheet .value):
(.style-spreadsheet :matches(.selector, .name, .value)):
(.style-spreadsheet :matches(.selector, .name, .value):focus):
(.style-spreadsheet .selector-inline):
(.style-spreadsheet .property):
(.style-spreadsheet .property-disabled,):
(.style-spreadsheet .property-disabled :matches(.name, .value)):
(.style-spreadsheet .styles-source):
(.style-spreadsheet :matches(a, .node-link)):
(.style-spreadsheet :matches(a, .node-link):hover):
(.style-spreadsheet .inherited):
(.style-spreadsheet .declarations):
(.style-spreadsheet input[type="checkbox"]):
(.style-spreadsheet input[type="checkbox"]:not(:checked)):
(.style-spreadsheet .declarations:hover input[type="checkbox"]):
* UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 9 Aug 2017 17:23:16 +0000 (17:23 +0000)]
[GStreamer][MSE] Add missing lock around getStreamByTrackId
https://bugs.webkit.org/show_bug.cgi?id=175323
Patch by Charlie Turner <cturner@igalia.com> on 2017-08-09
Reviewed by Xabier Rodriguez-Calvar.
Covered by existing tests.
* platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
(WebCore::PlaybackPipeline::enqueueSample): Ensure the media source
lock is taken before modifiying the track queues indirectly via the
iterator use in getTrackId.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 9 Aug 2017 16:41:56 +0000 (16:41 +0000)]
WPE-focused test gardening.
https://bugs.webkit.org/show_bug.cgi?id=175385
Unreviewed test gardening.
Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-09
* platform/wpe/TestExpectations: Marked failing tests.
* platform/wpe/fast/events/touch/basic-single-touch-events-expected.txt: Added platform-specific expectation.
* platform/wpe/js/date-timeClip-large-values-expected.txt: Removed (the platform-neutral expectation is fine).
* platform/wpe/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Updated for Cache enabling.
* transitions/clip-path-path-transitions-expected.txt: Updated for test change in r219243.
* transitions/resources/transition-test-helpers.js:
(parseClipPath): Updated to support the quotes in clip-path-path-transitions.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Wed, 9 Aug 2017 16:30:41 +0000 (16:30 +0000)]
REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
https://bugs.webkit.org/show_bug.cgi?id=175247
<rdar://problem/
33679804>
Reviewed by Brady Eidson.
Source/WebCore:
Add SPI so that Safari can differentiate between a form submission and a redirected form submission
and have PolicyCheck notify the frame loader client if the navigation was in response to receiving a
redirect response. This is the WebKit portion to fix an issue when a native app makes use of an OAuth
OAuth flow that bounces to Safari for user login and then bounce back to the app. Microsoft Graph's
OAuth flow is one example.
Safari was differentiating between a form submission and a redirected form submission based on the
nullity of WKNavigationAction.sourceFrame because in both cases the navigation type was WKNavigationTypeFormSubmitted.
The navigation type is the same for both navigations because WebKit always used the navigation
action from the original request for the redirect request when the original request redirected.
Prior to r219013, WKNavigationAction.sourceFrame would be nil for a form submission that redirects.
Following r219013, WKNavigationAction.sourceFrame is non-nil unless the navigation was initiated by
API. In particular, WKNavigationAction.sourceFrame is non-nil for the redirect navigation corresponding
to a form submission that redirects.
* loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* loader/FrameLoaderClient.h:
Have dispatchDecidePolicyForNavigationAction() take a boolean as to whether the navigation was in
response to receiving a redirect response.
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy): Notify the frame loader client whether the navigation
is in response to receiving a redirect response.
Source/WebKit:
Add SPI WKNavigationAction._isRedirect to query whether the navigation was in response to receiving
a redirect response. The majority of the WebKit change is plumbing this knowledge through to connect
it with the SPI.
* Shared/NavigationActionData.cpp:
(WebKit::NavigationActionData::encode const):
(WebKit::NavigationActionData::decode):
Encode and decode the boolean NavigationActionData::isRedirect.
* Shared/NavigationActionData.h:
* UIProcess/API/APINavigationAction.h:
* UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction _isRedirect]): Added.
* UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Set NavigationActionData::isRedirect
depending on whether the navigation is in response to receiving a redirect response.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKitLegacy/mac:
Plumb knowledge of whether a navigation was in response to receiving a redirect response.
We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
clients that need to make use of this information at this time. If such a needs comes up
then we can expose API/SPI similar to what we do for WebKit.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
Source/WebKitLegacy/win:
Plumb knowledge of whether a navigation was in response to receiving a redirect response.
We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
clients that need to make use of this information at this time. If such a needs comes up
then we can expose API/SPI similar to what we do for WebKit.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
* WebCoreSupport/WebFrameLoaderClient.h:
Tools:
Add tests for redirects.
* TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
(TEST):
* TestWebKitAPI/cocoa/TestProtocol.mm:
(createRedirectURL):
(-[TestProtocol startLoading]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryanhaddad@apple.com [Wed, 9 Aug 2017 16:02:10 +0000 (16:02 +0000)]
Skip failing JSC tests stress/regress-169783.js and wasm.yaml/wasm/stress/oom.js.
https://bugs.webkit.org/show_bug.cgi?id=175255
Unreviewed test gardening.
* stress/regress-169783.js:
* wasm/stress/oom.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 9 Aug 2017 15:59:01 +0000 (15:59 +0000)]
WTF::Function does not allow for reference / non-default constructible return types
https://bugs.webkit.org/show_bug.cgi?id=175244
Patch by Sam Weinig <sam@webkit.org> on 2017-08-09
Reviewed by Chris Dumez.
Source/JavaScriptCore:
* runtime/ArrayBuffer.cpp:
(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.
Source/WebCore:
* bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.
Source/WebKit:
* UIProcess/WebResourceLoadStatisticsStore.h:
Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.
Source/WTF:
When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.
This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.
* wtf/Function.h:
(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 9 Aug 2017 15:52:19 +0000 (15:52 +0000)]
[QuickLook] Use case-insensitive comparison of preview MIME types
https://bugs.webkit.org/show_bug.cgi?id=175350
<rdar://problem/
33761159>
Reviewed by Brady Eidson.
Source/WebCore:
MIME types are case-insensitive, but PreviewLoader was using a case-sensitive comparison to
determine if a MIME type was supported by QLPreviewConverter. As a result we would fail to
preview Excel macro-enabled workbooks, since CFNetwork would sniff a MIME type of
"application/vnd.ms-excel.sheet.macroEnabled.12" but QuickLook contained
"application/vnd.ms-excel.sheet.macroenabled.12" in its set of supported MIME type strings.
Fix this by copying the QuickLook supported MIME type set into a HashSet using
ASCIICaseInsensitiveHash and using that HashSet for MIME type checks.
Test: quicklook/excel-macro-enabled.html
* loader/ios/PreviewLoader.mm:
(WebCore::PreviewLoader::shouldCreateForMIMEType):
LayoutTests:
* platform/ios-11/quicklook/excel-macro-enabled-expected.txt: Added.
* quicklook/excel-macro-enabled-expected.txt: Added.
* quicklook/excel-macro-enabled.html: Added.
* quicklook/resources/excel-macro-enabled.xlsm: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Wed, 9 Aug 2017 13:25:49 +0000 (13:25 +0000)]
Unreviewed WPE gardening.
* platform/wpe/TestExpectations: Stop skipping the whole fast/
directory and then unskipping specific subdirectories since
that overrides any expectations coming from the generic WK2
TestExpectations file. Specific subdirectories that we haven't
yet generated results for are now skipped instead.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 9 Aug 2017 13:06:11 +0000 (13:06 +0000)]
Remove unnecessary copies of PlatformMediaSessionManager::m_sessions
https://bugs.webkit.org/show_bug.cgi?id=175375
Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-09
Reviewed by Sam Weinig.
Remove unnecessary copies of PlatformMediaSessionManager::m_sessions.
These should have been removed in r207688.
No new tests: no behavior change.
* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive const):
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const):
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground const):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Wed, 9 Aug 2017 13:04:39 +0000 (13:04 +0000)]
Reinstate active flag for iterators
https://bugs.webkit.org/show_bug.cgi?id=175312
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Resync WPT tests from upstream to gain test coverage.
* web-platform-tests/dom/traversal/NodeIterator-expected.txt:
* web-platform-tests/dom/traversal/NodeIterator.html:
* web-platform-tests/dom/traversal/TreeWalker-expected.txt:
* web-platform-tests/dom/traversal/TreeWalker.html:
Source/WebCore:
NodeIterator / TreeWalker should no longer allow recursive filters
after the following change to the DOM specification:
- https://github.com/whatwg/dom/pull/359
This patch aligns our behavior with the latest specification.
No new tests, updated existing tests.
* dom/NodeIterator.cpp:
(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
Note that we now also call m_candidateNode.clear() before returning an
exception. This was a pre-existing bug that we failed to do so in the
exception case but it became more obvious after this change now that
we throw. This was causing traversal/moz-bug559526.html to fail
otherwise (the filter was called one too many times). The test case
is passing in Firefox (The filter is called 4 times and they throw
each time).
* dom/Traversal.cpp:
(WebCore::NodeIteratorBase::NodeIteratorBase):
(WebCore::NodeIteratorBase::acceptNode):
* dom/Traversal.h:
* dom/TreeWalker.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 9 Aug 2017 09:22:21 +0000 (09:22 +0000)]
[GTK] [WPE] Update expectations for global-constructors-attributes.html.
https://bugs.webkit.org/show_bug.cgi?id=175373
Unreviewed test gardening.
Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-09
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/wpe/js/dom/global-constructors-attributes-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gskachkov@gmail.com [Wed, 9 Aug 2017 09:17:44 +0000 (09:17 +0000)]
REGRESSION: 2 test262/test/language/statements/async-function failures
https://bugs.webkit.org/show_bug.cgi?id=175334
Reviewed by Yusuke Suzuki.
JSTests:
Add @skip parameters to tests, and remove test for async iterator from
async await syntax test because it is already covered by async-iterator-syntax.js
* stress/async-await-syntax.js:
* stress/async-iteration-syntax.js:
Source/JavaScriptCore:
Switch off useAsyncIterator by default
* runtime/Options.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 9 Aug 2017 07:36:45 +0000 (07:36 +0000)]
RenderQuote should not mutate render tree
https://bugs.webkit.org/show_bug.cgi?id=175328
Reviewed by Zalan Bujtas.
RenderQuote text renderers are currently created and deleted in a quirky fashion using a linked list.
This patch moves to a simpler model that guarantees the mutations are always done in controlled fashion
during render tree update.
* dom/Document.cpp:
(WebCore::Document::updateTextRenderer):
Move text renderer updating to Document so we can set the inRenderTreeUpdate bit for it too.
* dom/Document.h:
* dom/Text.cpp:
(WebCore::Text::updateRendererAfterContentChange):
* rendering/RenderDescendantIterator.h:
(WebCore::RenderDescendantIteratorAdapter<T>::at):
(WebCore::RenderDescendantConstIteratorAdapter<T>::at const):
Add at() function for starting iteration from a specified renderer.
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::insertedIntoTree):
(WebCore::RenderQuote::willBeRemovedFromTree):
Register and unregister quotes to RenderView.
Don't do any mutations.
(WebCore::RenderQuote::styleDidChange):
Invalidate the text renderer but don't mutate it.
(WebCore::RenderQuote::updateTextRenderer):
(WebCore::RenderQuote::computeText const):
(WebCore::RenderQuote::updateRenderers):
Compute depth of all render quotes and update the text renderer as needed.
(WebCore::RenderQuote::willBeDestroyed): Deleted.
(WebCore::RenderQuote::attachQuote): Deleted.
(WebCore::RenderQuote::detachQuote): Deleted.
(WebCore::RenderQuote::updateDepth): Deleted.
Get rid of the linked list.
* rendering/RenderQuote.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::registerQuote):
(WebCore::RenderView::unregisterQuote):
Maintain a render tree order ListHashSet of RenderQuotes.
(WebCore::RenderView::updateSpecialRenderers):
Add a function for making additional render tree mutations at the end of a render tree update.
Currently this just invokes RenderQuote::updateRenderers.
* rendering/RenderView.h:
* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::commit):
Call RenderView::updateSpecialRenderers after committing all other changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Wed, 9 Aug 2017 07:16:56 +0000 (07:16 +0000)]
[WPE] Enable SUBTLE_CRYPTO in release builds
https://bugs.webkit.org/show_bug.cgi?id=175371
Reviewed by Carlos Garcia Campos.
* Source/cmake/OptionsWPE.cmake:
Use ON as the default port value for ENABLE_SUBTLE_CRYPTO in WPE.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 9 Aug 2017 07:13:05 +0000 (07:13 +0000)]
[GTK] Enable SUBTLE_CRYPTO in GTK+ releases
https://bugs.webkit.org/show_bug.cgi?id=172758
Reviewed by Žan Doberšek.
Add ENABLE_WEB_CRYPTO public option and make ENABLE_SUBTLE_CRYPTO depend on it.
* Source/cmake/OptionsGTK.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Wed, 9 Aug 2017 07:00:34 +0000 (07:00 +0000)]
[Soup] Incorrect conversion in msToSoupDate()
https://bugs.webkit.org/show_bug.cgi?id=175320
Reviewed by Carlos Garcia Campos.
Original patch by VaL Doroshchuk.
* platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::msToSoupDate): monthFromDayInYear() returns a value in the [0,11] range,
while soup_date_new() expects a month value in the [1,12] range. The return value
must be thus incremented by one to match that expectation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wenson_hsieh@apple.com [Wed, 9 Aug 2017 05:36:57 +0000 (05:36 +0000)]
Unreviewed, rolling out r220393.
This patch regresses the performance of WebPage::editorState.
Reverted changeset:
"[iOS WK2] WKWebView schedules nonstop layout after pressing
cmb+b,i,u inside a contenteditable div"
https://bugs.webkit.org/show_bug.cgi?id=175116
http://trac.webkit.org/changeset/220393
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cdumez@apple.com [Wed, 9 Aug 2017 05:15:47 +0000 (05:15 +0000)]
[Beacon] Add support for CORS-preflighting for WK2 / NETWORK_SESSION
https://bugs.webkit.org/show_bug.cgi?id=175264
<rdar://problem/
33547793>
Reviewed by Youenn Fablet.
Source/WebCore:
Pass additional information when creating a PingHandle so that the PingLoad
can deal with CORS-preflighting on Network process side.
Tests: http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html
http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html
http/wpt/beacon/cors/cors-preflight-blob-failure.html
http/wpt/beacon/cors/cors-preflight-blob-success.html
http/wpt/beacon/cors/cors-preflight-cookie.html
* WebCore.xcodeproj/project.pbxproj:
* loader/CrossOriginAccessControl.cpp:
(WebCore::validatePreflightResponse):
* loader/CrossOriginAccessControl.h:
* loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):
* loader/CrossOriginPreflightResultCache.h:
* loader/LoaderStrategy.h:
* loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):
* loader/PingLoader.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
* page/SecurityOrigin.h:
Source/WebKit:
Implement CORS-preflighting for beacons with a payload that has a non
safelisted MIME type, as per:
- https://w3c.github.io/beacon/#privacy
- https://www.w3.org/TR/beacon/#sec-processing-model
CORS-preflighting is completely handled on Network Process side because
a beacon request can outlive its page and therefore its WebContent
process. This requires us to pass a little more information to the
Network process, in particular the source origin and the corsMode.
The current implementation does not currently deal with CORS preflights
needed upon a redirect. This will be added in a follow-up.
* CMakeLists.txt:
* NetworkProcess/NetworkCORSPreflightChecker.cpp: Added.
(WebKit::NetworkCORSPreflightChecker::NetworkCORSPreflightChecker):
(WebKit::NetworkCORSPreflightChecker::~NetworkCORSPreflightChecker):
(WebKit::NetworkCORSPreflightChecker::startPreflight):
(WebKit::NetworkCORSPreflightChecker::willPerformHTTPRedirection):
(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
(WebKit::NetworkCORSPreflightChecker::didReceiveResponseNetworkSession):
(WebKit::NetworkCORSPreflightChecker::didReceiveData):
(WebKit::NetworkCORSPreflightChecker::didCompleteWithError):
(WebKit::NetworkCORSPreflightChecker::didSendData):
(WebKit::NetworkCORSPreflightChecker::wasBlocked):
(WebKit::NetworkCORSPreflightChecker::cannotShowURL):
* NetworkProcess/NetworkCORSPreflightChecker.h: Added.
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadPing):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/PingLoad.cpp: Added.
(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::startNetworkLoad):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveChallenge):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::didReceiveData):
(WebKit::PingLoad::didCompleteWithError):
(WebKit::PingLoad::didSendData):
(WebKit::PingLoad::wasBlocked):
(WebKit::PingLoad::cannotShowURL):
(WebKit::PingLoad::timeoutTimerFired):
(WebKit::PingLoad::needsCORSPreflight const):
(WebKit::PingLoad::doCORSPreflight):
* NetworkProcess/PingLoad.h:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::createPingHandle):
* WebProcess/Network/WebLoaderStrategy.h:
Source/WebKitLegacy:
createPingHandle() now takes new parameters but there is currently no behavior
change on WebKit1.
* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::createPingHandle):
* WebCoreSupport/WebResourceLoadScheduler.h:
LayoutTests:
Add layout test coverage.
* http/wpt/beacon/cors/cors-preflight-arraybufferview-failure-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html: Added.
* http/wpt/beacon/cors/cors-preflight-arraybufferview-success-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html: Added.
* http/wpt/beacon/cors/cors-preflight-blob-failure-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-blob-failure.html: Added.
* http/wpt/beacon/cors/cors-preflight-blob-success-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-blob-success.html: Added.
* http/wpt/beacon/cors/cors-preflight-cookie-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-cookie.html: Added.
* http/wpt/beacon/resources/beacon-preflight.py: Added.
(respondToCORSPreflight):
(main):
* http/wpt/beacon/resources/set-cookie.py: Added.
(main):
* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log