WebKit-https.git
8 years agoVersioning.
lforschler@apple.com [Thu, 13 Jun 2013 07:15:34 +0000 (07:15 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[ARM] Unreviewed gardening, skip one more test to paint the bot green.
ossy@webkit.org [Thu, 13 Jun 2013 06:10:26 +0000 (06:10 +0000)]
[ARM] Unreviewed gardening, skip one more test to paint the bot green.

* platform/qt-arm/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Unreviewed build correction.
bfulgham@apple.com [Thu, 13 Jun 2013 05:58:53 +0000 (05:58 +0000)]
[WinCairo] Unreviewed build correction.

* win/tools32/vsprops/WinCairo.props: Switch from using the
  $WebKitLibraries environment variable to the newer
  $WebKit_Libraries.
* win/tools32/vsprops/debug_wincairo.props: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
roger_fong@apple.com [Thu, 13 Jun 2013 01:48:44 +0000 (01:48 +0000)]
Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.

* Scripts/webkitpy/common/config/ews.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate webkit.org build instructions for Apple Windows port.
roger_fong@apple.com [Thu, 13 Jun 2013 01:15:58 +0000 (01:15 +0000)]
Update webkit.org build instructions for Apple Windows port.
https://bugs.webkit.org/show_bug.cgi?id=117563.

Reviewed by Brent Fulgham.

* building/build.html:
* building/debug.html:
* building/launch-debugger-vs2005.png: Removed.
* building/launch-debugger-vs2010.png: Copied from webkit.org/building/launch-debugger-vs2005.png.
* building/set-as-startup-project-vs2005.png: Removed.
* building/set-as-startup-project-vs2010.png: Copied from webkit.org/building/set-as-startup-project-vs2005.png.
* building/set-debugging-properties-vs2005.png: Removed.
* building/set-debugging-properties-vs2010.png: Copied from webkit.org/building/set-debugging-properties-vs2005.png.
* building/tools.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. EFL Gardening. Needs to add new baseline for some tests, which are passin...
gyuyoung.kim@samsung.com [Thu, 13 Jun 2013 01:13:46 +0000 (01:13 +0000)]
Unreviewed. EFL Gardening. Needs to add new baseline for some tests, which are passing on EFL bots.

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/editing/selection/3690703-2-expected.png: Added.
* platform/efl/editing/selection/3690703-2-expected.txt: Added.
* platform/efl/editing/selection/3690703-expected.png: Added.
* platform/efl/editing/selection/3690703-expected.txt: Added.
* platform/efl/editing/selection/3690719-expected.png: Added.
* platform/efl/editing/selection/3690719-expected.txt: Added.
* platform/efl/editing/selection/4397952-expected.png: Added.
* platform/efl/editing/selection/4397952-expected.txt: Added.
* platform/efl/editing/selection/4895428-3-expected.png: Added.
* platform/efl/editing/selection/4895428-3-expected.txt: Added.
* platform/efl/editing/selection/4975120-expected.png: Added.
* platform/efl/editing/selection/4975120-expected.txt: Added.
* platform/efl/editing/selection/5007143-2-expected.png: Added.
* platform/efl/editing/selection/5007143-2-expected.txt: Added.
* platform/efl/editing/selection/5007143-expected.png: Added.
* platform/efl/editing/selection/5007143-expected.txt: Added.
* platform/efl/editing/selection/5057506-expected.png: Added.
* platform/efl/editing/selection/5057506-expected.txt: Added.
* platform/efl/editing/selection/5195166-1-expected.txt: Added.
* platform/efl/editing/selection/7152-2-expected.png: Added.
* platform/efl/editing/selection/7152-2-expected.txt: Added.
* platform/efl/editing/selection/caret-before-select-expected.png: Added.
* platform/efl/editing/selection/caret-before-select-expected.txt: Added.
* platform/efl/editing/selection/caret-ltr-right-expected.png: Added.
* platform/efl/editing/selection/caret-ltr-right-expected.txt: Added.
* platform/efl/editing/selection/caret-rtl-2-left-expected.png: Added.
* platform/efl/editing/selection/caret-rtl-2-left-expected.txt: Added.
* platform/efl/editing/selection/caret-rtl-right-expected.png: Added.
* platform/efl/editing/selection/caret-rtl-right-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove irrelevant blog from Planet WebKit.
bfulgham@apple.com [Thu, 13 Jun 2013 01:00:43 +0000 (01:00 +0000)]
Remove irrelevant blog from Planet WebKit.
https://bugs.webkit.org/show_bug.cgi?id=117572

Reviewed by Mark Rowe.

* config.ini: Remove Chromium blog from planet.webkit.org

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Activate supported C++11 Features for VS2010
bfulgham@apple.com [Thu, 13 Jun 2013 00:59:48 +0000 (00:59 +0000)]
[Windows] Activate supported C++11 Features for VS2010
https://bugs.webkit.org/show_bug.cgi?id=117569

Reviewed by Anders Carlsson.

* wtf/Compiler.h: Turn on rvalue references and static_assert
when compiling with VS2010 (or newer)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the notion of inactive plug-ins
andersca@apple.com [Thu, 13 Jun 2013 00:34:45 +0000 (00:34 +0000)]
Remove the notion of inactive plug-ins
https://bugs.webkit.org/show_bug.cgi?id=117570
<rdar://problem/13484213>

Reviewed by Tim Horton.

Source/WebCore:

Remove RenderEmbeddedObject::PluginInactive and the replacement text.

* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
* platform/LocalizedStrings.h:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::unavailablePluginReplacementText):
* rendering/RenderEmbeddedObject.h:

Source/WebKit/mac:

Remove code that deals with inactive plug-ins.

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):

Source/WebKit2:

Remove code that deals with inactive plug-ins. We still keep around the kWKPluginLoadPolicyInactive API enum for now.

* Shared/Plugins/PluginModuleInfo.h:
* UIProcess/API/C/WKAPICast.h:
(WebKit::toWKPluginLoadPolicy):
(WebKit::toPluginModuleLoadPolicy):
* UIProcess/Plugins/PluginInfoStore.cpp:
* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Implement Accessibility2 APIs in Windows.
bfulgham@apple.com [Thu, 13 Jun 2013 00:05:23 +0000 (00:05 +0000)]
[Windows] Implement Accessibility2 APIs in Windows.
https://bugs.webkit.org/show_bug.cgi?id=117561

Reviewed by Anders Carlsson.

Source/WebKit:

* WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Add new IAccessible2 IDL files.
* WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters: Ditto.
* WebKit.vcxproj/Interfaces/InterfacesCommon.props: Reference new Accessible2 folder.
* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Build IAccessible2 symbols.
* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters: Ditto.

Source/WebKit/win:

* AccessibleBase.cpp: Add stubs for IAccessible2 interface, replace attributeValue
method with get_attribute from IAccessible2 API.
* AccessibleBase.h: Ditto.
* AccessibleDocument.cpp: Revise signatures for IAccessible2.
* AccessibleDocument.h: Ditto.
* AccessibleImage.cpp: Revise signatures for IAccessible2.
* AccessibleImage.h: Ditto.
* Interfaces/Accessible2: Added.
* Interfaces/Accessible2/Accessible2.idl: Added.
* Interfaces/Accessible2/Accessible2_2.idl: Added.
* Interfaces/Accessible2/AccessibleApplication.idl: Added.
* Interfaces/Accessible2/AccessibleRelation.idl: Added.
* Interfaces/Accessible2/AccessibleStates.idl: Added.
* Interfaces/Accessible2/IA2CommonTypes.idl: Added.
* Interfaces/AccessibleComparable.idl:
* Interfaces/WebKit.idl: Reference IAccessible2 types.
* WebFrame.cpp:
(WebFrame::accessible): Pass window handle to IAccessible types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Change default Traditional Chinese serif font on 10.9
dino@apple.com [Wed, 12 Jun 2013 23:55:59 +0000 (23:55 +0000)]
[Mac] Change default Traditional Chinese serif font on 10.9
https://bugs.webkit.org/show_bug.cgi?id=117568

Reviewed by Alexey Proskuryakov.

Change default font on newer versions of OS X.

* page/mac/SettingsMac.mm:
(WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti TC'
on 10.9 and above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Explicit include glib.h to avoid compilation errors if libsoup isn't used.
hugo.lima@openbossa.org [Wed, 12 Jun 2013 23:53:03 +0000 (23:53 +0000)]
[GTK] Explicit include glib.h to avoid compilation errors if libsoup isn't used.
https://bugs.webkit.org/show_bug.cgi?id=117564

Reviewed by Martin Robinson.

* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Change default Simplified Chinese serif font on 10.9
dino@apple.com [Wed, 12 Jun 2013 23:48:27 +0000 (23:48 +0000)]
[Mac] Change default Simplified Chinese serif font on 10.9
https://bugs.webkit.org/show_bug.cgi?id=117567

Reviewed by Alexey Proskuryakov.

Change default font on newer versions of OS X.

* page/mac/SettingsMac.mm:
(WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti SC'
instead of 'STSong' on newer systems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix crashes due to failed ImageBuffer allocation
gyuyoung.kim@samsung.com [Wed, 12 Jun 2013 23:30:12 +0000 (23:30 +0000)]
Fix crashes due to failed ImageBuffer allocation
https://bugs.webkit.org/show_bug.cgi?id=117541

Reviewed by Andreas Kling.

From Blink r152268 by <pdr@chromium.org>

A crash can happen due to a failed ImageBuffer allocation in
SVGImage::drawPatternForContainer(). Added a check for that failed allocation.

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
commit-queue@webkit.org [Wed, 12 Jun 2013 21:39:42 +0000 (21:39 +0000)]
[atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=115647

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-12
Reviewed by Martin Robinson.

Source/WebCore:

Override the get_object_locale() method of WebkitAccessibleWrapperAtk's internal
AtkObject, to include custom implementations for AtkDocument and AtkText objects,
taking the logic as-is from AtkDocument::get_document_locale() and DumpRenderTree's
AccessibilityUIElementAtk::language(), respectively.

Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
method.

No new functionality, no new tests.

* accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:
(webkitAccessibleDocumentInterfaceInit): Chains implementation of
AtkDocument::get_document_locale() to AtkObject::get_object_locale().
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetObjectLocale): Add implementation of locale resolution for
objects of type AtkDocument and AtkText.
(webkitAccessibleClassInit): Override AtkObject::get_object_locale() method.

Tools:

Locale resolution is moved to WebKitAccessibleWrapperAtk using
AtkObject::get_object_locale() API. Now, implementation of
AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
be leveraged to get_object_locale() of AtkObject.

Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
method.

No new functionality, no new tests.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::language): Leverage locale resolution to
AtkObject::get_object_locale().
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::language): Leverage locale resolution to
AtkObject::get_object_locale().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove last bits of GYP from build-webkit and update-webkit scripts
hugo.lima@openbossa.org [Wed, 12 Jun 2013 20:46:18 +0000 (20:46 +0000)]
Remove last bits of GYP from build-webkit and update-webkit scripts
https://bugs.webkit.org/show_bug.cgi?id=117557

Reviewed by Ryosuke Niwa.

* Scripts/build-webkit:
* Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Move more build targets for source code that's free of layer violations into...
zandobersek@gmail.com [Wed, 12 Jun 2013 20:18:16 +0000 (20:18 +0000)]
[GTK] Move more build targets for source code that's free of layer violations into libPlatform
https://bugs.webkit.org/show_bug.cgi?id=115936

Reviewed by Martin Robinson.

Source/Platform:

* GNUmakefile.am: Add additional Source/WebCore/platform subdirectories to the list of the directories
that are specific to the platform layer but still located in WebCore. Add Enchant and Freetype dependencies'
CFLAGS to the list of libPlatform CPPFLAGS. Add GStreamer dependency's CFLAGS to the list of libPlatformGtk
CPPFLAGS.

Source/WebCore:

No new tests - no new functionality.

* GNUmakefile.list.am: Move more build targets under the platform_sources and platformgtk_sources listing.
These build targets represent source files that are already free of platform layer violations and are as such
ready to be pushed down from the WebCore layer into the Platform layer.

Source/WebKit2:

* GNUmakefile.am: Add GStreamer dependency's CFLAGS to the list of libPlatformGtk2 CPPFLAGS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove forgotten unused Tools/Script/make-gypi script
hugo.lima@openbossa.org [Wed, 12 Jun 2013 20:07:39 +0000 (20:07 +0000)]
Remove forgotten unused Tools/Script/make-gypi script
https://bugs.webkit.org/show_bug.cgi?id=117558

Reviewed by Ryosuke Niwa.

This script isn't used since the GYP removal from WebKit.

* Scripts/make-gypi: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago"Open Video in New Window" doesn't make sense in fullscreen
commit-queue@webkit.org [Wed, 12 Jun 2013 19:58:29 +0000 (19:58 +0000)]
"Open Video in New Window" doesn't make sense in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=117556

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
Reviewed by Beth Dakin.

Source/WebCore:

No new tests needed.

* WebCore.exp.in: Added WebKit2 hook for mediaIsInFullscreen() method.

Source/WebKit2:

Adds method mediaIsInFullscreen() that checks if a media element is in
fullscreen mode, which is needed to decide when to display the
"Open Video in New Window" context menu item.

* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultMediaIsInFullscreen): Added.
Hooks into new InjectedBundleHitTestResult::mediaIsInFullscreen() method.
* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::mediaIsInFullscreen): Added.
Checks if media element is in fullscreen.
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAccessibility code assumes an area element's parent is a map element
rniwa@webkit.org [Wed, 12 Jun 2013 19:52:04 +0000 (19:52 +0000)]
Accessibility code assumes an area element's parent is a map element
https://bugs.webkit.org/show_bug.cgi?id=117496

Reviewed by Chris Fleizach.

Source/WebCore:

We can't make such an assumption. Scripts can insert any element between area and map elements.

Merge https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f.

Test: accessibility/image-map-with-indirect-area-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):

LayoutTests:

Add a regression test from https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f.

* accessibility/image-map-with-indirect-area-crash-expected.txt: Added.
* accessibility/image-map-with-indirect-area-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Whitespace between inlines with nowrap and a shrink-to-fit parent...
robert@webkit.org [Wed, 12 Jun 2013 19:20:33 +0000 (19:20 +0000)]
Source/WebCore: Whitespace between inlines with nowrap and a shrink-to-fit parent gets a line-break when it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=117370

Reviewed by David Hyatt.

Test: fast/text/whitespace/inline-whitespace-wrapping-8.html

A no-wrap inline shouldn't include trailing space when deciding whether it fits on a line.
Likewise when we finish iterating through the objects on a line we should clear our linebreak
if the only thing that prevents us fitting on the line is our collapsed trailing whitespace.

Removing the trailing space from this measurement means we need to watch out for potential
breaks between no-wrap inlines, in particular if we leave a no-wrap inline ignoring spaces
and enter an autowrap inline then we need to mark the beginning of the autowrap inline
as a potential linebreak. The test fast/text/whitespace/inline-whitespace-wrapping-5.html
is an example of such a case.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
(WebCore::LineWidth::setTrailingWhitespaceWidth):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests: Whitespace between inlines with nowrap and a shrink-to-fit parent line-break incorrectly
https://bugs.webkit.org/show_bug.cgi?id=117370

Reviewed by David Hyatt.

* fast/text/whitespace/inline-whitespace-wrapping-8-expected.html: Added.
* fast/text/whitespace/inline-whitespace-wrapping-8.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Shapes] rectangle and inset-rectangle do not properly handle rx and ry
commit-queue@webkit.org [Wed, 12 Jun 2013 18:59:58 +0000 (18:59 +0000)]
[CSS Shapes] rectangle and inset-rectangle do not properly handle rx and ry
https://bugs.webkit.org/show_bug.cgi?id=116745

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-06-12
Reviewed by Dirk Schulze.

Source/WebCore:

If ry is not supplied, it now defaults to the rx value. Also, if rx
and ry are not supplied, they default to 0px. This also has the effect
that the computed style for any rectangle or inset-rectangle now
contains all six parameters.

If rx > width/2 then it is clamped to width/2, and if ry > height/2,
then it is clamped to height/2. This happens at layout time because
given mixed units and relative units, that is the only time this
determination can be made.

Tests: fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html
       fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html

* css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape): Remove checks for undefined, since rx
    and ry cannot be undefined in BasicShapes anymore.
(WebCore::basicShapeForValue): If radii are undefined in CSS, set
    default values in the BasicShape, per the spec.
* rendering/ExclusionShape.cpp:
(WebCore::ensureRadiiDoNotOverlap): Utility method to ensure radii
    don't overlap.
(WebCore::ExclusionShape::createExclusionShape): Remove defaulting to
    zero, clamp radii per the spec.
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeRectangle::path): Remove defaulting.
(WebCore::BasicShapeRectangle::blend): Ditto.
(WebCore::BasicShapeInsetRectangle::path): Ditto.
(WebCore::BasicShapeInsetRectangle::blend): Ditto.
* rendering/style/BasicShapes.h:
(WebCore::BasicShapeRectangle::BasicShapeRectangle): Remove defaulting
    to undefined for radii.
(WebCore::BasicShapeRectangle::setCornerRadiusX): Add assert to
    prevent undefined.
       (WebCore::BasicShapeRectangle::setCornerRadiusY): Add assert to
    prevent undefined.
(WebCore::BasicShapeInsetRectangle::BasicShapeInsetRectangle): Ditto.
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX): Add assert to
    prevent undefined.
       (WebCore::BasicShapeInsetRectangle::setCornerRadiusY): Add assert to
    prevent undefined.

LayoutTests:

Update tests to check for the rx and ry conditions.

* fast/exclusions/parsing/parsing-shape-inside-expected.txt: New results.
* fast/exclusions/parsing/parsing-shape-outside-expected.txt: New results.
* fast/exclusions/parsing/script-tests/parsing-shape-inside.js: Update
    to reflect that the computed value now always has rx and ry.
* fast/exclusions/parsing/script-tests/parsing-shape-outside.js: Ditto.
* fast/exclusions/parsing/script-tests/parsing-test-utils.js: Ditto.
* fast/exclusions/resources/rounded-rectangle.js:
(genLeftRightRoundedRectFloatShapeOutsideRefTest): Factor out left and
    right into separate methods so that they can be used in tests that
    only have left floats or only right floats.
(genLeftRoundedRectFloatShapeOutsideRefTest): Ditto.
(genRightRoundedRectFloatShapeOutsideRefTest): Ditto.
* fast/exclusions/shape-inside/shape-inside-animation-expected.txt: New results.
* fast/exclusions/shape-inside/shape-inside-animation.html: Change to
    reflect new computed style value.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius-expected.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html: Added.
    Note that the expected test here uses shape-inside, because we
    really are just testing that the behavior is the same as a
    shape-inside with rx and ry set to 50%, and it turned out to be
    very hard to construct an expected result that didn't use
    shape-inside and wasn't off by a pixel.
* css3/masking/clip-path-animation.html: Update expected value.
* css3/masking/clip-path-animation-expected.txt: New results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Support Title UI Element Accessibility Attribute
bfulgham@apple.com [Wed, 12 Jun 2013 18:57:51 +0000 (18:57 +0000)]
[Windows] Support Title UI Element Accessibility Attribute
https://bugs.webkit.org/show_bug.cgi?id=117530

Reviewed by Anders Carlsson.

Source/WebCore:

Fixes: accessibility/list-item-role.html
       accessibility/hidden-legend.html

* accessibility/win/AccessibilityObjectWrapperWin.cpp:
(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue): Extend to support access
for the Title UI Element object.
* accessibility/win/AccessibilityObjectWrapperWin.h: Revise interface to use Variant output,
which is more in keeping with the Mac's 'id' method signature.

Source/WebKit/win:

* AccessibleBase.cpp:
(AccessibleBase::attributeValue): Extend to handle Title UI Element.
* AccessibleBase.h: Revise signature to use a variant argument.
* Interfaces/AccessibleComparable.idl:  Revise interface to use variant

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd new Web Inspector images for a blog post.
timothy@apple.com [Wed, 12 Jun 2013 18:53:47 +0000 (18:53 +0000)]
Add new Web Inspector images for a blog post.

* blog-files/new-inspector/activity-viewer.png: Added.
* blog-files/new-inspector/codemirror.png: Added.
* blog-files/new-inspector/console.png: Added.
* blog-files/new-inspector/hero-labeled.png: Added.
* blog-files/new-inspector/hero.png: Added.
* blog-files/new-inspector/layer-borders.png: Added.
* blog-files/new-inspector/layers.png: Added.
* blog-files/new-inspector/navigation-bar.png: Added.
* blog-files/new-inspector/open-sign.png: Added.
* blog-files/new-inspector/reasons.png: Added.
* blog-files/new-inspector/save.png: Added.
* blog-files/new-inspector/source-map.png: Added.
* blog-files/new-inspector/styles.png: Added.
* blog-files/new-inspector/toolbar-context-menu.png: Added.
* blog-files/new-inspector/toolbar-docked.png: Added.
* blog-files/new-inspector/toolbar.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Use RefPtr for HTMLInputElement inside CredentialTransformData
leoyang@rim.com [Wed, 12 Jun 2013 18:41:30 +0000 (18:41 +0000)]
[BlackBerry] Use RefPtr for HTMLInputElement inside CredentialTransformData
https://bugs.webkit.org/show_bug.cgi?id=117553

Reviewed by Carlos Garcia Campos.

In CredentialTransformData we should use RefPtr for
m_userNameElement, m_passwordElement and m_oldPasswordElement
because otherwise the elements could go away when the form
elements get destroyed.

Also add *const* for the parameter of CredentialTransformData::findPasswordFormFields().

No functionalities changed no new tests.

* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields):
(WebCore::CredentialTransformData::locateSpecificPasswords):
* WebCoreSupport/CredentialTransformData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Shaders] Animations and transitions should use validated custom programs
commit-queue@webkit.org [Wed, 12 Jun 2013 18:28:24 +0000 (18:28 +0000)]
[CSS Shaders] Animations and transitions should use validated custom programs
https://bugs.webkit.org/show_bug.cgi?id=117550

Run filters used for animations and transitions through RenderLayer::computeFilterOperations
in order to validate custom filter operations.

Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-12
Reviewed by Alexandru Chiculita.

No new tests as no platform can run custom filters with accelerated animations yet.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow for toggling fullscreen on <video> elements
commit-queue@webkit.org [Wed, 12 Jun 2013 17:33:31 +0000 (17:33 +0000)]
Allow for toggling fullscreen on <video> elements
https://bugs.webkit.org/show_bug.cgi?id=117220

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
Reviewed by Dean Jackson.

Source/WebCore:

This patch adds the ability for fullscreen
context menu item on <video> elements to switch between "Enter Fullscreen"
and "Exit Fullscreen" and behave appropriately.

No new tests. media/context-menu-action.html,
which has been disabled by bug 116651, is used to test context menus.

* English.lproj/Localizable.strings: Add "Exit Fullscreen" string.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::toggleFullscreenState): Added to appropriately enter/exit fullscreen.
* html/HTMLMediaElement.h:
* page/ContextMenuController.cpp:
* platform/ContextMenuItem.h:
* platform/LocalizedStrings.cpp:
* platform/LocalizedStrings.h:
Updated to rename variables more appropriately to reflect the toggle-ability of video fullscreen.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::mediaIsInFullscreen): Added to check if an element
was a media element in fullscreen.
(WebCore::HitTestResult::toggleMediaFullscreenState): Added to hook into
HTMLMediaElement::toggleFullscreenState.
* rendering/HitTestResult.h:

Source/WebKit2:

* Shared/API/c/WKContextMenuItemTypes.h:
* Shared/API/c/WKSharedAPICast.h:
Added variables to support the toggle-ability of the fullscreen
video context menu item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[ARM] Unreviewed gardening, unskip now passing tests and try to paint the bot green.
ossy@webkit.org [Wed, 12 Jun 2013 17:32:33 +0000 (17:32 +0000)]
[ARM] Unreviewed gardening, unskip now passing tests and try to paint the bot green.

* platform/qt-arm/TestExpectations:
* platform/qt-arm/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
* platform/qt-arm/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
* platform/qt-arm/svg/batik/text/textOnPath3-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkipping {}, () and [] blocks while error recovering in CSS
sergio@webkit.org [Wed, 12 Jun 2013 17:23:31 +0000 (17:23 +0000)]
Skipping {}, () and [] blocks while error recovering in CSS
https://bugs.webkit.org/show_bug.cgi?id=116071

Reviewed by Darin Adler.

From Blink r150201 and r150755 by <serya@chromium.org>

Source/WebCore:

Test: fast/css/parsing-expr-error-recovery.html

The CSS parser should properly recover from invalid {}, () and []
blocks skipping them instead of discarding the whole declaration
as invalid. This merge is actually made of two different changes
from Blink, the original one that fixes the bug and another one
which refactors a bit the code making it more legible.

* css/CSSGrammar.y.in:

LayoutTests:

* fast/css/parsing-expr-error-recovery-expected.txt: Added.
* fast/css/parsing-expr-error-recovery.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSExport header documentation substitutes "semicolon" for "colon"
commit-queue@webkit.org [Wed, 12 Jun 2013 17:22:57 +0000 (17:22 +0000)]
JSExport header documentation substitutes "semicolon" for "colon"
https://bugs.webkit.org/show_bug.cgi?id=117552

Patch by Conrad Shultz <conrad_shultz@apple.com> on 2013-06-12
Reviewed by Mark Hahnenberg.

* API/JSExport.h:
Fix a couple typos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Invalidate the ProcessLauncher when the process is terminated before it has...
carlosgc@webkit.org [Wed, 12 Jun 2013 17:17:42 +0000 (17:17 +0000)]
[GTK] Invalidate the ProcessLauncher when the process is terminated before it has finished launching
https://bugs.webkit.org/show_bug.cgi?id=117412

Reviewed by Anders Carlsson.

* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::terminateProcess): If process is still
launching just invalidate the launcher. Reset the process
identifier after killing the process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Remove dead WebDOM code
commit-queue@webkit.org [Wed, 12 Jun 2013 17:11:41 +0000 (17:11 +0000)]
[BlackBerry] Remove dead WebDOM code
https://bugs.webkit.org/show_bug.cgi?id=113370

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-12
Reviewed by Anders Carlsson.

BlackBerry PR 347565
Internally reviewed by Charles Wei.

.:

* Source/cmake/OptionsBlackBerry.cmake:

Source/WebCore:

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

* Api/WebPage.cpp:
* Api/WebPage.h:
* WebCoreSupport/AboutDataEnableFeatures.in:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[css exclusions] fast/css/variables/var-inside-shape.html is failing
sergio@webkit.org [Wed, 12 Jun 2013 17:01:00 +0000 (17:01 +0000)]
[css exclusions] fast/css/variables/var-inside-shape.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116059

Reviewed by Alexandru Chiculita.

Some shapes were incorrectly defined, there was a "rectange"
instead of a "rectangle" and also the number of parameters and
their types was wrong. Apart from that, both the CSS exclusions
and CSS variables settings were not enabled at runtime.

Some extra text was also added to the divs in order to verify that
the CSS exclusions are working properly.

* fast/css/variables/var-inside-shape-expected.html:
* fast/css/variables/var-inside-shape.html:
* platform/efl/TestExpectations: Removed var-inside-shape.html.
* platform/gtk/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowindow.find() case-insensitive search doesn't match diacritical marks
dbates@webkit.org [Wed, 12 Jun 2013 16:46:15 +0000 (16:46 +0000)]
window.find() case-insensitive search doesn't match diacritical marks
https://bugs.webkit.org/show_bug.cgi?id=117353
<rdar://problem/8535227>

Patch by Daniel Bates <dabates@apple.com> on 2013-06-12
Reviewed by Darin Adler.

Source/WebCore:

Currently, a case-insensitive window.find() search will return true for a word w
(e.g. café) with diacritical characters when w appears on the page without
diacritical marks (e.g. cafe). This leads to bad results, especially when
searching for a non-English word (e.g. qué) where the presence of an accented
character(s) may change the meaning of the word. Instead window.find() should
return false when case-insensitively matching a word with diacritical marks to
the same word without diacritical marks.

Test: fast/text/find-diacritical-mark.html

* editing/TextIterator.cpp:
(WebCore::SearchBuffer::SearchBuffer):

LayoutTests:

Added test to use window.find() to find a search string in text, where either
the search string or text (or both) contain diacritical characters.

Additionally, updated tests LayoutTests/fast/text/find-soft-hyphen.html
and LayoutTests/editing/execCommand/findString-diacriticals.html based on the
new behavior of window.find(). Moved function testFind() from LayoutTests/fast/text/script-tests/find-backwards.js
to its own file, LayoutTests/fast/text/resources/test-find.js, so that this function can
be used by both tests LayoutTests/fast/text/find-{backwards, diacritical-mark}.html.

* LayoutTests/editing/execCommand/findString-diacriticals.html: Update test based on the new
behavior of window.find().
* fast/text/find-backwards.html: Include external JavaScript file test-find.js.
* fast/text/find-case-folding-expected.txt: Rebase result; expected failure.
* fast/text/find-case-folding.html: Add comment to see bug #117548 with regards to expected failure.
* fast/text/find-diacritical-mark-expected.txt: Added.
* fast/text/find-diacritical-mark.html: Copied from LayoutTests/fast/text/find-backwards.html.
* fast/text/find-soft-hyphen-expected.txt: Rebase result.
* fast/text/resources/test-find.js: Added.
(testFind):
* fast/text/script-tests/find-backwards.js: Moved function testFind() from here to
file fast/text/resources/test-find.js and modified it to take an additional argument to
toggle search case sensitivity.
* fast/text/script-tests/find-diacritical-mark.js: Added.
* fast/text/script-tests/find-soft-hyphen.js: Update test based on the new behavior of window.find().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Smarter algorithm to determine the backingstore rect
commit-queue@webkit.org [Wed, 12 Jun 2013 16:06:52 +0000 (16:06 +0000)]
[BlackBerry] Smarter algorithm to determine the backingstore rect
https://bugs.webkit.org/show_bug.cgi?id=117451

JIRA115644
https://jira.bbqnx.net/browse/BRWSR-7028

Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-06-12
Reviewed by Rob Buis.

So far, the backingstore tile geometry allocation was
pretty straightforward: We would start off from the
current viewport and append all available tiles into
the current scrolling direction from there.

This will usually work well enough, but has the downside
of discarding all the tiles in the opposite direction.
Also, tiles very close to the viewport will often get
discarded even if the user only scrolls very slowly.

This patch completely revamps the algorithm for
determining where the backingstore should be positioned.

The general idea is that we construct a "desired rect"
based on the viewport and inflate it into all four
directions according to the current scroll momentum.
This rectangle will be similarly large as a backingstore
tile geometry rectangle might be, by using the
approximate number of pixels that are available in the
given number of tiles.

The proportions for extending the rectangle from the
viewport are influenced by different factors, including
scroll momentum, viewport ratio, available space in the
overall contents rectangle, and natural bias for the
"down" direction.

In practice, this results in a backingstore that is
roughly evenly distributed around the viewport when no
movement is happening, and will gradually narrow down
and extend into the scroll direction at a higher momentum.

The final tile geometry is constructed by trying fit
the tiles into the desired rect in a way that maximizes
the area of its intersection. There are a few parameters
that can be tweaked, the ones in this patch seem to
handle most cases well enough to minimize checkerboarding.

As an additional bonus, a rectangle-based tiling strategy
can more easily be adopted for accelerated compositing,
which currently operates on a simpler algorithm that also
inflates the viewport but does not take scrolling into
account.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::nonOverscrolled):
(BlackBerry::WebKit::BackingStorePrivate::enclosingTileRect):
(BlackBerry::WebKit::BackingStorePrivate::desiredBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::mergeDesiredBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::largestTileRectForDesiredRect):
(BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
* Api/BackingStore_p.h:
(BackingStorePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][CSS Regions] fast/regions/overflow-size-change-with-stacking-context.html fails
commit-queue@webkit.org [Wed, 12 Jun 2013 15:48:21 +0000 (15:48 +0000)]
[Qt][CSS Regions] fast/regions/overflow-size-change-with-stacking-context.html fails
https://bugs.webkit.org/show_bug.cgi?id=97199

Unreviewed, Qt Gardening.

Unskip test that is now passing on the bots.

Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-06-12

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport latest Web IDL indexed property getters
ch.dumez@sisa.samsung.com [Wed, 12 Jun 2013 14:41:19 +0000 (14:41 +0000)]
Support latest Web IDL indexed property getters
https://bugs.webkit.org/show_bug.cgi?id=117507

Reviewed by Kentaro Hara.

Support latest Web IDL indexed property getters:
http://www.w3.org/TR/WebIDL/#dfn-support-indexed-properties

Drop support for outdated [IndexedGetter] and [NumericIndexedGetter]
IDL extended attributes. Since the new getter format specifies the
return type, the bindings generator is now smart enough to know if
the indexed getter is numeric or not on its own.

Based on Blink r149564 by <kojih@chromium.org>.

No new tests, no behavior change.

* Modules/filesystem/EntryArray.idl:
* Modules/filesystem/EntryArraySync.idl:
* Modules/gamepad/GamepadList.idl:
* Modules/mediasource/SourceBufferList.idl:
* Modules/speech/SpeechGrammarList.idl:
* Modules/speech/SpeechRecognitionResult.idl:
* Modules/speech/SpeechRecognitionResultList.idl:
* bindings/scripts/CodeGenerator.pm:
(IsNumericType):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GetIndexedGetterFunction):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/TestEventTarget.idl:
* bindings/scripts/test/TestTypedArray.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSValueList.idl:
* css/MediaList.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSFilterValue.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSTransformValue.idl:
* dom/ClientRectList.idl:
* dom/DOMNamedFlowCollection.idl:
* dom/DOMStringList.idl:
* dom/DataTransferItemList.idl:
* dom/NamedNodeMap.idl:
* dom/NodeList.idl:
* dom/PropertyNodeList.idl:
* dom/TouchList.idl:
* fileapi/FileList.idl:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* html/HTMLAllCollection.idl:
* html/HTMLCollection.idl:
* html/HTMLFormControlsCollection.idl:
* html/HTMLFormElement.idl:
* html/HTMLPropertiesCollection.idl:
* html/HTMLSelectElement.idl:
* html/RadioNodeList.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/track/AudioTrackList.idl:
* html/track/TextTrackCueList.idl:
* html/track/TextTrackList.idl:
* html/track/TextTrackRegionList.idl:
* html/track/VideoTrackList.idl:
* page/PerformanceEntryList.idl:
* page/SpeechInputResultList.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Coordinated Graphics] Remove unused headers in CoordinatedLayerTreeHostProxy
commit-queue@webkit.org [Wed, 12 Jun 2013 14:37:28 +0000 (14:37 +0000)]
[Coordinated Graphics] Remove unused headers in CoordinatedLayerTreeHostProxy
https://bugs.webkit.org/show_bug.cgi?id=117539

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-06-12
Reviewed by Noam Rosenthal.

* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Unskipping passing tests.
kseo@webkit.org [Wed, 12 Jun 2013 13:50:30 +0000 (13:50 +0000)]
Unreviewed gardening. Unskipping passing tests.

* platform/gtk-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] MiniBrowser to automatically download "non-showable" documents when left click...
commit-queue@webkit.org [Wed, 12 Jun 2013 13:39:19 +0000 (13:39 +0000)]
[GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
https://bugs.webkit.org/show_bug.cgi?id=117533

Patch by Andres Gomez <agomez@igalia.com> on 2013-06-12
Reviewed by Carlos Garcia Campos.

MiniBrowser now starts automatically the download of the documents
that cannot be shown just by WebKit itself on link left clicking.

* MiniBrowser/gtk/BrowserWindow.c:
(webViewDecidePolicy): handled the
WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename [CallWith] to [ConstructorCallWith] for IDL interfaces
ch.dumez@sisa.samsung.com [Wed, 12 Jun 2013 12:25:41 +0000 (12:25 +0000)]
Rename [CallWith] to [ConstructorCallWith] for IDL interfaces
https://bugs.webkit.org/show_bug.cgi?id=117531

Reviewed by Kentaro Hara.

Rename [CallWith] to [ConstructorCallWith] for IDL interfaces as the
meaning is slightly different when [CallWith] is used for IDL operations
or attributes. This improves IDL readability a bit and makes it more
directly understandable.

Also removed [ConstructorCallWith] statements from interfaces with custom
constructors or no constructor, as this does not have any effect.

No new tests, no behavior change.

* Modules/filesystem/FileWriter.idl:
* Modules/mediasource/MediaSource.idl:
* Modules/mediasource/SourceBufferList.idl:
* Modules/mediastream/MediaStream.idl:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/notifications/Notification.idl:
* Modules/speech/SpeechRecognition.idl:
* Modules/speech/SpeechSynthesisUtterance.idl:
* Modules/webaudio/OfflineAudioContext.idl:
* Modules/websockets/WebSocket.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/TestInterface.idl:
* dom/MessageChannel.idl:
* fileapi/FileReader.idl:
* html/MediaController.idl:
* html/track/TextTrackCue.idl:
* page/EventSource.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:
* xml/XMLHttpRequest.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Set windows key-code for multimedia keys
allan.jensen@digia.com [Wed, 12 Jun 2013 11:44:33 +0000 (11:44 +0000)]
[Qt] Set windows key-code for multimedia keys
https://bugs.webkit.org/show_bug.cgi?id=117535

Reviewed by Jocelyn Turcotte.

Map Qt Key-events to their defined windows keycode values.

* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::windowsKeyCodeForKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Soup] Use ResourceLoadPriority
sergio@webkit.org [Wed, 12 Jun 2013 11:34:01 +0000 (11:34 +0000)]
[Soup] Use ResourceLoadPriority
https://bugs.webkit.org/show_bug.cgi?id=112902

Reviewed by Carlos Garcia Campos.

Use the ResourceLoadPriority from the ResourceRequest to set the
correnpondent priority to each SoupMessage.

No new tests required as there is no change in functionality,
we're just enabling a new feature in the underlying network stack.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupMessageForHandleAndRequest):
* platform/network/soup/ResourceRequest.h:
(WebCore):
(WebCore::toSoupMessagePriority): Translates ResourceLoadPriority
to SoupMessagePriority.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
zandobersek@gmail.com [Wed, 12 Jun 2013 08:51:48 +0000 (08:51 +0000)]
[GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
https://bugs.webkit.org/show_bug.cgi?id=116723

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

* GNUmakefile.am: When generating the WebCoreLayerGtk2.a archive from all the dependency archives, remove the
current archive (if any). Updating an existent archive in an incremental build is not bulletproof and can lead
to corrupt archives and subsequent build failures. On the other hand, the archive generation is not expensive
and produces a working archive without problems even on incremental builds.

Tools:

* TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
not expensive and produces a working archive without problems even on incremental builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove memoryInfoEnabled, quantizedMemoryInfoEnabled settings
zandobersek@gmail.com [Wed, 12 Jun 2013 08:45:44 +0000 (08:45 +0000)]
Remove memoryInfoEnabled, quantizedMemoryInfoEnabled settings
https://bugs.webkit.org/show_bug.cgi?id=117512

Reviewed by Darin Adler.

Source/WebCore:

* page/Settings.in: Remove the memoryInfoEnabled and the quantizedMemoryInfoEnabled settings. These are not used
anywhere anymore after r151199 which simplified and moved the MemoryInfo interface under window.internals.

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init): Remove the call to Settings::setMemoryInfoEnabled, the setting is being removed.

Source/WebKit/mac:

* WebKit.order: Remove the memoryInfoEnabled entry.
* WebView/WebPreferenceKeysPrivate.h: Remove WebKitMemoryInfoEnabledPreferenceKey.
* WebView/WebPreferences.mm: Remove memoryInfoEnabled, setMemoryInfoEnabled methods.
(+[WebPreferences initialize]): Don't set the default value for the WebKitMemoryInfoEnabledPreferenceKey, the preference is being removed.
* WebView/WebPreferencesPrivate.h: Remove memoryInfoEnabled, setMemoryInfoEnabled method declarations.
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Remove the call to Settings::setMemoryInfoEnabled, the setting is being removed.

Source/WebKit/win:

* Interfaces/IWebPreferencesPrivate.idl: Remove memoryInfoEnabled, setMemoryInfoEnabled entries.
* WebPreferenceKeysPrivate.h: Remove the WebKitMemoryInfoEnabledPreferenceKey definition.
* WebPreferences.cpp: Remove the memoryInfo, setMemoryInfoEnabled methods.
(WebPreferences::initializeDefaultSettings): Remove the WebKitMemoryInfoEnabledPreferenceKey entry initialization.
* WebPreferences.h: Remove the memoryInfo, setMemoryInfoEnabled method declarations.
* WebView.cpp:
(WebView::notifyPreferencesChanged): Remove the Settings::setMemoryInfoEnabled call, the method is being removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK build fix.
zandobersek@gmail.com [Wed, 12 Jun 2013 08:36:39 +0000 (08:36 +0000)]
Unreviewed GTK build fix.

* GNUmakefile.list.am: Adding missing build targets to the plugin process after r151480.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Parameter 'pseudoElement' from function 'webkit_dom_dom_window_get_computed_sty...
commit-queue@webkit.org [Wed, 12 Jun 2013 08:09:47 +0000 (08:09 +0000)]
[GTK] Parameter 'pseudoElement' from function 'webkit_dom_dom_window_get_computed_style' should be allowed to be NULL
https://bugs.webkit.org/show_bug.cgi?id=117332

Patch by Diego Pino Garcia <dpino@igalia.com> on 2013-06-12
Reviewed by Xan Lopez.

Source/WebCore:

Add parameter 'pseudoElement' to the list of parameters that are allowed to
be NULL.

* bindings/scripts/CodeGeneratorGObject.pm:
(GetGReturnMacro):

Source/WebKit/gtk:

Add test for function 'webkit_dom_dom_window_get_computed_style'.

* tests/testdomdomwindow.c:
(dom_dom_window_fixture_setup): Test setup for function
'dom_dom_window_get_computed_style'.
(dom_dom_window_fixture_teardown): Test teardown for function
'dom_dom_window_get_computed_style'.
(loadedCallback):
(test_dom_dom_window_get_computed_style): Checks function
'dom_dom_window_get_computed_style'.
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd CSS parsing recovery to functions
sergio@webkit.org [Wed, 12 Jun 2013 07:20:20 +0000 (07:20 +0000)]
Add CSS parsing recovery to functions
https://bugs.webkit.org/show_bug.cgi?id=117500

Reviewed by Andreas Kling.

From Blink r150205 by <serya@chromium.org>

Source/WebCore:

Add parsing recovery capabilities to functions. Errors were
correctly detected without this change but then the whole
declaration was invalidated. By using expr_recovery to handle them
we can recover from those errors and go on with the parsing.

* css/CSSGrammar.y.in:

LayoutTests:

* fast/css/parsing-error-recovery.html: added some test cases for
parsing recovery inside functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r151378.
ch.dumez@sisa.samsung.com [Wed, 12 Jun 2013 06:05:58 +0000 (06:05 +0000)]
Unreviewed, rolling out r151378.
http://trac.webkit.org/changeset/151378
https://bugs.webkit.org/show_bug.cgi?id=117400

Decreased IDL readability a bit.

* Modules/encryptedmedia/MediaKeys.idl:
* Modules/mediastream/RTCIceCandidate.idl:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/RTCSessionDescription.idl:
* Modules/webaudio/OfflineAudioContext.idl:
* Modules/websockets/WebSocket.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/TestInterface.idl:
* bindings/scripts/test/TestNamedConstructor.idl:
* css/WebKitCSSMatrix.idl:
* html/HTMLOptionElement.idl:
* page/EventSource.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, EFL Gardening. Unskip fast/canvas/webgl/context-attributes-alpha-depth...
gyuyoung.kim@samsung.com [Wed, 12 Jun 2013 05:29:35 +0000 (05:29 +0000)]
Unreviewed, EFL Gardening. Unskip fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html
for efl-wk2. Because Ubuntu 13.04 solves issues related to xvfb. However, EFL WK1 doesn't support
webgl yet. So, it needs to be moved to efl-wk1 TestExpectations.

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, EFL Gardening.
gyuyoung.kim@samsung.com [Wed, 12 Jun 2013 05:10:21 +0000 (05:10 +0000)]
Unreviewed, EFL Gardening.

EFL WK2 supports fast/canvas/webgl/read-pixels-test.html because Ubuntu 13.04 solves issues related to xvfb.
However, EFL WK1 doesn't support webgl yet. So, it is moved to efl-wk1 TestExpectations.

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd NSSupportsAppNap keys to WebProcess, PluginProcess
barraclough@apple.com [Wed, 12 Jun 2013 03:09:15 +0000 (03:09 +0000)]
Add NSSupportsAppNap keys to WebProcess, PluginProcess
https://bugs.webkit.org/show_bug.cgi?id=117528

Reviewed by Mark Rowe.

* PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
* WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
    - add NSSupportsAppNap key.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Window resize should close the popupmenu
commit-queue@webkit.org [Wed, 12 Jun 2013 02:54:35 +0000 (02:54 +0000)]
[EFL] Window resize should close the popupmenu
https://bugs.webkit.org/show_bug.cgi?id=117391

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-11
Reviewed by Christophe Dumez.

Added the code to close the popup when main window is resized.

* MiniBrowser/efl/main.c:
(on_window_resize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, EFL gardening. Unskip passing tests for new EFL bots.
gyuyoung.kim@samsung.com [Wed, 12 Jun 2013 01:47:29 +0000 (01:47 +0000)]
Unreviewed, EFL gardening. Unskip passing tests for new EFL bots.

fast/parser/document-write-fighting-eof.html
fast/parser/document-write-partial-entity-before-load.html

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake sure we aren't throttling plugin timers during initialisation and destruction
oliver@apple.com [Wed, 12 Jun 2013 01:12:27 +0000 (01:12 +0000)]
Make sure we aren't throttling plugin timers during initialisation and destruction
https://bugs.webkit.org/show_bug.cgi?id=117522

Reviewed by Darin Adler.

Add a new ActivityAssertion RAII class to handle allowing/disallowing
timer throttling.  Then make use of it during plugin initialisation
and destruction, as well as any synchronous messages (on the basis
that if another process is waiting for the plugin we shouldn't be
throttling timers).

* CMakeLists.txt:
* GNUmakefile.list.am:
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveSyncMessage):
(WebKit::WebProcessConnection::destroyPlugin):
(WebKit::WebProcessConnection::createPlugin):
* Shared/ActivityAssertion.cpp: Added.
(WebKit::ActivityAssertion::ActivityAssertion):
(WebKit::ActivityAssertion::~ActivityAssertion):
* Shared/ActivityAssertion.h: Added.
* Target.pri:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Unreviewed build correction after r151440.
bfulgham@apple.com [Tue, 11 Jun 2013 23:51:33 +0000 (23:51 +0000)]
[Windows] Unreviewed build correction after r151440.

* AccessibleBase.cpp:
(MSAARole): Switch back to emiting ROLE_SYSTEM_LISTITEM for
ListItemRole Web role to avoid breaking existing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Another part of rollout of r151408.
roger_fong@apple.com [Tue, 11 Jun 2013 23:16:53 +0000 (23:16 +0000)]
Unreviewed. Another part of rollout of r151408.

* win/tools64: Removed.
* win/tools64/scripts: Removed.
* win/tools64/vsprops: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHave to invalidate the mute button when changing the volume
rniwa@webkit.org [Tue, 11 Jun 2013 21:59:12 +0000 (21:59 +0000)]
Have to invalidate the mute button when changing the volume
https://bugs.webkit.org/show_bug.cgi?id=117464

Reviewed by Darin Adler.

Merge https://chromium.googlesource.com/chromium/blink/+/c4c685c82908449526fd8c251cc551e729ebed08
but without a test since the test doesn't work in WebKit.

* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::changedVolume):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Regions] Regions don't create a stacking context for their contents
mvujovic@adobe.com [Tue, 11 Jun 2013 21:55:06 +0000 (21:55 +0000)]
[CSS Regions] Regions don't create a stacking context for their contents
https://bugs.webkit.org/show_bug.cgi?id=114268

Reviewed by Alexandru Chiculita.

Source/WebCore:

Paint the region content (from RenderFlowThread) during the background phase instead of the
foreground phase.

Let's assume there is a region and a sibling element. The sibling partially overlaps the
region and appears after the region in DOM order.

Before this patch, we would paint in this order:
1) Region background
2) Sibling background
3) Region content
4) Sibling content

As a result, the sibling background would incorrectly paint between the region
background and the region content. Instead, the sibling background should paint over the
region background and the region content.

After this patch, we paint in this order:
1) Region background
2) Region content
3) Sibling background
4) Sibling content

Test: fast/regions/region-sibling-paint-order.html

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::paintObject):

LayoutTests:

* fast/regions/region-sibling-paint-order-expected.html: Added.
* fast/regions/region-sibling-paint-order.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. WinTools makefile fix.
roger_fong@apple.com [Tue, 11 Jun 2013 21:46:03 +0000 (21:46 +0000)]
Unreviewed. WinTools makefile fix.

* win/tools32/WinTools.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: (r149232) videos on disney.com are initially scrambled on load
jer.noble@apple.com [Tue, 11 Jun 2013 21:43:41 +0000 (21:43 +0000)]
REGRESSION: (r149232) videos on disney.com are initially scrambled on load
https://bugs.webkit.org/show_bug.cgi?id=117517

Reviewed by Eric Carlson.

Set a background color on the AVPlayerLayer to avoid corruption when no
frames are available to display.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved old broken code coverage tool.
achristensen@apple.com [Tue, 11 Jun 2013 21:23:43 +0000 (21:23 +0000)]
Removed old broken code coverage tool.
https://bugs.webkit.org/show_bug.cgi?id=117520

Reviewed by Sam Weinig.

* CodeCoverage: Removed.
* CodeCoverage/README: Removed.
* CodeCoverage/amber.png: Removed.
* CodeCoverage/cov.py: Removed.
* CodeCoverage/emerald.png: Removed.
* CodeCoverage/gcov.css: Removed.
* CodeCoverage/glass.png: Removed.
* CodeCoverage/regenerate-coverage-display: Removed.
* CodeCoverage/ruby.png: Removed.
* CodeCoverage/run-generate-coverage-data: Removed.
* CodeCoverage/snow.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse HTMLElementFactory to create equivalent elements in WebVTTElement
rniwa@webkit.org [Tue, 11 Jun 2013 21:18:55 +0000 (21:18 +0000)]
Use HTMLElementFactory to create equivalent elements in WebVTTElement
https://bugs.webkit.org/show_bug.cgi?id=117423

Reviewed by Eric Carlson.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/3d60bec8e5dabfe877c482797d9ef430bfde31

This change forces the calls through the factory so that we create appropriate sub-classes based upon the passed tag name,
rather than just creating a concrete HTMLElement class with an inappropriate tag name.

Test: media/track/getCueAsHTMLCrash.html

* html/track/WebVTTElement.cpp:
(WebCore::WebVTTElement::createEquivalentHTMLElement):

LayoutTests:

* media/track/getCueAsHTMLCrash-expected.txt: Added.
* media/track/getCueAsHTMLCrash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSplit SelectorDataList::executeSingleTagNameSelectorData() into the 4 kinds of traversal
benjamin@webkit.org [Tue, 11 Jun 2013 21:09:33 +0000 (21:09 +0000)]
Split SelectorDataList::executeSingleTagNameSelectorData() into the 4 kinds of traversal
https://bugs.webkit.org/show_bug.cgi?id=117486

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-11
Reviewed by Ryosuke Niwa.

Since this is pretty common, split the name selector to have the constant conditions
outside the traversal.

* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeSingleTagNameSelectorData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Update text track menu
eric.carlson@apple.com [Tue, 11 Jun 2013 20:55:02 +0000 (20:55 +0000)]
[Mac] Update text track menu
https://bugs.webkit.org/show_bug.cgi?id=117351

Reviewed by Darin Adler.

Source/WebCore:

No new tests, existing tests updated.

* English.lproj/Localizable.strings: Update the menu title.

* page/CaptionUserPreferencesMac.mm: System language is no longer needed.

* platform/LocalizedStrings.cpp: Ditto.
* platform/LocalizedStrings.h:

LayoutTests:

* media/video-controls-captions-trackmenu-localized.html:
* media/video-controls-captions-trackmenu-sorted.html:
* platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt:
* platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
* platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the element type in the selector checkers
benjamin@webkit.org [Tue, 11 Jun 2013 20:43:38 +0000 (20:43 +0000)]
Fix the element type in the selector checkers
https://bugs.webkit.org/show_bug.cgi?id=117450

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-11
Reviewed by Anders Carlsson.

* css/SelectorCheckerFastPath.cpp:
(WebCore::HTMLNames::checkClassValue):
* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeSingleClassNameSelectorData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up the initializer mess in Document
benjamin@webkit.org [Tue, 11 Jun 2013 20:40:32 +0000 (20:40 +0000)]
Clean up the initializer mess in Document
https://bugs.webkit.org/show_bug.cgi?id=117448

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-11
Reviewed by Ryosuke Niwa.

Basic cleaning from
https://chromium.googlesource.com/chromium/blink/+/e54ba8d3b62b0245ecdf2f3ec11cd33b4035a4d7

* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHave build-webkit build the WebInspectorUI project.
timothy@apple.com [Tue, 11 Jun 2013 20:39:44 +0000 (20:39 +0000)]
Have build-webkit build the WebInspectorUI project.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r151408.
commit-queue@webkit.org [Tue, 11 Jun 2013 20:12:02 +0000 (20:12 +0000)]
Unreviewed, rolling out r151408.
http://trac.webkit.org/changeset/151408
https://bugs.webkit.org/show_bug.cgi?id=117519

Opting for a different approach (Requested by rfong on
#webkit).

* win/WinTools.make: Removed.
* win/tools32/WinTools.make: Renamed from WebKitLibraries/win/tools64/WinTools.make.
* win/tools64/scripts/COPYRIGHT-END-YEAR: Removed.
* win/tools64/scripts/VERSION: Removed.
* win/tools64/scripts/auto-version.sh: Removed.
* win/tools64/scripts/feature-defines.sh: Removed.
* win/tools64/vsprops/FeatureDefines.props: Removed.
* win/tools64/vsprops/FeatureDefines.vsprops: Removed.
* win/tools64/vsprops/FeatureDefinesCairo.props: Removed.
* win/tools64/vsprops/FeatureDefinesCairo.vsprops: Removed.
* win/tools64/vsprops/WinCairo.props: Removed.
* win/tools64/vsprops/WinCairo.vsprops: Removed.
* win/tools64/vsprops/cURL.props: Removed.
* win/tools64/vsprops/cURL.vsprops: Removed.
* win/tools64/vsprops/common.props: Removed.
* win/tools64/vsprops/common.vsprops: Removed.
* win/tools64/vsprops/debug.props: Removed.
* win/tools64/vsprops/debug.vsprops: Removed.
* win/tools64/vsprops/debug_all.vsprops: Removed.
* win/tools64/vsprops/debug_wincairo.props: Removed.
* win/tools64/vsprops/debug_wincairo.vsprops: Removed.
* win/tools64/vsprops/debugsuffix.props: Removed.
* win/tools64/vsprops/production.props: Removed.
* win/tools64/vsprops/production.vsprops: Removed.
* win/tools64/vsprops/release.props: Removed.
* win/tools64/vsprops/release.vsprops: Removed.
* win/tools64/vsprops/releaseproduction.vsprops: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline results after r151451
robert@webkit.org [Tue, 11 Jun 2013 20:08:03 +0000 (20:08 +0000)]
Rebaseline results after r151451

Unreviewed, gardening.

* platform/efl/fast/forms/button-positioned-expected.txt:
* platform/efl/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/efl/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* platform/gtk/fast/forms/button-positioned-expected.txt:
* platform/gtk/fast/forms/input-appearance-preventDefault-expected.png:
* platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/gtk/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* platform/win/fast/forms/onselect-textfield-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd an option to run-webkit-tests to skip java dependency check
rniwa@webkit.org [Tue, 11 Jun 2013 20:03:08 +0000 (20:03 +0000)]
Add an option to run-webkit-tests to skip java dependency check
https://bugs.webkit.org/show_bug.cgi?id=117516

Reviewed by Andreas Kling.

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/port/mac.py:
(MacPort._check_port_build):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=117514
achristensen@apple.com [Tue, 11 Jun 2013 20:02:03 +0000 (20:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=117514
Removed extra Xcode code coverage flags.

Reviewed by Sam Weinig.

* Scripts/webkitdirs.pm:
(XcodeCoverageSupportOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSet the font size for in-band captions on the display box, not the :cue.
jer.noble@apple.com [Tue, 11 Jun 2013 19:58:28 +0000 (19:58 +0000)]
Set the font size for in-band captions on the display box, not the :cue.
https://bugs.webkit.org/show_bug.cgi?id=117515

Reviewed by Eric Carlson.

Make the in-band font size behavior match the out-of-band behavior.

* html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::setFontSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [Windows] Implement 'attributeValue' accessor to support testing.
bfulgham@apple.com [Tue, 11 Jun 2013 19:53:06 +0000 (19:53 +0000)]
Source/WebCore: [Windows] Implement 'attributeValue' accessor to support testing.
https://bugs.webkit.org/show_bug.cgi?id=117513

Reviewed by Anders Carlsson.

* WebCore.vcxproj/WebCore.vcxproj: Add new implementation file.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* accessibility/win/AccessibilityObjectWrapperWin.cpp: Added.
* accessibility/win/AccessibilityObjectWrapperWin.h: Add declaration

Source/WebKit/win: [Windows] Implement 'attributeValue' accessor to support testing.
https://bugs.webkit.org/show_bug.cgi?id=117513

Reviewed by Anders Carlsson.

* AccessibleBase.cpp:
(AccessibleBase::attributeValue): Added.
* AccessibleBase.h: Added method declaration.
* Interfaces/AccessibleComparable.idl: New accessor interface.

Tools: [Windows] Implement 'attributeValue' accessor to support testing
https://bugs.webkit.org/show_bug.cgi?id=117513

Reviewed by Anders Carlsson.

* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(comparableObject): Move earlier in file.
(findAccessibleObjectById): New implemenation.
(AccessibilityController::accessibleElementById): New implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening. Rebaselining various tests that are at the moment failing...
zandobersek@gmail.com [Tue, 11 Jun 2013 19:49:40 +0000 (19:49 +0000)]
Unreviewed GTK gardening. Rebaselining various tests that are at the moment failing and need the new baseline.

* platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-019-expected.txt:
* platform/gtk/editing/deleting/delete-block-merge-contents-020-expected.txt:
* platform/gtk/editing/pasteboard/4944770-2-expected.txt:
* platform/gtk/editing/pasteboard/8145-2-expected.txt:
* platform/gtk/editing/pasteboard/paste-line-endings-006-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
* platform/gtk/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
* platform/gtk/editing/pasteboard/paste-xml-expected.txt:
* platform/gtk/http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd WebInspectorUI to the Makefile.
timothy@apple.com [Tue, 11 Jun 2013 19:17:00 +0000 (19:17 +0000)]
Add WebInspectorUI to the Makefile.

Reviewed by Mark Rowe.

* Source/Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate the framework bundle identifier for the Web Inspector.
timothy@apple.com [Tue, 11 Jun 2013 19:16:51 +0000 (19:16 +0000)]
Update the framework bundle identifier for the Web Inspector.

Reviewed by Mark Rowe.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):
(WebInspectorFrontendClient::localizedStringsURL):
(-[WebInspectorWindowController inspectorPagePath]):

Source/WebKit2:

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
* WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspector::localizedStringsURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOpen Source the Safari Web Inspector back to WebKit.
timothy@apple.com [Tue, 11 Jun 2013 19:16:26 +0000 (19:16 +0000)]
Open Source the Safari Web Inspector back to WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPositioned Replaced Elements That Aren't RenderReplaced get Incorrect Width
robert@webkit.org [Tue, 11 Jun 2013 19:03:09 +0000 (19:03 +0000)]
Positioned Replaced Elements That Aren't RenderReplaced get Incorrect Width
https://bugs.webkit.org/show_bug.cgi?id=93735

Reviewed by Darin Adler.

Source/WebCore:

Replaced elements that aren't RenderReplaced aren't |isReplaced| and don't have an
intrinsic height or width. This causes them to go down the wrong height and width computation
path in RenderBox when they are absolute positioned.

The notion of |isReplaced| is entwined with the notion of being |isInline| so it isn't really
possible to make them isReplaced without re-wiring a lot of code. So instead use an ad-hoc definition
of isReplacedElement in RenderBox to bring all replaced elements into the height and width calculation.
To make sure we get the right height and width in there, give non-RenderReplaced replaced renderers
the helpers for returning their approximation of intrinsic height and width.

Test: fast/replaced/width-and-height-of-positioned-replaced-elements.html

* rendering/RenderBox.cpp:
(WebCore::isReplacedElement):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::intrinsicSize):
* rendering/RenderButton.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::computeLogicalHeight):
* rendering/RenderListBox.h:
* rendering/RenderMenuList.h:
* rendering/RenderReplaced.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::computeLogicalHeight):
* rendering/RenderTextControl.h:

LayoutTests:

* fast/forms/onselect-textfield-expected.txt:
* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* fast/replaced/width-and-height-of-positioned-replaced-elements.html: Added.
* platform/mac-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* platform/mac/fast/forms/button-positioned-expected.txt:
* platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* platform/qt/fast/forms/button-positioned-expected.txt:
* platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThere are unused variables in ApplyStyleCommand::mergeEndWithNextIfIdentical and...
rniwa@webkit.org [Tue, 11 Jun 2013 18:48:59 +0000 (18:48 +0000)]
There are unused variables in ApplyStyleCommand::mergeEndWithNextIfIdentical and ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds
https://bugs.webkit.org/show_bug.cgi?id=117475

Reviewed by Andreas Kling.

Removed.

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd baselines for test added in r151444
robert@webkit.org [Tue, 11 Jun 2013 18:48:44 +0000 (18:48 +0000)]
Add baselines for test added in r151444

Unreviewed.

* platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
* platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDo not filter cookies requested through the CookieStorageShim.
jer.noble@apple.com [Tue, 11 Jun 2013 18:48:08 +0000 (18:48 +0000)]
Do not filter cookies requested through the CookieStorageShim.
https://bugs.webkit.org/show_bug.cgi?id=117511
<rdar://problem/13603433>

Reviewed by Beth Dakin.

Since the shim function is called when the underlying media engine is
creating an HTTPRequest, use CookieRequestHeaderFieldValue (which does
not filter out HTTP-only cookies) rather than CookiesForDOM (which does).

* Shared/mac/CookieStorageShim.cpp:
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix typo in r151445
robert@webkit.org [Tue, 11 Jun 2013 18:33:36 +0000 (18:33 +0000)]
Fix typo in r151445

Unreviewed build fix.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove redundant calls to ceilToFloat in RenderBlock::computeInlinePreferredLogicalWidths
rniwa@webkit.org [Tue, 11 Jun 2013 18:22:28 +0000 (18:22 +0000)]
Remove redundant calls to ceilToFloat in RenderBlock::computeInlinePreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=117490

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/be336b14325b2938ff6a4fb6191073a6e717a57c.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPainting collapsed borders during scrolling
robert@webkit.org [Tue, 11 Jun 2013 18:11:31 +0000 (18:11 +0000)]
Painting collapsed borders during scrolling
https://bugs.webkit.org/show_bug.cgi?id=85658

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/repaint/table-cell-collapsed-border-scroll.html

WHen painting collapsed borders we need to paint the borders of the row above
the topmost dirtied row so that we compute the correct value for the dirtied row's collapsed border.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):

LayoutTests:

* fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
* fast/repaint/table-cell-collapsed-border-scroll.html: Added.
* platform/qt/fast/repaint/table-cell-collapsed-border-scroll-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[curl] Custom HTTP method support
ossy@webkit.org [Tue, 11 Jun 2013 16:37:14 +0000 (16:37 +0000)]
[curl] Custom HTTP method support
https://bugs.webkit.org/show_bug.cgi?id=117302

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-11
Reviewed by Kenneth Rohde Christiansen.

No new tests, already covered by existing ones like:
http/tests/xmlhttprequest/workers/methods.html
http/tests/xmlhttprequest/workers/methods-async.html

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::initializeHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Provide MSAA mappings for more WebCore roles.
bfulgham@apple.com [Tue, 11 Jun 2013 15:32:18 +0000 (15:32 +0000)]
[Windows] Provide MSAA mappings for more WebCore roles.
https://bugs.webkit.org/show_bug.cgi?id=117389

Reviewed by Chris Fleizach.

* AccessibleBase.cpp:
(MSAARole): Add additional mappings between WebCore roles and MSAA roles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove leftover wxWebkit code
commit-queue@webkit.org [Tue, 11 Jun 2013 15:14:59 +0000 (15:14 +0000)]
Remove leftover wxWebkit code
https://bugs.webkit.org/show_bug.cgi?id=117471

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-06-11
Reviewed by Andreas Kling.

.:

* Source/cmake/WebKitPackaging.cmake:

Source/WebKit2:

* Scripts/generate-forwarding-headers.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoediting/undo/undo-after-event-edited.html can be flaky
rniwa@webkit.org [Tue, 11 Jun 2013 15:09:18 +0000 (15:09 +0000)]
editing/undo/undo-after-event-edited.html can be flaky
https://bugs.webkit.org/show_bug.cgi?id=117461

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/515de860730b34289df5805b40adb2535a9a8ba1

* editing/undo/undo-after-event-edited.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Remove 'using namespace std'
commit-queue@webkit.org [Tue, 11 Jun 2013 15:06:16 +0000 (15:06 +0000)]
Web Inspector: Remove 'using namespace std'
https://bugs.webkit.org/show_bug.cgi?id=117498

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-06-11
Reviewed by Anders Carlsson.

No new tests, no behavior change.

* inspector/InspectorAgent.cpp: Remove unneeded 'using namespace std'.
* inspector/InspectorFrontendClientLocal.cpp: Use explicit std:: qualifiers instead.
(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowWidth):
* inspector/InspectorFrontendHost.cpp: Remove unneeded 'using namespace std'.
* inspector/InspectorPageAgent.cpp: Remove unneeded 'using namespace std'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Unskipping passing tests. Generate new baseline where...
zarvai@inf.u-szeged.hu [Tue, 11 Jun 2013 14:42:57 +0000 (14:42 +0000)]
[Qt] Unreviewed gardening. Unskipping passing tests. Generate new baseline where needed.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-11

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/fast/images/paletted-png-with-color-profile-expected.png: Added.
* platform/qt-5.0-wk2/fast/images/paletted-png-with-color-profile-expected.txt: Added.
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport latest Web IDL named property getters
ch.dumez@sisa.samsung.com [Tue, 11 Jun 2013 13:04:10 +0000 (13:04 +0000)]
Support latest Web IDL named property getters
https://bugs.webkit.org/show_bug.cgi?id=117403

Reviewed by Kentaro Hara.

Add support for the latest Web IDL named property getters to the JSC
bindings generator:
http://www.w3.org/TR/WebIDL/#idl-named-properties

Drop support for outdated [NamedGetter] IDL extended attribute.

Support for other kinds of named properties will be added in later
patches. This patch only brings named property getters.

This patch is based on Blink r149247 by kojih@chromium.org.

No new tests, no behavior change.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GetSpecialAccessorFunctionForType):
(GetNamedGetterFunction):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/IDLParser.pm:
(applyTypedefs):
(parseSpecialOperation):
(parseSpecials):
(applyMemberList):
* bindings/scripts/test/TestEventTarget.idl:
* css/StyleSheetList.idl:
* dom/DOMNamedFlowCollection.idl:
* dom/DOMStringMap.idl:
* dom/NamedNodeMap.idl:
* dom/NodeList.idl:
* html/HTMLAllCollection.idl:
* html/HTMLCollection.idl:
* html/HTMLFormControlsCollection.idl:
* html/HTMLPropertiesCollection.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:
* storage/Storage.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Add fallback for EWK2UnitTestBase if opengl is not available.
commit-queue@webkit.org [Tue, 11 Jun 2013 12:12:31 +0000 (12:12 +0000)]
[EFL][WK2] Add fallback for EWK2UnitTestBase if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=117504

Patch by Changhyup Jwa <ch.jwa@samsung.com> on 2013-06-11
Reviewed by Christophe Dumez.

There're many fails on efl webkit2 unit test if opengl is not available.
So, add fallback to non-opengl evas engine.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][EFL][GTK]fast/regions/overflow-size-change-with-stacking-context-rtl.html fails...
mihnea@adobe.com [Tue, 11 Jun 2013 08:48:10 +0000 (08:48 +0000)]
[Qt][EFL][GTK]fast/regions/overflow-size-change-with-stacking-context-rtl.html fails after r151202
https://bugs.webkit.org/show_bug.cgi?id=117295

Reviewed by Alexandru Chiculita.

Both test specify margins auto, which means that they can be computed to floats.
I changed the tests so that the margins are computed to integer values, to avoid
possible differences on platforms that enable subpixel layout.

* fast/regions/overflow-size-change-with-stacking-context-rtl-expected.html:
* fast/regions/overflow-size-change-with-stacking-context-rtl.html:
* platform/qt/TestExpectations: Unskip the skipped test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake WTR use its own temporary directory for application cache
ossy@webkit.org [Tue, 11 Jun 2013 08:39:57 +0000 (08:39 +0000)]
Make WTR use its own temporary directory for application cache
https://bugs.webkit.org/show_bug.cgi?id=117143

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

* UIProcess/API/C/WKContext.cpp:
(WKContextSetApplicationCacheDirectory):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::applicationCacheDirectory):
* UIProcess/WebContext.h:
(WebKit::WebContext::setApplicationCacheDirectory):
* UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Fix test_ewk2_context_menu
commit-queue@webkit.org [Tue, 11 Jun 2013 08:35:48 +0000 (08:35 +0000)]
[EFL][WK2] Fix test_ewk2_context_menu
https://bugs.webkit.org/show_bug.cgi?id=116601

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-06-11
Reviewed by Gyuyoung Kim.

test_ewk2_context_menu is always passing, it does not test any context menu feature
as it ends before context menu is called.
One single test was divided into two tests: testing WebKit2 created context menu and
testing menus and items created by application.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTrue): added function introducing internal loop until boolean value is changed to true
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
* UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
(customItemSelected):
(showContextMenu):
(showContextMenuForRemoveAndAppend):
(showContextMenuForSubmenu):
(hideContextMenu):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] Add ewk_view_navigate API
ryuan.choi@samsung.com [Tue, 11 Jun 2013 08:10:24 +0000 (08:10 +0000)]
[EFL][WK2] Add ewk_view_navigate API
https://bugs.webkit.org/show_bug.cgi?id=117467

Reviewed by Christophe Dumez.

The applications will use this API to navigate history more than one step.

* UIProcess/API/efl/ewk_back_forward_list_item_private.h:
(EwkBackForwardListItem::wkItem): Return WKBackForwardListItemRef for page to navigate.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_navigate_to): Added new API.
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F): Added more test case for navigation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Test editing/execCommand/indent-paragraphs.html times out
commit-queue@webkit.org [Tue, 11 Jun 2013 07:57:49 +0000 (07:57 +0000)]
[BlackBerry] Test editing/execCommand/indent-paragraphs.html times out
https://bugs.webkit.org/show_bug.cgi?id=117235

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-06-11
Reviewed by Rob Buis.

PR 346414.

After r150224 ResourceHandle::start() can fail returning false so
that the ResourceHandle is destroyed and the error not
handled. Handle the errors by scheduling a InvalidURLFailure and
returning true when startJob fails to make sure the ResourceHandle
is not destroyed and the error is handled and notified to the
client.

Fixes timeout in editing/execCommand/indent-paragraphs.html.

* platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove IntRect::pixelSnapped* and its enclosingRect since they are no longer used
rniwa@webkit.org [Tue, 11 Jun 2013 07:34:42 +0000 (07:34 +0000)]
Remove IntRect::pixelSnapped* and its enclosingRect since they are no longer used
https://bugs.webkit.org/show_bug.cgi?id=117494

Reviewed by Darin Adler.

Merge: https://chromium.googlesource.com/chromium/blink/+/9433dc00e882e2808ac1db3c1fd89090896d7b58
       https://chromium.googlesource.com/chromium/blink/+/7beaa73aa099170cb2cad02c12c5e0a448b12c21

* inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
* platform/graphics/IntRect.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::hitTestCulledInline):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAutoclose braces and parentheses at the end of style sheet
sergio@webkit.org [Tue, 11 Jun 2013 07:10:00 +0000 (07:10 +0000)]
Autoclose braces and parentheses at the end of style sheet
https://bugs.webkit.org/show_bug.cgi?id=117414

Reviewed by Andreas Kling.

From Blink r150202 by <serya@chromium.org>

Source/WebCore:

Use closing_parenthesis and closing_brace instead of the literals
'}' and ')'. This allows the parser to treat expressions with
unmatched closing braces/parenthesis as if all of them were
actually closed.

Tests: animations/keyframe-autoclose-brace.html
       css3/autoclose-braces-and-parentheses.html

* css/CSSGrammar.y.in:

LayoutTests:

* animations/keyframe-autoclose-brace-expected.txt: Added.
* animations/keyframe-autoclose-brace.html: Added.
* css3/autoclose-braces-and-parentheses-expected.txt: Added.
* css3/autoclose-braces-and-parentheses.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151424 268f45cc-cd09-0410-ab3c-d52691b4dbfc