WebKit-https.git
15 years ago <rdar://problem/5453494> Better lifetime management of WebDataSource and...
adachan [Fri, 7 Sep 2007 17:27:23 +0000 (17:27 +0000)]
    <rdar://problem/5453494> Better lifetime management of WebDataSource and WebDocumentLoader
        The problem was that WebDataSource does not hold a strong reference to the WebDocumentLoader.  If
        a WebDataSource is still around after the loader has been destroyed, it'll just point to
        a stale WebDocumentLoader.
        To fix this without a circular reference, WebDataSource now holds a strong reference to the
        WebDocumentLoader.  The WebDocumentLoader holds a strong reference to the WebDataSource
        until it's detached from the WebFrame.  When the WebDataSource is destroyed, it'll notify
        its WebDocumentLoader so the loader will clear any references to it.

        Reviewed by Darin.

        * WebDataSource.cpp:
        (WebDataSource::~WebDataSource): call WebDocumentLoader::detachDataSource() so the loader
        will clear any references to this data source
        (WebDataSource::documentLoader): m_loader is now a RefPtr so we need to call get().
        * WebDataSource.h:
        * WebDocumentLoader.cpp:
        (WebDocumentLoader::WebDocumentLoader): initialize m_dataSource since it's no longer a COMPtr.
        (WebDocumentLoader::~WebDocumentLoader): release m_dataSource if necessary
        (WebDocumentLoader::setDataSource): add a reference to m_dataSource
        (WebDocumentLoader::dataSource):
        (WebDocumentLoader::detachDataSource): clear m_detachedDataSource.
        (WebDocumentLoader::attachToFrame): call setDataSource() so it'll add the reference to the data source if necessary.
        (WebDocumentLoader::detachFromFrame): release the reference to the data source
        * WebDocumentLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin McCullough.
weinig [Fri, 7 Sep 2007 17:21:07 +0000 (17:21 +0000)]
    Reviewed by Kevin McCullough.

        Fix embarassing spelling mistakes.

        * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe-expected.txt.
        * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe.html.
        * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open-expected.txt.
        * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html: Copied from http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open.html.
        * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe-expected.txt: Removed.
        * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-subframe.html: Removed.
        * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open-expected.txt: Removed.
        * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foriegn-domain-window-open.html: Removed.
        * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-expected.txt.
        * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change-expected.txt.
        * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html.
        * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html.
        * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open-expected.txt.
        * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html: Copied from http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open.html.
        * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-expected.txt: Removed.
        * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change-expected.txt: Removed.
        * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe-location-change.html: Removed.
        * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-subframe.html: Removed.
        * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open-expected.txt: Removed.
        * http/tests/security/dataURL/xss-DENIED-to-data-url-in-foriegn-domain-window-open.html: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-subframe-expected.txt.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe.html: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-subframe.html.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-window-open-expected.txt.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open.html: Copied from http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-window-open.html.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-subframe-expected.txt: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-subframe.html: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-window-open-expected.txt: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foriegn-domain-window-open.html: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-subframe-expected.txt.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe.html: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-subframe.html.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-window-open-expected.txt.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open.html: Copied from http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-window-open.html.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-subframe-expected.txt: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-subframe.html: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-window-open-expected.txt: Removed.
        * http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foriegn-domain-window-open.html: Removed.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
kmccullo [Fri, 7 Sep 2007 16:52:45 +0000 (16:52 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        - Moved JSRetainPtr to the API.

        * API/JSRetainPtr.h: Copied from kjs/JSRetainPtr.h.
        (JSRetain):
        (JSRelease):
        (JSRetainPtr::JSRetainPtr):
        (JSRetainPtr::~JSRetainPtr):
        (JSRetainPtr::get):
        (JSRetainPtr::releaseRef):
        (JSRetainPtr::operator->):
        (JSRetainPtr::operator!):
        (JSRetainPtr::operator UnspecifiedBoolType):
        (::operator):
        (::adopt):
        (::swap):
        (swap):
        (operator==):
        (operator!=):
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/JSRetainPtr.h: Removed.

WebKitTools:

        Reviewed by Maciej.

        - Changed Drosera to take advantage of the JSRetainPtr changes.

        * Drosera/DebuggerDocument.cpp:
        (DebuggerDocument::breakpointEditorHTML):
        (DebuggerDocument::evaluateScript):
        (DebuggerDocument::valueForScopeVariableNamed):
        (DebuggerDocument::log):
        (DebuggerDocument::windowScriptObjectAvailable):
        (DebuggerDocument::toJSArray):
        (DebuggerDocument::callFunctionOnObject):
        (DebuggerDocument::logException):
        * Drosera/mac/DebuggerDocumentMac.mm:
        (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
        (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
        (DebuggerDocument::platformEvaluateScript):
        (DebuggerDocument::getPlatformCurrentFunctionStack):
        (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
        (DebuggerDocument::platformValueForScopeVariableNamed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix typo in previous commit
staikos [Fri, 7 Sep 2007 16:29:49 +0000 (16:29 +0000)]
Fix typo in previous commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoPatch from Qing Zhao to export more of the progress details and expose it from
staikos [Fri, 7 Sep 2007 14:49:02 +0000 (14:49 +0000)]
Patch from Qing Zhao to export more of the progress details and expose it from
QWebPage

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
tristan [Fri, 7 Sep 2007 03:48:39 +0000 (03:48 +0000)]
WebCore:

        Reviewed by Maciej Stachowiak.

        <rdar://problem/5333496> Back button stopped working on sfgate.com (14957)

        This fix is specifically targted to address sfgate.com and reuters.com with minimal
        impact to other areas of the frameloader.  It does not cause any regression tests to fail.
        I've added two layout tests: One to detect this particular bug, and one to address
        a secondary issue: if an iframe navigation occurs during onload by a timeout an
        additional history item is added, similarly to firefox.  We tried to match firefox
        more than IE with this fix but did gain a little bit of IE compatability.

        Tests: http/tests/navigation/onload-navigation-iframe-timeout.html
               http/tests/navigation/onload-navigation-iframe.html

        * dom/Document.h:
        (WebCore::Document::processingLoadEvent):
        Return the m_processingLoadEvent boolean so FrameLoader knows
        that the document is in the middle of calling <body onload>

        * html/HTMLFrameOwnerElement.cpp:
        (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
        * html/HTMLFrameOwnerElement.h:
        (WebCore::HTMLFrameOwnerElement::createdByParser):
        (WebCore::HTMLFrameOwnerElement::setCreatedByParser):
        Added support for a new member variable of frame elements: m_createdByParser.
        This lets us specifically target the fix to only iframes created via JS
        and not in-document.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        Initialize m_navigationDuringLoad to false

        (WebCore::FrameLoader::provisionalLoadStarted):
        Determine if the load we're about to start is occuring during
        an onload.

        (WebCore::FrameLoader::updateHistoryForStandardLoad):
        If the current frameloader is for a child frame, and the navigation is occuring
        during an onload update the current history item rather than adding a new one.

        * loader/FrameLoader.h:
        Added a new member variable, m_navigationDuringLoad to track
        the navigation status during the on load, rather than trying to determine
        the status after (which is nearly impossible due to a new runloop spin).

LayoutTests:

        Reviewed by Maciej Stachowiak.

        * http/tests/navigation/onload-navigation-iframe-expected.txt: Added.
        * http/tests/navigation/onload-navigation-iframe-timeout-expected.txt: Added.
        * http/tests/navigation/onload-navigation-iframe-timeout.html: Added.
        * http/tests/navigation/onload-navigation-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
mjs [Fri, 7 Sep 2007 02:53:23 +0000 (02:53 +0000)]
    Reviewed by Darin.

        - Remove single-threaded optimization for FastMalloc.

        It does not appear to help anywhere but Mac OS X on PPC, due to
        pthread_getspecific being slow there. On Intel, removing the
        optimization results in a ~1.5% PLT speedup, a ~1-5% JS iBench
        speedup, and a ~1.5% HTML iBench speedup. On PPC this change is a
        speedup on some benchmarks, a slight hit on others.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/collector.cpp:
        (KJS::Collector::registerThread):
        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_ThreadCache::GetCache):
        (WTF::TCMalloc_ThreadCache::GetCacheIfPresent):
        (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
        (WTF::do_malloc):
        * wtf/FastMallocInternal.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin McCullough.
weinig [Fri, 7 Sep 2007 02:02:21 +0000 (02:02 +0000)]
    Reviewed by Kevin McCullough.

        Update the Windows skiplist with the current failing tests.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBump version for submit
sfalken [Fri, 7 Sep 2007 00:14:14 +0000 (00:14 +0000)]
Bump version for submit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ddkilzer [Thu, 6 Sep 2007 22:38:34 +0000 (22:38 +0000)]
WebCore:

        Reviewed by Darin.

        The implementation of BackForwardList::clearPageCache() was removed in r21793.
        It's now safe to remove it from the header.

        * history/BackForwardList.h: Removed clearPageCache().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoEven better build fix.
thatcher [Thu, 6 Sep 2007 22:34:10 +0000 (22:34 +0000)]
Even better build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBetter build fix.
thatcher [Thu, 6 Sep 2007 22:17:59 +0000 (22:17 +0000)]
Better build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix.
thatcher [Thu, 6 Sep 2007 22:15:30 +0000 (22:15 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Ada.
andersca [Thu, 6 Sep 2007 21:28:05 +0000 (21:28 +0000)]
    Reviewed by Ada.

        <rdar://problem/5457844>
        Crash when using mouse wheel with plug-ins disabled.

        Null check the widget.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
andersca [Thu, 6 Sep 2007 21:15:32 +0000 (21:15 +0000)]
    Reviewed by Mitz.

        Small tweak.

        * plugins/win/PluginStreamWin.cpp:
        (WebCore::PluginStreamWin::startStream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
andersca [Thu, 6 Sep 2007 21:12:06 +0000 (21:12 +0000)]
    Reviewed by Mitz.

        Re-enable and the npapi-response-headers.html test so it no longer
        relies on the ordering of the requests being made.

        * http/tests/plugins/npapi-response-headers-expected.txt:
        * http/tests/plugins/npapi-response-headers.html: Copied from http/tests/plugins/npapi-response-headers.html.disabled.
        * http/tests/plugins/npapi-response-headers.html.disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam and Steve.
andersca [Thu, 6 Sep 2007 21:04:15 +0000 (21:04 +0000)]
    Reviewed by Adam and Steve.

        <rdar://problem/5459321>
        ADOBE: Safari 3 on Windows is passing bogus values in stream->headers in NPP_NewStream, causing Flash Player to crash.

        Serialize the headers into a stream and pass it to NPP_NewStream in stream->headers.

        * plugins/win/PluginStreamWin.cpp:
        (WebCore::PluginStreamWin::startStream):
        * plugins/win/PluginStreamWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
darin [Thu, 6 Sep 2007 20:57:57 +0000 (20:57 +0000)]
    Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15153
          REGRESSION: Assertion failure in FrameView::scheduleRelayout() (m_frame->view() == this)

        Back out the willRemove() part of the previous patch.
        It was incorrect and not needed to fix the bug anyway.

        * dom/Document.cpp: (WebCore::Document::detach): Remove willRemove().

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Put the willRemove() call
        back here where it was originally before the previous fix.

        * history/CachedPage.cpp: (WebCore::CachedPage::clear):
        * page/Frame.cpp:
        (WebCore::Frame::setView):
        (WebCore::Frame::setDocument):
        Added FIXMEs about the fact that we call detach() on the document but not willRemove().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
thatcher [Thu, 6 Sep 2007 20:43:50 +0000 (20:43 +0000)]
WebCore:

        Reviewed by Darin.

        Changed the blocked exception log message to match AppKit's blocked exception message.

        * platform/mac/BlockExceptions.mm:
        (ReportBlockedObjCException):

WebKit:

        Reviewed by Darin.

        <rdar://problem/5443883> Uncaught Objective-C exceptions in WebKit clients lead to hard-to-diagnose crashes

        Changed all the direct delegate calls to use helper functions that have direct access to
        WebView's delegate objects. These helper methods will catch any ObjC exceptions and call
        ReportDiscardedDelegateException to log the discarded exception. WebView's that have
        catchesDelegateExceptions set to NO will not pay the cost of a @try/@catch. The delegate
        forwarders also have the same behavior.

        * Misc/WebKitLogging.h:
        * Misc/WebKitLogging.m:
        (ReportDiscardedDelegateException):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadPluginRequest:]):
        * Plugins/WebNullPluginView.mm:
        (-[WebNullPluginView viewDidMoveToWindow]):
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::createWindow):
        (WebChromeClient::createModalDialog):
        (WebChromeClient::runModal):
        (WebChromeClient::toolbarsVisible):
        (WebChromeClient::statusbarVisible):
        (WebChromeClient::addMessageToConsole):
        (WebChromeClient::canRunBeforeUnloadConfirmPanel):
        (WebChromeClient::runBeforeUnloadConfirmPanel):
        (WebChromeClient::runJavaScriptAlert):
        (WebChromeClient::runJavaScriptConfirm):
        (WebChromeClient::runJavaScriptPrompt):
        (WebChromeClient::shouldInterruptJavaScript):
        (WebChromeClient::setStatusbarText):
        (WebChromeClient::print):
        * WebCoreSupport/WebContextMenuClient.mm:
        (WebContextMenuClient::getCustomMenuFromDefaultItems):
        (WebContextMenuClient::contextMenuItemSelected):
        * WebCoreSupport/WebDragClient.mm:
        (WebDragClient::startDrag):
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::textFieldDidBeginEditing):
        (WebEditorClient::textFieldDidEndEditing):
        (WebEditorClient::textDidChangeInTextField):
        (WebEditorClient::doTextFieldCommandFromEvent):
        (WebEditorClient::textWillBeDeletedInTextField):
        (WebEditorClient::textDidChangeInTextArea):
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge viewForPluginWithFrame:URL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
        (WebFrameLoaderClient::assignIdentifierToInitialRequest):
        (WebFrameLoaderClient::dispatchWillSendRequest):
        (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
        (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
        (WebFrameLoaderClient::dispatchDidReceiveResponse):
        (WebFrameLoaderClient::willCacheResponse):
        (WebFrameLoaderClient::dispatchDidReceiveContentLength):
        (WebFrameLoaderClient::dispatchDidFinishLoading):
        (WebFrameLoaderClient::dispatchDidFailLoading):
        (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
        (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
        (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
        (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
        (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebFrameLoaderClient::dispatchWillClose):
        (WebFrameLoaderClient::dispatchDidReceiveIcon):
        (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
        (WebFrameLoaderClient::dispatchDidReceiveTitle):
        (WebFrameLoaderClient::dispatchDidCommitLoad):
        (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
        (WebFrameLoaderClient::dispatchDidFailLoad):
        (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
        (WebFrameLoaderClient::dispatchDidFinishLoad):
        (WebFrameLoaderClient::dispatchDidFirstLayout):
        (WebFrameLoaderClient::dispatchCreatePage):
        (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
        (WebFrameLoaderClient::dispatchWillSubmitForm):
        (WebFrameLoaderClient::dispatchDidLoadMainResource):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView callDelegateDoCommandBySelectorIfNeeded:]):
        (-[WebHTMLView validateUserInterfaceItem:]):
        * WebView/WebPDFView.mm:
        (-[WebPDFView validateUserInterfaceItem:]):
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        * WebView/WebView.mm:
        (-[WebView _openNewWindowWithRequest:]):
        (-[WebView _menuForElement:defaultItems:]):
        (-[WebView _mouseDidMoveOverElement:modifierFlags:]):
        (-[WebView _cacheResourceLoadDelegateImplementations]):
        (-[WebView _cacheFrameLoadDelegateImplementations]):
        (-[WebView _policyDelegateForwarder]):
        (-[WebView _UIDelegateForwarder]):
        (-[WebView _editingDelegateForwarder]):
        (-[WebView _scriptDebugDelegateForwarder]):
        (-[WebView _setCatchesDelegateExceptions:]):
        (-[WebView _catchesDelegateExceptions]):
        (-[_WebSafeForwarder initWithTarget:defaultTarget:]):
        (-[_WebSafeForwarder forwardInvocation:]):
        (-[_WebSafeForwarder methodSignatureForSelector:]):
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        (-[WebView validateUserInterfaceItem:]):
        (-[WebView _headerHeight]):
        (-[WebView _footerHeight]):
        (-[WebView _drawHeaderInRect:]):
        (-[WebView _drawFooterInRect:]):
        (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
        (CallDelegate):
        (CallDelegateReturningFloat):
        (CallDelegateReturningBoolean):
        (CallUIDelegate):
        (CallUIDelegateReturningFloat):
        (CallUIDelegateReturningBoolean):
        (CallFrameLoadDelegate):
        (CallResourceLoadDelegate):
        (CallFormDelegate):
        (CallFormDelegateReturningBoolean):
        * WebView/WebViewInternal.h:
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
darin [Thu, 6 Sep 2007 19:39:32 +0000 (19:39 +0000)]
    Reviewed by Hyatt.

        - <rdar://problem/5457865> REGRESSION (9A527): Safari crashes when opening a page
          that immediately redirects to a PDF

        I don't know how to make an automated test that trips over this.

        The immediate cause of this regression was making a back/forward list entry in
        this case. Earlier, the quick redirect would not results in a separate entry.
        That's possibly a bug too, but it's better to fix the crash first.

        The page cache was putting the document into a strange state: Still attached but
        with the renderer set to 0. There was no good reason to do this, so got rid of it.
        Moved the responsibility to the caller of not calling detach() when moving into
        the page cache. This is more of a frame loader thing than a document thing.

        * dom/Document.cpp: (WebCore::Document::detach): Added assertions that this is
        only called on a document that's attached and not in the page cache. Also moved
        the call to willRemove in here, so that callers can't make the mistake of not
        calling that function. Removed the incorrectly-positioned code that made this
        function do less if it was called on a document in the page cache.

        * history/CachedPage.cpp: (WebCore::CachedPage::clear): Removed the code to handle
        a document with a renderer of 0. There was no need to put the document into this
        state. Any document in the page cache will always be "attached".

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Added a check to prevent
        from calling an unnecessary cancelParsing() on a document that's in the page cache
        and guard the call to detach() with a check of attached(), like all other calls to
        detach() on DOM objects.

        * page/Frame.cpp:
        (WebCore::Frame::setView): Added a missing check of attached(), like all other
        calls to detach() on DOM objects. Also added code to not call detach() on the
        document when it's in the page cache.
        (WebCore::Frame::setDocument): This call site already had the attached() check,
        but was missing the page cache check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
kmccullo [Thu, 6 Sep 2007 18:48:40 +0000 (18:48 +0000)]
JavaScriptCore:

        Reviewed by Adam, Sam, Darin.

        - Created a JSRetainPtr specifically for JSStringRefs so they can be automatically refed and derefed.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/JSRetainPtr.h: Copied from wtf/RetainPtr.h.
        (KJS::JSRetain):
        (KJS::JSRelease):
        (KJS::):
        (KJS::JSRetainPtr::JSRetainPtr):
        (KJS::JSRetainPtr::~JSRetainPtr):
        (KJS::JSRetainPtr::get):
        (KJS::JSRetainPtr::releaseRef):
        (KJS::JSRetainPtr::operator->):
        (KJS::JSRetainPtr::operator UnspecifiedBoolType):
        (KJS::::operator):
        (KJS::::adopt):
        (KJS::::swap):
        (KJS::swap):
        (KJS::operator==):
        (KJS::operator!=):

WebKitTools:

        Reviewed by Adam, Sam, Darin.

        - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.

        * Drosera/Debugger.h: Added.
        * Drosera/DebuggerDocument.cpp:
        (DebuggerDocument::breakpointEditorHTMLCallback):
        (DebuggerDocument::isPausedCallback):
        (DebuggerDocument::pauseCallback):
        (DebuggerDocument::resumeCallback):
        (DebuggerDocument::stepIntoCallback):
        (DebuggerDocument::evaluateScriptCallback):
        (DebuggerDocument::currentFunctionStackCallback):
        (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
        (DebuggerDocument::valueForScopeVariableNamedCallback):
        (DebuggerDocument::logCallback):
        (DebuggerDocument::breakpointEditorHTML):
        (DebuggerDocument::isPaused):
        (DebuggerDocument::pause):
        (DebuggerDocument::resume):
        (DebuggerDocument::stepInto):
        (DebuggerDocument::evaluateScript):
        (DebuggerDocument::currentFunctionStack):
        (DebuggerDocument::localScopeVariableNamesForCallFrame):
        (DebuggerDocument::valueForScopeVariableNamed):
        (DebuggerDocument::log):
        (DebuggerDocument::toolbarPause):
        (DebuggerDocument::toolbarResume):
        (DebuggerDocument::toolbarStepInto):
        (DebuggerDocument::toolbarStepOver):
        (DebuggerDocument::toolbarStepOut):
        (DebuggerDocument::toolbarShowConsole):
        (DebuggerDocument::toolbarCloseCurrentFile):
        (DebuggerDocument::updateFileSource):
        (DebuggerDocument::didParseScript):
        (DebuggerDocument::willExecuteStatement):
        (DebuggerDocument::didEnterCallFrame):
        (DebuggerDocument::willLeaveCallFrame):
        (DebuggerDocument::exceptionWasRaised):
        (DebuggerDocument::windowScriptObjectAvailable):
        (DebuggerDocument::toJSArray):
        (DebuggerDocument::callGlobalFunction):
        (DebuggerDocument::callFunctionOnObject):
        (DebuggerDocument::getDroseraJSClass):
        (DebuggerDocument::staticFunctions):
        (DebuggerDocument::logException):
        * Drosera/DebuggerDocument.h:
        (DebuggerDocument::DebuggerDocument):
        * Drosera/ForwardingHeaders: Added.
        * Drosera/ForwardingHeaders/wtf: Added.
        * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
        * Drosera/config.h:
        * Drosera/console.html:
        * Drosera/console.js:
        * Drosera/debugger.js:
        * Drosera/mac/DebuggerApplication.mm:
        (-[DebuggerApplication attach:]):
        * Drosera/mac/DebuggerDocumentMac.h:
        * Drosera/mac/DebuggerDocumentMac.mm:
        (+[NSString stringOrNilFromWebScriptResult:]):
        (+[DebuggerClientMac log:]):
        (-[DebuggerClientMac initWithServerName:]):
        (-[DebuggerClientMac dealloc]):
        (-[DebuggerClientMac pause]):
        (-[DebuggerClientMac resume]):
        (-[DebuggerClientMac pause:]):
        (-[DebuggerClientMac resume:]):
        (-[DebuggerClientMac stepInto:]):
        (-[DebuggerClientMac stepOver:]):
        (-[DebuggerClientMac stepOut:]):
        (-[DebuggerClientMac showConsole:]):
        (-[DebuggerClientMac closeCurrentFile:]):
        (-[DebuggerClientMac validateUserInterfaceItem:]):
        (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
        (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
        (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
        (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
        (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
        (DebuggerDocument::platformPause):
        (DebuggerDocument::platformResume):
        (DebuggerDocument::platformStepInto):
        (DebuggerDocument::platformEvaluateScript):
        (DebuggerDocument::platformCurrentFunctionStack):
        (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
        (DebuggerDocument::platformValueForScopeVariableNamed):
        (DebuggerDocument::platformLog):
        * Drosera/mac/Drosera.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAppease Sam[e]
oliver [Thu, 6 Sep 2007 18:42:54 +0000 (18:42 +0000)]
Appease Sam[e]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Same and Darin
oliver [Thu, 6 Sep 2007 18:42:01 +0000 (18:42 +0000)]
    Reviewed by Same and Darin

        Split the wrapper test into seperate Obj-C and JS tests so the we can use the JS tests on other platforms.

        * fast/dom/resources/wrapper-identity-base.js: Added -- This provides the basic utility functions and
          variables needed for the wrapper tests
        * fast/dom/wrapper-identity-expected.txt: Added.
        * fast/dom/wrapper-identity.html: Added.
        * platform/mac/fast/dom/objc-wrapper-identity-expected.txt: Copied from platform/mac/fast/dom/wrapper-identity-expected.txt.
        * platform/mac/fast/dom/objc-wrapper-identity.html: Copied from platform/mac/fast/dom/wrapper-identity.html.
        * platform/mac/fast/dom/wrapper-identity-expected.txt: Removed.
        * platform/mac/fast/dom/wrapper-identity.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
weinig [Thu, 6 Sep 2007 18:11:53 +0000 (18:11 +0000)]
    Reviewed by Adam Roben.

        Add fast/frames/onload-remove-iframe-crash.html to the windows skiplist becuase it currently crashes.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam Roben.
weinig [Thu, 6 Sep 2007 18:07:54 +0000 (18:07 +0000)]
    Reviewed by Adam Roben.

        Register the WebKit DLL on initialization of the DumpRenderTree.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
        (initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMake popup windows work again
staikos [Thu, 6 Sep 2007 17:05:21 +0000 (17:05 +0000)]
Make popup windows work again

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCheck in source change now that I committed the changelog!
harrison [Thu, 6 Sep 2007 16:56:57 +0000 (16:56 +0000)]
Check in source change now that I committed the changelog!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
harrison [Thu, 6 Sep 2007 16:55:23 +0000 (16:55 +0000)]
    Reviewed by Darin.

        Follow up on my fix for <rdar://problem/5306171>.
        My first patch (r25373) broke svg/custom/stroke-width-click.svg.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
        Add currPos.isNotNull() check because positions in non-html content (like svg)
        do not have visible positions, and we don't want to emit for them either.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-09-06 Mitz Pettel <mitz@webkit.org>
bdash [Thu, 6 Sep 2007 12:20:24 +0000 (12:20 +0000)]
2007-09-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Adam Roben.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14685
          <rdar://problem/5349755> text-align affects <select> button but not its drop-down menu

        * platform/PlatformString.h:
        (WebCore::String::defaultWritingDirection):
        * platform/StringImpl.cpp:
        (WebCore::StringImpl::defaultWritingDirection): Moved textDirectionForParagraph()
        from RenderMenuList.cpp here.
        * platform/StringImpl.h:
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::itemWritingDirectionIsNatural): Changed to return 'true'.
        (WebCore::PopupMenu::paint): Changed to use natural directionality for menu
        items.
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::adjustInnerStyle): Use defaultWritingDirection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Forgot the JS file.
mjs [Thu, 6 Sep 2007 10:31:56 +0000 (10:31 +0000)]
    Forgot the JS file.

        * misc/WebKitDetect.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not reviewed - copy of WebKitDetect script from wiki
mjs [Thu, 6 Sep 2007 10:09:13 +0000 (10:09 +0000)]
    Not reviewed - copy of WebKitDetect script from wiki

        * misc/WebKitDetect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver Hunt.
mjs [Thu, 6 Sep 2007 09:25:06 +0000 (09:25 +0000)]
    Reviewed by Oliver Hunt.

        - fixed <rdar://problem/5455457> REGRESSION (9A527-9A535): Colloquy crash on launch in WebCoreScriptDebugger initWithDelegate (with announce.js plug-in installed)

        * page/mac/FrameMac.mm:
        (WebCore::Frame::windowScriptObject): Ensure that -[WebView
        windowScriptObject] and -[WebFrame windowObject] return null until
        the windowScriptObjectAvailable: delegate method is sent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Stephanie.
oliver [Thu, 6 Sep 2007 04:34:16 +0000 (04:34 +0000)]
    Reviewed by Stephanie.

        Moved a number of tests from platform/mac that are not currently cross-platform,
        but should eventually be updated to work across all platforms.

        * editing/deleting/5300379-expected.checksum: Copied from platform/mac/editing/deleting/5300379-expected.checksum.
        * editing/deleting/5300379-expected.png: Copied from platform/mac/editing/deleting/5300379-expected.png.
        * editing/deleting/5300379-expected.txt: Copied from platform/mac/editing/deleting/5300379-expected.txt.
        * editing/deleting/5300379.html: Copied from platform/mac/editing/deleting/5300379.html.
        * editing/deleting/delete-to-end-of-paragraph-expected.checksum: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.checksum.
        * editing/deleting/delete-to-end-of-paragraph-expected.png: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png.
        * editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt.
        * editing/deleting/delete-to-end-of-paragraph.html: Copied from platform/mac/editing/deleting/delete-to-end-of-paragraph.html.
        * editing/deleting/smart-delete-003-expected.checksum: Copied from platform/mac/editing/deleting/smart-delete-003-expected.checksum.
        * editing/deleting/smart-delete-003-expected.png: Copied from platform/mac/editing/deleting/smart-delete-003-expected.png.
        * editing/deleting/smart-delete-003-expected.txt: Copied from platform/mac/editing/deleting/smart-delete-003-expected.txt.
        * editing/deleting/smart-delete-003.html: Copied from platform/mac/editing/deleting/smart-delete-003.html.
        * editing/deleting/smart-delete-004-expected.checksum: Copied from platform/mac/editing/deleting/smart-delete-004-expected.checksum.
        * editing/deleting/smart-delete-004-expected.png: Copied from platform/mac/editing/deleting/smart-delete-004-expected.png.
        * editing/deleting/smart-delete-004-expected.txt: Copied from platform/mac/editing/deleting/smart-delete-004-expected.txt.
        * editing/deleting/smart-delete-004.html: Copied from platform/mac/editing/deleting/smart-delete-004.html.
        * editing/execCommand/nsresponder-indent-expected.checksum: Copied from platform/mac/editing/execCommand/nsresponder-indent-expected.checksum.
        * editing/execCommand/nsresponder-indent-expected.png: Copied from platform/mac/editing/execCommand/nsresponder-indent-expected.png.
        * editing/execCommand/nsresponder-indent-expected.txt: Copied from platform/mac/editing/execCommand/nsresponder-indent-expected.txt.
        * editing/execCommand/nsresponder-indent.html: Copied from platform/mac/editing/execCommand/nsresponder-indent.html.
        * editing/execCommand/nsresponder-outdent-expected.checksum: Copied from platform/mac/editing/execCommand/nsresponder-outdent-expected.checksum.
        * editing/execCommand/nsresponder-outdent-expected.png: Copied from platform/mac/editing/execCommand/nsresponder-outdent-expected.png.
        * editing/execCommand/nsresponder-outdent-expected.txt: Copied from platform/mac/editing/execCommand/nsresponder-outdent-expected.txt.
        * editing/execCommand/nsresponder-outdent.html: Copied from platform/mac/editing/execCommand/nsresponder-outdent.html.
        * editing/selection/4947387-expected.checksum: Copied from platform/mac/editing/selection/4947387-expected.checksum.
        * editing/selection/4947387-expected.png: Copied from platform/mac/editing/selection/4947387-expected.png.
        * editing/selection/4947387-expected.txt: Copied from platform/mac/editing/selection/4947387-expected.txt.
        * editing/selection/4947387.html: Copied from platform/mac/editing/selection/4947387.html.
        * editing/selection/5195166-1-expected.checksum: Copied from platform/mac/editing/selection/5195166-1-expected.checksum.
        * editing/selection/5195166-1-expected.png: Copied from platform/mac/editing/selection/5195166-1-expected.png.
        * editing/selection/5195166-1-expected.txt: Copied from platform/mac/editing/selection/5195166-1-expected.txt.
        * editing/selection/5195166-1.html: Copied from platform/mac/editing/selection/5195166-1.html.
        * editing/selection/5195166-2-expected.checksum: Copied from platform/mac/editing/selection/5195166-2-expected.checksum.
        * editing/selection/5195166-2-expected.png: Copied from platform/mac/editing/selection/5195166-2-expected.png.
        * editing/selection/5195166-2-expected.txt: Copied from platform/mac/editing/selection/5195166-2-expected.txt.
        * editing/selection/5195166-2.html: Copied from platform/mac/editing/selection/5195166-2.html.
        * editing/selection/select-line-expected.txt: Copied from platform/mac/editing/selection/select-line-expected.txt.
        * editing/selection/select-line.html: Copied from platform/mac/editing/selection/select-line.html.
        * editing/selection/selection-actions-expected.checksum: Copied from platform/mac/editing/selection/selection-actions-expected.checksum.
        * editing/selection/selection-actions-expected.png: Copied from platform/mac/editing/selection/selection-actions-expected.png.
        * editing/selection/selection-actions-expected.txt: Copied from platform/mac/editing/selection/selection-actions-expected.txt.
        * editing/selection/selection-actions.html: Copied from platform/mac/editing/selection/selection-actions.html.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Updated results for:
harrison [Thu, 6 Sep 2007 01:47:30 +0000 (01:47 +0000)]
    Updated results for:
        <rdar://problem/5306171> Mail: The first return after an attachment in multipart/mixed message is lost

        * http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
        * http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level-expected.txt:
        * http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-to-javscript-url-expected.txt:
        * http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin McCullough.
weinig [Thu, 6 Sep 2007 00:32:36 +0000 (00:32 +0000)]
    Reviewed by Kevin McCullough.

        Use correct part of the test for cross-platform testing.

        * plugins/bindings-test-expected.txt:
        * plugins/bindings-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff Garen.
weinig [Wed, 5 Sep 2007 23:57:03 +0000 (23:57 +0000)]
    Reviewed by Geoff Garen.

        Split out mac specific tests from plugins/bindings-test.html into its own test.

        * platform/mac/plugins/bindings-test-objc-expected.txt: Added.
        * platform/mac/plugins/bindings-test-objc.html: Copied from plugins/bindings-test.html.
        * platform/win/Skipped:
        * plugins/bindings-test-expected.txt:
        * plugins/bindings-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam and Niko.
oliver [Wed, 5 Sep 2007 23:39:55 +0000 (23:39 +0000)]
    Reviewed by Adam and Niko.

        Force run-webkit-tests to not run the tests in platform/mac

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix ALT+key combos so that they go into the DOM.
hyatt [Wed, 5 Sep 2007 23:02:38 +0000 (23:02 +0000)]
Fix ALT+key combos so that they go into the DOM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff Garen.
weinig [Wed, 5 Sep 2007 22:39:32 +0000 (22:39 +0000)]
    Reviewed by Geoff Garen.

        Don't log DumpRenderTree injected properties in fast/dom/Window/window-properties.html.  This change makes
        it pass on Windows so it can be removed from the Skipped list.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-properties.html:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
weinig [Wed, 5 Sep 2007 20:58:28 +0000 (20:58 +0000)]
    Reviewed by Oliver.

        Fix many layout test failures caused by r25364.
        Set text size to standand size at the begining of each test matching the mac.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
harrison [Wed, 5 Sep 2007 20:46:41 +0000 (20:46 +0000)]
WebCore:

        Reviewed by Kevin Decker.

        <rdar://problem/5306171> Mail: The first return after an attachment in multipart/mixed message is lost

        Test added: editing/selection/toString-1.html

        Source changes:
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
        - Remove outdated and erroneous check for m_lastTextNode.
        - Fix VisiblePosition check to look for line diff. Simple position diff gives the
        wrong answer when the start is table/0 and the current is the first position
        inside the content of the table.

LayoutTests:

        Reviewed by Kevin Decker.

        Testcase for:
        <rdar://problem/5306171> Mail: The first return after an attachment in multipart/mixed message is lost

        * editing/selection/toString-1-expected.txt: Added.
        * editing/selection/toString-1.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-09-05 Mark Rowe <mrowe@apple.com>
bdash [Wed, 5 Sep 2007 14:24:37 +0000 (14:24 +0000)]
2007-09-05  Mark Rowe  <mrowe@apple.com>

        Unreviewed Qt build fix.

        * wtf/unicode/qt4/UnicodeQt4.h: Fix the constness of the src argument to toUpper to prevent build failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-09-04 Marvin Decker <marv.decker@gmail.com>
bdash [Wed, 5 Sep 2007 06:10:54 +0000 (06:10 +0000)]
2007-09-04  Marvin Decker  <marv.decker@gmail.com>

        Reviewed by Maciej Stachowiak.

        http://bugs.webkit.org/show_bug.cgi?id=15072
        Bug 15072: Fix ImageDecoder.cpp to not copy incoming data

        Change ImageDecoder::setData to take a SharedBuffer*.

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::ImageSource::setData):
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::RGBA32Buffer::bytes):
        (WebCore::RGBA32Buffer::height):
        (WebCore::ImageDecoder::setData):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::setData):
        (WebCore::GIFImageDecoder::frameCount):
        (WebCore::GIFImageDecoder::decode):
        (WebCore::GIFImageDecoder::decodingHalted):
        (WebCore::GIFImageDecoder::initFrameBuffer):
        * platform/image-decoders/gif/GIFImageDecoder.h:
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageDecoder::setData):
        (WebCore::JPEGImageDecoder::decode):
        * platform/image-decoders/jpeg/JPEGImageDecoder.h:
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::setData):
        (WebCore::PNGImageDecoder::decode):
        (WebCore::PNGImageDecoder::headerAvailable):
        (WebCore::PNGImageDecoder::rowAvailable):
        * platform/image-decoders/png/PNGImageDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago RS=Adam
oliver [Wed, 5 Sep 2007 05:16:53 +0000 (05:16 +0000)]
    RS=Adam

        Moving a number of mac specific tests into LayoutTests/platform/mac so that they
        don't need to be in the windows Skiplist.

        This includes most of the tests that used textInputController as it is a test
        of the mac-specific NSTextInput API.

        * editing/deleting/5300379-expected.checksum: Removed.
        * editing/deleting/5300379-expected.png: Removed.
        * editing/deleting/5300379-expected.txt: Removed.
        * editing/deleting/5300379.html: Removed.
        * editing/deleting/delete-to-end-of-paragraph-expected.checksum: Removed.
        * editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
        * editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
        * editing/deleting/delete-to-end-of-paragraph.html: Removed.
        * editing/deleting/smart-delete-003-expected.checksum: Removed.
        * editing/deleting/smart-delete-003-expected.png: Removed.
        * editing/deleting/smart-delete-003-expected.txt: Removed.
        * editing/deleting/smart-delete-003.html: Removed.
        * editing/deleting/smart-delete-004-expected.checksum: Removed.
        * editing/deleting/smart-delete-004-expected.png: Removed.
        * editing/deleting/smart-delete-004-expected.txt: Removed.
        * editing/deleting/smart-delete-004.html: Removed.
        * editing/execCommand/nsresponder-indent-expected.checksum: Removed.
        * editing/execCommand/nsresponder-indent-expected.png: Removed.
        * editing/execCommand/nsresponder-indent-expected.txt: Removed.
        * editing/execCommand/nsresponder-indent.html: Removed.
        * editing/execCommand/nsresponder-outdent-expected.checksum: Removed.
        * editing/execCommand/nsresponder-outdent-expected.png: Removed.
        * editing/execCommand/nsresponder-outdent-expected.txt: Removed.
        * editing/execCommand/nsresponder-outdent.html: Removed.
        * editing/input/firstrectforcharacterrange-plain-expected.txt: Removed.
        * editing/input/firstrectforcharacterrange-plain.html: Removed.
        * editing/input/firstrectforcharacterrange-styled-expected.txt: Removed.
        * editing/input/firstrectforcharacterrange-styled.html: Removed.
        * editing/input/mac: Removed.
        * editing/input/mac/hangul-enter-confirms-and-sends-keypress-expected.txt: Removed.
        * editing/input/mac/hangul-enter-confirms-and-sends-keypress.html: Removed.
        * editing/input/mac/hangul.js: Removed.
        * editing/input/mac/kotoeri-enter-to-confirm-and-newline-expected.txt: Removed.
        * editing/input/mac/kotoeri-enter-to-confirm-and-newline.html: Removed.
        * editing/input/mac/kotoeri.js: Removed.
        * editing/input/mac/logger.js: Removed.
        * editing/input/range-for-empty-document-expected.txt: Removed.
        * editing/input/range-for-empty-document.html: Removed.
        * editing/input/replace-invalid-range-expected.txt: Removed.
        * editing/input/replace-invalid-range.html: Removed.
        * editing/input/text-input-controller-expected.txt: Removed.
        * editing/input/text-input-controller.html: Removed.
        * editing/input/wrapped-line-char-rect-expected.txt: Removed.
        * editing/input/wrapped-line-char-rect.html: Removed.
        * editing/selection/4947387-expected.checksum: Removed.
        * editing/selection/4947387-expected.png: Removed.
        * editing/selection/4947387-expected.txt: Removed.
        * editing/selection/4947387.html: Removed.
        * editing/selection/5195166-1-expected.checksum: Removed.
        * editing/selection/5195166-1-expected.png: Removed.
        * editing/selection/5195166-1-expected.txt: Removed.
        * editing/selection/5195166-1.html: Removed.
        * editing/selection/5195166-2-expected.checksum: Removed.
        * editing/selection/5195166-2-expected.png: Removed.
        * editing/selection/5195166-2-expected.txt: Removed.
        * editing/selection/5195166-2.html: Removed.
        * editing/selection/select-line-expected.txt: Removed.
        * editing/selection/select-line.html: Removed.
        * editing/selection/selection-actions-expected.checksum: Removed.
        * editing/selection/selection-actions-expected.png: Removed.
        * editing/selection/selection-actions-expected.txt: Removed.
        * editing/selection/selection-actions.html: Removed.
        * fast/AppleScript: Removed.
        * fast/AppleScript/001-expected.txt: Removed.
        * fast/AppleScript/001.html: Removed.
        * fast/AppleScript/array-expected.txt: Removed.
        * fast/AppleScript/array.html: Removed.
        * fast/AppleScript/date-expected.txt: Removed.
        * fast/AppleScript/date.html: Removed.
        * fast/dom/character-index-for-point-expected.txt: Removed.
        * fast/dom/character-index-for-point.html: Removed.
        * fast/dom/wrapper-identity-expected.txt: Removed.
        * fast/dom/wrapper-identity.html: Removed.
        * fast/dom/wrapper-round-tripping-expected.txt: Removed.
        * fast/dom/wrapper-round-tripping.html: Removed.
        * fast/encoding/char-decoding-mac-expected.txt: Removed.
        * fast/encoding/char-decoding-mac.html: Removed.
        * fast/forms/attributed-strings-expected.txt: Removed.
        * fast/forms/attributed-strings.html: Removed.
        * fast/objc: Removed.
        * fast/objc/longlongTest-expected.txt: Removed.
        * fast/objc/longlongTest.html: Removed.
        * fast/text/attributed-substring-from-range-001-expected.txt: Removed.
        * fast/text/attributed-substring-from-range-001.html: Removed.
        * fast/text/attributed-substring-from-range-expected.txt: Removed.
        * fast/text/attributed-substring-from-range-in-textfield-expected.txt: Removed.
        * fast/text/attributed-substring-from-range-in-textfield.html: Removed.
        * fast/text/attributed-substring-from-range.html: Removed.
        * fast/text/justified-text-rect-expected.checksum: Removed.
        * fast/text/justified-text-rect-expected.png: Removed.
        * fast/text/justified-text-rect-expected.txt: Removed.
        * fast/text/justified-text-rect.html: Removed.
        * platform/mac/editing/deleting/5300379-expected.checksum: Copied from editing/deleting/5300379-expected.checksum.
        * platform/mac/editing/deleting/5300379-expected.png: Copied from editing/deleting/5300379-expected.png.
        * platform/mac/editing/deleting/5300379-expected.txt: Copied from editing/deleting/5300379-expected.txt.
        * platform/mac/editing/deleting/5300379.html: Copied from editing/deleting/5300379.html.
        * platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.checksum: Copied from editing/deleting/delete-to-end-of-paragraph-expected.checksum.
        * platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Copied from editing/deleting/delete-to-end-of-paragraph-expected.png.
        * platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from editing/deleting/delete-to-end-of-paragraph-expected.txt.
        * platform/mac/editing/deleting/delete-to-end-of-paragraph.html: Copied from editing/deleting/delete-to-end-of-paragraph.html.
        * platform/mac/editing/deleting/smart-delete-003-expected.checksum: Copied from editing/deleting/smart-delete-003-expected.checksum.
        * platform/mac/editing/deleting/smart-delete-003-expected.png: Copied from editing/deleting/smart-delete-003-expected.png.
        * platform/mac/editing/deleting/smart-delete-003-expected.txt: Copied from editing/deleting/smart-delete-003-expected.txt.
        * platform/mac/editing/deleting/smart-delete-003.html: Copied from editing/deleting/smart-delete-003.html.
        * platform/mac/editing/deleting/smart-delete-004-expected.checksum: Copied from editing/deleting/smart-delete-004-expected.checksum.
        * platform/mac/editing/deleting/smart-delete-004-expected.png: Copied from editing/deleting/smart-delete-004-expected.png.
        * platform/mac/editing/deleting/smart-delete-004-expected.txt: Copied from editing/deleting/smart-delete-004-expected.txt.
        * platform/mac/editing/deleting/smart-delete-004.html: Copied from editing/deleting/smart-delete-004.html.
        * platform/mac/editing/execCommand/nsresponder-indent-expected.checksum: Copied from editing/execCommand/nsresponder-indent-expected.checksum.
        * platform/mac/editing/execCommand/nsresponder-indent-expected.png: Copied from editing/execCommand/nsresponder-indent-expected.png.
        * platform/mac/editing/execCommand/nsresponder-indent-expected.txt: Copied from editing/execCommand/nsresponder-indent-expected.txt.
        * platform/mac/editing/execCommand/nsresponder-indent.html: Copied from editing/execCommand/nsresponder-indent.html.
        * platform/mac/editing/execCommand/nsresponder-outdent-expected.checksum: Copied from editing/execCommand/nsresponder-outdent-expected.checksum.
        * platform/mac/editing/execCommand/nsresponder-outdent-expected.png: Copied from editing/execCommand/nsresponder-outdent-expected.png.
        * platform/mac/editing/execCommand/nsresponder-outdent-expected.txt: Copied from editing/execCommand/nsresponder-outdent-expected.txt.
        * platform/mac/editing/execCommand/nsresponder-outdent.html: Copied from editing/execCommand/nsresponder-outdent.html.
        * platform/mac/editing/input: Copied from editing/input/mac.
        * platform/mac/editing/input/firstrectforcharacterrange-plain-expected.txt: Copied from editing/input/firstrectforcharacterrange-plain-expected.txt.
        * platform/mac/editing/input/firstrectforcharacterrange-plain.html: Copied from editing/input/firstrectforcharacterrange-plain.html.
        * platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt: Copied from editing/input/firstrectforcharacterrange-styled-expected.txt.
        * platform/mac/editing/input/firstrectforcharacterrange-styled.html: Copied from editing/input/firstrectforcharacterrange-styled.html.
        * platform/mac/editing/input/range-for-empty-document-expected.txt: Copied from editing/input/range-for-empty-document-expected.txt.
        * platform/mac/editing/input/range-for-empty-document.html: Copied from editing/input/range-for-empty-document.html.
        * platform/mac/editing/input/replace-invalid-range-expected.txt: Copied from editing/input/replace-invalid-range-expected.txt.
        * platform/mac/editing/input/replace-invalid-range.html: Copied from editing/input/replace-invalid-range.html.
        * platform/mac/editing/input/text-input-controller-expected.txt: Copied from editing/input/text-input-controller-expected.txt.
        * platform/mac/editing/input/text-input-controller.html: Copied from editing/input/text-input-controller.html.
        * platform/mac/editing/input/wrapped-line-char-rect-expected.txt: Copied from editing/input/wrapped-line-char-rect-expected.txt.
        * platform/mac/editing/input/wrapped-line-char-rect.html: Copied from editing/input/wrapped-line-char-rect.html.
        * platform/mac/editing/selection/4947387-expected.checksum: Copied from editing/selection/4947387-expected.checksum.
        * platform/mac/editing/selection/4947387-expected.png: Copied from editing/selection/4947387-expected.png.
        * platform/mac/editing/selection/4947387-expected.txt: Copied from editing/selection/4947387-expected.txt.
        * platform/mac/editing/selection/4947387.html: Copied from editing/selection/4947387.html.
        * platform/mac/editing/selection/5195166-1-expected.checksum: Copied from editing/selection/5195166-1-expected.checksum.
        * platform/mac/editing/selection/5195166-1-expected.png: Copied from editing/selection/5195166-1-expected.png.
        * platform/mac/editing/selection/5195166-1-expected.txt: Copied from editing/selection/5195166-1-expected.txt.
        * platform/mac/editing/selection/5195166-1.html: Copied from editing/selection/5195166-1.html.
        * platform/mac/editing/selection/5195166-2-expected.checksum: Copied from editing/selection/5195166-2-expected.checksum.
        * platform/mac/editing/selection/5195166-2-expected.png: Copied from editing/selection/5195166-2-expected.png.
        * platform/mac/editing/selection/5195166-2-expected.txt: Copied from editing/selection/5195166-2-expected.txt.
        * platform/mac/editing/selection/5195166-2.html: Copied from editing/selection/5195166-2.html.
        * platform/mac/editing/selection/select-line-expected.txt: Copied from editing/selection/select-line-expected.txt.
        * platform/mac/editing/selection/select-line.html: Copied from editing/selection/select-line.html.
        * platform/mac/editing/selection/selection-actions-expected.checksum: Copied from editing/selection/selection-actions-expected.checksum.
        * platform/mac/editing/selection/selection-actions-expected.png: Copied from editing/selection/selection-actions-expected.png.
        * platform/mac/editing/selection/selection-actions-expected.txt: Copied from editing/selection/selection-actions-expected.txt.
        * platform/mac/editing/selection/selection-actions.html: Copied from editing/selection/selection-actions.html.
        * platform/mac/fast/AppleScript: Copied from fast/AppleScript.
        * platform/mac/fast/dom: Added.
        * platform/mac/fast/dom/character-index-for-point-expected.txt: Copied from fast/dom/character-index-for-point-expected.txt.
        * platform/mac/fast/dom/character-index-for-point.html: Copied from fast/dom/character-index-for-point.html.
        * platform/mac/fast/dom/wrapper-identity-expected.txt: Copied from fast/dom/wrapper-identity-expected.txt.
        * platform/mac/fast/dom/wrapper-identity.html: Copied from fast/dom/wrapper-identity.html.
        * platform/mac/fast/dom/wrapper-round-tripping-expected.txt: Copied from fast/dom/wrapper-round-tripping-expected.txt.
        * platform/mac/fast/dom/wrapper-round-tripping.html: Copied from fast/dom/wrapper-round-tripping.html.
        * platform/mac/fast/encoding: Added.
        * platform/mac/fast/encoding/char-decoding-mac-expected.txt: Copied from fast/encoding/char-decoding-mac-expected.txt.
        * platform/mac/fast/encoding/char-decoding-mac.html: Copied from fast/encoding/char-decoding-mac.html.
        * platform/mac/fast/forms: Added.
        * platform/mac/fast/forms/attributed-strings-expected.txt: Copied from fast/forms/attributed-strings-expected.txt.
        * platform/mac/fast/forms/attributed-strings.html: Copied from fast/forms/attributed-strings.html.
        * platform/mac/fast/objc: Copied from fast/objc.
        * platform/mac/fast/text: Added.
        * platform/mac/fast/text/attributed-substring-from-range-001-expected.txt: Copied from fast/text/attributed-substring-from-range-001-expected.txt.
        * platform/mac/fast/text/attributed-substring-from-range-001.html: Copied from fast/text/attributed-substring-from-range-001.html.
        * platform/mac/fast/text/attributed-substring-from-range-expected.txt: Copied from fast/text/attributed-substring-from-range-expected.txt.
        * platform/mac/fast/text/attributed-substring-from-range-in-textfield-expected.txt: Copied from fast/text/attributed-substring-from-range-in-textfield-expected.txt.
        * platform/mac/fast/text/attributed-substring-from-range-in-textfield.html: Copied from fast/text/attributed-substring-from-range-in-textfield.html.
        * platform/mac/fast/text/attributed-substring-from-range.html: Copied from fast/text/attributed-substring-from-range.html.
        * platform/mac/fast/text/justified-text-rect-expected.checksum: Copied from fast/text/justified-text-rect-expected.checksum.
        * platform/mac/fast/text/justified-text-rect-expected.png: Copied from fast/text/justified-text-rect-expected.png.
        * platform/mac/fast/text/justified-text-rect-expected.txt: Copied from fast/text/justified-text-rect-expected.txt.
        * platform/mac/fast/text/justified-text-rect.html: Copied from fast/text/justified-text-rect.html.
        * platform/mac/plugins: Added.
        * platform/mac/plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Copied from plugins/pluginDocumentView-deallocated-dataSource-expected.txt.
        * platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html: Copied from plugins/pluginDocumentView-deallocated-dataSource.html.
        * platform/win/Skipped:
        * plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Removed.
        * plugins/pluginDocumentView-deallocated-dataSource.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Back out accidentally committed change.
mjs [Wed, 5 Sep 2007 05:15:06 +0000 (05:15 +0000)]
    Back out accidentally committed change.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/collector.cpp:
        (KJS::Collector::registerThread):
        * wtf/FastMalloc.cpp:
        (WTF::fastMallocSetIsMultiThreaded):
        (WTF::TCMalloc_ThreadCache::GetCache):
        (WTF::TCMalloc_ThreadCache::GetCacheIfPresent):
        (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
        (WTF::do_malloc):
        * wtf/FastMallocInternal.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
mjs [Wed, 5 Sep 2007 05:01:03 +0000 (05:01 +0000)]
    Reviewed by Darin.

        - Added Vector::appendRange(), which appends to a vector based on a given start and end iterator
        - Added keys() and values() functions to HashMap iterators, which give keys-only and values-only iterators

        Together, these allow easy copying of a set, or the keys or values of a map, into a Vector. Examples:

        HashMap<int, int> map;
        HashSet<int> set;
        Vector<int> vec;
        // ...
        vec.appendRange(set.begin(), set.end());
        vec.appendRange(map.begin().keys(), map.end().keys());
        vec.appendRange(map.begin().values(), map.end().values());

        This also allows for a slightly nicer syntax when iterating a map. Instead of saying
        (*it)->first, you can say *it.values(). Similarly for keys. Example:

        HashMap<int, int>::const_iterator end = map.end();
        for (HashMap<int, int>::const_iterator it = map.begin(); it != end; ++it)
        printf(" [%d => %d]", *it.keys(), *it.values());

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/HashIterators.h: Added.
        (WTF::):
        (WTF::HashTableConstKeysIterator::HashTableConstKeysIterator):
        (WTF::HashTableConstKeysIterator::get):
        (WTF::HashTableConstKeysIterator::operator*):
        (WTF::HashTableConstKeysIterator::operator->):
        (WTF::HashTableConstKeysIterator::operator++):
        (WTF::HashTableConstValuesIterator::HashTableConstValuesIterator):
        (WTF::HashTableConstValuesIterator::get):
        (WTF::HashTableConstValuesIterator::operator*):
        (WTF::HashTableConstValuesIterator::operator->):
        (WTF::HashTableConstValuesIterator::operator++):
        (WTF::HashTableKeysIterator::HashTableKeysIterator):
        (WTF::HashTableKeysIterator::get):
        (WTF::HashTableKeysIterator::operator*):
        (WTF::HashTableKeysIterator::operator->):
        (WTF::HashTableKeysIterator::operator++):
        (WTF::HashTableKeysIterator::operator HashTableConstKeysIterator<HashTableType, KeyType, MappedType>):
        (WTF::HashTableValuesIterator::HashTableValuesIterator):
        (WTF::HashTableValuesIterator::get):
        (WTF::HashTableValuesIterator::operator*):
        (WTF::HashTableValuesIterator::operator->):
        (WTF::HashTableValuesIterator::operator++):
        (WTF::HashTableValuesIterator::operator HashTableConstValuesIterator<HashTableType, KeyType, MappedType>):
        (WTF::operator==):
        (WTF::operator!=):
        * wtf/HashTable.h:
        * wtf/Vector.h:
        (WTF::::appendRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKitTools:
weinig [Wed, 5 Sep 2007 03:58:16 +0000 (03:58 +0000)]
WebKitTools:

        Reviewed by Adam.

        Fix for <rdar://problem/5382277>
        Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
        (textZoomInCallback):
        (textZoomOutCallback):

LayoutTests:

        Reviewed by Adam.

        Fix for <rdar://problem/5382277>
        Remove fast/css/ignore-text-zoom.html from skip list now that
        eventSender.textZoomIn is supported.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
thatcher [Wed, 5 Sep 2007 00:25:31 +0000 (00:25 +0000)]
    Reviewed by Darin.

        <rdar://problem/5452908> NIBs saved in the Pre-10.2 format while Safari 3 installed do not work without Safari 3

        This happened because we encoded a new field that the old WebKit does not know how to read.
        And NSCoder throws an exception if initWithCoder finishes while there is still unread data in the archive.

        The WebViewVersion is now 4 to distinguish that we do not encode/decode allowsUndo.

        * WebView/WebView.mm:
        (-[WebView initWithCoder:]): Only try to read allowsUndo if the version is 3.
        (-[WebView encodeWithCoder:]): No longer encode allowsUndo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
weinig [Wed, 5 Sep 2007 00:16:38 +0000 (00:16 +0000)]
    Build fix.

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix build bustage.
hyatt [Tue, 4 Sep 2007 23:23:36 +0000 (23:23 +0000)]
Fix build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
hyatt [Tue, 4 Sep 2007 22:58:27 +0000 (22:58 +0000)]
WebCore:

        Fix for <rdar://problem/5271213>, resizing iChat window is slower than in
        Tiger. This patch implements a fast scaling mode that can be used by
        WebViews, e.g., during window resizing.

        Reviewed by John Sullivan

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * page/Frame.cpp:
        (WebCore::FramePrivate::FramePrivate):
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::inLowQualityImageInterpolationMode):
        (WebCore::Page::setInLowQualityImageInterpolationMode):
        * page/Page.h:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawImage):
        * platform/graphics/GraphicsContext.h:
        (WebCore::GraphicsContext::setUseLowQualityImageInterpolation):
        (WebCore::GraphicsContext::useLowQualityImageInterpolation):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::setUseLowQualityImageInterpolation):
        (WebCore::GraphicsContext::useLowQualityImageInterpolation):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):

WebKit:

        Fix for <rdar://problem/5271213>, resizing iChat window is slower than in
        Tiger.  This patch implements a fast scaling mode that can be used by
        WebViews, e.g., during window resizing.

        Reviewed by John Sullivan

        * WebView/WebView.mm:
        (-[WebView _setUseFastImageScalingMode:]):
        (-[WebView _inFastImageScalingMode]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
darin [Tue, 4 Sep 2007 22:47:51 +0000 (22:47 +0000)]
    Reviewed by Hyatt.

        * WebView/WebView.mm:
        (-[WebView _loadBackForwardListFromOtherView:]): Added missing null check.
        (-[WebView _setInitiatedDrag:]): Ditto.
        (-[WebView _clearUndoRedoOperations]): Ditto.
        (-[WebView encodeWithCoder:]): Ditto.
        (-[WebView backForwardList]): Ditto.
        (-[WebView setMaintainsBackForwardList:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Updated test for <rdar://problem/5279521>. The old test didn't crash before...
adele [Tue, 4 Sep 2007 22:14:49 +0000 (22:14 +0000)]
    Updated test for <rdar://problem/5279521>.  The old test didn't crash before the fix.

        * editing/style/5279521.html:
        * editing/style/5279521-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBlind attempt at fixing Windows debug build
beidson [Tue, 4 Sep 2007 21:56:31 +0000 (21:56 +0000)]
Blind attempt at fixing Windows debug build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam
beidson [Tue, 4 Sep 2007 20:32:22 +0000 (20:32 +0000)]
    Reviewed by Adam

        Some SQLite tweaks for debugging
        -In debug builds, track the thread that opened the database and enforce that any statements
         that operate on the SQLDatabase do so from the thread that opened it
        -Track whether or not a transaction is in progress for the SQLDatabase to find cases where
         someone opens a new transaction while there is still one outstanding (a SQLite logic error)

        * loader/icon/SQLDatabase.cpp:
        (WebCore::SQLDatabase::SQLDatabase):
        (WebCore::SQLDatabase::open): Track the opening thread.  Also, return false if the DB failed to
          open instead of trying to run a PRAGMA on it!
        (WebCore::SQLDatabase::close): Reset the opening thread
        * loader/icon/SQLDatabase.h:
        (WebCore::SQLDatabase::transactionInProgress):
        (WebCore::SQLDatabase::sqlite3Handle): For access to the raw sqlite3* handle to do a thread
          safety check

        * loader/icon/SQLStatement.cpp:
        (WebCore::SQLStatement::prepare): Use the new sqlite3Handle accessor
        (WebCore::SQLStatement::step): Ditto

        * loader/icon/SQLTransaction.cpp:
        (WebCore::SQLTransaction::SQLTransaction): Removed the c'tor form that could automatically
          begin the transaction - never used and shouldn't be in practice!
        (WebCore::SQLTransaction::begin): Maintain the transaction-in-progress flag on the DB
        (WebCore::SQLTransaction::commit): Ditto
        (WebCore::SQLTransaction::rollback): Ditto
        * loader/icon/SQLTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
tristan [Tue, 4 Sep 2007 19:50:56 +0000 (19:50 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/5454935> Can't reply to this message in Mail -- -[DOMRange webArchive] is throwing an exception

        * WebView/WebArchiver.mm:
        (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
        Guard the creation of WebResource by ensuring that the passed in
        responseURL is never nil.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
harrison [Tue, 4 Sep 2007 16:55:42 +0000 (16:55 +0000)]
WebCore:

        Reviewed by Maciej and John.

        <rdar://problem/5452675> CrashTracer: [USER] 10 crashes in Mail at com.apple.WebCore: WebCore::Node::nodeIndex const + 6

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        Adjust pos to pos.downstream() after the refNode is calculated, but before the insertion. Doing it earlier
        undid the logic of positionAvoidingSpecialElementBoundary(). The downstream is still needed just to set the
        ending selection.

LayoutTests:

        Reviewed by Maciej and John.

        Testcase for:
        <rdar://problem/5452675> CrashTracer: [USER] 10 crashes in Mail at com.apple.WebCore: WebCore::Node::nodeIndex const + 6

        * editing/inserting/insert-paragraph-05.html: Added.
        * platform/mac/editing/inserting/insert-paragraph-05-expected.checksum: Added.
        * platform/mac/editing/inserting/insert-paragraph-05-expected.png: Added.
        * platform/mac/editing/inserting/insert-paragraph-05-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
antti [Tue, 4 Sep 2007 14:50:03 +0000 (14:50 +0000)]
WebCore:

        Reviewed by Maciej.

        Fix <rdar://problem/5452112>
        REGRESSION: Initially focused textfield on www.mac.com login page has no insertion point, and doesn't accept typed characters

        Use updateLayoutIgnorePendingStylesheets() instead of updateLayout(). We need to have rendering to set input focus.

        Test: fast/forms/focus-style-pending.html

        * dom/Element.cpp:
        (WebCore::Element::focus):

LayoutTests:

        Reviewed by Maciej.

        Test for <rdar://problem/5452112>
        REGRESSION: Initially focused textfield on www.mac.com login page has no insertion point, and doesn't accept typed characters

        * fast/forms/focus-style-pending-expected.txt: Added.
        * fast/forms/focus-style-pending.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixed Qt build on Windows
hausmann [Tue, 4 Sep 2007 13:02:04 +0000 (13:02 +0000)]
Fixed Qt build on Windows

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin Decker.
harrison [Mon, 3 Sep 2007 16:31:20 +0000 (16:31 +0000)]
    Reviewed by Kevin Decker.

        <rdar://problem/5456785> REGRESSION (r15963-r15970): Heading text not placed in VoiceOver Item Chooser (15132)

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject title]):
        For headings, return the text under the element instead of nil.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-08-20 Oleg Sukhodolsky <son.two@gmail.com>
zecke [Mon, 3 Sep 2007 13:48:57 +0000 (13:48 +0000)]
2007-08-20  Oleg Sukhodolsky <son.two@gmail.com>

        Reviewed by Mark.

        WebKitQt/WebCoreSupport should not be added to INCLUDEPATH for gdk-port

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-09-03 Mark Rowe <mrowe@apple.com>
bdash [Mon, 3 Sep 2007 09:56:30 +0000 (09:56 +0000)]
2007-09-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        <rdar://problem/5452164> Production build with in symbols directory has no debug info

        Enable debug symbol generation on all build configurations.  Production builds are stripped
        of symbols by Xcode during deployment post-processing.

        * Configurations/Base.xcconfig:
        * JavaScriptCore.xcodeproj/project.pbxproj:

2007-09-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        <rdar://problem/5452164> Production build with in symbols directory has no debug info

        Enable debug symbol generation on all build configurations.  Production builds are stripped
        of symbols by Xcode during deployment post-processing.

        * Configurations/Base.xcconfig:
        * JavaScriptGlue.xcodeproj/project.pbxproj:

2007-09-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        <rdar://problem/5452164> Production build with in symbols directory has no debug info

        Enable debug symbol generation on all build configurations.  Production builds are stripped
        of symbols by Xcode during deployment post-processing.

        * Configurations/Base.xcconfig:
        * WebCore.xcodeproj/project.pbxproj:

2007-09-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        <rdar://problem/5452164> Production build with in symbols directory has no debug info

        Enable debug symbol generation on all build configurations.  Production builds are stripped
        of symbols by Xcode during deployment post-processing.

        * Configurations/Base.xcconfig:
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson [Mon, 3 Sep 2007 01:37:26 +0000 (01:37 +0000)]
WebCore:

        Reviewed by John Sullivan and Mark Rowe

        Groundwork for support for monitoring IconDatabase in-memory statistics

        * WebCore.exp:
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::pageURLMappingCount): Stub for now
        (WebCore::IconDatabase::retainedPageURLCount): Ditto
        (WebCore::IconDatabase::iconRecordCount): Ditto
        (WebCore::IconDatabase::iconRecordCountWithData): Ditto
        * loader/icon/IconDatabase.h:

WebKit:

        Reviewed by John Sullivan and Mark Rowe

        Groundwork for support for monitoring IconDatabase in-memory statistics

        * Misc/WebCoreStatistics.h:
        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics iconPageURLMappingCount]):
        (+[WebCoreStatistics iconRetainedPageURLCount]):
        (+[WebCoreStatistics iconRecordCount]):
        (+[WebCoreStatistics iconsWithDataCount]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-09-02 Mark Rowe <mrowe@apple.com>
bdash [Mon, 3 Sep 2007 01:17:36 +0000 (01:17 +0000)]
2007-09-02  Mark Rowe  <mrowe@apple.com>

        Reviewed by Antti.

        <rdar://problem/5454704> WebKit seems to get too-narrow widths for "Monotype Corsiva", so lays out incorrectly

        * platform/mac/FontDataMac.mm:
        (WebCore::FontData::determinePitch): Work around NSFont incorrectly reporting Monotype Corsiva as fixed pitch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Sun, 2 Sep 2007 04:44:04 +0000 (04:44 +0000)]
WebCore:

        - rolled out fix for bug 12988 because it broke getElementById in a layout test
          I'm working on a new fix.

        * dom/Document.cpp: Rolled out.

LayoutTests:

        - rolled out the test case for 12988 until we re-fix it

        * fast/dom/duplicate-ids-document-order.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agogtk:
oliver [Sat, 1 Sep 2007 23:04:59 +0000 (23:04 +0000)]
gtk:

        Reviewed by Sam.

        <rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

        EditorClient::setInputMethodState stub

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::setInputMethodState):
        * WebCoreSupport/EditorClientGtk.h:

WebCore:

        Reviewed by Sam.

        <rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

        Adding a new EditorClient method so it is possible to inform WebKit of focus changes.
        Also added new virtual method Node::shouldUseInputMethod to allow us to trivially check
        whether an input method should be used when processing input for the currently focused
        Node.

        * bridge/EditorClient.h:
        * dom/Node.cpp:
        (WebCore::Node::shouldUseInputMethod):
        * dom/Node.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::shouldUseInputMethod):
        * html/HTMLInputElement.h:
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::shouldUseInputMethod):
        * html/HTMLTextAreaElement.h:
        * page/FocusController.cpp:
        (WebCore::FocusController::setFocusedNode):
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyEditorClient::setInputMethodState):

WebKit:

        Reviewed by Sam.

        <rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

        EditorClient::setInputMethodState stub

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::setInputMethodState):

WebKitQt:

        Reviewed by Sam.

        <rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

        EditorClient::setInputMethodState stub

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::setInputMethodState):
        * WebCoreSupport/EditorClientQt.h:

win:

        Reviewed by Sam.

        <rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions

        When focusing a password field or a non-editable element we disassociate any IME that may have
        been active, and reassociate should a non-password editable element is focused.

        This makes password input with an IME active simpler, and brings our IME behaviour in line with
        IE.

        * WebEditorClient.cpp:
        (WebEditorClient::setInputMethodState):
        * WebEditorClient.h:
        * WebView.cpp:
        (IMMDict::IMMDict):
        (WebView::setInputMethodState):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
rwlbuis [Sat, 1 Sep 2007 08:08:33 +0000 (08:08 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12988
        First element (in document order) is not returned when other duplicate ID-ed elements were created first

        Reset the element id cache when id's are added or removed and there
        are duplicates for that id.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
rwlbuis [Sat, 1 Sep 2007 07:43:31 +0000 (07:43 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=15083
        Some symbols in WebKit do not need to be exported

        Do not export these symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago <rdar://problem/5432594> Safari quits when hovering over mailto links on...
sfalken [Sat, 1 Sep 2007 05:44:27 +0000 (05:44 +0000)]
    <rdar://problem/5432594> Safari quits when hovering over mailto links on a webpage

        In addition to substituting %@ with %s, we also need to substitute %{1-9}$@ with %{1-9}$s.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBump version for submit
sfalken [Sat, 1 Sep 2007 00:56:07 +0000 (00:56 +0000)]
Bump version for submit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
aliceli1 [Fri, 31 Aug 2007 23:02:33 +0000 (23:02 +0000)]
WebCore:

        Reviewed by Tim Hatcher.

        Fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box

        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::show):
        Factored out the code in ::show() that created and styled the elements of the Deletion UI

        (WebCore::DeleteButtonController::createDeletionUI):
        Neglecting to move the append of the deletionUI elements into the same clause that handles the creation
        of them ended up creating multiple elements at were repeatedly appended to the target, resulting in a
        bloated table deletion UI which was slow to show and hide.

        * editing/DeleteButtonController.h:
        (WebCore::DeleteButtonController::enabled):
        Restore this function to how it used to be pre-r25305, sans asserts

        * editing/EditCommand.cpp:
        Add disable/enable sandwich when undoing/redoing commands too
        (WebCore::EditCommand::unapply):
        (WebCore::EditCommand::reapply):

LayoutTests:

        Reviewed by Tim Hatcher.

        Test for <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box

        * editing/deleting/deletionUI-single-instance.html: Added.
        * platform/mac/editing/deleting/deletionUI-single-instance-expected.checksum: Added.
        * platform/mac/editing/deleting/deletionUI-single-instance-expected.png: Added.
        * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
antti [Fri, 31 Aug 2007 22:09:03 +0000 (22:09 +0000)]
    Reviewed by Anders.

        Fix <rdar://problem/5452943>
        REGRESSION (r25283): Reproducible crash in HTMLObjectElement::getInstance under guard malloc

        Calling updateLayoutIgnorePendingStylesheets() may do arbitrary things to render tree so
        no RenderObjects can be cached over it.

        * html/HTMLEmbedElement.cpp:
        (WebCore::findWidgetRenderer):
        (WebCore::HTMLEmbedElement::getInstance):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::getInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
andersca [Fri, 31 Aug 2007 21:57:44 +0000 (21:57 +0000)]
    Reviewed by Mitz.

        <rdar://problem/5443936>
        Crash after QT movie completes playback at apple.com/imac

        If the plug-in or one of its children have focus, set it to NULL to prevent the web view window from getting the focus,
        which can cause a layout to happen while in HTMLObjectElement::detach. (This is what we do on the Mac).

        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginViewWin::setParent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele [Fri, 31 Aug 2007 18:51:05 +0000 (18:51 +0000)]
WebCore:

        Reviewed by Justin.

        Fix for <rdar://problem/5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)

        Test: editing/pasteboard/paste-plaintext-user-select-none.html

        * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering):
          Copy the user-select style from the current selection node and apply it so it is considered during the test rendering.
          This is important since we recently changed user-select to be inherited.  When we consider valid VisiblePositions for the test rendering,
          we need to have the correct user-select value that will actually be used for the real insertion.

LayoutTests:

        Reviewed by Justin.

        Test for <rdar://problem/5450600> REGRESSION: can't paste in textfield if its in a body that has user-select:none set (affects widgets)

        * editing/pasteboard/paste-plaintext-user-select-none-expected.txt: Added.
        * editing/pasteboard/paste-plaintext-user-select-none.html: Added.
        * fast/forms/textarea-paste-newline.html: Updated to escape '\n' in failure description.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
andersca [Fri, 31 Aug 2007 18:16:54 +0000 (18:16 +0000)]
    Reviewed by Oliver.

        <rdar://problem/5423939>
        http://bugs.webkit.org/show_bug.cgi?id=15013
        ASSERTION FAILED !m_inDestructor in WebCore::Shared<WebCore::PluginStreamWin>::ref() on Windows

        Protect the stream in case it's destroyed by the plug-in.

        * plugins/win/PluginStreamWin.cpp:
        (WebCore::PluginStreamWin::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
darin [Fri, 31 Aug 2007 16:13:54 +0000 (16:13 +0000)]
    Reviewed by Anders.

        - http://bugs.webkit.org/show_bug.cgi?id=15122

        * editing/htmlediting.cpp: (WebCore::avoidIntersectionWithNode):
        Change assertion so that it only fires when actually modifying the selection.
        This isn't nearly as helpful, because the old assertion could catch potential
        problems in more cases, but it's not obvious how to do better.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
oliver [Fri, 31 Aug 2007 04:33:05 +0000 (04:33 +0000)]
WebCore:

        Reviewed by Adam.

        <rdar://problem/5430772> REGRESSION(303-310A5) list items do not show with mouse over on istweb.apple.com/quack.apple.com

        VC++ treats bitfields as signed members, so Node::m_styleChange would be
        sign extended if it was assigned the value FullStyleChange.  This caused
        style recalculation to stop propagating.

        We work around this VC++ oddity by storing the enum as an unsigned, and
        casting back to StyleChangeType in the getter.

        Test: fast/css/hover-affects-child.html

        * dom/Node.h:
        (WebCore::Node::styleChangeType):

LayoutTests:

        Reviewed by Adam.

        Simple test case to ensure that hover affects are correctly propagated

        * fast/css/hover-affects-child-expected.txt: Added.
        * fast/css/hover-affects-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixing comma placement.
justing [Fri, 31 Aug 2007 01:40:25 +0000 (01:40 +0000)]
Fixing comma placement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
justing [Fri, 31 Aug 2007 01:36:55 +0000 (01:36 +0000)]
WebCore:

        Reviewed by Darin.

        <rdar://problem/5368833>
        REGRESSION: Pasting a triple-clicked line of quoted text at the top of a message adds an extra, quoted line

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertParagraphSeparator): Added an option for
        using a plain div to hold the new paragraph, instead of a clone of the previous
        block.
        * editing/CompositeEditCommand.h:
        * editing/InsertParagraphSeparatorCommand.cpp: Ditto.
        (WebCore::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): Ditto.
        (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
        * editing/InsertParagraphSeparatorCommand.h:
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Use a default block element when creating
        new paragraphs, so that empty paragraphs don't contain the block style of the previous
        one.
        Don't expand collapsed brs at the end of inserted content, this was the root of the bug.
        We'd copy <blockquote>hello<br></blockquote><br class="Apple-interchange-newline">
        and get an extra paragraph.  The removed code used to make sure that if the copied
        selection ends with a paragraph break that is represented in the copied markup by a
        regular br (not an interchange newline br), that that paragraph break appears in the
        pasted content, but shouldMergeEnd, which was introduced after this code was written,
        now takes care of that.
        (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Inserted content should always
        displace placeholder brs, even if that inserted content ends with a br.
        * editing/markup.cpp:
        (WebCore::needInterchangeNewlineAfter): This code failed to add an interchange newline
        if the user copied <div>hello</div><br>, only don't add an interchange newline when
        copying ^hello<br>^<br>, because then the copied paragraph break will already be
        represented in the copied markup by a br.
        (WebCore::createMarkup):

LayoutTests:

        Reviewed by Darin.

        <rdar://problem/5368833>
        REGRESSION: Pasting a triple-clicked line of quoted text at the top of a message adds an extra, quoted line

        Tested for behavior that we no longer want to have:
        * editing/pasteboard/quirks-mode-br-2-expected.checksum: Removed.
        * editing/pasteboard/quirks-mode-br-2-expected.png: Removed.
        * editing/pasteboard/quirks-mode-br-2-expected.txt: Removed.
        * editing/pasteboard/quirks-mode-br-2.html: Removed.

        * platform/mac/editing/pasteboard: Added.

        Demonstrates bug:
        * editing/pasteboard/5368833.html: Added.
        * platform/mac/editing/pasteboard/5368833-expected.checksum: Added.
        * platform/mac/editing/pasteboard/5368833-expected.png: Added.
        * platform/mac/editing/pasteboard/5368833-expected.txt: Added.

        Regenerated these expected results to reflect new behavior:
        * editing/pasteboard/paste-text-012-expected.checksum: Removed.
        * editing/pasteboard/paste-text-012-expected.png: Removed.
        * editing/pasteboard/paste-text-012-expected.txt: Removed.
        * editing/pasteboard/paste-text-013-expected.checksum: Removed.
        * editing/pasteboard/paste-text-016-expected.checksum: Removed.
        * editing/pasteboard/paste-text-016-expected.png: Removed.
        * editing/pasteboard/paste-text-016-expected.txt: Removed.
        * platform/mac/editing/pasteboard/paste-text-012-expected.checksum: Added.
        * platform/mac/editing/pasteboard/paste-text-012-expected.png: Added.
        * platform/mac/editing/pasteboard/paste-text-012-expected.txt: Added.
        * platform/mac/editing/pasteboard/paste-text-013-expected.checksum: Added.
        * platform/mac/editing/pasteboard/paste-text-013-expected.png: Added.
        * platform/mac/editing/pasteboard/paste-text-013-expected.txt: Added.
        * platform/mac/editing/pasteboard/paste-text-016-expected.checksum: Added.
        * platform/mac/editing/pasteboard/paste-text-016-expected.png: Added.
        * platform/mac/editing/pasteboard/paste-text-016-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoVersioning.
bdash [Fri, 31 Aug 2007 00:58:57 +0000 (00:58 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
harrison [Fri, 31 Aug 2007 00:10:48 +0000 (00:10 +0000)]
    Reviewed by Darin.

        <rdar://problem/5423900> Seed: safari crashes on submit feedback page in -[WebCoreAXObject isAttachment]

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject isAttachment]):
        Add nil check since element could be detached.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-08-30 Mitz Pettel <mitz@webkit.org>
bdash [Thu, 30 Aug 2007 22:38:20 +0000 (22:38 +0000)]
2007-08-30  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13282
          <rdar://problem/5126392> REGRESSION (NativePopUp): Rightmost character cut off in pop-up menu

        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::updateOptionsWidth): When measuring option text, use
        the same WebCore run rounding behavior that is used to draw it in the popup button.

2007-08-30  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - updated test results for http://bugs.webkit.org/show_bug.cgi?id=13282
          <rdar://problem/5126392> REGRESSION (NativePopUp): Rightmost character cut off in pop-up menu

        * editing/pasteboard/4641033-expected.checksum:
        * editing/pasteboard/4641033-expected.png:
        * editing/pasteboard/4641033-expected.txt:
        * fast/forms/HTMLOptionElement_label02-expected.checksum:
        * fast/forms/HTMLOptionElement_label02-expected.png:
        * fast/forms/HTMLOptionElement_label02-expected.txt:
        * fast/forms/HTMLOptionElement_label03-expected.checksum:
        * fast/forms/HTMLOptionElement_label03-expected.png:
        * fast/forms/HTMLOptionElement_label03-expected.txt:
        * fast/forms/control-restrict-line-height-expected.checksum:
        * fast/forms/control-restrict-line-height-expected.png:
        * fast/forms/control-restrict-line-height-expected.txt:
        * fast/forms/menulist-restrict-line-height-expected.checksum:
        * fast/forms/menulist-restrict-line-height-expected.png:
        * fast/forms/menulist-restrict-line-height-expected.txt:
        * fast/forms/menulist-width-change-expected.checksum:
        * fast/forms/menulist-width-change-expected.png:
        * fast/forms/menulist-width-change-expected.txt:
        * fast/forms/select-change-listbox-to-popup-expected.checksum:
        * fast/forms/select-change-listbox-to-popup-expected.png:
        * fast/forms/select-change-listbox-to-popup-expected.txt:
        * fast/forms/select-disabled-appearance-expected.checksum:
        * fast/forms/select-disabled-appearance-expected.png:
        * fast/forms/select-disabled-appearance-expected.txt:
        * fast/forms/stuff-on-my-optgroup-expected.checksum:
        * fast/forms/stuff-on-my-optgroup-expected.png:
        * fast/forms/stuff-on-my-optgroup-expected.txt:
        * fast/parser/document-write-option-expected.checksum:
        * fast/parser/document-write-option-expected.png:
        * fast/parser/document-write-option-expected.txt:
        * http/tests/navigation/anchor-basic-expected.txt:
        * http/tests/navigation/anchor-frames-expected.txt:
        * http/tests/navigation/anchor-goback-expected.checksum:
        * http/tests/navigation/anchor-goback-expected.png:
        * http/tests/navigation/anchor-goback-expected.txt:
        * http/tests/navigation/anchor-subframeload-expected.txt:
        * http/tests/navigation/javascriptlink-basic-expected.checksum:
        * http/tests/navigation/javascriptlink-basic-expected.png:
        * http/tests/navigation/javascriptlink-basic-expected.txt:
        * http/tests/navigation/javascriptlink-frames-expected.txt:
        * http/tests/navigation/javascriptlink-goback-expected.checksum:
        * http/tests/navigation/javascriptlink-goback-expected.png:
        * http/tests/navigation/javascriptlink-goback-expected.txt:
        * http/tests/navigation/javascriptlink-subframeload-expected.txt:
        * http/tests/navigation/metaredirect-basic-expected.checksum:
        * http/tests/navigation/metaredirect-basic-expected.png:
        * http/tests/navigation/metaredirect-basic-expected.txt:
        * http/tests/navigation/metaredirect-frames-expected.txt:
        * http/tests/navigation/metaredirect-goback-expected.checksum:
        * http/tests/navigation/metaredirect-goback-expected.png:
        * http/tests/navigation/metaredirect-goback-expected.txt:
        * http/tests/navigation/metaredirect-subframeload-expected.txt:
        * http/tests/navigation/post-goback2-expected.checksum:
        * http/tests/navigation/post-goback2-expected.png:
        * http/tests/navigation/post-goback2-expected.txt:
        * http/tests/navigation/postredirect-goback2-expected.checksum:
        * http/tests/navigation/postredirect-goback2-expected.png:
        * http/tests/navigation/postredirect-goback2-expected.txt:
        * http/tests/navigation/redirect302-basic-expected.checksum:
        * http/tests/navigation/redirect302-basic-expected.png:
        * http/tests/navigation/redirect302-basic-expected.txt:
        * http/tests/navigation/redirect302-frames-expected.txt:
        * http/tests/navigation/redirect302-goback-expected.checksum:
        * http/tests/navigation/redirect302-goback-expected.png:
        * http/tests/navigation/redirect302-goback-expected.txt:
        * http/tests/navigation/redirect302-subframeload-expected.txt:
        * http/tests/navigation/relativeanchor-basic-expected.txt:
        * http/tests/navigation/relativeanchor-frames-expected.txt:
        * http/tests/navigation/relativeanchor-goback-expected.txt:
        * http/tests/navigation/slowmetaredirect-basic-expected.checksum:
        * http/tests/navigation/slowmetaredirect-basic-expected.png:
        * http/tests/navigation/slowmetaredirect-basic-expected.txt:
        * http/tests/navigation/slowtimerredirect-basic-expected.checksum:
        * http/tests/navigation/slowtimerredirect-basic-expected.png:
        * http/tests/navigation/slowtimerredirect-basic-expected.txt:
        * http/tests/navigation/success200-basic-expected.checksum:
        * http/tests/navigation/success200-basic-expected.png:
        * http/tests/navigation/success200-basic-expected.txt:
        * http/tests/navigation/success200-frames-expected.txt:
        * http/tests/navigation/success200-frames-loadsame-expected.txt:
        * http/tests/navigation/success200-goback-expected.checksum:
        * http/tests/navigation/success200-goback-expected.png:
        * http/tests/navigation/success200-goback-expected.txt:
        * http/tests/navigation/success200-loadsame-expected.checksum:
        * http/tests/navigation/success200-loadsame-expected.png:
        * http/tests/navigation/success200-loadsame-expected.txt:
        * http/tests/navigation/success200-reload-expected.checksum:
        * http/tests/navigation/success200-reload-expected.png:
        * http/tests/navigation/success200-reload-expected.txt:
        * http/tests/navigation/success200-subframeload-expected.txt:
        * http/tests/navigation/timerredirect-basic-expected.checksum:
        * http/tests/navigation/timerredirect-basic-expected.png:
        * http/tests/navigation/timerredirect-basic-expected.txt:
        * http/tests/navigation/timerredirect-frames-expected.txt:
        * http/tests/navigation/timerredirect-goback-expected.checksum:
        * http/tests/navigation/timerredirect-goback-expected.png:
        * http/tests/navigation/timerredirect-goback-expected.txt:
        * http/tests/navigation/timerredirect-subframeload-expected.txt:
        * tables/mozilla/bugs/bug33855-expected.checksum:
        * tables/mozilla/bugs/bug33855-expected.png:
        * tables/mozilla/bugs/bug33855-expected.txt:
        * tables/mozilla/dom/tableDom-expected.checksum:
        * tables/mozilla/dom/tableDom-expected.png:
        * tables/mozilla/dom/tableDom-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
        * tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-08-30 Riku Voipio <riku.voipio@iki.fi>
bdash [Thu, 30 Aug 2007 22:33:39 +0000 (22:33 +0000)]
2007-08-30  Riku Voipio  <riku.voipio@iki.fi>

        Reviewed by Dave Kilzer.

        Better ARM defines.

        * kjs/ustring.h: Update comments to reflect the change and update test
        to fit changes to Platform.h.
        * wtf/Platform.h: Forced packing is only needed on oldabi ARM.
        Set middle-endian floats only for little-endian oldabi ARM.
        Set big-endian define for big-endian ARM.

2007-08-30  Riku Voipio  <riku.voipio@iki.fi>

        Reviewed by Dave Kilzer.

        Better ARM defines.

        * platform/DeprecatedString.h: Update comments to reflect the
        change and update test to fit changes to Platform.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim.
mjs [Thu, 30 Aug 2007 21:14:08 +0000 (21:14 +0000)]
    Reviewed by Tim.

        <rdar://problem/5439953> REGRESSION: Cannot load feeds in widgets in Dashcode due to change in WebKit delegate methods

        * WebView/WebFrame.mm:
        (-[WebFrame _attachScriptDebugger]): Don't create the debugger object if the frame has not yet
        created its script interpreter, to avoid premature dispatch of windowScriptObjectAvailable/Cleared
        delegate methods. The script debugger will be created in any case when the window object does appear.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Hatcher.
darin [Thu, 30 Aug 2007 18:06:06 +0000 (18:06 +0000)]
    Reviewed by Tim Hatcher.

        - fix http://bugs.webkig.org/show_bug.cgi?id=14981
          DEBUG builds of WebKit hang videwing Yahoo! Mail messages
          with ~5 MB text attachment

        * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::checkConsistency):
        * rendering/RenderFlow.cpp: (WebCore::RenderFlow::checkConsistency):
        * rendering/RenderText.cpp: (WebCore::RenderText::checkConsistency):
        Put the actual consistency check inside an ifdef. If you need it you can
        turn it on. There's still some function call overhead in builds that don't
        have NDEBUG defined, but that's worth it so we can turn this on and off
        without recompiling the world.

        - small code style improvement to recently changed function

        * editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer):
        Use a typedef and make_pair to make the code dealing with the pair simpler to read.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUse QKeySequence::StandardKey for the page wise scrolling shortcuts.
hausmann [Thu, 30 Aug 2007 14:44:54 +0000 (14:44 +0000)]
Use QKeySequence::StandardKey for the page wise scrolling shortcuts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWhen scrolling with the keyboard don't call update() on the entire widget.
hausmann [Thu, 30 Aug 2007 14:44:52 +0000 (14:44 +0000)]
When scrolling with the keyboard don't call update() on the entire widget.
The scrollbar/scrollview implementation is already smart enough to scroll with bitblt
on a value change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix scrolling with the keyboard if only one of the two scrollbars is visible.
hausmann [Thu, 30 Aug 2007 14:44:49 +0000 (14:44 +0000)]
Fix scrolling with the keyboard if only one of the two scrollbars is visible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix Qt/Gdk build.
hausmann [Thu, 30 Aug 2007 14:26:02 +0000 (14:26 +0000)]
Fix Qt/Gdk build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Antti.
antti [Thu, 30 Aug 2007 13:12:46 +0000 (13:12 +0000)]
    Reviewed by Antti.

        - fix <rdar://problem/5423270> CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore:
          WebCore::plainTextToMallocAllocatedBuffer + 762

        * editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer):
        Check for a malloc failure and exit the function if it failed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
andersca [Thu, 30 Aug 2007 01:32:14 +0000 (01:32 +0000)]
    Reviewed by Oliver.

        <rdar://problem/5404329>
        Plugin content starves WM_TIMER events on UI thread (affects idle behavior of app) on http://www.vincent-vella.com/, http://www.sagmeister.com/

        Add a tiny delay to invalidation timer to prevent it from starving other timers.

        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginViewWin::invalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Hatcher.
darin [Thu, 30 Aug 2007 00:45:52 +0000 (00:45 +0000)]
    Reviewed by Tim Hatcher.

        - fix <rdar://problem/4582212> WebKit inappropriately adds +initialize to
          NSPasteboard via a category, prevents AppKit initialize
          http://bugs.webkit.org/show_bug.cgi?id=9417

        * Misc/WebNSPasteboardExtras.h: Got rid of the global data objects and replaced
        them with global functions.

        * Misc/WebNSPasteboardExtras.mm:
        (initializePasteboardTypes): Changed the initialize method to be this function.
        (WebURLPasteboardType): Added, calls the initialize function and then returns
        the value of the global.
        (WebURLNamePasteboardType): Ditto.
        (+[NSPasteboard _web_writableTypesForURL]): Changed to call the new function instead
        of getting at the global directly.
        (+[NSPasteboard _web_dragTypesForURL]): Ditto.
        (-[NSPasteboard _web_writeURL:andTitle:types:]): Ditto.
        * WebCoreSupport/WebPasteboardHelper.mm:
        (WebPasteboardHelper::urlFromPasteboard): Ditto.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.

        * WebView/WebView.mm:
        (+[WebView initialize]): Added a call to one of the functions to take advantage
        of the side effect that initializes the globals; this is to help out old versions
        of Safari.
        (+[WebView URLTitleFromPasteboard:]): Changed to call the new function instead
        of getting at the global directly.

        * WebKit.exp: Add exports of the new functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
darin [Thu, 30 Aug 2007 00:32:10 +0000 (00:32 +0000)]
    Reviewed by Adele.

        * editing/htmlediting.cpp: (WebCore::avoidIntersectionWithNode):
        Fix an assert that was firing for me all the time when doing editing operations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca [Thu, 30 Aug 2007 00:23:37 +0000 (00:23 +0000)]
    Reviewed by Adam.

        <rdar://problem/5386098>
        Repro hang with some Flash plugin content (http://dougmccune.com/blog/2007/07/25/coming-to-flexcamp-at-adobe/)

        In some cases, Flash ends up starving the main loop by sending a lot of WM_USER + 1 messages. Throttle these
        messages so they won't end up hanging the web browser.

        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
        (WebCore::PluginMessageThrottlerWin::~PluginMessageThrottlerWin):
        (WebCore::PluginMessageThrottlerWin::appendMessage):
        (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
        (WebCore::PluginMessageThrottlerWin::allocateMessage):
        (WebCore::PluginMessageThrottlerWin::isInlineMessage):
        (WebCore::PluginMessageThrottlerWin::freeMessage):
        (WebCore::PluginViewWndProc):
        (WebCore::PluginViewWin::wndProc):
        (WebCore::PluginViewWin::determineQuirks):
        * plugins/win/PluginViewWin.h:
        (WebCore::):
        (WebCore::PluginViewWin::pluginWndProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
bdakin [Wed, 29 Aug 2007 23:15:08 +0000 (23:15 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/5436800> REGRESSION: PLT is 1.5% slower due
        to r24593 and r25098

        In r25098, we only called setCreatedByParser for XML! This patch
        calls it for HTML too, and takes care of the performance
        regression.

        * html/HTMLElementFactory.cpp:
        (WebCore::styleConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
antti [Wed, 29 Aug 2007 22:46:41 +0000 (22:46 +0000)]
WebCore:

        Reviewed by Mitz.

        Fix <rdar://problem/5425951>
        REGRESSION: change to updateLayoutIgnorePendingStylesheets causes SAP Portal page to render wrong

        If new nodes have been added or style recalc has been done with style sheets still pending, some nodes
        may not have had their real style calculated yet. Normally this state gets cleaned when style sheets arrive
        but in updateLayoutIgnorePendingStylesheets() we need to do full style recalc to get up-to-date style immediatly.

        Added a document flag to track if there are any nodes that did not have their real style calculated due to
        pending stylesheets.

        Test: fast/dynamic/style-access-late-stylesheet-load.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::styleForElement):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::recalcStyle):
        (WebCore::Document::updateLayoutIgnorePendingStylesheets):
        * dom/Document.h:
        (WebCore::Document::setHasNodesWithPlaceholderStyle):

LayoutTests:

        Reviewed by Mitz.

        Test for <rdar://problem/5425951>
        REGRESSION: change to updateLayoutIgnorePendingStylesheets causes SAP Portal page to render wrong

        * fast/dynamic/style-access-late-stylesheet-load-expected.txt: Added.
        * fast/dynamic/style-access-late-stylesheet-load.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
adele [Wed, 29 Aug 2007 22:05:24 +0000 (22:05 +0000)]
    Reviewed by Darin.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=15098
        <rdar://problem/5440319> REGRESSION (9A530-9A534): Double scroll bar on pdfs

        * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView):
         Don't suppress scrollbars before the view creation if we're making the view for a non-html view

        * WebView/WebFrameViewInternal.h: Make _scrollView return a WebDynamicScrollBarsView since so many clients were relying on it being that type anyway.
        * WebView/WebFrameView.mm:
        (-[WebFrameView _setDocumentView:]):
        (-[WebFrameView _scrollView]):
        (-[WebFrameView setAllowsScrolling:]):
        (-[WebFrameView allowsScrolling]):
        * WebView/WebView.mm:
        (-[WebView setAlwaysShowVerticalScroller:]):
        (-[WebView alwaysShowVerticalScroller]):
        (-[WebView setAlwaysShowHorizontalScroller:]):
        (-[WebView alwaysShowHorizontalScroller]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
aliceli1 [Wed, 29 Aug 2007 21:29:26 +0000 (21:29 +0000)]
    Reviewed by Maciej.

        We disable the DeleteButton UI before applying any editing commands.
        This patch simply moves those disable/enable calls to a more correct place, closer to the actual application of the editing command.

        * editing/EditCommand.cpp:
        (WebCore::EditCommand::apply):
        (WebCore::applyCommand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakComman...
aliceli1 [Wed, 29 Aug 2007 21:27:42 +0000 (21:27 +0000)]
    fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply()
                                       after dropping a selected image over container's close box

        Reviewed by Darin and Maciej.

        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::show):
        (WebCore::DeleteButtonController::hide):
        * editing/DeleteButtonController.h:
        (WebCore::DeleteButtonController::enabled):
        General changes made to DeleteButtonController: when hiding, it's not necessary to clear out
        the m_containerElement and m_target, especially since to fix this bug we need to keep
        their values around.  It's sufficient to just detach the container from target.

        * editing/EditCommand.cpp:
        (WebCore::EditCommand::EditCommand):
        Move the selection out of the deletion UI since we don't want to expose the deletion UI to any editing.

        * editing/Editor.cpp:
        (WebCore::Editor::rangeForPoint):
        Move the range out of the deletion UI since we don't want to expose the deletion UI to any editing.

        * editing/htmlediting.cpp:
        * editing/htmlediting.h:
        (WebCore::avoidIntersectionWithNode):
        Moved function that operates on Range from markup.cpp to here
        Added new implementation for function that operates on Selection

        * editing/markup.cpp:
        (WebCore::createMarkup):
        Moved function out of this file to htmlediting.cpp, and renamed to avoidIntersectionWithNode

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoTiger build fix.
hyatt [Wed, 29 Aug 2007 21:27:27 +0000 (21:27 +0000)]
Tiger build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25304 268f45cc-cd09-0410-ab3c-d52691b4dbfc