WebKit-https.git
9 years ago[Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
fsamuel@chromium.org [Wed, 30 Nov 2011 09:27:08 +0000 (09:27 +0000)]
[Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=73328

Reviewed by Kent Tamura.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::enableFixedLayoutMode):
(LayoutTestController::setFixedLayoutSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Added DEFAULT_CACHE_SIZE define.
commit-queue@webkit.org [Wed, 30 Nov 2011 09:22:10 +0000 (09:22 +0000)]
[EFL] Added DEFAULT_CACHE_SIZE define.
https://bugs.webkit.org/show_bug.cgi?id=73120

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-11-30
Reviewed by Filip Pizlo.

Remove form code 40960000 value used in code directly and replaced it by DEFAULT_CACHE_SIZE define. The code
looks cleaner now.

* ewk/ewk_tiled_matrix.cpp:
(ewk_tile_matrix_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJPEGImageDecoder: Code input color space case entries in numerical order
noel.gordon@gmail.com [Wed, 30 Nov 2011 09:12:24 +0000 (09:12 +0000)]
JPEGImageDecoder: Code input color space case entries in numerical order
https://bugs.webkit.org/show_bug.cgi?id=73287

Reviewed by Adam Barth.

No new tests. Covered by existing tests.

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode): JCS_YCbCr is one greater than JSC_RGB.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: fix transaction-basics layout test
dgrogan@chromium.org [Wed, 30 Nov 2011 09:07:29 +0000 (09:07 +0000)]
IndexedDB: fix transaction-basics layout test
https://bugs.webkit.org/show_bug.cgi?id=73302

Reviewed by Tony Chang.

- removed commitAndContinue in favor of transaction complete event
  handlers
- abort event handler no longer prints "complete event fired"
- addIDBObjectsAndCommit no longer overrides addIDBObjects
- removed starting a transaction from within a setversion transaction
- removed layoutTestController call and idb-specific done() in favor of
  finishJSTest and js-test-post include

* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-basics.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip tests on GTK presenting 1px differences since r101342.
philn@webkit.org [Wed, 30 Nov 2011 09:01:54 +0000 (09:01 +0000)]
Unreviewed, skip tests on GTK presenting 1px differences since r101342.

* platform/gtk/Skipped: Skip svg and tables tests failing on
64-bits but passing on 32-bits bot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFilterOperation* should stay in rendering/style, because it is directly referenced...
achicu@adobe.com [Wed, 30 Nov 2011 08:57:38 +0000 (08:57 +0000)]
FilterOperation* should stay in rendering/style, because it is directly referenced from RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=72539

Reviewed by Dean Jackson.

No new tests, just moving some files.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/style/CustomFilterOperation.h: Renamed from Source/WebCore/platform/graphics/filters/CustomFilterOperation.h.
* rendering/style/FilterOperation.h: Renamed from Source/WebCore/platform/graphics/filters/FilterOperation.h.
* rendering/style/FilterOperations.cpp: Renamed from Source/WebCore/platform/graphics/filters/FilterOperations.cpp.
* rendering/style/FilterOperations.h: Renamed from Source/WebCore/platform/graphics/filters/FilterOperations.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoResetting a put_by_id inline cache should preserve the "isDirect" bit
fpizlo@apple.com [Wed, 30 Nov 2011 08:44:12 +0000 (08:44 +0000)]
Resetting a put_by_id inline cache should preserve the "isDirect" bit
https://bugs.webkit.org/show_bug.cgi?id=73375

Reviewed by Gavin Barraclough.

For the replace case, we can find out if it was direct by looking at the
slow call. For the transition case, we explicitly remember if it was
direct.

* bytecode/CodeBlock.cpp:
(JSC::printStructureStubInfo):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):
* bytecode/StructureStubInfo.h:
(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::initPutByIdTransition):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCachePutByID):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::resetPatchPutById):
(JSC::JIT::isDirectPutById):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::resetPatchPutById):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Implement permission API for Qt port
commit-queue@webkit.org [Wed, 30 Nov 2011 08:41:19 +0000 (08:41 +0000)]
[Qt][WK2] Implement permission API for Qt port
https://bugs.webkit.org/show_bug.cgi?id=59200

Permission API hookup for Geolocation, it allows to receive in WebView
a signal when a permission request is done (e.g. to grant permission
for accessing geolocation information) and set it accordingly.

Patch by Adenilson Cavalcanti <adenilson.silva@openbossa.org> on 2011-11-30
Reviewed by Simon Hausmann.

.:

* Source/qtwebkit-export.map:

Source/WebKit/qt:

* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

* Target.pri:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebpermissionrequest.cpp: Added.
(QWebPermissionRequestPrivate::QWebPermissionRequestPrivate):
(QWebPermissionRequestPrivate::~QWebPermissionRequestPrivate):
(QWebPermissionRequest::create):
(QWebPermissionRequest::QWebPermissionRequest):
(QWebPermissionRequest::~QWebPermissionRequest):
(QWebPermissionRequest::type):
(QWebPermissionRequest::setAllow):
(QWebPermissionRequest::allow):
(QWebPermissionRequest::scheme):
(QWebPermissionRequest::host):
(QWebPermissionRequest::port):
* UIProcess/API/qt/qwebpermissionrequest_p.h: Added.
* UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/geolocation.html: Added.
* UIProcess/API/qt/tests/qmltests/qmltests.pro:
* UIProcess/qt/QtWebPageUIClient.cpp:
(QtWebPageUIClient::QtWebPageUIClient):
(QtWebPageUIClient::permissionRequest):
(QtWebPageUIClient::policyForGeolocationPermissionRequest):
* UIProcess/qt/QtWebPageUIClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip writing the result of diff_image since non-chromium ports don't implement diff_i...
hayato@chromium.org [Wed, 30 Nov 2011 08:17:19 +0000 (08:17 +0000)]
Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
https://bugs.webkit.org/show_bug.cgi?id=73381

Reviewed by Ryosuke Niwa.

This is a quick fix for the breakage of tests on non-chromium port.
We should implement diff_image later on non-chromium ports.

* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago-[WKView attributedSubstringForProposedRange:actualRange:] doesn't update actualRange...
ap@apple.com [Wed, 30 Nov 2011 08:11:24 +0000 (08:11 +0000)]
-[WKView attributedSubstringForProposedRange:actualRange:] doesn't update actualRange when it's out of bounds
https://bugs.webkit.org/show_bug.cgi?id=67813

Reviewed by Simon Fraser.

* UIProcess/API/mac/WKView.mm:
(-[WKView attributedSubstringForProposedRange:actualRange:]): Update actualRange to match
result length.
(-[WKView firstRectForCharacterRange:actualRange:]): Added a FIXME. This is harder to
implement, and it's unclear if clients care at this time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStorageEvent.key should not be nullable
haraken@chromium.org [Wed, 30 Nov 2011 08:07:45 +0000 (08:07 +0000)]
StorageEvent.key should not be nullable
https://bugs.webkit.org/show_bug.cgi?id=73125

Reviewed by Adam Barth.

Currently, document.createEvent('StorageEvent').key is evaluated as null.
However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent)
says that StorageEvent.key is not a nullable type, and thus
document.createEvent('StorageEvent').key should be '' (an empty string).

Source/WebCore:

* storage/StorageEvent.idl: Removed a [ConvertNullStringTo=Null] IDL from StorageEvent.key.

LayoutTests:

* storage/domstorage/events/basic-body-attribute-expected.txt: Updated the test result as described above.
* storage/domstorage/events/basic-expected.txt: Ditto.
* storage/domstorage/events/basic-setattribute-expected.txt: Ditto.
* storage/domstorage/events/script-tests/basic-body-attribute.js: Ditto.
(step6):
* storage/domstorage/events/script-tests/basic-setattribute.js: Ditto.
(step6):
* storage/domstorage/events/script-tests/basic.js: Ditto.
(step6):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for fill color not being applied inside visited links
commit-queue@webkit.org [Wed, 30 Nov 2011 07:56:23 +0000 (07:56 +0000)]
Fix for fill color not being applied inside visited links
https://bugs.webkit.org/show_bug.cgi?id=70434

Patch by Philip Rogers <pdr@google.com> on 2011-11-29
Reviewed by Antti Koivisto.

Source/WebCore:

Test: svg/custom/visited-link-color.svg

* rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::setFillPaint):
(WebCore::SVGRenderStyle::setStrokePaint):

LayoutTests:

* svg/custom/visited-link-color-expected.png: Added.
* svg/custom/visited-link-color-expected.txt: Added.
* svg/custom/visited-link-color.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[NRWT] Fix --platform=qt-5.0 --new-baseline combo
ossy@webkit.org [Wed, 30 Nov 2011 07:53:47 +0000 (07:53 +0000)]
[NRWT] Fix --platform=qt-5.0 --new-baseline combo
https://bugs.webkit.org/show_bug.cgi?id=72489

Patch by Balazs Ankes <Ankes.Balazs@stud.u-szeged.hu> on 2011-11-29
Reviewed by Eric Seidel.

Before the this fix always added "qt" option for the option list
* Scripts/run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/qt.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove RetainPtr::releaseRef
weinig@apple.com [Wed, 30 Nov 2011 06:03:13 +0000 (06:03 +0000)]
Remove RetainPtr::releaseRef
https://bugs.webkit.org/show_bug.cgi?id=73396

Reviewed by Dan Bernstein.

../JavaScriptCore:

* wtf/RetainPtr.h:
Be gone releaseRef! Long live leakRef!

../WebKit2:

* Platform/mac/ModuleMac.mm:
(WebKit::Module::unload):
Replace the final use of RetainPtr::releaseRef() with RetainPtr::leakRef(),
its sexy replacement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: chromium rebaseline for svg tests.
hayato@chromium.org [Wed, 30 Nov 2011 05:51:22 +0000 (05:51 +0000)]
Webkit gardening: chromium rebaseline for svg tests.
Unreviewed.

* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
* platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/absolute-sized-content-with-resources-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/animate-path-discrete-expected.png:
* platform/chromium-cg-mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
* platform/chromium-cg-mac-leopard/svg/text/bidi-text-anchor-direction-expected.png:
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/css/composite-shadow-example-expected.txt: Removed.
* platform/chromium-cg-mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
* platform/chromium-cg-mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/custom/linking-uri-01-b-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/custom/use-detach-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/foreignObject/text-tref-02-b-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/foreignObject/text-tref-02-b-expected.png.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
* platform/chromium-linux-x86/svg/text/bidi-text-anchor-direction-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt.
* platform/chromium-linux/svg/css/composite-shadow-example-expected.txt: Removed.
* platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
* platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.png:
* platform/chromium-linux/svg/hixie/perf/007-expected.png:
* platform/chromium-linux/svg/text/bidi-text-anchor-direction-expected.txt: Added.
* platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt.
* platform/chromium-mac-leopard/svg/css/composite-shadow-example-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.png: Added.
* platform/chromium-mac-leopard/svg/text/bidi-text-anchor-direction-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png:
* platform/chromium-mac-snowleopard/svg/foreignObject/text-tref-02-b-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/foreignObject/text-tref-02-b-expected.png.
* platform/chromium-mac/svg/css/composite-shadow-example-expected.txt: Removed.
* platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
* platform/chromium-win-vista/svg/css/composite-shadow-example-expected.txt: Removed.
* platform/chromium-win-vista/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
* platform/chromium-win-vista/svg/text/bidi-text-anchor-direction-expected.txt: Added.
* platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
* platform/chromium-win-xp/svg/css/composite-shadow-example-expected.txt: Removed.
* platform/chromium-win-xp/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
* platform/chromium-win-xp/svg/text/bidi-text-anchor-direction-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
* platform/chromium-win/svg/css/composite-shadow-example-expected.txt: Removed.
* platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
* platform/chromium-win/svg/hixie/perf/007-expected.png:
* platform/chromium/svg/css/composite-shadow-example-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/svg/css/composite-shadow-example-expected.txt.
* platform/chromium/svg/css/composite-shadow-with-opacity-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/svg/css/composite-shadow-with-opacity-expected.txt.
* platform/mac/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
* platform/win/svg/css/composite-shadow-example-expected.txt: Removed.
* platform/win/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
* svg/foreignObject/text-tref-02-b-expected.txt: Renamed from LayoutTests/platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd move semantics to RetainPtr
weinig@apple.com [Wed, 30 Nov 2011 05:42:14 +0000 (05:42 +0000)]
Add move semantics to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=73393

Reviewed by Anders Carlsson.

* wtf/RetainPtr.h:
(WTF::RetainPtr::RetainPtr):
Add a move constructor and move enabled assignment operators
to RetainPtr if the compiler being used supports rvalue
references. If the compiler does not support it, we fallback
to the copy semantics we have always had.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG local CSE may cause incorrect reference counting for a node
yuqiang.xian@intel.com [Wed, 30 Nov 2011 05:39:07 +0000 (05:39 +0000)]
DFG local CSE may cause incorrect reference counting for a node
https://bugs.webkit.org/show_bug.cgi?id=73390

Reviewed by Filip Pizlo.

When performing a node substitution, the ref count of the replaced
child will be increased, no matter whether the user node is skipped in
code generation or not. This will cause the reference count of the
replaced child never get the chance to become zero and so the
registers occupied by it cannot be reused simply without spilling, if
it's used by a "skipped" node.
This is a 1% gain on V8 benchmark, tested on IA32 Linux.

* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::performNodeCSE):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a way to revert a variable to its previous value after leaving a scope.
levin@chromium.org [Wed, 30 Nov 2011 05:36:03 +0000 (05:36 +0000)]
Add a way to revert a variable to its previous value after leaving a scope.
https://bugs.webkit.org/show_bug.cgi?id=73371

Reviewed by Adam Barth.

Source/JavaScriptCore:

In case anyone from Chromium sees this, it is nearly identical to AutoReset
but if the same name were used, it causes unnecessary ambiguity.

* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/TemporarilyChange.h: Added.
(WTF::TemporarilyChange::TemporarilyChange):
(WTF::TemporarilyChange::~TemporarilyChange):

Source/JavaScriptGlue:

* ForwardingHeaders/wtf/TemporarilyChange.h: Added.

Source/WebCore:

* ForwardingHeaders/wtf/TemporarilyChange.h: Added.

Source/WebKit/mac:

* ForwardingHeaders/wtf/TemporarilyChange.h: Added.

Tools:

* DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
* TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
* TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
(TestWebKitAPI::TEST): Added a test for TemporarilyChange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement [Supplemental] IDL and support it in run-bindings-tests
haraken@chromium.org [Wed, 30 Nov 2011 04:35:47 +0000 (04:35 +0000)]
Implement [Supplemental] IDL and support it in run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=73162

Reviewed by Adam Barth.

Source/WebCore:

- Overview:
    - Implement the [Supplemental] IDL in resolve-supplemental.pl and generate-bindings.pl.
    - Support the [Supplemental] IDL in run-bindings-tests.
    - Add TestSupplemental.idl as a binding test and confirm that it works.

- The spec for the [Supplemental] IDL: http://dev.w3.org/2006/webapi/WebIDL/#dfn-supplemental-interface

- This patch affects run-bindings-tests results only and does not affect any real builds
since no [Supplemental] IDL has been written in real WebCore IDL files for now.

- This patch makes a change on CodeGenerator*.pm to support the [Supplemental] IDL
for (custom) getters and setters.

- Added perl scripts implement the [Supplemental] IDL as follows:

    Previous build flow:
        foreach $idl (all IDL files) {
            generate-bindings.pl depends on $idl;
            generate-bindings.pl reads $idl;
            generate-bindings.pl generates .h and .cpp files for $idl;
        }

    New build flow (See the discussions in bug 72138 for more details):
        resolve-supplemental.pl depends on all IDL files;
        resolve-supplemental.pl reads all IDL files;
        resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
        resolve-supplemental.pl outputs supplemental_dependency.tmp;
        foreach $idl (all IDL files) {
            generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
            generate-bindings.pl reads $idl;
            generate-bindings.pl reads supplemental_dependency.tmp;
            generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files which are implementing $idl;
        }

Tests: bindings/scripts/test/TestSupplemental.idl

* bindings/scripts/generate-bindings.pl: The input is an IDL file |x| and the dependency file. generate-bindings.pl generates .h and .cpp files for the IDL file |x|, including all the attributes in the IDL files which are implementing the IDL file |x|. generate-bindings.pl addes the [ImplementedBy] IDL to the attributes with the [Supplemental] IDL in order to indicate what IDL is implementing the attributes.
* bindings/scripts/resolve-supplemental.pl: Added. resolve-supplemental.pl reads all IDL files, resolves [Supplemental=XXX] dependencies, and then outputs the dependency file. See the comment in resolve-supplemental.pl for the format of the dependency file.

* bindings/scripts/CodeGenerator.pm:
(GenerateConditionalStringFromAttributeValue): Avoids duplicated conditions.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): If an attribute is [ImplementedBy] another IDL, then we omit the declaration of the custom getter and setter.
(GenerateImplementation): If an attribute is [ImplementedBy] another IDL, then we call back the (custom) getter and setter of the IDL.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader): If an attribute is [ImplementedBy] another IDL, then we omit the declaration of the custom getter and setter.
(GenerateNormalAttrGetter): If an attribute is [ImplementedBy] another IDL, then we call back the getter of the IDL.
(GenerateNormalAttrSetter): If an attribute is [ImplementedBy] another IDL, then we call back the setter of the IDL.
(GenerateSingleBatchedAttribute): If an attribute is [ImplementedBy] another IDL, then we call back the custom getter or setter of the IDL.
* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation): If an attribute is [ImplementedBy] another IDL, then we call back the getter and setter of the IDL. CodeGeneratorCPP.pm does not support a custom getter and setter.
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperty): Ditto.
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation): Ditto.

* bindings/scripts/test/TestSupplemental.idl: Added. A test case for the [Supplemental] IDL.
* bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Updated a run-bindings-tests result.
(WebDOMTestInterface::str1):
(WebDOMTestInterface::str2):
(WebDOMTestInterface::setStr2):
* bindings/scripts/test/CPP/WebDOMTestInterface.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp: Ditto.
(webkit_dom_test_interface_get_str1):
(webkit_dom_test_interface_get_str2):
(webkit_dom_test_interface_set_str2):
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
(webkit_dom_test_interface_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h: Ditto.
* bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
(WebCore::jsTestInterfaceStr1):
(WebCore::jsTestInterfaceStr2):
(WebCore::jsTestInterfaceStr3):
(WebCore::JSTestInterface::put):
(WebCore::setJSTestInterfaceStr2):
(WebCore::setJSTestInterfaceStr3):
* bindings/scripts/test/JS/JSTestInterface.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestInterface.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestInterface.mm: Ditto.
(-[DOMTestInterface str1]):
(-[DOMTestInterface str2]):
(-[DOMTestInterface setStr2:]):
(-[DOMTestInterface str3]):
(-[DOMTestInterface setStr3:]):
* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore::TestInterfaceInternal::str1AttrGetter):
(WebCore::TestInterfaceInternal::str2AttrGetter):
(WebCore::TestInterfaceInternal::str2AttrSetter):
(WebCore::ConfigureV8TestInterfaceTemplate):

Tools:

run-bindings-tests supports the [Supplemental] IDL in the following way.
    (1) It creates a file |x| listing all IDL files.
    (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
    (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
        Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
        including all attributes in IDL files that are supplementing the IDL file |z|.

* Scripts/run-bindings-tests:
(generate_from_idl):
(generate_supplemental_dependency):
(detect_changes):
(run_tests):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream platform/network/blackberry/ProxyServerBlackBerry.cpp
leo.yang@torchmobile.com.cn [Wed, 30 Nov 2011 03:19:19 +0000 (03:19 +0000)]
Upstream platform/network/blackberry/ProxyServerBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=73288

Reviewed by Antonio Gomes.

Initial upstream, can't be built yet, no new tests.

* platform/network/blackberry/ProxyServerBlackBerry.cpp: Added.
(WebCore::proxyServersForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd COMPILER_SUPPORTS macro to allow for compiler feature testing
weinig@apple.com [Wed, 30 Nov 2011 03:05:09 +0000 (03:05 +0000)]
Add COMPILER_SUPPORTS macro to allow for compiler feature testing
https://bugs.webkit.org/show_bug.cgi?id=73386

Reviewed by Anders Carlsson.

* wtf/Compiler.h:
Add COMPILER_SUPPORTS and #defines for C++11 variadic templates and
rvalue references for Clang.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix clang build by using raw pointers instead of static OwnPtrs
nduca@chromium.org [Wed, 30 Nov 2011 02:29:34 +0000 (02:29 +0000)]
Unreviewed. Fix clang build by using raw pointers instead of static OwnPtrs
for WebCompositor managment.

* src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::initialize):
(WebKit::WebCompositorImpl::shutdown):
* src/WebCompositorImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list...
jberlin@webkit.org [Wed, 30 Nov 2011 02:29:06 +0000 (02:29 +0000)]
WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins
the first time it is called.
https://bugs.webkit.org/show_bug.cgi?id=73374 (<rdar://problem/10196057>)

Reviewed by Brady Eidson.

Source/WebCore:

Add a callback for when the Storage Tracker is done loading the list of origins with Local
Storage.

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::StorageTracker):
Keep track of whether the import from disk has been completed.
(WebCore::StorageTracker::notifyFinishedImportingOriginIdentifiersOnMainThread):
(WebCore::StorageTracker::finishedImportingOriginIdentifiers):
Set m_finishedImportingOriginIdentifiers to true and tell the client.
(WebCore::StorageTracker::syncImportOriginIdentifiers):
When finished, notify the shared StorageTracker on the main thread.
* storage/StorageTracker.h:
(WebCore::StorageTracker::originsLoaded):

* storage/StorageTrackerClient.h:
Add didFinishLoadingOrigins.

Source/WebKit/mac:

* Storage/WebStorageTrackerClient.h:
* Storage/WebStorageTrackerClient.mm:
(WebStorageTrackerClient::didFinishLoadingOrigins):

Source/WebKit2:

Queue any requests for the origins that have Local Storage until the StorageTracker is done
loading the list of those origins from disk.

* WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
(WebKit::keyValueStorageOriginIdentifiers):
Refactored here from getKeyValueStorageOrigins so it can be used by didFinishLoadingOrigins.
(WebKit::dispatchDidGetKeyValueStorageOrigins):
Ditto.
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
If the StorageTracker is not done loading the list of origins from disk, queue up the
request to be handled later.
(WebKit::WebKeyValueStorageManager::didFinishLoadingOrigins):
Dispatch the results for any requests that were make before the StorageTracker was done
loading the list of origins from disk.
(WebKit::WebKeyValueStorageManager::dispatchDidModifyOrigin):
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.h:

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Set the WebKeyValueStorageManager as the StorageTrackerClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
nduca@chromium.org [Wed, 30 Nov 2011 02:09:26 +0000 (02:09 +0000)]
[chromium] Enable threaded compositing via CCThreadProxy::hasThread only
https://bugs.webkit.org/show_bug.cgi?id=70838

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::layerRendererContext):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::enabled):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::context):
(WebCore::CCLayerTreeHost::setNeedsAnimate):
(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCProxy.cpp:
(WebCore::CCProxy::isMainThread):
(WebCore::CCProxy::isImplThread):
(WebCore::CCProxy::setMainThreadIsImplThread):
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::DebugScopedSetImplThread::DebugScopedSetImplThread):
(WebCore::DebugScopedSetImplThread::~DebugScopedSetImplThread):

Source/WebKit/chromium:

* public/WebCompositor.h:
* public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
* public/WebSettings.h:
* src/WebCompositorImpl.cpp:
(WebKit::WebCompositor::initialize):
(WebKit::WebCompositor::shutdown):
(WebKit::WebCompositor::fromIdentifier):
* src/WebKit.cpp:
(WebKit::initializeWithoutV8):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::composite):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
* src/WebSettingsImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::scheduleComposite):
(WebKit::WebViewImpl::graphicsContext3D):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::runTest):

Tools:

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::threadedCompositingEnabled):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::WebViewHost):
(WebViewHost::~WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Mac results after r101342.
simon.fraser@apple.com [Wed, 30 Nov 2011 01:44:00 +0000 (01:44 +0000)]
Update Mac results after r101342.

* platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
* platform/mac/transforms/svg-vs-css-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: chromium rebaseline.
zmo@google.com [Wed, 30 Nov 2011 01:20:23 +0000 (01:20 +0000)]
Webkit gardening: chromium rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: chromium rebaseline.
zmo@google.com [Wed, 30 Nov 2011 01:05:20 +0000 (01:05 +0000)]
Webkit gardening: chromium rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: chromium rebaseline.
zmo@google.com [Wed, 30 Nov 2011 00:54:50 +0000 (00:54 +0000)]
Webkit gardening: chromium rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r101363.
commit-queue@webkit.org [Wed, 30 Nov 2011 00:46:41 +0000 (00:46 +0000)]
Unreviewed, rolling out r101363.
http://trac.webkit.org/changeset/101363
https://bugs.webkit.org/show_bug.cgi?id=73373

checked in incorrect results (Requested by thorton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-29

* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
* platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
* platform/mac/svg/text/text-intro-05-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fix for Leopard compilation.
kevino@webkit.org [Wed, 30 Nov 2011 00:45:37 +0000 (00:45 +0000)]
[wx] Unreviewed build fix for Leopard compilation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebIDL: Add support for static for JSC and V8
arv@chromium.org [Wed, 30 Nov 2011 00:38:05 +0000 (00:38 +0000)]
WebIDL: Add support for static for JSC and V8
https://bugs.webkit.org/show_bug.cgi?id=72998

Reviewed by Adam Barth.

WebIDL uses "static" for class methods. We used to use "[ClassMethod]". This change makes us use the WebIDL syntax instead.

No new tests: Covered by existing tests.

* bindings/scripts/CodeGeneratorJS.pm:
(GetFunctionName): Use isStatic instead.
(GenerateOverloadedFunction): Ditto.
(GenerateImplementation): Ditto.
(GenerateParametersCheck): Ditto.
(GenerateImplementationFunctionCall): Ditto.
(GenerateConstructorDefinition): Ditto.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback): Ditto.
(GenerateImplementation): Ditto.
(GenerateFunctionCallString): Ditto.
* bindings/scripts/IDLParser.pm:
(ParseInterface): Set isStatic as needed.
* bindings/scripts/IDLStructure.pm: Update regular expression to parse "static".
* bindings/scripts/test/TestObj.idl: Use static instead of [ClassMethod].
* storage/IDBKeyRange.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: rebaseline.
zmo@google.com [Wed, 30 Nov 2011 00:30:48 +0000 (00:30 +0000)]
Webkit gardening: rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rebaselined a run-bindings-tests result.
haraken@chromium.org [Wed, 30 Nov 2011 00:30:19 +0000 (00:30 +0000)]
Unreviewed. Rebaselined a run-bindings-tests result.

* bindings/scripts/test/JS/JSFloat64Array.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago--webkit-visual-word should be able to reach end of text, instead of end of line
xji@chromium.org [Wed, 30 Nov 2011 00:23:23 +0000 (00:23 +0000)]
--webkit-visual-word should be able to reach end of text, instead of end of line
https://bugs.webkit.org/show_bug.cgi?id=72048

Reviewed by Ryosuke Niwa.

Source/WebCore:

Revert r92223 -- webkit-visual-word should reach boundary of line.
When there is no more left or right words in the same editing boundary and
current position is an editable position, return start or end position in this
editable content.

Test: editing/selection/move-by-word-visually-textarea.html

* editing/visible_units.cpp:
(WebCore::collectWordBreaksInBoxInsideBlockWithSameDirectionality):
(WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

LayoutTests:

* editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt:
* editing/selection/move-by-word-visually-inline-block-positioned-element.html:
* editing/selection/move-by-word-visually-multi-line-expected.txt:
* editing/selection/move-by-word-visually-multi-line.html:
* editing/selection/move-by-word-visually-single-space-inline-element-expected.txt:
* editing/selection/move-by-word-visually-textarea-expected.txt: Added.
* editing/selection/move-by-word-visually-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r101418.
commit-queue@webkit.org [Wed, 30 Nov 2011 00:19:58 +0000 (00:19 +0000)]
Unreviewed, rolling out r101418.
http://trac.webkit.org/changeset/101418
https://bugs.webkit.org/show_bug.cgi?id=73372

Chromium renderer crashes with ENABLE(MUTATION_OBSERVERS)
(Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-29

* public/platform/WebThread.h:
* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::shutdown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: rebaseline.
zmo@google.com [Wed, 30 Nov 2011 00:19:50 +0000 (00:19 +0000)]
Webkit gardening: rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: rebaseline.
zmo@google.com [Tue, 29 Nov 2011 23:49:09 +0000 (23:49 +0000)]
Webkit gardening: rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow WebCore to describe typed arrays to JSC
oliver@apple.com [Tue, 29 Nov 2011 23:36:33 +0000 (23:36 +0000)]
Allow WebCore to describe typed arrays to JSC
https://bugs.webkit.org/show_bug.cgi?id=73355

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Allow globaldata to track the structure of typed arrays.

* runtime/JSGlobalData.h:
(JSC::TypedArrayDescriptor::TypedArrayDescriptor):

Source/WebCore:

Update bindings codegen to report the data layout to JSC.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64Array::finishCreation):
* bindings/scripts/test/JS/JSFloat64Array.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoadd webkit_user_agent to DRT and webkit_unit_tests
dpranke@chromium.org [Tue, 29 Nov 2011 22:46:17 +0000 (22:46 +0000)]
add webkit_user_agent to DRT and webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=73362

Reviewed by Tony Chang.

In preparation for building webkit_glue as a separate component,
we need to explicitly declare DRT's and webkit_unit_tests'
dependencies on webkit_user_agent.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename some flexbox functions to be less confusing
tony@chromium.org [Tue, 29 Nov 2011 22:42:16 +0000 (22:42 +0000)]
Rename some flexbox functions to be less confusing
https://bugs.webkit.org/show_bug.cgi?id=73363

Reviewed by Ojan Vafai.

These methods no longer have anything to do with block/inline direction.

No new tests, just renaming some functions.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
* rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: rebaseline.
zmo@google.com [Tue, 29 Nov 2011 22:22:00 +0000 (22:22 +0000)]
Webkit gardening: rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: rebaseline svg tests.
zmo@google.com [Tue, 29 Nov 2011 22:08:09 +0000 (22:08 +0000)]
Webkit gardening: rebaseline svg tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for [ClassMethod] to CodeGeneratorJS.pm
arv@chromium.org [Tue, 29 Nov 2011 21:58:18 +0000 (21:58 +0000)]
Add support for [ClassMethod] to CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=73342

Reviewed by Adam Barth.

If a method is annotated with [ClassMethod] it will become a method on the JS constructor object and it will
call a static function on the C++ class.

This was previously only implemented in CodeGeneratorV8.pm so this brings JSC up to par.

No new tests: Covered by bindings/scripts/test/

* bindings/scripts/CodeGeneratorJS.pm:
(GetFunctionName): Refactor to reduce code duplication.
(GenerateHeader): Ditto.
(GenerateOverloadedFunction): This now handles both prototype functions and constructor functions.
(GenerateImplementation): Define class methods too.
(GenerateParametersCheck): Generate the right function access string.
(GenerateImplementationFunctionCall): SVG properties are not static methods.
(GenerateConstructorDefinition): For classes that have static methods we may now return function properties.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::getOwnPropertySlot): Ditto.
(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor): Ditto.
(WebCore::jsTestObjConstructorFunctionClassMethod): Now calls a static function.
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional): Ditto.
* bindings/scripts/test/JS/JSTestObj.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: rebaseline svg tests.
zmo@google.com [Tue, 29 Nov 2011 21:55:35 +0000 (21:55 +0000)]
Webkit gardening: rebaseline svg tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused JSDOMWrapperOwner
weinig@apple.com [Tue, 29 Nov 2011 21:47:11 +0000 (21:47 +0000)]
Remove unused JSDOMWrapperOwner
https://bugs.webkit.org/show_bug.cgi?id=73357

Reviewed by Adam Barth.

* bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
* bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::globalData):
Remove JSDOMWrapperOwner. It is unused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] WebKitMutationObserver::deliverAllMutations should be exposed through...
adamk@chromium.org [Tue, 29 Nov 2011 21:33:55 +0000 (21:33 +0000)]
[chromium] WebKitMutationObserver::deliverAllMutations should be exposed through the Chromium API
https://bugs.webkit.org/show_bug.cgi?id=71242

Reviewed by Darin Fisher.

Add addTaskObserver and removeTaskObserver to WebThread,
along with a new WebThread::TaskObserver interface.

For mutation observers, add a TaskObserver to the main thread
to deliver mutations after each task runs.

The Chromium side of this patch is http://codereview.chromium.org/8586038/

* public/platform/WebThread.h:
(WebKit::WebThread::TaskObserver::~TaskObserver):
* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::shutdown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up fast/regions/no-split-line-box.html test
tony@chromium.org [Tue, 29 Nov 2011 21:31:47 +0000 (21:31 +0000)]
Clean up fast/regions/no-split-line-box.html test
https://bugs.webkit.org/show_bug.cgi?id=73343

Patch by Alan Stearns <stearns@adobe.com> on 2011-11-29
Reviewed by Tony Chang.

* fast/regions/no-split-line-box.html:
* platform/efl/fast/regions/no-split-line-box-expected.png: Removed.
* platform/mac/fast/regions/no-split-line-box-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse contentsToRootView when converting the mouse coordinates for the context menu...
andersca@apple.com [Tue, 29 Nov 2011 21:29:18 +0000 (21:29 +0000)]
Use contentsToRootView when converting the mouse coordinates for the context menu key event
https://bugs.webkit.org/show_bug.cgi?id=73352

Reviewed by Adam Roben.

No new tests: Already covered by existing tests.

This is another step towards fixing https://bugs.webkit.org/show_bug.cgi?id=71945, by getting
rid of a call to ScrollView::contentsToWindow.

* page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEventForKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDecorate adoptWK with WARN_UNUSED_RETURN
andersca@apple.com [Tue, 29 Nov 2011 21:29:13 +0000 (21:29 +0000)]
Decorate adoptWK with WARN_UNUSED_RETURN
https://bugs.webkit.org/show_bug.cgi?id=73331

Reviewed by Sam Weinig.

* UIProcess/API/cpp/WKRetainPtr.h:
(WebKit::adoptWK):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDragClient::dragSourceActionMaskForPoint should use root view coordinates
andersca@apple.com [Tue, 29 Nov 2011 21:29:08 +0000 (21:29 +0000)]
DragClient::dragSourceActionMaskForPoint should use root view coordinates
https://bugs.webkit.org/show_bug.cgi?id=72409

Reviewed by Sam Weinig.

Source/WebCore:

* page/DragClient.h:
Rename parameter and remove obsolete comment.

* page/DragController.cpp:
(WebCore::DragController::delegateDragSourceAction):
* page/DragController.h:
Rename parameter.

* page/EventHandler.cpp:
(WebCore::EventHandler::updateDragSourceActionsAllowed):
Use contentsToRootView instead of contentsToWindow.

Source/WebKit/mac:

* WebCoreSupport/WebDragClient.mm:
(WebDragClient::dragSourceActionMaskForPoint):
Use -[WebView _convertPointFromRootView:] to convert the point to the web view coordinate system.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEditorClient::showCorrectionPanel should pass the string bounding box in root view...
andersca@apple.com [Tue, 29 Nov 2011 21:29:00 +0000 (21:29 +0000)]
EditorClient::showCorrectionPanel should pass the string bounding box in root view coordinates
https://bugs.webkit.org/show_bug.cgi?id=72408

Reviewed by Sam Weinig.

Source/WebCore:

Rename windowRectForRange to rootViewRectForRange and use contentsToRootView instead of contentsToWindow.

* editing/SpellingCorrectionController.cpp:
(WebCore::SpellingCorrectionController::show):
(WebCore::SpellingCorrectionController::correctionPanelTimerFired):
(WebCore::SpellingCorrectionController::rootViewRectForRange):
* editing/SpellingCorrectionController.h:

Source/WebKit/mac:

* WebCoreSupport/CorrectionPanel.mm:
(CorrectionPanel::show):
Convert the bounding rect to web view coordinates.

* WebView/WebView.mm:
(-[WebView _convertPointFromRootView:]):
(-[WebView _convertRectFromRootView:]):
* WebView/WebViewInternal.h:
Add helper methods for converting from root view coordinates to web view coordinates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix GTK+ WebKit2 build after r101312.
carlosgc@webkit.org [Tue, 29 Nov 2011 21:22:55 +0000 (21:22 +0000)]
Unreviewed. Fix GTK+ WebKit2 build after r101312.

* Scripts/generate-forwarding-headers.pl: Add blackberry to the
list of platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoinvalid cast in WebCore::toRenderBox / WebCore::RenderBox::firstChildBox
ojan@chromium.org [Tue, 29 Nov 2011 21:22:10 +0000 (21:22 +0000)]
invalid cast in WebCore::toRenderBox / WebCore::RenderBox::firstChildBox
https://bugs.webkit.org/show_bug.cgi?id=72668

Reviewed by David Hyatt.

Source/WebCore:

For new flexible boxes, we were setting childrenInline to true when
merging anonymous blocks, which we should never do. Do the same thing
we do for the deprecated flexboxes.

Test: css3/flexbox/anonymous-block-merge-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
* rendering/RenderObject.h:
(WebCore::RenderObject::setChildrenInline):
The default value of true was never used. Better to keep it explicit.

LayoutTests:

* css3/flexbox/anonymous-block-merge-crash-expected.txt: Added.
* css3/flexbox/anonymous-block-merge-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoList of builders in the flakiness dashboard is out of date
ojan@chromium.org [Tue, 29 Nov 2011 21:12:40 +0000 (21:12 +0000)]
List of builders in the flakiness dashboard is out of date
https://bugs.webkit.org/show_bug.cgi?id=73347

Reviewed by Adam Barth.

The chromium gpu bots no longer run layout tests, so kill that
group entirely.

* TestResultServer/static-dashboards/builders.js:
* TestResultServer/static-dashboards/dashboard_base.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: rebaseline svg tests.
zmo@google.com [Tue, 29 Nov 2011 21:07:12 +0000 (21:07 +0000)]
Webkit gardening: rebaseline svg tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't hard-code the list of WebKit2 generated sources
vestbo@webkit.org [Tue, 29 Nov 2011 20:47:28 +0000 (20:47 +0000)]
[Qt] Don't hard-code the list of WebKit2 generated sources

The generated sources are... wait for it... generated. So
use the generator itself to figure out which sources we need
to compile.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: rebaseline svg tests.
zmo@google.com [Tue, 29 Nov 2011 20:47:12 +0000 (20:47 +0000)]
Webkit gardening: rebaseline svg tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in IsolateTracker::addFakeRunIfNecessary(), preceded by assertion failure ...
rniwa@webkit.org [Tue, 29 Nov 2011 20:37:24 +0000 (20:37 +0000)]
Crash in IsolateTracker::addFakeRunIfNecessary(), preceded by assertion failure (m_nestedIsolateCount >= 1)
in IsolateTracker::exitIsolate()
https://bugs.webkit.org/show_bug.cgi?id=69275

Reviewed by Eric Seidel.

Source/WebCore:

The crash was caused by our false assumption that at most one isolated container exists between the start
and the root when appending a new run. Fixed the crash by computing the actual number of isolated containers
between the start and the root.

Test: fast/text/nested-bidi-isolate-crash.html

* rendering/InlineIterator.h:
(WebCore::numberOfIsolateAncestors):
(WebCore::IsolateTracker::IsolateTracker):
(WebCore::InlineBidiResolver::appendRun):

LayoutTests:

Add a regression test.

* fast/text/nested-bidi-isolate-crash-expected.txt: Added.
* fast/text/nested-bidi-isolate-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkit gardening: rebaseline svg tests.
zmo@google.com [Tue, 29 Nov 2011 20:31:11 +0000 (20:31 +0000)]
webkit gardening: rebaseline svg tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add a method to detect 'make dist' errors without running 'make dist'
mrobinson@webkit.org [Tue, 29 Nov 2011 20:30:17 +0000 (20:30 +0000)]
[GTK] Add a method to detect 'make dist' errors without running 'make dist'
https://bugs.webkit.org/show_bug.cgi?id=73216

Reviewed by Philippe Normand.

Add a script that tries to sniff out 'make dist' problems without running
'make dist.' 'make distcheck' takes a very long time to run and this should
reduce the amount of times it needs to be run consecutively.

* gtk/common.py:
(get_build_path.is_valid_build_directory): Guess the source directory
by the existence of the GNUmakefile instead of the .libs directory. This
allows one to run the script after running autogen.sh but before fully
building.
* gtk/find-make-dist-errors: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: rebaseline svg tests.
zmo@google.com [Tue, 29 Nov 2011 20:11:48 +0000 (20:11 +0000)]
Webkit gardening: rebaseline svg tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit gardening: rebaseline svn tests.
zmo@google.com [Tue, 29 Nov 2011 20:08:09 +0000 (20:08 +0000)]
Webkit gardening: rebaseline svn tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRevert that last change, apparently it destroys everything in the world.
oliver@apple.com [Tue, 29 Nov 2011 19:44:07 +0000 (19:44 +0000)]
Revert that last change, apparently it destroys everything in the world.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebase after r100819.
xji@chromium.org [Tue, 29 Nov 2011 19:31:09 +0000 (19:31 +0000)]
Rebase after r100819.

* platform/chromium-cg-mac-leopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Removed.
* platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Removed.
* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoflex-align:stretch + max-height needs to clamp to max-height and position appropriately
tony@chromium.org [Tue, 29 Nov 2011 19:07:57 +0000 (19:07 +0000)]
flex-align:stretch + max-height needs to clamp to max-height and position appropriately
https://bugs.webkit.org/show_bug.cgi?id=70780

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/flex-align-max.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth): When laying out columns, if the flex item is stretching,
we don't need to shrink wrap.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::isColumnFlow): Switch to RenderStyle helper method.
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection): For columns, we don't need to do anything.
For rows, handle max logical height by setting the height and recomputing (which will take max-height
into consideration).
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::isColumnFlexFlow): Helper method.

LayoutTests:

* css3/flexbox/flex-align-max-expected.txt: Added.
* css3/flexbox/flex-align-max.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove unused variable (gcc 4.6 complains about this)
tony@chromium.org [Tue, 29 Nov 2011 19:05:08 +0000 (19:05 +0000)]
[chromium] Remove unused variable (gcc 4.6 complains about this)
https://bugs.webkit.org/show_bug.cgi?id=73335

../../third_party/WebKit/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp:296:19:
error: variable 'oldReplicaMaskRect' set but not used [-Werror=unused-but-set-variable]

* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForRenderSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, other round of GTK rebaseline.
philn@webkit.org [Tue, 29 Nov 2011 18:56:40 +0000 (18:56 +0000)]
Unreviewed, other round of GTK rebaseline.

* platform/gtk/accessibility/dimensions-include-descendants-expected.txt: Added.
* platform/gtk/editing/execCommand/insertImage-expected.txt:
* platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
* platform/gtk/editing/selection/fake-drag-expected.txt: Added.
* platform/gtk/fast/forms/onselect-textarea-expected.txt: Added.
* platform/gtk/fast/table/multiple-captions-display-expected.txt:
* platform/gtk/plugins/embed-attributes-style-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDOM wrapper cache doesn't need to use JSDOMWrapper
oliver@apple.com [Tue, 29 Nov 2011 18:32:25 +0000 (18:32 +0000)]
DOM wrapper cache doesn't need to use JSDOMWrapper
https://bugs.webkit.org/show_bug.cgi?id=73333

Reviewed by Sam Weinig.

Make JSDOMWrapperCache use JSObject rather than JSDOMWrapper
and propagate the type change out.

* bindings/js/DOMWrapperWorld.h:
* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::toJSArrayBufferView):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDOMBinding.h:
(WebCore::setInlineCachedWrapper):
(WebCore::clearInlineCachedWrapper):
(WebCore::getCachedWrapper):
(WebCore::cacheWrapper):
(WebCore::wrap):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
(WebCore::toJS):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
* bindings/js/JSTrackCustom.cpp:
(WebCore::toJS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, another GTK svg rebaseline after r101342.
philn@webkit.org [Tue, 29 Nov 2011 18:26:14 +0000 (18:26 +0000)]
Unreviewed, another GTK svg rebaseline after r101342.

* platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
* platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Added.
* platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Added.
* platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Added.
* platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Added.
* platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Added.
* platform/gtk/svg/css/getComputedStyle-basic-expected.txt: Added.
* platform/gtk/svg/custom/image-small-width-height-expected.txt: Added.
* platform/gtk/svg/custom/pattern-rotate-expected.txt: Added.
* platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
* platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
* platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
* platform/gtk/svg/text/selection-background-color-expected.txt: Added.
* platform/gtk/svg/text/text-tselect-02-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK build fix after r101392.
philn@webkit.org [Tue, 29 Nov 2011 17:53:17 +0000 (17:53 +0000)]
Unreviewed, GTK build fix after r101392.

* GNUmakefile.am: USE_WEBAUDIO_FFTW was removed, don't use it anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] SIGSEV when a WebKitDownload fails
sergio@webkit.org [Tue, 29 Nov 2011 17:36:35 +0000 (17:36 +0000)]
[GTK] SIGSEV when a WebKitDownload fails
https://bugs.webkit.org/show_bug.cgi?id=72883

Reviewed by Xan Lopez.

After r100769 http status codes >= 400 trigger download
failures. We must ensure that the download is properly cancelled
before clearing the ResourceHandle client to avoid crashes.

* webkit/webkitdownload.cpp:
(DownloadClient::didReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] hide WebAudio build option until support for FFTW is removed
philn@webkit.org [Tue, 29 Nov 2011 17:34:50 +0000 (17:34 +0000)]
[GTK] hide WebAudio build option until support for FFTW is removed
https://bugs.webkit.org/show_bug.cgi?id=73295

Reviewed by Martin Robinson.

* configure.ac: Disable WebAudio until the FFTW dependency is removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK svg/W3C-I18N rebaseline.
philn@webkit.org [Tue, 29 Nov 2011 17:28:10 +0000 (17:28 +0000)]
Unreviewed, GTK svg/W3C-I18N rebaseline.

* platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed test_expectations update (added a bug ID).
senorblanco@chromium.org [Tue, 29 Nov 2011 17:21:56 +0000 (17:21 +0000)]
[chromium] Unreviewed test_expectations update (added a bug ID).

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed evening gardening.
ossy@webkit.org [Tue, 29 Nov 2011 17:10:40 +0000 (17:10 +0000)]
[Qt] Unreviewed evening gardening.

* platform/qt/Skipped:
 - Skip fast/block/child-not-removed-from-parent-lineboxes-crash.html because of https://bugs.webkit.org/show_bug.cgi?id=73250
 - Skip fast/dom/clone-node-style.html because of https://bugs.webkit.org/show_bug.cgi?id=73227
* platform/qt/svg/css/getComputedStyle-basic-expected.txt: Add Qt specific expected result after
  http://trac.webkit.org/changeset/101356/trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK fonts rebaseline after r101343.
philn@webkit.org [Tue, 29 Nov 2011 17:02:43 +0000 (17:02 +0000)]
Unreviewed, GTK fonts rebaseline after r101343.

* platform/gtk/fonts/complex-text-shadows-expected.txt:
* platform/gtk/fonts/cursive-expected.txt:
* platform/gtk/fonts/custom-font-missing-glyphs-expected.txt:
* platform/gtk/fonts/default-expected.txt:
* platform/gtk/fonts/fantasy-expected.txt:
* platform/gtk/fonts/font-face-with-complex-text-expected.txt:
* platform/gtk/fonts/font-with-no-valid-encoding-expected.txt:
* platform/gtk/fonts/fontconfig-aliasing-settings-expected.txt:
* platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt:
* platform/gtk/fonts/fontconfig-synthetic-oblique-expected.txt:
* platform/gtk/fonts/monospace-expected.txt:
* platform/gtk/fonts/sans-serif-expected.txt:
* platform/gtk/fonts/serif-expected.txt:
* platform/gtk/fonts/xsettings_antialias_settings-expected.txt:
* platform/gtk/fonts/zero-pixel-sized-fonts-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline of animations and fast after
philn@webkit.org [Tue, 29 Nov 2011 16:58:17 +0000 (16:58 +0000)]
Unreviewed, GTK rebaseline of animations and fast after
r101343. Also skip some failing fast/ ClientRect tests.

* platform/gtk/Skipped:
* platform/gtk/animations/additive-transform-animations-expected.txt:
* platform/gtk/animations/missing-values-first-keyframe-expected.txt:
* platform/gtk/animations/missing-values-last-keyframe-expected.txt:
* platform/gtk/animations/state-at-end-event-expected.txt:
* platform/gtk/fast/block/float/015-expected.txt:
* platform/gtk/fast/block/float/overhanging-tall-block-expected.txt:
* platform/gtk/fast/borders/rtl-border-05-expected.txt:
* platform/gtk/fast/css/word-space-extra-expected.txt:
* platform/gtk/fast/dom/34176-expected.txt:
* platform/gtk/fast/dom/inner-text-expected.txt:
* platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
* platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
* platform/gtk/fast/hidpi/broken-image-icon-hidpi-expected.txt:
* platform/gtk/fast/table/multiple-captions-display-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK media rebaseline after r101343.
philn@webkit.org [Tue, 29 Nov 2011 16:34:14 +0000 (16:34 +0000)]
Unreviewed, GTK media rebaseline after r101343.

* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/audio-repaint-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-expected.txt:
* platform/gtk/media/controls-without-preload-expected.txt:
* platform/gtk/media/media-controls-clone-expected.txt:
* platform/gtk/media/media-document-audio-repaint-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-frame-accurate-seek-expected.txt:
* platform/gtk/media/video-layer-crash-expected.txt:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-transformed-expected.txt:
* platform/gtk/media/video-zoom-controls-expected.txt:
* platform/gtk/media/video-zoom-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: TextPrompt should show suggest above or under so that it has maximal...
vsevik@chromium.org [Tue, 29 Nov 2011 16:24:47 +0000 (16:24 +0000)]
Web Inspector: TextPrompt should show suggest above or under so that it has maximal height.
https://bugs.webkit.org/show_bug.cgi?id=73239

Reviewed by Pavel Feldman.

Fixed suggest box vertical position / height calculation.
Added round corners when suggest box is positioned under text prompt.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPosition):
* inspector/front-end/inspector.css:
(.suggest-box.generic-suggest.under-anchor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove use of internal headers in the MiniBrowser
vestbo@webkit.org [Tue, 29 Nov 2011 16:18:13 +0000 (16:18 +0000)]
[Qt] Remove use of internal headers in the MiniBrowser

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix the GTK+ port build after r101307.
carlosgc@webkit.org [Tue, 29 Nov 2011 16:12:09 +0000 (16:12 +0000)]
Unreviewed. Fix the GTK+ port build after r101307.

Source/WebCore:

* GNUmakefile.list.am: Add missing files to compilation.

Source/WebKit2:

* GNUmakefile.am: Add missing files to compilation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix debug-shlib build without webkit2
hausmann@webkit.org [Tue, 29 Nov 2011 16:10:05 +0000 (16:10 +0000)]
[Qt] Fix debug-shlib build without webkit2

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: split Preferences into Preferences and Capabilities.
pfeldman@chromium.org [Tue, 29 Nov 2011 16:01:30 +0000 (16:01 +0000)]
Web Inspector: split Preferences into Preferences and Capabilities.
https://bugs.webkit.org/show_bug.cgi?id=73321

Source/WebCore:

Part of the Preferences defined in Settings.js are in fact backend capabilities.
Split them into two separate objects for further capabilities refactoring.

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerModel.js:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype._populateContextMenu):
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
* inspector/front-end/ProfileView.js:
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.populateImageSource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype._clearInterface):
* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
* inspector/front-end/StylesSidebarPane.js:
* inspector/front-end/inspector.js:

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

* src/js/DevTools.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add the infrastructure for enabling suspend/resume.
kenneth@webkit.org [Tue, 29 Nov 2011 15:56:04 +0000 (15:56 +0000)]
[Qt] Add the infrastructure for enabling suspend/resume.

Reviewed by Simon Hausmann.

Also, remove the painting optimization as it is broken in some
situations, as there is an assumption in that comparison that
the guards cannot be nested, which goes against the design and
its use.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):
(QQuickWebViewPrivate::_q_suspend):
(QQuickWebViewPrivate::_q_resume):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::scrollStateChanged):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureActive):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::itemSizeChanged):
* UIProcess/qt/QtViewportInteractionEngine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Custom fonts on surlybikes.com and boingboing.net do not load
mrobinson@webkit.org [Tue, 29 Nov 2011 15:49:58 +0000 (15:49 +0000)]
[GTK] Custom fonts on surlybikes.com and boingboing.net do not load
https://bugs.webkit.org/show_bug.cgi?id=69115

Reviewed by Gustavo Noronha Silva.

Instead of pretending to be Safari/Linux, pretend to be a Linux Chrome.
This fixes pages that assume that if a browser is Safari, but not OS X, it is
the iOS version of Safari.

* tests/testwebsettings.c:
(test_webkit_web_settings_user_agent): Update the test to reflect that the
user agent does not change.
* webkit/webkitwebsettings.cpp:
(chromeUserAgent): Renamed this from webkitUserAgent to more accurately
describe what it is.
(webkit_web_settings_class_init): Just use an empty string when initializing
the user agent to reduce code duplication.
(webkit_web_settings_set_property): Updated to reflect new method name.
(userAgentForURL): We don't need to special case Google Calendar any longer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed; new baselines for new test added in r101325.
senorblanco@chromium.org [Tue, 29 Nov 2011 15:49:04 +0000 (15:49 +0000)]
[chromium] Unreviewed; new baselines for new test added in r101325.

* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/accelerated-drawing: Added.
* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/accelerated-drawing: Added.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/accelerated-drawing: Added.
* platform/chromium-win/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Added.
* platform/chromium/platform/chromium/compositing/accelerated-drawing: Added.
* platform/chromium/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFinish up some miscellaneous GTK+ rebaselines after font metrics changes.
mrobinson@webkit.org [Tue, 29 Nov 2011 15:40:38 +0000 (15:40 +0000)]
Finish up some miscellaneous GTK+ rebaselines after font metrics changes.

* platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt:
* platform/gtk/transforms/2d/hindi-rotated-expected.txt:
* platform/gtk/transforms/2d/transform-borderbox-expected.txt:
* platform/gtk/transforms/2d/transform-fixed-container-expected.txt:
* platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
* platform/gtk/transforms/2d/zoom-menulist-expected.txt:
* platform/gtk/transforms/no_transform_hit_testing-expected.txt:
* platform/gtk/transforms/svg-vs-css-expected.txt:
* platform/gtk/transitions/default-timing-function-expected.txt:
* platform/gtk/transitions/move-after-transition-expected.txt:
* platform/gtk/transitions/svg-text-shadow-transition-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Make WebCore compile with Qt 5 and V8
hausmann@webkit.org [Tue, 29 Nov 2011 15:37:51 +0000 (15:37 +0000)]
[Qt] Make WebCore compile with Qt 5 and V8
https://bugs.webkit.org/show_bug.cgi?id=73313

Reviewed by Tor Arne Vestbø.

* DerivedSources.pri: Add missing V8 specific IDL files to the build.
* Target.pri: Ditto.
* bindings/v8/ScriptController.h: V8 NPAPI bindings don't really support
building with ENABLE_NETSCAPE_PLUGIN_API=0. These functions are always
defined, so they also need to be declared.
* platform/qt/PlatformSupportQt.cpp:
(WebCore::PlatformSupport::pluginScriptableObject): Don't return a
scriptable object when compiling without npapi.
* storage/StorageAreaImpl.cpp: Add missing Document.h include that is
included implicitly with the Chromium build but not with Qt.
* xml/XSLTProcessorQt.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFinish rebaselining table GTK+ results after metrics changes.
mrobinson@webkit.org [Tue, 29 Nov 2011 15:33:10 +0000 (15:33 +0000)]
Finish rebaselining table GTK+ results after metrics changes.

* platform/gtk/tables: Finish rebaselining tables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBegin rebaselining GTK+ results in the table directory after font
mrobinson@webkit.org [Tue, 29 Nov 2011 15:23:20 +0000 (15:23 +0000)]
Begin rebaselining GTK+ results in the table directory after font
metrics changes.

* platform/gtk/tables: Rebaseline tests in this directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-11-29 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 29 Nov 2011 15:16:22 +0000 (15:16 +0000)]
2011-11-29  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: fixing clang build.

        * inspector/InspectorBaseAgent.h:
        (WebCore::InspectorBaseAgentInterface::getAgentCapabilities):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::getAgentCapabilities):
        * inspector/InspectorDebuggerAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK dom/xhtml/level3 rebaseline after r101343.
philn@webkit.org [Tue, 29 Nov 2011 15:13:26 +0000 (15:13 +0000)]
Unreviewed, GTK dom/xhtml/level3 rebaseline after r101343.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFinish GTK+ SVG rebaselines.
mrobinson@webkit.org [Tue, 29 Nov 2011 15:11:26 +0000 (15:11 +0000)]
Finish GTK+ SVG rebaselines.

* platform/gtk/svg: Rebaseline more tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK editing/ rebaseline after r101343.
philn@webkit.org [Tue, 29 Nov 2011 15:05:49 +0000 (15:05 +0000)]
Unreviewed, GTK editing/ rebaseline after r101343.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoContinue updating WebKitGTK+ SVG baselines.
mrobinson@webkit.org [Tue, 29 Nov 2011 14:54:30 +0000 (14:54 +0000)]
Continue updating WebKitGTK+ SVG baselines.

* platform/gtk/svg: Continue updating results in this directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK fast/ rebaseline after r101343.
philn@webkit.org [Tue, 29 Nov 2011 14:46:07 +0000 (14:46 +0000)]
Unreviewed, GTK fast/ rebaseline after r101343.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: introduce generic capabilities concept, migrate debugger domain to...
pfeldman@chromium.org [Tue, 29 Nov 2011 14:43:10 +0000 (14:43 +0000)]
Web Inspector: introduce generic capabilities concept, migrate debugger domain to generic capabilities.
https://bugs.webkit.org/show_bug.cgi?id=73311

This step is necessary for getting rid of the 'capability' aspect in the Preferences. As a result,
single front-end will be applicable to multiple backend configurations.

Reviewed by Yury Semikhatsky.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/Inspector.json:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
* inspector/InspectorBaseAgent.cpp:
(WebCore::InspectorBaseAgentInterface::InspectorBaseAgentInterface):
(WebCore::InspectorBaseAgentInterface::~InspectorBaseAgentInterface):
* inspector/InspectorBaseAgent.h:
(WebCore::InspectorBaseAgentInterface::getCapabilities):
(WebCore::InspectorBaseAgentInterface::name):
(WebCore::InspectorBaseAgent::InspectorBaseAgent):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::getCapabilities):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
* inspector/InspectorMetaAgent.cpp: Added.
(WebCore::InspectorMetaAgent::~InspectorMetaAgent):
(WebCore::InspectorMetaAgent::getCapabilities):
(WebCore::InspectorMetaAgent::InspectorMetaAgent):
* inspector/InspectorMetaAgent.h: Added.
(WebCore::InspectorMetaAgent::create):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
* inspector/InspectorValues.h:
(WebCore::InspectorArray::begin):
(WebCore::InspectorArray::end):
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.enableDebugger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Make WebKit/qt build with V8 and Qt 5
hausmann@webkit.org [Tue, 29 Nov 2011 14:39:09 +0000 (14:39 +0000)]
[Qt] Make WebKit/qt build with V8 and Qt 5
https://bugs.webkit.org/show_bug.cgi?id=73315

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

For the Qt 5 / V8 build we use QJSEngine/QJSValue instead of
QScriptEngine/QScriptValue.

* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptController.h:
* bindings/v8/ScriptControllerQt.cpp:
(WebCore::ScriptController::qtScriptEngine):

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QtWebElementRuntime::initialize): #ifdef JSC code
properly. There's no V8 equivalent just yet.
* Api/qwebelement.h: Get rid of old V8 cruft.
* Api/qwebframe.cpp:
(QWebFrame::addToJavaScriptWindowObject): QScriptEngine -> QJSEngine.
(QWebFrame::evaluateJavaScript): Ditto.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(QtDRTNodeRuntime::initialize): #ifdef JSC code.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::didCreateScriptContext): Adapt to FrameLoaderClient
V8 API changes that happened long time ago.
(WebCore::FrameLoaderClientQt::willReleaseScriptContext): Ditto.
* WebCoreSupport/FrameLoaderClientQt.h: Ditto.
* WebCoreSupport/InspectorClientQt.cpp: Add missing include for V8 build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][V8] Add missing ExceptionCode.h include for SVG bindings
hausmann@webkit.org [Tue, 29 Nov 2011 14:36:39 +0000 (14:36 +0000)]
[Qt][V8] Add missing ExceptionCode.h include for SVG bindings
https://bugs.webkit.org/show_bug.cgi?id=73314

Reviewed by Kenneth Rohde Christiansen.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter): Similarly to other places where we use DOM
exceptions, make sure we include ExceptionCode.h here. It appears to be
an implicit inclusion in the Chromium build, but it should be explicit
like in the rest of the bindings.
(GenerateFunctionCallback): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: remove usage of innerHTML from inspector front-end
caseq@chromium.org [Tue, 29 Nov 2011 13:39:15 +0000 (13:39 +0000)]
Web Inspector: remove usage of innerHTML from inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=73305

Reviewed by Yury Semikhatsky.

* inspector/front-end/FontView.js:
(WebInspector.FontView.prototype._createContentIfNeeded):
* inspector/front-end/ShortcutsScreen.js:
(WebInspector.ShortcutsSection.prototype.addKey):
(WebInspector.ShortcutsSection.prototype.addRelatedKeys):
(WebInspector.ShortcutsSection.prototype.addAlternateKeys):
(WebInspector.ShortcutsSection.prototype._addLine):
(WebInspector.ShortcutsSection.prototype.renderSection):
(WebInspector.ShortcutsSection.prototype._renderSequence):
(WebInspector.ShortcutsSection.prototype._renderKey):
(WebInspector.ShortcutsSection.prototype.get _height):
(WebInspector.ShortcutsSection.prototype._createSpan):
(WebInspector.ShortcutsSection.prototype._joinNodes):
* inspector/front-end/WelcomeView.js:
(WebInspector.WelcomeView.prototype.addMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101364 268f45cc-cd09-0410-ab3c-d52691b4dbfc