WebKit-https.git
7 years agoVersioning.
bshafiei@apple.com [Thu, 10 Apr 2014 06:25:06 +0000 (06:25 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebVTT tests don't work because of a 800x600 snapshot (but are very flaky anyway)
ap@apple.com [Thu, 10 Apr 2014 06:17:05 +0000 (06:17 +0000)]
WebVTT tests don't work because of a 800x600 snapshot (but are very flaky anyway)
https://bugs.webkit.org/show_bug.cgi?id=131476

* platform/mac/TestExpectations: Skip them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build failure when #if USE(XPC_SERVICES) is false.
commit-queue@webkit.org [Thu, 10 Apr 2014 04:50:53 +0000 (04:50 +0000)]
Fix build failure when #if USE(XPC_SERVICES) is false.
https://bugs.webkit.org/show_bug.cgi?id=131474

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-04-09
Reviewed by Dan Bernstein.

Fix build.

* UIProcess/ios/WebProcessProxyIOS.mm:
Add #if around BackgroundTabFlags ForegroundTabFlags to prevent unused variable error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build failure.
jonlee@apple.com [Thu, 10 Apr 2014 04:42:34 +0000 (04:42 +0000)]
Fix build failure.
https://bugs.webkit.org/show_bug.cgi?id=131473

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-04-09
Reviewed by Dan Bernstein.

Fix build failure.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(mediaSelectionOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add API to set preferred languages
ryuan.choi@samsung.com [Thu, 10 Apr 2014 04:04:53 +0000 (04:04 +0000)]
[EFL][WK2] Add API to set preferred languages
https://bugs.webkit.org/show_bug.cgi?id=131435

Reviewed by Gyuyoung Kim.

Add ewk_context_preferred_languages_set to change the list of "Accept-Language".
This list is used to receive alternative version of contents, which is related
to specified languages from the contents provider.

* UIProcess/API/efl/ewk_context.cpp:
(ewk_context_preferred_languages_set):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(serverCallback):
(TEST_F): Added test case for ewk_context_preferred_languages_set

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTemporarily disable the JIT for the Windows port.
mark.lam@apple.com [Thu, 10 Apr 2014 03:55:29 +0000 (03:55 +0000)]
Temporarily disable the JIT for the Windows port.
<https://webkit.org/b/131470>

Reviewed by Brent Fulgham.

This is a temporary stop gap measure to green the Windows bots until
we have a fix for https://webkit.org/b/131182.

* runtime/Options.cpp:
(JSC::recomputeDependentOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[iOS][WK2] Add the initial WebProcess handling of animated resize for rotation
benjamin@webkit.org [Thu, 10 Apr 2014 03:39:33 +0000 (03:39 +0000)]
[iOS][WK2] Add the initial WebProcess handling of animated resize for rotation
https://bugs.webkit.org/show_bug.cgi?id=131469

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-09
Reviewed by Tim Horton.

Add the basic handling of dynamic resize from the WebProcess.

On animated resize, the UIProcess decides new target rects and scale. The information
is then passed to the WebProcess to update the content.

For various reason, the target rects and scale computed by the UIProcess can be incorrect
(for example, if viewport constraints limit the scale).

In those cases, the WebProcess has all the information to compute a better target. This patch
adds such a basic update mechanism.

Once the new values are computed, they are sent back to the UIProcess. If the rotation animation
is still ongoing, we do not want mess with it. What we do is set a temporary transform on the subviews
and restore the real value after the animation. The key is to have the two matrix multiplying to the end
value so that there is no visual difference.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:WebKit::]):
(-[WKWebView _dynamicViewportUpdateChangedTargetToScale:position:]):
(setViewportConfigurationMinimumLayoutSize):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _setMinimumLayoutSizeOverride:]):
(-[WKWebView _beginAnimatedResizeToSize:obscuredInsets:minimumLayoutSizeOverride:]):
(-[WKWebView _endAnimatedResize]):
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/API/ios/WKViewIOS.mm:
(-[WKView _frameOrBoundsChanged]):
(-[WKView setMinimumLayoutSizeOverride:]):
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::dynamicViewportUpdateChangedTarget):
* UIProcess/ios/WKContentView.h:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView setMinimumLayoutSize:]): Deleted.
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::dynamicViewportSizeUpdate):
(WebKit::WebPageProxy::dynamicViewportUpdateChangedTarget):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::dynamicViewportSizeUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[FTL] Emit multibyte NOPs on X86-64
commit-queue@webkit.org [Thu, 10 Apr 2014 02:38:12 +0000 (02:38 +0000)]
[FTL] Emit multibyte NOPs on X86-64
https://bugs.webkit.org/show_bug.cgi?id=131394

Patch by Juergen Ributzka <juergen@apple.com> on 2014-04-09
Reviewed by Michael Saboff.

* assembler/X86Assembler.h:
(JSC::X86Assembler::fillNops):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix after http://trac.webkit.org/changeset/167045
enrica@apple.com [Thu, 10 Apr 2014 01:47:51 +0000 (01:47 +0000)]
Unreviewed build fix after trac.webkit.org/changeset/167045

The file contained an invalid character.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[iOS] Media controls should resize as the user zooms
dino@apple.com [Thu, 10 Apr 2014 01:06:31 +0000 (01:06 +0000)]
[iOS] Media controls should resize as the user zooms
https://bugs.webkit.org/show_bug.cgi?id=131322

Reviewed by Eric Carlson.

On iOS the media controls should remain the same size
independent of user zoom. Have the HTMLMediaElement optionally
register for updates in the page scale to apply an inverse
scale.

* Modules/mediacontrols/MediaControlsHost.cpp: New exposed property that calls
back into HTMLMediaElement::mediaControlsDependOnPageScaleFactor.
(WebCore::MediaControlsHost::controlsDependOnPageScaleFactor):
(WebCore::MediaControlsHost::setControlsDependOnPageScaleFactor):
* Modules/mediacontrols/MediaControlsHost.h: Keep a reference to the actual
controls from the JavaScript side so we can talk to it later.
(WebCore::MediaControlsHost::controllerJSValue):
(WebCore::MediaControlsHost::setControllerJSValue):
* Modules/mediacontrols/MediaControlsHost.idl: Expose controlsDependOnPageScaleFactor.

* Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-panel): Specify the transform origin so that
scaling will keep the controls pinned to the bottom left corner.
(audio::-webkit-media-controls-start-playback-button): Update to the correct size
and provide new artwork.
(audio::-webkit-media-controls-start-playback-button.failed): New artwork.
* Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS): Tell the host that these controls care about the page scale.
(ControllerIOS.prototype.get pageScaleFactor): New getter.
(ControllerIOS.prototype.set pageScaleFactor): When set, update the play button and the panel.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript): Small naming cleanup.
(setPageScaleFactorProperty): Static helper to set a JS property value.
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): Keep a reference to the controls object,
and make sure to set the page scale factor on the controls.
(WebCore::HTMLMediaElement::pageScaleFactorChanged): Implement the callback, telling
the controls object that it needs to relayout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix iOS build.
antti@apple.com [Thu, 10 Apr 2014 00:51:28 +0000 (00:51 +0000)]
Try to fix iOS build.

* platform/graphics/ca/mac/TileController.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r165908): ~QuickLookHandle() tries to dereference a null ResourceHandle
aestes@apple.com [Thu, 10 Apr 2014 00:48:45 +0000 (00:48 +0000)]
REGRESSION (r165908): ~QuickLookHandle() tries to dereference a null ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=131467

Reviewed by Tim Horton.

QuickLookHandle stored a ResourceHandle pointer in order to later
retrive the URL of its firstRequest(), but after r165908 we no longer
always have a ResourceHandle. Since firstRequest()'s URL is the only
thing we need from ResourceHandle, store it directly rather than a
ResourceHandle pointer. In the case where we create a QuickLookHandle
from a ResourceLoader rather than a ResourceHandle, pass the loader's
originalRequest(), which represents the same request as firstRequest()
(i.e. the request after willSendRequest() but before redirects).

* platform/network/ios/QuickLook.h:
* platform/network/ios/QuickLook.mm:
(WebCore::QuickLookHandle::QuickLookHandle):
(WebCore::QuickLookHandle::create):
(WebCore::QuickLookHandle::didFail):
(WebCore::QuickLookHandle::~QuickLookHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Bug in AccessibilityNodeObject::helpText
commit-queue@webkit.org [Thu, 10 Apr 2014 00:18:49 +0000 (00:18 +0000)]
AX: Bug in AccessibilityNodeObject::helpText
https://bugs.webkit.org/show_bug.cgi?id=130386

Patch by James Craig <jcraig@apple.com> on 2014-04-09
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/help-text.html

Ancestor loop was always checking attribute of original node rather than current node.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::helpText):

LayoutTests:

Tests accessibility help text in a variety of examples.

* accessibility/help-text-expected.txt: Added.
* accessibility/help-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] Unreviewed bot maintenance. Re-add a number of passing
bfulgham@apple.com [Thu, 10 Apr 2014 00:10:30 +0000 (00:10 +0000)]
[Win] Unreviewed bot maintenance. Re-add a number of passing
tests, and turn off a few failures.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression: AX: list heuristics sometimes determined as presentational even when...
cfleizach@apple.com [Wed, 9 Apr 2014 23:51:28 +0000 (23:51 +0000)]
Regression: AX: list heuristics sometimes determined as presentational even when explicit roles applied
https://bugs.webkit.org/show_bug.cgi?id=131041

Reviewed by Mario Sanchez Prada.

Source/WebCore:

When display:table is used on a list item, it inserts RenderObjects that can be ignored as the children
of the list. This allows normal list heuristics to be applied.

* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored):

LayoutTests:

* accessibility/list-detection-expected.txt:
* accessibility/list-detection.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix the GTK+ build after resetDragOperation rename
mrobinson@webkit.org [Wed, 9 Apr 2014 23:37:39 +0000 (23:37 +0000)]
Try to fix the GTK+ build after resetDragOperation rename

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDragDataReceived): Rename resetDragOperation to resetDragSession.
(dragExitedCallback): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline some tests for GTK+
mrobinson@webkit.org [Wed, 9 Apr 2014 23:34:05 +0000 (23:34 +0000)]
Rebaseline some tests for GTK+

* platform/gtk/editing/input/scroll-viewport-page-up-down-expected.txt:
* platform/gtk/fast/text/international/cjk-segmentation-expected.txt: Added.
* platform/gtk/http/tests/xmlhttprequest/cache-override-expected.txt: Added.
* platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Added.
* platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
* platform/gtk/plugins/nested-plugin-objects-expected.txt: Added.
* platform/gtk/plugins/netscape-destroy-plugin-script-objects-expected.txt: Added.
* platform/gtk/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Added.
* platform/gtk/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
* platform/gtk/svg/custom/object-no-size-attributes-expected.txt:
* platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRolled back in r166972.
ggaren@apple.com [Wed, 9 Apr 2014 23:16:55 +0000 (23:16 +0000)]
Rolled back in r166972.

This time, we conditionally exclude linking against bmalloc in Production
builds. Production builds will not be able to link against bmalloc
until the Production build system has been updated to build bmalloc.

    WTF should link against bmalloc
    https://bugs.webkit.org/show_bug.cgi?id=131403

    Reviewed by Mark Rowe.

    * Configurations/WTF.xcconfig:
    * WTF.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPut bmalloc headers in the right place
ggaren@apple.com [Wed, 9 Apr 2014 23:11:22 +0000 (23:11 +0000)]
Put bmalloc headers in the right place
https://bugs.webkit.org/show_bug.cgi?id=131464

Reviewed by Mark Rowe.

../bmalloc:

* Configurations/bmalloc.xcconfig: Set PRIVATE_HEADERS_FOLDER_PATH to
specify that we don't just want to dump all of our generically-named
headers into /usr/local/include.

../WTF:

* wtf/FastMalloc.cpp: Use "<bmalloc/...>" syntax so we can find our
headers in <header-root>/usr/local/include/bmalloc/.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTileGrid should be PlatformCALayerClient instead of TileController
antti@apple.com [Wed, 9 Apr 2014 23:03:06 +0000 (23:03 +0000)]
TileGrid should be PlatformCALayerClient instead of TileController
https://bugs.webkit.org/show_bug.cgi?id=131456

Switch one more place to use removeTiles.

* platform/graphics/ca/mac/TileGrid.mm:
(WebCore::TileGrid::revalidateTiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove "System Font" from whitelisted DRT fonts and char width calculations
mmaxfield@apple.com [Wed, 9 Apr 2014 22:54:26 +0000 (22:54 +0000)]
Remove "System Font" from whitelisted DRT fonts and char width calculations
https://bugs.webkit.org/show_bug.cgi?id=131411

Reviewed by Tim Horton.

Covered by existing tests.

Source/WebCore:

* platform/graphics/Font.cpp:
(WebCore::Font::hasValidAverageCharWidth):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFullscreen does two view controller changes at once
commit-queue@webkit.org [Wed, 9 Apr 2014 22:35:12 +0000 (22:35 +0000)]
Fullscreen does two view controller changes at once
https://bugs.webkit.org/show_bug.cgi?id=131432

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-04-09
Reviewed by Eric Carlson.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
delay -presentViewController on the main run loop to allow
previous view controller change to complete.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable fullscreen captions selection
commit-queue@webkit.org [Wed, 9 Apr 2014 22:33:23 +0000 (22:33 +0000)]
Enable fullscreen captions selection
https://bugs.webkit.org/show_bug.cgi?id=131069

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-04-09
Reviewed by Eric Carlson.

Source/WebCore:

Enable media selection options from fullscreen. i.e. captions.

* WebCore.exp.in:
Add exports for
setAudioMediaSelectionOptions
setLegibleMediaSelectionOptions
selectAudioMediaOption
selectLegibleMediaOption

* platform/ios/WebVideoFullscreenInterface.h:
Add setAudioMediaSelectionOptions/setLegibleMediaSelectionOptions

* platform/ios/WebVideoFullscreenInterfaceAVKit.h:
Add setAudioMediaSelectionOptions/setLegibleMediaSelectionOptions

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
Add setAudioMediaSelectionOptions/setLegibleMediaSelectionOptions

(-[WebAVPlayerController dealloc]):
(-[WebAVPlayerController hasMediaSelectionOptions]):
(+[WebAVPlayerController keyPathsForValuesAffectingHasMediaSelectionOptions]):
(-[WebAVPlayerController hasAudioMediaSelectionOptions]):
(+[WebAVPlayerController keyPathsForValuesAffectingHasAudioMediaSelectionOptions]):
(-[WebAVPlayerController hasLegibleMediaSelectionOptions]):
(+[WebAVPlayerController keyPathsForValuesAffectingHasLegibleMediaSelectionOptions]):
(-[WebAVPlayerController currentAudioMediaSelectionOption]):
(-[WebAVPlayerController setCurrentAudioMediaSelectionOption:]):
(-[WebAVPlayerController currentLegibleMediaSelectionOption]):
(-[WebAVPlayerController setCurrentLegibleMediaSelectionOption:]):
(WebVideoFullscreenInterfaceAVKit::setAudioMediaSelectionOptions):
(WebVideoFullscreenInterfaceAVKit::setLegibleMediaSelectionOptions):
* platform/ios/WebVideoFullscreenModel.h:
Add selectAudioMediaOption/selectLegibleMediaOption

* platform/ios/WebVideoFullscreenModelMediaElement.h:
Add selectAudioMediaOption/selectLegibleMediaOption

* platform/ios/WebVideoFullscreenModelMediaElement.mm:
Add selectAudioMediaOption/selectLegibleMediaOption

(WebVideoFullscreenModelMediaElement::setMediaElement):
Send initial media selection options.

(WebVideoFullscreenModelMediaElement::selectAudioMediaOption):
Will be implemented when audio track slection is implemented.

(WebVideoFullscreenModelMediaElement::selectLegibleMediaOption):
Select corresponding text track on HTMLMediaElement.

Source/WebKit2:

Enable media selection in fullscreen.
setLegibleMediaSelectionOptions/setAudioMediaSelectionOptions provide a list of options.
selectAudioMediaOption/selectLegibleMediaOption change the selected option.

* UIProcess/ios/WebVideoFullscreenManagerProxy.h:
Add selectAudioMediaOption/selectLegibleMediaOption

* UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:
Add selectAudioMediaOption/selectLegibleMediaOption

* UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::selectAudioMediaOption):
Add selectAudioMediaOption

(WebKit::WebVideoFullscreenManagerProxy::selectLegibleMediaOption):
Add selectLegibleMediaOption

* WebProcess/ios/WebVideoFullscreenManager.h:
Add setAudioMediaSelectionOptions/setLegibleMediaSelectionOptions

* WebProcess/ios/WebVideoFullscreenManager.messages.in:
Add setAudioMediaSelectionOptions/setLegibleMediaSelectionOptions

* WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::setAudioMediaSelectionOptions):
Add setAudioMediaSelectionOptions

(WebKit::WebVideoFullscreenManager::setLegibleMediaSelectionOptions):
Add setLegibleMediaSelectionOptions

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agosystemHiddenFontFamilySet in DRT is unnecessary
mmaxfield@apple.com [Wed, 9 Apr 2014 22:33:16 +0000 (22:33 +0000)]
systemHiddenFontFamilySet in DRT is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=131414

Reviewed by Tim Horton.

It doesn't seem to affect test results on my machine.

* DumpRenderTree/mac/DumpRenderTree.mm:
(drt_NSFontManager_availableFonts):
(systemHiddenFontFamilySet): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] Add no shapes version of RegionsShapes performance test
zoltan@webkit.org [Wed, 9 Apr 2014 22:31:34 +0000 (22:31 +0000)]
[CSS Shapes] Add no shapes version of RegionsShapes performance test
https://bugs.webkit.org/show_bug.cgi?id=131455

Reviewed by Ryosuke Niwa.

This is a no shapes version of the RegionsShapes performance test. All the content
will wrap around the floating containers. This way we can compare the runtime/memory
usage of the RegionsShapes test with/without shapes. The test is skipped by default.

* Layout/Shapes/RegionsShapesNoShapes.html: Added.
* Layout/Shapes/resources/RegionsShapesContentNoShapes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTileGrid should be PlatformCALayerClient instead of TileController
antti@apple.com [Wed, 9 Apr 2014 22:29:15 +0000 (22:29 +0000)]
TileGrid should be PlatformCALayerClient instead of TileController
https://bugs.webkit.org/show_bug.cgi?id=131456

Reviewed by Tim Horton.

The client interface is for the tiles in the grid.

* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::setContentsScale):
(WebCore::TileController::createTileLayer):
(WebCore::TileController::platformCALayerPaintContents): Deleted.
(WebCore::TileController::platformCALayerDeviceScaleFactor): Deleted.
(WebCore::TileController::platformCALayerShowDebugBorders): Deleted.
(WebCore::TileController::platformCALayerShowRepaintCounter): Deleted.
(WebCore::TileController::platformCALayerIncrementRepaintCount): Deleted.
* platform/graphics/ca/mac/TileGrid.h:

    Move repaint counter to TileGrid too.

* platform/graphics/ca/mac/TileGrid.mm:
(WebCore::TileGrid::removeTiles):
(WebCore::TileGrid::removeAllSecondaryTiles):
(WebCore::TileGrid::removeTilesInCohort):

   Cleaned up tile removal.

(WebCore::TileGrid::revalidateTiles):
(WebCore::TileGrid::ensureTilesForRect):
(WebCore::TileGrid::platformCALayerPaintContents):
(WebCore::TileGrid::platformCALayerDeviceScaleFactor):
(WebCore::TileGrid::platformCALayerShowDebugBorders):
(WebCore::TileGrid::platformCALayerShowRepaintCounter):
(WebCore::TileGrid::platformCALayerContentsOpaque):
(WebCore::TileGrid::platformCALayerIncrementRepaintCount):
(WebCore::queueTileForRemoval): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename some dragging functions
ap@apple.com [Wed, 9 Apr 2014 22:24:42 +0000 (22:24 +0000)]
Rename some dragging functions
https://bugs.webkit.org/show_bug.cgi?id=131460

Reviewed by Tim Horton.

Source/WebCore:

Renamed performDrag to performDragOperation. This function is responsible for
accepting a drop, not for the whole drag.

The new name is not perfect either, but I think that it's better, and at least
it matches AppKit, like the other dragging destination functions already do.

* WebCore.exp.in:
* page/DragController.cpp:
(WebCore::DragController::performDragOperation):
(WebCore::DragController::performDrag): Deleted.
* page/DragController.h:

Source/WebKit/mac:

Renamed performDrag to performDragOperation.

* WebView/WebView.mm: (-[WebView performDragOperation:]):

Source/WebKit/win:

Renamed performDrag to performDragOperation.

* WebView.cpp: (WebView::Drop):

Source/WebKit2:

Renamed performDrag to performDragOperation.

Also renamed resetDragOperation to resetDragSession, because it's m_dragSession
that it resets.

* Shared/DragControllerAction.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDragDrop):
* UIProcess/API/mac/WKView.mm:
(-[WKView draggingEntered:]):
(-[WKView draggingExited:]):
(-[WKView performDragOperation:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performDragOperation):
(WebKit::WebPageProxy::performDrag): Deleted.
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::resetDragSession):
(WebKit::WebPageProxy::resetDragOperation): Deleted.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate SPI for managing tabs
barraclough@apple.com [Wed, 9 Apr 2014 22:13:07 +0000 (22:13 +0000)]
Update SPI for managing tabs
https://bugs.webkit.org/show_bug.cgi?id=131453

Reviewed by Alexey Proskuryakov.

* Configurations/WebKit2.xcconfig:
    - added AssertionServices
* UIProcess/WebProcessProxy.h:
    - added m_assertion, m_assertionState.
* UIProcess/ios/WebProcessProxyIOS.mm:
(WebKit::WebProcessProxy::updateProcessState):
    - create BKSProcessAssertion to take an assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWK2: Dictated words disappear after being inserted.
enrica@apple.com [Wed, 9 Apr 2014 22:12:40 +0000 (22:12 +0000)]
WK2: Dictated words disappear after being inserted.
https://bugs.webkit.org/show_bug.cgi?id=131458
<rdar://problem/16395011>

Reviewed by Benjamin Poulain.

The dictation engine treats selected text as text to be
removed. We need to ensure that the range selected to insert the
new text isn't reflected in the UI process until we are done
inserting the text.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::replaceDictatedText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Updated ChangeLog comment for r167031: <http://trac.webkit.org/r167031>.
mark.lam@apple.com [Wed, 9 Apr 2014 21:52:14 +0000 (21:52 +0000)]
Unreviewed.  Updated ChangeLog comment for r167031: <trac.webkit.org/r167031>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of JITOperationWrappers.h header file.
commit-queue@webkit.org [Wed, 9 Apr 2014 21:41:40 +0000 (21:41 +0000)]
Get rid of JITOperationWrappers.h header file.
https://bugs.webkit.org/show_bug.cgi?id=131450

Patch by Julien Brianceau <jbriance@cisco.com> on 2014-04-09
Reviewed by Michael Saboff.

JITOperationWrappers header file contains architecture specific code that is
not needed anymore, so get rid of it.

* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGOperations.cpp:
* jit/JITOperationWrappers.h: Removed.
* jit/JITOperations.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2014-04-09 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 9 Apr 2014 21:39:27 +0000 (21:39 +0000)]
2014-04-09  Geoffrey Garen  <ggaren@apple.com>

        Rolled back out r166972.

        The production buildbots are still broken because the build-root script
        doesn't build bmalloc.

        * WTF.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't offer "contact" actions in telephone number menus
beidson@apple.com [Wed, 9 Apr 2014 21:31:36 +0000 (21:31 +0000)]
Don't offer "contact" actions in telephone number menus
<rdar://problem/16556907> and https://bugs.webkit.org/show_bug.cgi?id=131451

Reviewed by Tim Horton.

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::showTelephoneNumberMenu): Skip actions that have to do with contacts,
  and skip separators too!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Initial text selection point should respect element focus.
samuel_white@apple.com [Wed, 9 Apr 2014 21:13:24 +0000 (21:13 +0000)]
AX: Initial text selection point should respect element focus.
https://bugs.webkit.org/show_bug.cgi?id=131402

Reviewed by Chris Fleizach.

Source/WebCore:

No new tests, updated existing selection-initial to test this functionality.

Support the case where we want to set the initial selection and there's already a focused element.

* page/EventHandler.cpp:
(WebCore::setKeyboardSelection):
(WebCore::handleKeyboardSelectionMovement):

LayoutTests:

Updating test to make sure initial selection respects the focused element when necessary. Now, if a VoiceOver user attempts to use
arrow keys to read text and selection isn't set, we will set initial selection before/after the focused element if one is present.

* platform/mac/accessibility/selection-initial-expected.txt:
* platform/mac/accessibility/selection-initial.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] Unreviewed test fix: Don't double-release BSTR.
bfulgham@apple.com [Wed, 9 Apr 2014 21:07:14 +0000 (21:07 +0000)]
[Win] Unreviewed test fix: Don't double-release BSTR.

* DumpRenderTree/win/DumpRenderTree.cpp:
(dump): Remove unneeded call to SysFreeString now that we are
using _bstr_t for this variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnsure that LLINT accessing of the ProtoCallFrame is big endian friendly.
mark.lam@apple.com [Wed, 9 Apr 2014 20:23:20 +0000 (20:23 +0000)]
Ensure that LLINT accessing of the ProtoCallFrame is big endian friendly.
<https://webkit.org/b/131449>

Reviewed by Mark Hahnenberg.

Change ProtoCallFrame::paddedArgCount to be of type uint32_t.  The argCount
that it pads is of type int anyway.  It doesn't need to be 64 bit.  This
also makes it work with the LLINT which is loading it with a loadi
instruction.

We should add the PayLoadOffset to ProtoCallFrame::argCountAndCodeOriginValue
when loading the argCount.

* interpreter/ProtoCallFrame.h:
(JSC::ProtoCallFrame::setPaddedArgCount):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] Various DumpRenderTree Fixes.
bfulgham@apple.com [Wed, 9 Apr 2014 20:21:36 +0000 (20:21 +0000)]
[Win] Various DumpRenderTree Fixes.
https://bugs.webkit.org/show_bug.cgi?id=131446.

Reviewed by Tim Horton.

* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(AccessibilityUIElement::description): Ditto.
(AccessibilityUIElement::helpText): Ditto.
(AccessibilityUIElement::intValue): Ditto.
(AccessibilityUIElement::isPressActionSupported): Ditto.
(AccessibilityUIElement::accessibilityValue): Ditto.
* DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
(DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
(DRTDesktopNotificationPresenter::AddRef): Ditto.
(DRTDesktopNotificationPresenter::Release): Ditto.
(DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
(DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
(DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
(DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
* DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
* DumpRenderTree/win/DumpRenderTree.cpp:
(dumpFrameScrollPosition): Ditto.
(dumpFramesAsText): Ditto.
(compareHistoryItems): Ditto.
(dumpHistoryItem): Ditto.
(dump): Ditto.
(resetDefaultsToConsistentValues): Ditto.
(resetWebViewToConsistentStateBeforeTesting): Ditto.
(runTest): Ditto.
(createWebViewAndOffscreenWindow): Ditto.
* DumpRenderTree/win/EditingDelegate.cpp:
(EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
(EditingDelegate::AddRef): Ditto.
(EditingDelegate::Release): Ditto.
(dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
(EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
(EditingDelegate::shouldEndEditingInDOMRange): Ditto.
(EditingDelegate::shouldInsertNode): Ditto.
(EditingDelegate::shouldInsertText): Ditto.
(EditingDelegate::shouldDeleteDOMRange): Ditto.
(EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
(EditingDelegate::shouldApplyStyle): Ditto.
(EditingDelegate::shouldChangeTypingStyle): Ditto.
(EditingDelegate::doPlatformCommand): Ditto.
(EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(EditingDelegate::webViewDidChange): Ditto.
(EditingDelegate::webViewDidEndEditing): Ditto.
(EditingDelegate::webViewDidChangeTypingStyle): Ditto.
(EditingDelegate::webViewDidChangeSelection): Ditto.
(EditingDelegate::checkSpellingOfString): Ditto.
* DumpRenderTree/win/FrameLoadDelegate.cpp:
(descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(FrameLoadDelegate::FrameLoadDelegate): Ditto.
(FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
(FrameLoadDelegate::AddRef): Ditto.
(FrameLoadDelegate::Release): Ditto.
(FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
(FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
(FrameLoadDelegate::didCommitLoadForFrame): Ditto.
(FrameLoadDelegate::didReceiveTitle): Ditto.
(FrameLoadDelegate::didChangeIcons): Ditto.
(delegatesWithDelayedWork): Ditto.
(FrameLoadDelegate::didFinishLoadForFrame): Ditto.
(FrameLoadDelegate::didFailLoadWithError): Ditto.
(FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
(FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
(FrameLoadDelegate::willCloseFrame): Ditto.
(FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
(FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
(FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
(FrameLoadDelegate::didDisplayInsecureContent): Ditto.
(FrameLoadDelegate::didRunInsecureContent): Ditto.
* DumpRenderTree/win/FrameLoadDelegate.h:
* DumpRenderTree/win/HistoryDelegate.cpp:
(HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(HistoryDelegate::updateHistoryTitle): Ditto.
(HistoryDelegate::populateVisitedLinksForWebView): Ditto.
* DumpRenderTree/win/PolicyDelegate.cpp:
(dumpPath):
(PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
(PolicyDelegate::AddRef): Ditto.
(PolicyDelegate::Release): Ditto.
(PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(PolicyDelegate::unableToImplementPolicyWithError): Ditto.
* DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
(ResourceLoadDelegate::AddRef): Ditto.
(ResourceLoadDelegate::Release): Ditto.
(ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
(ResourceLoadDelegate::willSendRequest): Ditto.
(ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
(ResourceLoadDelegate::didReceiveResponse): Ditto.
(ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
(ResourceLoadDelegate::didFailLoadingWithError): Ditto.
* DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
(TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(TestRunner::setUserStyleSheetLocation): Ditto.
(TestRunner::execCommand): Ditto.
(TestRunner::overridePreference): Ditto.
(TestRunner::evaluateScriptInIsolatedWorld): Ditto.
* DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
(TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(TextInputController::insertText): Ditto.
* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
(UIDelegate::AddRef): Ditto.
(UIDelegate::Release): Ditto.
(UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(UIDelegate::trackCustomPopupMenu): Ditto.
(UIDelegate::registerUndoWithTarget): Ditto.
(UIDelegate::removeAllActionsWithTarget): Ditto.
(UIDelegate::setActionTitle): Ditto.
(UIDelegate::undo): Ditto.
(UIDelegate::redo): Ditto.
(UIDelegate::canUndo): Ditto.
(UIDelegate::canRedo): Ditto.
(UIDelegate::printFrame): Ditto.
(UIDelegate::ftpDirectoryTemplatePath): Ditto.
(UIDelegate::webViewHeaderHeight): Ditto.
(UIDelegate::webViewFooterHeight): Ditto.
(UIDelegate::drawHeaderInRect): Ditto.
(UIDelegate::drawFooterInRect): Ditto.
(UIDelegate::webViewPrintingMarginRect): Ditto.
(UIDelegate::canRunModal): Ditto.
(UIDelegate::createModalDialog): Ditto.
(UIDelegate::runModal): Ditto.
(UIDelegate::isMenuBarVisible): Ditto.
(UIDelegate::setMenuBarVisible): Ditto.
(UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
(UIDelegate::paintCustomScrollbar): Ditto.
(UIDelegate::paintCustomScrollCorner): Ditto.
(UIDelegate::setFrame): Ditto.
(UIDelegate::webViewFrame): Ditto.
(UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
(UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
(UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
(UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
(UIDelegate::webViewAddMessageToConsole): Ditto.
(UIDelegate::doDragDrop): Ditto.
(UIDelegate::webViewGetDlgCode): Ditto.
(UIDelegate::createWebViewWithRequest): Ditto.
(UIDelegate::webViewClose): Ditto.
(UIDelegate::webViewFocus): Ditto.
(UIDelegate::webViewUnfocus): Ditto.
(UIDelegate::webViewPainted): Ditto.
(UIDelegate::exceededDatabaseQuota): Ditto.
(UIDelegate::embeddedViewWithArguments): Ditto.
(UIDelegate::webViewClosing): Ditto.
(UIDelegate::webViewSetCursor): Ditto.
(UIDelegate::webViewDidInvalidate): Ditto.
(UIDelegate::setStatusText): Ditto.
(UIDelegate::desktopNotificationsDelegate): Ditto.
(UIDelegate::drawBackground): Ditto.
(UIDelegate::decidePolicyForGeolocationRequest): Ditto.
(UIDelegate::didPressMissingPluginButton): Ditto.
* DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
(LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
(LoadHTMLStringItem::invoke): Ditto.
(ScriptItem::invoke): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHTMLCollection::updateNamedElementCach iterates over items twice
rniwa@webkit.org [Wed, 9 Apr 2014 19:32:41 +0000 (19:32 +0000)]
HTMLCollection::updateNamedElementCach iterates over items twice
https://bugs.webkit.org/show_bug.cgi?id=131448

Reviewed by Andreas Kling.

Compute the length first and go through the cache interface to traverse through items.

* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::updateNamedElementCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] Expose MPEG-TS metadata
b.long@cablelabs.com [Wed, 9 Apr 2014 18:43:40 +0000 (18:43 +0000)]
[GStreamer] Expose MPEG-TS metadata
https://bugs.webkit.org/show_bug.cgi?id=122001

Reviewed by Eric Carlson.

.:

* Source/cmake/FindGStreamer.cmake: Look for gstreamer-mpegts >= 1.3.0.
* Source/cmake/OptionsEfl.cmake: Same.
* Source/cmake/OptionsGTK.cmake: Same.

Source/WebCore:

Test: media/track/in-band/track-in-band-mpegts-metadata.html

* CMakeLists.txt: Add InbandDataTextTrack.
* PlatformGTK.cmake: Look for gstreamer-mpegts and use it if available.
* WebCore.vcxproj/WebCore.vcxproj: Add InbandDataTextTrack.
* WebCore.vcxproj/WebCore.vcxproj.filters: Same.
* WebCore.xcodeproj/project.pbxproj: Same.
* html/track/DataCue.cpp:
(WebCore::DataCue::DataCue): Add a constructor using raw data.
* html/track/DataCue.h:
(WebCore::DataCue::create): Same.
* html/track/InbandDataTextTrack.cpp: Added, InbandTextTrack which implements addDataCue().
* html/track/InbandDataTextTrack.h:
* html/track/InbandGenericTextTrack.h: Move unimplemented methods to InbandTextTrack.
* html/track/InbandWebVTTTextTrack.h: Same.
* html/track/InbandTextTrack.h: Same, and add inBandMetadataTrackDispatchType.
* html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::create): Add constructor for InbandDataTextTrack.
(WebCore::InbandTextTrack::inBandMetadataTrackDispatchType): Added.
* html/track/TextTrack.h:
(WebCore::TextTrack::inBandMetadataTrackDispatchType): Added (empty).
* html/track/TextTrack.idl: Add inBandMetadataTrackDispatchType.
* platform/graphics/InbandTextTrackPrivate.h: Add inBandMetadataTrackDispatchType and Data format.
(WebCore::InbandTextTrackPrivate::inBandMetadataTrackDispatchType):
* platform/graphics/InbandTextTrackPrivateClient.h: Add addDataCue() method.
* platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
(WebCore::InbandMetadataTextTrackPrivateGStreamer::create): Allow specifying the cue format and id.
 (WebCore::InbandMetadataTextTrackPrivateGStreamer::InbandMetadataTextTrackPrivateGStreamer): Same.
(WebCore::InbandMetadataTextTrackPrivateGStreamer::setInBandMetadataTrackDispatchType): Added.
(WebCore::InbandMetadataTextTrackPrivateGStreamer::addDataCue): Added.
(WebCore::InbandMetadataTextTrackPrivateGStreamer::addGenericCue): Added.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Check for MPEG-TS sections.
(WebCore::MediaPlayerPrivateGStreamer::processMpegTsSection): Add MPEG-TS section metadata, and get inBandMetadataTrackDispatchType from the PMT.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents): Explicitly use Generic CueFormat.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

LayoutTests:

* media/content/user-private-streams.ts: Added.
* media/track/in-band/track-in-band-mpegts-metadata-expected.txt: Added.
* media/track/in-band/track-in-band-mpegts-metadata.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Make AXPress much more reliable on the Web
cfleizach@apple.com [Wed, 9 Apr 2014 18:41:59 +0000 (18:41 +0000)]
AX: Make AXPress much more reliable on the Web
https://bugs.webkit.org/show_bug.cgi?id=131426

Reviewed by Mario Sanchez Prada.

Source/WebCore:

AXPress fails when an event handler is on a node higher in the parent chain than the focused node.

We need to make AXPress more reliable by
    1) Using the element that is focused as the target of the event
    2) Search for the inner most control object when dispatching the event

Updated existing accessibility/press-works-on-control-types.html

* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::press):
* accessibility/AccessibilityMenuList.h:
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::press):
* accessibility/AccessibilityMenuListPopup.h:
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::performDefaultAction):
* accessibility/AccessibilitySearchFieldButtons.cpp:
(WebCore::AccessibilitySearchFieldCancelButton::press):
* accessibility/AccessibilitySearchFieldButtons.h:
* accessibility/AccessibilitySpinButton.cpp:
(WebCore::AccessibilitySpinButtonPart::press):
* accessibility/AccessibilitySpinButton.h:

LayoutTests:

* accessibility/press-works-on-control-types-expected.txt:
* accessibility/press-works-on-control-types.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoContentFilterMac is broken when NE_FILTER_SOURCE is enabled.
beidson@apple.com [Wed, 9 Apr 2014 18:25:42 +0000 (18:25 +0000)]
ContentFilterMac is broken when NE_FILTER_SOURCE is enabled.
<rdar://problem/15978793> and https://bugs.webkit.org/show_bug.cgi?id=131445

Reviewed by Andy Estes.

No new tests (Not a tested feature).

* platform/mac/ContentFilterMac.mm:
(WebCore::ContentFilter::needsMoreData): Only consider m_neFilterSourceStatus if m_neFilterSource exists.
(WebCore::ContentFilter::didBlockData): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] Add no regions version of RegionsShapes performance test
zoltan@webkit.org [Wed, 9 Apr 2014 18:19:52 +0000 (18:19 +0000)]
[CSS Shapes] Add no regions version of RegionsShapes performance test
https://bugs.webkit.org/show_bug.cgi?id=131442

Reviewed by Ryosuke Niwa.

We would like have a no regions version for RegionsShapes performance test. The new
test produces similar layout to RegionsShapes.html without using regions. It is helpful
for us to do further comparisons when necessary. This test is skipped by default.

* Layout/Shapes/RegionsShapesNoRegions.html: Added.
* Layout/Shapes/resources/RegionsShapes.css: Added.
(html, body):
(.shape):
(#circleShape):
(#imageShape):
(#insetShape):
(#roundedInsetShape):
(#triangleLeft):
(#triangleRight):
(#selfIntersectingStar):
(#region1):
(#region2):
(#region3):
* Layout/Shapes/resources/RegionsShapesContent.html:
* Layout/Shapes/resources/RegionsShapesContentNoRegionsWidth400.html: Added.
* Layout/Shapes/resources/RegionsShapesContentNoRegionsWidth600.html: Added.
* Layout/Shapes/resources/RegionsShapesContentNoRegionsWidth800.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2014-04-09 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 9 Apr 2014 18:15:17 +0000 (18:15 +0000)]
2014-04-09  Geoffrey Garen  <ggaren@apple.com>

        Rolled back in r166972.

        The iOS buildbot's scripts have been updated to build bmalloc, so the
        build should now succeed on the bot.

        Also renamed "Frameworks" to "Libraries" as suggested in a review comment.

            WTF should link against bmalloc
            https://bugs.webkit.org/show_bug.cgi?id=131403

            Reviewed by Michael Saboff.

            This is required to build successfullly with bmalloc enabled.

            * WTF.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRewrite Function.bind as a builtin
oliver@apple.com [Wed, 9 Apr 2014 17:28:40 +0000 (17:28 +0000)]
Rewrite Function.bind as a builtin
https://bugs.webkit.org/show_bug.cgi?id=131083

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This change removes the existing function.bind implementation
entirely so JSBoundFunction is no more.

Instead we just return a regular JS closure with a few
private properties hanging off it that allow us to perform
the necessary bound function fakery.  While most of this is
simple, a couple of key changes:

- The parser and lexer now directly track whether they're
  parsing code for call or construct and convert the private
  name @IsConstructor into TRUETOK or FALSETOK as appropriate.
  This automatically gives us the ability to vary behaviour
  from within the builtin. It also leaves a lot of headroom
  for trivial future improvements.
- The instanceof operator now uses the prototypeForHasInstance
  private name, and we have a helper function to ensure that
  all objects that need to can update their magical 'prototype'
  property pair correctly.

* API/JSScriptRef.cpp:
(parseScript):
* JavaScriptCore.xcodeproj/project.pbxproj:
* builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createBuiltinExecutable):
* builtins/Function.prototype.js:
(bind.bindingFunction):
(bind.else.bindingFunction):
(bind):
* bytecode/UnlinkedCodeBlock.cpp:
(JSC::generateFunctionCodeBlock):
* bytecompiler/NodesCodegen.cpp:
(JSC::InstanceOfNode::emitBytecode):
* interpreter/Interpreter.cpp:
* parser/Lexer.cpp:
(JSC::Lexer<T>::Lexer):
(JSC::Lexer<LChar>::parseIdentifier):
(JSC::Lexer<UChar>::parseIdentifier):
* parser/Lexer.h:
* parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseInner):
* parser/Parser.h:
(JSC::parse):
* parser/ParserModes.h:
* runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
* runtime/CommonIdentifiers.h:
* runtime/Completion.cpp:
(JSC::checkSyntax):
* runtime/Executable.cpp:
(JSC::ProgramExecutable::checkSyntax):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind): Deleted.
* runtime/JSBoundFunction.cpp: Removed.
* runtime/JSBoundFunction.h: Removed.
* runtime/JSFunction.cpp:
(JSC::RetrieveCallerFunctionFunctor::RetrieveCallerFunctionFunctor):
(JSC::RetrieveCallerFunctionFunctor::operator()):
(JSC::retrieveCallerFunction):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::defineOwnProperty):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncSetTypeErrorAccessor):
* runtime/JSGlobalObjectFunctions.h:
* runtime/JSObject.h:
(JSC::JSObject::inlineGetOwnPropertySlot):

Source/WebCore:

Switch WebCore to use the helper functions when defining the
prototype properties on DOM constructors, and update bindings
tests accordingly.

* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::finishCreation):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::finishCreation):
* bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeConstructor::finishCreation):
* bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyConstructor::finishCreation):

LayoutTests:

Testing.

* js/dom/function-bind-expected.txt:
* js/regress/function-bind-expected.txt: Added.
* js/regress/function-bind.html: Added.
* js/regress/script-tests/function-bind.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed iOS build fix. Replacing deprecated enum with AVPlayerViewControllerExitFu...
enrica@apple.com [Wed, 9 Apr 2014 17:23:53 +0000 (17:23 +0000)]
Unreviewed iOS build fix. Replacing deprecated enum with AVPlayerViewControllerExitFullScreenReason.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController playerViewController:shouldDismissWithReason:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Monolithic elements should not affect the layout of the content outside...
stavila@adobe.com [Wed, 9 Apr 2014 17:07:50 +0000 (17:07 +0000)]
[CSS Regions] Monolithic elements should not affect the layout of the content outside its region
https://bugs.webkit.org/show_bug.cgi?id=130499

Reviewed by David Hyatt.

Source/WebCore:

When performing layout on an element flowed into regions, its logical height must not be incremented
past the region's logical bottom for monolithic elements in regions different than the last region their containing
block is fragmented into. This ensures that the following elements are correctly laid out
from the top of the next region.
This change must also be applied to floats in order to prevent text from avoiding part
of a float that did not actually made it into the current region, but instead overflowed
the previous one.

Tests: fast/regions/fragmentation-after-float-overflow-single-region.html
       fast/regions/fragmentation-after-monolithic-overflow-self-collapsed.html
       fast/regions/fragmentation-after-monolithic-overflow-single-region.html
       fast/regions/fragmentation-after-monolithic-overflow.html

* rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::computePlacedFloatsTree):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::getClearDelta):
(WebCore::RenderBlockFlow::applyAfterBreak): Deleted.
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow): Deleted.
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelowForBlock): Deleted.
(WebCore::RenderBlockFlow::flipFloatForWritingModeForChild): Deleted.
* rendering/RenderBlockFlow.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::isBoxInDifferentRegionsAsFloat):
* rendering/RenderFlowThread.h:

LayoutTests:

Added tests for different types of fragmentation following monolithic content
overflowing its region.
Rebased the webkit-flow-float-unable-to-push test as its expected result was not the correct one.

* fast/regions/webkit-flow-float-unable-to-push-expected.html:
* fast/regions/fragmentation-after-float-overflow-single-region-expected.html: Added.
* fast/regions/fragmentation-after-float-overflow-single-region.html: Added.
* fast/regions/fragmentation-after-monolithic-overflow-expected.html: Added.
* fast/regions/fragmentation-after-monolithic-overflow-self-collapsed-expected.html: Added.
* fast/regions/fragmentation-after-monolithic-overflow-self-collapsed.html: Added.
* fast/regions/fragmentation-after-monolithic-overflow-single-region-expected.html: Added.
* fast/regions/fragmentation-after-monolithic-overflow-single-region.html: Added.
* fast/regions/fragmentation-after-monolithic-overflow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse std::array in AffineTransform, and get rid of setMatrix
andersca@apple.com [Wed, 9 Apr 2014 17:05:18 +0000 (17:05 +0000)]
Use std::array in AffineTransform, and get rid of setMatrix
https://bugs.webkit.org/show_bug.cgi?id=131416

Reviewed by Sam Weinig.

* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::AffineTransform):
(WebCore::AffineTransform::multiply):
* platform/graphics/transforms/AffineTransform.h:
(WebCore::AffineTransform::setMatrix): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Plugin process crashes when loading totem plugin
carlosgc@webkit.org [Wed, 9 Apr 2014 16:53:26 +0000 (16:53 +0000)]
[GTK] Plugin process crashes when loading totem plugin
https://bugs.webkit.org/show_bug.cgi?id=131357

Reviewed by Martin Robinson.

Remove netscape plugin implementation from WebCore that was only
used by WebKit1. This removes the conflict between the WebCore NPN
symbols and the ones used by the plugins.

* CMakeLists.txt:
* PlatformEfl.cmake:
* PlatformGTK.cmake:
* PlatformWin.cmake:
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginPackageGtk.cpp: Removed.
* plugins/gtk/PluginViewGtk.cpp: Removed.
* plugins/gtk/gtk2xtbin.c: Removed.
* plugins/gtk/gtk2xtbin.h: Removed.
* plugins/gtk/xembed.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r166853): fast/preloader/document-write.html is very flaky
ap@apple.com [Wed, 9 Apr 2014 16:47:19 +0000 (16:47 +0000)]
REGRESSION (r166853): fast/preloader/document-write.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=130942

* platform/mac/TestExpectations: The offending code was re-landed, marking as
flaky again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofullscreen controls first show a play button instead of a pause button
commit-queue@webkit.org [Wed, 9 Apr 2014 16:12:58 +0000 (16:12 +0000)]
fullscreen controls first show a play button instead of a pause button
https://bugs.webkit.org/show_bug.cgi?id=131430

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-04-09
Reviewed by Jer Noble.

isPlaying() is false while buffering, paused() isn't; use paused() for
the play button.

* platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::setMediaElement):
(WebVideoFullscreenModelMediaElement::handleEvent):
Use HTMLMediaElement::paused() instead of HTMLMediaElement::isPlaying()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove duplicated files and unnecessary conditions from UseJSC.cmake
commit-queue@webkit.org [Wed, 9 Apr 2014 15:47:35 +0000 (15:47 +0000)]
Remove duplicated files and unnecessary conditions from UseJSC.cmake
https://bugs.webkit.org/show_bug.cgi?id=131438

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-04-09
Reviewed by Csaba Osztrogonác.

No new tests required.

* UseJSC.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Layout tests accessibility/children-changed-sends-notification.html and accessi...
mario.prada@samsung.com [Wed, 9 Apr 2014 15:08:17 +0000 (15:08 +0000)]
[GTK] Layout tests accessibility/children-changed-sends-notification.html and accessibility/notification-listeners.html fails
https://bugs.webkit.org/show_bug.cgi?id=131380

Reviewed by Chris Fleizach.

Source/WebCore:

Don't emit signals for added objects that we know won't be exposed
to the accessibility hierarchy (e.g. static text).

* accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::attachWrapper): Add extra check and early return.

LayoutTests:

Updated TestExpectations file and update layout test that was not
correctly written, and expecting the signals in the wrong order.

* platform/gtk/TestExpectations: Removed failure expectations.

* accessibility/children-changed-sends-notification.html: Updated
test to make sure we touch the accessibility tree after adding a
<button> so we get the 'add' signal at the right moment.

* accessibility/children-changed-sends-notification-expected.txt:
Updated expectations to expect the 'add' and 'remove' signals in
the right order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[AX][GTK] No new lines in some AX tests output
mario.prada@samsung.com [Wed, 9 Apr 2014 15:05:58 +0000 (15:05 +0000)]
[AX][GTK] No new lines in some AX tests output
https://bugs.webkit.org/show_bug.cgi?id=131294

Reviewed by Martin Robinson.

Source/WebCore:

Do not implement Hypetext or AtkText for the WebArea. Those
interfaces will be implemented by the containers (automatically
generated or not) for the different parts of the DOM and the
render subtree under this element anyway.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(getInterfaceMaskFromObject): Make sure we don't apply
WAIHypertext nor WAIText to objects with role WebAreaRole.

LayoutTests:

Removed failure expectations for tests now passing.

* platform/gtk/TestExpectations: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStylechecker: False positive on inline asm code.
ossy@webkit.org [Wed, 9 Apr 2014 09:48:26 +0000 (09:48 +0000)]
Stylechecker: False positive on inline asm code.
https://bugs.webkit.org/show_bug.cgi?id=130570

Patch by Gergo Balogh <gbalogh.u-szeged@partner.samsung.com> on 2014-04-09
Reviewed by Csaba Osztrogonác.

Disable stylechecking in asm blocks.

* Scripts/webkitpy/style/checkers/cpp.py:
(process_line):
(_InlineASMState):
(_InlineASMState.__init__):
(_InlineASMState.process_line):
(_InlineASMState.isInside):
(_process_lines):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_member_initialization_list):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening for GTK.
mario.prada@samsung.com [Wed, 9 Apr 2014 09:39:03 +0000 (09:39 +0000)]
Unreviewed gardening for GTK.

Updated test expectations after r166175, which removed an <hr>
from the original test accessibility/lists.html.

* platform/gtk/accessibility/lists-expected.txt: Updated

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resourc...
carlosgc@webkit.org [Wed, 9 Apr 2014 08:28:06 +0000 (08:28 +0000)]
[GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
https://bugs.webkit.org/show_bug.cgi?id=131029

Reviewed by Philippe Normand.

Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
tests and remove the getWebKit1TestResoucesDir() method.

* TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
(testDownloadLocalFile): Use Test::getResourcesDir().
(testDownloadLocalFileError): Ditto.
(serverCallback): Ditto.
* TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
(serverCallback): Ditto.
* TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
(httpServerCallback): Ditto.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
(serverCallback): Ditto.
* TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
* TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
* TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
(Test::getWebKit1TestResoucesDir): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] HTTP authentication regression tests fail
ap@apple.com [Wed, 9 Apr 2014 07:37:42 +0000 (07:37 +0000)]
[WK2] HTTP authentication regression tests fail
https://bugs.webkit.org/show_bug.cgi?id=81627
<rdar://problem/11079296>

Reviewed by Anders Carlsson.

Tools:

* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
to pageLoaderClient structure.
(WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
for password based authentication (we do get server trust challenges on some tests,
which WKTR can't handle).
When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
calls won't be made, at least on CFNetwork based platforms.
(WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
make sense to associate auth requests with individual resources - there can be
multiple resources loading at once from the same protection space, so WebKit1 API
that had a resource identifier was inherently racy.

LayoutTests:

* platform/mac-wk2/TestExpectations: Unskipped tests that now pass. Marked three
tests as failing, because enabling auth uncovered that they are failing
(in browser as well).

* platform/wk2/http: Added.
* platform/wk2/http/tests: Added.
* platform/wk2/http/tests/loading: Added.
* platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials: Added.
* platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt: Copied from LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt.
* platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Copied from LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt.
* platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt: Copied from LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt.
* platform/wk2/http/tests/misc: Added.
* platform/wk2/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt.
* platform/wk2/http/tests/misc/authentication-redirect-1: Added.
* platform/wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt.
* platform/wk2/http/tests/misc/authentication-redirect-2: Added.
* platform/wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt.
* platform/wk2/http/tests/misc/authentication-redirect-4: Added.
* platform/wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt.
* platform/wk2/http/tests/security: Added.
* platform/wk2/http/tests/security/401-logout: Added.
* platform/wk2/http/tests/security/401-logout/401-logout-expected.txt: Copied from LayoutTests/http/tests/security/401-logout/401-logout-expected.txt.
* platform/wk2/http/tests/xmlhttprequest: Added.
* platform/wk2/http/tests/xmlhttprequest/failed-auth-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/failed-auth-expected.txt.
* platform/wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/remember-bad-password-expected.txt.
WebKit2 results are the same as WebKit1, except that they lack resource URL. That
is expected with WebKit2 API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix GTK+ build after r166975.
carlosgc@webkit.org [Wed, 9 Apr 2014 07:35:31 +0000 (07:35 +0000)]
Unreviewed. Fix GTK+ build after r166975.

Do not use WebPage removed API to fix the build. Page overlays are
no broken, see https://bugs.webkit.org/show_bug.cgi?id=131433.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix GTK+ build after r166965.
carlosgc@webkit.org [Wed, 9 Apr 2014 07:31:08 +0000 (07:31 +0000)]
Unreviewed. Fix GTK+ build after r166965.

* WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::WebDragClient::startDrag): Rename Clipboard to DataTransfer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Change font path for DumpRenderTree and WebKitTestRunner
ryuan.choi@samsung.com [Wed, 9 Apr 2014 07:22:16 +0000 (07:22 +0000)]
[EFL] Change font path for DumpRenderTree and WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=131427

Reviewed by Gyuyoung Kim.

Since r166973, font path was changed.

* DumpRenderTree/PlatformEfl.cmake:
* WebKitTestRunner/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonil should only be used for objects
commit-queue@webkit.org [Wed, 9 Apr 2014 06:31:24 +0000 (06:31 +0000)]
nil should only be used for objects
https://bugs.webkit.org/show_bug.cgi?id=131431

Patch by Conrad Shultz <conrad_shultz@apple.com> on 2014-04-08
Reviewed by Chris Fleizach.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
nil -> NO.

* platform/mac/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController setMediaElement:]):
nil -> 0; change a NULL to nullptr while we're here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix EFL Build errors since r166975.
commit-queue@webkit.org [Wed, 9 Apr 2014 06:25:37 +0000 (06:25 +0000)]
Fix EFL Build errors since r166975.
https://bugs.webkit.org/show_bug.cgi?id=131421

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2014-04-08
Reviewed by Gyuyoung Kim.

This patch is just for fixing EFL build errors.
The page overlay functionality is not working yet.

* CMakeLists.txt:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
(WebKit::CoordinatedDrawingArea::display):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
* WebProcess/WebPage/PageOverlayController.cpp:
* WebProcess/WebPage/TapHighlightController.cpp:
(WebKit::TapHighlightController::hideHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions] Crash when video in region exits fullscreen
mihnea@adobe.com [Wed, 9 Apr 2014 06:18:00 +0000 (06:18 +0000)]
[CSSRegions] Crash when video in region exits fullscreen
https://bugs.webkit.org/show_bug.cgi?id=131366

Reviewed by Andrei Bucur.

Source/WebCore:

After fix for https://bugs.webkit.org/show_bug.cgi?id=130392, we compute the region ranges
information for inline elements collected in named flows with associated region chains.
The algorithm for this computation, implemented in RenderFlowThread::getRegionRangeForBox,
walks up the render tree trying to find the top-most unsplittable box under the named flow
in the case where the region ranges information is not available.

As this traversal works properly only when the starting box is not detached from the render tree,
i changed the named flow information clearing in RenderBlock::collapseAnonymousBoxChild
to occur before the child to be collapsed is removed from the render tree.

Test: fast/regions/full-screen-video-in-region-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseAnonymousBoxChild):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::getRegionRangeForBox):

LayoutTests:

* fast/regions/full-screen-video-in-region-crash-expected.txt: Added.
* fast/regions/full-screen-video-in-region-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTrying to unbreak flakiness dashboard after Gtk TextExpectations reshuffling.
ap@apple.com [Wed, 9 Apr 2014 06:13:10 +0000 (06:13 +0000)]
Trying to unbreak flakiness dashboard after Gtk TextExpectations reshuffling.

* platform/gtk-wk2/TestExpectations: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@167000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix for iOS (redux).
cfleizach@apple.com [Wed, 9 Apr 2014 05:25:36 +0000 (05:25 +0000)]
Unreviewed build fix for iOS (redux).

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityARIAIsBusy]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionIsAtomic]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix for iOS.
cfleizach@apple.com [Wed, 9 Apr 2014 05:23:27 +0000 (05:23 +0000)]
Unreviewed build fix for iOS.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityElementCount]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFactor tile coverage map into a class
antti@apple.com [Wed, 9 Apr 2014 05:01:54 +0000 (05:01 +0000)]
Factor tile coverage map into a class
https://bugs.webkit.org/show_bug.cgi?id=131417

Reviewed by Tim Horton.

* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/ca/PlatformCALayerClient.h:
(WebCore::PlatformCALayerClient::platformCALayerLayoutSublayersOfLayer):
(WebCore::PlatformCALayerClient::platformCALayerRespondsToLayoutChanges):
(WebCore::PlatformCALayerClient::platformCALayerAnimationStarted):
(WebCore::PlatformCALayerClient::platformCALayerContentsOrientation):
(WebCore::PlatformCALayerClient::platformCALayerShowDebugBorders):
(WebCore::PlatformCALayerClient::platformCALayerShowRepaintCounter):
(WebCore::PlatformCALayerClient::platformCALayerIncrementRepaintCount):
(WebCore::PlatformCALayerClient::platformCALayerLayerDidDisplay):

    Added default implementation to some of these to make clients less messy.

* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::~TileController):
(WebCore::TileController::platformCALayerPaintContents):
(WebCore::TileController::setTiledScrollingIndicatorPosition):
(WebCore::TileController::updateTileCoverageMap):
(WebCore::TileController::tiledScrollingIndicatorLayer):
* platform/graphics/ca/mac/TileCoverageMap.h: Added.
(WebCore::TileCoverageMap::setPosition):
(WebCore::TileCoverageMap::layer):
* platform/graphics/ca/mac/TileCoverageMap.mm: Added.

    The new class.

(WebCore::TileCoverageMap::TileCoverageMap):
(WebCore::TileCoverageMap::~TileCoverageMap):
(WebCore::TileCoverageMap::update):
(WebCore::TileCoverageMap::platformCALayerPaintContents):
(WebCore::TileCoverageMap::platformCALayerDeviceScaleFactor):
* platform/graphics/ca/mac/TileGrid.h:
* platform/graphics/ca/mac/TileGrid.mm:
(WebCore::TileGrid::drawTileMapContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSubpixel rendering: Clip outer rounded border rect on device pixel boundaries.
zalan@apple.com [Wed, 9 Apr 2014 03:52:53 +0000 (03:52 +0000)]
Subpixel rendering: Clip outer rounded border rect on device pixel boundaries.
https://bugs.webkit.org/show_bug.cgi?id=131404

Reviewed by Simon Fraser.

Use device pixel snapped rectangle to clip out rounded rects, when not all sides are solid/double.
Snapping it to device pixel boundaries ensures that when we call drawRect(devicePixelSnappedRect) later,
it leaves no cruft behind.

Source/WebCore:

Test: fast/borders/hidpi-rounded-border-on-subpixel-position.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):

LayoutTests:

* fast/borders/hidpi-rounded-border-on-subpixel-position-expected.html: Added.
* fast/borders/hidpi-rounded-border-on-subpixel-position.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix after r166479. 'bytes' is now abbreviated as 'B'.
rniwa@webkit.org [Wed, 9 Apr 2014 03:25:45 +0000 (03:25 +0000)]
Build fix after r166479. 'bytes' is now abbreviated as 'B'.

* public/js/helper-classes.js:
(PerfTestRuns.smallerIsBetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSome CSS teaks.
rniwa@webkit.org [Wed, 9 Apr 2014 02:54:45 +0000 (02:54 +0000)]
Some CSS teaks.

* public/common.css:
(#title):
* public/index.html:
(#charts .pane):
(#charts .arrow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTurn MSE on by default
jonlee@apple.com [Wed, 9 Apr 2014 02:18:52 +0000 (02:18 +0000)]
Turn MSE on by default
https://bugs.webkit.org/show_bug.cgi?id=131313
<rdar://problem/16525223>

Reviewed by Jer Noble.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* page/Settings.in: Add MEDIA_SOURCE conditional.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Set default to true.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:
* Shared/WebPreferencesStore.h: Set default to true.
* UIProcess/API/C/WKPreferencesRefPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove an unused parameter from loadResource.
andersca@apple.com [Wed, 9 Apr 2014 01:45:43 +0000 (01:45 +0000)]
Remove an unused parameter from loadResource.

Reviewed by Darin Adler.

Since the CachedResourceRequest has the charset in it, we don't need to pass it separately to loadRequest.

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
* loader/cache/CachedResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL build fix attempt since r166956
ryuan.choi@samsung.com [Wed, 9 Apr 2014 01:25:35 +0000 (01:25 +0000)]
Unreviewed EFL build fix attempt since r166956

Source/WebCore:

* page/efl/DragControllerEfl.cpp: Rename Clipboard to DataTransfer.
(WebCore::DragController::declareAndWriteDragImage):

Source/WebKit/efl:

* WebCoreSupport/DragClientEfl.cpp: Rename Clipboard to DataTransfer.
(WebCore::DragClientEfl::willPerformDragSourceAction):
(WebCore::DragClientEfl::startDrag): Ditto.
* WebCoreSupport/DragClientEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: REGRESSION (r155998): Elements render at very low resolution with...
simon.fraser@apple.com [Wed, 9 Apr 2014 01:11:52 +0000 (01:11 +0000)]
Source/WebCore: REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
https://bugs.webkit.org/show_bug.cgi?id=131412
<rdar://problem/16525044>

Reviewed by Tim Horton.

In r155998 we started to compute a root-relative transform in order to choose
a good contentsScale to avoid blurring on scaling.

However, the code failed to update this transform when passing over
GraphicsLayerCAs with no uncommitted changes, which caused us to choose
an incorrect contentsScale sometimes, resulting in blurriness.

Fix by updating the root-relative transform on layers with no uncommitted
changes.

Test: compositing/contents-scale/incremental-change.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):

LayoutTests: REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
https://bugs.webkit.org/show_bug.cgi?id=131412

Reviewed by Tim Horton.

Test that makes an incremental change to a layer property in a tree with
interesting 3d transforms.

* compositing/contents-scale/incremental-change-expected.html: Added.
* compositing/contents-scale/incremental-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't call CGPathAddPath with invalid CGAffineTransform objects
andersca@apple.com [Wed, 9 Apr 2014 01:11:15 +0000 (01:11 +0000)]
Don't call CGPathAddPath with invalid CGAffineTransform objects
https://bugs.webkit.org/show_bug.cgi?id=131413
<rdar://problem/16399645>

Reviewed by Darin Adler.

Covered by existing tests.

* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::addPath):
Don't try to add the path if the affine transform isn't invertible.

* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::isInvertible):
Handle infinite and NaN determinants.

(WebCore::AffineTransform::inverse):
Handle infinite and NaN determinants.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2014-04-08 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 9 Apr 2014 00:47:21 +0000 (00:47 +0000)]
2014-04-08  Geoffrey Garen  <ggaren@apple.com>

        Stop linking WTF against bmalloc.

        Reviewed by Enrica Casucci.

        This seems to have broken an iOS buildbot script. Disable it for now
        until we can fix the script.

        * WTF.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the build-jsc build
ggaren@apple.com [Wed, 9 Apr 2014 00:40:55 +0000 (00:40 +0000)]
Fix the build-jsc build
https://bugs.webkit.org/show_bug.cgi?id=131410

Reviewed by Michael Saboff.

* Scripts/build-jsc: Make sure to build bmalloc before WTF, since
WTF depends on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the typo in the previous commit.
rniwa@webkit.org [Wed, 9 Apr 2014 00:38:58 +0000 (00:38 +0000)]
Fix the typo in the previous commit.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing
rniwa@webkit.org [Wed, 9 Apr 2014 00:37:57 +0000 (00:37 +0000)]
REGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing
https://bugs.webkit.org/show_bug.cgi?id=131409

Reviewed by Anders Carlsson.

Create an empty API::InjectedBundle::FormClient to avoid crashing inside
m_mainFrame->coreFrame()->loader().detachFromParent().

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Replay: memoize nondeterministic attributes of the Screen interface
burg@cs.washington.edu [Wed, 9 Apr 2014 00:22:46 +0000 (00:22 +0000)]
Web Replay: memoize nondeterministic attributes of the Screen interface
https://bugs.webkit.org/show_bug.cgi?id=131339

Reviewed by Timothy Hatcher.

.:

* ManualTests/inspector/replay-window-screen.html: Added.

Source/WebCore:

The values from the screen interface are nondeterministic. Since we can't
change the physical screen dimensions, instead memoize values of attributes.

Test: ManualTests/inspector/replay-window-screen.html

* page/Screen.idl: Add Nondeterministic attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=131408
bdakin@apple.com [Wed, 9 Apr 2014 00:13:43 +0000 (00:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=131408
Scrollbars layers don't dynamically update when device scale factor changes
-and corresponding-
<rdar://problem/16503875>

Reviewed by Tim Horton.

The scrollbar layers are not children of the RenderView's layer, so they were
completely skipped over by this function before. We need to start this higher up
the tree in the rootGraphicsLayer(), which will typically return the
m_overflowControlsHostLayer.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::deviceOrPageScaleFactorChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Prevent deadlocks receiving WIRPermissionDenied message
commit-queue@webkit.org [Wed, 9 Apr 2014 00:12:11 +0000 (00:12 +0000)]
Web Inspector: Prevent deadlocks receiving WIRPermissionDenied message
https://bugs.webkit.org/show_bug.cgi?id=131406

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-04-08
Reviewed by Timothy Hatcher.

* inspector/remote/RemoteInspector.h:
* inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::stop):
(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
Provide a way to stop externally and a path to stop when in
the middle of handling a message already with the locked mutex.

* inspector/remote/RemoteInspectorXPCConnection.h:
* inspector/remote/RemoteInspectorXPCConnection.mm:
(Inspector::RemoteInspectorXPCConnection::close):
(Inspector::RemoteInspectorXPCConnection::closeFromMessage):
Provide a way to close externally and a path to close when in
the middle of handling a message already with a mutex.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHTMLConverter::aggregatedAttributesForAncestors should cache intermediate results
rniwa@webkit.org [Wed, 9 Apr 2014 00:06:09 +0000 (00:06 +0000)]
HTMLConverter::aggregatedAttributesForAncestors should cache intermediate results
https://bugs.webkit.org/show_bug.cgi?id=131400

Reviewed by Sam Weinig.

Instead of accumulating attributes from a character node to the highest ancestor,
recursively call aggregatedAttributesForElementAndItsAncestors so that aggregated
attributes are cached on each ancestor to eliminate the old O(n^2) behavior.

* editing/cocoa/HTMLConverter.mm:
(HTMLConverter::aggregatedAttributesForAncestors):
(HTMLConverter::aggregatedAttributesForElementAndItsAncestors): Extracted from aggregatedAttributesForAncestors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed CMake build fix after r166965.
jinwoo7.song@samsung.com [Tue, 8 Apr 2014 23:53:29 +0000 (23:53 +0000)]
Unreviewed CMake build fix after r166965.

* UseJSC.cmake: Rename JSClipboardCustom.cpp to JSDataTransferCustom.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Remove the WebKitGTK+ WebKit 1 code
mrobinson@webkit.org [Tue, 8 Apr 2014 23:44:44 +0000 (23:44 +0000)]
[GTK] Remove the WebKitGTK+ WebKit 1 code
https://bugs.webkit.org/show_bug.cgi?id=131399

Reviewed by Anders Carlsson.

.:

* Source/PlatformGTK.cmake: Remove WebKit1 dependency from dist target.
* Source/cmake/OptionsGTK.cmake: Remove option to compile with GTK+2 or with WebKit2 disabled.

Source/WebCore/platform/gtk/po:

* POTFILES.in: Remove references to WebKit1 source files from the list of
files with translatable strings.

Source/WebKit:

* PlatformGTK.cmake: Removed.
* gtk: Remove this entire directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnify and factor out page overlay implementations
timothy_horton@apple.com [Tue, 8 Apr 2014 23:40:43 +0000 (23:40 +0000)]
Unify and factor out page overlay implementations
https://bugs.webkit.org/show_bug.cgi?id=131353

Reviewed by Anders Carlsson.

* WebProcess/WebPage/PageOverlayController.cpp:
(WebKit::PageOverlayController::uninstallPageOverlay):
Don't turn fast scrolling back off unless the last overlay is removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Remove WebKit1 unit tests
mrobinson@webkit.org [Tue, 8 Apr 2014 23:36:28 +0000 (23:36 +0000)]
[GTK] Remove WebKit1 unit tests
https://bugs.webkit.org/show_bug.cgi?id=131359

Reviewed by Anders Carlsson.

Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
they were inadvertently left in http://trac.webkit.org/changeset/166504.

* CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
* Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
* TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
* TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
* TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
* TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
* TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
* TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
* TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
* TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a WKNavigationAction property indicating whether it resulted from processing...
andersca@apple.com [Tue, 8 Apr 2014 23:19:32 +0000 (23:19 +0000)]
Add a WKNavigationAction property indicating whether it resulted from processing a user gesture
https://bugs.webkit.org/show_bug.cgi?id=131405
<rdar://problem/16535453>

Reviewed by Tim Horton.

* Shared/NavigationActionData.cpp:
(WebKit::NavigationActionData::NavigationActionData):
(WebKit::NavigationActionData::encode):
(WebKit::NavigationActionData::decode):
* Shared/NavigationActionData.h:
* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
* UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnify and factor out page overlay implementations
timothy_horton@apple.com [Tue, 8 Apr 2014 23:09:52 +0000 (23:09 +0000)]
Unify and factor out page overlay implementations
https://bugs.webkit.org/show_bug.cgi?id=131353

Reviewed by Anders Carlsson.

Bring all of the PageOverlay code together in a single cross-platform
PageOverlayController, including hit-testing code from WebPage and painting
and layer-tree manipulation code from the DrawingArea.

This also makes all PageOverlays a single GraphicsLayer tree which can be
flushed and plugged into any DrawingArea in a straightforward manner.
We no longer have to watch for individual layers flipping into/out of tiling,
because they're hidden underneath the root PageOverlay GraphicsLayer.
Additionally, because GraphicsLayer is cross-platform, we can share
all of the fairly trivial but oft-repeated overlay management code.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/PageOverlayController.cpp: Added.
* WebProcess/WebPage/PageOverlayController.h: Added.
(WebKit::PageOverlayController::rootLayer):
Add PageOverlayController.

* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
Remove PageOverlay-related code from the DrawingAreas.

* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::setNeedsDisplay):
(WebKit::PageOverlay::fadeAnimationTimerFired):
(WebKit::PageOverlay::clear):
* WebProcess/WebPage/PageOverlay.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didChangeScrollOffset):
* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
Use PageOverlayController instead of the DrawingArea/WebPage to manipulate page overlays.

* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::pageOverlayController):
Remove PageOverlay-related code from WebPage.

* WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::outOfTreeLayerWasAdded): Deleted.
(WebKit::RemoteLayerTreeContext::outOfTreeLayerWillBeRemoved): Deleted.
(WebKit::RemoteLayerTreeContext::flushOutOfTreeLayers): Deleted.
Remove the no-longer-necessary out-of-tree layer code.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageInstallPageOverlayWithAnimation):
(WKBundlePageUninstallPageOverlayWithAnimation):
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight):
(WebKit::WebInspectorClient::hideHighlight):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::hideFindUI):
* WebProcess/WebPage/TelephoneNumberOverlayController.cpp:
(WebKit::TelephoneNumberOverlayController::createOverlayIfNeeded):
(WebKit::TelephoneNumberOverlayController::destroyOverlay):
Make use of the FadeMode enum.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening (Take 2): Prevent users from attempting
bfulgham@apple.com [Tue, 8 Apr 2014 22:59:27 +0000 (22:59 +0000)]
Unreviewed gardening (Take 2): Prevent users from attempting
to build with known invalid cURL.

* Scripts/webkitdirs.pm:
(checkInstalledTools): Check for 7.34.0 (the broken version), not
7.33.0 (the known good version).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Remove DumpRenderTree and GtkLauncher
mrobinson@webkit.org [Tue, 8 Apr 2014 22:52:26 +0000 (22:52 +0000)]
[GTK] Remove DumpRenderTree and GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=131373

Reviewed by Andreas Kling.

Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
no longer necessary now that WebKit1 GTK+ will be removed.

* CMakeLists.txt:
* DumpRenderTree/PlatformGTK.cmake: Removed.
* DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
* DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
* DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
* DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
* DumpRenderTree/gtk/EditingCallbacks.h: Removed.
* DumpRenderTree/gtk/EventSender.cpp: Removed.
* DumpRenderTree/gtk/EventSender.h: Removed.
* DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
* DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
* DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
* DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
* DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
* DumpRenderTree/gtk/TextInputController.cpp: Removed.
* DumpRenderTree/gtk/TextInputController.h: Removed.
* DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
* GtkLauncher/CMakeLists.txt: Removed.
* GtkLauncher/LauncherInspectorWindow.c: Removed.
* GtkLauncher/LauncherInspectorWindow.h: Removed.
* GtkLauncher/main.c: Removed.
* GtkLauncher/simple.svg: Removed.
* GtkLauncher/text.html: Removed.
* WebKitTestRunner/PlatformGTK.cmake:
* WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
* WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
* WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWTF should link against bmalloc
ggaren@apple.com [Tue, 8 Apr 2014 22:51:27 +0000 (22:51 +0000)]
WTF should link against bmalloc
https://bugs.webkit.org/show_bug.cgi?id=131403

Reviewed by Michael Saboff.

This is required to build successfullly with bmalloc enabled.

* WTF.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Address stale FIXMEs concerning console in JSContext inspection
commit-queue@webkit.org [Tue, 8 Apr 2014 22:46:10 +0000 (22:46 +0000)]
Web Inspector: Address stale FIXMEs concerning console in JSContext inspection
https://bugs.webkit.org/show_bug.cgi?id=131398

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-04-08
Reviewed by Timothy Hatcher.

* inspector/InjectedScriptSource.js:
The console object can be deleted from a page or JSContext,
so keep code that expects that it could have been deleted
to be resilient in those cases.

* inspector/JSGlobalObjectScriptDebugServer.h:
* inspector/agents/JSGlobalObjectDebuggerAgent.h:
* inspector/agents/JSGlobalObjectRuntimeAgent.h:
Change the FIXMEs to NOTEs that explain why these functions
have empty implementations for JSContext inspection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed iOS build fix.
enrica@apple.com [Tue, 8 Apr 2014 22:44:39 +0000 (22:44 +0000)]
Unreviewed iOS build fix.

Return false instead of nil in a function that returns BOOL.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange WebPageProxy::CreateNewPage to take a NavigationActionData object
andersca@apple.com [Tue, 8 Apr 2014 22:37:19 +0000 (22:37 +0000)]
Change WebPageProxy::CreateNewPage to take a NavigationActionData object
https://bugs.webkit.org/show_bug.cgi?id=131401

Reviewed by Dan Bernstein.

* UIProcess/API/APIUIClient.h:
(API::UIClient::createNewPage):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/API/Cocoa/WKNavigationAction.mm:
(toWKNavigationType):
* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::toWKNavigationType): Deleted.
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNon-empty ranges misdetected as empty ranges, avoiding telephone number detection.
beidson@apple.com [Tue, 8 Apr 2014 22:36:06 +0000 (22:36 +0000)]
Non-empty ranges misdetected as empty ranges, avoiding telephone number detection.
<rdar://problem/16553441> and https://bugs.webkit.org/show_bug.cgi?id=131397

Reviewed by Tim Horton.

No new tests (Only affects a currently untested Mac-only WK2 feature)

* editing/Editor.cpp:
(WebCore::Editor::scanSelectionForTelephoneNumbers): Fix detection of empty ranges so we don’t
  early return erroneously.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SVG] Fix CSS transform handling when zoomed
cavalcantii@gmail.com [Tue, 8 Apr 2014 22:27:37 +0000 (22:27 +0000)]
[SVG] Fix CSS transform handling when zoomed
https://bugs.webkit.org/show_bug.cgi?id=125836

Reviewed by Tim Horton.

Source/WebCore:

Tests: svg/zoom/page/zoom-css-transforms-expected.svg
       svg/zoom/page/zoom-css-transforms.svg

Adjusts CSS transforms when used in SVG to account for unexpected
translation scale. Backport from Chromium #174910.

* svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::animatedLocalTransform):

LayoutTests:

Adjusts CSS transforms when used in SVG to account for unexpected
translation scale. Backport from Chromium #174910.

* svg/zoom/page/zoom-css-transforms-expected.svg: Added.
* svg/zoom/page/zoom-css-transforms.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] large corner radius combined with 0 radius does not wrap properly
hmuller@adobe.com [Tue, 8 Apr 2014 22:26:03 +0000 (22:26 +0000)]
[CSS Shapes] large corner radius combined with 0 radius does not wrap properly
https://bugs.webkit.org/show_bug.cgi?id=129739

Reviewed by Bem Jones-Bey.

Source/WebCore:

Corrected special case handling for shape-outside border-box values with border-radius
values that greater than or equal to the box's height.

Tests: fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001.html
       fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002.html

* rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::getExcludedIntervals):

LayoutTests:

* fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001-expected.txt: Added.
* fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Rename Clipboard to DataTransfer
ap@apple.com [Tue, 8 Apr 2014 22:06:16 +0000 (22:06 +0000)]
Source/WebCore: Rename Clipboard to DataTransfer
https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

This is the name used in HTML5, and it's much better than the confusing Clipboard one.

Renamed related enums too, and made DataTransferAccessPolicy an enum class.

* CMakeLists.txt:
* Configurations/WebCore.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* WebCore.exp.in:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSClipboardCustom.cpp: Removed.
* bindings/js/JSDataTransferCustom.cpp: Copied from Source/WebCore/bindings/js/JSClipboardCustom.cpp.
(WebCore::JSDataTransfer::types):
(WebCore::JSClipboard::types): Deleted.
* bindings/js/JSEventCustom.cpp:
* dom/Clipboard.cpp: Removed.
* dom/Clipboard.h: Removed.
* dom/Clipboard.idl: Removed.
* dom/ClipboardAccessPolicy.h: Removed.
* dom/ClipboardEvent.cpp:
(WebCore::ClipboardEvent::ClipboardEvent):
* dom/ClipboardEvent.h:
(WebCore::ClipboardEvent::create):
(WebCore::ClipboardEvent::clipboard): Deleted.
* dom/ClipboardMac.mm: Removed.
* dom/DOMAllInOne.cpp:
* dom/DataTransfer.cpp: Copied from Source/WebCore/dom/Clipboard.cpp.
(WebCore::DataTransfer::DataTransfer):
(WebCore::DataTransfer::createForCopyAndPaste):
(WebCore::DataTransfer::~DataTransfer):
(WebCore::DataTransfer::setAccessPolicy):
(WebCore::DataTransfer::canReadTypes):
(WebCore::DataTransfer::canReadData):
(WebCore::DataTransfer::canWriteData):
(WebCore::DataTransfer::clearData):
(WebCore::DataTransfer::getData):
(WebCore::DataTransfer::setData):
(WebCore::DataTransfer::types):
(WebCore::DataTransfer::files):
(WebCore::DataTransfer::dropEffect):
(WebCore::DataTransfer::setDropEffect):
(WebCore::DataTransfer::effectAllowed):
(WebCore::DataTransfer::setEffectAllowed):
(WebCore::DataTransfer::setDragImage):
(WebCore::DataTransfer::createForDragAndDrop):
(WebCore::DataTransfer::canSetDragImage):
(WebCore::DataTransfer::updateDragImage):
(WebCore::DataTransfer::createDragImage):
(WebCore::DragImageLoader::DragImageLoader):
(WebCore::DragImageLoader::imageChanged):
(WebCore::DataTransfer::sourceOperation):
(WebCore::DataTransfer::destinationOperation):
(WebCore::DataTransfer::setSourceOperation):
(WebCore::DataTransfer::setDestinationOperation):
(WebCore::Clipboard::Clipboard): Deleted.
(WebCore::Clipboard::createForCopyAndPaste): Deleted.
(WebCore::Clipboard::~Clipboard): Deleted.
(WebCore::Clipboard::setAccessPolicy): Deleted.
(WebCore::Clipboard::canReadTypes): Deleted.
(WebCore::Clipboard::canReadData): Deleted.
(WebCore::Clipboard::canWriteData): Deleted.
(WebCore::Clipboard::clearData): Deleted.
(WebCore::Clipboard::getData): Deleted.
(WebCore::Clipboard::setData): Deleted.
(WebCore::Clipboard::types): Deleted.
(WebCore::Clipboard::files): Deleted.
(WebCore::Clipboard::dropEffect): Deleted.
(WebCore::Clipboard::setDropEffect): Deleted.
(WebCore::Clipboard::effectAllowed): Deleted.
(WebCore::Clipboard::setEffectAllowed): Deleted.
(WebCore::Clipboard::setDragImage): Deleted.
(WebCore::Clipboard::createForDragAndDrop): Deleted.
(WebCore::Clipboard::canSetDragImage): Deleted.
(WebCore::Clipboard::updateDragImage): Deleted.
(WebCore::Clipboard::createDragImage): Deleted.
(WebCore::Clipboard::sourceOperation): Deleted.
(WebCore::Clipboard::destinationOperation): Deleted.
(WebCore::Clipboard::setSourceOperation): Deleted.
(WebCore::Clipboard::setDestinationOperation): Deleted.
* dom/DataTransfer.h: Copied from Source/WebCore/dom/Clipboard.h.
* dom/DataTransfer.idl: Copied from Source/WebCore/dom/Clipboard.idl.
* dom/DataTransferAccessPolicy.h: Copied from Source/WebCore/dom/ClipboardAccessPolicy.h.
* dom/DataTransferItemList.h:
* dom/DataTransferMac.mm: Copied from Source/WebCore/dom/ClipboardMac.mm.
(WebCore::DataTransfer::createDragImage):
(WebCore::Clipboard::createDragImage): Deleted.
* dom/Event.h:
(WebCore::Event::clipboardData):
(WebCore::Event::internalDataTransfer):
(WebCore::Event::clipboard): Deleted.
* dom/Event.idl:
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::MouseEvent::initMouseEvent):
* dom/MouseEvent.h:
(WebCore::MouseEvent::dataTransfer):
* dom/MouseEvent.idl:
* dom/WheelEvent.cpp:
* editing/Editor.cpp:
(WebCore::Editor::canDHTMLCut):
(WebCore::Editor::canDHTMLCopy):
(WebCore::Editor::canDHTMLPaste):
(WebCore::Editor::tryDHTMLCopy):
(WebCore::Editor::tryDHTMLCut):
(WebCore::Editor::tryDHTMLPaste):
(WebCore::Editor::dispatchCPPEvent):
(WebCore::Editor::performCutOrCopy):
(WebCore::Editor::selectedTextForDataTransfer):
(WebCore::Editor::selectedTextForClipboard): Deleted.
* editing/Editor.h:
* editing/ios/EditorIOS.mm:
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
* editing/mac/EditorMac.mm:
(WebCore::Editor::takeFindStringFromSelection):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
* loader/EmptyClients.h:
* page/DragClient.h:
* page/DragController.cpp:
(WebCore::DragController::dragExited):
(WebCore::DragController::performDrag):
(WebCore::DragController::tryDHTMLDrag):
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::doSystemDrag):
* page/DragController.h:
* page/DragState.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::hasFileOfType):
(WebCore::hasStringOfType):
(WebCore::hasDropZoneType):
(WebCore::findDropZone):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):
(WebCore::EventHandler::freeDataTransfer):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::dispatchDragSrcEvent):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::freeClipboard): Deleted.
* page/EventHandler.h:
* page/efl/EventHandlerEfl.cpp:
(WebCore::EventHandler::createDraggingDataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.
* page/gtk/DragControllerGtk.cpp:
(WebCore::DragController::declareAndWriteDragImage):
* page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::createDraggingDataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.
* page/mac/DragControllerMac.mm:
(WebCore::DragController::declareAndWriteDragImage):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::createDraggingDataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.
* page/win/DragControllerWin.cpp:
(WebCore::DragController::declareAndWriteDragImage):
* page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::createDraggingataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.
* platform/Pasteboard.h:
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeSelection):
* platform/mac/PasteboardMac.mm:
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeRangeToDataObject):
(WebCore::Pasteboard::writeSelection):

Source/WebKit/ios: Rename Clipboard to DataTransfer
https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

* WebView/WebPDFViewPlaceholder.mm:

Source/WebKit/mac: Rename Clipboard to DataTransfer
https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

* WebCoreSupport/WebDragClient.h:
* WebCoreSupport/WebDragClient.mm:
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
* WebView/WebPDFView.mm:

Source/WebKit2: Fix build.

Patch by Anders Carlsson <andersca@apple.com> on 2014-04-08

* WebKit2Prefix.h:

LayoutTests: Rename Clipboard to DataTransfer
https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:
* js/dom/global-constructors-attributes-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed iOS build fix. Pass 0 instead of nil to the options parameter of addObserv...
jer.noble@apple.com [Tue, 8 Apr 2014 21:41:02 +0000 (21:41 +0000)]
Unreviewed iOS build fix. Pass 0 instead of nil to the options parameter of addObserver:forKeyPath:options:context.

* platform/graphics/ios/TextTrackRepresentationIOS.mm:
(-[WebCoreTextTrackRepresentationIOSHelper setParent:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166964 268f45cc-cd09-0410-ab3c-d52691b4dbfc