WebKit-https.git
13 years ago Reviewed by Darin Adler.
eric@webkit.org [Mon, 6 Oct 2008 08:23:37 +0000 (08:23 +0000)]
    Reviewed by Darin Adler.

        SVG should support ascent and descent properties <font-face> instead of <font>!
        https://bugs.webkit.org/show_bug.cgi?id=21365

        Tested by many many existing SVG tests.

        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::ascent):
        (WebCore::SVGFontFaceElement::descent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-05 Darin Fisher <darin@chromium.org>
mjs@apple.com [Mon, 6 Oct 2008 06:44:03 +0000 (06:44 +0000)]
2008-10-05  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        REGRESSION: crash in ScriptElement::notifyFinished
        Fixes https://bugs.webkit.org/show_bug.cgi?id=21329

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::notifyFinished): Revert part of r35744 to
        ensure that the ScriptElementData object is not destroyed prematurely.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-05 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Mon, 6 Oct 2008 06:33:06 +0000 (06:33 +0000)]
2008-10-05  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Oliver Hunt.

        Remove ScopeNode::containsClosures() now that it is unused.

        * kjs/nodes.h:
        (JSC::ScopeNode::containsClosures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-05 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 6 Oct 2008 06:05:19 +0000 (06:05 +0000)]
2008-10-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - fix releas-only test failures caused by the fix to bug 21375

        * VM/Machine.cpp:
        (JSC::Machine::unwindCallFrame): Update ExecState while unwinding call frames;
        it now matters more to have a still-valid ExecState, since dynamicGlobalObject
        will make use of the ExecState's scope chain.
        * VM/Machine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-05 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Mon, 6 Oct 2008 06:00:58 +0000 (06:00 +0000)]
2008-10-05  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Oliver Hunt.

        Bug 21364: Remove the branch in op_ret for OptionalCalleeActivation and OptionalCalleeArguments
        <https://bugs.webkit.org/show_bug.cgi?id=21364>

        Use information from the parser to detect whether an activation is
        needed or 'arguments' is used, and emit explicit instructions to tear
        them off before op_ret. This allows a branch to be removed from op_ret
        and simplifies some other code. This does cause a small change in the
        behaviour of 'f.arguments'; it is no longer live when 'arguments' is not
        mentioned in the lexical scope of the function.

        It should now be easy to remove the OptionaCalleeActivation slot in the
        call frame, but this will be done in a later patch.

        JavaScriptCore:

        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass):
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::emitReturn):
        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (JSC::Machine::unwindCallFrame):
        (JSC::Machine::privateExecute):
        (JSC::Machine::retrieveArguments):
        (JSC::Machine::cti_op_create_arguments):
        (JSC::Machine::cti_op_tear_off_activation):
        (JSC::Machine::cti_op_tear_off_arguments):
        * VM/Machine.h:
        * VM/Opcode.h:
        * kjs/Arguments.cpp:
        (JSC::Arguments::mark):
        * kjs/Arguments.h:
        (JSC::Arguments::isTornOff):
        (JSC::Arguments::Arguments):
        (JSC::Arguments::copyRegisters):
        (JSC::JSActivation::copyRegisters):
        * kjs/JSActivation.cpp:
        (JSC::JSActivation::argumentsGetter):
        * kjs/JSActivation.h:

        LayoutTests:

        * fast/js/function-dot-arguments-expected.txt:
        * fast/js/resources/function-dot-arguments.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-05 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 6 Oct 2008 02:48:08 +0000 (02:48 +0000)]
2008-10-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver Hunt.

        - fixed "REGRESSION (r37297): fast/js/deep-recursion-test takes too long and times out"
        https://bugs.webkit.org/show_bug.cgi?id=21375

        The problem is that dynamicGlobalObject had become O(N) in number
        of call frames, but unwinding the stack for an exception called it
        for every call frame, resulting in O(N^2) behavior for an
        exception thrown from inside deep recursion.

        Instead of doing it that way, stash the dynamic global object in JSGlobalData.

        * JavaScriptCore.exp:
        * VM/Machine.cpp:
        (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Helper class to temporarily
        store and later restore a dynamicGlobalObject in JSGlobalData.
        (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
        (JSC::Machine::execute): In each version, establish a DynamicGlobalObjectScope.
        For ProgramNode, always establish set new dynamicGlobalObject, for FunctionBody and Eval,
        only if none is currently set.
        * VM/Machine.h:
        * kjs/ExecState.h:
        * kjs/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData): Ininitalize new dynamicGlobalObject field to 0.
        * kjs/JSGlobalData.h:
        * kjs/JSGlobalObject.h:
        (JSC::ExecState::dynamicGlobalObject): Moved here from ExecState for benefit of inlining.
        Return lexical global object if this is a globalExec(), otherwise look in JSGlobalData
        for the one stashed there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-05 Chris Lord <chris@openedhand.com>
jmalonzo@webkit.org [Mon, 6 Oct 2008 01:43:07 +0000 (01:43 +0000)]
2008-10-05  Chris Lord  <chris@openedhand.com>

        Reviewed by Alp Toker. Landed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=20624
        WebKit-gtk uses deprecated GtkType/GtkObject

        * plugins/gtk/gtk2xtbin.c:
        (gtk_xtbin_get_type):
        * plugins/gtk/gtk2xtbin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-05 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 6 Oct 2008 00:58:42 +0000 (00:58 +0000)]
2008-10-05  Sam Weinig  <sam@webkit.org>

        Reviewed by Maciej Stachowiak.

        Avoid an extra lookup when transitioning to an existing StructureID
        by caching the offset of property that caused the transition.

        1% win on V8 suite.  Wash on SunSpider.

        * kjs/PropertyMap.cpp:
        (JSC::PropertyMap::put):
        * kjs/PropertyMap.h:
        * kjs/StructureID.cpp:
        (JSC::StructureID::StructureID):
        (JSC::StructureID::addPropertyTransition):
        * kjs/StructureID.h:
        (JSC::StructureID::setCachedTransistionOffset):
        (JSC::StructureID::cachedTransistionOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-05 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Sun, 5 Oct 2008 22:47:24 +0000 (22:47 +0000)]
2008-10-05  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Maciej Stachowiak.

        Bug 21364: Remove the branch in op_ret for OptionalCalleeActivation and OptionalCalleeArguments
        <https://bugs.webkit.org/show_bug.cgi?id=21364>

        This patch does not yet remove the branch, but it does a bit of refactoring
        so that a CodeGenerator now knows whether the associated CodeBlock will need
        a full scope before doing any code generation. This makes it possible to emit
        explicit tear-off instructions before every op_ret.

        * VM/CodeBlock.h:
        (JSC::CodeBlock::CodeBlock):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::generate):
        (JSC::CodeGenerator::CodeGenerator):
        (JSC::CodeGenerator::emitPushScope):
        (JSC::CodeGenerator::emitPushNewScope):
        * kjs/nodes.h:
        (JSC::ScopeNode::needsActivation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-05 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
jmalonzo@webkit.org [Sun, 5 Oct 2008 21:57:05 +0000 (21:57 +0000)]
2008-10-05  Luke Kenneth Casson Leighton  <lkcl@lkcl.net>

        Reviewed by David Hyatt.

        GTK_WINDOW_HWND not GTK_WINDOWING_HWND
        https://bugs.webkit.org/show_bug.cgi?id=20725

        Updated to ToT by Jan Alonzo.

        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::getValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-05 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 5 Oct 2008 21:50:12 +0000 (21:50 +0000)]
2008-10-05  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Darin Adler.

        Invalid cast from GdkWindow to GtkWidget
        https://bugs.webkit.org/show_bug.cgi?id=21391

        Fix a misplaced closing parenthesis to actually cast the widget, not the window

        * platform/gtk/PlatformScreenGtk.cpp:
        (WebCore::screenDepth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
abarth@webkit.org [Sun, 5 Oct 2008 19:12:30 +0000 (19:12 +0000)]
WebCore:

2008-10-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Alder.

        Attach the Origin header to POST requests to help defend against
        cross-site request forgery.

        https://bugs.webkit.org/show_bug.cgi?id=20792

        Collin Jackson <collinj@webkit.org> also contributed to this patch.

        Tests: http/tests/security/originHeader/origin-header-for-data.html
               http/tests/security/originHeader/origin-header-for-empty.html
               http/tests/security/originHeader/origin-header-for-get.html
               http/tests/security/originHeader/origin-header-for-https.html
               http/tests/security/originHeader/origin-header-for-post.html

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::createWindow):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createWindow):
        (WebCore::FrameLoader::urlSelected):
        (WebCore::FrameLoader::submitForm):
        (WebCore::FrameLoader::outgoingOrigin):
        (WebCore::FrameLoader::loadURL):
        (WebCore::FrameLoader::addExtraFieldsToRequest):
        (WebCore::FrameLoader::loadPostRequest):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::FrameLoader::loadItem):
        * loader/FrameLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        * loader/loader.cpp:
        (WebCore::Loader::Host::servePendingRequests):
        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::toHTTPOrigin):
        * platform/SecurityOrigin.h:
        * platform/network/ResourceRequestBase.h:
        (WebCore::ResourceRequestBase::httpOrigin):
        (WebCore::ResourceRequestBase::setHTTPOrigin):
        (WebCore::ResourceRequestBase::clearHTTPOrigin):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
        (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
        (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
        (WebCore::XMLHttpRequest::didReceiveResponsePreflight):

LayoutTests:

2008-10-04  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Tests for the new Origin header.

        https://bugs.webkit.org/show_bug.cgi?id=20792

        Collin Jackson <collinj@webkit.org> also contributed to this patch.

        * http/tests/security/originHeader: Added.
        * http/tests/security/originHeader/origin-header-for-data-expected.txt: Added.
        * http/tests/security/originHeader/origin-header-for-data.html: Added.
        * http/tests/security/originHeader/origin-header-for-empty-expected.txt: Added.
        * http/tests/security/originHeader/origin-header-for-empty.html: Added.
        * http/tests/security/originHeader/origin-header-for-get-expected.txt: Added.
        * http/tests/security/originHeader/origin-header-for-get.html: Added.
        * http/tests/security/originHeader/origin-header-for-https-expected.txt: Added.
        * http/tests/security/originHeader/origin-header-for-https.html: Added.
        * http/tests/security/originHeader/origin-header-for-post-expected.txt: Added.
        * http/tests/security/originHeader/origin-header-for-post.html: Added.
        * http/tests/security/originHeader/origin-header-for-xmlhttprequest-expected.txt: Added.
        * http/tests/security/originHeader/origin-header-for-xmlhttprequest.html: Added.
        * http/tests/security/originHeader/resources: Added.
        * http/tests/security/originHeader/resources/origin-header-post-to-http.html: Added.
        * http/tests/security/originHeader/resources/print-origin.cgi: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-05 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Sun, 5 Oct 2008 17:38:32 +0000 (17:38 +0000)]
2008-10-05  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Cameron Zwarich.

        Fix for bug #21387 - using SamplingTool with CTI.

        (1) A repatch offset offset changes due to an additional instruction to update SamplingTool state.
        (2) Fix an incusion order problem due to ExecState changes.
        (3) Change to a MACHINE_SAMPLING macro, use of exec should now be accessing global data.

        * VM/CTI.h:
        (JSC::CTI::execute):
        * VM/SamplingTool.h:
        (JSC::SamplingTool::privateExecuteReturned):
        * kjs/Shell.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 21381: Incremental parsing of html causes bogus line numbers in some cases
oliver@apple.com [Sun, 5 Oct 2008 08:28:51 +0000 (08:28 +0000)]
Bug 21381: Incremental parsing of html causes bogus line numbers in some cases
<https://bugs.webkit.org/show_bug.cgi?id=21381>

Reviewed by Tim Hatcher.

If we hit a parsing boundary (end of a packet, etc) in the middle of a
<script> element when we are doing an incremental parse, we exit the
parser, and reenter later when more data is available.  During this
reentry we incorrectly reset the scriptStartLineno to the current line
in the parser, which is now part way through the script element.

The solution is to track whether we are entering or reentering the parsing
of a script element.  We do this simply by 0 checking scriptStartLineno,
and resetting it after we complete parsing of each script element.

Test: http/tests/incremental/pause-in-script-element.pl

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-04 Alp Toker <alp@nuanti.com>
jmalonzo@webkit.org [Sun, 5 Oct 2008 06:13:28 +0000 (06:13 +0000)]
2008-10-04  Alp Toker  <alp@nuanti.com>

        Reviewed by David Hyatt. Landed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=20924
        [Gtk] Linux/Gtk: Recent tree revisions fail Acid2 and Acid3

        https://bugs.webkit.org/show_bug.cgi?id=19578
        [CURL] problem in parseDataUrl

        De-obfuscate parseDataUrl() and fix regressions introduced in r35954.
        This patch also fixes encoding support in escaped (non-Base64) data
        URLs. All manual data URL tests now pass in both GLib and non-GLib
        code paths.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::parseDataUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Makes breakpoints and debugging code during page load work in the
timothy@apple.com [Sun, 5 Oct 2008 04:12:40 +0000 (04:12 +0000)]
    Makes breakpoints and debugging code during page load work in the
        Web Inspector's debugger. Specifically, this makes the source
        code for loading resources show up in the Scripts panel.

        https://bugs.webkit.org/show_bug.cgi?id=19053
        rdar://problem/5933408

        Reviewed by Mark Rowe.

        * WebCore.xcodeproj/project.pbxproj: Mark the inspector group as
        not using tabs and a tab width of 8.
        * inspector/InspectorController.cpp:
        (WebCore::addResourceSourceToFrame): Return a bool to report if the
        source was added successfully or not.
        (WebCore::addSourceToFrame): Ditto.
        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
        Return early if the InspectorController.addSourceToFrame fails.
        Moved the delete of the _frameNeedsSetup property after that call so
        if the source wasn't added it will be attempted again.
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype.detach): Move a comment.
        (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
        Don't check if the resource is finished or failed, just attempt
        to add the source to the frame. WebCore has the source, but the
        finished property hasn't been set yet. Return early if the
        InspectorController.addSourceToFrame fails. Moved the delete
        of the _frameNeedsSetup property after that call so if the source
        wasn't added it will be attempted again.
        (WebInspector.SourceView.prototype._resourceLoadingFinished):
        Clear the _frameNeedsSetup and _sourceFrameSetup properties so
        the source frame will we populated again now that the resource
        load has finished.
        * manual-tests/inspector/debugger-pause-during-load.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd a 'Check For Weak VTables' build phase to catch weak vtables as early as possible.
mrowe@apple.com [Sun, 5 Oct 2008 03:04:18 +0000 (03:04 +0000)]
Add a 'Check For Weak VTables' build phase to catch weak vtables as early as possible.

Reviewed by Tim Hatcher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate check-for-weak-vtables to check only the final linked image for weak vtables.
mrowe@apple.com [Sun, 5 Oct 2008 03:04:11 +0000 (03:04 +0000)]
Update check-for-weak-vtables to check only the final linked image for weak vtables.
This gives more useful results than checking each object file independently.

Reviewed by Tim Hatcher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt build bustage.
hyatt@apple.com [Sun, 5 Oct 2008 02:55:58 +0000 (02:55 +0000)]
Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpgrade to WordPress 2.6.2.
mrowe@apple.com [Sun, 5 Oct 2008 02:21:53 +0000 (02:21 +0000)]
Upgrade to WordPress 2.6.2.

* blog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix build bustage I just introduced.
hyatt@apple.com [Sun, 5 Oct 2008 01:04:17 +0000 (01:04 +0000)]
Fix build bustage I just introduced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-04 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sun, 5 Oct 2008 00:55:01 +0000 (00:55 +0000)]
2008-10-04  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21373

        Tear down scrollbars in FrameView rather than ScrollView so that the connection to the hostWindow()
        is still present.

        Reviewed by Mark Rowe

        * page/FrameView.cpp:
        (WebCore::FrameView::~FrameView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt bustage.
hyatt@apple.com [Sat, 4 Oct 2008 23:33:17 +0000 (23:33 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt bustage.
hyatt@apple.com [Sat, 4 Oct 2008 23:15:55 +0000 (23:15 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 4 Oct 2008 22:52:19 +0000 (22:52 +0000)]
2008-10-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Avoid copying a Vector when using getSupportedKeySizes.

        * html/HTMLKeygenElement.cpp:
        (WebCore::HTMLKeygenElement::HTMLKeygenElement):
        * platform/SSLKeyGenerator.h:
        * platform/gtk/TemporaryLinkStubs.cpp:
        (WebCore::getSupportedKeySizes):
        * platform/mac/SSLKeyGeneratorMac.mm:
        (WebCore::getSupportedKeySizes):
        * platform/qt/TemporaryLinkStubs.cpp:
        (WebCore::getSupportedKeySizes):
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::getSupportedKeySizes):
        * platform/wx/TemporaryLinkStubs.cpp:
        (WebCore::getSupportedKeySizes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-04 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 4 Oct 2008 21:57:26 +0000 (21:57 +0000)]
2008-10-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Fix https://bugs.webkit.org/show_bug.cgi?id=21320
        leaks of PropertyNameArrayData seen on buildbot

        - Fix RefPtr cycle by making PropertyNameArrayData's pointer back
          to the StructureID a weak pointer.

        * kjs/PropertyNameArray.h:
        (JSC::PropertyNameArrayData::setCachedStructureID):
        (JSC::PropertyNameArrayData::cachedStructureID):
        * kjs/StructureID.cpp:
        (JSC::StructureID::getEnumerablePropertyNames):
        (JSC::StructureID::clearEnumerationCache):
        (JSC::StructureID::~StructureID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSpeculative fix for Qt bustage from inspector directory move.
hyatt@apple.com [Sat, 4 Oct 2008 21:56:06 +0000 (21:56 +0000)]
Speculative fix for Qt bustage from inspector directory move.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix build bustage from the inspector directory move on Windows.
hyatt@apple.com [Sat, 4 Oct 2008 21:53:05 +0000 (21:53 +0000)]
Fix build bustage from the inspector directory move on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Sat, 4 Oct 2008 21:12:54 +0000 (21:12 +0000)]
JavaScriptCore:

2008-10-04  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        - https://bugs.webkit.org/show_bug.cgi?id=21295
          Bug 21295: Replace ExecState with a call frame Register pointer

        10% faster on Richards; other v8 benchmarks faster too.
        A wash on SunSpider.

        This does the minimum necessary to get the speedup. Next step in
        cleaning this up is to replace ExecState with a CallFrame class,
        and be more judicious about when to pass a call frame and when
        to pass a global data pointer, global object pointer, or perhaps
        something else entirely.

        * VM/CTI.cpp: Remove the debug-only check of the exception in
        ctiVMThrowTrampoline -- already checked in the code the trampoline
        jumps to, so not all that useful. Removed the exec argument from
        ctiTrampoline. Removed emitDebugExceptionCheck -- no longer needed.
        (JSC::CTI::emitCall): Removed code to set ExecState::m_callFrame.
        (JSC::CTI::privateCompileMainPass): Removed code in catch to extract
        the exception from ExecState::m_exception; instead, the code that
        jumps into catch will make sure the exception is already in eax.
        * VM/CTI.h: Removed exec from the ctiTrampoline. Also removed the
        non-helpful "volatile". Temporarily left ARG_exec in as a synonym
        for ARG_r; I'll change that on a future cleanup pass when introducing
        more use of the CallFrame type.
        (JSC::CTI::execute): Removed the ExecState* argument.

        * VM/ExceptionHelpers.cpp:
        (JSC::InterruptedExecutionError::InterruptedExecutionError): Take
        JSGlobalData* instead of ExecState*.
        (JSC::createInterruptedExecutionException): Ditto.
        * VM/ExceptionHelpers.h: Ditto. Also removed an unneeded include.

        * VM/Machine.cpp:
        (JSC::slideRegisterWindowForCall): Removed the exec and
        exceptionValue arguments. Changed to return 0 when there's a stack
        overflow rather than using a separate exception argument to cut
        down on memory accesses in the calling convention.
        (JSC::Machine::unwindCallFrame): Removed the exec argument when
        constructing a DebuggerCallFrame. Also removed code to set
        ExecState::m_callFrame.
        (JSC::Machine::throwException): Removed the exec argument when
        construction a DebuggerCallFrame.
        (JSC::Machine::execute): Updated to use the register instead of
        ExecState and also removed various uses of ExecState.
        (JSC::Machine::debug):
        (JSC::Machine::privateExecute): Put globalData into a local
        variable so it can be used throughout the interpreter. Changed
        the VM_CHECK_EXCEPTION to get the exception in globalData instead
        of through ExecState.
        (JSC::Machine::retrieveLastCaller): Turn exec into a registers
        pointer by calling registers() instead of by getting m_callFrame.
        (JSC::Machine::callFrame): Ditto.
        Tweaked exception macros. Made new versions for when you know
        you have an exception. Get at global exception with ARG_globalData.
        Got rid of the need to pass in the return value type.
        (JSC::Machine::cti_op_add): Update to use new version of exception
        macros.
        (JSC::Machine::cti_op_pre_inc): Ditto.
        (JSC::Machine::cti_timeout_check): Ditto.
        (JSC::Machine::cti_op_instanceof): Ditto.
        (JSC::Machine::cti_op_new_func): Ditto.
        (JSC::Machine::cti_op_call_JSFunction): Optimized by using the
        ARG values directly instead of through local variables -- this gets
        rid of code that just shuffles things around in the stack frame.
        Also get rid of ExecState and update for the new way exceptions are
        handled in slideRegisterWindowForCall.
        (JSC::Machine::cti_vm_compile): Update to make exec out of r since
        they are both the same thing now.
        (JSC::Machine::cti_op_call_NotJSFunction): Ditto.
        (JSC::Machine::cti_op_init_arguments): Ditto.
        (JSC::Machine::cti_op_resolve): Ditto.
        (JSC::Machine::cti_op_construct_JSConstruct): Ditto.
        (JSC::Machine::cti_op_construct_NotJSConstruct): Ditto.
        (JSC::Machine::cti_op_resolve_func): Ditto.
        (JSC::Machine::cti_op_put_by_val): Ditto.
        (JSC::Machine::cti_op_put_by_val_array): Ditto.
        (JSC::Machine::cti_op_resolve_skip): Ditto.
        (JSC::Machine::cti_op_resolve_global): Ditto.
        (JSC::Machine::cti_op_post_inc): Ditto.
        (JSC::Machine::cti_op_resolve_with_base): Ditto.
        (JSC::Machine::cti_op_post_dec): Ditto.
        (JSC::Machine::cti_op_call_eval): Ditto.
        (JSC::Machine::cti_op_throw): Ditto. Also rearranged to return
        the exception value as the return value so it can be used by
        op_catch.
        (JSC::Machine::cti_op_push_scope): Ditto.
        (JSC::Machine::cti_op_in): Ditto.
        (JSC::Machine::cti_op_del_by_val): Ditto.
        (JSC::Machine::cti_vm_throw): Ditto. Also rearranged to return
        the exception value as the return value so it can be used by
        op_catch.

        * kjs/DebuggerCallFrame.cpp:
        (JSC::DebuggerCallFrame::functionName): Pass globalData.
        (JSC::DebuggerCallFrame::evaluate): Eliminated code to make a
        new ExecState.
        * kjs/DebuggerCallFrame.h: Removed ExecState argument from
        constructor.

        * kjs/ExecState.h: Eliminated all data members and made ExecState
        inherit privately from Register instead. Also added a typedef to
        the future name for this class, which is CallFrame. It's just a
        Register* that knows it's a pointer at a call frame. The new class
        can't be constructed or copied. Changed all functions to use
        the this pointer instead of m_callFrame. Changed exception-related
        functions to access an exception in JSGlobalData. Removed functions
        used by CTI to pass the return address to the throw machinery --
        this is now done directly with a global in the global data.

        * kjs/FunctionPrototype.cpp:
        (JSC::functionProtoFuncToString): Pass globalData instead of exec.

        * kjs/InternalFunction.cpp:
        (JSC::InternalFunction::name): Take globalData instead of exec.
        * kjs/InternalFunction.h: Ditto.

        * kjs/JSGlobalData.cpp: Initialize the new exception global to 0.
        * kjs/JSGlobalData.h: Declare two new globals. One for the current
        exception and another for the return address used by CTI to
        implement the throw operation.

        * kjs/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::init): Removed code to set up globalExec,
        which is now the same thing as globalCallFrame.
        (JSC::JSGlobalObject::reset): Get globalExec from our globalExec
        function so we don't have to repeat the logic twice.
        (JSC::JSGlobalObject::mark): Removed code to mark the exception;
        the exception is now stored in JSGlobalData and marked there.
        (JSC::JSGlobalObject::globalExec): Return a pointer to the end
        of the global call frame.
        * kjs/JSGlobalObject.h: Removed the globalExec data member.

        * kjs/JSObject.cpp:
        (JSC::JSObject::putDirectFunction): Pass globalData instead of exec.

        * kjs/collector.cpp:
        (JSC::Heap::collect): Mark the global exception.

        * profiler/ProfileGenerator.cpp:
        (JSC::ProfileGenerator::addParentForConsoleStart): Pass globalData
        instead of exec to createCallIdentifier.

        * profiler/Profiler.cpp:
        (JSC::Profiler::willExecute): Pass globalData instead of exec to
        createCallIdentifier.
        (JSC::Profiler::didExecute): Ditto.
        (JSC::Profiler::createCallIdentifier): Take globalData instead of
        exec.
        (JSC::createCallIdentifierFromFunctionImp): Ditto.
        * profiler/Profiler.h: Change interface to take a JSGlobalData
        instead of an ExecState.

WebKit/mac:

2008-10-04  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        - https://bugs.webkit.org/show_bug.cgi?id=21295
          Bug 21295: Replace ExecState with a call frame Register pointer

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::WebScriptDebugger): Remove 0 passed for ExecState.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-04 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 4 Oct 2008 21:10:00 +0000 (21:10 +0000)]
2008-10-04  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        - prepare for https://bugs.webkit.org/show_bug.cgi?id=21295
          Bug 21295: Replace ExecState with a call frame Register pointer

        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom):
        Remove bogus "const".
        * bindings/js/JSQuarantinedObjectWrapper.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-04 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 4 Oct 2008 21:03:11 +0000 (21:03 +0000)]
2008-10-04  David Hyatt  <hyatt@apple.com>

        Make PopupMenuClient obey the platform abstraction.  Remove any connection to Document and RenderStyle.

        Reviewed by Darin Adler

        * WebCore.xcodeproj/project.pbxproj:
        * platform/PopupMenuClient.h:
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::show):
        * platform/mac/PopupMenuMac.mm:
        (WebCore::PopupMenu::populate):
        (WebCore::PopupMenu::show):
        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::populate):
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::calculatePositionAndSize):
        (WebCore::PopupMenu::paint):
        (WebCore::PopupWndProc):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::itemStyle):
        (WebCore::RenderMenuList::menuStyle):
        (WebCore::RenderMenuList::hostWindow):
        * rendering/RenderMenuList.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::itemStyle):
        (WebCore::RenderTextControl::menuStyle):
        (WebCore::RenderTextControl::hostWindow):
        * rendering/RenderTextControl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-04 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Sat, 4 Oct 2008 20:32:21 +0000 (20:32 +0000)]
2008-10-04  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Darin Adler.

        Bug 21369: Add opcode documentation for all undocumented opcodes
        <https://bugs.webkit.org/show_bug.cgi?id=21369>

        This patch adds opcode documentation for all undocumented opcodes, and
        it also renames op_init_arguments to op_create_arguments.

        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass):
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::CodeGenerator):
        * VM/Machine.cpp:
        (JSC::Machine::privateExecute):
        (JSC::Machine::cti_op_create_arguments):
        * VM/Machine.h:
        * VM/Opcode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-04 Matt Lilek <webkit@mattlilek.com>
pewtermoose@webkit.org [Sat, 4 Oct 2008 18:41:03 +0000 (18:41 +0000)]
2008-10-04  Matt Lilek  <webkit@mattlilek.com>

        Build fix - restore Private role to headers that had it before the move.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix ChangeLog.
darin@apple.com [Sat, 4 Oct 2008 18:37:22 +0000 (18:37 +0000)]
Fix ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-04 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 4 Oct 2008 18:37:11 +0000 (18:37 +0000)]
2008-10-04  Darin Adler  <darin@apple.com>

        - try to fix build

        * DerivedSources.make: Add new inspector directory to VPATH.
        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-04 Matt Lilek <webkit@mattlilek.com>
pewtermoose@webkit.org [Sat, 4 Oct 2008 17:28:44 +0000 (17:28 +0000)]
2008-10-04  Matt Lilek  <webkit@mattlilek.com>

        Not reviewed, attempt to fix Gtk build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Move the Web Inspector files into a top-level "inspector" folder.
timothy@apple.com [Sat, 4 Oct 2008 08:10:54 +0000 (08:10 +0000)]
    Move the Web Inspector files into a top-level "inspector" folder.

        https://bugs.webkit.org/show_bug.cgi?id=21359

        Reviewed by Dave Hyatt.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * inspector/InspectorClient.h: Renamed from WebCore/page/InspectorClient.h.
        * inspector/InspectorController.cpp: Renamed from WebCore/page/InspectorController.cpp.
        * inspector/InspectorController.h: Renamed from WebCore/page/InspectorController.h.
        * inspector/JavaScriptCallFrame.cpp: Renamed from WebCore/page/JavaScriptCallFrame.cpp.
        * inspector/JavaScriptCallFrame.h: Renamed from WebCore/page/JavaScriptCallFrame.h.
        * inspector/JavaScriptCallFrame.idl: Renamed from WebCore/page/JavaScriptCallFrame.idl.
        * inspector/JavaScriptDebugListener.h: Renamed from WebCore/page/JavaScriptDebugListener.h.
        * inspector/JavaScriptDebugServer.cpp: Renamed from WebCore/page/JavaScriptDebugServer.cpp.
        * inspector/JavaScriptDebugServer.h: Renamed from WebCore/page/JavaScriptDebugServer.h.
        * inspector/JavaScriptProfile.cpp: Renamed from WebCore/page/JavaScriptProfile.cpp.
        * inspector/JavaScriptProfile.h: Renamed from WebCore/page/JavaScriptProfile.h.
        * inspector/JavaScriptProfileNode.cpp: Renamed from WebCore/page/JavaScriptProfileNode.cpp.
        * inspector/JavaScriptProfileNode.h: Renamed from WebCore/page/JavaScriptProfileNode.h.
        * inspector/front-end/Breakpoint.js: Renamed from WebCore/page/inspector/Breakpoint.js.
        * inspector/front-end/BreakpointsSidebarPane.js: Renamed from WebCore/page/inspector/BreakpointsSidebarPane.js.
        * inspector/front-end/CallStackSidebarPane.js: Renamed from WebCore/page/inspector/CallStackSidebarPane.js.
        * inspector/front-end/Console.js: Renamed from WebCore/page/inspector/Console.js.
        * inspector/front-end/DataGrid.js: Renamed from WebCore/page/inspector/DataGrid.js.
        * inspector/front-end/Database.js: Renamed from WebCore/page/inspector/Database.js.
        * inspector/front-end/DatabaseQueryView.js: Renamed from WebCore/page/inspector/DatabaseQueryView.js.
        * inspector/front-end/DatabaseTableView.js: Renamed from WebCore/page/inspector/DatabaseTableView.js.
        * inspector/front-end/DatabasesPanel.js: Renamed from WebCore/page/inspector/DatabasesPanel.js.
        * inspector/front-end/ElementsPanel.js: Renamed from WebCore/page/inspector/ElementsPanel.js.
        * inspector/front-end/ElementsTreeOutline.js: Renamed from WebCore/page/inspector/ElementsTreeOutline.js.
        * inspector/front-end/FontView.js: Renamed from WebCore/page/inspector/FontView.js.
        * inspector/front-end/ImageView.js: Renamed from WebCore/page/inspector/ImageView.js.
        * inspector/front-end/Images/back.png: Renamed from WebCore/page/inspector/Images/back.png.
        * inspector/front-end/Images/checker.png: Renamed from WebCore/page/inspector/Images/checker.png.
        * inspector/front-end/Images/clearConsoleButtons.png: Renamed from WebCore/page/inspector/Images/clearConsoleButtons.png.
        * inspector/front-end/Images/closeButtons.png: Renamed from WebCore/page/inspector/Images/closeButtons.png.
        * inspector/front-end/Images/consoleButtons.png: Renamed from WebCore/page/inspector/Images/consoleButtons.png.
        * inspector/front-end/Images/database.png: Renamed from WebCore/page/inspector/Images/database.png.
        * inspector/front-end/Images/databaseTable.png: Renamed from WebCore/page/inspector/Images/databaseTable.png.
        * inspector/front-end/Images/databasesIcon.png: Renamed from WebCore/page/inspector/Images/databasesIcon.png.
        * inspector/front-end/Images/debuggerContinue.png: Renamed from WebCore/page/inspector/Images/debuggerContinue.png.
        * inspector/front-end/Images/debuggerPause.png: Renamed from WebCore/page/inspector/Images/debuggerPause.png.
        * inspector/front-end/Images/debuggerStepInto.png: Renamed from WebCore/page/inspector/Images/debuggerStepInto.png.
        * inspector/front-end/Images/debuggerStepOut.png: Renamed from WebCore/page/inspector/Images/debuggerStepOut.png.
        * inspector/front-end/Images/debuggerStepOver.png: Renamed from WebCore/page/inspector/Images/debuggerStepOver.png.
        * inspector/front-end/Images/debuggingButtons.png: Renamed from WebCore/page/inspector/Images/debuggingButtons.png.
        * inspector/front-end/Images/disclosureTriangleSmallDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDown.png.
        * inspector/front-end/Images/disclosureTriangleSmallDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownBlack.png.
        * inspector/front-end/Images/disclosureTriangleSmallDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallDownWhite.png.
        * inspector/front-end/Images/disclosureTriangleSmallRight.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRight.png.
        * inspector/front-end/Images/disclosureTriangleSmallRightBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightBlack.png.
        * inspector/front-end/Images/disclosureTriangleSmallRightDown.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDown.png.
        * inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownBlack.png.
        * inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightDownWhite.png.
        * inspector/front-end/Images/disclosureTriangleSmallRightWhite.png: Renamed from WebCore/page/inspector/Images/disclosureTriangleSmallRightWhite.png.
        * inspector/front-end/Images/dockButtons.png: Renamed from WebCore/page/inspector/Images/dockButtons.png.
        * inspector/front-end/Images/elementsIcon.png: Renamed from WebCore/page/inspector/Images/elementsIcon.png.
        * inspector/front-end/Images/errorIcon.png: Renamed from WebCore/page/inspector/Images/errorIcon.png.
        * inspector/front-end/Images/errorMediumIcon.png: Renamed from WebCore/page/inspector/Images/errorMediumIcon.png.
        * inspector/front-end/Images/excludeButtons.png: Renamed from WebCore/page/inspector/Images/excludeButtons.png.
        * inspector/front-end/Images/focusButtons.png: Renamed from WebCore/page/inspector/Images/focusButtons.png.
        * inspector/front-end/Images/forward.png: Renamed from WebCore/page/inspector/Images/forward.png.
        * inspector/front-end/Images/glossyHeader.png: Renamed from WebCore/page/inspector/Images/glossyHeader.png.
        * inspector/front-end/Images/glossyHeaderPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderPressed.png.
        * inspector/front-end/Images/glossyHeaderSelected.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelected.png.
        * inspector/front-end/Images/glossyHeaderSelectedPressed.png: Renamed from WebCore/page/inspector/Images/glossyHeaderSelectedPressed.png.
        * inspector/front-end/Images/goArrow.png: Renamed from WebCore/page/inspector/Images/goArrow.png.
        * inspector/front-end/Images/largerResourcesButtons.png: Renamed from WebCore/page/inspector/Images/largerResourcesButtons.png.
        * inspector/front-end/Images/nodeSearchButtons.png: Renamed from WebCore/page/inspector/Images/nodeSearchButtons.png.
        * inspector/front-end/Images/paneBottomGrow.png: Renamed from WebCore/page/inspector/Images/paneBottomGrow.png.
        * inspector/front-end/Images/paneBottomGrowActive.png: Renamed from WebCore/page/inspector/Images/paneBottomGrowActive.png.
        * inspector/front-end/Images/paneGrowHandleLine.png: Renamed from WebCore/page/inspector/Images/paneGrowHandleLine.png.
        * inspector/front-end/Images/pauseOnExceptionButtons.png: Renamed from WebCore/page/inspector/Images/pauseOnExceptionButtons.png.
        * inspector/front-end/Images/percentButtons.png: Renamed from WebCore/page/inspector/Images/percentButtons.png.
        * inspector/front-end/Images/profileGroupIcon.png: Renamed from WebCore/page/inspector/Images/profileGroupIcon.png.
        * inspector/front-end/Images/profileIcon.png: Renamed from WebCore/page/inspector/Images/profileIcon.png.
        * inspector/front-end/Images/profileSmallIcon.png: Renamed from WebCore/page/inspector/Images/profileSmallIcon.png.
        * inspector/front-end/Images/profilesIcon.png: Renamed from WebCore/page/inspector/Images/profilesIcon.png.
        * inspector/front-end/Images/recordButtons.png: Renamed from WebCore/page/inspector/Images/recordButtons.png.
        * inspector/front-end/Images/reloadButtons.png: Renamed from WebCore/page/inspector/Images/reloadButtons.png.
        * inspector/front-end/Images/resourceCSSIcon.png: Renamed from WebCore/page/inspector/Images/resourceCSSIcon.png.
        * inspector/front-end/Images/resourceDocumentIcon.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIcon.png.
        * inspector/front-end/Images/resourceDocumentIconSmall.png: Renamed from WebCore/page/inspector/Images/resourceDocumentIconSmall.png.
        * inspector/front-end/Images/resourceJSIcon.png: Renamed from WebCore/page/inspector/Images/resourceJSIcon.png.
        * inspector/front-end/Images/resourcePlainIcon.png: Renamed from WebCore/page/inspector/Images/resourcePlainIcon.png.
        * inspector/front-end/Images/resourcePlainIconSmall.png: Renamed from WebCore/page/inspector/Images/resourcePlainIconSmall.png.
        * inspector/front-end/Images/resourcesIcon.png: Renamed from WebCore/page/inspector/Images/resourcesIcon.png.
        * inspector/front-end/Images/resourcesSizeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesSizeGraphIcon.png.
        * inspector/front-end/Images/resourcesTimeGraphIcon.png: Renamed from WebCore/page/inspector/Images/resourcesTimeGraphIcon.png.
        * inspector/front-end/Images/scriptsIcon.png: Renamed from WebCore/page/inspector/Images/scriptsIcon.png.
        * inspector/front-end/Images/searchSmallBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBlue.png.
        * inspector/front-end/Images/searchSmallBrightBlue.png: Renamed from WebCore/page/inspector/Images/searchSmallBrightBlue.png.
        * inspector/front-end/Images/searchSmallGray.png: Renamed from WebCore/page/inspector/Images/searchSmallGray.png.
        * inspector/front-end/Images/searchSmallWhite.png: Renamed from WebCore/page/inspector/Images/searchSmallWhite.png.
        * inspector/front-end/Images/segment.png: Renamed from WebCore/page/inspector/Images/segment.png.
        * inspector/front-end/Images/segmentEnd.png: Renamed from WebCore/page/inspector/Images/segmentEnd.png.
        * inspector/front-end/Images/segmentHover.png: Renamed from WebCore/page/inspector/Images/segmentHover.png.
        * inspector/front-end/Images/segmentHoverEnd.png: Renamed from WebCore/page/inspector/Images/segmentHoverEnd.png.
        * inspector/front-end/Images/segmentSelected.png: Renamed from WebCore/page/inspector/Images/segmentSelected.png.
        * inspector/front-end/Images/segmentSelectedEnd.png: Renamed from WebCore/page/inspector/Images/segmentSelectedEnd.png.
        * inspector/front-end/Images/splitviewDimple.png: Renamed from WebCore/page/inspector/Images/splitviewDimple.png.
        * inspector/front-end/Images/splitviewDividerBackground.png: Renamed from WebCore/page/inspector/Images/splitviewDividerBackground.png.
        * inspector/front-end/Images/statusbarBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBackground.png.
        * inspector/front-end/Images/statusbarBottomBackground.png: Renamed from WebCore/page/inspector/Images/statusbarBottomBackground.png.
        * inspector/front-end/Images/statusbarButtons.png: Renamed from WebCore/page/inspector/Images/statusbarButtons.png.
        * inspector/front-end/Images/statusbarMenuButton.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButton.png.
        * inspector/front-end/Images/statusbarMenuButtonSelected.png: Renamed from WebCore/page/inspector/Images/statusbarMenuButtonSelected.png.
        * inspector/front-end/Images/statusbarResizerHorizontal.png: Renamed from WebCore/page/inspector/Images/statusbarResizerHorizontal.png.
        * inspector/front-end/Images/statusbarResizerVertical.png: Renamed from WebCore/page/inspector/Images/statusbarResizerVertical.png.
        * inspector/front-end/Images/timelinePillBlue.png: Renamed from WebCore/page/inspector/Images/timelinePillBlue.png.
        * inspector/front-end/Images/timelinePillGray.png: Renamed from WebCore/page/inspector/Images/timelinePillGray.png.
        * inspector/front-end/Images/timelinePillGreen.png: Renamed from WebCore/page/inspector/Images/timelinePillGreen.png.
        * inspector/front-end/Images/timelinePillOrange.png: Renamed from WebCore/page/inspector/Images/timelinePillOrange.png.
        * inspector/front-end/Images/timelinePillPurple.png: Renamed from WebCore/page/inspector/Images/timelinePillPurple.png.
        * inspector/front-end/Images/timelinePillRed.png: Renamed from WebCore/page/inspector/Images/timelinePillRed.png.
        * inspector/front-end/Images/timelinePillYellow.png: Renamed from WebCore/page/inspector/Images/timelinePillYellow.png.
        * inspector/front-end/Images/tipBalloon.png: Renamed from WebCore/page/inspector/Images/tipBalloon.png.
        * inspector/front-end/Images/tipBalloonBottom.png: Renamed from WebCore/page/inspector/Images/tipBalloonBottom.png.
        * inspector/front-end/Images/tipIcon.png: Renamed from WebCore/page/inspector/Images/tipIcon.png.
        * inspector/front-end/Images/tipIconPressed.png: Renamed from WebCore/page/inspector/Images/tipIconPressed.png.
        * inspector/front-end/Images/toolbarItemSelected.png: Renamed from WebCore/page/inspector/Images/toolbarItemSelected.png.
        * inspector/front-end/Images/treeDownTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleBlack.png.
        * inspector/front-end/Images/treeDownTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeDownTriangleWhite.png.
        * inspector/front-end/Images/treeRightTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleBlack.png.
        * inspector/front-end/Images/treeRightTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeRightTriangleWhite.png.
        * inspector/front-end/Images/treeUpTriangleBlack.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleBlack.png.
        * inspector/front-end/Images/treeUpTriangleWhite.png: Renamed from WebCore/page/inspector/Images/treeUpTriangleWhite.png.
        * inspector/front-end/Images/userInputIcon.png: Renamed from WebCore/page/inspector/Images/userInputIcon.png.
        * inspector/front-end/Images/userInputPreviousIcon.png: Renamed from WebCore/page/inspector/Images/userInputPreviousIcon.png.
        * inspector/front-end/Images/warningIcon.png: Renamed from WebCore/page/inspector/Images/warningIcon.png.
        * inspector/front-end/Images/warningMediumIcon.png: Renamed from WebCore/page/inspector/Images/warningMediumIcon.png.
        * inspector/front-end/Images/warningsErrors.png: Renamed from WebCore/page/inspector/Images/warningsErrors.png.
        * inspector/front-end/MetricsSidebarPane.js: Renamed from WebCore/page/inspector/MetricsSidebarPane.js.
        * inspector/front-end/Object.js: Renamed from WebCore/page/inspector/Object.js.
        * inspector/front-end/ObjectPropertiesSection.js: Renamed from WebCore/page/inspector/ObjectPropertiesSection.js.
        * inspector/front-end/Panel.js: Renamed from WebCore/page/inspector/Panel.js.
        * inspector/front-end/Placard.js: Renamed from WebCore/page/inspector/Placard.js.
        * inspector/front-end/ProfileView.js: Renamed from WebCore/page/inspector/ProfileView.js.
        * inspector/front-end/ProfilesPanel.js: Renamed from WebCore/page/inspector/ProfilesPanel.js.
        * inspector/front-end/PropertiesSection.js: Renamed from WebCore/page/inspector/PropertiesSection.js.
        * inspector/front-end/PropertiesSidebarPane.js: Renamed from WebCore/page/inspector/PropertiesSidebarPane.js.
        * inspector/front-end/Resource.js: Renamed from WebCore/page/inspector/Resource.js.
        * inspector/front-end/ResourceCategory.js: Renamed from WebCore/page/inspector/ResourceCategory.js.
        * inspector/front-end/ResourceView.js: Renamed from WebCore/page/inspector/ResourceView.js.
        * inspector/front-end/ResourcesPanel.js: Renamed from WebCore/page/inspector/ResourcesPanel.js.
        * inspector/front-end/ScopeChainSidebarPane.js: Renamed from WebCore/page/inspector/ScopeChainSidebarPane.js.
        * inspector/front-end/Script.js: Renamed from WebCore/page/inspector/Script.js.
        * inspector/front-end/ScriptView.js: Renamed from WebCore/page/inspector/ScriptView.js.
        * inspector/front-end/ScriptsPanel.js: Renamed from WebCore/page/inspector/ScriptsPanel.js.
        * inspector/front-end/SidebarPane.js: Renamed from WebCore/page/inspector/SidebarPane.js.
        * inspector/front-end/SidebarTreeElement.js: Renamed from WebCore/page/inspector/SidebarTreeElement.js.
        * inspector/front-end/SourceFrame.js: Renamed from WebCore/page/inspector/SourceFrame.js.
        * inspector/front-end/SourceView.js: Renamed from WebCore/page/inspector/SourceView.js.
        * inspector/front-end/StylesSidebarPane.js: Renamed from WebCore/page/inspector/StylesSidebarPane.js.
        * inspector/front-end/TextPrompt.js: Renamed from WebCore/page/inspector/TextPrompt.js.
        * inspector/front-end/View.js: Renamed from WebCore/page/inspector/View.js.
        * inspector/front-end/WebKit.qrc: Renamed from WebCore/page/inspector/WebKit.qrc.
        * inspector/front-end/inspector.css: Renamed from WebCore/page/inspector/inspector.css.
        * inspector/front-end/inspector.html: Renamed from WebCore/page/inspector/inspector.html.
        * inspector/front-end/inspector.js: Renamed from WebCore/page/inspector/inspector.js.
        * inspector/front-end/treeoutline.js: Renamed from WebCore/page/inspector/treeoutline.js.
        * inspector/front-end/utilities.js: Renamed from WebCore/page/inspector/utilities.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Adds support to the Web Inspector's Elements panel for fast tag name,
timothy@apple.com [Sat, 4 Oct 2008 08:09:52 +0000 (08:09 +0000)]
    Adds support to the Web Inspector's Elements panel for fast tag name,
        class name, id and attribute name searching. The panel first tries
        using getElementById, getElementsByClassName and getElementsByTagName
        with the search query. Then does a slower search using XPath for partial
        matches, text and comment matches.

        Adds support for search queries like "<div>", "<h" and "frame>".
        These forms limit the search to tag names, text and comment matches.

        https://bugs.webkit.org/show_bug.cgi?id=21353

        Reviewed by Maciej Stachowiak.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.performSearch): Add tag syntax
        support. Add new search functions that try exact matches first.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Changes how searching works in the Web Inspector's Elements
timothy@apple.com [Sat, 4 Oct 2008 08:09:41 +0000 (08:09 +0000)]
    Changes how searching works in the Web Inspector's Elements
        panel. The search tasks are divided into chunks that are small
        units of work that are performed at a time interval. This
        change also prevents queries that will select all elements,
        since that isn't useful.

        https://bugs.webkit.org/show_bug.cgi?id=21285

        Reviewed by Oliver Hunt.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.searchCancled):
        Remove the searchResultsProperty form results since there might
        be an unfinished search.
        (WebInspector.ElementsPanel.prototype.performSearch): Divide the
        documents and search functions into chunks that are performed on
        a interval of 25ms. Prevent searches for "//*" and "*".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix a typo.
timothy@apple.com [Sat, 4 Oct 2008 08:00:42 +0000 (08:00 +0000)]
Fix a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
mjs@apple.com [Sat, 4 Oct 2008 07:15:33 +0000 (07:15 +0000)]
JavaScriptCore:

2008-10-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - "this" object in methods called on primitives should be wrapper object
        https://bugs.webkit.org/show_bug.cgi?id=21362

        I changed things so that functions which use "this" do a fast
        version of toThisObject conversion if needed. Currently we miss
        the conversion entirely, at least for primitive types. Using
        TypeInfo and the primitive check, I made the fast case bail out
        pretty fast.

        This is inexplicably an 1.007x SunSpider speedup (and a wash on V8 benchmarks).

        Also renamed some opcodes for clarity:

        init ==> enter
        init_activation ==> enter_with_activation

        * VM/CTI.cpp:
        (JSC::CTI::privateCompileMainPass):
        (JSC::CTI::privateCompileSlowCases):
        * VM/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * VM/CodeGenerator.cpp:
        (JSC::CodeGenerator::generate):
        (JSC::CodeGenerator::CodeGenerator):
        * VM/Machine.cpp:
        (JSC::Machine::privateExecute):
        (JSC::Machine::cti_op_convert_this):
        * VM/Machine.h:
        * VM/Opcode.h:
        * kjs/JSActivation.cpp:
        (JSC::JSActivation::JSActivation):
        * kjs/JSActivation.h:
        (JSC::JSActivation::createStructureID):
        * kjs/JSCell.h:
        (JSC::JSValue::needsThisConversion):
        * kjs/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        * kjs/JSGlobalData.h:
        * kjs/JSNumberCell.h:
        (JSC::JSNumberCell::createStructureID):
        * kjs/JSStaticScopeObject.h:
        (JSC::JSStaticScopeObject::JSStaticScopeObject):
        (JSC::JSStaticScopeObject::createStructureID):
        * kjs/JSString.h:
        (JSC::JSString::createStructureID):
        * kjs/JSValue.h:
        * kjs/TypeInfo.h:
        (JSC::TypeInfo::needsThisConversion):
        * kjs/nodes.h:
        (JSC::ScopeNode::usesThis):

WebCore:

2008-10-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - "this" object in methods called on primitives should be wrapper object
        https://bugs.webkit.org/show_bug.cgi?id=21362

        Updated so toThis conversion for the split window is handled properly.

        * bindings/scripts/CodeGeneratorJS.pm:

LayoutTests:

2008-10-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - test case for: "this" object in methods called on primitives should be wrapper object

        * fast/js/primitive-method-this-expected.txt: Added.
        * fast/js/primitive-method-this.html: Added.
        * fast/js/resources/primitive-method-this.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt bustage.
hyatt@apple.com [Sat, 4 Oct 2008 06:40:22 +0000 (06:40 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Sat, 4 Oct 2008 05:47:38 +0000 (05:47 +0000)]
2008-10-03  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Maciej Stachowiak.

        Bug 21356: The size of the RegisterFile differs depending on 32-bit / 64-bit and Debug / Release
        <https://bugs.webkit.org/show_bug.cgi?id=21356>

        The RegisterFile decreases in size (measured in terms of numbers of
        Registers) as the size of a Register increases. This causes

            js1_5/Regress/regress-159334.js

        to fail in 64-bit debug builds. This fix makes the RegisterFile on all
        platforms the same size that it is in 32-bit Release builds.

        * VM/RegisterFile.h:
        (JSC::RegisterFile::RegisterFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 4 Oct 2008 05:16:40 +0000 (05:16 +0000)]
2008-10-03  Sam Weinig  <sam@webkit.org>

        Reviewed by David "The Motivator" Hyatt.

        Patch for https://bugs.webkit.org/show_bug.cgi?id=21355
        Move SecurityOrigin out of platform/ to page/.

        It was a layering violation for SecurityOrigin to be in platform
        as it depended on FrameLoader.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * page/SecurityOrigin.cpp: Copied from platform/SecurityOrigin.cpp.
        * page/SecurityOrigin.h: Copied from platform/SecurityOrigin.h.
        * page/SecurityOriginHash.h: Copied from platform/SecurityOriginHash.h.
        * platform/SecurityOrigin.cpp: Removed.
        * platform/SecurityOrigin.h: Removed.
        * platform/SecurityOriginHash.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Marco Barisione <marco.barisione@collabora.co.uk>
jmalonzo@webkit.org [Sat, 4 Oct 2008 04:24:23 +0000 (04:24 +0000)]
2008-10-03  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18832
        [curl] file upload does not work

        The curl_off_t integer type has a different size depending if large
        file support is enabled or not. There is no different public API for
        the two cases, so the same function accepts a different type based on
        a compilation option the could be different in WebKit and libcurl.
        To fix the bug we query libcurl at runtime for large file support and
        pass the right type based on that.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::setupPOST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 4 Oct 2008 04:02:30 +0000 (04:02 +0000)]
2008-10-03  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by David Hyatt.

        Gtk build fixes.

        * platform/gtk/FileChooserGtk.cpp:
        (WebCore::FileChooser::openFileChooser):
        * platform/gtk/PlatformScreenGtk.cpp:
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenAvailableRect):
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::show):
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::platformAddChild):
        (WebCore::ScrollView::platformRemoveChild):
        * platform/gtk/WidgetGtk.cpp:
        (WebCore::Widget::setCursor):
        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::getValue):
        (WebCore::PluginView::forceRedraw):
        (WebCore::PluginView::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt bustage.
hyatt@apple.com [Sat, 4 Oct 2008 03:31:39 +0000 (03:31 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Windows bustage in WebKit side.
hyatt@apple.com [Sat, 4 Oct 2008 02:02:53 +0000 (02:02 +0000)]
Fix Windows bustage in WebKit side.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Windows bustage in WebKit side.
hyatt@apple.com [Sat, 4 Oct 2008 02:01:18 +0000 (02:01 +0000)]
Fix Windows bustage in WebKit side.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Win bustage.
hyatt@apple.com [Sat, 4 Oct 2008 01:50:21 +0000 (01:50 +0000)]
Fix Win bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 4 Oct 2008 01:39:43 +0000 (01:39 +0000)]
2008-10-03  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        - Some code cleanup to how we handle code features.

        1) Rename FeatureInfo typedef to CodeFeatures.
        2) Rename NodeFeatureInfo template to NodeInfo.
        3) Keep CodeFeature bitmask in ScopeNode instead of trying to break it out into individual bools.
        4) Rename misleadingly named "needsClosure" method to "containsClosures", which better describes the meaning
        of ClosureFeature.
        5) Make setUsersArguments() not take an argument since it only goes one way.

        * JavaScriptCore.exp:
        * VM/CodeBlock.h:
        (JSC::CodeBlock::CodeBlock):
        * kjs/NodeInfo.h:
        * kjs/Parser.cpp:
        (JSC::Parser::didFinishParsing):
        * kjs/Parser.h:
        (JSC::Parser::parse):
        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (JSC::ScopeNode::ScopeNode):
        (JSC::ProgramNode::ProgramNode):
        (JSC::ProgramNode::create):
        (JSC::EvalNode::EvalNode):
        (JSC::EvalNode::create):
        (JSC::FunctionBodyNode::FunctionBodyNode):
        (JSC::FunctionBodyNode::create):
        * kjs/nodes.h:
        (JSC::ScopeNode::usesEval):
        (JSC::ScopeNode::containsClosures):
        (JSC::ScopeNode::usesArguments):
        (JSC::ScopeNode::setUsesArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 4 Oct 2008 01:11:00 +0000 (01:11 +0000)]
2008-10-03  David Hyatt  <hyatt@apple.com>

        Fix Gtk bustage from use of containingWindow() over on the WebKit side.  Replace with HostWindow use.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 4 Oct 2008 01:09:37 +0000 (01:09 +0000)]
2008-10-03  David Hyatt  <hyatt@apple.com>

        Fix Qt bustage from missing include.

        * platform/qt/PlatformScreenQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 4 Oct 2008 01:08:35 +0000 (01:08 +0000)]
2008-10-03  David Hyatt  <hyatt@apple.com>

        Fix Windows scrollbar bustage in popup menus.

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupWndProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 4 Oct 2008 01:07:31 +0000 (01:07 +0000)]
2008-10-03  David Hyatt  <hyatt@apple.com>

        Fix Windows bustage.

        * platform/win/FileChooserWin.cpp:
        (WebCore::FileChooser::openFileChooser):
        * platform/win/PlatformScreenWin.cpp:
        (WebCore::monitorInfoForWidget):
        * platform/win/WidgetWin.cpp:
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::getValue):
        (WebCore::PluginView::forceRedraw):
        (WebCore::PluginView::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Pierre-Olivier Latour <pol@apple.com>
simon.fraser@apple.com [Sat, 4 Oct 2008 00:21:23 +0000 (00:21 +0000)]
2008-10-03  Pierre-Olivier Latour <pol@apple.com>

        Reviewed by Darin Adler

        Render images to RGBA8 bitmaps independently of platform endianness.

        Create image difference bitmap in reference image colorspace instead of device colorspace
        (which depends on the main display profile), so that no color matching happens.

        https://bugs.webkit.org/show_bug.cgi?id=21336

        * DumpRenderTree/cg/ImageDiffCG.cpp:
        (createDifferenceBitmap):
        (computePercentageDifferent):
        (compareImages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 4 Oct 2008 00:16:58 +0000 (00:16 +0000)]
2008-10-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        Fix hang when running with --pixel --reset, which occurs
        because DRT spews PNG data when the script does not expect it.

        https://bugs.webkit.org/show_bug.cgi?id=21323

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Sat, 4 Oct 2008 00:10:29 +0000 (00:10 +0000)]
2008-10-03  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Maciej Stachowiak.

        Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
        <https://bugs.webkit.org/show_bug.cgi?id=21343>

        A fix was landed for this issue in r37253, and the ChangeLog assumes
        that it is a compiler bug, but it turns out that it is a subtle issue
        with mixing signed and unsigned 32-bit values in a 64-bit environment.
        In order to properly fix this bug, we should convert our signed offsets
        into the register file to use ptrdiff_t.

        This may not be the only instance of this issue, but I will land this
        fix first and look for more later.

        * VM/Machine.cpp:
        (JSC::Machine::getArgumentsData):
        * VM/Machine.h:
        * kjs/Arguments.cpp:
        (JSC::Arguments::getOwnPropertySlot):
        * kjs/Arguments.h:
        (JSC::Arguments::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Fri, 3 Oct 2008 23:15:17 +0000 (23:15 +0000)]
2008-10-03  John Sullivan  <sullivan@apple.com>

        Fixed Release build

        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::destroyStream):
        added !LOG_DISABLED guard around declaration of npErr used only in LOG

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 3 Oct 2008 22:55:04 +0000 (22:55 +0000)]
2008-10-03  Darin Adler  <darin@apple.com>

        * bindings/js/JSInspectedObjectWrapper.cpp: Try to fix a build failure
        seen on some machines but not others by adding an include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 3 Oct 2008 22:41:30 +0000 (22:41 +0000)]
2008-10-03  Darin Adler  <darin@apple.com>

        - Qt build fix

        * bridge/qt/qt_runtime.cpp: Remove long-obsolete codeType and
        execute functions. Declarations for these relied on the CodeType
        enumeration, which used to be in ExecState.h; but the functions
        aren't needed at all.
        * bridge/qt/qt_runtime.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 3 Oct 2008 22:29:23 +0000 (22:29 +0000)]
2008-10-03  Darin Adler  <darin@apple.com>

        * VM/CTI.cpp: Another Windows build fix. Change the args of ctiTrampoline.

        * kjs/JSNumberCell.h: A build fix for newer versions of gcc. Added
        declarations of JSGlobalData overloads of jsNumberCell.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix wx bustage.
hyatt@apple.com [Fri, 3 Oct 2008 22:24:40 +0000 (22:24 +0000)]
Fix wx bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt bustage.
hyatt@apple.com [Fri, 3 Oct 2008 22:24:06 +0000 (22:24 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Gtk bustage.
hyatt@apple.com [Fri, 3 Oct 2008 22:23:47 +0000 (22:23 +0000)]
Fix Gtk bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 3 Oct 2008 21:58:20 +0000 (21:58 +0000)]
2008-10-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.

        Convert destroyStream over to C++.

        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::destroyStream):
        (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]):
        (-[WebBaseNetscapePluginStream _deliverData]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 3 Oct 2008 21:54:52 +0000 (21:54 +0000)]
2008-10-03  Darin Adler  <darin@apple.com>

        - try to fix Windows build

        * kjs/ScopeChain.h: Add forward declaration of JSGlobalData.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 3 Oct 2008 21:45:54 +0000 (21:45 +0000)]
2008-10-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.

        Use a Timer instead of -[NSObject performSelector:withObject:afterDelay];

        * Plugins/WebBaseNetscapePluginStream.h:
        (WebNetscapePluginStream::WebNetscapePluginStream):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream _destroyStream]):
        (-[WebBaseNetscapePluginStream _deliverData]):
        (WebNetscapePluginStream::deliverDataTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Fri, 3 Oct 2008 21:39:16 +0000 (21:39 +0000)]
JavaScriptCore:

2008-10-03  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        - next step of https://bugs.webkit.org/show_bug.cgi?id=21295
          Turn ExecState into a call frame pointer.

        Remove m_globalObject and m_globalData from ExecState.

        SunSpider says this is a wash (slightly faster but not statistically
        significant); which is good enough since it's a preparation step and
        not supposed to be a spedup.

        * API/JSCallbackFunction.cpp:
        (JSC::JSCallbackFunction::JSCallbackFunction):
        * kjs/ArrayConstructor.cpp:
        (JSC::ArrayConstructor::ArrayConstructor):
        * kjs/BooleanConstructor.cpp:
        (JSC::BooleanConstructor::BooleanConstructor):
        * kjs/DateConstructor.cpp:
        (JSC::DateConstructor::DateConstructor):
        * kjs/ErrorConstructor.cpp:
        (JSC::ErrorConstructor::ErrorConstructor):
        * kjs/FunctionPrototype.cpp:
        (JSC::FunctionPrototype::FunctionPrototype):
        * kjs/JSFunction.cpp:
        (JSC::JSFunction::JSFunction):
        * kjs/NativeErrorConstructor.cpp:
        (JSC::NativeErrorConstructor::NativeErrorConstructor):
        * kjs/NumberConstructor.cpp:
        (JSC::NumberConstructor::NumberConstructor):
        * kjs/ObjectConstructor.cpp:
        (JSC::ObjectConstructor::ObjectConstructor):
        * kjs/PrototypeFunction.cpp:
        (JSC::PrototypeFunction::PrototypeFunction):
        * kjs/RegExpConstructor.cpp:
        (JSC::RegExpConstructor::RegExpConstructor):
        * kjs/StringConstructor.cpp:
        (JSC::StringConstructor::StringConstructor):
        Pass JSGlobalData* instead of ExecState* to the InternalFunction
        constructor.

        * API/OpaqueJSString.cpp: Added now-needed include.

        * JavaScriptCore.exp: Updated.

        * VM/CTI.cpp:
        (JSC::CTI::emitSlowScriptCheck): Changed to use ARGS_globalData
        instead of ARGS_exec.

        * VM/CTI.h: Added a new argument to the CTI, the global data pointer.
        While it's possible to get to the global data pointer using the
        ExecState pointer, it's slow enough that it's better to just keep
        it around in the CTI arguments.

        * VM/CodeBlock.h: Moved the CodeType enum here from ExecState.h.

        * VM/Machine.cpp:
        (JSC::Machine::execute): Pass fewer arguments when constructing
        ExecState, and pass the global data pointer when invoking CTI.
        (JSC::Machine::firstCallFrame): Added. Used to get the dynamic global
        object, which is in the scope chain of the first call frame.
        (JSC::Machine::cti_op_add): Use globalData instead of exec when
        possible, to keep fast cases fast, since it's now more expensive to
        get to it through the exec pointer.
        (JSC::Machine::cti_timeout_check): Ditto.
        (JSC::Machine::cti_op_put_by_id_second): Ditto.
        (JSC::Machine::cti_op_get_by_id_second): Ditto.
        (JSC::Machine::cti_op_mul): Ditto.
        (JSC::Machine::cti_vm_compile): Ditto.
        (JSC::Machine::cti_op_get_by_val): Ditto.
        (JSC::Machine::cti_op_sub): Ditto.
        (JSC::Machine::cti_op_put_by_val): Ditto.
        (JSC::Machine::cti_op_put_by_val_array): Ditto.
        (JSC::Machine::cti_op_negate): Ditto.
        (JSC::Machine::cti_op_div): Ditto.
        (JSC::Machine::cti_op_pre_dec): Ditto.
        (JSC::Machine::cti_op_post_inc): Ditto.
        (JSC::Machine::cti_op_lshift): Ditto.
        (JSC::Machine::cti_op_bitand): Ditto.
        (JSC::Machine::cti_op_rshift): Ditto.
        (JSC::Machine::cti_op_bitnot): Ditto.
        (JSC::Machine::cti_op_mod): Ditto.
        (JSC::Machine::cti_op_post_dec): Ditto.
        (JSC::Machine::cti_op_urshift): Ditto.
        (JSC::Machine::cti_op_bitxor): Ditto.
        (JSC::Machine::cti_op_bitor): Ditto.
        (JSC::Machine::cti_op_call_eval): Ditto.
        (JSC::Machine::cti_op_throw): Ditto.
        (JSC::Machine::cti_op_is_string): Ditto.
        (JSC::Machine::cti_op_debug): Ditto.
        (JSC::Machine::cti_vm_throw): Ditto.

        * VM/Machine.h: Added firstCallFrame.

        * kjs/DebuggerCallFrame.cpp:
        (JSC::DebuggerCallFrame::evaluate): Pass fewer arguments when
        constructing ExecState.

        * kjs/ExecState.cpp: Deleted contents. Later we'll remove the
        file altogether.

        * kjs/ExecState.h: Removed m_globalObject and m_globalData.
        Moved CodeType into another header.
        (JSC::ExecState::ExecState): Take only a single argument, a
        call frame pointer.
        (JSC::ExecState::dynamicGlobalObject): Get the object from
        the first call frame since it's no longer stored.
        (JSC::ExecState::globalData): Get the global data from the
        scope chain, since we no longer store a pointer to it here.
        (JSC::ExecState::identifierTable): Ditto.
        (JSC::ExecState::propertyNames): Ditto.
        (JSC::ExecState::emptyList): Ditto.
        (JSC::ExecState::lexer): Ditto.
        (JSC::ExecState::parser): Ditto.
        (JSC::ExecState::machine): Ditto.
        (JSC::ExecState::arrayTable): Ditto.
        (JSC::ExecState::dateTable): Ditto.
        (JSC::ExecState::mathTable): Ditto.
        (JSC::ExecState::numberTable): Ditto.
        (JSC::ExecState::regExpTable): Ditto.
        (JSC::ExecState::regExpConstructorTable): Ditto.
        (JSC::ExecState::stringTable): Ditto.
        (JSC::ExecState::heap): Ditto.

        * kjs/FunctionConstructor.cpp:
        (JSC::FunctionConstructor::FunctionConstructor): Pass
        JSGlobalData* instead of ExecState* to the InternalFunction
        constructor.
        (JSC::constructFunction): Pass the global data pointer when
        constructing a new scope chain.

        * kjs/InternalFunction.cpp:
        (JSC::InternalFunction::InternalFunction): Take a JSGlobalData*
        instead of an ExecState*. Later we can change more places to
        work this way -- it's more efficient to take the type you need
        since the caller might already have it.
        * kjs/InternalFunction.h: Ditto.

        * kjs/JSCell.h:
        (JSC::JSCell::operator new): Added an overload that takes a
        JSGlobalData* so you can construct without an ExecState*.

        * kjs/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::init): Moved creation of the global scope
        chain in here, since it now requires a pointer to the global data.
        Moved the initialization of the call frame in here since it requires
        the global scope chain node. Removed the extra argument to ExecState
        when creating the global ExecState*.
        * kjs/JSGlobalObject.h: Removed initialization of globalScopeChain
        and the call frame from the JSGlobalObjectData constructor. Added
        a thisValue argument to the init function.

        * kjs/JSNumberCell.cpp: Added versions of jsNumberCell that take
        JSGlobalData* rather than ExecState*.
        * kjs/JSNumberCell.h:
        (JSC::JSNumberCell::operator new): Added a version that takes
        JSGlobalData*.
        (JSC::JSNumberCell::JSNumberCell): Ditto.
        (JSC::jsNumber): Ditto.
        * kjs/JSString.cpp:
        (JSC::jsString): Ditto.
        (JSC::jsSubstring): Ditto.
        (JSC::jsOwnedString): Ditto.
        * kjs/JSString.h:
        (JSC::JSString::JSString): Changed to take JSGlobalData*.
        (JSC::jsEmptyString): Added a version that takes JSGlobalData*.
        (JSC::jsSingleCharacterString): Ditto.
        (JSC::jsSingleCharacterSubstring): Ditto.
        (JSC::jsNontrivialString): Ditto.
        (JSC::JSString::getIndex): Ditto.
        (JSC::jsString): Ditto.
        (JSC::jsSubstring): Ditto.
        (JSC::jsOwnedString): Ditto.

        * kjs/ScopeChain.h: Added a globalData pointer to each node.
        (JSC::ScopeChainNode::ScopeChainNode): Initialize the globalData
        pointer.
        (JSC::ScopeChainNode::push): Set the global data pointer in the
        new node.
        (JSC::ScopeChain::ScopeChain): Take a globalData argument.

        * kjs/SmallStrings.cpp:
        (JSC::SmallStrings::createEmptyString): Take JSGlobalData* instead of
        ExecState*.
        (JSC::SmallStrings::createSingleCharacterString): Ditto.
        * kjs/SmallStrings.h:
        (JSC::SmallStrings::emptyString): Ditto.
        (JSC::SmallStrings::singleCharacterString): Ditto.

WebCore:

2008-10-03  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        - next step of https://bugs.webkit.org/show_bug.cgi?id=21295
          Turn ExecState into a call frame pointer.

        Remove m_globalObject and m_globalData from ExecState.

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
        Removed an argument now that JSGlobalObject doesn't need it any more.
        (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed the argument from
        the JSDOMWindowBaseData constructor, and added the this argument to the
        JSGlobalObject constructor. This is because a couple key bits of
        initialization moved from the data constructor to the JSGlobalObject
        constructor.
        * bindings/js/JSDOMWindowBase.h: Ditto.

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
        * bridge/runtime_method.cpp:
        (JSC::RuntimeMethod::RuntimeMethod):
        Pass JSGlobalData* instead of ExecState* to the InternalFunction
        constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 3 Oct 2008 21:34:54 +0000 (21:34 +0000)]
2008-10-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        Testcase for "white-space: -webkit-nowrap" only being converted to
        "white-space: nowrap" on <td> and <th> now, not any element with a table-cell
        dispay type.

        See https://bugs.webkit.org/show_bug.cgi?id=21287#c3

        * fast/table/td-display-nowrap-expected.txt: Added.
        * fast/table/td-display-nowrap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 3 Oct 2008 21:34:43 +0000 (21:34 +0000)]
2008-10-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by David Hyatt.

        More plug-in stream cleanup.

        * Plugins/WebBaseNetscapePluginStream.h:
        (WebNetscapePluginStream::create):
        (WebNetscapePluginStream::WebNetscapePluginStream):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (-[WebBaseNetscapePluginStream initWithFrameLoader:]):
        (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
        (-[WebBaseNetscapePluginStream dealloc]):
        (-[WebBaseNetscapePluginStream finalize]):
        (-[WebBaseNetscapePluginStream setPlugin:]):
        (WebNetscapePluginStream::setPlugin):
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
        (-[WebBaseNetscapePluginStream _destroyStream]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 3 Oct 2008 21:16:13 +0000 (21:16 +0000)]
2008-10-03  David Hyatt  <hyatt@apple.com>

        Fix Windows/Qt build bustage.

        Reviewed by ggaren

        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::platformWindow):
        * page/Chrome.cpp:
        (WebCore::Chrome::platformWindow):
        * page/Chrome.h:
        * page/ChromeClient.h:
        * platform/HostWindow.h:
        * platform/qt/PlatformScreenQt.cpp:
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::screenRect):
        (WebCore::screenAvailableRect):
        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::show):
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::calculatePositionAndSize):
        (WebCore::PopupWndProc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Cameron Zwarich <zwarich@apple.com>
cwzwarich@webkit.org [Fri, 3 Oct 2008 20:56:50 +0000 (20:56 +0000)]
2008-10-03  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Geoff Garen.

        Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
        <https://bugs.webkit.org/show_bug.cgi?id=21343>

        Add a workaround for a bug in GCC, which affects GCC 4.0, GCC 4.2, and
        llvm-gcc 4.2. I put it in an #ifdef because it was a slight regression
        on SunSpider in 32-bit, although that might be entirely random.

        * kjs/Arguments.cpp:
        (JSC::Arguments::getOwnPropertySlot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 3 Oct 2008 20:20:01 +0000 (20:20 +0000)]
2008-10-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        Make setStyle() take a const RenderStyle, to ensure that an
        earlier RenderStyle::diff() remains valid.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 3 Oct 2008 20:10:32 +0000 (20:10 +0000)]
2008-10-03  David Hyatt  <hyatt@apple.com>

        Preparation for enabling scrollbars to hit test properly inside transforms.  Clean up the scrollbar
        event handlers to no longer be virtual.  Don't pass a mouse event where none is needed.  Add a new
        method on Scrollbars called transformEvent that will apply all of the transforms to make a new event
        that will work properly for hit testing.  This patch just stubs out that method to return the same
        event untransformed.

        Reviewed by Darin Adler

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDoubleClickEvent):
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::EventHandler::handleMouseReleaseEvent):
        (WebCore::EventHandler::passMousePressEventToScrollbar):
        * page/gtk/EventHandlerGtk.cpp:
        * page/mac/EventHandlerMac.mm:
        * page/qt/EventHandlerQt.cpp:
        * page/win/EventHandlerWin.cpp:
        * page/wx/EventHandlerWx.cpp:
        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::mouseMoved):
        (WebCore::Scrollbar::mouseExited):
        (WebCore::Scrollbar::mouseUp):
        (WebCore::Scrollbar::mouseDown):
        (WebCore::Scrollbar::transformEvent):
        * platform/Scrollbar.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 3 Oct 2008 20:00:46 +0000 (20:00 +0000)]
2008-10-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyat

        Clean up code that changes the RenderStyle passed in to
        table renderer setStyle() methods.

        https://bugs.webkit.org/show_bug.cgi?id=21287

        * fast/table/floating-th.html: Added.
        * fast/table/table-display-types-strict.html: Added.
        * fast/table/table-display-types.html: Added.
        * platform/mac/fast/table/floating-th-expected.txt: Added.
        * platform/mac/fast/table/table-display-types-expected.txt: Added.
        * platform/mac/fast/table/table-display-types-strict-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Fri, 3 Oct 2008 19:17:35 +0000 (19:17 +0000)]
WebCore:

2008-10-03  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21340

        Remove "containingWindow()/setContainingWindow()" from Widget.  HostWindow covers this now.

        Reviewed by Dan Bernstein & Darin Adler

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::addChild):
        * platform/Widget.cpp:
        (WebCore::Widget::init):
        * platform/Widget.h:
        * platform/mac/WidgetMac.mm:
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::show):

WebKit/gtk:

2008-10-03  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21340

        Remove "containingWindow()/setContainingWindow()" from Widget.  HostWindow covers this now.

        Reviewed by Dan Bernstein & Darin Adler

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

WebKit/win:

2008-10-03  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21340

        Remove "containingWindow()/setContainingWindow()" from Widget.  HostWindow covers this now.

        Reviewed by Dan Bernstein & Darin Adler

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::transitionToCommittedForNewPage):
        * WebScrollBar.cpp:
        (WebScrollBar::WebScrollBar):
        (WebScrollBar::init):
        (WebScrollBar::invalidateScrollbarRect):
        * WebScrollBar.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 3 Oct 2008 19:06:28 +0000 (19:06 +0000)]
2008-10-03  Adele Peterson  <adele@apple.com>

        Reviewed by Sam Weinig.

        * css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily):
        Return early if settings is nil.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
rwlbuis@webkit.org [Fri, 3 Oct 2008 19:00:22 +0000 (19:00 +0000)]
    Reviewed by Darin.

        https://bugs.webkit.org/show_bug.cgi?id=20134
        REGRESSION (2.0.4-3.0.4): No default value set for <input type=range> with an even difference of (max - min)

        Make sure the input element gets the right default value when no value is set.

        Test: fast/forms/range-default-value.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 3 Oct 2008 18:50:22 +0000 (18:50 +0000)]
2008-10-03  David Hyatt  <hyatt@apple.com>

        Fix scroll method on Qt.  The delta was supposed to use .width()/.height() and not .x()/.y().

        Fix the QtPluginWidget to do an invalidate properly.

        Reviewed by ggaren

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::scroll):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove commented out method.
hyatt@apple.com [Fri, 3 Oct 2008 18:42:33 +0000 (18:42 +0000)]
Remove commented out method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 3 Oct 2008 18:29:28 +0000 (18:29 +0000)]
2008-10-03  David Hyatt  <hyatt@apple.com>

        Instead of a cross-platform init/destroy that forces every ScrollView platform to have a constructor/
        destructor that calls them, switch to having a cross-platform constructor/destructor that calls
        platform-specific init/destroy methods.

        With this change, ScrollViewWin.cpp can be removed from the build (yay!).

        Reviewed by Darin Adler

        * WebCore.vcproj/WebCore.vcproj:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::ScrollView):
        (WebCore::ScrollView::~ScrollView):
        (WebCore::ScrollView::platformInit):
        (WebCore::ScrollView::platformDestroy):
        (WebCore::ScrollView::platformAddChild):
        (WebCore::ScrollView::platformRemoveChild):
        * platform/ScrollView.h:
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::platformInit):
        (WebCore::ScrollView::platformDestroy):
        * platform/mac/ScrollViewMac.mm:
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::platformInit):
        (WebCore::ScrollView::platformDestroy):
        * platform/win/ScrollViewWin.cpp: Removed.
        * platform/wx/ScrollViewWx.cpp:
        (WebCore::ScrollView::platformInit):
        (WebCore::ScrollView::platformDestroy):
        (WebCore::ScrollView::setPlatformWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 3 Oct 2008 18:13:28 +0000 (18:13 +0000)]
2008-10-03  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/6012018>
        https://bugs.webkit.org/show_bug.cgi?id=21335
        CrashTracer: [USER] 4959 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 8

        * css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Return early if the frame is nil.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 3 Oct 2008 17:27:37 +0000 (17:27 +0000)]
2008-10-03  Darin Adler  <darin@apple.com>

        Rubber stamped by Alexey Proskuryakov.

        * kjs/Shell.cpp: (main): Don't delete JSGlobalData. Later, we need to change
        this tool to use public JavaScriptCore API instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Ariya Hidayat <ariya.hidayat@trolltech.com>
vestbo@webkit.org [Fri, 3 Oct 2008 17:01:31 +0000 (17:01 +0000)]
2008-10-03  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Build fix. Remove addToDirtyRegion from the header file.

        * WebCoreSupport/ChromeClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 3 Oct 2008 16:09:37 +0000 (16:09 +0000)]
2008-10-03  Darin Adler  <darin@apple.com>

        Suggested by Alexey Proskuryakov.

        * kjs/JSGlobalData.cpp:
        (JSC::JSGlobalData::~JSGlobalData): Remove call to heap.destroy() because
        it's too late to ref the JSGlobalData object once it's already being
        destroyed. In practice this is not a problem because WebCore's JSGlobalData
        is never destroyed and JSGlobalContextRelease takes care of calling
        heap.destroy() in advance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 3 Oct 2008 16:02:54 +0000 (16:02 +0000)]
2008-10-03  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Build fix.

        * platform/qt/WidgetQt.cpp:
        (WebCore::Widget::invalidateRect):

2008-10-03  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Build fix.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::scroll):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::):
        (WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Fri, 3 Oct 2008 13:36:23 +0000 (13:36 +0000)]
2008-10-03  Alp Toker  <alp@nuanti.com>

        Remove some left-over GTK+ includes. No change in functionality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Fri, 3 Oct 2008 12:59:50 +0000 (12:59 +0000)]
2008-10-03  Alp Toker  <alp@nuanti.com>

        Build fix following r37234. Remove addToDirtyRegion from the header
        too.

        * WebCoreSupport/ChromeClientGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Fri, 3 Oct 2008 12:38:12 +0000 (12:38 +0000)]
2008-10-03  Alp Toker  <alp@nuanti.com>

        Build fix for trailing comment after #endif

        * dom/ElementRareData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReplace SSE3 check with an SSE2 check, and implement SSE2 check on windows.
oliver@apple.com [Fri, 3 Oct 2008 11:11:55 +0000 (11:11 +0000)]
Replace SSE3 check with an SSE2 check, and implement SSE2 check on windows.

Reviewed by Maciej Stachowiak

5.6% win on SunSpider on windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
hyatt@apple.com [Fri, 3 Oct 2008 09:03:43 +0000 (09:03 +0000)]
WebCore:

2008-10-03  David Hyatt  <hyatt@apple.com>

        Remove addToDirtyRegion.

        Reviewed by Oliver Hunt

        * page/Chrome.cpp:
        * page/Chrome.h:
        * page/ChromeClient.h:
        * platform/ScrollView.h:
        * platform/gtk/ScrollViewGtk.cpp:
        * platform/qt/ScrollViewQt.cpp:
        * platform/win/ScrollViewWin.cpp:

WebKit/gtk:

2008-10-03  David Hyatt  <hyatt@apple.com>

         Remove addToDirtyRegion.

        Reviewed by Oliver Hunt

        * WebCoreSupport/ChromeClientGtk.cpp:

WebKit/mac:

2008-10-03  David Hyatt  <hyatt@apple.com>

        Remove addToDirtyRegion.

        Reviewed by Oliver Hunt

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:

WebKit/qt:

2008-10-03  David Hyatt  <hyatt@apple.com>

        Remove addToDirtyRegion.

        Reviewed by Oliver Hunt

        * WebCoreSupport/ChromeClientQt.cpp:

WebKit/win:

2008-10-03  David Hyatt  <hyatt@apple.com>

         Remove addToDirtyRegion.

         Reviewed by Oliver Hunt

        * WebCoreSupport/WebChromeClient.cpp:

WebKit/wx:

2008-10-03  David Hyatt  <hyatt@apple.com>

         Remove addToDirtyRegion.

         Reviewed by Oliver Hunt

        * WebKitSupport/ChromeClientWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej Stachowiak.
mitz@apple.com [Fri, 3 Oct 2008 09:00:08 +0000 (09:00 +0000)]
    Reviewed by Maciej Stachowiak.

        - fix a CachedResource leak introduced in r37176

        Undo r37176 and instead allow pruneDeadResources() to be re-entered, but
        afterwards bail out of the outer pruneDeadResources().

        * loader/Cache.cpp:
        (WebCore::Cache::Cache):
        (WebCore::Cache::pruneDeadResources):
        (WebCore::Cache::remove):
        * loader/Cache.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 3 Oct 2008 08:50:33 +0000 (08:50 +0000)]
2008-10-03  David Hyatt  <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=21330

        Fix Gtk adjustments so that they are properly checked again before creating horizontal/vertical
        scrollbars.

        Reviewed by Oliver Hunt

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::setHasHorizontalScrollbar):
        (WebCore::ScrollView::setHasVerticalScrollbar):
        (WebCore::ScrollView::platformHasHorizontalAdjustment):
        (WebCore::ScrollView::platformHasVerticalAdjustment):
        * platform/ScrollView.h:
        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::adjustmentChanged):
        (WebCore::ScrollView::ScrollView):
        (WebCore::ScrollView::~ScrollView):
        (WebCore::ScrollView::setGtkAdjustments):
        (WebCore::ScrollView::platformHandleHorizontalAdjustment):
        (WebCore::ScrollView::platformHandleVerticalAdjustment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Fri, 3 Oct 2008 08:15:36 +0000 (08:15 +0000)]
2008-10-03  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Maciej Stachowiak.

        Bug 21106: .in format discussed changes
        https://bugs.webkit.org/show_bug.cgi?id=21106

        Change "upperCase" to "interfaceName" per-tag parameter as
        discussed on the mailing list. Removed the per-attribute version
        as it was not used.

        Also add the "Element" suffix to all interfaceName parameter to match
        the class name (and thus remove it from make_names.pl).

        * dom/make_names.pl:
        * html/HTMLTagNames.in:
        * svg/svgtags.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother speculative Gtk scrolling fix.
hyatt@apple.com [Fri, 3 Oct 2008 07:52:53 +0000 (07:52 +0000)]
Another speculative Gtk scrolling fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother speculative Gtk scrolling fix.
hyatt@apple.com [Fri, 3 Oct 2008 07:52:38 +0000 (07:52 +0000)]
Another speculative Gtk scrolling fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAnother speculative Gtk scrolling fix.
hyatt@apple.com [Fri, 3 Oct 2008 07:51:08 +0000 (07:51 +0000)]
Another speculative Gtk scrolling fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-10-03 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 3 Oct 2008 07:47:19 +0000 (07:47 +0000)]
2008-10-03  Maciej Stachowiak  <mjs@apple.com>

        Rubber stamped by Cameron Zwarich.

        - fix mistaken change of | to || which caused a big perf regression on EarleyBoyer

        * kjs/grammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Qt bustage.
hyatt@apple.com [Fri, 3 Oct 2008 07:44:49 +0000 (07:44 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37226 268f45cc-cd09-0410-ab3c-d52691b4dbfc