WebKit-https.git
9 years agoFix the build.
mrowe@apple.com [Thu, 22 Mar 2012 01:13:56 +0000 (01:13 +0000)]
Fix the build.

Source/JavaScriptCore:

* wtf/MetaAllocator.h:
(MetaAllocator): Export the destructor.

Tools:

Ensure that our test tools don't try and use RTTI unnecessarily.

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test_expectations update for chromium.
eae@chromium.org [Thu, 22 Mar 2012 01:11:44 +0000 (01:11 +0000)]
Unreviewed test_expectations update for chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBDI element should have dir=auto by default
rniwa@webkit.org [Thu, 22 Mar 2012 01:08:22 +0000 (01:08 +0000)]
BDI element should have dir=auto by default
https://bugs.webkit.org/show_bug.cgi?id=68773

Reviewed by Daniel Bates.

Source/WebCore:

Treat bdi elements without dir content attribute as if they have dir=auto per spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/text-level-semantics.html#the-bdi-element

The patch tries to encapsulate the logic to look for dir content attribute and dir=auto.

It also adds HTMLBDIElement interface (binding remains to use HTMLElement) to set
selfOrAncestorHasDirAutoAttribute flag true by default, which is used by functions like
directionalityIfhasDirAutoAttribute to look for elements with dir=auto. Since dir=auto-ness of bdi
elements can be overridden by dir content attribute, we must change and only change the default value.

Tests: fast/text/international/bdi-dir-default-to-auto-expected.html
       fast/text/international/bdi-dir-default-to-auto.html

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* html/HTMLBDIElement.h: Added.
(WebCore):
(HTMLBDIElement):
(WebCore::HTMLBDIElement::create):
(WebCore::HTMLBDIElement::HTMLBDIElement): Sets selfOrAncestorHasDirAutoAttribute to true because
bdi elements are treated as if it has dir=auto by default.
* html/HTMLElement.cpp:
(WebCore::elementAffectsDirectionality): Added. Checks if the specified element is bdi or
has dir content attribute.
(WebCore):
(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::hasDirectionAuto): Added. Checks if the specified element should be treated
as if it has dir=auto (bdi or element with dir=auto).
(WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
* html/HTMLElement.h:
(HTMLElement):
* html/HTMLTagNames.in: Use HTMLBDIElement instead of HTMLElement for constructing bdi element
to set selfOrAncestorHasDirAutoAttribute true but still use HTMLElement for binding.

LayoutTests:

Add a test written by Aharon Lanin.

* fast/text/international/bdi-dir-default-to-auto-expected.html: Added.
* fast/text/international/bdi-dir-default-to-auto.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse CSSPrimitiveValue::convertToLength() in a few places.
macpherson@chromium.org [Thu, 22 Mar 2012 00:58:36 +0000 (00:58 +0000)]
Use CSSPrimitiveValue::convertToLength() in a few places.
https://bugs.webkit.org/show_bug.cgi?id=81492

Reviewed by Eric Seidel.

No new tests - refactoring only.

CSSPrimitiveValue::convertToLength() provides the same functionality that is duplicated
in many places in CSSStyleSelector. This patch removes some of that code duplication.

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyVerticalAlign::applyValue):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttp/tests/media/video-useragent.html should be skipped on Mac
eric.carlson@apple.com [Thu, 22 Mar 2012 00:37:46 +0000 (00:37 +0000)]
http/tests/media/video-useragent.html should be skipped on Mac
https://bugs.webkit.org/show_bug.cgi?id=81832

Reviewed by Dean Jackson.

* platform/mac/Skipped: Move video-useragent.html from the block skipped for
    https://bugs.webkit.org/show_bug.cgi?id=81604 to its own entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for ENABLE(SVG) && !ENABLE(FILTERS) after r111601.
paroga@webkit.org [Thu, 22 Mar 2012 00:31:03 +0000 (00:31 +0000)]
Build fix for ENABLE(SVG) && !ENABLE(FILTERS) after r111601.

* rendering/svg/RenderSVGRoot.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for !ENABLE(INSPECTOR) after r104831.
paroga@webkit.org [Thu, 22 Mar 2012 00:25:48 +0000 (00:25 +0000)]
Build fix for !ENABLE(INSPECTOR) after r104831.

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agovisual word movement: using cache to decrease the number of collectLeafBoxesInLogical...
xji@chromium.org [Thu, 22 Mar 2012 00:20:43 +0000 (00:20 +0000)]
visual word movement: using cache to decrease the number of collectLeafBoxesInLogicalOrder on RootInlineBox
https://bugs.webkit.org/show_bug.cgi?id=81408

Reviewed by Ryosuke Niwa.

Source/WebCore:

Cache logically ordered leaf boxes under a particular root box.
Also, move 'Vector<UChar, 1024> string' declared in visualWordPosition() to outside of loop (it is always
clear-ed before use).

* editing/visible_units.cpp:
(CachedLogicallyOrderedLeafBoxes): Add class to cache logically ordered leaf boxes under a particular root box.
(WebCore::CachedLogicallyOrderedLeafBoxes::size):
(WebCore::CachedLogicallyOrderedLeafBoxes::firstBox):
(WebCore):
(WebCore::CachedLogicallyOrderedLeafBoxes::CachedLogicallyOrderedLeafBoxes):
(WebCore::CachedLogicallyOrderedLeafBoxes::previousTextBox):
(WebCore::CachedLogicallyOrderedLeafBoxes::nextTextBox):
(WebCore::CachedLogicallyOrderedLeafBoxes::collectBoxes):
(WebCore::CachedLogicallyOrderedLeafBoxes::boxIndexInLeaves):
(WebCore::logicallyPreviousBox): Pass CachedLogicallyOrderedLeafBoxes object around.
(WebCore::logicallyNextBox):
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):
(WebCore::visualWordPosition):

LayoutTests:

* editing/selection/move-by-word-visually-single-space-one-element-expected.txt:
* editing/selection/move-by-word-visually-single-space-one-element.html:
  Add a test case that a word is spreading across multiple inline boxes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit should have some scripts to smooth interactions with GitHub
abarth@webkit.org [Thu, 22 Mar 2012 00:20:38 +0000 (00:20 +0000)]
WebKit should have some scripts to smooth interactions with GitHub
https://bugs.webkit.org/show_bug.cgi?id=81842

Reviewed by Eric Seidel.

These scripts support the workflow in
https://trac.webkit.org/wiki/UsingGitHub by automating the
configuration and syncing operations needed for a GitHub fork of WebKit
to track the main WebKit repository.

* Scripts/configure-github-as-upstream: Added.
* Scripts/sync-master-with-upstream: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unreviewed gardening; skip a few tests which are not really being rendered...
kubo@profusion.mobi [Thu, 22 Mar 2012 00:05:25 +0000 (00:05 +0000)]
[EFL] Unreviewed gardening; skip a few tests which are not really being rendered correctly.

* platform/efl/Skipped:
* platform/efl/fast/css/color-correction-on-background-image-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-background-image-expected.txt: Removed.
* platform/efl/fast/css/color-correction-on-backgrounds-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
* platform/efl/fast/css/color-correction-on-box-shadow-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
* platform/efl/fast/css/color-correction-on-text-shadow-expected.png: Removed.
* platform/efl/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
* platform/efl/fast/css/color-correction-untagged-images-expected.png: Removed.
* platform/efl/fast/css/color-correction-untagged-images-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed css3/filters/custom rebaseline for chromium.
eae@chromium.org [Thu, 22 Mar 2012 00:04:19 +0000 (00:04 +0000)]
Unreviewed css3/filters/custom rebaseline for chromium.

* platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.txt: Removed.
* platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.txt: Removed.
* platform/chromium-linux/css3/filters/custom/effect-custom-expected.txt: Removed.
* platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.txt: Removed.
* platform/chromium-linux/css3/filters/custom/missing-custom-filter-shader-expected.txt: Removed.
* platform/chromium-mac-leopard/css3/filters/custom: Added.
* platform/chromium-mac-leopard/css3/filters/custom/custom-filter-shader-cache-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/custom/effect-custom-combined-missing-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/custom/effect-custom-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/custom/effect-custom-parameters-expected.png: Added.
* platform/chromium-mac-leopard/css3/filters/custom/missing-custom-filter-shader-expected.png: Added.
* platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.txt: Removed.
* platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.txt: Removed.
* platform/chromium-mac/css3/filters/custom/effect-custom-expected.txt: Removed.
* platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.txt: Removed.
* platform/chromium-mac/css3/filters/custom/missing-custom-filter-shader-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWTR - log the pid of a crashing WebProcess
dpranke@chromium.org [Wed, 21 Mar 2012 23:29:29 +0000 (23:29 +0000)]
WTR - log the pid of a crashing WebProcess
https://bugs.webkit.org/show_bug.cgi?id=81575

Reviewed by Alexey Proskuryakov.

This allows run-webkit-tests to find the right crash log for a
given crashed WebProcess in WebKit2.

* WebKitTestRunner/TestController.cpp:
(WTR::exceededDatabaseQuota):
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::runTest):
(WTR::TestController::processDidCrash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix remaining WTF includes in JavaScriptCore in preparation for moving WTF headers...
eric@webkit.org [Wed, 21 Mar 2012 23:18:20 +0000 (23:18 +0000)]
Fix remaining WTF includes in JavaScriptCore in preparation for moving WTF headers out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=81834

Reviewed by Adam Barth.

* jsc.cpp:
* os-win32/WinMain.cpp:
* runtime/JSDateMath.cpp:
* runtime/TimeoutChecker.cpp:
* testRegExp.cpp:
* tools/CodeProfiling.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWTF::MetaAllocator has a weak vtable (discovered when building wtf as a static library)
eric@webkit.org [Wed, 21 Mar 2012 23:16:40 +0000 (23:16 +0000)]
WTF::MetaAllocator has a weak vtable (discovered when building wtf as a static library)
https://bugs.webkit.org/show_bug.cgi?id=81838

Reviewed by Geoffrey Garen.

My understanding is that weak vtables happen when the compiler/linker cannot
determine which compilation unit should constain the vtable.  In this case
because there were only pure virtual functions as well as an "inline"
virtual destructor (thus the virtual destructor was defined in many compilation
units).  Since you can't actually "inline" a virtual function (it still has to
bounce through the vtable), the "inline" on this virutal destructor doesn't
actually help performance, and is only serving to confuse the compiler here.
I've moved the destructor implementation to the .cpp file, thus making
it clear to the compiler where the vtable should be stored, and solving the error.

* wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::~MetaAllocator):
(WTF):
* wtf/MetaAllocator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Early out in a new prepareToDraw() step if checkerboarding an accelerated...
commit-queue@webkit.org [Wed, 21 Mar 2012 22:59:36 +0000 (22:59 +0000)]
[chromium] Early out in a new prepareToDraw() step if checkerboarding an accelerated animation in order to skip the frame
https://bugs.webkit.org/show_bug.cgi?id=81437

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-21
Reviewed by Adrienne Walker.

Source/WebCore:

Split CCLayerTreeHostImpl::drawLayers() into two phases:
prepareToDraw() and drawLayers().

When calculating a RenderPass, and we checkerboard a quad on a
layer, bubble this info back up to CCLayerTreeHostImpl. If the
layer is transforming in an animation, then abort the prepareToDraw()
phase and cause it to return false back to the thread proxy.

Unit test: CCLayerTreeHostImplTest.prepareToDrawFailsWhenAnimationUsesCheckerboard

* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore):
(WebCore::CCLayerTreeHostImpl::drawLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
(FrameData):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::append):
* platform/graphics/chromium/cc/CCQuadCuller.h:
(CCQuadCuller):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
* platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
(WebCore::CCSolidColorLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
(WebCore::CCTextureLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCTextureLayerImpl.h:
(CCTextureLayerImpl):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):

Source/WebKit/chromium:

* tests/CCAnimationTestCommon.cpp:
(WebCore):
(WebCore::addAnimatedTransform):
(WebKitTests::addOpacityTransitionToLayer):
(WebKitTests):
(WebKitTests::addAnimatedTransformToLayer):
* tests/CCAnimationTestCommon.h:
(WebCore):
(WebKitTests):
* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
(DidDrawCheckLayer):
(WebKitTests::DidDrawCheckLayer::DidDrawCheckLayer):
(MissingTextureAnimatingLayer):
(WebKitTests::MissingTextureAnimatingLayer::create):
(WebKitTests::MissingTextureAnimatingLayer::MissingTextureAnimatingLayer):
(WebKitTests):
(WebKitTests::BlendStateCheckLayer::appendQuads):
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::prepareToDrawOnCCThread):
(WTF::MockLayerTreeHostImpl::prepareToDraw):
(MockLayerTreeHostImpl):
(WTF::MockLayerTreeHostImpl::drawLayers):
* tests/CCQuadCullerTest.cpp:
(WebCore::appendQuads):
* tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
* tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
* tests/MockCCQuadCuller.h:
(WebCore::MockCCQuadCuller::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
dpranke@chromium.org [Wed, 21 Mar 2012 22:59:09 +0000 (22:59 +0000)]
WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
https://bugs.webkit.org/show_bug.cgi?id=81835
<rdar://problem/11082749>

Patch by Enrica Casucci <enrica@apple.com> on 2012-03-21
Reviewed by Brady Eidson.

* TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
* TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
(TestWebKitAPI::contextMenuCopyLink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
enrica@apple.com [Wed, 21 Mar 2012 22:46:49 +0000 (22:46 +0000)]
WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
https://bugs.webkit.org/show_bug.cgi?id=81835
<rdar://problem/11082749>

Reviewed by Brady Eidson.

Source/WebCore:

When writing the URL in the pasteboard for the WebURLWithTitles format,
we use the user visible string instead of the original URL.
In case of URL with Unicode characters, we lose the encoding.

Added TestWebKitAPI test.

* platform/mac/PasteboardMac.mm:
(WebCore::writeURLForTypes): Writes to the pasteboard the original URL.

Tools:

* TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
* TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
(TestWebKitAPI::contextMenuCopyLink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect LayoutUnit usage in VisiblePosition.cpp
leviw@chromium.org [Wed, 21 Mar 2012 22:42:25 +0000 (22:42 +0000)]
Correct LayoutUnit usage in VisiblePosition.cpp
https://bugs.webkit.org/show_bug.cgi?id=81775

Reviewed by Eric Seidel.

Correcting a mismatch between the .h and .cpp for the definition of localCaretRect,
and properly using LayoutUnits for local coordinates.

No new tests. No change in behavior.

* editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::localCaretRect): Switching to return a LayoutRect, as in the
header. Local coordinates are in LayoutUnits.
(WebCore::VisiblePosition::absoluteCaretBounds): Using LayoutRect for the localCaretRect.
(WebCore::VisiblePosition::lineDirectionPointForBlockDirectionNavigation): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Remove for chromium-mac-snowleopard and qt specific expected
eae@chromium.org [Wed, 21 Mar 2012 22:39:11 +0000 (22:39 +0000)]
Unreviewed. Remove for chromium-mac-snowleopard and qt specific expected
results made obsolete by r111601.

* platform/chromium-mac-snowleopard/svg/custom/delete-text-crash-expected.txt: Removed.
* platform/qt/svg/custom/delete-text-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago"this" argument for MutationCallbacks should be the MutationObserver
adamk@chromium.org [Wed, 21 Mar 2012 22:34:29 +0000 (22:34 +0000)]
"this" argument for MutationCallbacks should be the MutationObserver
https://bugs.webkit.org/show_bug.cgi?id=81712

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/mutation/callback-arguments.html

* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback): Add an overload that takes
an explicit this argument and have the old method call the new one.
* bindings/js/JSCallbackData.h:
(JSCallbackData):
* bindings/js/JSMutationCallbackCustom.cpp:
(WebCore::JSMutationCallback::handleEvent): Call the new overload.
* bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback): Add an overload that takes an explicit this
argument and have the old method call the new one.
* bindings/v8/custom/V8CustomVoidCallback.h:
(WebCore):
* bindings/v8/custom/V8MutationCallbackCustom.cpp:
(WebCore::V8MutationCallback::handleEvent): Call the new overload.

LayoutTests:

Merged new test with existing second-argument test.

* fast/mutation/callback-arguments-expected.txt: Added.
* fast/mutation/callback-arguments.html: Added.
* fast/mutation/callback-second-argument-expected.txt: Removed.
* fast/mutation/callback-second-argument.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Shaders] Make CSS Shaders compile on Chromium
achicu@adobe.com [Wed, 21 Mar 2012 22:28:53 +0000 (22:28 +0000)]
[CSS Shaders] Make CSS Shaders compile on Chromium
https://bugs.webkit.org/show_bug.cgi?id=81435

Source/WebCore:

Reviewed by Stephen White.

This patch enables the CSS Shaders compile time flag, but keeps the runtime flag disabled.
The only way to test the functionality now is to use the overridePreference from dump render tree.

Also part of this patch I fix a layering violation: I removed the "Document" reference from the FECustomFilter.cpp and passed the
HostWindow directly. There should be no problem when the HostWindow changes, because the RenderLayer and the FECustomFilter
get recreated anyway.

No new tests. I've updated the existing custom filter tests to run under Chromium and added the expected results.
I've just added window.layoutTestController.overridePreference("WebKitCSSCustomFilterEnabled", "1") to force
enable the feature at runtime.

* loader/cache/CachedResource.cpp: Made CachedResource::ShaderResource report as ResourceRequest::TargetIsSubresource for Chromium.
(WebCore::cachedResourceTypeToTargetType):

* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter): Removed Document and just used the HostWindow directly.
(WebCore::FECustomFilter::create):
(WebCore::FECustomFilter::initializeContext):
(WebCore::FECustomFilter::bindVertexAttribute): There was a typo and instead of using the "size" parameter it always used 4 component attribute.
Other drivers didn't complain about it, but it was clearly a bug.
(WebCore::FECustomFilter::bindProgramAndBuffers): Reading the image back from GPU will flip vertically the framebuffer in Chromium. I've flipped the
projection matrix only on Chromium, so that we get the correct result.

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build): Passing the HostWindow instead of the Document.

Source/WebKit/chromium:

Reviewed by Stephen White.

I've added the ENABLE_CSS_SHADERS flag by default, but kept CSS Shaders disabled using the runtime flag.

This change adds a new public API to WebSettings with syntax void setExperimentalCSSCustomFilterEnabled(bool).

* features.gypi:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setExperimentalCSSCustomFilterEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

Tools:

Reviewed by Stephen White.

I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::overridePreference):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):

LayoutTests:

Reviewed by Stephen White.

I've added window.layoutTestController.overridePreference("WebKitCSSCustomFilterEnabled", "1") to force
enable the feature at runtime.

I've rebased the expected results for chromium. It seems like the result is a little bit lighter then the old ones.
Also, some tests are failing and seem to be related to differences between V8 and JSC: jsWrapperClass returns "Object" and
"Function", for "__proto__" and "constructor" properties of the CSSValueList objects.
I've let the results keep the "FAIL" status for those particular cases.

* css3/filters/custom/custom-filter-shader-cache.html:
* css3/filters/custom/effect-custom-combined-missing.html:
* css3/filters/custom/effect-custom-parameters.html:
* css3/filters/custom/effect-custom.html:
* css3/filters/custom/missing-custom-filter-shader.html:
* css3/filters/script-tests/custom-filter-property-computed-style.js:
* css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
* css3/filters/script-tests/custom-filter-property-parsing.js:
* platform/chromium-linux/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Added.
* platform/chromium-linux/css3/filters/custom/custom-filter-property-parsing-expected.txt: Added.
* platform/chromium-linux/css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt: Added.
* platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png: Added.
* platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.txt: Added.
* platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png: Added.
* platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.txt: Added.
* platform/chromium-linux/css3/filters/custom/effect-custom-disabled-expected.txt: Added.
* platform/chromium-linux/css3/filters/custom/effect-custom-expected.png: Added.
* platform/chromium-linux/css3/filters/custom/effect-custom-expected.txt: Added.
* platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png: Added.
* platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.txt: Added.
* platform/chromium-linux/css3/filters/custom/missing-custom-filter-shader-expected.png: Added.
* platform/chromium-linux/css3/filters/custom/missing-custom-filter-shader-expected.txt: Added.
* platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png: Added.
* platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.txt: Added.
* platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png: Added.
* platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.txt: Added.
* platform/chromium-mac/css3/filters/custom/effect-custom-expected.png: Added.
* platform/chromium-mac/css3/filters/custom/effect-custom-expected.txt: Added.
* platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png: Added.
* platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.txt: Added.
* platform/chromium-mac/css3/filters/custom/filter-repaint-shaders-expected.png: Added.
* platform/chromium-mac/css3/filters/custom/filter-repaint-shaders-expected.txt: Added.
* platform/chromium-mac/css3/filters/custom/missing-custom-filter-shader-expected.png: Added.
* platform/chromium-mac/css3/filters/custom/missing-custom-filter-shader-expected.txt: Added.
* platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Added.
* platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt: Added.
* platform/chromium/css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt: Added.
* platform/chromium/css3/filters/custom/effect-custom-disabled-expected.txt: Added.
* platform/chromium/test_expectations.txt: I've added Mac and Linux results, so skipping the tests only on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: clean up actually getting crash logs from DRT/WTR crashes
dpranke@chromium.org [Wed, 21 Mar 2012 22:24:36 +0000 (22:24 +0000)]
webkitpy: clean up actually getting crash logs from DRT/WTR crashes
https://bugs.webkit.org/show_bug.cgi?id=81603

Reviewed by Adam Barth.

Add a new _get_crash_log() overridable method on the Port
object to customize how we fetch crash logs per port.
Mac will now slow-spin with a timeout waiting for the crash log, rather
than waiting for the ReportCrash process to exit (it appears
that the mac will manage multiple crashes with a single
ReportCrash process, the process waits around longer than
necessary, presumably to avoid thrashing if processes are
repeatedly crashing).

Also, add the DriverOutput should contain the crash log and other info,
which is created in a port-specific manner but can then be
treated generically. Previously single_test_runner would get
told that something crashed and attempt to do something to get
the crash log, but it didn't have the information it needed to
od the right thing; better to make the driver hand back the
right info.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._handle_error):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
(TestResultWriter.write_crash_log):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.diff_text):
(Port._get_crash_log):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_crash_log):
* Scripts/webkitpy/layout_tests/port/driver.py:
(DriverOutput.__init__):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.is_lion):
(MacPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.run_test):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.__init__):
(WebKitDriver._start):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip some flaky tests on GTK.
philn@webkit.org [Wed, 21 Mar 2012 22:23:23 +0000 (22:23 +0000)]
Unreviewed, skip some flaky tests on GTK.

* platform/gtk/Skipped: Those media and inspector tests are
sometimes hitting ASSERTs on Debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK gardening after r111601.
philn@webkit.org [Wed, 21 Mar 2012 22:10:54 +0000 (22:10 +0000)]
Unreviewed, GTK gardening after r111601.

* platform/gtk/svg/custom/delete-text-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated Mac WebKit2 expected results for this test. <http://webkit.org/b/81833> track...
mitz@apple.com [Wed, 21 Mar 2012 22:07:07 +0000 (22:07 +0000)]
Updated Mac WebKit2 expected results for this test. <webkit.org/b/81833> tracks the
fact that it is failing in WebKit2.

* platform/mac-wk2/fast/events: Added.
* platform/mac-wk2/fast/events/drag-link-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRealphabetize about webaudio move
commit-queue@webkit.org [Wed, 21 Mar 2012 21:26:47 +0000 (21:26 +0000)]
Realphabetize about webaudio move
https://bugs.webkit.org/show_bug.cgi?id=81825

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-21
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEvict tiles from pages in background tabs
andersca@apple.com [Wed, 21 Mar 2012 21:05:22 +0000 (21:05 +0000)]
Evict tiles from pages in background tabs
https://bugs.webkit.org/show_bug.cgi?id=81829
<rdar://problem/10866152>

Reviewed by Andreas Kling.

When the tile cache for a page is no longer in a window (which happens when it's moved to
a background tab), schedule a tile revalidation after 4 seconds. This tile revalidation
will ensure that tiles outside of the visible rect will be dropped.

* platform/graphics/ca/mac/TileCache.h:
(TileCache):
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::tileCacheLayerBoundsChanged):
(WebCore::TileCache::setIsInWindow):
(WebCore::TileCache::tileCoverageRect):
(WebCore):
(WebCore::TileCache::scheduleTileRevalidation):
(WebCore::TileCache::revalidateTiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRegExpMatchesArray should not copy the ovector
barraclough@apple.com [Wed, 21 Mar 2012 20:55:41 +0000 (20:55 +0000)]
RegExpMatchesArray should not copy the ovector
https://bugs.webkit.org/show_bug.cgi?id=81742

Reviewed by Michael Saboff.

Currently, all RegExpMatchesArray object contain Vector<int, 32>, used to hold any sub-pattern results.
This makes allocation/construction/destruction of these objects more expensive. Instead, just store the
main match, and recreate the sub-pattern ranges only if necessary (these are often only used for grouping,
and the results never accessed).
If the main match (index 0) of the RegExpMatchesArray is accessed, reify that value alone.

* dfg/DFGOperations.cpp:
    - RegExpObject match renamed back to test (test returns a bool).
* runtime/RegExpConstructor.cpp:
(JSC):
    - Removed RegExpResult, RegExpMatchesArray constructor, destroy method.
(JSC::RegExpMatchesArray::finishCreation):
    - Removed RegExpConstructorPrivate parameter.
(JSC::RegExpMatchesArray::reifyAllProperties):
    - (Was fillArrayInstance) Reify all properties of the RegExpMatchesArray.
    If there are sub-pattern properties, the RegExp is re-run to generate their values.
(JSC::RegExpMatchesArray::reifyMatchProperty):
    - Reify just the match (index 0) property of the RegExpMatchesArray.
* runtime/RegExpConstructor.h:
(RegExpConstructor):
(JSC::RegExpConstructor::performMatch):
    - performMatch now returns a MatchResult, rather than using out-parameters.
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::RegExpMatchesArray):
    - Moved from .cpp, stores the input/regExp/result to use when lazily reifying properties.
(RegExpMatchesArray):
(JSC::RegExpMatchesArray::create):
    - Now passed the input string matched against, the RegExp, and the MatchResult.
(JSC::RegExpMatchesArray::reifyAllPropertiesIfNecessary):
(JSC::RegExpMatchesArray::reifyMatchPropertyIfNecessary):
    - Helpers to conditionally reify properties.
(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::putByIndex):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyNames):
(JSC::RegExpMatchesArray::defineOwnProperty):
    - Changed to use reifyAllPropertiesIfNecessary/reifyMatchPropertyIfNecessary
    (getOwnPropertySlotByIndex calls reifyMatchPropertyIfNecessary if index is 0).
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::exec):
(JSC::RegExpObject::match):
    - match now returns a MatchResult.
* runtime/RegExpObject.h:
(JSC::MatchResult::MatchResult):
    - Added the result of a match is a start & end tuple.
(JSC::MatchResult::failed):
    - A failure is indicated by (notFound, 0).
(JSC::MatchResult::operator bool):
    - Evaluates to false if the match failed.
(JSC::MatchResult::empty):
    - Evaluates to true if the match succeeded with length 0.
(JSC::RegExpObject::test):
    - Now returns a bool.
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncTest):
    - RegExpObject match renamed back to test (test returns a bool).
* runtime/StringPrototype.cpp:
(JSC::removeUsingRegExpSearch):
(JSC::replaceUsingRegExpSearch):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
    - performMatch now returns a MatchResult, rather than using out-parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVG layout leaves objects still needing layout
schenney@chromium.org [Wed, 21 Mar 2012 20:55:06 +0000 (20:55 +0000)]
SVG layout leaves objects still needing layout
https://bugs.webkit.org/show_bug.cgi?id=81006

Unreviewed expectations changes.

* platform/mac/Skipped: Removed skipped tests fixed by 81006
* platform/win/Skipped: Removed skipped tests fixed by 81006

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVG layout leaves objects still needing layout
schenney@chromium.org [Wed, 21 Mar 2012 20:49:40 +0000 (20:49 +0000)]
SVG layout leaves objects still needing layout
https://bugs.webkit.org/show_bug.cgi?id=81006

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Change the layout of SVG objects such that resources that trigger
layout of other objects are handled in a distinct pass, and then
objects still requiring layout are laid out again.

Test: svg/custom/delete-text-innerText-crash.html

* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::layout):
* rendering/svg/RenderSVGResourceMarker.cpp:
(WebCore::RenderSVGResourceMarker::layout):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::addResourceForClientInvalidation):
(WebCore):
* rendering/svg/RenderSVGRoot.h:
(RenderSVGRoot):

LayoutTests:

* svg/custom/delete-text-crash-expected.png: Removed.
* svg/custom/delete-text-crash-expected.txt:
* svg/custom/delete-text-crash.html:
* svg/custom/delete-text-innerText-crash-expected.txt: Added.
* svg/custom/delete-text-innerText-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake use of CG rounded-rect primitives
timothy_horton@apple.com [Wed, 21 Mar 2012 20:41:43 +0000 (20:41 +0000)]
Make use of CG rounded-rect primitives
https://bugs.webkit.org/show_bug.cgi?id=79932
<rdar://problem/9274953>

Reviewed by Simon Fraser.

Portions of patch by Nikolas Zimmermann and Mustafizur Rahaman.

Dispatch to potentially platform-specific rounded rectangle path
construction from addPathForRoundedRect. Make use of this to call
wkCGPathAddRoundedRect on Lion and above, as long as the rounded
corners are all equivalent.

The origin of the stroke dash differs between the bezier approach
and the path added by wkCGPathAddRoundedRect, so Path::addRoundedRect()
takes a new parameter allowing code which is sensitive to stroke dash
origin (i.e. SVG) to fall back to the old behavior if need be.

Make use of the new Path::addRoundedRect() parameter to fall back to
the old (bezier) rounded-rect behavior when constructing a dashed SVG path,
in order to continue complying with the spec.

No new tests, as this is covered by many that use rounded corners,
and is only a performance improvement.

* WebCore.exp.in:
* platform/graphics/Path.cpp:
(WebCore::Path::addRoundedRect):
(WebCore):
(WebCore::Path::addPathForRoundedRect):
* platform/graphics/Path.h:
(Path):
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::platformAddPathForRoundedRect):
(WebCore):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* rendering/svg/SVGPathData.cpp:
(WebCore::updatePathFromRectElement):

Add wkCGPathAddRoundedRect.

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Add wkCGPathAddRoundedRect.

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: get ServerProcess out of the reportcrash business
dpranke@chromium.org [Wed, 21 Mar 2012 20:29:02 +0000 (20:29 +0000)]
webkitpy: get ServerProcess out of the reportcrash business
https://bugs.webkit.org/show_bug.cgi?id=81600

Unreviewed, build fix.

Re-land r111307 and r111293 with another fix for a crash in NRWT;
we need to check if the driver has crashed before attempting to
read from it.

* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._reset):
(ServerProcess._handle_possible_interrupt):
(ServerProcess.write):
(ServerProcess.read_stdout):
(ServerProcess.has_crashed):
(ServerProcess._read):
(ServerProcess.stop):
* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TrivialMockPort.check_for_leaks):
(TestServerProcess.test_broken_pipe):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._read_image_diff):
(WebKitDriver.has_crashed):
(WebKitDriver._check_for_driver_crash):
(WebKitDriver.run_test):
(WebKitDriver._read_block):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(MockServerProcess.__init__):
(MockServerProcess):
(MockServerProcess.has_crashed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
commit-queue@webkit.org [Wed, 21 Mar 2012 20:24:11 +0000 (20:24 +0000)]
[EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
https://bugs.webkit.org/show_bug.cgi?id=81507

Now that we're only loading from one directory, no need to
iterate over a list of directories anymore.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-21
Reviewed by Martin Robinson.

* DumpRenderTree/efl/CMakeLists.txt:
* DumpRenderTree/efl/FontManagement.cpp:
(addFontDirectory):
(addFontsToEnvironment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query support.
commit-queue@webkit.org [Wed, 21 Mar 2012 20:08:49 +0000 (20:08 +0000)]
[Chromium] GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query support.
https://bugs.webkit.org/show_bug.cgi?id=80988

Patch by David Reveman <reveman@chromium.org> on 2012-03-21
Reviewed by Adrienne Walker.

Source/Platform:

Add EXT_occlusion_query API to WebGraphicsContext3D.

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::createQueryEXT):
(WebKit::WebGraphicsContext3D::deleteQueryEXT):
(WebKit::WebGraphicsContext3D::isQueryEXT):
(WebKit::WebGraphicsContext3D::beginQueryEXT):
(WebKit::WebGraphicsContext3D::endQueryEXT):
(WebKit::WebGraphicsContext3D::getQueryivEXT):
(WebKit::WebGraphicsContext3D::getQueryObjectuivEXT):

Source/WebCore:

Expose EXT_occlusion_query API to WebKit compositor. Add
GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query
enums.

* platform/graphics/chromium/Extensions3DChromium.h:
(Extensions3DChromium):

Source/WebKit/chromium:

Expose EXT_occlusion_query API to WebKit compositor.

* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):
* src/GraphicsContext3DChromium.cpp:
(WebCore):
* src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* tests/FakeWebGraphicsContext3D.h:
(WebKit::FakeWebGraphicsContext3D::createQueryEXT):
(WebKit::FakeWebGraphicsContext3D::deleteQueryEXT):
(WebKit::FakeWebGraphicsContext3D::isQueryEXT):
(WebKit::FakeWebGraphicsContext3D::beginQueryEXT):
(WebKit::FakeWebGraphicsContext3D::endQueryEXT):
(WebKit::FakeWebGraphicsContext3D::getQueryivEXT):
(WebKit::FakeWebGraphicsContext3D::getQueryObjectuivEXT):
(FakeWebGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocompute the sign of flexibility for new flexbox
tony@chromium.org [Wed, 21 Mar 2012 20:00:22 +0000 (20:00 +0000)]
compute the sign of flexibility for new flexbox
https://bugs.webkit.org/show_bug.cgi?id=81722

Reviewed by Ojan Vafai.

This implements the computation of the sign of flexibility used by the
new flexing algorithm.
http://dev.w3.org/csswg/css3-flexbox/#resolve-the-flexible-lengths

No new tests, we don't use the sign of flexibility yet.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeNextFlexLine): Compute the size
adjusted for min/max as well as not adjusted.
(WebCore::RenderFlexibleBox::resolveFlexibleLengths): Renamed to match
spec text better.
* rendering/RenderFlexibleBox.h: Added enum for flex sign.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Extract WebInspector.UIBreakpoint from WebInspector.Breakpoint.
vsevik@chromium.org [Wed, 21 Mar 2012 19:42:51 +0000 (19:42 +0000)]
Web Inspector: Extract WebInspector.UIBreakpoint from WebInspector.Breakpoint.
https://bugs.webkit.org/show_bug.cgi?id=81669

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.get for):
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.uiSourceCodeRemoved):
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.removeBreakpoint):
(WebInspector.BreakpointManager.prototype._innerRemoveBreakpoint):
(WebInspector.BreakpointManager.prototype.removeAllBreakpoints):
(WebInspector.BreakpointManager.prototype._moveBreakpointInUI):
(WebInspector.BreakpointManager.prototype._uiBreakpoints.get this):
(WebInspector.BreakpointManager.prototype._uiBreakpoints):
(WebInspector.BreakpointManager.prototype.get _uiBreakpoint):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromUI):
(WebInspector.BreakpointManager.prototype._breakpoints):
(WebInspector.BreakpointManager.prototype._breakpoint):
(WebInspector.BreakpointManager.prototype._addBreakpointToModel):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromModel):
(WebInspector.BreakpointManager.prototype._forEachBreakpoint):
(WebInspector.BreakpointManager.prototype._setBreakpointInDebugger):
(WebInspector.BreakpointManager.prototype._removeBreakpointFromDebugger):
(WebInspector.BreakpointManager.prototype.debuggerReset):
(WebInspector.Breakpoint.prototype.serialize):
(WebInspector.Breakpoint.prototype.get uiBreakpoint):
(WebInspector.Breakpoint.prototype.createUIBreakpoint):
(WebInspector.Breakpoint.prototype.removeUIBreakpoint):
(WebInspector.UIBreakpoint):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._handleUISourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
* inspector/front-end/ScriptsPanel.js:

LayoutTests:

* inspector/debugger/breakpoint-manager-expected.txt:
* inspector/debugger/breakpoint-manager.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoadd DOCTYPE for move-by-word-visually tests
xji@chromium.org [Wed, 21 Mar 2012 19:37:25 +0000 (19:37 +0000)]
add DOCTYPE for move-by-word-visually tests
https://bugs.webkit.org/show_bug.cgi?id=81810

Reviewed by Ryosuke Niwa.

* editing/selection/move-by-word-visually-crash-test-1.html:
* editing/selection/move-by-word-visually-crash-test-2.html:
* editing/selection/move-by-word-visually-crash-test-3.html:
* editing/selection/move-by-word-visually-crash-test-4.html:
* editing/selection/move-by-word-visually-crash-test-css-generated-content.html:
* editing/selection/move-by-word-visually-crash-test-textarea.html:
* editing/selection/move-by-word-visually-inline-block-positioned-element.html:
* editing/selection/move-by-word-visually-null-box.html:
* editing/selection/move-by-word-visually-textarea.html:
* editing/selection/move-by-word-visually-wrong-left-right.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTileCache needs to know if its containing page is in a window
andersca@apple.com [Wed, 21 Mar 2012 19:24:24 +0000 (19:24 +0000)]
TileCache needs to know if its containing page is in a window
https://bugs.webkit.org/show_bug.cgi?id=81821

Reviewed by Andreas Kling.

This is in preparation for throwing away invisible tiles in background tabs to reduce memory usage.

* page/FrameView.cpp:
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
* page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::didMoveOnscreen):
(WebCore::Page::willMoveOffscreen):
* page/Page.h:
(WebCore::Page::isOnscreen):
(Page):
* platform/graphics/TiledBacking.h:
(TiledBacking):
* platform/graphics/ca/mac/TileCache.h:
(TileCache):
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache):
(WebCore::TileCache::setIsInWindow):
(WebCore):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSome chromium rebaselines that differed due to platform-specific text rendering.
ojan@chromium.org [Wed, 21 Mar 2012 19:16:35 +0000 (19:16 +0000)]
Some chromium rebaselines that differed due to platform-specific text rendering.
The changes to non-chromium platforms are the result of webkit-patch optimize-baselines
which removed duplicate baselines from the tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r111569.
philn@webkit.org [Wed, 21 Mar 2012 19:09:15 +0000 (19:09 +0000)]
Unreviewed, GTK rebaseline after r111569.

* platform/gtk/http/tests/security/clipboard/clipboard-file-access-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb audio layout test failed in debug with an ASSERT error in ReverbConvolverStage.cpp
commit-queue@webkit.org [Wed, 21 Mar 2012 19:06:53 +0000 (19:06 +0000)]
Web audio layout test failed in debug with an ASSERT error in ReverbConvolverStage.cpp
https://bugs.webkit.org/show_bug.cgi?id=81744

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-21
Reviewed by Chris Rogers.

* platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Font fallback in cr-win is wrong for string contains zero-width-space.
xji@chromium.org [Wed, 21 Mar 2012 19:04:30 +0000 (19:04 +0000)]
[chromium] Font fallback in cr-win is wrong for string contains zero-width-space.
https://bugs.webkit.org/show_bug.cgi?id=79961

Reviewed by Adam Barth.

Source/WebCore:

Treat zero-width-space (\u200B) as true for treatAsZeroWidthSpaceInComplexScipt().

* platform/graphics/Font.h:
(WebCore::Font::treatAsZeroWidthSpaceInComplexScript):
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::shapeAndPlaceItem):

LayoutTests:

* fast/text/zero-width-characters-complex-script.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test_expectations update for chromium.
eae@chromium.org [Wed, 21 Mar 2012 19:01:59 +0000 (19:01 +0000)]
Unreviewed test_expectations update for chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for !ENABLE(INSPECTOR) after r111005.
paroga@webkit.org [Wed, 21 Mar 2012 18:59:55 +0000 (18:59 +0000)]
Build fix for !ENABLE(INSPECTOR) after r111005.

* inspector/ContentSearchUtils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] V8GCForContextDispose should indicate whether a context is disposed for the...
commit-queue@webkit.org [Wed, 21 Mar 2012 18:54:18 +0000 (18:54 +0000)]
[V8] V8GCForContextDispose should indicate whether a context is disposed for the main frame or not
https://bugs.webkit.org/show_bug.cgi?id=81200

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-03-21
Reviewed by Adam Barth.

Pass a hint to V8::IdleNotification that requests more aggressive GC
when a main frame context is disposed and requests incremental GC otherwise.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::disposeContextHandles):
* bindings/v8/V8GCForContextDispose.cpp:
(WebCore::V8GCForContextDispose::V8GCForContextDispose):
(WebCore::V8GCForContextDispose::notifyContextDisposed):
(WebCore::V8GCForContextDispose::pseudoIdleTimerFired):
* bindings/v8/V8GCForContextDispose.h:
(V8GCForContextDispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] CCThreadProxy must initialize frameBeginTime to monotonicallyIncreasingTim...
nduca@chromium.org [Wed, 21 Mar 2012 18:43:21 +0000 (18:43 +0000)]
[chromium] CCThreadProxy must initialize frameBeginTime to monotonicallyIncreasingTime rather than zero
https://bugs.webkit.org/show_bug.cgi?id=81790

Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionBeginFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd multichannel support in RealtimeAnalyser
commit-queue@webkit.org [Wed, 21 Mar 2012 18:40:34 +0000 (18:40 +0000)]
Add multichannel support in RealtimeAnalyser
https://bugs.webkit.org/show_bug.cgi?id=81745

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-21
Reviewed by Chris Rogers.

* Modules/webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::writeInput):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium linux rebaseline.
eae@chromium.org [Wed, 21 Mar 2012 18:37:33 +0000 (18:37 +0000)]
Unreviewed chromium linux rebaseline.

* platform/chromium-linux/fast/eventsource: Removed.
* platform/chromium-linux/fast/eventsource/eventsource-url-attribute-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] MediaStream API (JSEP): Enhancing WebMediaHints and WebICEOptions
tommyw@google.com [Wed, 21 Mar 2012 18:29:44 +0000 (18:29 +0000)]
[chromium] MediaStream API (JSEP): Enhancing WebMediaHints and WebICEOptions
https://bugs.webkit.org/show_bug.cgi?id=81652

Reviewed by Adam Barth.

Adding an initialize method to WebMediaHints and WebICEOptions.
This is needed for Chromium unittests.

* public/platform/WebICEOptions.h:
(WebKit::WebICEOptions::WebICEOptions):
(WebICEOptions):
* public/platform/WebMediaHints.h:
(WebKit::WebMediaHints::WebMediaHints):
(WebMediaHints):
* src/AssertMatchingEnums.cpp:
* src/WebICEOptions.cpp:
(WebKit::WebICEOptions::initialize):
(WebKit):
(WebKit::WebICEOptions::candidateTypeToUse):
* src/WebMediaHints.cpp:
(WebKit::WebMediaHints::initialize):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoving HTMLTrackElement does not delete TextTrack
eric.carlson@apple.com [Wed, 21 Mar 2012 18:28:48 +0000 (18:28 +0000)]
Removing HTMLTrackElement does not delete TextTrack
https://bugs.webkit.org/show_bug.cgi?id=80873

Reviewed by Antti Koivisto.

Source/WebCore:

No new tests, but media/track/track-language-preference.html has been updated
to test this fix.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::didAddTrack): Renamed from trackWasAdded.
(WebCore::HTMLMediaElement::willRemoveTrack): Renamed from trackWasRemoved because it is
called before the track is removed, to allow the TextTrack to be removed.
* html/HTMLMediaElement.h:

* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree): Renamed from insertedIntoDocument
(WebCore::HTMLTrackElement::willRemove): Renamed from removedFromDocument.
* html/HTMLTrackElement.h:

* html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::trackElementIndex): Don't include tracks that are not in the
document in the calcualtion.

LayoutTests:

* media/track/track-language-preference-expected.txt:
* media/track/track-language-preference.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix out of memory by allowing overcommit
commit-queue@webkit.org [Wed, 21 Mar 2012 18:21:46 +0000 (18:21 +0000)]
Fix out of memory by allowing overcommit
https://bugs.webkit.org/show_bug.cgi?id=81743

Patch by Hojong Han <hojong.han@samsung.com> on 2012-03-21
Reviewed by Geoffrey Garen.

Garbage collection is not triggered and new blocks are added
because overcommit is allowed by MAP_NORESERVE flag when high water mark is big enough.

* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChecking in updated test expectations
mhahnenberg@apple.com [Wed, 21 Mar 2012 18:04:39 +0000 (18:04 +0000)]
Checking in updated test expectations

* platform/mac/fast/AppleScript/001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
zeno.albisser@nokia.com [Wed, 21 Mar 2012 18:02:15 +0000 (18:02 +0000)]
[Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
https://bugs.webkit.org/show_bug.cgi?id=81750

Building WebCore on mac currently creates an archive that is bigger than
4GB. But ranlib fails to create a symbol table for such a big archive,
even on 64bit machines.
Therefore we start using SVGAllInOne.cpp when building debug
on mac. This reduces the size of the archive by about 300MB.

Reviewed by Tor Arne Vestbø.

Source/WebCore:

* Target.pri:

Tools:

* qmake/mkspecs/features/mac/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] MediaStream API (JSEP): Introducing WebSessionDescription and WebIceCandidate
tommyw@google.com [Wed, 21 Mar 2012 17:55:04 +0000 (17:55 +0000)]
[chromium] MediaStream API (JSEP): Introducing WebSessionDescription and WebIceCandidate
https://bugs.webkit.org/show_bug.cgi?id=81339

Reviewed by Adam Barth.

Source/WebCore:

Not possible to test until the entire JSEP feature is commited.

* Modules/mediastream/IceCandidate.cpp:
(WebCore::IceCandidate::toSdp):
* Modules/mediastream/SessionDescription.cpp:
(WebCore::SessionDescription::toSdp):
* platform/mediastream/IceCandidateDescriptor.cpp:
(WebCore::IceCandidateDescriptor::toSDP):
* platform/mediastream/IceCandidateDescriptor.h:
(IceCandidateDescriptor):
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::constructSDP):
* platform/mediastream/MediaStreamCenter.h:
(MediaStreamCenter):
* platform/mediastream/SessionDescriptionDescriptor.cpp:
(WebCore::SessionDescriptionDescriptor::SessionDescriptionDescriptor):
(WebCore::SessionDescriptionDescriptor::toSDP):
(WebCore::SessionDescriptionDescriptor::initialSDP):
* platform/mediastream/SessionDescriptionDescriptor.h:
(SessionDescriptionDescriptor):

Source/WebKit/chromium:

Simple WebKit representations of the WebCore/platform versions.

* WebKit.gyp:
* public/platform/WebICECandidateDescriptor.h: Added.
(WebCore):
(WebKit):
(WebICECandidateDescriptor):
(WebKit::WebICECandidateDescriptor::WebICECandidateDescriptor):
(WebKit::WebICECandidateDescriptor::~WebICECandidateDescriptor):
(WebKit::WebICECandidateDescriptor::operator=):
(WebKit::WebICECandidateDescriptor::isNull):
* public/platform/WebSessionDescriptionDescriptor.h: Added.
(WebCore):
(WebKit):
(WebSessionDescriptionDescriptor):
(WebKit::WebSessionDescriptionDescriptor::WebSessionDescriptionDescriptor):
(WebKit::WebSessionDescriptionDescriptor::~WebSessionDescriptionDescriptor):
(WebKit::WebSessionDescriptionDescriptor::operator=):
(WebKit::WebSessionDescriptionDescriptor::isNull):
* src/WebICECandidateDescriptor.cpp: Added.
(WebKit):
(WebKit::WebICECandidateDescriptor::WebICECandidateDescriptor):
(WebKit::WebICECandidateDescriptor::assign):
(WebKit::WebICECandidateDescriptor::reset):
(WebKit::WebICECandidateDescriptor::initialize):
(WebKit::WebICECandidateDescriptor::operator PassRefPtr<WebCore::IceCandidateDescriptor>):
(WebKit::WebICECandidateDescriptor::label):
(WebKit::WebICECandidateDescriptor::candidateLine):
* src/WebSessionDescriptionDescriptor.cpp: Added.
(WebKit):
(WebKit::WebSessionDescriptionDescriptor::WebSessionDescriptionDescriptor):
(WebKit::WebSessionDescriptionDescriptor::assign):
(WebKit::WebSessionDescriptionDescriptor::reset):
(WebKit::WebSessionDescriptionDescriptor::operator WTF::PassRefPtr<WebCore::SessionDescriptionDescriptor>):
(WebKit::WebSessionDescriptionDescriptor::initialize):
(WebKit::WebSessionDescriptionDescriptor::numberOfAddedCandidates):
(WebKit::WebSessionDescriptionDescriptor::candidate):
(WebKit::WebSessionDescriptionDescriptor::initialSDP):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test_expectations update for chromium.
eae@chromium.org [Wed, 21 Mar 2012 17:52:50 +0000 (17:52 +0000)]
Unreviewed test_expectations update for chromium.

* platform/chromium/test_expectations.txt:
Marking rubberbanding and a couple of svg tests as flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse RFC version of WebSocket protocol by default
yutak@chromium.org [Wed, 21 Mar 2012 17:51:10 +0000 (17:51 +0000)]
Use RFC version of WebSocket protocol by default
https://bugs.webkit.org/show_bug.cgi?id=81718

Reviewed by Kent Tamura.

Flip the default value of Settings::m_useHixie76WebSocketProtocol so WebKit ports will use
RFC version of WebSocket protocol by default.

All the existing ports already use the RFC protocol as of now, so this change will not make
any impact (hopefully).

No new tests. No change in functionality.

* page/Settings.cpp:
(WebCore::Settings::Settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: only show JS event listeners in Event Listeners tab of Elements panel
caseq@chromium.org [Wed, 21 Mar 2012 17:49:51 +0000 (17:49 +0000)]
Web Inspector: only show JS event listeners in Event Listeners tab of Elements panel
https://bugs.webkit.org/show_bug.cgi?id=81798

Reviewed by Pavel Feldman.

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::getJSListenerFunctions):
* bindings/js/ScriptEventListener.cpp:
(WebCore::eventListenerHandlerBody):
(WebCore::eventListenerHandlerLocation):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::getJSListenerFunctions):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getEventListeners):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEventListener::Type enum has unused member InspectorDOMAgentType
caseq@chromium.org [Wed, 21 Mar 2012 17:47:08 +0000 (17:47 +0000)]
EventListener::Type enum has unused member InspectorDOMAgentType
https://bugs.webkit.org/show_bug.cgi?id=81794

Reviewed by Pavel Feldman.

* dom/EventListener.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIncremental cleanup of BitmapImage: inlined virtual functions
commit-queue@webkit.org [Wed, 21 Mar 2012 17:43:46 +0000 (17:43 +0000)]
Incremental cleanup of BitmapImage: inlined virtual functions
https://bugs.webkit.org/show_bug.cgi?id=81688

Patch by Tom Hudson <tomhudson@google.com> on 2012-03-21
Reviewed by James Robinson.

No change in functionality, so no new tests.

Move virtual functions defined in headers into .cpp files.

* WebCore.gypi:
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::isBitmapImage):
(WebCore):
(WebCore::BitmapImage::hasSingleSecurityOrigin):
(WebCore::BitmapImage::nativeImageForCurrentFrame):
(WebCore::BitmapImage::currentFrameHasAlpha):
(WebCore::BitmapImage::notSolidColor):
(WebCore::BitmapImage::decodedSize):
(WebCore::BitmapImage::mayFillWithSolidColor):
(WebCore::BitmapImage::solidColor):
* platform/graphics/BitmapImage.h:
(BitmapImage):
* platform/graphics/skia/BitmapImageSingleFrameSkia.cpp: Added.
(WebCore):
(WebCore::BitmapImageSingleFrameSkia::isBitmapImage):
(WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):
(WebCore::BitmapImageSingleFrameSkia::size):
(WebCore::BitmapImageSingleFrameSkia::destroyDecodedData):
(WebCore::BitmapImageSingleFrameSkia::decodedSize):
(WebCore::BitmapImageSingleFrameSkia::nativeImageForCurrentFrame):
(WebCore::BitmapImageSingleFrameSkia::notSolidColor):
* platform/graphics/skia/BitmapImageSingleFrameSkia.h:
(BitmapImageSingleFrameSkia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded fast/forms/placeholder-set-attribute.html to the Mac skipped list, because of
mitz@apple.com [Wed, 21 Mar 2012 17:43:20 +0000 (17:43 +0000)]
Added fast/forms/placeholder-set-attribute.html to the Mac skipped list, because of
<http://webkit.org/b/81802> REGRESSION: fast/forms/placeholder-set-attribute.html is failing intermittently because WebKit fails to repaint after setting the placeholder attribute

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r111558.
philn@webkit.org [Wed, 21 Mar 2012 17:31:52 +0000 (17:31 +0000)]
Unreviewed, GTK rebaseline after r111558.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Remove obsolete File attributes
ap@apple.com [Wed, 21 Mar 2012 17:26:40 +0000 (17:26 +0000)]
    Remove obsolete File attributes
        https://bugs.webkit.org/show_bug.cgi?id=79383

        Reviewed by Hajime Morita.

        * bindings/objc/PublicDOMInterfaces.h:
        * fileapi/File.h:
        * fileapi/File.idl:
        Removed fileName and fileSize, they have different names now.

        * html/FileInputType.cpp:
        (WebCore::FileInputType::appendFormData):
        (WebCore::FileInputType::getTypeSpecificValue):
        (WebCore::FileInputType::defaultToolTip):
        Updated to use new function names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkipped editing/selection/move-by-word-visually-crash-test-5.html due to isWordTextBr...
xji@chromium.org [Wed, 21 Mar 2012 17:25:54 +0000 (17:25 +0000)]
Skipped editing/selection/move-by-word-visually-crash-test-5.html due to isWordTextBreak() is not implemented.

* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] WebGraphicsLayer: Untie the layer updates and tile updates.
jocelyn.turcotte@nokia.com [Wed, 21 Mar 2012 17:25:07 +0000 (17:25 +0000)]
[Qt] WebGraphicsLayer: Untie the layer updates and tile updates.
https://bugs.webkit.org/show_bug.cgi?id=81771

Reviewed by Kenneth Rohde Christiansen.

The DidRenderFrame message needs to be sent for every UpdateTileForLayer
message, but this currently has to be triggered by m_shouldSyncFrame which
is only set after sending a SyncCompositingLayerState message.
This patch makes sure that tile updates won't trigger sending the whole
layer info if it didn't change, and send the DidRenderFrame message directly.

It also makes sure that the layer info is sent before any tile update so that
the layer can be created on the UI process before any tile update is handled.

* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::getBackingStore):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::removeTile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't clip the contents rendering to the contents size.
jocelyn.turcotte@nokia.com [Wed, 21 Mar 2012 17:23:30 +0000 (17:23 +0000)]
[Qt] Don't clip the contents rendering to the contents size.
https://bugs.webkit.org/show_bug.cgi?id=81770

Reviewed by Kenneth Rohde Christiansen.

The original bug was caused by the contents size updates
having to go through the UI process before being applied
on the TiledBackingStore of the non composited contents layer.
With this bug being fixed, the clipping isn't necessary anymore.

* UIProcess/qt/LayerBackingStore.cpp:
(WebKit::LayerBackingStore::paintToTextureMapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Apply tile removals at the same time as update buffer swaps.
jocelyn.turcotte@nokia.com [Wed, 21 Mar 2012 17:22:04 +0000 (17:22 +0000)]
[Qt] Apply tile removals at the same time as update buffer swaps.
https://bugs.webkit.org/show_bug.cgi?id=81768

Reviewed by Kenneth Rohde Christiansen.

When committing the scale, we have to remove old tiles once the
tiles for the new scale are rendered. This should however wait
until those tiles gets their buffer swapped (following the DidRenderFrame
message) to make sure that there is no rendered gap between the removals
and updates swap.
This patch continues rendering the removed tiles until the DidRenderFrame
message is received to discard the old contents and show the new contents
at the same frame.

* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::commitTileUpdates):
(WebKit::WebLayerTreeRenderer::flushLayerChanges):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* UIProcess/qt/LayerBackingStore.cpp:
(WebKit::LayerBackingStore::removeTile):
(WebKit::LayerBackingStore::commitTileUpdates):
* UIProcess/qt/LayerBackingStore.h:
(LayerBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Trigger scene graph repaints only for relevant layer updates.
jocelyn.turcotte@nokia.com [Wed, 21 Mar 2012 17:20:47 +0000 (17:20 +0000)]
[Qt] Trigger scene graph repaints only for relevant layer updates.
https://bugs.webkit.org/show_bug.cgi?id=81765

Reviewed by Kenneth Rohde Christiansen.

Tile updates and removal shouldn't re-render the scene all by themselves
since they need a buffer swap before having any effect on the framebuffer.

* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::dispatchUpdate):
(WebKit::LayerTreeHostProxy::deleteCompositingLayer):
(WebKit::LayerTreeHostProxy::setRootCompositingLayer):
(WebKit::LayerTreeHostProxy::didRenderFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't go through the UI process to update a layer's contents size.
jocelyn.turcotte@nokia.com [Wed, 21 Mar 2012 17:19:46 +0000 (17:19 +0000)]
[Qt] Don't go through the UI process to update a layer's contents size.
https://bugs.webkit.org/show_bug.cgi?id=81764

Reviewed by Kenneth Rohde Christiansen.

It's happening when navigating pages that contents from the old page
is still present on the tiles until the contents size is shrunk to cut it out.
Since the contents size updates are asynchronous and go through the UI process,
this could occasionally show some glitch frames.
Even worse, the user could delay this update by starting to pan and keep
his finger on the screen.
This patch makes sure that changes to contents size are notifying the LayerTreeHost
immediately when in fixed layout mode, and remove the loop through the UI process.

* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::setContentsSize):
* UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewLegacyPrivate::updateViewportSize):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
* WebProcess/WebPage/DrawingArea.h:
(WebKit):
(WebKit::DrawingArea::layerTreeHost):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updateBackingStoreState):
* WebProcess/WebPage/DrawingAreaImpl.h:
(WebKit::DrawingAreaImpl::layerTreeHost):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::sizeDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore Windows build fixing.
jberlin@webkit.org [Wed, 21 Mar 2012 17:18:06 +0000 (17:18 +0000)]
More Windows build fixing.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
Fix the order of the include directories to look in include/private first before looking
in include/private/JavaScriptCore.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops:
Look in the Production output directory (where the wtf headers will be). This is the same
thing that is done for jsc and testRegExp in ReleasePGO.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTiledBackingStore: Create the first round of tiles synchronously after setting the...
jocelyn.turcotte@nokia.com [Wed, 21 Mar 2012 17:18:00 +0000 (17:18 +0000)]
TiledBackingStore: Create the first round of tiles synchronously after setting the visible rect.
https://bugs.webkit.org/show_bug.cgi?id=81762

Reviewed by Kenneth Rohde Christiansen.

The first round of tiles should cover completely the visible rect.
Creating the tiles synchronously allows us to get the new tiles immediately
and prevents an extra AC layers sync to be able to remove the old tiles.

At some point it might also make sense to remove the tile creation timer
completely.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::coverWithTilesIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTiledBackingStore: When checking if the visible area is covered, only convert to...
jocelyn.turcotte@nokia.com [Wed, 21 Mar 2012 17:16:46 +0000 (17:16 +0000)]
TiledBackingStore: When checking if the visible area is covered, only convert to scaled coordinates once.
https://bugs.webkit.org/show_bug.cgi?id=81519

Reviewed by Kenneth Rohde Christiansen.

Both visibleRect and coverageRatio call mapFromContents on the input rect,
this woulc cause the coverageRatio to never reach 1.0 when the contents is
scaled up.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::visibleAreaIsCovered):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated Mac WebKit2 expected results for this test. <http://webkit.org/b/81797> track...
mitz@apple.com [Wed, 21 Mar 2012 17:13:55 +0000 (17:13 +0000)]
Updated Mac WebKit2 expected results for this test. <webkit.org/b/81797> tracks the
fact that it is failing in WebKit2.

* platform/mac-wk2/fast/history: Added.
* platform/mac-wk2/fast/history/visited-link-background-color-expected.png: Added.
* platform/mac-wk2/fast/history/visited-link-background-color-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaStream API: Need to support MediaStream constructor for JSC
commit-queue@webkit.org [Wed, 21 Mar 2012 17:08:26 +0000 (17:08 +0000)]
MediaStream API: Need to support MediaStream constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=78781

Patch by Mao Yujie <yujie.mao@intel.com> on 2012-03-21
Reviewed by Adam Barth.

No new tests.

* Modules/mediastream/DOMWindowMediaStream.idl:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitMediaStreamEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed tests_expectations update.
eae@chromium.org [Wed, 21 Mar 2012 17:06:14 +0000 (17:06 +0000)]
Unreviewed tests_expectations update.

Mark svg/custom/fill-opacity-update.svg as crashing on snowleopard dbg.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip building resources if SVGTRef is not in a document
commit-queue@webkit.org [Wed, 21 Mar 2012 16:56:06 +0000 (16:56 +0000)]
Skip building resources if SVGTRef is not in a document
https://bugs.webkit.org/show_bug.cgi?id=81473

Patch by Philip Rogers <pdr@google.com> on 2012-03-21
Reviewed by Nikolas Zimmermann.

Source/WebCore:

We can skip the building of pending resources in SVGTRef if we're not
yet in a document. This mirrors the nearly identical logic in
SVGUseElement::buildPendingResource() and
SVGFEImageElement::buildPendingResource().

Test: http/tests/svg/tref-adoptNode-crash.html

* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::buildPendingResource):

LayoutTests:

* http/tests/svg: Added.
* http/tests/svg/resources: Added.
* http/tests/svg/resources/svg-tref.svg: Added.
* http/tests/svg/tref-adoptNode-crash-expected.txt: Added.
* http/tests/svg/tref-adoptNode-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Use floating point scroll deltas for layers
commit-queue@webkit.org [Wed, 21 Mar 2012 16:52:38 +0000 (16:52 +0000)]
[chromium] Use floating point scroll deltas for layers
https://bugs.webkit.org/show_bug.cgi?id=81546

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-03-21
Reviewed by James Robinson.

Source/WebCore:

Use floating point scroll deltas for layers instead of integral scroll
deltas. This is because due to page scaling it may be necessary to
scroll layers in sub-CSS-pixel steps to avoid visible jumps. When the
floating point scroll offset is committed to the main thread, it is
truncated to integer, but the fractional part is kept on the CC side to
make sure fractional scroll offsets are accumulated correctly over
multiple commits.

Test: CCLayerTreeHostTestFractionalScroll

* platform/graphics/FloatPoint.h:
(WebCore::toSize):
(WebCore):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::scrollBy):
(WebCore::CCLayerImpl::setScrollDelta):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::scrollDelta):
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::adjustScrollsForPageScaleChange):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):

Source/WebKit/chromium:

New unit test for accumulating fractional scroll deltas across multiple commits.

* tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTestFractionalScroll):
(WTF::CCLayerTreeHostTestFractionalScroll::CCLayerTreeHostTestFractionalScroll):
(WTF::CCLayerTreeHostTestFractionalScroll::beginTest):
(WTF::CCLayerTreeHostTestFractionalScroll::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestFractionalScroll::applyScrollAndScale):
(WTF::CCLayerTreeHostTestFractionalScroll::afterTest):
(WTF):
(WTF::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WebSocket]The Sec-WebSocket-Accept MUST NOT appear more than once in an HTTP response
commit-queue@webkit.org [Wed, 21 Mar 2012 16:46:41 +0000 (16:46 +0000)]
[WebSocket]The Sec-WebSocket-Accept MUST NOT appear more than once in an HTTP response
https://bugs.webkit.org/show_bug.cgi?id=81655

Patch by Li Yin <li.yin@intel.com> on 2012-03-21
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header.html

* Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readHTTPHeaders):

LayoutTests:

* http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header-expected.txt: Added.
* http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header.html: Added.
* http/tests/websocket/tests/hybi/handshake-fail-by-more-accept-header_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Speedup heap snapshot loading.
commit-queue@webkit.org [Wed, 21 Mar 2012 16:37:06 +0000 (16:37 +0000)]
Web Inspector: Speedup heap snapshot loading.
https://bugs.webkit.org/show_bug.cgi?id=81788

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-03-21
Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotLoader.prototype._parseNodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] IndexedDB: Expose necessary IDB exception codes through WebKit API
jsbell@chromium.org [Wed, 21 Mar 2012 16:36:34 +0000 (16:36 +0000)]
[Chromium] IndexedDB: Expose necessary IDB exception codes through WebKit API
https://bugs.webkit.org/show_bug.cgi?id=81597

To fix http://crbug.com/96826 and http://crbug.com/113118 we need to be able throw
exceptions from the Chromium side, so expose the necessary members of IDBDatabaseException.

Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebIDBDatabaseException.h: Added.
(WebKit):
* src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: get rid of isInEditMode, use isBeingEdited on particular element.
pfeldman@chromium.org [Wed, 21 Mar 2012 16:33:12 +0000 (16:33 +0000)]
Web Inspector: get rid of isInEditMode, use isBeingEdited on particular element.
https://bugs.webkit.org/show_bug.cgi?id=81766

Reviewed by Yury Semikhatsky.

We should check event target and its ancestors for being edited, not use some
global property. This change also introduces Event.prototype.consume so that we
were consistently consuming events.

* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype._onKeyDown):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
* inspector/front-end/CSSSelectorProfileView.js:
* inspector/front-end/Checkbox.js:
(WebInspector.Checkbox.prototype.addEventListener):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._enterKeyPressed):
(WebInspector.ConsoleGroup.prototype._titleClicked):
* inspector/front-end/ContextMenu.js:
(WebInspector.ContextMenu.prototype.show):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._keyDown):
* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype._enterKeyPressed):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):
(WebInspector.DetailedHeapshotView.prototype._retainersHeaderDragging):
(WebInspector.DetailedHeapshotView.prototype._endRetainersHeaderDragging):
* inspector/front-end/Dialog.js:
(WebInspector.Dialog.prototype._onKeyDown):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):
(WebInspector.Drawer.prototype._endStatusBarDragging):
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.get if):
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen.prototype._onKeyDown):
* inspector/front-end/InspectorView.js:
(WebInspector.InspectorView.prototype._keyDown):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):
* inspector/front-end/NetworkPanel.js:
* inspector/front-end/Object.js:
(WebInspector.Event.prototype.preventDefault):
(WebInspector.Event.prototype.consume):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype._promptKeyDown):
* inspector/front-end/ProfileView.js:
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype._onKeyDown):
* inspector/front-end/Section.js:
(WebInspector.Section.prototype.handleClick):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SoftContextMenu.js:
(.WebInspector.SoftContextMenu.prototype.show):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseDown):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):
(.WebInspector.SoftContextMenu.prototype._discardMenu):
* inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.draggable.consume):
(WebInspector.Spectrum.draggable.start):
(WebInspector.Spectrum.draggable.stop):
(WebInspector.Spectrum.draggable):
(WebInspector.Spectrum.prototype._onKeyDown):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.muteEventListener):
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype.set _createNewRule):
(WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
(WebInspector.StylePropertiesSection.prototype._handleSelectorClick):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.onKeyDown):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.SuggestBox.prototype._onItemMouseDown):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._handleKeyDown):
* inspector/front-end/Toolbar.js:
(WebInspector.ToolbarDropdown.prototype._onKeyDown):
* inspector/front-end/UIUtils.js:
(WebInspector.isBeingEdited):
(WebInspector.startEditing):
* inspector/front-end/View.js:
(WebInspector.View.prototype._doLoadCSS):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):
(WebInspector.WatchExpressionsSidebarPane.prototype._refreshButtonClicked):
* inspector/front-end/inspector.js:
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector.documentKeyDown):
(WebInspector.postDocumentKeyDown):
(WebInspector.addMainEventListeners):
* inspector/front-end/treeoutline.js:
(TreeOutline.prototype._treeKeyPress):
(TreeOutline.prototype._treeKeyDown):
(TreeOutline.prototype._searchInputKeyDown):
(TreeElement.treeElementToggled):
(TreeElement.prototype.selectOnMouseDown):
* inspector/front-end/utilities.js:
(Event.prototype.consume):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the Windows build after r111504.
jberlin@webkit.org [Wed, 21 Mar 2012 16:25:49 +0000 (16:25 +0000)]
Fix the Windows build after r111504.

* WTF.vcproj/WTF.vcproj:
Platform.h was moved to Source/WTF.
* WTF.vcproj/copy-files.cmd:
Copy Platform.h from its new source location. This separate copy will not be necessary once
the full move is done and all the headers are being copied at once from the new locations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: event listener section doesn't show all event listeners of the element...
yurys@chromium.org [Wed, 21 Mar 2012 16:09:40 +0000 (16:09 +0000)]
Web Inspector: event listener section doesn't show all event listeners of the element ancestors
https://bugs.webkit.org/show_bug.cgi?id=81782

Source/WebCore:

Event listeners section now contains all event listeners for the selected
element ancestors chain (in case option "All Nodes" is selected).

Reviewed by Pavel Feldman.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getEventListenersForNode):
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
(WebInspector.EventListenersSidebarPane.prototype):

LayoutTests:

Reviewed by Pavel Feldman.

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.expandSelectedElementEventListenersEventBars):
(initialize_ElementTest.InspectorTest.dumpSelectedElementEventListeners):
* inspector/elements/event-listener-sidebar-expected.txt:
* inspector/elements/event-listener-sidebar.html:
* platform/chromium/inspector/elements/event-listener-sidebar-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: HeapSnapshot: move all builders and calculation calls to HeapSnapshot...
loislo@chromium.org [Wed, 21 Mar 2012 15:48:46 +0000 (15:48 +0000)]
Web Inspector: HeapSnapshot: move all builders and calculation calls to HeapSnapshot._init function.
https://bugs.webkit.org/show_bug.cgi?id=81784

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype._retainersForNode):
(WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
(WebInspector.HeapSnapshot.prototype._flagsOfNode):
(WebInspector.HeapSnapshot.prototype.aggregates):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype.get nodeIndexes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWTF headers should be in $(ConfigurationBuildDir)\include\private\wtf, not
jberlin@webkit.org [Wed, 21 Mar 2012 15:45:35 +0000 (15:45 +0000)]
WTF headers should be in $(ConfigurationBuildDir)\include\private\wtf, not
$(ConfigurationBuildDir)\include\private\JavaScriptCore\wtf.
https://bugs.webkit.org/show_bug.cgi?id=81739

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/jsc/jsc.vcproj:
Look for AtomicString.cpp, StringBuilder.cpp, StringImpl.cpp, and WTFString.cpp in the wtf
subdirectory of the build output, not the JavaScriptCore/wtf subdirectory.
* JavaScriptCore.vcproj/testRegExp/testRegExp.vcproj:
Ditto.

* JavaScriptCore.vcproj/testRegExp/testRegExpReleasePGO.vsprops:
Get the headers for those 4 files from the wtf subdirectory of the build output, not the
JavaScriptCore/wtf subdirectory.
* JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops:
Ditto.

Source/WebCore:

* WebCore.vcproj/WebCore.vcproj:
Look for AtomicString.cpp, StringBuilder.cpp, StringImpl.cpp, and WTFString.cpp in the wtf
subdirectory of the build output, not the JavaScriptCore/wtf subdirectory.

Source/WTF:

* WTF.vcproj/copy-files.cmd:
Copy the headers to private/include/wtf instead of private/include/JavaScriptCore/wtf.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Credential save and autofill implemetation
commit-queue@webkit.org [Wed, 21 Mar 2012 15:23:33 +0000 (15:23 +0000)]
[BlackBerry] Credential save and autofill implemetation
https://bugs.webkit.org/show_bug.cgi?id=80401

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-03-21
Reviewed by Rob Buis.

Source/WebCore:

Added interface function authenticationChallenge() and
notifyShouldSaveCredential() into PageClientBlackBerry.
As this class is our platform specific interface,
by doing this we don't need to add an interface function
in class FrameLoaderClient which is a platform
independent interface.

No new tests.

* platform/blackberry/PageClientBlackBerry.h:
(WebCore):
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):

Source/WebKit/blackberry:

This patch is intended to implement the credential persist
and autofill feature for BlackBerry porting.

Moved interface authenticationChallenge() from class
FrameLoaderClientBlackBerry to WebPagePrivate (derived from
PageClientBlackBerry as changes made in its parent interface class);
Implemented notifyShouldSaveCredential() in WebPagePrivate
and WebPageClient as well.
Added credentialManager() to retrive CredentialManager instance
as a global singleton; removed its m_frameLoaderClient which is
replaced with a passed in PageClientBlackBerry pointer, and modified
the interface function accordingly.

For the http authentication, autofill the input dialog in
function authenticationChallenge() and save the credential
information in the same function;
For the in-form authentication, autofill the username and
password input fields in function dispatchDidFinishLoad(),
and save the credential information in function
dispatchWillSubmitForm() or dispatchWillSendSubmitEvent().

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::notifyShouldSaveCredential):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/CredentialManager.cpp:
(WebCore::credentialManager):
(WebCore::CredentialManager::saveCredentialIfConfirmed):
* WebCoreSupport/CredentialManager.h:
(CredentialManager):
(WebCore::CredentialManager::CredentialManager):
(WebCore):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):
(WebCore):
* WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert some fast/regions pixel tests to reftests
commit-queue@webkit.org [Wed, 21 Mar 2012 14:51:12 +0000 (14:51 +0000)]
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=80602

Patch by hermwong <herm.wong@gmail.com> on 2012-03-21
Reviewed by Dirk Schulze.

- convert CSS regions tests from pixel tests to reftests.
- removed unnecessary image files that were used for pixel tests.
- added *.expected.html as the control for the reftests - these will render the position of objects without using CSS regions
- removed the "no red should be visible..." text from the positioned-objects-inline-static-in-rtl-regions because there was no red in the test file and the statement was irrelevant to the test.
- removed text from the positioned-objects-inline-static-spanning-regions.html test because it had nothing to do with the test. We based this on the visuals of the test and the fact that the test description made no mention of the text at all

* fast/regions/positioned-objects-clipped-spanning-regions-expected.html: Added.
* fast/regions/positioned-objects-clipped-spanning-regions.html:
* fast/regions/positioned-objects-in-regions-expected.html: Added.
* fast/regions/positioned-objects-in-rtl-regions-expected.html: Copied from LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions.html.
* fast/regions/positioned-objects-inline-static-in-regions-expected.html: Copied from LayoutTests/fast/regions/positioned-objects-inline-static-in-regions.html.
* fast/regions/positioned-objects-inline-static-in-regions.html:
* fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.html: Copied from LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions.html.
* fast/regions/positioned-objects-inline-static-in-rtl-regions.html:    no red should be visible because there was no red in the test file and the statement was irrelevant to the test.
* fast/regions/positioned-objects-inline-static-spanning-regions-expected.html: Added.
* fast/regions/positioned-objects-inline-static-spanning-regions.html:
* fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.html: Copied from LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions.html.
* fast/regions/positioned-objects-spanning-regions-expected.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/fast/regions/positioned-objects-clipped-spanning-regions-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-in-regions-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-in-regions-expected.txt: Removed.
* platform/efl/fast/regions/positioned-objects-in-rtl-regions-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-in-rtl-regions-expected.txt: Removed.
* platform/efl/fast/regions/positioned-objects-inline-static-in-regions-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-inline-static-in-regions-expected.txt: Removed.
* platform/efl/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt: Removed.
* platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-expected.txt: Removed.
* platform/efl/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt: Removed.
* platform/efl/fast/regions/positioned-objects-spanning-regions-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-spanning-regions-expected.txt: Removed.
* platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Removed.
* platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-clipped-spanning-regions-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-in-regions-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-in-regions-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-spanning-regions-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-spanning-regions-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaselining eventsource-url-attribute.html after r111529
keishi@webkit.org [Wed, 21 Mar 2012 14:44:48 +0000 (14:44 +0000)]
[chromium] Rebaselining eventsource-url-attribute.html after r111529

* platform/chromium-linux/fast/eventsource/eventsource-url-attribute-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaselining canvas-putImageData.html
keishi@webkit.org [Wed, 21 Mar 2012 14:39:42 +0000 (14:39 +0000)]
[chromium] Rebaselining canvas-putImageData.html

* platform/chromium-linux/fast/repaint/canvas-putImageData-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/canvas-putImageData-expected.txt: Removed.
* platform/chromium-win/fast/repaint/canvas-putImageData-expected.txt: Removed.
* platform/chromium/fast/repaint/canvas-putImageData-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/repaint/canvas-putImageData-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaselining limit-layer-bounds-fixed-positioned.html
keishi@webkit.org [Wed, 21 Mar 2012 14:35:48 +0000 (14:35 +0000)]
[chromium] Rebaselining limit-layer-bounds-fixed-positioned.html

* platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Renamed from LayoutTests/platform/chromium-win/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Marking convolution-mono-mono.html and canvas-toDataURL-webp.html as crashing.
keishi@webkit.org [Wed, 21 Mar 2012 14:29:06 +0000 (14:29 +0000)]
[chromium] Marking convolution-mono-mono.html and canvas-toDataURL-webp.html as crashing.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: HeapProfiler: DOM node id can overflow Int32.
loislo@chromium.org [Wed, 21 Mar 2012 14:21:31 +0000 (14:21 +0000)]
Web Inspector: HeapProfiler: DOM node id can overflow Int32.
https://bugs.webkit.org/show_bug.cgi?id=81776

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.Uint32Array):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot.prototype._buildReverseIndex.var):
(WebInspector.HeapSnapshot.prototype._buildReverseIndex):
(WebInspector.HeapSnapshot.prototype._buildNodeIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Increase size of Combo Box Options for touch and high DPI devices
commit-queue@webkit.org [Wed, 21 Mar 2012 14:19:45 +0000 (14:19 +0000)]
[chromium] Increase size of Combo Box Options for touch and high DPI devices
https://bugs.webkit.org/show_bug.cgi?id=80027

Patch by Tim Dresser <tdresser@chromium.org> on 2012-03-21
Reviewed by Darin Fisher.

Source/WebCore:

Scale Combo box popups by defaultDeviceScaleFactor, and add padding to
<option> elements when touch is enabled.

Manually tested with --default-device-scale-factor=1,2 and unset.
Each of these were tested with RuntimeEnabledFeatures::touchEnabled
set to true and false.

* platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowHeight):
* platform/chromium/PopupListBox.h:
(PopupContainerSettings):
* platform/chromium/PopupMenuChromium.cpp:
(WebCore):
(WebCore::PopupMenuChromium::show):
* platform/chromium/PopupMenuChromium.h:
(WebCore::PopupMenuChromium::optionPaddingForTouch):
(WebCore::PopupMenuChromium::setOptionPaddingForTouch):
(PopupMenuChromium):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::showPopup):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::applyAutofillSuggestions):
* tests/PopupMenuTest.cpp:
(WebKit::TestWebViewClient::screenInfo):
(WebKit::SelectPopupMenuTest::SetUp):
(WebKit::SelectPopupMenuTest::TearDown):
(SelectPopupMenuTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated the address list of committers.py.
ossy@webkit.org [Wed, 21 Mar 2012 14:18:50 +0000 (14:18 +0000)]
Updated the address list of committers.py.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-03-21
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] [WebSocket] provide WebFrameClient with a chance of
toyoshim@chromium.org [Wed, 21 Mar 2012 14:00:35 +0000 (14:00 +0000)]
[Chromium] [WebSocket] provide WebFrameClient with a chance of
accessing to opening WebSocketStreamHandle.
https://bugs.webkit.org/show_bug.cgi?id=78459

Reviewed by Kent Tamura and Darin Fisher.

Source/WebCore:

Add willOpenSocketStream client function to WebFrameClient with an
argument representing an opening SocketStreamHandle.
These mechanisms provide embedders with a chance to bind arbitrary
data to a WebSocketStreamHandle from WebFrameClient to which the
WebSocket object having the WebSocketStreamHandle belongs.

No new tests because this change just provide mechanisms to embedders.

* Modules/websockets/WebSocketChannel.cpp: Implement willOpenSocketStream to call a client function in WebFrameClient.
(WebCore::WebSocketChannel::willOpenSocketStream):
(WebCore):
* Modules/websockets/WebSocketChannel.h: Add willOpenSocketStream declaration.
(WebSocketChannel):
* loader/FrameLoaderClient.h: Add dispatchWillOpenSocketStream declaration.
(WebCore):
(FrameLoaderClient):
(WebCore::FrameLoaderClient::dispatchWillOpenSocketStream):
* platform/network/SocketStreamHandleClient.h: Add willOpenSocketStream declaration.
(WebCore::SocketStreamHandleClient::willOpenSocketStream):

Source/WebKit/chromium:

Add dispatchWillOpenSocketStream client function to WebFrameClient with
an argument representing an opening SocketStreamHandle.
These mechanisms provide embedders with a chance to bind arbitrary
data to a WebSocketStreamHandle from WebFrameClient to which the
WebSocket object having the WebSocketStreamHandle belongs.

No new tests because this change just provide mechanisms to embedders.

* public/WebFrameClient.h: Add dispatchWillOpenSocketStream declaration.
(WebKit):
(WebFrameClient):
(WebKit::WebFrameClient::willOpenSocketStream):
* public/platform/WebSocketStreamHandle.h: Add default implementation to virtual functions.
(WebKit::WebSocketStreamHandle::connect):
(WebKit::WebSocketStreamHandle::send):
(WebKit::WebSocketStreamHandle::close):
* src/FrameLoaderClientImpl.cpp: Implement dispatchWillOpenSocketStream.
(WebKit::FrameLoaderClientImpl::dispatchWillOpenSocketStream):
(WebKit):
* src/FrameLoaderClientImpl.h: Add dispatchWillOpenSocketStream declaratioin.
(FrameLoaderClientImpl):
* src/SocketStreamHandle.cpp: Call willOpenSocketStream client function.
(WebCore::SocketStreamHandleInternal::connect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Wk2] Removed test expectation after r111419.
ossy@webkit.org [Wed, 21 Mar 2012 13:56:12 +0000 (13:56 +0000)]
[Qt][Wk2] Removed test expectation after r111419.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-03-21
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0-wk2/css1/basic/inheritance-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=81761
commit-queue@webkit.org [Wed, 21 Mar 2012 13:52:44 +0000 (13:52 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81761
Fix Gobject binding for sequence<T> for function return type.

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-03-21
Reviewed by Kentaro Hara.

No new tests.

* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skip function with sequence<T> return type.
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_with_sequence_arg):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnskip test fixed in r111520.
philn@webkit.org [Wed, 21 Mar 2012 13:43:30 +0000 (13:43 +0000)]
Unskip test fixed in r111520.

* platform/gtk/Skipped: fast/dom/prototype-inheritance-2.html
should pass now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix for r111529.
caseq@chromium.org [Wed, 21 Mar 2012 13:38:07 +0000 (13:38 +0000)]
Unreviewed build fix for r111529.

* inspector/InjectedScriptHost.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r111497, r111506, r111508, and
ossy@webkit.org [Wed, 21 Mar 2012 13:36:18 +0000 (13:36 +0000)]
Unreviewed, rolling out r111497, r111506, r111508, and
r111513.
http://trac.webkit.org/changeset/111497
http://trac.webkit.org/changeset/111506
http://trac.webkit.org/changeset/111508
http://trac.webkit.org/changeset/111513
https://bugs.webkit.org/show_bug.cgi?id=81774

It broke 2 tests on all platform (Requested by Ossy on

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-21

Source/WebCore:

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement):
(WebCore::HTMLOptionElement::create):
(WebCore::HTMLOptionElement::attach):
(WebCore::HTMLOptionElement::detach):
(WebCore::HTMLOptionElement::formControlType):
(WebCore):
(WebCore::HTMLOptionElement::parseAttribute):
(WebCore::HTMLOptionElement::childrenChanged):
(WebCore::HTMLOptionElement::insertedIntoTree):
* html/HTMLOptionElement.h:
(HTMLOptionElement):
(WebCore::HTMLOptionElement::ownElementDisabled):
* html/HTMLTagNames.in:

LayoutTests:

* fast/forms/resources/select-live-pseudo-selectors.js:
(simulateClick):
* fast/forms/select-live-pseudo-selectors-expected.txt:
* platform/chromium-mac-leopard/fast/css/text-transform-select-expected.png:
* platform/chromium-mac-leopard/fast/forms/select/menulist-disabled-option-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/css/text-transform-select-expected.png:
* platform/chromium-mac-snowleopard/fast/css/text-transform-select-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/select-max-length-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/forms/select/menulist-disabled-option-expected.png: Removed.
* platform/chromium-mac/fast/css/text-transform-select-expected.png:
* platform/chromium-mac/fast/css/text-transform-select-expected.txt: Removed.
* platform/chromium-mac/fast/forms/select/menulist-disabled-option-expected.png: Removed.
* platform/chromium-win-xp/fast/forms/select-max-length-expected.txt: Removed.
* platform/chromium-win/fast/css/text-transform-select-expected.png:
* platform/chromium-win/fast/css/text-transform-select-expected.txt:
* platform/chromium-win/fast/forms/select/menulist-disabled-option-expected.png: Removed.
* platform/gtk/Skipped:
* platform/gtk/fast/css/text-transform-select-expected.txt:
* platform/mac/fast/css/text-transform-select-expected.png:
* platform/mac/fast/css/text-transform-select-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdating my nick in committers file.
wjmaclean@chromium.org [Wed, 21 Mar 2012 13:28:31 +0000 (13:28 +0000)]
Updating my nick in committers file.

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111531 268f45cc-cd09-0410-ab3c-d52691b4dbfc