14 years ago Reviewed by Anders
beidson [Wed, 7 Mar 2007 19:09:15 +0000 (19:09 +0000)]
    Reviewed by Anders

        Explicitly mention the prepare-Changelog step for contributing patches

        * coding/contributing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Wed, 7 Mar 2007 19:07:40 +0000 (19:07 +0000)]
    Reviewed by Geoff.

        - change tests that depend on the order of iteration of built-in properties
          to sort explicitly so they don't depend on the order any more

        * fast/dom/Window/resources/window-appendages-cleared-results.html:
        * fast/dom/Window/window-appendages-cleared-expected.txt:

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-properties.html:

        * fast/js/regexp-caching-expected.txt:
        * fast/js/regexp-caching.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Wed, 7 Mar 2007 18:32:11 +0000 (18:32 +0000)]
    Reviewed by Darin.

        Import/convert 4XPath test suite

        Import the rest of the converted suite. The only remaining failures are due to
        incorrect node order, bug 12497.

        * fast/xpath/4XPath/Core/test_literal_expr.html: Added.
        * fast/xpath/4XPath/Core/test_location_path.html: Added.
        * fast/xpath/4XPath/Core/test_node_test.html: Added.
        * fast/xpath/4XPath/Core/test_nodeset_expr.html: Added.
        * fast/xpath/4XPath/Core/test_parser-expected.txt: Added.
        * fast/xpath/4XPath/Core/test_parser.html: Added.
        * fast/xpath/4XPath/Core/test_predicate_list.html: Added.
        * fast/xpath/4XPath/Core/test_step-expected.txt: Added.
        * fast/xpath/4XPath/Core/test_step.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * WebCoreSupport/FrameLoaderClientQt.h: Oops, forgot the header.
darin [Wed, 7 Mar 2007 16:40:27 +0000 (16:40 +0000)]
    * WebCoreSupport/FrameLoaderClientQt.h: Oops, forgot the header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
ggaren [Wed, 7 Mar 2007 16:34:56 +0000 (16:34 +0000)]
    Reviewed by Darin Adler.

        Fixed ASSERT failure I just introduced.

        Made the fastMalloc isForbidden flag per thread. (Oops!) We expect that
        other threads will malloc while we're marking -- we just want to prevent
        our own marking from malloc'ing.

        * wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren [Wed, 7 Mar 2007 15:37:06 +0000 (15:37 +0000)]

        Reviewed by Maciej.


        Wrap pthread-specific assertion in #if USE(MULTIPLE_THREADS).

        * kjs/collector.cpp:


        Reviewed by Maciej Stachowiak.

        Fixed <rdar://problem/4576242> | http://bugs.webkit.org/show_bug.cgi?id=12586
        PAC file: malloc deadlock sometimes causes a hang @ www.apple.com/pro/profiles/ (12586)

        No test because this is very difficult to repro, and the new ASSERTs in
        JavaScriptCore catch the underlying cause while running normal layout tests.

        This is a modified version of r14752 on the branch.

        The fix is to use a bit inside each node, instead of a hash table, to track
        which node subtrees are in the process of being marked. This avoids a call
        to malloc inside mark().

        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_dom.cpp:
        * dom/Node.cpp:
        * dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Wed, 7 Mar 2007 15:01:10 +0000 (15:01 +0000)]

        Reviewed by Darin.

        - LayoutTests part of fix for http://bugs.webkit.org/show_bug.cgi?id=12463
          WebArchiver - attempt to insert nil exception when archive empty iframe

        Tests using both dumpDOMAsWebArchive() and dumpSourceAsWebArchive() were added
        for this bug since a similar fix was suggested for the DOM case which was not
        needed.  The remaining changes are related to renaming dumpAsWebArchive() to

        * webarchive/archive-empty-frame-dom-expected.txt: Added.
        * webarchive/archive-empty-frame-dom.html: Added.
        * webarchive/archive-empty-frame-source-expected.txt: Added.
        * webarchive/archive-empty-frame-source.html: Added.
        * webarchive/resources/dump-webarchive.js: Renamed dumpAsWebArchive() to dumpDOMAsWebArchive().
        * webarchive/test-body-background-expected.txt: Ditto.
        * webarchive/test-body-background.html: Ditto.
        * webarchive/test-duplicate-resources-expected.txt: Ditto.
        * webarchive/test-frameset-expected.txt: Ditto.
        * webarchive/test-frameset.html: Ditto.
        * webarchive/test-img-src-expected.txt: Ditto.
        * webarchive/test-img-src.html: Ditto.
        * webarchive/test-input-src-expected.txt: Ditto.
        * webarchive/test-input-src.html: Ditto.
        * webarchive/test-link-href-expected.txt: Ditto.
        * webarchive/test-link-href.html: Ditto.
        * webarchive/test-object-data-expected.txt: Ditto.
        * webarchive/test-object-data.html: Ditto.
        * webarchive/test-script-src-expected.txt: Ditto.
        * webarchive/test-table-background-expected.txt: Ditto.
        * webarchive/test-table-background.html: Ditto.
        * webarchive/test-td-background-expected.txt: Ditto.
        * webarchive/test-td-background.html: Ditto.


        Reviewed by Darin.

        - WebCore part of fix for http://bugs.webkit.org/show_bug.cgi?id=12463
          WebArchiver - attempt to insert nil exception when archive empty iframe

        When dealing with an iframe element with no src attribute, the element contains
        a src attribute in the DOM with a URL of "about:blank" and some HTML to implement
        the blank page.  In the original page source, however, the iframe element does
        not include a src attribute, which caused a nil archive to be returned for the
        childFrameArchive and thus caused the bug.  The fix is a simple nil check.

        Test: webarchive/archive-empty-frame-source.html

        * WebView/WebArchiver.mm:
        (+ (NSArray *)_subframeArchivesForFrame:(WebFrame *)frame): Don't add childFrameArchive
        to the subframeArchives array if it is nil.


        Reviewed by Darin.

        - WebKitTools part of fix for http://bugs.webkit.org/show_bug.cgi?id=12463
          WebArchiver - attempt to insert nil exception when archive empty iframe

        The dumpDOMAsWebArchive() test method uses the DOMDocument as a basis for creating
        a webarchive while the dumpSourceAsWebArchive() test method uses the original
        dataSource (page source) to create a webarchive.  Most tests currently use
        dumpDOMAsWebArchive() since this is what Safari does when saving a web page as a

        * DumpRenderTree/DumpRenderTree.m: Renamed dumpAsWebArchive to dumpDOMAsWebArchive.
        Added dumpSourceAsWebArchive.
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController dumpDOMAsWebArchive]):
        (-[LayoutTestController dumpSourceAsWebArchive]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Wed, 7 Mar 2007 14:25:57 +0000 (14:25 +0000)]

        Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12992
          Test failure (r19972):  LayoutTests/svg/custom/struct-use-09-b.svg

        * svg/custom/struct-use-09-b.svg: Changed to use Helvetica instead of 'Arial Black', Arial.
        * svg/custom/struct-use-09-b-expected.checksum: Update results.
        * svg/custom/struct-use-09-b-expected.png: Ditto.
        * svg/custom/struct-use-09-b-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt:...
darin [Wed, 7 Mar 2007 14:18:42 +0000 (14:18 +0000)]
    * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::userAgent):
        Try to fix the build by correcting the parameter here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-07 Shrikant Gangoda <shrikant.gangoda@celunite.com>
bdash [Wed, 7 Mar 2007 09:46:38 +0000 (09:46 +0000)]
2007-03-07  Shrikant Gangoda  <shrikant.gangoda@celunite.com>

        Reviewed by Maciej.


        Wrap pthread-specific assertion in #if USE(MULTIPLE_THREADS).

        * kjs/collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by mjs
justing [Wed, 7 Mar 2007 09:05:54 +0000 (09:05 +0000)]
    Reviewed by mjs

        Extra line left after deleting whitespace:pre text

        Re-enabled the test and removed a FIXME:
        * editing/deleting/merge-whitespace-pre-expected.checksum:
        * editing/deleting/merge-whitespace-pre-expected.png:
        * editing/deleting/merge-whitespace-pre-expected.txt:
        * editing/deleting/merge-whitespace-pre.html: Added.
        * editing/deleting/merge-whitespace-pre.html-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix an oversight in the spelling over oversight.
bdash [Wed, 7 Mar 2007 08:43:24 +0000 (08:43 +0000)]
Fix an oversight in the spelling over oversight.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago This patch reworks the WebCore memory cache to significantly reduce the amoun...
hyatt [Wed, 7 Mar 2007 07:42:45 +0000 (07:42 +0000)]
    This patch reworks the WebCore memory cache to significantly reduce the amount of memory consumed by
        images in the cache and to enhance the accuracy of the cache size as an absolute bound for the objects
        contained within it.  WebCore's memory use over time should significantly improve as a result of these

        Cached resources now have both an encoded size (the original data stream) and a decoded size (an estimate of
        the amount of memory consumed by an expanded version of that resource, e.g., the decoded frames of an image).
        Both sizes now count towards the total size of the object and towards the allowed memory cache total.

        By including both totals the reported size of resources will now be larger, and the cache will therefore become
        much more aggressive about flushing.

        Objects are stored in size-adjusted and popularity-aware LRU lists as before, but encoded size is now always
        used when determining the correct LRU list.

        The flush algorithm for the memory cache has been rewritten to first destroy decoded data before evicting
        resources.  By being able to compact its resources without evicting them, the memory cache can now hold many more
        unique resources (encoded) in the same amount of space.  Depending on how much of a hit we want to take from
        re-decoding images, the memory cache could in theory have its size significantly reduced now while still holding
        more resources than it did at the larger size!

        Reviewed by mjs

        * WebCore.xcodeproj/project.pbxproj:
        * loader/Cache.cpp:
        * loader/Cache.h:
        * loader/CachedCSSStyleSheet.cpp:
        * loader/CachedImage.cpp:
        * loader/CachedImage.h:
        * loader/CachedResource.cpp:
        * loader/CachedResource.h:
        * loader/CachedScript.cpp:
        * loader/CachedXSLStyleSheet.cpp:
        * platform/graphics/BitmapImage.cpp:
        * platform/graphics/BitmapImage.h:
        * platform/graphics/Image.cpp:
        * platform/graphics/Image.h:
        * platform/graphics/ImageAnimationObserver.h: Removed.
        * platform/graphics/ImageObserver.h: Added.
        * platform/graphics/svg/SVGImage.cpp:
        * platform/graphics/svg/SVGImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Sam Weinig.
ap [Wed, 7 Mar 2007 06:03:27 +0000 (06:03 +0000)]
    Reviewed by Sam Weinig.

        Fix and import 4XPath test_numeric_expr.html

        * xml/XPathPredicate.cpp:
        (WebCore::XPath::Negative::doEvaluate): Convert the argument to number.
        (WebCore::XPath::NumericOp::doEvaluate): Convert the arguments to numbers. Use a correct operation for mod.
        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::nodesInAxis): Do not append parent node if there is none.
        * xml/XPathValue.cpp:
        (WebCore::XPath::Value::toNumber): Do not convert to DeprecatedString just to trim whitespace and to convert to double.
        * platform/DeprecatedString.cpp:
        (WebCore::DeprecatedStringData::makeAscii): Added a FIXME about unreliable makeAscii() behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix broken layout test results.
bdash [Wed, 7 Mar 2007 05:55:30 +0000 (05:55 +0000)]
Fix broken layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
mjs [Wed, 7 Mar 2007 05:36:21 +0000 (05:36 +0000)]
    Reviewed by Adele.

        <rdar://problem/4619663> REGRESSION (NativePopup): Popup menu doesn't draw at the correct vertical position (9816)

        * platform/mac/PopupMenuMac.mm:
        (WebCore::PopupMenu::show): Make a temporary dummy view with the
        passed in rect, since AppKit will use the view bounds to determine
        what area to exclude when popping up a menu moved to the top of
        the screen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-07 Mark Rowe <mrowe@apple.com>
bdash [Wed, 7 Mar 2007 05:25:14 +0000 (05:25 +0000)]
2007-03-07  Mark Rowe  <mrowe@apple.com>

        Build fix.  Rebuild against 10.4 SDK.

        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren [Wed, 7 Mar 2007 04:25:49 +0000 (04:25 +0000)]

        Reviewed by Maciej Stachowiak.

        Fixed all known crashers exposed by run-webkit-tests --threaded. This covers:

        <rdar://problem/4565394> | http://bugs.webkit.org/show_bug.cgi?id=12585
            PAC file: after closing a window that contains macworld.com, new window
            crashes (KJS::PropertyMap::mark()) (12585)
        <rdar://problem/4571215> | http://bugs.webkit.org/show_bug.cgi?id=9211
            PAC file: Crash occurs when clicking on the navigation tabs at http://www.businessweek.com/ (9211)
            PAC file: Crash occurs when attempting to view image in slideshow mode
            at http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::
            ExecState*) + 312) if you use a PAC file

        (1) Added some missing JSLocks, along with related ASSERTs.

        (2) Fully implemented support for objects that can only be garbage collected
        on the main thread. So far, only WebCore uses this. We can add it to API
        later if we learn that it's needed.

        The implementation uses a "main thread only" flag inside each object. When
        collecting on a secondary thread, the Collector does an extra pass through
        the heap to mark all flagged objects before sweeping. This solution makes
        the common case -- flag lots of objects, but never collect on a secondary
        thread -- very fast, even though the uncommon case of garbage collecting
        on a secondary thread isn't as fast as it could be. I left some notes
        about how to speed it up, if we ever care.

        For posterity, here are some things I learned about GC while investigating:

        * Each collect must either mark or delete every heap object. "Zombie"
        objects, which are neither marked nor deleted, raise these issues:

            * On the next pass, the conservative marking algorithm might mark a
            zombie, causing it to mark freed objects.

            * The client might try to use a zombie, which would seem live because
            its finalizer had not yet run.

        * A collect on the main thread is free to delete any object. Presumably,
        objects allocated on secondary threads have thread-safe finalizers.

        * A collect on a secondary thread must not delete thread-unsafe objects.

        * The mark function must be thread-safe.

        Line by line comments:

        * API/JSObjectRef.h: Added comment specifying that the finalize callback
        may run on any thread.

        * JavaScriptCore.exp: Nothing to see here.

        * bindings/npruntime.cpp:
        (_NPN_GetStringIdentifier): Added JSLock.

        * bindings/objc/objc_instance.h:
        * bindings/objc/objc_instance.mm:
        (ObjcInstance::~ObjcInstance): Use an autorelease pool. The other callers
        to CFRelease needed one, too, but they were dead code, so I removed them
        instead. (This fixes a leak seen while running run-webkit-tests --threaded,
        although I don't think it's specifically a threading issue.)

        * kjs/collector.cpp:
        (KJS::Collector::collectOnMainThreadOnly): New function. Tells the collector
        to collect a value only if it's collecting on the main thread.
        (KJS::Collector::markMainThreadOnlyObjects): New function. Scans the heap
        for "main thread only" objects and marks them.

        * kjs/date_object.cpp:
        (KJS::DateObjectImp::DateObjectImp): To make the new ASSERTs happy, allocate
        our globals on the heap, avoiding a seemingly unsafe destructor call at
        program exit time.
        * kjs/function_object.cpp:
        (FunctionPrototype::FunctionPrototype): ditto

        * kjs/interpreter.cpp:
        (KJS::Interpreter::mark): Removed boolean parameter, which was an incomplete
        and arguably hackish way to implement markMainThreadOnlyObjects() inside WebCore.
        * kjs/interpreter.h:

        * kjs/identifier.cpp:
        (KJS::identifierTable): Added some ASSERTs to check for thread safety

        * kjs/list.cpp: Added some ASSERTs to check for thread safety problems.
        (KJS::List::empty): Make the new ASSERTs happy.

        * kjs/object.h:
        (KJS::JSObject::JSObject): "m_destructorIsThreadSafe" => "m_collectOnMainThreadOnly".
        I removed the constructor parameter because m_collectOnMainThreadOnly,
        like m_marked, is a Collector bit, so only the Collector should set or get it.

        * kjs/object_object.cpp:
        (ObjectPrototype::ObjectPrototype): Make the ASSERTs happy.
        * kjs/regexp_object.cpp:
        (RegExpPrototype::RegExpPrototype): ditto

        * kjs/ustring.cpp: Added some ASSERTs to check for thread safety problems.
        (KJS::UString::null): Make the new ASSERTs happy.
        * kjs/ustring.h:
        (KJS::UString::Rep::ref): Added some ASSERTs to check for thread safety problems.

        * kjs/value.h:


        Reviewed by Maciej Stachowiak.

        Fixed all known crashers exposed by run-webkit-tests --threaded while using
        a PAC file (for maximum carnage). See JavaScriptCore ChangeLog for
        more details.

        * JSBase.cpp:
        (JSBase::Release): Lock when deleting, because we may be deleting an object
        (like a JSRun) that holds thread-unsafe data.

        * JSUtils.cpp:
        (CFStringToUString): Don't lock, because our caller locks. Also, locking
        inside a function that returns thread-unsafe data by copy will only mask
        threading problems.

        * JavaScriptGlue.cpp:
        (JSRunEvaluate): Added missing JSLock.
        (JSRunCheckSyntax): Converted to JSLock.
        * JavaScriptGlue.xcodeproj/project.pbxproj:


        Reviewed by Maciej Stachowiak.

        Fixed all known crashers exposed by run-webkit-tests --threaded [*]. See
        JavaScriptCore ChangeLog for more details.

        * bindings/js/kjs_binding.cpp:
        (KJS::domNodesPerDocument): Added thread safety ASSERT.
        (KJS::ScriptInterpreter::mark): Removed obsolete logic for marking unsafe
        objects when collecting on a secondary thread. The Collector takes care
        of this now.

        * bindings/js/kjs_binding.h:
        (KJS::DOMObject::DOMObject): Used new API for specifying that WebCore
        objects should be garbage collected on the main thread only.

        * bindings/js/kjs_window.cpp:
        (KJS::ScheduledAction::execute): Moved JSLock to cover implementedsCall() call,
        which, for some subclasses, ends up allocating garbage collected objects.
        (This fix was speculative. I didn't actually see a crash from this.)
        (KJS::Window::timerFired): Added JSLock around ScheduleAction destruction,
        since it destroys a KJS::List.

        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject setException:]): Added JSLock. (This fix was speculative.
        I didn't actually see a crash from this.)

        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame evaluateWebScript:]): Added JSLock. (This fix
        was speculative. I didn't actually see a crash from this.)

        * dom/Document.cpp:
        (WebCore::Document::~Document): Added JSLock around modification to
        domNodesPerDocument(), which can be accessed concurrently during garbage
        * dom/Node.cpp:
        (WebCore::Node::setDocument): ditto.

        [*] fast/js/toString-stack-overflow.html is an exception. --threaded mode
        crashes this test because it causes the garbage collector to run frequently,
        and this test crashes if you happen to garbage collect while it's running.
        This is a known issue with stack overflow during the mark phase. It's
        not related to threading.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady
kdecker [Wed, 7 Mar 2007 04:18:16 +0000 (04:18 +0000)]
    Reviewed by Brady

        Fixed: <rdar://problem/4126976> private keys imported by WebKit should not be accessible by all applications

        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-07 Mark Rowe <mrowe@apple.com>
bdash [Wed, 7 Mar 2007 04:16:09 +0000 (04:16 +0000)]
2007-03-07  Mark Rowe  <mrowe@apple.com>

        Add dumpAsText to test to match expected results.

        * fast/dom/Window/window-location-replace-functions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-06 Mark Rowe <mrowe@apple.com>
bdash [Wed, 7 Mar 2007 04:07:42 +0000 (04:07 +0000)]
2007-03-06  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Fix http://bugs.webkit.org/show_bug.cgi?id=12942
        Bug 12942: ASSERTION FAILURE: qantas.com.au changing selected item in <select> via JS

        Test: fast/dom/select-selectedIndex-bug-12942.html.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::recalcListItems): Reset m_lastOnChangeIndex when recalculating list items.
        * html/HTMLSelectElement.h:

2007-03-06  Mark Rowe  <mrowe@apple.com>

        Reviewed by Sam Weinig.

        Test for http://bugs.webkit.org/show_bug.cgi?id=12942
        Bug 12942: ASSERTION FAILURE: qantas.com.au changing selected item in <select> via JS

        * fast/dom/select-selectedIndex-bug-12942-expected.txt: Added.
        * fast/dom/select-selectedIndex-bug-12942.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubberstamped by Kevin Decker
beidson [Wed, 7 Mar 2007 04:05:05 +0000 (04:05 +0000)]
    Rubberstamped by Kevin Decker


        * ChangeLog: Point out revision 20,000

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Not reviewed.
kjk [Wed, 7 Mar 2007 04:04:25 +0000 (04:04 +0000)]
    Not reviewed.

        Gdk build fix.

        * loader/gdk/FrameLoaderClientGdk.cpp: update userAgent() signature.
        * loader/gdk/FrameLoaderClientGdk.h: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-06 Mitz Pettel <mitz@webkit.org>
bdash [Wed, 7 Mar 2007 03:40:57 +0000 (03:40 +0000)]
2007-03-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12986
          REGRESSION(NativeListBox): Listboxes not updated when resized dynamically

        Test: fast/forms/select-change-listbox-size.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::parseMappedAttribute): Reattach on list box size change.

2007-03-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Adele.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12986
          REGRESSION(NativeListBox): Listboxes not updated when resized dynamically

        * fast/forms/select-change-listbox-size-expected.checksum: Added.
        * fast/forms/select-change-listbox-size-expected.png: Added.
        * fast/forms/select-change-listbox-size-expected.txt: Added.
        * fast/forms/select-change-listbox-size.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-06 Mitz Pettel <mitz@webkit.org>
bdash [Wed, 7 Mar 2007 03:35:03 +0000 (03:35 +0000)]
2007-03-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12885
          REGRESSION (r19696): Incomplete background repaint

        Tests: fast/repaint/content-into-overflow.html

        Changed repaintAfterLayoutIfNeeded() to take, in addition to the clipped overflow
        rect, the unclipped border box plus outline, and to repaint any areas that
        were added or removed from that box, in addition to any areas added or removed
        from the clipped overflow rect.

        * platform/graphics/svg/SVGResourceMarker.cpp:
        * rendering/RenderBlock.cpp:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absoluteClippedOverflowRect): Renamed getAbsoluteRepaintRect() to
        * rendering/RenderBox.h:
        * rendering/RenderFlexibleBox.cpp:
        * rendering/RenderFlow.cpp:
        * rendering/RenderFlow.h:
        * rendering/RenderForeignObject.cpp:
        * rendering/RenderHTMLCanvas.cpp:
        * rendering/RenderImage.cpp:
        * rendering/RenderLayer.cpp:
        * rendering/RenderLayer.h:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderPath.cpp:
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGHiddenContainer.cpp:
        * rendering/RenderSVGHiddenContainer.h:
        * rendering/RenderSVGImage.cpp:
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGText.cpp:
        * rendering/RenderSVGText.h:
        * rendering/RenderTable.cpp:
        * rendering/RenderTableCell.cpp:
        * rendering/RenderTableCell.h:
        * rendering/RenderTableCol.cpp:
        * rendering/RenderTableCol.h:
        * rendering/RenderTableRow.cpp:
        * rendering/RenderTableRow.h:
        * rendering/RenderText.cpp:
        * rendering/RenderText.h:

2007-03-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - repaint tests and updated result for http://bugs.webkit.org/show_bug.cgi?id=12885
          REGRESSION (r19696): Incomplete background repaint

        * fast/repaint/bugzilla-6278-expected.checksum:
        * fast/repaint/bugzilla-6278-expected.png:
        * fast/repaint/content-into-overflow-expected.checksum: Added.
        * fast/repaint/content-into-overflow-expected.png: Added.
        * fast/repaint/content-into-overflow-expected.txt: Added.
        * fast/repaint/content-into-overflow.html: Added.
        * fast/repaint/overflow-into-content-expected.checksum: Added.
        * fast/repaint/overflow-into-content-expected.png: Added.
        * fast/repaint/overflow-into-content-expected.txt: Added.
        * fast/repaint/overflow-into-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-06 Ian Eng <ian.eng.webkit@gmail.com>
bdash [Wed, 7 Mar 2007 03:30:37 +0000 (03:30 +0000)]
2007-03-06  Ian Eng <ian.eng.webkit@gmail.com>

        Reviewed by Maciej.

        - Tests for http://bugs.webkit.org/show_bug.cgi?id=12720
        Bug 12720: Re-defining window.location.toString function keeps re-loading forever

        * fast/dom/Window/window-location-replace-functions-expected.txt: Added.
        * fast/dom/Window/window-location-replace-functions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-06 Ian Eng <ian.eng.webkit@gmail.com>
bdash [Wed, 7 Mar 2007 03:15:26 +0000 (03:15 +0000)]
2007-03-06  Ian Eng <ian.eng.webkit@gmail.com>

        Reviewed by Maciej.

        - fixed http://bugs.webkit.org/show_bug.cgi?id=12720
        Bug 12720: Re-defining window.location.toString function keeps re-loading forever

        * bindings/js/kjs_window.cpp:
        Disallow replacing functions in LocationTable, and return early without updating URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej Stachowiak.
ggaren [Wed, 7 Mar 2007 02:27:35 +0000 (02:27 +0000)]
    Reviewed by Maciej Stachowiak.

        2% speedup on super accurate JS iBench.

        (KJS::Collector::collect): Removed anti-optimization to call
        pthread_is_threaded_np() before calling pthread_main_np(). Almost all
        apps have more than one thread, so the extra call is actually worse.
        Interestingly, even the single-threaded testkjs shows a speed gain
        from removing the pthread_is_threaded_np() short-circuit. Not sure why.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
kmccullo [Wed, 7 Mar 2007 02:22:20 +0000 (02:22 +0000)]

        Reviewed by Darin.

        REGRESSION: Bloglines.com Feeds tab cannot expand folders in TOT
        - Now all class constructors implement implementsHasInstance.

        * fast/dom/dom-instanceof-expected.txt: Added.
        * fast/dom/dom-instanceof.html: Added.


        Reviewed by Darin.

        REGRESSION: Bloglines.com Feeds tab cannot expand folders in TOT
        - Now all class constructors implement implementsHasInstance.

        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Rob & Oliver.
zimmermann [Wed, 7 Mar 2007 00:27:46 +0000 (00:27 +0000)]
Reviewed by Rob & Oliver.

Preparations for the new SVG text engine.

Handle baseline-shift / kerning css values correctly.
Recognize missing svg presentation attribute "font-size-adjust".
Add all missing svg<->css property mappings in mapToEntry().

Doesn't affect any layout test (as these properties are not used w/o my text patch).
While I'm at it, unify the macro names (RS_ -> SVG_RS_) & cleanup style a bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Wed, 7 Mar 2007 00:11:50 +0000 (00:11 +0000)]

        Reviewed by kevin

        FCKeditor: Remove Format sometimes doesn't work
        Underline style is not removed from selection after performing Remove Format

        * editing/execCommand/4786404-1-expected.checksum: Added.
        * editing/execCommand/4786404-1-expected.png: Added.
        * editing/execCommand/4786404-1-expected.txt: Added.
        * editing/execCommand/4786404-1.html: Added.
        * editing/execCommand/4786404-2-expected.checksum: Added.
        * editing/execCommand/4786404-2-expected.png: Added.
        * editing/execCommand/4786404-2-expected.txt: Added.
        * editing/execCommand/4786404-2.html: Added.
        Demonstrate fixes:
        * editing/execCommand/4920488-expected.checksum:
        * editing/execCommand/4920488-expected.png:
        * editing/execCommand/4920488-expected.txt:
        * editing/execCommand/4920742-1-expected.checksum:
        * editing/execCommand/4920742-1-expected.png:
        * editing/execCommand/4920742-1-expected.txt:
        * editing/execCommand/remove-formatting-2-expected.checksum:
        * editing/execCommand/remove-formatting-2-expected.png:
        * editing/execCommand/remove-formatting-2-expected.txt:
        Ditto, also added a FIXME:
        * editing/execCommand/remove-formatting-expected.checksum:
        * editing/execCommand/remove-formatting-expected.png:
        * editing/execCommand/remove-formatting-expected.txt:
        * editing/execCommand/remove-formatting.html:


        Reviewed by kevin

        FCKeditor: Remove Format sometimes doesn't work
        Underline style is not removed from selection after performing Remove Format

        * editing/Editor.cpp:
        (WebCore::Editor::removeFormattingAndStyle): Re-wrote this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Oliver.
zimmermann [Tue, 6 Mar 2007 23:45:03 +0000 (23:45 +0000)]
Reviewed by Oliver.

Add new <use> layout tests. (forgot in last commit)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Oliver.
zimmermann [Tue, 6 Mar 2007 23:40:49 +0000 (23:40 +0000)]
Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12979
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12981
Guard against registering pending resources with empty id.
Be careful with calling recalcStyle() in SVGUseElement, when change is "Detach" we
have to use special code, as calling attach() on the shadow tree root element will crash,
because it has no (direct) parent node, only a shadow parent node element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
kdecker [Tue, 6 Mar 2007 22:38:17 +0000 (22:38 +0000)]
    Reviewed by Adele.

        Fixed: <rdar://problem/5041660> REGRESSION: <keygen> element broken, prevents users from signing up for Thawte email certs

        * bindings/objc/DOM.mm:
        (WebCore::createElementClassMap): Added <keygen> to the DOM bindings so it can be accessed from Objective-C.
        * css/html4.css: Apply the look of the <select> element to <keygen>.
        * html/HTMLElementFactory.cpp:
        (WebCore::keygenConstructor): Added.
        (WebCore::createFunctionMap): Added keygen.
        * html/HTMLSelectElement.cpp: Made const typeAheadTimeout variable static const.
        (WebCore::HTMLSelectElement::HTMLSelectElement):  Fix both HTMLSelectElement constructors to initialize the
         same number of member variables. The fact that some fields were not initialized could (and would) crash the
         keygen element when selecting different items. Also removed m_typedString(String()) from the constructor
         initialization because this is not needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Mitz.
zimmermann [Tue, 6 Mar 2007 21:48:12 +0000 (21:48 +0000)]
Reviewed by Mitz.
Remove an alert() which got accidently added in my last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin
sullivan [Tue, 6 Mar 2007 19:35:17 +0000 (19:35 +0000)]
    Reviewed by Darin

        Made WebAuthenticationHandler.h SPI so Safari can call it directly.

        * WebKit.exp:
        added .objc_class_name_WebPanelAuthenticationHandler
        * WebKit.xcodeproj/project.pbxproj:
        changed status of WebAuthenticationHandler.h from "project" to "private"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
kmccullo [Tue, 6 Mar 2007 19:29:24 +0000 (19:29 +0000)]
    Reviewed by Darin.

        - Rename a function to clarify its purpose.

        * WebView/WebView.mm:
        (+[WebView registerURLSchemeAsLocal:]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
kmccullo [Tue, 6 Mar 2007 19:28:46 +0000 (19:28 +0000)]
    Reviewed by Darin.

        - Rename a function to clarify its purpose.

        * WebCore.exp:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
aroben [Tue, 6 Mar 2007 10:27:05 +0000 (10:27 +0000)]
    Build fix.

        * WebCore.exp: Updated symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
aroben [Tue, 6 Mar 2007 09:57:06 +0000 (09:57 +0000)]
    Reviewed by Anders.

        Added a parameter to all StringTruncator methods to specify whether
        rounding hacks should be on or off.

        No layout test possible.

        * platform/StringTruncator.cpp:
        (WebCore::stringWidth): Added disableRoundingHacks parameter.
        (WebCore::truncateString): Ditto.
        (WebCore::StringTruncator::centerTruncate): Ditto.
        (WebCore::StringTruncator::rightTruncate): Ditto.
        (WebCore::StringTruncator::width): Ditto.
        * platform/StringTruncator.h: Ditto.
        * platform/mac/FileChooserMac.mm:
        (WebCore::FileChooser::basenameForWidth): Pass in false to
        centerTruncate so that the truncation matches the way the text will be

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
andersca [Tue, 6 Mar 2007 09:05:42 +0000 (09:05 +0000)]

        Reviewed by Maciej.

        REGRESSION: WebKit browser doesn't display image at http://www.metoffice.gov.uk/weather/satellite/index.html

        Add some tests where image elements have id _and_ name elements.

        * fast/dom/HTMLDocument/document-special-properties-expected.txt:
        * fast/dom/HTMLDocument/document-special-properties.html:


        Reviewed by Maciej.

        REGRESSION: WebKit browser doesn't display image at http://www.metoffice.gov.uk/weather/satellite/index.html

        It turns out WinIE does allow you to access images by their id as special document properties. However, this is only
        allowed when the element also has a name attribute. The value of the name attribute is ignored and can even be empty!

        * bindings/js/kjs_html.cpp:
        Return jsUndefined() if the collection is empty.

        * html/HTMLImageElement.cpp:
        * html/HTMLImageElement.h:
        Add the id attribute value to the extra named item map.

        * html/HTMLNameCollection.cpp:
        Check for images with name attributes that match, as well as elements with id attributes that match where
        the element also has a name attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Tue, 6 Mar 2007 08:37:36 +0000 (08:37 +0000)]

        Reviewed by Adam.

        WebCore part of patch to make it possible to have different user agents for different URLs.

        * bindings/js/kjs_navigator.cpp:
        * bindings/js/kjs_proxy.cpp:
        * loader/DocumentLoader.cpp:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:


        Reviewed by Adam.

        Update for WebCore changes.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
kmccullo [Tue, 6 Mar 2007 07:04:16 +0000 (07:04 +0000)]

        Reviewed by Mark and Dave H.

- rdar://problem/5038491
        An oversite of the security fix that prevented remote from loading local is that it
        prevents user style sheets when the site is remote.  This fixes that.

        * http/tests/security/local-user-CSS-from-remote-expected.txt: Added.
        * http/tests/security/local-user-CSS-from-remote.html: Added.


        Reviewed by Mark and Dave H.

        - rdar://problem/5038491
        An oversite of the security fix that prevented remote from loading local is that it
        prevents user style sheets when the site is remote.  This fixes that.

        * loader/Cache.cpp: Propogate and check user style sheet flag.
        * loader/Cache.h: Propogate user style sheet flag.
        * loader/CachedCSSStyleSheet.cpp: Propogate user style sheet flag.
        * loader/CachedCSSStyleSheet.h: Propogate user style sheet flag.
        * loader/DocLoader.cpp: Propogate user style sheet flag.
        * loader/SubresourceLoader.cpp: Propogate and check user style sheet flag.
        * loader/SubresourceLoader.h: Add check for user style sheet flag.
        * loader/loader.cpp: Propogate user style sheet flag.
        * loader/loader.h: Propogate user style sheet flag.


        Reviewed by Mark and Dave H.

        - rdar://problem/4922454
        - This fixes a security issue by making remote referrers not able to access local
        resources, unless they register their schemes to be treated as local. The result is
        that those schemes can access local resources and cannot be accessed by remote
        Because this behavior is new a link-on-or-after check is made to determine if the
        app should use the older, less safe, behavior.

        * DumpRenderTree/DumpRenderTree.m: Add ability to set user style sheet to DRT.
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (+[LayoutTestController webScriptNameForSelector:]):
        (-[LayoutTestController setUserStyleSheetLocation:]):
        (-[LayoutTestController setUserStyleSheetEnabled:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Darin.
zimmermann [Tue, 6 Mar 2007 01:35:17 +0000 (01:35 +0000)]
Reviewed by Darin.

Fix all (except one) known <use> bug. The remaining bug (12630) is not crucical at all.
Enable <use> again as default SVG feature, as discussed on webkit-dev.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12936 (Master bug used to track all current use problems.)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12926 (transform attribute not respected in nested <use> elements)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12267 (getElementById broken for <use>)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12916 (use instance in symbol definition does not work)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12917 (mouseout event does not occur after scaling use instance)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12838 (SVG <use> DOM broken for script)
Added test: svg/custom/use-nested-transform.svg
Added test: svg/custom/struct-use-09-b.svg (not yet official W3C-SVG-1.1 testcase)
Fixes test: svg/custom/use-elementInstance-event-target.svg (rectangle now turns green on first click)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John
beidson [Tue, 6 Mar 2007 01:11:18 +0000 (01:11 +0000)]
    Reviewed by John

        Fixes <rdar://problem/4974258>
        Adds some key null checking

        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLElement::implementsCall): Null check doc/frame
        * bindings/objc/DOMInternal.mm:
        (-[WebScriptObject _initializeScriptDOMNodeImp]): Null check doc/frame

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Darin.
zimmermann [Tue, 6 Mar 2007 00:05:29 +0000 (00:05 +0000)]
Reviewed by Darin.

Path::normalAngleAtLength() / Path::pointAtLength() don't work correctly.
pointAtLength() was not implemented, basically and normalAngleAtLength()
had a bug in the tangent slope calculation.

The normalAngleAtLength() stuff can only be tested with my local textPath support.
New LayoutTest: svg/custom/path-textPath-simulation.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-05 Darin Adler <darin@apple.com>
oliver [Mon, 5 Mar 2007 23:02:18 +0000 (23:02 +0000)]
2007-03-05  Darin Adler  <darin@apple.com>

        Reviewed by Oliver.

        Text encoding test case

        * fast/encoding/char-encoding-expected.txt: Added.
        * fast/encoding/char-encoding.html: Added.
        * fast/encoding/charset-names-expected.txt: Moved.
        * fast/encoding/charset-names.html: Moved.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Mon, 5 Mar 2007 20:39:41 +0000 (20:39 +0000)]
    Reviewed by Darin.

        Fix and import 4XPath test_core_functions.html test


        * xml/XPathExpression.cpp:
        (WebCore::XPathExpression::evaluate): Fully initialize the evaluation context.

        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunSubstring::doEvaluate): Fixed handling of edge cases.
        (WebCore::XPath::FunRound::round): Reimplemented to match the spec; exposed FunRound::round() to be used in
        other functions.

        * fast/xpath/4XPath/Core/test_core_functions-expected.txt: Added.
        * fast/xpath/4XPath/Core/test_core_functions.html: Added.
        The remaining failures with id() are caused by an XML DOM problem - ID attributes declared
        in an internal subset are not treated as such.

        * fast/xpath/4XPath/Core/test.js: Common data for XPath tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * plugins/get-url-with-blank-target-expected.txt:
andersca [Mon, 5 Mar 2007 20:29:11 +0000 (20:29 +0000)]
    * plugins/get-url-with-blank-target-expected.txt:
        Update test result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
andersca [Mon, 5 Mar 2007 19:31:02 +0000 (19:31 +0000)]

        Reviewed by Adam, Darin.

        In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object

        * plugins/get-url-with-blank-target-expected.txt: Added.
        * plugins/get-url-with-blank-target.html: Added.


        Reviewed by Adam, Darin.

        In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadPluginRequest:]):
        Handle the case where the web view returned from the delegate method is null. Also, send out an error notification
        in that case so we can catch it.


        Reviewed by Adam, Darin.

        In Mail, a crash occurs at WebCore::Frame::tree() when clicking on embedded flash object

        Add a "getURLNotify" method to the plugin object. This lets you pass a URL, a target and a callback function
        to be run when the URL has finished (or failed) loading.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin and Kevin D
sullivan [Mon, 5 Mar 2007 18:37:17 +0000 (18:37 +0000)]
    Reviewed by Darin and Kevin D

        - fixed <rdar://problem/5038087> Header and footer on printed page are too large after certain steps

        * WebView/WebView.mm:
        (-[WebView _adjustPrintingMarginsForHeaderAndFooter]):
        This method was modifying the margins in the NSPrintInfo object without any sort of check whether
        this had already been done. In some cases this can be called multiple times with the same
        NSPrintInfo, so now we stash information in the NSPrintInfo's dictionary such that we always
        start with a fresh copy of the original margins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove accidentally committed tests.
ap [Mon, 5 Mar 2007 18:25:34 +0000 (18:25 +0000)]
Remove accidentally committed tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Mon, 5 Mar 2007 17:36:24 +0000 (17:36 +0000)]
    Reviewed by Darin.

        XPath relative operations are implemented incorrectly

        * xml/XPathPredicate.cpp:
        Reimplemented relative equality operations to match the spec.

        * xml/XPathPredicate.h:
        Moved relative operations to EqTestOp.

        * xml/XPathGrammar.y:
        * xml/XPathParser.cpp:
        Adapted for the above changes.

        * fast/xpath/4XPath/Core/test_boolean_expr-expected.txt: Added.
        * fast/xpath/4XPath/Core/test_boolean_expr.html: Added.

        * fast/xpath/4XPath/Borrowed/cz_20030217-expected.txt: Added.
        * fast/xpath/4XPath/Borrowed/cz_20030217.html: Added.
        * fast/xpath/4XPath/Borrowed/kd_20010423-expected.txt: Added.
        * fast/xpath/4XPath/Borrowed/kd_20010423.html: Added.
        * fast/xpath/4XPath/Borrowed/od_20000608-expected.txt: Added.
        * fast/xpath/4XPath/Borrowed/od_20000608.html: Added.
        * fast/xpath/4XPath/Borrowed/resources/od_20000608.xml: Added.
        * fast/xpath/4XPath/Borrowed/rs_20010831-expected.txt: Added.
        * fast/xpath/4XPath/Borrowed/rs_20010831.html: Added.
        * fast/xpath/4XPath/Borrowed/sr_20021217-expected.txt: Added.
        * fast/xpath/4XPath/Borrowed/sr_20021217.html: Added.
        Added a bunch of XPath tests that already passed.

        * fast/xpath/4XPath/Borrowed/namespace-nodes-expected.txt: Added.
        * fast/xpath/4XPath/Borrowed/namespace-nodes.html: Added.
        * fast/xpath/namespace-nodes-expected.txt: Removed.
        * fast/xpath/namespace-nodes.html: Removed.
        Moved a previously imported 4XPath test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoPesky apostrophe.
bdash [Mon, 5 Mar 2007 09:41:06 +0000 (09:41 +0000)]
Pesky apostrophe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-05 Mark Rowe <mrowe@apple.com>
bdash [Mon, 5 Mar 2007 09:39:15 +0000 (09:39 +0000)]
2007-03-05  Mark Rowe  <mrowe@apple.com>

        Reviewed by Lars.

        Fix http://bugs.webkit.org/show_bug.cgi?id=12947
        Bug 12947: REGRESSION: ASSERTION FAILED: maxWidth >= 0 in StringTruncator.cpp:109 in WebCore::truncateString()

        Handle nil window correctly in toUserSpace and toDeviceSpace.  On Intel Mac's a message to nil that returns a
        float will return 0.0.  We use this as the divisor in calculating a scale factor, which results in NaN being
        introduced into our rect.

        * platform/mac/ScreenMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
rwlbuis [Mon, 5 Mar 2007 09:07:41 +0000 (09:07 +0000)]
    Reviewed by Darin.

        parts of the CSS classes in this simple SVG example are not applied

        Make sure the xml stylesheets are parsed in strict mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Mon, 5 Mar 2007 06:18:37 +0000 (06:18 +0000)]
    Reviewed by Darin.

        shouldBe() should support NaN

        * fast/js/resources/js-test-pre.js: Make shouldBe() succeed if both sides are NaN numbers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Mon, 5 Mar 2007 05:40:16 +0000 (05:40 +0000)]

        Reviewed by Darin.

        * fast/events/keydown-keypress-preventDefault-expected.txt: Added.
        * fast/events/keydown-keypress-preventDefault.html: Added.


        Reviewed by Darin.

        Change to dispatch the keypress event during the defaultEventHandler for keydown events.  This matches IE behavior.
        This is preparation for fixing event dispatch with input methods (http://bugs.webkit.org/show_bug.cgi?id=10871)

        Test: fast/events/keydown-keypress-preventDefault.html

        * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Call the defaultKeyboardEventHandler for keydown events.
        * page/EventHandler.cpp:
        (WebCore::eventTargetNodeForDocument): Return 0 instead of false since the return type in EventTargetNode.
        (WebCore::EventHandler::keyEvent): Removed dispatch of keypress event, since this is now done in the default event handler.
        (WebCore::EventHandler::defaultKeyboardEventHandler): For keydown events, create and dispatch a keypress event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Nikolas Zimmermann (yay!).
ap [Mon, 5 Mar 2007 05:34:10 +0000 (05:34 +0000)]
    Reviewed by Nikolas Zimmermann (yay!).

        4XPath tests crash on lang() function

        Covered by 4XPath tests, to be landed later.

        * platform/StringImpl.cpp:
        (WebCore::StringImpl::reverseFind): Do not crash with empty strings.
        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunLang::doEvaluate): Do not crash when an element has no
        attributes. Use a proper namespace for xml:lang (not sure where "xms" came from).
        Rewrote the algorithm for suffix removing to match the spec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ddkilzer [Mon, 5 Mar 2007 01:33:33 +0000 (01:33 +0000)]

        Reviewed by Nikolas Zimmermann.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12950
          Assertions.cpp should not #define macros that are already defined

        * wtf/Assertions.cpp: Don't #define WINVER and _WIN32_WINNT if they
        are already defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
andersca [Sun, 4 Mar 2007 23:30:51 +0000 (23:30 +0000)]

        Reviewed by Darin.

        REGRESSION: XMLHttpRequest.abort() does not stop loading (12915)

        * http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt: Added.
        * http/tests/xmlhttprequest/abort-should-cancel-load.html: Added.


        Reviewed by Darin.

        REGRESSION: XMLHttpRequest.abort() does not stop loading (12915)

        * loader/DocumentLoader.cpp:
        Save the value of m_loading since calling FrameLoader::stopLoading could set it to false.

        * loader/SubresourceLoader.cpp:
        * loader/SubresourceLoader.h:
        Get rid of didCancel now, it's not needed anymore.

        * xml/xmlhttprequest.cpp:
        Call cancel() instead of stopLoading(). Also, set m_aborted to true so the XMLHttpRequest object
        won't be dereferenced in didFail when aborting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago WebCore:
kjk [Sun, 4 Mar 2007 21:24:32 +0000 (21:24 +0000)]

        Reviewed by Nikolas Zimmermann.

        Move ScrollView stubs to ScrollViewGdk.cpp

        * platform/gdk/FrameGdk.h: remove comment that no longer makes sense
        * platform/gdk/ScrollViewGdk.cpp:
        * platform/gdk/TemporaryLinkStubs.cpp:


        Reviewed by Nikolas Zimmermann.

        Load a url given on a command line in a way that also
        works for local (file://) urls.

        * GdkLauncher/main.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Sun, 4 Mar 2007 15:47:21 +0000 (15:47 +0000)]

        Reviewed by Nikolas Zimmermann.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12951
          REGRESSION (r19949): LayoutTests/fast/xsl/xslt-processer.html fails

        Fixed spelling of "processer" to "processor" in file names.

        * fast/xsl/xslt-processer-expected.txt: Removed.
        * fast/xsl/xslt-processer.html: Removed.
        * fast/xsl/xslt-processor-expected.txt: Added. Results progressed after fixing
        Bugzilla Bug 12735 (<rdar://problem/4545040>).
        * fast/xsl/xslt-processor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
kmccullo [Sat, 3 Mar 2007 02:18:43 +0000 (02:18 +0000)]

        Reviewed by Geoff.

        - rdar://problem/4922454
        - This fixes a security issue by making remote referrers not able to access local
        resources, unless they register their schemes to be treated as local. The result is
        that those schemes can access local resources and cannot be accessed by remote
        Because this behavior is new a link-on-or-after check is made to determine if the
        app should use the older, less safe, behavior.

        * fast/loader/local-CSS-from-local-expected.txt: Added.
        * fast/loader/local-CSS-from-local.html: Added.
        * fast/loader/local-JavaScript-from-local-expected.txt: Added.
        * fast/loader/local-JavaScript-from-local.html: Added.
        * fast/loader/local-iFrame-source-from-local-expected.txt: Added.
        * fast/loader/local-iFrame-source-from-local.html: Added.
        * fast/loader/local-image-from-local-expected.txt: Added.
        * fast/loader/local-image-from-local.html: Added.
        * http/tests/security/local-CSS-from-remote-expected.txt: Added.
        * http/tests/security/local-CSS-from-remote.html: Added.
        * http/tests/security/local-JavaScript-from-remote-expected.txt: Added.
        * http/tests/security/local-JavaScript-from-remote.html: Added.
        * http/tests/security/local-iFrame-from-remote-expected.txt: Added.
        * http/tests/security/local-iFrame-from-remote.html: Added.
        * http/tests/security/local-image-from-remote-expected.txt: Added.
        * http/tests/security/local-image-from-remote.html: Added.
        * http/tests/security/resources/compass.jpg: Added.
        * http/tests/security/resources/cssStyle.css: Added.
        * http/tests/security/resources/localPage.html: Added.
        * http/tests/security/resources/localScript.js: Added.


        Reviewed by Geoff.

        - rdar://problem/4922454
        - This fixes a security issue by making remote referrers not able to access local
        resources, unless they register their schemes to be treated as local. The result is
        that those schemes can access local resources and cannot be accessed by remote
        Because this behavior is new a link-on-or-after check is made to determine if the
        app should use the older, less safe, behavior.

        * WebCore.exp: added exported functions
        * bindings/objc/DOM.mm: consolodated function to base class
        (-[DOMElement image]):
        (-[DOMElement _imageTIFFRepresentation]):
        * dom/Document.cpp: Cache the document's ability to load local resources.
        * dom/Document.h: Cache the docuent's ability to load local resources.
        * html/HTMLImageLoader.cpp: Moved functionality into base class.
        * html/HTMLLinkElement.cpp: Handles null returns correctly now.
        * html/HTMLTokenizer.cpp: Moved functionality into base class.
        * ksvg2/misc/SVGImageLoader.cpp: Moved functionality into base class.
        * loader/Cache.cpp: Checks if the cached resource can be loaded.
        * loader/CachedCSSStyleSheet.cpp: Moved functionality into base class.
        * loader/CachedImage.cpp: Moved functionality into base class.
        * loader/CachedImage.h: Moved functionality into base class.
        * loader/CachedResource.cpp: Cache if the CachedResource should be treated as local
        * loader/CachedResource.h: Moved functionality into base class.
        * loader/CachedScript.cpp: Moved functionality into base class.
        * loader/CachedScript.h: Moved functionality into base class.
        * loader/CachedXBLDocument.cpp: Moved functionality into base class.
        * loader/CachedXSLStyleSheet.cpp: Moved functionality into base class.
        * loader/FrameLoader.cpp: See comments for each function below.
        (WebCore::FrameLoader::loadSubframe): Use new canLoad.
        (WebCore::FrameLoader::restrictAccessToLocal): return value of linked-on-or-after check.
        (WebCore::FrameLoader::setRestrictAccessToLocal): set value for linked-on-or-after check.
        (WebCore::localSchemes): Return set of schemes that are to be treated as local.
        (WebCore::FrameLoader::loadPlugin): Use new canLoad.
        (WebCore::FrameLoader::canLoad): Now multiple functions that each do the same work but some can take advantage of the cached values, if they were computed previously.
        (WebCore::FrameLoader::shouldHideReferrer): Extracted out the logic to determine if the referrer should be hidden so it is only calculated when needed.
        (WebCore::FrameLoader::loadResourceSynchronously): No longer calls canLoad to get hideReferrer info.
        (WebCore::FrameLoader::registerSchemeAsLocal): Functionality to register a scheme to be treated as local.
        (WebCore::FrameLoader::treatURLAsLocal): Given a URL this function determines if it should be treated as local.
        * loader/FrameLoader.h: Declared functions for this security fix.  See above.
        * loader/MainResourceLoader.cpp: Optized order of bools to regain performance.
        * loader/SubresourceLoader.cpp: Now restricts remote from loading local resources.
        * page/EventHandler.cpp: Moved functionality into base class.
        * platform/KURL.cpp: KURLs need to check all the registered schemes now.
        * rendering/HitTestResult.cpp: Moved functionality into base class.
        * rendering/RenderImage.cpp: Moved functionality into base class.
        * rendering/RenderImage.h: Moved functionality into base class.
        * rendering/RenderListItem.cpp: Moved functionality into base class.
        * rendering/RenderListMarker.cpp: Moved functionality into base class.
        * xml/xmlhttprequest.cpp: Check doc's cached value instead of determining independently.


        Reviewed by Geoff.

        - rdar://problem/4922454
        - This fixes a security issue by making remote referrers not able to access local
        resources, unless they register their schemes to be treated as local. The result is
        that those schemes can access local resources and cannot be accessed by remote
        Because this behavior is new a link-on-or-after check is made to determine if the
        app should use the older, less safe, behavior.

        * Misc/WebKitVersionChecks.h: added linked-on-or-after check
        * Misc/WebNSAttributedStringExtras.mm: Moved functionalit into the base class.
        * Plugins/WebNetscapePluginStream.mm: uses new canLoad functions
        * Plugins/WebPluginContainerCheck.mm: uses new canLoad functions
        (-[WebPluginContainerCheck _isForbiddenFileLoad]):
        * WebView/WebView.mm: make linked-on-or-after check and cache value, exposes SPI
        for registering a scheme as local.
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        (+[WebView registerSchemeAsLocal:]):
        * WebView/WebViewPrivate.h: exposes SPI for registering a scheme as local.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Sat, 3 Mar 2007 01:46:44 +0000 (01:46 +0000)]

        Reviewed by kevin

        REGRESSION: Gmail Editor: Copied message text pastes at the wrong font size

        * editing/pasteboard/5028447-expected.checksum: Added.
        * editing/pasteboard/5028447-expected.png: Added.
        * editing/pasteboard/5028447-expected.txt: Added.
        * editing/pasteboard/5028447.html: Added.


        Reviewed by kevin

        REGRESSION: Gmail Editor: Copied message text pastes at the wrong font size

        * editing/markup.cpp:
        (WebCore::createMarkup): The style of the div that holds
        a fully selected body's styles didn't include styles inherited
        from the body's ancestors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Tweaked parse-malloc-history to work with new malloc_history output format.
ggaren [Sat, 3 Mar 2007 00:48:34 +0000 (00:48 +0000)]
    Tweaked parse-malloc-history to work with new malloc_history output format.

        * Scripts/parse-malloc-history:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Fri, 2 Mar 2007 23:02:49 +0000 (23:02 +0000)]

        Reviewed by harrison

        innerHTML does not HTML-escape text nodes inside PRE elements
        Pasting into Mail from Safari's view-source window renders the HTML

        * editing/pasteboard/5027857-expected.checksum: Added.
        * editing/pasteboard/5027857-expected.png: Added.
        * editing/pasteboard/5027857-expected.txt: Added.
        * editing/pasteboard/5027857.html: Added.


        Reviewed by harrison

        innerHTML does not HTML-escape text nodes inside PRE elements
        Pasting into Mail from Safari's view-source window renders the HTML

        * editing/HTMLInterchange.cpp:
        (WebCore::convertHTMLTextToInterchangeFormat): Send this function
        the node that the text comes from as a parameter.  It shouldn't convert
        '\n's to spaces/nbsps if the text is coming from text where newlines are
        * editing/HTMLInterchange.h:
        * editing/markup.cpp:
        (WebCore::startMarkup): Escape text inside the children of PREs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
weinig [Fri, 2 Mar 2007 21:10:59 +0000 (21:10 +0000)]

        Reviewed by Anders.

        Try to fix the Qt build.

        * platform/qt/TemporaryLinkStubs.cpp: Add stubs.


        Reviewed by Anders.

        Try to fix the Qt build

        * WebCoreSupport/DragClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-02 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 2 Mar 2007 21:06:33 +0000 (21:06 +0000)]
2007-03-02  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Anders.

        Add unsigned int hash traits (matches existing unsigned long version)

        * wtf/HashTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Suggested by Darin.
harrison [Fri, 2 Mar 2007 21:06:26 +0000 (21:06 +0000)]
    Suggested by Darin.

        A more efficient solution to rdar://4961431.

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityIsIgnored]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin M.
aroben [Fri, 2 Mar 2007 19:55:21 +0000 (19:55 +0000)]
    Reviewed by Kevin M.

        Try to fix the Qt build.

        * kjs/DateMath.cpp:
        (KJS::msToGregorianDateTime): Removed unnecessary "struct" keyword.
        * kjs/DateMath.h: Moved forward declarations to the top of the file
        before they are used.
        * kjs/date_object.cpp:
        (KJS::formatLocaleDate): Changed to take a const GregorianDateTime&
        since GregorianDateTime is Noncopyable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Fri, 2 Mar 2007 19:53:42 +0000 (19:53 +0000)]

        Reviewed by john

        Gmail Editor: Copied text pastes on a new line instead of current line

        * editing/pasteboard/5032095-expected.checksum: Added.
        * editing/pasteboard/5032095-expected.png: Added.
        * editing/pasteboard/5032095-expected.txt: Added.
        * editing/pasteboard/5032095.html: Added.


        Reviewed by john

        Gmail Editor: Copied text pastes on a new line instead of current line

        Start merge failed to occur because positionAtStartOfInsertedContent
        had a bug.

        * editing/ReplaceSelectionCommand.cpp:
        Was failing when inserting <span><div>foo/div></span>. Return the
        inserted content's first VisiblePosition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin McCullough.
darin [Fri, 2 Mar 2007 17:42:20 +0000 (17:42 +0000)]
    Reviewed by Kevin McCullough.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12867
          REGRESSION: BenchJS test 7 (dates) is 220% slower than in Safari 2.0.4

        * kjs/DateMath.h: Marked GregorianDateTime as noncopyable, since it has a non-trivial
        destructor and not the correspoding copy constructor or assignment operator.
        Changed the GregorianDateTime constructor to use member initialization syntax.
        Fixed the destructor to use the array delete operator, since timeZone is an array.

        * kjs/DateMath.cpp:
        (KJS::daysInYear): Changed to call isLeapYear so the rule is not repeated twice.
        (KJS::getUTCOffset): Added caching on PLATFORM(DARWIN), since we can rely on the
        notify_check function and "com.apple.system.timezone" to let us know when the
        offset has changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix glyph map crasher.
hyatt [Fri, 2 Mar 2007 09:39:34 +0000 (09:39 +0000)]
Fix glyph map crasher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
antti [Fri, 2 Mar 2007 08:22:45 +0000 (08:22 +0000)]
    Reviewed by Maciej.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12895
        REGRESSION: imagemap: pointer cursor is shown everywhere

        Image with imagemap should never itself be URLElement in hit test results.

        No layout test, cursor state can't be captured.

        * rendering/RenderLayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
antti [Fri, 2 Mar 2007 07:59:15 +0000 (07:59 +0000)]

        Reviewed by Maciej.

        HTTP layout test for http://bugs.webkit.org/show_bug.cgi?id=12690
        REGRESSION: can not log in to bank of america with TOT webkit

        also for

        * http/tests/misc/multiple-submit-expected.txt: Added.
        * http/tests/misc/multiple-submit.html: Added.
        * http/tests/misc/resources/post-echo-and-notify-done.cgi: Added.


        Reviewed by Maciej.

        Fix http://bugs.webkit.org/show_bug.cgi?id=12690
        REGRESSION: can not log in to bank of america with TOT webkit

        and http://bugs.webkit.org/show_bug.cgi?id=12604
        REGRESSION: After closing the "Would you like to save password" sheet, the form fails
        to submit automatically at http://www.mac.com/WebObjects/HomePage.woa

        and http://bugs.webkit.org/show_bug.cgi?id=12020
        REGRESSION: Flickr uploading broken

        Turn protection against multiple forms submission back on. This approach is buggy
        but it is way better than not having it at all. Not protecting against this
        breaks number of major sites.

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityPerformAction:]):
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * page/EventHandler.cpp:
        * page/Frame.cpp:
        * page/mac/EventHandlerMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
kmccullo [Fri, 2 Mar 2007 02:42:47 +0000 (02:42 +0000)]

        Reviewed by Adam.

        - Tests that the url of a document after an open is what it was before the open.

        * fast/loader/external-script-URL-location-expected.txt: Added.
        * fast/loader/external-script-URL-location.html: Added.
        * fast/loader/resources/external-script-URL-location.js: Added.


        Reviewed by Adam.

        - Added the test case: external-script-URL-location.html
        - Fix an issue where the url of a document is null after an open if the document
        has no parent.

        * dom/Document.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
andersca [Fri, 2 Mar 2007 02:17:04 +0000 (02:17 +0000)]
    Reviewed by Darin.

        REGRESSION: Reproducible crash at IMDb in WebCore::FrameLoader::stopLoadingSubframes

        In rare cases, we could end up calling checkLoadComplete twice for the same frame. This would cause the
        didFailProvisionalLoad delegate method to be called twice for the same frame, and also cause the provisional document loader
        to be reset to null when other code wasn't expecting it.

        This regressed in revision 10904 with the fix for <rdar://problem/4184719>. The fix is to only call stopLoading on the frame
        if either the document loader is loading, or the document is still being parsed. I've verified that the bug is still fixed and
        that no leaks occur.

        * loader/DocumentLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
kjk [Fri, 2 Mar 2007 01:58:32 +0000 (01:58 +0000)]
    Reviewed by Darin.

        Fix ARM crash due to accessing non-4-byte-aligned memory
        as 32-bit values.

        * platform/AtomicString.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by harrison
justing [Fri, 2 Mar 2007 01:57:12 +0000 (01:57 +0000)]
    Reviewed by harrison

        Integrate Mail and WebKit paste operations

        Provide subresources used to create the fragment as a

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
        Update the calls to the changed method.
        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
        Give the caller the subresources in the WebArchive and RTF cases.
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Fri, 2 Mar 2007 01:53:50 +0000 (01:53 +0000)]
    Reviewed by Darin.

        <rdar://problem/5033905> Have the DOM secondary thread check raise an exception by default

        * platform/mac/ThreadCheck.mm:
        Initialize threadViolationIsException to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin
beidson [Thu, 1 Mar 2007 22:00:22 +0000 (22:00 +0000)]
    Reviewed by Darin

        <rdar://problem/5030628> - Crash opening a new window with the
        "New windows open to the same page" pref set

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem): Set the m_subItems vector capacity correctly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
ap [Thu, 1 Mar 2007 17:08:24 +0000 (17:08 +0000)]
    Reviewed by Maciej.

        Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document

        Test: editing/pasteboard/createMarkup-assert.xml

        * editing/markup.cpp:
        (WebCore::createMarkup): Removed the assertion, because it's wrong in a non-HTML world.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver and Hyatt.
aroben [Thu, 1 Mar 2007 07:43:27 +0000 (07:43 +0000)]
    Reviewed by Oliver and Hyatt.

        Fix <rdar://problem/5024233> Crash while using Find on empty document

        No layout test possible, as this involves a null document.

        * dom/Range.cpp:
        (WebCore::rangeOfContents): Added an ASSERT.
        * page/Frame.cpp:
        (WebCore::Frame::findString): Added a null-check for document().
        (WebCore::Frame::markAllMatchesForText): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-02-28 Oliver Hunt <oliver@apple.com>
oliver [Thu, 1 Mar 2007 03:25:29 +0000 (03:25 +0000)]
2007-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej.

        Fixes <rdar://problem/5012009>

        When looking for a requested resource we should also check
        the set of manually added subresources if WebCore can't find it.

        * WebView/WebDataSource.mm:
        (-[WebDataSource subresourceForURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim H.
thatcher [Thu, 1 Mar 2007 01:30:53 +0000 (01:30 +0000)]
    Reviewed by Tim H.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12887
        Bug#12887: [Drosera] Add ability to close loaded files

        * Drosera/DebuggerDocument.h:
        * Drosera/DebuggerDocument.m:
        (-[DebuggerDocument closeCurrentFile:]): Adds delegation to call a JS script to close files
        * Drosera/Drosera.xcodeproj/project.pbxproj:
        * Drosera/English.lproj/MainMenu.nib/classes.nib:
        * Drosera/English.lproj/MainMenu.nib/info.nib:
        * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Adds Close Current File menu item
        * Drosera/debugger.html: Changed "no files loaded" to "<No files loaded>" to match Xcode style
        * Drosera/debugger.js: Adds implementation of closeFile() to unload currently loaded file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Not reviewed - simple gdk build fix.
kjk [Thu, 1 Mar 2007 00:47:24 +0000 (00:47 +0000)]
    Not reviewed - simple gdk build fix.

        Add stubs for newly introduced localized strings.

        * platform/gdk/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
beidson [Thu, 1 Mar 2007 00:01:57 +0000 (00:01 +0000)]

        Reviewed by Beth

        Move the Thread Safety Check functions into their own header for export to WebKit

        * WebCore.exp: Export the function
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/scripts/CodeGeneratorObjC.pm: Include the new header
        * platform/Logging.h: Move stuff to ThreadCheck.h
        * platform/ThreadCheck.h: Added.
        * platform/mac/LoggingMac.mm: Move stuff to ThreadCheck.mm
        * platform/mac/ThreadCheck.mm: Added.


        Reviewed by Beth

        Start using the Thread Safety Check implemented in WebCore for the DOM bindings in the rest of
        the WebKit API instead of the ASSERT_MAIN_THREAD() hack

        * History/WebBackForwardList.mm:
        (-[WebBackForwardList initWithWebCoreBackForwardList:]):
        (-[WebBackForwardList init]):
        (-[WebBackForwardList dealloc]):
        (-[WebBackForwardList finalize]):
        * History/WebHistoryItem.mm:
        (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
        (-[WebHistoryItem dealloc]):
        (-[WebHistoryItem finalize]):
        (-[WebHistoryItem copyWithZone:]):
        (-[WebHistoryItem initWithWebCoreHistoryItem:]):
        * Misc/WebIconDatabase.mm:
        (-[WebIconDatabase init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady.
bdakin [Wed, 28 Feb 2007 23:46:58 +0000 (23:46 +0000)]
    Reviewed by Brady.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12923 REGRESSION:
        Assertion failure copying standalone image

        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeImage): Use the CachedImage as the
        resource. This makes more sense anyway. There is no need to null-
        check the renderer or the CachedImage since we return early if
        there is no Image* and the HitTestResult::image() function checks
        for these things.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Wed, 28 Feb 2007 23:08:47 +0000 (23:08 +0000)]

        Reviewed by Beth.

        Fix for <rdar://problem/4887423> REGRESSION: search results popup menu strings are not localized
        and <rdar://problem/3517227> accessibility-related strings in WebCore are not localized

        Use localized strings from WebKit instead of hard coded strings.

        * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject roleDescription]):
        * page/mac/WebCoreViewFactory.h:
        * platform/LocalizedStrings.h:
        * platform/mac/LocalizedStringsMac.mm:
        * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::itemText):


        Reviewed by Beth.

        Fix for <rdar://problem/4887423> REGRESSION: search results popup menu strings are not localized
        and <rdar://problem/3517227> accessibility-related strings in WebCore are not localized

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory searchMenuNoRecentSearchesText]):
        (-[WebViewFactory searchMenuRecentSearchesText]):
        (-[WebViewFactory searchMenuClearRecentSearchesText]):
        (-[WebViewFactory AXWebAreaText]):
        (-[WebViewFactory AXLinkText]):
        (-[WebViewFactory AXListMarkerText]):
        (-[WebViewFactory AXImageMapText]):
        (-[WebViewFactory AXHeadingText]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Bradeee Eidson.
ggaren [Wed, 28 Feb 2007 19:56:47 +0000 (19:56 +0000)]
    Reviewed by Bradeee Eidson.

        Disabling this test for now because it fails on the buildbot but not on
        my Intel or PPC machines. I've filed http://bugs.webkit.org/show_bug.cgi?id=12930
        to track this issue.

        * fast/leaks/003.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
antti [Wed, 28 Feb 2007 15:46:40 +0000 (15:46 +0000)]

        Reviewed by Maciej.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12911
        GoogleDocs: Ordered lists don't update immediately when start attribute changed

        * fast/lists/ol-start-dynamic-expected.checksum: Added.
        * fast/lists/ol-start-dynamic-expected.png: Added.
        * fast/lists/ol-start-dynamic-expected.txt: Added.
        * fast/lists/ol-start-dynamic.html: Added.


        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12911
        GoogleDocs: Ordered lists don't update immediately when start attribute changed

        Update list marker value when start attribute changes.

        * html/HTMLOListElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Maciej.
zimmermann [Wed, 28 Feb 2007 12:29:22 +0000 (12:29 +0000)]
Reviewed by Maciej.

Corrected the use of the new ENABLE() macros in some ksvg2/svg files.
Add new build-webkit flags "--(no-)xpath" / "--(no-)xslt", to be able
to switch off build features easily. Also add "--(no-)svg-experimental-features"
flag, to be able to test filters/animations/use/foreignObject easily.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-02-28 Mark Rowe <mrowe@apple.com>
bdash [Wed, 28 Feb 2007 09:00:23 +0000 (09:00 +0000)]
2007-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        <rdar://problem/5028473> WebKit allocates a huge number of NSCalendarDates while loading history file

        * History/WebHistory.mm:
        (-[WebHistoryPrivate insertItem:atDateIndex:]): Use lastVisitedTimeInterval rather than _lastVisitedDate to avoid allocating NSCalendarDates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
rwlbuis [Wed, 28 Feb 2007 08:29:50 +0000 (08:29 +0000)]
    Reviewed by Maciej.

        Any SVG element will create renderers even when children of HTML elements

        Allow creation of svg renderers only when parent is SVG, except for
        the <svg> element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
rwlbuis [Wed, 28 Feb 2007 07:55:31 +0000 (07:55 +0000)]
    Reviewed by Maciej.

        Markers do not render in webkit when it misses markerWidth or markerHeight attribute

        Set defaults for markerWidth/markerHeight so markers that do not specify them render.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Extending the timeout on this test to see if it fixes the buildbot failure.
ggaren [Wed, 28 Feb 2007 05:33:12 +0000 (05:33 +0000)]
    Extending the timeout on this test to see if it fixes the buildbot failure.
        (I don't get a failure locally.)

        * fast/leaks/003.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * loader/ResourceLoader.cpp:
andersca [Wed, 28 Feb 2007 01:16:59 +0000 (01:16 +0000)]
    * loader/ResourceLoader.cpp:
        Remove comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Wed, 28 Feb 2007 01:08:25 +0000 (01:08 +0000)]

        Reviewed by oliver

        REGRESSION: Images inserted with align left/right are lost

        * editing/inserting/12882-expected.checksum: Added.
        * editing/inserting/12882-expected.png: Added.
        * editing/inserting/12882-expected.txt: Added.
        * editing/inserting/12882.html: Added.


        Reviewed by oliver

        REGRESSION: Images inserted with align left/right are lost

        * editing/ReplaceSelectionCommand.cpp:
        Don't attempt to merge to or from a position before
        or after a block because it will be a no-op and
        lead to infinite recursion.
        In this case it instead resulted in content loss because
        of bugs in start/endOfParagraph (5027702).
        * editing/visible_units.cpp: Added two FIXMEs for
        the problems with start/endOfParagraph.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
andersca [Wed, 28 Feb 2007 00:38:00 +0000 (00:38 +0000)]
    Reviewed by Geoff.

        Make resource load delegate methods pass the right document loader.

        * loader/FrameLoader.cpp:
        Use the resource loader's document loader instead of the active one.

        * loader/MainResourceLoader.cpp:
        Make it so we send the frame load delegate method before the resource load delegate method.
        This was a regression from 2.0 and was caused by the fix to rdar://problem/4609195. Because the way the loader
        now works, both delegate methods will be called.

        * loader/ResourceLoader.cpp:
        * loader/ResourceLoader.h:
        Add document loader pointer to ResourceLoader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19902 268f45cc-cd09-0410-ab3c-d52691b4dbfc