WebKit-https.git
10 years agoiframe and frameset scaling is broken
fsamuel@chromium.org [Thu, 18 Aug 2011 07:23:11 +0000 (07:23 +0000)]
iframe and frameset scaling is broken
https://bugs.webkit.org/show_bug.cgi?id=57785

Source/WebCore:

Reviewed by Simon Fraser.

Fixed two iframe and frameset scaling bugs:
  #1 iframes and frameset backgrounds and scroll areas are doubly scaled when they are styled with -webkit-transform.
  #2 frameset does not respect -webkit-transform-origin when scaled

Tests: fast/frames/frame-set-scaling-3d.html
       fast/frames/frame-set-scaling-centered.html
       fast/frames/frame-set-scaling-rotate.html
       fast/frames/frame-set-scaling-skew.html
       fast/frames/frame-set-scaling.html
       fast/frames/iframe-scaling-with-scroll.html

* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
Update the FrameSet's layer transform after we've computed size to correctly account for the transform origin.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::childrenClipRect):
The dirty rect should be the document's unscaled size.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Don't scale the FrameView rect here. Scaling is done within the FrameView.

LayoutTests:

Added tests to verify that framesets and iframes are scaled and positioned correctly.

Reviewed by Simon Fraser.

* fast/frames/frame-set-scaling-3d-expected.png: Added.
* fast/frames/frame-set-scaling-3d-expected.txt: Added.
* fast/frames/frame-set-scaling-3d.html: Added.
* fast/frames/frame-set-scaling-centered-expected.png: Added.
* fast/frames/frame-set-scaling-centered-expected.txt: Added.
* fast/frames/frame-set-scaling-centered.html: Added.
* fast/frames/frame-set-scaling-expected.png: Added.
* fast/frames/frame-set-scaling-expected.txt: Added.
* fast/frames/frame-set-scaling-rotate-expected.png: Added.
* fast/frames/frame-set-scaling-rotate-expected.txt: Added.
* fast/frames/frame-set-scaling-rotate.html: Added.
* fast/frames/frame-set-scaling-skew-expected.png: Added.
* fast/frames/frame-set-scaling-skew-expected.txt: Added.
* fast/frames/frame-set-scaling-skew.html: Added.
* fast/frames/frame-set-scaling.html: Added.
* fast/frames/iframe-scaling-with-scroll.html: Added.
* platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
* platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
* platform/mac/fast/frames/iframe-scaling-with-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkit-patch pretty-diff should be shown in main help
abarth@webkit.org [Thu, 18 Aug 2011 07:21:37 +0000 (07:21 +0000)]
webkit-patch pretty-diff should be shown in main help
https://bugs.webkit.org/show_bug.cgi?id=66404

Reviewed by Dimitri Glazkov.

As requested by dglazkov.

* Scripts/webkitpy/tool/commands/prettydiff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed buildfix after r93268.
ossy@webkit.org [Thu, 18 Aug 2011 06:58:40 +0000 (06:58 +0000)]
Unreviewed buildfix after r93268.

* dom/Document.cpp:
(WebCore::disableRangeMutation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch RenderBox to to new layout types
eae@chromium.org [Thu, 18 Aug 2011 06:37:30 +0000 (06:37 +0000)]
Switch RenderBox to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66156

Reviewed by Eric Seidel.

Convert RenderBox to new layout abstraction as a part of the ongoing
conversion work.

No new tests as no new functionality.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::absoluteRects):
(WebCore::RenderBox::absoluteContentBox):
(WebCore::RenderBox::absoluteContentQuad):
(WebCore::RenderBox::outlineBoundsForRepaint):
(WebCore::RenderBox::reflectionBox):
(WebCore::RenderBox::reflectedRect):
(WebCore::RenderBox::verticalScrollbarWidth):
(WebCore::RenderBox::horizontalScrollbarHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
(WebCore::RenderBox::maskClipRect):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::overflowClipRect):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::positionLineBox):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::computeBlockStaticDistance):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::lineHeight):
(WebCore::RenderBox::baselinePosition):
(WebCore::RenderBox::logicalVisualOverflowRectForPropagation):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::logicalLayoutOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::locationOffsetIncludingFlipping):
* rendering/RenderBox.h:
(WebCore::RenderBox::borderFitAdjust):
(WebCore::RenderBox::intrinsicSize):
(WebCore::RenderBox::intrinsicLogicalWidth):
(WebCore::RenderBox::intrinsicLogicalHeight):
(WebCore::RenderBox::scrollbarLogicalHeight):
(WebCore::RenderBox::controlClipRect):
(WebCore::RenderBox::firstLineBoxBaseline):
(WebCore::RenderBox::lastLineBoxBaseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening
reni@webkit.org [Thu, 18 Aug 2011 06:34:55 +0000 (06:34 +0000)]
[Qt] Unreviewed gardening

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2011-08-17

* platform/qt/Skipped: Skip new failures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=66400
dslomov@google.com [Thu, 18 Aug 2011 04:47:16 +0000 (04:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66400
Fix TestWebKitAPI build on Mac OS.

Reviewed by David Levin.

* TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReduce usages of String::createUninitialized
sullivan@chromium.org [Thu, 18 Aug 2011 04:22:59 +0000 (04:22 +0000)]
Reduce usages of String::createUninitialized
https://bugs.webkit.org/show_bug.cgi?id=66399

Constructs Strings with StringBuilder instead of calling createUninitialized.

Reviewed by Adam Barth.

No new tests; no functional change.

* dom/StyleElement.cpp:
(WebCore::StyleElement::process):
* dom/Text.cpp:
(WebCore::Text::wholeText):
* html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::sourceForToken):
* platform/graphics/Font.cpp:
(WebCore::Font::normalizeSpaces):
* platform/text/TextCodecUserDefined.cpp:
(WebCore::TextCodecUserDefined::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch FrameView to to new layout types
eae@chromium.org [Thu, 18 Aug 2011 04:06:04 +0000 (04:06 +0000)]
Switch FrameView to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66147

Reviewed by Eric Seidel.

Convert Frame & FrameView to new layout abstraction as a part of the
ongoing conversion work.

No new tests, no new functionality.

* page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):
(WebCore::Frame::rangeForPoint):
(WebCore::Frame::setPageAndTextZoomFactors):
(WebCore::Frame::scalePage):
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::FrameView::create):
(WebCore::FrameView::reset):
(WebCore::FrameView::init):
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::setMarginWidth):
(WebCore::FrameView::setMarginHeight):
(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):
(WebCore::FrameView::scrollOffsetForFixedPosition):
(WebCore::FrameView::currentMousePosition):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::windowClipRectForLayer):
(WebCore::FrameView::scrollTo):
(WebCore::FrameView::invalidateScrollbarRect):
(WebCore::FrameView::getTickmarks):
(WebCore::FrameView::windowResizerRect):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::paintOverhangAreas):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
* page/FrameView.h:
(WebCore::FrameView::marginWidth):
(WebCore::FrameView::marginHeight):
* page/mac/FrameMac.mm:
(WebCore::Frame::snapshotDragImage):
(WebCore::Frame::nodeImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch html/* to to new layout types
eae@chromium.org [Thu, 18 Aug 2011 03:38:05 +0000 (03:38 +0000)]
Switch html/* to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66347

Reviewed by Eric Seidel.

Convert HTML* and shadow element to new layout abstraction as a part of
the ongoing conversion work.

No new tests, no new functionality.

* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::invalidateCachedRegion):
(WebCore::HTMLAreaElement::mapMouseEvent):
(WebCore::HTMLAreaElement::computePath):
(WebCore::HTMLAreaElement::computeRect):
(WebCore::HTMLAreaElement::getRegion):
* html/HTMLAreaElement.h:
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
* html/HTMLCanvasElement.h:
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::mapMouseEvent):
* html/HTMLMapElement.h:
* html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::finish):
(WebCore::ImageDocument::scale):
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::imageFitsInWindow):
* html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::size):
(WebCore::CanvasRenderingContext2D::drawImage):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::startDrag):
(WebCore::MediaControlPanelElement::continueDrag):
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::defaultEventHandler):
* html/shadow/MediaControlElements.h:
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::dragFrom):
(WebCore::SliderThumbElement::setPositionFromPoint):
* html/shadow/SliderThumbElement.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange references to leveldb.gyp to leveldatabase.gyp as part of the
commit-queue@webkit.org [Thu, 18 Aug 2011 03:24:58 +0000 (03:24 +0000)]
Change references to leveldb.gyp to leveldatabase.gyp as part of the
leveldb refactoring going on in chromium: crbug.com/89378
https://bugs.webkit.org/show_bug.cgi?id=66332

Patch by David Grogan <dgrogan@chromium.org> on 2011-08-17
Reviewed by Tony Gentilcore.

Tests: new-run-webkit-tests --debug --chromium --no-retry-failures --build-directory=llvm storage/indexeddb

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=66379
commit-queue@webkit.org [Thu, 18 Aug 2011 02:56:13 +0000 (02:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66379
implements load32WithCompactAddressOffsetPatch function
and fixes store32 and moveWithPatch functions for SH4 platforms.

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-08-17
Reviewed by Gavin Barraclough.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::rshift32):
(JSC::MacroAssemblerSH4::store32):
(JSC::MacroAssemblerSH4::load32WithCompactAddressOffsetPatch):
(JSC::MacroAssemblerSH4::moveWithPatch):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::movlMemRegCompact):
(JSC::SH4Assembler::readPointer):
(JSC::SH4Assembler::repatchCompact):
* jit/JIT.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement proper handling of focus/blur events in regard to shadow DOM boundaries.
hayato@chromium.org [Thu, 18 Aug 2011 02:41:10 +0000 (02:41 +0000)]
Implement proper handling of focus/blur events in regard to shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=61421

Reviewed by Dimitri Glazkov.

Introduces FocusEventDispatchMediator/BlurEventDispatchMediator so
that focus/blue events are stopped at the lowest common shadow boundary.

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::setFocusedNode):
* dom/Event.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
* dom/Event.h:
* dom/Node.cpp:
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):
* dom/Node.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchBlurEvent):
* html/HTMLFormControlElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::dispatchFocusEvent):
(WebCore::HTMLSelectElement::dispatchBlurEvent):
* html/HTMLSelectElement.h:
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
(WebCore::HTMLTextFormControlElement::dispatchBlurEvent):
* html/HTMLTextFormControlElement.h:
* page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):

LayoutTests:

* fast/dom/shadow/shadow-boundary-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCanvas fill and fillRect with SourceIn, DestinationIn, SourceOut, DestinationAtop...
commit-queue@webkit.org [Thu, 18 Aug 2011 02:14:14 +0000 (02:14 +0000)]
Canvas fill and fillRect with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
https://bugs.webkit.org/show_bug.cgi?id=66036

Source/WebCore:

These modes cannot be passed straight through to the underlying graphics context as the graphics context
and the HTML5 canvas spec have different interpretations to them. In the graphics context, the compositing
modes are applied just over the area being filled. In the HTML5 spec, the compositing modes are applied over
the entire canvas.

The SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy modes all need some kind of extra action
to just performing the composited fill on the canvas, as they need t he canvas to be cleared outside of the
area being filled.

Previous to this change the Copy mode did not do this clearing at all. The other modes did but if the
transformed path being filled contained anti-aliasing at its edges artifacts were introduced.

With this change, Copy now does a complete erase of the canvas before performing a fill as per normal.
The other modes use a temporary buffer just big enough for the transformed path (in device coordinates).
The fill is first done there in SourceOver mode. Then this is drawn into the canvas context using the
appropriate mode, with any areas outside the draw area being cleared.

Patch by Ben Wells <benwells@chromium.org> on 2011-08-17
Reviewed by James Robinson.

Test: fast/canvas/canvas-composite-transformclip.html

* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::transformAreaToDevice):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):
* html/canvas/CanvasRenderingContext2D.h:
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-08-17
Reviewed by James Robinson.

* fast/canvas/canvas-composite-alpha.html:
* fast/canvas/canvas-composite-transformclip-expected.txt: Added.
* fast/canvas/canvas-composite-transformclip.html: Added.
* platform/chromium-linux/fast/canvas/canvas-composite-expected.png:
* platform/chromium-linux/fast/canvas/canvas-composite-transformclip-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/canvas/canvas-composite-expected.png:
* platform/mac/fast/canvas/canvas-composite-transformclip-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch inspector to to new layout types
eae@chromium.org [Thu, 18 Aug 2011 02:00:04 +0000 (02:00 +0000)]
Switch inspector to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66358

Reviewed by Eric Seidel.

Convert inspector code to new layout abstraction as a part of the ongoing
conversion work.

No new tests, no new functionality.

* inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::drawNodeHighlight):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willPaintImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willPaint):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willPaint):
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createPaintData):
* inspector/TimelineRecordFactory.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch Editing code to new layout types
leviw@chromium.org [Thu, 18 Aug 2011 01:31:30 +0000 (01:31 +0000)]
Switch Editing code to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66355

Reviewed by Eric Seidel.

Converting remaining editing code to the LayoutUnit abstraction.

No new tests, no change in functionality.

* editing/Editor.cpp:
(WebCore::Editor::rangeForPoint):
(WebCore::Editor::insideVisibleArea):
(WebCore::Editor::countMatchesForText):
* editing/Editor.h:
* editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch Accessibility code to new layout types
leviw@chromium.org [Thu, 18 Aug 2011 01:18:55 +0000 (01:18 +0000)]
Switch Accessibility code to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66348

Reviewed by Eric Seidel.

Converting remaining Accessibility code to the LayoutUnit abstraction.

No new tests, no change in functionality

* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::elementRect):
* accessibility/AccessibilityImageMapLink.h:
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::elementAccessibilityHitTest):
* accessibility/AccessibilityListBox.h:
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::elementRect):
* accessibility/AccessibilityListBoxOption.h:
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::elementRect):
* accessibility/AccessibilityMenuListOption.h:
(WebCore::AccessibilityMenuListOption::size):
* accessibility/AccessibilityMenuListPopup.h:
(WebCore::AccessibilityMenuListPopup::elementRect):
(WebCore::AccessibilityMenuListPopup::size):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::clickPoint):
(WebCore::AccessibilityObject::orientation):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::accessibilityHitTest):
(WebCore::AccessibilityObject::boundingBoxRect):
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityObject::doAXBoundsForRange):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isOffScreen):
(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
(WebCore::AccessibilityRenderObject::elementRect):
(WebCore::AccessibilityRenderObject::size):
(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::doAXBoundsForRange):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::elementRect):
* accessibility/AccessibilityScrollView.h:
* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::elementRect):
* accessibility/AccessibilityScrollbar.h:
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect):
(WebCore::AccessibilitySliderThumb::size):
* accessibility/AccessibilitySlider.h:
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::elementRect):
(WebCore::AccessibilityTableColumn::size):
* accessibility/AccessibilityTableColumn.h:
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::elementRect):
(WebCore::AccessibilityTableHeaderContainer::size):
* accessibility/AccessibilityTableHeaderContainer.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper position]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityShowContextMenu]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdating the forms survey to include various element sizes.
jonlee@apple.com [Thu, 18 Aug 2011 01:02:16 +0000 (01:02 +0000)]
Updating the forms survey to include various element sizes.

* projects/forms/survey.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch focus handling to to new layout types
eae@chromium.org [Thu, 18 Aug 2011 00:49:01 +0000 (00:49 +0000)]
Switch focus handling to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66331

Reviewed by Eric Seidel.

Convert FocusController and SpatialNavigation to new layout abstraction
as a part of the ongoing conversion work.

No new tests, no new functionality.

* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):
* page/FocusController.h:
* page/SpatialNavigation.cpp:
(WebCore::alignmentForRects):
(WebCore::start):
(WebCore::middle):
(WebCore::end):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsPartiallyAligned):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::below):
(WebCore::rightOf):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::deflateIfOverlapped):
(WebCore::canScrollInDirection):
(WebCore::rectToAbsoluteCoordinates):
(WebCore::nodeRectInAbsoluteCoordinates):
(WebCore::frameRectInAbsoluteCoordinates):
(WebCore::entryAndExitPointsForDirection):
(WebCore::distanceDataForNode):
(WebCore::canBeScrolledIntoView):
(WebCore::virtualRectForDirection):
(WebCore::virtualRectForAreaElementAndDirection):
* page/SpatialNavigation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch Document, DocumentMarker, Clipboard, and Range to new layout types
leviw@chromium.org [Thu, 18 Aug 2011 00:36:48 +0000 (00:36 +0000)]
Switch Document, DocumentMarker, Clipboard, and Range to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66330

Reviewed by Eric Seidel.

Converting the remaining DOM classes to use the LayoutUnit abstraction.

No new tests, no new behavior.

* dom/Clipboard.h:
(WebCore::Clipboard::dragLocation):
* dom/Document.cpp:
(WebCore::Document::nodesFromRect):
(WebCore::nodeFromPoint):
(WebCore::Document::caretRangeFromPoint):
(WebCore::Document::prepareMouseEvent):
* dom/Document.h:
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
* dom/DocumentMarkerController.h:
* dom/Range.cpp:
(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):
* dom/RenderedDocumentMarker.h:
(WebCore::RenderedDocumentMarker::contains):
(WebCore::RenderedDocumentMarker::setRenderedRect):
(WebCore::RenderedDocumentMarker::renderedRect):
(WebCore::RenderedDocumentMarker::invalidMarkerRect):
(WebCore::RenderedDocumentMarker::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Removed an unused setting.
mitz@apple.com [Thu, 18 Aug 2011 00:17:19 +0000 (00:17 +0000)]
Source/WebCore: Removed an unused setting.

Reviewed by Anders Carlsson.

* WebCore.exp.in:
* page/Settings.cpp:
(WebCore::Settings::Settings): Removed initializer for m_needsTigerMailQuirks.
* page/Settings.h: Removed accessors.

Source/WebKit/mac: Removed some code that is not needed when building for Leopard or later.

Reviewed by Anders Carlsson.

* WebCoreSupport/WebContextMenuClient.mm:
(fixMenusToSendToOldClients): Removed check for Tiger Mail.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::objectContentType):
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView _preferencesChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove towards supporting user controlled prototypes on CanvasPixelArray
oliver@apple.com [Thu, 18 Aug 2011 00:08:26 +0000 (00:08 +0000)]
Move towards supporting user controlled prototypes on CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=66429

Reviewed by Gavin Barraclough.

Start using a per-global object structure for canvas pixel array.

* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSupport cast from CSSPrimitiveValue to unsigned, and use in appropriate places in...
macpherson@chromium.org [Thu, 18 Aug 2011 00:06:58 +0000 (00:06 +0000)]
Support cast from CSSPrimitiveValue to unsigned, and use in appropriate places in CSSStyleSelector::applyProperty
https://bugs.webkit.org/show_bug.cgi?id=66281

Reviewed by Eric Seidel.

No new tests - refactoring only.

The return if type!=CSS_NUMBER case becomes an ASSERT because it is unreachable unless there is an error in the parser.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from unsigned to CSSPrimitiveValue
(WebCore::CSSPrimitiveValue::operator unsigned):
Support cast from CSSPrimitiveValue to unsigned
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for CSSPropertyWebkitBoxFlex,
CSSPropertyWebkitBoxFlexGroup and CSSPropertyWebkitBoxOrdinalGroup properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoScrollAnimatorNone: Remove unused field
commit-queue@webkit.org [Wed, 17 Aug 2011 23:55:37 +0000 (23:55 +0000)]
ScrollAnimatorNone: Remove unused field
https://bugs.webkit.org/show_bug.cgi?id=66312

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-17
Reviewed by Adam Barth.

Source/WebCore:

No functional change; no test needed.

* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::scroll):
* platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

* tests/ScrollAnimatorNoneTest.cpp:
(ScrollAnimatorNoneTest::updateDataFromParameters):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEliminate the WebCGFloat compatibility definition that was needed for Tiger.
mitz@apple.com [Wed, 17 Aug 2011 23:37:03 +0000 (23:37 +0000)]
Eliminate the WebCGFloat compatibility definition that was needed for Tiger.

Rubber-stamped by Anders Carlsson.

* WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWork-in-progress on Soft link against AVFoundationCF and CoreMedia
jeffm@apple.com [Wed, 17 Aug 2011 23:32:34 +0000 (23:32 +0000)]
Work-in-progress on Soft link against AVFoundationCF and CoreMedia
https://bugs.webkit.org/show_bug.cgi?id=65725

Don't bother with SOFT_LINK_LIBRARY(libdispatch), we're going to continue to statically link to it since
the DLL will have already been loaded by other parts of AAS and is guaranteed to be available if AVFoundation
is enabled.

Reviewed by Anders Carlsson.

No new tests; no functional change.

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Removed SOFT_LINK_DEBUG_LIBRARY(libdispatch) and SOFT_LINK_LIBRARY(libdispatch).
(WebCore::MediaPlayerPrivateAVFoundationCF::isAvailable): Don't check for libdispatch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic spring cleaning: move scripts, styles, and images in the respective...
dglazkov@chromium.org [Wed, 17 Aug 2011 23:28:43 +0000 (23:28 +0000)]
garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
https://bugs.webkit.org/show_bug.cgi?id=66427

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
():
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEliminate the WebNSInteger and WebNSUInteger compatibility definitions that were
mitz@apple.com [Wed, 17 Aug 2011 23:16:45 +0000 (23:16 +0000)]
Eliminate the WebNSInteger and WebNSUInteger compatibility definitions that were
needed for Tiger.

Reviewed by Darin Adler.

* History/WebBackForwardList.h:
* WebView/WebDocumentInternal.h:
* WebView/WebHTMLRepresentation.h:
* WebView/WebPreferences.h:
* WebView/WebResourceLoadDelegate.h:
* WebView/WebResourceLoadDelegatePrivate.h:
* WebView/WebScriptDebugDelegate.h:
* WebView/WebTextIterator.h:
* WebView/WebUIDelegate.h:
* WebView/WebView.h:
* WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
jochen@chromium.org [Wed, 17 Aug 2011 23:14:30 +0000 (23:14 +0000)]
Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
https://bugs.webkit.org/show_bug.cgi?id=65877

Reviewed by Eric Seidel.

* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove base.keys and replace it with Object.keys.
dglazkov@chromium.org [Wed, 17 Aug 2011 23:08:10 +0000 (23:08 +0000)]
Remove base.keys and replace it with Object.keys.
https://bugs.webkit.org/show_bug.cgi?id=66422

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic Summary view should have items in descending chronological order.
dglazkov@chromium.org [Wed, 17 Aug 2011 22:51:55 +0000 (22:51 +0000)]
garden-o-matic Summary view should have items in descending chronological order.
https://bugs.webkit.org/show_bug.cgi?id=66403

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a few errors in garden-o-matic frontend unit tests.
dglazkov@chromium.org [Wed, 17 Aug 2011 22:41:02 +0000 (22:41 +0000)]
Fix a few errors in garden-o-matic frontend unit tests.
https://bugs.webkit.org/show_bug.cgi?id=66421

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] remove stale result and mark 3 new authentication tests as
tony@chromium.org [Wed, 17 Aug 2011 22:31:48 +0000 (22:31 +0000)]
[chromium] remove stale result and mark 3 new authentication tests as
failing because chromium drt is missing a function.  Also mark
midword-break-before-surrogate-pair-2.html as failing on mac.

* platform/chromium-cg-mac/http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
* platform/chromium-win/http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] fast/text/midword-break-before-surrogate-pair-2.html is failing
tony@chromium.org [Wed, 17 Aug 2011 22:17:12 +0000 (22:17 +0000)]
[chromium] fast/text/midword-break-before-surrogate-pair-2.html is failing
on win and linux due to missing glyph.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse the LLVM Compiler for optimized builds when recent enough versions of it are...
mrowe@apple.com [Wed, 17 Aug 2011 21:57:28 +0000 (21:57 +0000)]
Use the LLVM Compiler for optimized builds when recent enough versions of it are available.

Rubber-stamped by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBring some consistency to the CompilerVersion.xcconfig files. They all now include...
mrowe@apple.com [Wed, 17 Aug 2011 21:57:14 +0000 (21:57 +0000)]
Bring some consistency to the CompilerVersion.xcconfig files.  They all now include REAL_PLATFORM_NAME in the relevant setting names.

Rubber-stamped by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=66354 and <rdar://problem/9965209>
beidson@apple.com [Wed, 17 Aug 2011 21:43:43 +0000 (21:43 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66354 and <rdar://problem/9965209>
Regression:  On Lion, redirects lose HTTP authentication headers

Source/WebCore:

Reviewed by Alexey Proskuryakov and Darin Adler.

This changes makes WebCore try to apply basic credentials after a redirect if the redirect is to the same origin,
assuming the redirected URL did not contain credentials directly.

Tests: http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html
       http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html
       http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
(WebCore::ResourceHandle::createCFURLConnection): Use the applyBasicAuthorizationHeader helper.
(WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.

* platform/network/mac/ResourceHandleMac.mm:
(WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.
(WebCore::ResourceHandle::createNSURLConnection): Use the applyBasicAuthorizationHeader helper.
(WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.

LayoutTests:

These have to be in different paths to prevent credentials from leaking over from test to test.
Sad sad sad...

Reviewed by Alexey Proskuryakov.

* http/tests/misc/authentication-redirect-1: Added.
* http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-sent-to-redirect-expected.txt.
* http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html: Copied from LayoutTests/http/tests/misc/authentication-sent-to-redirect.html.
* http/tests/misc/authentication-redirect-1/resources: Added.
* http/tests/misc/authentication-redirect-1/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
* http/tests/misc/authentication-redirect-1/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
* http/tests/misc/authentication-redirect-2: Added.
* http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Added.
* http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html: Added.
* http/tests/misc/authentication-redirect-2/resources: Added.
* http/tests/misc/authentication-redirect-2/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
* http/tests/misc/authentication-redirect-2/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
* http/tests/misc/authentication-redirect-3: Added.
* http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt: Added.
* http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html: Added.
* http/tests/misc/authentication-redirect-3/resources: Added.
* http/tests/misc/authentication-redirect-3/resources/auth-echo.php: Copied from LayoutTests/http/tests/misc/resources/auth-echo.php.
* http/tests/misc/authentication-redirect-3/resources/auth-then-redirect-with-url-credentials.php: Added.
* http/tests/misc/authentication-redirect-3/resources/auth-then-redirect.php: Copied from LayoutTests/http/tests/misc/resources/auth-then-redirect.php.
* http/tests/misc/authentication-sent-to-redirect-expected.txt: Removed.
* http/tests/misc/authentication-sent-to-redirect.html: Removed.
* http/tests/misc/resources/auth-echo.php: Removed.
* http/tests/misc/resources/auth-then-redirect.php: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAccessibility stack exhaustion using role attribute
cfleizach@apple.com [Wed, 17 Aug 2011 21:34:52 +0000 (21:34 +0000)]
Accessibility stack exhaustion using role attribute
https://bugs.webkit.org/show_bug.cgi?id=65174

Reviewed by Darin Adler.

Forgot to commit review comments.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDump-as-markup conversion: editing/inserting/insert-3786362-fix.html
rniwa@webkit.org [Wed, 17 Aug 2011 21:29:40 +0000 (21:29 +0000)]
Dump-as-markup conversion: editing/inserting/insert-3786362-fix.html
https://bugs.webkit.org/show_bug.cgi?id=66396

Reviewed by Chang Shu.

Converted the test.

* editing/inserting/insert-3786362-fix-expected.txt: Added.
* editing/inserting/insert-3786362-fix.html:
* platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.png: Removed.
* platform/chromium-win/editing/inserting/insert-3786362-fix-expected.png: Removed.
* platform/chromium-win/editing/inserting/insert-3786362-fix-expected.txt: Removed.
* platform/gtk/editing/inserting/insert-3786362-fix-expected.png: Removed.
* platform/gtk/editing/inserting/insert-3786362-fix-expected.txt: Removed.
* platform/mac-leopard/editing/inserting/insert-3786362-fix-expected.png: Removed.
* platform/mac/editing/inserting/insert-3786362-fix-expected.png: Removed.
* platform/mac/editing/inserting/insert-3786362-fix-expected.txt: Removed.
* platform/qt/editing/inserting/insert-3786362-fix-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAccessibility stack exhaustion using role attribute
cfleizach@apple.com [Wed, 17 Aug 2011 21:24:06 +0000 (21:24 +0000)]
Accessibility stack exhaustion using role attribute
https://bugs.webkit.org/show_bug.cgi?id=65174

Source/WebCore:

Make sure we do not call accessibilityIsIgnored() during the AccessibilityObject
creation flow. That can lead to loops.

Reviewed by Darin Adler.

Tests: accessibility/crash-determining-aria-role-when-label-present.html

* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
* accessibility/AccessibilityRenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

* accessibility/crash-determining-aria-role-when-label-present-expected.txt: Added.
* accessibility/crash-determining-aria-role-when-label-present.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Tools to account for (CG) being added to Chromium builder names
abarth@webkit.org [Wed, 17 Aug 2011 21:16:39 +0000 (21:16 +0000)]
Update Tools to account for (CG) being added to Chromium builder names
https://bugs.webkit.org/show_bug.cgi?id=66410

Reviewed by Adam Barth.

Some of these names will change back once we turn on Skia bots.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
* TestResultServer/static-dashboards/builders.js:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWire up relative time to garden-o-matic summary view.
dglazkov@chromium.org [Wed, 17 Aug 2011 21:13:29 +0000 (21:13 +0000)]
Wire up relative time to garden-o-matic summary view.
https://bugs.webkit.org/show_bug.cgi?id=66343

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake run-api-tests run tests in alphabetical order
aroben@apple.com [Wed, 17 Aug 2011 21:08:24 +0000 (21:08 +0000)]
Make run-api-tests run tests in alphabetical order

Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order

Reviewed by David Kilzer.

* Scripts/run-api-tests:
(runAllTests):
(runAllTestsInSuite):
Sort the lists of tests and suites before iterating over them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Crash if compositing is disabled during updateLayers()
jamesr@google.com [Wed, 17 Aug 2011 20:58:21 +0000 (20:58 +0000)]
[chromium] Crash if compositing is disabled during updateLayers()
https://bugs.webkit.org/show_bug.cgi?id=66353

Reviewed by Kenneth Russell.

If compositing is turned off during LayerRendererChromium::updateLayers(), the rootLayer() will become null.
Sicne CCLayerTreeHost::doComposite() calls updateLayers() and then drawLayers() without checking for this case,
drawLayers() has to return without doing anything if the root layer is null.

Crash fixed based on crash reports.  No known reliably repro case, unfortunately.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJSC verbose debugging output sometimes doesn't work as expected.
fpizlo@apple.com [Wed, 17 Aug 2011 20:54:32 +0000 (20:54 +0000)]
JSC verbose debugging output sometimes doesn't work as expected.
https://bugs.webkit.org/show_bug.cgi?id=66107

Reviewed by Gavin Barraclough.

Hardened the CodeBlock::dump() code so that it no longer crashes.  Improved
the DFG verbose code so that it prints slightly more useful information.

* assembler/LinkBuffer.h:
(JSC::LinkBuffer::debugSize):
* bytecode/CodeBlock.cpp:
(JSC::valueToSourceString):
(JSC::CodeBlock::dump):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::numberOfRegExps):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9971293> Mid-word breaks can occur in the middle of a surrogate pair
mitz@apple.com [Wed, 17 Aug 2011 20:52:31 +0000 (20:52 +0000)]
<rdar://problem/9971293> Mid-word breaks can occur in the middle of a surrogate pair
https://bugs.webkit.org/show_bug.cgi?id=66402

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/text/midword-break-before-surrogate-pair-2.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Just never allow a mid-word
break before a trailing surrogate.

LayoutTests:

* fast/text/midword-break-before-surrogate-pair-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic should be able to rebaseline expected failures
abarth@webkit.org [Wed, 17 Aug 2011 20:15:59 +0000 (20:15 +0000)]
garden-o-matic should be able to rebaseline expected failures
https://bugs.webkit.org/show_bug.cgi?id=66204

Reviewed by Dimitri Glazkov.

This patch introduces a new view for displaying expect, actual, and
differences between results.  The new view also has a fledgling
controller that handles some basic operations.  The new view is
exercised by rebaseline.html, which lets you rebaselines expected
failures, but the new view is not fully integrated into
garden-o-matic.html

More patches will be required to make this stuff fully working, but
this patch was already somewhat spiraling out of control.  Hopefully
this patch will serve as a good starting point for further development.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-08-16 Chang Shu <cshu@webkit.org>
chang.shu@nokia.com [Wed, 17 Aug 2011 19:59:57 +0000 (19:59 +0000)]
2011-08-16  Chang Shu  <cshu@webkit.org>

        Support reset in WebCore::Internals
        https://bugs.webkit.org/show_bug.cgi?id=66307

        Reviewed by Dimitri Glazkov.

        New tests will be added when function reset is implemented.

        Added framework code in WebCoreTestSupport. The real implementation of
        Internals::reset() depends on the need from the settings that require a reset.

        * testing/Internals.cpp:
        (WebCore::Internals::reset):
        * testing/Internals.h:
        * testing/js/WebCoreTestSupport.cpp:
        (WebCoreTestSupport::resetInternalsObject):
        * testing/js/WebCoreTestSupport.h:
        * testing/v8/WebCoreTestSupport.cpp:
        (WebCoreTestSupport::resetInternalsObject):
        * testing/v8/WebCoreTestSupport.h:

2011-08-16  Chang Shu  <cshu@webkit.org>

        Support reset in WebCore::Internals
        https://bugs.webkit.org/show_bug.cgi?id=66307

        Reviewed by Dimitri Glazkov.

        Added framework code in WebKit.

        * public/WebTestingSupport.h:
        * src/WebTestingSupport.cpp:
        (WebKit::WebTestingSupport::resetInternalsObject):

2011-08-16  Chang Shu  <cshu@webkit.org>

        Support reset in WebCore::Internals
        https://bugs.webkit.org/show_bug.cgi?id=66307

        Reviewed by Dimitri Glazkov.

        Added framework code in WebKit.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::resetInternalsObject):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-08-16  Chang Shu  <cshu@webkit.org>

        Support reset in WebCore::Internals
        https://bugs.webkit.org/show_bug.cgi?id=66307

        Reviewed by Dimitri Glazkov.

        Added call to resetInternalsObject in DRT.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline for Windows, Chromium Windows, and Chromium Linux after r93221.
rniwa@webkit.org [Wed, 17 Aug 2011 19:44:03 +0000 (19:44 +0000)]
Rebaseline for Windows, Chromium Windows, and Chromium Linux after r93221.

* platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unused Core Animation related classes
andersca@apple.com [Wed, 17 Aug 2011 19:11:22 +0000 (19:11 +0000)]
Remove unused Core Animation related classes
https://bugs.webkit.org/show_bug.cgi?id=66393

Reviewed by Darin Adler.

* Shared/mac/CoreAnimationRenderer.h: Removed.
* Shared/mac/CoreAnimationRenderer.mm: Removed.
* Shared/mac/ShareableSurface.cpp: Removed.
* Shared/mac/ShareableSurface.h: Removed.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Windows Results for svg/W3C-SVG-1.1-SE/text-intro-05-t.svg
aroben@apple.com [Wed, 17 Aug 2011 19:10:19 +0000 (19:10 +0000)]
Update Windows Results for svg/W3C-SVG-1.1-SE/text-intro-05-t.svg

* platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
* platform/win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.

These results were checked in to platform/win but were really XP-specific.

* platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
* platform/win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
Updated these results for Windows 7.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a new build slave for the Qt port on Mac OS SnowLeopard.
alexis.menard@openbossa.org [Wed, 17 Aug 2011 18:56:33 +0000 (18:56 +0000)]
Add a new build slave for the Qt port on Mac OS SnowLeopard.
https://bugs.webkit.org/show_bug.cgi?id=66392

Modify the config file to include the new build slave.

Reviewed by Adam Roben.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Mark fast/canvas/webgl/data-view-crash.html as flaky
tony@chromium.org [Wed, 17 Aug 2011 18:53:48 +0000 (18:53 +0000)]
[chromium] Mark fast/canvas/webgl/data-view-crash.html as flaky
on linux debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix chromium mac compile. MediaPlayerPrivateAVFoundationObjC.* moved
tony@chromium.org [Wed, 17 Aug 2011 18:44:42 +0000 (18:44 +0000)]
Fix chromium mac compile.  MediaPlayerPrivateAVFoundationObjC.* moved
and the WebCore.gypi file wasn't updated.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove support for old didCreateIsolatedContext() signature
aa@chromium.org [Wed, 17 Aug 2011 18:39:18 +0000 (18:39 +0000)]
Remove support for old didCreateIsolatedContext() signature
https://bugs.webkit.org/show_bug.cgi?id=66249

Reviewed by Darin Fisher.

* public/WebFrameClient.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Crash in Document::recalcStyleSelector
inferno@chromium.org [Wed, 17 Aug 2011 18:29:24 +0000 (18:29 +0000)]
Source/WebCore: Crash in Document::recalcStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=66335

Reviewed by Simon Fraser.

When node is getting destroyed and its removedFromDocument
is not called due to entire document structure torn down(using
removeAllChildren), make sure to clear out the stylesheet
candidate node from document's structures in its destructor.

Test: svg/dom/stylesheet-candidate-node-crash-main.html

* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::~ProcessingInstruction):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::~HTMLLinkElement):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::~HTMLStyleElement):
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::~SVGStyleElement):

LayoutTests: Tests that we do not crash when iterating through stylesheet
candidate list hashset.
https://bugs.webkit.org/show_bug.cgi?id=66335

Reviewed by Simon Fraser.

* svg/dom/resources/stylesheet-candidate-node-crash.svg: Added.
* svg/dom/stylesheet-candidate-node-crash-main-expected.txt: Added.
* svg/dom/stylesheet-candidate-node-crash-main.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: AccessibilityObject levels are inconsistent
commit-queue@webkit.org [Wed, 17 Aug 2011 18:28:02 +0000 (18:28 +0000)]
Source/WebCore: AccessibilityObject levels are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=66180

Updated accessibilityTable to return level values consistent with other accessibilityObjects that
return level values. This means a value of 0 is now only returned when tableLevel() is called on a
non-table element.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.

Test: platform/mac/accessibility/element-level.html

* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::tableLevel):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools: AccessibilityObject levels are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=66180

Added the ability to get numeric attribute values using numberAttributeValue. This
function complements the existing stringAttributeValue and boolAttributeValue functions.
The addition of numberAttributeValue was necessary because the stringAttributeValue
function does a type check and will only return strings. This limitation made it
impossible to get values for attributes that returned an NSNumber.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.

* DumpRenderTree/AccessibilityUIElement.cpp:
(numberAttributeValueCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::numberAttributeValue):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::numberAttributeValue):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::numberAttributeValue):

LayoutTests: AccessibilityObject levels are inconsistent
https://bugs.webkit.org/show_bug.cgi?id=66180

This test ensures that all AccessibilityObjects that return a level value return consistent results.
For example, a level of 0 should only be returned by a level function when it is called on an
AccessibilityObject of the wrong type. It's especially important that we enforce this consistency
using layout tests because these level values are not defined by the W3C but are still used by
popular screen readers such as VoiceOver.

Patch by Sam White <samuel.white@rochester.edu> on 2011-08-17
Reviewed by Chris Fleizach.

* platform/mac/accessibility/element-level-expected.txt: Added.
* platform/mac/accessibility/element-level.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove support for old didCreateIsolatedContext() signature
aa@chromium.org [Wed, 17 Aug 2011 18:21:26 +0000 (18:21 +0000)]
Remove support for old didCreateIsolatedContext() signature
https://bugs.webkit.org/show_bug.cgi?id=66249

Reviewed by Darin Fisher.

* public/WebFrameClient.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateIsolatedScriptContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTell Trac logs always to display all specified revisions in a single page
aroben@apple.com [Wed, 17 Aug 2011 18:17:49 +0000 (18:17 +0000)]
Tell Trac logs always to display all specified revisions in a single page

Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
revisions than that.

Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
relevant revisions

Reviewed by Daniel Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
(trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
a single page.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
Updated tests for the above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix TestFailures's link to file a bug about TestFailures itself
aroben@apple.com [Wed, 17 Aug 2011 18:13:27 +0000 (18:13 +0000)]
Fix TestFailures's link to file a bug about TestFailures itself

Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
bug about itself is broken

Reviewed by Dan Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
the host from the path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTeach TestFailures to ignore unbelievably short test runs
aroben@apple.com [Wed, 17 Aug 2011 18:13:12 +0000 (18:13 +0000)]
Teach TestFailures to ignore unbelievably short test runs

Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956

Reviewed by Dan Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
that caused it not to run any tests at all (as happened for a while due to
<http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
Test for the above.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
(LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAn arrow key collapses directionless selection range in the wrong direction in BiDi
rniwa@webkit.org [Wed, 17 Aug 2011 18:07:33 +0000 (18:07 +0000)]
An arrow key collapses directionless selection range in the wrong direction in BiDi
https://bugs.webkit.org/show_bug.cgi?id=64626

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by willBeModified's always using block direction to determine
the direction to which the selection is collapsed. Fixed the bug by calling directionOfSelection
in willBeModified, which will return the text direction of the surrounding context when
the start and the end have the same direction. When the text directions at the start and at the end
of selection do not match, it uses the block's text direction.

Test: editing/selection/collapse-selection-in-bidi.html

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::directionOfSelection): Added.
(WebCore::FrameSelection::willBeModified): Calls directionOfSelection.
(WebCore::FrameSelection::modifyMovingRight): Ditto.
(WebCore::FrameSelection::modifyMovingLeft): Ditto.
* editing/FrameSelection.h:

LayoutTests:

Added a test to ensure collapsing directionless selection respects the direction of text around
the selection's end points.

* editing/selection/collapse-selection-in-bidi-expected.txt: Added.
* editing/selection/collapse-selection-in-bidi.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove onTimeout from WebIDBTransactionCallbacks.h
commit-queue@webkit.org [Wed, 17 Aug 2011 18:04:31 +0000 (18:04 +0000)]
Remove onTimeout from WebIDBTransactionCallbacks.h
https://bugs.webkit.org/show_bug.cgi?id=66326

Patch by David Grogan <dgrogan@chromium.org> on 2011-08-17
Reviewed by Tony Chang.

* public/WebIDBTransactionCallbacks.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSome AVFoundation source files should be in platform-specific directories
jeffm@apple.com [Wed, 17 Aug 2011 17:57:00 +0000 (17:57 +0000)]
Some AVFoundation source files should be in platform-specific directories
https://bugs.webkit.org/show_bug.cgi?id=66352

Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf,
and moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.

While I was at it, added svn:eol-style property to the MediaPlayerPrivateAVFoundationObjC.* files.

Also, for some reason, Visual Studio decided to re-sort a couple files in \inspector\front-end\ in WebCore.vcproj, even though
I just re-sorted the project in r93215.

Reviewed by Eric Carlson.

No new tests; no functional change.

* WebCore.vcproj/WebCore.vcproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf.

* WebCore.vcproj/WebCoreMediaQT.vsprops: Added $(ProjectDir)..\platform\graphics\avfoundation\cf to include paths.

* WebCore.xcodeproj/project.pbxproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Removed.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Removed.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Removed.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Removed.

* platform/graphics/avfoundation/cf: Added.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h.

* platform/graphics/avfoundation/objc: Added.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOnly set m_fontDirty if TextSizeAdjust is actually changed.
macpherson@chromium.org [Wed, 17 Aug 2011 17:45:40 +0000 (17:45 +0000)]
Only set m_fontDirty if TextSizeAdjust is actually changed.
https://bugs.webkit.org/show_bug.cgi?id=66022

Reviewed by Darin Adler.

No new tests. Refactoring only.

Reduces instances where the font information is dirtied to save recalculation where it is not necessary.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Call new setTextSizeAdjust function.
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::setTextSizeAdjust):
Add wrapper for RenderStyle::setTextSizeAdjust() that automatically updates m_fontDirty.
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setTextSizeAdjust):
Make setTextSizeAdjust return true if the unlderlying value was changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r93204.
steveblock@google.com [Wed, 17 Aug 2011 17:45:05 +0000 (17:45 +0000)]
Unreviewed, rolling out r93204.
http://trac.webkit.org/changeset/93204
https://bugs.webkit.org/show_bug.cgi?id=66375

Test no longer crashing since r93171

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Crash in HarfbuzzFace::~HarfbuzzFace
bashi@chromium.org [Wed, 17 Aug 2011 17:23:24 +0000 (17:23 +0000)]
[Chromium] Crash in HarfbuzzFace::~HarfbuzzFace
https://bugs.webkit.org/show_bug.cgi?id=66211

Holds Skia's unique font ID instead of FontPlatformData to avoid accessing freed FontPlatformData.

Reviewed by Tony Chang.

No new tests; no functional change.

* platform/graphics/chromium/HarfbuzzSkia.cpp:
(WebCore::releaseCachedHarfbuzzFace): Changed the argument.
(WebCore::HarfbuzzFace::HarfbuzzFace): Changed to have Skia's font uniqueID instead of FontPlatformData.
(WebCore::HarfbuzzFace::~HarfbuzzFace): Uses m_uniqueID to call releaseCachedHarfbuzzFace.
* platform/graphics/chromium/HarfbuzzSkia.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRe-sort the WebCore project with Visual Studio after recent changes that I assume...
jeffm@apple.com [Wed, 17 Aug 2011 17:16:31 +0000 (17:16 +0000)]
Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Add chromium baselines for tests added in r93144.
tony@chromium.org [Wed, 17 Aug 2011 17:16:20 +0000 (17:16 +0000)]
[chromium] Add chromium baselines for tests added in r93144.

* platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
* platform/chromium-cg-mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
* platform/chromium-win/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Mark svg/custom/repaint-shadow.svg and
tony@chromium.org [Wed, 17 Aug 2011 16:59:09 +0000 (16:59 +0000)]
[chromium] Mark svg/custom/repaint-shadow.svg and
media/media-blocked-by-beforeload.html as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix typo in test_expectations.txt.
tony@chromium.org [Wed, 17 Aug 2011 16:25:00 +0000 (16:25 +0000)]
[chromium] Fix typo in test_expectations.txt.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip another <progress> test on Windows
aroben@apple.com [Wed, 17 Aug 2011 16:02:37 +0000 (16:02 +0000)]
Skip another <progress> test on Windows

* platform/win/Skipped: Added fast/dom/shadow/tree-scope-crash.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: http/tests/inspector/network/disabled-cache-crash.html flaky
steveblock@google.com [Wed, 17 Aug 2011 15:49:17 +0000 (15:49 +0000)]
Web Inspector: http/tests/inspector/network/disabled-cache-crash.html flaky
https://bugs.webkit.org/show_bug.cgi?id=65558

Add TIMEOUT expectation.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows expected failure results for text-combine-image-test.html
aroben@apple.com [Wed, 17 Aug 2011 15:22:14 +0000 (15:22 +0000)]
Add Windows expected failure results for text-combine-image-test.html

Failure is tracked by <http://webkit.org/b/66376>.

* platform/win/fast/text/international/text-combine-image-test-expected.png:
* platform/win/fast/text/international/text-combine-image-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows expected failure results for new test added in r93068
aroben@apple.com [Wed, 17 Aug 2011 15:21:43 +0000 (15:21 +0000)]
Add Windows expected failure results for new test added in r93068

Failure is tracked by <http://webkit.org/b/66374>.

* platform/win/editing/deleting/regional-indicators-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows results for new test added in r91777
aroben@apple.com [Wed, 17 Aug 2011 15:21:14 +0000 (15:21 +0000)]
Add Windows results for new test added in r91777

* platform/win/fast/css/font-family-pictograph-expected.png: Added.
* platform/win/fast/css/font-family-pictograph-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows results for tests that differ from Lion due to font differences
aroben@apple.com [Wed, 17 Aug 2011 14:05:35 +0000 (14:05 +0000)]
Add Windows results for tests that differ from Lion due to font differences

These tests started failing in r93107 when I made Windows fall back to Lion results instead
of SnowLeopard results. This is good in general, but these particular tests happen to give
SnowLeopard-ish results due to some fonts that changed in Lion.

* platform/win/css1/font_properties/font-expected.png: Added.
* platform/win/css1/font_properties/font-expected.txt: Copied from platform/mac-snowleopard/css1/font_properties/font-expected.txt.
* platform/win/css2.1/t1508-c527-font-05-b-expected.png: Added.
* platform/win/css2.1/t1508-c527-font-05-b-expected.txt: Copied from platform/mac-snowleopard/css2.1/t1508-c527-font-05-b-expected.txt: Added.
* platform/win/css2.1/t1508-c527-font-10-c-expected.png: Added.
* platform/win/css2.1/t1508-c527-font-10-c-expected.txt: Copied from platform/mac-snowleopard/css2.1/t1508-c527-font-10-c-expected.txt.
* platform/win/fast/text/capitalize-boundaries-expected.png: Added.
* platform/win/fast/text/capitalize-boundaries-expected.txt: Copied from platform/win/fast/text/capitalize-boundaries-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows expected failures results for new test added in r93144
aroben@apple.com [Wed, 17 Aug 2011 14:04:56 +0000 (14:04 +0000)]
Add Windows expected failures results for new test added in r93144

Failure is tracked by <http://webkit.org/b/56101>.

* platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttp/tests/misc/font-face-in-multiple-segmented-faces.html assertion failure on Chromium
steveblock@google.com [Wed, 17 Aug 2011 13:50:46 +0000 (13:50 +0000)]
http/tests/misc/font-face-in-multiple-segmented-faces.html assertion failure on Chromium
https://bugs.webkit.org/show_bug.cgi?id=66375

Sets a CRASH expectation for Windows debug.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSet failing TEXT expectation for http/tests/security/mixedContent/insecure-plugin...
steveblock@google.com [Wed, 17 Aug 2011 13:05:43 +0000 (13:05 +0000)]
Set failing TEXT expectation for http/tests/security/mixedContent/insecure-plugin-in-iframe.html for all build flavors
http://crbug.com/26042

The test already has a failing TEXT expectation for DEBUG and for
LINUX RELEASE, but we're now seeing failures on Mac10.6. It looks like
it's generally flaky.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to...
commit-queue@webkit.org [Wed, 17 Aug 2011 11:45:43 +0000 (11:45 +0000)]
Chromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to match WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=66311

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-17
Reviewed by Dimitri Glazkov.

Updated wkScrollbarMinimumTotalLengthNeededForThumb() based on the latest disassembly of libWebKitSystemInterfaceLion.a.

* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarMinimumTotalLengthNeededForThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r93186.
steveblock@google.com [Wed, 17 Aug 2011 11:42:59 +0000 (11:42 +0000)]
Unreviewed, rolling out r93186.
http://trac.webkit.org/changeset/93186
https://bugs.webkit.org/show_bug.cgi?id=66114

Breaks LayoutTests on Chromium canary bots

Source/WebCore:

* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/cc/CCLayerImpl.h:

LayoutTests:

* compositing/backface-visibility-hierarchical-transform-expected.png: Removed.
* compositing/backface-visibility-hierarchical-transform-expected.txt: Removed.
* compositing/backface-visibility-hierarchical-transform.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION after r93011
ossy@webkit.org [Wed, 17 Aug 2011 10:54:50 +0000 (10:54 +0000)]
[Qt] REGRESSION after r93011
https://bugs.webkit.org/show_bug.cgi?id=66212

Unreviewed gardening.

* platform/qt-4.8/Skipped:
 - Unskip fast/css/font-face-opentype.html.
 - Unskip http/tests/security/cross-frame-access-put.html, because it passes now.
* platform/qt-4.8/fast/css/font-face-opentype-expected.txt: Update Qt 4.8 specific expected result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGet rid of calls to deprecatedNode and deprecatedEditingOffset in
rniwa@webkit.org [Wed, 17 Aug 2011 10:52:01 +0000 (10:52 +0000)]
Get rid of calls to deprecatedNode and deprecatedEditingOffset in
AccessibilityRenderObject.cpp and InsertTextCommand.cpp
https://bugs.webkit.org/show_bug.cgi?id=66014

Reviewed by Hajime Morita.

Removed calls to deprecatedNode and deprecatedEditingOffsets in the following files.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Calls Position::rootEditableElement
and Range::setEnd(const Position&, ExceptionCode) instead of manually pulling deprecatedNode
and deprecatedEditingOffset.
(WebCore::AccessibilityRenderObject::index): Abstracted the logic to loop through render objects
from deprecatedNodes' renderer to m_renderer as renderObjectContainsPosition.
* dom/Position.h:
(WebCore::Position::rootEditableElement): Added.
* dom/Range.cpp:
(WebCore::Range::setStart): Added.
(WebCore::Range::setEnd): Added.
* dom/Range.h:
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::insertTab):
* editing/RenderedPosition.cpp:
(WebCore::renderObjectContainsPosition): Extracted from AccessibilityRenderObject::index.
* editing/RenderedPosition.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Wed, 17 Aug 2011 10:49:25 +0000 (10:49 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped:
 - Unskip tests removed by r93095.
 - Skip fast/repaint/japanese-rl-selection-repaint-in-regions.html introduced in r93144.
* platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added. (test introduced in r93144)
* platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added. (test introduced in r93144)
* platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Added. (test introduced in r93144)
* platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added. (test introduced in r93144)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Mac: Fix issue where scrollbar wouldn't be drawn until page finished loading
commit-queue@webkit.org [Wed, 17 Aug 2011 08:28:31 +0000 (08:28 +0000)]
Chromium Mac: Fix issue where scrollbar wouldn't be drawn until page finished loading
https://bugs.webkit.org/show_bug.cgi?id=66238

Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-17
Reviewed by Dimitri Glazkov.

Overlay scrollbars were not visible if the user scrolled a page while the page was loading. The sequence of events necessary to reproduce this bug were:
  1. -[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:] is called
  2. animation is delayed because shouldSuspendScrollAnimations() is true
  3. ScrollAnimatorChromiumMac::scroll() is called before the ScrollAnimatorChromiumMac::m_initialScrollbarPaintTimer is fired.
  4. At this point the scrollbar painter assumes the scrollbar is already visible (because of 1.) so the scrollbar's alpha stays at 0. Thus the scrollbar isn't visible until the page finishes loading.
It turns out that the root problem was that when the initialScrollbarPainterTimer fired I wasn't flashing the scrollbar correctly. My implementation of wkScrollbarPainterForceFlashScrollers() just called flashScrollers. The Safari implementation of this function also calls hideOverlayScrollers. Calling hideOverlayScrollers causes the alpha to change to 0 which prevents step 4 from happening.

Also, now that wkScrollbarPainterForceFlashScrollers is working correctly I don't need the extra logic I added to the initialScrollbarPainterTimer handler. That logic restarted the timer if shouldSuspendScrollAnimations() was true. But this isn't necessary since calling wkScrollbarPainterForceFlashScrollers() causes -[ScrollbarPainterDelegate setUpAnimation:...] to be called which does the exact same thing. Removing the extra logic reverts http://trac.webkit.org/changeset/92316.

* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
* platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
(wkScrollbarPainterForceFlashScrollers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-08-16 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 17 Aug 2011 08:26:17 +0000 (08:26 +0000)]
2011-08-16  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: maintain visible view hierarchy and dispatch common view events automatically
        https://bugs.webkit.org/show_bug.cgi?id=66131

        Reviewed by Pavel Feldman.

        Test: inspector/view-events.html

        - added a notion of an optional parent to a View
        - maintain a list of View children
        - dispatch common view events, such as show/hide/resize automatically through the hierarchy of visible views.
        - promoted Panel's logic of (re)storing scroll positions to view
        - demoted inheritScrollPositionFromView to a couple of views that need it.

        * inspector/front-end/ApplicationCacheItemsView.js:
        (WebInspector.ApplicationCacheItemsView.prototype.onResize):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.populateStatusBar):
        (WebInspector.ConsoleView.prototype.elementsToRestoreScrollPositionsFor):
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype.onResize):
        (WebInspector.SimpleCookiesTable.prototype.onResize):
        * inspector/front-end/DOMStorageItemsView.js:
        (WebInspector.DOMStorageItemsView.prototype.onResize):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotView.prototype.onResize):
        * inspector/front-end/Drawer.js:
        (WebInspector.Drawer.prototype.set visibleView):
        (WebInspector.Drawer.prototype.show):
        (WebInspector.Drawer.prototype.hide):
        (WebInspector.Drawer.prototype.onResize):
        (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
        (WebInspector.Drawer.prototype._animateDrawerHeight):
        (WebInspector.Drawer.prototype._statusBarDragging):
        (WebInspector.Drawer.prototype._endStatusBarDragging):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.onResize):
        * inspector/front-end/ExtensionPanel.js:
        * inspector/front-end/FontView.js:
        (WebInspector.FontView.prototype.onResize):
        * inspector/front-end/IFrameView.js:
        (WebInspector.IFrameView):
        * inspector/front-end/NetworkItemView.js:
        (WebInspector.NetworkItemView.prototype._installHighlightSupport):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkLogView):
        (WebInspector.NetworkLogView.prototype.elementsToRestoreScrollPositionsFor):
        (WebInspector.NetworkLogView.prototype.onResize):
        (WebInspector.NetworkLogView.prototype.wasShown):
        (WebInspector.NetworkLogView.prototype.willHide):
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype.show):
        (WebInspector.NetworkPanel.prototype._showResource):
        (WebInspector.NetworkPanel.prototype._closeVisibleResource):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.show):
        (WebInspector.Panel.prototype.hide):
        (WebInspector.Panel.prototype.performSearch.processChunk):
        (WebInspector.Panel.prototype.performSearch):
        (WebInspector.Panel.prototype.updateSidebarWidth):
        * inspector/front-end/PanelEnablerView.js:
        (WebInspector.PanelEnablerView.prototype.show):
        (WebInspector.PanelEnablerView.prototype.onResize):
        * inspector/front-end/ProfileView.js:
        (WebInspector.CPUProfileView.prototype.onResize):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
        * inspector/front-end/ResourceCookiesView.js:
        (WebInspector.ResourceCookiesView.prototype.onResize):
        * inspector/front-end/ResourcePreviewView.js:
        (WebInspector.ResourcePreviewView.prototype.contentLoaded):
        * inspector/front-end/ResourceResponseView.js:
        (WebInspector.ResourceResponseView.prototype.contentLoaded):
        * inspector/front-end/ResourceTimingView.js:
        (WebInspector.ResourceTimingView.prototype.show):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.show):
        (WebInspector.ResourcesPanel.prototype._innerShowView):
        (WebInspector.ResourcesPanel.prototype.closeVisibleView):
        (WebInspector.ResourcesPanel.prototype.updateMainViewWidth):
        (WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.show):
        (WebInspector.ScriptsPanel.prototype._createSourceFrame):
        (WebInspector.ScriptsPanel.prototype._removeSourceFrame):
        (WebInspector.ScriptsPanel.prototype.setSidebarWidth):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype.show):
        (WebInspector.SourceFrame.prototype.willHide):
        (WebInspector.SourceFrame.prototype.clearMessages):
        (WebInspector.SourceFrame.prototype._setTextViewerDecorations):
        (WebInspector.SourceFrame.prototype.inheritScrollPositions):
        * inspector/front-end/TabbedPane.js:
        (WebInspector.TabbedPane.prototype.appendTab):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype.elementsToRestoreScrollPositionsFor):
        (WebInspector.TextViewer.prototype.inheritScrollPositions):
        (WebInspector.TextViewer.prototype.onResize):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype.onResize):
        (WebInspector.TimelinePanel.prototype.elementsToRestoreScrollPositionsFor):
        (WebInspector.TimelinePanel.prototype.show):
        * inspector/front-end/View.js:
        (WebInspector.View):
        (WebInspector.View.prototype.wasShown):
        (WebInspector.View.prototype.willHide):
        (WebInspector.View.prototype._innerShow):
        (WebInspector.View.prototype.show):
        (WebInspector.View.prototype._innerHide):
        (WebInspector.View.prototype.hide):
        (WebInspector.View.prototype._detach):
        (WebInspector.View.prototype.elementsToRestoreScrollPositionsFor):
        (WebInspector.View.prototype.storeScrollPositions):
        (WebInspector.View.prototype.restoreScrollPositions):
        (WebInspector.View.prototype.addChildView):
        (WebInspector.View.prototype.removeChildView):
        (WebInspector.View.prototype.onResize):
        (WebInspector.View.prototype.doResize):
        (WebInspector.View.prototype.dispatchToSelfAndVisibleChildren):
        (WebInspector.View.prototype.dispatchToVisibleChildren):
        * inspector/front-end/inspector.js:
        (WebInspector.windowResize):

2011-08-16  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: maintain visible view hierarchy and dispatch common view events automatically
        https://bugs.webkit.org/show_bug.cgi?id=66131

        Reviewed by Pavel Feldman.

        * inspector/view-events-expected.txt: Added.
        * inspector/view-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRepresent RenderStyle::textOverflow property using an enum instead of a bool.
macpherson@chromium.org [Wed, 17 Aug 2011 04:51:25 +0000 (04:51 +0000)]
Represent RenderStyle::textOverflow property using an enum instead of a bool.
https://bugs.webkit.org/show_bug.cgi?id=66356

Reviewed by Dan Bernstein.

No new tests - no behavioral changes.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from TextOverflow to CSSPrimitiveValue.
(WebCore::CSSPrimitiveValue::operator TextOverflow):
Support cast from CSSPrimitiveValue to TextOverflow.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for text overflow.
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::textOverflow):
Return TextOverflow enum.
(WebCore::InheritedFlags::setTextOverflow):
Accept TextOverflow enum parameter.
(WebCore::InheritedFlags::initialTextOverflow):
Return TextOverflowClip.
* rendering/style/RenderStyleConstants.h:
Define TextOverflow enum.
* rendering/style/StyleRareNonInheritedData.h:
Change representation of text overflow from bool to one-bit unsigned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoApple's Windows production build should fail to compile if AVFoundation is not enabled
jeffm@apple.com [Wed, 17 Aug 2011 04:49:15 +0000 (04:49 +0000)]
Apple's Windows production build should fail to compile if AVFoundation is not enabled
https://bugs.webkit.org/show_bug.cgi?id=66339

Generate a compile-time error for Production builds if !USE(AVFOUNDATION).

Reviewed by Darin Adler.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd new chromium-mac-leopard directory to match the chromium-mac that
abarth@webkit.org [Wed, 17 Aug 2011 01:41:29 +0000 (01:41 +0000)]
Add new chromium-mac-leopard directory to match the chromium-mac that
tony^work added.  This directory will house Skia results for Chromium Mac.

* platform/chromium-mac-leopard: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a CG qualifier similar to the GPU qualifier
abarth@webkit.org [Wed, 17 Aug 2011 01:38:35 +0000 (01:38 +0000)]
Add a CG qualifier similar to the GPU qualifier
https://bugs.webkit.org/show_bug.cgi?id=66359

Reviewed by Eric Seidel.

Once we have a Skia configuration on Chromium Mac, we'll use this CG
qualifier to note that expectations apply only to the CG configuration.

* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in Structure::visitChildren running iAd.js regression test suite under memory...
msaboff@apple.com [Wed, 17 Aug 2011 01:34:29 +0000 (01:34 +0000)]
Crash in Structure::visitChildren running iAd.js regression test suite under memory pressure
https://bugs.webkit.org/show_bug.cgi?id=66351

JIT::privateCompilePutByIdTransition expects that regT0 and regT1
have the basePayload and baseTag respectively.  In some cases,
we may get to this generated code with one or both of these
registers trash.  One know case is that regT0 on ARM may be
trashed as regT0 (r0) is also arg0 and can be overrun with sp due
to calls to JIT::restoreReturnAddress().  This patch uses the
values on the stack.  A longer term solution is to work out all
cases so that the register entry assumptions can assured.

While fixing this, also determined that the additional stack offset
of sizeof(void*) is not needed for ARM.

Reviewed by Gavin Barraclough.

* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r89086): All worker xhr requests trigger preflight requests.
levin@chromium.org [Wed, 17 Aug 2011 01:32:20 +0000 (01:32 +0000)]
REGRESSION (r89086): All worker xhr requests trigger preflight requests.
https://bugs.webkit.org/show_bug.cgi?id=66340

Reviewed by Adam Barth.

Test coming in a more comprehensive patch shortly. This is just a very targetted
patch to allow for easier merging.

* loader/CrossOriginAccessControl.cpp:
(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list
of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is
set before calling this function. This is similar to what is done for "origin" in here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd two sample mismatch reftests to make sure that reftests work correctly.
hayato@chromium.org [Wed, 17 Aug 2011 01:29:17 +0000 (01:29 +0000)]
Add two sample mismatch reftests to make sure that reftests work correctly.
https://bugs.webkit.org/show_bug.cgi?id=66218

Reviewed by Tony Chang.

One mismatch reftest is expected to pass, the other is expected to
fail. The failed one is marked as 'WONTFIX' in test expectations
in chromium port and is skipped in other ports.

* fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html: Added.
* fast/harness/sample-fail-mismatch-reftest.html: Added.
* fast/harness/sample-mismatch-reftest-expected-mismatch.html: Added.
* fast/harness/sample-mismatch-reftest.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoComputing screen-space transform for LayerChromium and CCLayerImpl
commit-queue@webkit.org [Wed, 17 Aug 2011 01:24:44 +0000 (01:24 +0000)]
Computing screen-space transform for LayerChromium and CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=66114

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-16
Reviewed by James Robinson.

Source/WebCore:

Test: compositing/backface-visibility-hierarchical-transform.html

Added a data member to LayerChromium and CCLayerImpl that holds
the screen-space transform.   The transform is computed in
calculateDrawTransformsAndVisibility(), which is used during
updating (LayerChromium) and drawing (CCLayerImpl).  This transform
will also be used for other things, such as HUD drawing, in upcoming
patches.

Also fixed a FIXME in LayerRendererChromium::drawLayer, which
was not computing the entire hierarchy of transforms to determine
back-face visibility.  Now it simply uses the screen space transform.

* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::screenSpaceDrawTransform):
(WebCore::LayerChromium::setScreenSpaceDrawTransform):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
(WebCore::calculateDrawTransformsAndVisibility):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::screenSpaceDrawTransform):
(WebCore::CCLayerImpl::setScreenSpaceDrawTransform):

LayoutTests:

This case tests if backface visibility properly accounts for a hierarchy
of transforms.

* compositing/backface-visibility-hierarchical-transform-expected.png: Added.
* compositing/backface-visibility-hierarchical-transform-expected.txt: Added.
* compositing/backface-visibility-hierarchical-transform.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore rebaselines for Windows WebKit2 port.
rniwa@webkit.org [Wed, 17 Aug 2011 01:11:04 +0000 (01:11 +0000)]
More rebaselines for Windows WebKit2 port.

* platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
* platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt:
* platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement proper handling of events which happen in children of shadow hosts.
hayato@chromium.org [Wed, 17 Aug 2011 00:57:31 +0000 (00:57 +0000)]
Implement proper handling of events which happen in children of shadow hosts.
https://bugs.webkit.org/show_bug.cgi?id=66285

Reviewed by Dimitri Glazkov.

Fix the issue where a shadow host stops an event propagation if an
event happens at the children of shadow hosts, outside of the shadow root.

Source/WebCore:

Test: fast/dom/shadow/shadow-contents-event.html

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::adjustToShadowBoundaries):

LayoutTests:

* fast/dom/shadow/details-summary-mouseover-expected.txt: Removed.
* fast/dom/shadow/details-summary-mouseover.html: Removed.
* fast/dom/shadow/shadow-contents-event-expected.txt: Added.
* fast/dom/shadow/shadow-contents-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(92717): WinPort needs to parse version information from port_name
eric@webkit.org [Wed, 17 Aug 2011 00:55:27 +0000 (00:55 +0000)]
REGRESSION(92717): WinPort needs to parse version information from port_name
https://bugs.webkit.org/show_bug.cgi?id=66325

Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).

* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake it possible to explicitly prevent a preflight via ThreadableLoaderOptions
commit-queue@webkit.org [Wed, 17 Aug 2011 00:16:22 +0000 (00:16 +0000)]
Make it possible to explicitly prevent a preflight via ThreadableLoaderOptions
https://bugs.webkit.org/show_bug.cgi?id=65694

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2011-08-16
Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests since there is no change in behavior.

* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
* loader/ThreadableLoader.h:
(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
* notifications/Notification.cpp:
(WebCore::Notification::startLoading):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):

Source/WebKit/chromium:

* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::loadAsynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange webkit-patch analyze-baselines to print in a more unix-friendly way
abarth@webkit.org [Tue, 16 Aug 2011 23:51:37 +0000 (23:51 +0000)]
Change webkit-patch analyze-baselines to print in a more unix-friendly way
https://bugs.webkit.org/show_bug.cgi?id=66349

Reviewed by James Robinson.

As requested by jamesr.

* Scripts/webkitpy/tool/commands/rebaseline.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowin-wk2 needs updated baselines for some editing tests
rniwa@webkit.org [Tue, 16 Aug 2011 23:30:13 +0000 (23:30 +0000)]
win-wk2 needs updated baselines for some editing tests
https://bugs.webkit.org/show_bug.cgi?id=66344

win-wk2 didn't have some necessary baselines for an earlier patch;
they have been copied directly from LayoutTests/platform/chromium-win

Patch by Wyatt Carss <wcarss@chromium.org> on 2011-08-16
Reviewed by Ryosuke Niwa.

* platform/win-wk2/editing/deleting: Added.
* platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt.
* platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-003-expected.txt.
* platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-ws-fixup-004-expected.txt.
* platform/win-wk2/editing/selection/transformed-selection-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@93177 268f45cc-cd09-0410-ab3c-d52691b4dbfc