WebKit-https.git
15 years ago Reviewed by Mark.
mjs [Fri, 27 Apr 2007 08:43:19 +0000 (08:43 +0000)]
    Reviewed by Mark.

        <rdar://problem/5154113> Repro ASSERT (would be crash) in KJS::GCLock::GCLock (13462)
        http://bugs.webkit.org/show_bug.cgi?id=13462

        * WebInspector/WebInspector.m:
        (-[WebInspectorPrivate dealloc]): Delay release of WebView to avoid GC re-entrancy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-27 Mark Rowe <mrowe@apple.com>
bdash [Fri, 27 Apr 2007 08:40:27 +0000 (08:40 +0000)]
2007-04-27  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        * WebCore.pro: Remove non-existent paths from qmake files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
andersca [Fri, 27 Apr 2007 08:10:54 +0000 (08:10 +0000)]
    Reviewed by Mitz.

        <rdar://problem/5165755>
        View Source is broken; empty window is shown

        Return YES for applewebdata URLs.

        * WebView/WebView.mm:
        (+[WebView _canHandleRequest:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-25 Lars Naesbye Christensen <lars@naesbye.dk>
bdash [Fri, 27 Apr 2007 07:52:27 +0000 (07:52 +0000)]
2007-04-25  Lars Naesbye Christensen <lars@naesbye.dk>

        Reviewed by Timothy Hatcher.

        http://bugs.webkit.org/show_bug.cgi?id=13477
        Bug 13477: Help and context menu cursors need dropshadows.

        * Resources/cellCursor.png:
        * Resources/contextMenuCursor.png:
        * Resources/helpCursor.png:
        * platform/mac/CursorMac.mm:
        (WebCore::contextMenuCursor):
        (WebCore::copyCursor):
        (WebCore::progressCursor):
        (WebCore::noDropCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-27 Christopher Brichford <chrisb@adobe.com>
bdash [Fri, 27 Apr 2007 07:44:03 +0000 (07:44 +0000)]
2007-04-27  Christopher Brichford  <chrisb@adobe.com>

        Reviewed by Timothy Hatcher.

        Fix for: Bug 13211: Move JavaScriptCore mac project files for apollo port
        http://bugs.webkit.org/show_bug.cgi?id=13211

        * JavaScriptCore.apolloproj/mac/JavaScriptCore.Debug.xcconfig: Added.
        * JavaScriptCore.apolloproj/mac/JavaScriptCore.Release.xcconfig: Added.
        * JavaScriptCore.apolloproj/mac/JavaScriptCore.xcconfig: Added.
        * JavaScriptCore.apolloproj/mac/JavaScriptCore.xcodeproj/project.pbxproj: Added.
        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig: Removed.
        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig: Removed.
        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig: Removed.
        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-27 Holger Freyther <freyther@kde.org>
bdash [Fri, 27 Apr 2007 07:37:26 +0000 (07:37 +0000)]
2007-04-27  Holger Freyther <freyther@kde.org>

        Reviewed by Maciej.

        Remove unmaintained CMake build system.

        * CMakeLists.txt: Removed.

2007-04-27  Holger Freyther <freyther@kde.org>

        Reviewed by Maciej.

        Remove unmaintained CMake build system.

        * CMakeLists.txt: Removed.
        * pcre/CMakeLists.txt: Removed.

2007-04-27  Holger Freyther <freyther@kde.org>

        Reviewed by Maciej.

        Remove unmaintained CMake build system.

        * CMakeLists.txt: Removed.

2007-04-27  Holger Freyther <freyther@kde.org>

        Reviewed by Maciej.

        Remove unmaintained CMake build system.

        * QtLauncher/CMakeLists.txt: Removed.
        * WebKitPart/CMakeLists.txt: Removed.

2007-04-27  Holger Freyther <freyther@kde.org>

        Reviewed by Maciej.

        Remove unmaintained CMake build system.

        * DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Removed.
        * Scripts/build-webkit: Remove references to CMake.
        * Scripts/webkitdirs.pm: Remove references to CMake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-27 Mark Rowe <mrowe@apple.com>
bdash [Fri, 27 Apr 2007 06:03:58 +0000 (06:03 +0000)]
2007-04-27  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        * JavaScriptCore.xcodeproj/project.pbxproj: Improve dependencies in Xcode project
        by marking dftables as a dependency of Generate Derived Sources rather than of
        JavaScriptCore itself.

2007-04-27  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        * JavaScriptGlue.xcodeproj/project.pbxproj: Improve dependencies in Xcode project
        by marking JavaScriptGlue as a dependency of testjsglue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-26 Matt Perry <mpComplete@gmail.com>
bdash [Fri, 27 Apr 2007 05:48:36 +0000 (05:48 +0000)]
2007-04-26  Matt Perry  <mpComplete@gmail.com>

        Reviewed by Maciej.

        Added a version check to hackAroundLibXMLEntityBug, since that bug has
        been fixed in recent versions of libxml2.

        * dom/XMLTokenizer.cpp:
        (WebCore::hackAroundLibXMLEntityBug):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-26 Christopher Brichford <chrisb@adobe.com>
bdash [Fri, 27 Apr 2007 05:36:21 +0000 (05:36 +0000)]
2007-04-26  Christopher Brichford  <chrisb@adobe.com>

        Reviewed by Timothy Hatcher.

        - Fix for Bug 13204: Submit initial version of mac project files for apollo
          port of WebCore
          http://bugs.webkit.org/show_bug.cgi?id=13204

        * WebCore.apolloproj/mac/WebCore.Debug.xcconfig: Added.
        * WebCore.apolloproj/mac/WebCore.Release.xcconfig: Added.
        * WebCore.apolloproj/mac/WebCore.xcconfig: Added.
        * WebCore.apolloproj/mac/WebCore.xcodeproj/project.pbxproj: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-26 Alp Toker <alp@atoker.com>
bdash [Fri, 27 Apr 2007 05:11:50 +0000 (05:11 +0000)]
2007-04-26  Alp Toker  <alp@atoker.com>

        Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=13505
        Cast loses precision on x86_64

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::beginTransparencyLayer):
        (WebCore::GraphicsContext::endTransparencyLayer):
        Use a stack of opacity values instead of Cairo user data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-26 Alp Toker <alp@atoker.com>
bdash [Fri, 27 Apr 2007 05:09:15 +0000 (05:09 +0000)]
2007-04-26  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        * GdkLauncher/main.cpp:
        (main): Avoid use of deprecated API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-26 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 27 Apr 2007 05:00:58 +0000 (05:00 +0000)]
2007-04-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13500
          REGRESSION: Listbox scrollbar does not reflect actual scrolled position when selected option is added after layout

        Test: fast/forms/listbox-scrollbar-incremental-load.html

        The scroller position was not updated correctly during insertion, since
        scrollbar proportions are updated only during layout

        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::selectionChanged): Delay scrolling to reveal the
        selection until after layout if m_optionsChanged is set. Layout is
        guaranteed to happen soon when the flag is set.

2007-04-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13500
          REGRESSION: Listbox scrollbar does not reflect actual scrolled position when selected option is added after layout

        * fast/forms/listbox-scrollbar-incremental-load-expected.checksum: Added.
        * fast/forms/listbox-scrollbar-incremental-load-expected.png: Added.
        * fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
        * fast/forms/listbox-scrollbar-incremental-load.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix -- added #includes that we used to get implicitly through
ggaren [Fri, 27 Apr 2007 01:41:40 +0000 (01:41 +0000)]
    Build fix -- added #includes that we used to get implicitly through
        JSStringRef.h.

        * API/JSNode.c:
        * API/JSNodeList.c:
        * API/minidom.c:
        * API/testapi.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej Stachowiak, Adam Roben.
ggaren [Fri, 27 Apr 2007 01:15:54 +0000 (01:15 +0000)]
    Reviewed by Maciej Stachowiak, Adam Roben.

        Fixed
        <rdar://problem/4885130> Remove #include of JSStringRefCF.h from JSStringRef.h
        <rdar://problem/4885123> JavaScriptCore is not cross-platform -- JSStringRef.h references CF datatypes

        * API/JSStringRef.h: Removed #include -- no clients need it anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix layout test results jnow that we no longer make empty render texts.
hyatt [Fri, 27 Apr 2007 00:36:48 +0000 (00:36 +0000)]
Fix layout test results jnow that we no longer make empty render texts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix layout test results jnow that we no longer make empty render texts.
hyatt [Fri, 27 Apr 2007 00:35:17 +0000 (00:35 +0000)]
Fix layout test results jnow that we no longer make empty render texts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix layout test results jnow that we no longer make empty render texts.
hyatt [Fri, 27 Apr 2007 00:34:17 +0000 (00:34 +0000)]
Fix layout test results jnow that we no longer make empty render texts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix layout test results jnow that we no longer make empty render texts.
hyatt [Fri, 27 Apr 2007 00:33:23 +0000 (00:33 +0000)]
Fix layout test results jnow that we no longer make empty render texts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for 13511, crash on a counters page. Make sure that RenderTexts
hyatt [Fri, 27 Apr 2007 00:30:34 +0000 (00:30 +0000)]
    Fix for 13511, crash on a counters page.  Make sure that RenderTexts
        never get a null StringImpl.  I would have added an assert that the length
        had to be nonzero also, but unfortunately editing creates empty RenderTexts
        because of its EditingText DOM subclass that always forces renderers to be
        made.  I suppose there is a good reason for this...

        Reviewed by aroben

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData):
        (WebCore::CharacterData::appendData):
        (WebCore::CharacterData::insertData):
        (WebCore::CharacterData::deleteData):
        (WebCore::CharacterData::replaceData):
        * rendering/RenderCounter.cpp:
        (WebCore::RenderCounter::RenderCounter):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::RenderText):
        (WebCore::RenderText::trimmedPrefWidths):
        (WebCore::RenderText::setTextWithOffset):
        (WebCore::RenderText::setTextInternal):
        (WebCore::RenderText::setText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
aliceli1 [Thu, 26 Apr 2007 23:21:45 +0000 (23:21 +0000)]
    Reviewed by Oliver.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::selectAll):
        adding null check

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 26 Apr 2007 21:53:59 +0000 (21:53 +0000)]
LayoutTests:

        Reviewed by oliver

        <rdar://problem/5120591> Crash when creating a link in Leopard wiki server

        * editing/execCommand/5120591-expected.checksum: Added.
        * editing/execCommand/5120591-expected.png: Added.
        * editing/execCommand/5120591-expected.txt: Added.
        * editing/execCommand/5120591.html: Added.

WebCore:

        Reviewed by oliver

        <rdar://problem/5120591>
        Crash when creating a link in Leopard wiki server

        * editing/CreateLinkCommand.cpp:
        (WebCore::CreateLinkCommand::doApply): Use a RefPtr,
        setting the anchor's href can destroy it if there is
        an ancestor with a subtree modified event listener.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-25 David Kilzer <ddkilzer@apple.com>
ddkilzer [Thu, 26 Apr 2007 21:15:26 +0000 (21:15 +0000)]
2007-04-25  David Kilzer  <ddkilzer@apple.com>

        Reviewed by Maciej.

        Add assertions for debug builds.

        * kjs/JSLock.cpp:
        (KJS::JSLock::lock): Assert the return value of pthread_mutex_lock() in debug builds.
        (KJS::JSLock::unlock): Assert the return value of pthread_mutex_unlock() in debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Changed debugging statements for more information.
kmccullo [Thu, 26 Apr 2007 20:37:04 +0000 (20:37 +0000)]
    - Changed debugging statements for more information.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by hyatt
hyatt [Thu, 26 Apr 2007 19:51:11 +0000 (19:51 +0000)]
    Reviewed by hyatt

        - http://bugs.webkit.org/show_bug.cgi?id=13496
          Eliminate repaintObjectsBeforeLayout

        No tests added since there is no change to functionality. Several
        tests in fast/repaint test repainting of objects that move during layout.

        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlockChildren): Removed an early
        setNeedsLayout(false). Resetting the bit here prevents the full repaint
        that we rely on when we decide not to repaint children that move.
        * rendering/RenderBlock.h:
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::setCellWidths): Replaced the call to
        repaintObjectsBeforeLayout() if the cell didn't need layout with
        an unconditional repaint(). We don't bother with repainting only the
        delta between the old and new widths, since by marking the cell for
        layout results in a full repaint with the new width anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for 13509. Don't recur to parent inline flows if they have been
hyatt [Thu, 26 Apr 2007 19:24:39 +0000 (19:24 +0000)]
    Fix for 13509.  Don't recur to parent inline flows if they have been
        marked as needing layout themselves.

        Reviewed by adele

        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::dirtyLinesFromChangedChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-26 Matt Perry <mpComplete@gmail.com>
ap [Thu, 26 Apr 2007 19:21:33 +0000 (19:21 +0000)]
2007-04-26  Matt Perry  <mpComplete@gmail.com>

        Reviewed and landed by Alexey.

        http://bugs.webkit.org/show_bug.cgi?id=13495
        Crash when referencing an undefined entity in an XHTML document

        Test: fast/parser/badentity.xhtml

        * dom/XMLTokenizer.cpp:
        (WebCore::getEntityHandler): Check for a NULL returned from getXHTMLEntity

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
andersca [Thu, 26 Apr 2007 18:37:56 +0000 (18:37 +0000)]
    Reviewed by Hyatt.

        <rdar://problem/4851944>
        REGRESSION: With TOT, BMP images can no longer be opened in the browser window

        On Tiger, the MIME type for the com.microsoft.bmp UTI isn't in the registry, so add it manually.

        * platform/MimeTypeRegistry.cpp:
        (WebCore::initialiseSupportedImageMIMETypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 13503, invalidateContainingBlockPrefWidths is 15% of the
hyatt [Thu, 26 Apr 2007 18:30:14 +0000 (18:30 +0000)]
    Fix for bug 13503, invalidateContainingBlockPrefWidths is 15% of the
        nesting PLT.  Avoid O(n^2) behavior by including inlines in the minmax
        dirty chain.

        Reviewed by kevin

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::calcInlinePrefWidths):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setPrefWidthsDirty):
        (WebCore::RenderObject::invalidateContainerPrefWidths):
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Adding debugging statements to see why these tests fail. These will be...
kmccullo [Thu, 26 Apr 2007 18:11:18 +0000 (18:11 +0000)]
    - Adding debugging statements to see why these tests fail.  These will be removed.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
andersca [Thu, 26 Apr 2007 17:37:41 +0000 (17:37 +0000)]
    Reviewed by Darin.

        <rdar://problem/5067925>
        Reproducible crash (infinite recursion) with a layout test that submits on unload (13078)

        Ask the document loader whether it's loading the main resource, since there are cases where the frame
        loader's variable isn't updated correctly.

        In the distant future, the frame loader shouldn't have an instance variable but this is the least intrusive fix for now.

        I couldn't come up with a good test case for this since it requires running three tests in a row and scheduleLoad didn't work. Also,
        calling submit in the onunload prevents any new tests from loading!

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::isLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-26 Oliver Hunt <oliver@apple.com>
oliver [Thu, 26 Apr 2007 09:20:14 +0000 (09:20 +0000)]
2007-04-26  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Fix <rdar://problem/5061252> REGRESSION: In Gmail, image fails
        to be inserted into message field after dragging

        Don't try to create <img> tags for local image files as it results
        in the potential to submit forms that look like they have an image,
        when in reality they don't.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentWithPaths:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago ... and fix the build.
andersca [Thu, 26 Apr 2007 07:09:08 +0000 (07:09 +0000)]
    ... and fix the build.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::continueAfterNavigationPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Revert the previous change - activeDocumentLoader never returns the policy...
andersca [Thu, 26 Apr 2007 07:06:42 +0000 (07:06 +0000)]
    Revert the previous change - activeDocumentLoader never returns the policy document loader.
        Instead, add a null check for the policy document loader.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::continueAfterNavigationPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Use the active document loader instead of the policy document loader.
andersca [Thu, 26 Apr 2007 07:02:19 +0000 (07:02 +0000)]
    Use the active document loader instead of the policy document loader.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::continueAfterNavigationPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
mjs [Thu, 26 Apr 2007 06:46:44 +0000 (06:46 +0000)]
    Reviewed by Anders.

        - fix build problems

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable warning that
        gives often downright incorrect results based on guessing what will happen in 64-bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Thu, 26 Apr 2007 06:37:56 +0000 (06:37 +0000)]
WebCore:

        Reviewed by Maciej.

        <rdar://problem/5049099> documents no longer have a default base URL

        Don't call canHandleRequest if we have valid substitute data and the protocol is "applewebdata".

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::continueAfterNavigationPolicy):

WebKit:

        Reviewed by Maciej.

        <rdar://problem/5049099> documents no longer have a default base URL

        If the base URL is nil, then create a unique applewebdata URL to match what Tiger WebKit does.

        * WebView/WebFrame.mm:
        (createUniqueWebDataURL):
        (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the build for platforms which overload the abs function
slewis [Thu, 26 Apr 2007 02:10:53 +0000 (02:10 +0000)]
Fix the build for platforms which overload the abs function

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-25 Oliver Hunt <oliver@apple.com>
oliver [Thu, 26 Apr 2007 00:26:45 +0000 (00:26 +0000)]
2007-04-25  Oliver Hunt  <oliver@apple.com>

        Rubber stamped by Adele.

        Roll out WebKit changes from from r21052 to fix regression noted in
        <rdar://problem/5159556> REGRESSION: In Mail, pressing option-command- ' doesn't decrease block quote in selection

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
        (-[WebHTMLView doCommandBySelector:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd another test case that is fixed by the new lazy minmax width code.
hyatt [Wed, 25 Apr 2007 22:04:17 +0000 (22:04 +0000)]
Add another test case that is fixed by the new lazy minmax width code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 13373, make sure to invalidate the pref widths for objects
hyatt [Wed, 25 Apr 2007 21:46:21 +0000 (21:46 +0000)]
    Fix for bug 13373, make sure to invalidate the pref widths for objects
        with percentage padding.

        Reviewed by beth

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlockChildren):
        (WebCore::RenderBlock::layoutPositionedObjects):
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd padding percent test.
hyatt [Wed, 25 Apr 2007 21:44:56 +0000 (21:44 +0000)]
Add padding percent test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Comment change. Correct the header name in the endif comment.
harrison [Wed, 25 Apr 2007 21:36:22 +0000 (21:36 +0000)]
    Comment change. Correct the header name in the endif comment.

        * editing/FormatBlockCommand.h:
        Change InsertListCommand_h to FormatBlockCommand_h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
darin [Wed, 25 Apr 2007 20:25:06 +0000 (20:25 +0000)]
    Reviewed by Geoff.

        - tweak the allocator for a small speedup -- Shark showed this was a win, but I can't
          measure an improvement right now, but it's also clear these changes do no harm

        * wtf/FastMalloc.cpp:
        (WTF::LgFloor): Use ALWAYS_INLINE here; in testing I did a while back this was necessary
        to get this single-instruction function to be inlined.
        (WTF::SizeClass): Use ALWAYS_INLINE here too for the same reason. Also change the special
        case for a size of 0 to work without a branch for a bit of extra speed.
        (WTF::ByteSizeForClass): Use ALWAYS_INLINE here too for the same reason.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
darin [Wed, 25 Apr 2007 20:02:30 +0000 (20:02 +0000)]
    Reviewed by Hyatt.

        * platform/AtomicString.cpp: (WebCore::AtomicString::add):
        Removed unnecessary use of strlen to check if a string is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-25 Mitz Pettel <mitz@webkit.org>
ddkilzer [Wed, 25 Apr 2007 19:59:19 +0000 (19:59 +0000)]
2007-04-25  Mitz Pettel  <mitz@webkit.org>

        Build fix.

        * rendering/RenderListMarker.h: Undeleted the m_text member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rearchitect calcPrefWidths. The calculation is now done lazily only when...
hyatt [Wed, 25 Apr 2007 19:10:24 +0000 (19:10 +0000)]
    Rearchitect calcPrefWidths.  The calculation is now done lazily only when minPrefWidth
        or maxPrefWidth are asked for.  The result of the calculation is cached.

        The new invalidation scheme for pref width invalidation follows the
        containing block hierarchy and knows to halt at positioned objects, since
        they cannot influence the size of their containers.

        Reviewed by darin

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::init):
        (WebCore::CSSStyleSelector::initForStyleResolve):
        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        * rendering/RenderApplet.cpp:
        (WebCore::RenderApplet::layout):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::makeChildrenNonInline):
        (WebCore::RenderBlock::removeChild):
        (WebCore::RenderBlock::layout):
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::calcPrefWidths):
        (WebCore::InlineMinMaxIterator::endOfInline):
        (WebCore::shouldGrowTableCellForImage):
        (WebCore::RenderBlock::calcInlinePrefWidths):
        (WebCore::RenderBlock::calcBlockPrefWidths):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::setStyle):
        (WebCore::RenderBox::minPrefWidth):
        (WebCore::RenderBox::maxPrefWidth):
        (WebCore::RenderBox::calcWidth):
        (WebCore::RenderBox::calcWidthUsing):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteHorizontalValues):
        * rendering/RenderBox.h:
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::removeChildNode):
        (WebCore::RenderContainer::appendChildNode):
        (WebCore::RenderContainer::insertChildNode):
        (WebCore::RenderContainer::layout):
        * rendering/RenderContainer.h:
        (WebCore::RenderContainer::moveChildNode):
        * rendering/RenderCounter.cpp:
        (WebCore::RenderCounter::dirtyLineBoxes):
        (WebCore::RenderCounter::calcPrefWidths):
        * rendering/RenderCounter.h:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::calcPrefWidths):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
        (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
        (WebCore::RenderFlexibleBox::calcPrefWidths):
        (WebCore::RenderFlexibleBox::layoutBlock):
        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::layout):
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::layout):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::layout):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::layout):
        * rendering/RenderInline.cpp:
        * rendering/RenderInline.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::updateFromElement):
        (WebCore::RenderListBox::calcPrefWidths):
        * rendering/RenderListItem.cpp:
        (WebCore::firstNonMarkerChild):
        (WebCore::RenderListItem::updateMarkerLocation):
        (WebCore::RenderListItem::calcPrefWidths):
        (WebCore::RenderListItem::layout):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::layout):
        (WebCore::RenderListMarker::calcPrefWidths):
        (WebCore::RenderListMarker::updateMargins):
        * rendering/RenderListMarker.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject):
        (WebCore::RenderObject::removeChildNode):
        (WebCore::RenderObject::moveChildNode):
        (WebCore::RenderObject::appendChildNode):
        (WebCore::RenderObject::insertChildNode):
        (WebCore::RenderObject::setPrefWidthsDirty):
        (WebCore::RenderObject::invalidateContainingBlockPrefWidths):
        (WebCore::RenderObject::information):
        (WebCore::RenderObject::setStyle):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::layer):
        (WebCore::RenderObject::hasLayer):
        (WebCore::RenderObject::prefWidthsDirty):
        (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
        (WebCore::RenderObject::setHasLayer):
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::layout):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::layout):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGHiddenContainer.cpp:
        * rendering/RenderSVGHiddenContainer.h:
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::layout):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::calcWidth):
        (WebCore::RenderTable::layout):
        (WebCore::RenderTable::removeChildNode):
        * rendering/RenderTable.h:
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::layout):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::removeChildNode):
        * rendering/RenderTableSection.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::trimmedPrefWidths):
        (WebCore::isSpaceAccordingToStyle):
        (WebCore::RenderText::minPrefWidth):
        (WebCore::RenderText::maxPrefWidth):
        (WebCore::RenderText::calcPrefWidths):
        (WebCore::RenderText::width):
        * rendering/RenderText.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::RenderView):
        (WebCore::RenderView::calcPrefWidths):
        (WebCore::RenderView::layout):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-25 Steve Falkenburg <sfalken@apple.com>
sfalken [Wed, 25 Apr 2007 19:01:22 +0000 (19:01 +0000)]
2007-04-25  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam.

        Mac callbacks for new spelling methods in WebEditorClient.
        Not used yet.

        * WebCoreSupport/WebEditorClient.h:
        (WebEditorClient::ignoreWordInSpellDocument):
        (WebEditorClient::learnWord):
        (WebEditorClient::checkSpellingOfString):
        (WebEditorClient::checkGrammarOfString):
        (WebEditorClient::updateSpellingUIWithGrammarString):
        (WebEditorClient::updateSpellingUIWithMisspelledWord):
        (WebEditorClient::showSpellingUI):
        (WebEditorClient::spellingUIIsShowing):
        (WebEditorClient::getGuessesForWord):

2007-04-25  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam.

        Fix spelling error in spelling method name.
        Expose new spelling callback methods to all platforms.

        * bridge/EditorClient.h:
        * platform/gdk/EditorClientGdk.cpp:
        (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
        * platform/gdk/EditorClientGdk.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString):
        (WebCore::SVGEmptyEditorClient::getGuessesForWord):

2007-04-25  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam.

        Fix spelling error in spelling method name.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::updateSpellingUIWithGrammarString):
        * WebCoreSupport/EditorClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ggaren [Wed, 25 Apr 2007 18:42:05 +0000 (18:42 +0000)]
WebCore:

        Reviewed by Darin Adler, Tim Hatcher.

        Fixed a few NSAutoreleasePool issues I noticed while reviewing Brady's patch.

        * platform/graphics/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::setCompositeOperation): Call -drain instead of
        -release, since -release is a no-op in a GC world.

WebKit:

        Reviewed by Darin Adler, Tim Hatcher.

        Fixed a few NSAutoreleasePool issues I noticed while reviewing Brady's patch.

        * Carbon/CarbonUtils.m:
        (PoolCleaner): Call -drain instead of -release, since -release is a
        no-op in a GC world.

        * Misc/WebKitErrors.m:
        (registerErrors): Condensed onto one line.

        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase refresh]): Call -drain instead of -release, since
        -release is a no-op in a GC world.

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::setStatusbarText):

        * WebInspector/WebNodeHighlightView.m:
        (-[WebNodeHighlightView initWithHighlight:andRects:forView:]): Don't drain
        and then release because drain deallocates the receiver, so the release
        is an over-release.

        * WebView/WebView.mm:
        (-[WebView rectsForTextMatches]): Re-allocate the pool after draining it,
        because drain deallocates the receiver, so the drain would leave you without
        any autorelease pool, causing a leak and then an over-release at the bottom
        of the loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Wed, 25 Apr 2007 18:21:08 +0000 (18:21 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=13445
        NodeList access by index is slow

        * dom/ChildNodeList.cpp:
        (WebCore::ChildNodeList::item): Support iterating backwards from the last accessed node
        or from the last child.
        * dom/NodeList.h: Make cachedLength unsigned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoDon't try and return a value from a stub function with return type of void.
bdash [Wed, 25 Apr 2007 17:34:38 +0000 (17:34 +0000)]
Don't try and return a value from a stub function with return type of void.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-26 Mark Rowe <mrowe@apple.com>
bdash [Wed, 25 Apr 2007 17:32:05 +0000 (17:32 +0000)]
2007-04-26  Mark Rowe  <mrowe@apple.com>

        Gdk build fix.  Add missing stub.

        * platform/gdk/TemporaryLinkStubs.cpp:
        (Editor::advanceToNextMisspelling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
rwlbuis [Wed, 25 Apr 2007 17:21:06 +0000 (17:21 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12163
        SVG text does not appear in a scrolling <div>

        Make sure SVG text is painted when scrolling by taking into account the
relative offset of the non-SVG parent in the paintInfo rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-26 Mark Rowe <mrowe@apple.com>
bdash [Wed, 25 Apr 2007 17:08:46 +0000 (17:08 +0000)]
2007-04-26  Mark Rowe  <mrowe@apple.com>

        Fix non-Mac builds after r21081.

        Stub out new Editor methods for Qt and Gdk, and new SVGEmptyEditorClient methods
        for all non-Mac builds.

        * editing/qt/EditorQt.cpp:
        (WebCore::Editor::showSpellingGuessPanel):
        (WebCore::Editor::spellingPanelIsShowing):
        * page/qt/EventHandlerQt.cpp:
        (WebCore::EventHandler::passWheelEventToWidget):
        (WebCore::EventHandler::passMousePressEventToScrollbar):
        * platform/gdk/TemporaryLinkStubs.cpp:
        (Editor::showSpellingGuessPanel):
        (Editor::spellingPanelIsShowing):
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyEditorClient::ignoreWordInSpellDocument):
        (WebCore::SVGEmptyEditorClient::learnWord):
        (WebCore::SVGEmptyEditorClient::checkSpellingOfString):
        (WebCore::SVGEmptyEditorClient::checkGrammarOfString):
        (WebCore::SVGEmptyEditorClient::udpateSpellingUIWithGrammarString):
        (WebCore::SVGEmptyEditorClient::updateSpellingUIWithMisspelledWord):
        (WebCore::SVGEmptyEditorClient::showSpellingUI):
        (WebCore::SVGEmptyEditorClient::spellingUIIsShowing):
        (WebCore::SVGEmptyEditorClient::getGuessesForWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Ada.
andersca [Wed, 25 Apr 2007 16:35:48 +0000 (16:35 +0000)]
    Reviewed by Ada.

        <rdar://problem/5122153>
        Crash occurs at WebCore::Frame::loader() when switching to Bookmarks view while loading standalone image

        Don't call writeRawData if the data length is 0. (This is checked by the decoder for the non-raw case).

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-26 Mark Rowe <mrowe@apple.com>
bdash [Wed, 25 Apr 2007 13:57:42 +0000 (13:57 +0000)]
2007-04-26  Mark Rowe  <mrowe@apple.com>

        Gdk build fix courtesy of Alp Toker.

        * make-generated-sources.sh:  Remove conditional logic to ensure the
        script exits with the correct exit code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Wed, 25 Apr 2007 07:47:03 +0000 (07:47 +0000)]
LayoutTests:

        Reviewed by Mitz.

        <rdar://problem/4869095>
        default content type for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)

        * http/tests/xmlhttprequest/default-content-type-dashboard-expected.txt: Added.
        * http/tests/xmlhttprequest/default-content-type-dashboard.html: Added.

WebCore:

        Reviewed by Mitz.

        <rdar://problem/4869095>
        default content type for XMLHttpRequest POSTs changed (breaks Flickrator 0.1 widget)

        Use the right MIME type.

        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):

WebKitTools:

        Reviewed by Mitz.

        Add a setUseDashboardCompatibilityMode method to LayoutTestController which is used to toggle
        the dashboard compatibility mode.

        * DumpRenderTree/DumpRenderTree.m:
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (+[LayoutTestController webScriptNameForSelector:]):
        (-[LayoutTestController setUseDashboardCompatibilityMode:]):
        (runTest):
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Wed, 25 Apr 2007 06:49:08 +0000 (06:49 +0000)]
    Reviewed by Maciej.

        - second round of preparation for Hyatt's "lazy minMaxWidth" change
          http://bugs.webkit.org/show_bug.cgi?id=13431

        These are small changes that are either safe to do first, or unrelated to the main
        change in Hyatt's patch.

        - Preallocate 4 entries each in m_layoutStruct and m_spanCells to save allocation
          in AutoTableLayout.
        - Add an early exit to RenderFlow::dirtyLinesFromChangedChild.
        - Change InlineBox::hasTextChildren() to use a bit directly and never a virtual function.
        - Save a virtual function call by using a local bool variable for isTableCell().

        - Fix containingBlock() so it returns 0 for table cells with no parent.

        - Change all callers who are getting at layer() as a boolean to use hasLayer().
        - Change if statements to max() function calls (only the ones Hyatt had in his patch).
        - Remove some old kdDebug calls.
        - Tweak formatting of some code.
        - Add const in one place.

        * bindings/js/kjs_html.cpp:
        (KJS::HTMLElementFunction::callAsFunction):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::eventMayStartDrag):
        * page/Frame.cpp:
        (WebCore::Frame::clearTimers):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        * rendering/AutoTableLayout.h:
        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):
        (WebCore::InlineBox::hasTextChildren):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::nodeAtPoint):
        * rendering/InlineFlowBox.h:
        (WebCore::InlineFlowBox::InlineFlowBox):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::repaintOverhangingFloats):
        (WebCore::RenderBlock::paintChildren):
        (WebCore::RenderBlock::paintFloats):
        (WebCore::RenderBlock::fillBlockSelectionGaps):
        (WebCore::RenderBlock::insertFloatingObject):
        (WebCore::RenderBlock::floatRect):
        (WebCore::RenderBlock::lowestPosition):
        (WebCore::RenderBlock::rightmostPosition):
        (WebCore::RenderBlock::leftmostPosition):
        (WebCore::RenderBlock::addOverhangingFloats):
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::hitTestContents):
        (WebCore::RenderBlock::calcPrefWidths):
        (WebCore::InlineMinMaxIterator::next):
        (WebCore::getBorderPaddingMargin):
        (WebCore::RenderBlock::calcInlinePrefWidths):
        (WebCore::RenderBlock::calcBlockPrefWidths):
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::appendChildNode):
        (WebCore::RenderContainer::insertChildNode):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
        (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::dirtyLinesFromChangedChild):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateVisibilityStatus):
        (WebCore::RenderLayer::updateLayerPosition):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::containingBlock):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::nodeAtPoint):
        (WebCore::RenderTableRow::paint):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::nodeAtPoint):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-24 Steve Falkenburg <sfalken@apple.com>
sfalken [Wed, 25 Apr 2007 04:22:56 +0000 (04:22 +0000)]
2007-04-24  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin, Oliver.

        Refactor spelling codepaths

        * bridge/EditorClient.h:
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
        (WebCore::ContextMenu::checkOrEnableIfNeeded):
        * platform/gdk/EditorClientGdk.cpp:
        (WebCore::EditorClientGdk::ignoreWordInSpellDocument):
        (WebCore::EditorClientGdk::learnWord):
        (WebCore::EditorClientGdk::checkSpellingOfString):
        (WebCore::EditorClientGdk::checkGrammarOfString):
        (WebCore::EditorClientGdk::udpateSpellingUIWithGrammarString):
        (WebCore::EditorClientGdk::updateSpellingUIWithMisspelledWord):
        (WebCore::EditorClientGdk::showSpellingUI):
        (WebCore::EditorClientGdk::spellingUIIsShowing):
        (WebCore::EditorClientGdk::getGuessesForWord):
        * platform/gdk/EditorClientGdk.h:

2007-04-24  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Oliver.

        Spelling and grammar stubs

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::ignoreWordInSpellDocument):
        (WebCore::EditorClientQt::learnWord):
        (WebCore::EditorClientQt::checkSpellingOfString):
        (WebCore::EditorClientQt::checkGrammarOfString):
        (WebCore::EditorClientQt::udpateSpellingUIWithGrammarString):
        (WebCore::EditorClientQt::updateSpellingUIWithMisspelledWord):
        (WebCore::EditorClientQt::showSpellingUI):
        (WebCore::EditorClientQt::spellingUIIsShowing):
        (WebCore::EditorClientQt::getGuessesForWord):
        * WebCoreSupport/EditorClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
mjs [Wed, 25 Apr 2007 02:11:33 +0000 (02:11 +0000)]
    Reviewed by Oliver.

        - use custom calling convention for everything in nodes.cpp on intel gcc for 1.5% speed boost

        Nearly all functions in nodes.cpp were marked up to use the
        regparm(3) calling convention under GCC for x86, since this is
        faster and they are all guaranteed to be called only internally to
        kjs.

        The only exception is destructors, since delete doesn't know how to use a custom calling convention.

        * kjs/nodes.cpp:
        (dotExprDoesNotAllowCallsString):
        * kjs/nodes.h:
        (KJS::Node::):
        (KJS::StatementNode::):
        (KJS::NullNode::):
        (KJS::BooleanNode::):
        (KJS::NumberNode::):
        (KJS::StringNode::):
        (KJS::RegExpNode::):
        (KJS::ThisNode::):
        (KJS::ResolveNode::):
        (KJS::GroupNode::):
        (KJS::ElementNode::):
        (KJS::ArrayNode::):
        (KJS::PropertyNameNode::):
        (KJS::PropertyNode::):
        (KJS::PropertyListNode::):
        (KJS::ObjectLiteralNode::):
        (KJS::BracketAccessorNode::):
        (KJS::DotAccessorNode::):
        (KJS::ArgumentListNode::):
        (KJS::ArgumentsNode::):
        (KJS::NewExprNode::):
        (KJS::FunctionCallValueNode::):
        (KJS::FunctionCallResolveNode::):
        (KJS::FunctionCallBracketNode::):
        (KJS::FunctionCallParenBracketNode::):
        (KJS::FunctionCallDotNode::):
        (KJS::FunctionCallParenDotNode::):
        (KJS::PostfixResolveNode::):
        (KJS::PostfixBracketNode::):
        (KJS::PostfixDotNode::):
        (KJS::PostfixErrorNode::):
        (KJS::DeleteResolveNode::):
        (KJS::DeleteBracketNode::):
        (KJS::DeleteDotNode::):
        (KJS::DeleteValueNode::):
        (KJS::VoidNode::):
        (KJS::TypeOfResolveNode::):
        (KJS::TypeOfValueNode::):
        (KJS::PrefixResolveNode::):
        (KJS::PrefixBracketNode::):
        (KJS::PrefixDotNode::):
        (KJS::PrefixErrorNode::):
        (KJS::UnaryPlusNode::):
        (KJS::NegateNode::):
        (KJS::BitwiseNotNode::):
        (KJS::LogicalNotNode::):
        (KJS::MultNode::):
        (KJS::AddNode::):
        (KJS::ShiftNode::):
        (KJS::RelationalNode::):
        (KJS::EqualNode::):
        (KJS::BitOperNode::):
        (KJS::BinaryLogicalNode::):
        (KJS::ConditionalNode::):
        (KJS::AssignResolveNode::):
        (KJS::AssignBracketNode::):
        (KJS::AssignDotNode::):
        (KJS::AssignErrorNode::):
        (KJS::CommaNode::):
        (KJS::AssignExprNode::):
        (KJS::VarDeclListNode::):
        (KJS::VarStatementNode::):
        (KJS::EmptyStatementNode::):
        (KJS::ExprStatementNode::):
        (KJS::IfNode::):
        (KJS::DoWhileNode::):
        (KJS::WhileNode::):
        (KJS::ForNode::):
        (KJS::ContinueNode::):
        (KJS::BreakNode::):
        (KJS::ReturnNode::):
        (KJS::WithNode::):
        (KJS::LabelNode::):
        (KJS::ThrowNode::):
        (KJS::TryNode::):
        (KJS::ParameterNode::):
        (KJS::Parameter::):
        (KJS::FunctionBodyNode::):
        (KJS::FuncExprNode::):
        (KJS::FuncDeclNode::):
        (KJS::SourceElementsNode::):
        (KJS::CaseClauseNode::):
        (KJS::ClauseListNode::):
        (KJS::SwitchNode::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
darin [Wed, 25 Apr 2007 01:14:03 +0000 (01:14 +0000)]
    Reviewed by Adele.

        - first round of preparation for Hyatt's "lazy minMaxWidth" change
          http://bugs.webkit.org/show_bug.cgi?id=13431

        This patch limits itself to renaming and making other super-simple
        changes so that the above change will be smaller and easier to review
        and understand.

        Rename:

            calcHorizontalMinMaxWidth -> calcHorizontalPrefWidths
            calcMinMaxWidth -> calcPrefWidths
            calcMinMaxWidthInternal -> calcPrefWidthsInternal
            calcVerticalMinMaxWidth -> calcVerticalPrefWidths
            setNeedsLayoutAndMinMaxRecalc -> setNeedsLayoutAndPrefWidthsRecalc
            trimmedMinMaxWidth -> trimmedPrefWidths

            RenderObject::m_maxWidth -> RenderObject::m_maxPrefWidth
            RenderObject::m_minWidth -> RenderObject::m_minPrefWidth
            RenderObject::maxWidth() -> RenderObject::maxPrefWidth()
            RenderObject::minWidth() -> RenderObject::minPrefWidth()

        Replace m_minMaxKnown, minMaxKnown(), and setMinMaxKnown() with
        m_prefWidthsDirty, prefWidthsDirty(), and setPrefWidthsDirty(),
        a boolean with the opposite sense.

        Convert some uses of if statements into "max".

        Change many uses of layer() to hasLayer(). For now it's just a boolean
        version of layer(), but Hyatt's patch makes it faster by using a bit.

        Added a guard to use of axObjectCache() to make RenderObject destruction
        a little faster for the normal case.

        Removed some assertions that will be removed in Hyatt's patch.

        Made some functions const that will be const in Hyatt's patch.

        Put in some revised comments from Hyatt's patch.

        Removed an unneeded nil check from RenderListMarker::setStyle.

        Moved RootInlineBox::setHorizontalOverflowPositions and
        RootInlineBox::setVerticalSelectionPositions to the RootInlineBox.h
        header and marked them inline.

        * dom/Document.cpp:
        (WebCore::Document::updateStyleSelector):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::parseMappedAttribute):
        * page/Frame.cpp:
        (WebCore::Frame::forceLayoutWithPageWidthRange):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::calcPrefWidths):
        (WebCore::AutoTableLayout::calcEffectiveWidth):
        * rendering/AutoTableLayout.h:
        * rendering/CounterNode.cpp:
        (WebCore::CounterNode::recount):
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcPrefWidths):
        * rendering/FixedTableLayout.h:
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paint):
        * rendering/RenderApplet.cpp:
        (WebCore::RenderApplet::layout):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::handleCompactChild):
        (WebCore::RenderBlock::getClearDelta):
        (WebCore::RenderBlock::calcPrefWidths):
        (WebCore::RenderBlock::calcInlinePrefWidths):
        (WebCore::RenderBlock::calcBlockPrefWidths):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::RenderBox):
        (WebCore::RenderBox::nodeAtPoint):
        (WebCore::RenderBox::calcWidth):
        (WebCore::RenderBox::calcWidthUsing):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteHorizontalValues):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::minPrefWidth):
        (WebCore::RenderBox::maxPrefWidth):
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::removeChildNode):
        (WebCore::RenderContainer::appendChildNode):
        (WebCore::RenderContainer::insertChildNode):
        (WebCore::RenderContainer::layout):
        * rendering/RenderContainer.h:
        (WebCore::RenderContainer::calcPrefWidths):
        * rendering/RenderCounter.cpp:
        (WebCore::RenderCounter::calcPrefWidths):
        * rendering/RenderCounter.h:
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::calcPrefWidths):
        * rendering/RenderFieldset.h:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::calcPrefWidths):
        * rendering/RenderFileUploadControl.h:
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
        (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
        (WebCore::RenderFlexibleBox::calcPrefWidths):
        (WebCore::RenderFlexibleBox::layoutBlock):
        (WebCore::RenderFlexibleBox::allowedChildFlex):
        * rendering/RenderFlexibleBox.h:
        (WebCore::RenderFlexibleBox::hasMultipleLines):
        (WebCore::RenderFlexibleBox::isVertical):
        (WebCore::RenderFlexibleBox::isHorizontal):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::absoluteClippedOverflowRect):
        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::layout):
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::layout):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::layout):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageChanged):
        (WebCore::RenderImage::layout):
        (WebCore::RenderImage::calcPrefWidths):
        * rendering/RenderImage.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::addChildToFlow):
        (WebCore::RenderInline::splitInlines):
        (WebCore::RenderInline::splitFlow):
        (WebCore::RenderInline::calcPrefWidths):
        * rendering/RenderInline.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::updateFromElement):
        (WebCore::RenderListBox::calcPrefWidths):
        * rendering/RenderListBox.h:
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::updateValue):
        (WebCore::RenderListItem::updateMarkerLocation):
        (WebCore::RenderListItem::calcPrefWidths):
        (WebCore::RenderListItem::layout):
        (WebCore::RenderListItem::explicitValueChanged):
        * rendering/RenderListItem.h:
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::setStyle):
        (WebCore::RenderListMarker::layout):
        (WebCore::RenderListMarker::imageChanged):
        (WebCore::RenderListMarker::calcPrefWidths):
        (WebCore::RenderListMarker::calcWidth):
        * rendering/RenderListMarker.h:
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::updateOptionsWidth):
        (WebCore::RenderMenuList::calcPrefWidths):
        * rendering/RenderMenuList.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject):
        (WebCore::addLayers):
        (WebCore::RenderObject::removeLayers):
        (WebCore::RenderObject::moveLayers):
        (WebCore::RenderObject::addAbsoluteRectForLayer):
        (WebCore::RenderObject::checkForRepaintDuringLayout):
        (WebCore::RenderObject::dump):
        (WebCore::RenderObject::setStyle):
        (WebCore::RenderObject::destroy):
        (WebCore::RenderObject::recalcMinMaxWidths):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::hasLayer):
        (WebCore::RenderObject::prefWidthsDirty):
        (WebCore::RenderObject::setPrefWidthsDirty):
        (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
        (WebCore::RenderObject::calcPrefWidths):
        (WebCore::RenderObject::minPrefWidth):
        (WebCore::RenderObject::maxPrefWidth):
        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::setWidget):
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget):
        (WebCore::RenderPartObject::layout):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::calcPrefWidths):
        * rendering/RenderReplaced.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::calcPrefWidths):
        (WebCore::RenderSVGContainer::layout):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGHiddenContainer.cpp:
        (WebCore::RenderSVGHiddenContainer::calcPrefWidths):
        * rendering/RenderSVGHiddenContainer.h:
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::layout):
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::calcPrefWidths):
        * rendering/RenderSlider.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::calcWidth):
        (WebCore::RenderTable::layout):
        (WebCore::RenderTable::calcPrefWidths):
        (WebCore::RenderTable::splitColumn):
        (WebCore::RenderTable::appendColumn):
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::updateFromElement):
        (WebCore::RenderTableCell::styleOrColWidth):
        (WebCore::RenderTableCell::calcPrefWidths):
        * rendering/RenderTableCell.h:
        * rendering/RenderTableCol.cpp:
        (WebCore::RenderTableCol::updateFromElement):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::layout):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::paint):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::trimmedPrefWidths):
        (WebCore::RenderText::calcPrefWidths):
        (WebCore::RenderText::calcPrefWidthsInternal):
        (WebCore::RenderText::setText):
        * rendering/RenderText.h:
        (WebCore::RenderText::minPrefWidth):
        (WebCore::RenderText::maxPrefWidth):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::calcPrefWidths):
        * rendering/RenderTextControl.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::RenderView):
        (WebCore::RenderView::calcPrefWidths):
        (WebCore::RenderView::layout):
        * rendering/RenderView.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::layout):
        * rendering/RootInlineBox.cpp:
        * rendering/RootInlineBox.h:
        (WebCore::RootInlineBox::setHorizontalOverflowPositions):
        (WebCore::RootInlineBox::setVerticalSelectionPositions):
        * rendering/TableLayout.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Tue, 24 Apr 2007 23:50:35 +0000 (23:50 +0000)]
LayoutTests:

        Reviewed by oliver

        <rdar://problem/5156401>
        Crash when dragging text into a link inside a table cell

        Test for the crash:
        * editing/pasteboard/5156401-1-expected.checksum: Added.
        * editing/pasteboard/5156401-1-expected.png: Added.
        * editing/pasteboard/5156401-1-expected.txt: Added.
        * editing/pasteboard/5156401-1.html: Added.

        Test inserting at the end of a link where we would previously
        insert in the wrong paragraph:
        * editing/inserting/5156401-2-expected.checksum: Added.
        * editing/inserting/5156401-2-expected.png: Added.
        * editing/inserting/5156401-2-expected.txt: Added.
        * editing/inserting/5156401-2.html: Added.

WebCore:

        Reviewed by oliver

        <rdar://problem/5156401>
        Crash when dragging text into a link inside a table cell

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
        Don't avoid the anchor if doing so would skip over a line break, that
        would put content in the wrong paragraph, which can throw ReplaceSelectionCommand,
        which relies on moveParagraphs into infinite recursion.
        Renamed the input position.
        Don't need to re-fetch the enclosing anchor when preparing to push it down,
        since it hasn't changed since the top of the function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
thatcher [Tue, 24 Apr 2007 22:59:30 +0000 (22:59 +0000)]
    Reviewed by Adam.

        <rdar://problem/5133011> 64-bit: Attempting to paste copied text in a input field results in a crash at WebCore::Range::startPosition()

        Change a couple incorrect uses of LONG_MAX to INT_MAX to match the variable type they are used in.
        The LONG_MAX on 64-bit was overflowing the int variables, causing this crash on paste.

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject value]):
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::handleTextNode):
        (WebCore::TextIterator::handleTextBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago GTK Build fix, ::findEntry->KJS::findEntry
oliver [Tue, 24 Apr 2007 21:06:14 +0000 (21:06 +0000)]
    GTK Build fix, ::findEntry->KJS::findEntry

        * kjs/lookup.cpp:
        (KJS::Lookup::findEntry):
        (KJS::Lookup::find):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
thatcher [Tue, 24 Apr 2007 20:28:37 +0000 (20:28 +0000)]
    Reviewed by Adam.

        <rdar://problem/4966982> 64-bit: In a unordered list, TYPE=DISC and TYPE=CIRCLE attribute values are ignored

        We need to draw our full-circle arcs counter-clockwise, since a clockwise arc from 0 to 2π is no arc at all!
        This only worked on 32-bit due to a rounding error in CoreGraphics, causing it to draw a full circle anyway.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::drawEllipse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson [Tue, 24 Apr 2007 20:21:23 +0000 (20:21 +0000)]
WebCore:

        Reviewed by Beth, Hyatt, Ada, and Darin

        <rdar://problem/5011477> and <rdar://problem/5011514>
        Provide support for the icon.db to be moved to a different directory from the old WebKit-style
        icons, and remove the old directory if that is the case

        Support for this starts in WebCore, where we can use the metadata table in the icon.db to track
        whether or not we've ever done the import

        * WebCore.exp:
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::defaultDatabaseFilename): Changed to "Icons.db"
        (WebCore::IconDatabase::IconDatabase):
        (WebCore::IconDatabase::deleteAllPreparedStatements): Delete the new statements added
        (WebCore::IconDatabase::imported): Grab this flag from the DB or return the cached flag
        (WebCore::IconDatabase::setImported): Store this flag into the DB
        (WebCore::IconDatabase::importedQuery): Actually do the DB query for this save
        (WebCore::IconDatabase::setImportedQuery): Actually do the DB query for this retrieval
        * loader/icon/IconDatabase.h:

WebKit:

        Reviewed by Beth, Hyatt, Ada, and Darin

        <rdar://problem/5011477> and <rdar://problem/5011514>
        Provide support for the icon.db to be moved to a different directory from the old WebKit-style
        icons, and remove the old directory if that is the case

        * Misc/WebIconDatabase.mm:
        (-[WebIconDatabase init]):
        (-[WebIconDatabase _importToWebCoreFormat]): Check "imported()" to determine if a conversion is needed
          - Look for WebIconDatabaseImportDirectoryDefaultsKey for the source location for the conversion
          - Set "imported" to true in the Icons.db
          - If the new Icons.db isn't in the same patch as the old icons, delete the entire directory when finished
          - Move old icon.db to Icons.db to reflect rename
        * Misc/WebIconDatabasePrivate.h: Add WebIconDatabaseImportDirectoryDefaultsKey so a WebKit client can tell WebKit
          where to look for the old icons if their location is different from the icon.db
        * WebKit.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Setting the valid architectures to 32-bit only, so these projects
thatcher [Tue, 24 Apr 2007 18:12:54 +0000 (18:12 +0000)]
    Setting the valid architectures to 32-bit only, so these projects
        will ignore requests to build them 64-bit. Once they can be built 64-bit,
        the valid architectures can be updated.

        * Drosera/Drosera.xcodeproj/project.pbxproj:
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Tue, 24 Apr 2007 17:37:50 +0000 (17:37 +0000)]
LayoutTests:

        Reviewed by Justin.

        - test for <rdar://problem/4356361> Selection after multiple delete
          keypresses and undo selects only the last deleted character

        * editing/undo/undo-combined-delete-boundary-expected.checksum: Added.
        * editing/undo/undo-combined-delete-boundary-expected.png: Added.
        * editing/undo/undo-combined-delete-boundary-expected.txt: Added.
        * editing/undo/undo-combined-delete-boundary.html: Added.
        * editing/undo/undo-combined-delete-expected.checksum: Added.
        * editing/undo/undo-combined-delete-expected.png: Added.
        * editing/undo/undo-combined-delete-expected.txt: Added.
        * editing/undo/undo-combined-delete.html: Added.
        * editing/undo/undo-delete-boundary-expected.checksum: Added.
        * editing/undo/undo-delete-boundary-expected.png: Added.
        * editing/undo/undo-delete-boundary-expected.txt: Added.
        * editing/undo/undo-delete-boundary.html: Added.
        * editing/undo/undo-delete-expected.checksum: Added.
        * editing/undo/undo-delete-expected.png: Added.
        * editing/undo/undo-delete-expected.txt: Added.
        * editing/undo/undo-delete.html: Added.
        * editing/undo/undo-forward-delete-boundary-expected.checksum: Added.
        * editing/undo/undo-forward-delete-boundary-expected.png: Added.
        * editing/undo/undo-forward-delete-boundary-expected.txt: Added.
        * editing/undo/undo-forward-delete-boundary.html: Added.
        * editing/undo/undo-forward-delete-expected.checksum: Added.
        * editing/undo/undo-forward-delete-expected.png: Added.
        * editing/undo/undo-forward-delete-expected.txt: Added.
        * editing/undo/undo-forward-delete.html: Added.

        * editing/deleting/delete-and-undo-expected.txt: One of the delegate callbacks has changed in
        this test's result, because it reflects the selection after undoing a sequence of deletions.

WebCore:

        Reviewed by Justin.

        - fix <rdar://problem/4356361> Selection after multiple delete
          keypresses and undo selects only the last deleted character

        Test: editing/undo/undo-combined-delete-boundary.html
        Test: editing/undo/undo-combined-delete.html
        Test: editing/undo/undo-delete-boundary.html
        Test: editing/undo/undo-delete.html
        Test: editing/undo/undo-forward-delete-boundary.html
        Test: editing/undo/undo-forward-delete.html

        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::insertText): Fix obviously-wrong code where there were missing
        braces. I couldn't find any real symptom of this, but I think the fix should go in anyway.
        All layout tests still pass.
        (WebCore::TypingCommand::deleteKeyPressed): Added code to compute a selection that goes
        back to the beginning of the composite editing operation.
        (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

        * editing/Selection.h:
        * editing/Selection.cpp: (WebCore::Selection::setWithoutValidation):
        Added. Back door to allow setting the ends of a selection without revalidating,
        because we need to use it on a selection where the endpoints may no longer be
        valid due to mutations done by earlier pieces of the editing operation.

        * editing/EditCommand.h:
        (WebCore::EditCommand::startingSelection): Return a const& for speed.
        (WebCore::EditCommand::endingSelection): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Tue, 24 Apr 2007 15:06:27 +0000 (15:06 +0000)]
LayoutTests:

        Reviewed by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13448
          REGRESSION: setting an input element's value to JavaScript null gives "null"

        * fast/forms/input-null-expected.txt: Added.
        * fast/forms/input-null.html: Added.

WebCore:

        Reviewed by Mitz.

        - fix for http://bugs.webkit.org/show_bug.cgi?id=13448
          REGRESSION: setting an input element's value to JavaScript null gives "null"

        Test: fast/forms/input-null.html

        * html/HTMLInputElement.idl: Convert JS null to the empty string on setting
        DOMString attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-24 Mitz Pettel <mitz@webkit.org>
bdash [Tue, 24 Apr 2007 12:29:18 +0000 (12:29 +0000)]
2007-04-24  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13453
          Control clip isn't applied to children's backgrounds, outlines and floats

        Test: fast/forms/control-clip.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint): Apply the clip in all phases that paint
        children. Split PaintPhaseOutline and PaintPhaseChildBlockBackground into
        two phases each, applying the clip only to the children.
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintObject): Treat the scrollbar as part of the
        background rather than as a child's background, now that children are
        clipped out.

2007-04-24  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13453
          Control clip isn't applied to children's backgrounds, outlines and floats

        * fast/forms/control-clip-expected.checksum: Added.
        * fast/forms/control-clip-expected.png: Added.
        * fast/forms/control-clip-expected.txt: Added.
        * fast/forms/control-clip.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-24 Mitz Pettel <mitz@webkit.org>
bdash [Tue, 24 Apr 2007 12:27:17 +0000 (12:27 +0000)]
2007-04-24  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Oliver Hunt.

        Changed an apostrophe (') into a right single quotation mark (U+2019).

        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-24 Mitz Pettel <mitz@webkit.org>
bdash [Tue, 24 Apr 2007 12:25:05 +0000 (12:25 +0000)]
2007-04-24  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Timothy Hatcher.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13459
          The "mapped style" link next to an attribute doesn't work

        * WebInspector/webInspector/inspector.js: Added a check that the rule is
        mapped from an attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-24 Benjamin Otte <otte@gnome.org>
bdash [Tue, 24 Apr 2007 11:51:45 +0000 (11:51 +0000)]
2007-04-24  Benjamin Otte  <otte@gnome.org>

        Reviewed by Mark Rowe.

        Gdk build system improvements.

        * make-generated-sources.sh: Exit with failure status if make fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-24 Benjamin Otte <otte@gnome.org>
bdash [Tue, 24 Apr 2007 11:49:40 +0000 (11:49 +0000)]
2007-04-24  Benjamin Otte  <otte@gnome.org>

        Reviewed by Mark Rowe.

        Gdk build system improvements.

        * Projects/gdk/webcore-gdk.bkl:
        fail if running any of the commands failed. In particular
        make-generated-sources.sh

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
mjs [Tue, 24 Apr 2007 08:44:14 +0000 (08:44 +0000)]
    Reviewed by Geoff.

        - compile most of JavaScriptCore as one file for 4% JS iBench speed improvement

        * JavaScriptCore.xcodeproj/project.pbxproj: Add AllInOneFile.cpp, and remove files it includes
        from the build.
        * kjs/AllInOneFile.cpp: Added.
        * kjs/dtoa.cpp: Renamed CONST to CONST_ to avoid conflict.
        (Bigint::):
        (Bigint::nrv_alloc):
        * kjs/lookup.cpp: Use "namspace KJS { ... }" instead of "using namespace KJS;"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber Stamped by Mark Rowe.
ggaren [Tue, 24 Apr 2007 06:37:30 +0000 (06:37 +0000)]
    Rubber Stamped by Mark Rowe.

        Disabling this test because it hangs all the time.
        (http://bugs.webkit.org/show_bug.cgi?id=13370)

        * http/tests/plugins/npapi-response-headers.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
bdakin [Tue, 24 Apr 2007 06:13:32 +0000 (06:13 +0000)]
WebCore:
        Reviewed by Adam.

        Fix for <rdar://problem/5155507> REGRESSION: Crash in
        RenderLayer::setHasVisibleContent()

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::appendChildNode): Must null-check
        enclosingLayer()
        (WebCore::RenderContainer::insertChildNode): Same.

LayoutTests:
        Reviewed by Adam.

        Test for <rdar://problem/5155507> REGRESSION: Crash in
        RenderLayer::setHasVisibleContent()

        * fast/css-generated-content/visibleContentHiddenParent-expected.checksum: Added.
        * fast/css-generated-content/visibleContentHiddenParent-expected.png: Added.
        * fast/css-generated-content/visibleContentHiddenParent-expected.txt: Added.
        * fast/css-generated-content/visibleContentHiddenParent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 13337, deep tag nesting is slow. This patch fixes a number of...
hyatt [Tue, 24 Apr 2007 04:55:54 +0000 (04:55 +0000)]
    Fix for bug 13337, deep tag nesting is slow.  This patch fixes a number of O(n^2) issues as well as making
        a few performance optimizations based off profiling.  Details next to each change below.

        Note that calcMinMaxWidth being slow is a critical separate piece of this puzzle.  Until bug 13430 is fixed,
        render tree construction will be O(n^2) (because of the minmaxrecalc bit setting being stupid enough to
        always crawl to the root of the tree) and calcMinMaxWidth will waste tons of unnecessary time.

        When these fixes are combined with the calcMinMaxWidth fix in 13430, the penguin page specified in 13337
        loads in < 2 seconds (down from an infinite hang before).

        Reviewed by aroben, ollie

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::locateCousinList):
        (WebCore::CSSStyleSelector::locateSharedStyle):
        * css/csstyleselector.h
        Cap the depth of cousin searching on the shared style optimization.  We will be willing to (at most) crawl
        up the tree the same distance that we were willing to crawl backwards through sibling lists.  Leaving it
        uncapped resulted in pathological style resolution for the case of an infinitely nested chain of singletons.

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
        (WebCore::HTMLParser::popBlock):
        Cap the number of residual style tags that we are willing to reopen.  We will reopen at most 200
        residual style tags, since the assumption is that once that many tags are on the stack, you're probably already
        every kind of bold, italic, and color of the rainbow.

        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::absoluteClippedOverflowRect):
        absoluteClippedOverflowRect can just return the empty rect when the inline flow has no line boxes instead of
        doing a bunch of work (and calling containingBlock()) for no reason.

        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::addChildToFlow):
        Remove the useless containingBlock() check from addChildToFlow.  Obviously every inline's containing block
        is a block flow.

        * rendering/bidi.cpp:
        (WebCore::inlineWidth):
        (WebCore::RenderBlock::createLineBoxes):
        Cap the depth of individual line trees to 200.  Again the assumption is that once that many open inlines exist
        all on one line that there's no way this would be intentional.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe and David Kilzer.
aroben [Tue, 24 Apr 2007 02:47:21 +0000 (02:47 +0000)]
    Reviewed by Mark Rowe and David Kilzer.

        * Scripts/build-webkit: Print the path to the run-safari script when
        finished building so that users can copy-and-paste the command to
        execute it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 13430, cap inline splitting for continuations to a maximum depth...
hyatt [Tue, 24 Apr 2007 01:27:57 +0000 (01:27 +0000)]
    Fix for bug 13430, cap inline splitting for continuations to a maximum depth of 200.

        Reviewed by olliej, antti

        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::splitInlines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-23 Alp Toker <alp@atoker.com>
bdash [Tue, 24 Apr 2007 00:59:44 +0000 (00:59 +0000)]
2007-04-23  Alp Toker  <alp@atoker.com>

        Gdk build fix. Track EventHandler change made in r21042.

        * page/gdk/EventHandlerGdk.cpp:
        (WebCore::EventHandler::passWheelEventToWidget):
        (WebCore::EventHandler::passMousePressEventToScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
thatcher [Tue, 24 Apr 2007 00:37:47 +0000 (00:37 +0000)]
    Reviewed by Darin.

        <rdar://problem/5024945> -[DOMRange lineBoxRects] doesn't include start and end nodes that have offsets

        * rendering/RenderText.cpp:
        (WebCore::RenderText::addLineBoxRects): Use min(box->len(), end) instead of special-casing UINT_MAX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix by Darin, reviewed by me.
adele [Tue, 24 Apr 2007 00:31:41 +0000 (00:31 +0000)]
    Fix by Darin, reviewed by me.

        Fix for REGRESSION: Can't upload attachments to bugzilla since the file upload control is reset immediately
        http://bugs.webkit.org/show_bug.cgi?id=13461

        * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement):
        Only clear the FileChooser if the value is empty *and* (not or) the filename is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
adele [Mon, 23 Apr 2007 23:48:28 +0000 (23:48 +0000)]
    Reviewed by Adam.

        Updated fix for <rdar://problem/4887426> Set a reasonable maximum number of recent searches for search menu

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Use a const int maxSavedResults instead of magic number 256.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the bug number for my last commit.
thatcher [Mon, 23 Apr 2007 23:45:09 +0000 (23:45 +0000)]
Fix the bug number for my last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
thatcher [Mon, 23 Apr 2007 23:42:52 +0000 (23:42 +0000)]
    Reviewed by Hyatt.

        <rdar://problem/5084400> [DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created

        Don't call selectionRect with a -1 end position, instead use the text length.

        * rendering/RenderText.cpp:
        (WebCore::RenderText::addLineBoxRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele [Mon, 23 Apr 2007 23:27:34 +0000 (23:27 +0000)]
WebCore:

        Fixed and reviewed by Darin, Adele, and Oliver.

        WebCore part of fix for <rdar://problem/5107538> REGRESSION: Page scroll when selecting characters from inline input candidate window by arrow buttons
        http://bugs.webkit.org/show_bug.cgi?id=13263

        * dom/KeyboardEvent.h: (WebCore::KeypressCommand::isEmpty): Added helper method.

WebKit:

        Fixed and reviewed by Darin, Adele, and Oliver.

        WebKit part of fix for <rdar://problem/5107538> REGRESSION: Page scroll when selecting characters from inline input candidate window by arrow buttons
        http://bugs.webkit.org/show_bug.cgi?id=13263

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):  If we have no command after calling interpretKeyEvents, we assume the input method handled the key.
        (-[WebHTMLView doCommandBySelector:]): Add noop: to the command vector, but then when actually performing actions, ignore it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago<rdar://problem/4938364> Attachment button has different string length between attrib...
pyeh [Mon, 23 Apr 2007 22:51:53 +0000 (22:51 +0000)]
<rdar://problem/4938364> Attachment button has different string length between attributeStringForRange and stringForRange
        <rdar://problem/4939536> AXLengthForTextMarkerRange returns zero length for the range of an attachment

        Reviewed by Darin.

        * bridge/mac/WebCoreAXObject.mm:
        (nsStringForReplacedNode):
        Added helper routine to check if the replaced node should be exposed as an attachment character in string representation.
        Added an additional check to make sure that text node is not considered a replaced node.
        Removed helper routine AXAttributedStringAppendReplaced since half of the functions are now taken care by nsStringForReplacedNode.
        The other half is directly used in the doAXAttributedStringForTextMarkerRange method.
        (-[WebCoreAXObject doAXStringForTextMarkerRange:]):
        (-[WebCoreAXObject doAXAttributedStringForTextMarkerRange:]):
        Both string and AttrbributedString methods will now utilize the helper routine nsStringForReplacedNode to return replacement
        characters for range occupied by attachment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix, not reviewed.
mjs [Mon, 23 Apr 2007 22:14:45 +0000 (22:14 +0000)]
    Build fix, not reviewed.

        * kjs/collector.h: Fix struct/class mismatch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
adele [Mon, 23 Apr 2007 22:10:27 +0000 (22:10 +0000)]
    Reviewed by Oliver.

        Fix for <rdar://problem/4887426> Set a reasonable maximum number of recent searches for search menu

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
        Enforce a maximum of 256 saved results for the search field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
mjs [Mon, 23 Apr 2007 22:08:40 +0000 (22:08 +0000)]
    Reviewed by Darin.

        - raise ALLOCATIONS_PER_COLLECTION to 4000, for 3.7% iBench speed improvement

        Now that the cell size is smaller and the block size is bigger, we can fit 4000 objects in
        the two spare cells the collector is willing to keep around, so collect a bit less often.

        * kjs/collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin and Geoff.
mjs [Mon, 23 Apr 2007 21:54:33 +0000 (21:54 +0000)]
    Reviewed by Darin and Geoff.

        - move mark and collectOnMainThreadOnly bits into separate bitmaps

        This saves 4 bytes per cell, allowing shrink of cell size to 32,
        which leads to a .8% speed improvement on iBench.

        This is only feasible because of all the previous changes on the branch.

        * kjs/collector.cpp:
        (KJS::allocateBlock): Adjust for some renames of constants.
        (KJS::Collector::markStackObjectsConservatively): Now that cells are 32 bytes (64
        bytes on 64-bit) the cell alignment check can be made much more strict, and also
        obsoletes the need for a % sizeof(CollectorCell) check. Also, we can mask off the low
        bits of the pointer to have a potential block pointer to look for.
        (KJS::Collector::collectOnMainThreadOnly): Use bitmap.
        (KJS::Collector::markMainThreadOnlyObjects): Use bitmap.
        (KJS::Collector::collect): When sweeping, use bitmaps directly to find mark bits.
        * kjs/collector.h:
        (KJS::): Move needed constants and type declarations here.
        (KJS::CollectorBitmap::get): Bit twiddling to get a bitmap value.
        (KJS::CollectorBitmap::set): Bit twiddling to set a bitmap bit to true.
        (KJS::CollectorBitmap::clear): Bit twiddling to set a bitmap bit to false.
        (KJS::CollectorBitmap::clearAll): Clear whole bitmap at one go.
        (KJS::Collector::cellBlock): New operation, compute the block pointer for
        a cell by masking off low bits.
        (KJS::Collector::cellOffset): New operation, compute the cell offset for a
        cell by masking off high bits and dividing (actually a shift).
        (KJS::Collector::isCellMarked): Check mark bit in bitmap
        (KJS::Collector::markCell): Set mark bit in bitmap.
        * kjs/value.h:
        (KJS::JSCell::JSCell): No more bits.
        (KJS::JSCell::marked): Let collector handle it.
        (KJS::JSCell::mark): Let collector handle it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
adele [Mon, 23 Apr 2007 21:24:50 +0000 (21:24 +0000)]
    Reviewed by Adam.

        Updating test from last checkin to include test case for select with and without a form element.

        * fast/events/onchange-select-popup-expected.txt:
        * fast/events/onchange-select-popup.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Mon, 23 Apr 2007 21:15:48 +0000 (21:15 +0000)]
LayoutTests:

        Reviewed by Hyatt & Adam.

        Tests for <rdar://problem/4807799> REGRESSION: calling select() in onSearch handler doesn't work if you hit enter to trigger the event

        * fast/events/onchange-passwordfield-expected.txt:
        * fast/events/onchange-passwordfield.html:
        * fast/events/onchange-searchfield-expected.txt:
        * fast/events/onchange-searchfield.html:
        * fast/events/onchange-select-popup-expected.txt: Added.
        * fast/events/onchange-select-popup.html: Added.
        * fast/events/onchange-textfield-expected.txt:
        * fast/events/onchange-textfield.html:
        * fast/forms/onchange-enter-submit-expected.txt:

WebCore:

        Reviewed by Hyatt & Adam.

        Fix for <rdar://problem/4807799> REGRESSION: calling select() in onSearch handler doesn't work if you hit enter to trigger the event
        Fix for <rdar://problem/5153970> onChange doesn't fire when focusing a popup, using type-ahead to select, and leaving

        This previous behavior to blur controls when hitting enter was added to achieve the result of firing the change event.  Firefox does not
        fire blur- just the change event, so this fix will match Firefox behavior.

        This also fixes a bug where we didn't fire the change event when using type-ahead selection with the popup menu.

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Fire change event instead of blur event when hitting enter.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::dispatchFocusEvent): Now that we have type-ahead selection for popups that can be opened with the arrow keys,
         we should always save the last selection when a popup gets focus, so it can be compared to the current selection when it loses focus.
        (WebCore::HTMLSelectElement::dispatchBlurEvent): For the same reasons as above, we should fire onChange for all popups on blur.

        (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire change event instead of blur event when hitting enter.  Removed an unnecessary
         check for form() before calling menuListOnChange().  Removed an unnecessary check for renderer() and usesMenuList().
        (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Remove call to blur.  Since list boxes fire the change event immediately after an
         action is taken, we don't need to fire anything after hitting enter.
        (WebCore::HTMLSelectElement::menuListOnChange): Reset m_lastOnChangeIndex after firing the change event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
thatcher [Mon, 23 Apr 2007 21:07:01 +0000 (21:07 +0000)]
    Reviewed by Darin.

        <rdar://problem/5124364> IB3 crashes when loading a nib containing a WebView that has a WebHTMLView encoded inside

        Since WebView's initWithCoder throws away all the decoded subviews, the WebHTMLView gets dealoced while it has a nil _private pointer.
        Checking for a nil _private in WehHTMLView's close fixes this crash. No need to implement a full initWithCoder for WebHTMLView since
        it will be thrown away by the WebView anyway.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView close]): Return earily if _priviate is nil.
        (-[WebHTMLView initWithFrame:]): Unrelated change that removes an AppKit version check that predates Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Ada.
andersca [Mon, 23 Apr 2007 17:07:09 +0000 (17:07 +0000)]
    Reviewed by Ada.

        <rdar://problem/5061022>
        REGRESSION: Acrobat 8 plug-in fails to scroll with trackpad two-finger scroll or mouse wheel (12995)

        Pass wheel events to all widgets.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleWheelEvent):
        * page/EventHandler.h:
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::passWheelEventToWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-23 Alp Toker <alp@atoker.com>
bdash [Mon, 23 Apr 2007 15:32:07 +0000 (15:32 +0000)]
2007-04-23  Alp Toker  <alp@atoker.com>

        Reviewed by Mark.

        Save and restore the context state when beginning and ending a transparency layer.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::beginTransparencyLayer):
        (WebCore::GraphicsContext::endTransparencyLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mark Rowe.
thatcher [Mon, 23 Apr 2007 15:01:06 +0000 (15:01 +0000)]
    Reviewed by Mark Rowe.

        Remove the "No Selection" message after leaving search mode.
        This was a regression caused by the inspector refresh.

        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-04-23 Alp Toker <alp@atoker.com>
bdash [Mon, 23 Apr 2007 14:16:40 +0000 (14:16 +0000)]
2007-04-23  Alp Toker  <alp@atoker.com>

        Reviewed by Mark.

        Further implementation and checks. The opacity layer code is not so beautiful
        but gets the job done with fewer complications than maintaining our own stack.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::translate):
        (WebCore::GraphicsContext::setPlatformStrokeThickness):
        (WebCore::GraphicsContext::beginTransparencyLayer):
        (WebCore::GraphicsContext::endTransparencyLayer):
        (WebCore::GraphicsContext::setCompositeOperation):
        (WebCore::GraphicsContext::rotate):
        (WebCore::GraphicsContext::scale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
andersca [Mon, 23 Apr 2007 14:14:26 +0000 (14:14 +0000)]
    Build fix.

        * kjs/regexp_object.h:
        RegExpObjectImpPrivate is a struct, not a class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
mjs [Mon, 23 Apr 2007 10:28:10 +0000 (10:28 +0000)]
    Reviewed by Darin.

        - shrink FunctionImp / DeclaredFunctionImp by 4 bytes, by moving parameter list to function body

        I reconciled this with a similar change in KDE kjs by Maks Orlovich <maksim@kde.org>.

        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        (KJS::FunctionImp::passInParameters):
        (KJS::FunctionImp::lengthGetter):
        (KJS::FunctionImp::getParameterName):
        * kjs/function.h:
        * kjs/function_object.cpp:
        (FunctionProtoFunc::callAsFunction):
        (FunctionObjectImp::construct):
        * kjs/nodes.cpp:
        (FunctionBodyNode::addParam):
        (FunctionBodyNode::paramString):
        (FuncDeclNode::addParams):
        (FuncDeclNode::processFuncDecl):
        (FuncExprNode::addParams):
        (FuncExprNode::evaluate):
        * kjs/nodes.h:
        (KJS::Parameter::Parameter):
        (KJS::FunctionBodyNode::numParams):
        (KJS::FunctionBodyNode::paramName):
        (KJS::FunctionBodyNode::parameters):
        (KJS::FuncExprNode::FuncExprNode):
        (KJS::FuncDeclNode::FuncDeclNode):
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable 64-bit warnings because
        they handle size_t badly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21032 268f45cc-cd09-0410-ab3c-d52691b4dbfc