justing [Thu, 16 Feb 2006 09:22:39 +0000 (09:22 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 16 Feb 2006 09:21:52 +0000 (09:21 +0000)]
WebKit:
Reviewed by darin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
Add drag and drop support to DumpRenderTree
Added a UI delegate method so that DumpRenderTree can perform dragging on its own.
Made _updateFocusState SPI, to allow us to test the behavior and appearance of
windows that have or don't have focus.
* WebView/WebHTMLView.m:
(-[WebHTMLView _updateFocusState]):
(-[NSArray viewDidMoveToWindow]):
(-[NSArray windowDidBecomeKey:]):
(-[NSArray windowDidResignKey:]):
(-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]):
(-[NSArray becomeFirstResponder]):
(-[NSArray resignFirstResponder]):
(-[WebHTMLView _formControlIsResigningFirstResponder:]):
* WebView/WebHTMLViewInternal.h:
* WebView/WebHTMLViewPrivate.h:
* WebView/WebUIDelegatePrivate.h:
* WebView/WebView.m:
WebKitTools:
Reviewed by darin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
Add drag and drop support to DumpRenderTree
Intercept the drag start using the new UI delegate method, package an NSDraggingInfo,
and send dragging updates. Put DumpRenderTree's WebView into an offscreen window.
* DumpRenderTree/DumpRenderTree.m:
(main):
(-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]):
(-[WaitUntilDoneDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
(-[WaitUntilDoneDelegate webViewFocus:]):
(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(+[LayoutTestController webScriptNameForSelector:]):
(-[LayoutTestController setWindowIsKey:]):
(-[LayoutTestController setMainFrameIsFirstResponder:]):
(-[EventSendingController init]):
(-[EventSendingController mouseDown]):
(-[EventSendingController mouseUp]):
(-[EventSendingController mouseMoveToX:Y:]):
(dumpRenderTree):
(-[DumpRenderTreeWindow isKeyWindow]):
(-[DumpRenderTreeDraggingInfo initWithImage:offset:pasteboard:source:]):
(-[DumpRenderTreeDraggingInfo dealloc]):
(-[DumpRenderTreeDraggingInfo draggingDestinationWindow]):
(-[DumpRenderTreeDraggingInfo draggingSourceOperationMask]):
(-[DumpRenderTreeDraggingInfo draggingLocation]):
(-[DumpRenderTreeDraggingInfo draggedImageLocation]):
(-[DumpRenderTreeDraggingInfo draggedImage]):
(-[DumpRenderTreeDraggingInfo draggingPasteboard]):
(-[DumpRenderTreeDraggingInfo draggingSource]):
(-[DumpRenderTreeDraggingInfo draggingSequenceNumber]):
(-[DumpRenderTreeDraggingInfo slideDraggedImageTo:]):
(-[DumpRenderTreeDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
* DumpRenderTree/TextInputController.m:
(-[TextInputController firstRectForCharactersFrom:length:]):
(-[TextInputController characterIndexForPointX:Y:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 16 Feb 2006 09:20:55 +0000 (09:20 +0000)]
Reviewed by darin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7148>
Add drag and drop support to DumpRenderTree
* css1/basic/comments-expected.checksum:
* css1/basic/comments-expected.png:
* css1/basic/containment-expected.checksum:
* css1/basic/containment-expected.png:
* css1/basic/id_as_selector-expected.checksum:
* css1/basic/id_as_selector-expected.png:
* css1/basic/inheritance-expected.checksum:
* css1/basic/inheritance-expected.png:
* css1/box_properties/border-expected.checksum:
* css1/box_properties/border-expected.png:
* css1/box_properties/border_bottom-expected.checksum:
* css1/box_properties/border_bottom-expected.png:
* css1/box_properties/border_bottom_width-expected.checksum:
* css1/box_properties/border_bottom_width-expected.png:
* css1/box_properties/border_left-expected.checksum:
* css1/box_properties/border_left-expected.png:
* css1/box_properties/border_left_width-expected.checksum:
* css1/box_properties/border_left_width-expected.png:
* css1/box_properties/border_right_inline-expected.checksum:
* css1/box_properties/border_right_inline-expected.png:
* css1/box_properties/border_right_width-expected.checksum:
* css1/box_properties/border_right_width-expected.png:
* css1/box_properties/border_style-expected.checksum:
* css1/box_properties/border_style-expected.png:
* css1/box_properties/border_top-expected.checksum:
* css1/box_properties/border_top-expected.png:
* css1/box_properties/border_top_width-expected.checksum:
* css1/box_properties/border_top_width-expected.png:
* css1/box_properties/border_width-expected.checksum:
* css1/box_properties/border_width-expected.png:
* css1/box_properties/clear-expected.checksum:
* css1/box_properties/clear-expected.png:
* css1/box_properties/clear_float-expected.checksum:
* css1/box_properties/clear_float-expected.png:
* css1/box_properties/float_elements_in_series-expected.checksum:
* css1/box_properties/float_elements_in_series-expected.png:
* css1/box_properties/float_margin-expected.checksum:
* css1/box_properties/float_margin-expected.png:
* css1/box_properties/float_on_text_elements-expected.checksum:
* css1/box_properties/float_on_text_elements-expected.png:
* css1/box_properties/height-expected.checksum:
* css1/box_properties/height-expected.png:
* css1/box_properties/margin-expected.checksum:
* css1/box_properties/margin-expected.png:
* css1/box_properties/margin_bottom-expected.checksum:
* css1/box_properties/margin_bottom-expected.png:
* css1/box_properties/margin_inline-expected.checksum:
* css1/box_properties/margin_inline-expected.png:
* css1/box_properties/margin_left-expected.checksum:
* css1/box_properties/margin_left-expected.png:
* css1/box_properties/margin_right-expected.checksum:
* css1/box_properties/margin_right-expected.png:
* css1/box_properties/margin_top-expected.checksum:
* css1/box_properties/margin_top-expected.png:
* css1/box_properties/padding-expected.checksum:
* css1/box_properties/padding-expected.png:
* css1/box_properties/padding_bottom-expected.checksum:
* css1/box_properties/padding_bottom-expected.png:
* css1/box_properties/padding_inline-expected.checksum:
* css1/box_properties/padding_inline-expected.png:
* css1/box_properties/padding_left-expected.checksum:
* css1/box_properties/padding_left-expected.png:
* css1/box_properties/padding_right-expected.checksum:
* css1/box_properties/padding_right-expected.png:
* css1/box_properties/padding_top-expected.checksum:
* css1/box_properties/padding_top-expected.png:
* css1/box_properties/width-expected.checksum:
* css1/box_properties/width-expected.png:
* css1/cascade/cascade_order-expected.checksum:
* css1/cascade/cascade_order-expected.png:
* css1/classification/display-expected.checksum:
* css1/classification/display-expected.png:
* css1/classification/list_style_type-expected.checksum:
* css1/classification/list_style_type-expected.png:
* css1/classification/white_space-expected.checksum:
* css1/classification/white_space-expected.png:
* css1/color_and_background/background-expected.checksum:
* css1/color_and_background/background-expected.png:
* css1/color_and_background/background_attachment-expected.checksum:
* css1/color_and_background/background_attachment-expected.png:
* css1/color_and_background/background_position-expected.checksum:
* css1/color_and_background/background_position-expected.png:
* css1/color_and_background/background_repeat-expected.checksum:
* css1/color_and_background/background_repeat-expected.png:
* css1/conformance/forward_compatible_parsing-expected.checksum:
* css1/conformance/forward_compatible_parsing-expected.png:
* css1/font_properties/font-expected.checksum:
* css1/font_properties/font-expected.png:
* css1/font_properties/font_family-expected.checksum:
* css1/font_properties/font_family-expected.png:
* css1/font_properties/font_size-expected.checksum:
* css1/font_properties/font_size-expected.png:
* css1/font_properties/font_weight-expected.checksum:
* css1/font_properties/font_weight-expected.png:
* css1/formatting_model/floating_elements-expected.checksum:
* css1/formatting_model/floating_elements-expected.png:
* css1/formatting_model/height_of_lines-expected.checksum:
* css1/formatting_model/height_of_lines-expected.png:
* css1/formatting_model/horizontal_formatting-expected.checksum:
* css1/formatting_model/horizontal_formatting-expected.png:
* css1/formatting_model/inline_elements-expected.checksum:
* css1/formatting_model/inline_elements-expected.png:
* css1/formatting_model/replaced_elements-expected.checksum:
* css1/formatting_model/replaced_elements-expected.png:
* css1/formatting_model/vertical_formatting-expected.checksum:
* css1/formatting_model/vertical_formatting-expected.png:
* css1/pseudo/anchor-expected.checksum:
* css1/pseudo/anchor-expected.png:
* css1/pseudo/firstletter-expected.checksum:
* css1/pseudo/firstletter-expected.png:
* css1/pseudo/firstline-expected.checksum:
* css1/pseudo/firstline-expected.png:
* css1/pseudo/multiple_pseudo_elements-expected.checksum:
* css1/pseudo/multiple_pseudo_elements-expected.png:
* css1/text_properties/letter_spacing-expected.checksum:
* css1/text_properties/letter_spacing-expected.png:
* css1/text_properties/line_height-expected.checksum:
* css1/text_properties/line_height-expected.png:
* css1/text_properties/text-transCapitalize-expected.checksum:
* css1/text_properties/text-transCapitalize-expected.png:
* css1/text_properties/text_decoration-expected.checksum:
* css1/text_properties/text_decoration-expected.png:
* css1/text_properties/text_indent-expected.checksum:
* css1/text_properties/text_indent-expected.png:
* css1/text_properties/text_transform-expected.checksum:
* css1/text_properties/text_transform-expected.png:
* css1/text_properties/vertical_align-expected.checksum:
* css1/text_properties/vertical_align-expected.png:
* css1/text_properties/word_spacing-expected.checksum:
* css1/text_properties/word_spacing-expected.png:
* css1/units/color_units-expected.checksum:
* css1/units/color_units-expected.png:
* css1/units/length_units-expected.checksum:
* css1/units/length_units-expected.png:
* css2.1/t0801-c412-hz-box-00-b-a-expected.checksum:
* css2.1/t0801-c412-hz-box-00-b-a-expected.png:
* css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum:
* css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
* css2.1/t0803-c5505-mrgn-02-c-expected.checksum:
* css2.1/t0803-c5505-mrgn-02-c-expected.png:
* css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum:
* css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
* css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum:
* css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
* css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum:
* css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
* css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
* css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
* css2.1/t1002-c5523-width-02-b-g-expected.checksum:
* css2.1/t1002-c5523-width-02-b-g-expected.png:
* css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum:
* css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
* css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum:
* css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
* css2.1/t1508-c527-font-07-b-expected.checksum:
* css2.1/t1508-c527-font-07-b-expected.png:
* editing/deleting/delete-after-span-ws-001-expected.checksum:
* editing/deleting/delete-after-span-ws-001-expected.png:
* editing/deleting/delete-after-span-ws-002-expected.checksum:
* editing/deleting/delete-after-span-ws-002-expected.png:
* editing/deleting/delete-after-span-ws-003-expected.checksum:
* editing/deleting/delete-after-span-ws-003-expected.png:
* editing/deleting/delete-and-undo-expected.checksum:
* editing/deleting/delete-and-undo-expected.png:
* editing/deleting/delete-and-undo-expected.txt:
* editing/deleting/delete-line-end-ws-001-expected.checksum:
* editing/deleting/delete-line-end-ws-001-expected.png:
* editing/deleting/delete-line-end-ws-002-expected.checksum:
* editing/deleting/delete-line-end-ws-002-expected.png:
* editing/inserting/insert-div-023-expected.checksum:
* editing/inserting/insert-div-023-expected.png:
* editing/selection/caret-and-focus-ring.html:
* editing/selection/drag-to-contenteditable-iframe-expected.checksum: Added.
* editing/selection/drag-to-contenteditable-iframe-expected.png: Added.
* editing/selection/drag-to-contenteditable-iframe-expected.txt: Added.
* editing/selection/drag-to-contenteditable-iframe.html: Added.
* editing/selection/focus_editable_html-expected.checksum:
* editing/selection/focus_editable_html-expected.png:
* editing/selection/iframe-expected.checksum:
* editing/selection/iframe-expected.png:
* editing/selection/replaced-boundaries-3-expected.checksum:
* editing/selection/replaced-boundaries-3-expected.png:
* editing/selection/select-all-001-expected.checksum:
* editing/selection/select-all-001-expected.png:
* editing/selection/select-all-002-expected.checksum:
* editing/selection/select-all-002-expected.png:
* editing/selection/select-all-003-expected.checksum:
* editing/selection/select-all-003-expected.png:
* editing/selection/select-all-004-expected.checksum:
* editing/selection/select-all-004-expected.png:
* editing/selection/select-box-expected.checksum:
* editing/selection/select-box-expected.png:
* editing/selection/selection-background.html:
* editing/selection/unrendered-001-expected.checksum:
* editing/selection/unrendered-001-expected.png:
* editing/selection/unrendered-002-expected.checksum:
* editing/selection/unrendered-002-expected.png:
* editing/selection/unrendered-003-expected.checksum:
* editing/selection/unrendered-003-expected.png:
* editing/selection/unrendered-004-expected.checksum:
* editing/selection/unrendered-004-expected.png:
* editing/selection/unrendered-005-expected.checksum:
* editing/selection/unrendered-005-expected.png:
* editing/undo/
4063751-expected.txt:
* editing/undo/redo-typing-001-expected.txt:
* editing/undo/undo-typing-001-expected.checksum:
* editing/undo/undo-typing-001-expected.png:
* editing/undo/undo-typing-001-expected.txt:
* fast/block/basic/016-expected.checksum:
* fast/block/basic/016-expected.png:
* fast/block/basic/text-indent-rtl-expected.checksum:
* fast/block/float/008-expected.checksum:
* fast/block/float/008-expected.png:
* fast/block/float/013-expected.checksum:
* fast/block/float/013-expected.png:
* fast/block/float/019-expected.checksum:
* fast/block/float/019-expected.png:
* fast/block/float/021-expected.checksum:
* fast/block/float/021-expected.png:
* fast/block/float/025-expected.checksum:
* fast/block/float/025-expected.png:
* fast/block/float/026-expected.checksum:
* fast/block/float/026-expected.png:
* fast/block/float/027-expected.checksum:
* fast/block/float/027-expected.png:
* fast/block/float/028-expected.checksum:
* fast/block/float/028-expected.png:
* fast/block/float/032-expected.checksum:
* fast/block/float/032-expected.png:
* fast/block/float/033-expected.checksum:
* fast/block/float/033-expected.png:
* fast/block/margin-collapse/103-expected.checksum:
* fast/block/margin-collapse/103-expected.png:
* fast/block/margin-collapse/104-expected.checksum:
* fast/block/margin-collapse/104-expected.png:
* fast/block/positioning/047-expected.checksum:
* fast/block/positioning/047-expected.png:
* fast/block/positioning/051-expected.checksum:
* fast/block/positioning/051-expected.png:
* fast/block/positioning/055-expected.checksum:
* fast/block/positioning/055-expected.png:
* fast/block/positioning/auto/007-expected.checksum:
* fast/block/positioning/auto/007-expected.png:
* fast/block/positioning/relayout-on-position-change-expected.checksum:
* fast/box-sizing/box-sizing-expected.checksum:
* fast/box-sizing/box-sizing-expected.png:
* fast/clip/014-expected.checksum:
* fast/clip/014-expected.png:
* fast/css-generated-content/014-expected.checksum:
* fast/css-generated-content/014-expected.png:
* fast/css/005-expected.checksum:
* fast/css/005-expected.png:
* fast/css/MarqueeLayoutTest-expected.checksum:
* fast/css/MarqueeLayoutTest-expected.png:
* fast/css/imageTileOpacity-expected.checksum:
* fast/css/imageTileOpacity-expected.png:
* fast/css/word-space-extra-expected.checksum:
* fast/css/word-space-extra-expected.png:
* fast/dom/HTMLObjectElement/object-as-frame.html:
* fast/dom/focus-contenteditable-expected.checksum:
* fast/dom/focus-contenteditable-expected.png:
* fast/dom/window-onFocus.html:
* fast/dynamic/008-expected.checksum:
* fast/dynamic/008-expected.png:
* fast/encoding/utf-16-big-endian-expected.checksum:
* fast/encoding/utf-16-big-endian-expected.png:
* fast/encoding/utf-16-little-endian-expected.checksum:
* fast/encoding/utf-16-little-endian-expected.png:
* fast/flexbox/009-expected.checksum:
* fast/flexbox/009-expected.png:
* fast/flexbox/016-expected.checksum:
* fast/flexbox/016-expected.png:
* fast/forms/001-expected.checksum:
* fast/forms/001-expected.png:
* fast/forms/003-expected.checksum:
* fast/forms/003-expected.png:
* fast/forms/004-expected.checksum:
* fast/forms/004-expected.png:
* fast/forms/HTMLOptionElement_label01-expected.checksum:
* fast/forms/HTMLOptionElement_label01-expected.png:
* fast/forms/HTMLOptionElement_label02-expected.checksum:
* fast/forms/HTMLOptionElement_label02-expected.png:
* fast/forms/HTMLOptionElement_label03-expected.checksum:
* fast/forms/HTMLOptionElement_label03-expected.png:
* fast/forms/HTMLOptionElement_label04-expected.checksum:
* fast/forms/HTMLOptionElement_label04-expected.png:
* fast/forms/button-sizes-expected.checksum:
* fast/forms/button-sizes-expected.png:
* fast/forms/checkbox-radio-onchange-expected.checksum:
* fast/forms/checkbox-radio-onchange-expected.png:
* fast/forms/form-element-geometry-expected.checksum:
* fast/forms/form-element-geometry-expected.png:
* fast/forms/indeterminate-expected.checksum:
* fast/forms/indeterminate-expected.png:
* fast/forms/option-script-expected.checksum:
* fast/forms/option-script-expected.png:
* fast/forms/option-strip-whitespace-expected.checksum:
* fast/forms/option-strip-whitespace-expected.png:
* fast/forms/radio_checked-expected.checksum:
* fast/forms/radio_checked-expected.png:
* fast/forms/radio_checked_dynamic-expected.checksum:
* fast/forms/radio_checked_dynamic-expected.png:
* fast/forms/textAreaLineHeight-expected.checksum:
* fast/forms/textAreaLineHeight-expected.png:
* fast/inline-block/tricky-baseline-expected.checksum:
* fast/inline-block/tricky-baseline-expected.png:
* fast/invalid/014-expected.checksum:
* fast/invalid/014-expected.png:
* fast/lists/008-expected.checksum:
* fast/lists/008-expected.png:
* fast/lists/li-br-expected.checksum:
* fast/lists/li-br-expected.png:
* fast/lists/olstart-expected.checksum:
* fast/lists/olstart-expected.png:
* fast/loader/form-events-back-forward.html: Removed.
* fast/loader/form-events-back-forward.html-disabled: Added.
* fast/overflow/002-expected.checksum:
* fast/overflow/002-expected.png:
* fast/overflow/003-expected.checksum:
* fast/overflow/003-expected.png:
* fast/overflow/005-expected.checksum:
* fast/overflow/005-expected.png:
* fast/overflow/006-expected.checksum:
* fast/overflow/006-expected.png:
* fast/overflow/007-expected.checksum:
* fast/overflow/007-expected.png:
* fast/overflow/image-selection-highlight-expected.checksum:
* fast/overflow/image-selection-highlight-expected.png:
* fast/overflow/overflow-auto-table-expected.checksum:
* fast/overflow/overflow-auto-table-expected.png:
* fast/overflow/overflow-rtl-expected.checksum:
* fast/overflow/overflow-rtl-expected.png:
* fast/overflow/overflow-text-hit-testing-expected.checksum:
* fast/overflow/overflow-text-hit-testing-expected.png:
* fast/overflow/scrollRevealButton-expected.checksum:
* fast/overflow/scrollRevealButton-expected.png:
* fast/parser/comments-expected.checksum:
* fast/parser/comments-expected.png:
* fast/parser/document-write-option-expected.checksum:
* fast/parser/document-write-option-expected.png:
* fast/parser/entities-in-xhtml-expected.checksum:
* fast/parser/entities-in-xhtml-expected.png:
* fast/replaced/005-expected.checksum:
* fast/replaced/005-expected.png:
* fast/replaced/width100percent-expected.checksum:
* fast/replaced/width100percent-expected.png:
* fast/selectors/166-expected.checksum:
* fast/selectors/166-expected.png:
* fast/table/023-expected.checksum:
* fast/table/023-expected.png:
* fast/table/034-expected.checksum:
* fast/table/034-expected.png:
* fast/table/040-expected.checksum:
* fast/table/040-expected.png:
* fast/table/border-collapsing/004-expected.checksum:
* fast/table/border-collapsing/004-expected.png:
* fast/table/edge-offsets-expected.checksum:
* fast/table/edge-offsets-expected.png:
* fast/table/height-percent-test-expected.checksum:
* fast/table/height-percent-test-expected.png:
* fast/table/overflowHidden-expected.checksum:
* fast/table/overflowHidden-expected.png:
* fast/table/wide-colspan-expected.checksum:
* fast/table/wide-colspan-expected.png:
* fast/table/wide-column-expected.checksum:
* fast/table/wide-column-expected.png:
* fast/text/softHyphen-expected.checksum:
* fast/text/softHyphen-expected.png:
* fast/text/whitespace/024-expected.checksum:
* fast/text/whitespace/024-expected.png:
* fast/tokenizer/004-expected.checksum:
* fast/tokenizer/004-expected.png:
* svg/custom/feDisplacementMap-01-expected.png: Removed.
* svg/custom/junk-data-expected.checksum:
* svg/custom/junk-data-expected.png:
* svg/custom/missing-xlink-expected.checksum:
* svg/custom/missing-xlink-expected.png:
* svg/custom/path-bad-data-expected.checksum:
* svg/custom/path-bad-data-expected.png:
* traversal/tree-walker-004-expected.checksum:
* traversal/tree-walker-004-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 16 Feb 2006 09:20:15 +0000 (09:20 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 16 Feb 2006 09:16:32 +0000 (09:16 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 16 Feb 2006 06:34:49 +0000 (06:34 +0000)]
JavaScriptCore:
Reviewed by Maciej, Eric.
- WebCore half of fix for <rdar://problem/
4176077> CrashTracer: 6569
crashes in DashboardClient at com.apple.JavaScriptCore:
KJS::Bindings::ObjcFallbackObjectImp::type()
WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use RefPtrs, and sent them to bed without dessert.
* bindings/jni/jni_instance.cpp: Made _instance a RefPtr
(JavaInstance::~JavaInstance):
(JObjectWrapper::JObjectWrapper):
* bindings/jni/jni_instance.h:
(KJS::Bindings::JObjectWrapper::ref):
(KJS::Bindings::JObjectWrapper::deref):
* bindings/jni/jni_runtime.cpp: Made _array a RefPtr
(JavaArray::~JavaArray):
(JavaArray::JavaArray):
* bindings/jni/jni_runtime.h:
(KJS::Bindings::JavaArray::operator=):
* bindings/objc/objc_runtime.h:
- Prohibited copying because that would muss the ref count.
- Prohibited construction without instance because an instance wrapper
without an instance is almost certainly a bug.
* bindings/objc/objc_runtime.mm:
(ObjcFallbackObjectImp::ObjcFallbackObjectImp):
* bindings/runtime.cpp:
(KJS::Bindings::Instance::Instance):
(KJS::Bindings::Instance::createBindingForLanguageInstance):
(KJS::Bindings::Instance::createRuntimeObject):
* bindings/runtime.h:
(KJS::Bindings::Instance::ref):
(KJS::Bindings::Instance::deref):
* bindings/runtime_object.cpp:
(RuntimeObjectImp::RuntimeObjectImp):
(RuntimeObjectImp::fallbackObjectGetter):
(RuntimeObjectImp::fieldGetter):
(RuntimeObjectImp::methodGetter):
(RuntimeObjectImp::getOwnPropertySlot):
(RuntimeObjectImp::put):
(RuntimeObjectImp::canPut):
* bindings/runtime_object.h:
- Removed ownsInstance data member because RefPtr takes care of
instance lifetime now.
- Prohibited copying because that would muss the ref count.
- Prohibited construction without instance because an instance wrapper
without an instance is almost certainly a bug.
(KJS::RuntimeObjectImp::getInternalInstance):
LayoutTests:
Reviewed by Eric.
- Layout test for <rdar://problem/
4176077> CrashTracer: 6569
crashes in DashboardClient at com.apple.JavaScriptCore:
KJS::Bindings::ObjcFallbackObjectImp::type()
* plugins: Added.
* plugins/undefined-property-crash-expected.txt: Added.
* plugins/undefined-property-crash.html: Added.
WebCore:
Reviewed by Maciej, Eric.
- WebCore half of fix for <rdar://problem/
4176077> CrashTracer: 6569
crashes in DashboardClient at com.apple.JavaScriptCore:
KJS::Bindings::ObjcFallbackObjectImp::type()
WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use RefPtrs, and sent them to bed without dessert.
* khtml/html/html_objectimpl.cpp:
(WebCore::HTMLAppletElementImpl::HTMLAppletElementImpl): Made
appletInstance a RefPtr
(WebCore::HTMLAppletElementImpl::getAppletInstance):
(WebCore::HTMLAppletElementImpl::detach):
(WebCore::HTMLEmbedElementImpl::HTMLEmbedElementImpl): Made
embedInstance a RefPtr
(WebCore::HTMLEmbedElementImpl::getEmbedInstance):
(WebCore::HTMLEmbedElementImpl::detach):
(WebCore::HTMLObjectElementImpl::HTMLObjectElementImpl): Made
objectInstance a RefPtr
(WebCore::HTMLObjectElementImpl::getObjectInstance):
(WebCore::HTMLObjectElementImpl::detach):
* bindings/js/JSDOMCore.cpp:
* khtml/ecma/kjs_dom.cpp:
(KJS::getRuntimeObject):
* khtml/html/html_objectimpl.h:
WebKitTools:
Reviewed by Eric.
* DumpRenderTree/DumpRenderTree.m:
(-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
Added a dummy method for the sake of LayoutTests/plugins/
undefined-property-crash.html. (It tests a crash due to fallback
object use. WebCore won't create a fallback object if the method is
not defined.)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 16 Feb 2006 06:11:16 +0000 (06:11 +0000)]
Reviewed by Tim H.
Updated the site to use the new layout.
* .htaccess: Added.
* ChangeLog:
* blog/wp-content/themes/classic: Removed.
* blog/wp-content/themes/classic/comments-popup.php: Removed.
* blog/wp-content/themes/classic/comments.php: Removed.
* blog/wp-content/themes/classic/footer.php: Removed.
* blog/wp-content/themes/classic/header.php: Removed.
* blog/wp-content/themes/classic/index.php: Removed.
* blog/wp-content/themes/classic/sidebar.php: Removed.
* blog/wp-content/themes/classic/style.css: Removed.
* blog/wp-content/themes/default: Removed.
* blog/wp-content/themes/default/404.php: Removed.
* blog/wp-content/themes/default/archive.php: Removed.
* blog/wp-content/themes/default/archives.php: Removed.
* blog/wp-content/themes/default/comments-popup.php: Removed.
* blog/wp-content/themes/default/comments.php: Removed.
* blog/wp-content/themes/default/footer.php: Removed.
* blog/wp-content/themes/default/header.php: Removed.
* blog/wp-content/themes/default/images: Removed.
* blog/wp-content/themes/default/images/kubrickbg.jpg: Removed.
* blog/wp-content/themes/default/images/kubrickbgcolor.jpg: Removed.
* blog/wp-content/themes/default/images/kubrickbgwide.jpg: Removed.
* blog/wp-content/themes/default/images/kubrickfooter.jpg: Removed.
* blog/wp-content/themes/default/images/kubrickheader.jpg: Removed.
* blog/wp-content/themes/default/index.php: Removed.
* blog/wp-content/themes/default/links.php: Removed.
* blog/wp-content/themes/default/page.php: Removed.
* blog/wp-content/themes/default/search.php: Removed.
* blog/wp-content/themes/default/searchform.php: Removed.
* blog/wp-content/themes/default/sidebar.php: Removed.
* blog/wp-content/themes/default/single.php: Removed.
* blog/wp-content/themes/default/style.css: Removed.
* blog/wp-content/themes/webkit/404.php:
* blog/wp-content/themes/webkit/archive.php:
* blog/wp-content/themes/webkit/archives.php:
* blog/wp-content/themes/webkit/footer.php:
* blog/wp-content/themes/webkit/header.php:
* blog/wp-content/themes/webkit/images: Removed.
* blog/wp-content/themes/webkit/images/bluebanner.png: Removed.
* blog/wp-content/themes/webkit/images/kubrickbg.jpg: Removed.
* blog/wp-content/themes/webkit/images/kubrickbgcolor.jpg: Removed.
* blog/wp-content/themes/webkit/images/kubrickbgwide.jpg: Removed.
* blog/wp-content/themes/webkit/images/kubrickfooter.jpg: Removed.
* blog/wp-content/themes/webkit/images/kubrickheader.jpg: Removed.
* blog/wp-content/themes/webkit/images/separator.png: Removed.
* blog/wp-content/themes/webkit/images/webkit-background.png: Removed.
* blog/wp-content/themes/webkit/index.php:
* blog/wp-content/themes/webkit/page.php:
* blog/wp-content/themes/webkit/search.php:
* blog/wp-content/themes/webkit/sidebar.php:
* blog/wp-content/themes/webkit/single.php:
* blog/wp-content/themes/webkit/style.css:
* building/build.html:
* building/checkout.html:
* coding/coding-style.html:
* coding/contributing.html:
* contact.html:
* css: Added.
* css/blue.css: Added.
* css/gray.css: Added.
* css/green.css: Added.
* css/ie.css: Added.
* css/main.css: Added.
* css/pink.css: Added.
* css/purple.css: Added.
* css/yellow.css: Added.
* footer.inc: Added.
* header.inc: Added.
* images/blue-background.png: Added.
* images/blue-bullet.png: Added.
* images/bluebanner.png: Removed.
* images/download.png: Added.
* images/end.png: Added.
* images/gray-background.png: Added.
* images/green-background.png: Added.
* images/green-bullet.png: Added.
* images/icon-gold.png: Added.
* images/icon.png: Added.
* images/ie-nav.png: Added.
* images/middle.png: Added.
* images/nav.png: Added.
* images/pink-background.png: Added.
* images/pink-bullet.png: Added.
* images/purple-background.png: Added.
* images/purple-bullet.png: Added.
* images/separator.png: Removed.
* images/webkit-background.png: Removed.
* images/welcomeopen.gif: Removed.
* images/yellow-background.png: Added.
* images/yellow-bullet.png: Added.
* index.html:
* nav.inc: Added.
* projects/accessibility/index.html:
* projects/cleanup/index.html:
* projects/compat/index.html:
* projects/css/index.html:
* projects/documentation/index.html:
* projects/dom/index.html:
* projects/editing/index.html:
* projects/forms/index.html:
* projects/html/index.html:
* projects/index.html:
* projects/javascript/index.html:
* projects/layout/index.html:
* projects/mathml/index.html:
* projects/performance/index.html:
* projects/plugins/index.html:
* projects/portability/index.html:
* projects/printing/index.html:
* projects/svg/index.html:
* projects/webkit/index.html:
* projects/xml/index.html:
* projects/xslt/index.html:
* quality/bugpriorities.html:
* quality/bugwriting.html:
* quality/bugzilla.html:
* quality/lifecycle.html:
* quality/reduction.html:
* quality/reporting.html:
* quality/testing.html:
* quality/testwriting.html:
* sidebar.css: Removed.
* sidebar.html: Removed.
* webkitdev.css: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Thu, 16 Feb 2006 04:21:14 +0000 (04:21 +0000)]
2006-02-15 Eric Seidel <eseidel@apple.com>
Add files missing from previous commit.
* svg/custom/feDisplacementMap-01-expected.checksum: Added.
* svg/custom/feDisplacementMap-01-expected.png: Added.
* svg/custom/feDisplacementMap-01-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 16 Feb 2006 00:19:21 +0000 (00:19 +0000)]
Reviewed by Eric.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4674
LEAK: WheelEventImpl leaked when mousewheel used
No test case because it requires manual mouse wheeling.
* dom/NodeImpl.cpp:
(WebCore::NodeImpl::dispatchWheelEvent): Use a RefPtr instead of just
leaking the WheelEventImpl.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 16 Feb 2006 00:16:34 +0000 (00:16 +0000)]
Reviewed by John.
- Applied the
4330457 change to CClass and ObjcClass as well.
Once plugins work in DumpRenderTree, running run-webkit-tests --leaks
will catch this.
This change isn't as critical because CClass and ObjcClass objects get
cached globally and never deleted, but it's good practice, in case we
ever do decide to delete CClass and ObjcClass objects.
This change requires prohibiting copying, because we don't do any
intelligent ref-counting -- when a Class is destroyed, it destroys its
methods and fields unconditionally. (Java classes already prohibited
copying.)
* bindings/c/c_class.cpp:
- Merged _commonInit and _commonDelete into constructor and destructor.
(CClass::CClass):
(CClass::~CClass):
(CClass::methodsNamed): Added delete callbacks
(CClass::fieldNamed): Added delete callbacks
* bindings/c/c_class.h: Prohibited copying
* bindings/c/c_instance.cpp:
(KJS::Bindings::CInstance::getClass): Changed to use the preferred
class factory method, to take advantage of the global cache.
[ Repeated changes applied to CClass for ObjcClass: ]
* bindings/objc/objc_class.h:
* bindings/objc/objc_class.mm:
(KJS::Bindings::ObjcClass::ObjcClass):
(KJS::Bindings::ObjcClass::~ObjcClass):
(KJS::Bindings::ObjcClass::methodsNamed):
(KJS::Bindings::ObjcClass::fieldNamed):
* bindings/objc/objc_runtime.h:
(KJS::Bindings::ObjcMethod::ObjcMethod): Initialized uninitialized
variable to prevent bad CFRelease.
(KJS::Bindings::ObjcMethod::~ObjcMethod): Removed erroneous ';' from
if statement to prevent bad CFRelease.
* bindings/objc/objc_runtime.cpp: Changed to use the preferred
ObjectStructPtr, for clarity.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 15 Feb 2006 23:50:09 +0000 (23:50 +0000)]
Reviewed by John.
- Fixed <rdar://problem/
4330457> CrashTracer: [REGRESSION] 3763 crashes
in Safari at com.apple.JavaScriptCore: KJS::Bindings::JavaInstance::
getClass const + 56
This was a memory leak in the bindings code. The leak was so extreme
that it would cause Safari or the JVM to abort from lack of memory.
Upon construction, Class objects create field and method objects,
storing them in CFDictionaries. The bug was that upon destruction, the
class objects released the dictionaries but didn't destroy the stored
objects.
The fix is to supply CFDictionary callbacks for destroying the values
added to the dictionary. This also requires prohibiting copying,
because we don't do any intelligent ref-counting -- when a Class is
destroyed, it destroys its methods and fields unconditionally.
* bindings/jni/jni_class.cpp:
(JavaClass::JavaClass): Added delete callbacks
* bindings/runtime.cpp: Added definitions for delete callbacks
(KJS::Bindings::deleteMethodList):
(KJS::Bindings::deleteMethod):
(KJS::Bindings::deleteField):
* bindings/runtime.h: Added declarations for delete callbacks
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 15 Feb 2006 23:04:54 +0000 (23:04 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 15 Feb 2006 22:58:40 +0000 (22:58 +0000)]
Make FontFamily compile on Win32. Fix image decoder issue with frameBufferAtIndex API.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 15 Feb 2006 22:57:09 +0000 (22:57 +0000)]
Make FontFamily compile on Win32. Fix image decoder issue with frameBufferAtIndex API.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 15 Feb 2006 22:37:24 +0000 (22:37 +0000)]
Make KWQFontFamily portable. Split it out into a cross-platform core and the Mac-specific version.
Move it to platform and rename it to FontFamily (and FontFamilyMac).
Reviewed by eric
* WebCore.xcodeproj/project.pbxproj:
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* kwq/KWQFont.h:
(QFont::firstFamily):
* kwq/KWQFont.mm:
(QFont::setFirstFamily):
* kwq/KWQFontFamily.h: Removed.
* kwq/KWQFontFamily.mm: Removed.
* platform/FontFamily.cpp: Added.
(WebCore::FontFamily::FontFamily):
(WebCore::FontFamily::~FontFamily):
(WebCore::FontFamily::operator=):
(WebCore::FontFamily::setFamily):
(WebCore::FontFamily::operator==):
* platform/FontFamily.h: Added.
(WebCore::FontFamily::family):
(WebCore::FontFamily::familyIsEmpty):
(WebCore::FontFamily::next):
(WebCore::FontFamily::appendFamily):
(WebCore::FontFamily::operator!=):
(WebCore::FontFamily::ref):
(WebCore::FontFamily::deref):
* platform/mac/FontFamilyMac.mm: Added.
(WebCore::retainDOMStringImpl):
(WebCore::releaseDOMStringImpl):
(WebCore::):
(WebCore::FontFamily::getNSFamily):
* rendering/font.h:
(khtml::FontDef::firstFamily):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 15 Feb 2006 16:36:43 +0000 (16:36 +0000)]
* English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 15 Feb 2006 14:47:17 +0000 (14:47 +0000)]
Reviewed by Tim H.
Updated page to show 10.4.4 or 10.4.5
Added support for recognizing Shiira.
* quality/reporting.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 15 Feb 2006 10:30:52 +0000 (10:30 +0000)]
2006-02-15 Oliver Hunt <ojh16@student.canterbury.ac.nz>
Reviewed by eseidel. Landed by eseidel.
Implemented feDisplacementMap.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5862
Test: svg/custom/feDisplacementMap-01.svg
* WebCore.xcodeproj/project.pbxproj: added files.
* kcanvas/KCanvasFilters.cpp:
(WebCore::KCanvasFEDisplacementMap::externalRepresentation):
* kcanvas/KCanvasFilters.h:
(WebCore::KCanvasFEDisplacementMap::KCanvasFEDisplacementMap):
(WebCore::KCanvasFEDisplacementMap::xChannelSelector):
(WebCore::KCanvasFEDisplacementMap::setXChannelSelector):
(WebCore::KCanvasFEDisplacementMap::yChannelSelector):
(WebCore::KCanvasFEDisplacementMap::setYChannelSelector):
(WebCore::KCanvasFEDisplacementMap::scale):
(WebCore::KCanvasFEDisplacementMap::setScale):
* kcanvas/device/quartz/KCanvasFilterQuartz.h:
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(WebCore::getVectorForChannel):
(WebCore::KCanvasFEDisplacementMapQuartz::getCIFilter):
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
(WebCore::KRenderingDeviceQuartz::createFilterEffect):
* kcanvas/device/quartz/filters/WKDisplacementMapFilter.cikernel: Added.
* kcanvas/device/quartz/filters/WKDisplacementMapFilter.h: Added.
* kcanvas/device/quartz/filters/WKDisplacementMapFilter.m: Added.
(+[WKDisplacementMapFilter initialize]):
(+[WKDisplacementMapFilter filterWithName:]):
(-[WKDisplacementMapFilter init]):
(-[WKDisplacementMapFilter outputImage]):
* ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp: Added.
(SVGFEDisplacementMapElementImpl::SVGFEDisplacementMapElementImpl):
(SVGFEDisplacementMapElementImpl::~SVGFEDisplacementMapElementImpl):
(SVGFEDisplacementMapElementImpl::in1):
(SVGFEDisplacementMapElementImpl::in2):
(SVGFEDisplacementMapElementImpl::xChannelSelector):
(SVGFEDisplacementMapElementImpl::yChannelSelector):
(SVGFEDisplacementMapElementImpl::scale):
(SVGFEDisplacementMapElementImpl::stringToChannel):
(SVGFEDisplacementMapElementImpl::parseMappedAttribute):
(SVGFEDisplacementMapElementImpl::filterEffect):
* ksvg2/svg/SVGFEDisplacementMapElementImpl.h: Added.
* ksvg2/svg/svgtags.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 15 Feb 2006 09:54:43 +0000 (09:54 +0000)]
2006-02-15 Eric Seidel <eseidel@apple.com>
Update missing result from last commit.
* fast/xsl/xslt-recursion-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 15 Feb 2006 09:44:49 +0000 (09:44 +0000)]
Rubber stamped by Anders.
* WebView/WebControllerPolicyHandlerDelegate.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 15 Feb 2006 09:20:41 +0000 (09:20 +0000)]
Reviewed by Anders.
- remove some voodoo code
* WebView/WebDataSource.m:
(-[WebDataSource _setLoading:]): Removed useless ref/deref of self and WebView.
A WebDataSource cannot be loading unless it is still connected to the WebView that
owns it and retained by it, because getting disconnected stops loading.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 15 Feb 2006 09:16:08 +0000 (09:16 +0000)]
2006-02-15 Eric Seidel <eseidel@apple.com>
Reviewed by darin.
Commit change forgotten after editing directory move.
* editing/markup.cpp:
(khtml::startMarkup): add support for serializing DOCTYPEs in xml
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 15 Feb 2006 05:49:40 +0000 (05:49 +0000)]
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6452
KURL::appendEscapingBadChars() doesn't know about %u-escaping.
Test case: fast/encoding/percent-escaping.html
* kwq/KWQKURL.mm: (appendEscapingBadChars):
Rather than adding support for %u, remove the existing
"do what I mean" escaping of percent characters that do not
look like a result of prior escaping.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 15 Feb 2006 03:30:42 +0000 (03:30 +0000)]
2006-02-14 Eric Seidel <eseidel@apple.com>
Fix build failure from last minute edit.
* khtml/xsl/xsl_stylesheetimpl.cpp:
(WebCore::XSLStyleSheetImpl::parseString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 15 Feb 2006 03:01:43 +0000 (03:01 +0000)]
2006-02-14 Eric Seidel <eseidel@apple.com>
Reviewed by darin.
Add incremental parsing support to XMLTokenizer.
This patch also does a few other little things:
- removes (unused) onHold support from Tokenizer
- adds serialization of DOCTYPEs for xml documents
- fixes xslt support to no longer depend on synchronous parsing
- fixes css styling for pages where xsl recursion is blocked
http://bugzilla.opendarwin.org/show_bug.cgi?id=6057
* dom/DocumentImpl.cpp:
(WebCore::DocumentImpl::DocumentImpl):
(WebCore::DocumentImpl::createProcessingInstruction):
(WebCore::DocumentImpl::open):
(WebCore::DocumentImpl::recalcStyleSelector):
* dom/dom_xmlimpl.cpp:
(WebCore::ProcessingInstructionImpl::checkStyleSheet):
* dom/xml_tokenizer.cpp:
(WebCore::XMLTokenizer::XMLTokenizer):
(WebCore::XMLTokenizer::write):
(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::error):
(WebCore::XMLTokenizer::initializeParserContext):
(WebCore::XMLTokenizer::finish):
(WebCore::xmlDocPtrForString):
(WebCore::parseAttributes):
* dom/xml_tokenizer.h:
* khtml/editing/markup.cpp:
(khtml::startMarkup): DOCTYPE serialization
* khtml/html/htmltokenizer.cpp:
(WebCore::HTMLTokenizer::HTMLTokenizer): removed onHold
(WebCore::HTMLTokenizer::reset): removed onHold
(WebCore::HTMLTokenizer::begin): removed onHold
(WebCore::HTMLTokenizer::write): removed onHold
(WebCore::HTMLTokenizer::finish): removed onHold
* khtml/html/htmltokenizer.h: removed onHold support
* khtml/xsl/xsl_stylesheetimpl.cpp:
(WebCore::XSLStyleSheetImpl::XSLStyleSheetImpl):
(WebCore::XSLStyleSheetImpl::~XSLStyleSheetImpl):
(WebCore::XSLStyleSheetImpl::document):
(WebCore::XSLStyleSheetImpl::setDocument):
(WebCore::XSLStyleSheetImpl::parseString):
(WebCore::XSLStyleSheetImpl::loadChildSheets):
(WebCore::XSLStyleSheetImpl::compileStyleSheet):
(WebCore::XSLStyleSheetImpl::locateStylesheetSubResource):
* khtml/xsl/xsl_stylesheetimpl.h: moved functions to .cpp file
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 15 Feb 2006 02:55:20 +0000 (02:55 +0000)]
Reviewed by Anders.
Improvements to frame loading:
- remove LayoutAcceptable state entirely
- fix WebImageView to work right without LayoutAcceptable state
- move guts of commitIfReady: to WebFrame
- try to separate page cache loading from normal loading a bit more
* English.lproj/StringsNotToBeLocalized.txt:
* WebView/WebDataSource.m:
(-[WebDataSource _prepareForLoadStart]):
(-[WebDataSource _loadFromPageCache:]):
(-[WebDataSource _startLoading]):
(-[WebDataSource _commitIfReady]):
(-[WebDataSource _setupForReplaceByMIMEType:]):
* WebView/WebDataSourcePrivate.h:
* WebView/WebFrame.m:
(-[WebFrame _transitionToCommitted:]):
(-[WebFrame _commitProvisionalLoad:]):
(-[WebFrame _checkLoadCompleteForThisFrame]):
(-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
* WebView/WebFramePrivate.h:
* WebView/WebImageRepresentation.h:
* WebView/WebImageRepresentation.m:
* WebView/WebImageView.m:
(-[WebImageView dataSourceUpdated:]):
(-[WebImageView setNeedsLayout:]):
(-[WebImageView writeImageToPasteboard:types:]):
(-[WebImageView copy:]):
(-[WebImageView mouseDragged:]):
* WebView/WebView.m:
(-[WebView _finishedLoadingResourceFromDataSource:]):
(-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 15 Feb 2006 02:35:29 +0000 (02:35 +0000)]
LayoutTests:
Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6815
Calculate correct width for new text fields
* fast/forms/input-appearance-width.html: Added.
* fast/forms/input-appearance-width-expected.txt: Added.
* fast/forms/input-appearance-width-expected.png: Added.
* fast/forms/input-appearance-width-expected.checksum: Added.
* fast/forms/input-appearance-minWidth.html: Added.
* fast/forms/input-appearance-minWidth-expected.txt: Added.
* fast/forms/input-appearance-minWidth-expected.png: Added.
* fast/forms/input-appearance-minWidth-expected.checksum: Added.
WebCore:
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6815
Calculate correct width for new text fields
Tests:
fast/forms/input-appearance-width.html
fast/forms/input-appearance-minWidth.html
* rendering/RenderTextField.cpp:
(WebCore::RenderTextField::createDivStyle): Remove fixed width for text field.
(WebCore::RenderTextField::calcMinMaxWidth): Added. This calls RenderBlock::calcMinMaxWidth and
then uses the size attribute to determine what the maxWidth should be.
* rendering/RenderTextField.h: Added calcMinMaxWidth.
* rendering/render_theme_mac.h: Added adjustTextFieldStyle.
* rendering/render_theme_mac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect): Remove inflation of rect. This is no longer necessary.
(WebCore::RenderThemeMac::paintTextField): ditto.
(WebCore::RenderThemeMac::setTextFieldCellState): change true to YES.
(WebCore::RenderThemeMac::adjustTextFieldStyle): Added. This is the temporary home of the code to set the
right padding and margins. When we flip the switch, this will go in html4.css.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Wed, 15 Feb 2006 02:07:07 +0000 (02:07 +0000)]
2006-02-14 Eric Seidel <eseidel@apple.com>
Reviewed by adele.
* Scripts/run-webkit-tests: added --results-directory (-o) option
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Wed, 15 Feb 2006 01:36:25 +0000 (01:36 +0000)]
Reviewed by Tim Hatcher.
removed -[DOMHTMLSelectElement _optionLabels], formerly used only by Safari, now unused.
* bindings/objc/DOMHTML.mm:
* bindings/objc/DOMPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 15 Feb 2006 00:15:17 +0000 (00:15 +0000)]
JavaScriptCore:
Reviewed by Justin.
Fixed <rdar://problem/
4415050> STD: WebCore build steps use echo -n, which will change
behavior due to POSIX version of sh
* JavaScriptCore.xcodeproj/project.pbxproj: removed the use of echo -n, replaced with printf ""
WebCore:
Reviewed by Justin.
Fixed <rdar://problem/
4415050> STD: WebCore build steps use echo -n, which will change
behavior due to POSIX version of sh
* WebCore.xcodeproj/project.pbxproj: removed the use of echo -n, replaced with printf ""
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 22:42:26 +0000 (22:42 +0000)]
One more of the same (this one tests list boxes instead of pop-up menus)
* fast/forms/HTMLOptionElement_label05-expected.checksum: Added.
* fast/forms/HTMLOptionElement_label05-expected.png: Added.
* fast/forms/HTMLOptionElement_label05-expected.txt: Added.
* fast/forms/HTMLOptionElement_label05.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 22:33:12 +0000 (22:33 +0000)]
Added another option element label test at Dave Hyatt's suggestion
* fast/forms/HTMLOptionElement_label04-expected.checksum: Added.
* fast/forms/HTMLOptionElement_label04-expected.png: Added.
* fast/forms/HTMLOptionElement_label04-expected.txt: Added.
* fast/forms/HTMLOptionElement_label04.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 14 Feb 2006 22:14:08 +0000 (22:14 +0000)]
Reviewed by Eric.
Moving these tests to a better location.
* dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Removed.
* dom/html/level2/html/HTMLOptionElement_label01-expected.png: Removed.
* dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Removed.
* dom/html/level2/html/HTMLOptionElement_label01.html: Removed.
* dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Removed.
* dom/html/level2/html/HTMLOptionElement_label02-expected.png: Removed.
* dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Removed.
* dom/html/level2/html/HTMLOptionElement_label02.html: Removed.
* dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Removed.
* dom/html/level2/html/HTMLOptionElement_label03-expected.png: Removed.
* dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Removed.
* dom/html/level2/html/HTMLOptionElement_label03.html: Removed.
* fast/forms/HTMLOptionElement_label01-expected.checksum: Added.
* fast/forms/HTMLOptionElement_label01-expected.png: Added.
* fast/forms/HTMLOptionElement_label01-expected.txt: Added.
* fast/forms/HTMLOptionElement_label01.html: Added.
* fast/forms/HTMLOptionElement_label02-expected.checksum: Added.
* fast/forms/HTMLOptionElement_label02-expected.png: Added.
* fast/forms/HTMLOptionElement_label02-expected.txt: Added.
* fast/forms/HTMLOptionElement_label02.html: Added.
* fast/forms/HTMLOptionElement_label03-expected.checksum: Added.
* fast/forms/HTMLOptionElement_label03-expected.png: Added.
* fast/forms/HTMLOptionElement_label03-expected.txt: Added.
* fast/forms/HTMLOptionElement_label03.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 14 Feb 2006 21:40:54 +0000 (21:40 +0000)]
Rubber-stamped by Eric.
- moved editing sources from khtml/editing to editing, and renamed files with single classes
* WebCore.xcodeproj/project.pbxproj: Added new, removed old.
* WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
* bridge/mac/MacFrame.mm:
* bridge/mac/WebCoreFrameBridge.mm:
* dom/DocumentImpl.cpp:
* dom/dom2_rangeimpl.cpp:
* dom/dom_position.cpp:
* khtml/khtml_events.cpp:
* kwq/KWQAccObject.mm:
* kwq/KWQAccObjectCache.h:
* kwq/KWQEditCommand.mm:
* page/Frame.cpp:
* page/FramePrivate.h:
* rendering/RenderBlock.cpp:
* rendering/RenderContainer.cpp:
* rendering/RenderText.cpp:
* rendering/render_br.cpp:
* rendering/render_inline.cpp:
* rendering/render_object.cpp:
* rendering/render_replaced.cpp:
Fixed up includes.
* editing: Added.
* editing/AppendNodeCommand.cpp: Added.
* editing/AppendNodeCommand.h: Added.
* editing/ApplyStyleCommand.cpp: Added.
* editing/ApplyStyleCommand.h: Added.
* editing/BreakBlockquoteCommand.cpp: Added.
* editing/BreakBlockquoteCommand.h: Added.
* editing/CompositeEditCommand.cpp: Added.
* editing/CompositeEditCommand.h: Added.
* editing/DeleteFromTextNodeCommand.cpp: Added.
* editing/DeleteFromTextNodeCommand.h: Added.
* editing/DeleteSelectionCommand.cpp: Added.
* editing/DeleteSelectionCommand.h: Added.
* editing/EditCommand.cpp: Added.
* editing/EditCommand.h: Added.
* editing/InsertIntoTextNodeCommand.cpp: Added.
* editing/InsertIntoTextNodeCommand.h: Added.
* editing/InsertLineBreakCommand.cpp: Added.
* editing/InsertLineBreakCommand.h: Added.
* editing/InsertNodeBeforeCommand.cpp: Added.
* editing/InsertNodeBeforeCommand.h: Added.
* editing/InsertParagraphSeparatorCommand.cpp: Added.
* editing/InsertParagraphSeparatorCommand.h: Added.
* editing/InsertTextCommand.cpp: Added.
* editing/InsertTextCommand.h: Added.
* editing/JoinTextNodesCommand.cpp: Added.
* editing/JoinTextNodesCommand.h: Added.
* editing/MergeIdenticalElementsCommand.cpp: Added.
* editing/MergeIdenticalElementsCommand.h: Added.
* editing/MoveSelectionCommand.cpp: Added.
* editing/MoveSelectionCommand.h: Added.
* editing/RebalanceWhitespaceCommand.cpp: Added.
* editing/RebalanceWhitespaceCommand.h: Added.
* editing/RemoveCSSPropertyCommand.cpp: Added.
* editing/RemoveCSSPropertyCommand.h: Added.
* editing/RemoveNodeAttributeCommand.cpp: Added.
* editing/RemoveNodeAttributeCommand.h: Added.
* editing/RemoveNodeCommand.cpp: Added.
* editing/RemoveNodeCommand.h: Added.
* editing/RemoveNodePreservingChildrenCommand.cpp: Added.
* editing/RemoveNodePreservingChildrenCommand.h: Added.
* editing/ReplaceSelectionCommand.cpp: Added.
* editing/ReplaceSelectionCommand.h: Added.
* editing/Selection.cpp:
* editing/SelectionController.cpp:
* editing/SetNodeAttributeCommand.cpp: Added.
* editing/SetNodeAttributeCommand.h: Added.
* editing/SplitElementCommand.cpp: Added.
* editing/SplitElementCommand.h: Added.
* editing/SplitTextNodeCommand.cpp: Added.
* editing/SplitTextNodeCommand.h: Added.
* editing/SplitTextNodeContainingElementCommand.cpp: Added.
* editing/SplitTextNodeContainingElementCommand.h: Added.
* editing/TypingCommand.cpp: Added.
* editing/TypingCommand.h: Added.
* editing/VisiblePosition.cpp: Added.
* editing/VisiblePosition.h: Added.
* editing/VisibleRange.cpp: Added.
* editing/VisibleRange.h: Added.
* editing/WrapContentsInDummySpanCommand.cpp: Added.
* editing/WrapContentsInDummySpanCommand.h: Added.
* editing/append_node_command.cpp: Removed.
* editing/append_node_command.h: Removed.
* editing/apply_style_command.cpp: Removed.
* editing/apply_style_command.h: Removed.
* editing/break_blockquote_command.cpp: Removed.
* editing/break_blockquote_command.h: Removed.
* editing/composite_edit_command.cpp: Removed.
* editing/composite_edit_command.h: Removed.
* editing/delete_from_text_node_command.cpp: Removed.
* editing/delete_from_text_node_command.h: Removed.
* editing/delete_selection_command.cpp: Removed.
* editing/delete_selection_command.h: Removed.
* editing/edit_command.cpp: Removed.
* editing/edit_command.h: Removed.
* editing/htmlediting.cpp:
* editing/insert_into_text_node_command.cpp: Removed.
* editing/insert_into_text_node_command.h: Removed.
* editing/insert_line_break_command.cpp: Removed.
* editing/insert_line_break_command.h: Removed.
* editing/insert_node_before_command.cpp: Removed.
* editing/insert_node_before_command.h: Removed.
* editing/insert_paragraph_separator_command.cpp: Removed.
* editing/insert_paragraph_separator_command.h: Removed.
* editing/insert_text_command.cpp: Removed.
* editing/insert_text_command.h: Removed.
* editing/join_text_nodes_command.cpp: Removed.
* editing/join_text_nodes_command.h: Removed.
* editing/jsediting.cpp:
* editing/markup.cpp:
* editing/merge_identical_elements_command.cpp: Removed.
* editing/merge_identical_elements_command.h: Removed.
* editing/move_selection_command.cpp: Removed.
* editing/move_selection_command.h: Removed.
* editing/rebalance_whitespace_command.cpp: Removed.
* editing/rebalance_whitespace_command.h: Removed.
* editing/remove_css_property_command.cpp: Removed.
* editing/remove_css_property_command.h: Removed.
* editing/remove_node_attribute_command.cpp: Removed.
* editing/remove_node_attribute_command.h: Removed.
* editing/remove_node_command.cpp: Removed.
* editing/remove_node_command.h: Removed.
* editing/remove_node_preserving_children_command.cpp: Removed.
* editing/remove_node_preserving_children_command.h: Removed.
* editing/replace_selection_command.cpp: Removed.
* editing/replace_selection_command.h: Removed.
* editing/set_node_attribute_command.cpp: Removed.
* editing/set_node_attribute_command.h: Removed.
* editing/split_element_command.cpp: Removed.
* editing/split_element_command.h: Removed.
* editing/split_text_node_command.cpp: Removed.
* editing/split_text_node_command.h: Removed.
* editing/split_text_node_containing_element.cpp: Removed.
* editing/split_text_node_containing_element_command.h: Removed.
* editing/typing_command.cpp: Removed.
* editing/typing_command.h: Removed.
* editing/visible_position.cpp: Removed.
* editing/visible_position.h: Removed.
* editing/visible_range.cpp: Removed.
* editing/visible_range.h: Removed.
* editing/visible_units.cpp:
* editing/wrap_contents_in_dummy_span_command.cpp: Removed.
* editing/wrap_contents_in_dummy_span_command.h: Removed.
* khtml/editing: Removed.
* khtml/editing/Selection.cpp: Removed.
* khtml/editing/Selection.h: Removed.
* khtml/editing/SelectionController.cpp: Removed.
* khtml/editing/SelectionController.h: Removed.
* khtml/editing/append_node_command.cpp: Removed.
* khtml/editing/append_node_command.h: Removed.
* khtml/editing/apply_style_command.cpp: Removed.
* khtml/editing/apply_style_command.h: Removed.
* khtml/editing/break_blockquote_command.cpp: Removed.
* khtml/editing/break_blockquote_command.h: Removed.
* khtml/editing/composite_edit_command.cpp: Removed.
* khtml/editing/composite_edit_command.h: Removed.
* khtml/editing/delete_from_text_node_command.cpp: Removed.
* khtml/editing/delete_from_text_node_command.h: Removed.
* khtml/editing/delete_selection_command.cpp: Removed.
* khtml/editing/delete_selection_command.h: Removed.
* khtml/editing/edit_actions.h: Removed.
* khtml/editing/edit_command.cpp: Removed.
* khtml/editing/edit_command.h: Removed.
* khtml/editing/html_interchange.cpp: Removed.
* khtml/editing/html_interchange.h: Removed.
* khtml/editing/htmlediting.cpp: Removed.
* khtml/editing/htmlediting.h: Removed.
* khtml/editing/insert_into_text_node_command.cpp: Removed.
* khtml/editing/insert_into_text_node_command.h: Removed.
* khtml/editing/insert_line_break_command.cpp: Removed.
* khtml/editing/insert_line_break_command.h: Removed.
* khtml/editing/insert_node_before_command.cpp: Removed.
* khtml/editing/insert_node_before_command.h: Removed.
* khtml/editing/insert_paragraph_separator_command.cpp: Removed.
* khtml/editing/insert_paragraph_separator_command.h: Removed.
* khtml/editing/insert_text_command.cpp: Removed.
* khtml/editing/insert_text_command.h: Removed.
* khtml/editing/join_text_nodes_command.cpp: Removed.
* khtml/editing/join_text_nodes_command.h: Removed.
* khtml/editing/jsediting.cpp: Removed.
* khtml/editing/jsediting.h: Removed.
* khtml/editing/markup.cpp: Removed.
* khtml/editing/markup.h: Removed.
* khtml/editing/merge_identical_elements_command.cpp: Removed.
* khtml/editing/merge_identical_elements_command.h: Removed.
* khtml/editing/move_selection_command.cpp: Removed.
* khtml/editing/move_selection_command.h: Removed.
* khtml/editing/rebalance_whitespace_command.cpp: Removed.
* khtml/editing/rebalance_whitespace_command.h: Removed.
* khtml/editing/remove_css_property_command.cpp: Removed.
* khtml/editing/remove_css_property_command.h: Removed.
* khtml/editing/remove_node_attribute_command.cpp: Removed.
* khtml/editing/remove_node_attribute_command.h: Removed.
* khtml/editing/remove_node_command.cpp: Removed.
* khtml/editing/remove_node_command.h: Removed.
* khtml/editing/remove_node_preserving_children_command.cpp: Removed.
* khtml/editing/remove_node_preserving_children_command.h: Removed.
* khtml/editing/replace_selection_command.cpp: Removed.
* khtml/editing/replace_selection_command.h: Removed.
* khtml/editing/set_node_attribute_command.cpp: Removed.
* khtml/editing/set_node_attribute_command.h: Removed.
* khtml/editing/split_element_command.cpp: Removed.
* khtml/editing/split_element_command.h: Removed.
* khtml/editing/split_text_node_command.cpp: Removed.
* khtml/editing/split_text_node_command.h: Removed.
* khtml/editing/split_text_node_containing_element.cpp: Removed.
* khtml/editing/split_text_node_containing_element_command.h: Removed.
* khtml/editing/text_affinity.h: Removed.
* khtml/editing/text_granularity.h: Removed.
* khtml/editing/typing_command.cpp: Removed.
* khtml/editing/typing_command.h: Removed.
* khtml/editing/visible_position.cpp: Removed.
* khtml/editing/visible_position.h: Removed.
* khtml/editing/visible_range.cpp: Removed.
* khtml/editing/visible_range.h: Removed.
* khtml/editing/visible_text.cpp: Removed.
* khtml/editing/visible_text.h: Removed.
* khtml/editing/visible_units.cpp: Removed.
* khtml/editing/visible_units.h: Removed.
* khtml/editing/wrap_contents_in_dummy_span_command.cpp: Removed.
* khtml/editing/wrap_contents_in_dummy_span_command.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 21:40:48 +0000 (21:40 +0000)]
Reviewed by Adele Peterson.
- tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7255
label attribute in option elements is ignored
* dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Added.
* dom/html/level2/html/HTMLOptionElement_label01-expected.png: Added.
* dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Added.
* dom/html/level2/html/HTMLOptionElement_label01.html: Added.
* dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Added.
* dom/html/level2/html/HTMLOptionElement_label02-expected.png: Added.
* dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Added.
* dom/html/level2/html/HTMLOptionElement_label02.html: Added.
* dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Added.
* dom/html/level2/html/HTMLOptionElement_label03-expected.png: Added.
* dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Added.
* dom/html/level2/html/HTMLOptionElement_label03.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 21:39:36 +0000 (21:39 +0000)]
Reviewed by Adele Peterson.
- fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7255
label attribute in option elements is ignored
Test cases:
* dom/html/level2/html/HTMLOptionElement_label01.html
* dom/html/level2/html/HTMLOptionElement_label02.html
* dom/html/level2/html/HTMLOptionElement_label03.html
* rendering/render_form.cpp:
(WebCore::RenderSelect::updateFromElement):
use label attribute, if present, when setting text on the widget.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vicki [Tue, 14 Feb 2006 21:18:37 +0000 (21:18 +0000)]
Reviewed by Maciej.
Change formatting in this file to match the style guidelines. No spaces after
opening parentheses or before closing parentheses.
* dom/DocumentImpl.cpp:
(WebCore::DocumentImpl::createDocumentFragment):
(WebCore::DocumentImpl::recalcStyle):
(WebCore::DocumentImpl::attach):
(WebCore::DocumentImpl::detach):
(WebCore::DocumentImpl::open):
(WebCore::DocumentImpl::write):
(WebCore::DocumentImpl::writeln):
(WebCore::DocumentImpl::setUserStyleSheet):
(WebCore::DocumentImpl::determineParseMode):
(WebCore::DocumentImpl::processHttpEquiv):
(WebCore::DocumentImpl::childAllowed):
(WebCore::DocumentImpl::childTypeAllowed):
(WebCore::DocumentImpl::recalcStyleSelector):
(WebCore::DocumentImpl::dispatchImageLoadEventsNow):
(WebCore::DocumentImpl::domain):
(WebCore::DocumentImpl::setDomain):
(WebCore::DocumentImpl::parseQualifiedName):
(WebCore::DocumentImpl::addMarker):
(WebCore::DocumentImpl::removeMarkers):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 19:13:51 +0000 (19:13 +0000)]
Reviewed by Tim Hatcher.
Some cleanup from the previous checkin, inspired by Darin's comments
* bridge/mac/MacFrame.h:
* bridge/mac/MacFrame.mm:
moved highlightAllMatchesForString out of here
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]):
now converts NSString to QString here, rather than in Frame/MacFrame
* dom/DocumentMarker.h: Added.
(WebCore::DocumentMarker::):
(WebCore::DocumentMarker::operator == ):
(WebCore::DocumentMarker::operator != ):
moved this struct to its own header file
* dom/DocumentImpl.h:
moved DocumentMarker out; now includes DocumentMarker.h
* page/Frame.h:
* page/Frame.cpp:
(WebCore::Frame::highlightAllMatchesForString):
moved here from MacFrame.[h,mm]. I thought this used other code from
MacFrame.mm but it doesn't.
* rendering/InlineTextBox.h:
removed unnecesssary variable names; use DocumentMarker::MarkerType in signature
of paintAllMarkersOfType
* rendering/InlineTextBox.cpp:
(khtml::InlineTextBox::paintTextMatchMarker):
better name for a variable, fixed bad indent
(khtml::InlineTextBox::paintAllMarkersOfType):
rewrote loop to bail out early if past end, for clarity;
use DocumentMarker::MarkerType in signature
* WebCore.xcodeproj/project.pbxproj:
updated for new file
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 14 Feb 2006 18:01:29 +0000 (18:01 +0000)]
More build fixes for case-sensitive drives. The #include "String.h" does not fail on normal HFS+ drives.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 14 Feb 2006 17:55:31 +0000 (17:55 +0000)]
Build fix for case-sensitive drives.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 16:57:47 +0000 (16:57 +0000)]
Reviewed by Tim Omernick.
Support for highlighting multiple text matches.
* WebView/WebHTMLViewPrivate.h:
* WebView/WebHTMLView.m:
(-[WebHTMLView highlightAllMatchesForString:caseSensitive:]):
new method, calls through to bridge
(-[WebHTMLView clearHighlightedMatches]):
ditto
* WebView/WebViewPrivate.h:
* WebView/WebView.m:
(-[WebView highlightAllMatchesForString:caseSensitive:]):
new method, calls through to documentView. For now this is hardwired to only work
with WebHTMLViews.
(-[WebView clearHighlightedMatches]):
ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 14 Feb 2006 16:57:34 +0000 (16:57 +0000)]
Reviewed by Tim Omernick.
Support for highlighting multiple text matches.
* dom/DocumentImpl.h:
(WebCore::DocumentMarker::):
Added new marker type TextMatch
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]):
new method, calls through to MacFrame implementation
(-[WebCoreFrameBridge clearHighlightedMatches]):
new method, removes all markers of type TextMatch
* bridge/mac/MacFrame.h:
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::highlightAllMatchesForString):
new method, adds a document marker for each range that matches the given string
* rendering/InlineTextBox.h:
* rendering/InlineTextBox.cpp:
(khtml::InlineTextBox::paint):
Moved DocumentMarker loop into separate method paintAllMarkersOfType. We now call
that method twice, once for spelling markers (after drawing text) and once for
text match markers (before drawing text)
(khtml::InlineTextBox::paintTextMatchMarker):
new method, paints a color behind a text match marker
(khtml::InlineTextBox::paintSpellingMarker):
renamed from paintMarker
(khtml::InlineTextBox::paintAllMarkersOfType):
new method, loops through all DocumentMarkers of a particular type and calls the
appropriate painting method for each one
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 14 Feb 2006 04:19:40 +0000 (04:19 +0000)]
WebCore:
Reviewed by Maciej.
- move pointer from frame to page here from WebKit
* WebCore.xcodeproj/project.pbxproj: Added PageMac.h.
* bridge/mac/PageMac.h: Added.
* bridge/mac/MacFrame.h: Added a page parameter to the constructor.
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::MacFrame): Pass the page and renderer to the Frame constructor.
Moved the call to Cache::init up into Frame, and got rid of the call to Frame::init
since that's now handled by the constructor. Also put the code to create the
browser extension object here.
(WebCore::MacFrame::submitForm): Update for new method name.
(WebCore::MacFrame::createFrame): Ditto.
(WebCore::MacFrame::sendContextMenuEvent): Update since m_doc is a RefPtr.
* bridge/mac/WebCoreFrameBridge.h: Changed parameters on init methods. Renamed
the part method to impl. Added a page method.
* bridge/mac/WebCoreFrameBridge.mm:
(frameHasSelection): Change use of part method to impl.
(-[WebCoreFrameBridge appendChild:]): Use m_frame directly instead of calling part method.
(-[WebCoreFrameBridge removeChild:]): Ditto.
(-[WebCoreFrameBridge initMainFrameWithPage:]): Added. Now does the first-time initialization
only here and create a frame for a main frame.
(-[WebCoreFrameBridge initSubframeWithRenderer:]): Added. Doesn't do the first-time initialization
and creates a frame for a subframe.
(-[WebCoreFrameBridge page]): Added.
(-[WebCoreFrameBridge setOpener:]): Change to use impl method instead of part.
(-[WebCoreFrameBridge executionContextForView:]): Ditto.
(-[WebCoreFrameBridge impl]): Added.
* bridge/mac/WebCorePageBridge.h: Removed init method and added setMainFrame: method and impl method.
* bridge/mac/WebCorePageBridge.mm:
(-[WebCorePageBridge init]): Changed to create a PageMac.
(-[WebCorePageBridge setMainFrame:]): Added.
(-[WebCorePageBridge impl]): Added.
* bridge/mac/BrowserExtensionMac.mm:
(WebCore::BrowserExtensionMac::createNewWindow):
* kwq/KWQAccObject.mm:
(-[KWQAccObject rendererForView:]):
* kwq/KWQComboBox.mm:
(-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]):
* kwq/KWQFileButton.mm:
(KWQFileButton::focusPolicy):
* kwq/KWQSlider.mm:
(QSlider::focusPolicy):
* kwq/KWQTextArea.mm:
(-[KWQTextAreaTextView _isResizableByUser]):
(-[KWQTextAreaTextView _trackResizeFromMouseDown:]):
Change methods to get from bridge back to objects to be named "impl".
The old one was named "part".
* page/Frame.h: Added Page and RenderPart parameter to constructor.
Added a page function. Removed the createBrowserExtension function.
* page/Frame.cpp:
(WebCore::parentFromOwnerRenderer): Added. Helper for constructor.
(WebCore::Frame::Frame): Moved all the code from init into here. Also change
to set the parent right from the start.
(WebCore::Frame::stopLoading): Change since m_doc is now a RefPtr.
(WebCore::Frame::clear): Ditto.
(WebCore::Frame::document): Ditto.
(WebCore::Frame::setDocument): Ditto.
(WebCore::Frame::begin): Ditto.
(WebCore::Frame::gotoAnchor): Ditto.
(WebCore::Frame::typingStyle): Change since m_typingStyle is now a RefPtr.
(WebCore::Frame::setTypingStyle): Ditto.
(WebCore::Frame::clearTypingStyle): Ditto.
(WebCore::Frame::isFrameSet): Change since m_doc is now a RefPtr.
(WebCore::Frame::page): Added.
* page/FramePrivate.h: Changed initialization to use member-initialization
syntax. Removed unused m_frames. Changed m_doc and m_typingStyle to use
RefPtr. Added an m_frame.
* page/Page.h: Made destructor virtual so we could have a Mac derived class.
Added a setMainFrame function and removed the mainFrame parameter from the constructor.
* page/Page.cpp:
(WebCore::Page::Page): Removed the mainFrame parameter.
(WebCore::Page::setMainFrame): Added.
WebKit:
Reviewed by Maciej.
- move pointer from frame to page over to WebCore
* WebCoreSupport/WebPageBridge.m: (-[WebPageBridge initWithMainFrameName:webView:frameView:]):
Call super init to create the page before creating the main frame and calling setMainFrame: with it.
* WebCoreSupport/WebFrameBridge.h: Remove page pointer, and change init function parameters.
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge initMainFrameWithPage:frameName:view:]): New function that is used only for
the main frame. Passes the page over to the other side of the bridge.
(-[WebFrameBridge initSubframeWithRenderer:frameName:view:]): New function that is used only for
subframes. Passes the renderer over to the other side of the bridge.
(-[WebFrameBridge mainFrame]):
(-[WebFrameBridge webView]):
(-[WebFrameBridge createWindowWithURL:frameName:]):
(-[WebFrameBridge showWindow]):
(-[WebFrameBridge areToolbarsVisible]):
(-[WebFrameBridge setToolbarsVisible:]):
(-[WebFrameBridge isStatusbarVisible]):
(-[WebFrameBridge setStatusbarVisible:]):
(-[WebFrameBridge setWindowFrame:]):
(-[WebFrameBridge windowFrame]):
(-[WebFrameBridge setWindowContentRect:]):
(-[WebFrameBridge windowContentRect]):
(-[WebFrameBridge setWindowIsResizable:]):
(-[WebFrameBridge windowIsResizable]):
(-[WebFrameBridge firstResponder]):
(-[WebFrameBridge makeFirstResponder:]):
(-[WebFrameBridge closeWindowSoon]):
(-[WebFrameBridge runJavaScriptAlertPanelWithMessage:]):
(-[WebFrameBridge runJavaScriptConfirmPanelWithMessage:]):
(-[WebFrameBridge canRunBeforeUnloadConfirmPanel]):
(-[WebFrameBridge runBeforeUnloadConfirmPanelWithMessage:]):
(-[WebFrameBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]):
(-[WebFrameBridge addMessageToConsole:]):
(-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]):
(-[WebFrameBridge setStatusText:]):
(-[WebFrameBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
(-[WebFrameBridge focusWindow]):
(-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
(-[WebFrameBridge userAgentForURL:]):
(-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]):
(-[WebFrameBridge previousKeyViewOutsideWebFrameViews]):
(-[WebFrameBridge defersLoading]):
(-[WebFrameBridge setDefersLoading:]):
(-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
(-[WebFrameBridge _preferences]):
(-[WebFrameBridge selectWordBeforeMenuEvent]):
(-[WebFrameBridge historyLength]):
(-[WebFrameBridge canGoBackOrForward:]):
(-[WebFrameBridge goBackOrForward:]):
(-[WebFrameBridge print]):
(-[WebFrameBridge pollForAppletInView:]):
(-[WebFrameBridge respondToChangedContents]):
(-[WebFrameBridge respondToChangedSelection]):
(-[WebFrameBridge undoManager]):
(-[WebFrameBridge issueCutCommand]):
(-[WebFrameBridge issueCopyCommand]):
(-[WebFrameBridge issuePasteCommand]):
(-[WebFrameBridge issuePasteAndMatchStyleCommand]):
(-[WebFrameBridge canPaste]):
(-[WebFrameBridge overrideMediaType]):
(-[WebFrameBridge isEditable]):
(-[WebFrameBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
(-[WebFrameBridge shouldBeginEditing:]):
(-[WebFrameBridge shouldEndEditing:]):
(-[WebFrameBridge windowObjectCleared]):
(-[WebFrameBridge spellCheckerDocumentTag]):
(-[WebFrameBridge isContinuousSpellCheckingEnabled]):
(-[WebFrameBridge didFirstLayout]):
(-[WebFrameBridge dashboardRegionsChanged:]):
(-[WebFrameBridge createModalDialogWithURL:]):
(-[WebFrameBridge canRunModal]):
(-[WebFrameBridge runModal]):
Change all calls to [_page webView] to use [self webView] instead.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 14 Feb 2006 04:11:21 +0000 (04:11 +0000)]
Updated test case after improving table deletion.
* selection/move-between-blocks-no-001-expected.txt: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 14 Feb 2006 03:29:43 +0000 (03:29 +0000)]
Reviewed by Justin.
- merge VisiblePosition:isCandidate() into Position::inRenderedContent()
These functions were answering the same question in different ways! We
only need one implementation.
* khtml/editing/visible_position.cpp:
(khtml::VisiblePosition::init):
(khtml::VisiblePosition::previousVisiblePosition):
(khtml::VisiblePosition::nextVisiblePosition):
(khtml::VisiblePosition::deepEquivalent):
* khtml/editing/visible_position.h:
* dom/dom_position.cpp:
(DOM::hasRenderedChildrenWithHeight):
(DOM::Position::inRenderedContent):
- improved table deletion.
Fixes: delete back by word from just after table did not delete the table
delete forward by char or word did not delete the table
deleting back to a table and again did not delete the table
* khtml/editing/htmlediting.cpp:
(WebCore::isFirstVisiblePositionAfterTableElement):
simpler implementation
(WebCore::positionBeforePrecedingTableElement):
simpler implementation
(WebCore::isFirstVisiblePositionBeforeTableElement):
new
(WebCore::positionAfterFollowingTableElement):
new
* khtml/editing/htmlediting.h:
* khtml/editing/SelectionController.cpp:
(WebCore::SelectionController::modifyExtendingRightForward):
select following table if granularity is char or word
(WebCore::SelectionController::modifyExtendingLeftBackward):
select preceding table if granularity is char or word
* khtml/editing/typing_command.cpp:
(khtml::TypingCommand::deleteKeyPressed):
simpler implementation, and let other deleteKeyPressed do boundary checking
(khtml::TypingCommand::forwardDeleteKeyPressed):
simpler implementation, and let other forwardDeleteKeyPressed do boundary checking
(khtml::TypingCommand::insertText):
standard formatting
(khtml::TypingCommand::insertLineBreak):
standard formatting
(khtml::TypingCommand::insertParagraphSeparatorInQuotedContent):
standard formatting
(khtml::TypingCommand::insertParagraphSeparator):
standard formatting
(khtml::TypingCommand::insertTextRunWithoutNewlines):
standard formatting
(khtml::TypingCommand::deleteKeyPressed):
use SelectionController to extend selection, to get all the selection
logic incl. table selection and editable/noneditable boundary checks
(khtml::TypingCommand::forwardDeleteKeyPressed):
use SelectionController to extend selection, to get all the selection
logic incl. table selection and editable/noneditable boundary checks
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 14 Feb 2006 01:01:11 +0000 (01:01 +0000)]
Fix for bug 5605, XSLT fails to import to arbitrary depth. Make sure m_embedded is initialized to false
in the XSLTStyleSheetImpl constructor.
Reviewed by timo
Adding xslt-import-depth.xml to fast/xsl
* khtml/xsl/xsl_stylesheetimpl.cpp:
(DOM::XSLStyleSheetImpl::XSLStyleSheetImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 14 Feb 2006 01:00:39 +0000 (01:00 +0000)]
Add layout test for import depth.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 13 Feb 2006 23:13:47 +0000 (23:13 +0000)]
Fix Win32 WebCore bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 13 Feb 2006 23:02:40 +0000 (23:02 +0000)]
2006-02-12 Alexander Kellett <lypanov@kde.org>
Reviewed by eseidel.
Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7207.
No testcases as this is not possible to reproduce via anything
other than manual interaction.
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(WebCore::KCanvasFilterQuartz::getCIFilterStack):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Mon, 13 Feb 2006 22:49:32 +0000 (22:49 +0000)]
Fix Win32 JavaScriptCore bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 13 Feb 2006 22:02:26 +0000 (22:02 +0000)]
Reviewed by Hyatt.
- moved QWidget to platform directory, renamed to Widget,
split into cross-platform and platform-specific parts,
removed some of the unused bits
* ForwardingHeaders/qwidget.h: Removed.
* kwq/KWQWidget.h: Removed.
* kwq/KWQWidget.mm: Removed.
* WebCore.vcproj/WebCore/WebCore.vcproj: Update for file removals and adds.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/Widget.h: Moved code here, fixed it up.
* platform/Widget.cpp: Ditto.
* platform/mac/WidgetMac.mm: Added.
* bindings/objc/DOMHTML.mm:
(viewForElement):
* bridge/mac/KWQKHTMLView.cpp:
(WebCore::FrameView::topLevelWidget):
* bridge/mac/MacFrame.h:
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::createPlugin):
(WebCore::MacFrame::nextKeyViewInFrame):
(WebCore::MacFrame::nextKeyViewForWidget):
(WebCore::MacFrame::currentEventIsMouseDownInWidget):
(WebCore::MacFrame::bridgeForWidget):
(WebCore::MacFrame::passMouseDownEventToWidget):
(WebCore::MacFrame::passSubframeEventToSubframe):
(WebCore::MacFrame::passWheelEventToChildWidget):
(WebCore::MacFrame::getAppletInstanceForWidget):
(WebCore::MacFrame::getEmbedInstanceForWidget):
(WebCore::MacFrame::getObjectInstanceForWidget):
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]):
(-[WebCoreFrameBridge copyRenderNode:copier:]):
(-[WebCoreFrameBridge elementForView:]):
(-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]):
* dom/DocumentImpl.cpp:
(WebCore::widgetForNode):
(WebCore::DocumentImpl::setFocusNode):
* khtml/ecma/kjs_window.cpp:
(KJS::Screen::getValueProperty):
(KJS::WindowFunc::callAsFunction):
* khtml/html/HTMLGenericFormElementImpl.cpp:
(WebCore::HTMLGenericFormElementImpl::isKeyboardFocusable):
(WebCore::HTMLGenericFormElementImpl::isMouseFocusable):
* khtml/html/html_objectimpl.cpp:
(WebCore::HTMLEmbedElementImpl::getEmbedInstance):
(WebCore::HTMLObjectElementImpl::getObjectInstance):
* kwq/KWQAccObject.mm:
(-[KWQAccObject addChildrenToArray:]):
(-[KWQAccObject attachmentView]):
(-[KWQAccObject doAXTextMarkerForPosition:]):
* kwq/KWQComboBox.h:
* kwq/KWQComboBox.mm:
(QComboBox::frameGeometry):
(QComboBox::setFrameGeometry):
(QComboBox::setFont):
(QComboBox::focusPolicy):
(-[KWQPopUpButtonCell widget]):
(-[KWQPopUpButton widget]):
(-[KWQPopUpButton mouseDown:]):
(-[KWQPopUpButton becomeFirstResponder]):
(-[KWQPopUpButton resignFirstResponder]):
(-[KWQPopUpButton nextKeyView]):
(-[KWQPopUpButton previousKeyView]):
* kwq/KWQFileButton.h:
* kwq/KWQFileButton.mm:
(KWQFileButton::focusPolicy):
* kwq/KWQFrame.h:
* kwq/KWQKCursor.h:
* kwq/KWQKJavaAppletWidget.h:
* kwq/KWQKJavaAppletWidget.mm:
(KJavaAppletWidget::KJavaAppletWidget):
* kwq/KWQLineEdit.h:
* kwq/KWQLineEdit.mm:
(QLineEdit::setFont):
(QLineEdit::setPalette):
(QLineEdit::focusPolicy):
* kwq/KWQListBox.h:
* kwq/KWQListBox.mm:
(QListBox::QListBox):
(QListBox::focusPolicy):
(QListBox::setFont):
(-[KWQListBoxScrollView widget]):
(-[KWQListBoxScrollView becomeFirstResponder]):
(-[KWQTableView mouseDown:]):
(-[KWQTableView widget]):
* kwq/KWQPainter.h:
* kwq/KWQRenderTreeDebug.cpp:
(write):
* kwq/KWQScrollBar.h:
* kwq/KWQScrollBar.mm:
(-[KWQScrollBar widget]):
(-[KWQScrollBar mouseDown:]):
(QScrollBar::QScrollBar):
(QScrollBar::~QScrollBar):
* kwq/KWQScrollView.h:
(QScrollView::QScrollView):
* kwq/KWQScrollView.mm:
(QScrollView::viewport):
(QScrollView::childX):
(QScrollView::childY):
(QScrollView::addChild):
(QScrollView::removeChild):
* kwq/KWQSlider.h:
* kwq/KWQSlider.mm:
(-[KWQSlider mouseDown:]):
(-[KWQSlider widget]):
(QSlider::setFont):
(QSlider::focusPolicy):
* kwq/KWQTextArea.mm:
(-[KWQTextAreaTextView widget]):
* kwq/KWQTextEdit.h:
* kwq/KWQTextEdit.mm:
(QTextEdit::QTextEdit):
(QTextEdit::setFont):
(QTextEdit::focusPolicy):
(QTextEdit::setPalette):
* kwq/KWQTextField.mm:
(-[KWQTextFieldController widget]):
(-[KWQTextFieldController textView:shouldHandleEvent:]):
(-[KWQTextFieldController textView:didHandleEvent:]):
(-[KWQTextField widget]):
(-[KWQTextField nextKeyView]):
(-[KWQTextField previousKeyView]):
(-[KWQSecureTextField widget]):
(-[KWQSecureTextField nextKeyView]):
(-[KWQSecureTextField previousKeyView]):
(-[KWQSearchField widget]):
(-[KWQSearchField nextKeyView]):
(-[KWQSearchField previousKeyView]):
* kwq/KWQView.h:
* kwq/KWQWindowWidget.h:
* kwq/KWQWindowWidget.mm:
(KWQWindowWidget::topLevelWidget):
* page/Frame.cpp:
(WebCore::isFrameElement):
(WebCore::Frame::frameForWidget):
(WebCore::Frame::nodeForWidget):
(WebCore::Frame::setDocumentFocus):
(WebCore::Frame::clearDocumentFocus):
(WebCore::Frame::passWidgetMouseDownEventToWidget):
* page/Frame.h:
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::init):
* page/FrameView.h:
* page/Plugin.h:
(WebCore::Plugin::Plugin):
(WebCore::Plugin::view):
* platform/Screen.h:
* platform/mac/ScreenMac.mm:
(WebCore::screen):
(WebCore::screenDepth):
(WebCore::screenRect):
(WebCore::usableScreenRect):
* rendering/render_applet.cpp:
(WebCore::RenderApplet::layout):
* rendering/render_form.cpp:
(WebCore::ComboBoxWidget::ComboBoxWidget):
(WebCore::RenderSelect::createListBox):
* rendering/render_form.h:
* rendering/render_frames.cpp:
(WebCore::RenderPart::setWidget):
* rendering/render_frames.h:
* rendering/render_object.cpp:
* rendering/render_replaced.cpp:
(WebCore::RenderWidget::resizeWidget):
(WebCore::RenderWidget::setQWidget):
* rendering/render_replaced.h:
(WebCore::RenderWidget::widget):
Change name from QWidget to Widget, a few other changes to get compiling.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 13 Feb 2006 21:57:47 +0000 (21:57 +0000)]
Versioning to 521.7
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 13 Feb 2006 19:34:53 +0000 (19:34 +0000)]
Reviewed by Darin.
Replaced the old NS_DURING exception blocking with @try/@catch.
* JavaScriptCorePrefix.h: undef try and catch to workaround a C++ conflict
* bindings/objc/objc_instance.mm:
(ObjcInstance::invokeMethod):
(ObjcInstance::invokeDefaultMethod):
(ObjcInstance::setValueOfUndefinedField):
(ObjcInstance::getValueOfUndefinedField):
* bindings/objc/objc_runtime.mm:
(ObjcField::valueFromInstance):
(ObjcField::setValueToInstance):
(ObjcArray::setValueAt):
(ObjcArray::valueAt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 13 Feb 2006 09:34:10 +0000 (09:34 +0000)]
- fix a couple problems building on Windows, based on requests
from Krzysztof Kowalczyk <kkowalczyk@gmail.com>
* kjs/JSImmediate.h: Change code using non-standard u_int32/64_t types
to the standard uint32/64_t. Also removed curious "isIEEE()" function
that checked the sizes of some types (and type sizes alone don't tell you if
the floating point conforms to the IEEE-standard). Added missing include
of <stdint.h>.
* kjs/property_slot.h: Added missing include of <assert.h>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 13 Feb 2006 05:31:22 +0000 (05:31 +0000)]
Reviewed and tweaked by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7206
REGRESSION: PDF "images" no longer render within HTML pages
* fast/replaced/page-as-image.html: Added.
* fast/replaced/page-as-image-expected.txt: Added.
* fast/replaced/page-as-image-expected.png: Added.
* fast/replaced/page-as-image-expected.checksum: Added.
* fast/replaced/resources/image.pdf: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 13 Feb 2006 05:27:27 +0000 (05:27 +0000)]
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7206
REGRESSION: PDF "images" no longer render within HTML pages
Test: fast/replaced/page-as-image.html
* platform/Image.cpp: (WebCore::Image::setNativeData):
Return false in the case where the PDF document has not been created yet.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 13 Feb 2006 04:11:27 +0000 (04:11 +0000)]
Rubber stamped by Geoff.
- comment out remote <base> URLs, these were making the tests hang for a long time
This also made the affected tests start passing.
* dom/xhtml/level2/html/HTMLBodyElement01-expected.checksum: Removed.
* dom/xhtml/level2/html/HTMLBodyElement01-expected.png: Removed.
* dom/xhtml/level2/html/HTMLBodyElement01-expected.txt:
* dom/xhtml/level2/html/HTMLBodyElement01.xhtml:
* dom/xhtml/level2/html/HTMLBodyElement02-expected.checksum: Removed.
* dom/xhtml/level2/html/HTMLBodyElement02-expected.png: Removed.
* dom/xhtml/level2/html/HTMLBodyElement02-expected.txt:
* dom/xhtml/level2/html/HTMLBodyElement02.xhtml:
* dom/xhtml/level2/html/HTMLBodyElement03-expected.checksum: Removed.
* dom/xhtml/level2/html/HTMLBodyElement03-expected.png: Removed.
* dom/xhtml/level2/html/HTMLBodyElement03-expected.txt:
* dom/xhtml/level2/html/HTMLBodyElement03.xhtml:
* dom/xhtml/level2/html/HTMLBodyElement04-expected.checksum: Removed.
* dom/xhtml/level2/html/HTMLBodyElement04-expected.png: Removed.
* dom/xhtml/level2/html/HTMLBodyElement04-expected.txt:
* dom/xhtml/level2/html/HTMLBodyElement04.xhtml:
* dom/xhtml/level2/html/HTMLBodyElement05-expected.checksum: Removed.
* dom/xhtml/level2/html/HTMLBodyElement05-expected.png: Removed.
* dom/xhtml/level2/html/HTMLBodyElement05-expected.txt:
* dom/xhtml/level2/html/HTMLBodyElement05.xhtml:
* dom/xhtml/level2/html/HTMLBodyElement06-expected.checksum: Removed.
* dom/xhtml/level2/html/HTMLBodyElement06-expected.png: Removed.
* dom/xhtml/level2/html/HTMLBodyElement06-expected.txt:
* dom/xhtml/level2/html/HTMLBodyElement06.xhtml:
* dom/xhtml/level2/html/body01-expected.checksum: Removed.
* dom/xhtml/level2/html/body01-expected.png: Removed.
* dom/xhtml/level2/html/body01-expected.txt:
* dom/xhtml/level2/html/body01.xhtml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 13 Feb 2006 03:06:19 +0000 (03:06 +0000)]
Reviewed by darin.
Cleaned up testkjs, added new "run" functionality to allow scripting
tests from within JS. ("run" is a part of my new super-accurate
JS iBench.)
No regressions in run-javascriptcore-tests.
* kjs/testkjs.cpp:
(GlobalImp::className):
(TestFunctionImp::):
(TestFunctionImp::callAsFunction):
(main):
(run):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 13 Feb 2006 02:43:45 +0000 (02:43 +0000)]
Reviewed by Maciej.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7209
reimplement Timer so it uses only a single timer from the underlying OS
* WebCore.vcproj/WebCore/WebCore.vcproj: Removed old files, added new.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/Timer.h: Updated for new timer implementation.
* platform/Timer.cpp: Added. Platform-independent implementation of timers
in terms of a single shared timer. Uses a heap to implement a priority queue
so we know which timer to fire first.
* platform/SharedTimer.h: Added.
* platform/mac/SharedTimerMac.cpp: Added.
* platform/win/SharedTimerWin.cpp: Added.
* platform/mac/TimerMac.cpp: Removed.
* platform/win/TimerWin.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 13 Feb 2006 00:51:35 +0000 (00:51 +0000)]
2006-02-12 Eric Seidel <eseidel@apple.com>
Reviewed by mjs.
* loader/CachedXSLStyleSheet.cpp: removed duplicate copy of xbl code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sun, 12 Feb 2006 22:07:15 +0000 (22:07 +0000)]
2006-02-12 Joost de Valk <jdevalk@opendarwin.org>
Reviewed by eseidel.
Added a little piece of text to the page about reductions, pointing to the bugzilla page.
Changed "Sign up for a" into "Create a" bugzilla account.
* quality/reduction.html:
* quality/reporting.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 12 Feb 2006 16:31:24 +0000 (16:31 +0000)]
Unreviewed build fix.
- fix build
* bindings/scripts/CodeGeneratorJS.pm: Update for splitting of the
dom_textimpl.h header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 12 Feb 2006 10:11:54 +0000 (10:11 +0000)]
Reviewed by Hyatt.
- factor WebArchive creation code out of other classes into new WebArchiver
http://bugzilla.opendarwin.org/show_bug.cgi?id=7208
* DOM/WebDOMOperations.m:
(-[DOMNode webArchive]):
(-[DOMRange webArchive]):
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebArchiver.h: Added.
* WebView/WebArchiver.m: Added.
(+[WebArchiver _subframeArchivesForFrame:]):
(+[WebArchiver archiveFrame:]):
(+[WebArchiver _archiveCurrentStateForFrame:]):
(+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
(+[WebArchiver archiveRange:]):
(+[WebArchiver archiveNode:]):
(+[WebArchiver archiveSelectionInFrame:]):
* WebView/WebDataSource.m:
(-[WebDataSource webArchive]):
* WebView/WebDataSourcePrivate.h:
* WebView/WebHTMLView.m:
(-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
(-[WebHTMLView _writeSelectionToPasteboard:]):
* WebView/WebHTMLViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 12 Feb 2006 10:07:23 +0000 (10:07 +0000)]
Correct tyop in ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 12 Feb 2006 10:03:59 +0000 (10:03 +0000)]
Reviewed by Darin.
- rename FrameTreeNode to FameTree and treeNode() to tree()
http://bugzilla.opendarwin.org/show_bug.cgi?id=7210
This may be slightly less accurate, but reads better.
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/BrowserExtensionMac.mm:
(WebCore::BrowserExtensionMac::createNewWindow):
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::submitForm):
(WebCore::MacFrame::nextKeyViewInFrameHierarchy):
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge firstChild]):
(-[WebCoreFrameBridge lastChild]):
(-[WebCoreFrameBridge childCount]):
(-[WebCoreFrameBridge previousSibling]):
(-[WebCoreFrameBridge nextSibling]):
(-[WebCoreFrameBridge appendChild:]):
(-[WebCoreFrameBridge removeChild:]):
(-[WebCoreFrameBridge setParent:]):
(-[WebCoreFrameBridge parent]):
(-[WebCoreFrameBridge setName:]):
(-[WebCoreFrameBridge name]):
* dom/DocumentImpl.cpp:
(WebCore::DocumentImpl::parentDocument):
* khtml/ecma/kjs_window.cpp:
(KJS::Window::getValueProperty):
(KJS::Window::put):
(KJS::Window::isSafeScript):
(KJS::WindowFunc::callAsFunction):
* khtml/html/html_baseimpl.cpp:
(WebCore::HTMLFrameElementImpl::isURLAllowed):
* khtml/html/html_headimpl.cpp:
(WebCore::HTMLLinkElementImpl::process):
* page/Frame.cpp:
(WebCore::Frame::stopLoading):
(WebCore::Frame::clear):
(WebCore::Frame::stopAnimations):
(WebCore::Frame::checkCompleted):
(WebCore::Frame::checkEmitLoadEvent):
(WebCore::Frame::slotChildCompleted):
(WebCore::Frame::findFrame):
(WebCore::Frame::setZoomFactor):
(WebCore::Frame::frameNames):
(WebCore::Frame::frames):
(WebCore::Frame::childFrameNamed):
(WebCore::Frame::incrementFrameCount):
(WebCore::Frame::decrementFrameCount):
(WebCore::Frame::topLevelFrameCount):
(WebCore::Frame::selectFrameElementInParentIfFullySelected):
(WebCore::Frame::userGestureHint):
(WebCore::Frame::canCachePage):
(WebCore::Frame::updatePolicyBaseURL):
(WebCore::Frame::setPolicyBaseURL):
(WebCore::Frame::tree):
(WebCore::Frame::frameDetached):
(WebCore::Frame::updateBaseURLForEmptyDocument):
* page/Frame.h:
* page/FramePrivate.h:
* page/FrameTree.cpp: Added.
(WebCore::FrameTree::~FrameTree):
(WebCore::FrameTree::setName):
(WebCore::FrameTree::appendChild):
(WebCore::FrameTree::removeChild):
* page/FrameTree.h: Added.
(WebCore::FrameTree::FrameTree):
* page/FrameTreeNode.cpp: Removed.
* page/FrameTreeNode.h: Removed.
* rendering/render_frames.cpp:
(WebCore::isURLAllowed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sun, 12 Feb 2006 08:50:21 +0000 (08:50 +0000)]
Fix bug 7182, animated GIFs don't clear previous animation frames.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sun, 12 Feb 2006 03:10:30 +0000 (03:10 +0000)]
- Fixed bad free resulting from 0 legnth StringImpl
No test case because currently this bug only has the effect of a bad
free on exit().
* platform/StringImpl.cpp:
(WebCore::StringImpl::StringImpl): Factored varied approaches to
initialization into two common routines: initWithChar and
initWithQChar. The common rule is: if we're not going to allocate
a string, make sure to set s to 0 so fastFree doesn't try to free it
later. For speed, initWithQChar uses memcpy() -- that's the only
difference between the two.
(WebCore::StringImpl::initWithChar):
(WebCore::StringImpl::initWithQChar):
* platform/StringImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 12 Feb 2006 01:18:46 +0000 (01:18 +0000)]
Rubber stamped by Eric.
- split dom_textimpl.{h,cpp} by class.
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
* bridge/mac/MacFrame.mm:
* dom/CDATASectionImpl.cpp: Added.
* dom/CDATASectionImpl.h: Added.
* dom/CharacterDataImpl.cpp: Added.
* dom/CharacterDataImpl.h: Added.
* dom/CommentImpl.cpp: Added.
* dom/CommentImpl.h: Added.
* dom/DocumentImpl.cpp:
* dom/EditingTextImpl.cpp: Added.
* dom/EditingTextImpl.h: Added.
* dom/NodeImpl.cpp:
* dom/TextImpl.cpp: Added.
* dom/TextImpl.h: Added.
* dom/dom2_rangeimpl.cpp:
* dom/dom_elementimpl.cpp:
* dom/dom_textimpl.cpp: Removed.
* dom/dom_textimpl.h: Removed.
* dom/xml_tokenizer.cpp:
* khtml/ecma/kjs_dom.cpp:
* khtml/ecma/kjs_html.cpp:
* khtml/editing/SelectionController.cpp:
* khtml/editing/apply_style_command.cpp:
* khtml/editing/break_blockquote_command.cpp:
* khtml/editing/composite_edit_command.cpp:
* khtml/editing/delete_from_text_node_command.cpp:
* khtml/editing/delete_selection_command.cpp:
* khtml/editing/htmlediting.cpp:
* khtml/editing/insert_into_text_node_command.cpp:
* khtml/editing/insert_line_break_command.cpp:
* khtml/editing/insert_paragraph_separator_command.cpp:
* khtml/editing/insert_text_command.cpp:
* khtml/editing/join_text_nodes_command.cpp:
* khtml/editing/markup.cpp:
* khtml/editing/rebalance_whitespace_command.cpp:
* khtml/editing/replace_selection_command.cpp:
* khtml/editing/split_text_node_command.cpp:
* khtml/editing/split_text_node_containing_element.cpp:
* khtml/editing/visible_position.cpp:
* khtml/html/HTMLElementImpl.cpp:
* khtml/html/HTMLKeygenElementImpl.cpp:
* khtml/html/HTMLOptionElementImpl.cpp:
* khtml/html/HTMLTextAreaElementImpl.cpp:
* khtml/html/html_headimpl.cpp:
* khtml/html/html_objectimpl.cpp:
* khtml/html/htmlparser.cpp:
* khtml/xsl/xslt_processorimpl.cpp:
* page/Frame.cpp:
* rendering/RenderText.h:
* rendering/render_frames.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sun, 12 Feb 2006 00:51:37 +0000 (00:51 +0000)]
2006-02-11 Alexander Kellett <lypanov@kde.org>
Reviewed by eseidel.
- Fixing http://bugzilla.opendarwin.org/show_bug.cgi?id=6942
Implement support for "em" and "ex" relative lengths.
- Layout tests changes:
Fixed: svg/W3C-SVG-1.1/coords-units-03-b.svg
New: svg/custom/coords-relative-units-transforms.svg
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 12 Feb 2006 00:21:43 +0000 (00:21 +0000)]
Reviewed by Darin.
Added a Bugzilla page, which contains information about creating a Bugzilla account, what editbugs and canconfirm
bits are and how to get them.
Changed link in reporting page to link to Bugzilla page.
* quality/bugzilla.html: Added.
* quality/reporting.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 12 Feb 2006 00:09:33 +0000 (00:09 +0000)]
Rubber-stamped by Eric.
- renamed all the platform/mac files to have a Mac suffix
(Hyatt and I discussed this change recently)
* WebCore.xcodeproj/project.pbxproj:
* platform/mac/Color.mm: Removed.
* platform/mac/ColorMac.mm: Added.
* platform/mac/FloatPoint.mm: Removed.
* platform/mac/FloatPointMac.mm: Added.
* platform/mac/FloatRect.mm: Removed.
* platform/mac/FloatRectMac.mm: Added.
* platform/mac/FloatSize.mm: Removed.
* platform/mac/FloatSizeMac.mm: Added.
* platform/mac/Image.mm: Removed.
* platform/mac/ImageMac.mm: Added.
* platform/mac/ImageSource.cpp: Removed.
* platform/mac/ImageSourceMac.cpp: Added.
* platform/mac/IntPoint.mm: Removed.
* platform/mac/IntPointMac.mm: Added.
* platform/mac/IntRect.mm: Removed.
* platform/mac/IntRectMac.mm: Added.
* platform/mac/IntSize.mm: Removed.
* platform/mac/IntSizeMac.mm: Added.
* platform/mac/QString.mm: Removed.
* platform/mac/QStringMac.mm: Added.
* platform/mac/Screen.mm: Removed.
* platform/mac/ScreenMac.mm: Added.
* platform/mac/SystemTime.cpp: Removed.
* platform/mac/SystemTimeMac.cpp: Added.
* platform/mac/Timer.cpp: Removed.
* platform/mac/TimerMac.cpp: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sat, 11 Feb 2006 23:54:23 +0000 (23:54 +0000)]
2006-02-11 Eric Seidel <eseidel@apple.com>
Rubber-stamped by darin.
Push kcanvas into WebCore namespace.
Fix KSVG2 to use WebCore namespace.
Remove all uses of khtml:: and KDOM:: from SVG code.
Too many files changed to bother showing here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 11 Feb 2006 23:38:35 +0000 (23:38 +0000)]
Reviewed by Darin.
* fast/events/event-targets.html: Fixed a small mistake in this test, noticed while
checking that bug 3609 is fixed in tip of tree.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sat, 11 Feb 2006 23:19:13 +0000 (23:19 +0000)]
2006-02-12 Joost de Valk <jdevalk@opendarwin.org>
Reviewed by eseidel.
- Changed 10.2 paragraph to say Mac OS X instead of just OS X
- Detabified the file.
* quality/reporting.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Sat, 11 Feb 2006 20:11:05 +0000 (20:11 +0000)]
LayoutTests:
Reviewed by Hyatt.
- new test and updated results for
http://bugzilla.opendarwin.org/show_bug.cgi?id=7054
Vertical scroll bars do not appear or do not scroll completely
* fast/replaced/width100percent-expected.checksum: Updated.
* fast/replaced/width100percent-expected.png: Updated.
* fast/replaced/width100percent-expected.txt: Updated.
* fast/table/edge-offsets-expected.checksum: Added.
* fast/table/edge-offsets-expected.png: Added.
* fast/table/edge-offsets-expected.txt: Added.
* fast/table/edge-offsets.html: Added.
WebCore:
Test: fast/table/edge-offsets.html
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7054
Vertical scroll bars do not appear or do not scroll completely
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::lowestPosition): Override the superclass implementation
to return the lowest of all the cells' lowest positions and the section's.
(WebCore::RenderTableSection::rightmostPosition): Ditto for rightmost.
(WebCore::RenderTableSection::leftmostPosition): Ditto for leftmost.
* rendering/RenderTableSection.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Sat, 11 Feb 2006 19:56:00 +0000 (19:56 +0000)]
No test until we figure out how to make one.
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7189
XSLT result parsing stops prematurely
* khtml/xsl/xslt_processorimpl.cpp:
(DOM::XSLTProcessorImpl::createDocumentFromSource): Removed the call to setParsing(false) from here
since it stopped parsing prematurely. Now the frame will call it when the tokenizer is finished.
* page/Frame.cpp:
(WebCore::Frame::clear): Disconnect the finishedParsing signal handler from the document.
(WebCore::Frame::setDocument): Disconnect the signal handler from the old document and
connect it to the new document.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Sat, 11 Feb 2006 19:39:02 +0000 (19:39 +0000)]
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6821
Fix for 5983 will not always update hover correctly.
* khtml/xml/DocumentImpl.cpp:
(WebCore::DocumentImpl::hoveredNodeDetached): Added this method. Moved the hover logic from
NodeImpl::detach here, modified to use the DOM tree instead of hoverAncestor,
to handle the case that the hover node is a text node, and to schedule an update
of hover state.
(WebCore::DocumentImpl::activeChainNodeDetached): Added this method to trim the
active chain above the node being detached.
* khtml/xml/DocumentImpl.h:
* khtml/xml/NodeImpl.cpp:
(WebCore::NodeImpl::detach): Moved most of the hover logic out of here into
DocumentImpl. Reset m_active and m_inActiveChain and call activeChainNodeDetached
when detaching an active node.
* manual-tests/bugzilla-6821.html: Added.
* page/FrameView.cpp:
(WebCore::FrameViewPrivate::FrameViewPrivate): Added hover-state update timer.
(WebCore::FrameViewPrivate::reset):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::viewportMouseMoveEvent):
(WebCore::FrameView::hoverTimerFired): Call DocumentImpl::prepareMouseEvent
when the timer fires to cause hover state to update.
(WebCore::FrameView::scheduleHoverStateUpdate): Added.
* page/FrameView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 11 Feb 2006 17:58:57 +0000 (17:58 +0000)]
* English.lproj/StringsNotToBeLocalized.txt: Updated paths for recent changes in directory structure.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Sat, 11 Feb 2006 16:03:26 +0000 (16:03 +0000)]
Reviewed by John Sullivan.
- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7171
No description in WebKitErrors.m for WebKitErrorPlugInWillHandleLoad
* English.lproj/Localizable.strings: Added new UI_STRING().
* Misc/WebKitErrors.m: Added #define for description.
(registerErrors): Added dictionary entry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 11 Feb 2006 10:48:56 +0000 (10:48 +0000)]
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3400
setting the .src of an iframe to the same value does not reload page
Test cases:
* fast/frames/frame-set-same-location.html
* fast/frames/frame-set-same-src.html
* fast/frames/iframe-set-same-location.html
* fast/frames/iframe-set-same-src.html
* khtml/html/html_baseimpl.cpp:
(WebCore::HTMLFrameElementImpl::setLocation):
Remove the check for the new URL being different from the current one.
Moved updateForNewURL() code into setLocation().
* khtml/html/html_baseimpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sat, 11 Feb 2006 10:34:55 +0000 (10:34 +0000)]
Reviewed by Darin.
- improve fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5163
RealPlayer.GetTitle() Crashes Safari/Dashboard
* bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16):
Use kCFStringEncodingISOLatin1 rather than kCFStringEncodingWindowsLatin1,
because the latter encoding has holes, and conversion can still fail.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sat, 11 Feb 2006 08:34:38 +0000 (08:34 +0000)]
2006-02-11 Eric Seidel <eseidel@apple.com>
Reviewed by hyatt.
Adding support for external entity declarations in XSLT.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7184
<rdar://problem/
4271696> support external DTD references in XSLT
* fast/parser/external-entities-expected.checksum: Added.
* fast/parser/external-entities-expected.png: Added.
* fast/parser/external-entities-expected.txt: Added.
* fast/parser/external-entities-in-xslt-expected.txt: Added.
* fast/parser/external-entities-in-xslt.xml: Added.
* fast/parser/external-entities.xml: Added.
* fast/parser/resources: Added.
* fast/parser/resources/external-entities.dtd: Added.
* fast/parser/resources/external-entities.xsl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sat, 11 Feb 2006 08:15:34 +0000 (08:15 +0000)]
2006-02-10 Eric Seidel <eseidel@apple.com>
Reviewed by hyatt.
Adding support for external entity declarations in XSLT.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7184
<rdar://problem/
4271696> support external DTD references in XSLT
* dom/xml_tokenizer.cpp:
(WebCore::OffsetBuffer::OffsetBuffer): new support class
(WebCore::OffsetBuffer::readOutBytes): read method
(WebCore::shouldAllowExternalLoad): for preventing common urls
(WebCore::openFunc): now does a synchronous data load
(WebCore::readFunc): returns data from the offset buffer
(WebCore::closeFunc): deletes offset buffer
(WebCore::setLoaderForLibXMLCallbacks): helper function
(WebCore::createQStringParser): cleanup
(WebCore::XMLTokenizer::finish):
* dom/xml_tokenizer.h:
* khtml/xsl/xsl_stylesheetimpl.cpp:
(WebCore::XSLStyleSheetImpl::parseString):
* khtml/xsl/xsl_stylesheetimpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 11 Feb 2006 07:35:03 +0000 (07:35 +0000)]
Make sure the GIF decoder behaves properly when the first frame of a GIF does not cover the entire image.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sat, 11 Feb 2006 07:07:12 +0000 (07:07 +0000)]
Implement an optimization to detect whether or not an image has alpha and do a blit instead of a blend in that case. r=eric
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Sat, 11 Feb 2006 02:16:54 +0000 (02:16 +0000)]
Reviewed by Hyatt
Layout test for <rdar://problem/
4149655> Frequently reported crash,
repro at lastminute.se in khtml::RenderBlock::createLineBoxes
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Sat, 11 Feb 2006 02:08:57 +0000 (02:08 +0000)]
Reviewed by Hyatt
Fix for <rdar://problem/
4149655> Frequently reported crash, repro
at lastminute.se in khtml::RenderBlock::createLineBoxes
Some crazy combination of an anonymous table, an inline form, and
generated content caused table objects to be added to a flow and
then split. This is very bad. Once the crash was fixed, there were
still some rendering issues that this patch also fixes. We needed
to make sure we only special case forms for non-CSS tables so that
the form and generated content render as expected.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 10 Feb 2006 22:57:15 +0000 (22:57 +0000)]
* index.html: Fixed a typo in a link.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 10 Feb 2006 18:47:25 +0000 (18:47 +0000)]
Reviewed by Darin.
- Inlined RefPtr assignment operators. .7% performance win on
super-accurate JS iBench.
* kxmlcore/RefPtr.h:
(KXMLCore::::operator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 10 Feb 2006 17:31:10 +0000 (17:31 +0000)]
Some factual corrections and some updates to the coding style
document to reflect our current practices.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 10 Feb 2006 17:11:56 +0000 (17:11 +0000)]
* building/checkout.html: Fixed a spelling mistake.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 10 Feb 2006 16:41:21 +0000 (16:41 +0000)]
- fixed the build, this time for sure
* bindings/js/JSDOMCore.cpp: Touch this file, since the project doesn't get
the dependencies right.
* bindings/js/JSDOMEvents.cpp: Ditto.
* bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Fix an uninitialized
variable warning and also tightened the code for Boolean, String, and Number
up a bit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 10 Feb 2006 10:14:25 +0000 (10:14 +0000)]
2006-02-10 Joost de Valk <jdevalk@opendarwin.org>
Reviewed and landed by Anders.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7164
Code cleanup
Changed <div id="banner" to <h1 id="banner"
global cleanup of CSS and code
* building/build.html:
* building/checkout.html:
* coding/coding-style.html:
* coding/contributing.html:
* contact.html:
* index.html:
* projects/accessibility/index.html:
* projects/cleanup/index.html:
* projects/compat/index.html:
* projects/css/index.html:
* projects/documentation/index.html:
* projects/dom/index.html:
* projects/editing/index.html:
* projects/forms/index.html:
* projects/html/index.html:
* projects/index.html:
* projects/javascript/index.html:
* projects/layout/index.html:
* projects/mathml/index.html:
* projects/performance/index.html:
* projects/plugins/index.html:
* projects/portability/index.html:
* projects/printing/index.html:
* projects/svg/index.html:
* projects/webkit/index.html:
* projects/xml/index.html:
* projects/xslt/index.html:
* quality/bugpriorities.html:
* quality/bugwriting.html:
* quality/lifecycle.html:
* quality/reduction.html:
* quality/reporting.html:
* quality/testing.html:
* quality/testwriting.html:
* webkitdev.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 10 Feb 2006 09:49:02 +0000 (09:49 +0000)]
Improve the double buffering of the image viewer test app on win32 to do a source composit op and not a source-over op.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 10 Feb 2006 09:47:56 +0000 (09:47 +0000)]
Merge cairo fixes from Mozilla and one additional fix after discussion with vlad. Code is now smarter about knowing when to blt vs. alpha blend.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 10 Feb 2006 09:03:44 +0000 (09:03 +0000)]
No review needed, just a build fix. This time for sure.
* kjs/JSType.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 10 Feb 2006 08:42:21 +0000 (08:42 +0000)]
JavaScriptCore:
Reviewed by eric.
- Fixed build. As it goes without saying, I will not mention that I
blame Kevin.
* JavaScriptCore.xcodeproj/project.pbxproj:
* kjs/JSImmediate.cpp:
(KJS::JSImmediate::toObject):
JavaScriptGlue:
Reviewed by eric.
- Fixed build.
* UserObjectImp.cpp:
(UserObjectImp::toPrimitive):
* UserObjectImp.h:
WebCore:
Reviewed by eric.
- Fixed build.
* bridge/mac/WebCoreFrameBridge.mm:
* khtml/ecma/kjs_binding.h:
(KJS::DOMFunction::toPrimitive):
* khtml/ecma/kjs_dom.cpp:
(KJS::DOMNode::toPrimitive):
(KJS::DOMNodeList::toPrimitive):
* khtml/ecma/kjs_dom.h:
* khtml/ecma/kjs_window.cpp:
(KJS::Location::toPrimitive):
(KJS::Selection::toPrimitive):
* khtml/ecma/kjs_window.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 10 Feb 2006 06:42:01 +0000 (06:42 +0000)]
Reviewed by mjs.
- Fixed <rdar://problem/
4343730> Should switch ConstantValues (null,
undefined, true, false) from JS objects to immediate values similar to
SimpleNumber
2.0% performance gain on my new super-accurate version of JS iBench.
(I promise to land a version of it soon.)
The gist of the change:
(1) The SimpleNumber class (simple_number.h) is now the JSImmediate
class (JSImmediate.h/.cpp), and it handles not only numbers but also
null, undefined, true, and false.
(2) JSImmediate provides convenience methods for the bit masking
necessary to encode and decode immediate values.
(3) ConstantValues, BooleanImp, NullImp, and UndefinedImp are gone.
(4) JSCell no longer implements functions like getBoolean, because
only a JSImmediate can be a boolean.
(5) JSImmediate no longer uses ALWAYS_INLINE because there's no need,
and ALWAYS_INLINE is a non-portable option of last resort.
(6) Type is now JSType, and it resides in its own file, JSType.h.
Since I was there, I did some header include sorting as part of this
change.
The rest pretty much explains itself.
* JavaScriptCore.xcodeproj/project.pbxproj: Removed simple_number.h,
added JSImmediate.h/.cpp.
* bindings/c/c_instance.cpp:
(KJS::Bindings::CInstance::defaultValue):
* bindings/c/c_instance.h:
* bindings/c/c_utility.cpp:
(KJS::Bindings::convertValueToNPVariant):
* bindings/jni/jni_instance.cpp:
(JavaInstance::defaultValue):
* bindings/jni/jni_instance.h:
* bindings/jni/jni_jsobject.cpp:
(JavaJSObject::convertValueToJObject):
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]):
Standardized calls to use getXXX instead of hand-rolling JSValue
functionality.
* bindings/objc/objc_instance.h:
* bindings/objc/objc_instance.mm:
(ObjcInstance::getValueOfUndefinedField):
(ObjcInstance::defaultValue):
* bindings/objc/objc_runtime.h:
* bindings/objc/objc_runtime.mm:
(ObjcFallbackObjectImp::type):
(ObjcFallbackObjectImp::defaultValue):
* bindings/runtime.h:
(KJS::Bindings::Instance::getValueOfUndefinedField):
* bindings/runtime_object.cpp:
(RuntimeObjectImp::defaultValue):
* bindings/runtime_object.h:
* kjs/JSImmediate.h: Added.
(KJS::JSImmediate::isImmediate):
(KJS::JSImmediate::isNumber):
(KJS::JSImmediate::isBoolean):
(KJS::JSImmediate::isUndefinedOrNull):
(KJS::JSImmediate::fromDouble):
(KJS::JSImmediate::toDouble):
(KJS::JSImmediate::toBoolean):
(KJS::JSImmediate::trueImmediate):
(KJS::JSImmediate::falseImmediate):
(KJS::JSImmediate::NaNImmediate):
(KJS::JSImmediate::undefinedImmediate):
(KJS::JSImmediate::nullImmediate):
(KJS::JSImmediate::tag):
(KJS::JSImmediate::unTag):
(KJS::JSImmediate::getTag):
(KJS::JSImmediate::):
(KJS::JSImmediate::isIEEE):
(KJS::JSImmediate::is32bit):
(KJS::JSImmediate::is64bit):
(KJS::JSImmediate::NanAsBits):
(KJS::JSImmediate::zeroAsBits):
(KJS::JSImmediate::oneAsBits):
* kjs/JSLock.cpp:
(KJS::JSLock::lock): Removed hack-o-rama to initialize ConstantValues.
* kjs/JSType.h: Added.
* kjs/collector.cpp:
(KJS::Collector::protect):
(KJS::Collector::unprotect):
(KJS::Collector::collect):
* kjs/internal.cpp:
(KJS::StringImp::toPrimitive):
(KJS::NumberImp::toPrimitive):
(KJS::NumberImp::toBoolean):
(KJS::GetterSetterImp::toPrimitive):
* kjs/internal.h:
(KJS::StringImp::type):
(KJS::NumberImp::type):
* kjs/object.cpp:
(KJS::JSObject::type):
(KJS::tryGetAndCallProperty): Replaced "Are you one of the six things
I'm looking for?" test with "Are you not the one thing I'm not looking
for" test.
(KJS::JSObject::defaultValue):
(KJS::JSObject::toPrimitive):
* kjs/object.h:
(KJS::GetterSetterImp::type):
(KJS::JSValue::isObject):
* kjs/operations.cpp:
(KJS::equal):
(KJS::strictEqual):
(KJS::add):
* kjs/reference.cpp:
(KJS::Reference::deleteValue):
* kjs/simple_number.h: Removed.
* kjs/string_object.cpp:
(StringInstance::getOwnPropertySlot): fixed indentation
* kjs/value.cpp:
(KJS::JSValue::toObject):
(KJS::jsNumberCell): New function to quarantine a PIC branch -- allows
us to inline jsNumber without adding PIC branches to callers.
* kjs/value.h:
(KJS::jsUndefined):
(KJS::jsNull):
(KJS::jsNaN):
(KJS::jsBoolean):
(KJS::jsNumber):
(KJS::JSValue::downcast):
(KJS::JSValue::isUndefinedOrNull):
(KJS::JSValue::isBoolean):
(KJS::JSValue::isNumber):
(KJS::JSValue::isString):
(KJS::JSValue::isObject):
(KJS::JSValue::getBoolean):
(KJS::JSValue::getNumber):
(KJS::JSValue::getString):
(KJS::JSValue::getObject):
(KJS::JSValue::getUInt32):
(KJS::JSValue::mark): Replaced !JSImmediate::is() test with assertion,
resulting in a slight performance gain. Callers should always check
!marked() before calling mark(), so it's impossible to call mark on
a JSImmediate.
(KJS::JSValue::marked):
(KJS::JSValue::type):
(KJS::JSValue::toPrimitive):
(KJS::JSValue::toBoolean):
(KJS::JSValue::toNumber):
(KJS::JSValue::toString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Fri, 10 Feb 2006 01:30:02 +0000 (01:30 +0000)]
Reviewed by Tim Hatcher.
<rdar://problem/
4153419> CrashTracer: 576 crashes in Safari at com.apple.WebKit: NPN_DestroyStream + 56
I never could reproduce this crasher, which seems to be caused by the Speed Download plugin. However,
I did find a way to make the affected code more bulletproof for those who are experiencing the crash.
* Plugins/WebBaseNetscapePluginStream.h:
Keep a WebBaseNetscapePluginView instead of the WebNetscapePluginPackage, since the plugin view could
potentially be deallocated before the stream finishes loading.
* Plugins/WebBaseNetscapePluginStream.m:
(-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]):
Use pluginView instead of plugin.
(-[WebBaseNetscapePluginStream dealloc]):
Assert that the plugin instance has been nulled out, since that's now part of the stream's teardown
phase.
Release pluginView instead of plugin.
(-[WebBaseNetscapePluginStream setPluginPointer:]):
Retain the plugin view instead of the plugin package, since the plugin view could be deallocated while
the stream is running.
This method now accepts a NULL argument so that we can easily clear out the pluginView backpointer
(and other ivars derived from it).
(-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
Use pluginView instead of plugin.
(-[WebBaseNetscapePluginStream _destroyStream]):
ditto
(-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
ditto
(-[WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError]):
Set the plugin instance to NULL, so that the pluginView backpointer is released. This method is called
for every plugin view's stream when the plugin view is stopped/destroyed.
(-[WebBaseNetscapePluginStream _deliverData]):
Use pluginView instead of plugin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 10 Feb 2006 01:20:59 +0000 (01:20 +0000)]
Reviewed by Hyatt.
- <rdar://problem/
4430614> RenderThemeMac crashes under GC
* rendering/render_theme_mac.mm:
(WebCore::RenderThemeMac::RenderThemeMac): Initialize all the pointers.
(WebCore::RenderThemeMac::setCheckboxCellState): Use KWQRetainNSRelease so
we can retain a pointer to an ObjC object in a C++ class.
(WebCore::RenderThemeMac::setRadioCellState): Ditto.
(WebCore::RenderThemeMac::setButtonCellState): Ditto.
(WebCore::RenderThemeMac::setTextFieldCellState): Ditto.
* kwq/KWQResourceLoader.h: Remove unneeded forward declaration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log