lforschler@apple.com [Thu, 14 Apr 2011 21:59:28 +0000 (21:59 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 14 Apr 2011 21:46:56 +0000 (21:46 +0000)]
REGRESSION(r74107): Including svg format in @font-face rules makes Web Fonts fail to load
https://bugs.webkit.org/show_bug.cgi?id=57766
<rdar://problem/
9232183>
Reviewed by Oliver Hunt.
Source/WebCore:
Move the knowledge of whether to interpret a font as SVG from CachedFont to CSSFontFaceSource. This way
we can try to interpret the same cached resource in multiple ways.
Test: fast/css/font-face-repeated-url.html
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::getFontData):
* css/CSSFontFaceSource.h:
(WebCore::CSSFontFaceSource::setHasExternalSVGFont):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::ensureSVGFontData):
Use TextResourceDecoder correctly.
(WebCore::CachedFont::getSVGFontById):
* loader/cache/CachedFont.h:
* svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::loadFont):
LayoutTests:
* fast/css/font-face-repeated-url-expected.txt: Added.
* fast/css/font-face-repeated-url.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 14 Apr 2011 21:39:08 +0000 (21:39 +0000)]
Make creating WebPreferences lazy
https://bugs.webkit.org/show_bug.cgi?id=58570
Reviewed by Anders Carlsson.
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):
(WebKit::WebPageGroup::preferences):
* UIProcess/WebPageGroup.h:
Don't create the WebPreference object until it is requested.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 14 Apr 2011 21:09:48 +0000 (21:09 +0000)]
Temporarily remove assertion that's firing all the time.
RS=Anders
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Thu, 14 Apr 2011 21:01:52 +0000 (21:01 +0000)]
2011-04-14 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Enable building Web Audio with MKL in Chrome-branded builds
https://bugs.webkit.org/show_bug.cgi?id=58561
Factored out MKL support into a separate GYP file that is
incorporated in Chrome-branded builds. Changed how the FFTFrame
implementations are pulled in and chosen so that all files can be
unconditionally compiled.
Tested with both Chrome-branded build (incorporating MKL) and
Chromium build (building just FFTFrameStub.cpp) on Linux.
* WebCore.gyp/WebCore.gyp:
* platform/audio/fftw/FFTFrameFFTW.cpp:
* platform/audio/mkl/FFTFrameMKL.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 14 Apr 2011 20:53:21 +0000 (20:53 +0000)]
2011-01-26 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] Web Inspector does not highlight elements
https://bugs.webkit.org/show_bug.cgi?id=35125
Adjust Web inspector to highlight elements on the page when the mouse
hovers the element on DOM inspector.
* Api/qwebframe.cpp:
(QWebFramePrivate::renderRelativeCoords):
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::highlight):
(WebCore::InspectorClientQt::hideHighlight):
2011-04-14 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
Reviewed by Antonio Gomes.
[Qt] Web Inspector does not highlight elements
https://bugs.webkit.org/show_bug.cgi?id=35125
We should call drawNodeHighlight() just if a highlighted node exists
to avoid do save()/restore() on the Graphics Context unnecessarily.
Added highlightedNode() method to check if we need to call drawNodeHighlight()
and only on this case do save()/restore() on the Graphics Context.
* inspector/InspectorAgent.h:
(WebCore::InspectorAgent::highlightedNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 14 Apr 2011 20:50:02 +0000 (20:50 +0000)]
2011-04-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] TilingData should return 1 tile when tile size is texture size.
https://bugs.webkit.org/show_bug.cgi?id=58364
* platform/graphics/gpu/TilingData.cpp:
(WebCore::computeNumTiles):
2011-04-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
[chromium] TilingData should return 1 tile if tile size is texture size.
https://bugs.webkit.org/show_bug.cgi?id=58364
Update test to properly handle this case.
* tests/TilingDataTest.cpp:
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 14 Apr 2011 20:39:10 +0000 (20:39 +0000)]
2011-04-14 James Robinson <jamesr@chromium.org>
Update chromium expectations for tests that have subtle 32vs64 bit rendering differences on linux in the GPU path.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 14 Apr 2011 20:34:29 +0000 (20:34 +0000)]
2011-04-14 Andy Estes <aestes@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r72141): Acid3 rendering is not pixel perfect.
https://bugs.webkit.org/show_bug.cgi?id=55734
* fast/text/zero-font-size.html: Added.
* platform/mac/fast/text/zero-font-size-expected.checksum: Added.
* platform/mac/fast/text/zero-font-size-expected.png: Added.
* platform/mac/fast/text/zero-font-size-expected.txt: Added.
2011-04-14 Andy Estes <aestes@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r72141): Acid3 rendering is not pixel perfect.
https://bugs.webkit.org/show_bug.cgi?id=55734
WebCore should render text with a 0px font size at 0px regardless of
minimum font size settings. This is compatible with other browsers that
have a minimum font size preference and ensures pixel-perfect rendering
on Acid3.
Test: fast/text/zero-font-size.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): If
specifiedSize is 0, return specified size regardless of zoom factor or
minimum font size.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Thu, 14 Apr 2011 20:31:43 +0000 (20:31 +0000)]
2011-04-14 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Have canvas drawImageFromRect just redirect to use drawImage
https://bugs.webkit.org/show_bug.cgi?id=58516
Test: fast/canvas/drawImageFromRect_withToDataURLAsSource.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
* html/canvas/CanvasRenderingContext2D.h:
2011-04-14 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Have canvas drawImageFromRect just redirect to use drawImage
https://bugs.webkit.org/show_bug.cgi?id=58516
* fast/canvas/drawImageFromRect_withToDataURLAsSource-expected.txt: Added.
* fast/canvas/drawImageFromRect_withToDataURLAsSource.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 14 Apr 2011 20:26:57 +0000 (20:26 +0000)]
2011-04-14 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=58535
Remove unnecessary baselines - the behavior on these tests should
match the mac port now.
* platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Removed.
* platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
* platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Removed.
* platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
* platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
* platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
* platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
* platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
* platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Removed.
* platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Removed.
* platform/win/compositing/overflow/resize-painting-expected.txt: Removed.
2011-04-14 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=58535
Change PLATFORM(MAC) guards to !PLATFORM(CHROMIUM) so they apply correctly to the windows build.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresScrollCornerLayer):
* rendering/RenderLayerCompositor.cpp:
(WebCore::shouldCompositeOverflowControls):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 14 Apr 2011 20:24:20 +0000 (20:24 +0000)]
[Qt] 9 tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52810
https://bugs.webkit.org/show_bug.cgi?id=52812
* platform/qt/Skipped: Add svg/text/text-align-05-b.svg
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 14 Apr 2011 20:17:11 +0000 (20:17 +0000)]
2011-04-14 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make protected object list in caches window reflect reality
https://bugs.webkit.org/show_bug.cgi?id=58565
Make sure the heap includes objects protected by Strong handles
in its list of protected objects.
* heap/HandleHeap.h:
* heap/Heap.cpp:
(JSC::HandleHeap::protectedObjectTypeCounts):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Thu, 14 Apr 2011 20:13:42 +0000 (20:13 +0000)]
BlobBuilder should be vendor-prefixed
https://bugs.webkit.org/show_bug.cgi?id=58518
Reviewed by Darin Fisher.
Source/WebCore:
Renamed BlobBuilder to WebKitBlobBuilder.
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* fileapi/WebKitBlobBuilder.cpp: Renamed from Source/WebCore/fileapi/BlobBuilder.cpp.
(WebCore::WebKitBlobBuilder::WebKitBlobBuilder):
(WebCore::WebKitBlobBuilder::getBuffer):
(WebCore::WebKitBlobBuilder::append):
(WebCore::WebKitBlobBuilder::getBlob):
* fileapi/WebKitBlobBuilder.h: Renamed from Source/WebCore/fileapi/BlobBuilder.h.
(WebCore::WebKitBlobBuilder::create):
* fileapi/WebKitBlobBuilder.idl: Renamed from Source/WebCore/fileapi/BlobBuilder.idl.
* page/DOMWindow.idl:
* workers/WorkerContext.idl:
LayoutTests:
* fast/dom/Window/script-tests/window-property-descriptors.js:
* fast/dom/Window/window-properties.html:
* fast/dom/Window/window-property-descriptors-expected.txt:
* fast/dom/prototype-inheritance-2-expected.txt:
* fast/dom/prototype-inheritance-expected.txt:
* fast/dom/script-tests/constructed-objects-prototypes.js:
(constructorPropertiesOnWindow):
* fast/dom/script-tests/prototype-inheritance-2.js:
(constructorNamesForWindow):
* fast/dom/script-tests/prototype-inheritance.js:
* fast/dom/window-domurl-crash.html:
* fast/files/blob-slice-overflow.html:
* fast/files/blob-slice-test.html:
* fast/files/resources/read-blob-test-cases.js:
(testReadingTripleSlicedHybridBlob):
* fast/files/resources/read-common.js:
(buildBlob):
* fast/files/workers/inline-worker-via-blob-url.html:
* fast/filesystem/resources/file-writer-events.js:
(tenXBlob):
(startWrite):
* fast/filesystem/resources/file-writer-gc-blob.js:
(tenXBlob):
(startWrite):
* fast/filesystem/resources/file-writer-sync-truncate-extend.js:
* fast/filesystem/resources/file-writer-sync-write-overlapped.js:
* fast/filesystem/resources/file-writer-utils.js:
* fast/js/global-constructors-expected.txt:
* fast/js/script-tests/global-constructors.js:
* http/tests/fileapi/create-blob-url-from-data-url.html:
* http/tests/local/blob/resources/hybrid-blob-util.js:
(HybridBlobTestUtil.this.appendAndCreateBlob):
(HybridBlobTestUtil):
* http/tests/security/resources/create-filesystem-file.html:
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:
* platform/win/fast/dom/window-domurl-crash-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 14 Apr 2011 19:54:30 +0000 (19:54 +0000)]
2011-04-14 Adam Barth <abarth@webkit.org>
Remove some trailing whitespace. I'm making this change to initialize
the SVN credentials on a new commit-queue machine. I'm sure there's a
better way to do this, but I don't know it.
* dom/Document.cpp:
(WebCore::Document::Document):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
psolanki@apple.com [Thu, 14 Apr 2011 19:50:37 +0000 (19:50 +0000)]
Set minimum priority for fast lane connections
https://bugs.webkit.org/show_bug.cgi?id=58353
Reviewed by David Kilzer.
Source/WebCore:
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Call
wkSetHTTPPipeliningMinimumFastLanePriority to allow javascript resources to use the fast
lane connections.
Source/WebKit/mac:
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
Source/WebKit2:
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Support for new WKSI method WKSetHTTPPipeliningMinimumFastLanePriority.
WebKitLibraries:
Add WKSetHTTPPipeliningMinimumFastLanePriority.
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 14 Apr 2011 18:55:31 +0000 (18:55 +0000)]
2011-04-14 Eric Seidel <eric@webkit.org>
Reviewed by Dimitri Glazkov.
queues.webkit.org should display when a bot last passed a patch
https://bugs.webkit.org/show_bug.cgi?id=58546
I am suspicious that some of our commit-queue instances are never
actually passing anything.
This will let us know if those bots are never passing patches.
* QueueStatusServer/handlers/queuestatus.py:
* QueueStatusServer/index.yaml:
* QueueStatusServer/templates/queuestatus.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 14 Apr 2011 18:53:52 +0000 (18:53 +0000)]
2011-04-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Roben.
REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
https://bugs.webkit.org/show_bug.cgi?id=58545
Remove platform-specific overrides; the default behavior should
be working everywhere now, I think.
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Thu, 14 Apr 2011 18:46:34 +0000 (18:46 +0000)]
Unreviewed, fixed tests caused by r83873.
* fast/filesystem/resources/file-writer-utils.js:
(verifyByteRangeIsZeroesHelper):
(verifyByteRangeAsStringHelper):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 14 Apr 2011 18:33:24 +0000 (18:33 +0000)]
[Qt] fast/transforms/scrollIntoView-transformed.html fails
https://bugs.webkit.org/show_bug.cgi?id=58559
* platform/qt/Skipped: Add fast/transforms/scrollIntoView-transformed.html until fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 14 Apr 2011 18:23:18 +0000 (18:23 +0000)]
2011-04-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queues are hitting an exception trying to land when the tree is red
https://bugs.webkit.org/show_bug.cgi?id=58558
Just an un-tested (and thus broken) code path from yesterday's changes.
* Scripts/webkitpy/common/net/layouttestresults.py:
* Scripts/webkitpy/common/net/layouttestresults_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Thu, 14 Apr 2011 18:19:49 +0000 (18:19 +0000)]
2011-04-14 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Fix Web Audio build on Linux Debug and with stub FFTFrame
https://bugs.webkit.org/show_bug.cgi?id=58555
Built Chromium/Linux in Debug mode to test.
* platform/audio/FFTFrame.cpp:
* platform/audio/FFTFrameStub.cpp:
(WebCore::FFTFrame::initialize):
* webaudio/AudioContext.cpp:
* webaudio/DefaultAudioDestinationNode.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 14 Apr 2011 18:13:10 +0000 (18:13 +0000)]
2011-04-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
[v8] Web Inspector: add initial implementation of WorkerScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=58552
* bindings/v8/DebuggerScript.js:
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded): each worker context
now have a debug id (similar to frame contexts).
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::retrieveWorkerContext):
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause): run message loop until
debugger command is received and execution is resumed.
(WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
* bindings/v8/WorkerScriptDebugServer.h:
* inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
(WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Thu, 14 Apr 2011 18:10:50 +0000 (18:10 +0000)]
Add webkit prefix to Blob.slice method and change its semantics to be
like Array.slice
https://bugs.webkit.org/show_bug.cgi?id=58496
Reviewed by Darin Fisher.
Source/WebCore:
Renamed Blob.slice to blob.webkitSlice and made it take start and end
parameters that're like Array.slice.
Test: fast/files/blob-slice-test.html
* fileapi/Blob.cpp:
(WebCore::Blob::webkitSlice):
* fileapi/Blob.h:
* fileapi/Blob.idl:
LayoutTests:
Added a new test to test the new behavior and also update all existing
tests to use the new name.
* fast/dom/Window/window-properties.html:
* fast/files/blob-slice-overflow.html:
* fast/files/blob-slice-test-expected.txt: Added.
* fast/files/blob-slice-test.html: Added.
* fast/files/resources/read-blob-test-cases.js:
(testReadingSlicedFileBlob):
(testReadingSlicedTextBlob):
(testReadingSlicedArrayBufferBlob):
(testReadingSlicedHybridBlob):
(testReadingTripleSlicedHybridBlob):
* fast/filesystem/resources/file-writer-utils.js:
(verifyByteRangeIsZeroesHelper):
(verifyByteRangeAsStringHelper):
* http/tests/local/blob/script-tests/send-hybrid-blob.js:
():
* http/tests/local/blob/script-tests/send-sliced-data-blob.js:
(runSliceTest):
* http/tests/local/fileapi/script-tests/send-sliced-dragged-file.js:
(onStableFileDrop):
(onUnstableFileDrop):
* http/tests/local/formdata/resources/send-form-data-common.js:
(testSendingFormData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 14 Apr 2011 18:10:47 +0000 (18:10 +0000)]
Clang warning fixes.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/mac/TextCheckerMac.mm:
* WebProcess/Downloads/mac/DownloadMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 14 Apr 2011 17:53:26 +0000 (17:53 +0000)]
[Qt] Height of "Ahem" font differs from all other ports.
https://bugs.webkit.org/show_bug.cgi?id=57954
Source/WebCore:
Patch by Andreas Kling <kling@webkit.org> on 2011-04-14
Reviewed by Benjamin Poulain.
QFontMetricsF::descent() returns the actual descent minus 1,
to account for the baseline. Add it back to get correct metrics
for WebKit.
QFontMetricsF::leading() may return negative values on some
platforms (those using FreeType), this breaks WebKit's assumption
that lineSpacing >= (ascent + descent), so we work around this in
the same fashion as SimpleFontDataFreeType and SimpleFontDataPango.
This is covered by thousands of layout tests.
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformInit):
LayoutTests:
* platform/qt/ [...]: Update expected files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 14 Apr 2011 17:47:48 +0000 (17:47 +0000)]
2011-04-14 Tony Chang <tony@chromium.org>
Reviewed by Adam Roben.
make PrettyPatch.rb aware of checksums in png files
https://bugs.webkit.org/show_bug.cgi?id=58387
Patch v2 with nil checks in the case of file adds and deletes.
* PrettyPatch/PrettyPatch.rb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 14 Apr 2011 17:26:46 +0000 (17:26 +0000)]
[wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 14 Apr 2011 17:21:36 +0000 (17:21 +0000)]
Fix build.
RuntimeApplicationChecks.h needs to be a private header so WebKit can find it.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 14 Apr 2011 17:10:06 +0000 (17:10 +0000)]
WebKit2: Add an option for a PageGroup to be invisible to the History Client.
https://bugs.webkit.org/show_bug.cgi?id=58547
Reviewed by Timothy Hatcher.
* Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):
* Shared/WebPageGroupData.h:
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectorPageGroup):
The Web Inspector should not be visible to the History Client, because its HTML-based nature
should not be exposed through the API.
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::WebPageGroup):
* UIProcess/WebPageGroup.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::updateGlobalHistory):
Do not send the message to the WebContent for the history client.
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
Ditto.
(WebKit::WebFrameLoaderClient::setTitle):
Ditto.
* WebProcess/WebPage/WebPageGroupProxy.h:
(WebKit::WebPageGroupProxy::isVisibleToHistoryClient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 14 Apr 2011 16:57:37 +0000 (16:57 +0000)]
2011-04-14 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, build fix for r83864.
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._childNodeRemoved):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 14 Apr 2011 16:47:34 +0000 (16:47 +0000)]
2011-04-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Content area highlight does not cover scrollbars
https://bugs.webkit.org/show_bug.cgi?id=58528
* inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::DrawNodeHighlight):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 14 Apr 2011 16:18:48 +0000 (16:18 +0000)]
2011-04-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: re-implement dom breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=57038
* inspector/debugger/dom-breakpoints.html:
2011-04-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: re-implement dom breakpoints.
https://bugs.webkit.org/show_bug.cgi?id=57038
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/BreakpointManager.js: Removed.
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.NativeBreakpointsSidebarPane):
(WebInspector.NativeBreakpointsSidebarPane.prototype._reset):
(WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
(WebInspector.CallStackSidebarPane.prototype.setStatus):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMAgent.prototype._childNodeRemoved):
* inspector/front-end/DOMBreakpointsSidebarPane.js: Added.
(WebInspector.DOMBreakpointsSidebarPane):
(WebInspector.DOMBreakpointsSidebarPane.prototype.setInspectedURL):
(WebInspector.DOMBreakpointsSidebarPane.prototype.populateNodeContextMenu.toggleBreakpoint):
(WebInspector.DOMBreakpointsSidebarPane.prototype.populateNodeContextMenu):
(WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage.didPushNodeToFrontend):
(WebInspector.DOMBreakpointsSidebarPane.prototype.createBreakpointHitStatusMessage):
(WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage.formatters.s):
(WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage.append):
(WebInspector.DOMBreakpointsSidebarPane.prototype._doCreateBreakpointHitStatusMessage):
(WebInspector.DOMBreakpointsSidebarPane.prototype.nodeRemoved):
(WebInspector.DOMBreakpointsSidebarPane.prototype._removeBreakpointsForNode):
(WebInspector.DOMBreakpointsSidebarPane.prototype._setBreakpoint):
(WebInspector.DOMBreakpointsSidebarPane.prototype._removeBreakpoint):
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint):
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):
(WebInspector.DOMBreakpointsSidebarPane.prototype._checkboxClicked):
(WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.DOMBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
(WebInspector.DOMBreakpointsSidebarPane.prototype._createBreakpointId):
(WebInspector.DOMBreakpointsSidebarPane.prototype._saveBreakpoints):
(WebInspector.DOMBreakpointsSidebarPane.prototype.restoreBreakpoints):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.show):
(WebInspector.ElementsPanel.prototype.updateModifiedNodes):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.coalesceCollapsedCrumbs):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.show):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.didCreateBreakpointHitStatusMessage):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._clearInterface):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
(WebInspector.Settings.prototype._set):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.inspectedURLChanged):
* inspector/front-end/utilities.js:
():
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Thu, 14 Apr 2011 15:51:53 +0000 (15:51 +0000)]
2011-04-14 Satish Sampath <satish@chromium.org>
Reviewed by Kent Tamura.
Disable speech input for readonly and disabled input fields.
https://bugs.webkit.org/show_bug.cgi?id=58540
* fast/speech/input-readonly-and-disabled-expected.txt: Added.
* fast/speech/input-readonly-and-disabled.html: Added.
2011-04-14 Satish Sampath <satish@chromium.org>
Reviewed by Kent Tamura.
Disable speech input for readonly and disabled input fields.
https://bugs.webkit.org/show_bug.cgi?id=58540
Test: fast/speech/input-readonly-and-disabled.html
* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 14 Apr 2011 15:49:05 +0000 (15:49 +0000)]
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Rollout r83849 and r83857.
* inspector/Inspector.json:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::setFrontend):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):
* inspector/InspectorDatabaseAgent.h:
* inspector/front-end/inspector.js:
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed. Rollout r83849 and r83857.
* http/tests/inspector-enabled/database-open.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Thu, 14 Apr 2011 15:47:38 +0000 (15:47 +0000)]
2011-04-14 Satish Sampath <satish@chromium.org>
Reviewed by Anders Carlsson.
Don't emit RegExp tables for chromium where they are not used
https://bugs.webkit.org/show_bug.cgi?id=58544
* JavaScriptCore.gyp/JavaScriptCore.gyp:
* create_regex_tables: Added the "--notables" command line argument.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 14 Apr 2011 15:25:35 +0000 (15:25 +0000)]
2011-04-14 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r83855.
http://trac.webkit.org/changeset/83855
After r83847 has been rolled out, these expectations no longer
apply.
* platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Removed.
* platform/chromium-gpu-linux/media/controls-strict-expected.png: Removed.
* platform/chromium-gpu-linux/media/controls-styling-expected.png: Removed.
* platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Removed.
* platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-controls-rendering-expected.png: Removed.
* platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
* platform/chromium-gpu-linux/media/video-no-audio-expected.png:
* platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Removed.
* platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Removed.
* platform/chromium-gpu-mac/media/controls-strict-expected.png: Removed.
* platform/chromium-gpu-mac/media/controls-styling-expected.png: Removed.
* platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Removed.
* platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Removed.
* platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.txt: Removed.
* platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Removed.
* platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
* platform/chromium-gpu-mac/media/video-no-audio-expected.png:
* platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
* platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-win/media/controls-after-reload-expected.png: Removed.
* platform/chromium-gpu-win/media/controls-strict-expected.png: Removed.
* platform/chromium-gpu-win/media/controls-styling-expected.png: Removed.
* platform/chromium-gpu-win/media/controls-without-preload-expected.png: Removed.
* platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Removed.
* platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Removed.
* platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Removed.
* platform/chromium-gpu-win/media/video-display-toggle-expected.png:
* platform/chromium-gpu-win/media/video-no-audio-expected.png:
* platform/chromium-gpu-win/media/video-volume-slider-expected.png:
* platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Removed.
* platform/chromium-linux/fast/layers/video-layer-expected.png:
* platform/chromium-linux/media/audio-controls-rendering-expected.png:
* platform/chromium-linux/media/controls-after-reload-expected.png:
* platform/chromium-linux/media/controls-strict-expected.png:
* platform/chromium-linux/media/controls-styling-expected.png:
* platform/chromium-linux/media/controls-without-preload-expected.png:
* platform/chromium-linux/media/media-document-audio-repaint-expected.png:
* platform/chromium-linux/media/video-controls-rendering-expected.png:
* platform/chromium-linux/media/video-display-toggle-expected.png:
* platform/chromium-linux/media/video-empty-source-expected.png:
* platform/chromium-linux/media/video-no-audio-expected.png:
* platform/chromium-linux/media/video-volume-slider-expected.png:
* platform/chromium-linux/media/video-zoom-controls-expected.png:
* platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png: Removed.
* platform/chromium-mac/fast/layers/video-layer-expected.checksum: Added.
* platform/chromium-mac/fast/layers/video-layer-expected.png:
* platform/chromium-mac/fast/layers/video-layer-expected.txt:
* platform/chromium-mac/media/audio-controls-rendering-expected.checksum: Added.
* platform/chromium-mac/media/audio-controls-rendering-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.txt:
* platform/chromium-mac/media/controls-after-reload-expected.checksum: Added.
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.txt:
* platform/chromium-mac/media/controls-strict-expected.checksum: Added.
* platform/chromium-mac/media/controls-strict-expected.png:
* platform/chromium-mac/media/controls-strict-expected.txt:
* platform/chromium-mac/media/controls-styling-expected.checksum: Added.
* platform/chromium-mac/media/controls-styling-expected.png:
* platform/chromium-mac/media/controls-styling-expected.txt:
* platform/chromium-mac/media/controls-without-preload-expected.checksum: Added.
* platform/chromium-mac/media/controls-without-preload-expected.png:
* platform/chromium-mac/media/controls-without-preload-expected.txt:
* platform/chromium-mac/media/media-document-audio-repaint-expected.checksum: Added.
* platform/chromium-mac/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
* platform/chromium-mac/media/video-controls-rendering-expected.checksum: Added.
* platform/chromium-mac/media/video-controls-rendering-expected.png:
* platform/chromium-mac/media/video-controls-rendering-expected.txt:
* platform/chromium-mac/media/video-display-toggle-expected.checksum: Added.
* platform/chromium-mac/media/video-display-toggle-expected.png:
* platform/chromium-mac/media/video-display-toggle-expected.txt:
* platform/chromium-mac/media/video-empty-source-expected.checksum: Added.
* platform/chromium-mac/media/video-empty-source-expected.png:
* platform/chromium-mac/media/video-empty-source-expected.txt:
* platform/chromium-mac/media/video-no-audio-expected.checksum: Added.
* platform/chromium-mac/media/video-no-audio-expected.png:
* platform/chromium-mac/media/video-no-audio-expected.txt:
* platform/chromium-mac/media/video-volume-slider-expected.checksum: Added.
* platform/chromium-mac/media/video-volume-slider-expected.png:
* platform/chromium-mac/media/video-volume-slider-expected.txt:
* platform/chromium-mac/media/video-zoom-controls-expected.png:
* platform/chromium-mac/media/video-zoom-controls-expected.txt:
* platform/chromium-win/fast/layers/video-layer-expected.png:
* platform/chromium-win/fast/layers/video-layer-expected.txt:
* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/audio-controls-rendering-expected.txt:
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.txt:
* platform/chromium-win/media/controls-strict-expected.png:
* platform/chromium-win/media/controls-strict-expected.txt:
* platform/chromium-win/media/controls-styling-expected.png:
* platform/chromium-win/media/controls-styling-expected.txt:
* platform/chromium-win/media/controls-without-preload-expected.png:
* platform/chromium-win/media/controls-without-preload-expected.txt:
* platform/chromium-win/media/media-document-audio-repaint-expected.png:
* platform/chromium-win/media/media-document-audio-repaint-expected.txt:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.txt:
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.txt:
* platform/chromium-win/media/video-empty-source-expected.png:
* platform/chromium-win/media/video-empty-source-expected.txt:
* platform/chromium-win/media/video-no-audio-expected.png:
* platform/chromium-win/media/video-no-audio-expected.txt:
* platform/chromium-win/media/video-volume-slider-expected.png:
* platform/chromium-win/media/video-volume-slider-expected.txt:
* platform/chromium-win/media/video-zoom-controls-expected.png:
* platform/chromium-win/media/video-zoom-controls-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 14 Apr 2011 15:23:36 +0000 (15:23 +0000)]
2011-04-14 Dimitri Glazkov <dglazkov@chromium.org>
Unreviewed, rolling out r83847.
http://trac.webkit.org/changeset/83847
https://bugs.webkit.org/show_bug.cgi?id=58477
Chromium media controls do use button borders, so this change
is incorrect.
* css/mediaControls.css:
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 14 Apr 2011 15:15:12 +0000 (15:15 +0000)]
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed test fix for r83849.
It was flaky.
* http/tests/inspector-enabled/database-open.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 14 Apr 2011 14:42:39 +0000 (14:42 +0000)]
Add new Windows expected results after r83820
Windows differs from Mac on these tests due to extra scrollbar layers. Presumably this is
because Mac uses native scrollbars for frames, and thus can't put them into layers.
<http://webkit.org/b/58535> tracks the difference, but will probably just be closed as
"works correctly".
* platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
* platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
* platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
* platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Added.
* platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
* platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
* platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
* platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
* platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
* platform/win/compositing/iframes/iframe-resize-expected.txt: Added.
* platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
* platform/win/compositing/iframes/overlapped-iframe-expected.txt: Added.
* platform/win/compositing/iframes/scrolling-iframe-expected.txt: Added.
* platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
* platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
* platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
* platform/win/compositing/overflow/resize-painting-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 14 Apr 2011 14:36:37 +0000 (14:36 +0000)]
2011-04-14 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Updated/added chromium test expectation for media controls tests following CSS change in r83847.
* platform/chromium-gpu-linux/media/controls-after-reload-expected.png: Added.
* platform/chromium-gpu-linux/media/controls-strict-expected.png: Added.
* platform/chromium-gpu-linux/media/controls-styling-expected.png: Added.
* platform/chromium-gpu-linux/media/controls-without-preload-expected.png: Added.
* platform/chromium-gpu-linux/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-gpu-linux/media/video-controls-rendering-expected.png: Added.
* platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
* platform/chromium-gpu-linux/media/video-no-audio-expected.png:
* platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-controls-expected.png: Added.
* platform/chromium-gpu-mac/media/controls-after-reload-expected.png: Added.
* platform/chromium-gpu-mac/media/controls-strict-expected.png: Added.
* platform/chromium-gpu-mac/media/controls-styling-expected.png: Added.
* platform/chromium-gpu-mac/media/controls-without-preload-expected.png: Added.
* platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-gpu-mac/media/media-document-audio-repaint-expected.txt: Added.
* platform/chromium-gpu-mac/media/video-controls-rendering-expected.png: Added.
* platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
* platform/chromium-gpu-mac/media/video-no-audio-expected.png:
* platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
* platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
* platform/chromium-gpu-win/media/controls-after-reload-expected.png: Added.
* platform/chromium-gpu-win/media/controls-strict-expected.png: Added.
* platform/chromium-gpu-win/media/controls-styling-expected.png: Added.
* platform/chromium-gpu-win/media/controls-without-preload-expected.png: Added.
* platform/chromium-gpu-win/media/media-document-audio-repaint-expected.png: Added.
* platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt: Added.
* platform/chromium-gpu-win/media/video-controls-rendering-expected.png: Added.
* platform/chromium-gpu-win/media/video-display-toggle-expected.png:
* platform/chromium-gpu-win/media/video-no-audio-expected.png:
* platform/chromium-gpu-win/media/video-volume-slider-expected.png:
* platform/chromium-gpu-win/media/video-zoom-controls-expected.png: Added.
* platform/chromium-linux/fast/layers/video-layer-expected.png:
* platform/chromium-linux/media/audio-controls-rendering-expected.png:
* platform/chromium-linux/media/controls-after-reload-expected.png:
* platform/chromium-linux/media/controls-strict-expected.png:
* platform/chromium-linux/media/controls-styling-expected.png:
* platform/chromium-linux/media/controls-without-preload-expected.png:
* platform/chromium-linux/media/media-document-audio-repaint-expected.png:
* platform/chromium-linux/media/video-controls-rendering-expected.png:
* platform/chromium-linux/media/video-display-toggle-expected.png:
* platform/chromium-linux/media/video-empty-source-expected.png:
* platform/chromium-linux/media/video-no-audio-expected.png:
* platform/chromium-linux/media/video-volume-slider-expected.png:
* platform/chromium-linux/media/video-zoom-controls-expected.png:
* platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png: Added.
* platform/chromium-mac/fast/layers/video-layer-expected.checksum: Removed.
* platform/chromium-mac/fast/layers/video-layer-expected.png:
* platform/chromium-mac/fast/layers/video-layer-expected.txt:
* platform/chromium-mac/media/audio-controls-rendering-expected.checksum: Removed.
* platform/chromium-mac/media/audio-controls-rendering-expected.png:
* platform/chromium-mac/media/audio-controls-rendering-expected.txt:
* platform/chromium-mac/media/controls-after-reload-expected.checksum: Removed.
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.txt:
* platform/chromium-mac/media/controls-strict-expected.checksum: Removed.
* platform/chromium-mac/media/controls-strict-expected.png:
* platform/chromium-mac/media/controls-strict-expected.txt:
* platform/chromium-mac/media/controls-styling-expected.checksum: Removed.
* platform/chromium-mac/media/controls-styling-expected.png:
* platform/chromium-mac/media/controls-styling-expected.txt:
* platform/chromium-mac/media/controls-without-preload-expected.checksum: Removed.
* platform/chromium-mac/media/controls-without-preload-expected.png:
* platform/chromium-mac/media/controls-without-preload-expected.txt:
* platform/chromium-mac/media/media-document-audio-repaint-expected.checksum: Removed.
* platform/chromium-mac/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
* platform/chromium-mac/media/video-controls-rendering-expected.checksum: Removed.
* platform/chromium-mac/media/video-controls-rendering-expected.png:
* platform/chromium-mac/media/video-controls-rendering-expected.txt:
* platform/chromium-mac/media/video-display-toggle-expected.checksum: Removed.
* platform/chromium-mac/media/video-display-toggle-expected.png:
* platform/chromium-mac/media/video-display-toggle-expected.txt:
* platform/chromium-mac/media/video-empty-source-expected.checksum: Removed.
* platform/chromium-mac/media/video-empty-source-expected.png:
* platform/chromium-mac/media/video-empty-source-expected.txt:
* platform/chromium-mac/media/video-no-audio-expected.checksum: Removed.
* platform/chromium-mac/media/video-no-audio-expected.png:
* platform/chromium-mac/media/video-no-audio-expected.txt:
* platform/chromium-mac/media/video-volume-slider-expected.checksum: Removed.
* platform/chromium-mac/media/video-volume-slider-expected.png:
* platform/chromium-mac/media/video-volume-slider-expected.txt:
* platform/chromium-mac/media/video-zoom-controls-expected.png:
* platform/chromium-mac/media/video-zoom-controls-expected.txt:
* platform/chromium-win/fast/layers/video-layer-expected.png:
* platform/chromium-win/fast/layers/video-layer-expected.txt:
* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/audio-controls-rendering-expected.txt:
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.txt:
* platform/chromium-win/media/controls-strict-expected.png:
* platform/chromium-win/media/controls-strict-expected.txt:
* platform/chromium-win/media/controls-styling-expected.png:
* platform/chromium-win/media/controls-styling-expected.txt:
* platform/chromium-win/media/controls-without-preload-expected.png:
* platform/chromium-win/media/controls-without-preload-expected.txt:
* platform/chromium-win/media/media-document-audio-repaint-expected.png:
* platform/chromium-win/media/media-document-audio-repaint-expected.txt:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.txt:
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.txt:
* platform/chromium-win/media/video-empty-source-expected.png:
* platform/chromium-win/media/video-empty-source-expected.txt:
* platform/chromium-win/media/video-no-audio-expected.png:
* platform/chromium-win/media/video-no-audio-expected.txt:
* platform/chromium-win/media/video-volume-slider-expected.png:
* platform/chromium-win/media/video-volume-slider-expected.txt:
* platform/chromium-win/media/video-zoom-controls-expected.png:
* platform/chromium-win/media/video-zoom-controls-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 14 Apr 2011 14:01:22 +0000 (14:01 +0000)]
Add Windows results for new tests added in r83787
Windows differs from the cross-platfom results due to <http://webkit.org/b/57334>.
* platform/win/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
* platform/win/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
* platform/win/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
* platform/win/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Apr 2011 13:59:41 +0000 (13:59 +0000)]
2011-04-14 Andrew Wason <rectalogic@rectalogic.com>
Reviewed by Andreas Kling.
Fix GraphicsContext3DQt.cpp compilation warnings treated as errors
https://bugs.webkit.org/show_bug.cgi?id=58478
No new tests.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::getProcAddress):
Do not use deprecated QString constructor to avoid warning.
(WebCore::GraphicsContext3D::reshape):
Use parenthesis to avoid warning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 14 Apr 2011 13:59:04 +0000 (13:59 +0000)]
Replace some known-to-fail assertions with FIXMEs
These assertions get hit during various layout tests. They indicate that we're sometimes
doing some extra work when a page goes into accelerated compositing mode, but otherwise
there's no bad effect.
See <http://webkit.org/b/58539> for more details.
Rubber-stamped by John Sullivan.
* WebView.cpp:
(WebView::paintIntoBackingStore):
(WebView::paintIntoWindow):
Replaced assertions with FIXMEs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 14 Apr 2011 13:48:37 +0000 (13:48 +0000)]
2011-04-14 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Removed ScrollableArea::paintScrollCorner() added in r83820,
as it breaks chromium clang build (shadowed by RenderLayer::paintScrollCorner()
with a different signature)
* platform/ScrollableArea.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Thu, 14 Apr 2011 13:42:26 +0000 (13:42 +0000)]
2011-04-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Ready to move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=58534
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _countPercent):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.idsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.nodeFieldValuesByIndex):
(WebInspector.HeapSnapshot.prototype._numbersComparator):
(WebInspector.HeapSnapshot.prototype.baseSnapshotHasNode):
(WebInspector.HeapSnapshot.prototype.updateBaseNodeIds):
(WebInspector.HeapSnapshotsDiff):
(WebInspector.HeapSnapshotsDiff.prototype.set baseIds):
(WebInspector.HeapSnapshotsDiff.prototype.set baseSelfSizes):
(WebInspector.HeapSnapshotsDiff.prototype.calculate):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy):
(WebInspector.HeapSnapshotProxy.prototype.createDiff):
(WebInspector.HeapSnapshotProxy.prototype.createEdgesProvider):
(WebInspector.HeapSnapshotProxy.prototype.createNodesProvider):
(WebInspector.HeapSnapshotProxy.prototype.dispose):
(WebInspector.HeapSnapshotProxy.prototype.nodeFieldValuesByIndex):
(WebInspector.HeapSnapshotProxy.prototype.pushBaseIds):
(WebInspector.HeapSnapshotsDiffProxy):
(WebInspector.HeapSnapshotsDiffProxy.prototype.calculate):
(WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseIds):
(WebInspector.HeapSnapshotsDiffProxy.prototype.pushBaseSelfSizes):
2011-04-14 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Ready to move detailed heap snapshots storage and processing into workers.
https://bugs.webkit.org/show_bug.cgi?id=58534
* inspector/profiler/detailed-heapshots-test.js:
(initialize_DetailedHeapshotTest.):
(initialize_DetailedHeapshotTest):
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMock):
(initialize_HeapSnapshotTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 14 Apr 2011 13:35:54 +0000 (13:35 +0000)]
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=57833
* inspector/Inspector.json:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::setFrontend):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::disable):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::executeSQL):
* inspector/InspectorDatabaseAgent.h:
* inspector/front-end/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 14 Apr 2011 13:31:50 +0000 (13:31 +0000)]
2011-04-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Chromium] "Remove Breakpoint" menu item is absent in the DOM breakpoints sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=58530
* inspector/front-end/ElementsPanel.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 14 Apr 2011 13:22:17 +0000 (13:22 +0000)]
2011-04-14 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Dimitri Glazkov.
REGRESSION(r83397) [Qt] When clicking on the media elements they
grow 2 pixels.
https://bugs.webkit.org/show_bug.cgi?id=58477
Since r83397 the media controls elements are actual DOM elements.
Therefore the global style-sheet applies to them. html.css defines
input[type="button"]:active to be border-style: inset which means
that when the buttons are active they grow by their border size.
* css/mediaControls.css:
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
diegohcg@webkit.org [Thu, 14 Apr 2011 13:17:18 +0000 (13:17 +0000)]
2011-04-14 Diego Gonzalez <diegohcg@webkit.org>
[Qt] Improve disable style for input elements in mobile theme
https://bugs.webkit.org/show_bug.cgi?id=58480
Reviewed by Kenneth Rohde Christiansen.
* platform/qt/QtMobileWebStyle.cpp:
(QtMobileWebStyle::drawControl):
(QtMobileWebStyle::drawPrimitive):
(QtMobileWebStyle::drawComplexControl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 14 Apr 2011 12:54:00 +0000 (12:54 +0000)]
2011-04-14 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: restore previous selection in Resources panel upon front-end reopen.
https://bugs.webkit.org/show_bug.cgi?id=58533
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._processCachedResources):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._initDefaultSelection):
(WebInspector.ResourcesPanel.prototype._populateResourceTree):
(WebInspector.ResourcesPanel.prototype._cachedResourcesLoaded):
* inspector/front-end/inspector.css:
(#close-button-left, #close-button-right):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 14 Apr 2011 12:52:49 +0000 (12:52 +0000)]
2011-04-14 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Added chromium baselines for SVG tests added in r83821.
* platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 14 Apr 2011 12:46:52 +0000 (12:46 +0000)]
2011-04-14 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: implement incremental CSS free flow editing.
https://bugs.webkit.org/show_bug.cgi?id=58529
* inspector/styles/get-set-stylesheet-text.html:
2011-04-14 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: implement incremental CSS free flow editing.
https://bugs.webkit.org/show_bug.cgi?id=58529
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleSheet.prototype.setText):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.isResourceRevision):
(WebInspector.Resource.prototype.setContent):
* inspector/front-end/ResourceView.js:
(WebInspector.CSSSourceFrame.prototype.isContentEditable):
(WebInspector.CSSSourceFrame.prototype.editContent):
(WebInspector.CSSSourceFrame.prototype.endEditing.commitIncrementalEdit):
(WebInspector.CSSSourceFrame.prototype.endEditing):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype.editContent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Thu, 14 Apr 2011 12:38:47 +0000 (12:38 +0000)]
2011-04-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1
https://bugs.webkit.org/show_bug.cgi?id=55719
Guard functionality related to complex text and implementations
that rely on MachPort with PLATFORM(MAC).
Based on Oleg Romashin's patch.
* PluginProcess/PluginControllerProxy.cpp:
* PluginProcess/PluginControllerProxy.messages.in:
* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::createWebProcessConnection):
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPlugin):
* Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::decode): Fix bad C++ that
does not compile with gcc-linux.
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.messages.in:
* WebKit2.pro: Move implementation that does not need external
visibility from WebKit2API.pri. Adding the headers as well.
* WebKit2API.pri:
* WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
* WebProcess/WebPage/WebPage.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 14 Apr 2011 12:32:17 +0000 (12:32 +0000)]
2011-04-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector:Duplicated display of storage db when running Web SQL from an iframe.
https://bugs.webkit.org/show_bug.cgi?id=57830
There was created a new InspectorDatabaseResource entry for every didOpenDatabase event.
Moreover there is new WebCore::Database for each didOpenDatabase event.
I decided to change the old instance of the Database to a new one if they both use the same file.
* inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::findByFileName):
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDatabaseResource.h:
(WebCore::InspectorDatabaseResource::setDatabase):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Thu, 14 Apr 2011 12:26:42 +0000 (12:26 +0000)]
Unreviewed.
svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg crashes in Debug build
https://bugs.webkit.org/show_bug.cgi?id=58525
Unskip svgdom-over-01-f.svg, since it is now passing.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Thu, 14 Apr 2011 12:16:30 +0000 (12:16 +0000)]
svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg crashes in Debug build
https://bugs.webkit.org/show_bug.cgi?id=58525
Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2011-04-14
Reviewed by Dirk Schulze.
A renderer is created even for those filter primitives
which parent is not a filter. A rendererIsNeeded() is
added to SVGFilterPrimitiveStandardAttributes.
Test: svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
* svg/SVGFilterPrimitiveStandardAttributes.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 14 Apr 2011 12:12:43 +0000 (12:12 +0000)]
2011-04-14 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
REGRESSION(r83397) [Qt] When the video is loading and the poster is shown
all the controls are not visible except the play button.
https://bugs.webkit.org/show_bug.cgi?id=58484
r83397 introduces a new API hasOwnDisabledStateHandlingFor to handle when
the controls should be disabled. Qt port paints its own controls, we don't want
the default implementation to handle the hidden/disable state for us.
Existing tests covers the visibility of the controls.
* platform/qt/RenderThemeQt.h:
(WebCore::RenderThemeQt::hasOwnDisabledStateHandlingFor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 14 Apr 2011 11:59:33 +0000 (11:59 +0000)]
2011-04-14 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Disabled form controls don't actually look disabled.
https://bugs.webkit.org/show_bug.cgi?id=58490
Unsetting QStyle::State_Enabled is not enough to get the "disabled" appearance
when painting controls. We must also set the QStyleOption's palette's current
color group.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Apr 2011 11:41:11 +0000 (11:41 +0000)]
2011-04-14 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Benjamin Poulain.
Added additional test for parsing codecs parameter.
https://bugs.webkit.org/show_bug.cgi?id=58188
* media/video-can-play-type-expected.txt:
* media/video-can-play-type.html:
2011-04-14 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Benjamin Poulain.
[Qt] MediaPlayerPrivateQt::supportsType does not parse codec parameter
https://bugs.webkit.org/show_bug.cgi?id=58188
The codec parameter in MediaPlayerPrivateQt::supportsType was not parsed into
a QStringList. This change parses and trims the list.
An additional test was added to video-can-play-type.html to test parsing of codec parameter.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::supportsType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Thu, 14 Apr 2011 11:20:36 +0000 (11:20 +0000)]
Optimizing lightning filter to ARM-NEON SIMD instruction set
https://bugs.webkit.org/show_bug.cgi?id=54456
Reviewed by Nikolas Zimmermann.
NEON is the SIMD instruction set for ARM. This instruction set
allows to speed-up the lighting filter by 4 times on ARM
(on WebCore/manual-tests/svg-filter-animation.svg).
* WebCore.pri:
* WebCore.pro:
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::drawLighting):
(WebCore::getPowerCoefficients):
(WebCore::FELighting::drawInteriorPixels):
* platform/graphics/filters/FELighting.h:
* platform/graphics/filters/arm/FELightingNEON.cpp: Added.
(__attribute__):
* platform/graphics/filters/arm/FELightingNEON.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Apr 2011 11:01:12 +0000 (11:01 +0000)]
2011-04-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Benjamin Poulain.
[Qt] GraphicsContext3D internal buffers are not freed
https://bugs.webkit.org/show_bug.cgi?id=57530
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 14 Apr 2011 10:53:04 +0000 (10:53 +0000)]
2011-04-14 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip 2 failing tests.
* platform/gtk/Skipped: Skip
http/tests/loading/onload-vs-immediate-refresh.pl and
svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 14 Apr 2011 10:46:14 +0000 (10:46 +0000)]
REGRESSION (r75555): Safari RSS sidebar jiggles when scrolling
https://bugs.webkit.org/show_bug.cgi?id=52988
Reviewed by Maciej Stachowiak.
Safari RSS relies on synchronous dispatch of ScrollEvent to update the
position of its sidebar during scrolling without producing a jiggling
effect. Due to r75555, this event is no longer dispatched synchronously
which results in stale repaints before the onscroll handler gets a
chance to update the position of the sidebar.
Since it is impractical to resolve this issue in Safari RSS itself, add
a quirk that restores synchronous ScrollEvent dispatch for Safari RSS.
No tests. This is an app-specific change that doesn't affect web
content.
* Android.mk: Add platform/RuntimeApplicationChecks.[cpp|h]
* CMakeLists.txt: Ditto.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/EventQueue.cpp:
(WebCore::shouldDispatchScrollEventSynchronously): Send ScrollEvent
synchronously if the embedding application is Safari and the document's
URL scheme is "feed" or "feeds".
(WebCore::EventQueue::enqueueOrDispatchScrollEvent): Dispatch
ScrollEvent synchronously if shouldDispatchScrollEventSynchronously()
returns true.
* dom/EventQueue.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::sendScrollEvent): Call enqueueOrDispatchScrollEvent().
* platform/RuntimeApplicationChecks.cpp: Added.
(WebCore::mainBundleIsEqualTo): Add a helper routine for CF platforms
that checks if the main bundle's identifier is equal to a given string.
This function returns false for non-CF platforms.
(WebCore::applicationIsSafari): Call mainBundleIsEqualTo().
(WebCore::applicationIsAppleMail): Ditto.
(WebCore::applicationIsMicrosoftMessenger): Ditto.
(WebCore::applicationIsAdobeInstaller): Ditto.
(WebCore::applicationIsAOLInstantMessenger): Ditto.
(WebCore::applicationIsMicrosoftMyDay): Ditto.
(WebCore::applicationIsMicrosoftOutlook): Ditto.
* platform/mac/RuntimeApplicationChecks.mm: Removed. Functions moved to
RuntimeApplicationChecks.cpp.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo): Call enqueueOrDispatchScrollEvent().
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollTo): Call enqueueOrDispatchScrollEvent().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 14 Apr 2011 09:56:25 +0000 (09:56 +0000)]
[Qt] fast/ruby tests fail
https://bugs.webkit.org/show_bug.cgi?id=58523
* platform/qt/Skipped: Add failing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 14 Apr 2011 09:44:48 +0000 (09:44 +0000)]
2011-04-14 James Robinson <jamesr@chromium.org>
Chromium expectation update.
* platform/chromium-gpu-mac/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
* platform/chromium-gpu-mac/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
* platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.checksum: Removed.
* platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.png:
* platform/chromium-gpu/compositing/iframes/become-overlapped-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/iframes/become-overlapped-iframe-expected.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Apr 2011 09:39:01 +0000 (09:39 +0000)]
2011-04-14 Bill Budge <bbudge@chromium.org>
Reviewed by Darin Fisher.
Make WebURLLoaderOptions disallow cross origin requests by default.
https://bugs.webkit.org/show_bug.cgi?id=58475
No new tests. Exposes no new functionality.
* public/WebURLLoaderOptions.h:
(WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Apr 2011 09:27:58 +0000 (09:27 +0000)]
2011-04-14 John Bates <jbates@google.com>
Reviewed by Kenneth Russell.
Fix bug with adding wrong context to LayerRendererChromium and get rid of RefPtr loop.
https://bugs.webkit.org/show_bug.cgi?id=58383
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::addChildContext):
(WebCore::LayerRendererChromium::removeChildContext):
* platform/graphics/chromium/LayerRendererChromium.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 14 Apr 2011 09:27:47 +0000 (09:27 +0000)]
2011-04-14 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r83808.
It seams that the MSVC compiler for WinCE does not handle the friend scope correct.
Add an addtional inline function to StructureTransitionTable to work around this.
* runtime/Structure.h:
(JSC::StructureTransitionTable::keyForWeakGCMapFinalizer):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::keyForFinalizer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 14 Apr 2011 09:18:46 +0000 (09:18 +0000)]
2011-04-14 James Robinson <jamesr@chromium.org>
Few more updates for r83820.
* platform/chromium-gpu/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt.
* platform/chromium-gpu/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Renamed from LayoutTests/platform/chromium-gpu/compositing/layer-creation.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 14 Apr 2011 08:47:31 +0000 (08:47 +0000)]
2011-04-14 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK baselines for new tests.
* platform/gtk/fast/borders/bidi-002-expected.checksum: Added.
* platform/gtk/fast/borders/bidi-002-expected.png: Added.
* platform/gtk/fast/borders/bidi-002-expected.txt: Added.
* platform/gtk/fast/borders/bidi-004-expected.checksum: Added.
* platform/gtk/fast/borders/bidi-004-expected.png: Added.
* platform/gtk/fast/borders/bidi-004-expected.txt: Added.
* platform/gtk/fast/borders/bidi-009a-expected.checksum: Added.
* platform/gtk/fast/borders/bidi-009a-expected.png: Added.
* platform/gtk/fast/borders/bidi-009a-expected.txt: Added.
* platform/gtk/fast/frames/iframe-outline-expected.checksum: Added.
* platform/gtk/fast/frames/iframe-outline-expected.png: Added.
* platform/gtk/fast/frames/iframe-outline-expected.txt: Added.
* platform/gtk/fast/inline/positioned-object-between-replaced-elements-expected.checksum: Added.
* platform/gtk/fast/inline/positioned-object-between-replaced-elements-expected.png: Added.
* platform/gtk/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.checksum: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 14 Apr 2011 08:45:40 +0000 (08:45 +0000)]
2011-04-14 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
[chromium] Failing GPU video tests
https://bugs.webkit.org/show_bug.cgi?id=57926
Rebaseline images.
* platform/chromium-gpu-linux/media/video-display-toggle-expected.checksum: Removed.
* platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
* platform/chromium-gpu-linux/media/video-no-audio-expected.checksum: Removed.
* platform/chromium-gpu-linux/media/video-no-audio-expected.png:
* platform/chromium-gpu-linux/media/video-volume-slider-expected.checksum: Removed.
* platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
* platform/chromium-gpu-mac/media/video-display-toggle-expected.checksum: Removed.
* platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
* platform/chromium-gpu-mac/media/video-no-audio-expected.checksum: Removed.
* platform/chromium-gpu-mac/media/video-no-audio-expected.png:
* platform/chromium-gpu-mac/media/video-volume-slider-expected.checksum: Removed.
* platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
* platform/chromium-gpu-win/media/video-display-toggle-expected.checksum: Removed.
* platform/chromium-gpu-win/media/video-display-toggle-expected.png:
* platform/chromium-gpu-win/media/video-no-audio-expected.checksum: Removed.
* platform/chromium-gpu-win/media/video-no-audio-expected.png:
* platform/chromium-gpu-win/media/video-volume-slider-expected.checksum: Removed.
* platform/chromium-gpu-win/media/video-volume-slider-expected.png:
* platform/chromium/test_expectations.txt:
2011-04-14 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
[chromium] Failing GPU video tests
https://bugs.webkit.org/show_bug.cgi?id=57926
Added/updated GPU directory names for rebaseline tool.
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 14 Apr 2011 08:27:13 +0000 (08:27 +0000)]
2011-04-14 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Kent Tamura.
[chromium] http/tests/loading/preload-append-scan.php fails
https://bugs.webkit.org/show_bug.cgi?id=58352
On chromium, onload-vs-immediate-refresh always caused the subsequent test to fail
with an additional didFinishLoadForFrame message. This was because the test
navigates via a refresh, but did not actually wait for the navigation to complete.
This patch fixes that by adding a waitUntilDone() and calling notifyDone() after the
redirect target page loads. Now the log for this test shows both navigations and no
part of the navigation leaks into the next test.
Also, since dumpAsText() shows alerts, there was no reason to write vs. alert the
SUCCESS message.
* http/tests/loading/onload-vs-immediate-refresh-expected.txt:
* http/tests/loading/onload-vs-immediate-refresh.pl:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 14 Apr 2011 08:20:43 +0000 (08:20 +0000)]
2011-04-14 James Robinson <jamesr@chromium.org>
Update expectations and baselines for r83820.
* compositing/iframes/overlapped-nested-iframes-expected.txt:
* platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.checksum: Removed.
* platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.checksum: Removed.
* platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum: Removed.
* platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-gpu-linux/compositing/iframes/become-overlapped-iframe-expected.txt: Copied from LayoutTests/platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt.
* platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Removed.
* platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
* platform/chromium-gpu-linux/compositing/overflow/scrollbar-painting-expected.checksum: Removed.
* platform/chromium-gpu-linux/compositing/overflow/scrollbar-painting-expected.png:
* platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.checksum: Removed.
* platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.checksum: Removed.
* platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Removed.
* platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Removed.
* platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-gpu-mac/compositing/iframes/become-overlapped-iframe-expected.txt: Copied from LayoutTests/platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt.
* platform/chromium-gpu-mac/compositing/iframes/composited-iframe-alignment-expected.png: Added.
* platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Removed.
* platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
* platform/chromium-gpu-mac/compositing/overflow/scrollbar-painting-expected.checksum: Removed.
* platform/chromium-gpu-mac/compositing/overflow/scrollbar-painting-expected.png:
* platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.checksum: Removed.
* platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum: Removed.
* platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
* platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum: Removed.
* platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum: Removed.
* platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-gpu-win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
* platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Removed.
* platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
* platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.checksum: Removed.
* platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
* platform/chromium-gpu/compositing/iframes/composited-parent-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt.
* platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt.
* platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-expected.txt.
* platform/chromium-gpu/compositing/iframes/connect-compositing-iframe2-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe2-expected.txt.
* platform/chromium-gpu/compositing/iframes/connect-compositing-iframe3-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe3-expected.txt.
* platform/chromium-gpu/compositing/iframes/enter-compositing-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/enter-compositing-iframe-expected.txt.
* platform/chromium-gpu/compositing/iframes/iframe-resize-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/iframe-resize-expected.txt.
* platform/chromium-gpu/compositing/iframes/iframe-size-from-zero-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt.
* platform/chromium-gpu/compositing/iframes/overlapped-iframe-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/iframes/overlapped-iframe-expected.txt.
* platform/chromium-gpu/compositing/layer-creation: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/layer-creation/overflow-scroll-overlap-expected.txt.
* platform/chromium-gpu/compositing/overflow/resize-painting-expected.txt: Renamed from LayoutTests/platform/chromium-gpu-win/compositing/overflow/resize-painting-expected.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Thu, 14 Apr 2011 07:14:57 +0000 (07:14 +0000)]
2011-04-14 Renata Hodovan <reni@webkit.org>
Reviewed by Nikolas Zimmermann.
CSS related SVG*Element changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=56906
Testing inherited CSS related SVG property changes by FEFlood, FESpecularLighting and FEDiffuseLighing filters.
Adding a missing test to check the dynamic update of lighting-color property of FESpecularLighting.
All the other modifications are covered by the existing dyanmic-update tests.
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
* svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html: Added.
* svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Added.
* svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html: Added.
* svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html: Added.
* svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEFloodElement-inherit-flood-color-css-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-lighting-color-css-prop.js: Added.
(executeTest):
2011-04-14 Renata Hodovan <reni@webkit.org>
Reviewed by Nikolas Zimmermann.
CSS related SVG*Element changes doesn't require relayout
https://bugs.webkit.org/show_bug.cgi?id=56906
The changes of some CSS related SVGFilter properties e.g. lighting_color, flood_color, flood_opacity
need only repaint. To avoid the default invalidation of filters in SVGResourceCache::clientStyleChange()
we need an early return. So RenderSVGResourceFilterPrimitive::styleDidChange() can handle these properties
via RenderSVGResourceFilter::primitiveAttributeChanged() the same way like we do it for the other SVGAttributes.
Tests: svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html
svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html
svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html
* platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::setFloodColor):
(WebCore::FEFlood::setFloodOpacity):
* platform/graphics/filters/FEFlood.h:
* platform/graphics/filters/FESpecularLighting.cpp:
(WebCore::FESpecularLighting::setLightingColor):
* platform/graphics/filters/FESpecularLighting.h:
* rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
* rendering/svg/RenderSVGResourceFilterPrimitive.h:
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientStyleChanged):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
* svg/SVGFEFloodElement.cpp:
(WebCore::SVGFEFloodElement::setFilterEffectAttribute):
* svg/SVGFEFloodElement.h:
* svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 14 Apr 2011 06:51:50 +0000 (06:51 +0000)]
2011-04-13 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Allow setting composited backing stores for scrollbars and scroll corners
https://bugs.webkit.org/show_bug.cgi?id=57202
Adds some new tests for composited scrollbars, updates test expectations to take into account scrollbar layers.
* compositing/iframes/become-composited-nested-iframes-expected.txt:
* compositing/iframes/become-overlapped-iframe-expected.txt:
* compositing/iframes/composited-parent-iframe-expected.txt:
* compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
* compositing/iframes/connect-compositing-iframe-expected.txt:
* compositing/iframes/connect-compositing-iframe2-expected.txt:
* compositing/iframes/connect-compositing-iframe3-expected.txt:
* compositing/iframes/enter-compositing-iframe-expected.txt:
* compositing/iframes/iframe-resize-expected.txt:
* compositing/iframes/iframe-size-from-zero-expected.txt:
* compositing/iframes/overlapped-iframe-expected.txt:
* compositing/iframes/repaint-after-losing-scrollbars-expected.checksum: Added.
* compositing/iframes/repaint-after-losing-scrollbars-expected.png: Added.
* compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Added.
* compositing/iframes/repaint-after-losing-scrollbars.html: Added.
* compositing/iframes/resources/repaint-after-losing-scrollbars-iframe.html: Added.
* compositing/iframes/scrolling-iframe-expected.txt:
* compositing/overflow/clip-content-under-overflow-controls-expected.checksum: Added.
* compositing/overflow/clip-content-under-overflow-controls-expected.png: Added.
* compositing/overflow/clip-content-under-overflow-controls-expected.txt: Added.
* compositing/overflow/clip-content-under-overflow-controls.html: Added.
* compositing/overflow/content-gains-scrollbars-expected.txt: Added.
* compositing/overflow/content-gains-scrollbars.html: Added.
* compositing/overflow/content-loses-scrollbars-expected.txt: Added.
* compositing/overflow/content-loses-scrollbars.html: Added.
* compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
* compositing/overflow/overflow-scrollbar-layers.html: Added.
* compositing/overflow/repaint-after-losing-scrollbars-expected.checksum: Added.
* compositing/overflow/repaint-after-losing-scrollbars-expected.png: Added.
* compositing/overflow/repaint-after-losing-scrollbars-expected.txt: Added.
* compositing/overflow/repaint-after-losing-scrollbars.html: Added.
* compositing/tiling/huge-layer-img-expected.png:
* platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.txt: Removed.
* platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.txt: Removed.
* platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.png:
* platform/chromium-gpu-linux/compositing/iframes/composited-iframe-alignment-expected.txt: Removed.
* platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.txt: Removed.
* platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.txt: Removed.
* platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.txt: Removed.
* platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.txt: Removed.
* platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.txt: Removed.
* platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
* platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
* platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt:
* platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
* platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe-expected.txt:
* platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe2-expected.txt:
* platform/chromium-gpu-win/compositing/iframes/connect-compositing-iframe3-expected.txt:
* platform/chromium-gpu-win/compositing/iframes/enter-compositing-iframe-expected.txt:
* platform/chromium-gpu-win/compositing/iframes/iframe-resize-expected.txt:
* platform/chromium-gpu-win/compositing/iframes/iframe-size-from-zero-expected.txt:
* platform/chromium-gpu-win/compositing/iframes/overlapped-iframe-expected.txt:
* platform/chromium-gpu-win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
* platform/chromium-gpu-win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
* platform/chromium-gpu-win/compositing/overflow/resize-painting-expected.txt:
* platform/chromium-gpu/compositing/geometry/foreground-layer-expected.txt: Added.
* platform/chromium-gpu/compositing/iframes/become-composited-nested-iframes-expected.txt: Copied from LayoutTests/compositing/iframes/become-composited-nested-iframes-expected.txt.
* platform/chromium-gpu/compositing/iframes/become-overlapped-iframe-expected.txt: Copied from LayoutTests/compositing/iframes/become-overlapped-iframe-expected.txt.
* platform/chromium-gpu/compositing/iframes/overlapped-nested-iframes-expected.txt: Copied from LayoutTests/compositing/iframes/become-composited-nested-iframes-expected.txt.
* platform/chromium-gpu/compositing/iframes/repaint-after-losing-scrollbars-expected.checksum: Added.
* platform/chromium-gpu/compositing/iframes/repaint-after-losing-scrollbars-expected.png: Added.
* platform/chromium-gpu/compositing/iframes/scrolling-iframe-expected.txt: Added.
* platform/chromium-gpu/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
* platform/chromium-gpu/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
* platform/chromium-gpu/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
* platform/chromium-gpu/compositing/overflow/repaint-after-losing-scrollbars-expected.checksum: Added.
* platform/chromium-gpu/compositing/overflow/repaint-after-losing-scrollbars-expected.png: Copied from LayoutTests/compositing/tiling/huge-layer-img-expected.png.
* platform/chromium/test_expectations.txt:
* platform/mac/Skipped:
2011-04-13 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Allow setting composited backing stores for scrollbars and scroll corners
https://bugs.webkit.org/show_bug.cgi?id=57202
This teaches ScrollableArea to manage GraphicsLayer backings for the two scrollbars and
scroll corner. ScrollableArea can position the layers and route invalidation and paint calls to
the correct place but depends on subclasses to manage the lifetime of the GraphicsLayers and
place them into the correct place in the hierarchy.
FrameView and RenderLayerCompositor updated to provide layers for frames with overflow controls.
that need them. The overflow control layers are siblings of the frame's clip layer.
RenderLayer and RenderLayerBacking updated to provide overflow control layers for layers that
need them. Currently, layers are only created for overflow controls on layers that are already composited
for other reasons and not necessarily for every RenderLayer with overflow. Overflow control layers are siblings
of the RenderLayerBacking's clipping layer if it exists, otherwise they are siblings of the layer's normal
children.
Tested by a number of compositing/ tests that have scrollbars and by these new tests:
compositing/iframes/repaint-after-losing-scrollbars.html
compositing/overflow/clip-content-under-overflow-controls.html
compositing/overflow/content-gains-scrollbars.html
compositing/overflow/content-loses-scrollbars.html
compositing/overflow/overflow-scrollbar-layers.html
compositing/overflow/repaint-after-losing-scrollbars.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
* page/FrameView.cpp:
(WebCore::FrameView::layerForHorizontalScrollbar):
(WebCore::FrameView::layerForVerticalScrollbar):
(WebCore::FrameView::layerForScrollCorner):
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::contentsResized):
(WebCore::FrameView::updateScrollCorner):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::invalidateScrollbar):
(WebCore::ScrollableArea::invalidateScrollCorner):
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::paintScrollCorner):
(WebCore::ScrollableArea::layerForHorizontalScrollbar):
(WebCore::ScrollableArea::layerForVerticalScrollbar):
(WebCore::ScrollableArea::layerForScrollCorner):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::invalidateRect):
* platform/Scrollbar.h:
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::invalidateRootLayerRect):
(WebCore::LayerRendererChromium::drawRootLayer):
(WebCore::LayerRendererChromium::setViewport):
(WebCore::LayerRendererChromium::updateAndDrawLayers):
(WebCore::LayerRendererChromium::updateLayers):
(WebCore::LayerRendererChromium::setRootLayer):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPartAnimation setCurrentProgress:]):
* platform/win/PopupMenuWin.h:
(WebCore::PopupMenuWin::invalidateScrollCornerRect):
(WebCore::PopupMenuWin::isScrollCornerVisible):
(WebCore::PopupMenuWin::scrollCornerRect):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollCornerRect):
(WebCore::RenderLayer::scrollCornerAndResizerRect):
(WebCore::RenderLayer::isScrollCornerVisible):
(WebCore::RenderLayer::invalidateScrollbarRect):
(WebCore::RenderLayer::invalidateScrollCornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::layerForHorizontalScrollbar):
(WebCore::RenderLayer::layerForVerticalScrollbar):
(WebCore::RenderLayer::layerForScrollCorner):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::horizontalScrollbar):
(WebCore::RenderLayer::verticalScrollbar):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::updateAfterWidgetResize):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateInternalHierarchy):
(WebCore::RenderLayerBacking::updateClippingLayers):
(WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresScrollCornerLayer):
(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
(WebCore::paintScrollbar):
(WebCore::RenderLayerBacking::paintContents):
* rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::layerForHorizontalScrollbar):
(WebCore::RenderLayerBacking::layerForVerticalScrollbar):
(WebCore::RenderLayerBacking::layerForScrollCorner):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::frameViewDidChangeLocation):
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::rootPlatformLayer):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::paintScrollbar):
(WebCore::RenderLayerCompositor::paintContents):
(WebCore::shouldCompositeOverflowControls):
(WebCore::RenderLayerCompositor::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerCompositor::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerCompositor::requiresScrollCornerLayer):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
(WebCore::RenderLayerCompositor::destroyRootPlatformLayer):
(WebCore::RenderLayerCompositor::detachRootPlatformLayer):
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::layerForHorizontalScrollbar):
(WebCore::RenderLayerCompositor::layerForVerticalScrollbar):
(WebCore::RenderLayerCompositor::layerForScrollCorner):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::isScrollCornerVisible):
(WebCore::RenderListBox::scrollCornerRect):
(WebCore::RenderListBox::invalidateScrollCornerRect):
2011-04-13 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Allow setting composited backing stores for scrollbars and scroll corners
https://bugs.webkit.org/show_bug.cgi?id=57202
Remove a lot of scrollbar hacks from the chromium compositor implementation now that
scrollbars go to real layers.
* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::invalidateScrollCornerRect):
(WebKit::WebScrollbarImpl::scrollCornerPresent):
* src/WebScrollbarImpl.h:
(WebKit::WebScrollbarImpl::scrollCornerRect):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::reallocateRenderer):
2011-04-13 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Allow setting composited backing stores for scrollbars and scroll corners
https://bugs.webkit.org/show_bug.cgi?id=57202
Update WebScrollBar to reflect ScrollableArea interface changes.
* WebScrollBar.h:
(WebScrollBar::invalidateScrollCornerRect):
(WebScrollBar::scrollCornerPresent):
(WebScrollBar::scrollCornerRect):
2011-04-13 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Allow setting composited backing stores for scrollbars and scroll corners
https://bugs.webkit.org/show_bug.cgi?id=57202
Update WebPopupMenuProxyWin to reflect ScrollableArea interface changes.
* UIProcess/win/WebPopupMenuProxyWin.h:
(WebKit::WebPopupMenuProxyWin::invalidateScrollCornerRect):
(WebKit::WebPopupMenuProxyWin::scrollCornerPresent):
(WebKit::WebPopupMenuProxyWin::scrollCornerRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 14 Apr 2011 06:26:32 +0000 (06:26 +0000)]
2011-04-13 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Added chromium expectations for test added in r83803.
* platform/chromium/iframe-outline-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Apr 2011 06:25:57 +0000 (06:25 +0000)]
2011-04-13 Cary Clark <caryclark@chromium.org>
Reviewed by Eric Seidel.
[Chromium] allow concurrent Skia and CG datatypes
https://bugs.webkit.org/show_bug.cgi?id=57848
The Chromium port is experimenting with running Skia as the WebKit rendering engine, and CoreGraphics
as the UI rendering engine. This permits Chromium to unify its graphics story while leveraging OS X to
draw elements like scrollbars and buttons.
Restructure the common graphics units, points, and rectangles, to convert to Sk-types and CG-types at
the same time. This requires only adding to the existing preprocessor commands, and will have no effect
on any existing platform.
Eventually, WTF_USE_SKIA_ON_MAC_CHROME will be defined to enable this, but for now, there's no
functional change.
No new tests as this provides no new functionality.
* platform/graphics/FloatPoint.h: Add USE(SKIA_ON_MAC_CHROME) to make CG type and operators visible
to a Skia-based Chrome Mac build.
* platform/graphics/FloatRect.h: Ditto.
* platform/graphics/FloatSize.h: Ditto.
* platform/graphics/IntPoint.h: Ditto.
* platform/graphics/IntRect.h: Ditto.
* platform/graphics/IntSize.h: Ditto.
* platform/graphics/cg/FloatPointCG.cpp: Ditto.
* platform/graphics/cg/FloatRectCG.cpp: Ditto.
* platform/graphics/cg/FloatSizeCG.cpp: Ditto.
* platform/graphics/cg/IntPointCG.cpp: Ditto.
* platform/graphics/cg/IntRectCG.cpp: Ditto.
* platform/graphics/cg/IntSizeCG.cpp: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 14 Apr 2011 05:56:21 +0000 (05:56 +0000)]
2011-04-13 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
Perl unit test removeEOL.pl should print test case name on failure
https://bugs.webkit.org/show_bug.cgi?id=58513
* Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
second argument of Test::Simple::ok().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Thu, 14 Apr 2011 05:44:29 +0000 (05:44 +0000)]
2011-04-13 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 58460 - childTypeAllowed() should be const
https://bugs.webkit.org/show_bug.cgi?id=58460
Made childTypeAllowed const.
No new tests. (minor refactoring).
* dom/Attr.cpp:
(WebCore::Attr::childTypeAllowed):
* dom/Attr.h:
* dom/CDATASection.cpp:
(WebCore::CDATASection::childTypeAllowed):
* dom/CDATASection.h:
* dom/Comment.cpp:
(WebCore::Comment::childTypeAllowed):
* dom/Comment.h:
* dom/Document.cpp:
(WebCore::Document::childTypeAllowed):
* dom/Document.h:
* dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::childTypeAllowed):
* dom/DocumentFragment.h:
* dom/Element.cpp:
(WebCore::Element::childTypeAllowed):
* dom/Element.h:
* dom/Node.h:
(WebCore::Node::childTypeAllowed):
* dom/Notation.cpp:
(WebCore::Notation::childTypeAllowed):
* dom/Notation.h:
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::childTypeAllowed):
* dom/ProcessingInstruction.h:
* dom/Text.cpp:
(WebCore::Text::childTypeAllowed):
* dom/Text.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Thu, 14 Apr 2011 05:41:38 +0000 (05:41 +0000)]
Add GTest unit-testing framework to WebKit
https://bugs.webkit.org/show_bug.cgi?id=58507
Patch by Dmitry Lomov <dslomov@google.com> on 2011-04-13
Reviewed by David Levin.
* Source/ThirdParty/gtest/CHANGES: Added.
* Source/ThirdParty/gtest/CMakeLists.txt: Added.
* Source/ThirdParty/gtest/CONTRIBUTORS: Added.
* Source/ThirdParty/gtest/COPYING: Added.
* Source/ThirdParty/gtest/Makefile.am: Added.
* Source/ThirdParty/gtest/README: Added.
* Source/ThirdParty/gtest/README.WebKit: Added.
* Source/ThirdParty/gtest/codegear/gtest.cbproj: Added.
* Source/ThirdParty/gtest/codegear/gtest.groupproj: Added.
* Source/ThirdParty/gtest/codegear/gtest_all.cc: Added.
* Source/ThirdParty/gtest/codegear/gtest_link.cc: Added.
* Source/ThirdParty/gtest/codegear/gtest_main.cbproj: Added.
* Source/ThirdParty/gtest/codegear/gtest_unittest.cbproj: Added.
* Source/ThirdParty/gtest/configure.ac: Added.
* Source/ThirdParty/gtest/include/gtest/gtest-death-test.h: Added.
* Source/ThirdParty/gtest/include/gtest/gtest-message.h: Added.
* Source/ThirdParty/gtest/include/gtest/gtest-param-test.h: Added.
* Source/ThirdParty/gtest/include/gtest/gtest-param-test.h.pump: Added.
* Source/ThirdParty/gtest/include/gtest/gtest-spi.h: Added.
* Source/ThirdParty/gtest/include/gtest/gtest-test-part.h: Added.
* Source/ThirdParty/gtest/include/gtest/gtest-typed-test.h: Added.
* Source/ThirdParty/gtest/include/gtest/gtest.h: Added.
* Source/ThirdParty/gtest/include/gtest/gtest_pred_impl.h: Added.
* Source/ThirdParty/gtest/include/gtest/gtest_prod.h: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-death-test-internal.h: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-filepath.h: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-linked_ptr.h: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h.pump: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util.h: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-string.h: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-tuple.h: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-tuple.h.pump: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-type-util.h: Added.
* Source/ThirdParty/gtest/include/gtest/internal/gtest-type-util.h.pump: Added.
* Source/ThirdParty/gtest/m4/acx_pthread.m4: Added.
* Source/ThirdParty/gtest/m4/gtest.m4: Added.
* Source/ThirdParty/gtest/make/Makefile: Added.
* Source/ThirdParty/gtest/msvc/gtest-md.sln: Added.
* Source/ThirdParty/gtest/msvc/gtest-md.vcproj: Added.
* Source/ThirdParty/gtest/msvc/gtest.sln: Added.
* Source/ThirdParty/gtest/msvc/gtest.vcproj: Added.
* Source/ThirdParty/gtest/msvc/gtest_main-md.vcproj: Added.
* Source/ThirdParty/gtest/msvc/gtest_main.vcproj: Added.
* Source/ThirdParty/gtest/msvc/gtest_prod_test-md.vcproj: Added.
* Source/ThirdParty/gtest/msvc/gtest_prod_test.vcproj: Added.
* Source/ThirdParty/gtest/msvc/gtest_unittest-md.vcproj: Added.
* Source/ThirdParty/gtest/msvc/gtest_unittest.vcproj: Added.
* Source/ThirdParty/gtest/run_tests.py: Added.
* Source/ThirdParty/gtest/samples/prime_tables.h: Added.
* Source/ThirdParty/gtest/samples/sample1.cc: Added.
* Source/ThirdParty/gtest/samples/sample1.h: Added.
* Source/ThirdParty/gtest/samples/sample10_unittest.cc: Added.
* Source/ThirdParty/gtest/samples/sample1_unittest.cc: Added.
* Source/ThirdParty/gtest/samples/sample2.cc: Added.
* Source/ThirdParty/gtest/samples/sample2.h: Added.
* Source/ThirdParty/gtest/samples/sample2_unittest.cc: Added.
* Source/ThirdParty/gtest/samples/sample3-inl.h: Added.
* Source/ThirdParty/gtest/samples/sample3_unittest.cc: Added.
* Source/ThirdParty/gtest/samples/sample4.cc: Added.
* Source/ThirdParty/gtest/samples/sample4.h: Added.
* Source/ThirdParty/gtest/samples/sample4_unittest.cc: Added.
* Source/ThirdParty/gtest/samples/sample5_unittest.cc: Added.
* Source/ThirdParty/gtest/samples/sample6_unittest.cc: Added.
* Source/ThirdParty/gtest/samples/sample7_unittest.cc: Added.
* Source/ThirdParty/gtest/samples/sample8_unittest.cc: Added.
* Source/ThirdParty/gtest/samples/sample9_unittest.cc: Added.
* Source/ThirdParty/gtest/scripts/fuse_gtest_files.py: Added.
* Source/ThirdParty/gtest/scripts/gen_gtest_pred_impl.py: Added.
* Source/ThirdParty/gtest/scripts/gtest-config.in: Added.
* Source/ThirdParty/gtest/scripts/pump.py: Added.
* Source/ThirdParty/gtest/scripts/test/Makefile: Added.
* Source/ThirdParty/gtest/scripts/upload.py: Added.
* Source/ThirdParty/gtest/scripts/upload_gtest.py: Added.
* Source/ThirdParty/gtest/src/gtest-all.cc: Added.
* Source/ThirdParty/gtest/src/gtest-death-test.cc: Added.
* Source/ThirdParty/gtest/src/gtest-filepath.cc: Added.
* Source/ThirdParty/gtest/src/gtest-internal-inl.h: Added.
* Source/ThirdParty/gtest/src/gtest-port.cc: Added.
* Source/ThirdParty/gtest/src/gtest-test-part.cc: Added.
* Source/ThirdParty/gtest/src/gtest-typed-test.cc: Added.
* Source/ThirdParty/gtest/src/gtest.cc: Added.
* Source/ThirdParty/gtest/src/gtest_main.cc: Added.
* Source/ThirdParty/gtest/test/gtest-death-test_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-filepath_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-linked_ptr_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-listener_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-message_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-options_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-param-test2_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-param-test_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-param-test_test.h: Added.
* Source/ThirdParty/gtest/test/gtest-port_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-test-part_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-tuple_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-typed-test2_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-typed-test_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest-typed-test_test.h: Added.
* Source/ThirdParty/gtest/test/gtest-unittest-api_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest_all_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest_break_on_failure_unittest.py: Added.
* Source/ThirdParty/gtest/test/gtest_break_on_failure_unittest_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_color_test.py: Added.
* Source/ThirdParty/gtest/test/gtest_color_test_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_env_var_test.py: Added.
* Source/ThirdParty/gtest/test/gtest_env_var_test_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_environment_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest_filter_unittest.py: Added.
* Source/ThirdParty/gtest/test/gtest_filter_unittest_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_help_test.py: Added.
* Source/ThirdParty/gtest/test/gtest_help_test_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_list_tests_unittest.py: Added.
* Source/ThirdParty/gtest/test/gtest_list_tests_unittest_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_main_unittest.cc: Added.
* Source/ThirdParty/gtest/test/gtest_nc.cc: Added.
* Source/ThirdParty/gtest/test/gtest_nc_test.py: Added.
* Source/ThirdParty/gtest/test/gtest_no_test_unittest.cc: Added.
* Source/ThirdParty/gtest/test/gtest_output_test.py: Added.
* Source/ThirdParty/gtest/test/gtest_output_test_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_output_test_golden_lin.txt: Added.
* Source/ThirdParty/gtest/test/gtest_output_test_golden_win.txt: Added.
* Source/ThirdParty/gtest/test/gtest_pred_impl_unittest.cc: Added.
* Source/ThirdParty/gtest/test/gtest_prod_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest_repeat_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest_shuffle_test.py: Added.
* Source/ThirdParty/gtest/test/gtest_shuffle_test_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_sole_header_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest_stress_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest_test_utils.py: Added.
* Source/ThirdParty/gtest/test/gtest_throw_on_failure_ex_test.cc: Added.
* Source/ThirdParty/gtest/test/gtest_throw_on_failure_test.py: Added.
* Source/ThirdParty/gtest/test/gtest_throw_on_failure_test_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_uninitialized_test.py: Added.
* Source/ThirdParty/gtest/test/gtest_uninitialized_test_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_unittest.cc: Added.
* Source/ThirdParty/gtest/test/gtest_xml_outfile1_test_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_xml_outfile2_test_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_xml_outfiles_test.py: Added.
* Source/ThirdParty/gtest/test/gtest_xml_output_unittest.py: Added.
* Source/ThirdParty/gtest/test/gtest_xml_output_unittest_.cc: Added.
* Source/ThirdParty/gtest/test/gtest_xml_test_utils.py: Added.
* Source/ThirdParty/gtest/test/production.cc: Added.
* Source/ThirdParty/gtest/test/production.h: Added.
* Source/ThirdParty/gtest/test/run_tests_util.py: Added.
* Source/ThirdParty/gtest/test/run_tests_util_test.py: Added.
* Source/ThirdParty/gtest/xcode/Config/DebugProject.xcconfig: Added.
* Source/ThirdParty/gtest/xcode/Config/FrameworkTarget.xcconfig: Added.
* Source/ThirdParty/gtest/xcode/Config/General.xcconfig: Added.
* Source/ThirdParty/gtest/xcode/Config/ReleaseProject.xcconfig: Added.
* Source/ThirdParty/gtest/xcode/Config/StaticLibraryTarget.xcconfig: Added.
* Source/ThirdParty/gtest/xcode/Config/TestTarget.xcconfig: Added.
* Source/ThirdParty/gtest/xcode/Resources/Info.plist: Added.
* Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/Info.plist: Added.
* Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/WidgetFramework.xcodeproj/project.pbxproj: Added.
* Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/runtests.sh: Added.
* Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/widget.cc: Added.
* Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/widget.h: Added.
* Source/ThirdParty/gtest/xcode/Samples/FrameworkSample/widget_test.cc: Added.
* Source/ThirdParty/gtest/xcode/Scripts/runtests.sh: Added.
* Source/ThirdParty/gtest/xcode/Scripts/versiongenerate.py: Added.
* Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Apr 2011 05:40:09 +0000 (05:40 +0000)]
2011-04-13 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION(r81880): Paste menu is disabled for many edit fields (yahoo and google search, yahoo mail msg, forms, etc)
https://bugs.webkit.org/show_bug.cgi?id=58284
<rdar://problem/
9246149>
* WebCore.exp.in: Exporting EditingBehavior.h for use in WebKit2
* editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldClearSelectionWhenLosingWebPageFocus): moving the platform-specific code out of an #ifdef and into this class for run-time instead of compile-time checking
2011-04-13 Jon Lee <jonlee@apple.com>
Reviewed by Maciej Stachowiak.
REGRESSION(r81880): Paste menu is disabled for many edit fields (yahoo and google search, yahoo mail msg, forms, etc)
https://bugs.webkit.org/show_bug.cgi?id=58284
<rdar://problem/
9246149>
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setFocused): Check for whether we are not supposed to be focused AND whether our platform behavior dictates to clear out the selection
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Thu, 14 Apr 2011 05:35:54 +0000 (05:35 +0000)]
2011-04-13 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Eric Seidel.
constructLine should take bidiRuns as a parameter
https://bugs.webkit.org/show_bug.cgi?id=58458
Pass bidiRuns to constructLine and move reachedEndOfTextRenderer so that it is
declared before constructLine.
No new tests as this is refactoring only.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::reachedEndOfTextRenderer):
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::layoutInlineChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 14 Apr 2011 05:35:19 +0000 (05:35 +0000)]
Fixed a bug where WKView changed the cursor when the mouse was moving over other views.
Reviewed by Sam Weinig.
* UIProcess/API/mac/WKView.mm:
(-[WKView mouseMoved:]): If getting this message because this view is the first responder,
ignore it unless it is inside the visible rect.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 14 Apr 2011 05:05:50 +0000 (05:05 +0000)]
2011-04-13 Simon Fraser <simon.fraser@apple.com>
Revert http://trac.webkit.org/changeset/83750 because it broke PrettyPatch.
https://bugs.webkit.org/show_bug.cgi?id=58510
* PrettyPatch/PrettyPatch.rb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 14 Apr 2011 04:01:50 +0000 (04:01 +0000)]
Accidentally made us GC on every allocation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 14 Apr 2011 03:57:40 +0000 (03:57 +0000)]
Fix 32bit tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 14 Apr 2011 03:28:23 +0000 (03:28 +0000)]
2011-04-13 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
GC allocate Structure
https://bugs.webkit.org/show_bug.cgi?id=58483
Additional structures are allocated beyond the expected threshold
so we preflight the test to get them allocated.
* fast/dom/gc-10.html:
2011-04-13 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
GC allocate Structure
https://bugs.webkit.org/show_bug.cgi?id=58483
Turn Structure into a GC allocated object. Most of this patch
is the mechanical change of replacing variations on RefPtr<Structure>
with either Structure* (for arguments and locals), WriteBarrier<Structure>
for the few cases where Structures are held by GC allocated objects
and Strong<Structure> for the root structure objects in GlobalData.
* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::JSCallbackConstructor):
* API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::createStructure):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::createStructure):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::createStructure):
* API/JSCallbackObjectFunctions.h:
(JSC::::JSCallbackObject):
* API/JSContextRef.cpp:
* JavaScriptCore.JSVALUE32_64only.exp:
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.exp:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::markStructures):
(JSC::CodeBlock::markAggregate):
* bytecode/CodeBlock.h:
(JSC::MethodCallLinkInfo::setSeen):
(JSC::GlobalResolveInfo::GlobalResolveInfo):
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::markAggregate):
(JSC::Instruction::Instruction):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::markAggregate):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initPutByIdTransition):
(JSC::StructureStubInfo::initPutByIdReplace):
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::DebuggerActivation):
* debugger/DebuggerActivation.h:
(JSC::DebuggerActivation::createStructure):
* heap/Handle.h:
* heap/MarkStack.cpp:
(JSC::MarkStack::markChildren):
(JSC::MarkStack::drain):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::sweep):
* heap/Strong.h:
(JSC::Strong::Strong):
(JSC::Strong::set):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::tryCachePutByID):
(JSC::Interpreter::uncachePutByID):
(JSC::Interpreter::tryCacheGetByID):
(JSC::Interpreter::uncacheGetByID):
(JSC::Interpreter::privateExecute):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchMethodCallProto):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchMethodCallProto):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::storePtrWithWriteBarrier):
* jsc.cpp:
(cleanupGlobalData):
* runtime/Arguments.h:
(JSC::Arguments::createStructure):
(JSC::Arguments::Arguments):
(JSC::JSActivation::copyRegisters):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
(JSC::constructArrayWithSizeQuirk):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::ArrayPrototype):
(JSC::arrayProtoFuncSplice):
* runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::createStructure):
* runtime/BatchedTransitionOptimizer.h:
(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
* runtime/BooleanConstructor.h:
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
* runtime/BooleanObject.h:
(JSC::BooleanObject::createStructure):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
* runtime/DateConstructor.h:
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance):
* runtime/DateInstance.h:
(JSC::DateInstance::createStructure):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
* runtime/DatePrototype.h:
(JSC::DatePrototype::createStructure):
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
* runtime/ErrorConstructor.h:
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
(JSC::ErrorInstance::create):
* runtime/ErrorInstance.h:
(JSC::ErrorInstance::createStructure):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::ErrorPrototype):
* runtime/ErrorPrototype.h:
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
* runtime/Executable.cpp:
* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::createStructure):
(JSC::NativeExecutable::NativeExecutable):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::createStructure):
* runtime/GetterSetter.h:
(JSC::GetterSetter::GetterSetter):
(JSC::GetterSetter::createStructure):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
* runtime/InternalFunction.h:
(JSC::InternalFunction::createStructure):
* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
(JSC::JSAPIValueWrapper::JSAPIValueWrapper):
* runtime/JSActivation.cpp:
(JSC::JSActivation::JSActivation):
* runtime/JSActivation.h:
(JSC::JSActivation::createStructure):
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
* runtime/JSArray.h:
(JSC::JSArray::createStructure):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::JSByteArray):
(JSC::JSByteArray::createStructure):
* runtime/JSByteArray.h:
(JSC::JSByteArray::JSByteArray):
* runtime/JSCell.cpp:
(JSC::isZombie):
* runtime/JSCell.h:
(JSC::JSCell::JSCell::JSCell):
(JSC::JSCell::JSCell::addressOfStructure):
(JSC::JSCell::JSCell::structure):
(JSC::JSCell::JSCell::markChildren):
(JSC::JSCell::JSValue::isZombie):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
* runtime/JSFunction.h:
(JSC::JSFunction::createStructure):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::clearBuiltinStructures):
(JSC::JSGlobalData::createLeaked):
* runtime/JSGlobalData.h:
(JSC::allocateGlobalHandle):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::markChildren):
(JSC::JSGlobalObject::copyGlobalsFrom):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::createStructure):
(JSC::Structure::prototypeChain):
(JSC::Structure::isValid):
(JSC::constructEmptyArray):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::JSNotAnObject):
(JSC::JSNotAnObject::createStructure):
* runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
* runtime/JSONObject.h:
(JSC::JSONObject::createStructure):
* runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
(JSC::JSObject::seal):
(JSC::JSObject::freeze):
(JSC::JSObject::preventExtensions):
(JSC::JSObject::removeDirect):
(JSC::JSObject::createInheritorID):
* runtime/JSObject.h:
(JSC::JSObject::createStructure):
(JSC::JSObject::JSObject):
(JSC::JSNonFinalObject::createStructure):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSFinalObject::create):
(JSC::JSFinalObject::createStructure):
(JSC::JSFinalObject::JSFinalObject):
(JSC::constructEmptyObject):
(JSC::createEmptyObjectStructure):
(JSC::JSObject::~JSObject):
(JSC::JSObject::setPrototype):
(JSC::JSObject::setStructure):
(JSC::JSObject::inheritorID):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::transitionTo):
(JSC::JSObject::markChildrenDirect):
* runtime/JSObjectWithGlobalObject.cpp:
(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
* runtime/JSObjectWithGlobalObject.h:
(JSC::JSObjectWithGlobalObject::createStructure):
(JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::create):
(JSC::JSPropertyNameIterator::get):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::createStructure):
(JSC::JSPropertyNameIterator::setCachedStructure):
(JSC::Structure::setEnumerationCache):
* runtime/JSStaticScopeObject.h:
(JSC::JSStaticScopeObject::JSStaticScopeObject):
(JSC::JSStaticScopeObject::createStructure):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::createStructure):
* runtime/JSType.h:
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
* runtime/JSValue.h:
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::createStructure):
(JSC::JSVariableObject::JSVariableObject):
(JSC::JSVariableObject::copyRegisterArray):
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::createStructure):
(JSC::JSWrapperObject::JSWrapperObject):
* runtime/JSZombie.cpp:
* runtime/JSZombie.h:
(JSC::JSZombie::JSZombie):
(JSC::JSZombie::createStructure):
* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):
* runtime/MathObject.h:
(JSC::MathObject::createStructure):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
(JSC::NativeErrorConstructor::markChildren):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::createStructure):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
* runtime/NativeErrorPrototype.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::createStructure):
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject):
* runtime/NumberObject.h:
(JSC::NumberObject::createStructure):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
* runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::createStructure):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::ObjectPrototype):
* runtime/ObjectPrototype.h:
* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::PropertyTable):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpMatchesArray::RegExpMatchesArray):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::createStructure):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::RegExpObject):
* runtime/RegExpObject.h:
(JSC::RegExpObject::createStructure):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
* runtime/RegExpPrototype.h:
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::ScopeChainNode):
(JSC::ScopeChainNode::createStructure):
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::StrictEvalActivation):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject):
* runtime/StringObject.h:
(JSC::StringObject::createStructure):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
(JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
(JSC::StringPrototype::createStructure):
* runtime/Structure.cpp:
(JSC::StructureTransitionTable::remove):
(JSC::StructureTransitionTable::add):
(JSC::Structure::Structure):
(JSC::Structure::~Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::getterSetterTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::toCacheableDictionaryTransition):
(JSC::Structure::toUncacheableDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::put):
(JSC::Structure::markChildren):
* runtime/Structure.h:
(JSC::Structure::create):
(JSC::Structure::setPrototypeWithoutTransition):
(JSC::Structure::createStructure):
(JSC::JSCell::createDummyStructure):
(JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::keyForFinalizer):
* runtime/StructureChain.cpp:
(JSC::StructureChain::StructureChain):
(JSC::StructureChain::markChildren):
* runtime/StructureChain.h:
(JSC::StructureChain::create):
(JSC::StructureChain::head):
(JSC::StructureChain::createStructure):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::WeakGCMapFinalizerCallback::finalizerContextFor):
(JSC::StructureTransitionTable::~StructureTransitionTable):
(JSC::StructureTransitionTable::slot):
(JSC::StructureTransitionTable::setMap):
(JSC::StructureTransitionTable::singleTransition):
(JSC::StructureTransitionTable::clearSingleTransition):
(JSC::StructureTransitionTable::setSingleTransition):
* runtime/WeakGCMap.h:
(JSC::DefaultWeakGCMapFinalizerCallback::finalizerContextFor):
(JSC::DefaultWeakGCMapFinalizerCallback::keyForFinalizer):
(JSC::WeakGCMap::contains):
(JSC::WeakGCMap::find):
(JSC::WeakGCMap::remove):
(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):
(JSC::WeakGCMap::finalize):
* runtime/WriteBarrier.h:
(JSC::writeBarrier):
(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
(JSC::WriteBarrierBase::setWithoutWriteBarrier):
2011-04-13 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
GC allocate Structure
https://bugs.webkit.org/show_bug.cgi?id=58483
Fix up JSG to correctly mark Structure, et al.
* JSRun.cpp:
(JSGlueGlobalObject::JSGlueGlobalObject):
* JSRun.h:
* JSUtils.cpp:
(JSObjectKJSValue):
* UserObjectImp.cpp:
(UserObjectImp::UserObjectImp):
* UserObjectImp.h:
(UserObjectImp::createStructure):
2011-04-13 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
GC allocate Structure
https://bugs.webkit.org/show_bug.cgi?id=58483
Update WebCore for Structure being a GC allocated object
* WebCore.exp.in:
* bindings/js/JSAudioConstructor.h:
(WebCore::JSAudioConstructor::createStructure):
* bindings/js/JSDOMBinding.cpp:
(WebCore::cacheDOMStructure):
* bindings/js/JSDOMBinding.h:
(WebCore::DOMObjectWithGlobalPointer::createStructure):
(WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
(WebCore::DOMConstructorObject::createStructure):
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
(WebCore::JSDOMGlobalObject::markChildren):
* bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::createStructure):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
* bindings/js/JSDOMWindowBase.h:
(WebCore::JSDOMWindowBase::createStructure):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::setWindow):
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::createStructure):
* bindings/js/JSDOMWrapper.h:
(WebCore::DOMObject::DOMObject):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
* bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::createStructure):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSOptionConstructor.h:
(WebCore::JSOptionConstructor::createStructure):
* bindings/js/JSWorkerContextBase.cpp:
(WebCore::JSWorkerContextBase::JSWorkerContextBase):
* bindings/js/JSWorkerContextBase.h:
(WebCore::JSWorkerContextBase::createStructure):
* bindings/js/ScriptCachedFrameData.h:
* bindings/js/SerializedScriptValue.h:
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/c/CRuntimeObject.h:
(JSC::Bindings::CRuntimeObject::createStructure):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::createStructure):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaRuntimeMethod::createStructure):
* bridge/jni/jsc/JavaRuntimeObject.h:
(JSC::Bindings::JavaRuntimeObject::createStructure):
* bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::createStructure):
* bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::createStructure):
* bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::createStructure):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::RuntimeArray):
* bridge/runtime_array.h:
(JSC::RuntimeArray::createStructure):
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::RuntimeMethod):
* bridge/runtime_method.h:
(JSC::RuntimeMethod::createStructure):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::RuntimeObject):
* bridge/runtime_object.h:
(JSC::Bindings::RuntimeObject::createStructure):
* history/HistoryItem.h:
2011-04-13 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
GC allocate Structure
https://bugs.webkit.org/show_bug.cgi?id=58483
Update WebKit for the world of GC allocated Structure
* Plugins/Hosted/NetscapePluginInstanceProxy.h:
* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyRuntimeMethod::createStructure):
* Plugins/Hosted/ProxyRuntimeObject.h:
(WebKit::ProxyRuntimeObject::createStructure):
2011-04-13 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
GC allocate Structure
https://bugs.webkit.org/show_bug.cgi?id=58483
Update WK2 for the world of GC allocated Structure
* WebProcess/Plugins/Netscape/JSNPMethod.h:
(WebKit::JSNPMethod::createStructure):
* WebProcess/Plugins/Netscape/JSNPObject.h:
(WebKit::JSNPObject::createStructure):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 14 Apr 2011 02:20:12 +0000 (02:20 +0000)]
2011-04-13 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
gdb-safari should pass arguments to safari.
https://bugs.webkit.org/show_bug.cgi?id=58439
We can do:
gdb-safari --debug LayoutTests/.../foo.html
* Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 14 Apr 2011 02:14:08 +0000 (02:14 +0000)]
2011-04-13 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=52763
r83799 broke test-webkitpy because it assumed we always have
access to a real filesystem (we don't during the unit tests).
Stubbing out the copy for now but we might need a better
solution at some point.
* Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 14 Apr 2011 02:13:31 +0000 (02:13 +0000)]
2011-04-13 Cary Clark <caryclark@google.com>
Reviewed by Eric Seidel.
Allow CG Font support in Chrome Darwin build using Skia
https://bugs.webkit.org/show_bug.cgi?id=58321
This allows Chrome to use Skia to do WebKit rendering, while
using CoreGraphics for glyph creation and computing font metrics.
It relies on an undefined platform token, WTF_USE_SKIA_ON_MAC_CHROME.
No new tests needed, no functionality change.
* loader/cache/CachedFont.cpp: Make CGFontRef functions and
CG-specific font code available to Chrome builds on Darwin using Skia.
* platform/graphics/FontPlatformData.h: Ditto.
(WebCore::FontPlatformData::hash): Ditto.
* platform/graphics/GlyphBuffer.h: Ditto.
(WebCore::GlyphBuffer::advanceAt): Ditto.
(WebCore::GlyphBuffer::add): Ditto.
(WebCore::GlyphBuffer::expandLastAdvance): Ditto.
* platform/graphics/SimpleFontData.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 14 Apr 2011 01:47:26 +0000 (01:47 +0000)]
2011-04-13 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Dimitri Glazkov.
The timeline of the video controls is unusable if the multimedia backend returns a
infinite duration.
https://bugs.webkit.org/show_bug.cgi?id=58452
In case the underlaying media element backend returns crazy values, e.g.
an infinite duration for the video we need to bail out and hide the timeline
rather than in a broken state where you can't use it. The previous code was just
checking if the duration was NaN.
We can't control from JS what the backend will return as a duration for the video
so we can't make an test for it.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::reset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 14 Apr 2011 01:41:34 +0000 (01:41 +0000)]
2011-04-13 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
Tests that iframe outline is drawn.
https://bugs.webkit.org/show_bug.cgi?id=57439
* fast/frames/iframe-outline.html: Added.
* platform/mac/fast/frames/iframe-outline-expected.checksum: Added.
* platform/mac/fast/frames/iframe-outline-expected.png: Added.
* platform/mac/fast/frames/iframe-outline-expected.txt: Added.
2011-04-13 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
Draw outline for render widgets.
https://bugs.webkit.org/show_bug.cgi?id=57439
Test: fast/frames/iframe-outline.html
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 14 Apr 2011 01:39:01 +0000 (01:39 +0000)]
2011-04-13 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change - remove tests that are no longer
failing.
* platform/mac/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 14 Apr 2011 01:37:18 +0000 (01:37 +0000)]
2011-04-13 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests --run-singly option is busted
https://bugs.webkit.org/show_bug.cgi?id=55909
Python's broken lexical scoping strikes again :(.
* Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 14 Apr 2011 01:24:48 +0000 (01:24 +0000)]
2011-04-13 Geoffrey Garen <ggaren@apple.com>
Try to fix ASSERTs seen on Windows bots.
* wtf/HashTable.h:
(WTF::hashTableSwap): Force MSVC to use the right version of swap.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Thu, 14 Apr 2011 01:13:39 +0000 (01:13 +0000)]
2011-04-13 Ojan Vafai <ojan@chromium.org>
Reviewed by Eric Seidel.
generated unexpected_results.html from unexpected_results.json
https://bugs.webkit.org/show_bug.cgi?id=52763
Eventually, we'll merge this with results.html and have a single richer results page.
For now, I just want to get something checked in that we can iterate on.
* Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
* Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Thu, 14 Apr 2011 01:12:39 +0000 (01:12 +0000)]
Unreviewed, rebaseline 4 tests added as r83787.
* platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
* platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
* platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
* platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
* platform/chromium-win/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
* platform/chromium-win/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
* platform/chromium-win/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
* platform/chromium-win/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 14 Apr 2011 01:12:01 +0000 (01:12 +0000)]
2011-04-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Up the failure limit to allow the commit-queue to actually land when the tree is red
https://bugs.webkit.org/show_bug.cgi?id=58499
This change increases the --exit-after-N-failures limit used by the commit-queue
from 1 to 10. This will cause the code added in bug 58494 to actually get
exercised and the queues should start being able to land when the trees are red.
When testing I found that test_runtests_leopard_commit_queue_hack_command was the
only unit test to actually detect this change! Since we don't actually
run on leopard anymore, I removed the hack code and repurposed the test.
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
* Scripts/webkitpy/tool/steps/runtests.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 14 Apr 2011 01:11:46 +0000 (01:11 +0000)]
2011-04-13 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Change the representation of ShadowRoot nodes in render tree dumps
https://bugs.webkit.org/show_bug.cgi?id=58432
Show "#shadow-root" for ShadorRoot nodes instead of "#document-fragment"
in DRT results.
No new tests. This change doesn't affect existing tests yet.
* dom/DocumentFragment.h:
Make nodeName() protected in order that ShdowRoot can override it.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::nodeName): Returns "#shadow-root".
* dom/ShadowRoot.h: Declare nodeName().
* rendering/RenderTreeAsText.cpp:
(WebCore::nodePosition): Don't show "child N " if the node is a shadow boundary.
We don't use isShadowRoot() here because the legacy shadow root nodes
return true for isShadowRoot() and we don't want to update existing
test results.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc