WebKit-https.git
10 years ago2011-05-20 Leo Yang <leo.yang@torchmobile.com.cn>
leo.yang@torchmobile.com.cn [Fri, 20 May 2011 07:56:57 +0000 (07:56 +0000)]
2011-05-20  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        SVGRootInlineBox triggers calculateBoundaries twice in layout
        https://bugs.webkit.org/show_bug.cgi?id=60979

        SVGRootInlineBox was calculating boundaries for children twice
        in computePerCharacterLayoutInformation(). The first time of
        calculation was in layoutChildBoxes() which is called by
        computePerCharacterLayoutInformation(), and the second time of
        calculation was in layoutRootBox() following layoutChildBoxes().

        This patch calculates rectangle of children in layoutChildBoxes()
        and then uses the rectange in layoutRootBox() to reduce a pass
        of calculating child boundaries.

        No functionality change, no new tests.

        * rendering/svg/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
        (WebCore::SVGRootInlineBox::layoutChildBoxes):
        (WebCore::SVGRootInlineBox::layoutRootBox):
        * rendering/svg/SVGRootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Fri, 20 May 2011 06:37:01 +0000 (06:37 +0000)]
2011-05-19  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position.
        https://bugs.webkit.org/show_bug.cgi?id=61163

        Manual test input-number-localization.html.
        Because we can't assume any number formats in various WebKit ports.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValue): The cursor must be the last position of visibleValue(), not m_value.
        * manual-tests/input-number-localization.html: Added manual test to check the cursor correctly moved to the last poisition of the input.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
ukai@chromium.org [Fri, 20 May 2011 06:25:39 +0000 (06:25 +0000)]
Unreviewed.

Chromium expectations update.

* platform/chromium/test_expectations.txt: add BUGWK61169

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 20 May 2011 05:31:07 +0000 (05:31 +0000)]
2011-05-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        WebKit2: Flashing when entering and exiting full screen mode
        https://bugs.webkit.org/show_bug.cgi?id=56957

        Guard against the parameter of setAnimating() matching the ivar value it's
        setting, thus avoiding tearing down the renderer's layer backing.

        * rendering/RenderFullScreen.cpp:
        (RenderFullScreen::setAnimating):
2011-05-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        WebKit2: Flashing when entering and exiting full screen mode
        https://bugs.webkit.org/show_bug.cgi?id=56957

        In the WKFullscreenWindowController, when exiting accelerated compositing mode,
        force a repaint, and don't actually remove the animation layer until the repaint
        completes.  Also, move back to parenting the WebView in a layer-backed view, and
        work around the SnowLeopard bug which causes a crash in those situations.  We no
        longer need to do a bunch of work in finishedEnterFullScreenAnimation, because
        the animation layer is "hiding" all the drawing happening in the webView underneath.

        In the WebFullScreenManagerMac, when asked to tear down the root layer, instead
        remove all its children, and set its contents to a flattened image of the full
        screen element and its children.  This helps patch over the time where everything
        is re-rendering and helps give the appearance of continuousness in the animation.

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
        (-[WKFullScreenWindowController beganExitFullScreenAnimation]):
        (-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]):
        (-[WKFullScreenWindowController exitAcceleratedCompositingMode]):
        (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]):
        (exitCompositedModeRepaintCompleted):
        (-[WKFullScreenWindowController _page]):
        (-[WKFullScreenWindowController _manager]):
        (-[WKFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix ARM build after r86919
loki@webkit.org [Fri, 20 May 2011 05:27:48 +0000 (05:27 +0000)]
Fix ARM build after r86919

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::nop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Dmitry Lomov <dslomov@google.com>
commit-queue@webkit.org [Fri, 20 May 2011 04:10:49 +0000 (04:10 +0000)]
2011-05-19  Dmitry Lomov  <dslomov@google.com>

        Reviewed by Adam Roben.

        Detect hangs in run-api-tests
        https://bugs.webkit.org/show_bug.cgi?id=48043

        * Scripts/run-api-tests: Added test timeouts

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Fri, 20 May 2011 02:39:21 +0000 (02:39 +0000)]
2011-05-19  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Adam Barth.

        Remove Node::deprecatedParserAddChild
        https://bugs.webkit.org/show_bug.cgi?id=60818

        Refactoring only so no new tests.

        This patch fails short of one instance of deprecatedParserAddChild which will
        require a refactoring of <input> shadow DOM to be removed.

        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::pushCurrentNode): Updated to use a ContainerNode.
        (WebCore::XMLDocumentParser::clearCurrentNodeStack): We now need to clear
        up m_leafTextNode too.

        (WebCore::XMLDocumentParser::enterText):
        (WebCore::XMLDocumentParser::exitText):
        Those methods were updated to use m_leafTextNode instead of m_currentNode.

        * dom/XMLDocumentParser.h:
        Changed the currentNode logic to use ContainerNode. Also fixed the style of the
        forward declarations.

        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::startElementNs):
        (WebCore::XMLDocumentParser::endElementNs):
        (WebCore::XMLDocumentParser::characters):
        (WebCore::XMLDocumentParser::processingInstruction):
        (WebCore::XMLDocumentParser::cdataBlock):
        (WebCore::XMLDocumentParser::comment):
        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::parse):
        (WebCore::XMLDocumentParser::parseStartElement):
        (WebCore::XMLDocumentParser::parseEndElement):
        (WebCore::XMLDocumentParser::parseCharacters):
        (WebCore::XMLDocumentParser::parseProcessingInstruction):
        (WebCore::XMLDocumentParser::parseCdata):
        (WebCore::XMLDocumentParser::parseComment):
        Removed the calls to deprecatedParserAddChild, changed the code to use
        m_leafTextNode when it made sense and used ContainerNode instead of
        Node for m_currentNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Mike Lawther <mikelawther@chromium.org>
commit-queue@webkit.org [Fri, 20 May 2011 02:01:05 +0000 (02:01 +0000)]
2011-05-19  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by Simon Fraser.

        implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
        https://bugs.webkit.org/show_bug.cgi?id=56627

        * css3/images/optimize-contrast-canvas-expected.checksum: Added.
        * css3/images/optimize-contrast-canvas-expected.png: Added.
        * css3/images/optimize-contrast-canvas-expected.txt: Added.
        * css3/images/optimize-contrast-canvas.html: Added.
        * css3/images/optimize-contrast-image-expected.checksum: Added.
        * css3/images/optimize-contrast-image-expected.png: Added.
        * css3/images/optimize-contrast-image-expected.txt: Added.
        * css3/images/optimize-contrast-image.html: Added.
2011-05-19  Mike Lawther  <mikelawther@chromium.org>

        Reviewed by Simon Fraser.

        implement image-rendering: optimize-contrast (with a vendor prefix) as defined in CSS3 image values
        https://bugs.webkit.org/show_bug.cgi?id=56627

        Tests: css3/images/optimize-contrast-canvas.html
               css3/images/optimize-contrast-image.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EImageRendering):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/CSSValueKeywords.in:
        * css/SVGCSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
        * css/SVGCSSPropertyNames.in:
        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * css/SVGCSSValueKeywords.in:
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::paint):
        * html/HTMLCanvasElement.h:
        * platform/graphics/ImageRenderingMode.h: Added.
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::ImageQualityController::shouldPaintAtLowQuality):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paintReplaced):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::diff):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::imageRendering):
        (WebCore::InheritedFlags::setImageRendering):
        (WebCore::InheritedFlags::initialImageRendering):
        * rendering/style/RenderStyleConstants.h:
        * rendering/style/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::diff):
        * rendering/style/SVGRenderStyle.h:
        (WebCore::SVGRenderStyle::InheritedFlags::operator==):
        (WebCore::SVGRenderStyle::setBitDefaults):
        * rendering/style/SVGRenderStyleDefs.h:
        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::writeStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 20 May 2011 01:33:46 +0000 (01:33 +0000)]
2011-05-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Randomise code starting location a little
        https://bugs.webkit.org/show_bug.cgi?id=61161

        Add a nop() function to the Assemblers so that we
        can randomise code offsets slightly at no real cost.

        * assembler/ARMAssembler.h:
        (JSC::ARMAssembler::nop):
        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::nop):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::nop):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::nop):
        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::nop):
        * assembler/MacroAssemblerSH4.h:
        (JSC::MacroAssemblerSH4::nop):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::nop):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::nop):
        * jit/JIT.cpp:
        (JSC::JIT::JIT):
        (JSC::JIT::privateCompile):
        * jit/JIT.h:
        * runtime/WeakRandom.h:
        (JSC::WeakRandom::getUint32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 20 May 2011 01:13:36 +0000 (01:13 +0000)]
2011-05-19  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; added new test to gtk Skipped list.
jer.noble@apple.com [Fri, 20 May 2011 01:03:13 +0000 (01:03 +0000)]
Unreviewed; added new test to gtk Skipped list.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix windows build.
oliver@apple.com [Fri, 20 May 2011 00:20:11 +0000 (00:20 +0000)]
Fix windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Dmitry Lomov <dslomov@google.com>
commit-queue@webkit.org [Fri, 20 May 2011 00:12:31 +0000 (00:12 +0000)]
2011-05-19  Dmitry Lomov  <dslomov@google.com>

        Reviewed by Adam Roben.

        run-api-tests should run one test per process
        https://bugs.webkit.org/show_bug.cgi?id=61088

        * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows,
        return code, and parsing GTest output format.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 19 May 2011 23:46:16 +0000 (23:46 +0000)]
2011-05-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Add guard pages to each end of the memory region used by the fixedvm allocator
        https://bugs.webkit.org/show_bug.cgi?id=61150

        Add mechanism to notify the OSAllocator that pages at either end of an
        allocation should be considered guard pages.  Update PageReservation,
        PageAllocation, etc to handle this.

        * JavaScriptCore.exp:
        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
        * wtf/OSAllocator.h:
        * wtf/OSAllocatorPosix.cpp:
        (WTF::OSAllocator::reserveUncommitted):
        (WTF::OSAllocator::reserveAndCommit):
        * wtf/PageAllocation.h:
        (WTF::PageAllocation::PageAllocation):
        * wtf/PageAllocationAligned.h:
        (WTF::PageAllocationAligned::PageAllocationAligned):
        * wtf/PageBlock.h:
        (WTF::PageBlock::PageBlock):
        * wtf/PageReservation.h:
        (WTF::PageReservation::reserve):
        (WTF::PageReservation::reserveWithGuardPages):
            Add a new function to make a reservation that will add guard
            pages to the ends of an allocation.
        (WTF::PageReservation::PageReservation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 19 May 2011 23:43:51 +0000 (23:43 +0000)]
2011-05-18  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Disable blending in compositor for WebGL layers with alpha=false
        https://bugs.webkit.org/show_bug.cgi?id=61091

        * compositing/webgl/webgl-no-alpha.html: Added.
        * platform/chromium-gpu/compositing/webgl/webgl-no-alpha-expected.png: Added.
        * platform/chromium-gpu/compositing/webgl/webgl-no-alpha-expected.txt: Added.
        * platform/mac-wk2/Skipped:
        * platform/mac/compositing/webgl/webgl-no-alpha-expected.png: Added.
        * platform/mac/compositing/webgl/webgl-no-alpha-expected.txt: Added.
2011-05-18  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Disable blending in compositor for WebGL layers with alpha=false
        https://bugs.webkit.org/show_bug.cgi?id=61091

        Test: compositing/webgl/webgl-no-alpha.html

        * platform/graphics/chromium/CanvasLayerChromium.cpp:
        (WebCore::CanvasLayerChromium::CanvasLayerChromium):
        (WebCore::CanvasLayerChromium::pushPropertiesTo):
        * platform/graphics/chromium/CanvasLayerChromium.h:
        * platform/graphics/chromium/WebGLLayerChromium.cpp:
        (WebCore::WebGLLayerChromium::setContext):
        * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
        (WebCore::CCCanvasLayerImpl::CCCanvasLayerImpl):
        (WebCore::CCCanvasLayerImpl::draw):
        * platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
        (WebCore::CCCanvasLayerImpl::setHasAlpha):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Jeremy Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 19 May 2011 23:17:00 +0000 (23:17 +0000)]
2011-05-18  Jeremy Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Poster is not shown in Safari for video element with no playable source elements.
        https://bugs.webkit.org/show_bug.cgi?id=61109

        * media/video-src-invalid-poster-expected.txt: Added.
        * media/video-src-invalid-poster.html: Added.
2011-05-18  Jeremy Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Poster is not shown in Safari for video element with no playable source elements.
        https://bugs.webkit.org/show_bug.cgi?id=61109

        Test: media/video-src-invalid-poster.html

        In the case where no video sources are playable, update the display state and
        renderer, allowing the poster image to display.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::waitForSourceChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Andrew Wilson <atwilson@chromium.org>
atwilson@chromium.org [Thu, 19 May 2011 22:29:24 +0000 (22:29 +0000)]
2011-05-19  Andrew Wilson  <atwilson@chromium.org>

        Reviewed by Darin Adler.

        MessagePortArray cloning code needs to verify source before copying
        https://bugs.webkit.org/show_bug.cgi?id=61130

        * fast/events/message-port-multi-expected.txt:
        * fast/events/resources/message-port-multi.js:
        Added test for "passing an array with an item at a really large index" to postMessage().
2011-05-19  Andrew Wilson  <atwilson@chromium.org>

        Reviewed by Darin Adler.

        MessagePortArray cloning code needs to verify source before copying.
        https://bugs.webkit.org/show_bug.cgi?id=61130

        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::fillMessagePortArray):
        Changed code to not pre-allocate the destination array.
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        (WebCore::getMessagePortArray):
        Changed code to not pre-allocate the destination array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAddress a review comment by Sam Weinig.
andersca@apple.com [Thu, 19 May 2011 22:13:58 +0000 (22:13 +0000)]
Address a review comment by Sam Weinig.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::didUpdateHistoryTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 19 May 2011 22:10:29 +0000 (22:10 +0000)]
2011-05-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Hang UI appears when WebProcess isn't running
        https://bugs.webkit.org/show_bug.cgi?id=61147
        <rdar://problem/9413683>

        This fixes two bugs:

        1. The HistoryClient related message handlers in WebContext could get invoked for pages that have been closed,
           and thus didn't have any subframes. Since we have a MESSAGE_CHECK that checks that the frame exists, we'd
           mark the currently dispatched message as invalid, which would end up calling Connection::Client::didReceiveInvalidMessage.
           Fix this by checking that the page exists first.

        2. In the call to WebProcessProxy::didReceiveInvalidMessage we'd first invalidate the CoreIPC connection to make sure
           that we won't get any further messages from this connection. We'd then go ahead and terminate the web process,
           but because we've already invalidated the CoreIPC connection we would never get the Connection::Client::didClose
           callback that would call WebPageProxy::processDidCrash. Fix this by explicitly calling WebProcessProxy::didClose.
           Also, add logging when we receive an invalid message

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::didNavigateWithNavigationData):
        (WebKit::WebContext::didPerformClientRedirect):
        (WebKit::WebContext::didPerformServerRedirect):
        (WebKit::WebContext::didUpdateHistoryTitle):
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::didReceiveInvalidMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash when detaching Web Inspector when parent is in process of closing.
bweinstein@apple.com [Thu, 19 May 2011 22:06:23 +0000 (22:06 +0000)]
Crash when detaching Web Inspector when parent is in process of closing.
https://bugs.webkit.org/show_bug.cgi?id=61141
<rdar://problem/9470027>

Reviewed by Adam Roben.

We were trying to send a WM_SIZE to a window that was in the process of closing. Switch
to using PostMessage, so the window will finish closing, and then it won't need to
process the WM_SIZE message anymore.

* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformAttach): Call PostMessage instead of SendMessage.
(WebKit::WebInspectorProxy::platformDetach): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
lforschler@apple.com [Thu, 19 May 2011 22:00:23 +0000 (22:00 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 19 May 2011 21:18:23 +0000 (21:18 +0000)]
2011-05-19  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-15 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 19 May 2011 20:39:10 +0000 (20:39 +0000)]
2011-05-15  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt][GTK] plugins/get-url-with-javascript-url.html fails
        https://bugs.webkit.org/show_bug.cgi?id=60834
        Fix unix test plugin for plugins/get-url-with-javascript-url.html

        * platform/qt/Skipped:
2011-05-15  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt][GTK] plugins/get-url-with-javascript-url.html fails
        https://bugs.webkit.org/show_bug.cgi?id=60834
        Fix unix test plugin for plugins/get-url-with-javascript-url.html

        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_new_stream):
        (webkit_test_plugin_write_ready):
        (webkit_test_plugin_write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 19 May 2011 20:36:01 +0000 (20:36 +0000)]
2011-05-19  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 19 May 2011 20:18:39 +0000 (20:18 +0000)]
2011-05-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make Executables release their JIT code as soon as they become dead
        https://bugs.webkit.org/show_bug.cgi?id=61134

        Add an ability to clear an Executable's jit code without requiring
        it to be destroyed, and then call that from a finalizer.

        * heap/Weak.h:
        (JSC::Weak::Weak):
        (JSC::Weak::leak):
        * jit/JITCode.h:
        (JSC::JITCode::clear):
        * runtime/Executable.cpp:
        (JSC::ExecutableFinalizer::finalize):
        (JSC::ExecutableBase::executableFinalizer):
        * runtime/Executable.h:
        (JSC::ExecutableBase::ExecutableBase):
        (JSC::ExecutableBase::clearExecutableCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 19 May 2011 20:18:26 +0000 (20:18 +0000)]
2011-05-19  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium gradient expectations update.

        * platform/chromium-linux-x86/fast/gradients: Added.
        * platform/chromium-linux-x86/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
        * platform/chromium-linux/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
        * platform/chromium-mac-leopard/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
        * platform/chromium-win-vista/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>
dglazkov@chromium.org [Thu, 19 May 2011 20:10:06 +0000 (20:10 +0000)]
2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86869, r86873, r86875, and r86877.
        http://trac.webkit.org/changeset/86869
        http://trac.webkit.org/changeset/86873
        http://trac.webkit.org/changeset/86875
        http://trac.webkit.org/changeset/86877
        https://bugs.webkit.org/show_bug.cgi?id=61139

        broke builds and debug DRT (Requested by rniwa on #webkit).

        * fast/dom/Window/script-tests/window-property-descriptors.js:
        * fast/dom/Window/window-properties.html:
        * fast/dom/script-tests/prototype-inheritance-2.js:
        * fast/dom/script-tests/prototype-inheritance.js:
        * fast/harness/internals-object-expected.txt: Removed.
        * fast/harness/internals-object.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86869, r86873, r86875, and r86877.
        http://trac.webkit.org/changeset/86869
        http://trac.webkit.org/changeset/86873
        http://trac.webkit.org/changeset/86875
        http://trac.webkit.org/changeset/86877
        https://bugs.webkit.org/show_bug.cgi?id=61139

        broke builds and debug DRT (Requested by rniwa on #webkit).

        * DerivedSources.make:
        * WebCore.exp.in:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * testing/Internals.cpp: Removed.
        * testing/Internals.h: Removed.
        * testing/Internals.idl: Removed.
        * testing/js/WebCoreTestSupport.cpp: Removed.
        * testing/js/WebCoreTestSupport.h: Removed.
        * testing/v8/WebCoreTestSupport.cpp: Removed.
        * testing/v8/WebCoreTestSupport.h: Removed.
2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86869, r86873, r86875, and r86877.
        http://trac.webkit.org/changeset/86869
        http://trac.webkit.org/changeset/86873
        http://trac.webkit.org/changeset/86875
        http://trac.webkit.org/changeset/86877
        https://bugs.webkit.org/show_bug.cgi?id=61139

        broke builds and debug DRT (Requested by rniwa on #webkit).

        * WebKit.gyp:
        * public/WebTestingSupport.h: Removed.
        * src/WebTestingSupport.cpp: Removed.
2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r86869, r86873, r86875, and r86877.
        http://trac.webkit.org/changeset/86869
        http://trac.webkit.org/changeset/86873
        http://trac.webkit.org/changeset/86875
        http://trac.webkit.org/changeset/86877
        https://bugs.webkit.org/show_bug.cgi?id=61139

        broke builds and debug DRT (Requested by rniwa on #webkit).

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::bindJSObjectsToWindow):
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 19 May 2011 20:01:06 +0000 (20:01 +0000)]
2011-05-19  Dimitri Glazkov  <dglazkov@chromium.org>

        One more fix after r86869.

        * WebCore.exp.in: Made __ZN7WebCore12JSDOMWrapperD2Ev only export for debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd two more symbols needed by the window.internals library.
andersca@apple.com [Thu, 19 May 2011 19:45:50 +0000 (19:45 +0000)]
Add two more symbols needed by the window.internals library.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 19 May 2011 19:26:56 +0000 (19:26 +0000)]
2011-05-19  Dimitri Glazkov  <dglazkov@chromium.org>

        Fix Leopard build after r86869.

        * WebCore.exp.in: Moved now-always-used exported symbols out of the conditional guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 19 May 2011 19:24:18 +0000 (19:24 +0000)]
2011-05-19  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 19 May 2011 18:59:30 +0000 (18:59 +0000)]
2011-05-19  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix plugins/windowless_plugin_paint_test.html
        https://bugs.webkit.org/show_bug.cgi?id=60992

        * platform/qt/Skipped:
2011-05-19  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix plugins/windowless_plugin_paint_test.html
        https://bugs.webkit.org/show_bug.cgi?id=60992

        Call gdk_init_check before gdk_display_get_default().
        If we don't do this, gdk_display_get_default() will hang
        the next time it's called.

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::getPluginDisplay):
2011-05-19  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix plugins/windowless_plugin_paint_test.html

        Call gdk_init_check before gdk_display_get_default().
        If we don't do this, gdk_display_get_default() will hang
        the next time it's called.

        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
        (WebKit::getPluginDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 19 May 2011 18:54:23 +0000 (18:54 +0000)]
2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        * fast/dom/Window/script-tests/window-property-descriptors.js: Added internals object to list of properties to skip.
        * fast/dom/Window/window-properties.html: Ditto.
        * fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
        * fast/dom/script-tests/prototype-inheritance.js: Ditto.
        * fast/harness/internals-object-expected.txt: Added.
        * fast/harness/internals-object.html: Added.
        * platform/gtk/Skipped: Skipped the newly added test until platform supports window.internals.
        * platform/mac-wk2/Skipped: Ditto.
        * platform/qt/Skipped: Ditto.
        * platform/win/Skipped: Ditto.
2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        Test: fast/harness/internals-object.html

        * DerivedSources.make: Added support for generating from Internals.idl.
        * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
        * WebCore.gypi: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
        * testing/Internals.cpp: Added.
        * testing/Internals.h: Added.
        * testing/Internals.idl: Added.
        * testing/js/WebCoreTestSupport.cpp: Added.
        * testing/js/WebCoreTestSupport.h: Added.
        * testing/v8/WebCoreTestSupport.cpp: Added.
        * testing/v8/WebCoreTestSupport.h: Added.
2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        * WebKit.gyp: Added linking new webkit_test_support library.
        * public/WebTestingSupport.h: Added.
        * src/WebTestingSupport.cpp: Added.
2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add build logistics and plumbing for window.internals object.
        https://bugs.webkit.org/show_bug.cgi?id=60313

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::bindJSObjectsToWindow): Added injection code.
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 19 May 2011 18:40:21 +0000 (18:40 +0000)]
2011-05-19  Dimitri Glazkov  <dglazkov@chromium.org>

        Accept XCode's decisions to keep modifying WebCore.xcodeproj.

        * WebCore.xcodeproj/project.pbxproj: Opened in XCode then closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Andrew Wason <rectalogic@rectalogic.com>
commit-queue@webkit.org [Thu, 19 May 2011 18:39:14 +0000 (18:39 +0000)]
2011-05-19  Andrew Wason  <rectalogic@rectalogic.com>

        Reviewed by Darin Adler.

        Fix GraphicsContext3DQt.cpp compile error
        https://bugs.webkit.org/show_bug.cgi?id=61128

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::GraphicsContext3D):
         clear() m_internal OwnPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Tonis Tiigi <tonistiigi@gmail.com>
commit-queue@webkit.org [Thu, 19 May 2011 18:14:58 +0000 (18:14 +0000)]
2011-05-19  Tonis Tiigi  <tonistiigi@gmail.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Resizing columns in the network panel is weird
        https://bugs.webkit.org/show_bug.cgi?id=55238

        Makes network panel column resizing more usable by adding "first only" and "last only"
        resizing methods to WebInspector.DataGrid. Current behavior is named "nearest" and
        remains default. Network panels datagrid is set to use method "last".

        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid.prototype.get resizeMethod):
        (WebInspector.DataGrid.prototype.set resizeMethod):
        (WebInspector.DataGrid.prototype._resizerDragging):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype._createTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 19 May 2011 17:46:09 +0000 (17:46 +0000)]
2011-05-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        JoinTextNodesCommand is never used
        https://bugs.webkit.org/show_bug.cgi?id=61089

        Deleted JoinTextNodesCommand because it's never used.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * editing/CompositeEditCommand.cpp:
        * editing/CompositeEditCommand.h:
        * editing/EditingAllInOne.cpp:
        * editing/JoinTextNodesCommand.cpp: Removed.
        * editing/JoinTextNodesCommand.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 19 May 2011 17:27:27 +0000 (17:27 +0000)]
2011-05-19  Ryosuke Niwa  <rniwa@webkit.org>

        Make Mac Leopard bot happy after r81176.

        * platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 19 May 2011 17:22:24 +0000 (17:22 +0000)]
2011-05-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION (r83322): Many crashes in Mail.app in WebCore::Node::nodeIndex
        https://bugs.webkit.org/show_bug.cgi?id=61012

        Added a test to ensure WebKit does not crash when inserting a content immediately after
        a styled element inside a Mail blockquote. Regrettably the expected result is incorrect,
        but it matches the behavior of WebKit before r83322.

        * editing/pasteboard/5065605-expected.txt: Reintroduced redundant style spans.
        * editing/pasteboard/paste-text-011-expected.txt: Ditto.
        * platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Ditto.
        * editing/pasteboard/paste-after-inline-style-element-expected.txt: Added.
        * editing/pasteboard/paste-after-inline-style-element.html: Added.
2011-05-19  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION (r83322): Many crashes in Mail.app in WebCore::Node::nodeIndex
        https://bugs.webkit.org/show_bug.cgi?id=61012

        The crash was caused by ReplaceSelectionCommand's inserting content into a middle of the paragraph
        being moved when the insertion position's container node is the node to split to. Fixed the crash
        by not changing the insertion position in such a case.

        Unfortunately, this fix caused markup to bloat in some tests but we'll take this regression since
        it's much better than crashing.

        Test: editing/pasteboard/paste-after-inline-style-element.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Thu, 19 May 2011 17:17:18 +0000 (17:17 +0000)]
2011-05-18  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Anders Carlsson.

        Plug-ins at YouTube, cnn.com, nytimes vanish when their top/left is scrolled out of view when zoomed
        https://bugs.webkit.org/show_bug.cgi?id=61101

        Scale both bounding boxes sent to m_plugin->geometryDidChange(), not just the frameRect. This fools
        the plugin into thinking it is drawing into an unscaled box with an unscaled view even when scaled.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::frame):Made this const so it can be used in clipRectInWindowCoordinates()
        (WebKit::PluginView::viewGeometryDidChange):Used IntRect::scale() rather than scaling by hand
        (WebKit::PluginView::clipRectInWindowCoordinates):Added scale of clipRect.
        * WebProcess/Plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove a redundant and broken data export
aroben@apple.com [Thu, 19 May 2011 17:15:51 +0000 (17:15 +0000)]
Remove a redundant and broken data export

Data can't be exported from JavaScriptCore.dll by listing it in the .def file. The
JS_EXPORTDATA macro must be used instead. (In this case it was already being used, leading
to a linker warning about multiple definitions.)

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSGlobalData::s_info.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Thu, 19 May 2011 16:51:09 +0000 (16:51 +0000)]
2011-05-19  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Anders Carlsson.

        Fix build with ENABLE_PLUGIN_PROCESS=1 for non-mac platforms after r86578
        https://bugs.webkit.org/show_bug.cgi?id=61113

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):
        (WebKit::PluginControllerProxy::tryToShortCircuitEvaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix SUPPORT_AUTOCORRECTION_PANEL build.
beidson@apple.com [Thu, 19 May 2011 16:33:32 +0000 (16:33 +0000)]
Try to fix SUPPORT_AUTOCORRECTION_PANEL build.

* editing/SpellingCorrectionController.cpp:
(WebCore::SpellingCorrectionController::recordSpellcheckerResponseForModifiedCorrection):
(WebCore::SpellingCorrectionController::processMarkersOnTextToBeReplacedByResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Skip failing test after r86841.
ossy@webkit.org [Thu, 19 May 2011 16:28:02 +0000 (16:28 +0000)]
[Qt] Skip failing test after r86841.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix SUPPORT_AUTOCORRECTION_PANEL build.
darin@apple.com [Thu, 19 May 2011 16:22:11 +0000 (16:22 +0000)]
Try to fix SUPPORT_AUTOCORRECTION_PANEL build.

* editing/SpellingCorrectionController.cpp:
(WebCore::markersHaveIdenticalDescription): Call description() function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Skip failing tests after r86834.
ossy@webkit.org [Thu, 19 May 2011 15:12:05 +0000 (15:12 +0000)]
[Qt] Skip failing tests after r86834.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 19 May 2011 13:08:46 +0000 (13:08 +0000)]
2011-05-19  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip 2 failing tests on GTK.

        * platform/gtk/Skipped: Skip http/tests/appcache/interrupted-update.html
        and http/tests/navigation/post-307-response.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Andrey Adaikin <aandrey@google.com>
commit-queue@webkit.org [Thu, 19 May 2011 12:44:39 +0000 (12:44 +0000)]
2011-05-19  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: switch to Scripts panel is too slow
        https://bugs.webkit.org/show_bug.cgi?id=61030

        - It is very expensive to listen to the DOM mutation events, thus we remove the listeners whenever we do any internal
        DOM manipulations (such as expand/collapse line rows) and set the listeners back when we are finished.
        - Also, when we switch to the Scripts panel that have a non-zero scrollTop offset, we would do the rendering work twice.

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.show):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextEditorMainPanel):
        (WebInspector.TextEditorMainPanel.prototype.beginDomUpdates):
        (WebInspector.TextEditorMainPanel.prototype.endDomUpdates):
        (WebInspector.TextEditorMainPanel.prototype._enableDOMNodeRemovedListener):
        (WebInspector.TextEditorMainChunk):
        (WebInspector.TextEditorMainChunk.prototype.set expanded):
        (WebInspector.TextEditorMainChunk.prototype._createRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Implement eventSender.scalePageBy
ossy@webkit.org [Thu, 19 May 2011 12:39:43 +0000 (12:39 +0000)]
[Qt] Implement eventSender.scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=60015

Patch by Zsolt Fehér <h490267@stud.u-szeged.hu> on 2011-05-19
Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::scalePageBy):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::scalePageBy):
* DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

* platform/qt/Skipped: Unskip fast/transforms/selection-bounds-in-transformed-view.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Skip failing tests after r86834.
ossy@webkit.org [Thu, 19 May 2011 12:35:40 +0000 (12:35 +0000)]
[Qt] Skip failing tests after r86834.

* platform/qt-mac/Skipped:
* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 19 May 2011 12:13:16 +0000 (12:13 +0000)]
2011-05-19  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: inspector protocol tests fixed.

        * inspector/InjectedScriptSource.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 David Grogan <dgrogan@chromium.org>
commit-queue@webkit.org [Thu, 19 May 2011 12:03:58 +0000 (12:03 +0000)]
2011-05-19  David Grogan  <dgrogan@chromium.org>

        Reviewed by David Levin.

        Make EventQueue post a Task to the task queue for each asynchronous event
        https://bugs.webkit.org/show_bug.cgi?id=60790

        Currently EventQueue queues up events to be fired asynchronously and
        fires each of them when a single DOMTimer goes off.  In the words of
        dimich, "Having 2 queues will sooner or later cause problems with
        ordering of tasks, termination, suspension and other things that all
        require some control on how queues operate."

        No new tests; this is just a refactoring to avoid potential future
        problems.

        * dom/EventQueue.cpp:
        (WebCore::EventQueue::EventQueue):
        (WebCore::EventQueue::EventDispatcherTask::create):
        (WebCore::EventQueue::EventDispatcherTask::dispatchEvent):
        (WebCore::EventQueue::EventDispatcherTask::performTask):
        (WebCore::EventQueue::EventDispatcherTask::cancel):
        (WebCore::EventQueue::EventDispatcherTask::EventDispatcherTask):
        (WebCore::EventQueue::removeEvent):
        (WebCore::EventQueue::enqueueEvent):
        (WebCore::EventQueue::enqueueOrDispatchScrollEvent):
        (WebCore::EventQueue::cancelEvent):
        (WebCore::EventQueue::cancelQueuedEvents):
        * dom/EventQueue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 19 May 2011 11:47:02 +0000 (11:47 +0000)]
2011-05-18  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        InjectedScriptSource.js - "Don't be eval()."
        https://bugs.webkit.org/show_bug.cgi?id=60800

        * inspector/console/console-eval-blocked-expected.txt: Added.
        * inspector/console/console-eval-blocked.html: Added.
2011-05-18  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        InjectedScriptSource.js - "Don't be eval()."
        https://bugs.webkit.org/show_bug.cgi?id=60800

        Thanks to Adam Barth for providing JSC implementation!

        InjectedScriptHost.evaluate is used to perform script evaluations for
        inspector needs. This method is not affected by CSP and should fix inspector
        on pages with CSP restrictions.

        Test: inspector/console/console-eval-blocked.html

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::evaluate):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::evaluateCallback):
        (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
        * inspector/InjectedScriptHost.idl:
        * inspector/InjectedScriptSource.js:
        (.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 19 May 2011 11:10:45 +0000 (11:10 +0000)]
2011-05-19  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: expose object class name as a part of RemoteObject mirror.
        https://bugs.webkit.org/show_bug.cgi?id=61067

        * inspector/InjectedScriptSource.js:
        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 19 May 2011 11:09:24 +0000 (11:09 +0000)]
2011-05-19  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make "this" a part of callFrame, not scope in the protocol.
        https://bugs.webkit.org/show_bug.cgi?id=61057

        * inspector/InjectedScriptSource.js:
        * inspector/Inspector.json:
        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Thu, 19 May 2011 11:04:13 +0000 (11:04 +0000)]
2011-05-19  Chang Shu  <cshu@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Rebaseline editing/style tests that are working
        https://bugs.webkit.org/show_bug.cgi?id=61075

        Also based on digging of Zsolt Fehér.

        * platform/qt/Skipped:
        * platform/qt/editing/style/5046875-1-expected.png: Added.
        * platform/qt/editing/style/5046875-1-expected.txt:
        * platform/qt/editing/style/5046875-2-expected.png: Added.
        * platform/qt/editing/style/5046875-2-expected.txt:
        * platform/qt/editing/style/5065910-expected.png: Added.
        * platform/qt/editing/style/5065910-expected.txt:
        * platform/qt/editing/style/5084241-expected.png: Added.
        * platform/qt/editing/style/5084241-expected.txt:
        * platform/qt/editing/style/5279521-expected.png: Added.
        * platform/qt/editing/style/5279521-expected.txt:
        * platform/qt/editing/style/block-style-004-expected.png: Added.
        * platform/qt/editing/style/block-style-005-expected.png: Added.
        * platform/qt/editing/style/block-style-006-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-001-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-001-expected.txt:
        * platform/qt/editing/style/create-block-for-style-002-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-002-expected.txt:
        * platform/qt/editing/style/create-block-for-style-003-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-003-expected.txt:
        * platform/qt/editing/style/create-block-for-style-004-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-004-expected.txt:
        * platform/qt/editing/style/create-block-for-style-005-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-005-expected.txt:
        * platform/qt/editing/style/create-block-for-style-006-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-006-expected.txt:
        * platform/qt/editing/style/create-block-for-style-007-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-007-expected.txt:
        * platform/qt/editing/style/create-block-for-style-008-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-008-expected.txt:
        * platform/qt/editing/style/create-block-for-style-009-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-009-expected.txt:
        * platform/qt/editing/style/create-block-for-style-010-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-010-expected.txt:
        * platform/qt/editing/style/create-block-for-style-011-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-011-expected.txt:
        * platform/qt/editing/style/create-block-for-style-012-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-012-expected.txt:
        * platform/qt/editing/style/create-block-for-style-013-expected.png: Added.
        * platform/qt/editing/style/create-block-for-style-013-expected.txt:
        * platform/qt/editing/style/font-family-with-space-expected.png: Added.
        * platform/qt/editing/style/font-family-with-space-expected.txt:
        * platform/qt/editing/style/fontsize-1-expected.png: Added.
        * platform/qt/editing/style/non-inheritable-styles-expected.png: Added.
        * platform/qt/editing/style/non-inheritable-styles-expected.txt:
        * platform/qt/editing/style/relative-font-size-change-001-expected.png: Added.
        * platform/qt/editing/style/relative-font-size-change-001-expected.txt:
        * platform/qt/editing/style/relative-font-size-change-002-expected.png: Added.
        * platform/qt/editing/style/relative-font-size-change-002-expected.txt:
        * platform/qt/editing/style/relative-font-size-change-003-expected.png: Added.
        * platform/qt/editing/style/relative-font-size-change-003-expected.txt:
        * platform/qt/editing/style/relative-font-size-change-004-expected.png: Added.
        * platform/qt/editing/style/relative-font-size-change-004-expected.txt:
        * platform/qt/editing/style/smoosh-styles-001-expected.png: Added.
        * platform/qt/editing/style/smoosh-styles-001-expected.txt:
        * platform/qt/editing/style/smoosh-styles-003-expected.png: Added.
        * platform/qt/editing/style/smoosh-styles-003-expected.txt:
        * platform/qt/editing/style/style-3690704-fix-expected.png: Added.
        * platform/qt/editing/style/style-3998892-fix-expected.png: Added.
        * platform/qt/editing/style/style-3998892-fix-expected.txt:
        * platform/qt/editing/style/style-boundary-001-expected.png: Added.
        * platform/qt/editing/style/style-boundary-001-expected.txt:
        * platform/qt/editing/style/style-boundary-004-expected.png: Added.
        * platform/qt/editing/style/style-boundary-004-expected.txt:
        * platform/qt/editing/style/table-selection-expected.png: Added.
        * platform/qt/editing/style/table-selection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 19 May 2011 10:23:07 +0000 (10:23 +0000)]
2011-05-19  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip failing GTK fullscreen test

        https://bugs.webkit.org/show_bug.cgi?id=61118

        * platform/gtk/Skipped: Skip fullscreen/full-screen-keyboard-enabled.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 19 May 2011 09:50:07 +0000 (09:50 +0000)]
2011-05-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        tooLong validity should not be true for a value set by a script
        https://bugs.webkit.org/show_bug.cgi?id=60948

        Update existing tests for the new behavior.

        * fast/forms/ValidityState-tooLong-input-expected.txt:
        * fast/forms/ValidityState-tooLong-textarea-expected.txt:
        * fast/forms/resources/textarea-live-pseudo-selectors.js:
        * fast/forms/script-tests/ValidityState-tooLong-input.js:
        * fast/forms/script-tests/ValidityState-tooLong-textarea.js:
2011-05-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        tooLong validity should not be true for a value set by a script
        https://bugs.webkit.org/show_bug.cgi?id=60948

        The specification has been updated so that tooLong should be true only
        for user-edit values.

        Introduce m_wasModifiedByUser flag to HTMLInputElement and
        HTMLTextAreaElemnt. It is set to true when a renderer updates the
        value, and is cleared when the value is updated by others.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::HTMLInputElement):
          Initialize m_wasModifiedByUser.
        (WebCore::HTMLInputElement::tooLong):
          Skip the check if m_wasModifiedByUser is false.
        (WebCore::HTMLInputElement::updateType): Clear m_wasModifiedByUser.
        (WebCore::HTMLInputElement::copyNonAttributeProperties):
        (WebCore::HTMLInputElement::setValue): If sendChange is true,
          m_wasModifiedByUser should be true because sendChange is set in a case
          of form auto-fill.  We assume a value set by form auto-fill is a kind
          of user-edit.
        (WebCore::HTMLInputElement::setValueFromRenderer):
          m_wasModifiedByUser should be true for the update by a renderer.
        * html/HTMLInputElement.h: Declare m_wasModifiedByUser.
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
          Initialize m_wasModifiedByUser.
        (WebCore::HTMLTextAreaElement::updateValue):
          m_wasModifiedByUser should be true for the update by a renderer.
        (WebCore::HTMLTextAreaElement::setValueCommon): Clear m_wasModifiedByUser.
        (WebCore::HTMLTextAreaElement::tooLong):
          Skip the check if m_wasModifiedByUser is false.
        * html/HTMLTextAreaElement.h: Declare m_wasModifiedByUser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 19 May 2011 09:47:53 +0000 (09:47 +0000)]
2011-05-19  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html needs new reference image on Leopard.

        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 David Barr <davidbarr@chromium.org>
commit-queue@webkit.org [Thu, 19 May 2011 09:45:53 +0000 (09:45 +0000)]
2011-05-19  David Barr  <davidbarr@chromium.org>

        Reviewed by Simon Fraser.

        CSS3: We fail 'border radius sum of radii' test
        https://bugs.webkit.org/show_bug.cgi?id=38788

        * fast/css/border-radius-non-negative-expected.txt: Added.
        * fast/css/border-radius-non-negative.html: Added.
        * platform/mac/fast/css/border-radius-non-negative-expected.png: Added.
2011-05-19  David Barr  <davidbarr@chromium.org>

        Reviewed by Simon Fraser.

        CSS3: We fail 'border radius sum of radii' test
        https://bugs.webkit.org/show_bug.cgi?id=38788

        Ignore border-radius properties with negative values.

        Test: fast/css/border-radius-non-negative.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseBorderRadius):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Thu, 19 May 2011 09:33:12 +0000 (09:33 +0000)]
2011-05-19  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Use ScriptContext::Task to hold pending events of ThreadableWebSocketChannelClientWrapper
        https://bugs.webkit.org/show_bug.cgi?id=61034

        Refactoring only. No new tests.

        * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
        (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
        (WebCore::ThreadableWebSocketChannelClientWrapper::resume):
        (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
        * websockets/ThreadableWebSocketChannelClientWrapper.h:
        Remove m_pendingConnected, m_pendingMessages and m_pendingClosed, and use ScriptContext::Task
        to hold these pending events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Kenichi Ishibashi <bashi@chromium.org>
commit-queue@webkit.org [Thu, 19 May 2011 09:22:47 +0000 (09:22 +0000)]
2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] IME candidate window appears wrong position in an iframe
        https://bugs.webkit.org/show_bug.cgi?id=61023

        Added a test which ensures the IME candidate position is located
        at suitable position.

        * platform/chromium-mac/editing/input/ime-candidate-window-position-expected.txt: Added.
        * platform/chromium-mac/editing/input/ime-candidate-window-position.html: Added.
        * platform/chromium-mac/editing/resources/ime-candidate-window-position-iframe.html: Added.
2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] IME candidate window appears wrong position in an iframe
        https://bugs.webkit.org/show_bug.cgi?id=61023

        Always adjusts the range to window relative coordinates.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::firstRectForCharacterRange): Removed condition
        which excludes editable selectionRoot from adjusting.
2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] IME candidate window appears wrong position in an iframe
        https://bugs.webkit.org/show_bug.cgi?id=61023

        Call the focused frame's firstRectForCharacterRange() instead of the
        main frame so that DRT behaves as the same as Chromium.

        * DumpRenderTree/chromium/TextInputController.cpp:
        (TextInputController::firstRectForCharacterRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Thu, 19 May 2011 09:21:58 +0000 (09:21 +0000)]
2011-05-19  Emil A Eklund  <eae@chromium.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION (r80808): Multiple <select> - Selection reset to first element from multiple selected ones
        https://bugs.webkit.org/show_bug.cgi?id=60986

        * fast/dom/HTMLSelectElement/change-multiple-preserve-selection-expected.txt:
        * fast/dom/HTMLSelectElement/change-multiple-preserve-selection.html:
2011-05-19  Emil A Eklund  <eae@chromium.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION (r80808): Multiple <select> - Selection reset to first element from multiple selected ones
        https://bugs.webkit.org/show_bug.cgi?id=60986

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setMultiple):
        Don't restore selection if the multiple attribute hasn't changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Mihnea Ovidenie <mihnea@adobe.com>
commit-queue@webkit.org [Thu, 19 May 2011 09:19:07 +0000 (09:19 +0000)]
2011-05-19  Mihnea Ovidenie  <mihnea@adobe.com>

        Reviewed by Simon Fraser.

        Gradients not horizontal using 270deg with odd div width
        https://bugs.webkit.org/show_bug.cgi?id=60157

        When the angle of the linear gradient is 270, the endpoint should
        be computed in the same way as for 0, 90, 180 cases since tan(270)
        is undefined.

        * fast/gradients/css3-linear-right-angle-gradients-expected.txt: Added.
        * fast/gradients/css3-linear-right-angle-gradients.html: Added.
        * platform/mac/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 19 May 2011 08:55:24 +0000 (08:55 +0000)]
2011-05-19  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, follow-up fix of the messages python unittests after r86812.

        [WebKit2] handleMessageDelayed leaks replyEncoder if decoding fails
        https://bugs.webkit.org/show_bug.cgi?id=60872

        * Scripts/webkit2/messages_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 19 May 2011 08:16:58 +0000 (08:16 +0000)]
2011-05-19  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr.html needs new reference image on Snow Leopard.

        * platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-19 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 19 May 2011 07:28:57 +0000 (07:28 +0000)]
2011-05-19  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Update mac pixel test baseline, had marginal differences in the filter results and the text selection rectangles since a while.
        The baseline passes again on my 32bit and 64bit machine, using run-webkit-tests --tolerance 0.011 -p svg

        * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png:
        * platform/mac/svg/batik/filters/feTile-expected.png:
        * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/mac/svg/custom/foreign-object-skew-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
        * platform/mac/svg/filters/feTile-expected.png:
        * platform/mac/svg/filters/filterRes-expected.png:
        * platform/mac/svg/filters/filterRes1-expected.png:
        * platform/mac/svg/filters/filterRes3-expected.png:
        * platform/mac/svg/filters/parent-children-with-same-filter-expected.png:
        * platform/mac/svg/filters/subRegion-one-effect-expected.png:
        * platform/mac/svg/filters/subRegion-two-effects-expected.png:
        * platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.png:
        * platform/mac/svg/text/text-align-01-b-expected.png:
        * platform/mac/svg/text/text-align-02-b-expected.png:
        * platform/mac/svg/text/text-align-04-b-expected.png:
        * platform/mac/svg/text/text-align-05-b-expected.png:
        * platform/mac/svg/text/text-align-06-b-expected.png:
        * platform/mac/svg/text/text-altglyph-01-b-expected.png:
        * platform/mac/svg/text/text-deco-01-b-expected.png:
        * platform/mac/svg/text/text-fonts-01-t-expected.png:
        * platform/mac/svg/text/text-fonts-02-t-expected.png:
        * platform/mac/svg/text/text-intro-05-t-expected.png:
        * platform/mac/svg/text/text-path-01-b-expected.png:
        * platform/mac/svg/text/text-text-01-b-expected.png:
        * platform/mac/svg/text/text-text-03-b-expected.png:
        * platform/mac/svg/text/text-text-04-t-expected.png:
        * platform/mac/svg/text/text-text-05-t-expected.png:
        * platform/mac/svg/text/text-text-06-t-expected.png:
        * platform/mac/svg/text/text-text-07-t-expected.png:
        * platform/mac/svg/text/text-text-08-b-expected.png:
        * platform/mac/svg/text/text-tref-01-b-expected.png:
        * platform/mac/svg/text/text-tselect-01-b-expected.png:
        * platform/mac/svg/text/text-tselect-02-f-expected.png:
        * platform/mac/svg/text/text-tspan-01-b-expected.png:
        * platform/mac/svg/text/text-ws-01-t-expected.png:
        * platform/mac/svg/text/text-ws-02-t-expected.png:
        * platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 19 May 2011 06:40:06 +0000 (06:40 +0000)]
2011-05-18  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html crashed once on Windows XP Debug (Tests)
        https://bugs.webkit.org/show_bug.cgi?id=57048

        * platform/network/cf/SocketStreamHandleCFNet.cpp:
        (WebCore::SocketStreamHandle::platformClose): use loaderRunLoop to schedule streams on platform WIN

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Skip flaky timed out tests on ARM
loki@webkit.org [Thu, 19 May 2011 06:17:25 +0000 (06:17 +0000)]
[Qt] Skip flaky timed out tests on ARM

Rubber-stamped by Csaba Osztrogonác.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAs originally reviewed by Anders Carlsson.
beidson@apple.com [Thu, 19 May 2011 06:16:15 +0000 (06:16 +0000)]
As originally reviewed by Anders Carlsson.

<rdar://problem/9457633> and https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Restore r86797 to how it was supposed to be using the appropriate #ifdef,
reverting the temporary r86814 in the process.

The #ifdef is BUILDING_ON_SNOW_LEOPARD, not BUILDING_ON_SNOWLEOPARD!

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 19 May 2011 06:08:29 +0000 (06:08 +0000)]
2011-05-18  MORITA Hajime  <morrita@google.com>

        Unreviewed attempt to fix clang build.

        * rendering/InlineTextBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 19 May 2011 04:08:25 +0000 (04:08 +0000)]
2011-05-18  Ryosuke Niwa  <rniwa@webkit.org>

        Yet another rebaseline after r81176.

        * platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 19 May 2011 04:02:52 +0000 (04:02 +0000)]
2011-05-18  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        editing/pasteboard/paste-blockquote-into-blockquote-3.html should be a dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=61102

        Converted the test.

        * editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
        * editing/pasteboard/paste-blockquote-into-blockquote-3.html:
        * platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
        * platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.
        * platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Thu, 19 May 2011 03:21:04 +0000 (03:21 +0000)]
2011-05-18  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Add histograms for paint times
        https://bugs.webkit.org/show_bug.cgi?id=61010

        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerPainter::paint):
2011-05-18  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Add histograms for paint times
        https://bugs.webkit.org/show_bug.cgi?id=61010

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::animate):
        (WebKit::WebViewImpl::layout):
        (WebKit::WebViewImpl::paint):
        (WebKit::WebViewImplContentPainter::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 19 May 2011 02:41:30 +0000 (02:41 +0000)]
2011-05-18  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Fix incorrect size when clipping image layer upload rects
        https://bugs.webkit.org/show_bug.cgi?id=61105

        The clipped destination and source rects should have the same size.

        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerTextureUpdater::updateTextureRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the WK2 SnowLeopard layouttests (again) until I can explore on a SnowLeopard...
beidson@apple.com [Thu, 19 May 2011 02:28:48 +0000 (02:28 +0000)]
Fix the WK2 SnowLeopard layouttests (again) until I can explore on a SnowLeopard machine tomorrow.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-17 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 19 May 2011 01:38:03 +0000 (01:38 +0000)]
2011-05-17  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        [Refactoring] Member variables of DocumentMarker should be encapsulated.
        https://bugs.webkit.org/show_bug.cgi?id=56814

        - Moved DocumentMarker's member variables to private and added getters for them.
        - Added DocumentMarker setters and constructors, which contain assertions against m_type values
          because description and activeMatch are used with specific type of MarkerType.
        - Moved chromium's WebKit::WebFrameImpl::addMarker() to DocumentMarkerController::addTextMatchMarker()
          because it accesses DocumentMarker internals.
        - Moved a version of DMC::addMarker() to private and add alternatives that hide
          internals of DocumentMarker. (The internal will be renewed by upcoming change.)

        * dom/DocumentMarker.h:
        (WebCore::DocumentMarker::type):
        (WebCore::DocumentMarker::startOffset):
        (WebCore::DocumentMarker::endOffset):
        (WebCore::DocumentMarker::description):
        (WebCore::DocumentMarker::hasDescription):
        (WebCore::DocumentMarker::activeMatch):
        (WebCore::DocumentMarker::clearDescription):
        (WebCore::DocumentMarker::setStartOffset):
        (WebCore::DocumentMarker::setEndOffset):
        (WebCore::DocumentMarker::operator==):
        (WebCore::DocumentMarker::DocumentMarker):
        (WebCore::DocumentMarker::shiftOffsets):
        (WebCore::DocumentMarker::setActiveMatch):
        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::addMarker):
        (WebCore::DocumentMarkerController::addTextMatchMarker):
        (WebCore::DocumentMarkerController::copyMarkers):
        (WebCore::DocumentMarkerController::removeMarkers):
        (WebCore::DocumentMarkerController::markerContainingPoint):
        (WebCore::DocumentMarkerController::markersInRange):
        (WebCore::DocumentMarkerController::renderedRectsForMarkers):
        (WebCore::DocumentMarkerController::removeMarkersFromList):
        (WebCore::DocumentMarkerController::repaintMarkers):
        (WebCore::DocumentMarkerController::shiftMarkers):
        (WebCore::DocumentMarkerController::setMarkersActive):
        (WebCore::DocumentMarkerController::hasMarkers):
        (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
        (WebCore::DocumentMarkerController::showMarkers):
        * dom/DocumentMarkerController.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
        * editing/Editor.cpp:
        (WebCore::Editor::selectionStartHasMarkerFor):
        * editing/SpellingCorrectionController.cpp:
        (WebCore::SpellingCorrectionController::respondToChangedSelection):
        * editing/SpellingCorrectionController.h:
        (WebCore::SpellingCorrectionController::shouldStartTimerFor):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::spellingToolTip):
        (WebCore::HitTestResult::replacedString):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::computeRectForReplacementMarker):
        (WebCore::InlineTextBox::paintDocumentMarkers):
        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
2011-05-17  MORITA Hajime  <morrita@google.com>

        Reviewed by Tony Chang.

        [Refactoring] Member variables of DocumentMarker should be encapsulated.
        https://bugs.webkit.org/show_bug.cgi?id=56814

        Moved addMarker() implementation to
        WebCore::DocumentMarkerController::addTextMatchMarker().

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::addMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 19 May 2011 01:36:41 +0000 (01:36 +0000)]
2011-05-18  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        [WebKit2] handleMessageDelayed leaks replyEncoder if decoding fails
        https://bugs.webkit.org/show_bug.cgi?id=60872

        Eliminate the concept of SyncReplyMode and instead hand around ownership
        of the reply decoder using an OwnPtr.

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::dispatchSyncMessage): Eliminated comments that say
        the same things the code itself does. Removed code that handles the
        reply mode. Instead, pass the OwnPtr to the message handling function and
        make the call to sendSyncReply conditional on whether the reply encoder
        is still non-null.

        * Platform/CoreIPC/Connection.h: Removed SyncReplyMode. Made
        didReceiveSyncMessage return void, and take OwnPtr<ArgumentEncoder>& for
        the reply encoder.

        * Platform/CoreIPC/HandleMessage.h:
        (CoreIPC::handleMessageDelayed): Take an OwnPtr&. Replaced the call to
        adoptPtr with a call to release.

        * PluginProcess/PluginControllerProxy.h: Updated to take an OwnPtr& and
        not return SyncReplyMode.
        * PluginProcess/WebProcessConnection.cpp:
        (WebKit::WebProcessConnection::didReceiveSyncMessage): Ditto.
        * PluginProcess/WebProcessConnection.h: Ditto.

        * Scripts/webkit2/messages.py: Updated for changes to sync messages.
        Eliminated unneeded return types and use get() when apporopriate to call
        the handleMessage functions.

        * Scripts/webkit2/messages_unittest.py: Tried to update this too.
        I don't know how to run the test, though.

        * Shared/Plugins/NPObjectMessageReceiver.h: Updated to take an OwnPtr& and
        not return SyncReplyMode.
        * Shared/Plugins/NPRemoteObjectMap.cpp:
        (WebKit::NPRemoteObjectMap::didReceiveSyncMessage): Ditto.
        * Shared/Plugins/NPRemoteObjectMap.h: Ditto.
        * UIProcess/Downloads/DownloadProxy.h: Ditto.
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::didReceiveSyncMessage): Ditto.
        * UIProcess/WebContext.h: Ditto.
        * UIProcess/WebFullScreenManagerProxy.cpp:
        (WebKit::WebFullScreenManagerProxy::didReceiveSyncMessage): Ditto.
        * UIProcess/WebFullScreenManagerProxy.h: Ditto.
        * UIProcess/WebIconDatabase.cpp:
        (WebKit::WebIconDatabase::didReceiveSyncMessage): Ditto.
        * UIProcess/WebIconDatabase.h: Ditto.
        * UIProcess/WebInspectorProxy.h: Ditto.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveSyncMessage): Ditto.
        * UIProcess/WebPageProxy.h: Ditto.
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::didReceiveSyncMessage): Ditto.
        * UIProcess/WebProcessProxy.h: Ditto.

        * WebProcess/Plugins/Netscape/JSNPObject.cpp: Added a missing include.

        * WebProcess/Plugins/PluginProcessConnection.cpp:
        (WebKit::PluginProcessConnection::didReceiveSyncMessage): Updated to take
        an OwnPtr& and not return SyncReplyMode.
        * WebProcess/Plugins/PluginProcessConnection.h: Ditto.
        * WebProcess/Plugins/PluginProxy.h: Ditto.
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::didReceiveSyncMessage): Ditto.
        * WebProcess/WebPage/WebPage.h: Ditto.
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::didReceiveSyncMessage): Ditto.
        * WebProcess/WebProcess.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 19 May 2011 01:31:26 +0000 (01:31 +0000)]
2011-05-18  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 19 May 2011 01:15:52 +0000 (01:15 +0000)]
2011-05-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        +[WebScriptObject throwException:] doesn't work when invoked from obj-c field access
        https://bugs.webkit.org/show_bug.cgi?id=61100

        The objc bindings were written to assume exceptions would
        come from obj-c style exceptions, rather than throwException:
        This code simply calls the global ObjcInstance mechanism for
        transferring the reported exception.

        * bridge/objc/objc_instance.h:
        * bridge/objc/objc_runtime.mm:
        (JSC::Bindings::ObjcField::valueFromInstance):
        (JSC::Bindings::ObjcField::setValueToInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 19 May 2011 00:45:27 +0000 (00:45 +0000)]
2011-05-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Some tests crashing in JSC::MarkStack::validateValue beneath ScriptController::clearWindowShell on SnowLeopard Intel Release (WebKit2 Tests)
        https://bugs.webkit.org/show_bug.cgi?id=61064

        Switch NonFinalObject to using WriteBarrier<> rather than WriteBarrierBase<>
        for its inline storage.  This resolves the problem of GC occurring before
        a subclass has initialised its anonymous storage.

        * runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-16 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 19 May 2011 00:38:20 +0000 (00:38 +0000)]
2011-05-16  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Robustly handle mapTexSubImage2D returning NULL
        https://bugs.webkit.org/show_bug.cgi?id=60934

        Also, lazily create the temp buffer so that both the map and non-map
        cases can use it.

        * platform/graphics/chromium/LayerTextureSubImage.cpp:
        (WebCore::LayerTextureSubImage::setSubImageSize):
        (WebCore::LayerTextureSubImage::uploadWithTexSubImage):
        (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Thu, 19 May 2011 00:16:40 +0000 (00:16 +0000)]
2011-05-18  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        Change RenderTextControl::hitInnerTextElement to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=61003

        Covered by existing tests.

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::hitInnerTextElement):
        * rendering/RenderTextControl.h:
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWK2: VoiceOver cannot move focus into a web area programmatically
cfleizach@apple.com [Thu, 19 May 2011 00:10:38 +0000 (00:10 +0000)]
WK2: VoiceOver cannot move focus into a web area programmatically
https://bugs.webkit.org/show_bug.cgi?id=60661

Reviewed by Maciej Stachowiak.

Source/WebCore:

Accessibility code relies on the ability to bring focus to the containing widget view.
In WK2, that message needs to be propagated to the UI process.

* page/ChromeClient.h:
(WebCore::ChromeClient::makeFirstResponder):
* page/mac/ChromeMac.mm:
(WebCore::Chrome::focusNSView):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::setFocus):

Source/WebKit2:

Add a makeFirstResponder method that will bring focus to the widget view within the UI
process.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::makeFirstResponder):
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::makeFirstResponder):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::makeFirstResponder):
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Alok Priyadarshi <alokp@chromium.org> and Adrienne Walker <enne@google...
enne@google.com [Wed, 18 May 2011 23:53:12 +0000 (23:53 +0000)]
2011-05-18  Alok Priyadarshi  <alokp@chromium.org> and Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Split canvas from LayerTilerChromium
        https://bugs.webkit.org/show_bug.cgi?id=60719

        LayerTilerChromium now just does tiling. It delegates the task of painting and updating textures to LayerTextureUpdater.
        Also abstracted LayerTextureSubImage to upload texture pixels.

        * WebCore.gypi:
        * platform/chromium/TraceEvent.h:
        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::create):
        (WebCore::ContentLayerChromium::ContentLayerChromium):
        (WebCore::ContentLayerChromium::~ContentLayerChromium):
        (WebCore::ContentLayerChromium::paintContentsIfDirty):
        (WebCore::ContentLayerChromium::cleanupResources):
        (WebCore::ContentLayerChromium::setLayerRenderer):
        (WebCore::ContentLayerChromium::createTextureUpdater):
        (WebCore::ContentLayerChromium::drawsContent):
        (WebCore::ContentLayerChromium::createTilerIfNeeded):
        (WebCore::ContentLayerChromium::updateCompositorResources):
        * platform/graphics/chromium/ContentLayerChromium.h:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
        (WebCore::ImageLayerTextureUpdater::~ImageLayerTextureUpdater):
        (WebCore::ImageLayerTextureUpdater::orientation):
        (WebCore::ImageLayerTextureUpdater::prepareToUpdate):
        (WebCore::ImageLayerTextureUpdater::updateTextureRect):
        (WebCore::ImageLayerTextureUpdater::imageRect):
        (WebCore::ImageLayerChromium::paintContentsIfDirty):
        (WebCore::ImageLayerChromium::updateCompositorResources):
        (WebCore::ImageLayerChromium::createTextureUpdater):
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerPainterChromium.h: Added.
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::updateRootLayerContents):
        (WebCore::LayerRendererChromium::drawRootLayer):
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        (WebCore::LayerRendererChromium::updateLayers):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/LayerTextureSubImage.cpp: Added.
        (WebCore::LayerTextureSubImage::LayerTextureSubImage):
        (WebCore::LayerTextureSubImage::~LayerTextureSubImage):
        (WebCore::LayerTextureSubImage::setSubImageSize):
        (WebCore::LayerTextureSubImage::upload):
        (WebCore::LayerTextureSubImage::uploadWithTexSubImage):
        (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
        * platform/graphics/chromium/LayerTextureSubImage.h: Copied from Source/WebCore/platform/chromium/TraceEvent.h.
        * platform/graphics/chromium/LayerTextureUpdater.h: Copied from Source/WebCore/platform/chromium/TraceEvent.h.
        (WebCore::LayerTextureUpdater::LayerTextureUpdater):
        (WebCore::LayerTextureUpdater::~LayerTextureUpdater):
        (WebCore::LayerTextureUpdater::context):
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: Added.
        (WebCore::LayerTextureUpdaterCanvas::LayerTextureUpdaterCanvas):
        (WebCore::LayerTextureUpdaterCanvas::paintContents):
        (WebCore::LayerTextureUpdaterBitmap::LayerTextureUpdaterBitmap):
        (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
        (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.h: Added.
        (WebCore::LayerTextureUpdaterCanvas::~LayerTextureUpdaterCanvas):
        (WebCore::LayerTextureUpdaterCanvas::contentRect):
        (WebCore::LayerTextureUpdaterBitmap::~LayerTextureUpdaterBitmap):
        (WebCore::LayerTextureUpdaterBitmap::orientation):
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::create):
        (WebCore::LayerTilerChromium::LayerTilerChromium):
        (WebCore::LayerTilerChromium::setTileSize):
        (WebCore::LayerTilerChromium::prepareToUpdate):
        (WebCore::LayerTilerChromium::updateRect):
        (WebCore::LayerTilerChromium::draw):
        * platform/graphics/chromium/LayerTilerChromium.h:
        (WebCore::LayerTilerChromium::Tile::Tile):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::draw):
2011-05-18  Alok Priyadarshi  <alokp@chromium.org> and Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        Split canvas from LayerTilerChromium
        https://bugs.webkit.org/show_bug.cgi?id=60719

        * src/WebViewImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Wed, 18 May 2011 23:43:23 +0000 (23:43 +0000)]
2011-05-18  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB put() should fail adding to object store that uses
        out-of-line keys and has no key generator and the key parameter
        was not provided
        https://bugs.webkit.org/show_bug.cgi?id=58609

        One new test and one fix to an existing test that relied on the old
        broken behavior.

        * storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt: Added.
        * storage/indexeddb/mozilla/key-requirements-put-no-key.html: Added.
        * storage/indexeddb/objectstore-autoincrement-expected.txt:
        * storage/indexeddb/objectstore-autoincrement.html:
2011-05-18  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB put() should fail adding to object store that uses
        out-of-line keys and has no key generator and the key parameter
        was not provided
        https://bugs.webkit.org/show_bug.cgi?id=58609

        Out-of-line keys means that objectStore->m_keyPath is null in ::put(),
        no key generator means that objectStore->autoIncrement() is false, and
        key parameter was not provided means that prpKey will be a null pointer.
        The combination of these 3 should throw a DATA_ERR.

        Test: storage/indexeddb/mozilla/key-requirements-put-no-key.html

        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::put):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Wed, 18 May 2011 23:34:52 +0000 (23:34 +0000)]
2011-05-18  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Oliver Hunt.

        [Qt] fast/encoding/yentest.html and yentest2.html fail
        https://bugs.webkit.org/show_bug.cgi?id=39852

        * platform/qt/Skipped: Unskip passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 18 May 2011 23:28:54 +0000 (23:28 +0000)]
2011-05-18  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium test expectations update for details element (Windows).
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 18 May 2011 23:14:25 +0000 (23:14 +0000)]
2011-05-18  Chris Rogers  <crogers@google.com>

        Reviewed by James Robinson.

        EqualPowerPanner is not using the correct azimuth range for stereo panning
        https://bugs.webkit.org/show_bug.cgi?id=61085

        No new tests since audio API is not yet implemented.

        * platform/audio/EqualPowerPanner.cpp:
        (WebCore::EqualPowerPanner::pan):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 18 May 2011 23:14:24 +0000 (23:14 +0000)]
2011-05-18  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Chromium expectations update for SVG tests.

        * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/filters: Added.
        * platform/chromium-linux-x86/svg/filters/feBlend-invalid-mode-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
        * platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
        * platform/chromium-linux/svg/filters/feBlend-invalid-mode-expected.txt: Added.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
        * platform/chromium-mac/svg/filters/feBlend-invalid-mode-expected.txt: Added.
        * platform/chromium-win-vista/svg/W3C-SVG-1.1-SE: Added.
        * platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
        * platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
        * platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
        * platform/chromium-win-vista/svg/dynamic-updates: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/filters: Added.
        * platform/chromium-win-vista/svg/filters/feBlend-invalid-mode-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Brett Wilson <brettw@chromium.org>
brettw@chromium.org [Wed, 18 May 2011 22:17:13 +0000 (22:17 +0000)]
2011-05-18  Brett Wilson  <brettw@chromium.org>

        Reviewed by Adam Barth.

        Don't create empty file objects if no download file path is specified.
        https://bugs.webkit.org/show_bug.cgi?id=60798

        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponse::setDownloadFilePath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Wed, 18 May 2011 22:10:55 +0000 (22:10 +0000)]
2011-05-18  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
        https://bugs.webkit.org/show_bug.cgi?id=33179

        Unskip the fast/events/onsearch-enter.html test.

        * platform/qt/Skipped:
2011-05-18  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
        https://bugs.webkit.org/show_bug.cgi?id=33179

        Fill the missing key text for the EnterKey event.

        Tests: fast/events/onsearch-enter.html

        * platform/qt/PlatformKeyboardEventQt.cpp:
        (WebCore::keyTextForKeyEvent):
2011-05-18  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
        https://bugs.webkit.org/show_bug.cgi?id=33179

        Remove the implementation of the handleInputMethodKeydown, which introduces
        a regression(r82243) on Linux. Also, add more Api tests for the EnterKey event.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleInputMethodKeydown): Remove implementation.
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods): Add more tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9457633> and https://bugs.webkit.org/show_bug.cgi?id=61009
beidson@apple.com [Wed, 18 May 2011 22:04:57 +0000 (22:04 +0000)]
<rdar://problem/9457633> and https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Reviewed by Anders Carlsson.

* Platform/unix/EnvironmentUtilities.cpp: Remove an unnecessary #include, as reviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
lforschler@apple.com [Wed, 18 May 2011 21:58:49 +0000 (21:58 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate the the context menu to reflect the system search provider on Mac.
timothy@apple.com [Wed, 18 May 2011 21:47:33 +0000 (21:47 +0000)]
Update the the context menu to reflect the system search provider on Mac.

<rdar://problem/9198419>

Reviewed by Sam Weinig.

Source/WebCore:

* English.lproj/Localizable.strings: Updated.
* Source/WebCore/WebCore.exp.in: Added _wkCopyDefaultSearchProviderDisplayName.
* platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::contextMenuItemTagSearchWeb): Use wkCopyDefaultSearchProviderDisplayName to
create the string.
* platform/mac/WebCoreSystemInterface.h: Added wkCopyDefaultSearchProviderDisplayName.
* platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

* DefaultDelegates/WebDefaultContextMenuDelegate.mm:
(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): Use wkCopyDefaultSearchProviderDisplayName to
create the web search context menu title.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.

Source/WebKit2:

* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle): Add a FIXME about using NSPerformService on Mac.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added CopyDefaultSearchProviderDisplayName.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9457633> and https://bugs.webkit.org/show_bug.cgi?id=61009
beidson@apple.com [Wed, 18 May 2011 21:46:33 +0000 (21:46 +0000)]
<rdar://problem/9457633> and https://bugs.webkit.org/show_bug.cgi?id=61009
Processes spawned by SnowLeopard's WebProcess attempt to install WebKit2 shims.

Reviewed by Anders Carlsson.

If the WebProcess or PluginProcess forks, it shouldn't pass WebKit2 shims along to the new process
in the DYLD_INSERT_LIBRARIES environment variable.

Add Environment Utilities helper to strip unwanted values from an environment variable:
* Platform/unix/EnvironmentUtilities.cpp: Added.
(WebKit::EnvironmentUtilities::stripValuesEndingWithString):
* Platform/unix/EnvironmentUtilities.h: Added.
* WebKit2.xcodeproj/project.pbxproj:

Strip PluginProcessShim.dylib from DYLD_INSERT_LIBRARIES:
* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):

Strip WebProcessShim.dylib from DYLD_INSERT_LIBRARIES:
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

Unprotect SnowLeopard now that it will behave and not spawn processes trying to use WebKit2 shims:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Wed, 18 May 2011 21:40:16 +0000 (21:40 +0000)]
2011-05-18  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        Marker test from ietestcenter fails
        https://bugs.webkit.org/show_bug.cgi?id=60721

        Change <marker> renderer creation behaviour to always create the renderer. This fixes
        the problem that no marker is rendered when display=none is set on the <marker>. The
        specification states that display=none should have no influence on <marker> usage:
        "The ‘display’ property does not apply to the ‘marker’ element; thus, ..., and ‘marker’
        elements are available for referencing even when the ‘display’ property on the ‘marker’
        element or any of its ancestors is set to none."

        Tests: svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg
               svg/custom/painting-marker-07-f-inherit.svg

        * svg/SVGMarkerElement.h:
        (WebCore::SVGMarkerElement::rendererIsNeeded):
2011-05-18  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        Marker test from ietestcenter fails
        https://bugs.webkit.org/show_bug.cgi?id=60721

        Test cases where display=none is set on <marker>, i.e. directly or through ancestor.

        * platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
        * platform/mac/svg/custom/painting-marker-07-f-inherit-expected.png: Added.
        * platform/mac/svg/custom/painting-marker-07-f-inherit-expected.txt: Added.
        * svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg: Added.
        * svg/custom/painting-marker-07-f-inherit.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Alexis Menard <alexis.menard@openbossa.org>, Simon Hausmann <simon...
commit-queue@webkit.org [Wed, 18 May 2011 21:26:03 +0000 (21:26 +0000)]
2011-05-18  Alexis Menard  <alexis.menard@openbossa.org>, Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Eric Carlson.

        MediaElements fails to load the data in some cases.
        https://bugs.webkit.org/show_bug.cgi?id=60760

        This test creates an hidden video element and make sure the loading works.

        * http/tests/media/media-can-load-when-hidden-expected.txt: Added.
        * http/tests/media/media-can-load-when-hidden.html: Added.
2011-05-18  Alexis Menard  <alexis.menard@openbossa.org>, Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Eric Carlson.

        MediaElements fails to load the data in some cases.
        https://bugs.webkit.org/show_bug.cgi?id=60760

        WebKitWebSourceGStreamer is the interface between WebKit and GStreamer
        that uses the ResourceHandle API to request data and pass it down. For
        our builds it is absolutely essential that we have a NetworkingContext
        available there, in order to get access to the QNetworkAccessManager.
        No access means we basically cannot load the video. The WebSource gains
        access to the NetworkingContext through a WebCore::Frame pointer it has.

        MediaPlayerPrivateGStreamer is responsible for propagating a pointer of
        the WebCore::Frame to the WebKitWebSource in
        mediaPlayerPrivateSourceChangedCallback. In there we used the MediaPlayer's
        frameView() accessor to access the frame. However the frameView() member
        is only set through the render tree's RenderVideo, which is rather unreliable
        given that some sites create "fake" video tags initially that only become
        visible later (or never).

        A more reliable way is to simply use the document of the MediaPlayerClient,
        which is provided at constructor time.

        Test: http/tests/media/media-can-load-when-hidden.html

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::sourceChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Wed, 18 May 2011 21:23:28 +0000 (21:23 +0000)]
2011-05-18  Justin Schuh  <jschuh@chromium.org>

        Unreviewed.

        Fixing previous Chromium tests expectations update for details element.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-18 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 18 May 2011 21:16:15 +0000 (21:16 +0000)]
2011-05-18  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Check HUD texture reserve status before using texture
        https://bugs.webkit.org/show_bug.cgi?id=61082

        This only changes behavior behind a flag, so shouldn't impact any tests.

        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@86788 268f45cc-cd09-0410-ab3c-d52691b4dbfc