loislo@chromium.org [Tue, 15 Mar 2011 14:41:54 +0000 (14:41 +0000)]
2011-03-15 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix.
Chromium: shared lib linux build are failing.
Two exclude rules for LocalizedNumberNone and TextEncodingDetectorNone were added to the wrong library.
It was webcore_remaining instead of webcore_platform.
* WebCore.gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 15 Mar 2011 14:38:53 +0000 (14:38 +0000)]
2011-03-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: expanding/collapsing object shouldn't affect outer console.group expansion state
https://bugs.webkit.org/show_bug.cgi?id=56373
* inspector/front-end/Section.js:
(WebInspector.Section):
(WebInspector.Section.prototype.toggleExpanded):
(WebInspector.Section.prototype.handleClick): stop click even propagation if it was handled by this section.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 15 Mar 2011 14:13:03 +0000 (14:13 +0000)]
2011-03-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: crash upon "//html//@id" search in elements panel.
https://bugs.webkit.org/show_bug.cgi?id=56334
* inspector/elements/elements-panel-search-expected.txt:
* inspector/elements/elements-panel-search.html:
2011-03-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: crash upon "//html//@id" search in elements panel.
https://bugs.webkit.org/show_bug.cgi?id=56334
* inspector/InspectorDOMAgent.cpp:
* inspector/front-end/ElementsTreeOutline.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 15 Mar 2011 14:02:56 +0000 (14:02 +0000)]
2011-03-15 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Swap two calls to setMonitoringXHREnabled to get rid of side effects on other tests.
* inspector/protocol/console-agent-expected.txt:
* inspector/protocol/console-agent.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 15 Mar 2011 13:47:37 +0000 (13:47 +0000)]
2011-03-15 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: further extension API cleanup (removed inspectedPage, add experimental prefix)
https://bugs.webkit.org/show_bug.cgi?id=56327
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI):
* inspector/front-end/ExtensionAPISchema.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 15 Mar 2011 13:08:54 +0000 (13:08 +0000)]
2011-03-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: when console.groupEnd calls twice
https://bugs.webkit.org/show_bug.cgi?id=56114
* inspector/console/console-nested-group-expected.txt: Added.
* inspector/console/console-nested-group.html: Added.
2011-03-15 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: when console.groupEnd calls twice
https://bugs.webkit.org/show_bug.cgi?id=56114
Test: inspector/console/console-nested-group.html
* inspector/ConsoleMessage.h:
(WebCore::ConsoleMessage::type):
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addConsoleMessage): do not coalesce adjacent EndGroup messages.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 15 Mar 2011 10:47:29 +0000 (10:47 +0000)]
2011-03-15 Chris Mumford <chris.mumford@palm.com>
Reviewed by Adam Barth.
Initializing several member variables that were not initialized in
their constructors. These values were all read prior to initialization
as reported by Valgrind.
No new tests: No feature additions/removals.
* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
* xml/XPathResult.cpp:
(WebCore::XPathResult::XPathResult):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Tue, 15 Mar 2011 10:46:21 +0000 (10:46 +0000)]
2011-03-15 Hayato Ito <hayato@chromium.org>
Reviewed by Shinichiro Hamaji.
[NRWT] Add support for reftests to new-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=55457
* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
* Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
* Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/test_files.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 15 Mar 2011 10:33:47 +0000 (10:33 +0000)]
2011-03-15 Ben Taylor <bentaylor.solx86@gmail.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=56255
Fix build on Solaris 10/Sun Studio 12 C++
No new tests. This is to fix compilation on Solaris 10 with Sun Studio 12 C++
* bridge/runtime_array.h:
(JSC::RuntimeArray::getConcreteArray):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 15 Mar 2011 10:32:13 +0000 (10:32 +0000)]
2011-03-15 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing media test on GTK.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 15 Mar 2011 10:19:45 +0000 (10:19 +0000)]
2011-03-15 Alexander Pavlov <apavlov@chromium.org>
[Chromium] Unreviewed, update test expectations
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Tue, 15 Mar 2011 10:10:53 +0000 (10:10 +0000)]
2011-03-15 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix compilation warning after r80892
https://bugs.webkit.org/show_bug.cgi?id=56302
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::originsWithLocalStorage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Tue, 15 Mar 2011 09:41:22 +0000 (09:41 +0000)]
2011-03-15 Robert Hogan <robert@webkit.org>
Reviewed by Adam Barth.
Document the qmakearg argument, and hint how to build webkit2 on Qt
https://bugs.webkit.org/show_bug.cgi?id=56326
* Scripts/build-webkit: add --qmakearg to build-webkit --help
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 15 Mar 2011 09:09:31 +0000 (09:09 +0000)]
2011-03-15 Ilya Sherman <isherman@chromium.org>
Reviewed by David Levin.
Update Chromium test expectations for fast/forms/onchange-setvalueforuser
https://bugs.webkit.org/show_bug.cgi?id=56365
* platform/chromium/fast/forms/onchange-setvalueforuser-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 15 Mar 2011 07:28:19 +0000 (07:28 +0000)]
Make Windows 7 Release (Tests) a core builder
We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
give it a few more days of greenness first.
Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
Reviewed by Sam Weinig.
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(BuildBot): Added a regexp to match Windows 7 Release (Tests).
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
Updated the core regexps to match the buildbot module. Updated the expected results to match
the current set of core builders.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 15 Mar 2011 06:58:45 +0000 (06:58 +0000)]
2011-03-14 Ryosuke Niwa <rniwa@webkit.org>
Another Chromium rebaseline for r81095.
* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Tue, 15 Mar 2011 06:50:36 +0000 (06:50 +0000)]
2011-03-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed build fix.
Buildfix when JIT is not enabled after r81079
https://bugs.webkit.org/show_bug.cgi?id=56361
* runtime/Executable.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 15 Mar 2011 06:34:16 +0000 (06:34 +0000)]
Add forgotten file from r81116
* TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 15 Mar 2011 06:21:41 +0000 (06:21 +0000)]
about:blank fake responses don't get serialized when sent the UIProcess
<rdar://problem/
9108119>
https://bugs.webkit.org/show_bug.cgi?id=56357
Source/WebCore:
Reviewed by Adam Roben
Test: AboutBlankLoad
* platform/network/cf/ResourceResponse.h:
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::cfURLResponse):
Create a CFURLResponseRef if one does not exist yet as we do for
NSURLResponses on the mac.
Tools:
Reviewed by Adam Roben.
* TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
(TestWebKitAPI::decidePolicyForResponse):
(TestWebKitAPI::TEST):
Add test that loads of about:blank have a response with a MIMEType of text/html.
* TestWebKitAPI/PlatformUtilities.h:
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::MIMETypeForWKURLResponse):
* TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::MIMETypeForWKURLResponse):
Add helper to get the MIMEType from a WKURLResponse.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
Add new files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 15 Mar 2011 06:11:59 +0000 (06:11 +0000)]
2011-03-14 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION: Print preview is blank when selecting multiple pages per sheet
https://bugs.webkit.org/show_bug.cgi?id=56341
<rdar://problem/
8991382>
* UIProcess/API/mac/WKPrintingView.mm: (pageDidDrawToPDF): Don't reset latest expected
callback number after receiving a different one. We only update preview after receiving
the latest expected page data (and the assumption is that AppKit will ask for pages in
natural order for N-up).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 15 Mar 2011 05:59:15 +0000 (05:59 +0000)]
2011-03-14 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Seeking videos using the timeline bar does not work properly and stop the video playback.
https://bugs.webkit.org/show_bug.cgi?id=56145
We do not need seekTimeout and queuedSeekTimeout anymore. setPosition on QMediaPlayer is good enough.
positionChanged() will be emitted when the data is buffered. On Linux the signal was not emitted because
of a bug in QtMultimedia.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::seek):
(WebCore::MediaPlayerPrivateQt::stateChanged):
(WebCore::MediaPlayerPrivateQt::positionChanged):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 15 Mar 2011 05:56:32 +0000 (05:56 +0000)]
2011-03-14 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Kenneth Russell.
Graphics Context is not properly recovered if the GPU process dies.
https://bugs.webkit.org/show_bug.cgi?id=56148
Split context recreation into two steps.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::doComposite):
(WebKit::WebViewImpl::reallocateRenderer):
* src/WebViewImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 15 Mar 2011 05:50:57 +0000 (05:50 +0000)]
2011-03-14 MORITA Hajime <morrita@google.com>
Unreviewed, skipped tests that uses an unsupported DRT API.
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 15 Mar 2011 05:48:07 +0000 (05:48 +0000)]
2011-03-14 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=44138
Crashes beneath SocketStreamHandle::readStreamCallback when running WebSocket tests.
* platform/win/Skipped: Unskipped tests that should be fixed now. I couldn't verify that
locally, becasue most WebSocket tests time out on my machine.
2011-03-14 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=44138
Crash beneath SocketStreamHandle::readStreamCallback when running websocket/tests/workers/worker-handshake-challenge-randomness.html
https://bugs.webkit.org/show_bug.cgi?id=55375
http/tests/websocket/tests/reload-crash.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
https://bugs.webkit.org/show_bug.cgi?id=56185
http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
* platform/network/cf/SocketStreamHandle.h: Made SocketStreamHandle ThreadSafeShared, so that
a pointer can be passed across threads when wrapped in a RefPtr.
* platform/network/cf/SocketStreamHandleCFNet.cpp: Make sure that an object still exists
when executing a method on main thread by using RefPtr.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 15 Mar 2011 05:44:15 +0000 (05:44 +0000)]
2011-03-14 Ryosuke Niwa <rniwa@webkit.org>
Chromium rebaselines for r81095.
* platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
* platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
* platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt:
* platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt:
* platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt:
* platform/chromium-linux/editing/selection/fake-drag-expected.txt: Removed.
* platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
* platform/chromium-win/editing/deleting/smart-delete-002-expected.txt:
* platform/chromium-win/editing/pasteboard/smart-drag-drop-expected.txt:
* platform/chromium-win/editing/pasteboard/smart-paste-001-expected.txt:
* platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt:
* platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt:
* platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
* platform/chromium-win/editing/selection/after-line-break-expected.txt:
* platform/chromium-win/editing/selection/expanding-selections-expected.txt:
* platform/chromium-win/editing/selection/expanding-selections2-expected.txt:
* platform/chromium-win/editing/selection/fake-drag-expected.txt:
* platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/chromium-win/editing/selection/triple-click-in-pre-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81110
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 15 Mar 2011 05:31:29 +0000 (05:31 +0000)]
2011-03-14 Ryosuke Niwa <rniwa@webkit.org>
GTK and Qt rebaselines for r81095.
* platform/gtk/editing/deleting/smart-delete-001-expected.txt:
* platform/gtk/editing/deleting/smart-delete-002-expected.txt:
* platform/gtk/editing/pasteboard/smart-paste-001-expected.txt:
* platform/gtk/editing/pasteboard/smart-paste-003-expected.txt:
* platform/gtk/editing/pasteboard/smart-paste-004-expected.txt:
* platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
* platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
* platform/gtk/editing/selection/expanding-selections-expected.txt:
* platform/gtk/editing/selection/expanding-selections2-expected.txt:
* platform/gtk/editing/selection/fake-drag-expected.txt:
* platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/gtk/editing/selection/triple-click-in-pre-expected.txt:
* platform/qt/editing/deleting/smart-delete-001-expected.txt:
* platform/qt/editing/pasteboard/smart-paste-001-expected.txt:
* platform/qt/editing/pasteboard/smart-paste-003-expected.txt:
* platform/qt/editing/pasteboard/smart-paste-004-expected.txt:
* platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
* platform/qt/editing/selection/expanding-selections-expected.txt:
* platform/qt/editing/selection/expanding-selections2-expected.txt:
* platform/qt/editing/selection/triple-click-in-pre-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 15 Mar 2011 05:24:34 +0000 (05:24 +0000)]
2011-03-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=56006
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::initializeView):
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 15 Mar 2011 04:58:08 +0000 (04:58 +0000)]
Mac build fix. Part 1 of N.
* WebCore.exp.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 15 Mar 2011 04:49:34 +0000 (04:49 +0000)]
2011-03-14 James Kozianski <koz@chromium.org>
Reviewed by Ojan Vafai.
Add method to make BuildBot return test outputs
https://bugs.webkit.org/show_bug.cgi?id=54374
The Builder.latest_cached_build will be used by the new rebaseline
script to determine the build to use baselines from.
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 15 Mar 2011 04:30:44 +0000 (04:30 +0000)]
Make WKBundlePageCanHandleRequest return true for empty document URLs
Reviewed by Sam Weinig.
Source/WebKit2:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::canHandleRequest): Return true for any URL schemes that are handled as
empty documents, and defer to the platform for everything else.
* WebProcess/WebPage/WebPage.h: Added platformCanHandleRequest.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformCanHandleRequest):
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformCanHandleRequest):
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::platformCanHandleRequest):
Renamed from canHandleRequest.
Tools:
Test that WKBundlePageCanHandleRequest returns true for empty document URLs
* TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
(TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
(TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
ensure the web process is initialized, then ask the bundle to run the test and assert that
it succeeded.
* TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
(TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
(TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
handle a given URL.
(TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
URL type cannot be handled).
(TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
result.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
Added new files to the project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Tue, 15 Mar 2011 04:11:30 +0000 (04:11 +0000)]
2011-03-14 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Eric Carlson.
Stalled media elements don't stop delaying the load event
https://bugs.webkit.org/show_bug.cgi?id=56316
* http/tests/media/video-play-stall-before-meta-data-expected.txt: Added.
* http/tests/media/video-play-stall-before-meta-data.html: Added.
2011-03-14 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Eric Carlson.
Stalled media elements don't stop delaying the load event
https://bugs.webkit.org/show_bug.cgi?id=56316
We should stop delaying the load event when the load has
stalled naturally, or if we require a user gesture to
continue the load.
Test: http/tests/media/video-play-stall-before-meta-data.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setNetworkState): when suspending, stop delaying.
(WebCore::HTMLMediaElement::progressEventTimerFired): when stalling, stop delaying.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 15 Mar 2011 03:56:29 +0000 (03:56 +0000)]
Roll out r81097. It broke the 32-bit Mac build and caused assertion failures on the Windows Debug bots.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 15 Mar 2011 03:50:35 +0000 (03:50 +0000)]
2011-03-14 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Martin Robinson.
[GTK] Possible leaks after splitting TextCheckerClientEnchant.
https://bugs.webkit.org/show_bug.cgi?id=55989
Convert gchar* to GOwnPtr<gchar> and refactor the code.
* WebCoreSupport/TextCheckerClientEnchant.cpp:
(WebKit::TextCheckerClientEnchant::checkSpellingOfString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 15 Mar 2011 02:38:01 +0000 (02:38 +0000)]
2011-03-13 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
Crash when dragging and dropping in a document with an invalid XHTML header
https://bugs.webkit.org/show_bug.cgi?id=48799
* editing/pasteboard/drop-file-svg.html: Added.
* editing/pasteboard/resources/drop-file-svg.svg: Added.
2011-03-13 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
Crash when dragging and dropping in a document with an invalid XHTML header
https://bugs.webkit.org/show_bug.cgi?id=48799
DragController tried to dispatch textInput event even when the
drag destination is not the editable area.
This change skips the event dispatching on that case.
Test: editing/pasteboard/drop-file-svg.html
* page/DragController.cpp:
(WebCore::DragController::dispatchTextInputEventFor):
(WebCore::DragController::concludeEditDrag):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81101
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Tue, 15 Mar 2011 02:28:03 +0000 (02:28 +0000)]
2011-03-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Made the global object moving-GC-safe
https://bugs.webkit.org/show_bug.cgi?id=56348
SunSpider reports no change.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::markChildren): Removed a dubious comment that
suggested we do not need to visit all our references during GC, since
that is not true in a moving GC.
Re-sorted data members by type, removed one duplicate, and added back
the one missing mark I found.
* runtime/JSGlobalObject.h: Re-sorted data members by type.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81100
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Tue, 15 Mar 2011 02:27:48 +0000 (02:27 +0000)]
Unreviewed, rolling out r81094.
http://trac.webkit.org/changeset/81094
https://bugs.webkit.org/show_bug.cgi?id=56355
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-03-14
Broke the chromium DRT related build. (Requested by dave_levin
on #webkit).
Source/WebCore:
* WebCore.exp.in:
* WebCore.order:
* page/Frame.cpp:
(WebCore::Frame::layerTreeAsText):
* page/Frame.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
* rendering/RenderLayerCompositor.h:
Source/WebKit/chromium:
* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::renderTreeAsText):
(WebKit::WebFrameImpl::layerTreeAsText):
* src/WebFrameImpl.h:
Tools:
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::layerTreeAsText):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::runFileTest):
(TestShell::dump):
* DumpRenderTree/chromium/TestShell.h:
(TestParams::TestParams):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81099
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 15 Mar 2011 02:24:37 +0000 (02:24 +0000)]
2011-03-14 Adam Barth <abarth@webkit.org>
Apparently we need to exclude DefaultSharedWorkerRepository.cpp from
the Chromium build, otherwise the objects visible in the global scope
change.
* WebCore.gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 15 Mar 2011 02:17:53 +0000 (02:17 +0000)]
2011-03-14 Rik Cabanier <cabanier@gmail.com>
Reviewed by David Hyatt.
bug 56052: percentages are incorrectly rounded in WebKit
https://bugs.webkit.org/show_bug.cgi?id=56052
* platform/mac/fast/css/percentage-non-integer-expected.txt:
2011-03-14 Rik Cabanier <cabanier@adobe.com>
Reviewed by David Hyatt.
bug 56052: percentages are incorrectly rounded in WebKit
https://bugs.webkit.org/show_bug.cgi?id=56052
test: fast/css/percentage-non-integer.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* page/PrintContext.cpp:
(WebCore::PrintContext::pageProperty):
* platform/Length.h:
(WebCore::Length::Length):
(WebCore::Length::operator*=):
(WebCore::Length::value):
(WebCore::Length::percent):
(WebCore::Length::setValue):
(WebCore::Length::calcValue):
(WebCore::Length::calcMinValue):
(WebCore::Length::isUndefined):
(WebCore::Length::isZero):
(WebCore::Length::isPositive):
(WebCore::Length::isNegative):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
(WebCore::FixedTableLayout::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addCell):
(WebCore::RenderTableSection::layoutRows):
* rendering/style/BorderData.h:
(WebCore::BorderData::hasBorderRadius):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 15 Mar 2011 02:09:43 +0000 (02:09 +0000)]
2011-03-14 Adam Barth <abarth@webkit.org>
Attempted Chromium build fix. Exclude AllInOne harder.
* WebCore.gyp/WebCore.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 15 Mar 2011 02:07:09 +0000 (02:07 +0000)]
2011-03-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
EventHandler calls shouldChangeSelection needlessly
https://bugs.webkit.org/show_bug.cgi?id=56324
Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and
avoided calling shouldChangeSelection and setSelection when the existing
selection is identical to that of new selection.
* page/EventHandler.cpp:
(WebCore::setSelectionIfNeeded): Extracted.
(WebCore::setNonDirectionalSelectionIfNeeded): Extracted.
(WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above.
(WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto.
(WebCore::EventHandler::handleMousePressEventTripleClick): Ditto.
(WebCore::EventHandler::handleMousePressEventSingleClick): Ditto.
(WebCore::EventHandler::updateSelectionForMouseDrag): Ditto.
(WebCore::EventHandler::handleMouseReleaseEvent): Ditto.
2011-03-14 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Rework object group building.
https://bugs.webkit.org/show_bug.cgi?id=55399
Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.
Alas, this cannot be implemented for one kind of objects---CSSProperties.
Part of core GC algorithm and tested extensively by exisiting layout tests.
* platform/chromium/test_expectations.txt: Temporary suppress text differences.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 15 Mar 2011 01:56:37 +0000 (01:56 +0000)]
2011-03-14 Daniel Sievers <sievers@google.com>
Reviewed by Simon Fraser.
[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139
* WebCore.exp.in:
* WebCore.order:
* page/Frame.cpp:
(WebCore::Frame::layerTreeAsText):
* page/Frame.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
* rendering/RenderLayerCompositor.h:
2011-03-14 Daniel Sievers <sievers@google.com>
Reviewed by Simon Fraser.
[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139
* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::renderTreeAsText):
(WebKit::WebFrameImpl::layerTreeAsText):
* src/WebFrameImpl.h:
2011-03-14 Daniel Sievers <sievers@google.com>
Reviewed by Simon Fraser.
[Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
https://bugs.webkit.org/show_bug.cgi?id=56139
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::layerTreeAsText):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::setShowDebugLayerTree):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::runFileTest):
(TestShell::dump):
* DumpRenderTree/chromium/TestShell.h:
(TestParams::TestParams):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 15 Mar 2011 01:42:59 +0000 (01:42 +0000)]
2011-03-14 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Add remaining files to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=56351
Adding the remaining files to WebCore.gypi required updating the
include/exclude lists in WebCore.gyp. These lists aren't overly
elegant, but we can try to improve them in the future.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* bindings/v8/ScriptCachedFrameData.cpp:
- Added ifdefs to this file to match the header.
* platform/graphics/WOFFFileFormat.cpp:
- Fixed build error when compiling without ENABLE(OPENTYPE_SANITIZER).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Tue, 15 Mar 2011 01:19:14 +0000 (01:19 +0000)]
2011-03-14 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Rework object group building.
https://bugs.webkit.org/show_bug.cgi?id=55399
Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.
Alas, this cannot be implemented for one kind of objects---CSSProperties.
Part of core GC algorithm and tested extensively by exisiting layout tests.
* platform/chromium/test_expectations.txt: Temporary suppress text differences.
2011-03-14 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Rework object group building.
https://bugs.webkit.org/show_bug.cgi?id=55399
Instead of going top-down (from owner to owned elements), go up---from objects
to their group ids. That fits better to v8's object grouping model and guarantees
that each wrapper belongs to the single group.
Alas, this cannot be implemented for one kind of objects---CSSProperties.
Part of core GC algorithm and tested extensively by exisiting layout tests.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/test/V8/V8TestInterface.cpp:
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
* bindings/scripts/test/V8/V8TestObj.cpp:
* bindings/v8/V8GCController.cpp:
(WebCore::calculateGroupId):
(WebCore::calculateRootStyleSheet):
(WebCore::GrouperVisitor::visitDOMWrapper):
(WebCore::GrouperVisitor::applyGrouping):
(WebCore::V8GCController::gcPrologue):
* bindings/v8/WrapperTypeInfo.h:
(WebCore::WrapperTypeInfo::isSubclass):
* css/CSSRuleList.h:
(WebCore::CSSRuleList::styleList):
* css/StyleSheetList.h:
(WebCore::StyleSheetList::document):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Tue, 15 Mar 2011 01:15:47 +0000 (01:15 +0000)]
Skipping some tests on Windows due to problems on mouse click handling.
See https://bugs.webkit.org/show_bug.cgi?id=56347.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 15 Mar 2011 01:13:19 +0000 (01:13 +0000)]
2011-03-14 Ryosuke Niwa <rniwa@webkit.org>
Mac Leopard rebaselines for r81053 (Grabbed off of Chromium bots).
* platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.checksum:
* platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.png:
* platform/mac-leopard/editing/selection/drag-select-1-expected.checksum:
* platform/mac-leopard/editing/selection/drag-select-1-expected.png:
* platform/mac-leopard/editing/selection/fake-drag-expected.checksum:
* platform/mac-leopard/editing/selection/fake-drag-expected.png:
* platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.checksum:
* platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.png:
* platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum:
* platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
* platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum:
* platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
* platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Tue, 15 Mar 2011 01:11:35 +0000 (01:11 +0000)]
CrashTracer: 60 crashes in WebProcess at com.apple.WebKit2: -[AccessibilityWebPageObject accessibilityHitTest:] + 248
https://bugs.webkit.org/show_bug.cgi?id=56336
Reviewed by Beth Dakin.
Crash trace indicates a nil pointer access in one of these m_page->mainFrame()->coreFrame()->view()
pointers.
* WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
(-[AccessibilityWebPageObject accessibilityHitTest:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 15 Mar 2011 00:53:53 +0000 (00:53 +0000)]
Assertion failure by form validation message for <select required> with float:left
https://bugs.webkit.org/show_bug.cgi?id=55995
Reviewed by James Robinson.
Source/WebCore:
Test: fast/forms/interactive-validation-select-crash.html
* rendering/RenderBlock.cpp:
(WebCore::canMergeContiguousAnonymousBlocks):
isAnonymousBlock() doesn't mean it is a RenderBlock. We need to check isRenderBlock().
LayoutTests:
* fast/forms/interactive-validation-select-crash-expected.txt: Added.
* fast/forms/interactive-validation-select-crash.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Tue, 15 Mar 2011 00:48:45 +0000 (00:48 +0000)]
Provide API for creating WKImage from CGImageRef
https://bugs.webkit.org/show_bug.cgi?id=56159
Reviewed by Sam Weinig.
Add function for creating a WKImage from CGImage data.
* Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateFromCGImage): Added. Creates a graphics context for the bitmap-backed image and draws into it.
* Shared/API/c/cg/WKImageCG.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Tue, 15 Mar 2011 00:39:56 +0000 (00:39 +0000)]
2011-03-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Made JSWrapperObject and subclasses moving-GC-safe
https://bugs.webkit.org/show_bug.cgi?id=56346
SunSpider reports no change.
* runtime/BooleanObject.cpp:
(JSC::BooleanObject::BooleanObject):
* runtime/DateInstance.cpp:
(JSC::DateInstance::DateInstance): No more need for JSGlobalData, since
we don't initialize the wrapped value in our constructor.
* runtime/DateInstance.h: Don't set the OverridesMarkChildren flag because
we do not in fact override markChildren.
* runtime/DatePrototype.h: Declare an anonymous slot, since wrapper object
no longer does so for us. Also added an ASSERT to catch a latent bug,
where DatePrototype stomped on its base class's anonymous slot. Hard-coded
anonymous slots are a plague on our code. This doesn't cause any problems
in our existing code since the base class never reads the anonymous slot
it declares, but it caused crashes when I tried to start using the slot
in an initial version of this patch.
* runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::JSWrapperObject):
(JSC::JSWrapperObject::internalValue):
(JSC::JSWrapperObject::setInternalValue): Resolved a problem where
our internal value was stored in two places: an anonymous slot, and a
data member which was not always visited during GC. Now, we only use the
data member, and we always visit it. (Instead of relying on certain
subclasses to set the OverridesMarkChildren bit, we set it ourselves.)
* runtime/NumberObject.cpp:
(JSC::NumberObject::NumberObject): No more need for JSGlobalData, since
we don't initialize the wrapped value in our constructor.
* runtime/NumberObject.h: Removed meaningless declaration.
* runtime/StringObject.cpp:
(JSC::StringObject::StringObject): No more need for JSGlobalData, since
we don't initialize the wrapped value in our constructor.
* runtime/StringObject.h: Don't set the OverridesMarkChildren flag because
we do not in fact override markChildren.
* runtime/StringPrototype.h: Declare an anonymous slot, since wrapper object
no longer does so for us. Also added an ASSERT to catch a latent bug,
where DatePrototype stomped on its base class's anonymous slot. Hard-coded
anonymous slots are a plague on our code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Tue, 15 Mar 2011 00:36:23 +0000 (00:36 +0000)]
2011-03-14 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Look-ahead assertions with back references don’t work as expected
https://bugs.webkit.org/show_bug.cgi?id=56082
Changed parentheses assertion processing to temporarily back out the
number of known characters after the assertion while processing the
assertion. This was done so that assertions don't fail due to
checking the number of required characters as additional to the
rest of the express since assertions don't "consume" input.
Added a byte code to uncheck characters to support the change.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::ByteCompiler::uncheckInput):
(JSC::Yarr::ByteCompiler::emitDisjunction):
* yarr/YarrInterpreter.h:
(JSC::Yarr::ByteTerm::UncheckInput):
2011-03-14 Michael Saboff <msaboff@apple.com>
Reviewed by Gavin Barraclough.
Look-ahead assertions with back references don’t work as expected
https://bugs.webkit.org/show_bug.cgi?id=56082
New tests to verify the corresponding changes.
* fast/regex/assertion-expected.txt: Added.
* fast/regex/assertion.html: Added.
* fast/regex/script-tests/assertion.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 15 Mar 2011 00:32:53 +0000 (00:32 +0000)]
2011-03-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Adam Roben.
[Qt][WK2]Unbreak InjectedBundle on Qt
https://bugs.webkit.org/show_bug.cgi?id=54109
No code changes so no new tests.
Revert the changes that were needed to use KURL
in WebKitTestRunner.
* Configurations/WebCore.xcconfig:
* WebCore.exp.in:
2011-03-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Adam Roben.
[Qt][WK2]Unbreak InjectedBundle on Qt
https://bugs.webkit.org/show_bug.cgi?id=54109
Add API's to WKURL and WKString to satisfy
WebKitTestRunner's needs.
* Shared/API/c/WKString.cpp:
(WKStringIsEqualToUTF8CStringIgnoringCase):
* Shared/API/c/WKString.h:
* Shared/API/c/WKURL.cpp:
(WKURLCopyHostName):
(WKURLCopyScheme):
* Shared/API/c/WKURL.h:
* Shared/WebString.h:
(WebKit::WebString::equalToUTF8StringIgnoringCase):
* Shared/WebURL.h: Added OwnPtr<KURL> member to be able
to lazily parse the URL and store the result.
(WebKit::WebURL::host):
(WebKit::WebURL::protocol):
(WebKit::WebURL::parseURLIfNecessary):
* win/WebKit2.def: Revert the symbol exports that were
needed to use KURL in WebKitTestRunner.
2011-03-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Adam Roben.
[Qt][WK2]Unbreak InjectedBundle on Qt
https://bugs.webkit.org/show_bug.cgi?id=54109
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
API's instead of KURL to analyze the URL.
* WebKitTestRunner/StringFunctions.h:
(WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
in the WebKitTestRunner project.
(WTR::toWK): Use adoptWK.
(WTR::operator<<): Added helper for printing a WKURL.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
against WebCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 14 Mar 2011 23:59:38 +0000 (23:59 +0000)]
It's the same old song (about the linux debug crash).
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Mon, 14 Mar 2011 23:52:53 +0000 (23:52 +0000)]
2011-03-14 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
Add WKViewSetScrollOffsetOnNextResize() to C API on Windows
https://bugs.webkit.org/show_bug.cgi?id=56340
* UIProcess/API/C/win/WKView.cpp:
(WKViewSetScrollOffsetOnNextResize): Added.
* UIProcess/API/C/win/WKView.h: Added WKViewSetScrollOffsetOnNextResize().
* UIProcess/win/WebView.cpp:
(WebKit::WebView::onSizeEvent): Apply any scroll offset when setting the drawing area size.
(WebKit::WebView::setScrollOffsetOnNextResize): Added.
* UIProcess/win/WebView.h: Added setScrollOffsetOnNextResize().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 14 Mar 2011 23:47:07 +0000 (23:47 +0000)]
2011-03-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Warning that round/roundf functions are already defined when compiled with RVCT 4 on symbian.
https://bugs.webkit.org/show_bug.cgi?id=56133
Add condition to not compile webkit internal math round functions on RVCT compiler versions
from 3.0.0 because they are already defined in compiler math library.
* wtf/MathExtras.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 14 Mar 2011 23:40:39 +0000 (23:40 +0000)]
Fix two memory leaks within LayoutTestController's storage support.
Reviewed by Adam Roben.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
by JSStringCreateWithCFString.
(LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
allocate.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Mon, 14 Mar 2011 23:31:00 +0000 (23:31 +0000)]
Bug 56284 - Add a dataflow intermediate representation for use in JIT generation.
Reviewed by Geoffrey Garen & Oliver Hunt.
The JSC JIT presently generates code directly from the bytecode used by the interpreter.
This is not an optimal intermediate representation for JIT code generation, since it does
not capture liveness information of values, and provides little opportunity to perform
any static analysis for even primitive types. The JIT currently generates two code paths,
a fast path handling common cases, and a slower path handling less common operand types.
However the slow path jumps back into the fast path, meaning that information arising
from the earlier type checks cannot be propagated to later operations.
This patch adds:
* a dataflow intermediate representation capable of describing a single basic block
of operations,
* a mechanism to convert a simple, single-block bytecode functions to the new IR,
* and a JIT code generator capable of generating code from this representation.
The JIT generates two code paths, with the slower path not reentering the fast path
mid-block, allowing speculative optimizations to be made on the hot path, with type
information arising from these speculative decisions able to be propagated through the
dataflow. Code generation of both speculative and non-speculative paths exploits the type
and liveness information represented in the dataflow graph to attempt to avoid redundant
boxing and type-checking of values, and to remove unnecessary spills of temporary values
to the RegisterFile.
The dataflow JIT currently can only support a subset of bytecode operations, limited to
arithmetic, bit-ops, and basic property access. Functions that cannot be compiled by the
dataflow JIT will be run using the existing JIT. The coverage of the dataflow JIT will be
expanded to include, control-flow, function calls, and then the long-tail of remaining
bytecode instructions. The JIT presently only support JSVALUE64, and as a consequence of
this only supports x86-64.
The status of the dataflow JIT is currently work-in-progress. Limitations of the present
JIT code generation may cause performance regressions, particularly:
* the policy to only generate arithmetic code on the speculative path using integer
instructions, never using floating point.
* the policy to only generate arithmetic code on the non-speculative path using
floating point instructions, never using integer.
* always generating JSValue adds on the non-speculative path as a call out to a
C-function, never handling this in JIT code.
* always assuming by-Value property accesses on the speculative path to be array
accesses.
* generating all by-Value property accesses from the non-speculative path as a call
out to a C-function.
* generating all by-Indentifer property accesses as a call out to a C-function.
Due to these regressions, the code is landed in a state where it is disabled in most
cases by the ENABLE_DFG_JIT_RESTRICTIONS guard in Platform.h. As these regressions are
addressed, the JIT will be allowed to trigger in more cases.
* JavaScriptCore.xcodeproj/project.pbxproj:
- Added new files to Xcode project.
* dfg: Added.
- Added directory for new code.
* dfg/DFGByteCodeParser.cpp: Added.
* dfg/DFGByteCodeParser.h: Added.
- Contruct a DFG::Graph representation from a bytecode CodeBlock.
* dfg/DFGGenerationInfo.h: Added.
- Track type & register information for VirtualRegisters during JIT code generation.
* dfg/DFGGraph.cpp: Added.
* dfg/DFGGraph.h: Added.
- Dataflow graph intermediate representation for code generation.
* dfg/DFGJITCodeGenerator.cpp: Added.
* dfg/DFGJITCodeGenerator.h: Added.
- Base class for SpeculativeJIT & NonSpeculativeJIT to share common functionality.
* dfg/DFGJITCompiler.cpp: Added.
* dfg/DFGJITCompiler.h: Added.
- Class responsible for driving code generation of speculativeJIT & non-speculative
code paths from the dataflow graph.
* dfg/DFGNonSpeculativeJIT.cpp: Added.
* dfg/DFGNonSpeculativeJIT.h: Added.
- Used to generate the non-speculative code path, this make no assumptions
about operand types.
* dfg/DFGOperations.cpp: Added.
* dfg/DFGOperations.h: Added.
- Helper functions called from the JIT generated code.
* dfg/DFGRegisterBank.h: Added.
- Used to track contents of physical registers during JIT code generation.
* dfg/DFGSpeculativeJIT.cpp: Added.
* dfg/DFGSpeculativeJIT.h: Added.
- Used to generate the speculative code path, this make assumptions about
operand types to enable optimization.
* runtime/Executable.cpp:
- Add code to attempt to use the DFG JIT to compile a function, with fallback
to the existing JIT.
* wtf/Platform.h:
- Added compile guards to enable the DFG JIT.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 14 Mar 2011 23:29:36 +0000 (23:29 +0000)]
Add more linux debug crashers to the sad list.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 14 Mar 2011 23:27:12 +0000 (23:27 +0000)]
2011-03-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
https://bugs.webkit.org/show_bug.cgi?id=56321
* Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
to the list of exceptions for WebKit2 C API headers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 14 Mar 2011 23:24:01 +0000 (23:24 +0000)]
2011-03-14 Martin Robinson <mrobinson@igalia.com>
Update GTK+ pixel results after r81053.
* platform/gtk/editing/selection/drag-select-1-expected.checksum:
* platform/gtk/editing/selection/drag-select-1-expected.png:
* platform/gtk/editing/selection/fake-drag-expected.checksum: Added.
* platform/gtk/editing/selection/fake-drag-expected.png: Added.
* platform/gtk/editing/selection/inline-closest-leaf-child-expected.checksum: Added.
* platform/gtk/editing/selection/inline-closest-leaf-child-expected.png: Added.
* platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
* platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
* platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 14 Mar 2011 23:14:02 +0000 (23:14 +0000)]
Show the list of recent leaky builds in reverse chronological order
Previously they were being shown in a deterministic but surprising order based on
lexicographically sorting the build offsets (-1, -10, -2, -3...).
Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
callback.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
psolanki@apple.com [Mon, 14 Mar 2011 23:13:19 +0000 (23:13 +0000)]
I checked in Intel-only version of these files in r80975. This fixes that by building all
the correct slices - i386/x86_64/ppc for SnowLeopard and i386/x86_64/ppc/ppc64 for Leopard.
Rubber-stamped by Mark Rowe.
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 14 Mar 2011 22:47:43 +0000 (22:47 +0000)]
Upstream test expectations from the chromium repository to WebKit.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 14 Mar 2011 22:38:10 +0000 (22:38 +0000)]
2011-03-14 Ryosuke Niwa <rniwa@webkit.org>
Mac pixel rebaselines for r81053.
* platform/mac/editing/selection/drag-select-1-expected.checksum:
* platform/mac/editing/selection/drag-select-1-expected.png:
* platform/mac/editing/selection/fake-drag-expected.checksum:
* platform/mac/editing/selection/fake-drag-expected.png:
* platform/mac/fast/text/atsui-rtl-override-selection-expected.checksum:
* platform/mac/fast/text/atsui-rtl-override-selection-expected.png:
* platform/mac/svg/custom/mouse-move-on-svg-container-expected.checksum:
* platform/mac/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
* platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
* platform/mac/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
* platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 14 Mar 2011 22:31:29 +0000 (22:31 +0000)]
2011-03-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed more cases of DeprecatedPtr (exception, SmallStrings)
https://bugs.webkit.org/show_bug.cgi?id=56332
* runtime/Identifier.cpp:
(JSC::Identifier::add):
(JSC::Identifier::addSlowCase): Use a variable instead of a hard-coded
constant, to make this code less brittle.
* runtime/JSGlobalData.h: Use HeapRoot instead of DeprecatedPtr because
this reference is owned and managed directly by the heap.
* runtime/JSString.cpp:
(JSC::JSString::substringFromRope):
* runtime/JSString.h:
(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsStringWithFinalizer):
(JSC::jsSubstring):
(JSC::jsOwnedString): Use a variable instead of a hard-coded
constant, to make this code less brittle.
* runtime/SmallStrings.cpp:
(JSC::SmallStringsStorage::rep):
(JSC::SmallStringsStorage::SmallStringsStorage):
(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::markChildren):
(JSC::SmallStrings::clear):
(JSC::SmallStrings::count): Use a variable instead of a hard-coded
constant, to make this code less brittle.
* runtime/SmallStrings.h:
(JSC::SmallStrings::singleCharacterString): Use HeapRoot instead of
DeprecatedPtr because these references are owned and managed directly by
the heap.
Stop using FixedArray because we only want a very limited set
of classes to be able to use HeapRoot. (Replaced with manual ASSERTs.)
* runtime/WriteBarrier.h:
(JSC::operator==):
(JSC::WriteBarrier::WriteBarrier):
(JSC::HeapRoot::HeapRoot):
(JSC::HeapRoot::operator=): Added HeapRoot, which is allowed to set
without write barrier because we assume all HeapRoots are scanned during
all GC passes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 14 Mar 2011 22:28:49 +0000 (22:28 +0000)]
Update the chromium windows baselines for r81053.
* platform/chromium-win/editing/selection/drag-select-1-expected.checksum:
* platform/chromium-win/editing/selection/drag-select-1-expected.png:
* platform/chromium-win/editing/selection/drag-select-1-expected.txt:
* platform/chromium-win/editing/selection/fake-drag-expected.txt:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.checksum:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.checksum:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 14 Mar 2011 22:25:24 +0000 (22:25 +0000)]
2011-03-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Compilation fails with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=55964
* WebCore.pro:
* platform/graphics/qt/Extensions3DQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 14 Mar 2011 22:19:55 +0000 (22:19 +0000)]
Show a list of up to 10 recent leaky builds when Leaks Viewer loads
Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
analyze
Reviewed by David Kilzer and Joe Pecoraro.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
(#url-prompt): Made this a bit taller to make room for the list of builds.
(#recent-builds-loading-indicator):
(#recent-builds-list):
Added styles for the build list and loading indicator.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
it. This will unescape it.
(LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
(LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
(LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
(LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
prompt UI.
(LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
now also used when a recent build is clicked.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
(RecentBuildsLoader): Store the callback.
(RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
builder. Find the revision number, leak count, and results URL for each one. Pass the
resulting info to our callback.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
(range): Added this helper function to return an array containing the integers [0, n).
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 14 Mar 2011 22:17:32 +0000 (22:17 +0000)]
Fixed typo in the change log entry for r81066.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 14 Mar 2011 22:15:47 +0000 (22:15 +0000)]
2011-03-14 Ryosuke Niwa <rniwa@webkit.org>
GTK rebaselines or r81053.
* platform/gtk/editing/selection/drag-select-1-expected.txt:
* platform/gtk/editing/selection/fake-drag-expected.txt:
* platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Mon, 14 Mar 2011 22:15:27 +0000 (22:15 +0000)]
FileSystemWin.cpp needs listDirectory() implementation
https://bugs.webkit.org/show_bug.cgi?id=56331
<rdar://problem/
9126635>
Reviewed by Adam Roben and Gavin Barraclough.
Source/JavaScriptCore:
Give StringConcatenate the ability to deal with const UChar*'s as a String type to append.
* wtf/text/StringConcatenate.h:
Source/WebCore:
Move PathWalker from an inline class in WebKit2 to its own class in WebCore,
so it can be used from both WebCore and WebKit2.
Implement FileSystemWin::listDirectory using PathWalker to populate the Vector
of paths matching the passed in pattern.
* WebCore.vcproj/WebCore.vcproj:
* platform/win/FileSystemWin.cpp:
(WebCore::listDirectory): Call through to PathWalker.
* platform/win/PathWalker.cpp: Added.
(WebCore::PathWalker::PathWalker): Moved from WebKit2. Added a second argument
for the pattern to pass to the Windows File APIs.
(WebCore::PathWalker::~PathWalker): Moved from WebKit2.
(WebCore::PathWalker::isValid): Ditto.
(WebCore::PathWalker::data): Ditto.
(WebCore::PathWalker::step): Ditto.
* platform/win/PathWalker.h: Added.
Source/WebKit2:
Move PathWalker down into WebCore, and call the PathWalker in WebCore
(that now has a second argument, the pattern to take).
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::pluginPathsInDirectory):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 14 Mar 2011 22:14:29 +0000 (22:14 +0000)]
Add rebaselines due to two changes:
For r81053, we have
editing/selection/drag-select-1.html, editing/selection/fake-drag.html, svg/custom/mouse-move-on-svg-container-standalone.svg,
svg/custom/mouse-move-on-svg-container.xhtml, svg/custom/mouse-move-on-svg-root-standalone.svg, svg/custom/mouse-move-on-svg-root.xhtml
For r81049, we have
fast/table/overflowHidden.html, fast/table/relative-position-containment.html, fast/table/relative-position-offsets.html, fast/table/relative-position-stacking.html
* platform/chromium-linux/editing/selection/drag-select-1-expected.checksum:
* platform/chromium-linux/editing/selection/drag-select-1-expected.png:
* platform/chromium-linux/editing/selection/drag-select-1-expected.txt: Added.
* platform/chromium-linux/editing/selection/fake-drag-expected.txt: Added.
* platform/chromium-linux/fast/table/relative-position-containment-expected.checksum: Added.
* platform/chromium-linux/fast/table/relative-position-containment-expected.png: Added.
* platform/chromium-linux/fast/table/relative-position-offsets-expected.checksum: Added.
* platform/chromium-linux/fast/table/relative-position-offsets-expected.png: Added.
* platform/chromium-linux/fast/table/relative-position-stacking-expected.checksum: Added.
* platform/chromium-linux/fast/table/relative-position-stacking-expected.png: Added.
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.checksum:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.checksum:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
* platform/chromium-win/fast/table/overflowHidden-expected.txt:
* platform/chromium-win/fast/table/relative-position-containment-expected.checksum: Added.
* platform/chromium-win/fast/table/relative-position-containment-expected.png: Added.
* platform/chromium-win/fast/table/relative-position-containment-expected.txt: Added.
* platform/chromium-win/fast/table/relative-position-offsets-expected.checksum: Added.
* platform/chromium-win/fast/table/relative-position-offsets-expected.png: Added.
* platform/chromium-win/fast/table/relative-position-offsets-expected.txt: Added.
* platform/chromium-win/fast/table/relative-position-stacking-expected.checksum: Added.
* platform/chromium-win/fast/table/relative-position-stacking-expected.png: Added.
* platform/chromium-win/fast/table/relative-position-stacking-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 14 Mar 2011 21:55:48 +0000 (21:55 +0000)]
2011-03-14 Ryosuke Niwa <rniwa@webkit.org>
Removed redundant baselines from Windows port so that rebaselines done in r81059 take effect.
* platform/win/svg/custom/mouse-move-on-svg-container-expected.txt: Removed.
* platform/win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Removed.
* platform/win/svg/custom/mouse-move-on-svg-root-expected.txt: Removed.
* platform/win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Mon, 14 Mar 2011 21:48:20 +0000 (21:48 +0000)]
Adjusting Snow Leopard expected results after r81035.
* platform/mac/fast/html/details-add-summary-1-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-1-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-10-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-10-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-2-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-2-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-3-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-3-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-4-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-4-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-5-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-5-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-6-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-6-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-7-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-7-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-8-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-8-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-9-and-click-expected.txt: Added.
* platform/mac/fast/html/details-add-summary-9-expected.txt: Added.
* platform/mac/fast/html/details-no-summary1-expected.txt: Added.
* platform/mac/fast/html/details-no-summary2-expected.txt: Added.
* platform/mac/fast/html/details-no-summary3-expected.txt: Added.
* platform/mac/fast/html/details-no-summary4-expected.txt: Added.
* platform/mac/fast/html/details-open-javascript-expected.txt: Added.
* platform/mac/fast/html/details-open1-expected.txt: Added.
* platform/mac/fast/html/details-open2-expected.txt: Added.
* platform/mac/fast/html/details-open3-expected.txt: Added.
* platform/mac/fast/html/details-open4-expected.txt: Added.
* platform/mac/fast/html/details-open5-expected.txt: Added.
* platform/mac/fast/html/details-open6-expected.txt: Added.
* platform/mac/fast/html/details-position-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-1-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-2-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-3-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-4-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-5-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
* platform/mac/fast/html/details-remove-summary-6-expected.txt: Added.
* platform/mac/fast/html/details-writing-mode-expected.txt: Added.
* platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 14 Mar 2011 21:45:48 +0000 (21:45 +0000)]
2011-03-14 Ryosuke Niwa <rniwa@webkit.org>
Qt rebaselines for r81053.
* platform/qt/editing/selection/drag-select-1-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81061
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 14 Mar 2011 21:44:00 +0000 (21:44 +0000)]
Try to fix the EFL build-bustage that their EWS bot did not see, but their core-builder did. (sigh)
* ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 14 Mar 2011 21:35:42 +0000 (21:35 +0000)]
2011-03-14 Ryosuke Niwa <rniwa@webkit.org>
Mac rebaselines for r81053.
* platform/mac/fast/text/atsui-rtl-override-selection-expected.txt:
* platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81059
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 14 Mar 2011 21:25:51 +0000 (21:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56320
Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
Reviewed by Anders Carlsson.
../WebCore:
Remove HistoryItem::icon():
* history/HistoryItem.cpp:
* history/HistoryItem.h:
* WebCore.exp.in:
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::defaultIcon):
../WebKit/efl:
* ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get): Use IconDatabase directly.
../WebKit/mac:
* History/WebHistoryItem.mm:
(-[WebHistoryItem icon]): This far-future FIXME is now irrelevant.
../WebKit/qt:
* Api/qwebhistory.cpp:
(QWebHistoryItem::icon): Use IconDatabase directly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Mon, 14 Mar 2011 21:22:32 +0000 (21:22 +0000)]
2011-03-13 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
Timer-based events should inherit the user gesture state of their
originating event in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=55104
* fast/events/popup-blocking-timers-expected.txt: Added.
* fast/events/popup-blocking-timers.html: Added.
2011-03-14 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
Timer-based events should inherit the user gesture state of their
originating event in certain cases.
https://bugs.webkit.org/show_bug.cgi?id=55104
If a timer is installed by a gesture-originated event and will fire
within one second, the timer-initiated event should behave as if it
were also initiated by a user gesture. Multi-shot timers should only
get this behavior on their first execution. Nested timers should not
get this behavior. This makes us compatible with Gecko when handling
popups and file chooser dialogs created from timer events.
Test: fast/events/popup-blocking-timers.html
* page/DOMTimer.cpp:
(WebCore::timeoutId): Create a helper function so that m_timeoutId can
be initialized in the data member initialization list.
(WebCore::shouldForwardUserGesture): Ditto, but for
m_shouldForwardUserGesture.
(WebCore::DOMTimer::DOMTimer): Move initialization of data members from
the ctor body to the data member initialization list. Also rename the
argument 'timeout' to 'interval'.
(WebCore::DOMTimer::fired): Create a UserGestureIndicator and set its
state based on the value of m_shouldForwardUserGesture.
(WebCore::DOMTimer::adjustMinimumTimerInterval): m_originalTimeout was
renamed to m_originalInterval.
* page/DOMTimer.h: Add m_shouldForwardUserGesture and rename
m_originalTimeout to m_originalInterval.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Mon, 14 Mar 2011 21:19:29 +0000 (21:19 +0000)]
2011-03-09 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Deleting content directly following a button inserts an unnecessary placeholder
https://bugs.webkit.org/show_bug.cgi?id=56053
Test to ensure unnecessary placeholders aren't inserted after buttons when delete is pressed.
* editing/deleting/delete-inserts-br-after-button-expected.txt: Added.
* editing/deleting/delete-inserts-br-after-button.html: Added.
2011-03-09 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Deleting content directly following a button inserts an unnecessary placeholder
https://bugs.webkit.org/show_bug.cgi?id=56053
Fixing a use of Node's enclosingBlockFlowElement with enclosingBlock htmlediting's
enclosingBlock, as enclosingBlockFlowElement would return inline-block elements despite
DeleteSelectionCommand treating them as blockflow.
Test: editing/deleting/delete-inserts-br-after-button.html
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 14 Mar 2011 20:56:18 +0000 (20:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=45164
Reviewed by Dan Bernstein.
REGRESSION: <a><img align=top></a> Clickable area too large
Make sure to clamp hit testing of quirky inline flow boxes the same way we already clamped
painting.
Source/WebCore:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
LayoutTests:
* fast/inline/inline-position-top-align-expected.txt: Added.
* fast/inline/inline-position-top-align.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Mon, 14 Mar 2011 20:53:38 +0000 (20:53 +0000)]
2011-03-14 Chris Marrin <cmarrin@apple.com>
Reviewed by Adam Roben.
REGRESSION (r75138-r75503): Animations on Apple HTML5 Gallery demo are wrong
https://bugs.webkit.org/show_bug.cgi?id=52845
The lastCommitTime() value in CACFLayerTreeHost was returning as the time
the render previous to this one happened. That often made it seem like
animations started more in the past than they did, breaking many animations.
The startAnimations() call actually fires from a CACF callback after all the
WebKit content has been rendered. So sending currentTime as the start time
to the animations is close enough for proper synchronization.
* platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81054
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 14 Mar 2011 20:47:34 +0000 (20:47 +0000)]
2011-03-11 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Selection uses first mousemove's localRect instead of that of mousedown
https://bugs.webkit.org/show_bug.cgi?id=56213
Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent
using the mouse coordinates of the mousedown event that started the drag.
Test: editing/selection/drag-select-rapidly.html
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
2011-03-11 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
Selection uses first mousemove's localRect instead of that of mousedown
https://bugs.webkit.org/show_bug.cgi?id=56213
Added a test to ensure the selection start is computed using the mouse coordinates passed down
to the corresponding mousedown event instead of that of the first mousemove event.
The test is co-authored by Evan Martin.
* editing/selection/anchor-focus2-expected.txt: Editing delegate changes.
* editing/selection/anchor-focus3-expected.txt: Ditto.
* editing/selection/drag-select-rapidly-expected.txt: Added.
* editing/selection/drag-select-rapidly.html: Added.
* platform/mac/editing/selection/drag-select-1-expected.txt: Selects the correct range of text.
* platform/mac/editing/selection/fake-drag-expected.txt: Ditto.
* platform/mac/editing/selection/inline-closest-leaf-child-expected.txt: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81053
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 14 Mar 2011 20:45:29 +0000 (20:45 +0000)]
Add a baseline for linux for this test since it matches what we have for OSX
except for the typical minor font differences.
* platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
* platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
* platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81052
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 14 Mar 2011 20:40:49 +0000 (20:40 +0000)]
<webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass): Don't leak any existing entry for the given name if
the class definition contains duplicates. This also removes what look to be leaks
of the StringImpl instances that are used as keys: the HashMap key type is a RefPtr
which retains / releases the instances at the appropriate time, so explicitly calling
ref is not necessary.
Tools:
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions): Remove duplicate entries.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81051
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Mon, 14 Mar 2011 20:40:45 +0000 (20:40 +0000)]
Apply a large, blunt object directly to the skull of the Leopard build.
Reviewed by Timothy Hatcher.
* Configurations/Base.xcconfig: Disable the generation of debugging symbols when
building the Debug configuration on Leopard. This should cut the size of the object
files that the linker needs to process by over 85%. This will hopefully allow them
to fit in to the 32-bit address space of the Leopard linker.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81050
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 14 Mar 2011 20:30:06 +0000 (20:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56246
Reviewed by Beth Dakin.
Add support for relative positioning to table cells. Back out the code that hacked around the lack of support
for offsetLeft, and add new tests to demonstrate that relative positioning works.
Source/WebCore:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetParent):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRelPositioned):
* rendering/RenderTableCell.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
* fast/table/relative-position-containment.html: Added.
* fast/table/relative-position-offsets.html: Added.
* fast/table/relative-position-stacking.html: Added.
* platform/mac/fast/table/overflowHidden-expected.txt:
* platform/mac/fast/table/relative-position-containment-expected.checksum: Added.
* platform/mac/fast/table/relative-position-containment-expected.png: Added.
* platform/mac/fast/table/relative-position-containment-expected.txt: Added.
* platform/mac/fast/table/relative-position-offsets-expected.checksum: Added.
* platform/mac/fast/table/relative-position-offsets-expected.png: Added.
* platform/mac/fast/table/relative-position-offsets-expected.txt: Added.
* platform/mac/fast/table/relative-position-stacking-expected.checksum: Added.
* platform/mac/fast/table/relative-position-stacking-expected.png: Added.
* platform/mac/fast/table/relative-position-stacking-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81049
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 14 Mar 2011 20:20:00 +0000 (20:20 +0000)]
Partial backout of https://bugs.webkit.org/show_bug.cgi?id=56230. Go back to repainting the root
layer, since first layouts and printing mess up otherwise.
Reviewed by Beth Dakin.
* page/FrameView.cpp:
(WebCore::FrameView::layout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 14 Mar 2011 20:19:02 +0000 (20:19 +0000)]
Improvements for the mondo linux debug failure list changes:
+ Add more tests that belong there.
+ Sort the tests that are there.
+ Add PASS to the lines that are there since these tests are known to pass and a passing
result for them shouldn't cause a test run to go orange.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81047
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Mon, 14 Mar 2011 19:13:38 +0000 (19:13 +0000)]
DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
Reviewed by Dan Bernstein.
* DumpRenderTree/mac/PerlSupport/Makefile:
Add whitespace when joining "-arch" with the architectures passed in as arguments.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81046
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 14 Mar 2011 18:59:52 +0000 (18:59 +0000)]
Clean up full repainting of layers during layout and at other times. Platforms that did not do an invalidation on
size changes were incorrectly relying on the DoFullRepaint case of RenderLayer::updateLayerPositions to invalidate
for them. However this code is now wrong, since it assumed that the outermost layer was a RenderView that encompassed
all of the child layers. This is no longer the case since the overflow changes that tightened up visual overflow
and limited that overflow only to content that the layer painted.
Reviewed by Simon Fraser.
Eliminate the DoFullRepaint flag and actually make no repainting of any kind happen from the layer code if FrameView's
m_doFullRepaint boolean is set. This will flush out any ports that aren't just invalidating the world on their
own in response to view resizes or fixed layout size changes and force them to fix things to be consistent with
the other ports.
Make the two dynamic calls to updateLayerPositions still do a full repaint by setting the repaint flag on the layer.
I'm suspicious as to the correctness of the repainting in both of these cases (both before and after this patch),
but the behavior should be the same.
No new tests, since this is untestable on ports that invalidate on a resize.
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleDidChange):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::removeOnlyThisLayer):
* rendering/RenderLayer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81045
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 14 Mar 2011 18:51:38 +0000 (18:51 +0000)]
Rebaselines due to r81035.
Also, added yet more tests to the linux debug crash sweeping through the layout tests.
* platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-1-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-10-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-10-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-2-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-3-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-3-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-4-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-4-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-5-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-5-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-6-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-6-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-7-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-7-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-8-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-8-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-9-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-add-summary-9-expected.png: Added.
* platform/chromium-linux/fast/html/details-no-summary1-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-no-summary1-expected.png: Added.
* platform/chromium-linux/fast/html/details-no-summary2-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-no-summary2-expected.png: Added.
* platform/chromium-linux/fast/html/details-no-summary3-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-no-summary3-expected.png: Added.
* platform/chromium-linux/fast/html/details-no-summary4-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-no-summary4-expected.png: Added.
* platform/chromium-linux/fast/html/details-open-javascript-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open-javascript-expected.png: Added.
* platform/chromium-linux/fast/html/details-open1-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open1-expected.png: Added.
* platform/chromium-linux/fast/html/details-open2-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open2-expected.png: Added.
* platform/chromium-linux/fast/html/details-open3-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open3-expected.png: Added.
* platform/chromium-linux/fast/html/details-open4-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open4-expected.png: Added.
* platform/chromium-linux/fast/html/details-open5-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open5-expected.png: Added.
* platform/chromium-linux/fast/html/details-open6-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-open6-expected.png: Added.
* platform/chromium-linux/fast/html/details-position-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-position-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-1-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-2-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-3-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-3-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-4-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-4-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-5-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-5-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-6-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-remove-summary-6-expected.png: Added.
* platform/chromium-linux/fast/html/details-writing-mode-expected.checksum: Added.
* platform/chromium-linux/fast/html/details-writing-mode-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-expected.txt: Added.
* platform/chromium-mac/fast/html/details-no-summary1-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-no-summary1-expected.png: Added.
* platform/chromium-mac/fast/html/details-no-summary1-expected.txt: Added.
* platform/chromium-mac/fast/html/details-no-summary2-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-no-summary2-expected.png: Added.
* platform/chromium-mac/fast/html/details-no-summary2-expected.txt: Added.
* platform/chromium-mac/fast/html/details-no-summary3-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-no-summary3-expected.png: Added.
* platform/chromium-mac/fast/html/details-no-summary3-expected.txt: Added.
* platform/chromium-mac/fast/html/details-no-summary4-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-no-summary4-expected.png: Added.
* platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open-javascript-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open-javascript-expected.png: Added.
* platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open1-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open1-expected.png: Added.
* platform/chromium-mac/fast/html/details-open1-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open2-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open2-expected.png: Added.
* platform/chromium-mac/fast/html/details-open2-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open3-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open3-expected.png: Added.
* platform/chromium-mac/fast/html/details-open3-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open4-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open4-expected.png: Added.
* platform/chromium-mac/fast/html/details-open4-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open5-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open5-expected.png: Added.
* platform/chromium-mac/fast/html/details-open5-expected.txt: Added.
* platform/chromium-mac/fast/html/details-open6-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-open6-expected.png: Added.
* platform/chromium-mac/fast/html/details-open6-expected.txt: Added.
* platform/chromium-mac/fast/html/details-position-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-position-expected.png: Added.
* platform/chromium-mac/fast/html/details-position-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt: Added.
* platform/chromium-mac/fast/html/details-writing-mode-expected.checksum: Added.
* platform/chromium-mac/fast/html/details-writing-mode-expected.png: Added.
* platform/chromium-mac/fast/html/details-writing-mode-expected.txt: Added.
* platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-1-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-1-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-10-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-10-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-10-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-2-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-2-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-3-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-3-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-3-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-4-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-4-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-4-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-5-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-5-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-5-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-6-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-6-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-6-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-7-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-7-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-7-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-8-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-8-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-8-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-add-summary-9-expected.checksum: Added.
* platform/chromium-win/fast/html/details-add-summary-9-expected.png: Added.
* platform/chromium-win/fast/html/details-add-summary-9-expected.txt: Added.
* platform/chromium-win/fast/html/details-no-summary1-expected.checksum: Added.
* platform/chromium-win/fast/html/details-no-summary1-expected.png: Added.
* platform/chromium-win/fast/html/details-no-summary1-expected.txt: Added.
* platform/chromium-win/fast/html/details-no-summary2-expected.checksum: Added.
* platform/chromium-win/fast/html/details-no-summary2-expected.png: Added.
* platform/chromium-win/fast/html/details-no-summary2-expected.txt: Added.
* platform/chromium-win/fast/html/details-no-summary3-expected.checksum: Added.
* platform/chromium-win/fast/html/details-no-summary3-expected.png: Added.
* platform/chromium-win/fast/html/details-no-summary3-expected.txt: Added.
* platform/chromium-win/fast/html/details-no-summary4-expected.checksum: Added.
* platform/chromium-win/fast/html/details-no-summary4-expected.png: Added.
* platform/chromium-win/fast/html/details-no-summary4-expected.txt: Added.
* platform/chromium-win/fast/html/details-open-javascript-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open-javascript-expected.png: Added.
* platform/chromium-win/fast/html/details-open-javascript-expected.txt: Added.
* platform/chromium-win/fast/html/details-open1-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open1-expected.png: Added.
* platform/chromium-win/fast/html/details-open1-expected.txt: Added.
* platform/chromium-win/fast/html/details-open2-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open2-expected.png: Added.
* platform/chromium-win/fast/html/details-open2-expected.txt: Added.
* platform/chromium-win/fast/html/details-open3-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open3-expected.png: Added.
* platform/chromium-win/fast/html/details-open3-expected.txt: Added.
* platform/chromium-win/fast/html/details-open4-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open4-expected.png: Added.
* platform/chromium-win/fast/html/details-open4-expected.txt: Added.
* platform/chromium-win/fast/html/details-open5-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open5-expected.png: Added.
* platform/chromium-win/fast/html/details-open5-expected.txt: Added.
* platform/chromium-win/fast/html/details-open6-expected.checksum: Added.
* platform/chromium-win/fast/html/details-open6-expected.png: Added.
* platform/chromium-win/fast/html/details-open6-expected.txt: Added.
* platform/chromium-win/fast/html/details-position-expected.checksum: Added.
* platform/chromium-win/fast/html/details-position-expected.png: Added.
* platform/chromium-win/fast/html/details-position-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-1-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-2-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-2-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-2-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-3-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-3-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-3-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-4-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-4-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-4-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-5-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-5-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-5-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
* platform/chromium-win/fast/html/details-remove-summary-6-expected.checksum: Added.
* platform/chromium-win/fast/html/details-remove-summary-6-expected.png: Added.
* platform/chromium-win/fast/html/details-remove-summary-6-expected.txt: Added.
* platform/chromium-win/fast/html/details-writing-mode-expected.checksum: Added.
* platform/chromium-win/fast/html/details-writing-mode-expected.png: Added.
* platform/chromium-win/fast/html/details-writing-mode-expected.txt: Added.
* platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 14 Mar 2011 18:39:40 +0000 (18:39 +0000)]
Fix windows build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Mon, 14 Mar 2011 18:38:38 +0000 (18:38 +0000)]
2011-03-14 Daniel Bates <dbates@rim.com>
https://bugs.webkit.org/show_bug.cgi?id=55438
Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Mon, 14 Mar 2011 18:23:24 +0000 (18:23 +0000)]
2011-03-14 Daniel Bates <dbates@rim.com>
Reviewed by David Kilzer.
Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
https://bugs.webkit.org/show_bug.cgi?id=55438
Separate out the EFL- and WinCE-specific logic from the port-independent logic in
webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
CMake arguments for feature defines.
* Scripts/build-webkit:
- Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
- Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
- Sorted forward declarations.
- Initialize $makeArgs with the empty string so as to simplify its use in string operations;
Modified call sites as needed.
* Scripts/webkitdirs.pm:
- Added cleanCMakeGeneratedProject() to clean a CMake build.
- Added buildCMakeGeneratedProject() to build using generated build system.
- Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
- Added generateBuildSystemFromCMakeProject() to generate the build system from
a CMake project.
- Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81041
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 14 Mar 2011 18:16:36 +0000 (18:16 +0000)]
2011-03-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214
This patch makes sure that all JSCell pointers written to
the registerfile are correctly tagged as JSCells, and replaces
raw int usage with the immediate representation.
For performance, register pressure, and general saneness reasons
I've added abstractions for reading and writing the tag
and payload of integer registers directly for the JSVALUE64
encoding.
* interpreter/Register.h:
(JSC::Register::withInt):
(JSC::Register::withCallee):
(JSC::Register::operator=):
(JSC::Register::i):
(JSC::Register::activation):
(JSC::Register::function):
(JSC::Register::propertyNameIterator):
(JSC::Register::scopeChain):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITInlineMethods.h:
(JSC::JIT::emitPutToCallFrameHeader):
(JSC::JIT::emitPutCellToCallFrameHeader):
(JSC::JIT::emitPutIntToCallFrameHeader):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emit_op_load_varargs):
(JSC::JIT::emitSlow_op_load_varargs):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_next_pname):
* jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::intPayloadFor):
(JSC::JSInterfaceJIT::intTagFor):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):
2011-03-11 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Ensure all values are correctly tagged in the registerfile
https://bugs.webkit.org/show_bug.cgi?id=56214
Make sure everything builds still.
* bridge/c/c_class.cpp:
* bridge/c/c_runtime.cpp:
* bridge/jni/JavaMethod.cpp:
* plugins/PluginViewNone.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81040
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Mon, 14 Mar 2011 18:02:39 +0000 (18:02 +0000)]
Unreviewed build fix for r81035.
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::defaultEventHandler):
* rendering/RenderDetailsMarker.cpp:
(WebCore::createDownArrowPath):
(WebCore::createUpArrowPath):
(WebCore::createLeftArrowPath):
(WebCore::createRightArrowPath):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Mon, 14 Mar 2011 17:52:31 +0000 (17:52 +0000)]
2011-03-12 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
FullScreen: Handle entering full screen security restrictions
https://bugs.webkit.org/show_bug.cgi?id=56264
* fullscreen/full-screen-css.html: Use runWithKeyDown.
* fullscreen/full-screen-remove-ancestor.html: Ditto.
* fullscreen/full-screen-remove.html: Ditto.
* fullscreen/full-screen-request.html: Ditto.
* fullscreen/full-screen-twice.html: Ditto.
* fullscreen/full-screen-test.js:
* fullscreen/full-screen-iframe-allowed-expected.txt: Added.
* fullscreen/full-screen-iframe-allowed.html: Added.
* fullscreen/full-screen-iframe-not-allowed-expected.txt: Added.
* fullscreen/full-screen-iframe-not-allowed.html: Added.
(runWithKeyDown): Added. Wraps the command in a keyDown/keyPress
listener.
* platform/mac-wk2/Skipped: Added new tests to skipped list.
* platform/qt-wk2/Skipped: Ditto.
2011-03-13 Jer Noble <jer.noble@apple.com>
FullScreen: Handle entering full screen security restrictions
https://bugs.webkit.org/show_bug.cgi?id=56264
Tests: fullscreen/full-screen-iframe-allowed.html
fullscreen/full-screen-iframe-not-allowed.html
Disable full screen documents in the following conditions:
1) requesting element is in an iframe which does not have a
webkitallowfullscreen attribute.
2) page is not processing a user gesture.
* dom/Document.cpp:
(WebCore::Document::fullScreenIsAllowedForElement): Added. Checks
to see if elements contained in IFRAMES are allowed to
enter full screen.
(WebCore::Document::webkitRequestFullScreenForElement): Checks
if page is currently processing a user gesture.
* dom/Document.h:
* html/HTMLAttributeNames.in: Added webkitallowfullscreenAttr.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::allowFullScreen): Added.
* html/HTMLFrameElementBase.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Mon, 14 Mar 2011 17:46:29 +0000 (17:46 +0000)]
REGRESSION(r80892): Use of uninitialized variable "m_syncCloseDatabase" in StorageAreaSync::sync
https://bugs.webkit.org/show_bug.cgi?id=56303
Patch by Anton D'Auria <adauria@apple.com> on 2011-03-14
Reviewed by David Levin.
Initialized m_syncCloseDatabase to false in the StorageAreaSync constructor.
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::StorageAreaSync):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Mon, 14 Mar 2011 17:39:12 +0000 (17:39 +0000)]
2011-03-14 Steve Block <steveblock@google.com>
Reviewed by Oliver Hunt.
JavaMethod.cpp does not compile with V8
https://bugs.webkit.org/show_bug.cgi?id=56306
Moved the ScopeChain.h include to JavaStringJSC.
No new tests, build fix only.
* bridge/jni/JavaMethod.cpp:
* bridge/jni/jsc/JavaStringJSC.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
luiz@webkit.org [Mon, 14 Mar 2011 17:35:17 +0000 (17:35 +0000)]
HTML5 <details> and <summary>: rendering
https://bugs.webkit.org/show_bug.cgi?id=51071
Reviewed by Dave Hyatt.
Source/WebCore:
Tests: fast/html/details-add-summary-1-and-click.html
fast/html/details-add-summary-1.html
fast/html/details-add-summary-10-and-click.html
fast/html/details-add-summary-10.html
fast/html/details-add-summary-2-and-click.html
fast/html/details-add-summary-2.html
fast/html/details-add-summary-3-and-click.html
fast/html/details-add-summary-3.html
fast/html/details-add-summary-4-and-click.html
fast/html/details-add-summary-4.html
fast/html/details-add-summary-5-and-click.html
fast/html/details-add-summary-5.html
fast/html/details-add-summary-6-and-click.html
fast/html/details-add-summary-6.html
fast/html/details-add-summary-7-and-click.html
fast/html/details-add-summary-7.html
fast/html/details-add-summary-8-and-click.html
fast/html/details-add-summary-8.html
fast/html/details-add-summary-9-and-click.html
fast/html/details-add-summary-9.html
fast/html/details-mouse-click.html
fast/html/details-no-summary1.html
fast/html/details-no-summary2.html
fast/html/details-no-summary3.html
fast/html/details-no-summary4.html
fast/html/details-open-javascript.html
fast/html/details-open1.html
fast/html/details-open2.html
fast/html/details-open3.html
fast/html/details-open4.html
fast/html/details-open5.html
fast/html/details-open6.html
fast/html/details-position.html
fast/html/details-remove-summary-1-and-click.html
fast/html/details-remove-summary-1.html
fast/html/details-remove-summary-2-and-click.html
fast/html/details-remove-summary-2.html
fast/html/details-remove-summary-3-and-click.html
fast/html/details-remove-summary-3.html
fast/html/details-remove-summary-4-and-click.html
fast/html/details-remove-summary-4.html
fast/html/details-remove-summary-5-and-click.html
fast/html/details-remove-summary-5.html
fast/html/details-remove-summary-6-and-click.html
fast/html/details-remove-summary-6.html
fast/html/details-writing-mode.html
http://www.w3.org/TR/html5/interactive-elements.html#the-details-element
The main <summary> element is the first <summary> element of a <details> element.
All other childs of the <details> element are rendered only if the attribute 'open' is set.
Click event toggles the 'open' attribute.
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::HTMLDetailsElement):
(WebCore::HTMLDetailsElement::findMainSummary):
(WebCore::HTMLDetailsElement::childrenChanged):
(WebCore::HTMLDetailsElement::finishParsingChildren):
(WebCore::HTMLDetailsElement::parseMappedAttribute):
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
(WebCore::HTMLDetailsElement::defaultEventHandler):
* html/HTMLDetailsElement.h:
(WebCore::HTMLDetailsElement::mainSummary):
Method createRenderer added to class HTMLSummaryElement.
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createRenderer):
* html/HTMLSummaryElement.h:
The first <summary> element is positioned at the top of its <details> parent.
The area occupied by this main <summary> element is the interactive area of the
<details> element. If the <details> tag has no <summary> child an OwnedSummaryRenderer
is created and added to the corresponding RenderDetails object.
* rendering/RenderDetails.cpp:
(WebCore::RenderDetails::RenderDetails):
(WebCore::RenderDetails::destroy):
(WebCore::RenderDetails::summaryBlock):
(WebCore::RenderDetails::contentBlock):
(WebCore::RenderDetails::addChild):
(WebCore::RenderDetails::removeChild):
(WebCore::RenderDetails::setMarkerStyle):
(WebCore::RenderDetails::styleDidChange):
(WebCore::RenderDetails::getRenderPosition):
(WebCore::RenderDetails::markerDestroyed):
(WebCore::RenderDetails::summaryDestroyed):
(WebCore::RenderDetails::moveSummaryToContents):
(WebCore::RenderDetails::createSummaryStyle):
(WebCore::RenderDetails::replaceMainSummary):
(WebCore::RenderDetails::createDefaultSummary):
(WebCore::RenderDetails::checkMainSummary):
(WebCore::RenderDetails::layout):
(WebCore::RenderDetails::isOpen):
(WebCore::RenderDetails::getParentOfFirstLineBox):
(WebCore::RenderDetails::firstNonMarkerChild):
(WebCore::RenderDetails::updateMarkerLocation):
* rendering/RenderDetails.h:
(WebCore::RenderDetails::interactiveArea):
(WebCore::RenderDetails::removeLeftoverAnonymousBlock):
(WebCore::RenderDetails::createsAnonymousWrapper):
(WebCore::RenderDetails::requiresForcedStyleRecalcPropagation):
A marker is added to the main <summary> element to indicate the current value of the 'open'
attribute of the <details> element.
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::RenderDetailsMarker):
(WebCore::RenderDetailsMarker::destroy):
(WebCore::RenderDetailsMarker::lineHeight):
(WebCore::RenderDetailsMarker::baselinePosition):
(WebCore::RenderDetailsMarker::computePreferredLogicalWidths):
(WebCore::RenderDetailsMarker::layout):
(WebCore::RenderDetailsMarker::getRelativeMarkerRect):
(WebCore::RenderDetailsMarker::isOpen):
(WebCore::createPath):
(WebCore::createDownArrowPath):
(WebCore::createUpArrowPath):
(WebCore::createLeftArrowPath):
(WebCore::createRightArrowPath):
(WebCore::RenderDetailsMarker::orientation):
(WebCore::RenderDetailsMarker::getCanonicalPath):
(WebCore::RenderDetailsMarker::getPath):
(WebCore::RenderDetailsMarker::paint):
* rendering/RenderDetailsMarker.h:
(WebCore::toRenderDetailsMarker):
* rendering/RenderSummary.cpp:
(WebCore::RenderSummary::RenderSummary):
(WebCore::RenderSummary::destroy):
(WebCore::RenderSummary::parentDetails):
(WebCore::RenderSummary::styleDidChange):
* rendering/RenderSummary.h:
* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
LayoutTests:
* fast/html/details-add-summary-1-and-click.html: Added.
* fast/html/details-add-summary-1.html: Added.
* fast/html/details-add-summary-10-and-click.html: Added.
* fast/html/details-add-summary-10.html: Added.
* fast/html/details-add-summary-2-and-click.html: Added.
* fast/html/details-add-summary-2.html: Added.
* fast/html/details-add-summary-3-and-click.html: Added.
* fast/html/details-add-summary-3.html: Added.
* fast/html/details-add-summary-4-and-click.html: Added.
* fast/html/details-add-summary-4.html: Added.
* fast/html/details-add-summary-5-and-click.html: Added.
* fast/html/details-add-summary-5.html: Added.
* fast/html/details-add-summary-6-and-click.html: Added.
* fast/html/details-add-summary-6.html: Added.
* fast/html/details-add-summary-7-and-click.html: Added.
* fast/html/details-add-summary-7.html: Added.
* fast/html/details-add-summary-8-and-click.html: Added.
* fast/html/details-add-summary-8.html: Added.
* fast/html/details-add-summary-9-and-click.html: Added.
* fast/html/details-add-summary-9.html: Added.
* fast/html/details-mouse-click-expected.txt: Added.
* fast/html/details-mouse-click.html: Added.
* fast/html/details-no-summary1.html: Added.
* fast/html/details-no-summary2.html: Added.
* fast/html/details-no-summary3.html: Added.
* fast/html/details-no-summary4.html: Added.
* fast/html/details-open-javascript.html: Added.
* fast/html/details-open1.html: Added.
* fast/html/details-open2.html: Added.
* fast/html/details-open3.html: Added.
* fast/html/details-open4.html: Added.
* fast/html/details-open5.html: Added.
* fast/html/details-open6.html: Added.
* fast/html/details-position.html: Added.
* fast/html/details-remove-summary-1-and-click.html: Added.
* fast/html/details-remove-summary-1.html: Added.
* fast/html/details-remove-summary-2-and-click.html: Added.
* fast/html/details-remove-summary-2.html: Added.
* fast/html/details-remove-summary-3-and-click.html: Added.
* fast/html/details-remove-summary-3.html: Added.
* fast/html/details-remove-summary-4-and-click.html: Added.
* fast/html/details-remove-summary-4.html: Added.
* fast/html/details-remove-summary-5-and-click.html: Added.
* fast/html/details-remove-summary-5.html: Added.
* fast/html/details-remove-summary-6-and-click.html: Added.
* fast/html/details-remove-summary-6.html: Added.
* fast/html/details-writing-mode.html: Added.
* platform/qt/fast/html/details-add-summary-1-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-1-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-10-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-10-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-2-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-2-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-3-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-3-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-4-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-4-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-5-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-5-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-6-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-6-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-7-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-7-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-8-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-8-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-9-and-click-expected.txt: Added.
* platform/qt/fast/html/details-add-summary-9-expected.txt: Added.
* platform/qt/fast/html/details-no-summary1-expected.txt: Added.
* platform/qt/fast/html/details-no-summary2-expected.txt: Added.
* platform/qt/fast/html/details-no-summary3-expected.txt: Added.
* platform/qt/fast/html/details-no-summary4-expected.txt: Added.
* platform/qt/fast/html/details-open-javascript-expected.txt: Added.
* platform/qt/fast/html/details-open1-expected.txt: Added.
* platform/qt/fast/html/details-open2-expected.txt: Added.
* platform/qt/fast/html/details-open3-expected.txt: Added.
* platform/qt/fast/html/details-open4-expected.txt: Added.
* platform/qt/fast/html/details-open5-expected.txt: Added.
* platform/qt/fast/html/details-open6-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-1-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-2-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-3-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-4-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-5-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
* platform/qt/fast/html/details-remove-summary-6-expected.txt: Added.
* platform/qt/fast/html/details-writing-mode-expected.txt: Added.
* platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc