WebKit-https.git
10 years agoWeb Inspector: sometimes ReceiveResponse event is attached to wrong parent.
loislo@chromium.org [Fri, 22 Jul 2011 15:19:14 +0000 (15:19 +0000)]
Web Inspector: sometimes ReceiveResponse event is attached to wrong parent.
https://bugs.webkit.org/show_bug.cgi?id=65016

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/timeline/timeline-receive-response-event.html

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::appendRecord):
* inspector/InspectorTimelineAgent.h:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):

LayoutTests:

* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.dump):
* inspector/timeline/resources/anImage.png: Added.
* inspector/timeline/resources/anotherImage.png: Added.
* inspector/timeline/timeline-receive-response-event-expected.txt: Added.
* inspector/timeline/timeline-receive-response-event.html: Added.
* platform/chromium/inspector/timeline/timeline-receive-response-event-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r89535): Form reset does not repaint a file upload control.
commit-queue@webkit.org [Fri, 22 Jul 2011 13:40:59 +0000 (13:40 +0000)]
REGRESSION(r89535): Form reset does not repaint a file upload control.
https://bugs.webkit.org/show_bug.cgi?id=65008

Patch by Kentaro Hara <haraken@google.com> on 2011-07-22
Reviewed by Kent Tamura.

Source/WebCore:

This patch fixes the code so that the file upload control is repainted
in updateFromElement() if no files are selected.

Tests: fast/forms/file-input-reset.html

* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::updateFromElement): Calls repaint() if no files are selected.

LayoutTests:

This patch fixes the code so that the file upload control is repainted
in updateFromElement() if no files are selected. The added test checks
if the label next to the file chooser button becomes "No file chosen"
when we press the reset button.

* fast/forms/file-input-reset-expected.html: Added.
* fast/forms/file-input-reset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: the max depth of the Timeline events' stack trace should be customizable.
loislo@chromium.org [Fri, 22 Jul 2011 13:38:02 +0000 (13:38 +0000)]
Web Inspector: the max depth of the Timeline events' stack trace should be customizable.
https://bugs.webkit.org/show_bug.cgi?id=65023

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::startTimelineProfiler):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
* inspector/TimelineRecordFactory.h:
* inspector/front-end/TimelineManager.js:
(WebInspector.TimelineManager.prototype.start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Adjust test expectations.
jknotten@chromium.org [Fri, 22 Jul 2011 10:53:24 +0000 (10:53 +0000)]
[Chromium] Adjust test expectations.
https://bugs.webkit.org/show_bug.cgi?id=65020

Create WebKit bug for slow/timing out layout tests:
editing/execCommand/4786404-1.html and
editing/execCommand/break-out-of-empty-list-item.html

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rolled DEPS.
rniwa@webkit.org [Fri, 22 Jul 2011 09:59:07 +0000 (09:59 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r91024.
loislo@chromium.org [Fri, 22 Jul 2011 08:48:41 +0000 (08:48 +0000)]
Unreviewed, rolling out r91024.
http://trac.webkit.org/changeset/91024
https://bugs.webkit.org/show_bug.cgi?id=65017

number of problems happened with invisible elements which grab
pointer events. (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-22

* inspector/front-end/inspector.css:
(.panel):
(.panel.visible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother Chromium rebaselines after r91493.
rniwa@webkit.org [Fri, 22 Jul 2011 08:34:20 +0000 (08:34 +0000)]
Another Chromium rebaselines after r91493.

* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Removed.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Removed.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert r91510 due to Chromium debug test failures.
rniwa@webkit.org [Fri, 22 Jul 2011 07:30:27 +0000 (07:30 +0000)]
Revert r91510 due to Chromium debug test failures.

* src/WebKit.cpp:
(WebKit::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReviewed by Darin Adler.
jpu@apple.com [Fri, 22 Jul 2011 07:16:47 +0000 (07:16 +0000)]
Reviewed by Darin Adler.

[Mac] Need to make sure autocorrection panel is dismissed in Document::setFocusNode().
https://bugs.webkit.org/show_bug.cgi?id=64824
<rdar://problem/9624232>

* editing/Editor.cpp:
(WebCore::Editor::textFieldDidEndEditing): Dismiss autocorrection panel when current node losing focus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix
barraclough@apple.com [Fri, 22 Jul 2011 06:55:41 +0000 (06:55 +0000)]
Windows build fix

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix after r91555.
rniwa@webkit.org [Fri, 22 Jul 2011 06:28:14 +0000 (06:28 +0000)]
Build fix after r91555.

* JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoA trivial fix for r91550.
tkent@chromium.org [Fri, 22 Jul 2011 05:35:38 +0000 (05:35 +0000)]
A trivial fix for r91550.
https://bugs.webkit.org/show_bug.cgi?id=65001

Source/WebCore:

Need to update placeholder visibility when the owner elemnent style is changed.

* html/HTMLTextFormControlElement.h: Make updatePlaceholderVisibility() public.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::styleDidChange):
Call updatePlaceholderVisibility().

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=19271
barraclough@apple.com [Fri, 22 Jul 2011 05:34:08 +0000 (05:34 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=19271
eliminate PIC branches by changing NaN handling in JSValue::toNumber

Reviewed by Sam Weinig.

Moving the non-numeric cases out of line seems to be a consistent
win on SunSpider for me, to the order of about 0.5%.

* runtime/JSCell.h:
(JSC::JSCell::JSValue::toNumber):
    - Changed to only handle values that are already numbers, moce non-numeric cases out of line.
* runtime/JSValue.cpp:
(JSC::JSValue::toNumberSlowCase):
    - Added toNumberSlowCase, handling non-numeric cases.
* runtime/JSValue.h:
    - Add declaration of toNumberSlowCase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=65002
psolanki@apple.com [Fri, 22 Jul 2011 05:27:03 +0000 (05:27 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=65002
Get authentication to work with USE(CFNETWORK) on Mac

Reviewed by David Kilzer.

Instead of creating a new CFURLAuthChallengeRef, we save and reuse the same object as the
one given to us by CFNetwork.

* platform/network/mac/AuthenticationMac.mm:
(-[WebCoreAuthenticationClientAsChallengeSender setCFChallenge:]): Accessor methods for the
new CFURLAuthChallengeRef ivar.
(-[WebCoreAuthenticationClientAsChallengeSender cfChallenge]):
(WebCore::core): Create AuthenticationChallenge using the saved CFURLAuthChallengeRef.
(WebCore::mac): Use the CFURLAuthChallengeRef object in AuthenticationChallenge instead of
creating a new one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=64875
barraclough@apple.com [Fri, 22 Jul 2011 05:24:24 +0000 (05:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=64875
Use of `yield` keyword is broken

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* parser/Lexer.cpp:
(JSC::Lexer::parseIdentifier):
    - The bug here is that a successful match of a RESERVED_IF_STRICT token from
      parseKeyword is being nullified back to IDENT. The problem is that in the
      case of IDENT matches parseKeyword should not move the lexer's input
      position, but in the case of RESERVED_IF_STRICT it has done so.

LayoutTests:

* fast/js/reserved-words-as-property-expected.txt:
* fast/js/script-tests/reserved-words-as-property.js:
    - Make this test more comprehensive, to cover future-reserved & non-reserved words.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a failing expectation for fast/forms/placeholder-in-invisible-elements.html
rniwa@webkit.org [Fri, 22 Jul 2011 05:06:33 +0000 (05:06 +0000)]
Add a failing expectation for fast/forms/placeholder-in-invisible-elements.html
added by r91550 on Chromium. The failure is tracked by the bug 65010.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove wrong test expectation added in r91490.
rniwa@webkit.org [Fri, 22 Jul 2011 04:55:34 +0000 (04:55 +0000)]
Remove wrong test expectation added in r91490.

Also add failing test expectation for scrollbar-drag-thumb-with-large-content.html, tracked by the bug 65009.

* platform/chromium-win-xp/fast/events/offsetX-offsetY-expected.txt: Removed.
* platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r90971): Placeholder and search cancel button are visible even in elements...
tkent@chromium.org [Fri, 22 Jul 2011 03:31:27 +0000 (03:31 +0000)]
REGRESSION(r90971): Placeholder and search cancel button are visible even in elements with visibility:hidden.
https://bugs.webkit.org/show_bug.cgi?id=65001

Reviewed by Dimitri Glazkov.

Source/WebCore:

Tests: fast/forms/placeholder-in-invisible-elements.html
       fast/forms/search-cancel-in-invisible-elements.html

* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Don't show the placeholder if the 'visibility' property of the owner element is 'hidden.'
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton): ditto.

LayoutTests:

* fast/forms/placeholder-in-invisible-elements-expected.html: Added.
* fast/forms/placeholder-in-invisible-elements.html: Added.
* fast/forms/search-cancel-in-invisible-elements-expected.html: Added.
* fast/forms/search-cancel-in-invisible-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThe input[type="number"] with step="any" should not suffer from step mismatch.
commit-queue@webkit.org [Fri, 22 Jul 2011 03:27:30 +0000 (03:27 +0000)]
The input[type="number"] with step="any" should not suffer from step mismatch.
https://bugs.webkit.org/show_bug.cgi?id=64858

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-07-21
Reviewed by Kent Tamura.

Source/WebCore:

Added check step="any" not to suffer from step mismatch.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::applyStep): Added check step="any".
(WebCore::HTMLInputElement::alignValueForStep): Added.

LayoutTests:

Added test cases of input[type="number"] with step="any"

* fast/forms/input-stepup-stepdown-expected.txt: added the test cases.
* fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto.
* fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: ditto.
* fast/forms/script-tests/input-stepup-stepdown.js: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Refactoring] ShadowContentSelector should be ShadowInclusionSelector
morrita@google.com [Fri, 22 Jul 2011 03:12:43 +0000 (03:12 +0000)]
[Refactoring] ShadowContentSelector should be ShadowInclusionSelector
https://bugs.webkit.org/show_bug.cgi?id=64850

Reviewed by Dimitri Glazkov.

Renamed:
- ShadowContentSelector -> ShadowInclusionSelector
- ShadowContentSelector::findInclusionFor -> ShadowInclusionSelector::findFor
- ShadowContentSelector::selectInclusion -> ShadowInclusionSelector::select
- ShadowContentSelector::unselectInclusion -> ShadowInclusionSelector::unselect
- ShadowContentSelector::didSelectInclusion -> ShadowInclusionSelector::didSelect
- ShadowContentSelector::willSelectInclusionOver -> ShadowInclusionSelector::willSelectOver
- ShadowContentSelector::hasChildren -> ShadowInclusionSelector::hasCandidates

No new tests. Just a textual change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/NodeRenderingContext.cpp:
* dom/ShadowContentElement.cpp:
(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):
* dom/ShadowInclusionSelector.cpp: Renamed from Source/WebCore/dom/ShadowContentSelector.cpp.
(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ShadowInclusionSelector::ShadowInclusionSelector):
(WebCore::ShadowInclusionSelector::~ShadowInclusionSelector):
(WebCore::ShadowInclusionSelector::select):
(WebCore::ShadowInclusionSelector::unselect):
(WebCore::ShadowInclusionSelector::findFor):
(WebCore::ShadowInclusionSelector::didSelect):
(WebCore::ShadowInclusionSelector::willSelectOver):
* dom/ShadowInclusionSelector.h: Renamed from Source/WebCore/dom/ShadowContentSelector.h.
(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):
(WebCore::ShadowInclusionSelector::hasCandidates):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):
* dom/ShadowRoot.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=60737
commit-queue@webkit.org [Fri, 22 Jul 2011 03:00:52 +0000 (03:00 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=60737

ThumbPosition() in ScrollbarTheme should be ceiled before returned.
Otherwise, some topest/leftest content can not be shown by dragging
scrollbar thumb.

Source/WebCore:

Patch by Robin Qiu <robin.qiu.dev@gmail.com> on 2011-07-21
Reviewed by Antonio Gomes.

Test: scrollbars/scrollbar-drag-thumb-with-large-content.html

* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::thumbPosition):
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarThemeQt::thumbPosition):

LayoutTests:

Patch by Robin Qiu <robin.qiu.dev@gmail.com> on 2011-07-21
Reviewed by Antonio Gomes.

* scrollbars/scrollbar-drag-thumb-with-large-content-expected.txt: Added.
* scrollbars/scrollbar-drag-thumb-with-large-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix typo in TestFailures
aroben@apple.com [Fri, 22 Jul 2011 02:46:49 +0000 (02:46 +0000)]
Fix typo in TestFailures

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium test expectation update after r91533.
rniwa@webkit.org [Fri, 22 Jul 2011 01:34:48 +0000 (01:34 +0000)]
Chromium test expectation update after r91533.
fast/css/absolute-child-with-percent-height-inside-relative-parent.html is missing a pixel result.
A patch to add the pixel result has been uploaded to the bug 64046.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGraphicsLayers in subframes can get sync'd multiple times
simon.fraser@apple.com [Fri, 22 Jul 2011 01:02:35 +0000 (01:02 +0000)]
GraphicsLayers in subframes can get sync'd multiple times
https://bugs.webkit.org/show_bug.cgi?id=52489

Reviewed by James Robinson.

Avoid doing a 'syncCompositingState' pass on the GraphicsLayers
for subframes, when those GraphicsLayers are rooted in the
parent document.

* page/FrameView.cpp:
(WebCore::FrameView::syncCompositingStateForThisFrame): Add a parameter
that contains the rootmost frame on which sync was called. This is used
to indicate to the compositor whether it's the root of the sync.
(WebCore::FrameView::syncCompositingStateIncludingSubframes): Pass the current
Frame in.
(WebCore::FrameView::paintContents): The sync is for this frame, so pass m_frame.
* page/FrameView.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges): New parameter
to specify whether this compositor is in the rootmost Frame being flushed.
We can avoid doing work if we know that flushing some ancestor frame would
have also traversed our GraphicsLayers.
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::isFlushingLayers): Make this private, since
callers are probably most intersted in enclosingCompositorFlushingLayers().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agosimplify gtest display now that we strip modifiers from the JSON
ojan@chromium.org [Fri, 22 Jul 2011 00:48:07 +0000 (00:48 +0000)]
simplify gtest display now that we strip modifiers from the JSON
https://bugs.webkit.org/show_bug.cgi?id=64990

Reviewed by Adam Barth.

Now that names are normalized, we can remove all the code that
handles gtest name changes (e.g. for adding modifiers like DISABLED_).
Instead, if you try to list a test with a modifier in it, we need
to strip the modifier so we get the normalized value.

We also get rid of the concept of extra/missing expectations for gtests.
In a patch soon, we'll stop showing extra/missing expectations from the UI
entirely and only leave it for the special updating test_expectations.txt
view of the dashboard, which doesn't apply to gtests.

* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLocal files cannot load icons.
commit-queue@webkit.org [Fri, 22 Jul 2011 00:40:30 +0000 (00:40 +0000)]
Local files cannot load icons.
https://bugs.webkit.org/show_bug.cgi?id=62459

Previous policy only allowed favicons for pages whose protocol was part of HTTP family.
Changed that to allow to any url that's not empty and whose protocol is not "about".
Also added this check where it attempts to start loading the favicon, so it can avoid
wasting time downloading a resource that won't be stored and won't be used.

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-07-21
Reviewed by Adam Barth.

Test: manual-tests/resources/favicon-loads-for-local-files.html

* loader/icon/IconController.cpp:
(WebCore::IconController::startLoader): Added check to avoid to request a favicon
when there's no way to store it.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::documentCanHaveIcon): Renamed function "pageCanHaveIcon"
to reflect better which url we're handling.

(WebCore::IconDatabase::synchronousIconForPageURL): Ditto.
(WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
(WebCore::IconDatabase::retainIconForPageURL): Ditto.
(WebCore::IconDatabase::releaseIconForPageURL): Ditto.
(WebCore::IconDatabase::setIconURLForPageURL): Ditto.
(WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
(WebCore::IconDatabase::importIconURLForPageURL): Ditto.
(WebCore::IconDatabase::performURLImport): Ditto.
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::documentCanHaveIcon): Added it as virtual to replace its
default behavior of not allowing favicons when we have IconDatabase enabled.

* manual-tests/resources/favicon-loads-for-local-files.html: Added.
* manual-tests/resources/favicon.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactor Trac.js for use in garden-o-matic
abarth@webkit.org [Fri, 22 Jul 2011 00:29:31 +0000 (00:29 +0000)]
Refactor Trac.js for use in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=64998

Reviewed by Adam Roben.

This patch refactors Trac.js to match the architecture and style of
garden-o-matic.  I've also factored AsynchronousCache out of Trac (and
moved it to base) because it was redundant with some other code we
already had.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
(FailingTestsBugForm):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder.start):
(ViewController.prototype._displayBuilder):
(ViewController.prototype._domForRegressionRange.trac.getCommitDataForRevisionRange):
(ViewController.prototype._domForRegressionRange):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Fix for bug 64046 - Wrong image height in absolutely positioned div in
commit-queue@webkit.org [Fri, 22 Jul 2011 00:14:42 +0000 (00:14 +0000)]
Source/WebCore: Fix for bug 64046 - Wrong image height in absolutely positioned div in
relatively positioned parent with bottom padding.
https://bugs.webkit.org/show_bug.cgi?id=64046

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-07-21
Reviewed by David Hyatt.

Test: fast/css/absolute-child-with-percent-height-inside-relative-parent.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::availableLogicalHeightUsing):

LayoutTests: Test to cover absolutely positioned child with percentage height
in relatively positioned parent with bottom padding.
https://bugs.webkit.org/show_bug.cgi?id=64046

Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2011-07-21
Reviewed by David Hyatt.

* fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
* fast/css/absolute-child-with-percent-height-inside-relative-parent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChangelog fix for 91496
mdelaney@apple.com [Fri, 22 Jul 2011 00:00:47 +0000 (00:00 +0000)]
Changelog fix for 91496

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoExtend the protector of a CSS style sheet. Because checkLoaded() can recursively...
gavinp@chromium.org [Thu, 21 Jul 2011 23:53:30 +0000 (23:53 +0000)]
Extend the protector of a CSS style sheet.  Because checkLoaded() can recursively delete
parent style elements, the protector should be extended to include the parent call.

https://bugs.webkit.org/show_bug.cgi?id=64736

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/css-imports-2.html

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::checkLoaded):

LayoutTests:

* fast/css/css-imports-2-expected.txt: Added.
* fast/css/css-imports-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTemporarily add failing test expectation for multi column tests after r91497.
rniwa@webkit.org [Thu, 21 Jul 2011 23:29:00 +0000 (23:29 +0000)]
Temporarily add failing test expectation for multi column tests after r91497.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix issue throwing a 500 to the bots. We were modifying
ojan@chromium.org [Thu, 21 Jul 2011 23:28:06 +0000 (23:28 +0000)]
Fix issue throwing a 500 to the bots. We were modifying
the dictionary during an iteration over it's keys and would get
RuntimeError: dictionary changed size during iteration

* TestResultServer/model/jsonresults.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium test expectation update for svg/W3C-SVG-1.1-SE/color-prop-05-t.svg.
rniwa@webkit.org [Thu, 21 Jul 2011 23:21:42 +0000 (23:21 +0000)]
Chromium test expectation update for svg/W3C-SVG-1.1-SE/color-prop-05-t.svg.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoORWT fails to consume some NRWT arguments
abarth@webkit.org [Thu, 21 Jul 2011 22:57:01 +0000 (22:57 +0000)]
ORWT fails to consume some NRWT arguments
https://bugs.webkit.org/show_bug.cgi?id=64988

Reviewed by Adam Roben.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement spinbutton support in RenderThemeSafari.
jberlin@webkit.org [Thu, 21 Jul 2011 22:34:56 +0000 (22:34 +0000)]
Implement spinbutton support in RenderThemeSafari.
https://bugs.webkit.org/show_bug.cgi?id=54662

Yet another spinbutton test ...

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMerge TestFailures and garden-o-matic unit tests harness
abarth@webkit.org [Thu, 21 Jul 2011 22:31:55 +0000 (22:31 +0000)]
Merge TestFailures and garden-o-matic unit tests harness
https://bugs.webkit.org/show_bug.cgi?id=64984

Reviewed by Adam Roben.

One unit testing framework is better than two.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement spinbutton support in RenderThemeSafari.
jberlin@webkit.org [Thu, 21 Jul 2011 22:22:32 +0000 (22:22 +0000)]
Implement spinbutton support in RenderThemeSafari.
https://bugs.webkit.org/show_bug.cgi?id=54662

Add another spinbutton test to the Skipped list to get the bots green.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Adam Roben.
abarth@webkit.org [Thu, 21 Jul 2011 22:20:44 +0000 (22:20 +0000)]
Rubber-stamped by Adam Roben.

Move garden-o-matic files into the same directory as TestFailures to
make it easier to integrate the codebases.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/config.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js.
* Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
* Scripts/webkitpy/tool/commands/gardenomatic.py:
* Scripts/webkitpy/tool/servers/data/gardeningserver: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Removed.
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Removed.
* Scripts/webkitpy/tool/servers/gardeningserver.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agofix links on the flakiness dashboard
ojan@chromium.org [Thu, 21 Jul 2011 22:13:33 +0000 (22:13 +0000)]
fix links on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=64832

Reviewed by Tony Chang.

Make them actual anchor tags and linkify the test name instead of
adding an extra link. Also simplify the update view since we now
show the linkified test name.

* TestResultServer/static-dashboards/flakiness_dashboard.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkit.org builders should upload results to test-results AppEngine instance
abarth@webkit.org [Thu, 21 Jul 2011 22:09:03 +0000 (22:09 +0000)]
webkit.org builders should upload results to test-results AppEngine instance
https://bugs.webkit.org/show_bug.cgi?id=64979

Reviewed by Adam Roben.

The master just needs to pass some flags to NRWT.  This patch also lets
ORWT consume the flags (ignoring them) so we can pass the flags
unconditionally.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonormalize gtest names in the result json
ojan@chromium.org [Thu, 21 Jul 2011 22:02:54 +0000 (22:02 +0000)]
normalize gtest names in the result json
https://bugs.webkit.org/show_bug.cgi?id=64971

Reviewed by Eric Seidel.

This will make the resulting JSON smaller and make the
flakiness dashboard much more sane (e.g. we won't need to
show you the FLAKY_ version and the normal version).

* TestResultServer/model/jsonresults.py:
* TestResultServer/model/jsonresults_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-07-20 Cris Neckar <cdn@chromium.org>
cdn@chromium.org [Thu, 21 Jul 2011 21:53:12 +0000 (21:53 +0000)]
2011-07-20  Cris Neckar  <cdn@chromium.org>

        Hook v8 up to cryptographicallyRandomValues as an entropy source.
        https://bugs.webkit.org/show_bug.cgi?id=64887

        Reviewed by Adam Barth.

        * src/WebKit.cpp:
        (WebKit::generateEntropy):
        (WebKit::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Reenable ORWT for the --leaks bot.
eric@webkit.org [Thu, 21 Jul 2011 21:48:32 +0000 (21:48 +0000)]
Unreviewed.  Reenable ORWT for the --leaks bot.
Something is still wrong with the leaks summarizing
but I'm about to head out on vacation for 2 weeks,
so it's best to just revert back to ORWT until I'm back.

* Scripts/run-webkit-tests:
(usingLeaks):
(useNewRunWebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate webglcontextlost / webglcontextrestored delivery to match spec changes
kbr@google.com [Thu, 21 Jul 2011 21:43:10 +0000 (21:43 +0000)]
Update webglcontextlost / webglcontextrestored delivery to match spec changes
https://bugs.webkit.org/show_bug.cgi?id=58621

Reviewed by James Robinson.

Source/WebCore:

Updated conditions under which webglcontextrestored event is
delivered to be spec compliant.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::loseContext):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
* html/canvas/WebGLRenderingContext.h:

LayoutTests:

Updated layout test to test spec compliant behavior.

* fast/canvas/webgl/context-lost-restored-expected.txt:
* fast/canvas/webgl/context-lost-restored.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium rebaselines after r91493.
rniwa@webkit.org [Thu, 21 Jul 2011 21:21:17 +0000 (21:21 +0000)]
Chromium rebaselines after r91493.

* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
* platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
* platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
* platform/chromium-win-xp/svg/W3C-SVG-1.1-SE: Added.
* platform/chromium-win-xp/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=64975
hyatt@apple.com [Thu, 21 Jul 2011 21:16:02 +0000 (21:16 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=64975
Elements that have columns (e.g., column-width or column-count non-auto) and elements that have
column-spans establish block formatting contexts, and therefore they should not be allowing
child margins to collapse with their own margins.

Reviewed by Beth Dakin.

Covered by existing tests.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd fast path for ImageBuffer::draw
mdelaney@apple.com [Thu, 21 Jul 2011 20:49:38 +0000 (20:49 +0000)]
Add fast path for ImageBuffer::draw
https://bugs.webkit.org/show_bug.cgi?id=64535

Reviewed by Simon Fraser.

No new tests. This patch doesn't change behavior; current tests are sufficient.

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage): Moved the main method version next to wrapper versions.

* platform/graphics/ImageBuffer.h:
1) Added BackingStoreCopy enum for choosing to copy backing store or not in copyImage().
2) Added copyNativeImage() behind USE(CG) - same as copyImage() but gives NativeImagePtr.
* platform/graphics/cg/ImageBufferCG.cpp: Added new methods described above.

* platform/graphics/GraphicsContext.h: Adding drawNativeImage() for fast draw path.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage): Added. Draws a nativeImagePtr into context.

* platform/graphics/Image.h: Added imageWithColorSpace behind CG platform ifdef
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw): Refactored out actual image drawing code into GraphicsContext,
so that it can be used by more than just BitmapImage without having to copy code.
(WebCore::Image::imageWithColorSpace): Made into an Image class function.

Updated copyImage() to for BackingStoreCopy:
* platform/graphics/qt/ImageBufferQt.cpp
* platform/graphics/filters/FETile.cpp
* platform/graphics/cairo/ImageBufferCairo.cpp
* platform/graphics/skia/ImageBufferSkia.cpp
* platform/graphics/wx/ImageBufferWx.cpp
* platform/graphics/wince/ImageBufferWinCE.cpp
* svg/SVGFEImageElement.cpp
* svg/graphics/SVGImage.cpp
* html/HTMLCanvasElement.cpp
* html/canvas/WebGLRenderingContext.cpp
* rendering/svg/RenderSVGResourcePattern.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium test expectations update after rolling out r91285 and r91332.
rniwa@webkit.org [Thu, 21 Jul 2011 20:31:39 +0000 (20:31 +0000)]
Chromium test expectations update after rolling out r91285 and r91332.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/64972> Clean up generated HTMLEntityTable.cpp output
ddkilzer@apple.com [Thu, 21 Jul 2011 20:23:41 +0000 (20:23 +0000)]
<webkit.org/b/64972> Clean up generated HTMLEntityTable.cpp output

Reviewed by Eric Seidel.

* html/parser/create-html-entity-table:
- Fix duplicate "EntityName" suffix on local variables (changes
  fooSemicolonEntityNameEntityName to fooSemicolonEntityName)
  for all 2138 symbols.
- Add newlines to make source file human-readable (as originally
  intended).
- Add static (const) keywords to local variables that are never
  referenced externally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-07-21 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Thu, 21 Jul 2011 20:12:46 +0000 (20:12 +0000)]
2011-07-21  Rob Buis  <rbuis@rim.com>

        Fix SVG Font resources link in W3C SVG 1.1SE tests
        https://bugs.webkit.org/show_bug.cgi?id=64953

        Reviewed by Dirk schulze.

        * platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
        * svg/W3C-SVG-1.1-SE/color-prop-05-t.svg:
        * svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg:
        * svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg:
        * svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg:
        * svg/W3C-SVG-1.1-SE/painting-control-04-f.svg:
        * svg/W3C-SVG-1.1-SE/painting-marker-07-f.svg:
        * svg/W3C-SVG-1.1-SE/struct-use-14-f.svg:
        * svg/W3C-SVG-1.1-SE/styling-css-04-f.svg:
        * svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg:
        * svg/W3C-SVG-1.1-SE/text-intro-02-b.svg:
        * svg/W3C-SVG-1.1-SE/text-intro-05-t.svg:
        * svg/W3C-SVG-1.1-SE/text-intro-09-b.svg:
        * svg/W3C-SVG-1.1-SE/text-tref-03-b.svg:
        * svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCreate a new survey page that showcases form and interactive elements for quick refer...
jonlee@apple.com [Thu, 21 Jul 2011 20:11:41 +0000 (20:11 +0000)]
Create a new survey page that showcases form and interactive elements for quick reference and comparison.
<rdar://problem/9782965>

Rubber-stamped by Maciej Stachowiak.

* projects/forms/image-usemap.png: Added.
* projects/forms/image1.png: Added.
* projects/forms/image10.png: Added.
* projects/forms/image16.png: Added.
* projects/forms/index.html: Update links
* projects/forms/survey.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocleanup jsonresults.py style in preparation for making some changes
ojan@chromium.org [Thu, 21 Jul 2011 19:45:46 +0000 (19:45 +0000)]
cleanup jsonresults.py style in preparation for making some changes
https://bugs.webkit.org/show_bug.cgi?id=64968

Reviewed by Adam Barth.

No code changes. Unittest still passes. Mostly just removing
useless comments and 80 character wrapping.

* TestResultServer/model/jsonresults.py:
* TestResultServer/model/jsonresults_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore Chromium rebaselines for r91474.
rniwa@webkit.org [Thu, 21 Jul 2011 19:30:32 +0000 (19:30 +0000)]
More Chromium rebaselines for r91474.

* platform/chromium-linux/fast/multicol/float-multicol-expected.png:
* platform/chromium-mac-leopard/fast/multicol/float-multicol-expected.png: Added.
* platform/chromium-mac/fast/multicol/float-multicol-expected.png: Added.
* platform/chromium-win-xp/fast/events: Added.
* platform/chromium-win-xp/fast/events/offsetX-offsetY-expected.txt: Added.
* platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
* platform/chromium-win/fast/multicol/float-multicol-expected.png:
* platform/chromium-win/fast/multicol/float-multicol-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing column header.
abarth@webkit.org [Thu, 21 Jul 2011 19:22:47 +0000 (19:22 +0000)]
Add missing column header.

* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Just fixing (and unittesting) a previous typo.
eric@webkit.org [Thu, 21 Jul 2011 19:15:35 +0000 (19:15 +0000)]
Unreviewed.  Just fixing (and unittesting) a previous typo.

Fix typo in print_leaks_summary regexp which was causing
leaks summarizing to fail on the --leaks bot.

* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic should be able to rebaseline many tests at once
abarth@webkit.org [Thu, 21 Jul 2011 19:14:39 +0000 (19:14 +0000)]
garden-o-matic should be able to rebaseline many tests at once
https://bugs.webkit.org/show_bug.cgi?id=64963

Reviewed by Dimitri Glazkov.

This patch contains some UI for rebaselining tests in bulk.  I don't
expect this UI to be the final UI, but the underlying infrastructure
will be useful.

* Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove LegacyDefaultOptionalArguments flag from FileAPI
commit-queue@webkit.org [Thu, 21 Jul 2011 19:13:47 +0000 (19:13 +0000)]
Remove LegacyDefaultOptionalArguments flag from FileAPI
https://bugs.webkit.org/show_bug.cgi?id=64539

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-07-21
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* fileapi/Blob.idl:
* fileapi/DirectoryEntry.idl:
* fileapi/DirectoryEntrySync.idl:
* fileapi/DirectoryReader.idl:
* fileapi/EntriesCallback.idl:
* fileapi/Entry.idl:
* fileapi/EntryArray.idl:
* fileapi/EntryArraySync.idl:
* fileapi/EntryCallback.idl:
* fileapi/EntrySync.idl:
* fileapi/ErrorCallback.idl:
* fileapi/FileCallback.idl:
* fileapi/FileEntry.idl:
* fileapi/FileList.idl:
* fileapi/FileReader.idl:
* fileapi/FileReaderSync.idl:
* fileapi/FileSystemCallback.idl:
* fileapi/FileWriter.idl:
* fileapi/FileWriterCallback.idl:
* fileapi/FileWriterSync.idl:
* fileapi/MetadataCallback.idl:
* fileapi/WebKitBlobBuilder.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agosort WebCore.xcodeproj
tony@chromium.org [Thu, 21 Jul 2011 19:12:05 +0000 (19:12 +0000)]
sort WebCore.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=64901

Unreviewed, just using sort-Xcode-project-file.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDisable failing new test on mac/win ports
rniwa@webkit.org [Thu, 21 Jul 2011 19:04:16 +0000 (19:04 +0000)]
Disable failing new test on mac/win ports
https://bugs.webkit.org/show_bug.cgi?id=64882

Patch by Scott Graham <scottmg@chromium.org> on 2011-07-21
Reviewed by Ryosuke Niwa.

* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=64900
barraclough@apple.com [Thu, 21 Jul 2011 18:59:38 +0000 (18:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=64900
Function.prototype.apply should accept an array-like object as its second argument

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncApply):
    - Remove the type error if object is not an array.

LayoutTests:

* fast/js/function-apply-expected.txt:
* fast/js/script-tests/function-apply.js:
    - Add a test for array-like objects.
* sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.3_Function.prototype.apply/S15.3.4.3_A6_T1-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.3_Function.prototype.apply/S15.3.4.3_A6_T4-expected.txt:
    - These tests are incorrect & assert ES3 behaviour.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=64964
barraclough@apple.com [Thu, 21 Jul 2011 18:57:57 +0000 (18:57 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=64964
DFG JIT - Enable support for eval code

Reviewed by Sam Weinig.

This is basically the same as program code, to the JIT!

* bytecode/Opcode.cpp:
* bytecode/Opcode.h:
    - Enable opcodeNames in !NDEBUG builds.
* dfg/DFGOperations.cpp:
    - Fix a bug exposed by eval support, throw correct type error for new.
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
    - Enable DFG JIT for eval code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCannot click to position the caret to the right of an image with display:block style.
enrica@apple.com [Thu, 21 Jul 2011 18:45:44 +0000 (18:45 +0000)]
Cannot click to position the caret to the right of an image with display:block style.
https://bugs.webkit.org/show_bug.cgi?id=64962
<rdar://problem/9446343>

Reviewed by David Hyatt.

Source/WebCore:

Test: editing/selection/click-on-block-image.html

The current implementation of positionForPoint always returns the visible
position to the left of the image, if the image has a block style.
This patch changes the behavior for block styled images to match the behavior
for inline images.

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::positionForPoint): Modified to avoid relying entirely
on InlineBox to calculate the position.

LayoutTests:

* editing/selection/click-on-block-image-expected.txt: Added.
* editing/selection/click-on-block-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium rebaseline for r91474.
rniwa@webkit.org [Thu, 21 Jul 2011 18:37:15 +0000 (18:37 +0000)]
Chromium rebaseline for r91474.

* platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
* platform/chromium-linux/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
* platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Removed.
* platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
* platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
* platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Removed.
* platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
* platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png:
* platform/chromium-mac-leopard/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
* platform/chromium-mac/fast/multicol/float-avoidance-expected.png: Added.
* platform/chromium-mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
* platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
* platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
* platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
* platform/chromium-mac/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
* platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
* platform/chromium-mac/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
* platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
* platform/chromium-win/fast/multicol/client-rects-expected.txt:
* platform/chromium-win/fast/multicol/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt:
* platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
* platform/chromium-win/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
* platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
* platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:
* platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agofast/events/offsetX-offsetY.html is failing on the bots.
weinig@apple.com [Thu, 21 Jul 2011 18:34:03 +0000 (18:34 +0000)]
fast/events/offsetX-offsetY.html is failing on the bots.

* fast/events/offsetX-offsetY-expected.txt:
* fast/events/offsetX-offsetY.html:
Update test and result in response to changes to margins in columns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic has trouble when the same test fails in different ways on diffrent...
abarth@webkit.org [Thu, 21 Jul 2011 17:25:41 +0000 (17:25 +0000)]
garden-o-matic has trouble when the same test fails in different ways on diffrent bots
https://bugs.webkit.org/show_bug.cgi?id=64830

Unreviewed.  (Missing the patch is blocking me from fixing the tree.)

This patch is just some minor bug fixes.  One of the bugs results from
the sadness of having two representations (a list and a space-separated
string) for the set of failure types.

* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Mark http/tests/inspector/console-websocket-error.html as timing out.
jknotten@chromium.org [Thu, 21 Jul 2011 16:31:17 +0000 (16:31 +0000)]
[Chromium] Mark http/tests/inspector/console-websocket-error.html as timing out.
https://bugs.webkit.org/show_bug.cgi?id=64957

This test times out on Linux Debug.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-07-21 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 21 Jul 2011 16:28:11 +0000 (16:28 +0000)]
2011-07-21  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: one liner typo fix in Inspector.json.

        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: CSS top margin collapses when paginating
weinig@apple.com [Thu, 21 Jul 2011 16:14:19 +0000 (16:14 +0000)]
Source/WebCore: CSS top margin collapses when paginating
https://bugs.webkit.org/show_bug.cgi?id=64906

Reviewed by David Hyatt.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateLogicalTopPosition):
Update to only go down paginated path when we actually have a page height (so
not in the case that we are just gathering breaks) and to call the version of
of nextPageLogicalTop that actually returns the next page, even if we are at
the boundary point.

(WebCore::RenderBlock::nextPageLogicalTopExcludingBoundaryPoint):
(WebCore::RenderBlock::nextPageLogicalTopIncludingBoundaryPoint):
Split into two functions which differ in how they deal with the boundary condition.

(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
Switch to call nextPageLogicalTopIncludingBoundaryPoint.

* rendering/RenderBlock.h:
Add new functions declarations and comment them.

LayoutTests: CSS top margin collapses when paginating
<rdar://problem/9434990>
https://bugs.webkit.org/show_bug.cgi?id=64906

Reviewed by David Hyatt.

* fast/multicol/client-rects-expected.txt:
* platform/mac/fast/multicol/float-avoidance-expected.txt:
* platform/mac/fast/multicol/float-multicol-expected.txt:
* platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.txt:
* platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt:
Update results now that we take margins into account.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Mark fast/js/function-apply-many-args.html as timing out.
jknotten@chromium.org [Thu, 21 Jul 2011 16:08:46 +0000 (16:08 +0000)]
[Chromium] Mark fast/js/function-apply-many-args.html as timing out.
https://bugs.webkit.org/show_bug.cgi?id=64955

The test is timing out on Mac Debug.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: RuntimeAgent.evaluateOn should not require "return X;" syntax.
pfeldman@chromium.org [Thu, 21 Jul 2011 15:49:30 +0000 (15:49 +0000)]
Web Inspector: RuntimeAgent.evaluateOn should not require "return X;" syntax.
https://bugs.webkit.org/show_bug.cgi?id=64691

Reviewed by Yury Semikhatsky.

Source/WebCore:

I'm introducing callFunctionOn that receives function declaration in order
to make call site syntax clear.

Test: inspector/runtime/runtime-callFunctionOn.html

* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::callFunctionOn):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::callFunctionOn):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode.dimensions):
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
(WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
* inspector/front-end/PropertiesSidebarPane.js:
(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved.protoList):
(WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.callFunction):

LayoutTests:

* inspector/protocol/runtime-agent-expected.txt:
* inspector/protocol/runtime-agent.html:
* inspector/runtime/runtime-callFunctionOn-expected.txt: Added.
* inspector/runtime/runtime-callFunctionOn.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Mark fast/frames/meta-refresh-user-gesture.html as crashy.
jknotten@chromium.org [Thu, 21 Jul 2011 15:39:39 +0000 (15:39 +0000)]
[Chromium] Mark fast/frames/meta-refresh-user-gesture.html as crashy.
https://bugs.webkit.org/show_bug.cgi?id=64952

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Fix test expectations, mark fast/forms/input-file-label.html as crashy.
jknotten@chromium.org [Thu, 21 Jul 2011 15:27:07 +0000 (15:27 +0000)]
[Chromium] Fix test expectations, mark fast/forms/input-file-label.html as crashy.
https://bugs.webkit.org/show_bug.cgi?id=64949

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Adopt existing GraphicsContext3D members (part 1)
commit-queue@webkit.org [Thu, 21 Jul 2011 15:12:07 +0000 (15:12 +0000)]
[Qt] Adopt existing GraphicsContext3D members (part 1)
https://bugs.webkit.org/show_bug.cgi?id=64877

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-07-21
Reviewed by Noam Rosenthal.

Existing WebGL layout tests should test this.

Remove GraphicsContext3DInternal members and use the existing
corresponding members from GraphicsContext3D instead.
Move most of the GraphicsContext3DInternal constructor, destructor
and the reshape() method into GraphicsContext3D.
The GraphicsContext3D members will be needed when we adopt
GraphicsContext3DOpenGL.cpp.

* platform/graphics/GraphicsContext3D.h:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintToTextureMapper):
(WebCore::GraphicsContext3DInternal::boundingRect):
(WebCore::GraphicsContext3DInternal::paint):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getError):
(WebCore::GraphicsContext3D::synthesizeGLError):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::getExtensions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Mark fast/dom/DeviceOrientation/no-synchronous-events.html as crashy.
jknotten@chromium.org [Thu, 21 Jul 2011 15:06:08 +0000 (15:06 +0000)]
[Chromium] Mark fast/dom/DeviceOrientation/no-synchronous-events.html as crashy.
https://bugs.webkit.org/show_bug.cgi?id=64947

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Remove test expectation for fast/speech/input-text-speechbutton.html.
jknotten@chromium.org [Thu, 21 Jul 2011 14:48:41 +0000 (14:48 +0000)]
[Chromium] Remove test expectation for fast/speech/input-text-speechbutton.html.
https://bugs.webkit.org/show_bug.cgi?id=64945

The test was fixed in https://bugs.webkit.org/show_bug.cgi?id=64857.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Mark test fast/flexbox/010.html as flaky (crashy).
jknotten@chromium.org [Thu, 21 Jul 2011 14:37:57 +0000 (14:37 +0000)]
[Chromium] Mark test fast/flexbox/010.html as flaky (crashy).
https://bugs.webkit.org/show_bug.cgi?id=64944

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Mark svg/W3C-SVG-1.1/animate-elem-78-t.svg as flaky (crashy).
jknotten@chromium.org [Thu, 21 Jul 2011 14:18:50 +0000 (14:18 +0000)]
[Chromium] Mark svg/W3C-SVG-1.1/animate-elem-78-t.svg as flaky (crashy).
https://bugs.webkit.org/show_bug.cgi?id=64941

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Mark http/tests/websocket/tests/hybi/reserved-opcodes.html flaky.
jknotten@chromium.org [Thu, 21 Jul 2011 13:48:44 +0000 (13:48 +0000)]
[Chromium] Mark http/tests/websocket/tests/hybi/reserved-opcodes.html flaky.
https://bugs.webkit.org/show_bug.cgi?id=64938

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Code cleanup for drag-and-drop
yael.aharon@nokia.com [Thu, 21 Jul 2011 13:39:34 +0000 (13:39 +0000)]
[Qt][WK2] Code cleanup for drag-and-drop
https://bugs.webkit.org/show_bug.cgi?id=64916

Reviewed by Andreas Kling.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::startDrag):
Allow receiving a NULL bitmap from the web process.

* UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::handleEvent):
Fix typo introduced in http://trac.webkit.org/changeset/90458.
All DnD related events should be GraphicsScene events.

* WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:
(WebKit::convertQPixmapToShareableBitmap):
Remove hack that creates a 1x1 bitmap.
It is no longer needed after http://trac.webkit.org/changeset/91016.

(WebKit::WebDragClient::startDrag):
Allow sending a NULL bitmap to the UI process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Remove windows baseline for fast/speech/input-text-speechbutton.
jknotten@chromium.org [Thu, 21 Jul 2011 13:28:12 +0000 (13:28 +0000)]
[Chromium] Remove windows baseline for fast/speech/input-text-speechbutton.
https://bugs.webkit.org/show_bug.cgi?id=64936

Unreviewed.

* platform/chromium-win/fast/speech/input-text-speechbutton-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: [protocol] extend setBreakpointByUrl request to accept incomplete...
pfeldman@chromium.org [Thu, 21 Jul 2011 12:19:56 +0000 (12:19 +0000)]
Web Inspector: [protocol] extend setBreakpointByUrl request to accept incomplete URL (predicates)
https://bugs.webkit.org/show_bug.cgi?id=60762

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/debugger-set-breakpoint-regex.html

* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::buildObjectForBreakpointCookie):
(WebCore::matches):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:

LayoutTests:

* inspector/debugger/debugger-set-breakpoint-regex-expected.txt: Added.
* inspector/debugger/debugger-set-breakpoint-regex.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r88757): input[type=range] renders incorrectly in RTL context.
tkent@chromium.org [Thu, 21 Jul 2011 11:21:40 +0000 (11:21 +0000)]
REGRESSION(r88757): input[type=range] renders incorrectly in RTL context.
https://bugs.webkit.org/show_bug.cgi?id=64904

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/forms/input-appearance-range-rtl.html

* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderThumb::layout):
The thumb should be positioned based on 'right' CSS property instead of 'left.'
(WebCore::SliderThumbElement::setPositionFromPoint):
The fraction should be flipped in RTL.

LayoutTests:

* fast/forms/input-appearance-range-rtl-expected.html: Added.
* fast/forms/input-appearance-range-rtl.html: Added.
* platform/chromium/test_expectatinos.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening for Qt.
kbalazs@webkit.org [Thu, 21 Jul 2011 10:22:26 +0000 (10:22 +0000)]
Unreviewed gardening for Qt.
Revert http://trac.webkit.org/changeset/91451 and skip the tests
via the Skipped list because the test_expectations way don't work.

* platform/qt/Skipped:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix fast/speech/input-text-speechbutton.html after r91249 .
jeremy@chromium.org [Thu, 21 Jul 2011 10:18:29 +0000 (10:18 +0000)]
Fix fast/speech/input-text-speechbutton.html after r91249 .
https://bugs.webkit.org/show_bug.cgi?id=64857

Reviewed by Kent Tamura.

* fast/speech/input-text-speechbutton.html: Correct mouse coordinates now that the microphone icon can be on the left in RTL..
* platform/chromium/test_expectations.txt: Test no longer times out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Remove networkDataRemoved field from resource.
vsevik@chromium.org [Thu, 21 Jul 2011 10:12:39 +0000 (10:12 +0000)]
Web Inspector: Remove networkDataRemoved field from resource.
https://bugs.webkit.org/show_bug.cgi?id=64749

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._frameNavigated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium DevTools] Remove unused method setAgentIdentifierPrefix from WebDevToolAgent.
vsevik@chromium.org [Thu, 21 Jul 2011 10:06:02 +0000 (10:06 +0000)]
[Chromium DevTools] Remove unused method setAgentIdentifierPrefix from WebDevToolAgent.
https://bugs.webkit.org/show_bug.cgi?id=64793

Reviewed by Pavel Feldman.

* public/WebDevToolsAgent.h:
* src/WebDevToolsAgentImpl.cpp:
* src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMediaStream API: Merging MediaStreamContainer and MediaStreamList
commit-queue@webkit.org [Thu, 21 Jul 2011 10:05:41 +0000 (10:05 +0000)]
MediaStream API: Merging MediaStreamContainer and MediaStreamList
https://bugs.webkit.org/show_bug.cgi?id=64794

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-07-21
Reviewed by Tony Gentilcore.

* GNUmakefile.list.am:
* dom/MediaStreamContainer.h: Removed.
* dom/MediaStreamList.cpp:
(WebCore::MediaStreamList::create):
(WebCore::MediaStreamList::MediaStreamList):
(WebCore::MediaStreamList::length):
(WebCore::MediaStreamList::item):
(WebCore::MediaStreamList::add):
(WebCore::MediaStreamList::remove):
(WebCore::MediaStreamList::contains):
(WebCore::MediaStreamList::get):
* dom/MediaStreamList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: always open dedicated worker inspector in a new window not a new tab
yurys@chromium.org [Thu, 21 Jul 2011 09:51:59 +0000 (09:51 +0000)]
Web Inspector: always open dedicated worker inspector in a new window not a new tab
https://bugs.webkit.org/show_bug.cgi?id=64872

Reviewed by Pavel Feldman.

* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype.openWorkerInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Refactoring] Shadow inclusion cache should be managed by ShadowContentSelector
morrita@google.com [Thu, 21 Jul 2011 09:39:37 +0000 (09:39 +0000)]
[Refactoring] Shadow inclusion cache should be managed by ShadowContentSelector
https://bugs.webkit.org/show_bug.cgi?id=64849

Reviewed by Dimitri Glazkov.

This change is a reorg around Shadow inclusion mechanism.
- Moved definition of ShadowInclusion, ShadowInclusionSet and ShadowInclusionList
  from ShadowContentElement.h to ShadowContentSelector.h, which is included
  from smaller number of places.
- Moved ShadowInclusionSet from ShadowRoot to ShadowContentSelector
- Made ShadowContentSelector's lifetime managed by ShadowRoot
  because ShadowInclusionSet is held by the selector.
- Thus, there is no longer "active" selector (ShadowContentSelector::s_currentInstance)
  Because the selector is associated for each ShadowRoot object.

No new tests. No behavior change.

* dom/NodeRenderingContext.cpp:
* dom/ShadowContentElement.cpp:
(WebCore::ShadowContentElement::ShadowContentElement):
(WebCore::ShadowContentElement::attach):
(WebCore::ShadowContentElement::detach):
* dom/ShadowContentElement.h:
(WebCore::ShadowContentElement::inclusions):
* dom/ShadowContentSelector.cpp:
(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ShadowContentSelector::ShadowContentSelector):
(WebCore::ShadowContentSelector::~ShadowContentSelector):
(WebCore::ShadowContentSelector::selectInclusion):
(WebCore::ShadowContentSelector::unselectInclusion):
(WebCore::ShadowContentSelector::findInclusionFor):
(WebCore::ShadowContentSelector::didSelectInclusion):
(WebCore::ShadowContentSelector::willSelectInclusionOver):
* dom/ShadowContentSelector.h:
(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):
(WebCore::ShadowContentSelector::hasChildren):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::~ShadowRoot):
(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):
* dom/ShadowRoot.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPatch by Rohan McGovern <rohan@mcgovern.id.au> on 2011-07-21
commit-queue@webkit.org [Thu, 21 Jul 2011 09:29:23 +0000 (09:29 +0000)]
Patch by Rohan McGovern <rohan@mcgovern.id.au> on 2011-07-21
Reviewed by Noam Rosenthal.

[Qt] Qt5 Build Fix: remove useless use of qRound(int)
https://bugs.webkit.org/show_bug.cgi?id=64907

Rounding an integer doesn't make sense.
Since 2dcd3939a8bd5ff743e4c87f87b2d81b1a101467 in qtbase, this is not
permitted to compile.

No new tests needed.

* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData): Eliminate qRound(int).
* platform/qt/PlatformScreenQt.cpp:
(WebCore::screenDepthPerComponent): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening for Qt.
kbalazs@webkit.org [Thu, 21 Jul 2011 09:27:02 +0000 (09:27 +0000)]
Unreviewed gardening for Qt.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=64927 and https://bugs.webkit.org/show_bug.cgi?id=64928

* platform/qt/test_expectations.txt:
Mark inspector/styles/css-live-edit.html as TIMEOUT.
Mark inspector/syles/get-set-stylesheet-text.html as PASS or TIMEOUT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] [WebKit API] Implement WebCore::defaultDetailsSummaryText()
rniwa@webkit.org [Thu, 21 Jul 2011 08:15:21 +0000 (08:15 +0000)]
[Chromium] [WebKit API] Implement WebCore::defaultDetailsSummaryText()
https://bugs.webkit.org/show_bug.cgi?id=63700

Remove failing test expectations from fast/html/details-*.html
since localization strings have been updated in Chromium side.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rolled DEPS.
rniwa@webkit.org [Thu, 21 Jul 2011 07:26:42 +0000 (07:26 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuildbot marks a nrwt bot red when tests are missing results
rniwa@webkit.org [Thu, 21 Jul 2011 06:53:59 +0000 (06:53 +0000)]
Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812

Reviewed by Adam Barth.

The bug was caused by multiple expressions matching on the single output.
Fixed it by exiting the loop as soon as one expression matches.

Because the regular expression for 'failures' is most general,
moved it to the end of the list to avoid it catching other cases.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a Valgrind failure caused by r91435.
rniwa@webkit.org [Thu, 21 Jul 2011 06:22:59 +0000 (06:22 +0000)]
Fix a Valgrind failure caused by r91435.

* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::ScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r91332.
commit-queue@webkit.org [Thu, 21 Jul 2011 05:56:42 +0000 (05:56 +0000)]
Unreviewed, rolling out r91332.
http://trac.webkit.org/changeset/91332
https://bugs.webkit.org/show_bug.cgi?id=64925

Crashes css3/images/optimize-contrast-canvas.html on safari-
mac,chromium-mac (Requested by mikelawther on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-20

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::makePresentationCopy):
(WebCore::HTMLCanvasElement::copiedImage):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::videoFrameToImage):
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
* platform/graphics/GraphicsContext.h:
* platform/graphics/Image.h:
* platform/graphics/ImageBuffer.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::copyImage):
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::cgImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::imageWithColorSpace):
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
* platform/graphics/filters/FETile.cpp:
(WebCore::FETile::apply):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyImage):
* platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImageForCurrentFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSVG feature status is not up-to-date
leo.yang@torchmobile.com.cn [Thu, 21 Jul 2011 05:49:22 +0000 (05:49 +0000)]
SVG feature status is not up-to-date
https://bugs.webkit.org/show_bug.cgi?id=64856

Patch by Leo Yang <leo.yang@torchmobile.com.cn> on 2011-07-20
Reviewed by Dirk Schulze.

Update SVG feature status after r91331.

* projects/svg/status.xml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r91380.
rniwa@webkit.org [Thu, 21 Jul 2011 05:04:49 +0000 (05:04 +0000)]
Unreviewed, rolling out r91380.
http://trac.webkit.org/changeset/91380
https://bugs.webkit.org/show_bug.cgi?id=64924

Caused assertion failures in Chromium's IndexedDB tests
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-20

* wtf/ThreadIdentifierDataPthreads.cpp:
(WTF::ThreadIdentifierData::identifier):
(WTF::ThreadIdentifierData::initialize):
(WTF::ThreadIdentifierData::initializeKeyOnceHelper):
(WTF::ThreadIdentifierData::initializeKeyOnce):
* wtf/ThreadIdentifierDataPthreads.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd crash expectation to fast/canvas/webgl/renderbuffer-initialization.html on Chromi...
rniwa@webkit.org [Thu, 21 Jul 2011 03:15:33 +0000 (03:15 +0000)]
Add crash expectation to fast/canvas/webgl/renderbuffer-initialization.html on Chromium Windows,
tracked by the bug 64920.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium build fix after r91440.
rniwa@webkit.org [Thu, 21 Jul 2011 03:04:41 +0000 (03:04 +0000)]
Chromium build fix after r91440.

* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::ScrollbarThemeChromiumMac::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@91442 268f45cc-cd09-0410-ab3c-d52691b4dbfc