WebKit-https.git
15 years agoAdd missing include for auto_ptr
staikos [Sun, 20 May 2007 17:45:02 +0000 (17:45 +0000)]
Add missing include for auto_ptr

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-20 David Kilzer <ddkilzer@webkit.org>
ddkilzer [Sun, 20 May 2007 14:12:06 +0000 (14:12 +0000)]
2007-05-20  David Kilzer  <ddkilzer@webkit.org>

        Reviewed by Adam Roben.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13565
          Change svn-create-patch to put LayoutTests in the end

        In addition to reordering test files under the LayoutTests directory so that they
        appear after source code files, this patch fixes an issue with prepare-ChangeLog
        if the first argument passed to it is a file name instead of a directory name.

        * Scripts/prepare-ChangeLog:
        (isGIT()): If first value in @dirs array is a file, use dirname() to get the directory.
        (isSVN()): Ditto.
        * Scripts/svn-create-patch:
        (generateFileList($\%\%\%)): Differentiate test files in the LayoutTests directory from
        source code files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 13785, O(n^2) counter creation.
hyatt [Sun, 20 May 2007 00:20:32 +0000 (00:20 +0000)]
    Fix for bug 13785, O(n^2) counter creation.

        Reviewed by darin

        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
        (WebCore::RenderCounter::originalText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-19 Mitz Pettel <mitz@webkit.org>
bdash [Sun, 20 May 2007 00:16:53 +0000 (00:16 +0000)]
2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12729
          box-shadow disappears when scrolling a div that it falls on/under

        Tests: fast/repaint/box-shadow-dynamic.html
               fast/repaint/box-shadow-h.html
               fast/repaint/box-shadow-v.html

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow.
        (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
        (WebCore::InlineFlowBox::paint): Account for box shadow when checking if
        the damage rect intersects.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked
        for the "exterior" overflow, add box shadow overflow.
        (WebCore::RenderBlock::overflowWidth): Ditto.
        (WebCore::RenderBlock::overflowLeft): Ditto.
        (WebCore::RenderBlock::overflowTop): Ditto.
        (WebCore::RenderBlock::overflowRect): Ditto.
        (WebCore::RenderBlock::layoutBlock): Factor box shadow into visual overflow.
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::lowestPosition): For overflow areas, when asked for
        the "exterior" extreme position, add box shadow.
        (WebCore::RenderFlow::rightmostPosition): Ditto.
        (WebCore::RenderFlow::leftmostPosition): Ditto.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateRects): Avoid clipping out box shadow.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Make sure to paint
        the box shadow when an edge with a shadow moves.
        (WebCore::RenderObject::adjustRectForOutlineAndShadow): Helper function
        that expands a given rectangle to encompass outline and box shadow.
        (WebCore::RenderObject::absoluteOutlineBox): Changed to include box shadow.
        * rendering/RenderObject.h:

2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - repaint tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=12729
          box-shadow disappears when scrolling a div that it falls on/under

        * fast/box-shadow/basic-shadows-expected.checksum:
        * fast/box-shadow/basic-shadows-expected.png:
        * fast/box-shadow/basic-shadows-expected.txt:
        * fast/repaint/box-shadow-dynamic-expected.checksum: Added.
        * fast/repaint/box-shadow-dynamic-expected.png: Added.
        * fast/repaint/box-shadow-dynamic-expected.txt: Added.
        * fast/repaint/box-shadow-dynamic.html: Added.
        * fast/repaint/box-shadow-h-expected.checksum: Added.
        * fast/repaint/box-shadow-h-expected.png: Added.
        * fast/repaint/box-shadow-h-expected.txt: Added.
        * fast/repaint/box-shadow-h.html: Added.
        * fast/repaint/box-shadow-v-expected.checksum: Added.
        * fast/repaint/box-shadow-v-expected.png: Added.
        * fast/repaint/box-shadow-v-expected.txt: Added.
        * fast/repaint/box-shadow-v.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-20 Mark Rowe <mrowe@apple.com>
bdash [Sat, 19 May 2007 23:42:28 +0000 (23:42 +0000)]
2007-05-20  Mark Rowe  <mrowe@apple.com>

        Update test results after r21597.

        * fast/frames/viewsource-attribute-expected.checksum:
        * fast/frames/viewsource-attribute-expected.png:
        * fast/frames/viewsource-attribute-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-19 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 19 May 2007 23:11:31 +0000 (23:11 +0000)]
2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13783
          REGRESSION (r21120): Frame resizers not repainted properly when dragged

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-19 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 19 May 2007 23:09:17 +0000 (23:09 +0000)]
2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13774
          REGRESSION: Crash emailing blog entry using Google Reader

        Test: fast/table/stale-grid-crash.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::recalcSections): Made const and replaced
        setNeedsLayout(true) with an assertion that the table is already
        marked for layout.
        (WebCore::RenderTable::sectionAbove): Added call to recalcSectionsIfNeeded().
        (WebCore::RenderTable::sectionBelow): Ditto.
        (WebCore::RenderTable::cellAbove): Ditto.
        (WebCore::RenderTable::cellBelow): Ditto.
        (WebCore::RenderTable::cellBefore): Ditto.
        (WebCore::RenderTable::cellAfter): Ditto.
        * rendering/RenderTable.h:
        Made some private member variables which are used in section recalc mutable.
        (WebCore::RenderTable::setNeedsSectionRecalc): Moved the call to
        setNeedsLayout() from recalcSections() into here, because I made
        recalcSections() const.
        (WebCore::RenderTable::recalcSectionsIfNeeded): Made const.

2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13774
          REGRESSION: Crash emailing blog entry using Google Reader

        * fast/table/stale-grid-crash-expected.checksum: Added.
        * fast/table/stale-grid-crash-expected.png: Added.
        * fast/table/stale-grid-crash-expected.txt: Added.
        * fast/table/stale-grid-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-19 Mitz Pettel <mitz@webkit.org>
bdash [Sat, 19 May 2007 22:54:26 +0000 (22:54 +0000)]
2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13320
          rounded corners with drop shadows are really slow

        Test for a rendering bug fixed by this patch:
            fast/box-shadow/border-radius-big.html

        No test for the performance ingredient.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::addRoundedRectClip): Made cross-platform.
        Changed to use a single clipping path. If all the radii cannot be
        accommodated, clips to a rect.
        (WebCore::GraphicsContext::clipOutRoundedRect): Changed to use a single
        clipping path. If all the radii cannot be accommodated, clips out a rect.
        * platform/graphics/GraphicsContext.h: Added clipOut(const Path&).
        * platform/graphics/Path.cpp:
        (WebCore::Path::createRoundedRectangle): Added. Returns a rounded rectangle
        with the specified radii. If all the radii cannot be accommodated, returns
        a rectangular path.
        * platform/graphics/Path.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::clipOut): Added.
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRoundedRect): Changed to use a single path.
        (WebCore::GraphicsContext::clipOut): Added.
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clipOut): Added.

2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13320
          rounded corners with drop shadows are really slow

        * fast/box-shadow/border-radius-big-expected.checksum: Added.
        * fast/box-shadow/border-radius-big-expected.png: Added.
        * fast/box-shadow/border-radius-big-expected.txt: Added.
        * fast/box-shadow/border-radius-big.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
andersca [Sat, 19 May 2007 13:14:44 +0000 (13:14 +0000)]
LayoutTests:

        Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=13771
        Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester

        * fast/frames/inline-object-inside-frameset-expected.txt: Added.
        * fast/frames/inline-object-inside-frameset.html: Added.

WebCore:

        Reviewed by Mitz.

        Test: fast/frames/inline-object-inside-frameset.html

        http://bugs.webkit.org/show_bug.cgi?id=13771
        Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester

        Don't paint inline objects.

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add support for plain text MIME types (CSS/JS/TXT) to view source mode.
hyatt [Sat, 19 May 2007 07:42:59 +0000 (07:42 +0000)]
    Add support for plain text MIME types (CSS/JS/TXT) to view source mode.
        CSS/JS will eventually tokenize via their own special tokenizers so that
        they can also be syntax-highlighted, but for now just treat them as
        plain text.

        Reviewed by aroben

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        (WebCore::HTMLViewSourceDocument::createTokenizer):
        (WebCore::HTMLViewSourceDocument::createContainingTable):
        (WebCore::HTMLViewSourceDocument::addViewSourceText):
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        * html/HTMLViewSourceDocument.h:
        * loader/TextDocument.cpp:
        (WebCore::TextTokenizer::TextTokenizer):
        (WebCore::TextTokenizer::write):
        * loader/TextDocument.h:
        (WebCore::TextTokenizer::checkBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix a glitch in view source mode attribute names.
hyatt [Sat, 19 May 2007 06:48:50 +0000 (06:48 +0000)]
    Fix a glitch in view source mode attribute names.

        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago "Linkify" view source mode links.
hyatt [Sat, 19 May 2007 05:16:08 +0000 (05:16 +0000)]
    "Linkify" view source mode links.

        Reviewed by andersca

        * css/view-source.css:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
        (WebCore::HTMLViewSourceDocument::addLink):
        * html/HTMLViewSourceDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Oliver Hunt <oliver@apple.com>
oliver [Sat, 19 May 2007 02:05:48 +0000 (02:05 +0000)]
2007-05-18  Oliver Hunt  <oliver@apple.com>

WebCore:

        Reviewed by Sam

        No longer need to pass HTMLImageElement and HTMLImageLoader on to WebKit
        Need to expose CachedResourceClient constructor

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Sam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13782
        REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode

        r21533 made used a DOMElement as the source for promise data, this meant it had to
        clear the dragging pasteboard following the drag.  In DRT a drag is non-blocking
        so this resulted in us prematurely clearing the pasteboard.

        This patch avoids this problem by referencing the source CachedImage rather than the
        DOMElement, so we don't need to worry about retaining an entire document forever, so
        we don't need to clear the dragging pasteboard following the drag.

        * Misc/WebNSPasteboardExtras.mm:
        (imageFromElement):
          Extract the underlying CachedImage from a DOMElement
        (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
          Use a CachedImage instead of a DOMElement

        * WebCoreSupport/WebDragClient.mm:
        (WebDragClient::startDrag):

        * WebKit.xcodeproj/project.pbxproj:

        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLViewPrivate clear]):
        (-[WebHTMLView pasteboardChangedOwner:]):
        (-[WebHTMLView pasteboard:provideDataForType:]):
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
        (-[WebHTMLView WebCore::]):
        (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
          Use CachedImage rather than DOMElement as promised data source

        * WebView/WebHTMLViewInternal.h:
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix more malformed test cases.
hyatt [Fri, 18 May 2007 23:32:59 +0000 (23:32 +0000)]
Fix more malformed test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix more malformed test cases.
hyatt [Fri, 18 May 2007 23:32:13 +0000 (23:32 +0000)]
Fix more malformed test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix more malformed test cases.
hyatt [Fri, 18 May 2007 23:31:14 +0000 (23:31 +0000)]
Fix more malformed test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix more malformed test cases.
hyatt [Fri, 18 May 2007 23:29:09 +0000 (23:29 +0000)]
Fix more malformed test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix more malformed test cases.
hyatt [Fri, 18 May 2007 23:26:03 +0000 (23:26 +0000)]
Fix more malformed test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBeating my head against these malformed http/navigation tests still.
hyatt [Fri, 18 May 2007 23:12:20 +0000 (23:12 +0000)]
Beating my head against these malformed http/navigation tests still.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBeating my head against these malformed http/navigation tests still.
hyatt [Fri, 18 May 2007 23:06:48 +0000 (23:06 +0000)]
Beating my head against these malformed http/navigation tests still.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBeating my head against these malformed http/navigation tests still.
hyatt [Fri, 18 May 2007 23:04:43 +0000 (23:04 +0000)]
Beating my head against these malformed http/navigation tests still.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBeating my head against these malformed http/navigation tests still.
hyatt [Fri, 18 May 2007 23:03:48 +0000 (23:03 +0000)]
Beating my head against these malformed http/navigation tests still.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBeating my head against these malformed http/navigation tests still.
hyatt [Fri, 18 May 2007 23:03:08 +0000 (23:03 +0000)]
Beating my head against these malformed http/navigation tests still.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBeating my head against these malformed http/navigation tests still.
hyatt [Fri, 18 May 2007 23:01:12 +0000 (23:01 +0000)]
Beating my head against these malformed http/navigation tests still.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixing broken http/navigation test cases that were written with malformed HTML.
hyatt [Fri, 18 May 2007 22:50:34 +0000 (22:50 +0000)]
Fixing broken http/navigation test cases that were written with malformed HTML.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixing broken http/navigation test cases that were written with malformed HTML.
hyatt [Fri, 18 May 2007 22:48:51 +0000 (22:48 +0000)]
Fixing broken http/navigation test cases that were written with malformed HTML.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixed potential crash with ASSERT in download due to previous commit.
tristan [Fri, 18 May 2007 22:46:36 +0000 (22:46 +0000)]
Fixed potential crash with ASSERT in download due to previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for <rdar://problem/5214338> REGRESSION: / mishandled in
hyatt [Fri, 18 May 2007 22:44:26 +0000 (22:44 +0000)]
    Fix for <rdar://problem/5214338> REGRESSION: / mishandled in
        HTML tokenization (13780).

        Reviewed by ggaren

        * html/HTMLTokenizer.cpp:
        (WebCore::Token::addAttribute):
        (WebCore::HTMLTokenizer::parseTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdded bugzilla link
beidson [Fri, 18 May 2007 22:40:56 +0000 (22:40 +0000)]
Added bugzilla link

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * WebCoreSupport/WebFrameLoaderClient.mm:
tristan [Fri, 18 May 2007 22:38:46 +0000 (22:38 +0000)]
    * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::download):
        asked the webframeloaderclient for its webview's history and
        injected the originated url into the created WebDownload

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej
beidson [Fri, 18 May 2007 22:38:16 +0000 (22:38 +0000)]
    Reviewed by Maciej

        <rdar://problem/5166149> - window.open() causes server to be hit twice

        This regressed in http://trac.webkit.org/projects/webkit/changeset/14637
        That patch was to fix broken behavior when opening an already existant window.
        The unfortunate side effect was to cause the server to be hit twice.
        Once during the call to frame->loader()->createWindow(), and again via a
        scheduled redirection.

        I decided to restore the original de-facto behavior by making the new window
        open via a scheduled redirection - there is a FIXME that was already here that
        explains the reason why we have to do it this way for now.

        Additionally, there were two distinct places that had their own logic to open
        a new window - the logic for window.open() and the logic for
        window.showModalDialog().  The logic was almost identical so I condensed them
        into one utility function that takes a flag to handle the slight difference.

        A layout test is not possible at this time since it would involve capturing
        server logs (the 1st connection does not exist long enough to result in any
        delegate callbacks).  That task is documented in
        http://bugs.webkit.org/show_bug.cgi?id=13769

        * bindings/js/kjs_window.cpp:
        (KJS::createWindow): Merged the two slightly different versions of "creating a window"
          logic here.  For the modal dialog case the load is an immediate call to changeLocation(),
          which is triggered by the "immediate" flag, and the other cases load via scheduleLocationChange()
        (KJS::showModalDialog): Call createWindow()
        (KJS::WindowFunc::callAsFunction): Handle frame targets of _top or _parent immediately and call
          createWindow() for all others

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Fri, 18 May 2007 21:06:14 +0000 (21:06 +0000)]
LayoutTests:

        Reviewed by Geoff.

        - update results to account for new JSHTMLElements that are being
          auto-generated and can now produce Constructors.

        * fast/dom/Window/element-constructors-on-window-expected.txt:
        * fast/dom/Window/window-properties-expected.txt:

WebCore:

        Reviewed by Geoff.

        Autogenerate the JS bindings for the HTMLTableElement, HTMLTableCaptionElement,
        HTMLTableCellElement, HTMLTableColElement, HTMLTableRowElement, HTMLTableSectionElement.

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        (WebCore::createJSHTMLWrapper):
        * bindings/js/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLElement::classInfo):
        (KJS::JSHTMLElement::accessors):
        (KJS::HTMLElementFunction::callAsFunction):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::):
        * html/HTMLTableCaptionElement.idl:
        * html/HTMLTableCellElement.idl:
        * html/HTMLTableColElement.idl:
        * html/HTMLTableElement.idl:
        * html/HTMLTableRowElement.idl:
        * html/HTMLTableSectionElement.idl:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin Decker
sullivan [Fri, 18 May 2007 20:47:45 +0000 (20:47 +0000)]
    Reviewed by Kevin Decker

        Improvement to WebKit part of fix for 5201499 based on more modern understanding. (That is,
        a couple of hours more modern.)

        * WebView/WebUIDelegatePrivate.h:
        add showPanel: parameter to just-introduced delegate method webView:saveFrameView:

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        pass NO for new showPanel: parameter, and update comment

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John.
mjs [Fri, 18 May 2007 20:33:57 +0000 (20:33 +0000)]
    Reviewed by John.

        <rdar://problem/5204792> REGRESSION (r21367): System widgets are drawn with vertical/horizontal scroll bars

        No test because the bug requires calling setAllowsScrolling: to reproduce.

        * WebView/WebFrameView.mm:
        (-[WebFrameView setAllowsScrolling:]): Update the FrameView's scroll state as well as the one
        on WebDynamicScrollBarsView, otherwise this setting won't stick if the frame has already loaded
        a document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not Reviewed, buildbot test fix.
mjs [Fri, 18 May 2007 20:32:15 +0000 (20:32 +0000)]
    Not Reviewed, buildbot test fix.

        - updated results for the last fiew checkins.

        * fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt:
        * fast/dom/replaceChild-expected.txt:
        * http/tests/loading/bad-scheme-subframe-expected.txt:
        * webarchive/loading/test-loading-archive-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Oliver Hunt <oliver@apple.com>
oliver [Fri, 18 May 2007 19:14:22 +0000 (19:14 +0000)]
2007-05-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Sam.

        Fix for <rdar://problem/5211122> DRT crash below
        SVGTimer::applyAnimations when page cache is enabled
        (SVG animation timers do not properly cancel themselves)

        There were still a few paths in the SVG Animation code
        that could cause timers to be created and used.  This
        patch inserts addition SVG_EXPERIMENTAL blocks to prevent
        these timers from being used.

        * ksvg2/misc/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::startAnimations):
        * ksvg2/misc/SVGTimer.cpp:
        (WebCore::SVGTimer::animationsByElement):
        (WebCore::SVGTimer::applyAnimations):
        (WebCore::SVGTimer::notifyAll):
        (WebCore::SVGTimer::addNotify):
        (WebCore::SVGTimer::removeNotify):
        * ksvg2/misc/TimeScheduler.cpp:
        (WebCore::TimeScheduler::addTimer):
        (WebCore::TimeScheduler::connectIntervalTimer):
        (WebCore::TimeScheduler::disconnectIntervalTimer):
        (WebCore::TimeScheduler::startAnimations):
        (WebCore::TimeScheduler::toggleAnimations):
        (WebCore::TimeScheduler::timerFired):
        * ksvg2/svg/SVGAnimationElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fixed spelling error.
ggaren [Fri, 18 May 2007 18:58:13 +0000 (18:58 +0000)]
    Fixed spelling error.

        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
weinig [Fri, 18 May 2007 17:52:02 +0000 (17:52 +0000)]
    Reviewed by Mitz.

        Update test results after Hyatt's update of view-source
        to include line numbers and a gutter.

        * fast/frames/viewsource-attribute-expected.checksum:
        * fast/frames/viewsource-attribute-expected.png:
        * fast/frames/viewsource-attribute-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin Decker
sullivan [Fri, 18 May 2007 17:05:30 +0000 (17:05 +0000)]
    Reviewed by Kevin Decker

        WebKit part of fix for 5201499 (support for PDFKit UI for saving PDFs to disk)

        Also, the PDFKit mechanism for notifying clients about "Open File Externally" was
        changed from a notification to a delegate method. The notification was new to
        Leopard, so removing it doesn't affect clients in the field.

        * WebView/WebUIDelegatePrivate.h:
        Declared new UI delegate method webView:saveFrameView:, analogous to the existing
        webView:printFrameView:

        * WebView/WebPDFView.mm:
        removed declaration of _webkit_PDFKitLaunchNotification
        (-[WebPDFView viewDidMoveToWindow]):
        don't observe _webkit_PDFKitLaunchNotification
        (-[WebPDFView viewWillMoveToWindow:]):
        ditto
        (-[WebPDFView PDFViewOpenPDFInNativeApplication:]):
        new PDFKit delegate method, replaces our use of _webkit_PDFKitLaunchNotification
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        new PDFKit delegate method, calls through to new WebKit UI delegate method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoPatch from Marius Bugge Monsen to fix clipboard crash.
zack [Fri, 18 May 2007 15:36:18 +0000 (15:36 +0000)]
Patch from Marius Bugge Monsen to fix clipboard crash.

Return a valid pointer to a Clipboard object
from newGeneralClipboard.
r=me

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoChanged the QWebPage::loadProgressChange API to have an integer (percent) argument
hausmann [Fri, 18 May 2007 14:17:52 +0000 (14:17 +0000)]
Changed the QWebPage::loadProgressChange API to have an integer (percent) argument
instead of a double precision float.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoKeyboard event crash fix by Marius Bugge Monsen.
zack [Fri, 18 May 2007 12:11:58 +0000 (12:11 +0000)]
Keyboard event crash fix by Marius Bugge Monsen.

The default constructed KeyboardEvent has
no PlatformKeyboardEvent.
r=me

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Oliver Hunt <oliver@apple.com>
oliver [Fri, 18 May 2007 10:15:05 +0000 (10:15 +0000)]
2007-05-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Mark.

        Fix capitalisation of resources referenced by test case.

        * svg/carto.net/window.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Mark Rowe <mrowe@apple.com>
bdash [Fri, 18 May 2007 09:50:19 +0000 (09:50 +0000)]
2007-05-18  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        Force LC_ALL to C when parsing locale-specific strings in 'svn' output.

        * Scripts/svn-create-patch:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Mark Rowe <mrowe@apple.com>
bdash [Fri, 18 May 2007 09:21:31 +0000 (09:21 +0000)]
2007-05-18  Mark Rowe  <mrowe@apple.com>

        Attempt to fix the Gdk build after r21562.

        * platform/gdk/TemporaryLinkStubs.cpp:
        (Widget::isEnabled):
        * platform/gdk/WidgetGdk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Adam Treat <treat@kde.org>
lars [Fri, 18 May 2007 08:49:00 +0000 (08:49 +0000)]
2007-05-18  Adam Treat <treat@kde.org>

        Reviewed by Lars

        Remove dead code.

        * platform/Widget.h:
        * platform/mac/WidgetMac.mm:
        * platform/qt/WidgetQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Holger Freyther <zecke@selfish.org>
bdash [Fri, 18 May 2007 08:44:11 +0000 (08:44 +0000)]
2007-05-18  Holger Freyther  <zecke@selfish.org>

        Reviewed by Maciej.

        Return true to make loading of pages working again

        * loader/gdk/FrameLoaderClientGdk.cpp:
        (WebCore::FrameLoaderClientGdk::canHandleRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Holger Freyther <zecke@selfish.org>
bdash [Fri, 18 May 2007 08:41:43 +0000 (08:41 +0000)]
2007-05-18  Holger Freyther  <zecke@selfish.org>

        Reviewed by Maciej.

        Make WebCore::Widget use GtkWidget to fix focus handling.

        * WebCore.pro: Add PlatformScrollBar
        * platform/ScrollView.h: Gtk stuff
        * platform/Widget.h: Take a GtkWidget
        * platform/gdk/PlatformScrollBarGdk.cpp: Added.
        (PlatformScrollbar::PlatformScrollbar):
        (PlatformScrollbar::~PlatformScrollbar):
        (PlatformScrollbar::width):
        (PlatformScrollbar::height):
        (PlatformScrollbar::setEnabled):
        (PlatformScrollbar::paint):
        (PlatformScrollbar::updateThumbPosition):
        (PlatformScrollbar::updateThumbProportion):
        (PlatformScrollbar::setRect):
        * platform/gdk/ScreenGdk.cpp: Implement depth handling
        (WebCore::screenDepth):
        * platform/gdk/ScrollViewGdk.cpp: use setGtkWidget, not setDrawable
        (WebCore::ScrollView::setGtkWidget):
        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/gdk/WidgetGdk.cpp:
        (WebCore::Widget::Widget):
        (WebCore::Widget::gtkWidget):
        (WebCore::Widget::setGtkWidget):
        (WebCore::Widget::hasFocus):
        (WebCore::Widget::setFocus):

2007-05-18  Holger Freyther  <zecke@selfish.org>

        Reviewed by Maciej.

        * GdkLauncher/main.cpp: Call setGtkWidget
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Zack
lars [Fri, 18 May 2007 08:38:11 +0000 (08:38 +0000)]
    Reviewed by Zack

        Correctly implement initialiseSupportedImageMIMETypes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>
bdash [Fri, 18 May 2007 08:34:04 +0000 (08:34 +0000)]
2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Maciej.

        Build fix for non-Qt and non-Mac ports.

        * html/HTMLCanvasElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org>
bdash [Fri, 18 May 2007 08:29:58 +0000 (08:29 +0000)]
2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark Rowe.

        No test added as this is hard to time.

        * platform/gdk/FrameGdk.cpp: Use needsLayout() to decide if layout()
        is needed.

        (WebCore::FrameGdk::dumpRenderTree):
        (WebCore::FrameGdk::handleGdkEvent):

2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark Rowe.

        * kjs/testkjs.pro: Make the Gdk port link to icu

2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark Rowe.

        * WebKit.pro: Build testkjs for Gdk and Qt

2007-05-18  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark Rowe.

        * GdkLauncher/main.cpp:
        (main): Call Frame::init to catch up with Maciej's changes.
        * Scripts/run-javascriptcore-tests: Remove --gdk from the command line
        passed to the helper scripts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoGenerate pkgconfig files for the Qt build.
hausmann [Fri, 18 May 2007 07:54:37 +0000 (07:54 +0000)]
Generate pkgconfig files for the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
lars [Fri, 18 May 2007 07:09:43 +0000 (07:09 +0000)]
    Reviewed by Hyatt.

        Remove unused handleMouseEvent methods in the Widget
        and derived classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUse the proper clipping algorithm
staikos [Fri, 18 May 2007 07:00:11 +0000 (07:00 +0000)]
Use the proper clipping algorithm

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by George Staikos.
weinig [Fri, 18 May 2007 06:36:07 +0000 (06:36 +0000)]
    Reviewed by George Staikos.

        Fix Qt build after adding JSHTMLAnchorElementCustom.cpp.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago- patch from Adam Treat to implement frameLoadCompleted()
staikos [Fri, 18 May 2007 06:32:08 +0000 (06:32 +0000)]
- patch from Adam Treat to implement frameLoadCompleted()
- build fix from George Staikos

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix preprocessor logic for CG/QT
staikos [Fri, 18 May 2007 06:08:11 +0000 (06:08 +0000)]
Fix preprocessor logic for CG/QT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplement forceLayoutForNonHTML
staikos [Fri, 18 May 2007 05:32:12 +0000 (05:32 +0000)]
Implement forceLayoutForNonHTML

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplement canShowMIMEType
staikos [Fri, 18 May 2007 05:28:31 +0000 (05:28 +0000)]
Implement canShowMIMEType

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add a line gutter to view source mode. The gutter uses counters, and this...
hyatt [Fri, 18 May 2007 05:07:23 +0000 (05:07 +0000)]
    Add a line gutter to view source mode.  The gutter uses counters, and this exposed the fact
        that pseudoStyleForElement was not walking all UA rules properly.

        Reviewed by aroben

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::pseudoStyleForElement):
        * css/view-source.css:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
        (WebCore::HTMLViewSourceDocument::addLine):
        (WebCore::HTMLViewSourceDocument::addText):
        * html/HTMLViewSourceDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Fri, 18 May 2007 04:17:59 +0000 (04:17 +0000)]
LayoutTests:

        Reviewed by ggaren

        <rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status

        * editing/selection/5209984-expected.txt: Added.
        * editing/selection/5209984.html: Added.

WebCore:

        Reviewed by ggaren

        <rdar://problem/5209984> REGRESSION: Crash on click after clearing Facebook status

        comparePositions() expects non-null positions.  It's
        given a null position by contains() if the current
        selection is a range selection but contains only invisible
        content *and* visible positions cannot be created from its
        end points.  This can happen when there is a range selection
        inside shadow content (like that inside text fields) that
        is made invisible.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::contains): Check for
        invisible end points.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Fri, 18 May 2007 02:50:44 +0000 (02:50 +0000)]
LayoutTests:

        Reviewed by Adam.

        Tests for <rdar://problem/5201423> REGRESSION: Links in
        sidebar don't work on Honda website

        * fast/dom/anchor-toString-expected.txt: Added.
        * fast/dom/anchor-toString.html: Added.
        * fast/forms/focus2.html:

WebCore:

        Reviewed by Adam.

        Fix for <rdar://problem/5201423> REGRESSION: Links in
        sidebar don't work on Honda website

        Anchor elements need to have the same behavior for implicit and
        explicit toString() calls.

        Test: fast/dom/anchor-toString.html

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLAnchorElementCustom.cpp: Added.
        (WebCore::JSHTMLAnchorElement::toString):
        * html/HTMLAnchorElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix.
ggaren [Thu, 17 May 2007 23:38:51 +0000 (23:38 +0000)]
    Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
adele [Thu, 17 May 2007 23:15:37 +0000 (23:15 +0000)]
    Reviewed by Hyatt.

        Update RenderMenuList PopupClient methods to consider style of inner block.

        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::itemStyle):
        (WebCore::RenderMenuList::clientStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not reviewed, emergency test fix.
mjs [Thu, 17 May 2007 22:57:49 +0000 (22:57 +0000)]
    Not reviewed, emergency test fix.

        - avoid crash on layout tests.

        Patched up my last change so that  widgets don't crash.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::mainReceivedCompleteError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
antti [Thu, 17 May 2007 22:25:01 +0000 (22:25 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test for http://bugs.webkit.org/show_bug.cgi?id=13727
        REGRESSION: Reproducible hang setting the selection's extent offset to -1
        <rdar://problem/5206890>

        * LayoutTests/editing/selection/selection-invalid-offset-expected.txt: Added.
        * LayoutTests/editing/selection/selection-invalid-offset.html: Added.

WebCore:

        Reviewed by Darin.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13727
        REGRESSION: Reproducible hang setting the selection's extent offset to -1
        <rdar://problem/5206890>

        Rise INDEX_SIZE_ERR if used selection index is negative. This matches HTML5 for
        getRangeAt() and collapse() which are part of the spec (FF throws NS_ERROR_FAILURE).

        Not throwing exceptions yet for too high offsets (except getRangeAt()) as it is
        unclear if WebCore's definition of offsets is the same as other browsers.

        * bindings/js/kjs_window.cpp:
        * WebCore/editing/SelectionController.cpp:
        * WebCore/editing/SelectionController.h:
        * WebCore/editing/VisiblePosition.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Thu, 17 May 2007 21:42:21 +0000 (21:42 +0000)]
LayoutTests:

        Reviewed by Mitz.

        Test for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

        * fast/text/international/bidi-menulist-expected.checksum: Added.
        * fast/text/international/bidi-menulist-expected.png: Added.
        * fast/text/international/bidi-menulist-expected.txt: Added.
        * fast/text/international/bidi-menulist.html: Added.

WebCore:

        Reviewed by Mitz.

        Fix for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s

        Test: fast/text/international/bidi-menulist.html

        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::adjustInnerStyle): Set the inner block style to direction: ltr, and text-align: left.  This means that
         we will ignore those settings in the button to match the way the text is displayed in the popup menu.
        (WebCore::RenderMenuList::createInnerBlock): Call adjustInnerStyle.
        (WebCore::RenderMenuList::setStyle): ditto.
        * rendering/RenderMenuList.h: Added adjustInnerStyle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoI accidently mucked around with these tests after generating results.
justing [Thu, 17 May 2007 21:16:48 +0000 (21:16 +0000)]
I accidently mucked around with these tests after generating results.
Correcting them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 17 May 2007 21:06:12 +0000 (21:06 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/execCommand/4924441-expected.checksum: Added.
        * editing/execCommand/4924441-expected.png: Added.
        * editing/execCommand/4924441-expected.txt: Added.
        * editing/execCommand/4924441.html: Added.
        * editing/execCommand/5207369-expected.checksum: Added.
        * editing/execCommand/5207369-expected.png: Added.
        * editing/execCommand/5207369-expected.txt: Added.
        * editing/execCommand/5207369.html: Added.
        * editing/execCommand/5210032-expected.checksum: Added.
        * editing/execCommand/5210032-expected.png: Added.
        * editing/execCommand/5210032-expected.txt: Added.
        * editing/execCommand/5210032.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4924441> List becomes nested when changing its type
        <rdar://problem/5210032> Content before a list is placed at the end of the list when its made into a list item
        <rdar://problem/5207369> Crash when removing ordering from a nested list

        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply):
        The outermostEnclosingList of the position before the start isn't
        the previousList if it contains the start.
        Ditto for the position after the end and the nextList.
        If we're putting the newly created list item into the next list,
        insert it at the start of that list, not the end (don't append).
        Avoid nesting newly created lists inside list items.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago<rdar://problem/4775672> AXTextMarkerRangeForUnorderedTextMarkers returns incorrect...
pyeh [Thu, 17 May 2007 18:35:18 +0000 (18:35 +0000)]
<rdar://problem/4775672> AXTextMarkerRangeForUnorderedTextMarkers returns incorrect order

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
        A selection's m_start is not guranteed to equal m_base since m_start can actually be m_base's downstream().
        A more accurate way to determine the order from selection is to ask directly for isBaseFirst().
        In addition, if the two visible positions given are the same position but different affinity, we need to
        handle it here rather than depend on the selection. This is because selection does not retain the
        affinity of both selection start/end visible positions as part of the selection validation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
beidson [Thu, 17 May 2007 17:52:44 +0000 (17:52 +0000)]
LayoutTests:

        Reviewed by Brady

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13759
          REGRESSION (r20182-r20184): Incorrect rendering of multipart images

        Created http/tests/multipart and moved the existing multipart test there.

        * http/tests/misc/multipart-expected.txt: Removed.
        * http/tests/misc/multipart.html: Removed.
        * http/tests/misc/resources/1x1-blue.png: Removed.
        * http/tests/misc/resources/multipart.php: Removed.
        * http/tests/multipart/invalid-image-data-expected.checksum: Added.
        * http/tests/multipart/invalid-image-data-expected.png: Added.
        * http/tests/multipart/invalid-image-data-expected.txt: Added.
        * http/tests/multipart/invalid-image-data.html: Added.
        * http/tests/multipart/resources/2x2-green.png: Added. Shared by both
        multipart tests.
        * http/tests/multipart/resources/abe.png: Added.
        * http/tests/multipart/resources/multipart.php: Added. Shared by both
        multipart tests.
        * http/tests/multipart/stop-crash.html: Renamed from misc/multipart.html.

WebCore:

        Reviewed by Brady

        - fix http://bugs.webkit.org/show_bug.cgi?id=13759
          REGRESSION (r20182-r20184): Incorrect rendering of multipart images

        Test: http/tests/multipart/invalid-image-data.html

        * loader/loader.cpp:
        (WebCore::Loader::didReceiveData): Make a copy of the current part's data
        instead of using the resource data, because the latter is going to be
        overwritten by the new part being received.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-17 Oliver Hunt <oliver@apple.com>
oliver [Thu, 17 May 2007 11:32:11 +0000 (11:32 +0000)]
2007-05-17  Oliver Hunt  <oliver@apple.com>

WebCore:

        Reviewed by Justin.

        Fix for <rdar://problem/4244861> Safari fails to create image file
        after releasing dragged image that has changed on source page

        Tell xcode to copy HTMLImageElement.h and HTMLImageLoader.h headers
        across to WebKit as private headers.

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Justin.

        Fix for <rdar://problem/4244861> Safari fails to create image file
        after releasing dragged image that has changed on source page

        This patch fixes this bug by manually creating an NSFileWrapper from
        the TIFF promise data for a drag if it is available.  This bypasses
        the problem of the required resource no longer being held due to page
        loads or other constraints.

        We need to leave the old path in place to allow for the case where
        the promised data is not available.

        * WebCoreSupport/WebDragClient.mm:
        (WebDragClient::declareAndWriteDragImage):
          Always use the top WebHTMLView as the pasteboard owner, this is
          safe as we only use the owner for resolving promised types.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _writeSelectionToPasteboard:]):
        (-[WebHTMLView writeSelectionToPasteboard:types:]):
          Always use the top WebHTMLView as the pasteboard owner.
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
          Add path to create NSFileWrapper from promise data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Thu, 17 May 2007 10:46:00 +0000 (10:46 +0000)]
LayoutTests:

        Reviewed by harrison

        Demonstrates bug:
        * editing/execCommand/5190926-expected.checksum: Added.
        * editing/execCommand/5190926-expected.png: Added.
        * editing/execCommand/5190926-expected.txt: Added.
        * editing/execCommand/5190926.html: Added.

        Avoided some nesting:
        * editing/execCommand/5142012-2-expected.txt:
        * editing/execCommand/switch-list-type-expected.txt:

WebCore:

        Reviewed by harrison

        <rdar://problem/5190926>
        Gmail Editor: Crash when removing list style from underlined, multi-item list

        The user underlined some text, then created a list.
        The list was placed inside the inline element carrying
        the underline style, so, that element surrounded the
        list instead of being at the lowest level (just above
        text nodes). This kind of markup is more difficult to
        edit. Filed 5192089 and added a workaround so that we
        don't produce this kind of markup.

        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply): Avoid inline
        elements when inserting the new list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-17 Oliver Hunt <oliver@apple.com>
oliver [Thu, 17 May 2007 08:54:18 +0000 (08:54 +0000)]
2007-05-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Fix for <rdar://problem/4343832> Trying to drag a large 6.2MB jpeg image
         out of Safari is unexpectedly slow (4 copies of image plus RTF document on pasteboard)

        This patch causes the construction of the RTF and TIFF data to be delayed until requested.

        We delay TIFF construction from a DOMElement as this may require generating TIFF data
        from the CachedImage, which is slow.  To allow the TIFF data to be created later the
        it's necessary to add a reference to the source DOMElement to the view.

        * Misc/WebNSPasteboardExtras.h:
        * Misc/WebNSPasteboardExtras.mm:
        (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
          Implements the delayed write of RTF data
        (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
          Set up the pasteboard to allow the data writing to be delayed
        (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
          Now we need to pass the WebHTMLView on to _web_writeImage:element:URL:title:archive:types:source:
        * WebCoreSupport/WebDragClient.mm:
        (WebDragClient::startDrag):
          Clear the dragging pasteboard once the drag has ended to ensure we don't hold references
          to anything longer than we need to.
        (WebDragClient::declareAndWriteDragImage):

        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLViewPrivate clear]):
        (-[WebHTMLView pasteboardChangedOwner:]):
          Make sure we clear out the DOMElement reference once it is no longer needed
        (-[WebHTMLView pasteboard:provideDataForType:]):
          Provide delayed data
        (-[WebHTMLView _writeSelectionToPasteboard:]):
          Make sure we set pasteboard ownership correctly
        (-[WebHTMLView promisedDragTIFFDataSource]):
        (-[WebHTMLView setPromisedDragTIFFDataSource:]):
        (-[WebHTMLView writeSelectionToPasteboard:types:]):
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebHTMLViewPrivate.h:

        * WebView/WebView.mm:
        (-[WebView _writeImageForElement:withPasteboardTypes:toPasteboard:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Allow redundant attributes with the same name in view source mode.
hyatt [Thu, 17 May 2007 08:52:21 +0000 (08:52 +0000)]
    Allow redundant attributes with the same name in view source mode.

        Reviewed by aroben

        * dom/NamedAttrMap.h:
        (WebCore::NamedAttrMap::insertAttribute):
        * html/HTMLTokenizer.cpp:
        (WebCore::Token::addAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@21531 268f45cc-cd09-0410...
andersca [Thu, 17 May 2007 08:48:45 +0000 (08:48 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBack out last patch based on discussion with Zack
staikos [Thu, 17 May 2007 08:46:12 +0000 (08:46 +0000)]
Back out last patch based on discussion with Zack

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
andersca [Thu, 17 May 2007 08:38:44 +0000 (08:38 +0000)]
WebCore:

        Reviewed by Darin.

        <rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

        This happens because the form delegate gets passed the wrong source frame during the second submit().
        If a frame with the given name is found, FrameLoader::load is called with the same parameters on the found frame.
        This causes the found frame to be used as the source frame, which is wrong.

        The fix is to create the form state object before checking what frame to load the new request in.

        * WebCore.exp:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::checkNavigationPolicy):
        (WebCore::FrameLoader::continueAfterNavigationPolicy):
        * loader/FrameLoader.h:
        * manual-tests/submit-form-with-target-twice.html: Added.

WebKit:

        Reviewed by Darin.

        <rdar://problem/5207156> Hamachi test tool causes assertion in FormCompletionController in Safari

        Update for WebCore changes.

        * WebView/WebFrame.mm:
        (-[WebFrame _loadURL:referrer:intoChild:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
mjs [Thu, 17 May 2007 06:52:11 +0000 (06:52 +0000)]
    Reviewed by Oliver.

        <rdar://problem/5205914> REGRESSION: PLT stops after loading first page due to r21479

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::frameHasLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdate the lone view source mode layout test.
hyatt [Thu, 17 May 2007 06:28:57 +0000 (06:28 +0000)]
Update the lone view source mode layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Improve the syntax-highlighted view source mode. It now preserves all whites...
hyatt [Thu, 17 May 2007 06:27:28 +0000 (06:27 +0000)]
    Improve the syntax-highlighted view source mode.  It now preserves all whitespace properly
        and highlights doctypes and comments (in addition to all the stuff it could highlight before).

        Reviewed by aroben

        * html/HTMLTokenizer.cpp:
        (WebCore::Token::addAttribute):
        (WebCore::HTMLTokenizer::parseTag):
        * html/HTMLTokenizer.h:
        (WebCore::Token::Token):
        (WebCore::Token::~Token):
        (WebCore::Token::reset):
        (WebCore::Token::addViewSourceChar):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        * html/HTMLViewSourceDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Build fix for some dev configurations
beidson [Thu, 17 May 2007 05:37:13 +0000 (05:37 +0000)]
    Build fix for some dev configurations

        * DumpRenderTree/DumpRenderTree.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
mjs [Thu, 17 May 2007 04:47:17 +0000 (04:47 +0000)]
    Reviewed by Adam.

        <rdar://problem/5191024> Page never loads completely (emonome.vodpod.com)
        <rdar://problem/5205162> REGRESSION (r21367): In the Address URL field, typing a site name doesn't redirect to site after pressing return
        http://bugs.webkit.org/show_bug.cgi?id=13683
        <rdar://problem/5208951> REGRESSION: Progress bar never completes on link click that downloads (13694)
        http://bugs.webkit.org/show_bug.cgi?id=13694
        <rdar://problem/5201598> REGRESSION: After uploading file to iDisk at mac.com, "loading" status remains and file does not appear in the list

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::mainReceivedCompleteError): Make sure to always check whether the overall
        load completed, even if we think the current frame load is already complete.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Thu, 17 May 2007 04:21:52 +0000 (04:21 +0000)]
LayoutTests:

        Reviewed by Justin.

        - added a bunch of layout tests using the new load delegate testing mechanism

        * http/tests/loading/bad-scheme-subframe-expected.txt: Added.
        * http/tests/loading/bad-scheme-subframe.html: Added.
        * http/tests/loading/bad-server-subframe-expected.txt: Added.
        * http/tests/loading/bad-server-subframe.html: Added.
        * http/tests/loading/basic-expected.txt: Added.
        * http/tests/loading/basic.html: Added.
        * http/tests/loading/empty-subframe-expected.txt: Added.
        * http/tests/loading/empty-subframe.html: Added.
        * http/tests/loading/simple-subframe-expected.txt: Added.
        * http/tests/loading/simple-subframe.html: Added.

WebKitTools:

        Reviewed by Justin.

        - created a new mechanism to log FrameLoadDelegate callbacks in directories named "loading"

        The reason for doing things in this slightly odd way is to make sure we don't miss the load delegates
        that happen before the load commits.

        Basically I moved WaitUntilDoneDelegate into a separate file (FrameLoadDelegate.m) and added
        optional logging for every FrameLoadDelegate callback, including SPI callbacks.

        * DumpRenderTree/DumpRenderTree.h:
        * DumpRenderTree/DumpRenderTree.m:
        (createWebView):
        (dumpRenderTree):
        (dump):
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController clearBackForwardList]):
        (-[LayoutTestController setUseDashboardCompatibilityMode:]):
        (-[LayoutTestController dumpFrameLoadCallbacks]):
        (-[LayoutTestController setWindowIsKey:]):
        (-[LayoutTestController setMainFrameIsFirstResponder:]):
        (-[LayoutTestController _doLoad:target:]):
        (-[LayoutTestController _doBackOrForwardNavigation:]):
        (-[LayoutTestController queueReload]):
        (-[LayoutTestController queueScript:]):
        (-[LayoutTestController queueLoad:target:]):
        (-[LayoutTestController setAcceptsEditing:]):
        (-[LayoutTestController setTabKeyCyclesThroughElements:]):
        (shouldLogFrameLoadDelegates):
        (runTest):
        (displayWebView):
        (+[DumpRenderTreeEvent mouseLocation]):
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/DumpRenderTreeDraggingInfo.m:
        (-[DumpRenderTreeDraggingInfo draggingDestinationWindow]):
        * DumpRenderTree/EventSendingController.m:
        (-[EventSendingController mouseDown]):
        (-[EventSendingController mouseUp]):
        (-[EventSendingController mouseMoveToX:Y:]):
        (-[EventSendingController contextClick]):
        * DumpRenderTree/FrameLoadDelegate.h: Added.
        * DumpRenderTree/FrameLoadDelegate.m: Added.
        (-[WebFrame _drt_descriptionSuitableForTestResult]):
        (-[FrameLoadDelegate processWork:]):
        (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
        (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
        (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
        (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
        (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
        (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
        (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
        (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
        (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
        (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
        (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
        (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
        (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
        (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
        (-[FrameLoadDelegate webView:willCloseFrame:]):
        (-[FrameLoadDelegate webView:didFirstLayoutInFrame:]):
        (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
        (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
        * DumpRenderTree/ResourceLoadDelegate.m:
        (-[NSURL _drt_descriptionSuitableForTestResult]):
        * DumpRenderTree/UIDelegate.m:
        (-[UIDelegate webViewFocus:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
bdakin [Wed, 16 May 2007 21:47:31 +0000 (21:47 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Changes for <rdar://problem/5204107> REGRESSION: CSS web forum site
        layout not displaying properly in latest WebKit

        New test:
        * fast/table/tableInsideCaption-expected.checksum: Added.
        * fast/table/tableInsideCaption-expected.png: Added.
        * fast/table/tableInsideCaption-expected.txt: Added.
        * fast/table/tableInsideCaption.html: Added.

        Good changes.
        * tables/mozilla/bugs/bug48028-1-expected.checksum:
        * tables/mozilla/bugs/bug48028-1-expected.png:
        * tables/mozilla/bugs/bug48028-1-expected.txt:
        * tables/mozilla_expected_failures/core/captions1-
        expected.checksum:
        * tables/mozilla_expected_failures/core/captions1-expected.png:
        * tables/mozilla_expected_failures/core/captions1-expected.txt:

        Not great changes. These changes expose other bugs. Filing reports
        for these.
        * tables/mozilla/bugs/bug48028-2-expected.txt:
        * tables/mozilla/bugs/bug55789-expected.checksum:
        * tables/mozilla/bugs/bug55789-expected.png:
        * tables/mozilla/bugs/bug55789-expected.txt:

WebCore:

        Reviewed by Hyatt.

        Fix for <rdar://problem/5204107> REGRESSION: CSS web forum site
        layout not displaying properly in latest WebKit

        Hyatt's http://trac.webkit.org/projects/webkit/changeset/21428
        exposed this bug. We were not handling error cases with <caption>
        correctly. This patch makes them do the same thing as colgroup.

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError):
        * html/HTMLParserErrorCodes.cpp: No need any more for caption-
        specific errors.
        (WebCore::htmlParserErrorMessageTemplate):
        * html/HTMLParserErrorCodes.h:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
kmccullo [Wed, 16 May 2007 20:57:47 +0000 (20:57 +0000)]
LayoutTests:

        Reviewed by Darin and Geoff.

        - rdar://problem/4981886
        - Added tests for allowing JS to close a window that was opened by the DOM.

        * fast/dom/open-and-close-by-DOM-expected.txt: Added.
        * fast/dom/open-and-close-by-DOM.html: Added.
        * fast/dom/resources/close.html: Added.
        * fast/dom/resources/middle.html: Added.

WebCore:

        Reviewed by Darin and Geoff.

        - rdar://problem/4981886
        - Now windows opened by the DOM can be closed by JS.

        * bindings/js/kjs_window.cpp:
        (KJS::createNewWindow):
        (KJS::WindowFunc::callAsFunction):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::openedByDOM):
        (WebCore::FrameLoader::setOpenedByDOM):
        (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
        * loader/FrameLoader.h:

WebKitTools:

        Reviewed by Darin and Geoff.

        - rdar://problem/4981886
        - Now windows opened by the DOM can be closed by JS.

        * DumpRenderTree/DumpRenderTree.m:
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController windowCount]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Wed, 16 May 2007 20:15:51 +0000 (20:15 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for <rdar://problem/4928671> Crash due to runaway recursion when fieldset has display: table-row (12066)

        * fast/css/fieldset-display-row-expected.checksum: Added.
        * fast/css/fieldset-display-row-expected.png: Added.
        * fast/css/fieldset-display-row-expected.txt: Added.
        * fast/css/fieldset-display-row.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix <rdar://problem/4928671> Crash due to runaway recursion when fieldset has display: table-row (12066)

        Test: fast/css/fieldset-display-row.html

        * rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild):
        Change all decision making about special handling for new children to use
        the class of the render object instead of the style, except for the cases
        where the style is the only way to tell (TABLE_COLUMN_GROUP and TABLE_CAPTION).
        Thus a RenderFieldset with table-row style won't get handled as if it was
        a table row.

        * rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Same thing.
        Except that here the styles that we ahave to look at are TABLE_CAPTION,
        TABLE_HEADER_GROUP, TABLE_FOOTER_GROUP, and TABLE_ROW_GROUP.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplement Canvas element in the Qt port.
zack [Wed, 16 May 2007 13:53:52 +0000 (13:53 +0000)]
Implement Canvas element in the Qt port.

Implementation of Context2D was completely missing in the
Qt port. This commit adds bigger parts of it.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix shared timers.
zack [Wed, 16 May 2007 13:50:18 +0000 (13:50 +0000)]
Fix shared timers.

Make the timers correctly use miliseconds. Based on a patch
from George.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Zack
lars [Wed, 16 May 2007 11:12:29 +0000 (11:12 +0000)]
    Reviewed by Zack

        pass the mouse events to the event handler, not the frameview.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Update layout tests for error handling changes.
lars [Wed, 16 May 2007 11:05:51 +0000 (11:05 +0000)]
 Update layout tests for error handling changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdate layout tests for error handling changes.
hyatt [Wed, 16 May 2007 09:25:45 +0000 (09:25 +0000)]
Update layout tests for error handling changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix Qt build.
hyatt [Wed, 16 May 2007 08:47:44 +0000 (08:47 +0000)]
Fix Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add rudimentary error reporting to the HTML parser. This is disabled
hyatt [Wed, 16 May 2007 08:11:05 +0000 (08:11 +0000)]
    Add rudimentary error reporting to the HTML parser.  This is disabled
        for now until it gets beefed up a bit more (and until we work out how
        best to pass the messages up without hurting perf).

        Clean up and remove dead error handling code and incorrect error handling
        code as well.

        Reviewed by mjs

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::HTMLParser):
        (WebCore::HTMLParser::handleError):
        (WebCore::HTMLParser::headCreateErrorCheck):
        (WebCore::HTMLParser::reportErrorToConsole):
        * html/HTMLParser.h:
        (WebCore::HTMLParser::reportError):
        * html/HTMLParserErrorCodes.cpp: Added.
        (WebCore::htmlParserErrorMessageTemplate):
        * html/HTMLParserErrorCodes.h: Added.
        (WebCore::):
        * html/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::tagStartLineNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make FrameLoader write "<html><body>" instead of just "<body>".
hyatt [Wed, 16 May 2007 06:22:17 +0000 (06:22 +0000)]
    Make FrameLoader write "<html><body>" instead of just "<body>".

        Reviewed by aroben

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agorepair changelog
staikos [Wed, 16 May 2007 05:04:25 +0000 (05:04 +0000)]
repair changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMake the loader pass cookies through
staikos [Wed, 16 May 2007 04:47:43 +0000 (04:47 +0000)]
Make the loader pass cookies through

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-15 Adam Treat <adam@staikos.net>
staikos [Wed, 16 May 2007 04:25:38 +0000 (04:25 +0000)]
2007-05-15  Adam Treat  <adam@staikos.net>

        Reviewed by George Staikos.

        - Implement drawArc with proper units.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-05-15 Adam Treat <adam@staikos.net>
staikos [Wed, 16 May 2007 04:19:14 +0000 (04:19 +0000)]
2007-05-15  Adam Treat  <adam@staikos.net>

        Reviewed by George Staikos.

        - Add missing paint for nested subframes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Wed, 16 May 2007 03:35:24 +0000 (03:35 +0000)]
LayoutTests:

        Reviewed by Oliver.

        - Yet more tests for http://bugs.webkit.org/show_bug.cgi?id=13722
          Finish testing and fixing the setting of DOM attributes to JS null

          Tests for SVG attributes that take a DOMString.

        * fast/dom/svg-element-attribute-js-null-expected.txt: Added.
        * fast/dom/svg-element-attribute-js-null.xhtml: Added.

WebCore:

        Reviewed by Oliver.

        - Patch for http://bugs.webkit.org/show_bug.cgi?id=13722
          Finish testing and fixing the setting of DOM attributes to JS null

          Convert JS null to null string for SVG attributes.

        Test: fast/dom/svg-element-attribute-js-null.xhtml

        * ksvg2/svg/SVGAngle.idl:
        * ksvg2/svg/SVGElement.idl:
        * ksvg2/svg/SVGLength.idl:
        * ksvg2/svg/SVGScriptElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21505 268f45cc-cd09-0410-ab3c-d52691b4dbfc